Pass large structs byref instead

Simulator/Actions/BaseComboAction.cs

@@ -10,7 +10,7 @@ public abstract class BaseComboAction : BaseAction
     protected bool BaseCanUse(Simulator s) =>
         base.CanUse(s);
 
-    private static bool VerifyDurability2(int durabilityA, int durability, Effects effects)
+    private static bool VerifyDurability2(int durabilityA, int durability, in Effects effects)
     {
         var wasteNots = effects.HasEffect(EffectType.WasteNot) || effects.HasEffect(EffectType.WasteNot2);
         // -A
@@ -23,13 +23,10 @@ public abstract class BaseComboAction : BaseAction
         return true;
     }
 
-    public static bool VerifyDurability2(SimulationState s, int durabilityA) =>
-        VerifyDurability2(durabilityA, s.Durability, s.ActiveEffects);
-
     public static bool VerifyDurability2(Simulator s, int durabilityA) =>
         VerifyDurability2(durabilityA, s.Durability, s.ActiveEffects);
 
-    public static bool VerifyDurability3(int durabilityA, int durabilityB, int durability, Effects effects)
+    public static bool VerifyDurability3(int durabilityA, int durabilityB, int durability, in Effects effects)
     {
         var wasteNots = Math.Max(effects.GetDuration(EffectType.WasteNot), effects.GetDuration(EffectType.WasteNot2));
         var manips = effects.HasEffect(EffectType.Manipulation);
@@ -56,7 +53,4 @@ public abstract class BaseComboAction : BaseAction
 
     public static bool VerifyDurability3(Simulator s, int durabilityA, int durabilityB) =>
         VerifyDurability3(durabilityA, durabilityB, s.Durability, s.ActiveEffects);
-
-    public static bool VerifyDurability3(SimulationState s, int durabilityA, int durabilityB) =>
-        VerifyDurability3(durabilityA, durabilityB, s.Durability, s.ActiveEffects);
 }

Simulator/Simulator.cs

@@ -35,17 +35,17 @@ public class Simulator
 
     public IEnumerable<ActionType> AvailableActions => ActionUtils.AvailableActions(this);
 
-    public Simulator(SimulationState state)
+    public Simulator(in SimulationState state)
     {
         State = state;
     }
 
-    public void SetState(SimulationState state)
+    public void SetState(in SimulationState state)
     {
         State = state;
     }
 
-    public (ActionResponse Response, SimulationState NewState) Execute(SimulationState state, ActionType action)
+    public (ActionResponse Response, SimulationState NewState) Execute(in SimulationState state, ActionType action)
     {
         State = state;
         return (Execute(action), State);
@@ -75,7 +75,7 @@ public class Simulator
         return ActionResponse.UsedAction;
     }
 
-    public (ActionResponse Response, SimulationState NewState, int FailedActionIdx) ExecuteMultiple(SimulationState state, IEnumerable<ActionType> actions)
+    public (ActionResponse Response, SimulationState NewState, int FailedActionIdx) ExecuteMultiple(in SimulationState state, IEnumerable<ActionType> actions)
     {
         State = state;
         var i = 0;

Simulator/SimulatorNoRandom.cs

@@ -2,7 +2,7 @@ namespace Craftimizer.Simulator;
 
 public class SimulatorNoRandom : Simulator
 {
-    public SimulatorNoRandom(SimulationState state) : base(state)
+    public SimulatorNoRandom(in SimulationState state) : base(state)
     {
     }
 

Solver/MCTS.cs

@@ -17,7 +17,7 @@ public sealed class MCTS
 
     public float MaxScore => rootScores.MaxScore;
 
-    public MCTS(MCTSConfig config, SimulationState state)
+    public MCTS(in MCTSConfig config, in SimulationState state)
     {
         this.config = config;
         var sim = new Simulator(state, config.MaxStepCount);
@@ -30,7 +30,7 @@ public sealed class MCTS
         rootScores = new();
     }
 
-    private static SimulationNode Execute(Simulator simulator, SimulationState state, ActionType action, bool strict)
+    private static SimulationNode Execute(Simulator simulator, in SimulationState state, ActionType action, bool strict)
     {
         (_, var newState) = simulator.Execute(state, action);
         return new(
@@ -61,7 +61,7 @@ public sealed class MCTS
 
     [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static (int arrayIdx, int subIdx) ChildMaxScore(ref NodeScoresBuffer scores)
+    private static (int arrayIdx, int subIdx) ChildMaxScore(in NodeScoresBuffer scores)
     {
         var length = scores.Count;
         var vecLength = Vector<float>.Count;
@@ -111,7 +111,7 @@ public sealed class MCTS
         float explorationConstant,
         float maxScoreWeightingConstant,
         int parentVisits,
-        ref NodeScoresBuffer scores)
+        in NodeScoresBuffer scores)
     {
         var length = scores.Count;
         var vecLength = Vector<float>.Count;
@@ -168,7 +168,7 @@ public sealed class MCTS
                 return node;
 
             // select the node with the highest score
-            var at = EvalBestChild(explorationConstant, maxScoreWeightingConstant, nodeVisits, ref node.ChildScores);
+            var at = EvalBestChild(explorationConstant, maxScoreWeightingConstant, nodeVisits, in node.ChildScores);
             nodeVisits = node.ChildScores.GetVisits(at);
             node = node.ChildAt(at)!;
         }
@@ -320,7 +320,7 @@ public sealed class MCTS
 
         while (node.Children.Count != 0)
         {
-            node = node.ChildAt(ChildMaxScore(ref node.ChildScores))!;
+            node = node.ChildAt(ChildMaxScore(in node.ChildScores))!;
 
             if (node.State.Action != null)
                 actions.Add(node.State.Action.Value);

Solver/MCTSConfig.cs

@@ -1,4 +1,4 @@
-using System.Runtime.InteropServices;
+using System.Runtime.InteropServices;
 
 namespace Craftimizer.Solver;
 
@@ -21,7 +21,7 @@ public readonly record struct MCTSConfig
     public float ScoreCP { get; init; }
     public float ScoreSteps { get; init; }
 
-    public MCTSConfig(SolverConfig config)
+    public MCTSConfig(in SolverConfig config)
     {
         MaxStepCount = config.MaxStepCount;
         MaxRolloutStepCount = config.MaxRolloutStepCount;

Solver/SimulationNode.cs

@@ -19,7 +19,7 @@ public struct SimulationNode
 
     public readonly bool IsComplete => CompletionState != CompletionState.Incomplete;
 
-    public SimulationNode(SimulationState state, ActionType? action, CompletionState completionState, ActionSet actions)
+    public SimulationNode(in SimulationState state, ActionType? action, CompletionState completionState, ActionSet actions)
     {
         State = state;
         Action = action;
@@ -32,10 +32,10 @@ public struct SimulationNode
         CompletionState.NoMoreActions :
         simCompletionState;
 
-    public readonly float? CalculateScore(MCTSConfig config) =>
+    public readonly float? CalculateScore(in MCTSConfig config) =>
         CalculateScoreForState(State, SimulationCompletionState, config);
 
-    public static float? CalculateScoreForState(SimulationState state, CompletionState completionState, MCTSConfig config)
+    public static float? CalculateScoreForState(in SimulationState state, CompletionState completionState, MCTSConfig config)
     {
         if (completionState != CompletionState.ProgressComplete)
             return null;

Solver/Simulator.cs

@@ -20,7 +20,7 @@ internal sealed class Simulator : SimulatorNoRandom
         }
     }
 
-    public Simulator(SimulationState state, int maxStepCount) : base(state)
+    public Simulator(in SimulationState state, int maxStepCount) : base(state)
     {
         this.maxStepCount = maxStepCount;
     }

Solver/Solver.cs

@@ -35,7 +35,7 @@ public sealed class Solver : IDisposable
     // Always called when a new step is generated.
     public event NewActionDelegate? OnNewAction;
 
-    public Solver(SolverConfig config, SimulationState state)
+    public Solver(in SolverConfig config, in SimulationState state)
     {
         Config = config;
         State = state;

Solver/SolverSolution.cs

@@ -9,7 +9,7 @@ public readonly record struct SolverSolution {
     public readonly IEnumerable<ActionType> ActionEnumerable { init => actions = SanitizeCombos(value).ToList(); }
     public readonly SimulationState State { get; init; }
 
-    public SolverSolution(IEnumerable<ActionType> actions, SimulationState state)
+    public SolverSolution(IEnumerable<ActionType> actions, in SimulationState state)
     {
         ActionEnumerable = actions;
         State = state;