From ec4466123c83d0d9c4e52ab566ca82db3f6990f0 Mon Sep 17 00:00:00 2001
From: Asriel Camora <asriel@camora.dev>
Date: Sun, 23 Jul 2023 02:44:19 +0400
Subject: [PATCH] settings fixes

---
 Craftimizer/Plugin.cs           | 2 +-
 Craftimizer/Windows/Settings.cs | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/Craftimizer/Plugin.cs b/Craftimizer/Plugin.cs
index f5fbe8e..6fefd28 100644
--- a/Craftimizer/Plugin.cs
+++ b/Craftimizer/Plugin.cs
@@ -35,7 +35,7 @@ public sealed class Plugin : IDalamudPlugin
         Service.Configuration = pluginInterface.GetPluginConfig() as Configuration ?? new Configuration();
 
         var assembly = Assembly.GetExecutingAssembly();
-        Version = assembly.GetCustomAttribute<AssemblyVersionAttribute>()!.Version;
+        Version = assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()!.InformationalVersion;
         Author = assembly.GetCustomAttribute<AssemblyCompanyAttribute>()!.Company;
         Configuration = assembly.GetCustomAttribute<AssemblyConfigurationAttribute>()!.Configuration;
         byte[] iconData;
diff --git a/Craftimizer/Windows/Settings.cs b/Craftimizer/Windows/Settings.cs
index 6f64a58..37ecc47 100644
--- a/Craftimizer/Windows/Settings.cs
+++ b/Craftimizer/Windows/Settings.cs
@@ -4,8 +4,6 @@ using ImGuiNET;
 using System.Numerics;
 using System;
 using Craftimizer.Solver.Crafty;
-using System.Reflection;
-using System.Diagnostics;
 
 namespace Craftimizer.Plugin.Windows;
 
@@ -19,7 +17,7 @@ public class Settings : Window
 
         SizeConstraints = new WindowSizeConstraints()
         {
-            MinimumSize = new Vector2(400, 600),
+            MinimumSize = new Vector2(400, 400),
             MaximumSize = new Vector2(float.MaxValue, float.MaxValue)
         };
         Size = SizeConstraints.Value.MinimumSize;
@@ -391,6 +389,9 @@ public class Settings : Window
 
     private static void DrawTabAbout()
     {
+        if (!ImGui.BeginTabItem("About"))
+            return;
+
         var plugin = Service.Plugin;
         var icon = plugin.Icon;
 
@@ -415,5 +416,7 @@ public class Settings : Window
         ImGuiUtils.Hyperlink("Craftingway", "https://craftingway.app");
         ImGui.SameLine(0, 0);
         ImGui.Text(" for the original solver algorithm");
+
+        ImGui.EndTabItem();
     }
 }