Remove ref passing, but keep devirtualizations

2024-03-16 13:24:26 -07:00
parent 3223bdcbfb
commit ec77f1d021
48 changed files with 411 additions and 787 deletions
@@ -1,17 +1,20 @@
 namespace Craftimizer.Simulator.Actions;

-public abstract class BaseComboAction : BaseAction
+public abstract class BaseComboAction(
+        ActionType actionTypeA, ActionType actionTypeB,
+        BaseAction actionA, BaseAction actionB,
+        int? defaultCPCost = null) :
+    BaseAction(
+        ActionCategory.Combo, Math.Max(actionA.Level, actionA.Level), actionB.ActionId,
+        increasesProgress: actionA.IncreasesProgress || actionB.IncreasesProgress,
+        increasesQuality: actionA.IncreasesQuality || actionB.IncreasesQuality,
+        defaultCPCost: defaultCPCost ?? (actionA.DefaultCPCost + actionB.DefaultCPCost))
 {
-    public abstract ActionType ActionTypeA { get; }
-    public abstract ActionType ActionTypeB { get; }
+    public readonly ActionType ActionTypeA = actionTypeA;
+    public readonly ActionType ActionTypeB = actionTypeB;

-    public BaseComboAction()
-    {
-        Category = ActionCategory.Combo;
-    }
-
-    protected bool BaseCouldUse(Simulator s, ref int cost) =>
-        base.CouldUse(s, ref cost);
+    protected bool BaseCouldUse(Simulator s) =>
+        base.CouldUse(s);

    private static bool VerifyDurability2(int durabilityA, int durability, in Effects effects)
    {