merge Update and Fixes for Branding and Security Fixes Merge branch 'feature/audit-fixes-phase-2'

This commit is contained in:
2026-05-02 04:02:28 +02:00
18 changed files with 435 additions and 138 deletions
+1 -1
View File
@@ -4,7 +4,7 @@
0.1.0 is our bootstrap release; the underlying Chat 2 base is 0.1.0 is our bootstrap release; the underlying Chat 2 base is
called out in the yaml changelog so users can see what it called out in the yaml changelog so users can see what it
derives from. --> derives from. -->
<Version>0.2.0</Version> <Version>0.3.0</Version>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
<!-- HellionChat fork: assembly is renamed so Dalamud uses <!-- HellionChat fork: assembly is renamed so Dalamud uses
pluginConfigs/HellionChat instead of pluginConfigs/ChatTwo, pluginConfigs/HellionChat instead of pluginConfigs/ChatTwo,
+11 -2
View File
@@ -168,10 +168,19 @@ public static class EmoteCache
internal async Task<byte[]> LoadAsync(Emote emote) internal async Task<byte[]> LoadAsync(Emote emote)
{ {
var dir = Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1"); // BetterTTV-supplied Id and ImageType are interpolated straight
// into the filename. HTTPS protects the wire, but a compromised
// upstream could still hand us "../foo" and write into the
// pluginConfigs root (or worse). Resolve the candidate path and
// refuse anything that escapes the cache directory.
var dir = Path.GetFullPath(Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1"));
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
var filePath = Path.Join(dir, $"{emote.Id}.{emote.ImageType}"); var dirPrefix = dir.EndsWith(Path.DirectorySeparatorChar) ? dir : dir + Path.DirectorySeparatorChar;
var filePath = Path.GetFullPath(Path.Join(dir, $"{emote.Id}.{emote.ImageType}"));
if (!filePath.StartsWith(dirPrefix, StringComparison.Ordinal))
throw new InvalidOperationException($"Emote path escapes cache directory: id={emote.Id}, type={emote.ImageType}");
if (File.Exists(filePath)) if (File.Exists(filePath))
{ {
RawData = await File.ReadAllBytesAsync(filePath); RawData = await File.ReadAllBytesAsync(filePath);
+73 -15
View File
@@ -3,12 +3,12 @@ author: JonKazama-Hellion
punchline: Chat 2 with privacy controls aligned to EU, US and JP rules punchline: Chat 2 with privacy controls aligned to EU, US and JP rules
description: |- description: |-
Hellion Chat is built on top of Chat 2 with one removal and a stack Hellion Chat is built on top of Chat 2 with one removal and a stack
of privacy controls on top. The /chat2 command, tabs, channel of privacy controls on top. Tabs, channel filters, RGB colours,
filters, RGB colours, emotes, screenshot mode, IPC integration and emotes, screenshot mode, IPC integration and the chat replacement
the chat replacement window itself work the same. The optional window itself work the same. The optional webinterface that Chat 2
webinterface that Chat 2 ships is intentionally not part of this ships is intentionally not part of this fork because it serves a
fork because it could not be hardened to the privacy guarantees different use case from the smaller default footprint Hellion Chat
Hellion Chat makes by default. is built around.
On top of that, Hellion Chat adds privacy and data-handling controls On top of that, Hellion Chat adds privacy and data-handling controls
designed to align with the modern data protection rules that apply designed to align with the modern data protection rules that apply
@@ -40,17 +40,75 @@ tags:
- Replacement - Replacement
- Privacy - Privacy
changelog: |- changelog: |-
**Hellion Chat 0.3.0 — Audit hardening, brand sweep and rebrand of slash commands**
This release closes the remaining audit follow-ups from the
0.2.0 cleanup and finishes turning Hellion Chat into a properly
branded fork rather than a Chat 2 with a different name.
Slash commands have been renamed across the board so they no
longer collide with the upstream plugin and tell you which
plugin owns them at a glance:
- /chat2 becomes /hellion
- /chat2Viewer becomes /hellionView
- /clearlog2 becomes /clearhellion
- /chat2Debugger becomes /hellionDebugger (internal)
- /chat2SeString becomes /hellionSeString (internal)
This is a breaking change for anyone with macros bound to the
old command names. The upstream Chat 2 commands keep working
if you also have that plugin installed.
Privacy and storage hardening based on the post-0.2.0 audit:
- Privacy filter master switch now states explicitly that the
filter only governs storage, not the live chat log
- Emote cache refuses to write outside its own directory if a
third-party API ever returns a path that escapes
- Retention sweep is serialised so the 24h auto-sweep and the
manual button cannot launch in parallel and race for the
SQLite connection
- DbViewer paging uses an int constant and the matching SQL
parameter name (the upstream code passed a float and a name
without the parameter prefix; both worked in practice but
were inconsistent)
Visual identity now matches the Hellion Online Media website:
- Theme palette switched to Arctic Cyan plus Ember Orange,
matching the website's BRANDING.md tokens
- Active tabs and window title bars use a brand-color-dark teal
variation as identity colour, replacing the previous slate
violet that did not appear in the brand
- Resize grips and scrollbar grabs picked up Ember Orange
instead of industrial amber on hover and active states
About tab rewritten and properly localised:
- New "Why this fork exists" block sets out the mission in
neutral terms, framing Chat 2's full-history default as the
right one for most users while explaining the narrower
default footprint this fork chose
- All Hellion-specific About copy now lives in HellionStrings
in EN and DE, so German users see the Hellion sections in
German rather than the upstream English fallback
- Webinterface absence is described as a focus mismatch
(different use case, substantial rebuild) rather than as
a security issue with the upstream code
- Translator list at the bottom of the About tab is reachable
again on smaller settings windows
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 0.2.0 — Webinterface removed** **Hellion Chat 0.2.0 — Webinterface removed**
Following an internal security and consistency audit the upstream The upstream webinterface has been removed in its entirety. It
webinterface has been removed in its entirety. Hardening it to the serves a different use case from the smaller default footprint
privacy guarantees Hellion Chat makes by default would have meant this fork is built around, namely remote access to chat from a
rewriting the auth flow (the upstream code uses a five-digit second device. Aligning it with the data minimisation defaults
numeric code from System.Random), changing the default bind address Hellion Chat ships with would have meant a substantial rebuild.
(currently every interface), reworking cookie handling and adding Removing it was the cleaner path for this particular fork.
the privacy filter to the live message stream that the webinterface
was broadcasting around it. The cumulative cost did not match the
niche use case for a fork that wants less network surface, not more.
What changed in this release: What changed in this release:
+1 -1
View File
@@ -724,7 +724,7 @@ internal class MessageStore : IDisposable
cmd.Parameters.AddWithValue("$After", ((DateTimeOffset) after).ToUnixTimeMilliseconds()); cmd.Parameters.AddWithValue("$After", ((DateTimeOffset) after).ToUnixTimeMilliseconds());
cmd.Parameters.AddWithValue("$Before", ((DateTimeOffset) before).ToUnixTimeMilliseconds()); cmd.Parameters.AddWithValue("$Before", ((DateTimeOffset) before).ToUnixTimeMilliseconds());
cmd.Parameters.AddWithValue("$Offset", DbViewer.RowPerPage * page); cmd.Parameters.AddWithValue("$Offset", DbViewer.RowPerPage * page);
cmd.Parameters.AddWithValue("OffsetCount", DbViewer.RowPerPage); cmd.Parameters.AddWithValue("$OffsetCount", DbViewer.RowPerPage);
return new MessageEnumerator(cmd.ExecuteReader()); return new MessageEnumerator(cmd.ExecuteReader());
} }
+24
View File
@@ -64,6 +64,15 @@ public sealed class Plugin : IDalamudPlugin
internal int DeferredSaveFrames = -1; internal int DeferredSaveFrames = -1;
// Serialises retention sweeps. The 24h auto-sweep on plugin load and
// the manual button in the Privacy tab both run on background threads;
// without this gate, hitting the manual button moments after a fresh
// plugin start would launch two sweeps in parallel and the second one
// would just re-do work the first one already finished. The lock guards
// the flag — the flag check itself bails before we touch the database.
internal readonly object RetentionSweepLock = new();
internal bool RetentionSweepRunning;
internal DateTime GameStarted { get; } internal DateTime GameStarted { get; }
// Tab management needs to happen outside the chatlog window class for access reasons // Tab management needs to happen outside the chatlog window class for access reasons
@@ -405,6 +414,16 @@ public sealed class Plugin : IDalamudPlugin
new Thread(() => new Thread(() =>
{ {
// Bail out cheaply if a manual sweep is already in flight; the
// lock around the actual work would queue us up otherwise and
// we would just re-do whatever the manual run already did.
lock (RetentionSweepLock)
{
if (RetentionSweepRunning)
return;
RetentionSweepRunning = true;
}
try try
{ {
var deleted = MessageManager.Store.DeleteByRetentionPolicy(policy, defaultDays); var deleted = MessageManager.Store.DeleteByRetentionPolicy(policy, defaultDays);
@@ -429,6 +448,11 @@ public sealed class Plugin : IDalamudPlugin
{ {
Log.Error(e, "Retention sweep failed"); Log.Error(e, "Retention sweep failed");
} }
finally
{
lock (RetentionSweepLock)
RetentionSweepRunning = false;
}
}) { IsBackground = true }.Start(); }) { IsBackground = true }.Start();
} }
+24
View File
@@ -44,6 +44,7 @@ internal class HellionStrings
internal static string Privacy_Tab_Title => Get(nameof(Privacy_Tab_Title)); internal static string Privacy_Tab_Title => Get(nameof(Privacy_Tab_Title));
internal static string Privacy_FilterEnabled_Name => Get(nameof(Privacy_FilterEnabled_Name)); internal static string Privacy_FilterEnabled_Name => Get(nameof(Privacy_FilterEnabled_Name));
internal static string Privacy_FilterEnabled_Description => Get(nameof(Privacy_FilterEnabled_Description)); internal static string Privacy_FilterEnabled_Description => Get(nameof(Privacy_FilterEnabled_Description));
internal static string Privacy_FilterEnabled_StorageOnly_Help => Get(nameof(Privacy_FilterEnabled_StorageOnly_Help));
internal static string Privacy_Whitelist_Help => Get(nameof(Privacy_Whitelist_Help)); internal static string Privacy_Whitelist_Help => Get(nameof(Privacy_Whitelist_Help));
internal static string Privacy_Preset_PrivacyFirst => Get(nameof(Privacy_Preset_PrivacyFirst)); internal static string Privacy_Preset_PrivacyFirst => Get(nameof(Privacy_Preset_PrivacyFirst));
internal static string Privacy_Preset_ClearAll => Get(nameof(Privacy_Preset_ClearAll)); internal static string Privacy_Preset_ClearAll => Get(nameof(Privacy_Preset_ClearAll));
@@ -140,4 +141,27 @@ internal class HellionStrings
internal static string Theme_WindowOpacity_Help => Get(nameof(Theme_WindowOpacity_Help)); internal static string Theme_WindowOpacity_Help => Get(nameof(Theme_WindowOpacity_Help));
internal static string Theme_UseHellionFont_Name => Get(nameof(Theme_UseHellionFont_Name)); internal static string Theme_UseHellionFont_Name => Get(nameof(Theme_UseHellionFont_Name));
internal static string Theme_UseHellionFont_Description => Get(nameof(Theme_UseHellionFont_Description)); internal static string Theme_UseHellionFont_Description => Get(nameof(Theme_UseHellionFont_Description));
internal static string About_Maintainer_Heading => Get(nameof(About_Maintainer_Heading));
internal static string About_Maintainer_Body => Get(nameof(About_Maintainer_Body));
internal static string About_Maintainer_Website_Label => Get(nameof(About_Maintainer_Website_Label));
internal static string About_Mission_Heading => Get(nameof(About_Mission_Heading));
internal static string About_Mission_P1 => Get(nameof(About_Mission_P1));
internal static string About_Mission_P2 => Get(nameof(About_Mission_P2));
internal static string About_Mission_P3 => Get(nameof(About_Mission_P3));
internal static string About_BuiltOn_Heading => Get(nameof(About_BuiltOn_Heading));
internal static string About_BuiltOn_P1 => Get(nameof(About_BuiltOn_P1));
internal static string About_BuiltOn_P2 => Get(nameof(About_BuiltOn_P2));
internal static string About_BuiltOn_Upstream_Label => Get(nameof(About_BuiltOn_Upstream_Label));
internal static string About_License_Heading => Get(nameof(About_License_Heading));
internal static string About_License_P1 => Get(nameof(About_License_P1));
internal static string About_License_P2 => Get(nameof(About_License_P2));
internal static string About_License_P3 => Get(nameof(About_License_P3));
internal static string About_SE_Heading => Get(nameof(About_SE_Heading));
internal static string About_SE_P1 => Get(nameof(About_SE_P1));
internal static string About_SE_P2 => Get(nameof(About_SE_P2));
internal static string About_Localization_Heading => Get(nameof(About_Localization_Heading));
internal static string About_Localization_P1 => Get(nameof(About_Localization_P1));
internal static string About_Localization_P2 => Get(nameof(About_Localization_P2));
internal static string About_Translators_TreeNode => Get(nameof(About_Translators_TreeNode));
} }
+76 -1
View File
@@ -21,6 +21,9 @@
<data name="Privacy_FilterEnabled_Description" xml:space="preserve"> <data name="Privacy_FilterEnabled_Description" xml:space="preserve">
<value>Wenn aktiviert, werden nur Nachrichten aus den erlaubten Kanälen in die Datenbank gespeichert. Beim Deaktivieren gilt wieder das Standard-Verhalten von ChatTwo, also alles außer Battle-Logs wird gespeichert.</value> <value>Wenn aktiviert, werden nur Nachrichten aus den erlaubten Kanälen in die Datenbank gespeichert. Beim Deaktivieren gilt wieder das Standard-Verhalten von ChatTwo, also alles außer Battle-Logs wird gespeichert.</value>
</data> </data>
<data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve">
<value>Der Filter steuert nur, was in die lokale Datenbank geschrieben wird. Im Chat-Log siehst du weiterhin jede Nachricht live, ausgeschlossene Kanäle werden nur nicht mehr gespeichert. Wenn du Kanäle auch aus der sichtbaren Anzeige entfernen willst, nutze die normalen Chat-Tab-Filter im Spiel.</value>
</data>
<data name="Privacy_Whitelist_Help" xml:space="preserve"> <data name="Privacy_Whitelist_Help" xml:space="preserve">
<value>Wähle aus, welche Kanäle in die lokale Datenbank gespeichert werden. Standard nach Datensparsamkeit: nur deine eigenen Konversationen. Über die Buttons unten kannst du eine Voreinstellung anwenden.</value> <value>Wähle aus, welche Kanäle in die lokale Datenbank gespeichert werden. Standard nach Datensparsamkeit: nur deine eigenen Konversationen. Über die Buttons unten kannst du eine Voreinstellung anwenden.</value>
</data> </data>
@@ -277,7 +280,7 @@
<value>Hellion-Theme für alle Plugin-Fenster verwenden</value> <value>Hellion-Theme für alle Plugin-Fenster verwenden</value>
</data> </data>
<data name="Theme_Enabled_Description" xml:space="preserve"> <data name="Theme_Enabled_Description" xml:space="preserve">
<value>Industrielle HUD-Palette mit cyan-blauen Aktionsfarben, schiefer-violetten Tabs und Bernstein-Akzenten für aktive Zustände, global angewendet auf Chat-Fenster, Einstellungen, Viewer und Wizard. Deaktivieren, um das Standard-Dalamud-Erscheinungsbild zu nutzen.</value> <value>Hellion-Online-Media-Palette aus Arctic Cyan und Ember Orange, angewendet auf Chat-Fenster, Einstellungen, Viewer und Wizard. Deaktivieren, um das Standard-Dalamud-Erscheinungsbild zu nutzen.</value>
</data> </data>
<data name="Theme_WindowOpacity_Label" xml:space="preserve"> <data name="Theme_WindowOpacity_Label" xml:space="preserve">
<value>Fenster-Deckkraft</value> <value>Fenster-Deckkraft</value>
@@ -291,4 +294,76 @@
<data name="Theme_UseHellionFont_Description" xml:space="preserve"> <data name="Theme_UseHellionFont_Description" xml:space="preserve">
<value>Rendert Chat und UI in Exo 2 (SIL Open Font License 1.1), die mit dem Plugin ausgeliefert wird. Deaktivieren, um auf die unter Einstellungen → Schrift gewählte Schriftart zurückzufallen.</value> <value>Rendert Chat und UI in Exo 2 (SIL Open Font License 1.1), die mit dem Plugin ausgeliefert wird. Deaktivieren, um auf die unter Einstellungen → Schrift gewählte Schriftart zurückzufallen.</value>
</data> </data>
<data name="About_Maintainer_Heading" xml:space="preserve">
<value>Maintainer</value>
</data>
<data name="About_Maintainer_Body" xml:space="preserve">
<value>Ich pflege Hellion Chat über Hellion Online Media. Auf der Website findest du die Kontaktdaten für lizenzrechtliche, rechtliche oder geschäftliche Fragen.</value>
</data>
<data name="About_Maintainer_Website_Label" xml:space="preserve">
<value>Website:</value>
</data>
<data name="About_Mission_Heading" xml:space="preserve">
<value>Warum es diesen Fork gibt</value>
</data>
<data name="About_Mission_P1" xml:space="preserve">
<value>Hellion Chat soll Chat 2 nicht ersetzen. Chat 2 liefert ein vollständiges Chat-Erlebnis mit kompletter Historie, die für Filter, Suche und Replay zur Verfügung steht. Dieser Default ist für die meisten Nutzer der richtige. Dieser Fork wählt einen anderen Ansatz: einen kleineren Default-Footprint, mit zusätzlichen Stellschrauben für Nutzer, die weniger fremden Chat auf der Festplatte behalten möchten.</value>
</data>
<data name="About_Mission_P2" xml:space="preserve">
<value>Der Wunsch nach diesem engeren Default war persönlich. Nach zwei Jahren mit Chat 2 lag meine Datenbank bei über zwei Millionen Nachrichten, der Großteil davon /say, /shout und /yell von Fremden in Limsa. Genau diese Daten machen Chat 2's Voll-Historie nützlich, und die meisten Nutzer behalten sie gerne. Mein eigener Geschmack wollte einen kleineren Default. Also habe ich diesen Fork gebaut.</value>
</data>
<data name="About_Mission_P3" xml:space="preserve">
<value>Ich strebe keine große Zielgruppe an, und der Fork steht nicht in Konkurrenz zu Chat 2. Der Code liegt offen unter derselben EUPL-1.2-Lizenz wie das Original. Infi, Anna oder sonst jemand dürfen reinschauen, Ideen mitnehmen, Fragen stellen oder das Projekt einfach ignorieren. Alles drei ist für mich in Ordnung.</value>
</data>
<data name="About_BuiltOn_Heading" xml:space="preserve">
<value>Aufbauend auf Chat 2</value>
</data>
<data name="About_BuiltOn_P1" xml:space="preserve">
<value>Hellion Chat ist ein Fork von Chat 2 von Infi und Anna (ascclemens). Das Chat-Replacement-Fenster, die IPC-Integration, die Render-Engine und der komplette Storage-Kern stammen aus dem Original.</value>
</data>
<data name="About_BuiltOn_P2" xml:space="preserve">
<value>Das Webinterface ist das einzige größere Teil, das ich entfernt habe. Es ist für den Remote-Zugriff auf den Chat von einem zweiten Gerät gebaut, also für einen anderen Fokus als der kleinere Default-Footprint, den dieser Fork verfolgt. Es an diese Defaults anzupassen hätte einen erheblichen Umbau bedeutet, also war die Entfernung der saubere Weg für genau diesen Fork.</value>
</data>
<data name="About_BuiltOn_Upstream_Label" xml:space="preserve">
<value>Upstream-Repository:</value>
</data>
<data name="About_License_Heading" xml:space="preserve">
<value>Lizenz</value>
</data>
<data name="About_License_P1" xml:space="preserve">
<value>Hellion Chat und Chat 2 stehen beide unter der European Union Public Licence v1.2 (EUPL-1.2).</value>
</data>
<data name="About_License_P2" xml:space="preserve">
<value>© 2023 bis 2026, die Chat-2-Autoren (Infi, Anna und die Upstream-Mitwirkenden).</value>
</data>
<data name="About_License_P3" xml:space="preserve">
<value>© 2026 Hellion Online Media für die Erweiterungen in diesem Fork.</value>
</data>
<data name="About_SE_Heading" xml:space="preserve">
<value>FINAL FANTASY XIV-Hinweis</value>
</data>
<data name="About_SE_P1" xml:space="preserve">
<value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. Alle Rechte vorbehalten.</value>
</data>
<data name="About_SE_P2" xml:space="preserve">
<value>Hellion Chat ist ein inoffizielles Fan-Plugin. Es steht in keiner Verbindung zu Square Enix und wird von ihnen weder unterstützt, gesponsert noch genehmigt.</value>
</data>
<data name="About_Localization_Heading" xml:space="preserve">
<value>Lokalisierung</value>
</data>
<data name="About_Localization_P1" xml:space="preserve">
<value>Die deutschen Übersetzungen der Hellion-spezifischen Strings stammen von mir. Weitere Sprachen sind aktuell nicht verfügbar.</value>
</data>
<data name="About_Localization_P2" xml:space="preserve">
<value>Die Übersetzerliste weiter unten gehört zu den Chat-2-Strings auf Crowdin. Diese Freiwilligen haben Chat 2 übersetzt, nicht die Hellion-Erweiterungen.</value>
</data>
<data name="About_Translators_TreeNode" xml:space="preserve">
<value>Chat-2-Community-Übersetzer (Upstream)</value>
</data>
</root> </root>
+77 -2
View File
@@ -21,6 +21,9 @@
<data name="Privacy_FilterEnabled_Description" xml:space="preserve"> <data name="Privacy_FilterEnabled_Description" xml:space="preserve">
<value>When enabled, only messages from whitelisted channels are persisted to the database. Disabling restores upstream ChatTwo behavior (everything except battle messages is stored).</value> <value>When enabled, only messages from whitelisted channels are persisted to the database. Disabling restores upstream ChatTwo behavior (everything except battle messages is stored).</value>
</data> </data>
<data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve">
<value>The filter only controls what is written to the local database. The chat log itself keeps showing every message live, disallowed channels just stop being saved. Use the channel hide options in your in-game chat tabs if you want to remove channels from the visible chat.</value>
</data>
<data name="Privacy_Whitelist_Help" xml:space="preserve"> <data name="Privacy_Whitelist_Help" xml:space="preserve">
<value>Pick which channels are stored in the local database. Privacy-First default: only your own conversations. Use the buttons below to apply a preset.</value> <value>Pick which channels are stored in the local database. Privacy-First default: only your own conversations. Use the buttons below to apply a preset.</value>
</data> </data>
@@ -121,7 +124,7 @@
<value>Auto-delete messages after a per-channel retention window</value> <value>Auto-delete messages after a per-channel retention window</value>
</data> </data>
<data name="Retention_Enabled_Description" xml:space="preserve"> <data name="Retention_Enabled_Description" xml:space="preserve">
<value>When enabled, messages older than the configured window are deleted on every plugin start (at most once per 24 hours). Off by default — the plugin never deletes history without your explicit consent.</value> <value>When enabled, messages older than the configured window are deleted on every plugin start (at most once per 24 hours). Off by default. The plugin never deletes history without your explicit consent.</value>
</data> </data>
<data name="Retention_Default_Label" xml:space="preserve"> <data name="Retention_Default_Label" xml:space="preserve">
<value>Default retention (days, 0 = never)</value> <value>Default retention (days, 0 = never)</value>
@@ -277,7 +280,7 @@
<value>Use the Hellion theme across all plugin windows</value> <value>Use the Hellion theme across all plugin windows</value>
</data> </data>
<data name="Theme_Enabled_Description" xml:space="preserve"> <data name="Theme_Enabled_Description" xml:space="preserve">
<value>Industrial HUD palette with cyan-teal action accents, slate-violet tabs and amber active highlights, applied globally to chat log, settings, viewers and the wizard. Disable to fall back to the default Dalamud look.</value> <value>Hellion Online Media palette of Arctic Cyan plus Ember Orange, applied across the chat log, settings, viewers and the wizard. Disable to fall back to the default Dalamud look.</value>
</data> </data>
<data name="Theme_WindowOpacity_Label" xml:space="preserve"> <data name="Theme_WindowOpacity_Label" xml:space="preserve">
<value>Window opacity</value> <value>Window opacity</value>
@@ -291,4 +294,76 @@
<data name="Theme_UseHellionFont_Description" xml:space="preserve"> <data name="Theme_UseHellionFont_Description" xml:space="preserve">
<value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1) which ships with the plugin. Disable to fall back to whatever font you picked under Settings → Fonts.</value> <value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1) which ships with the plugin. Disable to fall back to whatever font you picked under Settings → Fonts.</value>
</data> </data>
<data name="About_Maintainer_Heading" xml:space="preserve">
<value>Maintainer</value>
</data>
<data name="About_Maintainer_Body" xml:space="preserve">
<value>I maintain Hellion Chat through Hellion Online Media. The website has the contact details for licensing, legal or business questions.</value>
</data>
<data name="About_Maintainer_Website_Label" xml:space="preserve">
<value>Website:</value>
</data>
<data name="About_Mission_Heading" xml:space="preserve">
<value>Why this fork exists</value>
</data>
<data name="About_Mission_P1" xml:space="preserve">
<value>Hellion Chat is not trying to replace Chat 2. Chat 2 ships a complete chat experience with full history available for filtering, search and replay. That default is the right one for most users. This fork takes a different stance: a smaller default footprint, with extra knobs for users who want to keep less third-party chat on disk.</value>
</data>
<data name="About_Mission_P2" xml:space="preserve">
<value>The reason I wanted that narrower default was personal. After two years on Chat 2 my database had grown past two million messages, most of them /say, /shout and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full-history view powerful and most users are happy to keep it. For my own taste I wanted a smaller default. So I built this fork.</value>
</data>
<data name="About_Mission_P3" xml:space="preserve">
<value>I am not chasing a big audience and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the upstream plugin. Infi, Anna or anyone else are welcome to read it, borrow ideas, ask questions, or ignore the project. All three are fine by me.</value>
</data>
<data name="About_BuiltOn_Heading" xml:space="preserve">
<value>Built on Chat 2</value>
</data>
<data name="About_BuiltOn_P1" xml:space="preserve">
<value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat replacement window, the IPC integration, the rendering engine and the entire storage core come from upstream Chat 2.</value>
</data>
<data name="About_BuiltOn_P2" xml:space="preserve">
<value>The webinterface is the only major piece I removed. It is built for remote access to chat from a second device, which is a different focus than the smaller default footprint this fork is built around. Aligning it with these defaults would have meant a substantial rebuild, so removing it was the cleaner path for this particular fork.</value>
</data>
<data name="About_BuiltOn_Upstream_Label" xml:space="preserve">
<value>Upstream repository:</value>
</data>
<data name="About_License_Heading" xml:space="preserve">
<value>License</value>
</data>
<data name="About_License_P1" xml:space="preserve">
<value>Hellion Chat and Chat 2 both ship under the European Union Public Licence v1.2 (EUPL-1.2).</value>
</data>
<data name="About_License_P2" xml:space="preserve">
<value>© 2023 to 2026, the Chat 2 authors (Infi, Anna and the upstream contributors).</value>
</data>
<data name="About_License_P3" xml:space="preserve">
<value>© 2026 Hellion Online Media for the additions made in this fork.</value>
</data>
<data name="About_SE_Heading" xml:space="preserve">
<value>FINAL FANTASY XIV disclaimer</value>
</data>
<data name="About_SE_P1" xml:space="preserve">
<value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value>
</data>
<data name="About_SE_P2" xml:space="preserve">
<value>Hellion Chat is an unofficial, fan-made plugin. It has no affiliation with Square Enix and is not endorsed, sponsored or approved by them.</value>
</data>
<data name="About_Localization_Heading" xml:space="preserve">
<value>Localization</value>
</data>
<data name="About_Localization_P1" xml:space="preserve">
<value>The German translations of the Hellion-specific strings come from me. Other languages are not provided yet.</value>
</data>
<data name="About_Localization_P2" xml:space="preserve">
<value>The translator list below covers the upstream Chat 2 strings on Crowdin. Those volunteers translated Chat 2, not the Hellion additions.</value>
</data>
<data name="About_Translators_TreeNode" xml:space="preserve">
<value>Chat 2 community translators (upstream)</value>
</data>
</root> </root>
+4 -4
View File
@@ -99,8 +99,8 @@ public sealed class ChatLogWindow : Window
SetUpTextCommandChannels(); SetUpTextCommandChannels();
SetUpAllCommands(); SetUpAllCommands();
Plugin.Commands.Register("/clearlog2", "Clear the Chat 2 chat log").Execute += ClearLog; Plugin.Commands.Register("/clearhellion", "Clear the Hellion Chat log").Execute += ClearLog;
Plugin.Commands.Register("/chat2").Execute += ToggleChat; Plugin.Commands.Register("/hellion").Execute += ToggleChat;
Plugin.ClientState.Login += Login; Plugin.ClientState.Login += Login;
Plugin.ClientState.Logout += Logout; Plugin.ClientState.Logout += Logout;
@@ -115,8 +115,8 @@ public sealed class ChatLogWindow : Window
Plugin.AddonLifecycle.UnregisterListener(AddonEvent.PostUpdate, "ActionDetail", PayloadHandler.MoveTooltip); Plugin.AddonLifecycle.UnregisterListener(AddonEvent.PostUpdate, "ActionDetail", PayloadHandler.MoveTooltip);
Plugin.ClientState.Logout -= Logout; Plugin.ClientState.Logout -= Logout;
Plugin.ClientState.Login -= Login; Plugin.ClientState.Login -= Login;
Plugin.Commands.Register("/chat2").Execute -= ToggleChat; Plugin.Commands.Register("/hellion").Execute -= ToggleChat;
Plugin.Commands.Register("/clearlog2").Execute -= ClearLog; Plugin.Commands.Register("/clearhellion").Execute -= ClearLog;
} }
private void Logout(int _, int __) private void Logout(int _, int __)
+4 -4
View File
@@ -22,7 +22,7 @@ namespace ChatTwo.Ui;
public class DbViewer : Window public class DbViewer : Window
{ {
public const float RowPerPage = 1000.0f; public const int RowPerPage = 1000;
private readonly Plugin Plugin; private readonly Plugin Plugin;
@@ -76,19 +76,19 @@ public class DbViewer : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin.Commands.Register("/chat2Viewer", "Get access to your message history, with simple filter options.", true).Execute += Toggle; Plugin.Commands.Register("/hellionView", "Get access to your message history, with simple filter options.", true).Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin.Commands.Register("/chat2Viewer", "Get access to your message history, with simple filter options.", true).Execute -= Toggle; Plugin.Commands.Register("/hellionView", "Get access to your message history, with simple filter options.", true).Execute -= Toggle;
} }
private void Toggle(string _, string __) => Toggle(); private void Toggle(string _, string __) => Toggle();
public override void Draw() public override void Draw()
{ {
var totalPages = (int)Math.Ceiling(Count / RowPerPage); var totalPages = (int)Math.Ceiling((double)Count / RowPerPage);
if (totalPages < 1) if (totalPages < 1)
totalPages = 1; totalPages = 1;
+2 -2
View File
@@ -28,12 +28,12 @@ public class DebuggerWindow : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin.Commands.Register("/chat2Debugger", showInHelp: false).Execute += Toggle; Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin.Commands.Register("/chat2Debugger", showInHelp: false).Execute -= Toggle; Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute -= Toggle;
} }
private void Toggle(string _, string __) => Toggle(); private void Toggle(string _, string __) => Toggle();
+63 -47
View File
@@ -21,63 +21,79 @@ internal static class HellionStyle
{ {
// Encoded as 0xRRGGBBAA, matching ChatTwo convention (see Settings.cs // Encoded as 0xRRGGBBAA, matching ChatTwo convention (see Settings.cs
// Ko-fi buttons). RgbaToAbgr handles the byte swap to the format ImGui // Ko-fi buttons). RgbaToAbgr handles the byte swap to the format ImGui
// expects. // expects. Hex values are sourced from the Hellion Online Media brand
// guide ("Arctic Cyan + Ember Glow", BRANDING.md in the website repo).
// Primary — cyan-teal for actionable controls (buttons, checks, sliders). // Primary — Arctic Cyan, used for every interactive control (buttons,
private const uint PrimaryRgba = 0x00B8D4FF; // checks, sliders, separators when hovered). Three brand stages plus a
private const uint PrimaryHoverRgba = 0x26C6DAFF; // hover that lifts to brand-color-light and a press that drops to
private const uint PrimaryActiveRgba = 0x00838FFF; // brand-color-dark.
private const uint PrimaryRgba = 0x00BED2FF; // brand-color
private const uint PrimaryHoverRgba = 0x4DD9E8FF; // brand-color-light
private const uint PrimaryActiveRgba = 0x0097A7FF; // brand-color-dark
// Secondary — industrial amber, used as a warm highlight for active // Identity — brand-color-dark teal for window title bars and the
// states (tab borders, resize grips, scrollbar grabs). // active tab. Sits visibly below the primary cyan on buttons so the
private const uint SecondaryRgba = 0xFFB300FF; // user sees "where am I" (deep teal) versus "what can I click"
private const uint SecondaryHoverRgba = 0xFFC940FF; // (brand cyan) without leaving the cyan family.
private const uint SecondaryActiveRgba = 0xC68400FF; private const uint IdentityRgba = 0x0097A7FF; // brand-color-dark
private const uint IdentityHoverRgba = 0x4DD9E8FF; // brand-color-light
private const uint IdentityDeepRgba = 0x005670FF; // dimmer teal for unfocused-active tab
// Tertiary — slate violet, reserved for title bars and the active tab // Accent — Ember Orange for warm highlights on grips and scrollbar
// background so identity beats out the cyan accent without competing // pulls. Replaces the previous industrial amber so the plugin matches
// with it on action controls. // the website's CTA palette. AccentActive is reserved for any future
private const uint TertiaryRgba = 0x7B61FFFF; // pressed-state on accent surfaces; the current slots only need
private const uint TertiaryHoverRgba = 0x9580FFFF; // AccentRgba and AccentHoverRgba.
private const uint TertiaryActiveRgba = 0x5E45D9FF; private const uint AccentRgba = 0xF97316FF; // accent-color
private const uint AccentHoverRgba = 0xFB923CFF; // accent-color-light
// Surfaces — deep slate window/frame backgrounds, steel borders. // Surfaces — Hellion brand background ladder. Window darkest, frame
private const uint WindowBgRgba = 0x0E1A20FF; // hover ladder climbs into surface tones. Matches the website's
private const uint ChildBgRgba = 0x102027FF; // background / background-medium / background-light / surface vars.
private const uint PopupBgRgba = 0x102027FF; private const uint WindowBgRgba = 0x070B12FF; // background
private const uint FrameBgRgba = 0x162831FF; private const uint ChildBgRgba = 0x0C1220FF; // background-medium
private const uint FrameBgHoverRgba = 0x1F3540FF; private const uint PopupBgRgba = 0x0C1220FF; // background-medium
private const uint FrameBgActiveRgba = 0x274250FF; private const uint FrameBgRgba = 0x141E30FF; // background-light
private const uint BorderRgba = 0x37474FFF; private const uint FrameBgHoverRgba = 0x1A2538FF; // surface
private const uint FrameBgActiveRgba = 0x22303FFF; // surface-hover
// Cyan-tinted border — matches website --border-brand (cyan @ 40% α).
private const uint BorderRgba = 0x00BED266;
private const uint BorderShadowRgba = 0x00000000; private const uint BorderShadowRgba = 0x00000000;
// Headers / collapsing-headers / tree nodes / selectables. // Headers / collapsing-headers / tree nodes / selectables — same
private const uint HeaderRgba = 0x1B2C36FF; // surface ladder as frames so panels feel consistent.
private const uint HeaderHoverRgba = 0x263A45FF; private const uint HeaderRgba = 0x141E30FF;
private const uint HeaderActiveRgba = 0x324A57FF; private const uint HeaderHoverRgba = 0x1A2538FF;
private const uint HeaderActiveRgba = 0x22303FFF;
// Title bars — tertiary identity for the active state. // Title bars — Identity teal on active so the focused window reads
private const uint TitleBgRgba = 0x0E1A20FF; // as "yours" without using accent or primary slots.
private const uint TitleBgActiveRgba = 0x5E45D9FF; private const uint TitleBgRgba = 0x070B12FF;
private const uint TitleBgCollapsedRgba = 0x0A1318FF; private const uint TitleBgActiveRgba = IdentityRgba;
private const uint TitleBgCollapsedRgba = 0x05080EFF;
// Tabs — tertiary tint, secondary highlight while hovered/unfocused. // Tabs — neutral inactive, Identity-light on hover, Identity teal on
private const uint TabRgba = 0x162831FF; // active. Unfocused-active uses the deeper Identity stage so an
private const uint TabHoveredRgba = 0x9580FFFF; // unfocused window's active tab still reads but does not pull focus.
private const uint TabActiveRgba = 0x7B61FFFF; private const uint TabRgba = 0x141E30FF;
private const uint TabUnfocusedRgba = 0x12222AFF; private const uint TabHoveredRgba = IdentityHoverRgba;
private const uint TabUnfocusedActiveRgba = 0x5E45D9FF; private const uint TabActiveRgba = IdentityRgba;
private const uint TabUnfocusedRgba = 0x0C1220FF;
private const uint TabUnfocusedActiveRgba = IdentityDeepRgba;
// Scrollbar — slate base, secondary amber on grab. // Scrollbar — Ember on grab so the pull stands out without competing
private const uint ScrollbarBgRgba = 0x0E1A20FF; // with the cyan action buttons. Idle grab is a subtle surface tone,
private const uint ScrollbarGrabRgba = 0x37474FFF; // hover/active climb into accent.
private const uint ScrollbarGrabHoveredRgba = 0xFFC940FF; private const uint ScrollbarBgRgba = 0x070B12FF;
private const uint ScrollbarGrabActiveRgba = 0xFFB300FF; private const uint ScrollbarGrabRgba = 0x22303FFF; // surface-hover
private const uint ScrollbarGrabHoveredRgba = AccentHoverRgba;
private const uint ScrollbarGrabActiveRgba = AccentRgba;
// Resize grip — secondary amber for the active corner pull. // Resize grip — same Ember treatment as the scrollbar.
private const uint ResizeGripRgba = 0x37474FFF; private const uint ResizeGripRgba = 0x141E30FF;
private const uint ResizeGripHoveredRgba = 0xFFC940FF; private const uint ResizeGripHoveredRgba = AccentHoverRgba;
private const uint ResizeGripActiveRgba = 0xFFB300FF; private const uint ResizeGripActiveRgba = AccentRgba;
// Separator and check mark / slider follow the primary cyan. // Separator and check mark / slider follow the primary cyan.
+2 -2
View File
@@ -30,14 +30,14 @@ public class SeStringDebugger : Window
DisableWindowSounds = true; DisableWindowSounds = true;
#if DEBUG #if DEBUG
Plugin.Commands.Register("/chat2SeString", showInHelp: false).Execute += Toggle; Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute += Toggle;
#endif #endif
} }
public void Dispose() public void Dispose()
{ {
#if DEBUG #if DEBUG
Plugin.Commands.Register("/chat2SeString", showInHelp: false).Execute -= Toggle; Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute -= Toggle;
#endif #endif
} }
+2 -2
View File
@@ -52,14 +52,14 @@ public sealed class SettingsWindow : Window
Initialise(); Initialise();
Plugin.Commands.Register("/chat2", "Perform various actions with Chat 2.").Execute += Command; Plugin.Commands.Register("/hellion", "Perform various actions with Hellion Chat.").Execute += Command;
Plugin.Interface.UiBuilder.OpenConfigUi += Toggle; Plugin.Interface.UiBuilder.OpenConfigUi += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin.Interface.UiBuilder.OpenConfigUi -= Toggle; Plugin.Interface.UiBuilder.OpenConfigUi -= Toggle;
Plugin.Commands.Register("/chat2").Execute -= Command; Plugin.Commands.Register("/hellion").Execute -= Command;
} }
private void Command(string command, string args) private void Command(string command, string args)
+35 -34
View File
@@ -60,68 +60,69 @@ internal sealed class About : ISettingsTab
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
// Hellion-specific maintainer / attribution / license / SE- ImGui.TextColored(ImGuiColors.ParsedGold, HellionStrings.About_Maintainer_Heading);
// disclaimer block. Hand-rolled in English here rather than via ImGui.TextUnformatted(HellionStrings.About_Maintainer_Body);
// HellionStrings — the legal-ish copy stays close to the EUPL-1.2 ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label);
// wording and the SE disclaimer is the same in every locale.
ImGui.TextColored(ImGuiColors.ParsedGold, "Maintainer");
ImGui.TextUnformatted("Hellion Chat is maintained by Hellion Online Media (Florian Wathling).");
ImGui.TextUnformatted("Website:");
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia"))
Dalamud.Utility.Util.OpenLink("https://hellion-media.de"); Dalamud.Utility.Util.OpenLink("https://hellion-media.de");
ImGui.TextUnformatted("For licensing, legal or contact inquiries please reach out via the website above.");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
ImGui.TextColored(ImGuiColors.ParsedGold, "Built on Chat 2"); ImGui.TextColored(ImGuiColors.ParsedGold, HellionStrings.About_Mission_Heading);
ImGui.TextUnformatted("Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens)."); ImGui.TextUnformatted(HellionStrings.About_Mission_P1);
ImGui.TextUnformatted("Every chat replacement feature, the IPC integration, the rendering engine and the storage core come from upstream Chat 2."); ImGui.Spacing();
ImGui.TextUnformatted("The upstream webinterface is intentionally not part of Hellion Chat — it could not be hardened to the privacy guarantees this fork makes by default."); ImGui.TextUnformatted(HellionStrings.About_Mission_P2);
ImGui.TextUnformatted("Upstream repository:"); ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.About_Mission_P3);
ImGuiHelpers.ScaledDummy(10.0f);
ImGui.TextColored(ImGuiColors.ParsedGold, HellionStrings.About_BuiltOn_Heading);
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_P1);
ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_P2);
ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream"))
Dalamud.Utility.Util.OpenLink("https://github.com/Infiziert90/ChatTwo"); Dalamud.Utility.Util.OpenLink("https://github.com/Infiziert90/ChatTwo");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
ImGui.TextColored(ImGuiColors.ParsedGold, "License"); ImGui.TextColored(ImGuiColors.ParsedGold, HellionStrings.About_License_Heading);
ImGui.TextUnformatted("Hellion Chat and Chat 2 are licensed under the European Union Public License v1.2 (EUPL-1.2)."); ImGui.TextUnformatted(HellionStrings.About_License_P1);
ImGui.TextUnformatted("© 20232026 the Chat 2 authors (Infi, Anna and the upstream contributors)."); ImGui.TextUnformatted(HellionStrings.About_License_P2);
ImGui.TextUnformatted("© 2026 Hellion Online Media — for the Hellion Chat additions."); ImGui.TextUnformatted(HellionStrings.About_License_P3);
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
ImGui.TextColored(ImGuiColors.DalamudOrange, "FINAL FANTASY XIV disclaimer"); ImGui.TextColored(ImGuiColors.DalamudOrange, HellionStrings.About_SE_Heading);
ImGui.TextUnformatted("FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved."); ImGui.TextUnformatted(HellionStrings.About_SE_P1);
ImGui.TextUnformatted("Hellion Chat is an unofficial, fan-made plugin and is not affiliated with, endorsed, sponsored or approved by Square Enix."); ImGui.TextUnformatted(HellionStrings.About_SE_P2);
ImGui.Spacing(); ImGui.Spacing();
ImGui.TextColored(ImGuiColors.ParsedGold, "Localization"); ImGui.TextColored(ImGuiColors.ParsedGold, HellionStrings.About_Localization_Heading);
ImGui.TextUnformatted("German translations of Hellion-specific UI strings (HellionStrings.de.resx) are written by the Hellion Online Media maintainer."); ImGui.TextUnformatted(HellionStrings.About_Localization_P1);
ImGui.TextUnformatted("All other locales for Hellion-specific strings are not currently provided."); ImGui.TextUnformatted(HellionStrings.About_Localization_P2);
ImGui.TextUnformatted("The translator list below covers the upstream Chat 2 community translators on Crowdin — their work covers the inherited Chat 2 strings, not the Hellion additions.");
ImGui.Spacing(); ImGui.Spacing();
var height = ImGui.GetContentRegionAvail().Y - ImGui.CalcTextSize("A").Y - ImGui.GetStyle().ItemSpacing.Y * 2; // The translator list lives at the bottom of the About tab. Render
using (var aboutChild = ImRaii.Child("about", new Vector2(-1, height))) // it directly inside the parent scroll container instead of a
// fixed-height child — the previous "remaining space" calculation
// shrank to zero (or below) once the About copy grew, which made
// the section unreachable on smaller settings windows.
using (var treeNode = ImRaii.TreeNode(HellionStrings.About_Translators_TreeNode))
{ {
if (aboutChild)
{
using var treeNode = ImRaii.TreeNode("Chat 2 community translators (upstream)");
if (treeNode) if (treeNode)
{ {
using var translatorChild = ImRaii.Child("translators"); using var indent = ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false);
if (translatorChild)
{
foreach (var translator in Translators) foreach (var translator in Translators)
ImGui.TextUnformatted(translator); ImGui.TextUnformatted(translator);
} }
} }
}
}
ImGui.Spacing(); ImGui.Spacing();
} }
} }
+17 -4
View File
@@ -55,7 +55,10 @@ internal sealed class Privacy : ISettingsTab
private long CleanupDeleteCount; private long CleanupDeleteCount;
private bool CleanupRunning; private bool CleanupRunning;
private bool RetentionRunning; // The retention-running state lives on Plugin so the auto-sweep and
// this manual button see the same flag. UI reads stay lock-free
// because ImGui is single-threaded and bool reads are atomic in .NET.
private bool RetentionRunning => Plugin.RetentionSweepRunning;
// Export form state // Export form state
private int ExportRangeDays = 30; private int ExportRangeDays = 30;
@@ -104,6 +107,8 @@ internal sealed class Privacy : ISettingsTab
HellionStrings.Privacy_FilterEnabled_Name, HellionStrings.Privacy_FilterEnabled_Name,
HellionStrings.Privacy_FilterEnabled_Description); HellionStrings.Privacy_FilterEnabled_Description);
ImGuiUtil.HelpText(HellionStrings.Privacy_FilterEnabled_StorageOnly_Help);
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
@@ -408,10 +413,17 @@ internal sealed class Privacy : ISettingsTab
private void StartRetentionRun() private void StartRetentionRun()
{ {
if (RetentionRunning) // Take the shared retention lock so we cannot fight the auto-sweep
// for the database connection. If the auto-sweep is already in
// flight we just bail — the user can press the button again once
// it finishes.
lock (Plugin.RetentionSweepLock)
{
if (Plugin.RetentionSweepRunning)
return; return;
Plugin.RetentionSweepRunning = true;
}
RetentionRunning = true;
var policy = Plugin.Config.RetentionPerChannelDays.ToDictionary(p => (int)(ushort)p.Key, p => p.Value); var policy = Plugin.Config.RetentionPerChannelDays.ToDictionary(p => (int)(ushort)p.Key, p => p.Value);
var defaultDays = Plugin.Config.RetentionDefaultDays; var defaultDays = Plugin.Config.RetentionDefaultDays;
@@ -443,7 +455,8 @@ internal sealed class Privacy : ISettingsTab
} }
finally finally
{ {
RetentionRunning = false; lock (Plugin.RetentionSweepLock)
Plugin.RetentionSweepRunning = false;
} }
}) { IsBackground = true }.Start(); }) { IsBackground = true }.Start();
} }
+8 -6
View File
@@ -1,6 +1,6 @@
# Hellion Chat # Hellion Chat
**Version 0.2.0** — DSGVO-bewusste Erweiterung von [Chat 2](https://github.com/Infiziert90/ChatTwo) für FINAL FANTASY XIV / Dalamud. **Version 0.3.0** — DSGVO-bewusste Erweiterung von [Chat 2](https://github.com/Infiziert90/ChatTwo) für FINAL FANTASY XIV / Dalamud.
Hellion Chat baut auf Chat 2 auf und ergänzt es um Datenschutz- und Daten-Handling-Kontrollen, die mit den Datenschutz-Regeln in der EU, den USA und Japan im Einklang sind. Alle Chat-2-Funktionen, Befehle und Tastenkürzel funktionieren unverändert. Eigenständiger Plugin-Slot, eigene Konfiguration, eigene Datenbank. Hellion Chat baut auf Chat 2 auf und ergänzt es um Datenschutz- und Daten-Handling-Kontrollen, die mit den Datenschutz-Regeln in der EU, den USA und Japan im Einklang sind. Alle Chat-2-Funktionen, Befehle und Tastenkürzel funktionieren unverändert. Eigenständiger Plugin-Slot, eigene Konfiguration, eigene Datenbank.
@@ -56,7 +56,7 @@ Privates Repository, EUPL-1.2-lizenziert. Distribution über Custom-Repo währen
### Was gegenüber Chat 2 fehlt ### Was gegenüber Chat 2 fehlt
- **Webinterface** wurde in Hellion Chat 0.2.0 entfernt. Der eingebaute HTTP-Server hat unter dem Privacy-Versprechen nicht abgesichert werden können (5-stelliger numerischer Auth-Code aus `System.Random`, Bind auf alle Interfaces per Default, Cookies ohne Security-Flags und ein Server-Sent-Events-Stream der den Privacy-Filter umgangen hat). Wer den Funktionsumfang von Chat 2 vollständig braucht, sollte beim Upstream-Plugin bleiben; Hellion Chat fokussiert auf DSGVO-konforme Persistenz und verzichtet bewusst auf Remote-Zugriffs-Features. - **Webinterface** wurde in Hellion Chat 0.2.0 entfernt. Es bedient einen anderen Anwendungsfall als der Fokus dieses Forks, nämlich Remote-Zugriff auf den Chat von einem zweiten Gerät. An die kleineren Defaults dieses Forks anzupassen hätte einen erheblichen Umbau bedeutet, also ist es ersatzlos entfernt worden. Wer den vollen Funktionsumfang von Chat 2 chte, ist mit dem Upstream-Plugin besser bedient. Hellion Chat fokussiert sich auf einen schmaleren Datenbestand und verzichtet bewusst auf Remote-Zugriffs-Features.
--- ---
@@ -231,7 +231,7 @@ Konflikte in Upstream-Sprach-Ressourcen (`Language.<lang>.resx`) kommen häufig
## Projektstatus ## Projektstatus
**Version 0.2.0** | Stand: Mai 2026 **Version 0.3.0** | Stand: Mai 2026
Alle Bootstrap-Phasen abgeschlossen: Alle Bootstrap-Phasen abgeschlossen:
@@ -244,11 +244,13 @@ Alle Bootstrap-Phasen abgeschlossen:
- [x] About-Tab im Hellion-Branding mit License + Disclaimer - [x] About-Tab im Hellion-Branding mit License + Disclaimer
- [x] AI-Disclosure dokumentiert (Pair-Klassifikation) - [x] AI-Disclosure dokumentiert (Pair-Klassifikation)
- [x] Webinterface entfernt (Phase 1.5, Audit-Konsequenz aus 2026-05-02) - [x] Webinterface entfernt (Phase 1.5, Audit-Konsequenz aus 2026-05-02)
- [x] Audit-Hardening Phase 2 (Path-Traversal, Retention-Race, DbViewer-Konsistenz, Privacy-Filter-Help-Text)
- [x] Slash-Commands auf `/hellion`-Familie umbenannt
- [x] Theme auf Hellion-Online-Media-Brand-Palette aligned (Arctic Cyan + Ember Orange)
- [x] About-Tab vollständig lokalisiert (EN + DE) mit Mission-Statement und neutraler Tonart
Phase 2 (offen, kein festes Datum): Phase 3 (offen, kein festes Datum):
- [ ] EmoteCache Path-Traversal-Hardening (`Path.GetFullPath` + StartsWith-Check)
- [ ] Race-Hardening für `RetentionLastRunAt` (CompareExchange / Lock)
- [ ] MySQL/MariaDB-Backend mit Drei-Stufen-Bestätigung - [ ] MySQL/MariaDB-Backend mit Drei-Stufen-Bestätigung
- [ ] PostgreSQL-Backend - [ ] PostgreSQL-Backend
- [ ] Encryption für sensible Channels (AES-256, lokaler Key) - [ ] Encryption für sensible Channels (AES-256, lokaler Key)
+7 -7
View File
File diff suppressed because one or more lines are too long