From 0551116a0c9ca1e61550aa8177decb0a521e2749 Mon Sep 17 00:00:00 2001 From: Jon Kazama Date: Wed, 19 Aug 2026 09:52:49 +0200 Subject: [PATCH] refactor(sidebar): let the channel header resolve the same icon Visibility only. The header has to show the icon the sidebar row shows, and the lookup table alone would not do it: it only answers for a tab with an explicitly chosen icon, and the default is none. Most tabs reach their icon through the derivation this method wraps. --- HellionChat/Ui/Components/Sidebar.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/HellionChat/Ui/Components/Sidebar.cs b/HellionChat/Ui/Components/Sidebar.cs index b0b4a02..1a2c890 100644 --- a/HellionChat/Ui/Components/Sidebar.cs +++ b/HellionChat/Ui/Components/Sidebar.cs @@ -486,7 +486,11 @@ internal sealed class Sidebar ImGui.PopID(); } - private static FontAwesomeIcon ResolveTabIcon(Tab tab) + // internal since v1.13.0: the channel header shows the same icon as the row + // in here, and it has to resolve it the same way. IconByName alone would not + // do -- it only answers for a tab with an explicitly chosen icon, and the + // default is none, so most tabs fall through to the derivation below. + internal static FontAwesomeIcon ResolveTabIcon(Tab tab) { if ( !string.IsNullOrWhiteSpace(tab.Icon) && IconByName.TryGetValue(tab.Icon, out var mapped)