Implement #101

ChatTwo/ChatTwo.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
-        <Version>1.28.1</Version>
+        <Version>1.28.2</Version>
         <TargetFramework>net8.0-windows</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>

ChatTwo/ChatTwo.yaml

@@ -22,21 +22,7 @@ tags:
   - Chat
   - Replacement
 changelog:  |-
-  **Fonts**
-  - Uses dalamud font chooser
-  - Italic font version can be chosen
-  - Config options related to fonts have been reset
-  - Old font names and sizes used are displayed for up to a month
-
-  **LiteDB**
-  - Migration option removed
-  - Old files can still be deleted in the database tab
-
-  **Keybinds**
-  - Avoids overriding modifiers after leaving a vanilla text box [thanks dean]
-    - This would prevent you from holding e.g. Ctrl between multiple vanilla text boxes
-  - Reworks linkshell rotation code to fix issues with LS number gaps causing linkshell rotation to not function [thanks dean]
-
-  **Textures**
-  - Switch to dalamuds internal texture cache
-  - Role icons are now compatible with penumbra [thanks mopi]
+  **Misc**
+  - Implement 24-hour clock timestamp option [default false]
+  - Fix hide activity channels not being saved across sessions
+  - Loc updates

ChatTwo/Configuration.cs

@@ -75,6 +75,7 @@ internal class Configuration : IPluginConfiguration
     public bool PlaySounds = true;
     public bool KeepInputFocus = true;
     public int MaxLinesToRender = 10_000;
+    public bool Use24HourClock;
 
     public bool ShowEmotes = true;
     public HashSet<string> BlockedEmotes = [];
@@ -163,6 +164,7 @@ internal class Configuration : IPluginConfiguration
         PlaySounds = other.PlaySounds;
         KeepInputFocus = other.KeepInputFocus;
         MaxLinesToRender = other.MaxLinesToRender;
+        Use24HourClock = other.Use24HourClock;
         ShowEmotes = other.ShowEmotes;
         BlockedEmotes = other.BlockedEmotes;
         FontsEnabled = other.FontsEnabled;

ChatTwo/Resources/Language.Designer.cs

@@ -3380,6 +3380,24 @@ namespace ChatTwo.Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Display timestamps as their 24-hour clock version..
+        /// </summary>
+        internal static string Options_Use24HourClock_Description {
+            get {
+                return ResourceManager.GetString("Options_Use24HourClock_Description", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to 24-hour clock.
+        /// </summary>
+        internal static string Options_Use24HourClock_Name {
+            get {
+                return ResourceManager.GetString("Options_Use24HourClock_Name", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to This feature isn&apos;t implemented yet.
         /// </summary>

ChatTwo/Resources/Language.resx

@@ -151,6 +151,12 @@
     <data name="Options_PrettierTimestamps_Description">
         <value>Display messages in a more modern style.</value>
     </data>
+    <data name="Options_Use24HourClock_Name">
+        <value>24-hour clock</value>
+    </data>
+    <data name="Options_Use24HourClock_Description">
+        <value>Display timestamps as their 24-hour clock version.</value>
+    </data>
     <data name="Options_MoreCompactPretty_Name">
         <value>More compact modern layout</value>
     </data>

ChatTwo/Ui/ChatLogWindow.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Globalization;
 using System.Numerics;
 using System.Runtime.InteropServices;
 using System.Text;
@@ -1074,13 +1075,14 @@ public sealed class ChatLogWindow : Window
 
                 if (tab.DisplayTimestamp)
                 {
-                    var timestamp = message.Date.ToLocalTime().ToString("t");
+                    var timestamp = message.Date.ToLocalTime().ToString("t", !Plugin.Config.Use24HourClock ? null : CultureInfo.CreateSpecificCulture("es-ES"));
                     if (isTable)
                     {
                         if (!Plugin.Config.HideSameTimestamps || timestamp != lastTimestamp)
                         {
                             lastTimestamp = timestamp;
                             ImGui.TextUnformatted(timestamp);
+
                             // We use an IsItemHovered() check here instead of
                             // just calling SetTooltip() to avoid computing the
                             // tooltip string for all visible items on every

ChatTwo/Ui/SettingsTabs/Display.cs

@@ -96,6 +96,8 @@ internal sealed class Display : ISettingsTab
         ImGui.Separator();
         ImGui.Spacing();
 
+        ImGuiUtil.OptionCheckbox(ref Mutable.Use24HourClock, Language.Options_Use24HourClock_Name, Language.Options_Use24HourClock_Description);
+
         ImGuiUtil.OptionCheckbox(ref Mutable.PrettierTimestamps, Language.Options_PrettierTimestamps_Name, Language.Options_PrettierTimestamps_Description);
 
         if (Mutable.PrettierTimestamps)