JonKazama-Hellion/HellionChat
1
0
Fork 0
Code Issues Pull Requests Actions Releases 28 Activity

Temp fix for FPS drops with too many messages rendered

Browse Source 
- Also replaces TextWrap with an ImRaii using version
This commit is contained in:
Infi
2024-05-13 15:24:51 +02:00
parent b7c6c1da5a
commit 26e993be67
5 changed files with 73 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ChatTwo/Ui/ChatLogWindow.cs
+26 -6
View File
@@ -896,6 +896,12 @@ public sealed class ChatLogWindow : Window
private void DrawMessages(Tab tab, PayloadHandler handler, bool isTable, bool moreCompact = false, float oldCellPaddingY = 0)
{
// TODO Remove when the temp fix is replaced with a perm one
Plugin.DebuggerWindow.InvisibleMessages = 0;
Plugin.DebuggerWindow.InvisibleAfter = 0;
Plugin.DebuggerWindow.HeightNull = 0;
Plugin.DebuggerWindow.HeightCalculationsInside = 0;
try
{
tab.MessagesMutex.Wait();
@@ -963,13 +969,19 @@ public sealed class ChatLogWindow : Window
if (i > 0)
{
var prevMessage = tab.Messages[i - 1];
if (prevMessage.IsVisible.TryGetValue(tab.Identifier, out var prevVisible) && prevVisible)
// TODO: TryGetValue isn't always true for some strange reason
// This should be looked into, because default will be null for the prevHeight in that case
prevMessage.Height.TryGetValue(tab.Identifier, out var prevHeight);
if (prevHeight == null || (prevMessage.IsVisible.TryGetValue(tab.Identifier, out var prevVisible) && prevVisible))
{
Plugin.DebuggerWindow.HeightCalculationsInside++;
var newHeight = ImGui.GetCursorPosY() - lastPosY;
// Remove the padding from the bottom of the previous row and the top of the current row.
if (isTable && !moreCompact)
// Remove the padding from the bottom of the
// previous row and the top of the current row.
newHeight -= oldCellPaddingY * 2;
if (newHeight != 0)
prevMessage.Height[tab.Identifier] = newHeight;
}
@@ -979,9 +991,12 @@ public sealed class ChatLogWindow : Window
// message has rendered once
// message isn't visible, so render dummy
message.Height.TryGetValue(tab.Identifier, out var height);
if (height == null)
Plugin.DebuggerWindow.HeightNull++;
message.IsVisible.TryGetValue(tab.Identifier, out var visible);
if (height != null && !visible)
{
Plugin.DebuggerWindow.InvisibleMessages++;
var beforeDummy = ImGui.GetCursorPos();
// skip to the message column for vis test
@@ -999,7 +1014,9 @@ public sealed class ChatLogWindow : Window
ImGui.SetCursorPos(beforeDummy);
}
else
{
continue;
}
}
if (tab.DisplayTimestamp)
@@ -1034,14 +1051,17 @@ public sealed class ChatLogWindow : Window
ImGui.SameLine();
}
// We need to draw something otherwise the item visibility check below won't work.
if (message.Content.Count == 0)
// We need to draw something otherwise the item visibility
// check below won't work.
DrawChunks(new[] { new TextChunk(ChunkSource.Content, null, " ") }, true, handler, lineWidth);
else
DrawChunks(message.Content, true, handler, lineWidth);
message.IsVisible[tab.Identifier] = ImGui.IsItemVisible();
var vis = ImGui.IsItemVisible();
if (!vis)
Plugin.DebuggerWindow.InvisibleAfter++;
message.IsVisible[tab.Identifier] = vis;
}
}
finally
ChatTwo/Ui/Debugger.cs
+11
View File
@@ -11,6 +11,11 @@ public class DebuggerWindow : Window
private readonly Plugin Plugin;
private readonly ChatLogWindow ChatLogWindow;
public int InvisibleMessages;
public int InvisibleAfter;
public int HeightNull;
public int HeightCalculationsInside;
public DebuggerWindow(Plugin plugin) : base($"Debugger###chat2-debugger")
{
Plugin = plugin;
@@ -50,5 +55,11 @@ public class DebuggerWindow : Window
ImGui.TextUnformatted($"Hovered Item: {ChatLogWindow.PayloadHandler._hoveredItem}");
ImGui.TextUnformatted($"Hover Counter: {ChatLogWindow.PayloadHandler._hoverCounter}");
ImGui.TextUnformatted($"Last Hover Counter: {ChatLogWindow.PayloadHandler._lastHoverCounter}");
ImGui.NewLine();
ImGui.NewLine();
ImGui.TextUnformatted($"Invisible Messages: {InvisibleMessages}");
ImGui.TextUnformatted($"Invisible After: {InvisibleAfter}");
ImGui.TextUnformatted($"Height was null: {HeightNull}");
ImGui.TextUnformatted($"Actual Height Calculations {HeightCalculationsInside}");
}
}