From 57da4557002a7fd31048348352e932d5e31d7bbc Mon Sep 17 00:00:00 2001 From: Jon Kazama Date: Tue, 12 May 2026 10:47:43 +0200 Subject: [PATCH] fix: post-review polish on v1.4.4 - IsAllowedForStorage warning now only fires for ChatTypes the build doesn't recognise (Enum.IsDefined), not for opted-out known ones - Drop stale tests-location comment in HonorificService --- HellionChat/Configuration.cs | 10 ++++++---- HellionChat/Integrations/HonorificService.cs | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/HellionChat/Configuration.cs b/HellionChat/Configuration.cs index 920caa3..c463467 100755 --- a/HellionChat/Configuration.cs +++ b/HellionChat/Configuration.cs @@ -77,12 +77,14 @@ public class Configuration : IPluginConfiguration if (PrivacyPersistChannels.Contains(type)) return true; - // F3.2: log first occurrence so a new patch's ChatType doesn't drop - // off the radar. Failsafe still applies via PrivacyPersistUnknownChannels. - if (_warnedUnknownChannels.Add(type)) + // F3.2: log first occurrence of a ChatType the running build doesn't + // recognise — i.e. one a future FFXIV patch may have added. Known + // types the user opted out of are routed through the failsafe + // silently, like before. + if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type)) { Plugin.Log.Warning( - "PrivacyFilter: unknown ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.", + "PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.", type, PrivacyPersistUnknownChannels ); diff --git a/HellionChat/Integrations/HonorificService.cs b/HellionChat/Integrations/HonorificService.cs index 446d972..73b47d3 100644 --- a/HellionChat/Integrations/HonorificService.cs +++ b/HellionChat/Integrations/HonorificService.cs @@ -156,8 +156,6 @@ internal sealed class HonorificService : IDisposable } } - // --- Pure-logic helpers; tested via HellionChat.Tests/Integrations. --- - internal static HonorificTitleData? ParseTitleJson(string json) { if (string.IsNullOrEmpty(json))