From 66450dd51821adef1ebfb464584bf8641dff2f46 Mon Sep 17 00:00:00 2001 From: JonKazama-Hellion Date: Sat, 2 May 2026 21:19:40 +0200 Subject: [PATCH] refactor(i18n): pull tabs and database tab names into hellionstrings Both tab classes were the last two settings tabs still pulling their display name from the upstream Language resource bundle. Move them into HellionStrings so all eight settings tabs share one i18n source. The unused Language.Options_*_Tab keys stay around for backwards compat with cherry-picked upstream tabs. --- ChatTwo/Resources/HellionStrings.Designer.cs | 2 ++ ChatTwo/Resources/HellionStrings.de.resx | 6 ++++++ ChatTwo/Resources/HellionStrings.resx | 6 ++++++ ChatTwo/Ui/SettingsTabs/Database.cs | 2 +- ChatTwo/Ui/SettingsTabs/Tabs.cs | 2 +- 5 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ChatTwo/Resources/HellionStrings.Designer.cs b/ChatTwo/Resources/HellionStrings.Designer.cs index c4dd719..671109f 100644 --- a/ChatTwo/Resources/HellionStrings.Designer.cs +++ b/ChatTwo/Resources/HellionStrings.Designer.cs @@ -196,6 +196,8 @@ internal class HellionStrings internal static string Settings_Tab_Appearance => Get(nameof(Settings_Tab_Appearance)); internal static string Settings_Tab_Window => Get(nameof(Settings_Tab_Window)); internal static string Settings_Tab_Chat => Get(nameof(Settings_Tab_Chat)); + internal static string Settings_Tab_Tabs => Get(nameof(Settings_Tab_Tabs)); + internal static string Settings_Tab_Database => Get(nameof(Settings_Tab_Database)); internal static string Settings_Tab_Information => Get(nameof(Settings_Tab_Information)); // Hellion Chat — General-Tab section headings diff --git a/ChatTwo/Resources/HellionStrings.de.resx b/ChatTwo/Resources/HellionStrings.de.resx index 1f9b7f4..d82ef5a 100644 --- a/ChatTwo/Resources/HellionStrings.de.resx +++ b/ChatTwo/Resources/HellionStrings.de.resx @@ -445,6 +445,12 @@ Chat + + Kanäle + + + Datenbank + Über diff --git a/ChatTwo/Resources/HellionStrings.resx b/ChatTwo/Resources/HellionStrings.resx index 519f010..6617440 100644 --- a/ChatTwo/Resources/HellionStrings.resx +++ b/ChatTwo/Resources/HellionStrings.resx @@ -445,6 +445,12 @@ Chat + + Tabs + + + Database + Information diff --git a/ChatTwo/Ui/SettingsTabs/Database.cs b/ChatTwo/Ui/SettingsTabs/Database.cs index afa75e9..46e6b12 100755 --- a/ChatTwo/Ui/SettingsTabs/Database.cs +++ b/ChatTwo/Ui/SettingsTabs/Database.cs @@ -16,7 +16,7 @@ internal sealed class Database : ISettingsTab private Plugin Plugin { get; } private Configuration Mutable { get; } - public string Name => Language.Options_Database_Tab + "###tabs-database"; + public string Name => HellionStrings.Settings_Tab_Database + "###tabs-database"; internal Database(Plugin plugin, Configuration mutable) { diff --git a/ChatTwo/Ui/SettingsTabs/Tabs.cs b/ChatTwo/Ui/SettingsTabs/Tabs.cs index 518644f..1f4b7ee 100755 --- a/ChatTwo/Ui/SettingsTabs/Tabs.cs +++ b/ChatTwo/Ui/SettingsTabs/Tabs.cs @@ -13,7 +13,7 @@ internal sealed class Tabs : ISettingsTab private Plugin Plugin { get; } private Configuration Mutable { get; } - public string Name => Language.Options_Tabs_Tab + "###tabs-tabs"; + public string Name => HellionStrings.Settings_Tab_Tabs + "###tabs-tabs"; private int ToOpen = -2;