fix: close what the style review found, starting with a gate the metadata skipped

The real defect first. RefreshDatabaseMetadata was the one worker of six
that never took the shared lock, and its flag was the one of six missing
from the tab's busy state. It calls MessageCount, which holds the read
lock, so a wipe could start while it was in there -- and the tab would
not have known to grey the button, because it could not see the worker.
Both halves fixed. The pattern is why: seven near-copies of one worker
skeleton, and each copy decided something slightly different.

The clear button failed silently when its thread could not start. The
most destructive control in the plugin, pressed, and nothing happens,
with no way to tell that from a wipe that worked -- while the three
harmless workers beside it do report. Maintenance was the mirror: its
comment promises refusals are said out loud, and then swallowed the
actual failure. Three start-failure paths also bypassed the notify
helper that carries the teardown check, three weeks after it was added
for exactly that.

The database numbers now wait for a real read, like the clear hint
already did. Zero bytes and zero messages read as an empty database, not
as a number nobody has fetched.

SelectionAfterDelete is gone, with its three tests. The accordion has no
selection, so its return value went into a discard -- a function
answering a question the interface does not ask, with green tests
guarding nothing. The project's own self-test README calls that the
anti-pattern of record.

Six new keys replaced by the translated orphans that already said the
same thing. A commit earlier in this cycle is literally called "stop
duplicating a key" and these went past it. The duplicate button also had
the label "Add", which is the one string out of ninety-four that was
never written.

Tests: CleanupDeleteTypes had none, and with the failsafe on -- how a
fresh config ships -- it is the path every cleanup takes. Four now,
including the one that matters: an empty list deletes nothing rather
than everything.

And a self-test for the gate wiring, which is what would have caught the
metadata worker. The unit tests prove the gate works; nothing proved the
workers use it.
This commit is contained in:
2026-08-19 07:09:54 +02:00
parent e7b76fb21b
commit 9ea9e96145
37 changed files with 310 additions and 529 deletions
+3 -18
View File
@@ -1094,12 +1094,6 @@
<data name="Settings_Emotes_Block" xml:space="preserve">
<value>Bloquear</value>
</data>
<data name="Settings_NotifyFailedTell_Name" xml:space="preserve">
<value>Avisar cuando un tell no llega</value>
</data>
<data name="Settings_NotifyFailedTell_Description" xml:space="preserve">
<value>El juego solo informa de un tell fallido en el registro. Esto muestra una notificación, para que un mensaje a alguien desconectado o en otro mundo no pase desapercibido.</value>
</data>
<data name="ChatLog_ScrollToBottom_Tooltip" xml:space="preserve">
<value>Ir al mensaje más reciente</value>
</data>
@@ -1163,9 +1157,6 @@
<data name="Settings_Section_License" xml:space="preserve">
<value>Licencia</value>
</data>
<data name="Settings_General_ReduceMotion_Description" xml:space="preserve">
<value>Desactiva las transiciones del tema, los efectos al pasar el cursor y las partículas.</value>
</data>
<data name="Settings_Keybinds_Hint" xml:space="preserve">
<value>Haz clic en un botón y luego pulsa la combinación de teclas. Esc borra.</value>
</data>
@@ -1223,12 +1214,6 @@
<data name="Settings_Window_PopoutTitleBar_Name" xml:space="preserve">
<value>Barra de título en pop-outs</value>
</data>
<data name="Settings_Window_InactiveOpacity_Name" xml:space="preserve">
<value>Opacidad inactiva</value>
</data>
<data name="Settings_Window_InactiveOpacity_Description" xml:space="preserve">
<value>Se aplica mientras otra ventana tiene el foco.</value>
</data>
<data name="Settings_Window_AllowMove_Name" xml:space="preserve">
<value>Permitir mover</value>
</data>
@@ -1307,9 +1292,6 @@
<data name="Settings_Theme_ImportFile" xml:space="preserve">
<value>Importar archivo de tema…</value>
</data>
<data name="Settings_Theme_ExportActive" xml:space="preserve">
<value>Exportar el tema activo…</value>
</data>
<data name="Settings_Theme_ImportPathHint" xml:space="preserve">
<value>Ruta al archivo JSON (o arrástralo a la carpeta)</value>
</data>
@@ -1343,4 +1325,7 @@
<data name="Settings_Preview_TypeAMessage" xml:space="preserve">
<value>Escribe un mensaje...</value>
</data>
<data name="Settings_Tabs_Duplicate" xml:space="preserve">
<value>Duplicar</value>
</data>
</root>