From a10c115b9bd69ea887a5cf029b749c4dfe92b21b Mon Sep 17 00:00:00 2001 From: JonKazama-Hellion Date: Sun, 3 May 2026 22:05:20 +0200 Subject: [PATCH] fix: IDisposable contract + zh-Hans webinterface translation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Ui/Debugger.cs DebuggerWindow now declares IDisposable so the existing Dispose() method participates in disposal patterns (using-blocks, container cleanup). Previously the method existed but the type didn't advertise it, so callers had no way to invoke it correctly and the command-handler subscription leaked - Resources/Language.zh-Hans.resx Webinterface_Start_Success contained "网页界面已停止。" (web interface stopped) for what is semantically the start-success message; corrected to "网页界面已启动。" (web interface started). String is unused in the Hellion fork (webinterface removed) but remains in the resource bundle for upstream compatibility --- HellionChat/Resources/Language.zh-Hans.resx | 2 +- HellionChat/Ui/Debugger.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/HellionChat/Resources/Language.zh-Hans.resx b/HellionChat/Resources/Language.zh-Hans.resx index 1ccc180..ee716eb 100644 --- a/HellionChat/Resources/Language.zh-Hans.resx +++ b/HellionChat/Resources/Language.zh-Hans.resx @@ -1364,7 +1364,7 @@ 启动 - 网页界面已停止。 + 网页界面已启动。 网页界面启动失败。检查 /xllog 获取更多信息。 diff --git a/HellionChat/Ui/Debugger.cs b/HellionChat/Ui/Debugger.cs index 8f69694..ffeeee6 100644 --- a/HellionChat/Ui/Debugger.cs +++ b/HellionChat/Ui/Debugger.cs @@ -9,7 +9,7 @@ using Lumina.Text.ReadOnly; namespace HellionChat.Ui; -public class DebuggerWindow : Window +public class DebuggerWindow : Window, IDisposable { private readonly Plugin Plugin; private readonly ChatLogWindow ChatLogWindow;