JonKazama-Hellion/HellionChat
1
0
Fork 0
Code Issues 1 Pull Requests Actions Releases 28 Activity

revert(top-tabs): drop icon prefix — Dalamud default font lacks FontAwesome codepoints

Browse Source 
Tofu-squares rendered in-game (verified by Flo 2026-05-05 19:21).
ImGui TabItem labels render in a single font frame; mixed-font
(FontAwesome icon + default font for tab name) is not possible
without Font-Atlas merging at FontManager level — out of scope
for v1.2.0.

Top-Tabs visual modernization is now driven by the Underline-Pill
alone (T6, kept). Sidebar (icon-only) remains the use case where
icons earn their keep. v1.2.0 Akzeptanzkriterium AC1 wird auf
"Top-Tabs haben Pill-Underline" reduziert.
This commit is contained in:
Jon Kazama
2026-05-05 19:23:26 +02:00
parent bc0f44712f
commit c28c972ae3
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HellionChat/Ui/ChatLogWindow.cs
+1 -7
View File
@@ -1360,13 +1360,7 @@ public sealed class ChatLogWindow : Window
if (Plugin.WantedTab == tabI) if (Plugin.WantedTab == tabI)
flags |= ImGuiTabItemFlags.SetSelected; flags |= ImGuiTabItemFlags.SetSelected;
// v1.2.0 — Icon-Glyph als Prefix vor dem Tab-Namen. using var tabItem = ImRaii.TabItem($"{tab.Name}{unread}###log-tab-{tabI}", flags);
// Strategy A: Codepoint einfach in den Label-String einbauen.
// Funktioniert wenn Dalamuds Default-Font-Atlas FontAwesome-
// Glyphen mit-merged. Falls nicht (Tofu-Square sichtbar),
// wechseln wir auf Strategy B mit separatem Icon-Render.
var icon = TabIconMapping.Resolve(tab);
using var tabItem = ImRaii.TabItem($"{icon.ToIconString()} {tab.Name}{unread}###log-tab-{tabI}", flags);
DrawTabContextMenu(tab, tabI); DrawTabContextMenu(tab, tabI);
if (!tabItem.Success) if (!tabItem.Success)