docs(comments): trim verbose dispose and thread rationale
Match the new HellionChat comment-length convention: 1-3 lines for standard pitfall notes, 5+ only for non-trivial workarounds. The previous Dispose comment was 14 lines of textbook prose, which veered into AI-slop territory and would rot on the next refactor.
This commit is contained in:
@@ -66,11 +66,8 @@ internal class MessageManager : IAsyncDisposable
|
||||
|
||||
Store = new MessageStore(DatabasePath());
|
||||
|
||||
// IsBackground = true so a stuck worker never blocks plugin unload.
|
||||
// The worker has its own cancellation path via PendingThreadCancellationToken,
|
||||
// and DisposeAsync waits up to 10s for cooperative shutdown. The
|
||||
// background flag is the safety net for the case where cooperative
|
||||
// shutdown fails to drain the queue in time.
|
||||
// IsBackground so a stuck worker never blocks plugin unload.
|
||||
// Cooperative cancel via PendingThreadCancellationToken first, background flag is the safety net.
|
||||
PendingMessageThread = new Thread(() => ProcessPendingMessages(PendingThreadCancellationToken.Token))
|
||||
{
|
||||
IsBackground = true,
|
||||
|
||||
Reference in New Issue
Block a user