style: align v1.4.5 additions with HellionChat conventions

Pattern-adherence pass after the cycle's code commits:

- ChatLogWindow.cs: NotifiedDrawFailure renamed from
  _notifiedDrawFailure. The file's per-window state flags (DrewThisFrame,
  WasDocked, Activate, PlayedClosingSound, …) all use PascalCase
  without underscore prefix; the new flag now matches that
- Plugin.cs: trim the session-only RemoveAll comment from 5 lines to 2
  and add the standard TEST-MIRROR pointer line. Same shape as
  AutoTellTabsService.cs:28 and the other six TEST-MIRROR sites
- InputHistoryService.cs: add the TEST-MIRROR pointer for the new
  Build-Suite tests
This commit is contained in:
2026-05-12 15:30:01 +02:00
parent cafb6faa39
commit d0ec94c3e6
3 changed files with 8 additions and 9 deletions
+1
View File
@@ -4,6 +4,7 @@ namespace HellionChat;
// Shared input history for all ChatInputBars (main and pop-out windows).
// Push deduplicates: existing entries are moved to the end when re-added.
// TEST-MIRROR: ../../Hellion Build test/Util/InputHistoryServiceTests.cs
public static class InputHistoryService
{
private const int MaxSize = 30;
+3 -5
View File
@@ -164,11 +164,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
);
}
// Auto-Tell-Tabs are session-only: their messages are usually
// privacy-filtered and resurrecting an empty tab from a crashed
// session would trigger DB-reconstruction on the next load. The
// TempTabCounter then re-pegs the snapshot from the stripped list in
// AutoTellTabsService.Initialize. (F2.3 — TEST-MIRROR in Build-Suite.)
// Session-only tabs are stripped on every load; AutoTellTabsService.Initialize
// then re-pegs TempTabCounter from the stripped list, not the pre-strip snapshot.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/TempTabCounterTests.cs
Config.Tabs.RemoveAll(t => t.IsTempTab);
LanguageChanged(Interface.UiLanguage);
+4 -4
View File
@@ -90,9 +90,9 @@ public sealed class ChatLogWindow : Window
private bool PlayedClosingSound = true;
private bool DrewThisFrame;
// F7.1: one-shot guard so a recurring draw failure doesn't spam the
// One-shot guard so a recurring draw failure doesn't spam the
// notification stack frame-by-frame. Resets only on next plugin reload.
private bool _notifiedDrawFailure;
private bool NotifiedDrawFailure;
private long FrameTime; // set every frame
internal long LastActivityTime = Environment.TickCount64;
@@ -631,7 +631,7 @@ public sealed class ChatLogWindow : Window
catch (Exception ex)
{
Plugin.Log.Error(ex, "Error drawing Chat Log window");
if (!_notifiedDrawFailure)
if (!NotifiedDrawFailure)
{
Plugin.Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification
@@ -642,7 +642,7 @@ public sealed class ChatLogWindow : Window
InitialDuration = TimeSpan.FromSeconds(20),
}
);
_notifiedDrawFailure = true;
NotifiedDrawFailure = true;
}
// Prevent recurring draw failures from constantly trying to grab
// input focus, which breaks every other ImGui window.