style: align v1.4.5 additions with HellionChat conventions
Pattern-adherence pass after the cycle's code commits: - ChatLogWindow.cs: NotifiedDrawFailure renamed from _notifiedDrawFailure. The file's per-window state flags (DrewThisFrame, WasDocked, Activate, PlayedClosingSound, …) all use PascalCase without underscore prefix; the new flag now matches that - Plugin.cs: trim the session-only RemoveAll comment from 5 lines to 2 and add the standard TEST-MIRROR pointer line. Same shape as AutoTellTabsService.cs:28 and the other six TEST-MIRROR sites - InputHistoryService.cs: add the TEST-MIRROR pointer for the new Build-Suite tests
This commit is contained in:
@@ -4,6 +4,7 @@ namespace HellionChat;
|
|||||||
|
|
||||||
// Shared input history for all ChatInputBars (main and pop-out windows).
|
// Shared input history for all ChatInputBars (main and pop-out windows).
|
||||||
// Push deduplicates: existing entries are moved to the end when re-added.
|
// Push deduplicates: existing entries are moved to the end when re-added.
|
||||||
|
// TEST-MIRROR: ../../Hellion Build test/Util/InputHistoryServiceTests.cs
|
||||||
public static class InputHistoryService
|
public static class InputHistoryService
|
||||||
{
|
{
|
||||||
private const int MaxSize = 30;
|
private const int MaxSize = 30;
|
||||||
|
|||||||
@@ -164,11 +164,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Auto-Tell-Tabs are session-only: their messages are usually
|
// Session-only tabs are stripped on every load; AutoTellTabsService.Initialize
|
||||||
// privacy-filtered and resurrecting an empty tab from a crashed
|
// then re-pegs TempTabCounter from the stripped list, not the pre-strip snapshot.
|
||||||
// session would trigger DB-reconstruction on the next load. The
|
// TEST-MIRROR: ../../Hellion Build test/_Helpers/TempTabCounterTests.cs
|
||||||
// TempTabCounter then re-pegs the snapshot from the stripped list in
|
|
||||||
// AutoTellTabsService.Initialize. (F2.3 — TEST-MIRROR in Build-Suite.)
|
|
||||||
Config.Tabs.RemoveAll(t => t.IsTempTab);
|
Config.Tabs.RemoveAll(t => t.IsTempTab);
|
||||||
|
|
||||||
LanguageChanged(Interface.UiLanguage);
|
LanguageChanged(Interface.UiLanguage);
|
||||||
|
|||||||
@@ -90,9 +90,9 @@ public sealed class ChatLogWindow : Window
|
|||||||
private bool PlayedClosingSound = true;
|
private bool PlayedClosingSound = true;
|
||||||
private bool DrewThisFrame;
|
private bool DrewThisFrame;
|
||||||
|
|
||||||
// F7.1: one-shot guard so a recurring draw failure doesn't spam the
|
// One-shot guard so a recurring draw failure doesn't spam the
|
||||||
// notification stack frame-by-frame. Resets only on next plugin reload.
|
// notification stack frame-by-frame. Resets only on next plugin reload.
|
||||||
private bool _notifiedDrawFailure;
|
private bool NotifiedDrawFailure;
|
||||||
|
|
||||||
private long FrameTime; // set every frame
|
private long FrameTime; // set every frame
|
||||||
internal long LastActivityTime = Environment.TickCount64;
|
internal long LastActivityTime = Environment.TickCount64;
|
||||||
@@ -631,7 +631,7 @@ public sealed class ChatLogWindow : Window
|
|||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
Plugin.Log.Error(ex, "Error drawing Chat Log window");
|
Plugin.Log.Error(ex, "Error drawing Chat Log window");
|
||||||
if (!_notifiedDrawFailure)
|
if (!NotifiedDrawFailure)
|
||||||
{
|
{
|
||||||
Plugin.Notification.AddNotification(
|
Plugin.Notification.AddNotification(
|
||||||
new Dalamud.Interface.ImGuiNotification.Notification
|
new Dalamud.Interface.ImGuiNotification.Notification
|
||||||
@@ -642,7 +642,7 @@ public sealed class ChatLogWindow : Window
|
|||||||
InitialDuration = TimeSpan.FromSeconds(20),
|
InitialDuration = TimeSpan.FromSeconds(20),
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
_notifiedDrawFailure = true;
|
NotifiedDrawFailure = true;
|
||||||
}
|
}
|
||||||
// Prevent recurring draw failures from constantly trying to grab
|
// Prevent recurring draw failures from constantly trying to grab
|
||||||
// input focus, which breaks every other ImGui window.
|
// input focus, which breaks every other ImGui window.
|
||||||
|
|||||||
Reference in New Issue
Block a user