refactor(emotes): drop async void on LoadData
async void Task.Run() is a no-op for awaiting purposes since the void returns immediately. Switch LoadData to async Task and have the two callers fire-and-forget the task directly. Exceptions still go through the existing try/catch inside LoadData.
This commit is contained in:
@@ -177,7 +177,7 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
|
||||
GameFunctions.GameFunctions.SetChatInteractable(true);
|
||||
|
||||
if (Plugin.Config.ShowEmotes)
|
||||
Task.Run(EmoteCache.LoadData);
|
||||
_ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside
|
||||
|
||||
Initialise();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user