refactor(emotes): drop async void on LoadData

async void Task.Run() is a no-op for awaiting purposes since the void
returns immediately. Switch LoadData to async Task and have the two
callers fire-and-forget the task directly. Exceptions still go through
the existing try/catch inside LoadData.
This commit is contained in:
2026-05-02 21:20:16 +02:00
parent 66450dd518
commit ddd72a878e
3 changed files with 3 additions and 3 deletions
+1 -1
View File
@@ -66,7 +66,7 @@ public static class EmoteCache
public static string[] SortedCodeArray = []; public static string[] SortedCodeArray = [];
public static async void LoadData() public static async Task LoadData()
{ {
if (State is not LoadingState.Unloaded) if (State is not LoadingState.Unloaded)
return; return;
+1 -1
View File
@@ -241,7 +241,7 @@ public sealed class Plugin : IDalamudPlugin
Interface.UiBuilder.OpenMainUi += OpenMainUi; Interface.UiBuilder.OpenMainUi += OpenMainUi;
if (Config.ShowEmotes) if (Config.ShowEmotes)
Task.Run(EmoteCache.LoadData); _ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside
#if !DEBUG #if !DEBUG
// Avoid 300ms hitch when sending first message by preloading the // Avoid 300ms hitch when sending first message by preloading the
+1 -1
View File
@@ -177,7 +177,7 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
GameFunctions.GameFunctions.SetChatInteractable(true); GameFunctions.GameFunctions.SetChatInteractable(true);
if (Plugin.Config.ShowEmotes) if (Plugin.Config.ShowEmotes)
Task.Run(EmoteCache.LoadData); _ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside
Initialise(); Initialise();
} }