diff --git a/HellionChat/Ui/StyleEngine/TypeScale.cs b/HellionChat/Ui/StyleEngine/TypeScale.cs index ca8f3a5..fc504e6 100644 --- a/HellionChat/Ui/StyleEngine/TypeScale.cs +++ b/HellionChat/Ui/StyleEngine/TypeScale.cs @@ -4,19 +4,22 @@ internal enum TypeRole { Body, Sender, - Header, Meta, } // Named sizes derived from one base, so a role means the same thing wherever it // is drawn. // -// Three of the four share the base size. That is deliberate: what sets the -// sender apart is weight and what sets the header apart is small caps with wide -// tracking, and neither is a size. Solving those with size instead would make -// the log look like a ransom note. Only the meta role -- timestamps and the -// header's trailing detail -- steps down, because it is meant to be skipped over -// rather than read. +// Two of the three share the base size. That is deliberate: what sets the sender +// apart is weight, not size. Solving that with size instead would make the log +// look like a ransom note. Only the meta role -- timestamps and the header's +// trailing detail -- steps down, because it is meant to be skipped over rather +// than read. +// +// There is no Header role. The channel header is set apart by small caps with +// wide tracking and runs at the body size, so a role for it would resolve to +// exactly Body and never be pushed -- a value with no call site, which is the one +// thing this whole style track exists to stop. // // The factors are defaults, not constants. The master spec puts typography under // theme control rather than user control, and ThemeTypography already exists as @@ -31,7 +34,6 @@ internal static class TypeScale [ 1.00f, // Body -- the reference every other role is stated against 1.00f, // Sender -- set apart by weight, see FontManager.SenderWeight - 1.00f, // Header -- set apart by small caps and tracking 0.82f, // Meta -- timestamps, and the world and clock in the header ]; diff --git a/HellionChat/Ui/Windows/ChannelPopoutWindow.cs b/HellionChat/Ui/Windows/ChannelPopoutWindow.cs index b82dcf0..5c01d54 100644 --- a/HellionChat/Ui/Windows/ChannelPopoutWindow.cs +++ b/HellionChat/Ui/Windows/ChannelPopoutWindow.cs @@ -142,7 +142,7 @@ internal sealed class ChannelPopoutWindow : Window, IFocusableChatWindow InputBar.Height ); - // The header close button can unbind us mid-frame (CloseRequested -> + // Anything drawn above can unbind us mid-frame (CloseRequested -> // pool.TryClose -> Unbind nulls Bound). Re-check before the body so we // never hand a null tab to MessageList/InputBar in this same Draw call. if (Bound is null) @@ -173,6 +173,4 @@ internal sealed class ChannelPopoutWindow : Window, IFocusableChatWindow _input.Draw(Bound); } - - // Name only. Shown when the window has no title bar to carry it. }