JonKazama-Hellion/HellionChat
1
0
Fork 0
Code Issues 1 Pull Requests 3 Actions Releases 49 Activity

fix(tells): a tell no longer takes the keyboard mid-sentence

Browse Source 
Reported by Carla: a tell arriving while you are typing pulls the focus
away. The interruption is the visible half. The sharp half is that the
input buffer belongs to the WINDOW while the send target is read off
whatever tab is active at Enter -- so a line typed at one person could
leave addressed to whoever just wrote, and in this game losing the
keyboard means the next sentence walks the character around.

Nothing is revealed now while any chat surface is mid-sentence, in any
mode. The tab still appears and still carries its unread mark. The check
lives in its own file because the answer has to be identical everywhere:
it started inside the reveal plan, and a second pop-out path walked
straight past it -- AutoTellTabsService opened windows off its own flag,
at tab creation, a tick before the router was ever asked.

Those two paths are one now. AutoTellTabsOpenAsPopout and TellAutoOpenMode
were two settings for one decision, and the older one won every race,
which is why the other looked inert. Config schema 28 carries the old flag
forward so nobody's behaviour changes. "Off" went with it: it never
stopped the tab from being created -- that is the auto-tell switch -- it
only stopped the jump to it, which is what the switch below it does.

Also in here, all from the same corner of the code:

- Closing a tab was lost in the v2.0.0 rebuild. The trash entry lived in
  the retired ChatLogWindow menu, and the rebuilt one restored rename,
  sound, pop-out and pinning but not this. For tell tabs that left no way
  out at all: IsEditable keeps them out of the settings editor on purpose
  and points at the context menu, which could not close them either.
  Pinned tell tabs stay disabled with a tooltip rather than absent.
- Re-anchoring the active tab used an unconditional Tabs[0] in three
  places, and Tabs[0] can be popped out -- so it ran OnTabActivated over a
  tab live in its own window and stripped its tell binding. With every tab
  popped, the seed and the re-anchor also fought each other every frame.
- PinTab_LimitReached still pointed at "Promote to permanent", removed in
  May. Spanish said "Desija", which is not a word; Greek left "tell tabs"
  untranslated; pt-PT broke its own unpin verb.
- Pop Out was a hardcoded English literal despite the key existing in all
  25 languages since v1.5.6, and the tell-open modes were the last English
  display names in the plugin.
- Segmented setting rows measured 200px flat, which cut German labels in
  half. They size to their longest label now.
- Metrics.Scale still called GlobalScaleSafe. It is an alias for
  GlobalScale in current Dalamud, and dropping it clears the last compiler
  warning in the project.
This commit is contained in:
JonKazama-Hellion
2026-08-23 02:12:27 +02:00
parent 522545c7a2
commit eca566321a
42 changed files with 882 additions and 284 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HellionChat/Resources/HellionStrings.hu.resx
+19 -7
View File
@@ -480,7 +480,7 @@
<value>A fül-oldalsáv szélessége képpontban. Az alapértelmezés (44 px) csak ikont mutat; szélesítsd meg, hogy a szakaszfejlécek (pl. „Aktív tellek (3)") ne legyenek levágva.</value>
</data>
<data name="PinTab_LimitReached" xml:space="preserve">
<value>Elérted a {0} rögzített tell-fül maximumát. Először oldd fel az egyiket, vagy használd az Állandó füllé előléptetés funkciót.</value>
<value>Elérted a {0} rögzített tell-fül maximumát. Először oldd fel az egyiket.</value>
</data>
<data name="PinTab_PinnedTooltip" xml:space="preserve">
<value>Rögzített: túléli az újrabejelentkezést.</value>
@@ -514,12 +514,6 @@
<data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve">
<value>Minden auto-tell-fül mellé egy kattintható gombot ad, amellyel a beszélgető partnert már üdvözöltként lehet megjelölni: a fül neve ezután halvány lesz. Hasznos klubi köszöntőknek, akik párhuzamosan sok beszélgetést kezelnek. Alapértelmezés szerint ki van kapcsolva.</value>
</data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve">
<value>Új /tell-fülek megnyitása közvetlenül pop-outként</value>
</data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve">
<value>Ha aktív, minden újonnan létrehozott /tell-fül azonnal saját ablakként nyílik meg. Az ablak bezárásakor a fül visszakerül az oldalsávba.</value>
</data>
<data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve">
<value>Az előtöltött tellek száma az Adatvédelem fülön állítható be.</value>
</data>
@@ -1031,6 +1025,15 @@
<data name="Tabs_NotificationSound_CustomOption" xml:space="preserve">
<value>Hellion hang</value>
</data>
<data name="Tabs_Close_MenuItem" xml:space="preserve">
<value>Fül bezárása</value>
</data>
<data name="Tabs_Close_UnpinFirst" xml:space="preserve">
<value>Előbb oldd fel a fül rögzítését, utána zárhatod be.</value>
</data>
<data name="Tabs_Close_LastTab" xml:space="preserve">
<value>Legalább egy fülnek maradnia kell. Előbb hozz létre egy másikat.</value>
</data>
<data name="FailedTell_Notification_Generic" xml:space="preserve">
<value>Egy tell nem kézbesíthető.</value>
</data>
@@ -1186,6 +1189,15 @@
<data name="Settings_Channels_TellAutoOpenMode_Description" xml:space="preserve">
<value>Hol nyílik meg egy tell, amikor megérkezik.</value>
</data>
<data name="Settings_Channels_TellAutoOpen_MainWindow" xml:space="preserve">
<value>Főablak</value>
</data>
<data name="Settings_Channels_TellAutoOpen_Popout" xml:space="preserve">
<value>Kiugró ablak</value>
</data>
<data name="Settings_Channels_TellAutoOpen_BusyHint" xml:space="preserve">
<value>Amíg gépelsz, nem nyílik ablak. A fül a főablakban vár, hogy a billentyűzet ne ugorjon vissza a játékba.</value>
</data>
<data name="Settings_Channels_TellSwitchAlways_Name" xml:space="preserve">
<value>Váltás a fülre minden tellnél</value>
</data>