JonKazama-Hellion/HellionChat
1
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Releases 42 Activity

refactor(services): route logging through IPluginLogProxy

Browse Source 
F12.2 step 5b — service cluster (~42 sites in 16 files):
MessageManager, GameFunctions/{Chat, GameFunctions, KeybindManager},
EmoteCache, PayloadHandler, AutoTellTabsService, FontManager, Commands,
Util/{WrapperUtil, AutoTranslate, MemoryUtil}, Message, Themes/ThemeRegistry,
Ipc/ExtraChat, Configuration.

The proxy interface gained Dalamud's params-overload signature
(messageTemplate + params object[]) to cover Configuration.cs:86 which
relies on Serilog-style placeholders.

Verified: zero remaining Plugin.Log.X(...) call-sites in HellionChat/,
build green, build-suite 690/690.
This commit is contained in:
Jon Kazama
2026-05-13 08:38:40 +02:00
parent 63cad62c89
commit fee2459e73
18 changed files with 78 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HellionChat/MessageManager.cs
+9 -7
View File
@@ -91,7 +91,7 @@ internal class MessageManager : IAsyncDisposable
await Task.Delay(100);
if (PendingMessageThread.IsAlive)
Plugin.Log.Warning(
Plugin.LogProxy.Warning(
"PendingMessageThread did not observe cancellation within 10s. "
+ "Worker remains on background thread; next plugin reload releases it."
);
@@ -137,7 +137,7 @@ internal class MessageManager : IAsyncDisposable
}
catch (Exception ex)
{
Plugin.Log.Error(ex, "Error processing pending message");
Plugin.LogProxy.Error(ex, "Error processing pending message");
}
}
else
@@ -182,10 +182,12 @@ internal class MessageManager : IAsyncDisposable
// Mark failed messages as deleted to prevent retry attempts
var failedIds = messages.FailedMessageIds();
Plugin.Log.Info($"Marking {failedIds.Count} messages as deleted due to parse failures");
Plugin.LogProxy.Info(
$"Marking {failedIds.Count} messages as deleted due to parse failures"
);
foreach (var msgId in messages.FailedMessageIds())
{
Plugin.Log.Debug($"Marking message '{msgId}' as deleted due to parse failure");
Plugin.LogProxy.Debug($"Marking message '{msgId}' as deleted due to parse failure");
Store.DeleteMessage(msgId);
}
}
@@ -201,10 +203,10 @@ internal class MessageManager : IAsyncDisposable
}
catch (Exception ex)
{
Plugin.Log.Error(ex, "Error in FilterAllTabs");
Plugin.LogProxy.Error(ex, "Error in FilterAllTabs");
}
Plugin.Log.Debug($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms");
Plugin.LogProxy.Debug($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms");
});
}
@@ -259,7 +261,7 @@ internal class MessageManager : IAsyncDisposable
}
catch (Exception ex)
{
Plugin.Log.Error(ex, "Error in ContentIdResolver");
Plugin.LogProxy.Error(ex, "Error in ContentIdResolver");
}
}