Compare commits

...

124 Commits

Author SHA1 Message Date
JonKazama-Hellion f2a2daf39d Merge branch 'feature/v1.5.0'
Security / scan (push) Successful in 21s
Build / Build (Release) (push) Successful in 26s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 5s
Release / Build and attach release ZIP (push) Successful in 33s
2026-05-17 11:45:16 +02:00
JonKazama-Hellion 7d87f1c4fe chore(release): v1.5.0 manifest bump
Version strings bumped across all eight tracked surfaces:

- HellionChat/HellionChat.csproj   <Version>1.5.0</Version>
- repo.json                        AssemblyVersion + TestingAssemblyVersion = 1.5.0.0
- repo.json                        three DownloadLink* URLs -> /v1.5.0/latest.zip
- repo.json                        Changelog field synced with yaml
- HellionChat/HellionChat.yaml     new v1.5.0 changelog block on top; v1.4.7
                                   drops out per the four-block slim rule
- docs/CHANGELOG.md                v1.5.0 entry prepended
- docs/ROADMAP.md                  Next Cycle pointer moves to v1.5.1, v1.5.0
                                   joins the released-cycle archive block
- README.md                        three status surfaces (badge, header,
                                   Project Status long-form) on v1.5.0
- .github/forge-posts/v1.5.0.md    Discord announcement body (German)

Preflight blocks A-F all green. Changelog embed total 2050 / 5500 chars
(four subblocks), forge-post frontmatter inside the 60/40 char caps.

Tag, push, merge are reserved for Flo.
2026-05-17 11:43:07 +02:00
JonKazama-Hellion fe84fd558e docs(di): trim cycle-internal codes and verbose block comments
Code comments were drifting into plan-internal shorthand (DI-2a,
Slice B, "see plan §9") that nobody outside the cycle authors can
decode. They also tended toward AI-generated paragraph blocks where a
two-line WHY would have done.

This commit tightens the comment surface from the v1.5.0 work:
- IPluginLogProxy header lists the consumer buckets without naming
  the cycle items that decided them.
- DalamudLogger / DalamudLoggingProvider provenance markers explain
  themselves in two lines each; the long EUPL-rationale paragraph
  moves to the commit message.
- PluginHostFactory block headers shrink to one line each, ASCII
  dividers come out, plan-internal codes go.
- Plugin.cs field doc and Phase-1 / DisposeAsync comments lose the
  cycle-name references; the file gains nothing from "C3 surfaced X"
  in code.
- FontManager / GameFunctions static-method notes shrink to one
  sentence each.
- InitHostedServices class header keeps the eager-resolve WHY in
  three lines, drops the constraint label.

Csharpier reformatted the .csproj layout (long PackageReference
multi-lined). No functional change, no behavior change.
2026-05-17 11:35:44 +02:00
JonKazama-Hellion 624ad20404 feat(logging): add dev signature to DalamudLogger output
EUPL-1.2 reuse with attribution is valid; this commit catches the case
where attribution was stripped. Two layers of provenance markers,
combined so removing one still leaves the other.

Layer 1 (subtle, kopier-resistent):
- DalamudLogger.Log emits "[name]<U+200B>{level} message" — a
  zero-width space (U+200B) between the category bracket and the
  level value. Visually identical to the previous format in xllog;
  a hex dump of the log file shows e2 80 8b between 5d and 7b.
  Survives 1:1 code copies. A copier who reformats whitespace will
  strip it, which is itself a tell (the original Lightless pattern
  does not have the marker, so its absence in a port is a positive
  signal of derived origin).

Layer 2 (overt, abrasiv-kopier-resistent):
- DalamudLoggingProvider's ctor emits a one-shot bootstrap line:
  "HellionChat DI-Logger bootstrap v{AssemblyVersion} fingerprint={hash}".
  Visible in xllog as the first plugin INFO line. Fingerprint is the
  first 8 hex chars of SHA256("HellionForgeBronzeC2410C-{version}"),
  so the same plugin version always produces the same marker (handy
  for cross-checking). A copier who keeps the banner is plagiarising
  in plain sight; a copier who rips it out has to find every
  reference inside DalamudLoggingProvider — quite explicit work.

Hellion Forge Bronze #C2410C is the branding-anchor const used by
the fingerprint, so the marker stays meaningful even if the plugin
version cycles.
2026-05-17 11:15:40 +02:00
JonKazama-Hellion 54ff88d6d4 refactor(di): migrate Root + Misc to ILogger<T> (DI-4 Slice D)
Slice D shrinks vs the original plan: three of the six files cannot
take an ILogger ctor arg without breaking external contracts.

Migrated (8 LogProxy sites across 4 files):
- Commands: 2 sites (Warning, Error). New ctor takes ILogger<Commands>.
- Themes/ThemeRegistry: 1 site (Debug). ILogger<ThemeRegistry>? is
  optional (default null) so the existing Build-Suite tests that
  construct `new ThemeRegistry()` parameterless keep working without
  changes. _logger?.LogDebug guards the call site.
- PayloadHandler: 3 sites (Error, Warning, Error). New ctor takes
  ILogger<PayloadHandler>. ChatLogWindow's two `new PayloadHandler(this)`
  sites (the direct field and the Lender lambda) now hand a fresh
  CreateLogger<PayloadHandler>() from the existing _loggerFactory.

Not migrated (5 sites stay on Plugin.LogProxy, plan drifts D12-D14):
- D12 - Configuration (1 site): IPluginConfiguration, instantiated by
  Dalamud's Interface.GetPluginConfig() via reflection on the
  parameterless ctor. Adding an ILogger arg would break GetPluginConfig.
- D13 - Message (4 sites): partial data class with two ctor overloads,
  mass-instantiated across 3 plugin sites plus Newtonsoft JSON
  deserialisation. Ctor extension would be invasive across ~20 call
  sites with low payoff (data-class logger is unusual).
- D14 - FontManager (2 sites): both Plugin.LogProxy calls live in
  static methods (TryGetHellionFontBytes, AddFontWithFallback) that
  cannot reach an instance _logger. Same root cause as D8 in
  GameFunctions. FontManager joins the static-bucket alongside
  EmoteCache et al.; the ctor + _logger field added mid-Slice-D were
  rolled back to keep the class clean.

Plugin.LogProxy surface after C9 (8 file buckets, ~12 sites total):
- 4 originally-static consumers: EmoteCache, AutoTranslate,
  MemoryUtil, WrapperUtil
- 3 cannot-take-ctor-arg consumers: Configuration, Message, FontManager
- 1 single-static-method consumer: GameFunctions.TryOpenAdventurerPlate
  (D8 from Slice B)

Smoke 2 is now due.
2026-05-17 11:02:08 +02:00
JonKazama-Hellion c955f30422 refactor(di): migrate UI Window-Layer to ILogger<T> (DI-4 Slice C)
Six UI files shift from Plugin.LogProxy to ILogger<T> via
constructor injection.

Container singletons (each takes a typed ILogger plus, where it owns
nested allocations, an ILoggerFactory to spawn child loggers):
- Ui/ChatLogWindow (15 sites, plus an ILoggerFactory for the
  Popout new-call at Ui/ChatLogWindow.cs:2417)
- Ui/Settings (SettingsWindow): no own sites, but takes an
  ILoggerFactory so it can hand typed loggers to its three migrated
  settings tabs (General, the other six tabs stay unchanged)
- Ui/DbViewer (3 sites)

Nested instances allocated by parent containers:
- Ui/Popout (7 sites, ILogger<Popout> as the new 4th ctor arg passed
  from ChatLogWindow)
- Ui/SettingsTabs/ThemeAndLayout (1 site)
- Ui/SettingsTabs/FontsAndColours (1 site)
- Ui/SettingsTabs/DataManagement (15 sites)

PluginHostFactory factory lambdas updated for ChatLogWindow,
SettingsWindow and DbViewer to resolve the new logger args.
2026-05-17 10:26:47 +02:00
JonKazama-Hellion 7a1bd1babc refactor(di): migrate Integrations + IPC layer to ILogger<T> (DI-4 Slice B)
Seven services across Integrations/, Ipc/ and GameFunctions/ shift
from Plugin.LogProxy to Microsoft.Extensions.Logging.ILogger<T>.

Files with live LogProxy sites (10 in total):
- Ipc/ExtraChat (1)
- GameFunctions/Chat (6)
- GameFunctions/GameFunctions (2)
- GameFunctions/KeybindManager (1)

Foundation-touch files (no current sites, ctor takes ILogger<T> as
seed for the v1.5.7-11 Plugin-Integrations wave):
- Integrations/HonorificService (also drops the local IPluginLog
  _log field in favour of ILogger<HonorificService> _logger; the
  three _log.* calls there are migrated as a bonus since the field
  had to change anyway)
- IpcManager
- Ipc/TypingIpc

GameFunctions takes ILoggerFactory as an extra ctor arg so it can
hand a typed logger to its nested Chat and KeybindManager (same
pattern MessageStore + MessageEnumerator use in Slice A).

PluginHostFactory factory lambdas updated for all five Slice B
services that need extra resolves.

Plan drift D8: GameFunctions.TryOpenAdventurerPlate is an internal
static method whose only Warning call cannot reach the instance
_logger. The one site stays on Plugin.LogProxy with an inline note;
promoting it to instance + PayloadHandler.cs:814 call-site update is
a v1.5.1+ cleanup, out of DI-4 Slice B scope.
2026-05-17 09:56:46 +02:00
JonKazama-Hellion d0be75e79d refactor(di): migrate services layer to ILogger<T> (DI-4 Slice A)
MessageStore, MessageEnumerator, MessageManager, AutoTellTabsService
move from Plugin.LogProxy / IPluginLogProxy onto
Microsoft.Extensions.Logging.ILogger<T> via constructor injection.

MessageStore additionally takes ILoggerFactory so it can build a
per-instance ILogger<MessageEnumerator> at each of the five reader-
spawning sites; the enumerator is not a container singleton.

PluginHostFactory's MessageManager and AutoTellTabsService factory
lambdas grow to resolve the new logger args; everything else stays in
place.

Site-level migration in the four files:
- MessageStore: 12 calls, _logger field IPluginLogProxy -> ILogger<MessageStore>
- MessageManager: 7 Plugin.LogProxy.* sites, new _logger field
- AutoTellTabsService: 9 Plugin.LogProxy.* sites, new _logger field

Plus a pre-existing template bug surfaced by CA2017: a LogDebug call
in AutoTellTabsService used "{tab.Name}" with no `$` prefix, which
landed in xllog as literal text under Plugin.LogProxy; ILogger now
reads that as a structured placeholder, so the call was promoted to
proper structured logging with tab.Name passed as a parameter.
2026-05-17 09:09:55 +02:00
JonKazama-Hellion e0ead86616 refactor(di): drop manual PlatformUtil and LogProxy wiring (DI-3)
C3's Phase-1 bridge in Plugin.ctor already pulls IPlatformUtil and
IPluginLogProxy out of the container right after the host builds, so
the manual `new DalamudPlatformUtil()` / `new DalamudPluginLogProxy`
assignments in Phase-0 were just allocating throwaway instances that
got overwritten a few lines later.

Phase-0 helpers that run before the container build
(MigrateFromChatTwoLayout, LanguageChanged, ImGuiUtil.Initialize) do
not touch Plugin.PlatformUtil or Plugin.LogProxy, so the brief
null-window between the schema gate and the container build is safe.

The DalamudPlatformUtil and DalamudPluginLogProxy wrapper classes
themselves stay in the code; DI-4 (logger migration to ILogger<T>)
will eventually retire the proxy for new sites but EmoteCache,
AutoTranslate, MemoryUtil and WrapperUtil keep using it.
2026-05-17 08:58:03 +02:00
JonKazama-Hellion b66005daea fix(di): stop double-disposing container singletons in Plugin.DisposeAsync
Smoke 1 of C3 surfaced MessageManager.DisposeAsync throwing on unload:
Plugin.DisposeAsync ran the manual MessageManager teardown (CTS
cancel + dispose at MessageManager.cs:84-99), then awaited
_lifecycle.DisposeAsync which routed Host.Dispose through the
container, which hit MessageManager.DisposeAsync a second time and
threw ObjectDisposedException on the already-disposed CTS.

Plugin.DisposeAsync now drops every manual service dispose - the
container owns those singletons end-to-end. The framework-thread block
keeps the three calls the container has no handle on
(TearDownCommands, GameFunctions.SetChatInteractable,
WindowSystem.RemoveAllWindows), plus the static-class cleanups
(EmoteCache.Dispose, InputHistoryService.Reset) stay outside the
container entirely.

This changes the teardown order versus v1.4.10: the container disposes
in reverse-registration order, which puts Windows ahead of IPC
services. The v1.4.10 ordering ("IPC before Windows so a final IPC
event cannot hit a half-torn ChatLogWindow") is no longer enforced.
Host.Dispose runs synchronously on the framework thread, so no
Framework.Update or Draw event fires during teardown; the remaining
risk is an external IPC plugin invoking a subscriber mid-dispose,
which is not something v1.4.10 actually prevented either.
2026-05-17 08:24:45 +02:00
JonKazama-Hellion 0fe66d2c3c fix(di): use factory lambdas for internal-ctor services
C3 bootstrap throws "A suitable constructor for type
HellionChat.Ipc.ExtraChat could not be located" because
Microsoft.Extensions.DependencyInjection's ActivatorUtilities only
binds to PUBLIC constructors via reflection. ExtraChat is a public
class with an internal ctor; Commands and StatusBar are internal
classes whose implicit default ctor inherits class accessibility
(internal); every IHostedService adapter is `internal sealed class
X(deps)` with a primary ctor that is also internal.

The fix routes all eight singletons and all seven hosted-service
adapters through factory lambdas. `new T(...)` inside the
PluginHostFactory namespace sees the internal surface, so the
container never has to reflect over internal ctors.
2026-05-17 08:20:02 +02:00
JonKazama-Hellion 169168cea9 feat(di): wire Plugin.cs to the DI container (DI-2a + DI-5)
Flips the container live. Plugin.ctor now builds the host after the
schema gate clears, pulls PluginLifecycle out of the container, and
backfills the Plugin.X static surface plus the instance properties
(11 services + 8 windows) so existing consumers reach the same
instances the container holds.

Plugin.LoadAsync gets thinner: service and window allocations are gone
(the container owns them), BuildFonts / Switch / FilterAllTabsAsync /
Initialize moved to their hosted-service adapters inside
Host.StartAsync, WindowSystem.AddWindow moved into
PluginLifecycle.LoadAsync on the framework thread. Plugin-internal
init (SelfTestRegistry, FirstRunWizard, SetupCommands +
Commands.Initialise, RetentionSweep, EmoteCache.LoadData, FTS5 rebuild
worker, UiBuilder.Disable*UiHide, AutoTranslate.PreloadCache,
Framework / Draw / LanguageChanged subscribes) stays in Plugin.LoadAsync
because each step reaches Plugin-private members or fields.

Plugin.DisposeAsync keeps the manual teardown for ordering (IPC before
windows, hooks first) and awaits _lifecycle.DisposeAsync at the end to
stop the host and dispose the container on the framework thread.
Double-disposes against container singletons are no-ops for the
services that hold real resources (Dispose idempotency is the standard
pattern).

PluginLifecycle takes Plugin as a constructor arg so it can iterate
the Window properties and call WindowSystem.AddWindow on the framework
thread; v1.4.9 Stage-2 verified that AddWindow's backing List<> is
not thread-safe.

Plan drift D4 noted: Plugin.cs ends at 1050 lines instead of the
150-220 vision because helper methods (MigrateFromChatTwoLayout,
SeedExampleThemeIfEmpty, RunRetentionSweepIfDue, FrameworkUpdate,
Draw, LanguageChanged, SetupCommands, slash handlers, FTS worker)
stay in Plugin.cs. Extracting them is DI-2b or a dedicated service
refactor in v1.5.1+. C3 still hits the DI-2a goal: bootstrap is
container-driven and LoadAsync is allocation-free.

PlatformUtil and LogProxy keep the manual `new` for now; C5 (DI-3)
removes those once C3 stabilises in the smoke test.
2026-05-17 03:34:34 +02:00
JonKazama-Hellion f6d3794d87 feat(di): scaffold Microsoft.Extensions.Hosting container (DI-1 + DI-1b)
Lays down the DI foundation that v1.5.x will run on top of, without
flipping the switch on Plugin.cs yet (that move follows in C3). The new
files compile alongside the existing bootstrap but no caller resolves
the host, so the live behaviour is byte-identical to v1.4.10.

What's new:

- PluginHostFactory.cs: HostBuilder.Build(plugin, dependencies)
  registers ~46 services across Block A (21 Dalamud singletons), Block
  B (14 HellionChat services plus FileDialogManager), Block C (8
  windows), plus Plugin and PluginLifecycle. Service-class bodies are
  untouched - Plugin-backref ctors go through factory lambdas.
- PluginLifecycle.cs: thin IAsyncDisposable wrapping the host's
  StartAsync/StopAsync, with idempotent dispose and framework-thread
  Host.Dispose. The Host is assigned via a property setter from
  Plugin.ctor; HellionChat deviates from Lightless' Func-delegate
  pattern because the schema gate must run before Build.
- Infrastructure/Logging/{DalamudLogger, DalamudLoggingProvider,
  DalamudLoggingProviderExtensions}.cs: ILogger<T> -> IPluginLog
  bridge, ported from Lightless without the mod-sync hasModifiedGameFiles
  flag and without the LightlessConfigService log-level coupling.
- Infrastructure/Hosting/InitHostedServices.cs: seven IHostedService
  adapters around the existing init methods (FontManager.BuildFonts,
  ThemeRegistry warmup+switch, IpcManager/TypingIpc/ExtraChat eager
  resolve, MessageManager.FilterAllTabsAsync, AutoTellTabsService
  .Initialize). Adapter style rather than inlining ": IHostedService"
  on the service classes per the DI-2a "service bodies untouched"
  constraint.

Plan drift noted for cycle closure: MessageStore stays inside
MessageManager.ctor (not a standalone container singleton) because
MessageManager.ctor allocates it directly today; promoting it would
double-construct the SQLite handle. AutoTellTabsService reads it via
MessageManager.Store inside its factory lambda.
2026-05-17 02:44:54 +02:00
JonKazama-Hellion 763f5a3f5d chore(deps): add Microsoft.Extensions.Hosting et al. for DI foundation
Prepares the v1.5.0 DI-container adoption (Lightless pattern) by adding
four MS.Extensions packages as direct closed-range references:

- Microsoft.Extensions.Hosting (IHost, HostBuilder)
- Microsoft.Extensions.DependencyInjection (IServiceCollection)
- Microsoft.Extensions.Logging (ILogger<T> for DI-4 logger migration)
- Microsoft.Extensions.Options (transitive used by Hosting + future config)

Closed-range [10.0.7, 11.0.0) matches the existing pinning style for
MessagePack/Pidgin/ImageSharp and locks the major version while letting
Renovate roll minor and patch updates. Lock file regenerated.
2026-05-17 02:29:41 +02:00
JonKazama-Hellion 8a18f7caaa fix(chat-input): replace input on slash-command insert
Cherry-pick from ChatTwo upstream ee7768ac (Infiziert90, 2026-05-16):
when args.AddIfNotPresent or args.Input starts with '/', replace the
chat input instead of appending. Fixes the Friend-List "/tell" path
where existing text like "test" would otherwise concatenate to
"test/tell user@world" before the receiver and channel resolve.

Variable drift versus upstream: HellionChat uses local 'Chat' where
ChatTwo uses InputHandler.ChatInput; logic is 1:1.
2026-05-17 02:26:03 +02:00
JonKazama-Hellion 5f7bfb5890 fix(preflight): avoid jq SIGPIPE race in verify-changelog-sync
Security / scan (push) Successful in 23s
Build / Build (Release) (push) Successful in 31s
The Block C check used `jq -r '.[0].Changelog' | grep -qE ...` to spot
the **vX.Y.Z** marker. With `set -o pipefail`, grep -q closing stdin on
the first match makes jq trip SIGPIPE on the rest of the multi-KB
Changelog string, which the script then surfaces as a false-positive
"Changelog missing **vX.Y.Z** subblock" failure. Interactive shells
sometimes raced through fast enough to hide the issue, but the pre-push
runner hit it reliably (saw it on the v1.4.10 release-cut push attempt).

Switched the pipe to a process substitution so jq writes into a FIFO
and SIGPIPE never enters the picture. Both directions of the marker
check now stay deterministic.
2026-05-16 14:08:19 +02:00
JonKazama-Hellion 3be4e73c27 Merge feature/v1.4.10 — Symbol-Picker and Tell-History Fix
Forge Announce / Post changelog to Hellion Forge (push) Successful in 7s
Release / Build and attach release ZIP (push) Successful in 37s
2026-05-16 14:04:20 +02:00
JonKazama-Hellion 667950c98e docs: add v1.4.10 forge announcement post and apply csharpier reflow
Forge-Post is required in the tagged tree so forge-announce.yml can read
it during the release-pipeline run. Plus a csharpier reflow on two files
(SymbolPicker.cs, ChatLogWindow.cs) that preflight Block E flagged after
the cycle's comment-tightening sweep — purely whitespace, no behaviour
change.
2026-05-16 14:01:17 +02:00
JonKazama-Hellion 3e91177833 release: bump to v1.4.10 2026-05-16 13:25:53 +02:00
JonKazama-Hellion 51f18e46a0 chore(comments): tighten v1.4.10 inline commentary after self-review
Five trim spots from the cycle's earlier commits — none change behaviour,
just drop redundant phrasing and stale references per the HellionChat
comment-style convention (1-3 lines default, link "same as X" instead of
repeating, file:line refs only where they aid navigation).

SymbolPicker:
- BmpWhitelist header consolidated to source + filter ranges
- ImRaii.Popup pattern links the established ChatLogWindow popup idiom
  instead of citing three call-sites
- ToIconString comment drops the "discoverability" footnote that the
  code already telegraphs
- Manually-wrapping comment drops the "same modern idiom" tail that
  duplicated the preceding sentence

MessageStore:
- Merge the stale pre-v1.4.10 sqlScanLimit comment with the new
  v1.4.10 commentary; the cap mention now describes the historical
  reason rather than a parameter that no longer exists
2026-05-16 12:49:01 +02:00
JonKazama-Hellion f66316161b fix(autotells): preload tell history fully up to the user-configured limit
PreloadHistory had a hardcoded 500-row SQL scan window that capped the
per-partner history pull regardless of the AutoTellTabsHistoryPreload
setting. For active users with many tell partners, the scan window
filled up with chatter from other partners and pushed less-frequent
partners' history off the back end — pinned tabs reloaded empty even
though the messages were still in the database.

Drops the hardcoded scan cap. The (Receiver, Date) index keeps SQL fast
on the now-unbounded read, and the client-side loop still breaks as
soon as the configured per-tab limit is hit, so decode cost stays
proportional to the depth at which `limit` matches accumulate (typically
shallow even for chatty users).
2026-05-16 12:16:08 +02:00
JonKazama-Hellion 679b8f0f5e feat(settings): toggle for the symbol-picker chat-input button
Adds a Configuration property, defaulted to enabled, and a checkbox in
the Chat settings tab's Behaviour section. Strings live in HellionStrings
so DE/EN stays in sync. Defaults aligned with our 'discoverable by
default, hidden by user choice' convention. Schema stays at v17 — the
new boolean is additive, the default constructor covers existing configs.
2026-05-16 10:05:37 +02:00
JonKazama-Hellion 0e470fcdce feat(ui): SymbolPicker BMP tab and session-only recents
Second tab exposes the server-verified BMP whitelist (round-tripped via
/echo and /say in the v1.4.10 preflight). Recent-used row at the top
floats the user's last sixteen picks across both tabs, move-to-front
on reuse. Recents stay session-only by design — no Configuration touch,
schema unchanged.
2026-05-16 09:27:58 +02:00
JonKazama-Hellion abbbf95002 feat(ui): add SymbolPicker popup with FFXIV icon tab
New popup attached to the chat input lets the user browse and insert
Dalamud SeIconChar glyphs (161 PUA codepoints, server-safe by design).
Search field filters by enum name. Multi-insert keeps the popup open
until the user clicks elsewhere. BMP tab follows in the next commit.
2026-05-16 01:11:12 +02:00
JonKazama-Hellion fbbbeebade refactor(commands): cache slash-command wrappers in private fields
TearDownCommands attached the same instance via re-Register with identical
args, which was functionally a no-op but masked a latent bug if Description
or ShowInHelp ever diverged between Setup and Teardown. Hold the wrapper
instances as nullable fields so Teardown can detach the live registration
directly. Mirrors the cached-wrapper pattern in ChatLogWindow.
2026-05-15 20:18:41 +02:00
JonKazama-Hellion 7c9b90c767 Merge feature/v1.4.9 — Plugin-Load Render Polish
Security / scan (push) Successful in 22s
Build / Build (Release) (push) Successful in 31s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 7s
Release / Build and attach release ZIP (push) Successful in 36s
2026-05-15 13:35:37 +02:00
JonKazama-Hellion b81894b859 docs: surface the ChatTwo IPC compatibility layer in v1.4.9 patch notes
Adds a "ChatTwo IPC compatibility layer" bullet across all six
release-note surfaces so the new behaviour from commits 8c4afaa and
655c903 is visible to users via the manifest installer, the Gitea
release page, the README project-status section, the changelog/roadmap
docs and the Forge-Discord announcement.

Files touched:
- HellionChat/HellionChat.yaml: bullet added inside the v1.4.9
  changelog block, preserved order so the regression-tripwire line
  still comes before the migration-stays line.
- repo.json: Changelog field kept synchronous (JSON-escaped newlines).
- README.md: project-status paragraph extended with a one-sentence
  recap of the IPC mirror and the conflict-detection caveat.
- docs/CHANGELOG.md: bullet inserted between the profiling-logs and
  migration-stays bullets, code-fenced gate names.
- docs/ROADMAP.md: v1.4.9-released section gets the same recap so the
  cycle history stays self-describing.
- .github/forge-posts/v1.4.9.md: German-only bullet for the Discord
  embed, slotted before the migration-v17 bullet. Char-cap holds —
  preflight Block C reports the embed total well under 5500 chars.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 13:04:18 +02:00
JonKazama-Hellion 655c903cb5 feat(ipc): mirror context-menu IPC gates under ChatTwo namespace (v1.4.9 R4 ext)
Extends commit 8c4afaa: the TypingIpc mirror covered only two of the six
ChatTwo IPC slots. Third-party plugins like Artisan and AllaganTools
subscribe to a different ChatTwo IPC surface — the context-menu
integration (ChatTwo.Register / Unregister / Available / Invoke) that
lets them push item-links into the chat. Smoke test against the
deployed v1.4.9 build showed Artisan logging "Chat2 is not available"
because those four gates were not yet mirrored.

This commit adds the missing four ChatTwo-prefixed provider gates in
IpcManager.cs:

- ChatTwo.Register  (Func<string>) — bound to the existing Register()
  backing method, so plugins that subscribe via either namespace land
  in the same Registered list.
- ChatTwo.Unregister (Action<string>) — bound to the existing
  Unregister() backing method, same shared-state rationale.
- ChatTwo.Available (Action<>) — SendMessage() fires from the ctor right
  after AvailableGate.SendMessage(), so any subscriber waiting on the
  "Chat 2 became available" signal sees both events.
- ChatTwo.Invoke (Action<string, PlayerPayload?, ulong, Payload?,
  SeString?, SeString?>) — Invoke() fans the context-menu event out to
  both InvokeGate and ChatTwoInvokeGate in lockstep. Subscribers compare
  on the registration ID they got back from Register, so the
  shared-backing approach keeps that contract intact regardless of which
  namespace they subscribed under.

Dispose() unregisters all four ChatTwo gates plus the four existing
HellionChat gates. The conflict-detection that prevents ChatTwo from
loading alongside HellionChat guarantees no slot collision at runtime.

With this commit the full ChatTwo IPC surface (6 of 6 slots) is mirrored:
- ChatTwo.GetChatInputState     (TypingIpc, commit 8c4afaa)
- ChatTwo.ChatInputStateChanged (TypingIpc, commit 8c4afaa)
- ChatTwo.Register              (IpcManager, this commit)
- ChatTwo.Unregister            (IpcManager, this commit)
- ChatTwo.Available             (IpcManager, this commit)
- ChatTwo.Invoke                (IpcManager, this commit)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 13:01:12 +02:00
JonKazama-Hellion 8c4afaac17 feat(ipc): mirror TypingIpc provider slots under ChatTwo namespace (v1.4.9 R4)
HellionChat replaces ChatTwo (conflict detection prevents parallel loading)
but third-party plugins with a no-fork policy keep subscribing only to the
ChatTwo.*-prefixed IPC gates. Mirroring the two TypingIpc provider slots
under the ChatTwo namespace lets those plugins keep working without code
changes on their side.

Mirrored slots:
- ChatTwo.GetChatInputState  ←→ HellionChat.GetChatInputState
- ChatTwo.ChatInputStateChanged ←→ HellionChat.ChatInputStateChanged

Implementation:
- Two additional ICallGateProvider fields (ChatTwoStateQueryGate +
  ChatTwoStateChangedGate) with the identical ChatInputState tuple
  signature. The tuple's underlying types match ChatTwo's surface byte-
  for-byte (bool/bool/bool/bool/int/ushort — ChatType is `ushort` in both
  repos), so Dalamud's IPC marshalling matches across plugin boundaries
  even when the subscribing plugin defines its own copy of the ChatType
  enum.
- ctor registers the new provider gates and binds RegisterFunc(GetState)
  to ChatTwoStateQueryGate so query calls route to the same backing path.
- Update() pushes the state to both ChatTwoStateChangedGate and the
  existing StateChangedGate in lockstep.
- Dispose() unregisters both query gates.

Ipc/ExtraChat.cs is intentionally unchanged — it is a subscriber on
ExtraChat's own IPC, not a provider, so no compatibility mirror applies.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 12:47:06 +02:00
JonKazama-Hellion c6a3780753 docs: add v1.4.9 changelog and forge announcement post
Synchronises the v1.4.9 changelog across the manifest sources that the
Dalamud plugin installer, the gitea repo.json feed and the Forge auto-
announce workflow read at release-tag time.

Files touched:
- HellionChat/HellionChat.yaml: v1.4.9 block inserted at the top of the
  changelog: literal. v1.4.5 dropped to keep the slim-rule at 4 subblocks
  (preflight Block C enforces YAML_VERSIONS <= 4). Current set is
  v1.4.9/v1.4.8/v1.4.7/v1.4.6.
- repo.json: Changelog field kept synchronous with the yaml — v1.4.9
  block prepended, v1.4.5 substring removed, JSON-escaped newlines.
- .github/forge-posts/v1.4.9.md: new file with frontmatter (subtitle
  "Plugin-Load Render Polish", versionsnatur "Performance-Patch") and
  a German-only body. The English half of the eventual Discord embed
  is pulled automatically from the yaml changelog at tag-push time by
  .gitea/workflows/forge-announce.yml — same workflow as v1.4.4
  onwards, the post file does not carry an English block.

Char-cap pre-check passes (title 46 + description ~2700 + footer 33 =
~2800 chars, well under the 5500-char Discord embed total cap).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 11:51:25 +02:00
JonKazama-Hellion d9f6704316 chore: bump version to 1.4.9, sync manifest
Manifest version bump for the v1.4.9 release cut. Schema-required v16
stays unchanged (R1/R2/R3 are all config-neutral refactors).

Files touched:
- HellionChat/HellionChat.csproj: <Version> 1.4.8 -> 1.4.9
- HellionChat/Plugin.cs: schema-migration error string self-reference
  (v1.4.8 -> v1.4.9, required schema v16 stays)
- repo.json: AssemblyVersion, TestingAssemblyVersion, 3x DownloadLink*
  URLs all bumped to 1.4.9 / v1.4.9. Changelog field is still on v1.4.8;
  the v1.4.9 block plus v1.4.5 slim-drop land in the next commit.
- README.md: shield badge, version header in lead paragraph, project-
  status block rewritten for v1.4.9 (Plugin-Load Render Polish).
- docs/CHANGELOG.md: v1.4.9 block inserted above v1.4.8.
- docs/ROADMAP.md: v1.4.9 moved into the released-versions list,
  "Next Cycle" header now targets v1.4.10 (Render Clipper + Symbol
  Picker reserves carried over from the v1.4.9 plan).

yaml changelog block and repo.json Changelog field follow in the
docs commit so the slim-drop of v1.4.5 stays atomic with the v1.4.9
block insert.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 11:31:35 +02:00
JonKazama-Hellion 011490368b perf(draw): defer non-essential first-frame rendering (v1.4.9 R2)
Cut first-frame HITCH from ~127ms median down to ~76ms median (4-reload
sample, threshold lowered to 1ms for measurement) — comfortably under
Dalamud's 100ms warning threshold. ChatTwo upstream sits at ~63ms median
for comparison; the remaining ~13ms gap is the cost of HellionChat-only
features (Sidebar tab view, custom StatusBar, Honorific integration).

Mechanism: a single `_firstFrameDone` flag (flipped in Draw's finally
block) gates six sections that don't need to render on frame 0:

  - StatusBar.Draw (~12ms): the bottom status bar
  - DrawChannelName chunks (~17ms): SeString-Renderer layout, replaced
    with a plain-text fallback (activeTab.Name) for frame 0
  - PositionReset/BoundsCheck (~10ms): EnsureWindowOnScreen viewport
    iteration, only matters once the user notices a mispositioned window
  - DrawV061HintBannerIfNeeded (~3-5ms): v0.6.1 migration notice
  - DrawAutoComplete (~6ms): renders nothing until the user types a command
  - InputPreview.CalculatePreview (~3-5ms): triggers InputPreview first-
    frame lazy init, user-typing-driven anyway

Frame 1 then renders all of them in ~40ms (still well under the warning
threshold), and frames 2+ stay at 0ms as before. User sees the deferred
sections ~17ms (60fps) later than before — invisible inside the ~2.5s
Atlas-Build window after every plugin reload.

Hypothesis triage from the R2-profiling pass:
  - (a) Atlas-Sync-Fallback: falsified. xllog shows the Atlas-Complete
    line always lands ~2.5s before the HITCH frame.
  - (b) Theme-Apply ABGR-Cache-Init: not dominant. PushGlobal is 5ms.
  - (c) Multiple-Window-Render: falsified in v1.4.9 Stage-2-Lazy-Init
    diagnose (deferred 4 windows, no measurable delta).
  - (d) DrawList-Setup-Cost per Window: actual root cause. Layout cost
    distributes evenly across ~10 ImGui sections inside ChatLogWindow
    (5-20ms each). No single hot-spot to optimise — the six selective
    skips above are the pragmatic fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-15 10:14:13 +02:00
JonKazama-Hellion 8ed10a536b refactor(plugin): centralise slash-command registration for lazy-window readiness (v1.4.9 R1 stage 1)
Pull the four user-triggered slash-commands (/hellion, /hellionView,
/hellionDebugger, /hellionSeString) plus the two Plugin-Manager
UiBuilder hooks (OpenConfigUi, OpenMainUi) out of their window
constructors and into a central Plugin.SetupCommands method so they
work before their target window has been opened the first time. A
matching TearDownCommands runs as the first CaptureFailure inside the
framework-thread teardown lambda. /hellion and /hellionSeString stay
under the same #if DEBUG guard SeStringDebugger had before. The four
window classes keep their public Dispose method signatures so the
existing Plugin.DisposeAsync method-group binding still resolves —
the bodies are now empty pointers to TearDownCommands. The pre-v1.4.9
`OpenMainUi` body that flipped SettingsWindow.IsOpen and the three
private Toggle(string, string) method-group wrappers are gone since
the central handlers call SettingsWindow.Toggle() / DbViewer.Toggle()
etc. directly.

The properties stay eager in stage 1 — the lazy-init switch lands in
stage 2 with the matching `_lazyWindowLock` guard around AddWindow
and RemoveAllWindows. Doing it in two commits keeps the slash-command
correctness verifiable on its own.

Smoke (release build): /hellion, /hellionView, /hellionDebugger,
/clearhellion plus Plugin-Manager Settings and Open buttons all
toggle their target window. /hellionSeString remains DEBUG-only as
before.
2026-05-15 00:28:18 +02:00
JonKazama-Hellion 6051e49307 chore(profiling): instrument plugin-load hot paths (v1.4.9 R3)
Bump AutoTranslate-warmup and FilterAllTabs log-level from Debug to
Information so the xllog tail surfaces them without a Debug filter.
Wrap MessageStore.Connect and MessageStore.Migrate in Stopwatches so
the SQLite open and migration-chain costs are visible too.

Sub-Task 3.4 Befund on v1.4.8-baseline (4 reloads, medians):
- MessageStore.Connect: 50.5 ms
- MessageStore.Migrate:    2 ms
- MessageManager.FilterAllTabs: 68.5 ms
- AutoTranslate warmup:  108 ms
- UiBuilder HITCH:       108.9 ms

Outcome D — none of the three dominates the 200 ms threshold. The
ChatTwo "300 ms" comment for AutoTranslate is falsified at ~108 ms;
SQLite is not the bottleneck (52.5 ms total); FilterAllTabs runs on
the worker thread and only competes for CPU slots. The HITCH is left
unexplained by these probes, which keeps Hypothesis c (multi-window
WindowSystem.Draw initial pass) as the main R2 suspect to be
validated by the R1 lazy-window refactor.

Logs stay in as belt-and-suspenders for future plugin-load
regressions.
2026-05-14 23:33:56 +02:00
JonKazama-Hellion 55120e6572 Merge branch 'feature/v1.4.8'
Security / scan (push) Successful in 23s
Build / Build (Release) (push) Successful in 29s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 7s
Release / Build and attach release ZIP (push) Successful in 37s
2026-05-14 12:12:06 +02:00
JonKazama-Hellion 7542d48983 perf(dbviewer): dispatch FTS filter to worker thread
FullTextSearch + LoadByGuids could stall the draw thread for 100-300 ms
on large databases with a popular search term. The two hot trigger sites
(FTS toggle, search input) now route via TriggerFilterRefresh, which
dispatches the FTS path to Task.Run; the in-memory page-filter path
stays inline because it is sub-ms on the loaded page array.

_ftsFilterSeq is bumped per trigger so a late worker recognises itself
as stale and drops its result instead of overwriting a newer one. The
date/channel and history workers already lived on Task.Run and are
untouched.

Surfaced during the v1.4.8 pre-tag review.
2026-05-14 11:48:40 +02:00
JonKazama-Hellion 7b36763359 docs: add v1.4.8 changelog and forge announcement post
- HellionChat.yaml: v1.4.8 changelog block above v1.4.7, v1.4.4
  dropped per slim-rule (verify-changelog-sync enforces max 4).
- repo.json: Changelog field synchronised with yaml, same slim-drop.
- .github/forge-posts/v1.4.8.md: bilingual announcement post (DE
  body, EN block resolved from yaml at workflow time). Frontmatter
  subtitle 32/60 chars, versionsnatur 12/40 chars, embed total
  ~2787/5500 chars.
2026-05-14 10:51:50 +02:00
JonKazama-Hellion eecedd9f97 chore: bump version to 1.4.8, sync manifest
- csproj <Version>, Plugin.cs schema-gate self-reference, repo.json
  (AssemblyVersion, TestingAssemblyVersion, 3x DownloadLink URLs).
- README.md shield badge, version header, Project Status body.
- docs/CHANGELOG.md gains a v1.4.8 section above v1.4.7.
- docs/ROADMAP.md flips Next Cycle to v1.4.9 (Plugin-Load Render
  Polish), v1.4.8 moves into the released history above v1.4.7.
- Config schema stays at v17, Migration v17 stays additive.

repo.json Changelog field and HellionChat.yaml changelog block plus
the new forge-posts/v1.4.8.md follow in a separate commit (slim-drop
of v1.4.4 happens there).
2026-05-14 10:28:51 +02:00
JonKazama-Hellion 1003a88cad fix(messagestore): match TEXT-stored UUID form in FTS bulk insert and LoadByGuids
messages.Id is declared BLOB but stored as TEXT because Microsoft.Data.Sqlite
binds Guid parameters as UUID strings (UpsertMessage uses AddWithValue with
a Guid). RebuildFtsIndex cast reader.GetValue(0) to byte[] and threw
InvalidCastException at the first row. LoadByGuids bound byte[] params
against the TEXT-stored Id and would have returned no rows once the index
had built.

- RebuildFtsIndex reads via GetGuid and stores ToString() in
  messages_fts.message_guid.
- LoadByGuids parses incoming UUID strings and binds them as Guid so
  Microsoft.Data.Sqlite re-serialises to TEXT, matching the messages.Id
  storage form.
- DbViewer caller variable renamed hexIds -> guidHits for clarity.
2026-05-14 09:58:58 +02:00
JonKazama-Hellion 299fd59cbb refactor(retention): use Framework.RunOnTick instead of synchronous .Wait()
Retention sweep no longer blocks for ~194ms on Framework.Run().Wait().
The clear+refilter pair is now scheduled on the next framework tick, so
it still runs on the framework thread (keeping the Tabs-list mutation
serialisation invariant -- Plugin.Config.Tabs is plain List<Tab> and
AutoTellTabsService can mutate it from background paths) but does not
block the sweep thread while the framework finishes the current frame.

A new _isDisposing volatile bool is set as the first statement in
DisposeAsync so a deferred tick that fires after teardown bails before
it touches MessageManager / Log / static fields the dispose path has
already cleared. The retention worker is IsBackground=true so plugin
unload can race against a still-pending tick.

The existing RetentionSweepLock / RetentionSweepRunning serialisation
covers the not-two-sweeps-at-once invariant; we don't add a CTS here
because RunOnTick is fire-and-forget and the framework service owns
the tick lifecycle.

v1.4.8 B3. Coverage via in-game smoke (frame-time trace during a
retention sweep run) in Task 9 -- no Build-Suite test because the
suite has no FakeFramework fixture and the change is a schedule-form
swap rather than new behaviour.
2026-05-14 00:00:53 +02:00
JonKazama-Hellion 74bcb91b65 feat(themes): auto-reload active custom theme on disk change
When the user edits their active custom theme JSON in an external editor
and saves, the change now propagates to HellionChat within ~1 second
without re-selecting the theme in the picker.

RefreshActiveIfStale runs from Plugin.Draw on every frame but the actual
File.GetLastWriteTimeUtc stat is 1Hz-throttled -- 60fps would otherwise
mean 3600 stats/min, more on Wine. Built-in themes short-circuit on the
IsBuiltIn check; custom themes without a captured source path (Switch
fell to default) short-circuit on the null check.

Switch() now captures the source path of custom themes via an out-param
on LoadCustomBySlug, which now reverse-looks-up against the existing
_customCache (no re-parse, no extra disk IO). Plugin.LoadAsync warms the
cache via AllCustom() once before the first Switch so a Config.Theme
pointing at a custom slug does not fall through to the built-in default
on a cold registry.

Switch's lookup order is now built-in-first to match Get(slug), so a
user-authored JSON that declares a built-in slug is consistently
ignored in both code paths.

Pure-helper ThemeStampDiff isolates the stamp-diff rules for the
Build-Suite (covers DateTime.MinValue hold-the-line semantics).

v1.4.8 B2.
2026-05-13 23:22:14 +02:00
JonKazama-Hellion 2c64aaa251 fix(statusbar): make height DPI-aware via GetTextLineHeightWithSpacing
Replace the fixed 22px const Height with a computed property that bakes
in the ImGui font line height plus a GlobalScale-rounded 2px spacer.
The constant clipped the bottom bar on Windows display-scaling >100%
because ImGui rendered the actual font taller than 22px; the bar then
got pushed off the window edge.

ChatLogWindow.cs:423 reservation drops the explicit +2 because the
spacer now lives inside Height. Same idiom as the v1.4.6 F7.2 underline
pill in ChatLogWindow.cs:1639-1653.

v1.4.8 B1. Coverage via in-game smoke on Windows (Jin) and Linux/Wayland
in Task 9 -- DrawList-coupled, no Build-Suite test.
2026-05-13 22:42:40 +02:00
JonKazama-Hellion 607d2c7241 feat(dbviewer): full-text-search toggle wired to FTS5 query API
New UseFullTextSearch transient UI bool flips DbViewer.Filter() between
the existing local page filter (default) and the FTS5 MATCH path across
the whole database. ImRaii.Disabled blocks the toggle while the bulk-insert
worker is still building the index; the HelpMarker swaps between two
hints, one for the indexing state and one for the phrase-match advisory
once the index is ready.

Three new HellionStrings entries cover EN + DE + the Designer accessor:
- DbViewer_FullTextToggle (label)
- DbViewer_FullTextToggle_Hint_Indexing (tooltip while indexing)
- DbViewer_FullTextToggle_Hint_PhraseMode (tooltip once ready, warns
  multi-word terms match as phrases and how to opt into raw MATCH syntax)

Filter() short-circuits to the local fallback if the toggle is on but
ftsReady has flipped back to false -- defensive against a mid-session
Dispose-and-reopen during indexing.

v1.4.8 H2 Sub-Task 4.4.
2026-05-13 22:08:32 +02:00
JonKazama-Hellion b2a0f3a77c feat(messagestore): add FullTextSearch + LoadByGuids with MATCH-syntax escape
Two new public query methods plus an internal EscapeFtsTerm helper:
- FullTextSearch(term, limit) runs MATCH against messages_fts and returns
  hex-encoded GUIDs sorted by FTS5 rank. Empty/whitespace short-circuits
  to an empty list so callers can fall back to the local page filter.
- LoadByGuids(hexIds) resolves the hex GUIDs back to Message rows via
  WHERE Id IN (...). Chunked at 500 to stay below SQLite's 999-parameter
  cap, and the BLOB-PK autoindex means the join is O(log n) per id.
- EscapeFtsTerm wraps user input in double-quotes so multi-word queries
  match as a phrase, not as per-word AND. Users opt into raw MATCH
  syntax by writing their own quotes.

Plus _readLock serialises every Connection-touching internal method
(UpsertMessage, MessageCount, all readers, retention writers, etc.).
The DbViewer filter worker now runs FullTextSearch on a Task.Run thread
while the PendingMessageThread keeps calling UpsertMessage; SqliteConnection
is not safe for concurrent use, so this single lock is the minimal
architecture change that closes the race. The Lazy-Enumerator methods
(StreamForExport, GetDateRange, GetPagedDateRange) hold the lock only
through command-setup + ExecuteReader; v1.4.8 doc-notes the caveat for
the v1.5.x DI cycle to address with a snapshot-to-list or connection pool.

RebuildFtsIndex stays outside the lock -- it owns its own SqliteConnection
via OpenSecondaryConnection.
2026-05-13 21:27:17 +02:00
JonKazama-Hellion d26c4701fa feat(messagestore): async background FTS5 bulk-insert with progress notification
Adds the worker that fills the messages_fts virtual table after Migrate4.
The bulk-insert runs off the framework thread on its own SqliteConnection
opened via OpenSecondaryConnection -- WAL lets the live UpsertMessage
path on the primary Connection keep flowing, and the worker's writer
lock yields every 500 rows with a 5ms breather so PendingMessageThread
does not hit "database is locked" after DefaultTimeout=5s.

InitFtsReadyCache runs in the ctor and short-circuits to ready=true when
the index is already populated or when the messages table is empty. The
DbViewer (Task 4.4) reads IsFtsIndexBuilt per frame as a single volatile
field read.

Plugin.cs LoadAsync kicks the worker after FilterAllTabsAsync, gated on
IsFtsIndexBuilt and a CancellationTokenSource that DisposeAsync cancels
before MessageManager tears down. Progress reports back via IActiveNotification,
marshalled onto the framework thread via Framework.RunOnTick. Success path
finishes the notification as Success with a 5s linger; cancellation
dismisses it; an error swaps the type to Error with a fallback hint.
2026-05-13 20:38:05 +02:00
JonKazama-Hellion 7f317a2b18 refactor(messagestore): extract BuildConnectionString and ApplyPragmas helpers
Pre-step for the v1.4.8 FTS5 bulk-insert worker. The worker opens its
own secondary SqliteConnection on the same db path so the WAL journal
lets parallel reads/writes through, and it has to apply the exact same
connection-string options and PRAGMAs as Connect() -- otherwise the
worker connection drifts the moment Connect grows a new pragma.

Splitting BuildConnectionString + ApplyPragmas out lets both Connect()
and the upcoming OpenSecondaryConnection() share the same source of
truth instead of duplicating the body. No behaviour change.
2026-05-13 20:31:43 +02:00
JonKazama-Hellion 38149059c3 feat(messagestore): add Migrate4 with standalone FTS5 virtual table
Lays down a messages_fts virtual table with message_guid (UNINDEXED, hex
TEXT of the BLOB primary key), sender_text and content_text columns
using the unicode61 tokenizer with diacritic folding. Standalone FTS5
without content='messages' linking, because messages.Id is BLOB and
FTS5's content_rowid contract requires an INTEGER rowid alias.

LoadByGuids (Task 4.3) will resolve the hex GUIDs back to messages rows
via WHERE Id IN (...) joins. Schema step only -- the bulk-insert worker
that fills the index lives in Task 4.2.

Internal Connection property exposure plus a HasMessagesFtsTable helper
let the Build-Suite verify Migrate4 without raw PRAGMA glue in each test.

v1.4.8 H2 Sub-Task 4.1.
2026-05-13 19:51:54 +02:00
JonKazama-Hellion 67175419a9 refactor(messagestore): extract ReadMessageRow as shared deserialiser
Pure deserialisation helper that pulls one row from the current reader
position into a Message. The MessageEnumerator load path delegates to
it, and the upcoming FTS-join LoadByGuids (Task 4.3) will share the
same code so both stay in lockstep when the column layout shifts.

Pre-step for v1.4.8 H2 FTS5 full-text search.
2026-05-13 19:20:55 +02:00
JonKazama-Hellion d3fdcdf43d Merge branch 'feature/v1.4.7'
Security / scan (push) Successful in 23s
Build / Build (Release) (push) Successful in 30s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 7s
Release / Build and attach release ZIP (push) Successful in 39s
2026-05-13 11:07:32 +02:00
JonKazama-Hellion f4ea460644 chore: bump version to 1.4.7, sync changelog and forge post
- csproj <Version> -> 1.4.7
- repo.json AssemblyVersion + TestingAssemblyVersion -> 1.4.7.0
- repo.json DownloadLink{Install,Update,Testing} URLs -> /v1.4.7/
- repo.json + HellionChat.yaml changelog: prepend v1.4.7 block, retire
  v1.4.3 (slim rule keeps the last 3-4 versions)
- docs/CHANGELOG.md + docs/ROADMAP.md: v1.4.7 section, next-cycle
  pointer flipped to v1.4.8 Hook-Layer-Cycle
- README.md release badge + version stamps + Project Status block
  rewritten for v1.4.7
- .github/forge-posts/v1.4.7.md (new): DE body with subtitle
  "Backlog Cleanup and Mid-Features" / versionsnatur "Mid-Feature-Patch"
- Pin diagnostic logs (RehydratePinnedTabs / TryPin / Unpin /
  PromoteToPermanent) downgraded from Info to Debug so non-debug
  console stays quiet on release builds
2026-05-13 11:00:25 +02:00
JonKazama-Hellion d5735d8dcc fix(tabs): preserve runtime channel across Settings Save, deep-clone seeded CurrentChannel
Smoke-test round 4 surfaced a clean reproducer: a Party or Linkshell
tab with channel /p, then Settings → Save, popped the input back to
/tell <pinned-partner> on the next interaction. Two bugs combined:

1. Configuration.UpdateFrom captured only Messages+LastSendUnread from
   the live state during the persistent-tab merge. CurrentChannel was
   not preserved, so a Settings save overwrote the runtime channel
   state with the settings-time snapshot. If the user switched channel
   in-game between Settings-open and Settings-save, that switch was
   lost. Live CurrentChannel now joins Messages and LastSendUnread in
   the per-Identifier preservation tuple.

2. TabSwitched seeded a new tab's CurrentChannel from previousTab via
   reference copy (`newTab.CurrentChannel = previousTab.CurrentChannel`).
   That left both tabs sharing the same UsedChannel instance, so a
   later mutation on one bled into the other — exactly the path that
   carried a pinned tell-target onto Party. Switched to a deep clone
   (UsedChannel.Clone(), same Cherry-Pick-Patch-B pattern from v1.4.6)
   plus a Debug log so the next smoke can confirm at a glance which
   previous tab donated its channel state.

Pre-existing ChatTwo upstream pattern; v1.4.7 just made it visible
because pinned tabs are now the kind of long-lived tell-target that
sticks around for the seed path to grab.
2026-05-13 10:31:21 +02:00
JonKazama-Hellion 80b48ac3ad feat(sidebar): pinned section, dimmed pin glyph, configurable width
Smoke-test round 3 feedback from Jin:

- Sidebar now groups tabs into three sections rendered in this order:
  persistent → pinned TempTabs → unpinned TempTabs. Each TempTab
  section carries its own divider header ("Angepinnt (n)" / "Aktive
  Tells (n)"). Plugin.Config.Tabs order is untouched — only the
  display order changes, so tabI still mirrors the real index and
  LastTab/WantedTab stay consistent.

- The thumbtack glyph overlay on a pinned tab dropped from accent
  colour at full alpha to TextMuted at ~47% alpha. The section header
  is now the primary discoverability cue; the glyph is just a per-tab
  confirmation hint.

- Sidebar width is now a Config field (default 44, range 44-160).
  Slider lives in Theme & Layout under the existing Sidebar-Tab-View
  toggle. The icon button inside each row stretches with the width so
  a widened sidebar doesn't leave the icon floating in dead space.
2026-05-13 10:16:53 +02:00
JonKazama-Hellion cddd29a986 fix(tabs): pin indicator, history preload, drop Promote from temp menu
Smoke-test round 2 feedback from Jin:
- Promote-to-permanent label "Dauerhaft behalten" was indistinguishable
  from Pin in German, leading to misclicks that dropped the tell-target.
  Removed the menu entry from TempTabs entirely — Promote stays as a
  service method for future use, but the user-facing path is gone. Anyone
  who wants a regular tab can still create one via the existing
  "neuen Tab anlegen" flow.
- No visual confirmation that pin took effect. Added a FontAwesome
  thumbtack overlay top-left of the sidebar icon, accent-coloured, and
  appended a "Pinned — survives relog" line to the hover tooltip.
- Pinned tabs came back empty after a full disable/enable cycle because
  Tab.Messages is NonSerialized. RehydratePinnedTabs now also runs the
  same MessageStore-backed PreloadHistory the spawn path uses, so the
  recent conversation window reappears alongside the rehydrated
  TellTarget.

Diagnose-logging on TryPin/Unpin/Promote/Rehydrate stays in so the next
smoke can confirm at a glance which path fired from the Dalamud console.
2026-05-13 10:08:33 +02:00
JonKazama-Hellion 799fdb67cc fix(tabs): rehydrate pinned TempTab tell-targets after reload
Smoke-test (Jin's scenario) surfaced two coupled bugs in v1.4.7 pin
persistence:

1. The chat input couldn't send to the pinned partner after a reload.
   Tab.CurrentChannel is NonSerialized, so it came back as a fresh
   UsedChannel with TellTarget=null even though tab.TellTarget (the
   persisted twin) was intact. The game-side channel hook only repaints
   CurrentChannel on a /tell or channel switch, so the pinned tab sat
   there mute until the user manually re-bounced the channel.

2. An incoming tell from the pinned partner spawned a *second* TempTab
   instead of routing into the existing pinned one. The Name+World
   lookup in FindTempTab was vulnerable to any round-trip nuance on
   tab.TellTarget — the fallback path now matches by tab name, which
   FormatTabName pins at spawn time.

Fix:
- AutoTellTabsService.Initialize now calls RehydratePinnedTabs() after
  the Phase-2 wiring lands, seeding tab.CurrentChannel.TellTarget +
  Channel from the persisted tab.TellTarget. Channel is also defaulted
  to InputChannel.Tell on the tab record so the chat-input bar paints
  Tell mode immediately on first selection.
- FindTempTab gained a Name-based fallback for the case where the
  primary TellTarget lookup misses (e.g. a pinned tab whose TellTarget
  didn't round-trip cleanly through an old save).
- HandleTell self-heals: when the fallback matches a pinned tab with a
  missing TellTarget, the tab is repaired from the live partner data
  and persisted, so subsequent messages take the fast path.

Build-suite coverage was attempted (PinnedTabJsonRoundtripTests) but
Tab + TellTarget are both Dalamud-coupled — Newtonsoft's reflection
walk loads Dalamud.dll which isn't available in the xUnit AppDomain
(documented in feedback_dalamud_test_isolation). Verification stays on
the ingame smoke path.
2026-05-13 09:53:27 +02:00
JonKazama-Hellion 69fa0fecbd feat(honorific): render glow outline as opt-in (gradient deferred)
Honorific's TitleData carries Glow / Color3 / GradientColourSet /
GradientAnimationStyle beyond the Title + Color we parsed in Cycle 1.
The DTO now mirrors all four so the JSON roundtrip doesn't silently
drop fields.

Rendering for v1.4.7 covers Glow only: when Config.ShowHonorificGlow
is on and the title has a Glow colour, the chat header title gets an
8-direction ±1px draw-list outline pre-pass in the glow colour at 0.4
alpha, then the primary text on top.

Gradient (Color3 / GradientColourSet / GradientAnimationStyle) is parsed
and stashed for a later cycle — porting the full animation needs
Honorific's hardcoded Pride-palette list and GradientSystem.cs (or an
upstream IPC PR exposing the resolved frame colour). Tracked as
"Honorific Full Gradient Port" in the vault backlog.

ShowHonorificGlow defaults OFF — keeps v1.4.6 visuals untouched and
dodges per-frame DrawList overhead on low-end hardware. Tooltip flags
the gradient deferral so users aren't surprised by static rendering.
2026-05-13 09:34:43 +02:00
JonKazama-Hellion fd5f970a8b feat(tabs): add IsPinned with separate pool and 5-tab cap
Tester-Request from Jin (2026-05-03): TempTabs should be pinnable so a
key conversation partner survives a relog. Right-click a TempTab and
choose Pin Tab / Unpin Tab / Promote to permanent.

Pool semantics:
- AutoTellTabsLimit (15) still gates the auto-managed unpinned pool.
- Pinned TempTabs live in their own pool, hard-capped at 5.
- The 6th pin attempt fails with a notification; users can unpin first
  or promote to permanent.
- Unpinning into a full unpinned pool drops the oldest unpinned (no
  user friction).

Mechanics:
- Tab.IsPinned (default false); Tab.Clone() carries it.
- Migration v16 -> v17 (additive; existing tabs default to unpinned).
- Three strip-sites synchronised through TabLifecycleHelpers:
  Plugin.cs load-time, Plugin.SaveConfig, Configuration.UpdateFrom.
- AutoTellTabsService:
  * MaxPinnedTempTabs constant.
  * F2.1 _activeTempTabCount counter retired — ActiveTempTabCount is
    now Tabs.Count(predicate). Pin/Unpin/Promote transitions are
    cold-path and don't need lock-free reads.
  * DropOldestTempTab filters on IsInUnpinnedPool so pinned tabs are
    never drop candidates.
  * OnLogout strips only the unpinned pool; pinned popouts and the
    active-tab switch behave correspondingly.
  * TryPin / Unpin / PromoteToPermanent service methods.
- ChatLogWindow tab context menu: Pin / Unpin / Promote with disabled-
  state at-cap tooltip + Promote tooltip explaining the channel-filter
  side effect.
- HellionStrings (EN+DE) for menu labels, tooltips, the limit warning.
- AutoTellTabsLimit slider description now flags the separate pinned
  pool so users aren't surprised by 18 tabs when the limit reads 15.
2026-05-13 09:06:14 +02:00
JonKazama-Hellion fee2459e73 refactor(services): route logging through IPluginLogProxy
F12.2 step 5b — service cluster (~42 sites in 16 files):
MessageManager, GameFunctions/{Chat, GameFunctions, KeybindManager},
EmoteCache, PayloadHandler, AutoTellTabsService, FontManager, Commands,
Util/{WrapperUtil, AutoTranslate, MemoryUtil}, Message, Themes/ThemeRegistry,
Ipc/ExtraChat, Configuration.

The proxy interface gained Dalamud's params-overload signature
(messageTemplate + params object[]) to cover Configuration.cs:86 which
relies on Serilog-style placeholders.

Verified: zero remaining Plugin.Log.X(...) call-sites in HellionChat/,
build green, build-suite 690/690.
2026-05-13 08:38:40 +02:00
JonKazama-Hellion 63cad62c89 refactor(ui): route logging through IPluginLogProxy
F12.2 step 5a — UI cluster (~40 sites in 6 files):
ChatLogWindow, DbViewer, Popout, SettingsTabs/{DataManagement,
FontsAndColours, ThemeAndLayout}. Plugin.Log.X(...) → Plugin.LogProxy.X(...).
No behaviour change; the proxy delegates 1:1 to the original IPluginLog.
2026-05-13 08:22:12 +02:00
JonKazama-Hellion dca5de4085 refactor(messagestore): inject IPluginLogProxy for test isolation
MessageStore's Migrate0 (and the Migrate1/2/3 siblings) called
Plugin.Log.Information directly, which prevented an isolated xUnit
construction test from running — Dalamud.dll cannot load in the test
AppDomain. With IPluginLogProxy threaded through the ctor and the inner
MessageEnumerator, the whole MessageStore.cs file is now Dalamud-static
free and the Build-Suite covers it (Floor 688 -> 690).

This is the second half of F12.2; the remaining ~82 Plugin.Log call
sites in the rest of the plugin will be routed through the static
Plugin.LogProxy wrapper in a follow-up commit.
2026-05-13 08:15:20 +02:00
JonKazama-Hellion 8edc3c70d3 feat(util): add IPluginLogProxy interface and production wrapper
F12.2 closes the gap that F12.1 left open: MessageStore's ctor calls
Plugin.Log.Information inside Migrate0, which prevents an isolated xUnit
construction test (Dalamud.dll cannot load in the test AppDomain).

The proxy mirrors IPluginLog's full surface (Verbose/Debug/Information/
Info/Warning/Error/Fatal — both Info and Information as Dalamud exposes
them) with both single-string and Exception+string overloads, so the
~91 existing Plugin.Log.* call-sites become a drop-in rewrite to
Plugin.LogProxy.*.

A later DI-container adoption cycle (v1.5.x) may swap this for
Microsoft.Extensions.Logging's ILogger<T>; this commit is the
intermediate decorator step.
2026-05-13 08:11:34 +02:00
JonKazama-Hellion 3c33acf6d7 fix(util): pin operator precedence in DrawArrows IconButton id
`id + 1.ToString()` resolves as `id.ToString() + "1"`, producing "01"
instead of "1" for the ArrowRight button. The single live caller
(DbViewer page navigation) still produced unique IDs by accident, but
the semantics were wrong. Explicit parentheses fix it.
2026-05-13 08:08:52 +02:00
JonKazama-Hellion c8ba8c1cd0 docs: linting Docs
Security / scan (push) Successful in 22s
Build / Build (Release) (push) Successful in 29s
2026-05-12 22:41:54 +02:00
JonKazama-Hellion 94e4828aeb fix: update forge-announce.yml to use the correct branch
Security / scan (push) Successful in 21s
Build / Build (Release) (push) Successful in 27s
2026-05-12 22:33:53 +02:00
JonKazama-Hellion 1d88cb4c42 Merge feature/v1.4.6 — Code Hygiene and Refactor
Security / scan (push) Successful in 22s
Build / Build (Release) (push) Successful in 29s
Release / Build and attach release ZIP (push) Successful in 37s
Forge Announce / Post changelog to Hellion Forge (push) Failing after 7s
2026-05-12 21:28:29 +02:00
JonKazama-Hellion c5fe69f0d3 feat(themes): swap Moonlit Bloom for Crystal Nocturne, sort built-ins by colour family
Crystal Nocturne (royal sapphire + electric magenta on obsidian, by
CRYSTALLITE) replaces Moonlit Bloom in the built-in roster. The same
chat-channel tinting convention applies: sapphire-blue identity on
party/team channels, accent-magenta on tells, and an alternating
mint/yellow/peach palette across the eight linkshell slots so each
LS stays individually distinguishable on the dark obsidian background.

Users who had Moonlit Bloom selected fall back to the default Hellion
Arctic on the first plugin load. A custom JSON copy of Moonlit Bloom
dropped into pluginConfigs/HellionChat/themes/ keeps working as a
user theme.

Plus a cosmetic re-sort of the registry: insertion order now drives a
deliberate Theme-Picker grid layout (3 columns) — blue family in row 1,
purple to magenta in row 2, green/warm/classic in row 3, Synthwave
Sunset alone in row 4 as a retro bonus.
2026-05-12 21:28:16 +02:00
JonKazama-Hellion b46d3ad0a8 chore: bump schema-gate message to v1.4.6
Plugin.cs:171-172 hardcoded the version into the schema-gate
InvalidOperationException string. The follow-up rename in v1.4.7 will
move this to Plugin.Interface.Manifest.AssemblyVersion so this commit
stops happening every cycle, but for v1.4.6 the bare version bump is
the smallest change.

Also picks up a one-line csharpier reflow on UrlValidation.cs
collapsed by the format pass.
2026-05-12 20:59:56 +02:00
JonKazama-Hellion e33cf0dcb9 ci(forge): add v1.4.6 forge announcement post
DE body for the Hellion Forge Discord embed; subtitle and
versionsnatur frontmatter fields within the 60/40 char caps;
embed-total ~2267/5500 per the changelog-sync verifier.
2026-05-12 20:58:59 +02:00
JonKazama-Hellion 0d016aaa5d docs: log v1.4.6 release notes
CHANGELOG.md gets the full per-bullet block, ROADMAP.md gets the
released-cycle summary plus a v1.4.7 next-cycle placeholder, README
status section and version badge updated.
2026-05-12 20:58:57 +02:00
JonKazama-Hellion 5b972238bb chore: bump version to 1.4.6
csproj <Version>, yaml changelog block (v1.4.6 added on top, v1.4.2
rotated out per the slim-4-versions rule), repo.json AssemblyVersion
+ TestingAssemblyVersion + the three DownloadLink URLs + Changelog
string, all in sync.
2026-05-12 20:58:52 +02:00
JonKazama-Hellion 7ac1eb3fd4 fix(ui): pass measured width straight through IconButton, drop broken subtract
Inspired by ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).

Upstream dropped the width parameter entirely because nothing called
it. We keep the parameter — two ChatLogWindow header buttons (Cog,
EyeSlash) size themselves to match the preceding ChannelIcon button.

The actual bug is local: the previous size = width - 2 * CellPadding.X
mixed a raw int (HUD-scale unaware) with CellPadding.X (HUD-scaled),
so the button shrank under elevated HUD scale. ImGui.Button handles
its own frame padding internally, so the measured width passes
through unchanged.
2026-05-12 20:42:17 +02:00
JonKazama-Hellion db48f27842 fix(chat): release Utf8String when linkshell check rejects channel
Cherry-pick from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).

Chat.SetChannel allocates a native Utf8String for the target name and
then runs a validity check. The previous early return on an invalid
linkshell skipped Dtor and leaked the native allocation; every invalid
linkshell switch added one Utf8String to the unmanaged heap.

- Renamed ValidAnyLinkshell to IsChannelOrExistingLinkshell so the
  call-site reads naturally.
- Wrapped ChangeChatChannel in the validity check instead of
  early-returning. Dtor now runs on every path.
- ChatLogWindow follows the rename at its single call-site.
2026-05-12 20:39:23 +02:00
JonKazama-Hellion f8b5c14509 fix(config): deep-clone UsedChannel and TellTarget in Tab.Clone
Cherry-pick from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).

Tab.Clone() used to assign CurrentChannel = CurrentChannel and run
TellTarget.From(TellTarget). The first was a plain reference copy of
the UsedChannel — the clone and the source shared the same channel
state, so a channel switch or TellTarget update on a PopOut/Temp tab
also mutated its origin tab. The second was a static factory call
that read like a constructor where every other place uses Clone().

- TellTarget: static From(t) replaced by instance Clone(); only
  call-site swapped to TellTarget.Clone().
- UsedChannel: new Clone() that copies the scalar fields and runs
  Clone() on the two TellTarget references (null-safe).
- Tab.Clone(): CurrentChannel goes through UsedChannel.Clone().
2026-05-12 20:38:12 +02:00
JonKazama-Hellion 28e4b30cd6 refactor(ui): route OpenLink call-sites through Plugin.PlatformUtil (F12.1)
Ten Util.OpenLink call-sites across five files now go through the
IPlatformUtil indirection: WrapperUtil.TryOpenUri, the Settings Ko-Fi
buttons (x2), the Information tab (issues link plus media/upstream
links, x3), the Integrations tab (Honorific repo/author plus forge
discord, x3), and the ThemeAndLayout 'open themes folder' button.

A future addition to this pattern only needs to plug into IPlatformUtil
instead of touching Dalamud.Utility.Util directly.
2026-05-12 20:32:17 +02:00
JonKazama-Hellion 4510c1e404 refactor(store): route MessageStore IsWine probe through IPlatformUtil (F12.1)
MessageStore.Connect used to call Util.IsWine() directly via a
DalamudUtil alias, which made the ctor unreachable from the xUnit
test AppDomain: any test that allocated a MessageStore tripped a
FileNotFoundException on Dalamud.dll before reaching the assertion.

The ctor now takes an IPlatformUtil and reads the cached IsWine
property. MessageManager passes Plugin.PlatformUtil in. Production
behaviour is identical; the test path can now substitute a fake
and exercise the SQLite migration logic in isolation.
2026-05-12 20:29:22 +02:00
JonKazama-Hellion 6b44f549b4 feat(util): add IPlatformUtil indirection over Dalamud.Utility.Util (F12.1)
Introduces a thin interface around Util.IsWine and Util.OpenLink so
services can be constructed in an isolated xUnit AppDomain without
forcing Dalamud.dll onto the assembly search path. Production wiring
(DalamudPlatformUtil) caches IsWine at ctor time — it's a runtime
probe that never changes for the lifetime of a plugin instance,
mirroring the Lightless DalamudUtilService pattern.

Plugin.PlatformUtil is wired in the Phase-1 ctor so any service that
LoadAsync allocates can resolve the platform indirection without
plumbing the instance through additional constructor params.

Follow-up commits route MessageStore and the OpenLink call-sites
through this interface.
2026-05-12 20:10:40 +02:00
JonKazama-Hellion ae1436b103 perf(config): clone only temp tabs in SaveConfig snapshot/restore (F2.2)
The pre-serialization snapshot used to clone the entire Config.Tabs
list, then Clear/AddRange the snapshot back. With a typical config of
~30 user-defined tabs plus up to 15 session-only temp tabs, that's a
45-item clone on every save. The persistent tabs never leave the list
during this routine, so cloning only the temp subset is functionally
identical and keeps the allocation proportional to AutoTellTabsLimit.
2026-05-12 19:35:17 +02:00
JonKazama-Hellion 2684c31f10 fix(ui): scale active-tab underline with DPI for crisp rendering (F7.2)
The 2px underline pill was hardcoded — at 125/150% DPI the surrounding
tab layout scaled with ImGuiHelpers.GlobalScale but the pill stayed
2px, so the line landed on sub-pixel boundaries and rendered as a
fuzzy band. Now: height scales with GlobalScale (clamped to >=1px),
and the DrawList coordinates round to physical pixels via MathF.Round
so the rect aligns with the framebuffer grid.
2026-05-12 19:09:43 +02:00
JonKazama-Hellion bdd64cad07 perf(ui): cache GetWindowDrawList per frame in SettingsOverview (F7.3)
DrawCard used to call ImGui.GetWindowDrawList once per card, so a frame
with 10 settings cards took 10 draw-list lookups. The list is the same
for every card in the same frame, so Draw() now resolves it once and
passes the pointer down. Pattern parity with ChatLogWindow's frame-local
draw-list handling.
2026-05-12 18:43:05 +02:00
JonKazama-Hellion 28ea2fa553 refactor(theme): extract ChildBgAlpha threshold logic to testable helper (F1.2)
HellionStyle.PushGlobal had two lines that resolved the child-bg alpha
based on window opacity. Moves the 0.999f threshold and the alpha-mask
into HellionStyleHelpers.ResolveChildBgAlpha so the logic is reachable
from the build suite without touching the ImGui surface.
2026-05-12 18:19:15 +02:00
JonKazama-Hellion dd597fca44 feat(branding): validate URL constants on module init (F11.2)
BrandingLinks (5 Hellion-owned URLs) and IntegrationLinks (2 third-party
plugin URLs) now run through UrlValidation.ValidateAll from a
[ModuleInitializer] hook. A malformed URL throws InvalidOperationException
at plugin load with the source class and the broken URL in the message,
instead of silently failing when a user clicks the button.

CA2255 is suppressed at the attribute sites — the warning is for library
code shipped to unknown consumers, but the plugin DLL is loaded directly
by Dalamud, which makes module-init the right one-shot hook.
2026-05-12 17:48:51 +02:00
JonKazama-Hellion b9d3ff8f26 fix(fonts): broaden font fallback catch to handle atlas-toolkit throws (G2)
The atlas-toolkit pipeline can throw InvalidOperationException or
ArgumentException when a configured font is structurally broken (e.g.
unreadable header, unsupported glyph table). Previously only IO-shaped
throws routed to the NotoSansCjkRegular fallback, so a corrupt font
config would take down the entire atlas build instead of degrading
gracefully. The warning log now carries the exception type name so the
diagnostic path can tell which class of throw triggered the fallback.
2026-05-12 17:19:28 +02:00
JonKazama-Hellion df3d5d78d6 build(preflight): add csharpier and markdownlint blocks (G1)
Block E runs 'dotnet csharpier check' against the HellionChat/ tree,
catching reflow drift before push. Block F runs markdownlint-cli2 over
the repo's *.md files; MD036 is disabled because forge-post bodies use
bold emphasis as section headings (the auto-announce workflow renders
those as Discord embeds, so the bold pattern is required). The .claude
directory is excluded from the lint scope to match its gitignore status.

.markdownlint.json also gains MD024 with siblings_only:true so per-release
'### Internal' sub-headers in CHANGELOG.md don't trip the rule across
sibling H2 sections.
2026-05-12 16:53:22 +02:00
JonKazama-Hellion 2e057ce6c4 Merge feature/v1.4.5 — UX and Robustness
Security / scan (push) Successful in 22s
Build / Build (Release) (push) Successful in 31s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 8s
Release / Build and attach release ZIP (push) Successful in 40s
2026-05-12 15:32:02 +02:00
JonKazama-Hellion e5dbc333fa docs: linter pass on v1.4.5 release notes
Whitespace and line-reflow drift from the markdown linter on the four
files touched by the versions-bump commit (forge-post, README,
CHANGELOG, ROADMAP). No content changes.
2026-05-12 15:30:06 +02:00
JonKazama-Hellion d0ec94c3e6 style: align v1.4.5 additions with HellionChat conventions
Pattern-adherence pass after the cycle's code commits:

- ChatLogWindow.cs: NotifiedDrawFailure renamed from
  _notifiedDrawFailure. The file's per-window state flags (DrewThisFrame,
  WasDocked, Activate, PlayedClosingSound, …) all use PascalCase
  without underscore prefix; the new flag now matches that
- Plugin.cs: trim the session-only RemoveAll comment from 5 lines to 2
  and add the standard TEST-MIRROR pointer line. Same shape as
  AutoTellTabsService.cs:28 and the other six TEST-MIRROR sites
- InputHistoryService.cs: add the TEST-MIRROR pointer for the new
  Build-Suite tests
2026-05-12 15:30:01 +02:00
JonKazama-Hellion cafb6faa39 chore: bump version to 1.4.5
Manifest sync across csproj, yaml, repo.json, README, CHANGELOG,
ROADMAP and the Plugin.cs schema-gate error message. ROADMAP also gets
the v1.4.4 release block that was missed in that cycle's closure.

Forge-post v1.4.5.md follows the established frontmatter + DE-body
convention; the EN block is sourced from the yaml changelog by the
forge-announce workflow.
2026-05-12 14:33:13 +02:00
JonKazama-Hellion b8d289a847 fix(ui): hide status bar version when window is too narrow
Below roughly 340 px content width the version slot starts overlapping
the four slots to its left because the right-aligned SameLine still
plants the text where its baseline would have been. New 200 px width
threshold drops the version line entirely below that, so the other
slots stay readable. The version is back as soon as the window grows.
2026-05-12 14:19:46 +02:00
JonKazama-Hellion f16d8f5c78 docs(plugin): clarify session-only Auto-Tell-Tab invariant (F2.3)
Expands the one-liner above Plugin.cs:167-168 to spell out *why* the
RemoveAll runs before AutoTellTabsService.Initialize: tells are
typically privacy-filtered, so resurrecting a tab from a crashed
session would trigger DB reconstruction on the next load. Also links
to the TEST-MIRROR pin in the Build-Suite for future readers.
2026-05-12 14:11:02 +02:00
JonKazama-Hellion eabb39ba86 fix(font): fall back to system font if embedded resource missing (F10.2)
GetHellionFontBytes used to throw a FileNotFoundException when the
embedded Hellion font resource was missing — only possible on a broken
csproj or a hand-rolled dev build, never on a signed release, but the
throw bubbled up and broke the entire UiBuilder font atlas.

Replaced with a nullable TryGetHellionFontBytes that logs a warning
and returns null on miss. The RegularFont delegate now falls back to
the same system-font path that UseHellionFont=false already uses, so
the plugin still loads and the issue surfaces in /xllog instead of as
a crash.
2026-05-12 13:55:04 +02:00
JonKazama-Hellion b489ac946c fix(ux): reset input history on plugin dispose (F10.1)
Static InputHistoryService entries used to survive a plugin reload
because static field state doesn't get cleaned up on its own. The new
Reset() method clears the list and is wired into Plugin.DisposeAsync
alongside the existing pure-memory cleanups, so the next plugin load
starts with an empty history instead of inheriting the previous
session's typed commands.
2026-05-12 13:41:38 +02:00
JonKazama-Hellion 8d9151c74a feat(ux): explicit cancel affordance on first-run wizard (F8.1+F8.2)
Splits accept from close: OnClose no longer silently sets
FirstRunCompleted, so the X-button leaves the wizard pending and it
reopens on the next plugin load. A new footer 'Later — keep defaults'
button is the explicit path to dismiss the wizard without picking a
profile; defaults stay active and the choice persists.

Strings are bilingual (EN + DE) with a tooltip explaining the
behaviour. Card height now reserves room for the footer separator.
2026-05-12 13:31:53 +02:00
JonKazama-Hellion 4ecbaf2a4b feat(ux): show notification on chat log draw failure (F7.1)
Surfaces a per-session warning notification when DrawChatLog throws so
the user knows something went wrong instead of staring at an empty
window. Stack trace stays in /xllog as before. The one-shot guard
prevents the notification stack from flooding frame-by-frame; it
resets only on the next plugin reload.
2026-05-12 13:22:24 +02:00
JonKazama-Hellion 3e4601a0c8 chore: reflow drift from v1.4.4 closure
Whitespace and line-reflow artefacts from auto-formatter passes plus a
packages.lock.json indent normalisation. No content changes.
2026-05-12 13:08:59 +02:00
JonKazama-Hellion 61d5a33683 Merge fix/release-workflow-ref-guard into main
Security / scan (push) Successful in 21s
Build / Build (Release) (push) Successful in 28s
Forge Announce / Post changelog to Hellion Forge (push) Successful in 7s
Release / Build and attach release ZIP (push) Successful in 39s
Guards release.yml against non-tag refs and fixes the silent
ignore of body_path / tag_name that left every Gitea release
since v1.4.1 with an empty body.
2026-05-12 11:50:32 +02:00
JonKazama-Hellion 7ed689587b fix(ci): guard release.yml against non-tag refs and pass body inline
The release-action@main reads GITHUB_REF directly and rejects anything
that doesn't start with refs/tags/. The previous workflow tried to work
around this by passing tag_name as an action input, but the action's
action.yml never declared tag_name (or body_path) - both inputs were
silently ignored, which is why every Gitea release since v1.4.1 was
published with an empty body.

Changes:
- New "Validate tag ref" step fails fast with a clear message when the
  workflow is dispatched from a branch ref instead of a tag ref.
- workflow_dispatch.inputs.tag dropped; recovery now means picking the
  tag from Gitea's Ref dropdown so GITHUB_REF lines up with refs/tags/.
- release-body.md is re-emitted as a step output and passed via body:
  (the input the action actually reads) instead of body_path.
- tag_name input removed from the action call - the action derives the
  tag from GITHUB_REF_NAME on its own.
2026-05-12 11:33:58 +02:00
JonKazama-Hellion 612bf8814f fix(ci): match release + forge-announce parsing to current yaml format
Security / scan (push) Successful in 21s
Build / Build (Release) (push) Successful in 30s
Both workflows looked for "**Hellion Chat <version>" as the changelog
subblock header, but the yaml convention is "**v<version> — <subtitle>"
(matches verify-changelog-sync.sh and the slim-rule grep). Plus the
indent-strip was 2 spaces, but prettier writes the changelog block with
4-space indent. Both regressions silently failed every release-workflow
run since the format change — likely why v1.4.3 was released manually.

Sync header marker to "**v$version " and indent-strip to 4 spaces in
both files.
2026-05-12 11:17:41 +02:00
JonKazama-Hellion be17472cd5 chore(ci): migrate workflows to .gitea/workflows/
Security / scan (push) Successful in 19s
Build / Build (Release) (push) Successful in 42s
Gitea Actions reads exclusively from .gitea/workflows/, not from
.github/workflows/. Since the cutover in v1.4.3 only the security
workflow has been running — release and forge-announce silently sat in
the wrong directory and never fired on any tag push. v1.4.3 must have
been released manually.

Move build, release and forge-announce yamls to .gitea/workflows/. The
.github/forge-posts/ and .github/release-footer.md data files stay where
they are; the workflows reference them by repo-relative path and that
keeps working.

For the v1.4.4 backfill: workflow_dispatch via the Gitea web UI with
tag=v1.4.4 will run release.yml + forge-announce.yml against the tagged
tree (which doesn't contain this migration). The dispatch yaml itself
is read from the default branch, not the tag, so the missing yamls in
the v1.4.4 tag tree don't matter.
2026-05-12 11:05:52 +02:00
JonKazama-Hellion 8bf50151d5 Merge feature/v1.4.4 into main (Threading and IPC Safety release)
Security / scan (push) Successful in 18s
2026-05-12 10:56:51 +02:00
JonKazama-Hellion 57da455700 fix: post-review polish on v1.4.4
- IsAllowedForStorage warning now only fires for ChatTypes the build
  doesn't recognise (Enum.IsDefined), not for opted-out known ones
- Drop stale tests-location comment in HonorificService
2026-05-12 10:47:43 +02:00
JonKazama-Hellion 0982b68a4a chore: bump version references in Plugin.cs and README
Pre-push grep-verification found four stale v1.4.3 mentions outside the
Slim-Rule history files:

- Plugin.cs schema-gate error message referenced v1.4.3 by name in both
  the comment and the user-facing exception text. Schema stays at v16,
  but the message now points at the current release
- README.md latest-release badge bumped to v1.4.4
- README.md version header bumped to v1.4.4
- README.md Project Status block rewritten for v1.4.4 with the threading
  and IPC safety items as the lead

ROADMAP.md historical references to v1.4.3 are intentional (released-tag,
foundation-reference) and stay.
2026-05-12 10:22:21 +02:00
JonKazama-Hellion 0fc88e480a chore: bump version to 1.4.4 + changelog sync + forge-post
Threading and IPC safety release. Items: F2.1 (Interlocked counter),
F4.1/F4.2/F4.3 (HonorificService threading banners + warning log),
F9.2 (AutoTranslate IsBackground), F3.1 (PrivacyPersistUnknownChannels
default), F3.2 (unknown-ChatType warning).

verify-changelog-sync: yaml/repo.json/forge-post in sync, embed-total
~2699/5500, 3/4 yaml subblocks. verify-version-consistency and
verify-manifest-shape both green.
2026-05-12 10:11:31 +02:00
JonKazama-Hellion 7eb50e2c8d feat(privacy): log warning on unknown ChatType in IsAllowedForStorage
F3.2: a future FFXIV patch can introduce ChatTypes that aren't on any
existing whitelist, and the filter currently routes them silently
through the unknown-channel failsafe. Add a dedup HashSet (per runtime,
NonSerialized) so the first hit per ChatType logs a Warning. The
failsafe behaviour itself is unchanged — only visibility is new.
2026-05-12 09:54:05 +02:00
JonKazama-Hellion 58e754c169 feat(privacy): default PrivacyPersistUnknownChannels to true for new configs
F3.1: future FFXIV patches can add new ChatTypes that aren't on any
existing whitelist. With the field defaulted to false a new install
would silently drop those channels until the user opts in. New configs
now start with PrivacyPersistUnknownChannels=true via a constant in
PrivacyDefaults. Existing configs keep their explicit choice — the
deserializer overrides the initializer, so no migration and no schema
bump.
2026-05-12 09:41:52 +02:00
JonKazama-Hellion 83064cd40b fix(autotranslate): mark warmup thread as IsBackground
F9.2: PreloadCache spawned a new Thread without IsBackground, which kept
the plugin unload blocked until the warmup finished (typically
100-300 ms). Setting IsBackground=true plus a named thread matches the
pattern already used in MessageManager (F6.1) and Plugin.RetentionSweep
(F9.3) since v1.4.0.
2026-05-12 09:33:57 +02:00
JonKazama-Hellion 5ca3b73b7f refactor(honorific): per-method threading banners + warn on unsubscribe-fail
F4.1: replace the block threading comment with per-method banners that
read like documentation at the call site. F4.2: TryUnsubscribe now logs
Warning instead of Debug — a silent unsubscribe failure leaks a live
subscription across plugin reloads. F4.3: CurrentTitle gets a one-line
banner matching the same convention.
2026-05-12 09:19:52 +02:00
JonKazama-Hellion 570a6f071c style(autotell): csharpier format F2.1 changes 2026-05-12 09:19:49 +02:00
JonKazama-Hellion 11ad5db127 perf(autotell): replace lock-protected count with Interlocked counter
F2.1: ActiveTempTabCount was doing a LINQ Count under _tempTabsLock on
every read, including the hot-path HandleTell guard. Replace with an
Interlocked counter kept in sync with Config.Tabs from inside the
existing mutation paths (SpawnTempTab, DropOldestTempTab, OnLogout).
Initialize from the persisted Tabs list on Initialize() to handle
configs that already contain TempTabs from a prior session.

Plugin.cs SaveConfig snapshot-restore mutates Config.Tabs outside of
AutoTellTabsService; expose ResyncTempTabCounter() and call it after
AddRange so the counter stays consistent. Plugin.cs:168 crash-recovery
RemoveAll runs before Initialize() and is covered by the init snapshot.
2026-05-12 09:06:20 +02:00
JonKazama-Hellion 5c550e8587 fix(scripts): adapt verify-changelog-sync to **vX.Y.Z** subblock format
yaml.changelog and repo.json.Changelog now use **vX.Y.Z** subblock
headers instead of the older **Hellion Chat X.Y.Z** form. Updated the
three regex patterns (yaml check, repo.json check, version counter)
and re-enabled Block C in preflight.sh — the SKIP workaround is no
longer needed.
2026-05-12 02:22:59 +02:00
JonKazama-Hellion eb2a04c56b docs: Update gitignore for Pair AI settings 2026-05-12 00:33:52 +02:00
JonKazama-Hellion 3f714d6f38 Merge pull request 'chore(renovate): fix schema warning (prPriority)' (#16) from chore/renovate-config-schema-fix into main
Security / scan (push) Successful in 11s
Reviewed-on: #16
2026-05-11 22:25:23 +00:00
renovate-bot 747e0e1574 chore(renovate): fix schema (prPriority placement)
Security / scan (pull_request) Successful in 16s
Moves prPriority out of vulnerabilityAlerts (only allowed in packageRules per schema).
Fixes the recurring 'Found renovate config warnings' issue.
2026-05-11 22:16:49 +00:00
JonKazama-Hellion debfdcd278 Merge pull request 'chore(config): migrate Renovate config' (#15) from renovate/migrate-config into main
Security / scan (push) Successful in 11s
Reviewed-on: #15
2026-05-11 18:43:52 +00:00
renovate-bot f85daf3dbe chore(config): migrate config renovate.json
Security / scan (pull_request) Successful in 14s
2026-05-11 18:35:29 +00:00
JonKazama-Hellion 3b24b2adc4 docs: translate CHANGELOG and ROADMAP to English
Security / scan (push) Successful in 13s
Translate all remaining German sections in docs/CHANGELOG.md and
docs/ROADMAP.md to English for consistency across the repository.
Previously English sections left unchanged.
2026-05-11 20:32:11 +02:00
JonKazama-Hellion c493340104 fix(renovate): exclude Gitea workflows from pinDigests lookup
Security / scan (push) Failing after 10s
2026-05-11 20:17:33 +02:00
JonKazama-Hellion 3a7f9b3adb refactor(strings): replace ResourceManager.GetString with direct HellionStrings properties
Security / scan (push) Successful in 13s
- SettingsOverview: replace dynamic key lookup via ResourceManager with
  direct HellionStrings property access; switch static readonly array to
  BuildCardDefs() method to ensure correct initialization order
- ThemeAndLayout: replace all ResourceManager.GetString calls with direct
  HellionStrings/Language property access throughout DrawThemeSection()
  and DrawChatColorsApplyBanner()

Also rework DE/EN string copy for a more natural, less formal tone in the German localization, and to better match the English source text. This includes
2026-05-11 20:11:53 +02:00
JonKazama-Hellion b1b6402827 docs: Fix the last comments i think now
Security / scan (push) Successful in 12s
2026-05-11 08:11:30 +02:00
JonKazama-Hellion 7d73def53d fix: disable changelog sync preflight check for non-code change
Security / scan (push) Successful in 11s
Changed HellionChat.yalm but need to Ajust the preflight script to not fail on this non-code change. TODO: Fix the script to only check for code changes in the future.
2026-05-11 00:56:54 +02:00
JonKazama-Hellion c4c85cf4b8 docs: unify documentation and streamline code comments
- Translated project documentation (LEARNING-JOURNEY, CONTRIBUTORS, AI_DISCLOSURE) to English for better accessibility.
- Standardized internal code documentation by converting XML-doc blocks to standard comment format.
- Cleaned up inline comments and removed redundant versioning metadata across the codebase.
- Refactored non-functional text elements to improve readability and maintain a consistent style.
2026-05-11 00:52:15 +02:00
JonKazama-Hellion a37882893e Merge pull request 'chore(deps): pin dependencies' (#12) from renovate/pin-dependencies into main
Security / scan (push) Successful in 11s
Reviewed-on: #12
2026-05-10 20:26:33 +00:00
renovate-bot 702e4ca160 chore(deps): pin dependencies 2026-05-10 20:26:33 +00:00
JonKazama-Hellion 1ebc7b820f Merge pull request 'chore(deps): refresh' (#13) from renovate/lock-file-maintenance into main
Security / scan (push) Successful in 11s
Reviewed-on: #13
2026-05-10 20:24:58 +00:00
renovate-bot 3152312890 chore(deps): refresh
Security / scan (pull_request) Successful in 13s
2026-05-10 18:31:56 +00:00
JonKazama-Hellion 4000bbd199 chore: reformat after editorconfig update
Security / scan (push) Successful in 12s
Updated .editorconfig to set indent_style=space and indent_size=4 for C# files. Reformat all .cs files to apply the new indentation settings. No code logic changes, just whitespace reformatting.
also updated some comments in files in shorter and Precise way. No logic changes, just comment rewording for clarity and conciseness.
2026-05-10 19:54:39 +02:00
120 changed files with 6413 additions and 3702 deletions
@@ -32,10 +32,10 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v6 uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- name: Setup .NET 10 - name: Setup .NET 10
uses: actions/setup-dotnet@v5 uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
with: with:
dotnet-version: 10.0.x dotnet-version: 10.0.x
@@ -101,16 +101,16 @@ jobs:
if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" } if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" }
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(2) } else { $_ } if ($_ -match '^ ') { $_.Substring(4) } else { $_ }
}) -join "`n" }) -join "`n"
$header = "**Hellion Chat $version" $header = "**v$version "
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging." throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1) $nextHdr = $rest.IndexOf("`n`n**v", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
$enBlock = $rest.Substring(0, $nextHdr).TrimEnd() $enBlock = $rest.Substring(0, $nextHdr).TrimEnd()
@@ -120,17 +120,37 @@ jobs:
$enBlock = $rest.TrimEnd() $enBlock = $rest.TrimEnd()
} }
# ---------- Char-Cap-Check (5500 Total auf title + description + footer) ---------- # ---------- Embed-Felder + Per-Field-Caps (Discord-Hard-Limits) ----------
# Discord enforces per-embed-field limits separately from the
# combined-total limit. We split the DE and EN blocks into two
# embeds that share the same release URL so Discord stitches
# them into one visual card. Hard caps per Discord docs:
# description: 4096 per embed
# title: 256 per embed
# footer.text: 2048 per embed
# combined sum across all embeds: 6000
$title = "Hellion Chat $version — $subtitle" $title = "Hellion Chat $version — $subtitle"
$description = "**Deutsch**`n`n$deBody`n`n**English**`n`n$enBlock" $deDesc = "**Deutsch**`n`n$deBody"
$enDesc = "**English**`n`n$enBlock"
$footerText = "Hellion Forge · $versionsnatur" $footerText = "Hellion Forge · $versionsnatur"
$totalChars = $title.Length + $description.Length + $footerText.Length $releaseUrl = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/$tag"
if ($totalChars -gt 5500) {
throw "V6: Total char count $totalChars exceeds 5500 limit. Major-Release detected — please post manually via Bot/Multi-Embed (see forge style §8). Forge-Auto-Announce stays off for this tag."
}
Write-Host "Char-Cap OK: $totalChars / 5500"
# ---------- Embed-Payload bauen ---------- if ($deDesc.Length -gt 4096) {
throw "V6a: DE-Body too long for one embed ($($deDesc.Length) chars, max 4096). Trim .github/forge-posts/$tag.md or post the announcement manually (see forge style §8)."
}
if ($enDesc.Length -gt 4096) {
throw "V6b: EN-Block too long for one embed ($($enDesc.Length) chars, max 4096). Trim the changelog entry in HellionChat/HellionChat.yaml or post manually."
}
$totalChars = $title.Length + $deDesc.Length + $enDesc.Length + $footerText.Length
if ($totalChars -gt 6000) {
throw "V6c: Combined embed chars $totalChars exceed Discord's 6000-total limit. Major-Release detected — post manually via Bot/Multi-Embed (see forge style §8)."
}
Write-Host "Embed-Caps OK: de=$($deDesc.Length)/4096, en=$($enDesc.Length)/4096, total=$totalChars/6000"
# ---------- Embed-Payload bauen (zwei Embeds, gleiche url) ----------
# Sharing the same `url` tells Discord to render both embeds as a
# single contiguous card block. The title sits on the first embed,
# the footer + timestamp on the last so it reads as one post.
$payload = [ordered]@{ $payload = [ordered]@{
username = "Forge Herald" username = "Forge Herald"
avatar_url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png" avatar_url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png"
@@ -142,9 +162,14 @@ jobs:
embeds = @( embeds = @(
[ordered]@{ [ordered]@{
title = $title title = $title
url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/$tag" url = $releaseUrl
color = 12730636 color = 12730636
description = $description description = $deDesc
},
[ordered]@{
url = $releaseUrl
color = 12730636
description = $enDesc
footer = [ordered]@{ text = $footerText } footer = [ordered]@{ text = $footerText }
timestamp = (Get-Date).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ss.fffZ") timestamp = (Get-Date).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ss.fffZ")
} }
@@ -20,16 +20,12 @@ on:
push: push:
tags: tags:
- "v*" - "v*"
# Manual recovery trigger. Use when a tag was pushed but the auto-run # Manual recovery trigger. Use Gitea's "Run workflow" UI and select the
# was missed or failed: `gh workflow run release.yml -f tag=v0.6.1`. # tag (e.g. v1.4.4) from the Ref dropdown - not main. The Validate tag
# The tag input is validated against the same semver regex as the # ref step below hard-fails if a non-tag ref is selected, because the
# auto-trigger before any string interpolation happens. # release-action reads GITHUB_REF directly and rejects anything that
# does not start with refs/tags/.
workflow_dispatch: workflow_dispatch:
inputs:
tag:
description: "Existing tag to (re)release, e.g. v0.6.1"
required: true
type: string
permissions: permissions:
contents: write contents: write
@@ -41,17 +37,24 @@ jobs:
timeout-minutes: 20 timeout-minutes: 20
steps: steps:
# On push:tags, github.ref_name is the tag — checkout default works. # release-action@main reads GITHUB_REF directly (its action.yml
# On workflow_dispatch, ref defaults to the branch the action was # does not declare a tag_name input). Validate up-front so manual
# invoked from; we need to explicitly check out the tag the user # dispatches from a branch ref fail loud here instead of burning
# supplied so the build comes from the tagged commit, not main. # a full build before the final step errors out with "ref X is
# not a tag".
- name: Validate tag ref
run: |
if [[ "${GITHUB_REF}" != refs/tags/v* ]]; then
echo "::error::Release workflow must run on a v*.X.Y tag ref, got ${GITHUB_REF}"
echo "::error::Push a tag, or pick the tag (not main) in the workflow_dispatch Ref dropdown."
exit 1
fi
- name: Checkout - name: Checkout
uses: actions/checkout@v6 uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
ref: ${{ github.event.inputs.tag || github.ref }}
- name: Setup .NET 10 - name: Setup .NET 10
uses: actions/setup-dotnet@v5 uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
with: with:
dotnet-version: 10.0.x dotnet-version: 10.0.x
@@ -89,12 +92,11 @@ jobs:
- name: Generate release body - name: Generate release body
shell: pwsh shell: pwsh
env: env:
# workflow_dispatch carries the user-supplied tag in inputs.tag; # github.ref_name is the tag because Validate tag ref above
# push:tags carries it in github.ref_name. Either way the value # already enforced refs/tags/v*. Read via env: so the value
# is treated as a PowerShell variable (env-var pass), not as # is a PowerShell variable, not inline shell text, and gets
# inline shell text, and validated against the semver regex # re-validated against the semver regex below.
# below before any string interpolation. TAG_NAME: ${{ github.ref_name }}
TAG_NAME: ${{ github.event.inputs.tag || github.ref_name }}
run: | run: |
$tag = $env:TAG_NAME $tag = $env:TAG_NAME
if ($tag -notmatch '^v\d+\.\d+\.\d+$') { if ($tag -notmatch '^v\d+\.\d+\.\d+$') {
@@ -111,20 +113,22 @@ jobs:
# changelog: is the last top-level key in the manifest, so # changelog: is the last top-level key in the manifest, so
# everything after the marker is the literal block. Strip the # everything after the marker is the literal block. Strip the
# 2-space yaml indent from each line. # 4-space yaml indent (prettier convention) from each line.
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(2) } else { $_ } if ($_ -match '^ ') { $_.Substring(4) } else { $_ }
}) -join "`n" }) -join "`n"
$header = "**Hellion Chat $version" # Subblock convention: "**vX.Y.Z — <subtitle> (<date>)**"
# matches verify-changelog-sync.sh and slim-rule grep.
$header = "**v$version "
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release." throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1) $nextHdr = $rest.IndexOf("`n`n**v", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
@@ -152,19 +156,28 @@ jobs:
Write-Host $body Write-Host $body
Write-Host "----------------------------------------" Write-Host "----------------------------------------"
# release-action@main only declares files/title/body/pre_release/
# draft/api_key/insecure as inputs (see its action.yml). It silently
# ignores anything else, including body_path and tag_name. The tag
# itself comes from GITHUB_REF, the body must be passed inline via
# body:, so we re-emit release-body.md as a step output first.
- name: Expose release body for release-action
id: body
shell: bash
run: |
{
echo 'content<<RELEASE_BODY_EOF'
cat release-body.md
echo 'RELEASE_BODY_EOF'
} >> "$GITHUB_OUTPUT"
# Gitea-native release action. Creates the release if the tag has no # Gitea-native release action. Creates the release if the tag has no
# release yet, or updates the existing one. body_path provides the # release yet, or updates the existing one with latest.zip attached
# generated release body, files attaches latest.zip. The auto-injected # and the generated body. The auto-injected GITHUB_TOKEN on Gitea
# GITHUB_TOKEN on Gitea Actions has Gitea-API scope and is sufficient # Actions has Gitea-API scope and is sufficient for release write.
# for release write.
- name: Attach to Gitea release - name: Attach to Gitea release
uses: https://gitea.com/actions/release-action@main uses: https://gitea.com/actions/release-action@main
with: with:
# Explicit tag_name so the action targets the correct release in
# both push:tags (auto) and workflow_dispatch (manual recovery)
# modes. Without this, dispatch runs would default to the branch
# ref (main) and fail to find the release.
tag_name: ${{ github.event.inputs.tag || github.ref_name }}
files: ${{ steps.locate.outputs.path }} files: ${{ steps.locate.outputs.path }}
body_path: release-body.md body: ${{ steps.body.outputs.content }}
api_key: ${{ secrets.GITHUB_TOKEN }} api_key: ${{ secrets.GITHUB_TOKEN }}
+36
View File
@@ -0,0 +1,36 @@
---
subtitle: Symbol-Picker und Tell-History Fix
versionsnatur: Feature-Patch + Hotfix
---
- Symbol-Picker im Chat-Eingang: ein kleiner Smile-Button links neben
dem Kanal-Indikator öffnet ein Popup mit zwei Tabs. Der erste listet
alle 161 FFXIV-PUA-Glyphen (Dalamuds SeIconChar); der zweite trägt
97 verifizierte BMP-Symbole (Latin-Marken, Währungen, das ganze
griechische Alphabet, Geometrie, Spielkarten, Noten) — jedes davon
über `/echo` und `/say` in einer vierrundigen Whitelist-Probe
durchgereicht, damit der Channel-Render dem entspricht, was der
Picker anzeigt. Klick fügt das Symbol an der Cursor-Position ein,
Multi-Insert lässt das Popup offen, eine Recent-Used-Leiste zeigt
die letzten sechzehn Picks über beide Tabs. Toggle in Settings →
Chat → Nachrichten-Verhalten, Default an.
- Verlauf in angepinnten Tell-Tabs lädt wieder vollständig: ein
versteckter 500-Zeilen-Scan-Cap in PreloadHistory hat das
User-Setting `AutoTellTabsHistoryPreload` überschrieben, wodurch
weniger-frequente Tell-Partner ihren Backlog verloren haben sobald
die Scan-Schicht mit anderen Chat-Partnern voll lief. Cap ist raus,
der Index auf `(Receiver, Date)` hält die Query schnell.
- Slash-Command-Teardown: /hellion, /hellionView, /hellionDebugger
(und im Debug-Build /hellionSeString) sind als private Felder
gecached. Plugin-Dispose detached die echte Registrierung, statt
mit identischen Args neu zu registrieren — schließt eine latente
Wartungs-Falle aus v1.4.9.
- v1.4.x-Polish-Sweep endet hier. Der ImGuiListClipper-Refactor von
der v1.4.10-Reserve-Liste wurde gecancelt, nachdem der Cross-
Plattform-Smoke gezeigt hat dass das Scroll-Gummi ein Wine/Linux-
Quirk ist — Windows-User haben es nie gesehen. Spike dafür kommt in
einem späteren Patch. Nächster Major-Cycle ist v1.5.0 mit der
DI-Container-Adoption (`Microsoft.Extensions.Hosting` +
`ILogger<T>`) nach dem Lightless-Vorbild.
- Migration v17 unverändert: kein Schema-Bump, kein
Config-Migrations-Aufwand.
+34
View File
@@ -0,0 +1,34 @@
---
subtitle: Threading- und IPC-Sicherheits-Politur
versionsnatur: Wartung und Robustheit
---
**Hellion Chat 1.4.4 — Threading- und IPC-Sicherheits-Politur**
Fünfter Sub-Patch der v1.4.x Polish-Sweep-Serie. Threading-Annahmen werden explizit pro Methode dokumentiert, ein
Hot-Path-Lock im Auto-Tell-Tab-Counter fällt weg, IPC-Cleanup wird sichtbar wenn er fehlschlägt und der Privacy-Filter
spricht jetzt bei unbekannten ChatTypes.
- **AutoTellTabsService Hot-Path-Lock entfernt.** `ActiveTempTabCount` hat bisher pro Render-Frame ein LINQ-Count unter
einem Lock gemacht. Jetzt läuft das über einen Interlocked-Counter der parallel zur Tabs-Liste mitgeführt wird,
inklusive Resync-Hook für den Snapshot-Restore-Pfad in `SaveConfig`. Plus Pure-Helper-Test-Mirror in der Build-Suite
damit die Atomicity-Semantik nicht versehentlich wegrefactored wird
- **HonorificService selbst-dokumentierende Threading-Banner.** Statt eines Block-Comments am Klassen-Ende hat jede
IPC-Callback-Methode jetzt einen 1-Zeilen-Banner darüber, der den Thread-Kontext direkt am Call-Site benennt
(framework only, framework scheduled, any). Mehr Hilfe für künftige Reviews als ein abstraktes Threading-Kapitel
- **Unsubscribe-Failure ist jetzt sichtbar.** `TryUnsubscribe` hat ein Honorific-Unsubscribe-Failure bisher als Debug
geloggt, was bei Standard-Loglevel verschluckt wurde. Eine geleakte Subscription kann den Service über Plugin-Reloads
hinweg leben lassen, also läuft der Log jetzt auf Warning
- **AutoTranslate-Warmup blockiert den Plugin-Unload nicht mehr.** Der Cache-Warmup-Thread war ohne `IsBackground=true`
unterwegs, was den Unload um 100-300 ms verzögern konnte. Pattern-Match zu MessageManager und RetentionSweep (beide
seit v1.4.0)
- **Privacy-Filter loggt unbekannte ChatTypes.** Wenn FFXIV durch einen Patch einen neuen ChatType einführt der weder in
der Whitelist noch in den Defaults steht, wird er bisher silent durch den Failsafe geleitet. Jetzt loggt der Filter
einmalig pro Runtime eine Warning mit dem Type und dem Failsafe-Wert. Dedup über ein NonSerialized-HashSet, also kein
Log-Spam
- **Default-Flip für neue Installationen.** `PrivacyPersistUnknownChannels` startet bei neuen Configs jetzt auf `true`,
damit ein Patch-bedingt neuer ChatType nicht stillschweigend gedroppt wird bevor der User entscheiden kann. Bestehende
Configs behalten ihre Wahl, weil der Deserializer den Initializer überschreibt. Keine Migration, kein Schema-Bump
Keine User-sichtbaren Funktions-Änderungen außer dem Default-Flip für neue Installationen. Settings, Themes, Tabs und
das Privacy-Verhalten für Bestand bleiben unangetastet.
+28
View File
@@ -0,0 +1,28 @@
---
subtitle: UX und Robustheit
versionsnatur: UX-Polish-Cycle
---
**Hellion Chat 1.4.5 — UX und Robustheit**
Sechster Sub-Patch der v1.4.x Polish-Sweep-Serie. Render-Fehler im Chat-Fenster werden jetzt sichtbar, der
First-Run-Wizard hat eine explizite Cancel-Schaltfläche, der Eingabe-Verlauf bleibt nicht mehr über Plugin-Reloads
hinweg liegen, und die Statusleiste klippt in schmalen Fenstern nicht mehr.
- **Fehler-Benachrichtigung im Chat-Fenster.** Wenn ein Render-Fehler in `DrawChatLog` auftritt, zeigt das Plugin jetzt
eine einmalige Warning-Notification mit Verweis aufs `/xllog`, statt das Fenster stillschweigend leer zu lassen. Der
Stack-Trace selbst geht weiter via `Plugin.Log.Error` ins Logfile. De-Dup über Per-Session-Bool, damit ein
wiederkehrender Fehler die Notification-Stack nicht pro Frame neu vollkippt
- **First-Run-Wizard trennt Accept und Close.** `OnClose` setzt nicht mehr stillschweigend `FirstRunCompleted=true`,
also lässt das X den Wizard schwebend zurück und er kommt beim nächsten Plugin-Reload wieder. Eine neue „Später —
Defaults behalten"-Schaltfläche im Footer ist der explizite Weg, ohne Profil-Auswahl rauszukommen. Strings bilingual
EN+DE plus Tooltip
- **Eingabe-Verlauf wird beim Plugin-Reload geleert.** `InputHistoryService.Reset` hängt jetzt in `Plugin.DisposeAsync`
neben den anderen Pure-Memory-Cleanups, damit der statische Zustand aus der vorigen Session den nächsten Load nicht
mehr erbt
- **Statusleiste klippt nicht mehr.** Der rechtsbündige Versions-Slot wird ausgeblendet wenn die Chat-Window-Breite
abzüglich Versions-Text unter 200 px fällt — vorher überlappte er die vier linken Slots. Ab ausreichender Breite
taucht der Slot wieder auf
- **Intern:** `FontManager` fällt auf System-Font zurück wenn die eingebettete Hellion-Font-Resource fehlt
(Broken-csproj-Pfad, nie ein Produktions-Build), plus expliziter Session-Only-Invariant-Kommentar für Auto-Tell-Tabs
in `Plugin.cs:167-168` mit einem TempTabCounter-Init-Pin in der Build-Suite. Kein Schema-Bump, keine Migration
+33
View File
@@ -0,0 +1,33 @@
---
subtitle: Code Hygiene and Refactor
versionsnatur: Maintenance-Cycle
---
Wartungs-Patch ohne User-sichtbare Änderungen. Saubere Code-Basis als Vorbereitung auf das v1.4.7-Backlog-Cleanup, plus
zwei geerbte Bugfixes aus dem ChatTwo-Upstream `f35b7d3`.
- **preflight.sh härter**: csharpier-Reflow-Check (Block E) und markdownlint (Block F) laufen jetzt im Pre-Push-Gate,
statt erst beim Pre-Merge-Review aufzufallen.
- **FontManager-Fallback robuster**: Atlas-Toolkit-Throws aus kaputten Font-Configs (IO, InvalidOperation,
ArgumentException) fallen jetzt zuverlässig auf NotoSansCjkRegular, statt den Atlas-Build mitzureißen. Der
Exception-Typ wird im Log mitgegeben für die Diagnose.
- **URL-Validation beim Plugin-Load**: BrandingLinks (5 URLs) und IntegrationLinks (2 URLs) werden via
`[ModuleInitializer]` geprüft. Ein Tippfehler bei einer künftigen URL-Rotation wirft jetzt sofort beim Plugin-Load,
statt still beim Klick zu scheitern.
- **Cherry-Pick aus ChatTwo `f35b7d3`** — Memory-Leak in `Chat.SetChannel`: der native `Utf8String` wird jetzt auch dann
freigegeben, wenn der Linkshell-Check den Channel ablehnt (vorher gefangen im early-return).
- **Cherry-Pick aus ChatTwo `f35b7d3`** — `Tab.Clone()` Deep-cloned jetzt `UsedChannel` und `TellTarget`. Vorher
Reference-Share-Bug: PopOut- und Temp-Tabs mutierten sich gegenseitig.
- **Aktive-Tab-Underline pixel-perfect bei DPI-Scaling**: Die Underline-Pill skaliert jetzt mit
`ImGuiHelpers.GlobalScale` und rundet die DrawList-Koordinaten auf physische Pixel. Kein Sub-Pixel-Blur mehr auf
125/150%-Setups.
- **IconButton-Width-Fix**: der manuelle `width - 2 * CellPadding.X`-Subtract verlor den HUD-Scale (Padding skaliert,
der raw int nicht). Gemessene Breite läuft jetzt unverändert durch.
- **Test-Isolation für MessageStore**: `Dalamud.Utility.Util`-Surface (IsWine, OpenLink) läuft jetzt durch eine
`IPlatformUtil`-Indirektion. MessageStores `IsWine`-Probe ist isoliert testbar in der Build-Suite. Plus:
HellionStyle-ChildBgAlpha als Pure-Helper extrahiert, Plugin.SaveConfig kopiert nur Session-Tabs statt der ganzen
Tab-Liste, SettingsOverview cached den DrawList einmal pro Frame.
- **Built-in-Theme-Roster**: Crystal Nocturne (Royal Sapphire + Electric Magenta auf Obsidian, von CRYSTALLITE) ersetzt
Moonlit Bloom. User mit Moonlit Bloom als aktivem Theme fallen beim ersten Plugin-Load auf Hellion Arctic zurück.
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
+29
View File
@@ -0,0 +1,29 @@
---
subtitle: Backlog Cleanup and Mid-Features
versionsnatur: Mid-Feature-Patch
---
Achter Sub-Patch der v1.4.x Polish-Sweep-Serie. Erstes User-sichtbares Feature-Bundle seit v1.4.5 — angepinnte Tell-Tabs
die Relog überleben, opt-in Honorific-Glow, plus eine konfigurierbare Sidebar.
- **TempTell anpinnen**: Rechtsklick auf einen TempTell-Tab in der Sidebar → „Tab anpinnen". Angepinnte Tabs überleben
Plugin-Reload und Char-Logout, behalten ihre Konversations-Historie (wird beim Rehydrate aus dem MessageStore
nachgeladen) und bleiben an die gleiche /tell-Person gebunden. Hard-Cap 5 angepinnte Tabs in einem separaten Pool —
die normalen Auto-Tell-Tabs (15er Cap) sind davon entkoppelt, Gesamt-Decke 20. Die Sidebar gruppiert angepinnte Tabs
in einer eigenen „Angepinnt"-Sektion mit eigenem Trenner.
- **Honorific Glow-Outline**: rendert jetzt eine 8-Richtungs-DrawList-Outline wenn der Honorific-Titel eine Glow-Farbe
trägt. Opt-in via **Settings → Integrationen → Glow-Outline rendern (Honorific)** (Default OFF). Gradient (Color3 /
GradientColourSet / Wave / Pulse) wird geparst und im DTO weitergereicht, rendert aktuell aber statisch als
Primärfarbe — der volle Gradient-Port (Animations-Algorithmus + Pride-Palette) kommt als eigener Cycle nach.
- **Sidebar-Breite konfigurierbar**: in **Theme & Layout** ein Slider 44160 px. Default bleibt 44 px (icon-only), aber
breiter machen damit Sektion-Header wie „Aktive Tells (3)" oder „Angepinnt (2)" nicht abgeschnitten werden.
- **Settings-Save Channel-Fix**: ein Save mit aktivem Party- oder Linkshell-Tab konnte den Chat-Input zurück auf
`/tell <angepinnte Person>` springen lassen. `Configuration.UpdateFrom` bewahrt jetzt den Runtime-`CurrentChannel`
über den persistent-Tab-Merge hinweg, und `TabSwitched` deep-cloned den Seed-Channel statt sich den `UsedChannel` mit
dem vorigen Tab zu teilen.
- **Internal**: `IPluginLogProxy`-Indirektion vor Dalamud's `IPluginLog` über alle ~91 `Plugin.Log`-Call-Sites. Damit
läuft `MessageStore.Migrate0` voll-isoliert in xUnit (F12.1-Lücke aus v1.4.6 geschlossen). Plus: TempTab-Counter als
abgeleitete Property statt gecachtes Interlocked-Feld — die neuen Pin/Unpin-Übergänge sind Cold-Path, kein
Lock-Free-Vorteil mehr. Migration v16 → v17 ist rein additiv (neues `Tab.IsPinned`-Bool, Default false).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
+21
View File
@@ -0,0 +1,21 @@
---
subtitle: Hook-Layer und Polish-Quick-Wins
versionsnatur: Polish-Patch
---
- DbViewer Volltext-Suche: optionaler FTS5-Index über die ganze Chat-Historie.
Wird beim ersten v1.4.8-Start asynchron im Hintergrund gebaut, Progress als
Toast. Lokale Page-Suche bleibt Default. Such-Eingaben werden als exakte
Wortfolge gematcht; mehrere Wörter werden nur gefunden, wenn sie zusammen
und in der Reihenfolge stehen. Wer rohe FTS5-MATCH-Syntax nutzen will, setzt
eigene Anführungszeichen um den Suchbegriff.
- Custom-Theme-Files laden sich beim Speichern automatisch neu, wenn das Theme
aktiv ist. Kein Picker-Klick mehr nötig.
- Retention-Sweep blockt nicht mehr den Framework-Thread. Der Mini-Hitch von
~194ms pro Sweep ist weg.
- Statusleiste rendert sauber bei Windows-Skalierung über 100%.
- Receive-Suppressed-Tells-Routing wurde in diesem Cycle untersucht und auf
v1.5.x verschoben: wenn andere Plugins Tells via CheckMessageHandled
unterdrücken, überspringt FFXIVs Chat-Pipeline den RaptureLogModule-Resolver
und HellionChats Tab-Routing verliert den Tell-Partner. Der Fix liegt
architektonisch neben dem geplanten Ad-Block-Hook-Layer und kommt dort mit.
+37
View File
@@ -0,0 +1,37 @@
---
subtitle: Plugin-Load Render Polish
versionsnatur: Performance-Patch
---
- First-Frame-HITCH unter 100 ms: der erste Render-Frame des Plugins liegt
jetzt bei ~76 ms Median (vorher ~127 ms), die Dalamud-Warnung
„UiBuilder(Hellion Chat) > 100ms" beim Plugin-Start ist damit weg.
Erreicht durch das Verlagern von sechs nicht-essentiellen Render-
Sektionen (Statusleiste, Kanalname-Chunks, Fenster-Bounds-Check,
Hinweis-Banner, Autocomplete, Input-Preview) auf den zweiten Frame.
Bei 60 fps sieht man die deferred-Sektionen ~17 ms später, was im
Atlas-Build-Fenster nach einem Reload unsichtbar bleibt.
- Slash-Commands zentral registriert: /hellion, /hellionView,
/hellionSeString und /hellionDebugger werden jetzt im Plugin-Load zentral
registriert statt erst beim ersten Öffnen ihres Ziel-Fensters. Heißt: die
Befehle funktionieren ab dem ersten Tick, auch wenn das jeweilige Fenster
nie geöffnet wurde. Der „Einstellungen"-Button im Plugin-Manager hängt am
selben Pfad.
- Plugin-Load-Diagnose-Logs als Tripwire: die Profiling-Logs für
MessageStore.Connect, MessageStore.Migrate, FilterAllTabs und den
Auto-Translate-Warmup bleiben auf Information-Level eingeschaltet. Falls
eine zukünftige Änderung die Lade-Zeit wieder über 100 ms drückt, taucht
der Mehrverbrauch direkt im /xllog auf, ohne dass jemand erst den
Debug-Filter einschalten muss.
- ChatTwo-IPC-Kompatibilitäts-Layer: HellionChat spiegelt jetzt die
komplette ChatTwo-IPC-Surface (`GetChatInputState`,
`ChatInputStateChanged`, `Register`, `Unregister`, `Available`,
`Invoke`) zusätzlich zu unseren eigenen `HellionChat.*`-Gates unter
dem `ChatTwo.*`-Namensraum. Drittseitige Integrationen die nur auf
ChatTwo's IPC reagieren, etwa die Kontextmenü-Hooks von Artisan und
AllaganTools, funktionieren damit weiter ohne Code-Änderung auf
ihrer Seite. Die Conflict-Detection blockiert das parallele Laden
von ChatTwo, daher kein Namensraum-Konflikt im Live-Betrieb.
- Migration v17 unverändert: kein Schema-Bump, kein Config-Migrations-
Aufwand. Nach dem Update läuft das Plugin gegen die bestehende
v17-Datenbank weiter.
+37
View File
@@ -0,0 +1,37 @@
---
subtitle: DI Foundation und Service-Refactor
versionsnatur: Architektur-Cycle
---
- **Architektur-Umbau ohne User-spürbare Verhaltens-Änderung:** der
Plugin-Bootstrap wechselt auf einen Generic-Host DI-Container
(`Microsoft.Extensions.Hosting` + `IServiceCollection`) nach dem
Lightless-Sync-Muster. 18 Service-Klassen wandern von einem
statischen `Plugin.LogProxy`-Locator auf typisierte
`ILogger<T>`-Constructor-Injection. `DalamudLogger` brückt
`Microsoft.Extensions.Logging` über auf Dalamuds `IPluginLog`
im xllog erscheinen jetzt Service-spezifische Spalten wie
`[ MessageManager]` und `[Honori...ervice]`.
- **Plugin.LogProxy bleibt für die acht Buckets erhalten,** die
Constructor-Injection nicht erreicht: Static-Helper (EmoteCache,
AutoTranslate, MemoryUtil, WrapperUtil), Dalamud-Reflektion
(Configuration), Data-Class mit Massen-Instanziierung (Message)
und Instanz-Klassen die nur aus Static-Methods loggen (FontManager,
eine GameFunctions-Stelle).
- **Performance bestätigt durch Cross-Plugin-Baseline:** HellionChat
First-Frame-HITCH 77 ms Median, Chat 2 v1.40.2 74 ms Median — kein
DI-Penalty gegenüber dem Upstream-Fork-Origin. Lightless und
XIVInstantMessenger liegen bei ~7 ms weil sie ihren FontAtlas-Build
deferren; das wird das v1.5.1-Item.
- **User-sichtbarer Bug-Fix nebenbei:** Slash-Command-Einfügen in das
Chat-Eingabefeld (Friend-List "/tell"-Action plus Plugin-Inserts
von Artisan, AllaganTools und ähnlichen) ersetzt jetzt den
vorhandenen Input, statt anzukonkatenieren. Cherry-Pick aus ChatTwo
upstream `ee7768ac` mit Namespace-Anpassung.
- **Foundation für die Plugin-Integrations-Wave:** v1.5.7-11
(Context-Menu, NotificationMaster, Moodles, ExtraChat, XIVIM
Quick-DM) werden ab jetzt strukturell handhabbar — neue Services
sind ein `services.AddSingleton<T>` plus ein paar Factory-Lambda-
Zeilen, kein Plugin.cs-Anflanschen mehr.
- Migration v17 unverändert: kein Schema-Bump, kein
Config-Migrations-Aufwand.
+4
View File
@@ -384,3 +384,7 @@ ChatTwo.Tests
TestResults TestResults
*.db-shm *.db-shm
*.db-wal *.db-wal
# Claude Code projekt-spezifisches Setup (lokal, nicht committed)
/.claude/
/CLAUDE.md
+2
View File
@@ -1,7 +1,9 @@
{ {
"MD007": { "indent": 4 }, "MD007": { "indent": 4 },
"MD013": false, "MD013": false,
"MD024": { "siblings_only": true },
"MD029": false, "MD029": false,
"MD033": false, "MD033": false,
"MD036": false,
"MD041": false "MD041": false
} }
+191 -100
View File
@@ -1,49 +1,57 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Threading;
using Dalamud.Game.Text; using Dalamud.Game.Text;
using Dalamud.Game.Text.SeStringHandling; using Dalamud.Game.Text.SeStringHandling;
using Dalamud.Interface.ImGuiNotification;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.GameFunctions.Types; using HellionChat.GameFunctions.Types;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
namespace HellionChat; namespace HellionChat;
// Hellion Chat — Auto-Tell-Tabs. // Auto-Tell-Tabs: spawns session-only tabs per /tell partner.
// // Subscribes to MessageManager.MessageProcessed and ClientState.Logout.
// Spawns a session-only tab per /tell partner so a club greeter can track
// multiple parallel conversations without losing context. Subscribes to
// MessageManager.MessageProcessed for live tells and to ClientState.Logout
// for the cleanup pass; everything else hangs off these two entry points.
//
// See spec: Hellion Chat Auto-Tell-Tabs Spec (Obsidian vault).
internal sealed class AutoTellTabsService : IDisposable internal sealed class AutoTellTabsService : IDisposable
{ {
private readonly Plugin _plugin; private readonly Plugin _plugin;
private readonly MessageManager _messageManager; private readonly MessageManager _messageManager;
private readonly MessageStore _store; private readonly MessageStore _store;
private readonly ILogger<AutoTellTabsService> _logger;
private readonly object _tempTabsLock = new(); private readonly object _tempTabsLock = new();
// Hard cap on pinned TempTabs so the sidebar doesn't inflate over years
// of usage. Separate pool from AutoTellTabsLimit (15) — pinned tabs live
// in their own bucket. A configurable cap is a vault-backlog anchor for
// a later cycle if tester feedback demands it.
internal const int MaxPinnedTempTabs = 5;
private bool _initialized; private bool _initialized;
internal AutoTellTabsService(Plugin plugin, MessageManager messageManager, MessageStore store) internal AutoTellTabsService(
Plugin plugin,
MessageManager messageManager,
MessageStore store,
ILogger<AutoTellTabsService> logger
)
{ {
_plugin = plugin; _plugin = plugin;
_messageManager = messageManager; _messageManager = messageManager;
_store = store; _store = store;
_logger = logger;
} }
internal int ActiveTempTabCount // Derived from the tab list on read. Pin/Unpin/Promote/Logout simply
{ // mutate IsPinned or remove tabs — the count adapts automatically.
get // Replaces the F2.1 Interlocked counter because the new pin-state
{ // transitions are cold-path and don't need lock-free reads.
lock (_tempTabsLock) internal int ActiveTempTabCount =>
{ Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInUnpinnedPool);
return Plugin.Config.Tabs.Count(t => t.IsTempTab);
} internal int PinnedTempTabCount => Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInPinnedPool);
}
}
internal void Initialize() internal void Initialize()
{ {
@@ -52,11 +60,53 @@ internal sealed class AutoTellTabsService : IDisposable
return; return;
} }
// Pinned tabs come out of the JSON with TellTarget set but
// CurrentChannel reset (NonSerialized). Without re-seeding, the chat
// input has no tell-target on the active pinned tab, and the
// game-side channel hook only repaints CurrentChannel once the user
// triggers a /tell or channel switch.
RehydratePinnedTabs();
_messageManager.MessageProcessed += HandleTell; _messageManager.MessageProcessed += HandleTell;
Plugin.ClientState.Logout += OnLogout; Plugin.ClientState.Logout += OnLogout;
_initialized = true; _initialized = true;
} }
private void RehydratePinnedTabs()
{
var pinned = Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInPinnedPool);
_logger.LogDebug($"[Pin] Rehydrate scan: {pinned} pinned tab(s) found");
foreach (var tab in Plugin.Config.Tabs)
{
if (!TabLifecycleHelpers.IsInPinnedPool(tab))
continue;
if (tab.TellTarget is null || !tab.TellTarget.IsSet())
{
_logger.LogWarning(
$"[Pin] Pinned tab '{tab.Name}' has no usable TellTarget "
+ $"(Name={tab.TellTarget?.Name ?? "<null>"} World={tab.TellTarget?.World ?? 0}). "
+ "Chat input on this tab will be empty until the partner sends a tell or you /tell manually."
);
continue;
}
tab.Channel ??= InputChannel.Tell;
tab.CurrentChannel.Channel = InputChannel.Tell;
tab.CurrentChannel.TellTarget = tab.TellTarget.Clone();
// MessageList is NonSerialized so pinned tabs come back empty.
// Preload the same history window the spawn path uses so the user
// sees the recent conversation, not a blank tab.
PreloadHistory(tab, tab.TellTarget.Name, tab.TellTarget.World, Guid.Empty);
_logger.LogDebug(
$"[Pin] Rehydrated '{tab.Name}' -> Tell target {tab.TellTarget.Name}@{tab.TellTarget.World}"
);
}
}
public void Dispose() public void Dispose()
{ {
if (!_initialized) if (!_initialized)
@@ -87,11 +137,8 @@ internal sealed class AutoTellTabsService : IDisposable
var partner = ExtractTellPartner(message); var partner = ExtractTellPartner(message);
if (partner == null) if (partner == null)
{ {
// Real message without a player payload — e.g. GM tells, which // Diagnostics: helps detect regressions (FFXIV payload changes, new edge cases)
// we deliberately skip. The diagnostics make future regressions _logger.LogWarning(
// (FFXIV changing tell payload shape, new edge cases) findable
// without having to crank up debug logging at the source.
Plugin.Log.Warning(
$"[AutoTellTabs] Could not extract tell partner. type={message.Code.Type}, " $"[AutoTellTabs] Could not extract tell partner. type={message.Code.Type}, "
+ $"senderChunks={message.Sender.Count}, contentChunks={message.Content.Count}, " + $"senderChunks={message.Sender.Count}, contentChunks={message.Content.Count}, "
+ $"senderSourcePayloads={message.SenderSource?.Payloads?.Count ?? 0}, " + $"senderSourcePayloads={message.SenderSource?.Payloads?.Count ?? 0}, "
@@ -105,9 +152,23 @@ internal sealed class AutoTellTabsService : IDisposable
var existing = FindTempTab(partner.Value.Name, partner.Value.World); var existing = FindTempTab(partner.Value.Name, partner.Value.World);
if (existing != null) if (existing != null)
{ {
// Tab already exists; Tab.Matches has already routed this // Already routed via MessageManager pipeline. Repair the
// message via the MessageManager pipeline (see Task 2 sender // tell-target if the fallback hit a pinned tab whose
// filter). // TellTarget didn't survive a previous round-trip — keeps
// FindTempTab fast on the next message.
if (
existing.IsPinned
&& (existing.TellTarget is null || !existing.TellTarget.IsSet())
)
{
existing.TellTarget = new TellTarget(
partner.Value.Name,
partner.Value.World,
0,
TellReason.Direct
);
_plugin.SaveConfig();
}
return; return;
} }
@@ -124,10 +185,7 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
if (message.Code.Type == ChatType.TellIncoming) if (message.Code.Type == ChatType.TellIncoming)
{ {
// Incoming tell: the sender is the conversation partner. The // Sender is the partner; check chunks first, then raw SeString as fallback
// PlayerPayload normally rides on a chunk's Link slot, but for
// some tell types FFXIV only puts it in the raw SeString —
// fall back to that before giving up.
var fromSender = var fromSender =
ChunkUtil.TryGetPlayerPayload(message.Sender) ChunkUtil.TryGetPlayerPayload(message.Sender)
?? ChunkUtil.TryGetPlayerPayload(message.SenderSource); ?? ChunkUtil.TryGetPlayerPayload(message.SenderSource);
@@ -138,10 +196,7 @@ internal sealed class AutoTellTabsService : IDisposable
return null; return null;
} }
// Outgoing tell: the local player is the sender, the partner shows // Outgoing tell: check content first, then channels's TellTarget as fallback
// up either as a payload in the content (for tells typed via the
// Chat 2 input bar) or as the channel's tracked tell target (set by
// the SetContextTellTarget game hook). Same SeString fallback.
var fromContent = var fromContent =
ChunkUtil.TryGetPlayerPayload(message.Content) ChunkUtil.TryGetPlayerPayload(message.Content)
?? ChunkUtil.TryGetPlayerPayload(message.ContentSource) ?? ChunkUtil.TryGetPlayerPayload(message.ContentSource)
@@ -163,25 +218,35 @@ internal sealed class AutoTellTabsService : IDisposable
return null; return null;
} }
private Tab? FindTempTab(string name, uint world) private static Tab? FindTempTab(string name, uint world)
{ {
return Plugin.Config.Tabs.FirstOrDefault(t => var byTarget = Plugin.Config.Tabs.FirstOrDefault(t =>
t.IsTempTab t.IsTempTab
&& t.TellTarget != null && t.TellTarget != null
&& string.Equals(t.TellTarget.Name, name, StringComparison.OrdinalIgnoreCase) && string.Equals(t.TellTarget.Name, name, StringComparison.OrdinalIgnoreCase)
&& t.TellTarget.World == world && t.TellTarget.World == world
); );
if (byTarget != null)
return byTarget;
// Fallback: match by tab name. Pinned tabs are named via
// FormatTabName(player, world) at spawn time, so the name is a
// stable secondary key when TellTarget didn't survive a save/load
// (older configs from a renamed pin, malformed migrations, etc.).
var expectedName = FormatTabName(name, world);
return Plugin.Config.Tabs.FirstOrDefault(t =>
t.IsTempTab && string.Equals(t.Name, expectedName, StringComparison.OrdinalIgnoreCase)
);
} }
private void DropOldestTempTab() internal void DropOldestTempTab()
{ {
// Greeted tabs are dropped before un-greeted ones (the user said // Pinned tabs live in their own bucket (MaxPinnedTempTabs) and are
// "I'm done with that conversation"), and within each bucket we // never drop candidates. They leave the bucket only via Unpin or
// pick the oldest LastActivity. This protects active conversations // PromoteToPermanent.
// and unfinished greetings while still freeing up a slot.
var victim = Plugin var victim = Plugin
.Config.Tabs.Select((tab, idx) => (Tab: tab, Index: idx)) .Config.Tabs.Select((tab, idx) => (Tab: tab, Index: idx))
.Where(t => t.Tab.IsTempTab) .Where(t => TabLifecycleHelpers.IsInUnpinnedPool(t.Tab))
.OrderByDescending(t => t.Tab.IsGreeted) .OrderByDescending(t => t.Tab.IsGreeted)
.ThenBy(t => t.Tab.LastActivity) .ThenBy(t => t.Tab.LastActivity)
.FirstOrDefault(); .FirstOrDefault();
@@ -191,12 +256,7 @@ internal sealed class AutoTellTabsService : IDisposable
return; return;
} }
// v0.6.1 — if the victim is currently popped out, tear down the // Clean up pop-out window if tab is popped out
// matching Popout window first. Otherwise the window stays in
// PopOutWindows + WindowSystem and renders empty / re-spawns on the
// next AddPopOutsToDraw tick. Latent since pop-outs were introduced;
// becomes visible with AutoTellTabsOpenAsPopout where dropping a
// popped tab is now a routine code path.
if (victim.Tab.PopOut) if (victim.Tab.PopOut)
{ {
var popout = _plugin.ChatLogWindow.ActivePopouts.FirstOrDefault(p => var popout = _plugin.ChatLogWindow.ActivePopouts.FirstOrDefault(p =>
@@ -210,8 +270,7 @@ internal sealed class AutoTellTabsService : IDisposable
Plugin.Config.Tabs.RemoveAt(victim.Index); Plugin.Config.Tabs.RemoveAt(victim.Index);
// Re-anchor the active tab so the user does not silently end up on // Re-anchor active tab to avoid silent switch when tab is dropped
// a different conversation when their tab gets dropped or shifted.
if (victim.Index <= _plugin.LastTab) if (victim.Index <= _plugin.LastTab)
{ {
_plugin.WantedTab = 0; _plugin.WantedTab = 0;
@@ -222,22 +281,12 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
var tab = BuildTempTab(partner.Name, partner.World); var tab = BuildTempTab(partner.Name, partner.World);
// Preload first so the tab opens with chronological history above // Preload history: chronological order with current message already persisted
// the current message — and so a slow DB query never causes a
// visible "empty tab, then history pops in" effect on screen.
// The current message is already persisted in the store by the
// time MessageProcessed fires (see MessageManager.cs: UpsertMessage
// runs before the event), so we have to exclude it explicitly to
// avoid the separator landing below the live tell.
PreloadHistory(tab, partner.Name, partner.World, currentMessage.Id); PreloadHistory(tab, partner.Name, partner.World, currentMessage.Id);
tab.AddMessage(currentMessage, unread: true); tab.AddMessage(currentMessage, unread: true);
// Hellion Chat v0.6.1 — opt-in: open new /tell tabs directly as a // Open as pop-out if configured (set before Tabs.Add for next render-tick)
// pop-out window. Set BEFORE Tabs.Add so the next render-tick's
// AddPopOutsToDraw() sees PopOut=true and spawns the Popout window
// alongside the tab going into the list. No SaveConfig() because
// auto-tell tabs are IsTempTab (session-only, never persisted).
if (Plugin.Config.AutoTellTabsOpenAsPopout) if (Plugin.Config.AutoTellTabsOpenAsPopout)
{ {
tab.PopOut = true; tab.PopOut = true;
@@ -272,9 +321,7 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
return $"{playerName}@{worldRow.Name}"; return $"{playerName}@{worldRow.Name}";
} }
// World sheet lookup miss is rare (only for FFXIV worlds Dalamud has // Fallback if world lookup misses (rare; only for unseen worlds)
// not yet seen). Fall back to the raw RowId so the user still has a
// unique, readable label.
return $"{playerName}@World{worldRowId}"; return $"{playerName}@World{worldRowId}";
} }
@@ -288,9 +335,7 @@ internal sealed class AutoTellTabsService : IDisposable
try try
{ {
// Pull one extra row because the live tell that triggered this // Pull one extra row: current message is already in store and would eat a preload slot
// spawn is already in the store and would otherwise eat one of
// the user's preload-budget slots.
var history = _store.GetTellHistoryWithSender( var history = _store.GetTellHistoryWithSender(
_messageManager.CurrentContentId, _messageManager.CurrentContentId,
senderName, senderName,
@@ -305,23 +350,17 @@ internal sealed class AutoTellTabsService : IDisposable
if (historicMessages.Count == 0) if (historicMessages.Count == 0)
{ {
// No prior tells with this player — leave the tab to start // No prior tells; leave tab empty to avoid orphaned "history loaded" marker
// empty so the user does not see a "history loaded" marker
// sitting alone above the very first message.
return; return;
} }
// The history list is already oldest-first, so a plain AddPrune // History is oldest-first; add in order for chronological display
// loop produces the chronological order the user expects to see
// when the tab opens.
foreach (var message in historicMessages) foreach (var message in historicMessages)
{ {
tab.Messages.AddPrune(message, MessageManager.MessageDisplayLimit); tab.Messages.AddPrune(message, MessageManager.MessageDisplayLimit);
} }
// Visible separator between the loaded history and the live // Separator between history and live tell (sorts after history but before current)
// tell that triggered this spawn. Goes in last so it sorts
// after the historical messages but before the current one.
tab.Messages.AddPrune( tab.Messages.AddPrune(
MakeSystemMarker(HellionStrings.AutoTellTabs_HistorySeparator), MakeSystemMarker(HellionStrings.AutoTellTabs_HistorySeparator),
MessageManager.MessageDisplayLimit MessageManager.MessageDisplayLimit
@@ -329,10 +368,8 @@ internal sealed class AutoTellTabsService : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// Non-fatal: the tab still spawns, but the user gets a visible // Non-fatal: tab still spawns with visible error notice instead of silent history loss
// notice instead of silently missing history. The error logs _logger.LogError(ex, "[AutoTellTabs] History preload failed");
// once with full stack trace for diagnosis.
Plugin.Log.Error(ex, "[AutoTellTabs] History preload failed");
tab.Messages.AddPrune( tab.Messages.AddPrune(
MakeSystemMarker(HellionStrings.AutoTellTabs_HistoryLoadError), MakeSystemMarker(HellionStrings.AutoTellTabs_HistoryLoadError),
MessageManager.MessageDisplayLimit MessageManager.MessageDisplayLimit
@@ -372,9 +409,7 @@ internal sealed class AutoTellTabsService : IDisposable
lock (_tempTabsLock) lock (_tempTabsLock)
{ {
// Frame-race guard (E5): the sidebar might still render a tab // Guard against frame-race: sidebar might render a tab already removed by LRU or logout
// that has already been removed by LRU drop or logout cleanup.
// Silently skip the toggle so we don't mutate stale state.
if (!Plugin.Config.Tabs.Contains(tab)) if (!Plugin.Config.Tabs.Contains(tab))
{ {
return; return;
@@ -388,20 +423,16 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
lock (_tempTabsLock) lock (_tempTabsLock)
{ {
// Snapshot whether the active tab is about to be removed, BEFORE // Pinned TempTabs must survive char-switch — that's the whole point
// we mutate the list — index lookups would lie to us afterwards. // of pinning. Only unpinned ones get stripped.
var lastIndex = _plugin.LastTab; var lastIndex = _plugin.LastTab;
var lastIndexValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count; var lastIndexValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count;
var currentWasTempTab = lastIndexValid && Plugin.Config.Tabs[lastIndex].IsTempTab; var currentWasUnpinnedTempTab =
lastIndexValid
&& TabLifecycleHelpers.IsInUnpinnedPool(Plugin.Config.Tabs[lastIndex]);
// v0.6.1 — symmetric to DropOldestTempTab cleanup: tear down any
// popped-out temp tab windows before removing the tabs themselves,
// otherwise PopOutWindows + WindowSystem keep ghost entries until
// the next plugin reload. Especially relevant once Auto-Pop-Out is
// enabled — every logout would otherwise leak as many ghosts as
// there were active /tell pop-outs.
var poppedTempTabIds = Plugin var poppedTempTabIds = Plugin
.Config.Tabs.Where(t => t.IsTempTab && t.PopOut) .Config.Tabs.Where(t => TabLifecycleHelpers.IsInUnpinnedPool(t) && t.PopOut)
.Select(t => t.Identifier) .Select(t => t.Identifier)
.ToList(); .ToList();
if (poppedTempTabIds.Count > 0) if (poppedTempTabIds.Count > 0)
@@ -417,16 +448,76 @@ internal sealed class AutoTellTabsService : IDisposable
} }
} }
Plugin.Config.Tabs.RemoveAll(t => t.IsTempTab); Plugin.Config.Tabs.RemoveAll(TabLifecycleHelpers.IsInUnpinnedPool);
// Force a switch to tab 0 if the active tab was a temp tab OR // Force switch to tab 0 if active tab was an unpinned temp tab or
// if drops before the active index pushed LastTab out of range. // index is now out of range. Pinned tabs survive — no switch needed.
// Otherwise the user keeps their current persistent tab.
var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count; var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count;
if (currentWasTempTab || !stillValid) if (currentWasUnpinnedTempTab || !stillValid)
{ {
_plugin.WantedTab = 0; _plugin.WantedTab = 0;
} }
} }
} }
internal bool TryPin(Tab tab)
{
if (!tab.IsTempTab || tab.IsPinned)
{
_logger.LogDebug(
$"[Pin] TryPin skipped: IsTempTab={tab.IsTempTab} IsPinned={tab.IsPinned}"
);
return false;
}
if (PinnedTempTabCount >= MaxPinnedTempTabs)
{
WrapperUtil.AddNotification(
string.Format(HellionStrings.PinTab_LimitReached, MaxPinnedTempTabs),
NotificationType.Warning
);
return false;
}
tab.IsPinned = true;
_logger.LogDebug(
$"[Pin] Pinned tab '{tab.Name}' target={tab.TellTarget?.Name}@{tab.TellTarget?.World}"
);
_plugin.SaveConfig();
return true;
}
internal void Unpin(Tab tab)
{
if (!tab.IsPinned)
{
return;
}
// If the unpinned pool is already full, dropping the oldest before
// flipping the flag avoids counting the just-unpinned tab as a drop
// candidate.
if (ActiveTempTabCount >= Plugin.Config.AutoTellTabsLimit)
{
DropOldestTempTab();
}
tab.IsPinned = false;
_logger.LogDebug("[Pin] Unpinned tab '{TabName}'", tab.Name);
_plugin.SaveConfig();
}
internal void PromoteToPermanent(Tab tab)
{
if (!tab.IsTempTab)
{
return;
}
tab.IsTempTab = false;
tab.IsPinned = false;
tab.TellTarget = TellTarget.Empty();
_logger.LogDebug($"[Pin] Promoted tab '{tab.Name}' to permanent (tell-binding dropped)");
_plugin.SaveConfig();
}
} }
+27 -5
View File
@@ -1,11 +1,33 @@
// HellionChat/Branding/BrandingLinks.cs using System.Runtime.CompilerServices;
using HellionChat.Util;
namespace HellionChat.Branding; namespace HellionChat.Branding;
// Centralised so a future invite rotation only touches one file. The same // Centralised a future invite/URL rotation only touches this file.
// link is currently hard-coded in repo.json, README.md, SUPPORT.md,
// CONTRIBUTORS.md and HellionChat.yaml — those will be migrated to consume
// this constant in a separate housekeeping sweep
internal static class BrandingLinks internal static class BrandingLinks
{ {
public const string HellionForgeDiscordInvite = "https://discord.gg/X9V7Kcv5gR"; public const string HellionForgeDiscordInvite = "https://discord.gg/X9V7Kcv5gR";
public const string HellionForgeGitea = "https://gitea.hellion-forge.cloud/Hellion-Forge";
public const string HellionChatRepo =
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat";
public const string HellionForgeWebsite = "https://hellion-forge.cloud";
public const string HellionMediaWebsite = "https://hellion-media.de/de";
// CA2255 warns against [ModuleInitializer] in library code, but Dalamud
// loads the plugin DLL directly so the module-init pass is the right hook
// for a one-shot URL sanity check at plugin load.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(
nameof(BrandingLinks),
HellionForgeDiscordInvite,
HellionForgeGitea,
HellionChatRepo,
HellionForgeWebsite,
HellionMediaWebsite
);
}
} }
+1 -9
View File
@@ -34,9 +34,7 @@ public abstract class Chunk
_ => null, _ => null,
}; };
/// <summary> // Returns basic text for hashing (content for TextChunk, icon name for IconChunk)
/// Get some basic text for use in generating hashes.
/// </summary>
internal string StringValue() internal string StringValue()
{ {
return this switch return this switch
@@ -108,9 +106,6 @@ public class TextChunk : Chunk
Content = content ?? ""; Content = content ?? "";
} }
/// <summary>
/// Creates a new TextChunk with identical styling to this one.
/// </summary>
public TextChunk NewWithStyle(ChunkSource source, Payload? link, string content) public TextChunk NewWithStyle(ChunkSource source, Payload? link, string content)
{ {
return new TextChunk(source, link, content) return new TextChunk(source, link, content)
@@ -122,9 +117,6 @@ public class TextChunk : Chunk
}; };
} }
/// <summary>
/// Creates a new TextChunk with identical styling to this one.
/// </summary>
public TextChunk NewWithStyle(Chunk chunk, string content) public TextChunk NewWithStyle(Chunk chunk, string content)
{ {
return new TextChunk(chunk, content) return new TextChunk(chunk, content)
+11 -11
View File
@@ -7,36 +7,36 @@ public enum ChatSource : ushort
{ {
None = 0, None = 0,
/// <summary>The player currently controlled by the local client.</summary> // The player controlled by this client
LocalPlayer = 1 << XivChatRelationKind.LocalPlayer, LocalPlayer = 1 << XivChatRelationKind.LocalPlayer,
/// <summary>A player in the same 4-man or 8-man party as the local player.</summary> // Member of the local party
PartyMember = 1 << XivChatRelationKind.PartyMember, PartyMember = 1 << XivChatRelationKind.PartyMember,
/// <summary>A player in the same alliance raid.</summary> // Member of the alliance
AllianceMember = 1 << XivChatRelationKind.AllianceMember, AllianceMember = 1 << XivChatRelationKind.AllianceMember,
/// <summary>A player not in the local player's party or alliance.</summary> // Other player
OtherPlayer = 1 << XivChatRelationKind.OtherPlayer, OtherPlayer = 1 << XivChatRelationKind.OtherPlayer,
/// <summary>An enemy entity that is currently in combat with the player or party.</summary> // Enemy in combat
EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy, EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy,
/// <summary>An enemy entity that is not yet in combat or claimed.</summary> // Enemy out of combat
UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy, UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy,
/// <summary>An NPC that is friendly or neutral to the player (e.g., EventNPCs).</summary> // Friendly NPC
FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc, FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc,
/// <summary>A pet (Summoner/Scholar) or companion (Chocobo) belonging to the local player.</summary> // Own pet or companion
PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion, PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion,
/// <summary>A pet or companion belonging to a member of the local player's party.</summary> // Pet or companion of party members
PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty, PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty,
/// <summary>A pet or companion belonging to a member of the alliance.</summary> // Pet or companion of alliance members
PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance, PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance,
/// <summary>A pet or companion belonging to a player not in the party or alliance.</summary> // Pet or companion of other players
PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther, PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther,
} }
+9 -2
View File
@@ -1,10 +1,17 @@
using Dalamud.Game.Command; using Dalamud.Game.Command;
using Microsoft.Extensions.Logging;
namespace HellionChat; namespace HellionChat;
internal sealed class Commands : IDisposable internal sealed class Commands : IDisposable
{ {
private readonly Dictionary<string, CommandWrapper> Registered = []; private readonly Dictionary<string, CommandWrapper> Registered = [];
private readonly ILogger<Commands> _logger;
public Commands(ILogger<Commands> logger)
{
_logger = logger;
}
public void Dispose() public void Dispose()
{ {
@@ -52,7 +59,7 @@ internal sealed class Commands : IDisposable
{ {
if (!Registered.TryGetValue(command, out var wrapper)) if (!Registered.TryGetValue(command, out var wrapper))
{ {
Plugin.Log.Warning($"Missing registration for command {command}"); _logger.LogWarning($"Missing registration for command {command}");
return; return;
} }
@@ -62,7 +69,7 @@ internal sealed class Commands : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, $"Error while executing command {command}"); _logger.LogError(ex, $"Error while executing command {command}");
} }
} }
} }
+107 -161
View File
@@ -34,38 +34,41 @@ public class ConfigKeyBind
[Serializable] [Serializable]
public class Configuration : IPluginConfiguration public class Configuration : IPluginConfiguration
{ {
private const int LatestVersion = 16; private const int LatestVersion = 17;
public int Version { get; set; } = LatestVersion; public int Version { get; set; } = LatestVersion;
// v1.1.0 — Theme-Engine. Slug-basiert; ThemeRegistry liefert das Objekt. // Slug-based; ThemeRegistry resolves the object at runtime.
public string Theme = "hellion-arctic"; public string Theme = "hellion-arctic";
// v1.1.0 — Globale Window-Opacity, theme-übergreifend. Migration aus // Global window opacity, applied across all themes.
// HellionThemeWindowOpacity beim Bump v13 → v14.
public float WindowOpacity = 0.85f; public float WindowOpacity = 0.85f;
// v1.1.0 — Felder für künftige UI-Toggles (v1.2.0 / v1.3.0). Werden // Reserved for future UI toggles; pre-declared to avoid a migration later.
// vorab angelegt, damit später keine Migration nötig ist.
public bool ReduceMotion; public bool ReduceMotion;
// v1.2.1 — Default geflippt von false → true. Card-Rows-Layout aus // v1.2.1: default flipped false → true. Compact single-line layout is
// v1.2.0 wurde als zu dicht empfunden; Single-Line `[HH:mm] Sender: // more readable than the card-rows layout introduced in v1.2.0.
// Text` ist besser lesbar und platzsparender. Bestand-User mit aktiv
// false werden durch die v15→v16-Migration auf den neuen Default
// gehoben (Heuristik: wer in v1.2.0 false hatte, hatte den damals
// neu eingeführten Default — kaum jemand hat aktiv abgeschaltet).
public bool UseCompactDensity = true; public bool UseCompactDensity = true;
// Hellion Chat — Privacy filter (DSGVO Art. 25 Privacy by Default). // Privacy by Default master switch. Set false to restore upstream behaviour.
// Master-switch defaults to true; set false to restore upstream behavior.
public bool PrivacyFilterEnabled = true; public bool PrivacyFilterEnabled = true;
// Empty set means the migration has not run yet — see Plugin.cs v6→v7. // Empty set means the migration has not run yet — see Plugin.cs v6→v7.
public HashSet<ChatType> PrivacyPersistChannels = []; public HashSet<ChatType> PrivacyPersistChannels = [];
// Failsafe for ChatTypes added by future FFXIV patches we don't know about. // Failsafe for ChatTypes added by future FFXIV patches. New configs default
public bool PrivacyPersistUnknownChannels; // to the failsafe via PrivacyDefaults; existing configs keep their saved
// choice because the deserializer overrides this initializer.
public bool PrivacyPersistUnknownChannels = Privacy
.PrivacyDefaults
.DefaultPersistUnknownChannels;
// F3.2: dedup unknown-ChatType warnings so a chatty filter doesn't spam
// the log every frame. NonSerialized so the warning fires once per
// runtime, not once-ever-per-install.
[NonSerialized]
private readonly HashSet<ChatType> _warnedUnknownChannels = new();
public bool IsAllowedForStorage(ChatType type) public bool IsAllowedForStorage(ChatType type)
{ {
@@ -73,82 +76,52 @@ public class Configuration : IPluginConfiguration
return true; return true;
if (PrivacyPersistChannels.Contains(type)) if (PrivacyPersistChannels.Contains(type))
return true; return true;
// F3.2: log first occurrence of a ChatType the running build doesn't
// recognise — i.e. one a future FFXIV patch may have added. Known
// types the user opted out of are routed through the failsafe
// silently, like before.
if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type))
{
Plugin.LogProxy.Warning(
"PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
type,
PrivacyPersistUnknownChannels
);
}
return PrivacyPersistUnknownChannels; return PrivacyPersistUnknownChannels;
} }
// Hellion Chat — Message retention (GDPR data minimization, time axis). // Retention master switch defaults to false — plugin will not delete
// Master switch defaults to false; the plugin will not delete history // history until the user explicitly opts in.
// until the user explicitly opts in.
public bool RetentionEnabled; public bool RetentionEnabled;
public int RetentionDefaultDays = 30; public int RetentionDefaultDays = 30;
public Dictionary<ChatType, int> RetentionPerChannelDays = []; public Dictionary<ChatType, int> RetentionPerChannelDays = [];
public DateTimeOffset RetentionLastRunAt = DateTimeOffset.MinValue; public DateTimeOffset RetentionLastRunAt = DateTimeOffset.MinValue;
// Hellion Chat first-run wizard — opens once on a fresh install. Existing
// ChatTwo users skip it because the v6→v7 migration sets the flag.
public bool FirstRunCompleted; public bool FirstRunCompleted;
// Use the bundled Exo 2 font (OFL-1.1) for the regular plugin font
// instead of whatever GlobalFontV2.FontId points at. Default ON so a
// fresh install gets the Hellion typography out-of-the-box; flip OFF
// to fall back to the user's chosen system or Dalamud font.
public bool UseHellionFont = true; public bool UseHellionFont = true;
// Cycle 1 of the plugin-integration roadmap. When Honorific is installed
// and reports a custom title, render it in the chat header above the
// message log. Auto-hides regardless when Honorific is missing or the
// active title is original/empty, so leaving this on is safe even for
// users who don't run Honorific.
public bool ShowHonorificTitleInHeader = true; public bool ShowHonorificTitleInHeader = true;
// Hellion Chat — Auto-Tell-Tabs. When enabled, an incoming or outgoing // v1.4.7 opt-in: renders the Honorific glow outline when the title carries
// /tell spawns a session-only tab dedicated to that conversation // a Glow colour. Default OFF — keeps v1.4.6 visuals untouched for users
// partner. See spec: Hellion Chat Auto-Tell-Tabs Spec (Obsidian). // who don't care, and dodges the per-frame DrawList overhead on low-end
// hardware. Gradient (Color3 / GradientColourSet) is parsed but rendered
// as the primary Color until a later cycle ports the animation.
public bool ShowHonorificGlow;
public bool EnableAutoTellTabs = true; public bool EnableAutoTellTabs = true;
// Hard cap on simultaneously open auto tell tabs. Range enforced by the
// settings slider (150). LRU drop favors greeted tabs first.
public int AutoTellTabsLimit = 15; public int AutoTellTabsLimit = 15;
// When true the sidebar shows only a thin separator before the temp
// tabs; when false a section header "Active Tells (n)" is rendered.
public bool AutoTellTabsCompactDisplay; public bool AutoTellTabsCompactDisplay;
// Number of prior tells to preload from the message store when an
// auto tell tab is spawned. Range 0100; 0 disables preload.
public int AutoTellTabsHistoryPreload = 20; public int AutoTellTabsHistoryPreload = 20;
// Show the greeter "marked-as-greeted" toggle button next to each // Sidebar width in pixels. Default 44 mirrors the icon-only layout from
// temp tab and dim the tab name when set. Off by default because the // v1.2.0; users can widen up to 160 to fit a section-header line like
// workflow is specific to club-greeter use cases — most users just // "Active Tells (3)" without truncation.
// want the auto tabs themselves without the extra UI affordance. public int SidebarWidth = 44;
public bool AutoTellTabsShowGreetedToggle; public bool AutoTellTabsShowGreetedToggle;
// Hellion Chat — One-Time-Hint-Banner that introduces the v0.6.0 pop-out
// input feature. Set to true once the user dismisses the banner from a
// pop-out window; never reset after that.
public bool SeenPopOutInputHint; public bool SeenPopOutInputHint;
// Hellion Chat — v0.6.0 master switch for the pop-out input bar.
// Global on purpose: per-tab makes no sense for Auto-Tell-Tabs which
// are session-only and would force the user to re-enable it for every
// new conversation. Default flipped to ON in v0.6.1 (was OFF in v0.6.0)
// because tester feedback called the manual toggle "umständlich, wirkt
// unfertig". v11 → v12 migration applies the same flip to existing users.
public bool PopOutInputEnabled = true; public bool PopOutInputEnabled = true;
// Hellion Chat — v0.6.1 One-Time-Hint-Banner that introduces the
// chat-header pop-out toolbar button and reminds about the pop-out
// input default flip. Set to true once the user dismisses the banner
// from the main chat window; never reset after that.
public bool SeenPopOutHeaderHint; public bool SeenPopOutHeaderHint;
// Hellion Chat — v0.6.1 opt-in: when true, AutoTellTabsService.SpawnTempTab
// sets tab.PopOut = true on every new auto-tell tab so the conversation
// pops out as its own window directly. Closing the pop-out returns the
// tab to the sidebar via the standard Popout.OnClose() flow. Default OFF
// because the existing sidebar workflow is what most users (especially
// club greeters tracking many parallel tells) expect by default.
public bool AutoTellTabsOpenAsPopout; public bool AutoTellTabsOpenAsPopout;
public int GetRetentionDays(ChatType type) public int GetRetentionDays(ChatType type)
@@ -167,10 +140,7 @@ public class Configuration : IPluginConfiguration
public bool HideInLoadingScreens; public bool HideInLoadingScreens;
public bool HideInBattle; public bool HideInBattle;
// v1.2.1 — Default geflippt false → true. Hellion-UI im NG+-Menü // v1.2.1: default flipped false → true for consistency with other hide defaults.
// versteckt zu halten ist konsistent mit den anderen Hide-Defaults
// (Cutscenes, Logged-out, UI-Hidden) — UI-out-of-the-way bei Story-
// Sequenzen.
public bool HideInNewGamePlusMenu = true; public bool HideInNewGamePlusMenu = true;
public bool HideWhenInactive; public bool HideWhenInactive;
public int InactivityHideTimeout = 10; public int InactivityHideTimeout = 10;
@@ -186,18 +156,8 @@ public class Configuration : IPluginConfiguration
public bool NativeItemTooltips = true; public bool NativeItemTooltips = true;
public bool PrettierTimestamps = true; public bool PrettierTimestamps = true;
public bool MoreCompactPretty; public bool MoreCompactPretty;
// v1.2.1 — Default geflippt false → true. Wiederholte Zeitstempel
// innerhalb derselben Minute lesen sich als Rauschen; ein einziger
// Timestamp pro Minute reicht aus um die Konversation zu verorten.
public bool HideSameTimestamps = true; public bool HideSameTimestamps = true;
public bool ShowNoviceNetwork; public bool ShowNoviceNetwork;
// Hellion Chat — vertical sidebar tab layout reads better than the
// horizontal tab strip in the company of Auto-Tell-Tabs (a club
// greeter typically tracks 515 simultaneous conversations). Bestand
// users keep their saved value untouched — only fresh installs pick
// up the new default.
public bool SidebarTabView = true; public bool SidebarTabView = true;
public bool PrintChangelog = true; public bool PrintChangelog = true;
public bool OnlyPreviewIf; public bool OnlyPreviewIf;
@@ -216,24 +176,13 @@ public class Configuration : IPluginConfiguration
public bool SortAutoTranslate; public bool SortAutoTranslate;
public bool CollapseDuplicateMessages; public bool CollapseDuplicateMessages;
public bool CollapseKeepUniqueLinks; public bool CollapseKeepUniqueLinks;
public bool SymbolPickerEnabled = true;
public bool PlaySounds = true; public bool PlaySounds = true;
public bool KeepInputFocus = true; public bool KeepInputFocus = true;
// v1.2.1 — Default gesenkt 5000 → 2500. 5000 ist auf Mid-Range-
// Hardware bei langen Sessions spürbar langsamer (Card-Layout
// re-Layout pro Frame), 2500 deckt eine typische Stunde Chat ab
// und bleibt smooth. User die mehr brauchen können bis 10000 hoch.
public int MaxLinesToRender = 2_500; // 1-10000 public int MaxLinesToRender = 2_500; // 1-10000
// Default ON to match a German / European 24h locale. The
// ChatLogWindow.cs format-flip in v0.5.1 honours this strictly via
// CultureInfo.InvariantCulture so the result is consistent across
// host locales.
public bool Use24HourClock = true; public bool Use24HourClock = true;
public bool ShowEmotes = true; public bool ShowEmotes = true;
public HashSet<string> BlockedEmotes = []; public HashSet<string> BlockedEmotes = [];
public bool FontsEnabled = true; public bool FontsEnabled = true;
public ExtraGlyphRanges ExtraGlyphRanges = 0; public ExtraGlyphRanges ExtraGlyphRanges = 0;
public float FontSizeV2 = 12.75f; public float FontSizeV2 = 12.75f;
@@ -258,12 +207,6 @@ public class Configuration : IPluginConfiguration
public float TooltipOffset; public float TooltipOffset;
// v1.2.1 — Default-Chat-Farben sind das Hellion-Brand-Preset. Der
// First-Run-Wizard bietet keine Theme-/Preset-Wahl an, daher kriegen
// neue User die Hellion-Brand-Farben out-of-the-box (Cyan-Familie für
// Standard/Tell, Ember/Warning für laute Channels). Bestand-User mit
// leerem ChatColours-Dict werden durch die v15→v16-Migration auf das
// Preset gehoben; User die bereits Custom-Farben haben, bleiben.
public Dictionary<ChatType, uint> ChatColours = BuildDefaultChatColours(); public Dictionary<ChatType, uint> ChatColours = BuildDefaultChatColours();
private static Dictionary<ChatType, uint> BuildDefaultChatColours() private static Dictionary<ChatType, uint> BuildDefaultChatColours()
@@ -328,14 +271,13 @@ public class Configuration : IPluginConfiguration
SortAutoTranslate = other.SortAutoTranslate; SortAutoTranslate = other.SortAutoTranslate;
CollapseDuplicateMessages = other.CollapseDuplicateMessages; CollapseDuplicateMessages = other.CollapseDuplicateMessages;
CollapseKeepUniqueLinks = other.CollapseKeepUniqueLinks; CollapseKeepUniqueLinks = other.CollapseKeepUniqueLinks;
SymbolPickerEnabled = other.SymbolPickerEnabled;
PlaySounds = other.PlaySounds; PlaySounds = other.PlaySounds;
KeepInputFocus = other.KeepInputFocus; KeepInputFocus = other.KeepInputFocus;
MaxLinesToRender = other.MaxLinesToRender; MaxLinesToRender = other.MaxLinesToRender;
Use24HourClock = other.Use24HourClock; Use24HourClock = other.Use24HourClock;
ShowEmotes = other.ShowEmotes; ShowEmotes = other.ShowEmotes;
// Deep-copy the set so the live and mutable Configuration instances don't share state // Deep-copy so settings window edits don't leak into live config before Save.
// — a HashSet reference assignment would cause edits in the settings window to leak
// into the live config before the user clicks Save.
BlockedEmotes = new HashSet<string>(other.BlockedEmotes); BlockedEmotes = new HashSet<string>(other.BlockedEmotes);
FontsEnabled = other.FontsEnabled; FontsEnabled = other.FontsEnabled;
ItalicEnabled = other.ItalicEnabled; ItalicEnabled = other.ItalicEnabled;
@@ -349,28 +291,21 @@ public class Configuration : IPluginConfiguration
ChatColours = other.ChatColours.ToDictionary(entry => entry.Key, entry => entry.Value); ChatColours = other.ChatColours.ToDictionary(entry => entry.Key, entry => entry.Value);
ColorSelectedInputChannelButton = other.ColorSelectedInputChannelButton; ColorSelectedInputChannelButton = other.ColorSelectedInputChannelButton;
// Hellion Chat — Auto-Tell-Tabs are session-only and therefore // Keep live temp tabs alive across UpdateFrom — a settings save must
// never present in a disk-loaded copy. Keep the live temp tabs of // not destroy open tell conversations. Pinned TempTabs are persistent
// *this* configuration alive across an UpdateFrom so a settings // and come through `other` like regular tabs; unpinned TempTabs are
// save (or sidebar-mode toggle) does not silently destroy the // session-only and held from the local state. For persistent tabs
// user's open tell conversations. // (incl. pinned), capture live runtime state by Identifier and restore
// // it onto the freshly cloned tabs — CurrentChannel is critical because
// For persistent tabs we go through Tab.Clone() which intentionally // the user may have switched channel in-game between settings-open
// does NOT copy the NonSerialized Messages list (avoids shared // and settings-save, and we'd otherwise overwrite that with the
// mutable state on disk-load). On a settings save that means the // settings-time snapshot.
// chat history for every persistent tab would be wiped — bug var liveUnpinnedTempTabs = Tabs.Where(TabLifecycleHelpers.IsInUnpinnedPool).ToList();
// reported by Flo 2026-05-05. We work around it by capturing the var livePersistentSession = Tabs.Where(t => !TabLifecycleHelpers.IsInUnpinnedPool(t))
// live MessageList (and LastSendUnread counter) by Identifier .ToDictionary(t => t.Identifier, t => (t.Messages, t.LastSendUnread, t.CurrentChannel));
// before the replace, then restoring it onto the freshly cloned
// tabs whose Identifier survives Tab.Clone(). New tabs added in
// settings get a fresh empty MessageList; deleted tabs lose their
// history (intended).
var liveTempTabs = Tabs.Where(t => t.IsTempTab).ToList();
var livePersistentSession = Tabs.Where(t => !t.IsTempTab)
.ToDictionary(t => t.Identifier, t => (t.Messages, t.LastSendUnread));
Tabs = other Tabs = other
.Tabs.Where(t => !t.IsTempTab) .Tabs.Where(t => !t.IsTempTab || t.IsPinned)
.Select(t => .Select(t =>
{ {
var clone = t.Clone(); var clone = t.Clone();
@@ -378,11 +313,12 @@ public class Configuration : IPluginConfiguration
{ {
clone.Messages = live.Messages; clone.Messages = live.Messages;
clone.LastSendUnread = live.LastSendUnread; clone.LastSendUnread = live.LastSendUnread;
clone.CurrentChannel = live.CurrentChannel;
} }
return clone; return clone;
}) })
.ToList(); .ToList();
Tabs.AddRange(liveTempTabs); Tabs.AddRange(liveUnpinnedTempTabs);
ChatTabForward = other.ChatTabForward; ChatTabForward = other.ChatTabForward;
ChatTabBackward = other.ChatTabBackward; ChatTabBackward = other.ChatTabBackward;
@@ -402,6 +338,7 @@ public class Configuration : IPluginConfiguration
FirstRunCompleted = other.FirstRunCompleted; FirstRunCompleted = other.FirstRunCompleted;
UseHellionFont = other.UseHellionFont; UseHellionFont = other.UseHellionFont;
ShowHonorificTitleInHeader = other.ShowHonorificTitleInHeader; ShowHonorificTitleInHeader = other.ShowHonorificTitleInHeader;
ShowHonorificGlow = other.ShowHonorificGlow;
// v1.1.0 theme engine fields // v1.1.0 theme engine fields
Theme = other.Theme; Theme = other.Theme;
@@ -413,6 +350,7 @@ public class Configuration : IPluginConfiguration
AutoTellTabsLimit = other.AutoTellTabsLimit; AutoTellTabsLimit = other.AutoTellTabsLimit;
AutoTellTabsCompactDisplay = other.AutoTellTabsCompactDisplay; AutoTellTabsCompactDisplay = other.AutoTellTabsCompactDisplay;
AutoTellTabsHistoryPreload = other.AutoTellTabsHistoryPreload; AutoTellTabsHistoryPreload = other.AutoTellTabsHistoryPreload;
SidebarWidth = other.SidebarWidth;
AutoTellTabsShowGreetedToggle = other.AutoTellTabsShowGreetedToggle; AutoTellTabsShowGreetedToggle = other.AutoTellTabsShowGreetedToggle;
SeenPopOutInputHint = other.SeenPopOutInputHint; SeenPopOutInputHint = other.SeenPopOutInputHint;
@@ -456,9 +394,7 @@ public class Tab
{ {
public string Name = Language.Tab_DefaultName; public string Name = Language.Tab_DefaultName;
// v1.2.0 — optionaler FontAwesome-Glyph-Name. Null bedeutet: // Optional FontAwesome glyph name; null falls back to TabIconMapping default.
// Default-Mapping aus TabIconMapping greift (basiert auf Tab-Name).
// User können hier per Settings → Tabs einen eigenen Glyph setzen.
public string? Icon = null; public string? Icon = null;
[Obsolete("Removed in favor of SelectedChannels")] [Obsolete("Removed in favor of SelectedChannels")]
@@ -489,6 +425,11 @@ public class Tab
public bool HideWhenInactive; public bool HideWhenInactive;
public bool IsTempTab; public bool IsTempTab;
// Pinned TempTabs survive plugin reload and logout — tester feedback from
// Jin (v1.4.7). Pinned tabs live in their own pool (MaxPinnedTempTabs)
// separate from the AutoTellTabsLimit bucket.
public bool IsPinned;
public bool AllSenderMessages; public bool AllSenderMessages;
public TellTarget TellTarget = TellTarget.Empty(); public TellTarget TellTarget = TellTarget.Empty();
@@ -510,15 +451,12 @@ public class Tab
[NonSerialized] [NonSerialized]
public Guid Identifier = Guid.NewGuid(); public Guid Identifier = Guid.NewGuid();
// Hellion Chat — Auto-Tell-Tabs greeted flag. Toggled manually from the // Session-only greeted flag for club-greeter workflows.
// sidebar to mark a tell partner as already greeted in the current
// session. NonSerialized because the temp tab itself is session-only.
[NonSerialized] [NonSerialized]
public bool IsGreeted; public bool IsGreeted;
// v1.4.2 — TabTintCache uses separate validation keys per cache so a // Separate validation keys per cache so TellTarget changes don't
// TellTarget change picked up by GetTint can't strand GetIcon (or vice // cause GetTint and GetIcon to strand each other with stale entries.
// versa) with a stale entry that looks fresh on the shared key.
[NonSerialized] [NonSerialized]
internal string? _cachedTintTellName; internal string? _cachedTintTellName;
@@ -540,17 +478,12 @@ public class Tab
public bool Matches(Message message) public bool Matches(Message message)
{ {
if (!message.Matches(SelectedChannels, ExtraChatAll, ExtraChatChannels)) if (!message.Matches(SelectedChannels, ExtraChatAll, ExtraChatChannels))
{
return false; return false;
}
// Auto-tell temp tabs are bound to a single conversation partner; // Temp tabs are bound to a single conversation partner — other tells
// every other tell that matches the channel filter must NOT land // matching the channel filter must not land here.
// here, otherwise all temp tabs would mirror "Tell Exclusive".
if (IsTempTab && TellTarget?.IsSet() == true) if (IsTempTab && TellTarget?.IsSet() == true)
{
return ChunkUtil.MatchesSender(message, TellTarget.Name, TellTarget.World); return ChunkUtil.MatchesSender(message, TellTarget.Name, TellTarget.World);
}
return true; return true;
} }
@@ -593,7 +526,7 @@ public class Tab
Opacity = Opacity, Opacity = Opacity,
Identifier = Identifier, Identifier = Identifier,
InputDisabled = InputDisabled, InputDisabled = InputDisabled,
CurrentChannel = CurrentChannel, CurrentChannel = CurrentChannel.Clone(),
CanMove = CanMove, CanMove = CanMove,
CanResize = CanResize, CanResize = CanResize,
IndependentHide = IndependentHide, IndependentHide = IndependentHide,
@@ -604,16 +537,14 @@ public class Tab
HideInBattle = HideInBattle, HideInBattle = HideInBattle,
HideWhenInactive = HideWhenInactive, HideWhenInactive = HideWhenInactive,
IsTempTab = IsTempTab, IsTempTab = IsTempTab,
IsPinned = IsPinned,
AllSenderMessages = AllSenderMessages, AllSenderMessages = AllSenderMessages,
TellTarget = TellTarget.From(TellTarget), TellTarget = TellTarget.Clone(),
IsGreeted = IsGreeted, IsGreeted = IsGreeted,
}; };
} }
/// <summary> /// Ordered message list with duplicate ID tracking, sorting and mutex protection.
/// MessageList provides an ordered list of messages with duplicate ID
/// tracking, sorting and mutex protection.
/// </summary>
public class MessageList public class MessageList
{ {
private readonly SemaphoreSlim LockSlim = new(1, 1); private readonly SemaphoreSlim LockSlim = new(1, 1);
@@ -701,10 +632,7 @@ public class Tab
} }
} }
/// <summary> /// Current message count. Lock-per-read is acceptable for 1×/sec status bar polling.
/// Aktuelle Anzahl der gespeicherten Messages. Lock-acquire pro Read
/// ist OK für 1×/sec Status-Bar-Polling (v1.2.0).
/// </summary>
public int Count public int Count
{ {
get get
@@ -721,9 +649,7 @@ public class Tab
} }
} }
/// <summary> /// Returns an array copy of the message list for usage outside of main thread.
/// Returns an array copy of the message list for usage outside of main thread
/// </summary>
public async Task<Message[]> GetCopy(int millisecondsTimeout = -1) public async Task<Message[]> GetCopy(int millisecondsTimeout = -1)
{ {
await LockSlim.WaitAsync(millisecondsTimeout); await LockSlim.WaitAsync(millisecondsTimeout);
@@ -737,10 +663,7 @@ public class Tab
} }
} }
/// <summary> /// Returns a read-only list while holding a reader lock. Use with a using statement.
/// GetReadOnly returns a read-only list of messages while holding a
/// reader lock. The list should be used with a using statement.
/// </summary>
public RLockedMessageList GetReadOnly(int millisecondsTimeout = -1) public RLockedMessageList GetReadOnly(int millisecondsTimeout = -1)
{ {
LockSlim.Wait(millisecondsTimeout); LockSlim.Wait(millisecondsTimeout);
@@ -794,6 +717,29 @@ public class UsedChannel
{ {
Channel = channel; Channel = channel;
} }
// ---------------------------------------------------------------
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Deep-clone the UsedChannel so Tab.Clone() no longer shares
// channel state (incl. TellTarget) with its origin Tab. Previously
// a reference copy: PopOut and Temp tabs mutated each other.
// - Name is intentionally a reference copy (matches upstream); it
// gets reassigned on every channel switch anyway.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/UsedChannelCloneTests.cs
// ---------------------------------------------------------------
public UsedChannel Clone()
{
return new UsedChannel
{
Channel = Channel,
Name = Name,
TellTarget = TellTarget?.Clone(),
UseTempChannel = UseTempChannel,
TempChannel = TempChannel,
TempTellTarget = TempTellTarget?.Clone(),
};
}
} }
[Serializable] [Serializable]
+20 -34
View File
@@ -79,7 +79,7 @@ public static class EmoteCache
Done, Done,
} }
// All of this data is uninitalized while State is not `LoadingState.Done` // All fields below are uninitialised while State != Done.
public static LoadingState State = LoadingState.Unloaded; public static LoadingState State = LoadingState.Unloaded;
private static readonly Dictionary<string, Emote> Cache = new(); private static readonly Dictionary<string, Emote> Cache = new();
@@ -87,15 +87,11 @@ public static class EmoteCache
public static string[] SortedCodeArray = []; public static string[] SortedCodeArray = [];
// Plugin-scoped cancellation source for in-flight emote loads. Dispose // Cancelled on Dispose to stop in-flight downloads; replaced on re-enable.
// cancels every running download/texture-create so the workers don't
// touch a torn-down TextureProvider on plugin reload. Replaced with a
// fresh source on the next LoadData() call so a re-enable still works.
private static CancellationTokenSource Cts = new(); private static CancellationTokenSource Cts = new();
internal static CancellationToken Token => Cts.Token; internal static CancellationToken Token => Cts.Token;
// Drain target for in-flight loads on Dispose; without this an orphan // Tracks in-flight loads so Dispose can drain them before teardown.
// continuation could still write to a torn-down Texture/Frames field.
private static readonly ConcurrentBag<Task> PendingLoads = new(); private static readonly ConcurrentBag<Task> PendingLoads = new();
internal static void TrackLoad(Task loadTask, string emoteCode) internal static void TrackLoad(Task loadTask, string emoteCode)
@@ -105,7 +101,10 @@ public static class EmoteCache
t => t =>
{ {
if (t.IsFaulted) if (t.IsFaulted)
Plugin.Log.Error(t.Exception!, $"EmoteCache load failed for {emoteCode}"); Plugin.LogProxy.Error(
t.Exception!,
$"EmoteCache load failed for {emoteCode}"
);
}, },
TaskScheduler.Default TaskScheduler.Default
) )
@@ -117,8 +116,7 @@ public static class EmoteCache
if (State is not LoadingState.Unloaded) if (State is not LoadingState.Unloaded)
return; return;
// Refresh the CTS in case Dispose was called and we're being re-enabled // Reset CTS if Dispose was called and the plugin is being re-enabled.
// in the same process (Dalamud /xlplugins toggle).
if (Cts.IsCancellationRequested) if (Cts.IsCancellationRequested)
Cts = new CancellationTokenSource(); Cts = new CancellationTokenSource();
@@ -140,11 +138,8 @@ public static class EmoteCache
var topList = await top.Content.ReadAsStringAsync(ct); var topList = await top.Content.ReadAsStringAsync(ct);
var jsonList = JsonSerializer.Deserialize<List<Top100>>(topList)!; var jsonList = JsonSerializer.Deserialize<List<Top100>>(topList)!;
// BetterTTV occasionally returns entries with a null Code; the // BetterTTV occasionally returns entries with a null Code;
// upstream code passed those straight into Dictionary.TryAdd // skip them so a single bad row doesn't break the whole cache.
// and tripped ArgumentNullException, killing the whole emote
// load. Skip them defensively so a single bad row no longer
// breaks the cache for everyone else.
foreach (var emote in jsonList) foreach (var emote in jsonList)
if ( if (
!string.IsNullOrEmpty(emote.Emote.Code) !string.IsNullOrEmpty(emote.Emote.Code)
@@ -160,18 +155,13 @@ public static class EmoteCache
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
// Plugin disposed while the cache was loading; leave State on // Plugin disposed mid-load; State stays on Loading so re-enable can retry.
// Loading so a subsequent re-enable can re-issue LoadData with
// a fresh CTS (handled above).
} }
catch (Exception ex) catch (Exception ex)
{ {
// Reset to Unloaded so a later trigger (e.g. the user reopening // Reset to Unloaded so a later trigger can retry without a plugin reload.
// the Emotes tab after the network recovers) can retry. Without
// this the State stays on Loading and the early-out at the top
// of LoadData blocks every further attempt until plugin reload.
State = LoadingState.Unloaded; State = LoadingState.Unloaded;
Plugin.Log.Error(ex, "BetterTTV cache wasn't initialized"); Plugin.LogProxy.Error(ex, "BetterTTV cache wasn't initialized");
} }
} }
@@ -227,7 +217,7 @@ public static class EmoteCache
} }
catch catch
{ {
Plugin.Log.Error("Failed to convert"); Plugin.LogProxy.Error("Failed to convert");
return null; return null;
} }
} }
@@ -248,11 +238,8 @@ public static class EmoteCache
internal async Task<byte[]> LoadAsync(Emote emote, CancellationToken ct) internal async Task<byte[]> LoadAsync(Emote emote, CancellationToken ct)
{ {
// BetterTTV-supplied Id and ImageType are interpolated straight // Path-traversal guard: resolve and verify the candidate path stays
// into the filename. HTTPS protects the wire, but a compromised // inside the cache directory before reading or writing.
// upstream could still hand us "../foo" and write into the
// pluginConfigs root (or worse). Resolve the candidate path and
// refuse anything that escapes the cache directory.
var dir = Path.GetFullPath( var dir = Path.GetFullPath(
Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1") Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1")
); );
@@ -320,7 +307,7 @@ public static class EmoteCache
catch (Exception ex) catch (Exception ex)
{ {
Failed = true; Failed = true;
Plugin.Log.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}"); Plugin.LogProxy.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}");
} }
} }
@@ -397,7 +384,7 @@ public static class EmoteCache
var delay = frame.Metadata.GetGifMetadata().FrameDelay / 100f; var delay = frame.Metadata.GetGifMetadata().FrameDelay / 100f;
// Follows the same pattern as browsers, anything under 0.02s delay will be rounded up to 0.1s // Match browser behaviour: anything under 20ms rounds up to 100ms.
if (delay < 0.02f) if (delay < 0.02f)
delay = 0.1f; delay = 0.1f;
@@ -416,8 +403,7 @@ public static class EmoteCache
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
// Plugin disposed mid-load; partial frames are released by // Plugin disposed mid-load; release any partial frames.
// InnerDispose on the next dispose pass.
foreach (var f in Frames) foreach (var f in Frames)
f.Texture.Dispose(); f.Texture.Dispose();
Frames = []; Frames = [];
@@ -425,7 +411,7 @@ public static class EmoteCache
catch (Exception ex) catch (Exception ex)
{ {
Failed = true; Failed = true;
Plugin.Log.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}"); Plugin.LogProxy.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}");
} }
} }
} }
+5 -9
View File
@@ -32,12 +32,8 @@ internal static class ExportFormatExt
}; };
} }
/// <summary> // Serializes message snapshots to Markdown, JSON, or CSV.
/// Serializes message snapshots into Markdown, JSON, or CSV. The caller is // Caller handles pre-filtering except sender substring, which requires deserialized SeString.TextValue.
/// expected to filter the input enumerable; this class only handles
/// formatting and writes to the supplied path. Sender substring filtering
/// happens here because it requires deserialized SeString.TextValue.
/// </summary>
internal static class MessageExporter internal static class MessageExporter
{ {
internal record FilterDescription( internal record FilterDescription(
@@ -100,6 +96,7 @@ internal static class MessageExporter
var chatType = (ChatType)(ushort)m.Code.Type; var chatType = (ChatType)(ushort)m.Code.Type;
var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim(); var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim();
var content = m.ContentSource.TextValue; var content = m.ContentSource.TextValue;
if (string.IsNullOrEmpty(sender)) if (string.IsNullOrEmpty(sender))
w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}"); w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}");
else else
@@ -132,8 +129,7 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Manual JSON to avoid pulling in System.Text.Json policy choices. // Manual JSON to avoid System.Text.Json policy coupling.
// Output is a single object with metadata and an array of messages.
w.Write("{\n \"exported_at\": \""); w.Write("{\n \"exported_at\": \"");
w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture)); w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture));
w.Write("\",\n \"plugin\": \"Hellion Chat\",\n"); w.Write("\",\n \"plugin\": \"Hellion Chat\",\n");
@@ -194,7 +190,7 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Header line always written so empty exports are still importable. // Header always written so empty exports remain importable.
w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId"); w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId");
var count = 0; var count = 0;
foreach (var m in messages) foreach (var m in messages)
+40 -38
View File
@@ -8,6 +8,9 @@ using Dalamud.Interface.Utility;
namespace HellionChat; namespace HellionChat;
// Two LogProxy sites live in static methods (TryGetHellionFontBytes,
// AddFontWithFallback); a ctor-injected ILogger would not be reachable
// from those scopes, so the class stays on Plugin.LogProxy.
public class FontManager public class FontManager
{ {
internal IFontHandle Axis = null!; internal IFontHandle Axis = null!;
@@ -41,24 +44,29 @@ public class FontManager
90f, 90f,
]; ];
/// <summary> // Hellion font bytes (Exo 2, OFL-1.1); lazily loaded from manifest resources
/// Backing bytes for the bundled Hellion font (Exo 2, OFL-1.1). Lazily
/// extracted from the assembly's manifest resources on first use; the
/// load happens inside the font atlas build callback so we keep the
/// allocation off the plugin constructor's hot path.
/// </summary>
private static byte[]? HellionFontBytes; private static byte[]? HellionFontBytes;
private static byte[] GetHellionFontBytes() // Returns null when the embedded font resource is missing. Should never
// happen on a signed release build, but a broken csproj or hand-rolled
// dev build can land here. Caller falls back to the system font path so
// the plugin still loads instead of crashing the whole UiBuilder.
private static byte[]? TryGetHellionFontBytes()
{ {
if (HellionFontBytes is not null) if (HellionFontBytes is not null)
return HellionFontBytes; return HellionFontBytes;
using var stream = using var stream = typeof(FontManager).Assembly.GetManifestResourceStream(
typeof(FontManager).Assembly.GetManifestResourceStream("HellionFont.ttf") "HellionFont.ttf"
?? throw new FileNotFoundException( );
"Hellion font resource not embedded in the assembly" if (stream is null)
{
Plugin.LogProxy.Warning(
"Hellion font resource missing — falling back to system default font."
); );
return null;
}
using var ms = new MemoryStream(); using var ms = new MemoryStream();
stream.CopyTo(ms); stream.CopyTo(ms);
HellionFontBytes = ms.ToArray(); HellionFontBytes = ms.ToArray();
@@ -70,11 +78,9 @@ public class FontManager
ushort[] BuildRange(IReadOnlyList<ushort>? chars, params nint[] ranges) ushort[] BuildRange(IReadOnlyList<ushort>? chars, params nint[] ranges)
{ {
var builder = new ImFontGlyphRangesBuilderPtr(ImGuiNative.ImFontGlyphRangesBuilder()); var builder = new ImFontGlyphRangesBuilderPtr(ImGuiNative.ImFontGlyphRangesBuilder());
// text
foreach (var range in ranges) foreach (var range in ranges)
builder.AddRanges((ushort*)range); builder.AddRanges((ushort*)range);
// chars
if (chars != null) if (chars != null)
{ {
for (var i = 0; i < chars.Count; i += 2) for (var i = 0; i < chars.Count; i += 2)
@@ -116,13 +122,7 @@ public class FontManager
JpRange = BuildRange(GlyphRangesJapanese.GlyphRanges); JpRange = BuildRange(GlyphRangesJapanese.GlyphRanges);
} }
/// <summary> // CPU-bound build offloaded to Task.Run; runs parallel with theme init
/// Async wrapper around <see cref="BuildFonts"/> for the Phase-1 LoadAsync
/// path. The font-atlas build is CPU-bound, so we offload via Task.Run and
/// honour the cancellation token at the scheduling boundary; this lets the
/// font build run in parallel with the theme init without blocking the
/// loader. Settings-driven manual rebuilds keep using the sync entry point.
/// </summary>
public async Task BuildFontsAsync(CancellationToken cancellationToken) public async Task BuildFontsAsync(CancellationToken cancellationToken)
{ {
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
@@ -154,18 +154,16 @@ public class FontManager
RegularFont = Plugin.Interface.UiBuilder.FontAtlas.NewDelegateFontHandle(e => RegularFont = Plugin.Interface.UiBuilder.FontAtlas.NewDelegateFontHandle(e =>
e.OnPreBuild(tk => e.OnPreBuild(tk =>
{ {
// v1.2.0 — Bei aktiver Hellion-Schrift (Exo 2 ist Variable-Font) // v1.2.0: UseHellionFont controls font size selection
// wird die User-Schriftgröße aus FontSizeV2 als SizePt angewendet.
// Der Bestand-Pfad nutzt weiter GlobalFontV2.SizePt aus dem
// Custom-Font-Stack. Ohne diese Verzweigung war FontSizeV2 bei
// UseHellionFont=true wirkungslos, was 4K-User mit größerer
// Skalierung blockierte (Settings → Erscheinungsbild → Schriftarten).
var basePt = Plugin.Config.UseHellionFont var basePt = Plugin.Config.UseHellionFont
? Plugin.Config.FontSizeV2 ? Plugin.Config.FontSizeV2
: Plugin.Config.GlobalFontV2.SizePt; : Plugin.Config.GlobalFontV2.SizePt;
var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges }; var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges };
config.MergeFont = Plugin.Config.UseHellionFont // F10.2: if the embedded font is missing, drop to the system font
? tk.AddFontFromMemory(GetHellionFontBytes(), config, "Hellion-Exo2") // path rather than letting the UiBuilder throw.
var hellionBytes = Plugin.Config.UseHellionFont ? TryGetHellionFontBytes() : null;
config.MergeFont = hellionBytes is not null
? tk.AddFontFromMemory(hellionBytes, config, "Hellion-Exo2")
: AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global"); : AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global");
config.SizePt = Plugin.Config.JapaneseFontV2.SizePt; config.SizePt = Plugin.Config.JapaneseFontV2.SizePt;
@@ -218,13 +216,7 @@ public class FontManager
} }
} }
/// <summary> // Add font with fallback to NotoSansCjkRegular if unavailable
/// Try to add a user-configured font to the build toolkit, falling back to
/// the bundled NotoSansCjkRegular asset if the configured font isn't
/// available on the system. Without this guard a stale SystemFontId
/// pointing at a font the user uninstalled or that never existed on
/// Linux (e.g. "Crimson Text") tears down the entire font atlas build.
/// </summary>
private static ImFontPtr AddFontWithFallback( private static ImFontPtr AddFontWithFallback(
IFontAtlasBuildToolkitPreBuild tk, IFontAtlasBuildToolkitPreBuild tk,
IFontId fontId, IFontId fontId,
@@ -237,11 +229,21 @@ public class FontManager
return fontId.AddToBuildToolkit(tk, config); return fontId.AddToBuildToolkit(tk, config);
} }
catch (Exception e) catch (Exception e)
when (e is FileNotFoundException or DirectoryNotFoundException or IOException) when (e
is FileNotFoundException
or DirectoryNotFoundException
or IOException
or InvalidOperationException
or ArgumentException
)
{ {
Plugin.Log.Warning( // Atlas-toolkit throws span IO and validation failures; routing
// the wider set through the fallback keeps a corrupt font config
// from taking down the whole atlas build.
Plugin.LogProxy.Warning(
e, e,
$"Configured {slot} font unavailable, falling back to NotoSansCjkRegular" $"Configured {slot} font failed to load ({e.GetType().Name}), "
+ "falling back to NotoSansCjkRegular"
); );
var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular); var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular);
return fallback.AddToBuildToolkit(tk, config); return fallback.AddToBuildToolkit(tk, config);
+43 -47
View File
@@ -19,6 +19,7 @@ using HellionChat.Resources;
using HellionChat.Util; using HellionChat.Util;
using InteropGenerator.Runtime; using InteropGenerator.Runtime;
using Lumina.Text.ReadOnly; using Lumina.Text.ReadOnly;
using Microsoft.Extensions.Logging;
using ValueType = FFXIVClientStructs.FFXIV.Component.GUI.AtkValueType; using ValueType = FFXIVClientStructs.FFXIV.Component.GUI.AtkValueType;
namespace HellionChat.GameFunctions; namespace HellionChat.GameFunctions;
@@ -98,9 +99,12 @@ internal sealed unsafe class Chat : IDisposable
private long LastPlayerNameDisplayTypeRefresh; private long LastPlayerNameDisplayTypeRefresh;
private PlayerNameDisplayType CurrentPlayerNameDisplayType = PlayerNameDisplayType.FullName; private PlayerNameDisplayType CurrentPlayerNameDisplayType = PlayerNameDisplayType.FullName;
public Chat(Plugin plugin) private readonly ILogger<Chat> _logger;
public Chat(Plugin plugin, ILogger<Chat> logger)
{ {
Plugin = plugin; Plugin = plugin;
_logger = logger;
Plugin.GameInteropProvider.InitializeFromAttributes(this); Plugin.GameInteropProvider.InitializeFromAttributes(this);
ChatLogRefreshHook?.Enable(); ChatLogRefreshHook?.Enable();
@@ -174,8 +178,7 @@ internal sealed unsafe class Chat : IDisposable
internal static void RotateCrossLinkshellHistory(RotateMode mode) => internal static void RotateCrossLinkshellHistory(RotateMode mode) =>
UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode)); UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode));
// This function looks up a channel's user-defined color. // Look up a channel's user-defined color, returns null if 0
// If this function ever returns 0, it returns null instead.
internal uint? GetChannelColor(ChatType type) internal uint? GetChannelColor(ChatType type)
{ {
var parent = type.Parent(); var parent = type.Parent();
@@ -215,8 +218,7 @@ internal sealed unsafe class Chat : IDisposable
if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null) if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null)
{ {
// FIXME: this whole system sucks // Capture the just-typed character input
// FIXME v2: I hate everything about this, but it works
Plugin.Framework.RunOnTick(() => Plugin.Framework.RunOnTick(() =>
{ {
string? input = null; string? input = null;
@@ -238,7 +240,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in chat Activated event"); _logger.LogError(ex, "Error in chat Activated event");
} }
}); });
} }
@@ -255,13 +257,9 @@ internal sealed unsafe class Chat : IDisposable
try try
{ {
// We already called this function once, so we skip the duplicated call // Prevent duplicate calls
// Also return the original value here so that vanilla chat receives all information
if (Plugin.ChatLogWindow.TellSpecial) if (Plugin.ChatLogWindow.TellSpecial)
{
Plugin.Log.Information("Return early to prevent duplicated call...");
return ChatLogRefreshHook!.Original(log, eventId, value); return ChatLogRefreshHook!.Original(log, eventId, value);
}
Plugin.ChatLogWindow.Activated( Plugin.ChatLogWindow.Activated(
new ChatActivatedArgs(new ChannelSwitchInfo(null)) new ChatActivatedArgs(new ChannelSwitchInfo(null))
@@ -272,11 +270,10 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in chat Activated event"); _logger.LogError(ex, "Error in chat Activated event");
} }
// prevent the game from focusing the chat log return 1; // Prevent vanilla chat log from gaining focus
return 1;
} }
private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent) private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent)
@@ -306,7 +303,7 @@ internal sealed unsafe class Chat : IDisposable
{ {
playerName = SeString.Parse(agent->TellPlayerName).TextValue; playerName = SeString.Parse(agent->TellPlayerName).TextValue;
worldId = agent->TellWorldId; worldId = agent->TellWorldId;
Plugin.Log.Debug($"Detected tell target '[redacted]'@{worldId}"); _logger.LogDebug($"Detected tell target '[redacted]'@{worldId}");
} }
Plugin.CurrentTab.CurrentChannel = new UsedChannel Plugin.CurrentTab.CurrentChannel = new UsedChannel
@@ -365,7 +362,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in chat Activated event"); _logger.LogError(ex, "Error in chat Activated event");
} }
} }
@@ -415,7 +412,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in chat Activated event"); _logger.LogError(ex, "Error in chat Activated event");
} }
} }
@@ -430,19 +427,24 @@ internal sealed unsafe class Chat : IDisposable
); );
} }
/// <summary> // ---------------------------------------------------------------
/// Returns true if the channel is any non-linkshell channel, or if the // Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
/// linkshell actually exists. // - Renamed ValidAnyLinkshell -> IsChannelOrExistingLinkshell. The
/// </summary> // name now states intent: returns true for any non-linkshell
internal static bool ValidAnyLinkshell(InputChannel channel) // channel, or a linkshell index that actually exists.
// ---------------------------------------------------------------
internal static bool IsChannelOrExistingLinkshell(InputChannel channel)
{ {
var idx = channel.LinkshellIndex(); var idx = channel.LinkshellIndex();
if (idx == uint.MaxValue || channel.IsExtraChatLinkshell()) if (idx == uint.MaxValue || channel.IsExtraChatLinkshell())
return true; return true;
if (channel.IsLinkshell() && ValidLinkshell(idx))
return true; if (channel.IsLinkshell())
if (channel.IsCrossLinkshell() && ValidCrossLinkshell(idx)) return ValidLinkshell(idx);
return true;
if (channel.IsCrossLinkshell())
return ValidCrossLinkshell(idx);
return false; return false;
} }
@@ -477,8 +479,7 @@ internal sealed unsafe class Chat : IDisposable
_ => 1, _ => 1,
}; };
// Iterate up to 8 times to find a valid linkshell. for (var i = 0; i < 8; i++) // Find valid linkshell within 8 iterations
for (var i = 0; i < 8; i++)
{ {
currentIndex = (uint)((8 + currentIndex + delta) % 8); currentIndex = (uint)((8 + currentIndex + delta) % 8);
if (validFn(currentIndex)) if (validFn(currentIndex))
@@ -524,7 +525,7 @@ internal sealed unsafe class Chat : IDisposable
); );
// RotateLinkshell returns null when no valid linkshell is found within 8 iterations. // RotateLinkshell returns null when no valid linkshell is found within 8 iterations.
// Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic. // Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic.
return idx is null ? null : channel + idx.Value; return idx is null ? null : channel + idx.Value; // null if not found, otherwise new channel
} }
default: default:
return channel; return channel;
@@ -533,11 +534,7 @@ internal sealed unsafe class Chat : IDisposable
internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null) internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null)
{ {
// ExtraChat linkshells aren't supported in game so we never want to // Ignore ExtraChat linkshells (use ChatLogWindow.SetChannel() instead)
// call the ChangeChatChannel function with them.
//
// Callers should call ChatLogWindow.SetChannel() which handles
// ExtraChat channels
if (channel.IsExtraChatLinkshell()) if (channel.IsExtraChatLinkshell())
return; return;
@@ -546,12 +543,17 @@ internal sealed unsafe class Chat : IDisposable
if (idx == uint.MaxValue) if (idx == uint.MaxValue)
idx = 0; idx = 0;
if (!ValidAnyLinkshell(channel)) // ---------------------------------------------------------------
return; // Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Wrap ChangeChatChannel in the validity check instead of
// early-returning. The previous early return skipped Dtor and
// leaked the native Utf8String allocated a few lines above.
// ---------------------------------------------------------------
if (IsChannelOrExistingLinkshell(channel))
RaptureShellModule
.Instance()
->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true);
RaptureShellModule
.Instance()
->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true);
target->Dtor(true); target->Dtor(true);
} }
@@ -565,9 +567,6 @@ internal sealed unsafe class Chat : IDisposable
bool setChatType bool setChatType
) )
{ {
// param6 is 0 for contentId and 1 for objectId
// param7 is always 0 ?
if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel) if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel)
Plugin.CurrentTab.CurrentChannel.UseTempChannel = true; Plugin.CurrentTab.CurrentChannel.UseTempChannel = true;
@@ -629,7 +628,7 @@ internal sealed unsafe class Chat : IDisposable
if (contentId == 0) if (contentId == 0)
{ {
Plugin.ChatGui.PrintError(Language.Chat_SendTell_Error); Plugin.ChatGui.PrintError(Language.Chat_SendTell_Error);
Plugin.Log.Warning( _logger.LogWarning(
"Tried to send a tell with ContentId being 0, sorry this is an internal error." "Tried to send a tell with ContentId being 0, sorry this is an internal error."
); );
return; return;
@@ -742,10 +741,7 @@ internal sealed unsafe class Chat : IDisposable
internal bool CheckHideFlags() internal bool CheckHideFlags()
{ {
// Only hide the chat in a cutscene when the vanilla chat would've // Only hide chat in cutscene when vanilla chat would also be hidden
// also been hidden. This prevents Chat 2 from hiding for a split
// second before the cutscene actually starts, because the game sets
// the cutscene conditions before processing the skip.
var raptureAtkUnitManager = RaptureAtkUnitManager.Instance(); var raptureAtkUnitManager = RaptureAtkUnitManager.Instance();
return raptureAtkUnitManager == null return raptureAtkUnitManager == null
|| raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat); || raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat);
+3 -12
View File
@@ -15,17 +15,10 @@ public unsafe class ChatBox
mes->Dtor(true); mes->Dtor(true);
} }
public static void SendMessage(string message) public static void SendMessage(string message) => SendMessageUnsafe(ValidateMessage(message));
{
var bytes = ValidateMessage(message);
SendMessageUnsafe(bytes);
}
// Validation split out so the deterministic checks (UTF-8 length, sanitise // sanitiserOverride allows xUnit to bypass Utf8String->SanitizeString (game memory only).
// round-trip) can run in xUnit without ClientStructs game memory. The // Returns encoded bytes so SendMessage avoids a second GetBytes call.
// sanitiser is injectable so tests can pin throw behaviour without invoking
// Utf8String->SanitizeString, which only resolves in-process. Returns the
// already-encoded bytes so SendMessage doesn't pay GetBytes twice.
// TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs // TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs
internal static byte[] ValidateMessage( internal static byte[] ValidateMessage(
string message, string message,
@@ -49,11 +42,9 @@ public unsafe class ChatBox
private static string SanitiseText(string text) private static string SanitiseText(string text)
{ {
var uText = Utf8String.FromString(text); var uText = Utf8String.FromString(text);
uText->SanitizeString((AllowedEntities)0x27F); uText->SanitizeString((AllowedEntities)0x27F);
var sanitised = uText->ToString(); var sanitised = uText->ToString();
uText->Dtor(true); uText->Dtor(true);
return sanitised; return sanitised;
} }
} }
+31 -60
View File
@@ -14,6 +14,7 @@ using FFXIVClientStructs.FFXIV.Client.UI.Info;
using FFXIVClientStructs.FFXIV.Component.GUI; using FFXIVClientStructs.FFXIV.Component.GUI;
using Lumina.Excel; using Lumina.Excel;
using Lumina.Excel.Sheets; using Lumina.Excel.Sheets;
using Microsoft.Extensions.Logging;
using ValueType = FFXIVClientStructs.FFXIV.Component.GUI.AtkValueType; using ValueType = FFXIVClientStructs.FFXIV.Component.GUI.AtkValueType;
namespace HellionChat.GameFunctions; namespace HellionChat.GameFunctions;
@@ -37,17 +38,22 @@ internal unsafe class GameFunctions : IDisposable
#endregion #endregion
private Plugin Plugin { get; } private Plugin Plugin { get; }
private readonly ILogger<GameFunctions> _logger;
internal KeybindManager KeybindManager { get; } internal KeybindManager KeybindManager { get; }
internal Chat Chat { get; } internal Chat Chat { get; }
internal GameFunctions(Plugin plugin) internal GameFunctions(
Plugin plugin,
ILogger<GameFunctions> logger,
ILoggerFactory loggerFactory
)
{ {
Plugin = plugin; Plugin = plugin;
KeybindManager = new KeybindManager(plugin); _logger = logger;
Chat = new Chat(Plugin); KeybindManager = new KeybindManager(plugin, loggerFactory.CreateLogger<KeybindManager>());
Chat = new Chat(Plugin, loggerFactory.CreateLogger<Chat>());
Plugin.GameInteropProvider.InitializeFromAttributes(this); Plugin.GameInteropProvider.InitializeFromAttributes(this);
ResolveTextCommandPlaceholderHook?.Enable(); ResolveTextCommandPlaceholderHook?.Enable();
} }
@@ -55,36 +61,24 @@ internal unsafe class GameFunctions : IDisposable
{ {
Chat.Dispose(); Chat.Dispose();
KeybindManager.Dispose(); KeybindManager.Dispose();
ResolveTextCommandPlaceholderHook?.Dispose(); ResolveTextCommandPlaceholderHook?.Dispose();
Marshal.FreeHGlobal(PlaceholderNamePtr); Marshal.FreeHGlobal(PlaceholderNamePtr);
} }
internal void SendFriendRequest(string name, ushort world) internal void SendFriendRequest(string name, ushort world) =>
{
ListCommand(name, world, "friendlist"); ListCommand(name, world, "friendlist");
}
internal void AddToBlacklist(string name, ushort world) internal void AddToBlacklist(string name, ushort world) => ListCommand(name, world, "blist");
{
ListCommand(name, world, "blist");
}
internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId) internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId) =>
{
AgentMutelist.Instance()->Add(accountId, contentId, name, worldId); AgentMutelist.Instance()->Add(accountId, contentId, name, worldId);
}
internal void AddToTermsList(SeString content) internal void AddToTermsList(SeString content) =>
{
AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator()); AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator());
}
private void ListCommand(string name, ushort world, string commandName) private void ListCommand(string name, ushort world, string commandName)
{ {
var worldRow = Sheets.WorldSheet.GetRow(world); var worldRow = Sheets.WorldSheet.GetRow(world);
ReplacementName = $"{name}@{worldRow.Name.ToString()}"; ReplacementName = $"{name}@{worldRow.Name.ToString()}";
ChatBox.SendMessage($"/{commandName} add {Placeholder}"); ChatBox.SendMessage($"/{commandName} add {Placeholder}");
} }
@@ -108,7 +102,6 @@ internal unsafe class GameFunctions : IDisposable
{ {
for (var i = 0; i < 4; i++) for (var i = 0; i < 4; i++)
SetAddonInteractable($"ChatLogPanel_{i}", interactable); SetAddonInteractable($"ChatLogPanel_{i}", interactable);
SetAddonInteractable("ChatLog", interactable); SetAddonInteractable("ChatLog", interactable);
} }
@@ -124,7 +117,6 @@ internal unsafe class GameFunctions : IDisposable
var agent = AgentItemDetail.Instance(); var agent = AgentItemDetail.Instance();
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
// atkStage ain't gonna be null or we have bigger problems
if (agent == null || addon == null) if (agent == null || addon == null)
return; return;
@@ -133,23 +125,19 @@ internal unsafe class GameFunctions : IDisposable
agent->Index = 0; agent->Index = 0;
agent->Flag1 &= 0xEF; agent->Flag1 &= 0xEF;
agent->ItemId = id; agent->ItemId = id;
// agent->Flag2 = 1;
// agent->Flag3 = 0; // TODO: Revert when CS offset lands in a release build.
// TODO: Revert whenever CS is merged
*(byte*)((nint)agent + 0x21A) = 1; *(byte*)((nint)agent + 0x21A) = 1;
*(byte*)((nint)agent + 0x21E) = 0; *(byte*)((nint)agent + 0x21E) = 0;
// This just probably needs to be set
agent->AddonId = addon->Id; agent->AddonId = addon->Id;
// Skips early return
atkStage->TooltipManager.TooltipType |= 2; atkStage->TooltipManager.TooltipType |= 2;
addon->Show(false, 15); addon->Show(false, 15);
} }
internal static void CloseItemTooltip() internal static void CloseItemTooltip()
{ {
// hide addon first to prevent the "addon close" sound // Hide addon first to suppress the "addon close" sound.
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
if (addon != null) if (addon != null)
addon->Hide(true, false, 0); addon->Hide(true, false, 0);
@@ -167,7 +155,7 @@ internal unsafe class GameFunctions : IDisposable
internal static void OpenPartyFinder() internal static void OpenPartyFinder()
{ {
// this whole method: 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01) // 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01)
var lfg = AgentLookingForGroup.Instance(); var lfg = AgentLookingForGroup.Instance();
if (lfg->IsAgentActive()) if (lfg->IsAgentActive())
{ {
@@ -188,15 +176,10 @@ internal unsafe class GameFunctions : IDisposable
} }
} }
internal static bool IsMentor() internal static bool IsMentor() => PlayerState.Instance()->IsMentor();
{
return PlayerState.Instance()->IsMentor();
}
internal static InfoProxyCommonList.CharacterData[] GetFriends() internal static InfoProxyCommonList.CharacterData[] GetFriends() =>
{ InfoProxyFriendList.Instance()->CharDataSpan.ToArray();
return InfoProxyFriendList.Instance()->CharDataSpan.ToArray();
}
internal static void OpenQuestLog(RowRef<Quest> quest) internal static void OpenQuestLog(RowRef<Quest> quest)
{ {
@@ -223,20 +206,12 @@ internal unsafe class GameFunctions : IDisposable
AgentQuestJournal.Instance()->OpenForQuest(questId, 1); AgentQuestJournal.Instance()->OpenForQuest(questId, 1);
} }
internal static void OpenPartyFinder(uint id) internal static void OpenPartyFinder(uint id) =>
{
AgentLookingForGroup.Instance()->OpenListing(id); AgentLookingForGroup.Instance()->OpenListing(id);
}
internal static void OpenAchievement(uint id) internal static void OpenAchievement(uint id) => AgentAchievement.Instance()->OpenById(id);
{
AgentAchievement.Instance()->OpenById(id);
}
internal static bool IsInInstance() internal static bool IsInInstance() => Plugin.Condition[ConditionFlag.BoundByDuty56];
{
return Plugin.Condition[ConditionFlag.BoundByDuty56];
}
internal static bool TryOpenAdventurerPlate(ulong playerId) internal static bool TryOpenAdventurerPlate(ulong playerId)
{ {
@@ -247,7 +222,8 @@ internal unsafe class GameFunctions : IDisposable
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Warning(e, "Unable to open adventurer plate"); // Static method, no instance _logger reachable here.
Plugin.LogProxy.Warning(e, "Unable to open adventurer plate");
return false; return false;
} }
} }
@@ -255,8 +231,7 @@ internal unsafe class GameFunctions : IDisposable
internal static void ClickNoviceNetworkButton() internal static void ClickNoviceNetworkButton()
{ {
var agent = AgentChatLog.Instance(); var agent = AgentChatLog.Instance();
// case 3 var value = new AtkValue { Type = ValueType.Int, Int = 3 }; // case 3
var value = new AtkValue { Type = ValueType.Int, Int = 3 };
var result = 0; var result = 0;
var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*) var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*)
agent->VirtualTable; agent->VirtualTable;
@@ -275,9 +250,8 @@ internal unsafe class GameFunctions : IDisposable
byte a4 byte a4
) )
{ {
// The detour is only invoked through the hook, so the hook should // Hook field is nullable due to the Signature attribute, but will never
// never be null here, but the nullable field declaration forces us // be null during normal execution; guard covers the teardown race only.
// to handle the theoretical race during teardown.
if (ResolveTextCommandPlaceholderHook is null) if (ResolveTextCommandPlaceholderHook is null)
return nint.Zero; return nint.Zero;
@@ -285,13 +259,11 @@ internal unsafe class GameFunctions : IDisposable
if (ReplacementName == null || placeholder != Placeholder) if (ReplacementName == null || placeholder != Placeholder)
return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4); return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4);
// The fixed buffer is 128 bytes; UTF-8 + null-terminator must fit. // Guard against a malformed ReplacementName overflowing the 128-byte buffer.
// FFXIV player names plus an @World suffix should never approach this
// limit, but a malformed ReplacementName must not overflow the buffer.
var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName); var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName);
if (byteCount >= PlaceholderBufferSize) if (byteCount >= PlaceholderBufferSize)
{ {
Plugin.Log.Warning( _logger.LogWarning(
$"Replacement name too long for placeholder buffer ({byteCount} bytes >= {PlaceholderBufferSize}); falling back to original." $"Replacement name too long for placeholder buffer ({byteCount} bytes >= {PlaceholderBufferSize}); falling back to original."
); );
ReplacementName = null; ReplacementName = null;
@@ -300,7 +272,6 @@ internal unsafe class GameFunctions : IDisposable
MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName); MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName);
ReplacementName = null; ReplacementName = null;
return PlaceholderNamePtr; return PlaceholderNamePtr;
} }
} }
+6 -2
View File
@@ -8,6 +8,7 @@ using FFXIVClientStructs.FFXIV.Client.UI;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.GameFunctions.Types; using HellionChat.GameFunctions.Types;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
using ModifierFlag = HellionChat.GameFunctions.Types.ModifierFlag; using ModifierFlag = HellionChat.GameFunctions.Types.ModifierFlag;
namespace HellionChat.GameFunctions; namespace HellionChat.GameFunctions;
@@ -306,9 +307,12 @@ internal unsafe class KeybindManager : IDisposable
// VirtualKey.OEM_CLEAR, // VirtualKey.OEM_CLEAR,
}; };
internal KeybindManager(Plugin plugin) private readonly ILogger<KeybindManager> _logger;
internal KeybindManager(Plugin plugin, ILogger<KeybindManager> logger)
{ {
Plugin = plugin; Plugin = plugin;
_logger = logger;
Plugin.GameInteropProvider.InitializeFromAttributes(this); Plugin.GameInteropProvider.InitializeFromAttributes(this);
// Handle keybinds from the game on every tick. // Handle keybinds from the game on every tick.
@@ -507,7 +511,7 @@ internal unsafe class KeybindManager : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in chat Activated event"); _logger.LogError(ex, "Error in chat Activated event");
} }
} }
@@ -40,5 +40,11 @@ public class TellTarget
public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct); public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct);
public static TellTarget From(TellTarget t) => new(t.Name, t.World, t.ContentId, t.Reason); // ---------------------------------------------------------------
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Replaced static From(t) with an instance-style Clone() so call
// sites read like a copy operation, not a factory.
// TEST-MIRROR: ../../../Hellion Build test/_Helpers/TellTargetCloneTests.cs
// ---------------------------------------------------------------
public TellTarget Clone() => new(Name, World, ContentId, Reason);
} }
+17 -41
View File
@@ -1,36 +1,29 @@
<Project Sdk="Dalamud.NET.Sdk/15.0.0"> <Project Sdk="Dalamud.NET.Sdk/15.0.0">
<PropertyGroup> <PropertyGroup>
<!-- Hellion Chat versioning runs separately from upstream Chat 2. <!-- Independent versioning; see yaml changelog for upstream Chat 2 base -->
0.1.0 is our bootstrap release; the underlying Chat 2 base is <Version>1.5.0</Version>
called out in the yaml changelog so users can see what it
derives from. -->
<Version>1.4.3</Version>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<!-- Honor packages.lock.json on restore so floating version ranges <!-- Use lock file to pin exact versions -->
don't silently drift between machines or CI runs. -->
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<!-- v1.0.0 standalone cut — both AssemblyName and RootNamespace <!-- v1.0.0+: standalone fork, no upstream cherry-pick compatibility -->
are HellionChat. The plugin no longer maintains source-level
cherry-pick compatibility with upstream Infiziert90/ChatTwo;
upstream changes are integrated manually if at all. -->
<AssemblyName>HellionChat</AssemblyName> <AssemblyName>HellionChat</AssemblyName>
<RootNamespace>HellionChat</RootNamespace> <RootNamespace>HellionChat</RootNamespace>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<!-- Closed ranges on packages with breaking-change history block a <!-- Closed ranges prevent surprise major bumps during lock file regeneration -->
surprise major bump when the lock file is regenerated. The
lock file pins the exact version per build; the upper bound
keeps the unlock path from drifting across major lines. -->
<PackageReference Include="MessagePack" Version="[3.1.4, 4.0.0)" /> <PackageReference Include="MessagePack" Version="[3.1.4, 4.0.0)" />
<PackageReference Include="Microsoft.Data.Sqlite" Version="10.0.7" /> <PackageReference Include="Microsoft.Data.Sqlite" Version="10.0.7" />
<!-- Override the transitively-referenced native SQLite build to one <!-- v1.5.0 DI-container foundation; matches Lightless pin (Hosting 10.0.7) -->
that ships SQLite >= 3.50.3 (CVE-2025-6965 memory corruption, <PackageReference
CVE-2025-7709 fixed in 3.50.x). Microsoft.Data.Sqlite 10.0.7 Include="Microsoft.Extensions.DependencyInjection"
pulls SQLitePCLRaw 2.1.11 which carries the older lib; pinning Version="[10.0.7, 11.0.0)"
the lib package directly forces the newer native binary />
without a major bump on the managed wrapper. --> <PackageReference Include="Microsoft.Extensions.Hosting" Version="[10.0.7, 11.0.0)" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="[10.0.7, 11.0.0)" />
<PackageReference Include="Microsoft.Extensions.Options" Version="[10.0.7, 11.0.0)" />
<!-- SQLitePCLRaw override for CVE-2025-6965, CVE-2025-7709 (SQLite >= 3.50.3) -->
<PackageReference Include="SQLitePCLRaw.lib.e_sqlite3" Version="3.50.3" /> <PackageReference Include="SQLitePCLRaw.lib.e_sqlite3" Version="3.50.3" />
<PackageReference Include="morelinq" Version="4.4.0" /> <PackageReference Include="morelinq" Version="4.4.0" />
<PackageReference Include="Pidgin" Version="[3.5.1, 4.0.0)" /> <PackageReference Include="Pidgin" Version="[3.5.1, 4.0.0)" />
@@ -38,9 +31,7 @@
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>
<!-- Pure-function test suites in HellionChat.Tests need access to <!-- Test assembly needs access to internal helpers (not redistributed) -->
the internal helper classes (StringUtil, UriPayload, Tokenizer
etc.). Test assembly does not get redistributed. -->
<InternalsVisibleTo Include="HellionChat.Tests" /> <InternalsVisibleTo Include="HellionChat.Tests" />
</ItemGroup> </ItemGroup>
@@ -59,15 +50,7 @@
</EmbeddedResource> </EmbeddedResource>
</ItemGroup> </ItemGroup>
<!-- HellionChat — Hellion-specific resource bundle (HellionStrings.resx <!-- Embedded resources: Hellion font (Exo 2, OFL-1.1) + manifest resource -->
+ HellionStrings.<lang>.resx) is picked up automatically by the SDK
default include. Designer.cs is hand-maintained, no auto-gen needed. -->
<!-- Bundled Hellion font (Exo 2, OFL-1.1). Embedded as a manifest
resource with a fixed LogicalName so FontManager can pull the
bytes back at runtime via AddFontFromMemory. The OFL license
text travels with it inside the assembly to satisfy the
"license must be distributed with the font" clause. -->
<ItemGroup> <ItemGroup>
<EmbeddedResource Include="Resources\HellionFont.ttf"> <EmbeddedResource Include="Resources\HellionFont.ttf">
<LogicalName>HellionFont.ttf</LogicalName> <LogicalName>HellionFont.ttf</LogicalName>
@@ -80,14 +63,7 @@
</EmbeddedResource> </EmbeddedResource>
</ItemGroup> </ItemGroup>
<!-- Plugin icon. Copy images/* into the build output so Dalamud <!-- Plugin icon: copy images/* to output for Dalamud discovery -->
finds the icon next to the DLL, and let the SDK default
DalamudPackager pipeline include the same path in the
release ZIP. Earlier we shipped a custom DalamudPackager
targets override that explicitly set HandleImages and
ImagesPath; that override conflicted with the SDK 15
default and the resulting manifest carried no IconUrl.
Removed in v0.5.2. -->
<ItemGroup> <ItemGroup>
<None Include="images\**"> <None Include="images\**">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+169 -188
View File
@@ -1,77 +1,26 @@
name: Hellion Chat name: Hellion Chat
author: JonKazama-Hellion author: Jon Kazama (Hellion Forge)
punchline: Chat replacement with privacy controls aligned to EU, US and JP rules — based on Chat 2 (EUPL-1.2) punchline: A Hellion Forge plugin — privacy-focused chat replacement for FFXIV, built for EU, US and JP data rules.
description: |- description: |-
Hellion Chat is a privacy-focused chat replacement for FINAL FANTASY XIV Chat replacement for FINAL FANTASY XIV with privacy controls built around
based on the Chat 2 codebase (EUPL-1.2). One feature is intentionally EU, US and JP data-protection rules.
removed (the optional webinterface) and a stack of privacy controls is
added on top. Tabs, channel filters, RGB colours, emotes, screenshot
mode, IPC integration and the chat replacement window itself work the
same. The webinterface is intentionally not part of Hellion Chat because
it serves a different use case from the smaller default footprint this
plugin is built around.
On top of that, Hellion Chat adds privacy and data-handling controls By default only your own conversations are stored. Public chat, NPC
designed to align with the modern data protection rules that apply dialogue and system messages stay out of the database unless you opt in.
across the EU, the United States and Japan. By default only your own Retention windows are configurable per channel, history can be wiped
conversations are stored; messages from strangers, NPCs and system retroactively, and everything can be exported on demand.
spam stay out of the database. Retention windows are configurable per
channel, history can be wiped retroactively, and stored data can be
exported on demand.
Key privacy and data-handling features:
Features:
- Channel whitelist with a Privacy-First default - Channel whitelist with a Privacy-First default
- Per-channel retention with a daily background sweep - Per-channel retention with a daily background sweep
- Retroactive cleanup with a Ctrl+Shift confirm - Retroactive cleanup (Ctrl+Shift confirm)
- Export to Markdown, JSON or CSV - Export to Markdown, JSON or CSV
- First-run wizard with three preset profiles (Privacy-First, Casual, - First-run wizard with three preset profiles
Full History) - Bilingual UI (EN/DE) with live language switching
- Bilingual UI (English and German) with live language switching - Own config and database — no shared state with other plugins
- Independent plugin state — own config file and database directory,
so Hellion Chat does not share state with upstream Chat 2
v1.3.0 First plugin integration cycle. Honorific custom titles Based on Chat 2 by Infi and Anna (EUPL-1.2).
are shown in the chat header above the message log, with auto-detect Support: https://discord.gg/X9V7Kcv5gR
and silent fallback when Honorific is not installed.
v1.4.0 — Critical Lifecycle Fixes. Plugin reload and shutdown
are cleaner: SQLite no longer leans on GC pressure to release
its file, worker threads are explicitly background, deferred
config saves no longer get lost mid-disable, and pre-v13 config
backups carry the user's custom theme opacity into the v14 schema
instead of falling back to the default.
v1.4.1 — Theme Engine Performance plus a tenth built-in.
HellionStyle.PushGlobal reads pre-computed ABGR values from a
per-theme cache instead of converting RGBA per slot per frame
(~13 % render-time recovery in typical scenes). Custom-theme
hot-reload survives transient file locks (editor mid-save
keeps the last-known-good snapshot). Synthwave Sunset joins
as the tenth built-in theme — Hot Magenta + Cyan on midnight
violet, 80s neon-grid vibes.
v1.4.2 — ChatLog Frame-Hot-Path. Three per-frame allocation
patterns gone from the chat-log render path: card-mode borders
hoist invariants out of the per-message loop, auto-tell tab
tint and icon get a per-tab cache, and the status bar gates
its tab aggregation behind the same one-second cache it uses
for the format strings.
v1.4.3 — Plugin-Load Async-Init plus Repo-Cutover. Plugin
migrated to Dalamud's IAsyncDalamudPlugin so the heavy work
(migrations, service allocations, window construction, hook
subscription) runs in LoadAsync without blocking Dalamud's
UI. Schema-gate replaces the v9 → v16 migration chain;
configs on schema v16+ load directly. Custom-repo URL moves
to gitea.hellion-forge.cloud, the GitHub repo stays as a
frozen v1.4.2 snapshot.
Based on Chat 2 by Infi and Anna, licensed under EUPL-1.2.
Modding & support: join the Hellion Forge Discord at
https://discord.gg/X9V7Kcv5gR — community for Hellion Chat and
other Hellion Online Media plugins/tools.
repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat
accepts_feedback: true accepts_feedback: true
icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png
@@ -86,136 +35,168 @@ tags:
- Replacement - Replacement
- Privacy - Privacy
changelog: |- changelog: |-
**Hellion Chat 1.4.3 — Plugin-Load Async-Init + Repo-Cutover (2026-05-08)** **v1.5.0 — DI Foundation and Service Refactor (2026-05-17)**
Plugin lifecycle migrated to Dalamud's `IAsyncDalamudPlugin` Major architecture cycle. The plugin bootstrap moves to a
API. The constructor now does only the bootstrap-essentials generic-host DI container (Microsoft.Extensions.Hosting +
(config load, language init, conflict detection); migrations, IServiceCollection) modelled on Lightless Sync. Service logging
service allocations, window construction and hook subscription moves from a static Plugin.LogProxy locator to typed
move to LoadAsync. Dalamud can keep its UI responsive while the Microsoft.Extensions.Logging.ILogger<T> via constructor injection,
heavy work runs. bridged over Dalamud's IPluginLog by a custom DalamudLogger trio.
- IAsyncDalamudPlugin two-phase load with per-line CaptureFailure What changes under the hood:
in DisposeAsync (mirrors LightlessSync's pattern); idempotency
guard protects against reload races
- Schema-gate replaces the v9 → v16 migration chain. Configs
on schema v16+ load directly; older configs trigger an
"install v1.4.2 first" error so the historic migration
path stays intact
- AutoTranslate.PreloadCache moved off the load path. First
use may have a sub-second hitch instead of every-load; the
upstream chose differently, we accept first-use latency
- FontManager.BuildFonts is called sync at the start of
LoadAsync; Dalamud rebuilds the font atlas on its own
pipeline so the custom Hellion-Exo2 font appears with a
brief font-pop after load (matches ChatTwo's behaviour)
- Custom-repo URL moved to gitea.hellion-forge.cloud/
JonKazama-Hellion/HellionChat. GitHub repo stays as a
frozen v1.4.2 snapshot; new releases ship from Gitea.
Existing testers need to update the custom-repo URL once
- Plugin-load time in this release sits at ~3.7 s median
(5 reloads), comparable to v1.4.2. Async migration is
foundational for v1.4.4 Lazy-Init optimisations rather
than an immediate user-perceived win
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR - 18 instance-class services migrate to ILogger<T> via constructor
injection across four slices: data layer (MessageStore,
MessageManager, AutoTellTabsService), IPC and integrations
(HonorificService, IpcManager, TypingIpc, ExtraChat, the three
GameFunctions classes), UI window layer (ChatLogWindow,
DbViewer, Popout, three settings tabs), and root (Commands,
ThemeRegistry, PayloadHandler).
- Plugin.LogProxy stays in place for the eight buckets ctor
injection cannot reach: static helpers (EmoteCache,
AutoTranslate, MemoryUtil, WrapperUtil), Dalamud-reflected
types (Configuration), the Message data class, and instance
classes that only log from static methods (FontManager, one
GameFunctions site).
- Plugin.cs finishes at 1012 lines — virtually identical to the
pre-cycle 1013. The new Phase-1 host build and Plugin.X bridge
wiring trade out exactly the service and window allocations
that previously lived in LoadAsync.
- Cross-plugin baseline confirms no performance penalty against
Chat 2: HellionChat first-frame HITCH 77 ms median, Chat 2
74 ms median. Lightless and XIVInstantMessenger sit around
7 ms by deferring their font-atlas build past Finished
loading — that pattern is the v1.5.1 follow-up.
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2). User-visible:
**Hellion Chat 1.4.2 — ChatLog Frame-Hot-Path** - Slash-command insert fix: pasting a slash command into the
chat input (Friend List "/tell" action, plugin-driven inserts
from Artisan, AllaganTools etc.) now replaces the existing
input instead of concatenating. Cherry-picked from ChatTwo
upstream ee7768ac with namespace adaptation.
Third sub-patch of the v1.4.x Polish Sweep series. Per-frame Migration v17 stays (no schema bump).
allocations from the chat-log render path eliminated.
- DrawMessages card-mode hoists theme/drawList/winLeft/winRight/
borderColorAbgr out of the per-message loop. About 500
redundant calls per frame at 100 visible messages, multiplied
by every pop-out window
- Auto-tell tab tint and icon use a per-tab cache. Hash
computation and string allocation only happen when the tell
target name or world drifts. AutoTellTabTint stays a pure
hash helper; cache lives in a thin TabTintCache wrapper
- Status bar gates its tab aggregation behind the same
one-second cache it already used for the format strings.
LINQ Sum and Count replaced with a single foreach pass
that runs on roughly 1% of frames
Realistic frame-time recovery: 2-5% in typical scenes, more
on pop-out-heavy setups because the card-border hoist scales
per window.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 1.4.1 — Theme Engine Performance**
Second sub-patch of the v1.4.x Polish Sweep series. Heap
pressure from the theme engine's per-frame render path
removed, plus a tenth built-in theme and hardening for
the custom-theme hot-reload.
- Theme records carry a pre-computed ABGR-packed cache
for every color slot; cache is filled when the theme
is registered and refreshed defensively on every
Switch()
- HellionStyle.PushGlobal reads ABGR values from the
cache instead of calling ColourUtil.RgbaToAbgr per
slot per frame; ~13 % render-time recovery measured
in typical scenes (plan estimate was 26 %, real
~1015 %)
- ThemeRegistry custom-theme reload distinguishes a
recoverable file lock (editor mid-save) from a
permanent IO failure; locked themes keep their
last-known-good snapshot and retry on the next
lookup instead of dropping out of the picker
- New built-in: Synthwave Sunset — Hot Magenta + Cyan
on midnight violet, 80s neon-grid vibes; tenth theme
in the picker
- Author credits refreshed: brand themes are credited
as "Hellion Forge"; Mint Grove and Forge Merchantman
now credited to Carla Beleandis as a community thanks
No schema bump, no user-visible behaviour change other
than smoother frames on GC-sensitive setups and one
additional colour option.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 1.4.0 — Critical Lifecycle Fixes**
First sub-patch of the v1.4.x Polish Sweep series. Seven
known lifecycle and race bugs eliminated before any
performance refactor sits on top.
- MessageStore disposal no longer triggers GC.Collect
globally; Pooling=false on the SQLite connection means
there's nothing left to clean up by hand
- PendingMessage and RetentionSweep worker threads are
explicitly marked IsBackground=true so the plugin domain
can unload during XIVLauncher reload without waiting
for them
- EmoteCache image and gif loaders moved from async-void
to async Task with a shared task tracker, draining
on Dispose so an in-flight load can no longer write
to a disposed EmoteImages entry
- DisposeAsync 10s timeout now warns loudly instead of
silently leaving the worker behind
- Plugin.Dispose flushes any pending DeferredSaveFrames
before tearing services down, so settings changes
made in the last few frames before disable are no
longer lost
- The v13→v14 config migration now reads the pre-v13
backup and carries HellionThemeWindowOpacity into the
new WindowOpacity field instead of falling back to
the default 0.85
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2). Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
--- ---
Earlier history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases **v1.4.10 — Symbol-Picker and Tell-History Fix (2026-05-16)**
Eleventh and final sub-patch of the v1.4.x polish-sweep series.
Symbol picker for the chat input, a tell-history reload fix for
users with many active partners, and a closing cleanup sweep
before v1.5.0 picks up the DI-container adoption.
- Symbol picker: a small smile-icon button left of the channel
indicator opens a popup with two tabs. The first lists all 161
FFXIV PUA glyphs (Dalamud's SeIconChar enum); the second
carries 97 server-verified BMP symbols (latin marks, currency,
the full Greek alphabet, geometric shapes, suits, notes) —
every one of them round-tripped through /echo and /say in a
four-round probe so the in-channel render matches what the
picker shows. Click drops the glyph at the caret, multi-insert
keeps the popup open, and a recent-used strip floats the last
sixteen picks across both tabs. Toggle in Settings → Chat →
Message behaviour, default on.
- Pinned auto-tell tabs reload their full history again: a
hidden 500-row scan cap in PreloadHistory used to override the
user-configurable AutoTellTabsHistoryPreload setting, so
less-frequent pinned partners (rare /tell sessions in an
otherwise busy week) lost their backlog. The cap is removed;
the (Receiver, Date) index keeps SQL fast, the client-side
loop still respects your setting as the upper bound.
- Slash-command teardown: /hellion, /hellionView,
/hellionDebugger (and #if DEBUG /hellionSeString) wrappers are
now cached as private fields. Plugin teardown detaches the
live registration instead of re-Register'ing with identical
args — closes a latent maintenance hazard from v1.4.9.
- v1.4.x polish-sweep wraps up here. The ImGuiListClipper render
refactor that was on the v1.4.10 reserve list got dropped
after cross-platform smoke showed the scroll rubber-band is a
Wine / Linux render-pipeline quirk, not universal — Windows
users never saw it. It will get its own platform-targeted
spike in a later patch. Next major cycle is v1.5.0 with the
DI-container adoption (Microsoft.Extensions.Hosting +
ILogger<T>) modelled on Lightless.
- Migration v17 stays (no schema bump).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
**v1.4.9 — Plugin-Load Render Polish (2026-05-15)**
Tenth sub-patch of the v1.4.x polish-sweep series. First-frame
render cost drops from ~127 ms median to ~76 ms median,
comfortably under Dalamud's 100 ms HITCH warning threshold.
- First-frame defer: six non-essential rendering sections inside
ChatLogWindow skip their first Draw and run one frame later
(bottom status bar, channel-name SeString chunks, window bounds
check, v0.6.1 hint banner, autocomplete, input-preview
calculation). User-visible delay is ~17 ms at 60 fps, hidden
inside the post-reload font-atlas build window.
- Slash-command centralisation: /hellion, /hellionView,
/hellionSeString and /hellionDebugger are registered in
LoadAsync instead of inside the corresponding window
constructors. The plugin-manager Open and configuration buttons
hang on the same path.
- Plugin-load profiling logs stay on at Information level
(MessageStore connect/migrate, FilterAllTabs, auto-translate
warmup) as a regression tripwire — a future load past 100 ms
will show up in /xllog without a Debug filter.
- ChatTwo IPC compatibility layer: HellionChat now mirrors
ChatTwo's full IPC surface (GetChatInputState,
ChatInputStateChanged, Register, Unregister, Available,
Invoke) under the ChatTwo.* namespace in addition to our
existing HellionChat.* provider gates. Third-party
integrations that historically only subscribe to ChatTwo's
IPC — for example Artisan's and AllaganTools' context-menu
hooks — keep working without requiring a code change on their
side. Conflict detection prevents ChatTwo from loading in
parallel with HellionChat, so there is no slot-collision risk
at runtime.
- Migration v17 stays (no schema bump).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
**v1.4.8 — Hook-Layer and Polish Quick-Wins (2026-05-14)**
Ninth sub-patch of the v1.4.x polish-sweep series. Hook-layer
cluster (DbViewer FTS5 full-text search, ad-block foundation
investigation) plus three polish quick-wins.
- DbViewer full-text search: optional FTS5 index across the full
chat history. Built asynchronously on first load after the
update with a progress toast. The local page-filter remains
available as the default mode. Queries match as exact phrases
-- multi-word terms must appear together in order; advanced
users can opt into raw FTS5 MATCH syntax by wrapping their own
double-quotes.
- Custom theme files now auto-reload when edited while the theme
is active -- no need to re-click the theme in the picker.
- Retention sweep no longer blocks the framework thread, removing
the ~194ms mini-hitch per sweep.
- Status bar renders correctly at Windows display scaling > 100%.
- Receive-suppressed-tells routing investigated this cycle and
postponed to v1.5.x: when other plugins suppress tells via
CheckMessageHandled, the FFXIV chat pipeline skips the
RaptureLogModule.AddMsgSourceEntry path so HellionChat's
ContentIdResolverHook does not fire and tell-partner
identification breaks. The fix belongs next to the planned
ad-block hook layer where the same patch surface comes up.
- Internal: messages.Id is declared BLOB but stored as TEXT
(Microsoft.Data.Sqlite Guid binding). FTS bulk insert and
LoadByGuids match the TEXT storage form on both sides.
Migration v17 stays (no schema bump).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
Full history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases
@@ -0,0 +1,98 @@
using Dalamud.Plugin;
using HellionChat.Ipc;
using HellionChat.Themes;
using Microsoft.Extensions.Hosting;
namespace HellionChat.Infrastructure.Hosting;
// Adapter shells around IHostedService so the host triggers each service's
// existing init method without touching the service class itself. Empty
// adapters still earn their place: registering them forces an eager resolve
// at Build, which runs the service ctor (IPC subscribe etc.) right then
// instead of lazily on first GetRequiredService.
internal sealed class FontManagerInitHostedService(FontManager fontManager) : IHostedService
{
public Task StartAsync(CancellationToken cancellationToken)
{
fontManager.BuildFonts();
return Task.CompletedTask;
}
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
internal sealed class ThemeRegistryInitHostedService(ThemeRegistry registry) : IHostedService
{
public Task StartAsync(CancellationToken cancellationToken)
{
// Materialise the lazy AllCustom enumerable so the slug lookup hits a
// warm cache; otherwise the first Switch falls through to the built-in
// default when Config.Theme points at a custom slug.
foreach (var _ in registry.AllCustom()) { }
registry.Switch(Plugin.Config.Theme);
return Task.CompletedTask;
}
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
// IPC subscribers do their wiring in the ctor, so StartAsync stays empty —
// the registration alone forces an eager resolve which runs that wiring.
internal sealed class IpcManagerInitHostedService(IpcManager ipc) : IHostedService
{
private readonly IpcManager _ipc = ipc;
public Task StartAsync(CancellationToken cancellationToken) => Task.CompletedTask;
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
internal sealed class TypingIpcInitHostedService(TypingIpc typingIpc) : IHostedService
{
private readonly TypingIpc _typingIpc = typingIpc;
public Task StartAsync(CancellationToken cancellationToken) => Task.CompletedTask;
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
internal sealed class ExtraChatInitHostedService(ExtraChat extraChat) : IHostedService
{
private readonly ExtraChat _extraChat = extraChat;
public Task StartAsync(CancellationToken cancellationToken) => Task.CompletedTask;
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
internal sealed class MessageManagerInitHostedService(
IDalamudPluginInterface pluginInterface,
MessageManager manager
) : IHostedService
{
public Task StartAsync(CancellationToken cancellationToken)
{
// FilterAllTabsAsync rebuilds the per-tab view from the message store;
// on Boot, tabs come up empty and the first chat events fill them, so
// we skip the rebuild to avoid a pointless full-history scan.
if (pluginInterface.Reason is not PluginLoadReason.Boot)
manager.FilterAllTabsAsync();
return Task.CompletedTask;
}
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
internal sealed class AutoTellTabsServiceInitHostedService(AutoTellTabsService service)
: IHostedService
{
public Task StartAsync(CancellationToken cancellationToken)
{
service.Initialize();
return Task.CompletedTask;
}
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
}
@@ -0,0 +1,64 @@
using System.Text;
using Dalamud.Plugin.Services;
using Microsoft.Extensions.Logging;
namespace HellionChat.Infrastructure.Logging;
internal sealed class DalamudLogger : ILogger
{
private readonly string _name;
private readonly IPluginLog _pluginLog;
public DalamudLogger(string name, IPluginLog pluginLog)
{
_name = name;
_pluginLog = pluginLog;
}
IDisposable? ILogger.BeginScope<TState>(TState state) => default!;
// Filtering happens in Dalamud's /xllog. Letting every level through keeps
// the HellionChat side stateless; if we ever want a per-plugin floor we add
// a Config.LogLevel and tighten this method.
public bool IsEnabled(LogLevel logLevel) => true;
public void Log<TState>(
LogLevel logLevel,
EventId eventId,
TState state,
Exception? exception,
Func<TState, Exception?, string> formatter
)
{
if (!IsEnabled(logLevel))
return;
// U+200B between the bracket and the level is a quiet provenance
// marker; byte-distinguishable from any 1:1 port of this format.
if ((int)logLevel <= (int)LogLevel.Information)
{
_pluginLog.Information($"[{_name}]{{{(int)logLevel}}} {state}");
return;
}
var sb = new StringBuilder();
sb.Append($"[{_name}]{{{(int)logLevel}}} {state} {exception?.Message}");
if (!string.IsNullOrWhiteSpace(exception?.StackTrace))
sb.AppendLine(exception.StackTrace);
var inner = exception?.InnerException;
while (inner != null)
{
sb.AppendLine($"InnerException {inner}: {inner.Message}");
sb.AppendLine(inner.StackTrace);
inner = inner.InnerException;
}
if (logLevel == LogLevel.Warning)
_pluginLog.Warning(sb.ToString());
else if (logLevel == LogLevel.Error)
_pluginLog.Error(sb.ToString());
else
_pluginLog.Fatal(sb.ToString());
}
}
@@ -0,0 +1,73 @@
using System.Collections.Concurrent;
using System.Reflection;
using System.Security.Cryptography;
using System.Text;
using Dalamud.Plugin.Services;
using Microsoft.Extensions.Logging;
namespace HellionChat.Infrastructure.Logging;
[ProviderAlias("Dalamud")]
public sealed class DalamudLoggingProvider : ILoggerProvider
{
// Hellion Forge Bronze (#C2410C). Mixed into the bootstrap fingerprint.
private const string HellionMarker = "HellionForgeBronzeC2410C";
private readonly ConcurrentDictionary<string, DalamudLogger> _loggers = new(
StringComparer.OrdinalIgnoreCase
);
private readonly IPluginLog _pluginLog;
public DalamudLoggingProvider(IPluginLog pluginLog)
{
_pluginLog = pluginLog;
EmitBootstrapBanner();
}
// One-shot per plugin load. Intentionally visible in xllog so uncredited
// ports of the DalamudLogger trio keep announcing their origin.
private void EmitBootstrapBanner()
{
var version =
typeof(DalamudLoggingProvider).Assembly.GetName().Version?.ToString() ?? "0.0.0";
var fingerprint = ComputeFingerprint(version);
_pluginLog.Information(
$"HellionChat DI-Logger bootstrap v{version} fingerprint={fingerprint}"
);
}
private static string ComputeFingerprint(string version)
{
var seed = Encoding.UTF8.GetBytes($"{HellionMarker}-{version}");
var hash = SHA256.HashData(seed);
var sb = new StringBuilder(8);
for (var i = 0; i < 4; i++)
sb.Append(hash[i].ToString("x2"));
return sb.ToString();
}
public ILogger CreateLogger(string categoryName)
{
// Category-name normalisation mirrors Lightless: take the leaf type
// name, then either ellipsis-trim long ones or left-pad short ones to
// 15 chars so the xllog column stays aligned across services.
var catName = categoryName.Split(".", StringSplitOptions.RemoveEmptyEntries).Last();
if (catName.Length > 15)
catName = string.Concat(
catName.AsSpan(0, 6),
"...",
catName.AsSpan(catName.Length - 6, 6)
);
else
catName = catName.PadLeft(15);
return _loggers.GetOrAdd(catName, name => new DalamudLogger(name, _pluginLog));
}
public void Dispose()
{
_loggers.Clear();
GC.SuppressFinalize(this);
}
}
@@ -0,0 +1,23 @@
using Dalamud.Plugin.Services;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Microsoft.Extensions.Logging;
namespace HellionChat.Infrastructure.Logging;
public static class DalamudLoggingProviderExtensions
{
public static ILoggingBuilder AddDalamudLogging(
this ILoggingBuilder builder,
IPluginLog pluginLog
)
{
builder.ClearProviders();
builder.Services.TryAddEnumerable(
ServiceDescriptor.Singleton<ILoggerProvider, DalamudLoggingProvider>(
_ => new DalamudLoggingProvider(pluginLog)
)
);
return builder;
}
}
+12 -10
View File
@@ -2,14 +2,9 @@ using System.Collections.Generic;
namespace HellionChat; namespace HellionChat;
// Hellion Chat — v0.6.0 shared input history. Replaces the embedded // Shared input history for all ChatInputBars (main and pop-out windows).
// ChatLogWindow.InputBacklog so that pop-out windows with their own // Push deduplicates: existing entries are moved to the end when re-added.
// ChatInputBar can navigate the same Up/Down history as the main window. // TEST-MIRROR: ../../Hellion Build test/Util/InputHistoryServiceTests.cs
// Index semantics are kept identical to the v0.5.x InputBacklog:
// index 0 = oldest entry
// index Count - 1 = newest entry
// Push performs move-to-newest deduplication: existing entries are
// removed before the new one is appended at the end.
public static class InputHistoryService public static class InputHistoryService
{ {
private const int MaxSize = 30; private const int MaxSize = 30;
@@ -26,8 +21,7 @@ public static class InputHistoryService
var trimmed = entry.Trim(); var trimmed = entry.Trim();
// Move-to-newest: existing entries are removed before the append // Move-to-newest: remove existing entry before adding at the end
// so the same line typed twice does not occupy two history slots.
for (var i = 0; i < _entries.Count; i++) for (var i = 0; i < _entries.Count; i++)
{ {
if (_entries[i] == trimmed) if (_entries[i] == trimmed)
@@ -48,4 +42,12 @@ public static class InputHistoryService
return null; return null;
return _entries[cursor]; return _entries[cursor];
} }
// Plugin reload doesn't reset static state automatically. Plugin.DisposeAsync
// calls this so the next load starts with an empty history instead of
// inheriting the previous session's entries.
public static void Reset()
{
_entries.Clear();
}
} }
+37 -96
View File
@@ -2,69 +2,51 @@ using System;
using Dalamud.Plugin; using Dalamud.Plugin;
using Dalamud.Plugin.Ipc; using Dalamud.Plugin.Ipc;
using Dalamud.Plugin.Services; using Dalamud.Plugin.Services;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json; using Newtonsoft.Json;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// We pull Newtonsoft.Json into this single file for IPC compatibility: // Newtonsoft.Json is used here for IPC compatibility with Honorific, which
// Honorific serialises its TitleData with Newtonsoft (see // serialises TitleData with it. It's a transitive Dalamud dependency — no
// Honorific-master/IpcProvider.cs:9 and CustomTitle.cs:12). Using the // new NuGet entry needed. The rest of HellionChat uses System.Text.Json.
// same library guarantees identical handling of System.Numerics.Vector3?
// and the enum fields we ignore. Newtonsoft is a transitive dependency
// via Dalamud, so no new NuGet entry is needed. The rest of HellionChat
// keeps using System.Text.Json.
internal sealed class HonorificService : IDisposable internal sealed class HonorificService : IDisposable
{ {
private const string IpcNamespace = "Honorific"; private const string IpcNamespace = "Honorific";
// Major version of the Honorific IPC contract HellionChat is built against. // Major version of the Honorific IPC contract we're built against.
// Used both by the runtime compatibility check and by the settings tab when
// it tells the user which major version we expected, so the literal lives
// in exactly one place.
internal const uint ExpectedApiMajor = 3; internal const uint ExpectedApiMajor = 3;
// IPC gates we subscribe to. Keep them as fields so Dispose can // IPC gates — kept as fields so Dispose can unsubscribe the same instances.
// unsubscribe the same instances we subscribed in the constructor.
private readonly ICallGateSubscriber<(uint, uint)> _apiVersion; private readonly ICallGateSubscriber<(uint, uint)> _apiVersion;
private readonly ICallGateSubscriber<string> _getLocalCharacterTitle; private readonly ICallGateSubscriber<string> _getLocalCharacterTitle;
private readonly ICallGateSubscriber<string, object> _localCharacterTitleChanged; private readonly ICallGateSubscriber<string, object> _localCharacterTitleChanged;
private readonly ICallGateSubscriber<object> _ready; private readonly ICallGateSubscriber<object> _ready;
private readonly ICallGateSubscriber<object> _disposing; private readonly ICallGateSubscriber<object> _disposing;
private readonly IPluginLog _log; private readonly ILogger<HonorificService> _logger;
private readonly IFramework _framework; private readonly IFramework _framework;
private bool _versionWarningLogged; private bool _versionWarningLogged;
// Thread: framework only — IPC delivery + ImGui render both run there.
public HonorificTitleData? CurrentTitle { get; private set; } public HonorificTitleData? CurrentTitle { get; private set; }
public bool IsAvailable { get; private set; } public bool IsAvailable { get; private set; }
public (uint Major, uint Minor)? DetectedApiVersion { get; private set; } public (uint Major, uint Minor)? DetectedApiVersion { get; private set; }
public HonorificService( public HonorificService(
IDalamudPluginInterface pluginInterface, IDalamudPluginInterface pluginInterface,
IPluginLog log, ILogger<HonorificService> logger,
IFramework framework IFramework framework
) )
{ {
_framework = framework; _framework = framework;
_log = log; _logger = logger;
// Dalamud caches gate objects per-name for the lifetime of the // Gate objects are cached per-name by Dalamud and safe to register
// plugin interface, so we can register subscribers even when // before Honorific loads — they just won't fire until it does.
// Honorific isn't loaded yet — the gate just won't fire. Calling // Initial pull is scheduled on the framework thread because plugin
// InvokeFunc before Honorific is up will throw, which is why the // constructors run on the loader thread, and Honorific's IPC handlers
// initial pull below is wrapped in try-catch. // read ObjectTable.LocalPlayer which throws off the framework thread.
//
// Thread-context: plugin constructors run on Dalamud's plugin-loader
// thread, NOT the framework thread. Honorific's IPC handlers read
// ObjectTable.LocalPlayer (Honorific IpcProvider.cs:61), which throws
// "Not on main thread!" outside the framework thread. If Honorific is
// already loaded when HellionChat starts, a synchronous InvokeFunc
// here would surface that exception, the broad catch below would
// mark IsAvailable=false, and OnTitleChanged's `if (!IsAvailable)`
// gate would block every subsequent title update. We therefore
// schedule the initial pull onto the framework thread via
// IFramework.RunOnFrameworkThread so the IPC call sees the right
// thread context.
_apiVersion = pluginInterface.GetIpcSubscriber<(uint, uint)>($"{IpcNamespace}.ApiVersion"); _apiVersion = pluginInterface.GetIpcSubscriber<(uint, uint)>($"{IpcNamespace}.ApiVersion");
_getLocalCharacterTitle = pluginInterface.GetIpcSubscriber<string>( _getLocalCharacterTitle = pluginInterface.GetIpcSubscriber<string>(
$"{IpcNamespace}.GetLocalCharacterTitle" $"{IpcNamespace}.GetLocalCharacterTitle"
@@ -84,16 +66,14 @@ internal sealed class HonorificService : IDisposable
public void Dispose() public void Dispose()
{ {
// Honorific may already be gone by the time we dispose. Wrap each // Wrap each unsubscribe — a missing gate must not block the others.
// unsubscribe so a missing gate doesn't prevent the others from // Leaking a subscription keeps this service alive across plugin reloads.
// unsubscribing — leaking even one subscription leaves a callback
// alive that captures `this`, which keeps the whole service alive
// and breaks plugin reload.
TryUnsubscribe(() => _localCharacterTitleChanged.Unsubscribe(OnTitleChanged)); TryUnsubscribe(() => _localCharacterTitleChanged.Unsubscribe(OnTitleChanged));
TryUnsubscribe(() => _ready.Unsubscribe(OnReady)); TryUnsubscribe(() => _ready.Unsubscribe(OnReady));
TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing)); TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing));
} }
// Thread: framework (scheduled from ctor and OnReady).
private void TryInitialPull() private void TryInitialPull()
{ {
try try
@@ -105,7 +85,7 @@ internal sealed class HonorificService : IDisposable
{ {
if (!_versionWarningLogged) if (!_versionWarningLogged)
{ {
_log.Warning( _logger.LogWarning(
"Honorific API version mismatch — expected major 3, " "Honorific API version mismatch — expected major 3, "
+ "found {Major}.{Minor}. Disabling Honorific integration.", + "found {Major}.{Minor}. Disabling Honorific integration.",
version.Item1, version.Item1,
@@ -119,68 +99,47 @@ internal sealed class HonorificService : IDisposable
IsAvailable = true; IsAvailable = true;
_versionWarningLogged = false; _versionWarningLogged = false;
// Pull the current title once at startup; from here on we rely
// on LocalCharacterTitleChanged events.
var json = _getLocalCharacterTitle.InvokeFunc(); var json = _getLocalCharacterTitle.InvokeFunc();
CurrentTitle = ParseTitleJson(json); CurrentTitle = ParseTitleJson(json);
} }
catch (Exception ex) catch (Exception ex)
{ {
// Honorific isn't installed or hasn't initialised yet. The Ready // Honorific not installed or not yet initialised — Ready will retry.
// event will give us a second chance later. Log at Debug so _logger.LogDebug(ex, "Honorific not available at HellionChat startup; awaiting Ready.");
// users without Honorific don't see noise on every reload.
_log.Debug(ex, "Honorific not available at HellionChat startup; awaiting Ready.");
IsAvailable = false; IsAvailable = false;
CurrentTitle = null; CurrentTitle = null;
} }
} }
// Honorific fires LocalCharacterTitleChanged through its nameplate hook // Thread: framework (Dalamud IPC delivery contract).
// (Honorific-master/Plugin.cs:665), which means we get title updates on
// character switches automatically as soon as the new character is
// rendered. While the user is in the character-select menu, HellionChat's
// window is hidden by default via HideWhenNotLoggedIn (Configuration.cs:152),
// so the stale-title window between logout and login isn't user-visible.
private void OnTitleChanged(string json) private void OnTitleChanged(string json)
{ {
// Don't update cached state when we've already decided we can't trust // Skip updates on version mismatch; subscription stays live for reload.
// Honorific (e.g. version mismatch). Subscription stays live in case a
// compatible Honorific reloads, in which case Ready triggers TryInitialPull
// and sets IsAvailable back to true.
if (!IsAvailable) if (!IsAvailable)
return; return;
CurrentTitle = ParseTitleJson(json); CurrentTitle = ParseTitleJson(json);
} }
// Thread: any (Honorific dispatches NotifyReady from its own thread).
private void OnReady() private void OnReady()
{ {
// Honorific loaded after HellionChat; redo the version check and
// initial pull. Idempotent on purpose — Honorific can fire Ready
// more than once across reloads.
//
// Honorific's NotifyReady may dispatch from any thread, and
// TryInitialPull eventually calls IPC handlers that read
// ObjectTable.LocalPlayer — same "Not on main thread!" hazard as
// the constructor path. Schedule onto the framework thread.
_framework.RunOnFrameworkThread(TryInitialPull); _framework.RunOnFrameworkThread(TryInitialPull);
} }
// Thread: framework (IPC delivery contract); idempotent — Disposing fires once.
private void OnDisposing() private void OnDisposing()
{ {
// Honorific is unloading. Drop our cached state so the header // Honorific unloading — clear cached state so the header hides next frame.
// hides on the next frame; subscriptions stay registered because // Subscriptions stay registered in case Honorific reloads.
// the gates may come back later (Honorific reload). // CurrentTitle is already nulled by OnTitleChanged before this fires,
// // re-clearing here is belt-and-braces.
// Race-note: Honorific's NotifyDisposing calls ChangedLocalCharacterTitle(null)
// BEFORE SendMessage on the Disposing gate (IpcProvider.cs:109-111),
// so OnTitleChanged is expected to fire first and already null out
// CurrentTitle. We re-clear here as belt-and-braces; should the
// ordering ever flip, ShouldRenderSlot would still gate on IsAvailable.
CurrentTitle = null; CurrentTitle = null;
IsAvailable = false; IsAvailable = false;
DetectedApiVersion = null; DetectedApiVersion = null;
} }
// Thread: framework (called from Dispose, which runs on the framework
// cleanup block in Plugin.DisposeAsync).
private void TryUnsubscribe(Action unsubscribe) private void TryUnsubscribe(Action unsubscribe)
{ {
try try
@@ -189,33 +148,15 @@ internal sealed class HonorificService : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
_log.Debug(ex, "Honorific unsubscribe failed (likely already gone)."); // Warning not Debug — a silent unsubscribe failure leaks a live
// subscription across plugin reloads.
_logger.LogWarning(
ex,
"Honorific unsubscribe failed (likely API break or gate already gone)."
);
} }
} }
// Threading note: Dalamud fires IPC events on the framework thread and
// ImGui renders on the framework thread, so OnTitleChanged and the
// render path that reads CurrentTitle never race — OnTitleChanged is
// safe to keep direct (no RunOnFrameworkThread wrap needed) because
// LocalCharacterTitleChanged delivery is framework-thread by Dalamud
// contract. If a future change moves either side onto a worker thread,
// switch to volatile/Interlocked for the CurrentTitle field.
//
// The constructor's initial pull and OnReady, on the other hand, are
// explicitly scheduled via IFramework.RunOnFrameworkThread because
// they run outside that contract: the constructor executes on the
// plugin-loader thread, and Honorific's NotifyReady can dispatch from
// any thread. Both call paths eventually invoke IPC handlers that read
// ObjectTable.LocalPlayer, which throws "Not on main thread!" off the
// framework thread — see the constructor comment block for context.
//
// Divergence from ChatTwo/Ipc/ExtraChat.cs: that file uses `volatile`
// on its state fields out of caution. We don't, because the framework-
// thread delivery is the documented Dalamud contract. If the two files
// ever need to share a threading audit, this is the place to revisit.
// --- Pure-logic helpers below; tested via HellionChat.Tests/Integrations. ---
internal static HonorificTitleData? ParseTitleJson(string json) internal static HonorificTitleData? ParseTitleJson(string json)
{ {
if (string.IsNullOrEmpty(json)) if (string.IsNullOrEmpty(json))
+13 -8
View File
@@ -2,16 +2,21 @@ using System.Numerics;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// Local DTO mirroring Honorific's TitleData shape. We replicate the structure // Local DTO mirroring Honorific's TitleData — no hard reference to Honorific.dll
// instead of referencing Honorific.dll because a hard build-time dependency // so HellionChat loads cleanly when Honorific is absent.
// would couple the two assemblies and break HellionChat at load time when //
// Honorific is missing. Glow, Color3, GradientColourSet and GradientAnimationStyle // v1.4.7: render Glow only. Gradient (Color3 / GradientColourSet / Style) is
// are intentionally omitted — Cycle 1 renders text in the primary Color only; // parsed and stashed so a future cycle can render it without re-shaping the
// the "Honorific Full Fidelity" backlog item adds them later as a pure // JSON roundtrip — see vault anchor "Honorific Full Gradient Port" (would
// extension that won't break this DTO's existing consumers. // need GradientSystem.cs + the hardcoded Pride-palette list ported, or an
// upstream IPC PR exposing the resolved frame colour).
internal sealed record HonorificTitleData( internal sealed record HonorificTitleData(
string? Title, string? Title,
bool IsPrefix, bool IsPrefix,
bool IsOriginal, bool IsOriginal,
Vector3? Color Vector3? Color,
Vector3? Glow,
Vector3? Color3,
int? GradientColourSet,
string? GradientAnimationStyle
); );
+13 -5
View File
@@ -1,12 +1,20 @@
using System.Runtime.CompilerServices;
using HellionChat.Util;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// External URLs for the third-party plugins HellionChat integrates with. // Third-party plugin URLs — separate from BrandingLinks (Hellion-owned URLs).
// Kept separate from BrandingLinks (which is for Hellion-owned URLs) so
// future cycles can extend this file with maintainer attribution links
// for Moodles, NotificationMaster, ExtraChat, etc. without polluting the
// brand-links class.
internal static class IntegrationLinks internal static class IntegrationLinks
{ {
public const string HonorificRepo = "https://github.com/Caraxi/Honorific"; public const string HonorificRepo = "https://github.com/Caraxi/Honorific";
public const string HonorificAuthor = "https://github.com/Caraxi"; public const string HonorificAuthor = "https://github.com/Caraxi";
// See BrandingLinks.ValidateUrls for the CA2255 rationale.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(nameof(IntegrationLinks), HonorificRepo, HonorificAuthor);
}
} }
+14 -21
View File
@@ -1,9 +1,12 @@
using Dalamud.Plugin.Ipc; using Dalamud.Plugin.Ipc;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ipc; namespace HellionChat.Ipc;
public sealed class ExtraChat : IDisposable public sealed class ExtraChat : IDisposable
{ {
private readonly ILogger<ExtraChat> _logger;
#pragma warning disable CS0649 // Assigned through IPC #pragma warning disable CS0649 // Assigned through IPC
[Serializable] [Serializable]
private struct OverrideInfo private struct OverrideInfo
@@ -26,10 +29,9 @@ public sealed class ExtraChat : IDisposable
internal (string, uint)? ChannelOverride { get; set; } internal (string, uint)? ChannelOverride { get; set; }
// Volatile reference: IPC callbacks (OnChannelCommandColours/OnChannelNames) fire on a // volatile: IPC callbacks fire on a Dalamud thread while ImGui reads these.
// Dalamud-dispatcher thread while the ImGui thread reads the IReadOnlyDictionary projections. // Reference assignment is atomic on x64, but the barrier ensures visibility
// Reference assignment is atomic on x64, but the JIT (especially Mono on Wine/Linux) needs // across threads (especially Mono/Wine). See AUDIT-2026-05-05 [SEC-01].
// the volatile barrier to guarantee visibility across threads. See AUDIT-2026-05-05 [SEC-01].
private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new(); private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new();
internal IReadOnlyDictionary<string, uint> ChannelCommandColours => internal IReadOnlyDictionary<string, uint> ChannelCommandColours =>
ChannelCommandColoursInternal; ChannelCommandColoursInternal;
@@ -37,8 +39,9 @@ public sealed class ExtraChat : IDisposable
private volatile Dictionary<Guid, string> ChannelNamesInternal = new(); private volatile Dictionary<Guid, string> ChannelNamesInternal = new();
internal IReadOnlyDictionary<Guid, string> ChannelNames => ChannelNamesInternal; internal IReadOnlyDictionary<Guid, string> ChannelNames => ChannelNamesInternal;
internal ExtraChat() internal ExtraChat(ILogger<ExtraChat> logger)
{ {
_logger = logger;
OverrideChannelGate = Plugin.Interface.GetIpcSubscriber<OverrideInfo, object>( OverrideChannelGate = Plugin.Interface.GetIpcSubscriber<OverrideInfo, object>(
"ExtraChat.OverrideChannelColour" "ExtraChat.OverrideChannelColour"
); );
@@ -54,6 +57,7 @@ public sealed class ExtraChat : IDisposable
OverrideChannelGate.Subscribe(OnOverrideChannel); OverrideChannelGate.Subscribe(OnOverrideChannel);
ChannelCommandColoursGate.Subscribe(OnChannelCommandColours); ChannelCommandColoursGate.Subscribe(OnChannelCommandColours);
ChannelNamesGate.Subscribe(OnChannelNames); ChannelNamesGate.Subscribe(OnChannelNames);
try try
{ {
ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!); ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!);
@@ -61,8 +65,8 @@ public sealed class ExtraChat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// ExtraChat is optional; missing IPC peer is normal when the plugin isn't loaded. // ExtraChat is optional; IPC failure is normal when the plugin isn't loaded.
Plugin.Log.Verbose(ex, "ExtraChat IPC initial state query failed (peer not loaded?)"); _logger.LogTrace(ex, "ExtraChat IPC initial state query failed (peer not loaded?)");
} }
} }
@@ -75,22 +79,11 @@ public sealed class ExtraChat : IDisposable
private void OnOverrideChannel(OverrideInfo info) private void OnOverrideChannel(OverrideInfo info)
{ {
if (info.Channel == null) ChannelOverride = info.Channel == null ? null : (info.Channel, info.Rgba);
{
ChannelOverride = null;
return;
}
ChannelOverride = (info.Channel, info.Rgba);
} }
private void OnChannelCommandColours(Dictionary<string, uint> obj) private void OnChannelCommandColours(Dictionary<string, uint> obj) =>
{
ChannelCommandColoursInternal = obj; ChannelCommandColoursInternal = obj;
}
private void OnChannelNames(Dictionary<Guid, string> obj) private void OnChannelNames(Dictionary<Guid, string> obj) => ChannelNamesInternal = obj;
{
ChannelNamesInternal = obj;
}
} }
+28 -1
View File
@@ -1,5 +1,6 @@
using Dalamud.Plugin.Ipc; using Dalamud.Plugin.Ipc;
using HellionChat.Code; using HellionChat.Code;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ipc; namespace HellionChat.Ipc;
@@ -19,12 +20,26 @@ internal sealed class TypingIpc : IDisposable
private ICallGateProvider<ChatInputState> StateQueryGate { get; } private ICallGateProvider<ChatInputState> StateQueryGate { get; }
private ICallGateProvider<ChatInputState, object?> StateChangedGate { get; } private ICallGateProvider<ChatInputState, object?> StateChangedGate { get; }
// v1.4.9 R4: ChatTwo IPC compatibility mirror. Some third-party plugins
// have a no-fork policy and subscribe only to ChatTwo.*-prefixed IPC
// gates. HellionChat replaces ChatTwo (conflict detection prevents
// parallel loading), so mirroring the ChatTwo provider slots lets those
// plugins keep working without code changes on their side. The tuple
// shape is textually identical to ChatTwo's IPC surface (same member
// order, same underlying types — ChatType is `ushort` in both repos)
// so Dalamud's IPC marshalling matches across plugin boundaries.
private ICallGateProvider<ChatInputState> ChatTwoStateQueryGate { get; }
private ICallGateProvider<ChatInputState, object?> ChatTwoStateChangedGate { get; }
private ChatInputState LastState; private ChatInputState LastState;
private bool HasState; private bool HasState;
internal TypingIpc(Plugin plugin) private readonly ILogger<TypingIpc> _logger;
internal TypingIpc(Plugin plugin, ILogger<TypingIpc> logger)
{ {
Plugin = plugin; Plugin = plugin;
_logger = logger;
StateQueryGate = Plugin.Interface.GetIpcProvider<ChatInputState>( StateQueryGate = Plugin.Interface.GetIpcProvider<ChatInputState>(
"HellionChat.GetChatInputState" "HellionChat.GetChatInputState"
@@ -33,7 +48,16 @@ internal sealed class TypingIpc : IDisposable
"HellionChat.ChatInputStateChanged" "HellionChat.ChatInputStateChanged"
); );
// v1.4.9 R4: ChatTwo-prefixed compatibility slots (see class-level comment).
ChatTwoStateQueryGate = Plugin.Interface.GetIpcProvider<ChatInputState>(
"ChatTwo.GetChatInputState"
);
ChatTwoStateChangedGate = Plugin.Interface.GetIpcProvider<ChatInputState, object?>(
"ChatTwo.ChatInputStateChanged"
);
StateQueryGate.RegisterFunc(GetState); StateQueryGate.RegisterFunc(GetState);
ChatTwoStateQueryGate.RegisterFunc(GetState);
} }
private ChatInputState BuildState() private ChatInputState BuildState()
@@ -67,10 +91,13 @@ internal sealed class TypingIpc : IDisposable
HasState = true; HasState = true;
LastState = state; LastState = state;
StateChangedGate.SendMessage(state); StateChangedGate.SendMessage(state);
// v1.4.9 R4: mirror on ChatTwo-prefixed slot for no-fork-policy plugins.
ChatTwoStateChangedGate.SendMessage(state);
} }
public void Dispose() public void Dispose()
{ {
StateQueryGate.UnregisterFunc(); StateQueryGate.UnregisterFunc();
ChatTwoStateQueryGate.UnregisterFunc();
} }
} }
+54 -1
View File
@@ -1,11 +1,14 @@
using Dalamud.Game.Text.SeStringHandling; using Dalamud.Game.Text.SeStringHandling;
using Dalamud.Game.Text.SeStringHandling.Payloads; using Dalamud.Game.Text.SeStringHandling.Payloads;
using Dalamud.Plugin.Ipc; using Dalamud.Plugin.Ipc;
using Microsoft.Extensions.Logging;
namespace HellionChat; namespace HellionChat;
internal sealed class IpcManager : IDisposable internal sealed class IpcManager : IDisposable
{ {
private readonly ILogger<IpcManager> _logger;
private ICallGateProvider<string> RegisterGate { get; } private ICallGateProvider<string> RegisterGate { get; }
private ICallGateProvider<string, object?> UnregisterGate { get; } private ICallGateProvider<string, object?> UnregisterGate { get; }
private ICallGateProvider<object?> AvailableGate { get; } private ICallGateProvider<object?> AvailableGate { get; }
@@ -19,10 +22,31 @@ internal sealed class IpcManager : IDisposable
object? object?
> InvokeGate { get; } > InvokeGate { get; }
// v1.4.9 R4: ChatTwo IPC compatibility mirror. Third-party plugins with
// a no-fork policy (e.g. Artisan, AllaganTools) only subscribe to the
// ChatTwo.*-prefixed context-menu integration gates. Mirroring all four
// provider slots under the ChatTwo namespace lets those plugins keep
// working without code changes on their side. Conflict detection
// prevents ChatTwo and HellionChat from loading in parallel, so no slot
// collision risk.
private ICallGateProvider<string> ChatTwoRegisterGate { get; }
private ICallGateProvider<string, object?> ChatTwoUnregisterGate { get; }
private ICallGateProvider<object?> ChatTwoAvailableGate { get; }
private ICallGateProvider<
string,
PlayerPayload?,
ulong,
Payload?,
SeString?,
SeString?,
object?
> ChatTwoInvokeGate { get; }
internal List<string> Registered { get; } = []; internal List<string> Registered { get; } = [];
public IpcManager() public IpcManager(ILogger<IpcManager> logger)
{ {
_logger = logger;
RegisterGate = Plugin.Interface.GetIpcProvider<string>("HellionChat.Register"); RegisterGate = Plugin.Interface.GetIpcProvider<string>("HellionChat.Register");
RegisterGate.RegisterFunc(Register); RegisterGate.RegisterFunc(Register);
@@ -41,7 +65,32 @@ internal sealed class IpcManager : IDisposable
object? object?
>("HellionChat.Invoke"); >("HellionChat.Invoke");
// v1.4.9 R4: ChatTwo-prefixed mirrors of the four context-menu slots
// above. Share the same Register/Unregister backing methods so a
// plugin that subscribes via either namespace lands in the same
// Registered list. SendMessage on Invoke fans out to both gates.
ChatTwoRegisterGate = Plugin.Interface.GetIpcProvider<string>("ChatTwo.Register");
ChatTwoRegisterGate.RegisterFunc(Register);
ChatTwoAvailableGate = Plugin.Interface.GetIpcProvider<object?>("ChatTwo.Available");
ChatTwoUnregisterGate = Plugin.Interface.GetIpcProvider<string, object?>(
"ChatTwo.Unregister"
);
ChatTwoUnregisterGate.RegisterAction(Unregister);
ChatTwoInvokeGate = Plugin.Interface.GetIpcProvider<
string,
PlayerPayload?,
ulong,
Payload?,
SeString?,
SeString?,
object?
>("ChatTwo.Invoke");
AvailableGate.SendMessage(); AvailableGate.SendMessage();
ChatTwoAvailableGate.SendMessage();
} }
internal void Invoke( internal void Invoke(
@@ -54,6 +103,8 @@ internal sealed class IpcManager : IDisposable
) )
{ {
InvokeGate.SendMessage(id, sender, contentId, payload, senderString, content); InvokeGate.SendMessage(id, sender, contentId, payload, senderString, content);
// v1.4.9 R4: fan out the same event to plugins listening on ChatTwo.Invoke.
ChatTwoInvokeGate.SendMessage(id, sender, contentId, payload, senderString, content);
} }
private string Register() private string Register()
@@ -72,6 +123,8 @@ internal sealed class IpcManager : IDisposable
{ {
UnregisterGate.UnregisterAction(); UnregisterGate.UnregisterAction();
RegisterGate.UnregisterFunc(); RegisterGate.UnregisterFunc();
ChatTwoUnregisterGate.UnregisterAction();
ChatTwoRegisterGate.UnregisterFunc();
Registered.Clear(); Registered.Clear();
} }
} }
+4 -4
View File
@@ -153,8 +153,8 @@ public partial class Message
} }
catch (ArgumentException ex) catch (ArgumentException ex)
{ {
Plugin.Log.Error(ex, "Failed to parse extra chat channel GUID"); Plugin.LogProxy.Error(ex, "Failed to parse extra chat channel GUID");
Plugin.Log.Error($"Byte Array: ${string.Join(", ", data[4..^1])}"); Plugin.LogProxy.Error($"Byte Array: ${string.Join(", ", data[4..^1])}");
return Guid.Empty; return Guid.Empty;
} }
} }
@@ -251,7 +251,7 @@ public partial class Message
AddChunkWithMessage( AddChunkWithMessage(
text.NewWithStyle(chunk.Source, chunk.Link, token.Value) text.NewWithStyle(chunk.Source, chunk.Link, token.Value)
); );
Plugin.Log.Debug( Plugin.LogProxy.Debug(
$"Invalid URL accepted by Regex but failed URI parsing: '{token.Value}'" $"Invalid URL accepted by Regex but failed URI parsing: '{token.Value}'"
); );
} }
@@ -416,7 +416,7 @@ public partial class Message
catch (Exception) catch (Exception)
{ {
AddChunkWithMessage(text.NewWithStyle(chunk.Source, chunk.Link, split)); AddChunkWithMessage(text.NewWithStyle(chunk.Source, chunk.Link, split));
Plugin.Log.Debug($"Failed to parse the text param: '{split}'"); Plugin.LogProxy.Debug($"Failed to parse the text param: '{split}'");
} }
} }
} }
+36 -53
View File
@@ -14,6 +14,7 @@ using HellionChat.Util;
using Lumina.Text.Expressions; using Lumina.Text.Expressions;
using Lumina.Text.Payloads; using Lumina.Text.Payloads;
using Lumina.Text.ReadOnly; using Lumina.Text.ReadOnly;
using Microsoft.Extensions.Logging;
namespace HellionChat; namespace HellionChat;
@@ -22,21 +23,13 @@ internal class MessageManager : IAsyncDisposable
internal const int MessageDisplayLimit = 10_000; internal const int MessageDisplayLimit = 10_000;
private Plugin Plugin { get; } private Plugin Plugin { get; }
private readonly ILogger<MessageManager> _logger;
internal MessageStore Store { get; } internal MessageStore Store { get; }
private Dictionary<ChatType, NameFormatting> Formats { get; } = []; private Dictionary<ChatType, NameFormatting> Formats { get; } = [];
private ulong LastContentId { get; set; } private ulong LastContentId { get; set; }
// Messages go into the PendingSync queue first, which will be consumed one // PendingSync (main thread) → PendingAsync (worker thread); LinkedList for O(1) Last access
// at a time in the main thread. This is to delay the async processing until
// after we've received the content ID from the ContentIdResolver hook.
//
// After that, the message is enqueued in the PendingAsync queue, which will
// be consumed in a separate thread and perform more processing (emotes,
// URLs) as well as inserting the message into the database.
// LinkedList instead of Queue: ContentIdResolver hits PendingSync.Last
// every hook call. Queue<T>.Last() is the LINQ extension and walks the
// whole queue (O(n)); LinkedList<T>.Last is an O(1) node reference.
private LinkedList<PendingMessage> PendingSync { get; } = []; private LinkedList<PendingMessage> PendingSync { get; } = [];
private ConcurrentQueue<PendingMessage> PendingAsync { get; } = []; private ConcurrentQueue<PendingMessage> PendingAsync { get; } = [];
private readonly Thread PendingMessageThread; private readonly Thread PendingMessageThread;
@@ -53,21 +46,26 @@ internal class MessageManager : IAsyncDisposable
} }
} }
// Hellion Chat — Auto-Tell-Tabs hook. Fires after a fully processed // Auto-Tell-Tabs hook: fires after a message is processed and stored, allowing
// message has been routed to all matching persistent tabs and stored // AutoTellTabsService to spawn or refresh temp tabs without coupling.
// in the database. The AutoTellTabsService subscribes to spawn or
// refresh temp tabs without having to wedge itself into ProcessMessage
// directly.
public event Action<Message>? MessageProcessed; public event Action<Message>? MessageProcessed;
internal unsafe MessageManager(Plugin plugin) internal unsafe MessageManager(
Plugin plugin,
ILogger<MessageManager> logger,
ILoggerFactory loggerFactory
)
{ {
Plugin = plugin; Plugin = plugin;
_logger = logger;
Store = new MessageStore(DatabasePath()); Store = new MessageStore(
DatabasePath(),
Plugin.PlatformUtil,
loggerFactory.CreateLogger<MessageStore>(),
loggerFactory
);
// IsBackground so a stuck worker never blocks plugin unload.
// Cooperative cancel via PendingThreadCancellationToken first, background flag is the safety net.
PendingMessageThread = new Thread(() => PendingMessageThread = new Thread(() =>
ProcessPendingMessages(PendingThreadCancellationToken.Token) ProcessPendingMessages(PendingThreadCancellationToken.Token)
) )
@@ -105,14 +103,11 @@ internal class MessageManager : IAsyncDisposable
await Task.Delay(100); await Task.Delay(100);
if (PendingMessageThread.IsAlive) if (PendingMessageThread.IsAlive)
Plugin.Log.Warning( _logger.LogWarning(
"PendingMessageThread did not observe cancellation within 10s. " "PendingMessageThread did not observe cancellation within 10s. "
+ "Worker remains on a background thread; next plugin reload releases it. " + "Worker remains on background thread; next plugin reload releases it."
+ "If this recurs, file a bug with /xllog after the previous reload."
); );
// CTS owns an unmanaged WaitHandle; dispose even if the worker is
// alive — it checks IsCancellationRequested via the linked token.
PendingThreadCancellationToken.Dispose(); PendingThreadCancellationToken.Dispose();
Store.Dispose(); Store.Dispose();
@@ -154,7 +149,7 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error processing pending message"); _logger.LogError(ex, "Error processing pending message");
} }
} }
else else
@@ -166,12 +161,7 @@ internal class MessageManager : IAsyncDisposable
internal void ClearAllTabs() internal void ClearAllTabs()
{ {
// Hellion Chat — TempTabs haben keine DB-Persistenz (session-only, // TempTabs are session-only (not persisted); exclude them to preserve Tell history
// direkt vom AutoTellTabsService befüllt). Ein Clear+Refilter würde
// sie leer hinterlassen weil FilterAllTabs nichts aus der DB
// findet — Tells sind oft durch Privacy-Filter blockiert oder
// schlicht session-flüchtig. TempTabs vom Clear-Pfad ausschließen
// damit Settings-Save den Tell-Verlauf nicht zerstört.
foreach (var tab in Plugin.Config.Tabs.Where(t => !t.IsTempTab)) foreach (var tab in Plugin.Config.Tabs.Where(t => !t.IsTempTab))
tab.Clear(); tab.Clear();
} }
@@ -184,12 +174,7 @@ internal class MessageManager : IAsyncDisposable
using var messages = Store.GetMostRecentMessages(CurrentContentId, since); using var messages = Store.GetMostRecentMessages(CurrentContentId, since);
// We store the pending messages to be added to the chat log in a // TempTabs are excluded; they maintain live state from AutoTellTabsService
// temporary list, and apply them all at once after filtering.
// TempTabs werden ausgeschlossen — sie bleiben live-state aus dem
// AutoTellTabsService, ein DB-Refilter würde sie nur partial
// wiederherstellen falls Tells in DB liegen, oder leer lassen wenn
// Privacy-Filter sie blockiert hat.
var pendingTabs = Plugin var pendingTabs = Plugin
.Config.Tabs.Where(t => !t.IsTempTab) .Config.Tabs.Where(t => !t.IsTempTab)
.Select(tab => (tab, new List<Message>())) .Select(tab => (tab, new List<Message>()))
@@ -198,7 +183,7 @@ internal class MessageManager : IAsyncDisposable
foreach (var (_, pendingMessages) in pendingTabs.Where(ptab => ptab.Item1.Matches(message))) foreach (var (_, pendingMessages) in pendingTabs.Where(ptab => ptab.Item1.Matches(message)))
pendingMessages.Add(message); pendingMessages.Add(message);
// Apply the messages to the chat log in one go. // Apply messages to chat log all at once.
foreach (var (tab, pendingMessages) in pendingTabs) foreach (var (tab, pendingMessages) in pendingTabs)
tab.Messages.AddSortPrune(pendingMessages, MessageDisplayLimit); tab.Messages.AddSortPrune(pendingMessages, MessageDisplayLimit);
@@ -207,13 +192,14 @@ internal class MessageManager : IAsyncDisposable
WrapperUtil.AddNotification(Language.LoadMessages_Error, NotificationType.Error); WrapperUtil.AddNotification(Language.LoadMessages_Error, NotificationType.Error);
// Mark the failed messages as deleted so we don't try to load them // Mark failed messages as deleted to prevent retry attempts
// again.
var failedIds = messages.FailedMessageIds(); var failedIds = messages.FailedMessageIds();
Plugin.Log.Info($"Marking {failedIds.Count} messages as deleted due to parse failures"); _logger.LogInformation(
$"Marking {failedIds.Count} messages as deleted due to parse failures"
);
foreach (var msgId in messages.FailedMessageIds()) foreach (var msgId in messages.FailedMessageIds())
{ {
Plugin.Log.Debug($"Marking message '{msgId}' as deleted due to parse failure"); _logger.LogDebug($"Marking message '{msgId}' as deleted due to parse failure");
Store.DeleteMessage(msgId); Store.DeleteMessage(msgId);
} }
} }
@@ -229,10 +215,13 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in FilterAllTabs"); _logger.LogError(ex, "Error in FilterAllTabs");
} }
Plugin.Log.Debug($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms"); // v1.4.9 R3 profiling: Information so the xllog tail surfaces this
// without a Debug filter. Belt-and-suspenders for future plugin-load
// regressions; remains in place after Sub-Task 3.4 Befund.
_logger.LogInformation($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms");
}); });
} }
@@ -256,16 +245,10 @@ internal class MessageManager : IAsyncDisposable
// Update colour codes. // Update colour codes.
GlobalParametersCache.Refresh(); GlobalParametersCache.Refresh();
// We delay messages to be handed off to the async processing thread // Delay to next tick to get content ID from ContentIdResolver hook
// in the next tick, otherwise we can't get the content ID from the hook
// below.
PendingSync.AddLast(pendingMessage); PendingSync.AddLast(pendingMessage);
} }
// This hook is called immediately after receiving a message with the
// message's content ID. If multiple messages are received in the same tick,
// this will be called for each message immediately after ChatMessage is
// called for each message.
private unsafe void ContentIdResolver( private unsafe void ContentIdResolver(
RaptureLogModule* agent, RaptureLogModule* agent,
ulong contentId, ulong contentId,
@@ -293,7 +276,7 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error in ContentIdResolver"); _logger.LogError(ex, "Error in ContentIdResolver");
} }
} }
@@ -408,7 +391,7 @@ internal class MessageManager : IAsyncDisposable
var after = formats var after = formats
.GetRange(firstStringParam + 1, secondStringParam - firstStringParam) .GetRange(firstStringParam + 1, secondStringParam - firstStringParam)
.Where(payload => payload.Type == ReadOnlySePayloadType.Text) .Where(payload => payload.Type == ReadOnlySePayloadType.Text)
.Select(text => Encoding.UTF8.GetString(text.Body.Span)); // Can't use `ToString()` as it defaults to macro .Select(text => Encoding.UTF8.GetString(text.Body.Span));
var nameFormatting = NameFormatting.Of(string.Join("", before), string.Join("", after)); var nameFormatting = NameFormatting.Of(string.Join("", before), string.Join("", after));
Formats[type] = nameFormatting; Formats[type] = nameFormatting;
File diff suppressed because it is too large Load Diff
+8 -4
View File
@@ -20,6 +20,7 @@ using HellionChat.Resources;
using HellionChat.Ui; using HellionChat.Ui;
using HellionChat.Util; using HellionChat.Util;
using Lumina.Excel.Sheets; using Lumina.Excel.Sheets;
using Microsoft.Extensions.Logging;
using Action = System.Action; using Action = System.Action;
using ChatTwoPartyFinderPayload = HellionChat.Util.PartyFinderPayload; using ChatTwoPartyFinderPayload = HellionChat.Util.PartyFinderPayload;
using DalamudPartyFinderPayload = Dalamud.Game.Text.SeStringHandling.Payloads.PartyFinderPayload; using DalamudPartyFinderPayload = Dalamud.Game.Text.SeStringHandling.Payloads.PartyFinderPayload;
@@ -40,9 +41,12 @@ public sealed class PayloadHandler
private const uint PopupSfx = 1; private const uint PopupSfx = 1;
internal PayloadHandler(ChatLogWindow logWindow) private readonly ILogger<PayloadHandler> _logger;
internal PayloadHandler(ChatLogWindow logWindow, ILogger<PayloadHandler> logger)
{ {
LogWindow = logWindow; LogWindow = logWindow;
_logger = logger;
} }
internal void Draw() internal void Draw()
@@ -131,7 +135,7 @@ public sealed class PayloadHandler
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error executing integration"); _logger.LogError(ex, "Error executing integration");
} }
} }
@@ -535,7 +539,7 @@ public sealed class PayloadHandler
) )
) )
{ {
Plugin.Log.Warning("Could not find DalamudLinkHandlers"); _logger.LogWarning("Could not find DalamudLinkHandlers");
return; return;
} }
@@ -546,7 +550,7 @@ public sealed class PayloadHandler
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error executing DalamudLinkPayload handler"); _logger.LogError(ex, "Error executing DalamudLinkPayload handler");
} }
} }
+431 -252
View File
@@ -14,6 +14,9 @@ using HellionChat.Ipc;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Ui; using HellionChat.Ui;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Data.Sqlite;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
namespace HellionChat; namespace HellionChat;
@@ -90,10 +93,8 @@ public sealed class Plugin : IAsyncDalamudPlugin
public readonly WindowSystem WindowSystem = new(PluginName); public readonly WindowSystem WindowSystem = new(PluginName);
// v1.4.3: properties moved from { get; } to { get; private set; } = null!; // Phase-2 services are constructed in LoadAsync; null! shape is kept
// because LoadAsync now owns construction of the Phase-2 services. // consistent across all properties for clarity.
// Phase-1 services use the same shape for consistency, even though
// they're still allocated in the ctor.
public SettingsWindow SettingsWindow { get; private set; } = null!; public SettingsWindow SettingsWindow { get; private set; } = null!;
public ChatLogWindow ChatLogWindow { get; private set; } = null!; public ChatLogWindow ChatLogWindow { get; private set; } = null!;
public DbViewer DbViewer { get; private set; } = null!; public DbViewer DbViewer { get; private set; } = null!;
@@ -115,27 +116,55 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal Ui.StatusBar StatusBar { get; private set; } = null!; internal Ui.StatusBar StatusBar { get; private set; } = null!;
internal Integrations.HonorificService HonorificService { get; private set; } = null!; internal Integrations.HonorificService HonorificService { get; private set; } = null!;
// (B3) Lightless idempotency guard — Dalamud may fire DisposeAsync twice // Platform indirection over Dalamud.Utility.Util. Wired in Phase-1 ctor so
// in a reload race; second call short-circuits. // any service allocated in LoadAsync can read Plugin.PlatformUtil.
internal static IPlatformUtil PlatformUtil { get; private set; } = null!;
// Log indirection over Dalamud's IPluginLog. Same rationale as PlatformUtil:
// call-sites read through LogProxy so MessageStore can be tested in
// isolation. Wired immediately after Dalamud injects Log.
internal static IPluginLogProxy LogProxy { get; private set; } = null!;
// Nullable so DisposeAsync stays safe if Host-build throws before the
// fields get assigned — Dalamud fires DisposeAsync regardless.
private readonly IHost? _host;
private readonly PluginLifecycle? _lifecycle;
// Wrapper cached so TearDown can detach the live instance instead of
// re-registering with identical args (v1.4.9 ISSUE-1 cleanup).
private CommandWrapper? _hellionSettingsCmd;
private CommandWrapper? _hellionViewCmd;
private CommandWrapper? _hellionDebuggerCmd;
#if DEBUG
private CommandWrapper? _hellionSeStringCmd;
#endif
// Idempotency guard — Dalamud may fire DisposeAsync twice in a reload race.
private int _disposeStarted; private int _disposeStarted;
// Set in the first DisposeAsync statement so async callbacks scheduled
// via Framework.RunOnTick (v1.4.8 B3 retention sweep) can early-bail
// before they touch state that has already been torn down. Volatile
// because the tick reads it from a different thread than the writer.
private volatile bool _isDisposing;
internal int DeferredSaveFrames = -1; internal int DeferredSaveFrames = -1;
// Serialises retention sweeps. The 24h auto-sweep on plugin load and // Cancels the v1.4.8 FTS5 bulk-insert worker on plugin teardown. The
// the manual button in the Privacy tab both run on background threads; // worker runs off the framework thread on its own SqliteConnection, so a
// without this gate, hitting the manual button moments after a fresh // Dispose mid-rebuild must signal cancellation before MessageManager
// plugin start would launch two sweeps in parallel and the second one // tears down (the worker logs "rebuild failed" via Log on error paths).
// would just re-do work the first one already finished. The lock guards private CancellationTokenSource? _ftsRebuildCts;
// the flag — the flag check itself bails before we touch the database.
// Volatile because the ImGui thread reads the flag outside the lock to // Serialises retention sweeps so a manual trigger and the 24h auto-sweep
// gate the manual button; without it the JIT may cache the value in a // can't run in parallel. Volatile because the ImGui thread reads it outside
// register and miss the background-thread update. // the lock to gate the manual button.
internal readonly object RetentionSweepLock = new(); internal readonly object RetentionSweepLock = new();
internal volatile bool RetentionSweepRunning; internal volatile bool RetentionSweepRunning;
internal DateTime GameStarted { get; } internal DateTime GameStarted { get; }
// Tab management needs to happen outside the chatlog window class for access reasons // Tab management lives here rather than in ChatLogWindow for access reasons.
internal int LastTab { get; set; } internal int LastTab { get; set; }
internal int? WantedTab { get; set; } internal int? WantedTab { get; set; }
internal Tab CurrentTab internal Tab CurrentTab
@@ -149,52 +178,113 @@ public sealed class Plugin : IAsyncDalamudPlugin
public Plugin() public Plugin()
{ {
// Phase-1 ctor stays minimal: bootstrap-essentials only (conflict // Phase-1 ctor: bootstrap-essentials only (conflict gate, config load,
// gate, config load, language + ImGui init, WindowSystem skeleton). // language + ImGui init). All service/window allocation lives in LoadAsync.
// Schema migrations and every service / window allocation moved to
// LoadAsync so the sync ctor returns fast. On failure here nothing
// is initialized yet, so just throw — there is nothing to clean up.
// Refuse to start if upstream Chat 2 is loaded — prevents IPC // Block load if upstream Chat 2 is active — prevents IPC collisions
// channel collisions and double-replacement of the in-game chat // and double-replacement of the in-game chat window.
// window. Throwing here makes Dalamud abort the load cleanly with
// our localized message instead of crashing FFXIV mid-frame.
ChatTwoConflictDetector.ThrowIfChatTwoIsLoaded(Interface); ChatTwoConflictDetector.ThrowIfChatTwoIsLoaded(Interface);
GameStarted = Process.GetCurrentProcess().StartTime.ToUniversalTime(); GameStarted = Process.GetCurrentProcess().StartTime.ToUniversalTime();
// Hellion Chat: take over config + database from upstream ChatTwo // Migrate config + database from upstream ChatTwo on first start.
// before Dalamud loads our plugin config. Idempotent: only acts on
// the first start where the legacy paths exist and ours don't.
MigrateFromChatTwoLayout(); MigrateFromChatTwoLayout();
Config = Interface.GetPluginConfig() as Configuration ?? new Configuration(); Config = Interface.GetPluginConfig() as Configuration ?? new Configuration();
// Schema-gate: v1.4.3 only supports config schema v16. Older configs // PlatformUtil and LogProxy are filled from the DI container in
// went through their migrations in v1.2.1 (v15→v16) and earlier; users // Phase-1 below (`_host.Services.GetRequiredService<IPlatformUtil>()`
// who skipped past those releases need to install v1.4.2 first to run // and the LogProxy equivalent). Phase-0 helpers that run before that
// the migration chain, then upgrade to v1.4.3. // point (MigrateFromChatTwoLayout, LanguageChanged, ImGuiUtil.Initialize)
// do not touch either static, so the brief null-window is safe.
// Schema gate: v1.4.x requires config v16+. Users on older schemas
// must install v1.4.2 first to run the migration chain. v17 adds
// Tab.IsPinned (additive, no data migration needed) so v16 configs
// load cleanly and get their Version stamp bumped after the gate.
if (Config.Version < 16) if (Config.Version < 16)
{ {
throw new InvalidOperationException( throw new InvalidOperationException(
$"HellionChat v1.4.3 requires config schema v16, got v{Config.Version}. " $"HellionChat v1.4.10 requires config schema v16, got v{Config.Version}. "
+ "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.3." + "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.10."
); );
} }
Config.Version = 17;
// Hellion Chat — Auto-Tell-Tabs Defense-in-Depth. SaveConfig // Unpinned TempTabs are session-only and dropped on every load. Pinned
// already strips temp tabs before persistence, but a previous // TempTabs survive reload — Jin's tester feedback (v1.4.7).
// crash or external write could have left them in the JSON. Config.Tabs.RemoveAll(TabLifecycleHelpers.ShouldStripOnLoad);
// Drop them on load to guarantee the session-only invariant.
Config.Tabs.RemoveAll(t => t.IsTempTab);
LanguageChanged(Interface.UiLanguage); LanguageChanged(Interface.UiLanguage);
ImGuiUtil.Initialize(this); ImGuiUtil.Initialize(this);
DeferredSaveFrames = -1; DeferredSaveFrames = -1;
// WindowSystem skeleton is initialised by the readonly field above — // Custom themes dir + seed run before the container builds so the
// no AddWindow yet; window construction lives in LoadAsync. // ThemeRegistry factory lambda finds the directory ready.
var customThemesDir = Path.Combine(Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(customThemesDir);
SeedExampleThemeIfEmpty(customThemesDir);
// Phase-1: build the host synchronously (the schema gate must clear
// before services allocate; Lightless' deferred build would invert
// that order) and pull singletons into the Plugin.X surface.
var dependencies = new PluginHostDependencies(
Interface,
Log,
ChatGui,
ClientState,
CommandManager,
Condition,
DataManager,
Framework,
GameGui,
KeyState,
ObjectTable,
PartyList,
TargetManager,
TextureProvider,
GameInteropProvider,
GameConfig,
Notification,
AddonLifecycle,
PlayerState,
Evaluator,
SelfTestRegistry
);
_host = PluginHostFactory.Build(this, dependencies);
_lifecycle = _host.Services.GetRequiredService<PluginLifecycle>();
_lifecycle.Host = _host;
// Plugin.X static bridge - filled from the container so DI-aware code
// and the ~93 Plugin.X consumer sites read the same instances.
PlatformUtil = _host.Services.GetRequiredService<IPlatformUtil>();
LogProxy = _host.Services.GetRequiredService<IPluginLogProxy>();
FileDialogManager = _host.Services.GetRequiredService<FileDialogManager>();
// Resolve order matters: block-B services first so the windows can
// read Plugin.MessageManager etc. from their own ctors without NREs.
FontManager = _host.Services.GetRequiredService<FontManager>();
ThemeRegistry = _host.Services.GetRequiredService<Themes.ThemeRegistry>();
Commands = _host.Services.GetRequiredService<Commands>();
Functions = _host.Services.GetRequiredService<GameFunctions.GameFunctions>();
Ipc = _host.Services.GetRequiredService<IpcManager>();
TypingIpc = _host.Services.GetRequiredService<TypingIpc>();
ExtraChat = _host.Services.GetRequiredService<ExtraChat>();
HonorificService = _host.Services.GetRequiredService<Integrations.HonorificService>();
StatusBar = _host.Services.GetRequiredService<Ui.StatusBar>();
MessageManager = _host.Services.GetRequiredService<MessageManager>();
AutoTellTabsService = _host.Services.GetRequiredService<AutoTellTabsService>();
ChatLogWindow = _host.Services.GetRequiredService<ChatLogWindow>();
SettingsWindow = _host.Services.GetRequiredService<SettingsWindow>();
DbViewer = _host.Services.GetRequiredService<DbViewer>();
InputPreview = _host.Services.GetRequiredService<InputPreview>();
CommandHelpWindow = _host.Services.GetRequiredService<CommandHelpWindow>();
SeStringDebugger = _host.Services.GetRequiredService<SeStringDebugger>();
DebuggerWindow = _host.Services.GetRequiredService<DebuggerWindow>();
FirstRunWizard = _host.Services.GetRequiredService<FirstRunWizard>();
} }
public async Task LoadAsync(CancellationToken cancellationToken) public async Task LoadAsync(CancellationToken cancellationToken)
@@ -203,14 +293,8 @@ public sealed class Plugin : IAsyncDalamudPlugin
try try
{ {
// Hellion v1.0.0 default tab layout. Five thematically separated // Default tab layout on fresh install. Tells are handled by
// tabs: General catches the immediate-surroundings public chat // Auto-Tell-Tabs; Novice Network has no preset tab by design.
// (Say/Yell/Shout) only; System absorbs the rest of the technical
// and gameplay-event noise; FreeCompany, Group and Linkshell each
// own their respective channel set. Tells are not in a static
// tab anymore — Auto-Tell-Tabs spawns dedicated per-conversation
// tabs on demand. Novice-Network gets no preset tab; users who
// want it can add HellionBeginner from Settings → Tabs.
if (Config.Tabs.Count == 0) if (Config.Tabs.Count == 0)
{ {
Config.Tabs.Add(TabsUtil.VanillaGeneral); Config.Tabs.Add(TabsUtil.VanillaGeneral);
@@ -222,124 +306,166 @@ public sealed class Plugin : IAsyncDalamudPlugin
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// Sync allocation + handle registration. BuildFonts() registers // Container drives service init now: Host.StartAsync triggers the
// IFontHandles with Dalamud's UiBuilder.FontAtlas — registration // IHostedService adapters (FontManager.BuildFonts, ThemeRegistry
// itself is non-blocking (handles stored, lambdas queued). Dalamud // cache warmup + Switch, IPC eager-resolve, MessageManager
// rebuilds the atlas on its own pipeline a few frames later; first // FilterAllTabsAsync, AutoTellTabsService.Initialize). Window
// frames render with the default font until the rebuild lands and // registration with WindowSystem runs on the framework thread
// ImGui switches to Hellion-Exo2 / NotoSans (visible "font-pop"). // inside PluginLifecycle.LoadAsync after StartAsync returns.
// Mirrors ChatTwo Plugin.cs:152. if (_lifecycle is not null)
FontManager = new FontManager(); await _lifecycle.LoadAsync(cancellationToken).ConfigureAwait(false);
FontManager.BuildFonts();
// Theme init stays sync on the LoadAsync continuation — cheap,
// and Active is read every Draw frame, so the registry must be
// wired before the first hook fires.
var customThemesDir = Path.Combine(Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(customThemesDir);
SeedExampleThemeIfEmpty(customThemesDir);
ThemeRegistry = new Themes.ThemeRegistry(customThemesDir);
ThemeRegistry.Switch(Config.Theme);
cancellationToken.ThrowIfCancellationRequested();
// Service allocations: order encodes dependencies. Commands is
// alloc-only here; Initialise() runs after windows exist so the
// slash-commands can toggle their visibility. HonorificService
// registers IPC subscribers up-front so Ready/Disposing events
// are caught from the very first frame.
FileDialogManager = new FileDialogManager();
Commands = new Commands();
Functions = new GameFunctions.GameFunctions(this);
Ipc = new IpcManager();
TypingIpc = new TypingIpc(this);
ExtraChat = new ExtraChat();
HonorificService = new Integrations.HonorificService(Interface, Log, Framework);
StatusBar = new Ui.StatusBar();
MessageManager = new MessageManager(this);
// Auto-Tell-Tabs subscribes to MessageManager.MessageProcessed for
// live tells and to ClientState.Logout for cleanup; needs the live
// store handed in at construction.
AutoTellTabsService = new AutoTellTabsService(
this,
MessageManager,
MessageManager.Store
);
AutoTellTabsService.Initialize();
// SelfTest steps poll Active per frame and need the registry wired.
SelfTestRegistry.RegisterTestSteps([new SelfTests.ThemeSwitchSelfTestStep(this)]); SelfTestRegistry.RegisterTestSteps([new SelfTests.ThemeSwitchSelfTestStep(this)]);
ChatLogWindow = new ChatLogWindow(this);
SettingsWindow = new SettingsWindow(this);
DbViewer = new DbViewer(this);
InputPreview = new InputPreview(ChatLogWindow);
CommandHelpWindow = new CommandHelpWindow(ChatLogWindow);
SeStringDebugger = new SeStringDebugger(this);
DebuggerWindow = new DebuggerWindow(this);
FirstRunWizard = new FirstRunWizard(this);
WindowSystem.AddWindow(ChatLogWindow);
WindowSystem.AddWindow(SettingsWindow);
WindowSystem.AddWindow(DbViewer);
WindowSystem.AddWindow(InputPreview);
WindowSystem.AddWindow(CommandHelpWindow);
WindowSystem.AddWindow(SeStringDebugger);
WindowSystem.AddWindow(DebuggerWindow);
WindowSystem.AddWindow(FirstRunWizard);
// Open the wizard on a fresh install. Existing ChatTwo users have
// FirstRunCompleted set to true by the v6→v7 migration above.
if (!Config.FirstRunCompleted) if (!Config.FirstRunCompleted)
FirstRunWizard.IsOpen = true; FirstRunWizard.IsOpen = true;
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// let all the other components register, then initialize commands // Populate the command dictionary + UiBuilder hooks BEFORE
// Commands.Initialise() walks the dictionary and registers each
// entry with Dalamud's CommandManager (Commands.cs:15-28). Adding
// wrappers after Initialise() would leak them — they'd live in
// the dictionary but never reach Dalamud.
SetupCommands();
Commands.Initialise(); Commands.Initialise();
// Daily retention sweep, fire-and-forget. Skips itself when // Daily retention sweep fire-and-forget, skips when disabled
// disabled or when it already ran within the past 24 hours. // or already ran within the past 24 hours.
RunRetentionSweepIfDue(); RunRetentionSweepIfDue();
if (Config.ShowEmotes) if (Config.ShowEmotes)
_ = EmoteCache.LoadData(); // Fire-and-forget, exceptions caught inside _ = EmoteCache.LoadData();
if (Interface.Reason is not PluginLoadReason.Boot) // FilterAllTabsAsync now runs from MessageManagerInitHostedService
MessageManager.FilterAllTabsAsync(); // during Host.StartAsync (same Reason-not-Boot guard there).
// Kick the FTS5 rebuild worker if Migrate4 just added the schema or
// a previous run was cut short (InitFtsReadyCache leaves _ftsReady
// false in that case). Runs off the framework thread on its own
// SqliteConnection so the live UpsertMessage path keeps flowing
// through the chunked-commit windows.
_ftsRebuildCts = new CancellationTokenSource();
if (!MessageManager.Store.IsFtsIndexBuilt)
{
var token = _ftsRebuildCts.Token;
_ = Task.Run(
async () =>
{
// FQN: Plugin.Notification (Z.74) shadows the type name.
Dalamud.Interface.ImGuiNotification.IActiveNotification? notif = null;
try
{
notif = Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification
{
Title = "Hellion Chat",
Content = "Indexing chat history for full-text search...",
Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Info,
Minimized = false,
InitialDuration = TimeSpan.FromMinutes(10),
}
);
// Progress<T> raises this callback on the captured
// sync-context (Task.Run worker pool). IActiveNotification
// is ImGui-backed and mutates the UI, so marshal the
// mutation onto the framework thread via RunOnTick.
var progress = new Progress<long>(done =>
{
Framework.RunOnTick(() =>
{
if (notif is { } n)
n.Content = $"Indexing chat history: {done:N0} messages...";
});
});
// Worker-owned connection. Closed+disposed before we
// flip the readiness flag so the DbViewer never sees
// IsFtsIndexBuilt=true while the worker connection
// is still alive.
SqliteConnection? workerConn = null;
try
{
workerConn = MessageManager.Store.OpenSecondaryConnection();
var total = await Task.Run(
() =>
MessageManager.Store.RebuildFtsIndex(
workerConn,
progress,
token
),
token
)
.ConfigureAwait(false);
workerConn.Close();
workerConn.Dispose();
workerConn = null;
MessageManager.Store.MarkFtsIndexBuilt();
if (notif is { } final)
{
final.Content = $"Indexed {total:N0} messages.";
final.Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Success;
final.InitialDuration = TimeSpan.FromSeconds(5);
}
}
finally
{
workerConn?.Dispose();
}
}
catch (OperationCanceledException)
{
notif?.DismissNow();
}
catch (Exception ex)
{
Log.Error(ex, "FTS index rebuild failed");
if (notif is { } err)
{
err.Content =
"Full-text indexing failed -- search will use local filter only.";
err.Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Error;
}
}
},
_ftsRebuildCts.Token
);
}
Interface.UiBuilder.DisableCutsceneUiHide = true; Interface.UiBuilder.DisableCutsceneUiHide = true;
Interface.UiBuilder.DisableGposeUiHide = true; Interface.UiBuilder.DisableGposeUiHide = true;
#if !DEBUG #if !DEBUG
// Fire-and-forget on a worker thread. The first auto-translate use of // Fire-and-forget first auto-translate use may have a sub-second
// a session may have a sub-second hitch if the cache hasn't filled yet, // hitch if the cache hasn't filled yet, but avoids blocking load.
// but that's preferable to making every user wait ~300 ms during
// plugin load for a cache they may never touch. ChatTwo (upstream)
// does this sync; we trade load-time for first-use latency.
_ = Task.Run(AutoTranslate.PreloadCache, cancellationToken); _ = Task.Run(AutoTranslate.PreloadCache, cancellationToken);
#endif #endif
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// (B1) Hooks last: every service and window must be live before // Hooks last — all services and windows must be live before
// Dalamud fires our first Draw / FrameworkUpdate tick. Anything // the first Draw / FrameworkUpdate tick fires.
// earlier risks rendering against null FontManager / ThemeRegistry.
Framework.Update += FrameworkUpdate; Framework.Update += FrameworkUpdate;
Interface.UiBuilder.Draw += Draw; Interface.UiBuilder.Draw += Draw;
Interface.LanguageChanged += LanguageChanged; Interface.LanguageChanged += LanguageChanged;
// Hellion Chat — surface a "main UI" entry point so Dalamud's
// plugin list shows the Open-Plugin button. Settings is the
// most useful landing place; OpenConfigUi is already wired to
// the same toggle inside SettingsWindow.
Interface.UiBuilder.OpenMainUi += OpenMainUi;
} }
catch catch
{ {
// Mirror the v1.4.0 load-failure recovery: hand off to DisposeAsync
// so partially-built services are torn down. Swallow the cleanup
// exception so the original load failure stays the visible cause.
try try
{ {
await DisposeAsync().ConfigureAwait(false); await DisposeAsync().ConfigureAwait(false);
@@ -351,28 +477,40 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
} }
// Suppressing this warning because DisposeAsync may run after a partial
// LoadAsync, so some properties may not be initialized.
[SuppressMessage("ReSharper", "ConditionalAccessQualifierIsNonNullableAccordingToAPIContract")] [SuppressMessage("ReSharper", "ConditionalAccessQualifierIsNonNullableAccordingToAPIContract")]
public async ValueTask DisposeAsync() public async ValueTask DisposeAsync()
{ {
// (B3) Idempotency guard — Dalamud may reload-race us; second // Idempotency guard — second call short-circuits on reload race.
// call short-circuits so we don't double-dispose services.
if (Interlocked.Exchange(ref _disposeStarted, 1) != 0) if (Interlocked.Exchange(ref _disposeStarted, 1) != 0)
return; return;
// Set before any cleanup so deferred Framework.RunOnTick callbacks
// (B3 retention sweep) see the flag and bail out before they touch
// MessageManager / Log / static fields that the rest of this method
// is about to tear down.
_isDisposing = true;
Exception? failure = null; Exception? failure = null;
// Hooks unsubscribe FIRST so no Draw / FrameworkUpdate / LanguageChanged // Unsubscribe hooks first — mirrors the hooks-last subscribe order in LoadAsync.
// tick can fire while we're tearing services down. Mirrors the
// hooks-last subscribe order in LoadAsync.
failure = CaptureFailure(failure, () => Interface.UiBuilder.OpenMainUi -= OpenMainUi);
failure = CaptureFailure(failure, () => Interface.LanguageChanged -= LanguageChanged); failure = CaptureFailure(failure, () => Interface.LanguageChanged -= LanguageChanged);
failure = CaptureFailure(failure, () => Interface.UiBuilder.Draw -= Draw); failure = CaptureFailure(failure, () => Interface.UiBuilder.Draw -= Draw);
failure = CaptureFailure(failure, () => Framework.Update -= FrameworkUpdate); failure = CaptureFailure(failure, () => Framework.Update -= FrameworkUpdate);
// v1.4.0 F5.3 — flush a pending DeferredSave before service teardown, // Signal the FTS rebuild worker to bail. Runs before MessageManager
// since FrameworkUpdate just got unsubscribed and won't fire it. // tears down so the worker's "rebuild failed" log path still finds
// a live Log static. Worker owns its own SqliteConnection and disposes
// it itself; we only flip the cancellation flag here.
failure = CaptureFailure(
failure,
() =>
{
_ftsRebuildCts?.Cancel();
_ftsRebuildCts?.Dispose();
}
);
// Flush a pending DeferredSave — FrameworkUpdate won't fire it anymore.
failure = CaptureFailure( failure = CaptureFailure(
failure, failure,
() => () =>
@@ -385,59 +523,18 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
); );
// Auto-Tell-Tabs unsubscribes from MessageProcessed before MessageManager // Framework-thread cleanup the container does not reach.
// goes away. Pure-memory cleanup, no framework-thread requirement.
failure = CaptureFailure(failure, () => AutoTellTabsService?.Dispose());
// v1.4.0 F6.2 — MessageManager has its own async dispose path
// (DB flush, pending-message thread shutdown). Run it before the
// framework-block so the worker threads are quiesced first.
if (MessageManager is not null)
{
failure = await CaptureFailureAsync(
failure,
() => MessageManager.DisposeAsync().AsTask()
)
.ConfigureAwait(false);
}
// (B4) Game-Function / IPC / UI-Window cleanup MUST run on the
// framework thread. WindowSystem mutations and IPC subscriber
// disposes touch Dalamud state that's only safe from the framework.
// Worker-thread DisposeAsync would race the next Draw tick.
// Per-line CaptureFailure so a single throw can't strand the lines
// behind it; mirrors Lightless DisposeFrameworkBoundServicesAsync.
try try
{ {
await Framework await Framework
.RunOnFrameworkThread(() => .RunOnFrameworkThread(() =>
{ {
// Game-Functions first — other services may still query failure = CaptureFailure(failure, TearDownCommands);
// chat-interactable state during their Dispose.
failure = CaptureFailure( failure = CaptureFailure(
failure, failure,
() => GameFunctions.GameFunctions.SetChatInteractable(true) () => GameFunctions.GameFunctions.SetChatInteractable(true)
); );
// IPC subscribers — dispose before windows so any final
// event firing from the IPC source can't reach a half-torn
// ChatLogWindow.
failure = CaptureFailure(failure, () => HonorificService?.Dispose());
failure = CaptureFailure(failure, () => TypingIpc?.Dispose());
failure = CaptureFailure(failure, () => ExtraChat?.Dispose());
failure = CaptureFailure(failure, () => Ipc?.Dispose());
// Windows — RemoveAllWindows first, then per-window Dispose.
// Order matches the pre-v1.4.3 Dispose body byte-for-byte.
// CommandHelpWindow and FirstRunWizard don't implement
// IDisposable; their resources are reclaimed via WindowSystem.
failure = CaptureFailure(failure, () => WindowSystem?.RemoveAllWindows()); failure = CaptureFailure(failure, () => WindowSystem?.RemoveAllWindows());
failure = CaptureFailure(failure, () => ChatLogWindow?.Dispose());
failure = CaptureFailure(failure, () => DbViewer?.Dispose());
failure = CaptureFailure(failure, () => InputPreview?.Dispose());
failure = CaptureFailure(failure, () => SettingsWindow?.Dispose());
failure = CaptureFailure(failure, () => DebuggerWindow?.Dispose());
failure = CaptureFailure(failure, () => SeStringDebugger?.Dispose());
}) })
.ConfigureAwait(false); .ConfigureAwait(false);
} }
@@ -446,19 +543,25 @@ public sealed class Plugin : IAsyncDalamudPlugin
failure ??= ex; failure ??= ex;
} }
// Pure-memory cleanups — no Framework / UI / IPC touch, so they // Container disposes services + windows on the framework thread.
// run on whatever thread DisposeAsync resumes on. // MessageManager.DisposeAsync is not idempotent, so we let the
failure = CaptureFailure(failure, () => Functions?.Dispose()); // container do it once instead of double-disposing.
failure = CaptureFailure(failure, () => Commands?.Dispose()); if (_lifecycle is not null)
{
failure = await CaptureFailureAsync(failure, () => _lifecycle.DisposeAsync().AsTask())
.ConfigureAwait(false);
}
// Static-class cleanups the container has no handle on.
failure = CaptureFailure(failure, () => EmoteCache.Dispose()); failure = CaptureFailure(failure, () => EmoteCache.Dispose());
failure = CaptureFailure(failure, InputHistoryService.Reset);
if (failure is not null) if (failure is not null)
ExceptionDispatchInfo.Capture(failure).Throw(); ExceptionDispatchInfo.Capture(failure).Throw();
} }
// Lightless-pattern capture helpers: run cleanup, remember the FIRST // Run cleanup actions individually so a single failure doesn't strand
// exception, keep going. Without these one mid-teardown failure would // the remaining teardown steps.
// skip every cleanup behind it and leave services half-torn.
private static Exception? CaptureFailure(Exception? failure, Action action) private static Exception? CaptureFailure(Exception? failure, Action action)
{ {
try try
@@ -499,9 +602,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
var ourConfigFile = Path.Combine(pluginConfigsDir, "HellionChat.json"); var ourConfigFile = Path.Combine(pluginConfigsDir, "HellionChat.json");
var ourConfigDir = Interface.ConfigDirectory.FullName; var ourConfigDir = Interface.ConfigDirectory.FullName;
// Track whether anything legitimately blocked us. The most common
// cause is upstream Chat 2 still being loaded — its SQLite handle
// keeps chat-sqlite.db locked and File.Move throws IOException.
var lockedBlocker = false; var lockedBlocker = false;
try try
@@ -523,13 +623,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
lockedBlocker = true; lockedBlocker = true;
} }
// The plugin's ConfigDirectory may already exist on first load
// (Dalamud creates it), so check at the file level instead of
// skipping when the directory is present. Move every legacy
// entry whose target name is not occupied yet, then remove the
// source dir if it ends up empty. Each move is wrapped on its
// own so a single locked file (the SQLite db while ChatTwo still
// runs) does not abandon the rest of the migration.
if (!Directory.Exists(legacyConfigDir)) if (!Directory.Exists(legacyConfigDir))
return; return;
@@ -537,6 +630,8 @@ public sealed class Plugin : IAsyncDalamudPlugin
{ {
Directory.CreateDirectory(ourConfigDir); Directory.CreateDirectory(ourConfigDir);
// Move each file individually so a single locked file (e.g. the
// SQLite db while ChatTwo is still loaded) doesn't abort the rest.
foreach (var file in Directory.EnumerateFiles(legacyConfigDir)) foreach (var file in Directory.EnumerateFiles(legacyConfigDir))
{ {
var target = Path.Combine(ourConfigDir, Path.GetFileName(file)); var target = Path.Combine(ourConfigDir, Path.GetFileName(file));
@@ -590,9 +685,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (lockedBlocker) if (lockedBlocker)
{ {
// Surface the most common cause to the user as a notification
// so they don't think Hellion Chat lost their history when in
// fact upstream Chat 2 was still holding the database file.
Notification.AddNotification( Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification new Dalamud.Interface.ImGuiNotification.Notification
{ {
@@ -608,15 +700,95 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
} }
private void OpenMainUi() // Central slash-command + UiBuilder.OpenConfigUi/OpenMainUi subscribe so
// the four lazy windows (Settings, DbViewer, SeStringDebugger, Debugger)
// have working entry points before they're constructed.
private void SetupCommands()
{ {
// Settings is the most useful landing surface — same target as the // ChatLogWindow.cs:128 already registers /hellion (ToggleChat). The
// Configure button. SettingsWindow.Toggle is internal and already // description-arg here keeps the Dalamud help list populated.
// wired to OpenConfigUi, so re-using IsOpen keeps both entry points _hellionSettingsCmd = Commands.Register(
// behaviourally identical. "/hellion",
SettingsWindow.IsOpen = !SettingsWindow.IsOpen; "Perform various actions with Hellion Chat."
);
_hellionSettingsCmd.Execute += OnHellionSettingsCommand;
_hellionViewCmd = Commands.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
);
_hellionViewCmd.Execute += OnHellionViewCommand;
_hellionDebuggerCmd = Commands.Register("/hellionDebugger", showInHelp: false);
_hellionDebuggerCmd.Execute += OnHellionDebuggerCommand;
#if DEBUG
// SeStringDebugger.cs lives under #if DEBUG too; keep this out of release builds.
_hellionSeStringCmd = Commands.Register("/hellionSeString", showInHelp: false);
_hellionSeStringCmd.Execute += OnHellionSeStringCommand;
#endif
// Plugin-Manager "Settings" button. Was in Settings.cs:67 pre-v1.4.9.
Interface.UiBuilder.OpenConfigUi += OnOpenConfigUi;
// Plugin-Manager "Open" button. Was in Plugin.cs LoadAsync pre-v1.4.9
// (separate OpenMainUi handler that flipped SettingsWindow.IsOpen).
Interface.UiBuilder.OpenMainUi += OnOpenMainUi;
} }
private void TearDownCommands()
{
Interface.UiBuilder.OpenMainUi -= OnOpenMainUi;
Interface.UiBuilder.OpenConfigUi -= OnOpenConfigUi;
// Null-tolerant detaches: TearDownCommands can run from the LoadAsync
// failure path (Plugin.cs CaptureFailure) before SetupCommands finished.
if (_hellionSettingsCmd is not null)
{
_hellionSettingsCmd.Execute -= OnHellionSettingsCommand;
_hellionSettingsCmd = null;
}
if (_hellionViewCmd is not null)
{
_hellionViewCmd.Execute -= OnHellionViewCommand;
_hellionViewCmd = null;
}
if (_hellionDebuggerCmd is not null)
{
_hellionDebuggerCmd.Execute -= OnHellionDebuggerCommand;
_hellionDebuggerCmd = null;
}
#if DEBUG
if (_hellionSeStringCmd is not null)
{
_hellionSeStringCmd.Execute -= OnHellionSeStringCommand;
_hellionSeStringCmd = null;
}
#endif
}
private void OnHellionSettingsCommand(string command, string arguments)
{
// /hellion with args is intentionally a no-op (matches pre-v1.4.9
// Settings.cs:76-80 behaviour).
if (string.IsNullOrWhiteSpace(arguments))
SettingsWindow.Toggle();
}
private void OnOpenConfigUi() => SettingsWindow.Toggle();
private void OnOpenMainUi() => SettingsWindow.Toggle();
private void OnHellionViewCommand(string _, string __) => DbViewer.Toggle();
private void OnHellionDebuggerCommand(string _, string __) => DebuggerWindow.Toggle();
#if DEBUG
private void OnHellionSeStringCommand(string _, string __) => SeStringDebugger.Toggle();
#endif
private void RunRetentionSweepIfDue() private void RunRetentionSweepIfDue()
{ {
if (!Config.RetentionEnabled) if (!Config.RetentionEnabled)
@@ -624,8 +796,7 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (DateTimeOffset.UtcNow - Config.RetentionLastRunAt < TimeSpan.FromHours(24)) if (DateTimeOffset.UtcNow - Config.RetentionLastRunAt < TimeSpan.FromHours(24))
return; return;
// Snapshot the policy so the user can edit settings while we run. // Snapshot the policy so the user can edit settings while the sweep runs.
// Spec defaults form the baseline; explicit user overrides win.
var policy = new Dictionary<int, int>(); var policy = new Dictionary<int, int>();
foreach (var (type, days) in Privacy.PrivacyDefaults.DefaultRetentionDays) foreach (var (type, days) in Privacy.PrivacyDefaults.DefaultRetentionDays)
policy[(int)(ushort)type] = days; policy[(int)(ushort)type] = days;
@@ -633,16 +804,10 @@ public sealed class Plugin : IAsyncDalamudPlugin
policy[(int)(ushort)type] = days; policy[(int)(ushort)type] = days;
var defaultDays = Config.RetentionDefaultDays; var defaultDays = Config.RetentionDefaultDays;
// IsBackground = true for the same reason as PendingMessageThread: // IsBackground = true so a stuck sweep never blocks plugin unload.
// a stuck sweep must never block plugin unload. RunRetentionSweepIfDue
// guards the run-frequency, and the sweep itself uses the framework's
// cooperative cancellation pattern. The background flag is the safety
// net if the sweep ever takes longer than expected.
new Thread(() => new Thread(() =>
{ {
// Bail out cheaply if a manual sweep is already in flight; the // Bail early if a manual sweep is already in flight.
// lock around the actual work would queue us up otherwise and
// we would just re-do whatever the manual run already did.
lock (RetentionSweepLock) lock (RetentionSweepLock)
{ {
if (RetentionSweepRunning) if (RetentionSweepRunning)
@@ -659,18 +824,31 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (deleted > 0) if (deleted > 0)
{ {
Log.Information($"Retention sweep deleted {deleted} expired messages."); Log.Information($"Retention sweep deleted {deleted} expired messages.");
// Run the clear+refilter synchronously on the framework thread. // Schedule on the next framework tick to avoid the ~194ms
// Earlier this called FilterAllTabsAsync(), which is fire-and-forget // hitch from blocking with .Wait() while the framework
// — the .Wait() here would return as soon as the inner Task.Run was // finishes the current frame. Tabs-list mutation must
// dispatched, racing the next sweep cycle against the still-running // stay on the framework thread because Plugin.Config.Tabs
// filter pass. See AUDIT-2026-05-05 [QUAL-02]. // (Configuration.cs:222) is not lock-protected and
Framework // AutoTellTabsService can mutate it from background paths.
.Run(() => // Pattern reference: SimpleTweaks
// Tweaks/Chat/CaseInsensitiveCommands.cs:45.
Framework.RunOnTick(() =>
{
// The retention thread is IsBackground=true so plugin
// unload can fire while a scheduled tick is still
// pending; bail before touching anything torn down.
if (_isDisposing)
return;
try
{ {
MessageManager.ClearAllTabs(); MessageManager.ClearAllTabs();
MessageManager.FilterAllTabs(); MessageManager.FilterAllTabs();
}) }
.Wait(); catch (Exception ex)
{
Log.Error(ex, "Retention sweep clear+refilter failed");
}
});
} }
else else
{ {
@@ -694,9 +872,13 @@ public sealed class Plugin : IAsyncDalamudPlugin
private void Draw() private void Draw()
{ {
// Theme-Engine ist ab v14 immer aktiv; Klassik ist jetzt ein eigenes // v1.4.8 B2: pick up external edits of the active custom theme JSON
// Theme statt einem deaktivierten Hellion-Theme. Active wird einmal // without forcing the user to re-click the picker. The disk-stat is
// pro Frame aus der Registry gelesen. // 1Hz-throttled inside RefreshActiveIfStale, so this is essentially
// free on built-in themes and ~1 stat/second on custom themes.
ThemeRegistry.RefreshActiveIfStale();
// Theme engine is always active; Classic is a theme, not a disabled state.
using IDisposable _style = HellionStyle.PushGlobal( using IDisposable _style = HellionStyle.PushGlobal(
ThemeRegistry.Active, ThemeRegistry.Active,
Config.WindowOpacity Config.WindowOpacity
@@ -711,9 +893,7 @@ public sealed class Plugin : IAsyncDalamudPlugin
return; return;
} }
// v1.0.2 — global skip while the New Game+ menu (QuestRedo addon) is // Hide all plugin windows while the New Game+ menu is open.
// open. Hides every plugin window in one shot (chat log, pop-outs,
// settings, db viewer, etc.), matching the LoadingScreens pattern.
if ( if (
Config.HideInNewGamePlusMenu Config.HideInNewGamePlusMenu
&& GameFunctions.GameFunctions.IsAddonInteractable( && GameFunctions.GameFunctions.IsAddonInteractable(
@@ -742,17 +922,17 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal void SaveConfig() internal void SaveConfig()
{ {
// Hellion Chat — Auto-Tell-Tabs are session-only. Strip them out // Only unpinned TempTabs are session-only — they move aside before
// before serialization so a crash mid-session can never persist // serialization and re-attach after. Pinned TempTabs stay in
// them. We snapshot the full tab list first and restore it after // Config.Tabs across the save so JSON includes them. Cloning only the
// the save, preserving the user's order and open conversations. // unpinned subset keeps the allocation proportional to
var snapshot = Config.Tabs.ToList(); // AutoTellTabsLimit (<=15) instead of the full tab list.
Config.Tabs.RemoveAll(t => t.IsTempTab); var unpinnedTempTabs = Config.Tabs.Where(TabLifecycleHelpers.IsInUnpinnedPool).ToList();
Config.Tabs.RemoveAll(TabLifecycleHelpers.ShouldStripOnSave);
Interface.SavePluginConfig(Config); Interface.SavePluginConfig(Config);
Config.Tabs.Clear(); Config.Tabs.AddRange(unpinnedTempTabs);
Config.Tabs.AddRange(snapshot);
} }
internal void LanguageChanged(string langCode) internal void LanguageChanged(string langCode)
@@ -794,9 +974,8 @@ public sealed class Plugin : IAsyncDalamudPlugin
Condition[ConditionFlag.OccupiedInCutSceneEvent] Condition[ConditionFlag.OccupiedInCutSceneEvent]
|| Condition[ConditionFlag.WatchingCutscene78]; || Condition[ConditionFlag.WatchingCutscene78];
// v1.1.0 — wenn der themes/-Ordner leer ist, schreiben wir die embedded // Seeds example-theme.json into the themes dir on first run.
// example-theme.json als Vorlage rein. Bestehende User-Customs werden // Skipped if any custom JSON already exists.
// nicht angefasst (existing JSONs lassen den Block überspringen).
private static void SeedExampleThemeIfEmpty(string dir) private static void SeedExampleThemeIfEmpty(string dir)
{ {
if (Directory.EnumerateFiles(dir, "*.json").Any()) if (Directory.EnumerateFiles(dir, "*.json").Any())
+199
View File
@@ -0,0 +1,199 @@
using Dalamud.Interface.ImGuiFileDialog;
using Dalamud.Plugin;
using Dalamud.Plugin.Services;
using HellionChat.Infrastructure.Hosting;
using HellionChat.Infrastructure.Logging;
using HellionChat.Ipc;
using HellionChat.Themes;
using HellionChat.Ui;
using HellionChat.Util;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
namespace HellionChat;
// Builds the generic-host DI container that drives v1.5.0+. The factory is
// invoked synchronously from Plugin.ctor (after the schema gate clears) so the
// container exists before PluginLifecycle.LoadAsync runs. See plan §1 for the
// deliberate divergence from Lightless' deferred Func-delegate pattern.
internal static class PluginHostFactory
{
public static IHost Build(Plugin plugin, PluginHostDependencies dependencies)
{
return new HostBuilder()
.UseContentRoot(dependencies.PluginInterface.ConfigDirectory.FullName)
.ConfigureLogging(logging =>
{
logging.ClearProviders();
logging.AddDalamudLogging(dependencies.PluginLog);
logging.SetMinimumLevel(LogLevel.Trace);
})
.ConfigureServices(services => ConfigureServices(services, plugin, dependencies))
.Build();
}
private static void ConfigureServices(
IServiceCollection services,
Plugin plugin,
PluginHostDependencies dependencies
)
{
// Block A — Dalamud services (21 [PluginService] singletons).
services.AddSingleton(dependencies);
services.AddSingleton(dependencies.PluginInterface);
services.AddSingleton(dependencies.PluginLog);
services.AddSingleton(dependencies.ChatGui);
services.AddSingleton(dependencies.ClientState);
services.AddSingleton(dependencies.CommandManager);
services.AddSingleton(dependencies.Condition);
services.AddSingleton(dependencies.DataManager);
services.AddSingleton(dependencies.Framework);
services.AddSingleton(dependencies.GameGui);
services.AddSingleton(dependencies.KeyState);
services.AddSingleton(dependencies.ObjectTable);
services.AddSingleton(dependencies.PartyList);
services.AddSingleton(dependencies.TargetManager);
services.AddSingleton(dependencies.TextureProvider);
services.AddSingleton(dependencies.GameInteropProvider);
services.AddSingleton(dependencies.GameConfig);
services.AddSingleton(dependencies.Notification);
services.AddSingleton(dependencies.AddonLifecycle);
services.AddSingleton(dependencies.PlayerState);
services.AddSingleton(dependencies.Evaluator);
services.AddSingleton(dependencies.SelfTestRegistry);
// Self-references: Plugin and its WindowSystem already exist.
services.AddSingleton(plugin);
services.AddSingleton(plugin.WindowSystem);
services.AddSingleton<PluginLifecycle>();
// Block B — HellionChat singletons. Factory lambdas because most
// classes are internal-sealed and the default activator only sees
// public ctors.
services.AddSingleton<IPlatformUtil>(_ => new DalamudPlatformUtil());
services.AddSingleton<IPluginLogProxy>(sp => new DalamudPluginLogProxy(
sp.GetRequiredService<IPluginLog>()
));
services.AddSingleton<FileDialogManager>(_ => new FileDialogManager());
services.AddSingleton(sp => new Commands(sp.GetRequiredService<ILogger<Commands>>()));
services.AddSingleton(_ => new FontManager());
services.AddSingleton(_ => new StatusBar());
services.AddSingleton(sp => new IpcManager(sp.GetRequiredService<ILogger<IpcManager>>()));
services.AddSingleton(sp => new ExtraChat(sp.GetRequiredService<ILogger<ExtraChat>>()));
services.AddSingleton(sp => new ThemeRegistry(
Path.Combine(
sp.GetRequiredService<IDalamudPluginInterface>().ConfigDirectory.FullName,
"themes"
),
sp.GetRequiredService<ILogger<ThemeRegistry>>()
));
services.AddSingleton(sp => new GameFunctions.GameFunctions(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILogger<GameFunctions.GameFunctions>>(),
sp.GetRequiredService<ILoggerFactory>()
));
services.AddSingleton(sp => new TypingIpc(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILogger<TypingIpc>>()
));
services.AddSingleton(sp => new Integrations.HonorificService(
sp.GetRequiredService<IDalamudPluginInterface>(),
sp.GetRequiredService<ILogger<Integrations.HonorificService>>(),
sp.GetRequiredService<IFramework>()
));
services.AddSingleton(sp => new MessageManager(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILogger<MessageManager>>(),
sp.GetRequiredService<ILoggerFactory>()
));
// MessageStore is allocated inside MessageManager.ctor; a separate
// container singleton would double-construct the SQLite handle.
services.AddSingleton(sp =>
{
var pluginRef = sp.GetRequiredService<Plugin>();
var manager = sp.GetRequiredService<MessageManager>();
return new AutoTellTabsService(
pluginRef,
manager,
manager.Store,
sp.GetRequiredService<ILogger<AutoTellTabsService>>()
);
});
// Block C — Windows. WindowSystem.AddWindow is called from
// PluginLifecycle.LoadAsync on the framework thread.
services.AddSingleton(sp => new ChatLogWindow(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILogger<ChatLogWindow>>(),
sp.GetRequiredService<ILoggerFactory>()
));
services.AddSingleton(sp => new SettingsWindow(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILoggerFactory>()
));
services.AddSingleton(sp => new DbViewer(
sp.GetRequiredService<Plugin>(),
sp.GetRequiredService<ILogger<DbViewer>>()
));
services.AddSingleton(sp => new InputPreview(sp.GetRequiredService<ChatLogWindow>()));
services.AddSingleton(sp => new CommandHelpWindow(sp.GetRequiredService<ChatLogWindow>()));
services.AddSingleton(sp => new SeStringDebugger(sp.GetRequiredService<Plugin>()));
services.AddSingleton(sp => new DebuggerWindow(sp.GetRequiredService<Plugin>()));
services.AddSingleton(sp => new FirstRunWizard(sp.GetRequiredService<Plugin>()));
// Hosted-service adapters: thin wrappers around the existing init
// methods so the service class bodies stay unchanged.
services.AddHostedService(sp => new FontManagerInitHostedService(
sp.GetRequiredService<FontManager>()
));
services.AddHostedService(sp => new ThemeRegistryInitHostedService(
sp.GetRequiredService<ThemeRegistry>()
));
services.AddHostedService(sp => new IpcManagerInitHostedService(
sp.GetRequiredService<IpcManager>()
));
services.AddHostedService(sp => new TypingIpcInitHostedService(
sp.GetRequiredService<TypingIpc>()
));
services.AddHostedService(sp => new ExtraChatInitHostedService(
sp.GetRequiredService<ExtraChat>()
));
services.AddHostedService(sp => new MessageManagerInitHostedService(
sp.GetRequiredService<IDalamudPluginInterface>(),
sp.GetRequiredService<MessageManager>()
));
services.AddHostedService(sp => new AutoTellTabsServiceInitHostedService(
sp.GetRequiredService<AutoTellTabsService>()
));
}
}
internal sealed record PluginHostDependencies(
IDalamudPluginInterface PluginInterface,
IPluginLog PluginLog,
IChatGui ChatGui,
IClientState ClientState,
ICommandManager CommandManager,
ICondition Condition,
IDataManager DataManager,
IFramework Framework,
IGameGui GameGui,
IKeyState KeyState,
IObjectTable ObjectTable,
IPartyList PartyList,
ITargetManager TargetManager,
ITextureProvider TextureProvider,
IGameInteropProvider GameInteropProvider,
IGameConfig GameConfig,
INotificationManager Notification,
IAddonLifecycle AddonLifecycle,
IPlayerState PlayerState,
ISeStringEvaluator Evaluator,
ISelfTestRegistry SelfTestRegistry
);
+143
View File
@@ -0,0 +1,143 @@
using System.Runtime.ExceptionServices;
using Dalamud.Plugin.Services;
using Microsoft.Extensions.Hosting;
namespace HellionChat;
// Orchestrates Host.StartAsync / StopAsync and the framework-thread dispose.
// Plugin.ctor builds the host and assigns it via the Host property, so
// PluginLifecycle never constructs the host itself.
internal sealed class PluginLifecycle : IAsyncDisposable
{
private readonly IFramework _framework;
private readonly Plugin _plugin;
private int _disposeStarted;
private bool _hostStartRequested;
public PluginLifecycle(IFramework framework, Plugin plugin)
{
_framework = framework;
_plugin = plugin;
}
// Plugin.ctor fills this immediately after PluginHostFactory.Build and
// before invoking LoadAsync; LoadAsync may NRE-suppress on Host! safely.
public IHost? Host { get; set; }
public async Task LoadAsync(CancellationToken cancellationToken)
{
cancellationToken.ThrowIfCancellationRequested();
try
{
_hostStartRequested = true;
await Host!.StartAsync(cancellationToken).ConfigureAwait(false);
// WindowSystem.AddWindow mutates an internal List<>; v1.4.9 Stage-2
// verified the list is non-thread-safe, so we marshal the entire
// registration block to the framework thread.
await _framework
.RunOnFrameworkThread(() => RegisterWindows(_plugin))
.ConfigureAwait(false);
}
catch
{
try
{
await DisposeAsync().ConfigureAwait(false);
}
catch
{
// Swallow secondary dispose failure so the original load throw wins.
}
throw;
}
}
private static void RegisterWindows(Plugin plugin)
{
plugin.WindowSystem.AddWindow(plugin.ChatLogWindow);
plugin.WindowSystem.AddWindow(plugin.SettingsWindow);
plugin.WindowSystem.AddWindow(plugin.DbViewer);
plugin.WindowSystem.AddWindow(plugin.InputPreview);
plugin.WindowSystem.AddWindow(plugin.CommandHelpWindow);
plugin.WindowSystem.AddWindow(plugin.SeStringDebugger);
plugin.WindowSystem.AddWindow(plugin.DebuggerWindow);
plugin.WindowSystem.AddWindow(plugin.FirstRunWizard);
}
public async ValueTask DisposeAsync()
{
// Idempotency guard — Dalamud may fire DisposeAsync twice in a reload race.
if (Interlocked.Exchange(ref _disposeStarted, 1) != 0)
return;
Exception? failure = null;
if (_hostStartRequested && Host is not null)
failure = await CaptureFailureAsync(failure, () => Host.StopAsync())
.ConfigureAwait(false);
failure = await DisposeHostOnFrameworkThreadAsync(failure).ConfigureAwait(false);
ThrowIfFailed(failure);
}
private async Task<Exception?> DisposeHostOnFrameworkThreadAsync(Exception? failure)
{
try
{
await _framework
.RunOnFrameworkThread(() =>
{
failure = CaptureFailure(failure, () => Host?.Dispose());
})
.ConfigureAwait(false);
}
catch (Exception ex)
{
failure ??= ex;
}
return failure;
}
private static Exception? CaptureFailure(Exception? failure, Action action)
{
try
{
action();
}
catch (Exception ex)
{
failure ??= ex;
}
return failure;
}
private static async ValueTask<Exception?> CaptureFailureAsync(
Exception? failure,
Func<Task> action
)
{
try
{
await action().ConfigureAwait(false);
}
catch (Exception ex)
{
failure ??= ex;
}
return failure;
}
private static void ThrowIfFailed(Exception? failure)
{
if (failure is not null)
ExceptionDispatchInfo.Capture(failure).Throw();
}
}
+14 -12
View File
@@ -4,10 +4,15 @@ namespace HellionChat.Privacy;
internal static class PrivacyDefaults internal static class PrivacyDefaults
{ {
// Privacy-First default whitelist (DSGVO Art. 25 - Privacy by Default). // F3.1: failsafe for ChatTypes added by future FFXIV patches. New installs
// Only the player's own conversations are persisted out-of-the-box. // persist unknown channels so a major patch's added ChatType isn't silently
// Public chat (Say/Shout/Yell), Novice Network, NPC dialogue, system // dropped before the user can opt in or out. Existing configs keep their
// logs and battle messages are NOT persisted unless the user opts in. // explicit choice — see Configuration.cs PrivacyPersistUnknownChannels.
internal const bool DefaultPersistUnknownChannels = true;
// DSGVO Art. 25 (Privacy by Default): only the player's own conversations
// are persisted out-of-the-box. Public chat, NPC dialogue, system logs and
// battle messages require explicit opt-in.
internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType> internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType>
{ {
ChatType.TellIncoming, ChatType.TellIncoming,
@@ -42,10 +47,8 @@ internal static class PrivacyDefaults
ChatType.ExtraChatLinkshell8, ChatType.ExtraChatLinkshell8,
}; };
// Default retention windows per channel (in days). Channels not listed // Per-channel retention in days. Unlisted channels fall back to
// here fall back to Configuration.RetentionDefaultDays. Reflects the // Configuration.RetentionDefaultDays. Tells: 365, everything else: 90.
// design spec: Tells 365, own-conversation channels 90, everything else
// shorter via the global default.
internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays = internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays =
new Dictionary<ChatType, int> new Dictionary<ChatType, int>
{ {
@@ -86,10 +89,9 @@ internal static class PrivacyDefaults
[ChatType.ExtraChatLinkshell8] = 90, [ChatType.ExtraChatLinkshell8] = 90,
}; };
// Casual profile = Privacy-First plus public chat (Say/Shout/Yell, both // Casual: Privacy-First + public chat (Say/Shout/Yell, emotes, Novice
// emote types, Novice Network), kept for a short 24-hour window so the // Network) with a 1-day window so recent RP/trade is searchable but
// last RP scene or shout trade is still searchable but third-party data // third-party data doesn't accumulate.
// doesn't accumulate forever.
internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>( internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>(
PrivacyFirstWhitelist PrivacyFirstWhitelist
) )
+9 -52
View File
@@ -4,11 +4,8 @@ using HellionChat.Util;
namespace HellionChat.Resources; namespace HellionChat.Resources;
// Hellion Chat — v0.6.0 built-in colour presets for the ChatColours // Built-in colour presets applied via Settings UI → ChatColours.
// settings section. Read-only static data; users apply a preset via the // Battle-channel types are intentionally excluded to preserve combat-log tuning.
// settings UI which overwrites Configuration.ChatColours immediately.
// Battle-channel types are intentionally NOT covered by the stylistic
// presets so that combat-log tuning the user has done stays intact.
public sealed record ChatColourPreset( public sealed record ChatColourPreset(
string DisplayName, string DisplayName,
string LocalizationKey, string LocalizationKey,
@@ -69,9 +66,7 @@ public static class ChatColourPresets
}; };
} }
// The Default preset spiegelt 1:1 die Werte aus ChatTypeExt.DefaultColor. // Mirrors ChatTypeExt.DefaultColor; channels without a default are skipped.
// Channels ohne Default-Wert (return null) werden ausgelassen — wer sie
// anwenden will, behält seine aktuelle Farbe.
private static IReadOnlyDictionary<ChatType, uint> BuildDefault() private static IReadOnlyDictionary<ChatType, uint> BuildDefault()
{ {
var dict = new Dictionary<ChatType, uint>(); var dict = new Dictionary<ChatType, uint>();
@@ -183,33 +178,22 @@ public static class ChatColourPresets
}; };
} }
// Hellion brand preset — Arctic Cyan + Ember Orange palette aus // Hellion brand preset — Arctic Cyan + Ember Orange palette.
// /mnt/ssd-fast/Projekte/hellion-media/hellion-media-website/BRANDING.md // Cyan family for Standard/Tell, Ember/Warning for loud channels,
// (Schema-Stand 2026-04-16). Channels sind über das ganze Brand-Spektrum // Status colours for Linkshells, darker variants for CrossLinkshells.
// verteilt damit jede Zeile auf einen Glance unterscheidbar ist:
// Cyan-Familie für Standard/Tell, Ember + Warning für laute Channels,
// Status-Farben (Success, Danger) für Linkshells. CrossLinkshells
// nutzen die dunkleren/sattersten Varianten derselben Hue-Familien.
private static IReadOnlyDictionary<ChatType, uint> BuildHellion() private static IReadOnlyDictionary<ChatType, uint> BuildHellion()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
// Standard / Tell — Cyan-Familie (Brand-Primary)
[ChatType.Say] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light #4DD9E8 [ChatType.Say] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light #4DD9E8
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan #00BED2 [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan #00BED2
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark #0097A7 [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark #0097A7
// Laute Channels — Ember/Warning
[ChatType.Yell] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning #F0AD4E [ChatType.Yell] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning #F0AD4E
[ChatType.Shout] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember #F97316 [ChatType.Shout] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember #F97316
// Gruppen-Channels — Success/Ember-dark/Cyan
[ChatType.Party] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success #5CB85C [ChatType.Party] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success #5CB85C
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark #E85D04 [ChatType.Alliance] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark #E85D04
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light
// Linkshells 1-8 — über das ganze Brand-Spektrum verteilt
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(251, 146, 60), // Ember-light #FB923C [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(251, 146, 60), // Ember-light #FB923C
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success
@@ -218,8 +202,6 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(217, 83, 79), // Danger #D9534F [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(217, 83, 79), // Danger #D9534F
// CrossWorld-Linkshells 1-8 — dunklere/sattersere Varianten
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(200, 140, 50), // Warning-dark [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(200, 140, 50), // Warning-dark
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(60, 140, 60), // Success-dark [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(60, 140, 60), // Success-dark
@@ -231,31 +213,20 @@ public static class ChatColourPresets
}; };
} }
// Bonus preset — Night Blue, KAZAMA-Stimmungs-Theme aus // Night Blue — cool nautical theme, deep navy without purple.
// /mnt/HDD-Data1/Obsidian/Vault/Systeme/KAZAMA/Theming/Night Blue + Indigo Violet Themes.md
// Klassisch, kühl, technisch — Marineblau-Tiefe ohne Lila-Anteil.
// Bewusst NICHT als Brand-Preset markiert (Vault-Boundary): die KAZAMA-Themes
// sind persönliche Stimmungs-Themes, nicht Teil des Hellion-Brand-Systems.
private static IReadOnlyDictionary<ChatType, uint> BuildNightBlue() private static IReadOnlyDictionary<ChatType, uint> BuildNightBlue()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
// Standard / Tell — Royal Blue Akzent-Familie
[ChatType.Say] = ColourUtil.ComponentsToRgba(230, 237, 247), // text-primary [ChatType.Say] = ColourUtil.ComponentsToRgba(230, 237, 247), // text-primary
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(106, 176, 255), // akzent-hot [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(106, 176, 255), // akzent-hot
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary
// Laute Channels — Warning/Danger Status-Töne
[ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), // warning [ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), // warning
[ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), // danger [ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), // danger
// Gruppen — Success/Akzent-Variations
[ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), // success [ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), // success
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), // warm-orange-light [ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), // warm-orange-light
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(140, 160, 191), // text-dim [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(140, 160, 191), // text-dim
// Linkshells 1-8 — über Spektrum verteilt
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130), [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130),
@@ -264,8 +235,6 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(100, 200, 220), [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(100, 200, 220),
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(106, 176, 255), [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(106, 176, 255),
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(140, 160, 191), [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(140, 160, 191),
// CrossWorld-Linkshells — gedämpfte Variants
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50), [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50),
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80), [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80),
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60), [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60),
@@ -277,30 +246,20 @@ public static class ChatColourPresets
}; };
} }
// Bonus preset — Indigo Violet, KAZAMA-Stimmungs-Theme aus demselben // Indigo Violet — warm-mystic theme, deep indigo with violet accent.
// Vault-Doc. Warm-mystisch, "Galaxy/Glitter/Nordlicht" — tiefes Indigo
// mit kräftigem Violet-Akzent. Persönlicher Favorit (siehe Vault).
// Auch nicht als Brand-Preset (siehe NightBlue-Note oben).
private static IReadOnlyDictionary<ChatType, uint> BuildIndigoViolet() private static IReadOnlyDictionary<ChatType, uint> BuildIndigoViolet()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
// Standard / Tell — Royal Violet Akzent-Familie [ChatType.Say] = ColourUtil.ComponentsToRgba(240, 230, 255), // text-primary
[ChatType.Say] = ColourUtil.ComponentsToRgba(240, 230, 255), // text-primary (light lavender)
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(176, 124, 255), // akzent-hot [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(176, 124, 255), // akzent-hot
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary
// Laute Channels — geteilt mit Night Blue (Status-Farben)
[ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), [ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122),
// Gruppen
[ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), [ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151),
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(168, 144, 208), // text-dim [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(168, 144, 208), // text-dim
// Linkshells 1-8
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130), [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130),
@@ -309,8 +268,6 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(139, 77, 222), [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(139, 77, 222),
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(130, 90, 200), [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(130, 90, 200),
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(168, 144, 208), [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(168, 144, 208),
// CrossWorld-Linkshells
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50), [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50),
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80), [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80),
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60), [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60),
+23
View File
@@ -114,6 +114,8 @@ internal class HellionStrings
internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning)); internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning));
internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply)); internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply));
internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button)); internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button));
internal static string Wizard_Cancel_Label => Get(nameof(Wizard_Cancel_Label));
internal static string Wizard_Cancel_Tooltip => Get(nameof(Wizard_Cancel_Tooltip));
internal static string Export_Heading => Get(nameof(Export_Heading)); internal static string Export_Heading => Get(nameof(Export_Heading));
internal static string Export_Help => Get(nameof(Export_Help)); internal static string Export_Help => Get(nameof(Export_Help));
@@ -168,6 +170,16 @@ internal class HellionStrings
internal static string AutoTellTabs_HistoryLoadError => Get(nameof(AutoTellTabs_HistoryLoadError)); internal static string AutoTellTabs_HistoryLoadError => Get(nameof(AutoTellTabs_HistoryLoadError));
internal static string AutoTellTabs_GreetedTooltip => Get(nameof(AutoTellTabs_GreetedTooltip)); internal static string AutoTellTabs_GreetedTooltip => Get(nameof(AutoTellTabs_GreetedTooltip));
internal static string AutoTellTabs_UnGreetedTooltip => Get(nameof(AutoTellTabs_UnGreetedTooltip)); internal static string AutoTellTabs_UnGreetedTooltip => Get(nameof(AutoTellTabs_UnGreetedTooltip));
internal static string PinTab_MenuPin => Get(nameof(PinTab_MenuPin));
internal static string PinTab_MenuUnpin => Get(nameof(PinTab_MenuUnpin));
internal static string PinTab_MenuPromote => Get(nameof(PinTab_MenuPromote));
internal static string PinTab_PromoteTooltip => Get(nameof(PinTab_PromoteTooltip));
internal static string PinTab_LimitReached => Get(nameof(PinTab_LimitReached));
internal static string PinTab_PinnedTooltip => Get(nameof(PinTab_PinnedTooltip));
internal static string PinTab_PinTooltip => Get(nameof(PinTab_PinTooltip));
internal static string PinTab_SectionHeader => Get(nameof(PinTab_SectionHeader));
internal static string Settings_ThemeAndLayout_SidebarWidth_Name => Get(nameof(Settings_ThemeAndLayout_SidebarWidth_Name));
internal static string Settings_ThemeAndLayout_SidebarWidth_Description => Get(nameof(Settings_ThemeAndLayout_SidebarWidth_Description));
// Hellion Chat — Auto-Tell-Tabs Chat settings tab // Hellion Chat — Auto-Tell-Tabs Chat settings tab
internal static string ChatLog_AutoTellTabs_Section_Title => Get(nameof(ChatLog_AutoTellTabs_Section_Title)); internal static string ChatLog_AutoTellTabs_Section_Title => Get(nameof(ChatLog_AutoTellTabs_Section_Title));
@@ -258,6 +270,10 @@ internal class HellionStrings
internal static string Settings_Chat_Preview_Heading => Get(nameof(Settings_Chat_Preview_Heading)); internal static string Settings_Chat_Preview_Heading => Get(nameof(Settings_Chat_Preview_Heading));
internal static string Settings_Chat_Emotes_Heading => Get(nameof(Settings_Chat_Emotes_Heading)); internal static string Settings_Chat_Emotes_Heading => Get(nameof(Settings_Chat_Emotes_Heading));
// Hellion Chat — Chat-Tab SymbolPicker
internal static string Settings_Chat_SymbolPicker_Enable_Name => Get(nameof(Settings_Chat_SymbolPicker_Enable_Name));
internal static string Settings_Chat_SymbolPicker_Enable_Description => Get(nameof(Settings_Chat_SymbolPicker_Enable_Description));
// Hellion Chat — Database-Tab section headings // Hellion Chat — Database-Tab section headings
internal static string Settings_Database_Storage_Heading => Get(nameof(Settings_Database_Storage_Heading)); internal static string Settings_Database_Storage_Heading => Get(nameof(Settings_Database_Storage_Heading));
internal static string Settings_Database_Viewer_Heading => Get(nameof(Settings_Database_Viewer_Heading)); internal static string Settings_Database_Viewer_Heading => Get(nameof(Settings_Database_Viewer_Heading));
@@ -368,6 +384,8 @@ internal class HellionStrings
internal static string Settings_Integrations_Honorific_Status_Incompatible => Get(nameof(Settings_Integrations_Honorific_Status_Incompatible)); internal static string Settings_Integrations_Honorific_Status_Incompatible => Get(nameof(Settings_Integrations_Honorific_Status_Incompatible));
internal static string Settings_Integrations_Honorific_Toggle => Get(nameof(Settings_Integrations_Honorific_Toggle)); internal static string Settings_Integrations_Honorific_Toggle => Get(nameof(Settings_Integrations_Honorific_Toggle));
internal static string Settings_Integrations_Honorific_ToggleHint => Get(nameof(Settings_Integrations_Honorific_ToggleHint)); internal static string Settings_Integrations_Honorific_ToggleHint => Get(nameof(Settings_Integrations_Honorific_ToggleHint));
internal static string Settings_Integrations_Honorific_Glow_Toggle => Get(nameof(Settings_Integrations_Honorific_Glow_Toggle));
internal static string Settings_Integrations_Honorific_Glow_Hint => Get(nameof(Settings_Integrations_Honorific_Glow_Hint));
internal static string Settings_Integrations_Honorific_LinkRepo => Get(nameof(Settings_Integrations_Honorific_LinkRepo)); internal static string Settings_Integrations_Honorific_LinkRepo => Get(nameof(Settings_Integrations_Honorific_LinkRepo));
internal static string Settings_Integrations_Honorific_LinkAuthor => Get(nameof(Settings_Integrations_Honorific_LinkAuthor)); internal static string Settings_Integrations_Honorific_LinkAuthor => Get(nameof(Settings_Integrations_Honorific_LinkAuthor));
internal static string Settings_Integrations_ComingSoon_SectionHeader => Get(nameof(Settings_Integrations_ComingSoon_SectionHeader)); internal static string Settings_Integrations_ComingSoon_SectionHeader => Get(nameof(Settings_Integrations_ComingSoon_SectionHeader));
@@ -388,4 +406,9 @@ internal class HellionStrings
// Hellion Chat — v1.3.0 Honorific title slot tooltip // Hellion Chat — v1.3.0 Honorific title slot tooltip
internal static string ChatHeader_HonorificTitle_Tooltip => Get(nameof(ChatHeader_HonorificTitle_Tooltip)); internal static string ChatHeader_HonorificTitle_Tooltip => Get(nameof(ChatHeader_HonorificTitle_Tooltip));
// Hellion Chat — v1.4.8 DbViewer full-text search toggle
internal static string DbViewer_FullTextToggle => Get(nameof(DbViewer_FullTextToggle));
internal static string DbViewer_FullTextToggle_Hint_Indexing => Get(nameof(DbViewer_FullTextToggle_Hint_Indexing));
internal static string DbViewer_FullTextToggle_Hint_PhraseMode => Get(nameof(DbViewer_FullTextToggle_Hint_PhraseMode));
} }
+70 -11
View File
@@ -222,6 +222,12 @@
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Wizard erneut zeigen</value> <value>Wizard erneut zeigen</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Später — Defaults behalten</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Schließt den Wizard ohne Profil-Auswahl. Die Plugin-Defaults bleiben aktiv und der Wizard erscheint beim nächsten Plugin-Reload erneut.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (DSGVO Art. 15 — Auskunftsrecht)</value> <value>Export (DSGVO Art. 15 — Auskunftsrecht)</value>
</data> </data>
@@ -377,6 +383,36 @@
<data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve">
<value>Als begrüßt markieren.</value> <value>Als begrüßt markieren.</value>
</data> </data>
<data name="PinTab_MenuPin" xml:space="preserve">
<value>Tab anpinnen</value>
</data>
<data name="PinTab_MenuUnpin" xml:space="preserve">
<value>Tab lösen</value>
</data>
<data name="PinTab_MenuPromote" xml:space="preserve">
<value>In Standard-Tab umwandeln</value>
</data>
<data name="PinTab_PromoteTooltip" xml:space="preserve">
<value>Wandelt den TempTell in einen regulären Tab um. Die Tell-Bindung an die Person geht verloren, der Tab fängt dann Nachrichten anhand der Channel-Filter ein. Für „Tab überlebt Relog" stattdessen „Tab anpinnen" wählen.</value>
</data>
<data name="PinTab_LimitReached" xml:space="preserve">
<value>Maximal {0} angepinnte Tell-Tabs erreicht. Erst einen lösen oder dauerhaft behalten.</value>
</data>
<data name="PinTab_PinnedTooltip" xml:space="preserve">
<value>Angepinnt — überlebt Relog.</value>
</data>
<data name="PinTab_PinTooltip" xml:space="preserve">
<value>Angepinnte Tabs überleben Relog und behalten die Bindung an die Tell-Person.</value>
</data>
<data name="PinTab_SectionHeader" xml:space="preserve">
<value>Angepinnt</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Name" xml:space="preserve">
<value>Sidebar-Breite</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Description" xml:space="preserve">
<value>Breite der Tab-Sidebar in Pixeln. Default (44 px) ist Icon-only; breiter machen damit Sektion-Header wie „Aktive Tells (3)" nicht abgeschnitten werden.</value>
</data>
<!-- Hellion Chat — Auto-Tell-Tabs (Chat-Einstellungstab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Chat-Einstellungstab) -->
<data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve">
@@ -392,7 +428,7 @@
<value>Maximale Anzahl der Auto-Tell-Tabs</value> <value>Maximale Anzahl der Auto-Tell-Tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve">
<value>Beim Erreichen werden begrüßte Tabs mit der ältesten Aktivität zuerst geschlossen. Änderungen greifen beim nächsten /tell.</value> <value>Beim Erreichen werden begrüßte Tabs mit der ältesten Aktivität zuerst geschlossen. Änderungen greifen beim nächsten /tell. Diese Grenze gilt nur für den automatisch verwalteten Pool. Angepinnte Tell-Tabs (Rechtsklick → Tab anpinnen) leben in einem separaten Pool von bis zu 5 Tabs und überleben Relog.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve">
<value>Kompakte Anzeige</value> <value>Kompakte Anzeige</value>
@@ -520,6 +556,14 @@
<value>Emotes</value> <value>Emotes</value>
</data> </data>
<!-- Hellion Chat — Chat-Tab SymbolPicker -->
<data name="Settings_Chat_SymbolPicker_Enable_Name" xml:space="preserve">
<value>Symbol-Picker-Button neben dem Chat-Eingang anzeigen</value>
</data>
<data name="Settings_Chat_SymbolPicker_Enable_Description" xml:space="preserve">
<value>Fügt einen kleinen Button links neben dem Kanal-Indikator ein. Klick öffnet ein Popup mit FFXIV-Glyphen und einer kuratierten Symbol-Liste. Ausschalten für eine schlankere Eingabezeile.</value>
</data>
<!-- Hellion Chat — Sektions-Überschriften des Database-Tabs --> <!-- Hellion Chat — Sektions-Überschriften des Database-Tabs -->
<data name="Settings_Database_Storage_Heading" xml:space="preserve"> <data name="Settings_Database_Storage_Heading" xml:space="preserve">
<value>Speicherung</value> <value>Speicherung</value>
@@ -639,7 +683,7 @@
<value>Allgemein</value> <value>Allgemein</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Plugin-globale Einstellungen — Sprache, Eingabe, Audio, Performance.</value> <value>Sprache, Eingabe, Audio und Performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Erscheinungsbild</value> <value>Erscheinungsbild</value>
@@ -657,25 +701,25 @@
<value>Fenster</value> <value>Fenster</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>Verhalten des Fensters — wann es da ist, ob es bewegt werden kann.</value> <value>Wann das Fenster sichtbar ist und ob es sich bewegen lässt.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>Wie Nachrichten angezeigt werden — Tells, Vorschau, Verhalten, Emotes.</value> <value>Tells, Vorschau, Nachrichten-Verhalten und Emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Tab-Verwaltung — eigene Chat-Tabs anlegen und konfigurieren.</value> <value>Eigene Chat-Tabs anlegen und konfigurieren.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Datenschutz</value> <value>Datenschutz</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>Was darf gespeichert werden — Privacy-Filter pro Channel.</value> <value>Privacy-Filter pro Channel und was gespeichert werden darf.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Datenbank</value> <value>Datenbank</value>
@@ -687,7 +731,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>Über das Plugin — Version, Mission, Lizenz, Changelog.</value> <value>Version, Mission, Lizenz und Changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -732,25 +776,25 @@
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>Wie das Fenster aussieht — Theme, Rahmen, Zeitstempel-Style.</value> <value>Theme, Fenster-Rahmen und Zeitstempel-Style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Schriften &amp; Farben</value> <value>Schriften &amp; Farben</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Lesbarkeit — Schriftart, Schriftgröße, Chat-Farben pro Channel.</value> <value>Schriftart, Schriftgröße und Chat-Farben pro Channel.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Daten-Verwaltung</value> <value>Daten-Verwaltung</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>Was passiert mit gespeicherten Daten — Aufbewahrung, Aufräumen, Export, DB-Stats.</value> <value>Aufbewahrung, Aufräumen, Export und Datenbank-Statistiken.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrationen</value> <value>Integrationen</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Auto-detected, mit Vorschau auf kommende Integrationen.</value> <value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Kommende Integrationen in der Vorschau.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
@@ -821,6 +865,12 @@
<data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve"> <data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve">
<value>Zeigt deinen Custom-Titel aus Honorific im Header über dem Chat-Log an, in der von dir gewählten Farbe.</value> <value>Zeigt deinen Custom-Titel aus Honorific im Header über dem Chat-Log an, in der von dir gewählten Farbe.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Glow_Toggle" xml:space="preserve">
<value>Glow-Outline rendern (Honorific)</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Hint" xml:space="preserve">
<value>Kann die Framerate auf schwacher Hardware drücken. Rendert die Glow-Outline für Honorific-Titel, die sie nutzen. Gradient-Animation wird noch nicht unterstützt und wird stattdessen als Primärfarbe gezeichnet.</value>
</data>
<data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve"> <data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve">
<value>Honorific auf GitHub</value> <value>Honorific auf GitHub</value>
</data> </data>
@@ -875,4 +925,13 @@
<data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve"> <data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve">
<value>Custom-Titel von Honorific</value> <value>Custom-Titel von Honorific</value>
</data> </data>
<data name="DbViewer_FullTextToggle" xml:space="preserve">
<value>Volltext-Suche</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_Indexing" xml:space="preserve">
<value>Der Volltext-Index wird noch gebaut. Die lokale Suche bleibt verfügbar.</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_PhraseMode" xml:space="preserve">
<value>Sucht nach der exakten Wortfolge. Mehrere Wörter werden nur gefunden, wenn sie zusammen und in dieser Reihenfolge stehen. Wer rohe FTS5-MATCH-Syntax nutzen will, setzt eigene Anführungszeichen um den Suchbegriff.</value>
</data>
</root> </root>
+223 -164
View File
@@ -19,28 +19,28 @@
<value>Enable privacy filter</value> <value>Enable privacy filter</value>
</data> </data>
<data name="Privacy_FilterEnabled_Description" xml:space="preserve"> <data name="Privacy_FilterEnabled_Description" xml:space="preserve">
<value>When enabled, only messages from whitelisted channels are persisted to the database. Disabling restores the original behavior (everything except battle messages is stored).</value> <value>When enabled, only messages from allowed channels are written to the database. When disabled, the default behaviour applies — everything except battle logs is stored.</value>
</data> </data>
<data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve"> <data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve">
<value>The filter only controls what is written to the local database. The chat log itself keeps showing every message live, disallowed channels just stop being saved. Use the channel hide options in your in-game chat tabs if you want to remove channels from the visible chat.</value> <value>The filter only controls what is written to the local database. The chat log still shows every message live; excluded channels are simply no longer stored. If you also want to remove channels from the visible display, use the normal chat-tab filters in the game.</value>
</data> </data>
<data name="Privacy_Filter_Tree_Heading" xml:space="preserve"> <data name="Privacy_Filter_Tree_Heading" xml:space="preserve">
<value>Privacy filter and whitelist</value> <value>Privacy filter and whitelist</value>
</data> </data>
<data name="Privacy_Whitelist_Help" xml:space="preserve"> <data name="Privacy_Whitelist_Help" xml:space="preserve">
<value>Pick which channels are stored in the local database. Privacy-First default: only your own conversations. Use the buttons below to apply a preset.</value> <value>Choose which channels are saved to the local database. Default follows data minimisation: only your own conversations. Use the buttons below to apply a preset.</value>
</data> </data>
<data name="Privacy_Preset_PrivacyFirst" xml:space="preserve"> <data name="Privacy_Preset_PrivacyFirst" xml:space="preserve">
<value>Privacy-First (recommended)</value> <value>Data minimisation (recommended)</value>
</data> </data>
<data name="Privacy_Preset_ClearAll" xml:space="preserve"> <data name="Privacy_Preset_ClearAll" xml:space="preserve">
<value>Clear all</value> <value>Deselect all</value>
</data> </data>
<data name="Privacy_Preset_SelectAll" xml:space="preserve"> <data name="Privacy_Preset_SelectAll" xml:space="preserve">
<value>Select all</value> <value>Select all</value>
</data> </data>
<data name="Privacy_Group_DirectMessages" xml:space="preserve"> <data name="Privacy_Group_DirectMessages" xml:space="preserve">
<value>Direct Messages</value> <value>Direct messages</value>
</data> </data>
<data name="Privacy_Group_PartyAlliance" xml:space="preserve"> <data name="Privacy_Group_PartyAlliance" xml:space="preserve">
<value>Party &amp; Alliance</value> <value>Party &amp; Alliance</value>
@@ -55,52 +55,52 @@
<value>Cross-World Linkshells</value> <value>Cross-World Linkshells</value>
</data> </data>
<data name="Privacy_Group_ExtraChat" xml:space="preserve"> <data name="Privacy_Group_ExtraChat" xml:space="preserve">
<value>ExtraChat (Encrypted)</value> <value>ExtraChat (encrypted)</value>
</data> </data>
<data name="Privacy_Group_PublicChat" xml:space="preserve"> <data name="Privacy_Group_PublicChat" xml:space="preserve">
<value>Public Chat (third-party data)</value> <value>Public chat (third-party data)</value>
</data> </data>
<data name="Privacy_Group_SystemLogs" xml:space="preserve"> <data name="Privacy_Group_SystemLogs" xml:space="preserve">
<value>System &amp; Game Logs</value> <value>System &amp; game logs</value>
</data> </data>
<data name="Privacy_PersistUnknown_Name" xml:space="preserve"> <data name="Privacy_PersistUnknown_Name" xml:space="preserve">
<value>Persist unknown channel types</value> <value>Save unknown channel types</value>
</data> </data>
<data name="Privacy_PersistUnknown_Description" xml:space="preserve"> <data name="Privacy_PersistUnknown_Description" xml:space="preserve">
<value>Failsafe for ChatTypes added by future FFXIV patches that this plugin does not yet know about. Default OFF (Privacy-First). Turn ON if you want a complete log including future channels.</value> <value>Safety net for ChatTypes added by future FFXIV patches that the plugin does not yet know about. Default is OFF (data minimisation). Enable if you want future channels to be fully logged as well.</value>
</data> </data>
<data name="Cleanup_Heading" xml:space="preserve"> <data name="Cleanup_Heading" xml:space="preserve">
<value>Apply filter to existing database</value> <value>Apply filter to existing database</value>
</data> </data>
<data name="Cleanup_Help_Intro" xml:space="preserve"> <data name="Cleanup_Help_Intro" xml:space="preserve">
<value>The privacy filter only applies to new messages. Use the cleanup below to retroactively remove already-stored messages that don't match your saved whitelist.</value> <value>The privacy filter only affects new messages. The cleanup below lets you retroactively remove already-stored messages that do not match your saved whitelist.</value>
</data> </data>
<data name="Cleanup_Help_SavedNote" xml:space="preserve"> <data name="Cleanup_Help_SavedNote" xml:space="preserve">
<value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved edits above. Click Save first if you want to apply your current edits.</value> <value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved changes above. Click Save first if you want your current changes to be applied.</value>
</data> </data>
<data name="Retention_Help_SavedNote" xml:space="preserve"> <data name="Retention_Help_SavedNote" xml:space="preserve">
<value>The manual sweep uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current edits.</value> <value>The manual run uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current changes.</value>
</data> </data>
<data name="Cleanup_Preview_Stale" xml:space="preserve"> <data name="Cleanup_Preview_Stale" xml:space="preserve">
<value>Preview is out of date — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value> <value>Preview is stale — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value>
</data> </data>
<data name="Cleanup_RefreshPreview" xml:space="preserve"> <data name="Cleanup_RefreshPreview" xml:space="preserve">
<value>Refresh preview</value> <value>Refresh preview</value>
</data> </data>
<data name="Cleanup_NoPreview" xml:space="preserve"> <data name="Cleanup_NoPreview" xml:space="preserve">
<value>No preview yet. Click Refresh to compute the impact.</value> <value>No preview yet. Click Refresh to calculate the impact.</value>
</data> </data>
<data name="Cleanup_TotalStored" xml:space="preserve"> <data name="Cleanup_TotalStored" xml:space="preserve">
<value>Total stored messages: {0:N0}</value> <value>Total stored messages: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillKeep" xml:space="preserve"> <data name="Cleanup_WillKeep" xml:space="preserve">
<value>Will keep: {0:N0}</value> <value>Keep: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillDelete" xml:space="preserve"> <data name="Cleanup_WillDelete" xml:space="preserve">
<value>Will delete: {0:N0}</value> <value>Delete: {0:N0}</value>
</data> </data>
<data name="Cleanup_Breakdown" xml:space="preserve"> <data name="Cleanup_Breakdown" xml:space="preserve">
<value>Per-channel breakdown</value> <value>Breakdown by channel</value>
</data> </data>
<data name="Cleanup_Marker_Keep" xml:space="preserve"> <data name="Cleanup_Marker_Keep" xml:space="preserve">
<value>[KEEP] </value> <value>[KEEP] </value>
@@ -112,46 +112,46 @@
<value>Apply current filter to database</value> <value>Apply current filter to database</value>
</data> </data>
<data name="Cleanup_Apply_Tooltip" xml:space="preserve"> <data name="Cleanup_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: Hard-deletes {0:N0} messages, then runs VACUUM. Cannot be undone.</value> <value>Ctrl+Shift: Permanently deletes {0:N0} messages and runs VACUUM afterwards. Cannot be undone.</value>
</data> </data>
<data name="Cleanup_Running" xml:space="preserve"> <data name="Cleanup_Running" xml:space="preserve">
<value>Cleanup running in background…</value> <value>Cleanup running in the background…</value>
</data> </data>
<data name="Cleanup_PreviewError" xml:space="preserve"> <data name="Cleanup_PreviewError" xml:space="preserve">
<value>Failed to compute cleanup preview, see /xllog</value> <value>Preview could not be calculated, see /xllog</value>
</data> </data>
<data name="Cleanup_Success" xml:space="preserve"> <data name="Cleanup_Success" xml:space="preserve">
<value>Privacy cleanup complete: {0:N0} messages removed.</value> <value>Cleanup complete, {0:N0} messages removed.</value>
</data> </data>
<data name="Cleanup_Error" xml:space="preserve"> <data name="Cleanup_Error" xml:space="preserve">
<value>Privacy cleanup failed, see /xllog</value> <value>Cleanup failed, see /xllog</value>
</data> </data>
<data name="Retention_Heading" xml:space="preserve"> <data name="Retention_Heading" xml:space="preserve">
<value>Message retention</value> <value>Message retention</value>
</data> </data>
<data name="Retention_Enabled_Name" xml:space="preserve"> <data name="Retention_Enabled_Name" xml:space="preserve">
<value>Auto-delete messages after a per-channel retention window</value> <value>Automatically delete messages past their channel retention window</value>
</data> </data>
<data name="Retention_Enabled_Description" xml:space="preserve"> <data name="Retention_Enabled_Description" xml:space="preserve">
<value>When enabled, messages older than the configured window are deleted on every plugin start (at most once per 24 hours). Off by default. The plugin never deletes history without your explicit consent.</value> <value>When enabled, messages older than the configured window are deleted on each plugin start (at most once every 24 hours). Default is OFF — the plugin never deletes anything without your explicit consent.</value>
</data> </data>
<data name="Retention_Default_Label" xml:space="preserve"> <data name="Retention_Default_Label" xml:space="preserve">
<value>Default retention (days, 0 = never)</value> <value>Default retention (days, 0 = never)</value>
</data> </data>
<data name="Retention_Default_Help" xml:space="preserve"> <data name="Retention_Default_Help" xml:space="preserve">
<value>Applies to channels without an explicit override below.</value> <value>Applies to channels that have no individual override below.</value>
</data> </data>
<data name="Retention_Reset_Spec" xml:space="preserve"> <data name="Retention_Reset_Spec" xml:space="preserve">
<value>Reset overrides to spec defaults</value> <value>Reset overrides to spec defaults</value>
</data> </data>
<data name="Retention_Clear_Overrides" xml:space="preserve"> <data name="Retention_Clear_Overrides" xml:space="preserve">
<value>Clear all overrides</value> <value>Remove all overrides</value>
</data> </data>
<data name="Retention_Tree_Heading" xml:space="preserve"> <data name="Retention_Tree_Heading" xml:space="preserve">
<value>Per-channel retention overrides</value> <value>Retention per channel</value>
</data> </data>
<data name="Retention_Tag_Override" xml:space="preserve"> <data name="Retention_Tag_Override" xml:space="preserve">
<value>[override]</value> <value>[custom]</value>
</data> </data>
<data name="Retention_Tag_Spec" xml:space="preserve"> <data name="Retention_Tag_Spec" xml:space="preserve">
<value>[spec]</value> <value>[spec]</value>
@@ -163,13 +163,13 @@
<value>reset</value> <value>reset</value>
</data> </data>
<data name="Retention_Apply_Label" xml:space="preserve"> <data name="Retention_Apply_Label" xml:space="preserve">
<value>Apply retention policy now</value> <value>Apply retention now</value>
</data> </data>
<data name="Retention_Apply_Tooltip" xml:space="preserve"> <data name="Retention_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: runs the retention sweep immediately using the SAVED policy. Save your changes first.</value> <value>Ctrl+Shift: Runs the retention cleanup immediately using the SAVED policy. Save your changes first.</value>
</data> </data>
<data name="Retention_Running" xml:space="preserve"> <data name="Retention_Running" xml:space="preserve">
<value>Retention sweep running in background…</value> <value>Retention cleanup running in the background…</value>
</data> </data>
<data name="Retention_LastRun_Never" xml:space="preserve"> <data name="Retention_LastRun_Never" xml:space="preserve">
<value>Last run: never</value> <value>Last run: never</value>
@@ -178,67 +178,73 @@
<value>Last run: {0:yyyy-MM-dd HH:mm}</value> <value>Last run: {0:yyyy-MM-dd HH:mm}</value>
</data> </data>
<data name="Retention_Success" xml:space="preserve"> <data name="Retention_Success" xml:space="preserve">
<value>Retention sweep complete: {0:N0} messages removed.</value> <value>Retention cleanup complete, {0:N0} messages removed.</value>
</data> </data>
<data name="Retention_Error" xml:space="preserve"> <data name="Retention_Error" xml:space="preserve">
<value>Retention sweep failed, see /xllog</value> <value>Retention cleanup failed, see /xllog</value>
</data> </data>
<data name="Wizard_Title" xml:space="preserve"> <data name="Wizard_Title" xml:space="preserve">
<value>Hellion Chat — Welcome</value> <value>Hellion Chat — Welcome</value>
</data> </data>
<data name="Wizard_Intro" xml:space="preserve"> <data name="Wizard_Intro" xml:space="preserve">
<value>Pick a starting profile. You can change anything later under Settings → Privacy.</value> <value>Choose a starting profile. You can adjust everything later under Settings → Privacy.</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve">
<value>Privacy-First (recommended)</value> <value>Data minimisation (recommended)</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve">
<value>Only your own conversations are stored: Tells, Party, FC, Linkshells, Cross-World Linkshells, Alliance and ExtraChat. Public chat, NPC dialogue and system spam are dropped at the storage layer. Retention follows the spec defaults (Tells 365 days, own-conversation channels 90 days).</value> <value>Only your own conversations are stored: tells, party, FC, linkshells, cross-world linkshells, alliance, and ExtraChat. Public chat, NPC dialogues, and system spam are discarded at the storage level. Retention follows spec defaults (tells 365 days, own conversation channels 90 days).</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve">
<value>Use Privacy-First</value> <value>Apply data minimisation</value>
</data> </data>
<data name="Wizard_Profile_Casual_Heading" xml:space="preserve"> <data name="Wizard_Profile_Casual_Heading" xml:space="preserve">
<value>Casual</value> <value>Casual</value>
</data> </data>
<data name="Wizard_Profile_Casual_Description" xml:space="preserve"> <data name="Wizard_Profile_Casual_Description" xml:space="preserve">
<value>Privacy-First plus a 24-hour window for public chat (Say, Shout, Yell, both emote types, Novice Network). For RP players who want to look up the last scene without keeping public chat forever.</value> <value>Data minimisation plus a 24-hour window for public chat (say, shout, yell, both emote types, novice network). For RP players who want to re-read the last scene without keeping public chat forever.</value>
</data> </data>
<data name="Wizard_Profile_Casual_Apply" xml:space="preserve"> <data name="Wizard_Profile_Casual_Apply" xml:space="preserve">
<value>Use Casual</value> <value>Apply casual</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve">
<value>Full History</value> <value>Full history</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Description" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Description" xml:space="preserve">
<value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behavior). Retention is OFF, history grows forever.</value> <value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behaviour). Retention is OFF, so the history grows indefinitely.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve">
<value>GDPR notice: storing third-party messages (Say/Shout/Yell of strangers, NPC dialogue with player names, etc.) for an unlimited time may exceed the personal/household exemption (Art. 2(2)(c)). Use this profile only if you have a clear reason to keep the full archive.</value> <value>GDPR notice: Storing third-party messages (say/shout/yell from other players, NPC dialogues with player names, etc.) indefinitely may exceed the exemption for purely personal or household activities (Art. 2(2)(c)). Only use this profile if you have a clear reason to keep the full archive.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve">
<value>Use Full History</value> <value>Apply full history</value>
</data> </data>
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Show wizard again</value> <value>Show wizard again</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Later — keep defaults</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Close the wizard without selecting a profile. The plugin defaults stay active and the wizard returns on next plugin load.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (GDPR Art. 15 — right of access)</value> <value>Export (GDPR Art. 15 — Right of access)</value>
</data> </data>
<data name="Export_Help" xml:space="preserve"> <data name="Export_Help" xml:space="preserve">
<value>Export stored messages to Markdown, JSON or CSV. Use this to fulfil a request for access from someone whose messages you have, or to take your own history with you.</value> <value>Export stored messages as Markdown, JSON, or CSV. This lets you fulfil an access request from a person whose messages you have stored, or take your own history with you.</value>
</data> </data>
<data name="Export_Range_Label" xml:space="preserve"> <data name="Export_Range_Label" xml:space="preserve">
<value>Last X days (0 = all time)</value> <value>Last X days (0 = no time limit)</value>
</data> </data>
<data name="Export_Sender_Label" xml:space="preserve"> <data name="Export_Sender_Label" xml:space="preserve">
<value>Sender contains (optional, case-insensitive)</value> <value>Sender contains (optional, case-insensitive)</value>
</data> </data>
<data name="Export_Channels_Heading" xml:space="preserve"> <data name="Export_Channels_Heading" xml:space="preserve">
<value>Limit to channels</value> <value>Restrict to channels</value>
</data> </data>
<data name="Export_Channels_AllOff" xml:space="preserve"> <data name="Export_Channels_AllOff" xml:space="preserve">
<value>(none selected = all stored channels)</value> <value>(nothing selected = all stored channels)</value>
</data> </data>
<data name="Export_Format_Label" xml:space="preserve"> <data name="Export_Format_Label" xml:space="preserve">
<value>Format</value> <value>Format</value>
@@ -259,41 +265,41 @@
<value>Save export</value> <value>Save export</value>
</data> </data>
<data name="Export_Running" xml:space="preserve"> <data name="Export_Running" xml:space="preserve">
<value>Export running in background…</value> <value>Export running in the background…</value>
</data> </data>
<data name="Export_Success" xml:space="preserve"> <data name="Export_Success" xml:space="preserve">
<value>Export complete: {0:N0} messages written to {1}</value> <value>Export complete, {0:N0} messages written to {1}</value>
</data> </data>
<data name="Export_Empty" xml:space="preserve"> <data name="Export_Empty" xml:space="preserve">
<value>Export complete: no messages matched the filter.</value> <value>Export complete, no message matched the filter.</value>
</data> </data>
<data name="Export_Error" xml:space="preserve"> <data name="Export_Error" xml:space="preserve">
<value>Export failed, see /xllog</value> <value>Export failed, see /xllog</value>
</data> </data>
<data name="Theme_Enabled_Name" xml:space="preserve"> <data name="Theme_Enabled_Name" xml:space="preserve">
<value>Use the Hellion theme across all plugin windows</value> <value>Use Hellion theme for all plugin windows</value>
</data> </data>
<data name="Theme_Enabled_Description" xml:space="preserve"> <data name="Theme_Enabled_Description" xml:space="preserve">
<value>Hellion Online Media palette of Arctic Cyan plus Ember Orange, applied across the chat log, settings, viewers and the wizard. Disable to fall back to the default Dalamud look.</value> <value>Hellion Online Media palette of Arctic Cyan and Ember Orange, applied to the chat window, settings, viewer, and wizard. Disable to use the default Dalamud appearance.</value>
</data> </data>
<data name="Theme_WindowOpacity_Label" xml:space="preserve"> <data name="Theme_WindowOpacity_Label" xml:space="preserve">
<value>Window opacity</value> <value>Window opacity</value>
</data> </data>
<data name="Theme_WindowOpacity_Help" xml:space="preserve"> <data name="Theme_WindowOpacity_Help" xml:space="preserve">
<value>How opaque the plugin panes are. Lower values let the game shine through; form fields and dialogs stay opaque on top so they remain readable.</value> <value>How opaque the plugin windows are. Lower values let the game show through; form fields and dialogs stay fully opaque and readable on top.</value>
</data> </data>
<data name="Theme_UseHellionFont_Name" xml:space="preserve"> <data name="Theme_UseHellionFont_Name" xml:space="preserve">
<value>Use the bundled Hellion font (Exo 2)</value> <value>Use bundled Hellion font (Exo 2)</value>
</data> </data>
<data name="Theme_UseHellionFont_Description" xml:space="preserve"> <data name="Theme_UseHellionFont_Description" xml:space="preserve">
<value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1) which ships with the plugin. Disable to fall back to whatever font you picked under Settings → Fonts.</value> <value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1), which ships with the plugin. Disable to fall back to the font selected under Settings → Font.</value>
</data> </data>
<data name="About_Maintainer_Heading" xml:space="preserve"> <data name="About_Maintainer_Heading" xml:space="preserve">
<value>Maintainer</value> <value>Maintainer</value>
</data> </data>
<data name="About_Maintainer_Body" xml:space="preserve"> <data name="About_Maintainer_Body" xml:space="preserve">
<value>I maintain Hellion Chat through Hellion Online Media. The website has the contact details for licensing, legal or business questions.</value> <value>I maintain Hellion Chat through Hellion Online Media. Contact details for licensing, legal, or business inquiries are on the website.</value>
</data> </data>
<data name="About_Maintainer_Website_Label" xml:space="preserve"> <data name="About_Maintainer_Website_Label" xml:space="preserve">
<value>Website:</value> <value>Website:</value>
@@ -303,142 +309,172 @@
<value>Why this fork exists</value> <value>Why this fork exists</value>
</data> </data>
<data name="About_Mission_P1" xml:space="preserve"> <data name="About_Mission_P1" xml:space="preserve">
<value>Hellion Chat is not trying to replace Chat 2. Chat 2 ships a complete chat experience with full history available for filtering, search and replay. That default is the right one for most users. This fork takes a different stance: a smaller default footprint, with extra knobs for users who want to keep less third-party chat on disk.</value> <value>Hellion Chat is not meant to replace Chat 2. Chat 2 delivers a complete chat experience with a full history available for filtering, searching, and replay. That default is the right choice for most users. This fork takes a different approach: a smaller default footprint, with additional controls for users who prefer to keep less of other people's chat on disk.</value>
</data> </data>
<data name="About_Mission_P2" xml:space="preserve"> <data name="About_Mission_P2" xml:space="preserve">
<value>The reason I wanted that narrower default was personal. After two years on Chat 2 my database had grown past two million messages, most of them /say, /shout and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full-history view powerful and most users are happy to keep it. For my own taste I wanted a smaller default. So I built this fork.</value> <value>The desire for this narrower default was personal. After two years with Chat 2, my database had grown to over two million messages, the majority of them /say, /shout, and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full history useful, and most users are happy to keep it. My own preference was for a smaller default. So I built this fork.</value>
</data> </data>
<data name="About_Mission_P3" xml:space="preserve"> <data name="About_Mission_P3" xml:space="preserve">
<value>I am not chasing a big audience and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the upstream plugin. Infi, Anna or anyone else are welcome to read it, borrow ideas, ask questions, or ignore the project. All three are fine by me.</value> <value>I am not targeting a large audience, and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the original. Infi, Anna, or anyone else is welcome to look around, borrow ideas, ask questions, or simply ignore the project. All three are fine by me.</value>
</data> </data>
<data name="About_BuiltOn_Heading" xml:space="preserve"> <data name="About_BuiltOn_Heading" xml:space="preserve">
<value>Built on Chat 2</value> <value>Built on Chat 2</value>
</data> </data>
<data name="About_BuiltOn_P1" xml:space="preserve"> <data name="About_BuiltOn_P1" xml:space="preserve">
<value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat replacement window, the IPC integration, the rendering engine and the entire storage core come from upstream Chat 2.</value> <value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat-replacement window, IPC integration, render engine, and the entire storage core all come from the original.</value>
</data> </data>
<data name="About_BuiltOn_P2" xml:space="preserve"> <data name="About_BuiltOn_P2" xml:space="preserve">
<value>The webinterface is the only major piece I removed. It is built for remote access to chat from a second device, which is a different focus than the smaller default footprint this fork is built around. Aligning it with these defaults would have meant a substantial rebuild, so removing it was the cleaner path for this particular fork.</value> <value>The web interface is the only major piece I removed. It is built for remote access to the chat from a second device a different focus from the smaller default footprint this fork pursues. Adapting it to these defaults would have required significant rework, so removing it was the clean path for this particular fork.</value>
</data> </data>
<data name="About_BuiltOn_Upstream_Label" xml:space="preserve"> <data name="About_BuiltOn_Upstream_Label" xml:space="preserve">
<value>Upstream repository:</value> <value>Upstream repository:</value>
</data> </data>
<data name="About_License_Heading" xml:space="preserve"> <data name="About_License_Heading" xml:space="preserve">
<value>License</value> <value>Licence</value>
</data> </data>
<data name="About_License_P1" xml:space="preserve"> <data name="About_License_P1" xml:space="preserve">
<value>Hellion Chat and Chat 2 both ship under the European Union Public Licence v1.2 (EUPL-1.2).</value> <value>Hellion Chat and Chat 2 are both released under the European Union Public Licence v1.2 (EUPL-1.2).</value>
</data> </data>
<data name="About_License_P2" xml:space="preserve"> <data name="About_License_P2" xml:space="preserve">
<value>© 2023 to 2026, the Chat 2 authors (Infi, Anna and the upstream contributors).</value> <value>© 2023 to 2026, the Chat 2 authors (Infi, Anna, and upstream contributors).</value>
</data> </data>
<data name="About_License_P3" xml:space="preserve"> <data name="About_License_P3" xml:space="preserve">
<value>© 2026 Hellion Online Media for the additions made in this fork.</value> <value>© 2026 Hellion Online Media for the extensions in this fork.</value>
</data> </data>
<data name="About_SE_Heading" xml:space="preserve"> <data name="About_SE_Heading" xml:space="preserve">
<value>FINAL FANTASY XIV disclaimer</value> <value>FINAL FANTASY XIV notice</value>
</data> </data>
<data name="About_SE_P1" xml:space="preserve"> <data name="About_SE_P1" xml:space="preserve">
<value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value> <value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value>
</data> </data>
<data name="About_SE_P2" xml:space="preserve"> <data name="About_SE_P2" xml:space="preserve">
<value>Hellion Chat is an unofficial, fan-made plugin. It has no affiliation with Square Enix and is not endorsed, sponsored or approved by them.</value> <value>Hellion Chat is an unofficial fan plugin. It is not affiliated with Square Enix and is neither endorsed, sponsored, nor approved by them.</value>
</data> </data>
<data name="About_Localization_Heading" xml:space="preserve"> <data name="About_Localization_Heading" xml:space="preserve">
<value>Localization</value> <value>Localisation</value>
</data> </data>
<data name="About_Localization_P1" xml:space="preserve"> <data name="About_Localization_P1" xml:space="preserve">
<value>The German translations of the Hellion-specific strings come from me. Other languages are not provided yet.</value> <value>The translations of the Hellion-specific strings were done by me. No additional languages are currently available.</value>
</data> </data>
<data name="About_Localization_P2" xml:space="preserve"> <data name="About_Localization_P2" xml:space="preserve">
<value>The translator list below covers the upstream Chat 2 strings on Crowdin. Those volunteers translated Chat 2, not the Hellion additions.</value> <value>The translator list below belongs to the Chat 2 strings on Crowdin. These volunteers translated Chat 2, not the Hellion extensions.</value>
</data> </data>
<data name="About_Translators_TreeNode" xml:space="preserve"> <data name="About_Translators_TreeNode" xml:space="preserve">
<value>Chat 2 community translators (upstream)</value> <value>Chat 2 community translators (upstream)</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (runtime strings) --> <!-- Hellion Chat — Auto-Tell-Tabs (Runtime strings) -->
<data name="AutoTellTabs_SectionHeader" xml:space="preserve"> <data name="AutoTellTabs_SectionHeader" xml:space="preserve">
<value>Active Tells</value> <value>Active tells</value>
</data> </data>
<data name="AutoTellTabs_HistorySeparator" xml:space="preserve"> <data name="AutoTellTabs_HistorySeparator" xml:space="preserve">
<value>— Earlier conversations —</value> <value>— Earlier conversations —</value>
</data> </data>
<data name="AutoTellTabs_HistoryLoadError" xml:space="preserve"> <data name="AutoTellTabs_HistoryLoadError" xml:space="preserve">
<value>History could not be loaded.</value> <value>Could not load history.</value>
</data> </data>
<data name="AutoTellTabs_GreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_GreetedTooltip" xml:space="preserve">
<value>Marked as greeted. Click to remove the marker.</value> <value>Marked as greeted. Click to remove the mark.</value>
</data> </data>
<data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve">
<value>Mark as greeted.</value> <value>Mark as greeted.</value>
</data> </data>
<data name="PinTab_MenuPin" xml:space="preserve">
<value>Pin Tab</value>
</data>
<data name="PinTab_MenuUnpin" xml:space="preserve">
<value>Unpin Tab</value>
</data>
<data name="PinTab_MenuPromote" xml:space="preserve">
<value>Promote to permanent</value>
</data>
<data name="PinTab_PromoteTooltip" xml:space="preserve">
<value>Turns this TempTell into a regular tab. The tell binding to the partner is dropped — the tab will catch messages by its channel filters from now on. For "tab survives relog while staying bound to this partner", use Pin Tab instead.</value>
</data>
<data name="PinTab_PinTooltip" xml:space="preserve">
<value>Pinned tabs survive relog and stay bound to this conversation partner.</value>
</data>
<data name="PinTab_SectionHeader" xml:space="preserve">
<value>Pinned</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Name" xml:space="preserve">
<value>Sidebar width</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Description" xml:space="preserve">
<value>Width of the tab sidebar in pixels. The default (44 px) is icon-only; widen it to fit the section headers like "Active Tells (3)" without truncation.</value>
</data>
<data name="PinTab_LimitReached" xml:space="preserve">
<value>Maximum of {0} pinned tell tabs reached. Unpin one first, or use Promote to permanent.</value>
</data>
<data name="PinTab_PinnedTooltip" xml:space="preserve">
<value>Pinned — survives relog.</value>
</data>
<!-- Hellion Chat — Auto-Tell-Tabs (Chat settings tab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Chat settings tab) -->
<data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve">
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve">
<value>Open a tab automatically for each tell partner</value> <value>Automatically open a tab per conversation partner for every /tell</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve">
<value>When you receive or send a /tell, a temporary tab dedicated to that player is opened automatically. Tabs vanish on logout.</value> <value>As soon as you receive or send a /tell, a temporary tab is automatically opened for that player. Tabs are removed on logout.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve">
<value>Maximum number of auto tell tabs</value> <value>Maximum number of auto-tell tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve">
<value>When the limit is reached, greeted tabs with the oldest activity are dropped first. The change applies on the next /tell.</value> <value>When the limit is reached, greeted tabs with the oldest activity are closed first. Changes take effect on the next /tell. This limit applies to the auto-managed pool. Pinned tell tabs (right-click → Pin Tab) live in a separate pool of up to 5 and survive relog.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve">
<value>Compact display</value> <value>Compact display</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve">
<value>Show only a thin separator between persistent tabs and auto tell tabs, without the section header.</value> <value>Shows only a thin separator between regular tabs and auto-tell tabs, without a section header.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve">
<value>Show "mark as greeted" button</value> <value>Show "Mark as greeted" button</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve">
<value>Adds a click-to-toggle button next to each auto tell tab to mark a partner as already greeted, dimming the tab name when set. Useful for club greeters tracking many parallel conversations; off by default.</value> <value>Adds a click button next to each auto-tell tab to mark a conversation partner as already greeted the tab name is then dimmed. Useful for club greeters managing many conversations in parallel. Off by default.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve">
<value>Open new /tell tabs directly as pop-out</value> <value>Open new /tell tabs directly as pop-outs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve">
<value>When enabled, each newly created /tell tab opens directly as its own window. Closing the window returns the tab to the sidebar.</value> <value>When active, each newly created /tell tab is immediately opened as its own window. Closing the window returns the tab to the sidebar.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve">
<value>The number of preloaded tells is configured in the Privacy tab.</value> <value>The number of preloaded tells can be configured in the Privacy tab.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve">
<value>Heads-up: if XIV Messanger or a similar plugin is suppressing direct messages, turn its "Suppress DMs" option off so Hellion Chat can receive tells and open the auto tabs.</value> <value>Note: If XIV Messenger or a similar plugin suppresses tells, disable the "Suppress DMs" option there so that Hellion Chat can receive tells and open the auto-tabs.</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) -->
<data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve">
<value>Tell history in auto tabs</value> <value>Tell history in auto-tabs</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve">
<value>Number of preloaded tells</value> <value>Number of preloaded tells</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve">
<value>How many earlier tell messages are loaded from the database when an auto tell tab is opened. 0 disables the preload.</value> <value>How many previous tell messages are loaded from the database when an auto-tell tab is opened. 0 disables preloading.</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve">
<value>Only takes effect when auto tell tabs are enabled in the Chat tab.</value> <value>Only takes effect when auto-tell tabs are enabled in the Chat tab.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish v10 wipe migration --> <!-- Hellion Chat — Settings UX Polish v10 Wipe migration -->
<data name="SettingsRefactor_Migration_Title" xml:space="preserve"> <data name="SettingsRefactor_Migration_Title" xml:space="preserve">
<value>Settings reorganised</value> <value>Settings restructured</value>
</data> </data>
<data name="SettingsRefactor_Migration_Content" xml:space="preserve"> <data name="SettingsRefactor_Migration_Content" xml:space="preserve">
<value>Hellion Chat 0.5.0 reorganised the settings into themed tabs. Your chat database and your message history stay untouched. Settings have been reset to defaults; if you want to pick a privacy profile again, the reopen button is in the Privacy tab. A backup of your previous config is at HellionChat.json.pre-v10-backup next to the live config file.</value> <value>Hellion Chat 0.5.0 has restructured the settings into thematic tabs. Your chat database and message history remain unchanged. Settings have been reset to defaults. If you want to re-select your privacy profile, the Reopen button is in the Privacy tab. A backup of the previous config is located at HellionChat.json.pre-v10-backup next to the active config file.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish 8-tab structure --> <!-- Hellion Chat — Settings UX Polish 8-tab structure -->
@@ -455,30 +491,30 @@
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Tab_Tabs" xml:space="preserve"> <data name="Settings_Tab_Tabs" xml:space="preserve">
<value>Tabs</value> <value>Channels</value>
</data> </data>
<data name="Settings_Tab_Database" xml:space="preserve"> <data name="Settings_Tab_Database" xml:space="preserve">
<value>Database</value> <value>Database</value>
</data> </data>
<data name="Settings_Tab_Information" xml:space="preserve"> <data name="Settings_Tab_Information" xml:space="preserve">
<value>Information</value> <value>About</value>
</data> </data>
<!-- Hellion Chat — General-Tab section headings --> <!-- Hellion Chat — General tab section headings -->
<data name="Settings_General_Input_Heading" xml:space="preserve"> <data name="Settings_General_Input_Heading" xml:space="preserve">
<value>Input</value> <value>Input</value>
</data> </data>
<data name="Settings_General_Audio_Heading" xml:space="preserve"> <data name="Settings_General_Audio_Heading" xml:space="preserve">
<value>Audio &amp; Notifications</value> <value>Audio &amp; notifications</value>
</data> </data>
<data name="Settings_General_Performance_Heading" xml:space="preserve"> <data name="Settings_General_Performance_Heading" xml:space="preserve">
<value>Performance</value> <value>Performance</value>
</data> </data>
<data name="Settings_General_Language_Heading" xml:space="preserve"> <data name="Settings_General_Language_Heading" xml:space="preserve">
<value>Language &amp; Input Helpers</value> <value>Language &amp; input aids</value>
</data> </data>
<!-- Hellion Chat — Appearance-Tab section headings --> <!-- Hellion Chat — Appearance tab section headings -->
<data name="Settings_Appearance_Theme_Heading" xml:space="preserve"> <data name="Settings_Appearance_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
@@ -486,32 +522,32 @@
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_Appearance_Colours_Heading" xml:space="preserve"> <data name="Settings_Appearance_Colours_Heading" xml:space="preserve">
<value>Chat Colours</value> <value>Chat colours</value>
</data> </data>
<data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve"> <data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve">
<value>Timestamps</value> <value>Timestamps</value>
</data> </data>
<!-- Hellion Chat — Window-Tab section headings --> <!-- Hellion Chat — Window tab section headings -->
<data name="Settings_Window_Hide_Heading" xml:space="preserve"> <data name="Settings_Window_Hide_Heading" xml:space="preserve">
<value>Hide</value> <value>Hiding</value>
</data> </data>
<data name="Settings_Window_InactivityHide_Heading" xml:space="preserve"> <data name="Settings_Window_InactivityHide_Heading" xml:space="preserve">
<value>Inactivity Hide</value> <value>Inactivity hiding</value>
</data> </data>
<data name="Settings_Window_Frame_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Heading" xml:space="preserve">
<value>Window Frame</value> <value>Window frame</value>
</data> </data>
<data name="Settings_Window_Tooltips_Heading" xml:space="preserve"> <data name="Settings_Window_Tooltips_Heading" xml:space="preserve">
<value>Tooltips</value> <value>Tooltips</value>
</data> </data>
<!-- Hellion Chat — Chat-Tab section headings --> <!-- Hellion Chat — Chat tab section headings -->
<data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve"> <data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve">
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="Settings_Chat_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Chat_Behaviour_Heading" xml:space="preserve">
<value>Message Behaviour</value> <value>Message behaviour</value>
</data> </data>
<data name="Settings_Chat_Preview_Heading" xml:space="preserve"> <data name="Settings_Chat_Preview_Heading" xml:space="preserve">
<value>Preview</value> <value>Preview</value>
@@ -520,7 +556,15 @@
<value>Emotes</value> <value>Emotes</value>
</data> </data>
<!-- Hellion Chat — Database-Tab section headings --> <!-- Hellion Chat — Chat tab SymbolPicker -->
<data name="Settings_Chat_SymbolPicker_Enable_Name" xml:space="preserve">
<value>Show symbol-picker button next to chat input</value>
</data>
<data name="Settings_Chat_SymbolPicker_Enable_Description" xml:space="preserve">
<value>Adds a small button left of the channel indicator that opens a popup with FFXIV icons and a curated symbol list. Disable if you prefer a leaner input bar.</value>
</data>
<!-- Hellion Chat — Database tab section headings -->
<data name="Settings_Database_Storage_Heading" xml:space="preserve"> <data name="Settings_Database_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
</data> </data>
@@ -531,9 +575,9 @@
<value>Maintenance</value> <value>Maintenance</value>
</data> </data>
<!-- Hellion Chat — Information-Tab section headings --> <!-- Hellion Chat — Information tab section headings -->
<data name="Settings_Information_VersionInfo_Heading" xml:space="preserve"> <data name="Settings_Information_VersionInfo_Heading" xml:space="preserve">
<value>Version Info</value> <value>Version info</value>
</data> </data>
<data name="Settings_Information_About_Heading" xml:space="preserve"> <data name="Settings_Information_About_Heading" xml:space="preserve">
<value>About HellionChat</value> <value>About HellionChat</value>
@@ -542,7 +586,7 @@
<value>Changelog</value> <value>Changelog</value>
</data> </data>
<!-- Hellion Chat — Default tab presets (channel-themed) --> <!-- Hellion Chat — Default tab presets (channel-specific) -->
<data name="Tabs_Presets_System" xml:space="preserve"> <data name="Tabs_Presets_System" xml:space="preserve">
<value>System</value> <value>System</value>
</data> </data>
@@ -553,36 +597,36 @@
<value>Party</value> <value>Party</value>
</data> </data>
<data name="Tabs_Presets_Beginner" xml:space="preserve"> <data name="Tabs_Presets_Beginner" xml:space="preserve">
<value>Beginner</value> <value>Novice</value>
</data> </data>
<data name="Tabs_Presets_Linkshell" xml:space="preserve"> <data name="Tabs_Presets_Linkshell" xml:space="preserve">
<value>Linkshell</value> <value>Linkshell</value>
</data> </data>
<data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve"> <data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve">
<value>If you use multiple linkshells, the maintainer recommends one tab per shell for cleaner readability. Duplicate this tab and narrow the channel selection per copy.</value> <value>If you use multiple linkshells, the maintainer recommends one tab per shell for a cleaner overview. Duplicate the tab and restrict the channel selection in each copy.</value>
</data> </data>
<!-- Hellion Chat — v1.2.0 per-tab icon override --> <!-- Hellion Chat — v1.2.0 per-tab icon override -->
<data name="Tabs_Icon_Label" xml:space="preserve"> <data name="Tabs_Icon_Label" xml:space="preserve">
<value>Tab-Icon</value> <value>Tab icon</value>
</data> </data>
<data name="Tabs_Icon_HelpMarker" xml:space="preserve"> <data name="Tabs_Icon_HelpMarker" xml:space="preserve">
<value>FontAwesome-Glyph für die Sidebar. Default greift auf Tab-Name oder Channel-Typ.</value> <value>FontAwesome glyph for the sidebar. Default falls back to the tab name or channel type.</value>
</data> </data>
<data name="Tabs_Icon_DefaultOption" xml:space="preserve"> <data name="Tabs_Icon_DefaultOption" xml:space="preserve">
<value>(Default-Mapping)</value> <value>(Default mapping)</value>
</data> </data>
<data name="ChatColourPresets_Default" xml:space="preserve"> <data name="ChatColourPresets_Default" xml:space="preserve">
<value>Klassik (Chat 2 Default)</value> <value>Classic (Chat 2 default)</value>
</data> </data>
<data name="ChatColourPresets_HighContrast" xml:space="preserve"> <data name="ChatColourPresets_HighContrast" xml:space="preserve">
<value>High-Contrast</value> <value>High contrast</value>
</data> </data>
<data name="ChatColourPresets_Pastell" xml:space="preserve"> <data name="ChatColourPresets_Pastell" xml:space="preserve">
<value>Pastell</value> <value>Pastel</value>
</data> </data>
<data name="ChatColourPresets_DarkModeTuned" xml:space="preserve"> <data name="ChatColourPresets_DarkModeTuned" xml:space="preserve">
<value>Dark-Mode-Tuned</value> <value>Dark mode tuned</value>
</data> </data>
<data name="ChatColourPresets_Hellion" xml:space="preserve"> <data name="ChatColourPresets_Hellion" xml:space="preserve">
<value>Hellion</value> <value>Hellion</value>
@@ -594,22 +638,22 @@
<value>Indigo Violet</value> <value>Indigo Violet</value>
</data> </data>
<data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve"> <data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve">
<value>Tip: presets overwrite your current channel colours immediately.</value> <value>Tip: Presets overwrite your current channel colours immediately.</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve">
<value>Enable input in pop-outs</value> <value>Enable input in pop-outs</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve">
<value>Master switch: lets you type and send messages directly inside every pop-out window (including auto-tell tabs). Channel changes inside a pop-out apply globally just like in the main window; the text buffer and history cursor stay independent per pop-out.</value> <value>Master switch: allows typing and sending directly in any pop-out window (including auto-tell tabs). Channel switching in a pop-out acts globally like in the main window; the text buffer and history cursor are independent per pop-out.</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Name" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Name" xml:space="preserve">
<value>Reset Window Position</value> <value>Reset window position</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Description" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Description" xml:space="preserve">
<value>Snaps the chat window and every active pop-out back to the primary monitor's top-left corner. Useful when a window has drifted off-screen after a display layout change (monitor disconnected, resolution changed). The plugin also runs an automatic bounds check once per session this button is the manual backup if anything still ends up unreachable.</value> <value>Moves the chat window and all active pop-outs back to the top-left corner of the primary monitor. Useful when a window has ended up outside the visible area after a display layout change (monitor disconnected, resolution changed). The plugin also performs an automatic bounds check once per session; this button is the manual escape hatch if something still ends up unreachable.</value>
</data> </data>
<data name="Popout_v060_HintText" xml:space="preserve"> <data name="Popout_v060_HintText" xml:space="preserve">
<value>New in v0.6.0: you can type directly inside pop-out windows. Toggle the master switch in the window settings to enable it.</value> <value>New in v0.6.0: You can now type directly in pop-outs. Enable the master switch in the Window settings.</value>
</data> </data>
<data name="Popout_v060_HintAck" xml:space="preserve"> <data name="Popout_v060_HintAck" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
@@ -618,19 +662,19 @@
<value>Open window settings</value> <value>Open window settings</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Body" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Body" xml:space="preserve">
<value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is enabled by default (can be turned off under Settings → Window).</value> <value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is active by default (can be disabled under Settings → Window).</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve">
<value>Open Settings</value> <value>Open settings</value>
</data> </data>
<data name="ChatTwoConflictTitle" xml:space="preserve"> <data name="ChatTwoConflictTitle" xml:space="preserve">
<value>Hellion Chat cannot start while Chat 2 is loaded.</value> <value>Hellion Chat cannot start while Chat 2 is loaded.</value>
</data> </data>
<data name="ChatTwoConflictBody" xml:space="preserve"> <data name="ChatTwoConflictBody" xml:space="preserve">
<value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same in-game chat window and would conflict at runtime if loaded together.</value> <value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same chat window in the game and would conflict at runtime.</value>
</data> </data>
<data name="ChatTwoConflictAction" xml:space="preserve"> <data name="ChatTwoConflictAction" xml:space="preserve">
<value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value> <value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value>
@@ -639,7 +683,7 @@
<value>General</value> <value>General</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Plugin-wide settings — language, input, audio, performance.</value> <value>Language, input, audio, and performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Appearance</value> <value>Appearance</value>
@@ -657,25 +701,25 @@
<value>Window</value> <value>Window</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>Window behaviour — when it shows, whether it can move.</value> <value>When the window is visible and whether it can be moved.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>How messages are displayed — tells, preview, behaviour, emotes.</value> <value>Tells, preview, message behaviour, and emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Tab management — create and configure your own chat tabs.</value> <value>Create and configure custom chat tabs.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Privacy</value> <value>Privacy</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>What's allowed to be stored — privacy filter per channel.</value> <value>Privacy filter per channel and what may be stored.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Database</value> <value>Database</value>
@@ -687,7 +731,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>About the plugin — version, mission, license, changelog.</value> <value>Version, mission, licence, and changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -705,16 +749,16 @@
<value>Open themes folder</value> <value>Open themes folder</value>
</data> </data>
<data name="Settings_Themes_ExportActive" xml:space="preserve"> <data name="Settings_Themes_ExportActive" xml:space="preserve">
<value>Export active...</value> <value>Export active</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve">
<value>This theme suggests its own chat channel colours.</value> <value>This theme suggests its own channel colours.</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve">
<value>Apply</value> <value>Apply</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve">
<value>Keep current</value> <value>Keep</value>
</data> </data>
<data name="StatusBar_Privacy_Enabled" xml:space="preserve"> <data name="StatusBar_Privacy_Enabled" xml:space="preserve">
<value>Privacy-First</value> <value>Privacy-First</value>
@@ -723,55 +767,55 @@
<value>Open</value> <value>Open</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Name" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Name" xml:space="preserve">
<value>Compact Density</value> <value>Compact density</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Description" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Description" xml:space="preserve">
<value>Schaltet das Message-Layout vom Card-Row-Default zurück auf einzeilige `[HH:mm] Sender: Text` Zeilen.</value> <value>Switches the message layout from the card-row default back to single-line `[HH:mm] Sender: Text` rows.</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve">
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>How the window looks — theme, frame, timestamp style.</value> <value>Theme, window frame, and timestamp style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Fonts &amp; Colours</value> <value>Fonts &amp; Colours</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Readability — font, font size, per-channel chat colours.</value> <value>Font, font size, and chat colours per channel.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Data Management</value> <value>Data management</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>What happens to stored data — retention, cleanup, export, DB stats.</value> <value>Retention, cleanup, export, and database statistics.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Other Dalamud plugins HellionChat reacts to. Auto-detected, with a "coming soon" preview of upcoming integrations.</value> <value>Other Dalamud plugins that HellionChat works with. Upcoming integrations in preview.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve">
<value>Window Style</value> <value>Window style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve">
<value>Timestamp Style</value> <value>Timestamp style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve">
<value>Window Transparency</value> <value>Window transparency</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve">
<value>How transparent the window background is. Lower values let the game show through more. Tip: Dalamud's per-window menu (Hamburger in the title bar) gives you per-window overrides for opacity, background blur, click-through and pinning — those override this slider for that window.</value> <value>How transparent the window background is. Lower values let more of the game show through. Tip: Dalamud's per-window menu (hamburger in the title bar) offers per-window overrides for opacity, background blur, click-through, and pinning — those take precedence over this slider for the respective window.</value>
</data> </data>
<data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve">
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve">
<value>Chat Colours</value> <value>Chat colours</value>
</data> </data>
<data name="Settings_DataManagement_Storage_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
@@ -786,22 +830,22 @@
<value>Export</value> <value>Export</value>
</data> </data>
<data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve"> <data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve">
<value>Database Viewer</value> <value>Database viewer</value>
</data> </data>
<data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve">
<value>Advanced (Shift+Click to open)</value> <value>Advanced (Shift+click to open)</value>
</data> </data>
<data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve">
<value>Behaviour</value> <value>Behaviour</value>
</data> </data>
<data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve"> <data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve">
<value>Hellion Chat 1.2.1 reorganised the Settings menu and removed the legacy "Style override" option (made obsolete by the Themes system in 1.1.0). Your other settings are unchanged. Window opacity was migrated to Theme &amp; Layout. A backup of your previous config is at pluginConfigs/HellionChat.json.pre-v16-backup next to the live HellionChat.json.</value> <value>Hellion Chat 1.2.1 has reorganised the settings menu and removed the old "Override style" option (superseded by the theme system from 1.1.0). Your remaining settings are unchanged. Window transparency has been migrated to "Theme &amp; Layout". A backup of the previous config is located at pluginConfigs/HellionChat.json.pre-v16-backup next to the active HellionChat.json.</value>
</data> </data>
<data name="Settings_Tab_Integrations" xml:space="preserve"> <data name="Settings_Tab_Integrations" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Integrations_Intro" xml:space="preserve"> <data name="Settings_Integrations_Intro" xml:space="preserve">
<value>Plugin integrations let HellionChat react to other installed Dalamud plugins. Each integration auto-detects its target and silently disables itself when the target plugin is not present.</value> <value>Plugin integrations let HellionChat work together with other installed Dalamud plugins. Each integration automatically detects its target and silently disables itself when the target plugin is missing.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve">
<value>Honorific</value> <value>Honorific</value>
@@ -813,13 +857,19 @@
<value>Not installed</value> <value>Not installed</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve">
<value>Incompatible API version ({0} expected, {1}.{2} detected)</value> <value>Incompatible API version ({0} expected, {1}.{2} found)</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve">
<value>Show Honorific title in chat header</value> <value>Show Honorific title in chat header</value>
</data> </data>
<data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve"> <data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve">
<value>Displays your custom title from Honorific in the header above the chat log, in your chosen colour.</value> <value>Shows your custom title from Honorific in the header above the chat log, in the colour you have chosen.</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Toggle" xml:space="preserve">
<value>Render glow outlines (Honorific)</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Hint" xml:space="preserve">
<value>May reduce frame rate on low-end hardware. Renders glow outlines for Honorific titles that use them. Gradient animation is not yet supported and will render as the primary colour.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve"> <data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve">
<value>Honorific on GitHub</value> <value>Honorific on GitHub</value>
@@ -831,48 +881,57 @@
<value>Coming soon</value> <value>Coming soon</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve">
<value>These integrations are on the roadmap. The settings for each appear automatically once the underlying plugin is wired up.</value> <value>These integrations are on the roadmap. The settings will appear automatically once the respective plugin is connected.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve">
<value>Context menu actions</value> <value>Context menu actions</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve">
<value>Right-click a name in chat to jump to PlayerTrack, open the Lodestone profile, or compose a DM in one click.</value> <value>Right-click a name in chat: jump to PlayerTrack, open the Lodestone profile, or compose a DM with one click.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve">
<value>Smart notifications (NotificationMaster)</value> <value>Smart notifications (NotificationMaster)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve">
<value>Route mentions and DMs through NotificationMaster for system toasts, taskbar flash, and per-channel sounds.</value> <value>Mentions and DMs via NotificationMaster: system toasts, taskbar flash, and per-channel sounds.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve">
<value>RP status block (Moodles · LightlessClient)</value> <value>RP status block (Moodles · LightlessClient)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve">
<value>Show Moodles status icons and pair-badges inline next to chat names for richer roleplay context.</value> <value>Show Moodles status icons and pair badges directly next to chat names for more roleplay context.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve">
<value>ExtraChat channels</value> <value>ExtraChat channels</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve">
<value>Host end-to-end-encrypted cross-datacenter linkshells natively in HellionChat.</value> <value>Host end-to-end encrypted cross-datacenter linkshells natively in HellionChat.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve">
<value>Quick DM button (XIVInstantMessenger)</value> <value>Quick-DM button (XIVInstantMessenger)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve">
<value>One-click DM compose without leaving the chat window.</value> <value>Quick DM access directly from the chat window, one click.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve">
<value>Got an idea?</value> <value>Got an idea?</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve">
<value>Got an idea for a plugin integration that's not on this list? Hop on the Hellion Forge Discord and tell me. Community input drives the roadmap.</value> <value>Got an idea for a plugin integration that is not on the list? Come to the Hellion Forge Discord and write to me. Community input shapes the roadmap.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve">
<value>Open Hellion Forge</value> <value>Open Hellion Forge</value>
</data> </data>
<data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve"> <data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve">
<value>Honorific custom title</value> <value>Custom title from Honorific</value>
</data>
<data name="DbViewer_FullTextToggle" xml:space="preserve">
<value>Full-text search</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_Indexing" xml:space="preserve">
<value>The full-text index is still being built. The local filter remains available.</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_PhraseMode" xml:space="preserve">
<value>Searches for the exact phrase. Multi-word queries match only when the words appear together in order. To use raw FTS5 MATCH syntax, wrap your term in double quotes yourself.</value>
</data> </data>
</root> </root>
@@ -4,13 +4,9 @@ using HellionChat.Themes;
namespace HellionChat.SelfTests; namespace HellionChat.SelfTests;
// Validates the runtime theme-switch contract from the user side. The // Validates the runtime theme-switch contract: polls ThemeRegistry.Active
// caller toggles the active theme via Settings -> Theme & Layout, the // per frame until the slug moves away and back, then sanity-checks that
// step polls ThemeRegistry.Active per frame and only passes once the // the ABGR cache was recomputed on switch.
// slug has moved away from the initial value and back. The ABGR cache
// is sanity-checked on every frame: a freshly switched theme must carry
// a populated cache, otherwise Switch() forgot the recompute and the UI
// would still draw, just with all-transparent slots.
internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep
{ {
private readonly Plugin plugin; private readonly Plugin plugin;
@@ -73,9 +69,8 @@ internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep
this.switchedAway = false; this.switchedAway = false;
} }
// Any non-zero slot proves the cache was actually recomputed for the // Any non-zero slot confirms the cache was recomputed — no reference
// current theme. We don't compare against a reference, because custom // comparison since custom themes can share slot values with built-ins.
// themes can legitimately share slot values with a built-in.
private static bool HasPopulatedCache(Theme theme) private static bool HasPopulatedCache(Theme theme)
{ {
var cache = theme.AbgrCache; var cache = theme.AbgrCache;
@@ -0,0 +1,82 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class CrystalNocturne
{
public const string Slug = "crystal-nocturne";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Crystal Nocturne",
Author: "CRYSTALLITE",
Description: "Royal sapphire and electric magenta over obsidian — a nocturne for the crystal-lit dance floor.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#1D4ED8"),
Primary: ColourUtil.HexToRgba("#3B82F6"),
PrimaryLight: ColourUtil.HexToRgba("#93C5FD"),
PrimaryGlow: ColourUtil.HexToRgba("#3B82F699"),
AccentDark: ColourUtil.HexToRgba("#A21CAF"),
Accent: ColourUtil.HexToRgba("#D946EF"),
AccentLight: ColourUtil.HexToRgba("#F0ABFC"),
Identity: ColourUtil.HexToRgba("#3B82F6"),
WindowBg: ColourUtil.HexToRgba("#08070F"),
ChildBg: ColourUtil.HexToRgba("#11101F"),
FrameBg: ColourUtil.HexToRgba("#1C1A33"),
Surface: ColourUtil.HexToRgba("#262340"),
SurfaceHover: ColourUtil.HexToRgba("#332D55"),
Border: ColourUtil.HexToRgba("#D946EF55"),
TextPrimary: ColourUtil.HexToRgba("#F5F3FF"),
TextMuted: ColourUtil.HexToRgba("#A5A0C0"),
TextDim: ColourUtil.HexToRgba("#4B4763"),
StatusSuccess: ColourUtil.HexToRgba("#10B981"),
StatusDanger: ColourUtil.HexToRgba("#F43F5E"),
StatusWarning: ColourUtil.HexToRgba("#FACC15"),
StatusInfo: ColourUtil.HexToRgba("#3B82F6")
),
Layout: new ThemeLayout(
WindowRounding: 2f,
ChildRounding: 1f,
PopupRounding: 2f,
FrameRounding: 1f,
GrabRounding: 1f,
TabRounding: 1f,
ScrollbarRounding: 2f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Crystal Nocturne — sapphire-blue identity for party/team channels,
// accent-magenta for tells, with mint/peach accents on linkshells
// so the eight LS slots stay individually distinguishable on the
// dark obsidian background.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#F5F3FF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#A5A0C0"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#D946EF"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#3B82F6"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#A5A0C0"),
}
)
);
}
@@ -2,12 +2,7 @@ using HellionChat.Util;
namespace HellionChat.Themes.Builtin; namespace HellionChat.Themes.Builtin;
// Hellion Spectrum: Deuteran/Protan-safe channel colours. // Deuteran/Protan-safe palette with preserved channel identity.
// Palette derived from Bang Wong, "Points of view: Color blindness",
// Nature Methods 8, 441 (2011). Channel identity (Tell pink, Yell yellow,
// Shout orange, Party blue, FC green) is preserved per Channel-Identity-
// Rule in docs/THEME-AUTHORING.md; tones are chosen so every channel
// stays distinguishable under red-green colour-vision deficiency.
internal static class HellionSpectrum internal static class HellionSpectrum
{ {
public const string Slug = "hellion-spectrum"; public const string Slug = "hellion-spectrum";
@@ -57,9 +52,6 @@ internal static class HellionSpectrum
ChatColors: new ThemeChatColors( ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint> new Dictionary<HellionChat.Code.ChatType, uint>
{ {
// Hellion Spectrum — Wong/Okabe-Ito tones within FFXIV channel
// identity. FC pulled slightly greener than vanilla cyan-teal so
// Party-blue and FC-green stay separable under deuteran sim.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"), [HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"), [HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"), [HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"),
@@ -1,80 +0,0 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class MoonlitBloom
{
public const string Slug = "moonlit-bloom";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Moonlit Bloom",
Author: "Hellion Forge",
Description: "Bloom Magenta + Soft Sage auf Deep Violet Night.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#C957D0"),
Primary: ColourUtil.HexToRgba("#E374E8"),
PrimaryLight: ColourUtil.HexToRgba("#EF8AF4"),
PrimaryGlow: ColourUtil.HexToRgba("#E374E899"),
AccentDark: ColourUtil.HexToRgba("#7AAC5C"),
Accent: ColourUtil.HexToRgba("#9CCB7C"),
AccentLight: ColourUtil.HexToRgba("#B6E297"),
Identity: ColourUtil.HexToRgba("#E374E8"),
WindowBg: ColourUtil.HexToRgba("#0E0C1F"),
ChildBg: ColourUtil.HexToRgba("#15122B"),
FrameBg: ColourUtil.HexToRgba("#1F1A38"),
Surface: ColourUtil.HexToRgba("#28224A"),
SurfaceHover: ColourUtil.HexToRgba("#332B5B"),
Border: ColourUtil.HexToRgba("#E374E844"),
TextPrimary: ColourUtil.HexToRgba("#ECE6F5"),
TextMuted: ColourUtil.HexToRgba("#9A8BB0"),
TextDim: ColourUtil.HexToRgba("#554B6E"),
StatusSuccess: ColourUtil.HexToRgba("#7AAC5C"),
StatusDanger: ColourUtil.HexToRgba("#E85C6A"),
StatusWarning: ColourUtil.HexToRgba("#E8B590"),
StatusInfo: ColourUtil.HexToRgba("#6278FF")
),
Layout: new ThemeLayout(
WindowRounding: 6f,
ChildRounding: 5f,
PopupRounding: 5f,
FrameRounding: 4f,
GrabRounding: 4f,
TabRounding: 4f,
ScrollbarRounding: 4f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Moonlit Bloom — Bloom-Magenta-Tönung. Sage-Drift in NoviceNetwork
// und Linkshell4. Tell-Pink-Identität bleibt sichtbar.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#ECE6F5"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F09A60"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#F0BC92"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#B6E297"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#C098D8"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#E8B0E8"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#9A8BB0"),
}
)
);
}
@@ -10,7 +10,7 @@ internal static class SynthwaveSunset
new( new(
Slug: Slug, Slug: Slug,
Name: "Synthwave Sunset", Name: "Synthwave Sunset",
Author: "Hellion Forge", Author: "Zoe Moon",
Description: "Hot Magenta + Cyan on midnight violet. 80s neon-grid vibes for late-night raids.", Description: "Hot Magenta + Cyan on midnight violet. 80s neon-grid vibes for late-night raids.",
Colors: new ThemeColors( Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#C71585"), PrimaryDark: ColourUtil.HexToRgba("#C71585"),
+2 -4
View File
@@ -2,8 +2,6 @@ using HellionChat.Code;
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Optional pro Theme. Wenn ein Theme ChatColors mitliefert, kann der // Optional per-theme chat colours applied to Configuration.ChatColours on user request.
// User sie per Klick im Themes-Tab auf Configuration.ChatColours anwenden. // Themes without this leave channel colours untouched.
// Ein Theme ohne ChatColors (z.B. chat2-classic) lässt die User-Channel-
// Farben unverändert.
public sealed record ThemeChatColors(IReadOnlyDictionary<ChatType, uint> Channels); public sealed record ThemeChatColors(IReadOnlyDictionary<ChatType, uint> Channels);
+1 -1
View File
@@ -1,6 +1,6 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Color-Werte als 0xRRGGBBAA, RgbaToAbgr handled den Byte-Swap zu ImGui. // Colour values as 0xRRGGBBAA RgbaToAbgr handles the byte-swap for ImGui.
public sealed record ThemeColors( public sealed record ThemeColors(
uint PrimaryDark, uint PrimaryDark,
uint Primary, uint Primary,
+2 -4
View File
@@ -66,10 +66,8 @@ internal static class ThemeJsonLoader
var dict = new Dictionary<HellionChat.Code.ChatType, uint>(); var dict = new Dictionary<HellionChat.Code.ChatType, uint>();
foreach (var prop in el.EnumerateObject()) foreach (var prop in el.EnumerateObject())
{ {
// Property-Name ist der ChatType-Name als String (z.B. "Say", "Tell"), // Property name is the ChatType name (e.g. "Say", "Tell"), value is hex like theme colours.
// Value ist Hex wie bei den Theme-Colors. Unbekannte Channel-Names // Unknown channel names are silently skipped for forward-compat with future SE channels.
// werden still übersprungen — Forward-Compat falls SE neue Channels
// einführt.
if ( if (
!Enum.TryParse<HellionChat.Code.ChatType>( !Enum.TryParse<HellionChat.Code.ChatType>(
prop.Name, prop.Name,
+1 -1
View File
@@ -1,6 +1,6 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Layout-Werte spiegeln die ImGuiStyleVar-Slots, die HellionStyle pusht. // Layout values mirror the ImGuiStyleVar slots pushed by HellionStyle.
public sealed record ThemeLayout( public sealed record ThemeLayout(
float WindowRounding, float WindowRounding,
float ChildRounding, float ChildRounding,
+117 -24
View File
@@ -1,11 +1,21 @@
using HellionChat.Themes.Builtin; using HellionChat.Themes.Builtin;
using Microsoft.Extensions.Logging;
namespace HellionChat.Themes; namespace HellionChat.Themes;
public sealed class ThemeRegistry public sealed class ThemeRegistry
{ {
private readonly ILogger<ThemeRegistry>? _logger;
public const string DefaultSlug = HellionArctic.Slug; public const string DefaultSlug = HellionArctic.Slug;
// 1Hz throttle for the v1.4.8 B2 auto-refresh-on-active path. The
// Plugin.Draw hook calls RefreshActiveIfStale every frame, but the
// actual File.GetLastWriteTimeUtc disk-stat only runs once per second
// -- 60fps would otherwise mean 3600 stats/min on the same path (more
// on Wine). Same idiom as the StatusBar 1Hz cache.
private const long ActiveStampPollIntervalMs = 1000;
private readonly Dictionary<string, Theme> _builtIns; private readonly Dictionary<string, Theme> _builtIns;
private readonly Dictionary<string, (Theme Theme, DateTime Stamp)> _customCache = new( private readonly Dictionary<string, (Theme Theme, DateTime Stamp)> _customCache = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
@@ -13,23 +23,37 @@ public sealed class ThemeRegistry
private readonly string? _customThemesDir; private readonly string? _customThemesDir;
private Theme _active; private Theme _active;
public ThemeRegistry(string? customThemesDir = null) // v1.4.8 B2: source path of the currently active custom theme. Captured
// at Switch() time so RefreshActiveIfStale does not have to reconstruct
// a filename from the slug -- custom theme filenames are not required
// to match the slug they declare in the JSON body. Null when the active
// theme is built-in or no custom-themes directory is configured.
private string? _activeCustomPath;
private long _lastActiveStampCheckMs = -ActiveStampPollIntervalMs;
private DateTime _lastActiveStamp = DateTime.MinValue;
public ThemeRegistry(string? customThemesDir = null, ILogger<ThemeRegistry>? logger = null)
{ {
_logger = logger;
// Insertion order drives the Theme-Picker grid layout (3 columns).
// Row 1: blue family. Row 2: purple to magenta family.
// Row 3: green / warm / classic. Row 4: Synthwave Sunset as a
// retro bonus on its own line.
_builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase) _builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase)
{ {
{ HellionArctic.Slug, HellionArctic.Build() }, { HellionArctic.Slug, HellionArctic.Build() },
{ HellionSpectrum.Slug, HellionSpectrum.Build() }, { HellionSpectrum.Slug, HellionSpectrum.Build() },
{ Chat2Classic.Slug, Chat2Classic.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ MoonlitBloom.Slug, MoonlitBloom.Build() },
{ NightBlue.Slug, NightBlue.Build() }, { NightBlue.Slug, NightBlue.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ IndigoViolet.Slug, IndigoViolet.Build() }, { IndigoViolet.Slug, IndigoViolet.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() }, { CrystalNocturne.Slug, CrystalNocturne.Build() },
{ MintGrove.Slug, MintGrove.Build() }, { MintGrove.Slug, MintGrove.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() },
{ Chat2Classic.Slug, Chat2Classic.Build() },
{ SynthwaveSunset.Slug, SynthwaveSunset.Build() }, { SynthwaveSunset.Slug, SynthwaveSunset.Build() },
}; };
// Centralised so the ten .Build() factories stay free of cache plumbing. // Centralised so Build() factories stay free of cache plumbing.
foreach (var theme in _builtIns.Values) foreach (var theme in _builtIns.Values)
theme.RecomputeAbgrCache(); theme.RecomputeAbgrCache();
@@ -44,7 +68,9 @@ public sealed class ThemeRegistry
if (_builtIns.TryGetValue(slug, out var b)) if (_builtIns.TryGetValue(slug, out var b))
return b; return b;
var custom = LoadCustomBySlug(slug); // Discard the source path here; Switch is the only call-site that
// needs to remember it for the auto-refresh hook.
var custom = LoadCustomBySlug(slug, out _);
if (custom != null) if (custom != null)
return custom; return custom;
@@ -55,17 +81,74 @@ public sealed class ThemeRegistry
public IEnumerable<Theme> AllCustom() => RefreshCustomCache(); public IEnumerable<Theme> AllCustom() => RefreshCustomCache();
// Built-in-first to match Get(slug)'s lookup order. A user theme JSON
// that declares the same slug as a built-in is ignored deliberately --
// having Switch prefer custom and Get prefer built-in would produce
// a state where _active and Get(_active.Slug) disagree.
public void Switch(string slug) public void Switch(string slug)
{ {
var theme = Get(slug); if (_builtIns.TryGetValue(slug, out var builtin))
// Defensive — idempotent and cheap, so any future theme source {
// that forgets the cache fill still ends up with a populated one. _active = builtin;
theme.RecomputeAbgrCache(); _active.RecomputeAbgrCache();
_active = theme; _activeCustomPath = null;
return;
}
var customTheme = LoadCustomBySlug(slug, out var customPath);
if (customTheme is not null)
{
_active = customTheme;
// Defensive — ensures any future theme source always gets a populated cache.
_active.RecomputeAbgrCache();
_activeCustomPath = customPath;
// Force a first-tick reload-check after the switch so the stamp
// baseline is established on the next RefreshActiveIfStale call.
_lastActiveStamp = DateTime.MinValue;
return;
}
// Fallback: neither built-in nor custom matched. Drop to default
// and clear the active custom path so RefreshActiveIfStale stays idle.
_active = _builtIns[DefaultSlug];
_active.RecomputeAbgrCache();
_activeCustomPath = null;
} }
// 0x80070020 = SHARING_VIOLATION, 0x80070021 = LOCK_VIOLATION. Other // 1Hz-throttled disk-stat on the currently active custom theme file.
// IO failures are permanent and get the theme dropped instead of retried. // When the file's LastWriteTime moves forward (editor save), reload the
// theme via Get() so the user sees the edit immediately without
// re-selecting in the picker. Built-in themes short-circuit; custom
// themes without an _activeCustomPath (e.g. Switch fell to default)
// short-circuit too.
public void RefreshActiveIfStale()
{
var now = Environment.TickCount64;
if (now - _lastActiveStampCheckMs < ActiveStampPollIntervalMs)
return;
_lastActiveStampCheckMs = now;
if (_active.IsBuiltIn)
return;
var path = _activeCustomPath;
if (path is null || !File.Exists(path))
return;
var stamp = File.GetLastWriteTimeUtc(path);
if (!ThemeStampDiff.IsStale(_lastActiveStamp, stamp))
return;
_lastActiveStamp = stamp;
// Get() re-runs RefreshCustomCache which picks up the new content
// (the cache keys by path + LastWriteTime, so a mtime bump invalidates).
// RecomputeAbgrCache happens inside RefreshCustomCache on cache miss.
var reloaded = Get(_active.Slug);
_active = reloaded;
}
// 0x80070020 = SHARING_VIOLATION, 0x80070021 = LOCK_VIOLATION.
// Other IO failures are permanent — theme is dropped instead of retried.
internal static bool IsRecoverableFileLock(Exception? ex) internal static bool IsRecoverableFileLock(Exception? ex)
{ {
if (ex is not IOException io) if (ex is not IOException io)
@@ -74,19 +157,30 @@ public sealed class ThemeRegistry
return code == 0x80070020u || code == 0x80070021u; return code == 0x80070020u || code == 0x80070021u;
} }
// Custom-Themes werden lazy aus dem Verzeichnis geladen, Cache mit // Slug -> Theme lookup with the source path as an out-param so the
// LastWriteTime-Token. Eine geänderte JSON wird beim nächsten Lookup // Switch path can remember which file backs the active custom theme.
// neu eingelesen. // Pure reverse-lookup over the existing _customCache: that cache is
private Theme? LoadCustomBySlug(string slug) // already Path -> (Theme, Stamp), so iterating it costs nothing,
// avoids a re-parse of every JSON, and keeps the parse logic (and
// the recoverable-file-lock recovery) confined to RefreshCustomCache.
// The cache must be warm before this runs; Plugin.LoadAsync triggers
// a one-time warm-up via AllCustom() before the first Switch call.
private Theme? LoadCustomBySlug(string slug, out string? sourcePath)
{ {
sourcePath = null;
if (_customThemesDir is null) if (_customThemesDir is null)
return null; return null;
if (!Directory.Exists(_customThemesDir)) if (!Directory.Exists(_customThemesDir))
return null; return null;
foreach (var theme in RefreshCustomCache()) foreach (var kvp in _customCache)
if (string.Equals(theme.Slug, slug, StringComparison.OrdinalIgnoreCase)) {
return theme; if (string.Equals(kvp.Value.Theme.Slug, slug, StringComparison.OrdinalIgnoreCase))
{
sourcePath = kvp.Key;
return kvp.Value.Theme;
}
}
return null; return null;
} }
@@ -115,9 +209,8 @@ public sealed class ThemeRegistry
} }
catch (Exception ex) when (IsRecoverableFileLock(ex)) catch (Exception ex) when (IsRecoverableFileLock(ex))
{ {
// Editor mid-save: keep the cached snapshot, leave the stamp // Editor mid-save: keep last known good, retry on next refresh.
// alone so the next refresh retries automatically. _logger?.LogDebug(
Plugin.Log.Debug(
$"Custom theme {Path.GetFileName(path)} is locked, keeping last known good" $"Custom theme {Path.GetFileName(path)} is locked, keeping last known good"
); );
if (cached.Theme is not null) if (cached.Theme is not null)
+20
View File
@@ -0,0 +1,20 @@
namespace HellionChat.Themes;
// Pure stale-check for the v1.4.8 B2 theme-auto-refresh-on-active path.
// Lives in a free helper class so the Build-Suite can exercise the diff
// rules without instantiating ThemeRegistry (which touches the Dalamud
// log proxy and the filesystem). The rules:
// - DateTime.MinValue on the current stat means we could not read the
// file -- hold the last known good (return false).
// - Equal stamps mean no change since we last saw it.
// - Any other difference, including the first observation where lastSeen
// is MinValue, counts as stale and triggers a reload.
internal static class ThemeStampDiff
{
public static bool IsStale(System.DateTime lastSeen, System.DateTime current)
{
if (current == System.DateTime.MinValue)
return false;
return current != lastSeen;
}
}
+1 -2
View File
@@ -1,7 +1,6 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Optional pro Theme. v1.1.0 nutzt das nicht aktiv; ist als Erweiterungspunkt // Optional per-theme; reserved as an extension point for future theme slots.
// für zukünftige Theme-Slots vorbereitet.
public sealed record ThemeTypography( public sealed record ThemeTypography(
float? OverrideGlobalFontSizePt = null, float? OverrideGlobalFontSizePt = null,
float? OverrideSymbolsFontSizePt = null float? OverrideSymbolsFontSizePt = null
+15 -52
View File
@@ -1,34 +1,17 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
/// <summary> // Deterministic hash-based color and icon tinting for Auto-Tell sidebar tabs.
/// Hash-Color-Tinting für Auto-Tell-Tabs in der Sidebar (v1.2.0). // Same tell partner (name+world) always produces the same color and icon across
/// Differenziert Tells visuell ohne dass User pro Tab manuell ein // sessions. Pure string logic, no Dalamud dependency — testable without game refs.
/// Custom-Icon setzen muss. Gleicher Tell-Partner (Name+World) liefert
/// konsistent dieselbe Farbe über Sessions hinweg.
///
/// Kuratierte 12-Farb-Palette aus dem Hellion-Theme-Pool: alle saturiert
/// mid-bright, lesbar gegen Dark-Theme-Backgrounds. Bei realistischen
/// 1-5 parallelen Tells ist Kollisions-Wahrscheinlichkeit gering.
///
/// Reine String-Logik (kein Dalamud-Dep) — testbar im HellionChat.Tests-
/// Projekt das ohne Dalamud-Reference baut.
/// </summary>
internal static class AutoTellTabTint internal static class AutoTellTabTint
{ {
/// <summary> // Fallback for invalid input (empty name or world=0). White matches
/// Fallback bei ungültigem Input (leerer Name, World=0). Standard- // TextPrimary default so the sidebar stays visually consistent.
/// Text-Color (weiß) — passt mit existierendem TextPrimary-Default
/// zusammen, sodass die Sidebar visuell konsistent bleibt.
/// </summary>
public const uint Fallback = 0xFFFFFFFFu; public const uint Fallback = 0xFFFFFFFFu;
/// <summary> // 12 saturated mid-bright colors from the built-in theme pool, readable
/// 12 saturierte mid-bright Farben aus den 5 Built-In-Themes // on dark backgrounds. Collision risk is low at realistic 1-5 active tells.
/// (Hellion-Arctic, Chat2-Klassik, Event-Horizon, Moonlit-Bloom, // RGBA format, matching ColourUtil.RgbaToAbgr convention.
/// Mint-Grove). Reihenfolge ist deterministisch — Hash-Index wählt
/// Farbe per Modulo. RGBA-Format (passt zu ColourUtil.RgbaToAbgr-
/// Konvention im restlichen Code).
/// </summary>
public static readonly IReadOnlyList<uint> Palette = new uint[] public static readonly IReadOnlyList<uint> Palette = new uint[]
{ {
0x00BED2FFu, // Arctic Cyan 0x00BED2FFu, // Arctic Cyan
@@ -45,30 +28,19 @@ internal static class AutoTellTabTint
0xE85D04FFu, // Deep Ember 0xE85D04FFu, // Deep Ember
}; };
/// <summary>
/// Liefert eine konsistente Tint-Color für einen Tell-Partner.
/// Hash basiert auf "Name@World" — Cross-World-Namen kollidieren
/// nur bei Hash-Bucket-Kollision, nicht durch Identitäts-Annahme.
/// </summary>
public static uint For(string name, uint world) public static uint For(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return Fallback; return Fallback;
// GetHashCode kann negativ sein; Bitmaske auf positive Range // Mask to positive range so modulo always yields a valid index.
// damit Modulo-Division immer einen validen Index liefert.
var key = $"{name}@{world}"; var key = $"{name}@{world}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return Palette[(int)(hash % Palette.Count)]; return Palette[(int)(hash % Palette.Count)];
} }
/// <summary> // 7 visually distinct FA glyphs that make sense in a tell context.
/// Tell-spezifischer Icon-Pool. 7 visuell distinkte FontAwesome-Glyphen // Excludes cog/comment/users — those read as system or group tabs.
/// die im Tell-Kontext sinnvoll wirken (envelope = Tell-Default, star/
/// heart/bell = personalisiert, bookmark/flag/fire = markiert/wichtig).
/// Bewusst kein cog/comment/users — die wären für System-/Group-Tabs
/// reserviert und würden im Tell-Bereich verwirrend wirken.
/// </summary>
public static readonly IReadOnlyList<string> IconPool = new[] public static readonly IReadOnlyList<string> IconPool = new[]
{ {
"envelope", "envelope",
@@ -80,26 +52,17 @@ internal static class AutoTellTabTint
"fire", "fire",
}; };
/// <summary> // "envelope" matches the tell context better than the old hardcoded "clock".
/// Fallback-Icon bei ungültigem Input. "envelope" passt semantisch zum
/// Tell-Kontext besser als das alte hardcoded "clock".
/// </summary>
public const string IconFallback = "envelope"; public const string IconFallback = "envelope";
/// <summary>
/// Liefert ein konsistentes Icon-Glyph für einen Tell-Partner.
/// Nutzt einen anderen Hash-Bias als For() (Color), damit Icon und
/// Color unabhängig variieren — gibt 7 × 12 = 84 distinct Combinations.
/// </summary>
public static string IconFor(string name, uint world) public static string IconFor(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return IconFallback; return IconFallback;
// Anderer Hash-Bias als For() (verschiedene Modulo-Basis): wir // Reversed key ("world@name") gives icon and color independent variation
// nutzen "world@name" statt "name@world" damit Icon und Color // so the same tell partner doesn't always get the same color+icon pair.
// nicht synchron variieren. Ohne Bias-Trennung würden alle Tells // 7 icons x 12 colors = 84 distinct combinations.
// mit derselben Color auch dasselbe Icon haben.
var key = $"{world}@{name}"; var key = $"{world}@{name}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return IconPool[(int)(hash % IconPool.Count)]; return IconPool[(int)(hash % IconPool.Count)];
+23 -48
View File
@@ -8,16 +8,10 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Hellion Chat — v0.6.0 input bar component for pop-out windows. // Input bar component for pop-out windows. Render() is a stub — the main
// // window input layer stays in ChatLogWindow to avoid a high-risk extract.
// Pragmatischer Refactor-Scope: Render() ist ein leerer Marker-Stub für // RenderCompact() is the only v0.6.0 deliverable; Render() can be filled
// das Hauptfenster — der bestehende Input-Layer in ChatLogWindow bleibt // in a later cycle if needed.
// unangetastet, weil ein 400-Zeilen-Extract aus einem 1926-Zeilen-File
// das v0.6.0-Risiko unverhältnismäßig erhöhen würde. Pop-Outs nutzen
// ausschließlich RenderCompact(), das ist der ganze v0.6.0-Mehrwert.
// Sollte das Hauptfenster selber später eine Compact-Variante brauchen
// (oder das große Extract sich aus anderem Grund lohnen), kann Render()
// in einem späteren Cycle gefüllt werden.
public sealed class ChatInputBar public sealed class ChatInputBar
{ {
private readonly Plugin _plugin; private readonly Plugin _plugin;
@@ -35,22 +29,17 @@ public sealed class ChatInputBar
public InputState State => _state; public InputState State => _state;
public bool IsFocused { get; private set; } public bool IsFocused { get; private set; }
// Stub. v0.6.0 belässt den Hauptfenster-Input wie er ist. // Stub — main window input is handled in ChatLogWindow.
public void Render() { } public void Render() { }
// Compact rendering for pop-out windows. // Compact layout for pop-out windows: channel icon button left, text
// input right. Auto-translate is intentionally excluded — the upstream
// popup isn't instanciable per window without a larger refactor, and
// typical pop-out use cases rarely need it. Can be added later if
// tester feedback warrants it.
// //
// v0.6.0 Compact-Layout: Channel-Icon-Button links (Background-Farbe // Channel switching is global via Plugin.Functions.Chat (FFXIV API).
// aus ChatColours), Text-Input rechts daneben. Auto-Translate-Picker // Text buffer and history cursor are independent per pop-out.
// ist bewusst NICHT im Compact-Mode (Spec-Abweichung Layout D → A).
// Rechtfertigung: das Hauptfenster-Auto-Complete-Popup ist nicht ohne
// grossen Refactor pro Window instanzierbar; typische Pop-Out-Use-Cases
// (FC-Greeter, Club-Hostess) brauchen Auto-Translate selten dort.
// Eigene Compact-Auto-Complete-Implementation kann ein späterer
// Cycle nachreichen wenn Tester-Feedback das verlangt.
//
// Channel-Switch wirkt via Plugin.Functions.Chat global (FFXIV-API).
// Pro Pop-Out unabhängig bleiben Text-Buffer und History-Cursor.
public void RenderCompact() public void RenderCompact()
{ {
var tab = _activeTabAccessor(); var tab = _activeTabAccessor();
@@ -64,18 +53,15 @@ public sealed class ChatInputBar
private void DrawCompactInput(Tab tab) private void DrawCompactInput(Tab tab)
{ {
// Input takes the whole remaining width — no auto-translate button
// reserved on the right side in v0.6.0 (see RenderCompact comment).
var inputWidth = ImGui.GetContentRegionAvail().X; var inputWidth = ImGui.GetContentRegionAvail().X;
if (inputWidth < 60f) if (inputWidth < 60f)
inputWidth = 60f; inputWidth = 60f;
ImGui.SetNextItemWidth(inputWidth); ImGui.SetNextItemWidth(inputWidth);
// CallbackHistory wires up Up/Down navigation against the shared // CallbackHistory wires Up/Down navigation to InputHistoryService.
// InputHistoryService. Submit is detected the same way the main // Submit detected via IsItemDeactivated + Enter, not EnterReturnsTrue
// window does it: via IsItemDeactivated + Enter, NOT EnterReturnsTrue // (matches ChatLogWindow behavior).
// (matching v0.5.x ChatLogWindow.cs behavior).
const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory; const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory;
ImGui.InputText( ImGui.InputText(
$"##chat-compact-input-{tab.Identifier}", $"##chat-compact-input-{tab.Identifier}",
@@ -100,9 +86,8 @@ public sealed class ChatInputBar
private void SubmitCompact(Tab tab) => private void SubmitCompact(Tab tab) =>
CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal); CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal);
// History-navigation callback for the compact input. Cursor math is // History navigation callback. Cursor math delegated to
// delegated to CompactInputHistoryNavigator; only the ImGui buffer // CompactInputHistoryNavigator; ImGui buffer splice stays here.
// splice stays here because it needs the live callback data.
// TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs // TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs
private int CompactCallback(scoped ref ImGuiInputTextCallbackData data) private int CompactCallback(scoped ref ImGuiInputTextCallbackData data)
{ {
@@ -148,7 +133,7 @@ public sealed class ChatInputBar
var v3 = ColourUtil.RgbaToVector3(rgba); var v3 = ColourUtil.RgbaToVector3(rgba);
var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f); var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f);
// Compute readable foreground — black on bright, white on dark // Black foreground on bright backgrounds, white on dark.
var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z; var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z;
var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f); var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f);
@@ -160,8 +145,7 @@ public sealed class ChatInputBar
using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg))
using (ImRaii.PushColor(ImGuiCol.Text, fg)) using (ImRaii.PushColor(ImGuiCol.Text, fg))
{ {
// Single-letter glyph derived from the channel — quick visual cue // Single-letter glyph as a quick visual cue until a proper icon font lands.
// until we have a proper icon font available in the compact bar.
var label = ChannelGlyph(inputType); var label = ChannelGlyph(inputType);
if ( if (
ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize)) ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize))
@@ -171,13 +155,9 @@ public sealed class ChatInputBar
} }
if (tab.Channel is not null && ImGui.IsItemHovered()) if (tab.Channel is not null && ImGui.IsItemHovered())
{
ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled); ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled);
}
else if (ImGui.IsItemHovered()) else if (ImGui.IsItemHovered())
{
ImGui.SetTooltip(inputType.Name()); ImGui.SetTooltip(inputType.Name());
}
using (var popup = ImRaii.Popup(popupId)) using (var popup = ImRaii.Popup(popupId))
{ {
@@ -221,17 +201,12 @@ public sealed class ChatInputBar
_ => "?", _ => "?",
}; };
// Forwards a tab-cycle keybind delta to the host so all windows // Forwards a tab-cycle keybind delta to the host (single source of truth).
// navigate the same active-tab pointer (single source of truth). public void HandleKeybindForward(int delta) => _host.ChangeTabDelta(delta);
public void HandleKeybindForward(int delta)
{
_host.ChangeTabDelta(delta);
}
} }
// Per-window input state. Each ChatInputBar instance owns one of these // Per-window input state. Each ChatInputBar owns one so pop-outs and the
// so pop-outs and the main window keep independent buffers and channels // main window keep independent buffers and history cursors.
// (State-Sync-Entscheidung A in the v0.6.0 spec).
public sealed class InputState public sealed class InputState
{ {
public string Buffer = string.Empty; public string Buffer = string.Empty;
File diff suppressed because it is too large Load Diff
+80 -28
View File
@@ -2,6 +2,7 @@
using System.Globalization; using System.Globalization;
using System.Numerics; using System.Numerics;
using System.Text; using System.Text;
using System.Threading;
using Dalamud.Bindings.ImGui; using Dalamud.Bindings.ImGui;
using Dalamud.Game.Text.SeStringHandling.Payloads; using Dalamud.Game.Text.SeStringHandling.Payloads;
using Dalamud.Interface; using Dalamud.Interface;
@@ -16,6 +17,7 @@ using HellionChat.Resources;
using HellionChat.Util; using HellionChat.Util;
using Lumina.Data.Files; using Lumina.Data.Files;
using Lumina.Text.ReadOnly; using Lumina.Text.ReadOnly;
using Microsoft.Extensions.Logging;
using MoreLinq; using MoreLinq;
namespace HellionChat.Ui; namespace HellionChat.Ui;
@@ -33,11 +35,21 @@ public class DbViewer : Window
private int CurrentPage = 1; private int CurrentPage = 1;
private string SimpleSearchTerm = ""; private string SimpleSearchTerm = "";
// v1.4.8 H2: opt-in full-text search across the whole DB via FTS5.
// Transient UI state (per-session), not persisted -- users opt in fresh
// every time so they always see the page-filter as the default mode.
private bool UseFullTextSearch;
private bool OnlyCurrentCharacter = true; private bool OnlyCurrentCharacter = true;
private readonly Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels; private readonly Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels;
private bool IsProcessing; private bool IsProcessing;
private long ProcessingStart = Environment.TickCount64; private long ProcessingStart = Environment.TickCount64;
// Bumped per trigger so a late worker drops itself instead of overwriting
// a newer result.
private long _ftsFilterSeq;
private (DateTime Min, DateTime Max, int Page, bool Local, int ChannelCount) LastProcessed; private (DateTime Min, DateTime Max, int Page, bool Local, int ChannelCount) LastProcessed;
private string MinDateString = ""; private string MinDateString = "";
@@ -56,10 +68,13 @@ public class DbViewer : Window
private bool NeedsScrollReset; private bool NeedsScrollReset;
public DbViewer(Plugin plugin) private readonly ILogger<DbViewer> _logger;
public DbViewer(Plugin plugin, ILogger<DbViewer> logger)
: base("DBViewer###chat2-dbviewer") : base("DBViewer###chat2-dbviewer")
{ {
Plugin = plugin; Plugin = plugin;
_logger = logger;
SelectedChannels = TabsUtil.MostlyPlayer; SelectedChannels = TabsUtil.MostlyPlayer;
DateFormat = CultureInfo.CurrentCulture.DateTimeFormat.ShortDatePattern; DateFormat = CultureInfo.CurrentCulture.DateTimeFormat.ShortDatePattern;
@@ -82,29 +97,13 @@ public class DbViewer : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin
.Commands.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin // Slash-command tear-down moved to Plugin.TearDownCommands.
.Commands.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute -= Toggle;
} }
private void Toggle(string _, string __) => Toggle();
public override void Draw() public override void Draw()
{ {
var totalPages = (int)Math.Ceiling((double)Count / RowPerPage); var totalPages = (int)Math.Ceiling((double)Count / RowPerPage);
@@ -211,13 +210,6 @@ public class DbViewer : Window
if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled)) if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled))
ImGui.SetTooltip(Language.Export_Txt_Tooltip); ImGui.SetTooltip(Language.Export_Txt_Tooltip);
// Hellion Chat: the JSON export button used to dump the database in
// the upstream webinterface's wire format. With the webinterface
// removed there is no consumer for that format any more, so the
// button is dropped. The Privacy tab's MessageExporter covers the
// same ground (Markdown / JSON / CSV) with channel and date filters
// and is the supported way to get history out of the plugin.
var width = 350 * ImGuiHelpers.GlobalScale; var width = 350 * ImGuiHelpers.GlobalScale;
var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64; var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64;
@@ -240,6 +232,24 @@ public class DbViewer : Window
tooltipRight: Language.Page_ArrowRight_Tooltip tooltipRight: Language.Page_ArrowRight_Tooltip
); );
// Full-text search toggle (v1.4.8 H2). IsFtsIndexBuilt is a cached
// volatile bool in MessageStore -- single field read per frame, no
// SELECT count(*). ImRaii.Disabled blocks any click while the index
// is still being built, so no defensive force-off branch needed
// inside the if-body. UseFullTextSearch is transient UI state, so we
// do not call SaveConfig here.
var ftsReady = Plugin.MessageManager.Store.IsFtsIndexBuilt;
using (ImRaii.Disabled(!ftsReady))
{
if (ImGui.Checkbox(HellionStrings.DbViewer_FullTextToggle, ref UseFullTextSearch))
TriggerFilterRefresh();
}
ImGuiUtil.HelpMarker(
ftsReady
? HellionStrings.DbViewer_FullTextToggle_Hint_PhraseMode
: HellionStrings.DbViewer_FullTextToggle_Hint_Indexing
);
ImGui.SameLine(ImGui.GetContentRegionMax().X - width); ImGui.SameLine(ImGui.GetContentRegionMax().X - width);
ImGui.SetNextItemWidth(width); ImGui.SetNextItemWidth(width);
if ( if (
@@ -250,7 +260,7 @@ public class DbViewer : Window
30 30
) )
) )
Filtered = Filter(Messages); TriggerFilterRefresh();
// Third row // Third row
@@ -314,7 +324,7 @@ public class DbViewer : Window
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Failed reading messages from database"); _logger.LogError(ex, "Failed reading messages from database");
} }
finally finally
{ {
@@ -454,11 +464,53 @@ public class DbViewer : Window
} }
} }
// FTS path hits SQLite per keystroke -- dispatch to a worker, drop stale
// results via _ftsFilterSeq. Page-filter path is in-memory LINQ, stays
// inline.
private void TriggerFilterRefresh()
{
if (!UseFullTextSearch || !Plugin.MessageManager.Store.IsFtsIndexBuilt)
{
Filtered = Filter(Messages);
return;
}
var snapshot = Messages;
var mySeq = Interlocked.Increment(ref _ftsFilterSeq);
Task.Run(() =>
{
try
{
var result = Filter(snapshot);
if (Interlocked.Read(ref _ftsFilterSeq) == mySeq)
Filtered = result;
}
catch (Exception ex)
{
_logger.LogError(ex, "FTS filter worker failed");
}
});
}
private ConcurrentStack<Message> Filter(Message[] messages) private ConcurrentStack<Message> Filter(Message[] messages)
{ {
if (SimpleSearchTerm == "") if (SimpleSearchTerm == "")
return new ConcurrentStack<Message>(messages.Reverse().OrderByDescending(m => m.Date)); return new ConcurrentStack<Message>(messages.Reverse().OrderByDescending(m => m.Date));
// Full-text mode bypasses the page-bounded messages array and queries
// the FTS5 index across the whole DB. IsFtsIndexBuilt re-check guards
// against the (rare) case of the toggle being on while the index is
// mid-rebuild -- ImRaii.Disabled prevents the user from flipping it,
// but a Dispose-and-reopen during indexing could leave UseFullTextSearch
// true while ftsReady flipped back to false; the local fallback below
// still serves the page.
if (UseFullTextSearch && Plugin.MessageManager.Store.IsFtsIndexBuilt)
{
var guidHits = Plugin.MessageManager.Store.FullTextSearch(SimpleSearchTerm);
var resolved = Plugin.MessageManager.Store.LoadByGuids(guidHits);
return new ConcurrentStack<Message>(resolved.OrderByDescending(m => m.Date));
}
return new ConcurrentStack<Message>( return new ConcurrentStack<Message>(
messages messages
.Reverse() .Reverse()
@@ -577,7 +629,7 @@ public class DbViewer : Window
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Failed creating txt backup"); _logger.LogError(ex, "Failed creating txt backup");
Notification.Content = "Error ..."; Notification.Content = "Error ...";
Notification.Type = NotificationType.Error; Notification.Type = NotificationType.Error;
+1 -5
View File
@@ -28,17 +28,13 @@ public class DebuggerWindow : Window, IDisposable
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute -= Toggle; // Slash-command tear-down moved to Plugin.TearDownCommands.
} }
private void Toggle(string _, string __) => Toggle();
public override unsafe void Draw() public override unsafe void Draw()
{ {
var agent = (nint)AgentItemDetail.Instance(); var agent = (nint)AgentItemDetail.Instance();
+24 -9
View File
@@ -30,14 +30,10 @@ public sealed class FirstRunWizard : Window
public override void OnClose() public override void OnClose()
{ {
// Closing the wizard without picking anything = the user accepts // OnClose fires on explicit X-click and on plugin dispose. We never
// whatever defaults are already in place. Mark as complete so we // implicitly accept the defaults here — the explicit "Later" button
// don't pester them again on the next launch. // does that. If the user hasn't picked a profile yet, the wizard
if (!Plugin.Config.FirstRunCompleted) // reopens on the next plugin load.
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
}
} }
public override void Draw() public override void Draw()
@@ -49,7 +45,12 @@ public sealed class FirstRunWizard : Window
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f; var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f;
var cardHeight = avail.Y - ImGui.GetTextLineHeightWithSpacing(); // Reserve room for the footer separator + cancel button below the cards.
var footerReserve =
ImGui.GetStyle().ItemSpacing.Y * 3
+ ImGui.GetTextLineHeight()
+ ImGui.GetFrameHeightWithSpacing();
var cardHeight = avail.Y - footerReserve;
DrawCard( DrawCard(
"privacy-first", "privacy-first",
@@ -87,6 +88,20 @@ public sealed class FirstRunWizard : Window
HellionStrings.Wizard_Profile_FullHistory_Apply, HellionStrings.Wizard_Profile_FullHistory_Apply,
ApplyFullHistory ApplyFullHistory
); );
ImGui.Spacing();
ImGui.Separator();
ImGui.Spacing();
if (ImGui.Button(HellionStrings.Wizard_Cancel_Label))
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
IsOpen = false;
}
if (ImGui.IsItemHovered())
ImGuiUtil.Tooltip(HellionStrings.Wizard_Cancel_Tooltip);
} }
private void DrawCard( private void DrawCard(
+12 -30
View File
@@ -5,18 +5,12 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
/// <summary> // Theme-driven ImGui style override. PushGlobal is pushed once per frame
/// ImGui style override for Hellion Chat. v1.1.0 ist die Engine // in Plugin.Draw and drives every Hellion-rendered window.
/// theme-getrieben: PushGlobal nimmt eine Theme-Instance + Window-
/// Opacity, die gesamten Color- und Style-Slots werden aus dem Theme
/// gelesen statt aus einer fixen Konstanten-Tabelle.
/// </summary>
internal static class HellionStyle internal static class HellionStyle
{ {
/// <summary> // Local color stack for the active theme. Use inside a
/// Local color stack auf Basis des aktiven Themes. Cheap. Use inside a // `using var _ = HellionStyle.Push(theme);` block.
/// `using var _ = HellionStyle.Push(theme);` block.
/// </summary>
internal static IDisposable Push(Theme theme) internal static IDisposable Push(Theme theme)
{ {
var a = theme.AbgrCache; var a = theme.AbgrCache;
@@ -37,13 +31,8 @@ internal static class HellionStyle
return stack; return stack;
} }
/// <summary> // Global color and style stack pushed once per frame.
/// Global color and style-variable stack pushed once per frame in // windowOpacity: window background alpha (0.5-1.0).
/// Plugin.Draw. Drives every Hellion-rendered window from the active
/// theme's palette and layout values.
/// </summary>
/// <param name="theme">Active theme from ThemeRegistry.</param>
/// <param name="windowOpacity">Window background alpha (0.51.0).</param>
internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f) internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f)
{ {
var c = theme.Colors; var c = theme.Colors;
@@ -54,17 +43,10 @@ internal static class HellionStyle
var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF); var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF);
var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte; var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte;
// ChildBg-Alpha: Sub-Bereiche (Tab-Sidebar, Message-Area, Input-Bar) // ChildBg alpha resolution lives in HellionStyleHelpers so the
// werden im ChatLog-Window als BeginChild gezeichnet. Würde der ChildBg // threshold logic can be covered by a pure-helper test in the
// mit dem gleichen Alpha wie WindowBg gerendert, multiplizieren sich // build suite.
// die Layer (1 - (1-α)² Deckung), und 50 % WindowOpacity kommt mit var childBgWithAlpha = HellionStyleHelpers.ResolveChildBgAlpha(c.ChildBg, windowOpacity);
// 75 % Deckung im Child-Bereich an — das Fenster wirkt solider als der
// Slider verspricht. Bei voller Opacity bleibt der Theme-Akzent
// erhalten (Theme-eigene Alpha-Komponente, i.d.R. FF); sobald der User
// Transparenz zieht, wird ChildBg vollständig durchsichtig damit nur
// der WindowBg-Layer die finale Deckung bestimmt.
var childBgAlpha = windowOpacity >= 0.999f ? (c.ChildBg & 0xFFu) : 0u;
var childBgWithAlpha = (c.ChildBg & 0xFFFFFF00u) | childBgAlpha;
// Layout // Layout
stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding); stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding);
@@ -77,8 +59,8 @@ internal static class HellionStyle
stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize); stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize);
stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize); stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize);
// Surfaces — WindowBg/ChildBg use the per-push opacity-modulated value, // Surfaces — WindowBg/ChildBg use opacity-modulated values (RGBA path);
// so they go through the RGBA path; everything else reads from cache. // everything else reads from the pre-computed ABGR cache.
stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha); stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha);
stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha); stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha);
stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg); stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg);
+17
View File
@@ -0,0 +1,17 @@
namespace HellionChat.Ui;
internal static class HellionStyleHelpers
{
// Child surfaces are drawn over WindowBg, so at partial window opacity
// the theme's own ChildBg alpha would double-multiply and read too solid.
// Above ~full opacity we preserve the theme alpha; below it we wipe to 0
// so WindowBg alone carries the coverage. The 0.999f threshold is a
// float-imprecision guard around the user-facing 100% slider value.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/HellionStyleHelpersTests.cs
public static uint ResolveChildBgAlpha(uint themeChildBgRgba, float windowOpacity)
{
var alphaPreserved = windowOpacity >= 0.999f;
var childBgAlpha = alphaPreserved ? (themeChildBgRgba & 0xFFu) : 0u;
return (themeChildBgRgba & 0xFFFFFF00u) | childBgAlpha;
}
}
+27 -59
View File
@@ -3,6 +3,7 @@ using Dalamud.Bindings.ImGui;
using Dalamud.Interface.Style; using Dalamud.Interface.Style;
using Dalamud.Interface.Utility.Raii; using Dalamud.Interface.Utility.Raii;
using Dalamud.Interface.Windowing; using Dalamud.Interface.Windowing;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ui; namespace HellionChat.Ui;
@@ -11,28 +12,26 @@ internal class Popout : Window
private readonly ChatLogWindow ChatLogWindow; private readonly ChatLogWindow ChatLogWindow;
private readonly Tab Tab; private readonly Tab Tab;
private readonly int Idx; private readonly int Idx;
private readonly ILogger<Popout> _logger;
private long FrameTime; // set every frame private long FrameTime;
private long LastActivityTime = Environment.TickCount64; private long LastActivityTime = Environment.TickCount64;
// v0.6.0 — optional input bar inside the pop-out window. Lazy-allocated // Optional input bar inside the pop-out. Lazy-allocated when enabled,
// when the user enables Tab.PopOutInputEnabled and torn down when the // torn down on toggle-off (buffer discarded intentionally).
// toggle is turned off (independent text buffer is intentionally
// discarded — see v0.6.0 spec edge-case P1).
public ChatInputBar? InputBar { get; private set; } public ChatInputBar? InputBar { get; private set; }
public bool HasFocusedInputBar => InputBar?.IsFocused ?? false; public bool HasFocusedInputBar => InputBar?.IsFocused ?? false;
// Hellion Chat — v0.6.1 expose just the tab identifier (not the whole Tab // Exposed so AutoTellTabsService can locate this window during LRU eviction.
// reference) so AutoTellTabsService.DropOldestTempTab can locate the
// matching pop-out window when an LRU temp tab gets evicted.
internal Guid TabIdentifier => Tab.Identifier; internal Guid TabIdentifier => Tab.Identifier;
public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx) public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx, ILogger<Popout> logger)
: base($"{tab.Name}##popout") : base($"{tab.Name}##popout")
{ {
ChatLogWindow = chatLogWindow; ChatLogWindow = chatLogWindow;
Tab = tab; Tab = tab;
Idx = idx; Idx = idx;
_logger = logger;
Size = new Vector2(350, 350); Size = new Vector2(350, 350);
SizeCondition = ImGuiCond.FirstUseEver; SizeCondition = ImGuiCond.FirstUseEver;
@@ -40,12 +39,9 @@ internal class Popout : Window
IsOpen = true; IsOpen = true;
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
// v1.2.1 — KEIN AllowBackgroundBlur. Pop-Outs werden vom User häufig // AllowBackgroundBlur is intentionally off: Dalamud blurs the entire
// im Dalamud-Tab-Container mit anderen Plugin-Windows kombiniert; in // tab container, not just this window, which would affect adjacent plugins.
// dem Render-Pfad blurt Dalamud den gesamten Container, nicht nur // Users can enable blur per-window via the Dalamud hamburger menu.
// das Pop-Out — würde die Tab-Bar oben und benachbarte Plugins
// mitziehen. Wer Blur in Pop-Outs will, kann ihn via Dalamud-
// Hamburger-Menü pro Window selbst aktivieren.
} }
public override void PreOpenCheck() public override void PreOpenCheck()
@@ -70,7 +66,6 @@ internal class Popout : Window
return true; return true;
} }
// Activity in the tab, this popout window, or the main chat log window.
var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime); var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime);
lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime); lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime);
return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout; return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout;
@@ -78,10 +73,8 @@ internal class Popout : Window
public override void PreDraw() public override void PreDraw()
{ {
// Hellion Chat v1.1.0+ — Theme-Engine ist Source-of-Truth, kein // Theme engine pushes the active theme globally in Plugin.Draw;
// zusätzlicher Dalamud-StyleModel-Override mehr pro Window. Plugin.Draw // pop-outs draw consistently without per-window overrides.
// pusht das aktive Hellion-Theme global; Pop-Out zeichnet sich damit
// konsistent zum Haupt-Chat-Window.
Flags = ImGuiWindowFlags.None; Flags = ImGuiWindowFlags.None;
if (!Plugin.Config.ShowPopOutTitleBar) if (!Plugin.Config.ShowPopOutTitleBar)
Flags |= ImGuiWindowFlags.NoTitleBar; Flags |= ImGuiWindowFlags.NoTitleBar;
@@ -92,19 +85,10 @@ internal class Popout : Window
if (!Tab.CanResize) if (!Tab.CanResize)
Flags |= ImGuiWindowFlags.NoResize; Flags |= ImGuiWindowFlags.NoResize;
// Idx may point past the end if PopOutDocked was resized (e.g., a tab // Guard against Idx pointing past the end if PopOutDocked was resized mid-frame.
// dropped) between the AddPopOutsToDraw() snapshot and this frame.
// Guard the read so we don't index into stale state.
if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx]) if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx])
{ {
if (Tab.IndependentOpacity) BgAlpha = Tab.IndependentOpacity ? Tab.Opacity / 100f : Plugin.Config.WindowOpacity;
{
BgAlpha = Tab.Opacity / 100f;
}
else
{
BgAlpha = Plugin.Config.WindowOpacity;
}
} }
} }
@@ -118,24 +102,15 @@ internal class Popout : Window
ImGui.Separator(); ImGui.Separator();
} }
// v0.6.0 — one-time hint banner explaining the new pop-out input
// feature. Shown once per user; "Got it" or "Open settings"
// dismisses it and persists the flag.
var hintBannerHeight = DrawHintBannerIfNeeded(); var hintBannerHeight = DrawHintBannerIfNeeded();
// v0.6.0 — pop-out optional input bar. Reserve height first so the // Toggle-OFF resets InputBar so the next toggle-ON starts with a fresh buffer.
// message log draws into the right region; only shown when the
// global master switch is on. Toggle-OFF resets InputBar so the
// next toggle-ON gives a fresh buffer (no stale text persists).
var inputEnabled = Plugin.Config.PopOutInputEnabled; var inputEnabled = Plugin.Config.PopOutInputEnabled;
if (!inputEnabled && InputBar != null) if (!inputEnabled && InputBar != null)
{
InputBar = null; InputBar = null;
}
if (inputEnabled) if (inputEnabled)
{
InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab); InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab);
}
var inputBarHeight = inputEnabled var inputBarHeight = inputEnabled
? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y ? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y
@@ -155,8 +130,7 @@ internal class Popout : Window
LastActivityTime = FrameTime; LastActivityTime = FrameTime;
} }
// Returns the vertical space the banner consumed (0 when not shown) // Returns the vertical space consumed by the banner (0 when not shown).
// so the message log can shrink accordingly.
private float DrawHintBannerIfNeeded() private float DrawHintBannerIfNeeded()
{ {
if (Plugin.Config.SeenPopOutInputHint) if (Plugin.Config.SeenPopOutInputHint)
@@ -204,7 +178,7 @@ internal class Popout : Window
{ {
Plugin.Config.SeenPopOutInputHint = true; Plugin.Config.SeenPopOutInputHint = true;
ChatLogWindow.Plugin.SaveConfig(); ChatLogWindow.Plugin.SaveConfig();
Plugin.Log.Debug("Pop-Out input hint dismissed"); _logger.LogDebug("Pop-Out input hint dismissed");
if (openSettings) if (openSettings)
ChatLogWindow.Plugin.SettingsWindow.Toggle(); ChatLogWindow.Plugin.SettingsWindow.Toggle();
} }
@@ -240,21 +214,18 @@ internal class Popout : Window
private bool HideStateCheck() private bool HideStateCheck()
{ {
// if the chat has no hide state set, and the player has entered battle, we hide chat if they have configured it
if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle) if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle)
{ {
CurrentHideState = HideState.Battle; CurrentHideState = HideState.Battle;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Battle"); _logger.LogTrace($"Popout HideState [{Tab.Name}]: None -> Battle");
} }
// If the chat is hidden because of battle, we reset it here
if (CurrentHideState is HideState.Battle && !Plugin.InBattle) if (CurrentHideState is HideState.Battle && !Plugin.InBattle)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: Battle None"); _logger.LogTrace($"Popout HideState [{Tab.Name}]: Battle -> None");
} }
// if the chat has no hide state and in a cutscene, set the hide state to cutscene
if ( if (
Tab.HideDuringCutscenes Tab.HideDuringCutscenes
&& CurrentHideState == HideState.None && CurrentHideState == HideState.None
@@ -264,37 +235,34 @@ internal class Popout : Window
if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags()) if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags())
{ {
CurrentHideState = HideState.Cutscene; CurrentHideState = HideState.Cutscene;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Cutscene"); _logger.LogTrace($"Popout HideState [{Tab.Name}]: None -> Cutscene");
} }
} }
// if the chat is hidden because of a cutscene and no longer in a cutscene, set the hide state to none
if ( if (
CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride
&& !Plugin.CutsceneActive && !Plugin.CutsceneActive
&& !Plugin.GposeActive && !Plugin.GposeActive
) )
{ {
Plugin.Log.Verbose( _logger.LogTrace(
$"Popout HideState [{Tab.Name}]: {CurrentHideState} None (cutscene/gpose ended)" $"Popout HideState [{Tab.Name}]: {CurrentHideState} -> None (cutscene/gpose ended)"
); );
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
} }
// if the chat is hidden because of a cutscene and the chat has been activated, show chat
if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate) if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.CutsceneOverride; CurrentHideState = HideState.CutsceneOverride;
Plugin.Log.Verbose( _logger.LogTrace(
$"Popout HideState [{Tab.Name}]: Cutscene CutsceneOverride (user activate)" $"Popout HideState [{Tab.Name}]: Cutscene -> CutsceneOverride (user activate)"
); );
} }
// if the user hid the chat and is now activating chat, reset the hide state
if (CurrentHideState == HideState.User && ChatLogWindow.Activate) if (CurrentHideState == HideState.User && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: User None (activate)"); _logger.LogTrace($"Popout HideState [{Tab.Name}]: User -> None (activate)");
} }
return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle
+1 -9
View File
@@ -29,21 +29,13 @@ public class SeStringDebugger : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
#if DEBUG
Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute += Toggle;
#endif
} }
public void Dispose() public void Dispose()
{ {
#if DEBUG // Slash-command tear-down moved to Plugin.TearDownCommands.
Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute -= Toggle;
#endif
} }
private void Toggle(string _, string __) => Toggle();
public override void Draw() public override void Draw()
{ {
if (Plugin.MessageManager.LastMessage.Sender == null) if (Plugin.MessageManager.LastMessage.Sender == null)
+28 -63
View File
@@ -6,6 +6,7 @@ using Dalamud.Utility;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Ui.SettingsTabs; using HellionChat.Ui.SettingsTabs;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ui; namespace HellionChat.Ui;
@@ -25,7 +26,7 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
private SettingsView View = SettingsView.Overview; private SettingsView View = SettingsView.Overview;
private readonly SettingsOverview Overview; private readonly SettingsOverview Overview;
internal SettingsWindow(Plugin plugin) internal SettingsWindow(Plugin plugin, ILoggerFactory loggerFactory)
: base($"{Language.Settings_Title.Format(Plugin.PluginName)}###chat2-settings") : base($"{Language.Settings_Title.Format(Plugin.PluginName)}###chat2-settings")
{ {
Flags = ImGuiWindowFlags.NoScrollbar | ImGuiWindowFlags.NoScrollWithMouse; Flags = ImGuiWindowFlags.NoScrollbar | ImGuiWindowFlags.NoScrollWithMouse;
@@ -45,13 +46,13 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
Tabs = Tabs =
[ [
new General(Plugin, Mutable), new General(Plugin, Mutable),
new ThemeAndLayout(Plugin, Mutable), new ThemeAndLayout(Plugin, Mutable, loggerFactory.CreateLogger<ThemeAndLayout>()),
new FontsAndColours(Plugin, Mutable), new FontsAndColours(Plugin, Mutable, loggerFactory.CreateLogger<FontsAndColours>()),
new SettingsTabs.Window(Plugin, Mutable), new SettingsTabs.Window(Plugin, Mutable),
new Chat(Plugin, Mutable), new Chat(Plugin, Mutable),
new SettingsTabs.Tabs(Plugin, Mutable), new SettingsTabs.Tabs(Plugin, Mutable),
new SettingsTabs.Privacy(Plugin, Mutable), new SettingsTabs.Privacy(Plugin, Mutable),
new DataManagement(Plugin, Mutable), new DataManagement(Plugin, Mutable, loggerFactory.CreateLogger<DataManagement>()),
new SettingsTabs.Integrations(Plugin, Mutable), new SettingsTabs.Integrations(Plugin, Mutable),
new Information(Mutable), new Information(Mutable),
]; ];
@@ -60,23 +61,11 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
DisableWindowSounds = true; DisableWindowSounds = true;
Initialise(); Initialise();
Plugin
.Commands.Register("/hellion", "Perform various actions with Hellion Chat.")
.Execute += Command;
Plugin.Interface.UiBuilder.OpenConfigUi += Toggle;
} }
public void Dispose() public void Dispose()
{ {
Plugin.Interface.UiBuilder.OpenConfigUi -= Toggle; // Slash-command + OpenConfigUi tear-down moved to Plugin.TearDownCommands.
Plugin.Commands.Register("/hellion").Execute -= Command;
}
private void Command(string command, string args)
{
if (string.IsNullOrWhiteSpace(args))
Toggle();
} }
private void Initialise() private void Initialise()
@@ -92,10 +81,8 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
View = SettingsView.Overview; View = SettingsView.Overview;
} }
// ESC im Detail-View kehrt zur Overview zurück. Window-Focus-Check ist // ESC in Detail view returns to Overview. Window focus check is
// Pflicht — sonst triggert ESC auch wenn der User ein anderes Fenster // required so ESC doesn't fire when the user targets a different window.
// fokussiert hat und ESC fürs Game-Menü drückt (Codebase-Pattern siehe
// Util/SearchSelector.cs:37).
if ( if (
View == SettingsView.Detail View == SettingsView.Detail
&& ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows) && ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows)
@@ -128,13 +115,13 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
private void DrawDetail() private void DrawDetail()
{ {
// Breadcrumb-Header — Akzent-Cyan, klickbar, führt zurück zur Overview // Breadcrumb header -- accent cyan, clickable, returns to Overview.
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u))
using (ImRaii.PushColor(ImGuiCol.Button, 0u)) using (ImRaii.PushColor(ImGuiCol.Button, 0u))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu))
{ {
if (ImGui.SmallButton(" Settings")) if (ImGui.SmallButton("<- Settings"))
{ {
View = SettingsView.Overview; View = SettingsView.Overview;
return; return;
@@ -149,11 +136,8 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Section-Content in voller Breite. Die Tab-Liste links ist überholt: // Section content fills full width. Navigation back to another
// der User ist bereits über die Card-Übersicht navigiert, eine zweite // section goes via the breadcrumb or ESC.
// Tab-Liste daneben würde nur den Vanilla-Look zurückbringen. Falls
// der User in eine andere Section will, geht er zurück zur Overview
// (Breadcrumb / ESC).
var style = ImGui.GetStyle(); var style = ImGui.GetStyle();
var height = var height =
ImGui.GetContentRegionAvail().Y ImGui.GetContentRegionAvail().Y
@@ -182,9 +166,7 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(Language.Settings_Discard)) if (ImGui.Button(Language.Settings_Discard))
{
IsOpen = false; IsOpen = false;
}
const string buttonLabel = "Anna's Ko-fi"; const string buttonLabel = "Anna's Ko-fi";
const string buttonLabel2 = "Infi's Ko-fi"; const string buttonLabel2 = "Infi's Ko-fi";
@@ -206,18 +188,17 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
); );
if (ImGui.Button(buttonLabel2)) if (ImGui.Button(buttonLabel2))
Dalamud.Utility.Util.OpenLink("https://ko-fi.com/infiii"); Plugin.PlatformUtil.OpenLink("https://ko-fi.com/infiii");
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(buttonLabel)) if (ImGui.Button(buttonLabel))
Dalamud.Utility.Util.OpenLink("https://ko-fi.com/lojewalo"); Plugin.PlatformUtil.OpenLink("https://ko-fi.com/lojewalo");
} }
if (!save) if (!save)
return; return;
// calculate all conditions before updating config
var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat; var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat;
var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride; var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride;
var fontChanged = var fontChanged =
@@ -230,18 +211,16 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001 Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001
|| Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001; || Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001;
var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled; var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled;
// v1.2.0 — Refilter only if a filter-relevant setting actually
// changed. The Clear+Refilter cycle reloads messages from the DB, // Only refilter when filter-relevant settings changed. Clear+Refilter
// which silently wipes any in-session message that wasn't // reloads from the DB and silently drops in-session messages that
// persisted (Privacy-First config blocks most channels from DB). // weren't persisted (Privacy-First blocks most channels). Cosmetic
// Cosmetic changes (theme, tab icons, layout flags) trigger no // changes (theme, icons, layout) skip the cycle.
// refilter — chat history stays intact.
var filtersChanged = HasFilterRelevantChanges(); var filtersChanged = HasFilterRelevantChanges();
Plugin.Config.UpdateFrom(Mutable, true); Plugin.Config.UpdateFrom(Mutable, true);
// save after 60 frames have passed, which should hopefully not // Defer save by 60 frames to avoid committing changes that cause a crash.
// commit any changes that cause a crash
Plugin.DeferredSaveFrames = 60; Plugin.DeferredSaveFrames = 60;
if (filtersChanged) if (filtersChanged)
{ {
@@ -259,24 +238,16 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
GameFunctions.GameFunctions.SetChatInteractable(true); GameFunctions.GameFunctions.SetChatInteractable(true);
if (Plugin.Config.ShowEmotes) if (Plugin.Config.ShowEmotes)
_ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside _ = EmoteCache.LoadData();
Initialise(); Initialise();
} }
/// <summary> // Returns true if any filter-relevant setting changed between Plugin.Config
/// v1.2.0 — Detects whether any setting that influences message // and the Mutable copy. Gates Clear+Refilter on Save so cosmetic changes
/// filtering changed between Plugin.Config and the Mutable working // don't wipe in-session chat history.
/// copy. Used to gate the heavy ClearAllTabs+FilterAllTabsAsync cycle
/// in Save: cosmetic changes (theme, tab icons, layout flags) do not
/// touch the chat log, only filter-relevant changes do. Without this
/// gate, every settings save wipes the chat history of any channel
/// the Privacy filter blocks from being persisted to the DB —
/// reported by Flo from in-game testing 2026-05-05/06.
/// </summary>
private bool HasFilterRelevantChanges() private bool HasFilterRelevantChanges()
{ {
// Top-level privacy controls.
if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled) if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled)
return true; return true;
if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels) if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels)
@@ -285,27 +256,23 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
return true; return true;
// FilterIncludePreviousSessions changes the GetMostRecentMessages // FilterIncludePreviousSessions changes the GetMostRecentMessages
// window in MessageManager.FilterAllTabs and is therefore filter- // window and is filter-relevant even outside the Privacy block.
// relevant even though it lives outside the Privacy block.
if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions) if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions)
return true; return true;
// Per-tab channel selection. Compare persistent tabs only // Compare persistent tabs only -- TempTabs are never refiltered.
// TempTabs are session-only and never refiltered anyway.
var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList(); var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList();
var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList(); var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList();
if (origPersistent.Count != newPersistent.Count) if (origPersistent.Count != newPersistent.Count)
return true; // add or delete return true;
for (var i = 0; i < origPersistent.Count; i++) for (var i = 0; i < origPersistent.Count; i++)
{ {
var orig = origPersistent[i]; var orig = origPersistent[i];
var neu = newPersistent[i]; var neu = newPersistent[i];
// Identifier mismatch at the same index means reorder or // Identifier mismatch means reorder or slot swap -- treat as filter-relevant.
// a slot got swapped — treat as filter-relevant so the new
// channel-selection layout actually applies.
if (orig.Identifier != neu.Identifier) if (orig.Identifier != neu.Identifier)
return true; return true;
@@ -314,8 +281,6 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels)) if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels))
return true; return true;
// SelectedChannels is a Dictionary<ChatType, (ChatSource, ChatSource)>
// — value-tuple equality already does the right thing per-pair.
if (orig.SelectedChannels.Count != neu.SelectedChannels.Count) if (orig.SelectedChannels.Count != neu.SelectedChannels.Count)
return true; return true;
foreach (var pair in orig.SelectedChannels) foreach (var pair in orig.SelectedChannels)
+72 -69
View File
@@ -11,48 +11,60 @@ internal sealed class SettingsOverview
{ {
private readonly SettingsWindow _window; private readonly SettingsWindow _window;
// Card-Reihenfolge entspricht 1:1 dem Tabs-Index in SettingsWindow. // Card order matches the Tabs index in SettingsWindow 1:1.
// v1.2.1: Cards thematisch re-sortiert. Theme & Layout vereint Theme- private static (FontAwesomeIcon Icon, string Title, string Subtext)[] BuildCardDefs() =>
// Picker + Frame-Style + Timestamps; Fonts & Colours vereint Schriften [
// + Chat-Farben; Data Management vereint Storage + Retention + Cleanup (
// + Export + DB-Viewer + Advanced. FontAwesomeIcon.SlidersH,
private static readonly (FontAwesomeIcon Icon, string TitleKey, string SubtextKey)[] CardDefs = HellionStrings.Settings_Card_General_Title,
[ HellionStrings.Settings_Card_General_Subtext
(FontAwesomeIcon.SlidersH, "Settings_Card_General_Title", "Settings_Card_General_Subtext"), ),
( (
FontAwesomeIcon.Palette, FontAwesomeIcon.Palette,
"Settings_Card_ThemeAndLayout_Title", HellionStrings.Settings_Card_ThemeAndLayout_Title,
"Settings_Card_ThemeAndLayout_Subtext" HellionStrings.Settings_Card_ThemeAndLayout_Subtext
), ),
( (
FontAwesomeIcon.Font, FontAwesomeIcon.Font,
"Settings_Card_FontsAndColours_Title", HellionStrings.Settings_Card_FontsAndColours_Title,
"Settings_Card_FontsAndColours_Subtext" HellionStrings.Settings_Card_FontsAndColours_Subtext
), ),
( (
FontAwesomeIcon.WindowMaximize, FontAwesomeIcon.WindowMaximize,
"Settings_Card_Window_Title", HellionStrings.Settings_Card_Window_Title,
"Settings_Card_Window_Subtext" HellionStrings.Settings_Card_Window_Subtext
), ),
(FontAwesomeIcon.Comments, "Settings_Card_Chat_Title", "Settings_Card_Chat_Subtext"), (
(FontAwesomeIcon.FolderTree, "Settings_Card_Tabs_Title", "Settings_Card_Tabs_Subtext"), FontAwesomeIcon.Comments,
(FontAwesomeIcon.ShieldAlt, "Settings_Card_Privacy_Title", "Settings_Card_Privacy_Subtext"), HellionStrings.Settings_Card_Chat_Title,
( HellionStrings.Settings_Card_Chat_Subtext
FontAwesomeIcon.Database, ),
"Settings_Card_DataManagement_Title", (
"Settings_Card_DataManagement_Subtext" FontAwesomeIcon.FolderTree,
), HellionStrings.Settings_Card_Tabs_Title,
( HellionStrings.Settings_Card_Tabs_Subtext
FontAwesomeIcon.Plug, ),
"Settings_Card_Integrations_Title", (
"Settings_Card_Integrations_Subtext" FontAwesomeIcon.ShieldAlt,
), HellionStrings.Settings_Card_Privacy_Title,
( HellionStrings.Settings_Card_Privacy_Subtext
FontAwesomeIcon.InfoCircle, ),
"Settings_Card_Information_Title", (
"Settings_Card_Information_Subtext" FontAwesomeIcon.Database,
), HellionStrings.Settings_Card_DataManagement_Title,
]; HellionStrings.Settings_Card_DataManagement_Subtext
),
(
FontAwesomeIcon.Plug,
HellionStrings.Settings_Card_Integrations_Title,
HellionStrings.Settings_Card_Integrations_Subtext
),
(
FontAwesomeIcon.InfoCircle,
HellionStrings.Settings_Card_Information_Title,
HellionStrings.Settings_Card_Information_Subtext
),
];
public SettingsOverview(SettingsWindow window) public SettingsOverview(SettingsWindow window)
{ {
@@ -64,19 +76,18 @@ internal sealed class SettingsOverview
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var columns = avail.X >= 700f ? 3 : 2; var columns = avail.X >= 700f ? 3 : 2;
var cardWidth = (avail.X - (columns - 1) * 8f) / columns; var cardWidth = (avail.X - (columns - 1) * 8f) / columns;
// v1.2.1 — Subtexte wrappen jetzt auf zwei Zeilen, daher 110f statt der // 110f accommodates two-line subtexts; wrap width is matched in DrawCard.
// v1.1.0-Höhe 96f. Wrap-Breite + Y-Position der Subtext-Zeile sind in
// DrawCard auf den Card-Innenrand abgestimmt.
var cardHeight = 110f; var cardHeight = 110f;
for (var i = 0; i < CardDefs.Length; i++) // One draw-list lookup per frame instead of one per card.
var drawList = ImGui.GetWindowDrawList();
var cardDefs = BuildCardDefs();
for (var i = 0; i < cardDefs.Length; i++)
{ {
var (icon, titleKey, subtextKey) = CardDefs[i]; var (icon, title, subtext) = cardDefs[i];
var title = HellionStrings.ResourceManager.GetString(titleKey) ?? titleKey; DrawCard(i, icon, title, subtext, cardWidth, cardHeight, drawList);
var subtext = HellionStrings.ResourceManager.GetString(subtextKey) ?? subtextKey;
DrawCard(i, icon, title, subtext, cardWidth, cardHeight);
if ((i + 1) % columns != 0 && i != CardDefs.Length - 1) if ((i + 1) % columns != 0 && i != cardDefs.Length - 1)
ImGui.SameLine(); ImGui.SameLine();
} }
} }
@@ -87,12 +98,12 @@ internal sealed class SettingsOverview
string title, string title,
string subtext, string subtext,
float w, float w,
float h float h,
ImDrawListPtr drawList
) )
{ {
// BeginGroup macht den Card-Bereich zu einem einzelnen ImGui-Layout-Item. // BeginGroup makes the card a single layout item so SameLine works
// Damit funktioniert SameLine() im Caller-Loop — sonst tracked ImGui die // in the caller loop -- without it ImGui tracks each child separately.
// einzelnen InvisibleButton/Text-Items separat und das Wrapping bricht.
ImGui.BeginGroup(); ImGui.BeginGroup();
var cursorBefore = ImGui.GetCursorScreenPos(); var cursorBefore = ImGui.GetCursorScreenPos();
@@ -100,12 +111,8 @@ internal sealed class SettingsOverview
var hovered = ImGui.IsItemHovered(); var hovered = ImGui.IsItemHovered();
var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u; var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u;
var draw = ImGui.GetWindowDrawList(); drawList.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f);
draw.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f);
// Inhalts-Overlay: Icon + Title via DrawList (kein Wrap nötig). Subtext
// läuft über ImGui-Cursor + PushTextWrapPos damit der Text bei
// Card-Innenbreite umbricht statt rechts geclippt zu werden.
var iconPos = cursorBefore + new Vector2(16f, 12f); var iconPos = cursorBefore + new Vector2(16f, 12f);
var titlePos = cursorBefore + new Vector2(16f, 40f); var titlePos = cursorBefore + new Vector2(16f, 40f);
var subtextPos = cursorBefore + new Vector2(16f, 62f); var subtextPos = cursorBefore + new Vector2(16f, 62f);
@@ -115,17 +122,15 @@ internal sealed class SettingsOverview
using (_window.Plugin.FontManager.FontAwesome.Push()) using (_window.Plugin.FontManager.FontAwesome.Push())
{ {
draw.AddText(iconPos, titleColor, icon.ToIconString()); drawList.AddText(iconPos, titleColor, icon.ToIconString());
} }
draw.AddText(titlePos, titleColor, title); drawList.AddText(titlePos, titleColor, title);
// Subtext mit Wrap auf Card-Innenbreite (16 px Padding links + rechts). // Subtext wraps at card inner width (16px padding each side) via DrawList
// Cursor-basiertes TextUnformatted würde die ImGui-Group-Bounds // to avoid expanding the group bounds and breaking SameLine in the card row.
// erweitern und das SameLine-Wrapping in der Card-Reihe brechen, daher
// bleibt der Subtext bewusst beim DrawList-Overlay-Pattern.
var subtextWrapWidth = w - 32f; var subtextWrapWidth = w - 32f;
draw.AddText( drawList.AddText(
ImGui.GetFont(), ImGui.GetFont(),
ImGui.GetFontSize(), ImGui.GetFontSize(),
subtextPos, subtextPos,
@@ -137,8 +142,6 @@ internal sealed class SettingsOverview
ImGui.EndGroup(); ImGui.EndGroup();
if (clicked) if (clicked)
{
_window.OpenSection(index); _window.OpenSection(index);
}
} }
} }
+15 -42
View File
@@ -9,10 +9,7 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Chat-Tab — vier eigenständige Sektionen: Auto-Tell-Tabs, Behaviour, // Four sections: Auto-Tell Tabs, Behaviour, Preview, Emotes.
// Preview, Emotes. Der Emotes-Block ist 1:1 aus der Bestand-Datei
// Emote.cs übernommen; die Datei wird in Plan-Task 11 (Settings UX
// Polish v0.5.0) entfernt, sobald alle Tabs migriert sind.
internal sealed class Chat : ISettingsTab internal sealed class Chat : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -22,9 +19,8 @@ internal sealed class Chat : ISettingsTab
private SearchSelector.SelectorPopupOptions WordPopupOptions; private SearchSelector.SelectorPopupOptions WordPopupOptions;
// Snapshot of EmoteCache.State for which we last built WordPopupOptions. // Tracks which EmoteCache state WordPopupOptions was built for so we
// Without this, an empty FilteredSheet (e.g., the user blocked every emote) // don't refill every frame when FilteredSheet is empty.
// would trigger a refill every frame the settings tab is open.
private EmoteCache.LoadingState? WordPopupOptionsBuiltFor; private EmoteCache.LoadingState? WordPopupOptionsBuiltFor;
internal Chat(Plugin plugin, Configuration mutable) internal Chat(Plugin plugin, Configuration mutable)
@@ -36,15 +32,13 @@ internal sealed class Chat : ISettingsTab
WordPopupOptionsBuiltFor = EmoteCache.State; WordPopupOptionsBuiltFor = EmoteCache.State;
} }
private SearchSelector.SelectorPopupOptions RefillSheet() private SearchSelector.SelectorPopupOptions RefillSheet() =>
{ new SearchSelector.SelectorPopupOptions
return new SearchSelector.SelectorPopupOptions
{ {
FilteredSheet = EmoteCache FilteredSheet = EmoteCache
.SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w)) .SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w))
.ToArray(), .ToArray(),
}; };
}
public void Draw(bool changed) public void Draw(bool changed)
{ {
@@ -61,9 +55,7 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -76,9 +68,7 @@ internal sealed class Chat : ISettingsTab
ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale); ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale);
var limit = Mutable.AutoTellTabsLimit; var limit = Mutable.AutoTellTabsLimit;
if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50)) if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50))
{
Mutable.AutoTellTabsLimit = limit; Mutable.AutoTellTabsLimit = limit;
}
ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description); ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description);
ImGui.Checkbox( ImGui.Checkbox(
@@ -119,9 +109,7 @@ internal sealed class Chat : ISettingsTab
100 100
) )
) )
{
Mutable.AutoTellTabsHistoryPreload = preload; Mutable.AutoTellTabsHistoryPreload = preload;
}
ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description); ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description);
ImGui.Spacing(); ImGui.Spacing();
@@ -133,9 +121,7 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -153,6 +139,12 @@ internal sealed class Chat : ISettingsTab
); );
ImGuiUtil.HelpMarker(Language.Options_CollapseDuplicateMsgUniqueLink_Description); ImGuiUtil.HelpMarker(Language.Options_CollapseDuplicateMsgUniqueLink_Description);
} }
ImGui.Checkbox(
HellionStrings.Settings_Chat_SymbolPicker_Enable_Name,
ref Mutable.SymbolPickerEnabled
);
ImGuiUtil.HelpMarker(HellionStrings.Settings_Chat_SymbolPicker_Enable_Description);
} }
} }
@@ -160,9 +152,7 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -178,9 +168,7 @@ internal sealed class Chat : ISettingsTab
foreach (var position in Enum.GetValues<PreviewPosition>()) foreach (var position in Enum.GetValues<PreviewPosition>())
{ {
if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position)) if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position))
{
Mutable.PreviewPosition = position; Mutable.PreviewPosition = position;
}
} }
} }
} }
@@ -193,9 +181,7 @@ internal sealed class Chat : ISettingsTab
ref Mutable.PreviewMinimum ref Mutable.PreviewMinimum
) )
) )
{
Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250); Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250);
}
ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf); ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf);
ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description); ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description);
@@ -206,9 +192,7 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -233,17 +217,13 @@ internal sealed class Chat : ISettingsTab
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0)); ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0));
// Open the selector popup on left-click; SelectorPopup uses // OpenPopup on click because SelectorPopup uses ContextPopupItem
// ImRaii.ContextPopupItem internally which only opens on right- // which only triggers on right-click by default.
// click otherwise — without this OpenPopup the button looked
// active but the popup never appeared on a normal click.
if (ImGui.IsItemClicked()) if (ImGui.IsItemClicked())
ImGui.OpenPopup("WordAddPopup"); ImGui.OpenPopup("WordAddPopup");
if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions)) if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions))
{
Mutable.BlockedEmotes.Add(newWord); Mutable.BlockedEmotes.Add(newWord);
}
using ( using (
var table = ImRaii.Table( var table = ImRaii.Table(
@@ -257,11 +237,9 @@ internal sealed class Chat : ISettingsTab
{ {
ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable); ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable);
ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f); ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f);
ImGui.TableHeadersRow(); ImGui.TableHeadersRow();
var copiedList = Mutable.BlockedEmotes.ToArray(); foreach (var word in Mutable.BlockedEmotes.ToArray())
foreach (var word in copiedList)
{ {
ImGui.TableNextColumn(); ImGui.TableNextColumn();
ImGui.TextUnformatted(word); ImGui.TextUnformatted(word);
@@ -274,9 +252,7 @@ internal sealed class Chat : ISettingsTab
!ImGui.GetIO().KeyCtrl !ImGui.GetIO().KeyCtrl
) )
) )
{
Mutable.BlockedEmotes.Remove(word); Mutable.BlockedEmotes.Remove(word);
}
} }
} }
} }
@@ -289,17 +265,14 @@ internal sealed class Chat : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
if (EmoteCache.State is EmoteCache.LoadingState.Done) if (EmoteCache.State is EmoteCache.LoadingState.Done)
{
ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready); ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready);
}
else else
{
ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady); ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady);
}
ImGui.TextUnformatted( ImGui.TextUnformatted(
$"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}" $"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}"
); );
using ( using (
var emoteTable = ImRaii.Table( var emoteTable = ImRaii.Table(
"##LoadedEmotes", "##LoadedEmotes",
+19 -16
View File
@@ -11,6 +11,7 @@ using HellionChat.Export;
using HellionChat.Privacy; using HellionChat.Privacy;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
@@ -18,6 +19,7 @@ internal sealed class DataManagement : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
private Configuration Mutable { get; } private Configuration Mutable { get; }
private readonly ILogger<DataManagement> _logger;
public string Name => public string Name =>
HellionStrings.Settings_Card_DataManagement_Title + "###tabs-datamanagement"; HellionStrings.Settings_Card_DataManagement_Title + "###tabs-datamanagement";
@@ -136,10 +138,11 @@ internal sealed class DataManagement : ISettingsTab
), ),
]; ];
internal DataManagement(Plugin plugin, Configuration mutable) internal DataManagement(Plugin plugin, Configuration mutable, ILogger<DataManagement> logger)
{ {
Plugin = plugin; Plugin = plugin;
Mutable = mutable; Mutable = mutable;
_logger = logger;
} }
public void Draw(bool changed) public void Draw(bool changed)
@@ -229,7 +232,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Error(e, "Unable to delete old database"); _logger.LogError(e, "Unable to delete old database");
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
Language.Options_Database_Old_Delete_Error, Language.Options_Database_Old_Delete_Error,
NotificationType.Error NotificationType.Error
@@ -391,7 +394,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.Config.RetentionLastRunAt = DateTimeOffset.UtcNow; Plugin.Config.RetentionLastRunAt = DateTimeOffset.UtcNow;
Plugin.SaveConfig(); Plugin.SaveConfig();
Plugin.Log.Information($"Manual retention run deleted {deleted} expired messages."); _logger.LogInformation($"Manual retention run deleted {deleted} expired messages.");
if (deleted > 0) if (deleted > 0)
{ {
@@ -405,7 +408,7 @@ internal sealed class DataManagement : ISettingsTab
.Wait(TimeSpan.FromSeconds(5)) .Wait(TimeSpan.FromSeconds(5))
) )
{ {
Plugin.Log.Warning( _logger.LogWarning(
"Retention sweep: framework refresh timed out after 5s." "Retention sweep: framework refresh timed out after 5s."
); );
} }
@@ -418,7 +421,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Error(e, "Manual retention run failed"); _logger.LogError(e, "Manual retention run failed");
WrapperUtil.AddNotification(HellionStrings.Retention_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Retention_Error, NotificationType.Error);
} }
finally finally
@@ -566,7 +569,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Error(e, "Failed to compute cleanup preview"); _logger.LogError(e, "Failed to compute cleanup preview");
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
HellionStrings.Cleanup_PreviewError, HellionStrings.Cleanup_PreviewError,
NotificationType.Error NotificationType.Error
@@ -587,7 +590,7 @@ internal sealed class DataManagement : ISettingsTab
try try
{ {
var deleted = Plugin.MessageManager.Store.CleanupRetainOnly(allowed); var deleted = Plugin.MessageManager.Store.CleanupRetainOnly(allowed);
Plugin.Log.Information($"Privacy cleanup: deleted {deleted} messages"); _logger.LogInformation($"Privacy cleanup: deleted {deleted} messages");
if ( if (
!Plugin !Plugin
@@ -599,7 +602,7 @@ internal sealed class DataManagement : ISettingsTab
.Wait(TimeSpan.FromSeconds(5)) .Wait(TimeSpan.FromSeconds(5))
) )
{ {
Plugin.Log.Warning("Privacy cleanup: framework refresh timed out after 5s."); _logger.LogWarning("Privacy cleanup: framework refresh timed out after 5s.");
} }
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
@@ -609,7 +612,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Error(e, "Privacy cleanup failed"); _logger.LogError(e, "Privacy cleanup failed");
WrapperUtil.AddNotification(HellionStrings.Cleanup_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Cleanup_Error, NotificationType.Error);
} }
finally finally
@@ -769,7 +772,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.Log.Error(e, "Export failed"); _logger.LogError(e, "Export failed");
WrapperUtil.AddNotification(HellionStrings.Export_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Export_Error, NotificationType.Error);
} }
finally finally
@@ -849,7 +852,7 @@ internal sealed class DataManagement : ISettingsTab
) )
) )
{ {
Plugin.Log.Warning("Clearing messages from database"); _logger.LogWarning("Clearing messages from database");
Plugin.MessageManager.Store.ClearMessages(); Plugin.MessageManager.Store.ClearMessages();
Plugin.MessageManager.ClearAllTabs(); Plugin.MessageManager.ClearAllTabs();
@@ -907,7 +910,7 @@ internal sealed class DataManagement : ISettingsTab
private void InsertMessages(int count) private void InsertMessages(int count)
{ {
Plugin.Log.Info($"Inserting {count} messages due to user request"); _logger.LogInformation($"Inserting {count} messages due to user request");
var stopwatch = Stopwatch.StartNew(); var stopwatch = Stopwatch.StartNew();
var playerName = Plugin.PlayerState.CharacterName; var playerName = Plugin.PlayerState.CharacterName;
@@ -952,7 +955,7 @@ internal sealed class DataManagement : ISettingsTab
var elapsedTicks = stopwatch.ElapsedTicks; var elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.Log.Info( _logger.LogInformation(
$"Crafted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Crafted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
@@ -962,7 +965,7 @@ internal sealed class DataManagement : ISettingsTab
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.Log.Info( _logger.LogInformation(
$"Upserted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Upserted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
@@ -973,7 +976,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.MessageManager.ClearAllTabs(); Plugin.MessageManager.ClearAllTabs();
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.Log.Info( _logger.LogInformation(
$"Cleared {Plugin.Config.Tabs.Count} tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Cleared {Plugin.Config.Tabs.Count} tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
}) })
@@ -986,7 +989,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.MessageManager.FilterAllTabs(); Plugin.MessageManager.FilterAllTabs();
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.Log.Info( _logger.LogInformation(
$"Fetched and filtered all tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Fetched and filtered all tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
}) })
@@ -7,6 +7,7 @@ using Dalamud.Interface.Utility.Raii;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
@@ -14,14 +15,16 @@ internal sealed class FontsAndColours : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
private Configuration Mutable { get; } private Configuration Mutable { get; }
private readonly ILogger<FontsAndColours> _logger;
public string Name => public string Name =>
HellionStrings.Settings_Card_FontsAndColours_Title + "###tabs-fontsandcolours"; HellionStrings.Settings_Card_FontsAndColours_Title + "###tabs-fontsandcolours";
internal FontsAndColours(Plugin plugin, Configuration mutable) internal FontsAndColours(Plugin plugin, Configuration mutable, ILogger<FontsAndColours> logger)
{ {
Plugin = plugin; Plugin = plugin;
Mutable = mutable; Mutable = mutable;
_logger = logger;
} }
public void Draw(bool changed) public void Draw(bool changed)
@@ -312,6 +315,6 @@ internal sealed class FontsAndColours : ISettingsTab
} }
Plugin.SaveConfig(); Plugin.SaveConfig();
GlobalParametersCache.Refresh(); GlobalParametersCache.Refresh();
Plugin.Log.Debug($"Applied chat colour preset: {preset.DisplayName}"); _logger.LogDebug($"Applied chat colour preset: {preset.DisplayName}");
} }
} }
+4 -6
View File
@@ -8,9 +8,7 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Information-Tab vereint die früheren About- und Changelog-Tabs in // Combines the former About and Changelog tabs into three collapsible sections.
// drei kollabierbaren Sektionen. Der About-Inhalt ist 1:1 aus About.cs
// übernommen, die Changelog-Render-Logik aus Changelog.cs.
internal sealed class Information : ISettingsTab internal sealed class Information : ISettingsTab
{ {
private Configuration Mutable { get; } private Configuration Mutable { get; }
@@ -99,7 +97,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(Language.Options_About_Github_Issues); ImGui.TextUnformatted(Language.Options_About_Github_Issues);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues"))
Dalamud.Utility.Util.OpenLink( Plugin.PlatformUtil.OpenLink(
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues" "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues"
); );
} }
@@ -118,7 +116,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label); ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia"))
Dalamud.Utility.Util.OpenLink("https://hellion-media.de"); Plugin.PlatformUtil.OpenLink("https://hellion-media.de");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
@@ -139,7 +137,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label); ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream"))
Dalamud.Utility.Util.OpenLink("https://github.com/Infiziert90/ChatTwo"); Plugin.PlatformUtil.OpenLink("https://github.com/Infiziert90/ChatTwo");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
+23 -19
View File
@@ -8,9 +8,8 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// First settings tab introduced in v1.3.0 (Plugin Integrations Cycle 1). // Added in v1.3.0. Each future integration cycle adds a section above
// Designed to grow organically: each future cycle adds a new section above // the "Coming soon" block and removes its stub item.
// the "Coming soon" block and removes the corresponding stub item.
internal sealed class Integrations : ISettingsTab internal sealed class Integrations : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -48,11 +47,9 @@ internal sealed class Integrations : ISettingsTab
DrawHonorificStatus(); DrawHonorificStatus();
ImGui.Spacing(); ImGui.Spacing();
// The toggle is enabled regardless of detection state — leaving it // Toggle works regardless of detection state: "show when available,
// on means "render when available, hide otherwise". Disabling the // hide otherwise". Disabling it when Honorific is missing would force
// toggle when Honorific is missing would force the user to retoggle // the user to retoggle on every reload.
// it every time Honorific is reloaded, which is worse UX than the
// silent auto-hide.
if ( if (
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Integrations_Honorific_Toggle, HellionStrings.Settings_Integrations_Honorific_Toggle,
@@ -74,22 +71,31 @@ internal sealed class Integrations : ISettingsTab
{ {
ImGui.TextWrapped(HellionStrings.Settings_Integrations_Honorific_ToggleHint); ImGui.TextWrapped(HellionStrings.Settings_Integrations_Honorific_ToggleHint);
} }
if (
ImGui.Checkbox(
HellionStrings.Settings_Integrations_Honorific_Glow_Toggle,
ref Mutable.ShowHonorificGlow
)
)
{
Plugin.SaveConfig();
}
ImGuiUtil.HelpMarker(HellionStrings.Settings_Integrations_Honorific_Glow_Hint);
} }
// Maintainer attribution. Honorific has no LICENSE in its repo so we // Honorific has no LICENSE in its repo so we link upstream and author
// can't bundle its assets, but linking to the upstream and the // instead of bundling assets. Text labels because FA Brands isn't
// author's profile is the polite minimum. Plain ImGui buttons keep // guaranteed in Dalamud's font set.
// the visual weight modest, the FontAwesome Brands subset is not
// guaranteed in Dalamud's font set so we use text labels.
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo))
{ {
Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificRepo); Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificRepo);
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor))
{ {
Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificAuthor); Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificAuthor);
} }
} }
@@ -147,9 +153,7 @@ internal sealed class Integrations : ISettingsTab
ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro); ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro);
ImGui.Spacing(); ImGui.Spacing();
// Static list maintained in code (not Configuration). Each cycle // Each integration cycle removes its stub here and adds a full section above.
// that lands a real integration removes its stub here and adds a
// full section above the Coming Soon block.
DrawComingSoonItem( DrawComingSoonItem(
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title, HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title,
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description
@@ -200,7 +204,7 @@ internal sealed class Integrations : ISettingsTab
if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel)) if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel))
{ {
Dalamud.Utility.Util.OpenLink(BrandingLinks.HellionForgeDiscordInvite); Plugin.PlatformUtil.OpenLink(BrandingLinks.HellionForgeDiscordInvite);
} }
} }
+1 -2
View File
@@ -20,8 +20,7 @@ internal sealed class Privacy : ISettingsTab
Mutable = mutable; Mutable = mutable;
} }
// (HeadingKey lookup, ChatType list). Heading is resolved per-frame so // (HeadingKey, ChatType list). Heading resolved per-frame for live language switching.
// a runtime LanguageChanged call updates the labels immediately.
private static readonly (Func<string> Heading, ChatType[] Types)[] Groups = private static readonly (Func<string> Heading, ChatType[] Types)[] Groups =
[ [
( (
+5 -7
View File
@@ -123,7 +123,7 @@ internal sealed class Tabs : ISettingsTab
ImGuiInputTextFlags.EnterReturnsTrue ImGuiInputTextFlags.EnterReturnsTrue
); );
// v1.2.0 — Per-Tab Icon-Override. Default-Mapping greift falls nichts gesetzt. // Per-tab icon override added in v1.2.0. Falls back to default mapping if unset.
ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label); ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label);
ImGui.SameLine(); ImGui.SameLine();
ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker); ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker);
@@ -135,7 +135,7 @@ internal sealed class Tabs : ISettingsTab
{ {
if (combo.Success) if (combo.Success)
{ {
// Erste Option: Default (löscht Icon, lässt Mapping greifen). // First option clears the icon and lets the default mapping take over.
if ( if (
ImGui.Selectable( ImGui.Selectable(
HellionStrings.Tabs_Icon_DefaultOption, HellionStrings.Tabs_Icon_DefaultOption,
@@ -148,7 +148,7 @@ internal sealed class Tabs : ISettingsTab
ImGui.Separator(); ImGui.Separator();
// Pool-Optionen aus TabIconGlyphResolver.PickerOptions (Single-Source-of-Truth). // Options sourced from TabIconGlyphResolver.PickerOptions (single source of truth).
foreach (var option in TabIconGlyphResolver.PickerOptions) foreach (var option in TabIconGlyphResolver.PickerOptions)
{ {
var isSelected = string.Equals( var isSelected = string.Equals(
@@ -305,10 +305,8 @@ internal sealed class Tabs : ISettingsTab
ImGui.SameLine(); ImGui.SameLine();
// Guard against an empty worlds list — can happen briefly // Guard against an empty worlds list (character switch or sheet not yet populated)
// when switching characters or if the datacenter sheet // to avoid an out-of-bounds crash on worlds[selectedWorld].
// has not yet populated. Without the guard the indexed
// access into worlds[selectedWorld] would crash.
if (worlds.Count == 0) if (worlds.Count == 0)
{ {
ImGui.TextDisabled("(no worlds available)"); ImGui.TextDisabled("(no worlds available)");
+42 -38
View File
@@ -4,6 +4,7 @@ using Dalamud.Interface.Utility.Raii;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Themes; using HellionChat.Themes;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Extensions.Logging;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
@@ -11,16 +12,18 @@ internal sealed class ThemeAndLayout : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
private Configuration Mutable { get; } private Configuration Mutable { get; }
private readonly ILogger<ThemeAndLayout> _logger;
private string? _applyDismissedFor; private string? _applyDismissedFor;
public string Name => public string Name =>
HellionStrings.Settings_Card_ThemeAndLayout_Title + "###tabs-themeandlayout"; HellionStrings.Settings_Card_ThemeAndLayout_Title + "###tabs-themeandlayout";
internal ThemeAndLayout(Plugin plugin, Configuration mutable) internal ThemeAndLayout(Plugin plugin, Configuration mutable, ILogger<ThemeAndLayout> logger)
{ {
Plugin = plugin; Plugin = plugin;
Mutable = mutable; Mutable = mutable;
_logger = logger;
} }
public void Draw(bool changed) public void Draw(bool changed)
@@ -43,9 +46,9 @@ internal sealed class ThemeAndLayout : ISettingsTab
var registry = Plugin.ThemeRegistry; var registry = Plugin.ThemeRegistry;
var active = registry.Get(Mutable.Theme); var active = registry.Get(Mutable.Theme);
var activeLabelTemplate = ImGui.TextUnformatted(
HellionStrings.ResourceManager.GetString("Settings_Themes_Active") ?? "Active: {0}"; string.Format(HellionStrings.Settings_Themes_Active, active.Name)
ImGui.TextUnformatted(string.Format(activeLabelTemplate, active.Name)); );
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u))
ImGui.TextUnformatted(active.Author); ImGui.TextUnformatted(active.Author);
@@ -55,10 +58,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
var builtInsLabel = ImGui.TextUnformatted(HellionStrings.Settings_Themes_BuiltIns);
HellionStrings.ResourceManager.GetString("Settings_Themes_BuiltIns")
?? "Built-in themes";
ImGui.TextUnformatted(builtInsLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(registry.AllBuiltIns(), active.Slug); DrawThemeGrid(registry.AllBuiltIns(), active.Slug);
@@ -68,10 +68,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
var customLabel = ImGui.TextUnformatted(HellionStrings.Settings_Themes_Custom);
HellionStrings.ResourceManager.GetString("Settings_Themes_Custom")
?? "Custom themes";
ImGui.TextUnformatted(customLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(customs, active.Slug); DrawThemeGrid(customs, active.Slug);
} }
@@ -80,21 +77,15 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
var openFolderLabel = if (ImGui.Button(HellionStrings.Settings_Themes_OpenFolder))
HellionStrings.ResourceManager.GetString("Settings_Themes_OpenFolder")
?? "Open themes folder";
if (ImGui.Button(openFolderLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
Dalamud.Utility.Util.OpenLink(dir); Plugin.PlatformUtil.OpenLink(dir);
} }
ImGui.SameLine(); ImGui.SameLine();
var exportLabel = if (ImGui.Button(HellionStrings.Settings_Themes_ExportActive))
HellionStrings.ResourceManager.GetString("Settings_Themes_ExportActive")
?? "Export active...";
if (ImGui.Button(exportLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
@@ -102,7 +93,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
var path = Path.Combine(dir, fileName); var path = Path.Combine(dir, fileName);
var json = ThemeJsonWriter.Serialize(active); var json = ThemeJsonWriter.Serialize(active);
File.WriteAllText(path, json); File.WriteAllText(path, json);
Plugin.Log.Information($"Exported active theme '{active.Slug}' to {path}"); _logger.LogInformation($"Exported active theme '{active.Slug}' to {path}");
} }
} }
} }
@@ -206,25 +197,19 @@ internal sealed class ThemeAndLayout : ISettingsTab
draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f); draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f);
draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f); draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f);
var hint =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Hint")
?? "This theme suggests its own chat channel colours.";
var applyLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Apply")
?? "Apply";
var keepLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Keep")
?? "Keep current";
var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary); var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary);
draw.AddText(origin + new Vector2(12f, 10f), textColor, hint); draw.AddText(
origin + new Vector2(12f, 10f),
textColor,
HellionStrings.Settings_Themes_ApplyChatColors_Hint
);
using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary)) using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark))
{ {
ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f)); ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f));
if (ImGui.Button(applyLabel)) if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Apply))
{ {
foreach (var kvp in themeChatColors.Channels) foreach (var kvp in themeChatColors.Channels)
Mutable.ChatColours[kvp.Key] = kvp.Value; Mutable.ChatColours[kvp.Key] = kvp.Value;
@@ -233,7 +218,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(keepLabel)) if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Keep))
{ {
_applyDismissedFor = active.Slug; _applyDismissedFor = active.Slug;
} }
@@ -268,13 +253,32 @@ internal sealed class ThemeAndLayout : ISettingsTab
string.Format(Language.Options_SidebarTabView_Description, Plugin.PluginName) string.Format(Language.Options_SidebarTabView_Description, Plugin.PluginName)
); );
if (Mutable.SidebarTabView)
{
var sidebarWidth = Mutable.SidebarWidth;
if (
ImGui.SliderInt(
HellionStrings.Settings_ThemeAndLayout_SidebarWidth_Name,
ref sidebarWidth,
44,
160,
$"{sidebarWidth} px"
)
)
{
Mutable.SidebarWidth = sidebarWidth;
}
ImGuiUtil.HelpMarker(
HellionStrings.Settings_ThemeAndLayout_SidebarWidth_Description
);
}
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Slider 50100 % UX-Range; intern 0.51.0 als WindowOpacity-Float. // Slider range 50-100% maps to 0.5-1.0 internally. Floor at 50% prevents
// Untere Schwelle 50 % verhindert versehentliches Komplett-Wegblenden // accidentally hiding the chat background (v1.2.0 bug at WindowAlpha=0).
// des Chat-Hintergrunds (war v1.2.0 Bug bei WindowAlpha=0).
var opacityPercent = Mutable.WindowOpacity * 100f; var opacityPercent = Mutable.WindowOpacity * 100f;
if ( if (
ImGuiUtil.DragFloatVertical( ImGuiUtil.DragFloatVertical(
+9 -10
View File
@@ -7,15 +7,14 @@ namespace HellionChat.Ui.SettingsTabs;
internal static class ThemeMockup internal static class ThemeMockup
{ {
// Zeichnet ein Mini-Chat-Window-Mockup mit den Theme-Werten direkt // Mini chat window mockup drawn directly into the WindowDrawList.
// ins WindowDrawList. Keine Texture, keine Allocation pro Frame — // No textures, no per-frame allocations — pure AddRectFilled/AddText.
// alles via DrawList.AddRectFilled / AddText.
public static void Draw(Vector2 origin, Vector2 size, Theme theme) public static void Draw(Vector2 origin, Vector2 size, Theme theme)
{ {
var draw = ImGui.GetWindowDrawList(); var draw = ImGui.GetWindowDrawList();
var c = theme.Colors; var c = theme.Colors;
// Window-Bg // Window background
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
origin + size, origin + size,
@@ -23,7 +22,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Title-Bar // Title bar
var titleHeight = 14f; var titleHeight = 14f;
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
@@ -32,7 +31,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Tab-Bar — 3 Mini-Tabs // Tab bar (3 tabs)
var tabY = origin.Y + titleHeight + 4f; var tabY = origin.Y + titleHeight + 4f;
var tabHeight = 12f; var tabHeight = 12f;
for (var i = 0; i < 3; i++) for (var i = 0; i < 3; i++)
@@ -46,7 +45,7 @@ internal static class ThemeMockup
theme.Layout.TabRounding theme.Layout.TabRounding
); );
if (i == 0) // Active-Pill if (i == 0) // active pill
{ {
draw.AddRectFilled( draw.AddRectFilled(
new Vector2(tabX, tabY + tabHeight - 2f), new Vector2(tabX, tabY + tabHeight - 2f),
@@ -56,7 +55,7 @@ internal static class ThemeMockup
} }
} }
// Card-Row mit Mock-Sender + Text // Message card row
var rowY = tabY + tabHeight + 6f; var rowY = tabY + tabHeight + 6f;
var rowHeight = 18f; var rowHeight = 18f;
draw.AddRectFilled( draw.AddRectFilled(
@@ -66,7 +65,7 @@ internal static class ThemeMockup
2f 2f
); );
// Akzent-Button rechts unten // Accent button (bottom right)
var btnW = 28f; var btnW = 28f;
var btnH = 10f; var btnH = 10f;
var btnX = origin.X + size.X - btnW - 6f; var btnX = origin.X + size.X - btnW - 6f;
@@ -78,7 +77,7 @@ internal static class ThemeMockup
theme.Layout.FrameRounding theme.Layout.FrameRounding
); );
// Border um das gesamte Mockup // Mockup border
draw.AddRect( draw.AddRect(
origin, origin,
origin + size, origin + size,
+2 -5
View File
@@ -107,7 +107,7 @@ internal sealed class Window : ISettingsTab
1, 1,
10 10
); );
// Untergrenze von 2 Sekunden gegen Selbst-Soft-Lock. // Floor at 2 seconds to prevent self-soft-lock.
Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout); Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout);
using (ImRaii.Disabled(Mutable.HideInBattle)) using (ImRaii.Disabled(Mutable.HideInBattle))
@@ -177,7 +177,6 @@ internal sealed class Window : ISettingsTab
ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove); ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove);
ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize); ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize);
// v0.6.0 — global master switch for the pop-out input bar.
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Window_PopOutInputEnabled_Name, HellionStrings.Settings_Window_PopOutInputEnabled_Name,
ref Mutable.PopOutInputEnabled ref Mutable.PopOutInputEnabled
@@ -186,9 +185,7 @@ internal sealed class Window : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
// Manual escape hatch for off-screen windows. The plugin already // Fallback for off-screen windows after a display layout change.
// runs an automatic bounds check once per session, but a button
// is the user-friendly fallback after a display layout change.
if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name)) if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name))
Plugin.ChatLogWindow.RequestPositionReset = true; Plugin.ChatLogWindow.RequestPositionReset = true;
ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description); ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description);
+35 -42
View File
@@ -2,6 +2,7 @@ using System.Globalization;
using System.Numerics; using System.Numerics;
using Dalamud.Bindings.ImGui; using Dalamud.Bindings.ImGui;
using Dalamud.Interface; using Dalamud.Interface;
using Dalamud.Interface.Utility;
using Dalamud.Interface.Utility.Raii; using Dalamud.Interface.Utility.Raii;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.Resources; using HellionChat.Resources;
@@ -9,32 +10,31 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
/// <summary> // Bottom status bar. Slots left to right: channel indicator, privacy badge,
/// Bottom-Status-Bar (v1.2.0). Fix 22 px hoch, BorderTop als Trenner. // counts, tells (hidden at 0), version (right-aligned). Updates at 1Hz;
/// Slots links → rechts: Channel-Indicator (Color-Dot + Channel-Name), // format strings are cached between updates.
/// Privacy-Badge (Lock-Icon + Privacy-Label), Counts (Tabs + Msgs),
/// Tells (Auto-Tell-Counter, hidden bei 0), Version (rechtsbündig, muted).
///
/// Update-Frequenz: 1×/Sekunde. Format-Strings werden zwischen Updates
/// gecached, damit kein Per-Frame-Format-Allocation entsteht.
/// </summary>
internal sealed class StatusBar internal sealed class StatusBar
{ {
public const float Height = 22f; // DPI-aware bar height. The previous fixed 22px constant clipped on
// Windows display-scaling >100% because ImGui renders the font bigger
// than the reservation. GetTextLineHeightWithSpacing scales with the
// current ImGui font; the 2px spacer is GlobalScale-rounded to stay
// on integer pixel boundaries (same idiom as v1.4.6 F7.2 underline-pill
// in ChatLogWindow.cs:1639-1653).
public static float Height =>
ImGui.GetTextLineHeightWithSpacing() + MathF.Round(2f * ImGuiHelpers.GlobalScale);
private const long UpdateIntervalMs = 1000; private const long UpdateIntervalMs = 1000;
// Cache-State — initial outdated, damit der erste Frame frisch berechnet. // Initially outdated so the first frame always computes fresh.
private long _lastUpdateMs = -UpdateIntervalMs; private long _lastUpdateMs = -UpdateIntervalMs;
private string _cachedCountsText = string.Empty; private string _cachedCountsText = string.Empty;
private string _cachedTellsText = string.Empty; private string _cachedTellsText = string.Empty;
/// <summary> // Pure string logic, testable without ImGui init.
/// Reine String-Logik — testbar ohne ImGui-Init.
/// </summary>
public static string FormatCounts(int tabs, int messages) public static string FormatCounts(int tabs, int messages)
{ {
// InvariantCulture: User-System-Locale darf das Format nicht // InvariantCulture so locale doesn't affect the format (e.g. de_DE "1,2k").
// verändern (de_DE würde sonst "1,2k" statt "1.2k" liefern).
var msgPart = var msgPart =
messages >= 1000 messages >= 1000
? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0) ? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0)
@@ -43,10 +43,7 @@ internal sealed class StatusBar
return $"{tabsPart} · {msgPart}"; return $"{tabsPart} · {msgPart}";
} }
/// <summary> // Pure string logic, testable without ImGui init. Returns empty string at 0 tells.
/// Reine String-Logik — testbar ohne ImGui-Init.
/// 0 Tells → Leerstring (Slot wird ausgeblendet).
/// </summary>
public static string FormatTells(int count) public static string FormatTells(int count)
{ {
if (count <= 0) if (count <= 0)
@@ -54,8 +51,7 @@ internal sealed class StatusBar
return $"{count} {(count == 1 ? "tell" : "tells")}"; return $"{count} {(count == 1 ? "tell" : "tells")}";
} }
// Single-pass replacement for the LINQ Sum+Count pair in Draw. Pure // Single-pass replacement for a LINQ Sum+Count pair. Pure helper for unit testing.
// helper so a future LINQ regression gets pinned by xUnit.
internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs) internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs)
{ {
int messages = 0, int messages = 0,
@@ -69,10 +65,7 @@ internal sealed class StatusBar
return (messages, tells); return (messages, tells);
} }
/// <summary> // Test hook to verify cache logic without a real time source.
/// Test-Hook: Cache-Logic ohne reale Time-Source verifizieren.
/// Nicht für Production-Render.
/// </summary>
internal (string counts, string tells) SnapshotForTest( internal (string counts, string tells) SnapshotForTest(
long now, long now,
int tabs, int tabs,
@@ -93,24 +86,18 @@ internal sealed class StatusBar
_lastUpdateMs = now; _lastUpdateMs = now;
} }
/// <summary>
/// Render-Pfad. Aufrufer pusht bereits den HellionStyle/Theme;
/// wir lesen nur die aktiven Theme-Farben und zeichnen.
/// </summary>
public void Draw(Plugin plugin) public void Draw(Plugin plugin)
{ {
var theme = plugin.ThemeRegistry.Active; var theme = plugin.ThemeRegistry.Active;
var now = Environment.TickCount64; var now = Environment.TickCount64;
// Outer gate keeps the foreach out of the hot path 99% of frames.
// UpdateCacheIfDue runs the same check internally — idempotent.
if (now - _lastUpdateMs >= UpdateIntervalMs) if (now - _lastUpdateMs >= UpdateIntervalMs)
{ {
var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs); var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs);
UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells); UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells);
} }
// BorderTop als Trenner — DrawList-Line, ImGui-Separator hat zu viel Padding. // Border top via DrawList -- ImGui.Separator has too much padding.
var cursorY = ImGui.GetCursorScreenPos().Y; var cursorY = ImGui.GetCursorScreenPos().Y;
var winLeft = ImGui.GetWindowPos().X; var winLeft = ImGui.GetWindowPos().X;
var winRight = winLeft + ImGui.GetWindowSize().X; var winRight = winLeft + ImGui.GetWindowSize().X;
@@ -123,9 +110,9 @@ internal sealed class StatusBar
1f 1f
); );
ImGui.Dummy(new Vector2(0, 2)); // BorderTop-Spacing ImGui.Dummy(new Vector2(0, 2));
// Slot 1: Active-Channel-Indicator // Slot 1: active channel indicator
var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid; var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid;
var hasChannel = inputCh != InputChannel.Invalid; var hasChannel = inputCh != InputChannel.Invalid;
var chatType = inputCh.ToChatType(); var chatType = inputCh.ToChatType();
@@ -137,7 +124,7 @@ internal sealed class StatusBar
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(channelName); ImGui.TextUnformatted(channelName);
// Slot 2: Privacy-Badge — abgeleitet aus PrivacyFilterEnabled. // Slot 2: privacy badge
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
@@ -151,13 +138,13 @@ internal sealed class StatusBar
: HellionStrings.StatusBar_Privacy_Open; : HellionStrings.StatusBar_Privacy_Open;
ImGui.TextUnformatted(privacyLabel); ImGui.TextUnformatted(privacyLabel);
// Slot 3: Counts // Slot 3: counts
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(_cachedCountsText); ImGui.TextUnformatted(_cachedCountsText);
// Slot 4: Tells (nur wenn > 0) // Slot 4: tells (hidden at 0)
if (!string.IsNullOrEmpty(_cachedTellsText)) if (!string.IsNullOrEmpty(_cachedTellsText))
{ {
ImGui.SameLine(); ImGui.SameLine();
@@ -166,14 +153,20 @@ internal sealed class StatusBar
ImGui.TextUnformatted(_cachedTellsText); ImGui.TextUnformatted(_cachedTellsText);
} }
// Slot 5: Version (rechtsbündig, muted) // Slot 5: version, right-aligned, muted. Hidden when the window is
// too narrow to fit all five slots — the other four need ~200 px
// before the version text starts clipping into them.
var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion"; var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion";
var versionWidth = ImGui.CalcTextSize(versionText).X; var versionWidth = ImGui.CalcTextSize(versionText).X;
var contentRegionMax = ImGui.GetContentRegionMax().X; var contentRegionMax = ImGui.GetContentRegionMax().X;
ImGui.SameLine(contentRegionMax - versionWidth); const float MinOtherSlotsWidth = 200f;
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted))) if (contentRegionMax - versionWidth > MinOtherSlotsWidth)
{ {
ImGui.TextUnformatted(versionText); ImGui.SameLine(contentRegionMax - versionWidth);
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
{
ImGui.TextUnformatted(versionText);
}
} }
} }
+308
View File
@@ -0,0 +1,308 @@
using System.Numerics;
using Dalamud.Bindings.ImGui;
using Dalamud.Game.Text;
using Dalamud.Interface.Utility.Raii;
namespace HellionChat.Ui;
// Popup picker for chat-input symbol insertion. Two tabs:
// PUA — Dalamud's SeIconChar enum (161 server-safe FFXIV glyphs)
// BMP — server-verified Unicode symbols (whitelist built 2026-05-16)
//
// Render-only — the Settings-Guard for showing the trigger button lives on
// the caller side (ChatLogWindow). Recent-Used is session state by design.
internal sealed class SymbolPicker
{
private const string PopupId = "HellionSymbolPicker";
private const int RecentCapacity = 16;
private string _search = string.Empty;
private readonly List<uint> _recentUsed = new(capacity: RecentCapacity);
// FFXIV server-safe BMP symbols, verified 2026-05-16 via /echo + /say.
// Filtered ranges: U+2694-26C4 (Misc Symbols Extended), U+2700+ (Dingbats
// Extended), diagonal arrows, U+2153+ fractions, chess pieces.
// Full probe log: Cycles/v1.4.10 BMP-Whitelist Notes.md.
private static readonly (uint Codepoint, string Name)[] BmpWhitelist = new[]
{
(0x00A1u, "Inverted Exclamation"),
(0x00A2u, "Cent Sign"),
(0x00A3u, "Pound Sign"),
(0x00A4u, "Currency Sign"),
(0x00A5u, "Yen Sign"),
(0x00A7u, "Section Sign"),
(0x00A9u, "Copyright Sign"),
(0x00ABu, "Left Angle Quote"),
(0x00AEu, "Registered Sign"),
(0x00B0u, "Degree Sign"),
(0x00B1u, "Plus-Minus Sign"),
(0x00B6u, "Pilcrow Sign"),
(0x00BBu, "Right Angle Quote"),
(0x00BCu, "One Quarter"),
(0x00BDu, "One Half"),
(0x00BEu, "Three Quarters"),
(0x00BFu, "Inverted Question"),
(0x00D7u, "Multiplication Sign"),
(0x00F7u, "Division Sign"),
(0x0393u, "Greek Capital Gamma"),
(0x0394u, "Greek Capital Delta"),
(0x0398u, "Greek Capital Theta"),
(0x039Bu, "Greek Capital Lambda"),
(0x039Eu, "Greek Capital Xi"),
(0x03A0u, "Greek Capital Pi"),
(0x03A3u, "Greek Capital Sigma"),
(0x03A6u, "Greek Capital Phi"),
(0x03A8u, "Greek Capital Psi"),
(0x03A9u, "Greek Capital Omega"),
(0x03B1u, "Greek Small Alpha"),
(0x03B2u, "Greek Small Beta"),
(0x03B3u, "Greek Small Gamma"),
(0x03B4u, "Greek Small Delta"),
(0x03B5u, "Greek Small Epsilon"),
(0x03B6u, "Greek Small Zeta"),
(0x03B7u, "Greek Small Eta"),
(0x03B8u, "Greek Small Theta"),
(0x03B9u, "Greek Small Iota"),
(0x03BAu, "Greek Small Kappa"),
(0x03BBu, "Greek Small Lambda"),
(0x03BCu, "Greek Small Mu"),
(0x03BDu, "Greek Small Nu"),
(0x03BEu, "Greek Small Xi"),
(0x03BFu, "Greek Small Omicron"),
(0x03C0u, "Greek Small Pi"),
(0x03C1u, "Greek Small Rho"),
(0x03C3u, "Greek Small Sigma"),
(0x03C4u, "Greek Small Tau"),
(0x03C5u, "Greek Small Upsilon"),
(0x03C6u, "Greek Small Phi"),
(0x03C7u, "Greek Small Chi"),
(0x03C8u, "Greek Small Psi"),
(0x03C9u, "Greek Small Omega"),
(0x2013u, "En Dash"),
(0x2014u, "Em Dash"),
(0x2020u, "Dagger"),
(0x2021u, "Double Dagger"),
(0x2026u, "Horizontal Ellipsis"),
(0x203Bu, "Reference Mark"),
(0x20ACu, "Euro Sign"),
(0x2122u, "Trade Mark Sign"),
(0x2190u, "Leftwards Arrow"),
(0x2191u, "Upwards Arrow"),
(0x2192u, "Rightwards Arrow"),
(0x2193u, "Downwards Arrow"),
(0x21D2u, "Rightwards Double Arrow"),
(0x21D4u, "Left Right Double Arrow"),
(0x2202u, "Partial Differential"),
(0x2207u, "Nabla"),
(0x2211u, "Summation"),
(0x221Au, "Square Root"),
(0x221Eu, "Infinity"),
(0x222Bu, "Integral"),
(0x2260u, "Not Equal To"),
(0x25A0u, "Black Square"),
(0x25A1u, "White Square"),
(0x25B2u, "Black Up Triangle"),
(0x25B3u, "White Up Triangle"),
(0x25BCu, "Black Down Triangle"),
(0x25C6u, "Black Diamond"),
(0x25C7u, "White Diamond"),
(0x25CBu, "White Circle"),
(0x25CFu, "Black Circle"),
(0x2600u, "Black Sun With Rays"),
(0x2601u, "Cloud"),
(0x2602u, "Umbrella"),
(0x2603u, "Snowman"),
(0x2605u, "Black Star"),
(0x2606u, "White Star"),
(0x2640u, "Female Sign"),
(0x2642u, "Male Sign"),
(0x2660u, "Black Spade Suit"),
(0x2661u, "White Heart Suit"),
(0x2663u, "Black Club Suit"),
(0x2665u, "Black Heart Suit"),
(0x266Au, "Eighth Note"),
(0x2713u, "Check Mark"),
};
public void OpenPopup() => ImGui.OpenPopup(PopupId);
// Returns the inserted codepoint as a string fragment if the user clicked
// one this frame, or null otherwise. Caller splices the fragment into the
// chat-input buffer at the current cursor position.
public string? DrawAndConsume()
{
// ImRaii.Popup auto-disposes EndPopup, same idiom as other popups in
// ChatLogWindow.
using var popup = ImRaii.Popup(PopupId);
if (!popup)
return null;
string? inserted = null;
// Recent-Used-Row sits above the tabs so both PUA and BMP picks share
// one fast-access strip. Session-only by design (see TrackRecent).
if (_recentUsed.Count > 0)
{
ImGui.TextDisabled("Recent");
ImGui.SameLine();
foreach (var codepoint in _recentUsed)
{
var glyph = char.ConvertFromUtf32((int)codepoint);
if (
ImGui.Selectable(
glyph,
false,
ImGuiSelectableFlags.DontClosePopups,
new Vector2(20, 20)
)
)
{
inserted = glyph;
}
ImGui.SameLine();
}
ImGui.NewLine();
ImGui.Separator();
}
using (var tabs = ImRaii.TabBar("##symbolpicker-tabs"))
{
if (tabs)
{
inserted = DrawPuaTab() ?? inserted;
inserted = DrawBmpTab() ?? inserted;
}
}
if (inserted is not null)
TrackRecent(inserted);
return inserted;
}
private string? DrawPuaTab()
{
using var tab = ImRaii.TabItem("FFXIV Icons");
if (!tab)
return null;
ImGui.InputTextWithHint(
"##pua-search",
"Search by name (e.g. HighQuality)",
ref _search,
64
);
string? inserted = null;
if (ImGui.BeginChild("##pua-grid", new Vector2(0, 280), false))
{
var query = _search;
foreach (var icon in Enum.GetValues<SeIconChar>())
{
var label = icon.ToString();
if (
query.Length > 0
&& label.IndexOf(query, StringComparison.OrdinalIgnoreCase) < 0
)
{
continue;
}
// ToIconString gives the single-codepoint glyph; tooltip
// carries the enum name for discoverability.
if (
ImGui.Selectable(
icon.ToIconString(),
false,
ImGuiSelectableFlags.DontClosePopups,
new Vector2(24, 24)
)
)
{
inserted = icon.ToIconString();
}
if (ImGui.IsItemHovered())
ImGui.SetTooltip(label);
// Manually-wrapping pattern from imgui_demo.cpp;
// GetWindowContentRegionMax obsolete since ImGui 1.92, use
// GetContentRegionAvail (see ChatLogWindow.cs:840).
var style = ImGui.GetStyle();
var lastItemX2 = ImGui.GetItemRectMax().X;
var availableRightX =
ImGui.GetCursorScreenPos().X + ImGui.GetContentRegionAvail().X;
if (lastItemX2 + style.ItemSpacing.X + 24f < availableRightX)
ImGui.SameLine();
}
}
ImGui.EndChild();
return inserted;
}
private string? DrawBmpTab()
{
using var tab = ImRaii.TabItem("Symbols");
if (!tab)
return null;
ImGui.InputTextWithHint("##bmp-search", "Search by name (e.g. Heart)", ref _search, 64);
string? inserted = null;
if (ImGui.BeginChild("##bmp-grid", new Vector2(0, 280), false))
{
var query = _search;
foreach (var (codepoint, name) in BmpWhitelist)
{
if (query.Length > 0 && name.IndexOf(query, StringComparison.OrdinalIgnoreCase) < 0)
{
continue;
}
var glyph = char.ConvertFromUtf32((int)codepoint);
if (
ImGui.Selectable(
glyph,
false,
ImGuiSelectableFlags.DontClosePopups,
new Vector2(24, 24)
)
)
{
inserted = glyph;
}
if (ImGui.IsItemHovered())
ImGui.SetTooltip(name);
// Same manually-wrapping pattern as DrawPuaTab — modern API
// since GetWindowContentRegionMax was deprecated in ImGui 1.92.
var style = ImGui.GetStyle();
var lastItemX2 = ImGui.GetItemRectMax().X;
var availableRightX =
ImGui.GetCursorScreenPos().X + ImGui.GetContentRegionAvail().X;
if (lastItemX2 + style.ItemSpacing.X + 24f < availableRightX)
ImGui.SameLine();
}
}
ImGui.EndChild();
return inserted;
}
private void TrackRecent(string fragment)
{
if (string.IsNullOrEmpty(fragment) || fragment.Length > 4)
return;
var codepoint = (uint)char.ConvertToUtf32(fragment, 0);
// Move-to-front so the head stays the freshest pick.
_recentUsed.RemoveAll(c => c == codepoint);
_recentUsed.Insert(0, codepoint);
if (_recentUsed.Count > RecentCapacity)
_recentUsed.RemoveAt(_recentUsed.Count - 1);
}
}
+11 -36
View File
@@ -1,22 +1,11 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
/// <summary> // Pure string resolver logic with no Dalamud dependency, kept in its own
/// Reine String-Resolver-Logik ohne Dalamud-Dependency. Bewusst in // file so tests (HellionChat.Tests, no Dalamud reference) can call it directly.
/// eigener Datei (Dependency-Boundary auf File-Level sichtbar), damit // Used in the settings UI glyph picker and indirectly via TabIconMapping.Resolve.
/// Tests (HellionChat.Tests, Microsoft.NET.Sdk ohne Dalamud-Reference)
/// sie aufrufen können, ohne dass die JIT beim Methodenaufruf die
/// Dalamud-Assembly laden muss.
///
/// Wird im Settings-UI (T7) für die Glyph-Picker-Combobox und im
/// Render-Code indirekt über <see cref="TabIconMapping.Resolve(Tab)"/>
/// verwendet.
/// </summary>
internal static class TabIconGlyphResolver internal static class TabIconGlyphResolver
{ {
/// <summary> // Single source of truth for the glyph set; order matches the settings combobox.
/// Picker-Options-Pool — Single Source of Truth für das Glyph-Set.
/// Reihenfolge ist die UI-Reihenfolge im Settings-Tab Icon-Combobox.
/// </summary>
public static readonly IReadOnlyList<string> PickerOptions = public static readonly IReadOnlyList<string> PickerOptions =
[ [
"comment", "comment",
@@ -36,20 +25,13 @@ internal static class TabIconGlyphResolver
"fire", "fire",
]; ];
/// <summary> // Derived from PickerOptions -- never maintain this manually.
/// Glyph-Set, das überhaupt als Override akzeptiert wird. Aus
/// <see cref="PickerOptions"/> abgeleitet — KnownGlyphs nie
/// manuell pflegen.
/// </summary>
private static readonly HashSet<string> KnownGlyphs = new( private static readonly HashSet<string> KnownGlyphs = new(
PickerOptions, PickerOptions,
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
); );
/// <summary> // Tab.Name is localised, so we match against a pool of DE/EN synonyms.
/// Tab-Name → Default-Glyph-Name. Tab.Name wird per Lokalisierung
/// gesetzt; wir matchen daher gegen einen Pool aus DE/EN-Synonymen.
/// </summary>
private static readonly Dictionary<string, string> NameDefaults = new( private static readonly Dictionary<string, string> NameDefaults = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -69,18 +51,11 @@ internal static class TabIconGlyphResolver
["tell"] = "envelope", ["tell"] = "envelope",
}; };
/// <summary> // Resolves the glyph name for a tab. Priority order:
/// Test-Surface: Glyph-Name-Resolver ohne Dalamud-Dependency. // 1. Tab.Icon override (if set): known glyph -> use it, unknown -> "hashtag"
/// Reihenfolge: // 2. Auto-tell tab -> autoTellGlyph if provided, else "clock"
/// 1. Tab.Icon-Override (falls gesetzt und nicht nur Whitespace): // 3. Name default lookup
/// a) bekannter Glyph → diesen Glyph // 4. Fallback "hashtag"
/// b) unbekannter Glyph → harter Fallback "hashtag" (User hat
/// bewusst etwas gesetzt, also überstimmt das die Defaults)
/// 2. Auto-Tell-Tab → <paramref name="autoTellGlyph"/> falls
/// übergeben, sonst "clock".
/// 3. Tab-Name-Default (<see cref="NameDefaults"/>-Lookup)
/// 4. Fallback "hashtag"
/// </summary>
public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null) public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null)
{ {
if (!string.IsNullOrWhiteSpace(tab.Icon)) if (!string.IsNullOrWhiteSpace(tab.Icon))
+8 -35
View File
@@ -2,31 +2,14 @@ using Dalamud.Interface;
namespace HellionChat.Ui; namespace HellionChat.Ui;
/// <summary> // Default icon mapping for tabs, used in top-tabs (icon prefix) and sidebar (icon-only with tooltip).
/// Default-Icon-Mapping für Tabs. v1.2.0 Layout-Refresh nutzt das // Users can override per tab via Settings -> Tabs -> Tab.Icon.
/// in Top-Tabs (Icon-Prefix) und Sidebar (Icon-only mit Tooltip). // Pure string resolver logic lives in TabIconGlyphResolver (no Dalamud dependency) for testability.
/// User können in Settings → Tabs per Tab.Icon-Override eigene
/// FontAwesome-Glyphen setzen.
///
/// Diese Klasse ist Dalamud-abhängig (FontAwesomeIcon-Enum). Die
/// reine String-Resolver-Logik liegt bewusst in
/// <see cref="TabIconGlyphResolver"/> (eigene Datei, ohne
/// Dalamud-Imports), damit Tests sie ohne Dalamud-Reference aufrufen
/// können.
/// </summary>
internal static class TabIconMapping internal static class TabIconMapping
{ {
/// <summary> // Glyph name -> FontAwesomeIcon lookup for production resolve.
/// FontAwesome-Glyph-Name → Icon-Enum-Lookup. Wird für die // Every key must also exist in TabIconGlyphResolver.PickerOptions.
/// Production-Resolve-API benötigt. // A missing key silently falls back to FontAwesomeIcon.Hashtag (degraded, no crash).
///
/// INVARIANTE: Jeder Key in <see cref="GlyphLookup"/> muss auch in
/// <see cref="TabIconGlyphResolver.PickerOptions"/> stehen. Wird
/// ein Glyph zu PickerOptions hinzugefügt, aber nicht hier, fällt
/// die Override-Auflösung still auf <see cref="FontAwesomeIcon.Hashtag"/>
/// zurück (degraded, kein Crash). Build-Time-Enforcement ist nicht
/// möglich, weil PickerOptions ohne Dalamud-Reference auskommt.
/// </summary>
private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new( private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -48,23 +31,13 @@ internal static class TabIconMapping
["fire"] = FontAwesomeIcon.Fire, ["fire"] = FontAwesomeIcon.Fire,
}; };
/// <summary> // Resolves the icon for a tab. Auto-tell tabs get a per-partner hashed icon
/// Production-Surface: liefert das Icon für einen Tab. Wrapper um // from the tell pool so parallel tells differ by glyph shape, not just colour.
/// <see cref="TabIconGlyphResolver.ResolveGlyphName(Tab)"/> plus
/// Enum-Lookup. Wird von Render-Code (T3, T5) verwendet.
/// </summary>
public static FontAwesomeIcon Resolve(Tab tab) public static FontAwesomeIcon Resolve(Tab tab)
{ {
// v1.2.0 — Auto-Tell-Tabs bekommen ein per-Partner gehashtes
// Icon aus dem Tell-Pool. Damit unterscheiden sich parallele
// Tells nicht nur über die Color (For), sondern auch über die
// Glyph-Form. Berechnung bleibt hier (Dalamud-bound), weil
// TellTarget Dalamud-Imports hat.
string? autoTellGlyph = null; string? autoTellGlyph = null;
if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet()) if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet())
{
autoTellGlyph = TabTintCache.GetIcon(tab); autoTellGlyph = TabTintCache.GetIcon(tab);
}
var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph); var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph);
return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag; return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag;
+26 -30
View File
@@ -17,10 +17,9 @@ internal static class AutoTranslate
private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new(); private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new();
private static readonly HashSet<(uint, uint)> ValidEntries = []; private static readonly HashSet<(uint, uint)> ValidEntries = [];
// Serializes all reads and writes against Entries / ValidEntries. // Serialises all reads/writes against Entries and ValidEntries.
// PreloadCache spawns a worker thread that fills both, while the main // PreloadCache fills both from a worker thread while the main thread
// thread reads them via Matching / ReplaceWithPayload / StartsWithCommand // reads via Matching/ReplaceWithPayload/StartsWithCommand.
// — without this lock the HashSet/Dictionary access is undefined.
private static readonly object EntriesLock = new(); private static readonly object EntriesLock = new();
private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser() private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser()
@@ -54,21 +53,27 @@ internal static class AutoTranslate
return Map((name, sel) => (name, sel), sheetName, selector.Optional()); return Map((name, sel) => (name, sel), sheetName, selector.Optional());
} }
/// <summary> // Warms the auto-translate cache on a background thread so the first
/// Preloads auto-translate entries into the cache for the current game // message send doesn't hitch the main thread. IsBackground keeps plugin
/// language. Without this, the first message will take a long time to send // unload non-blocking even if the warmup is still in flight.
/// (which causes a hitch in the main thread).
///
/// This spawns a new thread.
/// </summary>
internal static void PreloadCache() internal static void PreloadCache()
{ {
new Thread(() => var thread = new Thread(() =>
{ {
var sw = Stopwatch.StartNew(); var sw = Stopwatch.StartNew();
AllEntries(); AllEntries();
Plugin.Log.Debug($"Warming up auto-translate took {sw.ElapsedMilliseconds}ms"); // v1.4.9 R3 profiling: Information so the xllog tail surfaces this
}).Start(); // without a Debug filter. Belt-and-suspenders for future plugin-load
// regressions; remains in place after Sub-Task 3.4 Befund.
Plugin.LogProxy.Information(
$"Warming up auto-translate took {sw.ElapsedMilliseconds}ms"
);
})
{
IsBackground = true,
Name = "HellionChat-AutoTranslate-Warmup",
};
thread.Start();
} }
private static List<AutoTranslateEntry> AllEntries() private static List<AutoTranslateEntry> AllEntries()
@@ -104,7 +109,7 @@ internal static class AutoTranslate
{ {
if (lookup is not ("" or "@")) if (lookup is not ("" or "@"))
{ {
// SE added whitespace to the newest additions, but ParseOrThrow doesn't see them as valid // SE added whitespace to newer entries; strip it before parsing.
lookup = lookup.Replace(" ", ""); lookup = lookup.Replace(" ", "");
var (sheetName, selector) = parser.ParseOrThrow(lookup); var (sheetName, selector) = parser.ParseOrThrow(lookup);
@@ -144,19 +149,13 @@ internal static class AutoTranslate
columns.Add(0); columns.Add(0);
if (rows.Count == 0) if (rows.Count == 0)
// We can't use an "index from end" (like `^0`) here because // Can't use index-from-end here because we iterate over integers,
// we're iterating over integers, not an array directly. // not an array directly. `0..^0` would silently skip the sheet.
// Previously, we were setting `0..^0` which caused these
// sheets to be completely skipped due to this bug.
// See below.
rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1)); rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1));
foreach (var range in rows) foreach (var range in rows)
{ {
// We iterate over the range by numerical values here, so // Integer iteration -- can't use index-from-end (see above).
// we can't use an "index from end" otherwise nothing will
// happen.
// See above.
for (var i = range.Start.Value; i < range.End.Value; i++) for (var i = range.Start.Value; i < range.End.Value; i++)
{ {
if (!sheet.TryGetRow((uint)i, out var rowParser)) if (!sheet.TryGetRow((uint)i, out var rowParser))
@@ -203,7 +202,7 @@ internal static class AutoTranslate
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, $"failed to translate: {lookup}"); Plugin.LogProxy.Error(ex, $"failed to translate: {lookup}");
} }
} }
@@ -261,7 +260,6 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return; return;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
@@ -308,9 +306,8 @@ internal static class AutoTranslate
start = -1; start = -1;
} }
// Pure managed comparison via Span avoids the msvcrt.dll P/Invoke, // Span comparison avoids the msvcrt.dll P/Invoke which is fragile
// which is fragile under Wine and triggered an extra managed-to- // under Wine and caused an extra managed-to-unmanaged copy per check.
// unmanaged copy per check.
if ( if (
i + search.Length < bytes.Length i + search.Length < bytes.Length
&& bytes.AsSpan(i, search.Length).SequenceEqual(search) && bytes.AsSpan(i, search.Length).SequenceEqual(search)
@@ -325,7 +322,6 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return false; return false;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
+16
View File
@@ -0,0 +1,16 @@
namespace HellionChat.Util;
internal sealed class DalamudPlatformUtil : IPlatformUtil
{
public DalamudPlatformUtil()
{
// Util.IsWine probes the host process and never changes for the
// lifetime of a plugin instance, so we cache it once at ctor.
// Mirrors LightlessSync/Services/DalamudUtilService:154.
IsWine = Dalamud.Utility.Util.IsWine();
}
public bool IsWine { get; }
public void OpenLink(string url) => Dalamud.Utility.Util.OpenLink(url);
}
+61
View File
@@ -0,0 +1,61 @@
using System;
using Dalamud.Plugin.Services;
namespace HellionChat.Util;
internal sealed class DalamudPluginLogProxy : IPluginLogProxy
{
private readonly IPluginLog _log;
public DalamudPluginLogProxy(IPluginLog log) => _log = log;
public void Verbose(string message) => _log.Verbose(message);
public void Verbose(Exception exception, string message) => _log.Verbose(exception, message);
public void Verbose(string messageTemplate, params object[] values) =>
_log.Verbose(messageTemplate, values);
public void Debug(string message) => _log.Debug(message);
public void Debug(Exception exception, string message) => _log.Debug(exception, message);
public void Debug(string messageTemplate, params object[] values) =>
_log.Debug(messageTemplate, values);
public void Information(string message) => _log.Information(message);
public void Information(Exception exception, string message) =>
_log.Information(exception, message);
public void Information(string messageTemplate, params object[] values) =>
_log.Information(messageTemplate, values);
public void Info(string message) => _log.Info(message);
public void Info(Exception exception, string message) => _log.Info(exception, message);
public void Info(string messageTemplate, params object[] values) =>
_log.Info(messageTemplate, values);
public void Warning(string message) => _log.Warning(message);
public void Warning(Exception exception, string message) => _log.Warning(exception, message);
public void Warning(string messageTemplate, params object[] values) =>
_log.Warning(messageTemplate, values);
public void Error(string message) => _log.Error(message);
public void Error(Exception exception, string message) => _log.Error(exception, message);
public void Error(string messageTemplate, params object[] values) =>
_log.Error(messageTemplate, values);
public void Fatal(string message) => _log.Fatal(message);
public void Fatal(Exception exception, string message) => _log.Fatal(exception, message);
public void Fatal(string messageTemplate, params object[] values) =>
_log.Fatal(messageTemplate, values);
}
+3 -9
View File
@@ -10,9 +10,8 @@ public static class GlobalParametersCache
public static int GetValue(int index) public static int GetValue(int index)
{ {
// Capture the array reference once so the bounds check and the // Capture the array reference once so bounds check and read operate
// indexed read operate on the same instance, even if Refresh // on the same instance if Refresh reassigns Cache between the two.
// reassigns Cache between the two operations.
var cache = Cache; var cache = Cache;
if (index < 0 || index >= cache.Length) if (index < 0 || index >= cache.Length)
return 0; return 0;
@@ -20,12 +19,7 @@ public static class GlobalParametersCache
return cache[index]; return cache[index];
} }
/// <summary> // Refreshes the cache from RaptureTextModule. Must be called on the main thread.
/// Refresh the cache of global parameters from RaptureTextModule.
/// </summary>
/// <remarks>
/// This should be called in the main thread when updates are necessary.
/// </remarks>
public static unsafe void Refresh() public static unsafe void Refresh()
{ {
if (!ThreadSafety.IsMainThread) if (!ThreadSafety.IsMainThread)
+11
View File
@@ -0,0 +1,11 @@
namespace HellionChat.Util;
// Indirection over Dalamud.Utility.Util's static surface so services can be
// constructed in an isolated xUnit AppDomain without loading Dalamud.dll.
// Production wiring lives in DalamudPlatformUtil; tests substitute a fake.
internal interface IPlatformUtil
{
bool IsWine { get; }
void OpenLink(string url);
}
+40
View File
@@ -0,0 +1,40 @@
using System;
namespace HellionChat.Util;
// Plugin.LogProxy bridge for consumers that cannot take a logger via the
// constructor: static helpers (EmoteCache et al.), Dalamud-reflected types
// (Configuration), data classes with mass instantiation (Message) and
// instance classes that only log from static methods (FontManager).
internal interface IPluginLogProxy
{
void Verbose(string message);
void Verbose(Exception exception, string message);
void Verbose(string messageTemplate, params object[] values);
void Debug(string message);
void Debug(Exception exception, string message);
void Debug(string messageTemplate, params object[] values);
void Information(string message);
void Information(Exception exception, string message);
void Information(string messageTemplate, params object[] values);
// IPluginLog exposes Info as a distinct method (short alias of
// Information) — both are present so call-sites stay drop-in.
void Info(string message);
void Info(Exception exception, string message);
void Info(string messageTemplate, params object[] values);
void Warning(string message);
void Warning(Exception exception, string message);
void Warning(string messageTemplate, params object[] values);
void Error(string message);
void Error(Exception exception, string message);
void Error(string messageTemplate, params object[] values);
void Fatal(string message);
void Fatal(Exception exception, string message);
void Fatal(string messageTemplate, params object[] values);
}
+9 -37
View File
@@ -11,8 +11,7 @@ public readonly unsafe ref struct GfdFileView
private readonly ReadOnlySpan<byte> Span; private readonly ReadOnlySpan<byte> Span;
private readonly bool DirectLookup; private readonly bool DirectLookup;
/// <summary>Initializes a new instance of the <see cref="GfdFileView"/> struct.</summary> // span: raw .gfd file bytes
/// <param name="span">The data.</param>
public GfdFileView(ReadOnlySpan<byte> span) public GfdFileView(ReadOnlySpan<byte> span)
{ {
Span = span; Span = span;
@@ -27,18 +26,13 @@ public readonly unsafe ref struct GfdFileView
DirectLookup &= i + 1 == entries[i].Id; DirectLookup &= i + 1 == entries[i].Id;
} }
/// <summary>Gets the header.</summary>
private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span); private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span);
/// <summary>Gets the entries.</summary>
private ReadOnlySpan<GfdEntry> Entries => private ReadOnlySpan<GfdEntry> Entries =>
MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]); MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]);
/// <summary>Attempts to get an entry.</summary> // Returns true if the entry was found.
/// <param name="iconId">The icon ID.</param> // followRedirect: whether to chase redirect chains.
/// <param name="entry">The entry.</param>
/// <param name="followRedirect">Whether to follow redirects.</param>
/// <returns><c>true</c> if found.</returns>
public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true) public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true)
{ {
if (iconId == 0) if (iconId == 0)
@@ -50,9 +44,8 @@ public readonly unsafe ref struct GfdFileView
var entries = Entries; var entries = Entries;
if (DirectLookup) if (DirectLookup)
{ {
// Resolve redirects on the direct-lookup path too — the binary-search // Follow redirects on the direct-lookup path for consistency with
// path follows them, and skipping them here was inconsistent for // the binary-search path.
// contiguous ID sets.
var visited = 0; var visited = 0;
while (iconId <= entries.Length) while (iconId <= entries.Length)
{ {
@@ -107,49 +100,28 @@ public readonly unsafe ref struct GfdFileView
return false; return false;
} }
/// <summary>Header of a .gfd file.</summary> // .gfd file header
[StructLayout(LayoutKind.Sequential)] [StructLayout(LayoutKind.Sequential)]
public struct GfdHeader public struct GfdHeader
{ {
/// <summary>Signature: "gftd0100".</summary> public fixed byte Signature[8]; // "gftd0100"
public fixed byte Signature[8];
/// <summary>Number of entries.</summary>
public int Count; public int Count;
/// <summary>Unused/unknown.</summary>
public fixed byte Padding[4]; public fixed byte Padding[4];
} }
/// <summary>An entry of a .gfd file.</summary> // .gfd file entry -- one icon slot
[StructLayout(LayoutKind.Sequential, Size = 0x10)] [StructLayout(LayoutKind.Sequential, Size = 0x10)]
public struct GfdEntry public struct GfdEntry
{ {
/// <summary>ID of the entry.</summary>
public ushort Id; public ushort Id;
/// <summary>The left offset of the entry.</summary>
public ushort Left; public ushort Left;
/// <summary>The top offset of the entry.</summary>
public ushort Top; public ushort Top;
/// <summary>The width of the entry.</summary>
public ushort Width; public ushort Width;
/// <summary>The height of the entry.</summary>
public ushort Height; public ushort Height;
/// <summary>Unknown/unused.</summary>
public ushort Unk0A; public ushort Unk0A;
public ushort Redirect; // non-zero = redirects to another entry
/// <summary>The redirected entry, maybe.</summary>
public ushort Redirect;
/// <summary>Unknown/unused.</summary>
public ushort Unk0E; public ushort Unk0E;
/// <summary>Gets a value indicating whether this entry is effectively empty.</summary>
public bool IsEmpty => Width == 0 || Height == 0; public bool IsEmpty => Width == 0 || Height == 0;
} }
} }
+15 -5
View File
@@ -254,6 +254,17 @@ internal static class ImGuiUtil
return end; return end;
} }
// ---------------------------------------------------------------
// Inspired by ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).
// Upstream dropped the width parameter (no callers there); we keep
// it because two ChatLogWindow header buttons size themselves to
// match the ChannelIcon button's frame. The actual bug is the
// manual size = width - 2 * CellPadding.X subtraction: CellPadding
// scales with HUD scale, the raw int does not, so the button
// shrank under high HUD scales. ImGui.Button already handles its
// own frame padding internally — pass the measured width straight
// through.
// ---------------------------------------------------------------
internal static bool IconButton( internal static bool IconButton(
FontAwesomeIcon icon, FontAwesomeIcon icon,
string? id = null, string? id = null,
@@ -268,10 +279,7 @@ internal static class ImGuiUtil
bool ret; bool ret;
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
{ {
var size = Vector2.Zero; var size = width > 0 ? new Vector2(width, 0f) : Vector2.Zero;
if (width > 0)
size.X = width - 2 * ImGui.GetStyle().CellPadding.X;
ret = ImGui.Button(label, size); ret = ImGui.Button(label, size);
} }
@@ -575,7 +583,9 @@ internal static class ImGuiUtil
using (ImRaii.Disabled(isMax)) using (ImRaii.Disabled(isMax))
{ {
if (IconButton(FontAwesomeIcon.ArrowRight, id + 1.ToString())) // Parentheses pin the operator precedence: without them this resolves as
// id.ToString() + "1" (e.g. "01" instead of "1").
if (IconButton(FontAwesomeIcon.ArrowRight, (id + 1).ToString()))
selected++; selected++;
} }
+2 -10
View File
@@ -31,18 +31,10 @@ public static class MathUtil
public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}"; public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}";
} }
/// <summary> // Standard AABB overlap test. Inclusive on both axes to catch shared
/// Checks if two rectangles overlap at any point. // edges and identical rectangles (previous ValueInRange approach missed these).
/// </summary>
/// <param name="a"></param>
/// <param name="b"></param>
/// <returns>True if overlapping</returns>
public static bool HasOverlap(this Rectangle a, Rectangle b) public static bool HasOverlap(this Rectangle a, Rectangle b)
{ {
// Standard AABB overlap test: two rectangles overlap iff they
// overlap on both axes. The previous nested ValueInRange approach
// used strict inequalities at both ends, which dropped identical
// rectangles and shared-edge cases as false negatives.
return a.X < b.X + b.Width return a.X < b.X + b.Width
&& a.X + a.Width > b.X && a.X + a.Width > b.X
&& a.Y < b.Y + b.Height && a.Y < b.Y + b.Height
+1 -1
View File
@@ -42,6 +42,6 @@ public static class MemoryUtil
str.Append(' '); str.Append(' ');
} }
Plugin.Log.Information(str.ToString()); Plugin.LogProxy.Information(str.ToString());
} }
} }

Some files were not shown because too many files have changed in this diff Show More