Compare commits

..

2 Commits

Author SHA1 Message Date
JonKazama-Hellion 2736551505 Bump to 0.3.1 with the upstream emote regression fix
Quick patch release. The previous commit on this branch is a
straight cherry-pick of Infi's upstream "Fix a regression from
API 15 updates" (ff899ff), which restores BetterTTV emote
deserialisation by switching the Emote and Top100 DTOs from
public fields to public properties so System.Text.Json picks up
the [JsonPropertyName] attributes correctly.

Without this, a fresh Hellion Chat install would happily fetch
emote JSON from BetterTTV but every entry would deserialise to
empty defaults, leaving the cache silently empty.

Manifest version bumps from 0.3.0 to 0.3.1 in csproj, the
HellionChat.yaml manifest plus its changelog, the custom-repo
repo.json (assembly version, testing assembly version and the
three download links), and the README version banner. The 0.3.0
changelog entry stays underneath in chronological order.

Build (Release) verified clean.
2026-05-02 04:11:13 +02:00
Infi 0679a0e57a Fix a regression from API 15 updates
(cherry picked from commit ff899ffe54ef76bcdf9c13b5690957c5b5e17637)
2026-05-02 04:10:22 +02:00
5 changed files with 31 additions and 14 deletions
+1 -1
View File
@@ -4,7 +4,7 @@
0.1.0 is our bootstrap release; the underlying Chat 2 base is 0.1.0 is our bootstrap release; the underlying Chat 2 base is
called out in the yaml changelog so users can see what it called out in the yaml changelog so users can see what it
derives from. --> derives from. -->
<Version>0.3.0</Version> <Version>0.3.1</Version>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
<!-- HellionChat fork: assembly is renamed so Dalamud uses <!-- HellionChat fork: assembly is renamed so Dalamud uses
pluginConfigs/HellionChat instead of pluginConfigs/ChatTwo, pluginConfigs/HellionChat instead of pluginConfigs/ChatTwo,
+5 -5
View File
@@ -32,23 +32,23 @@ public static class EmoteCache
private struct Top100() private struct Top100()
{ {
[JsonPropertyName("emote")] [JsonPropertyName("emote")]
public Emote Emote = default; public Emote Emote { get; set; }
[JsonPropertyName("id")] [JsonPropertyName("id")]
public string Id = string.Empty; public string Id { get; set; }
} }
[Serializable] [Serializable]
public struct Emote() public struct Emote()
{ {
[JsonPropertyName("id")] [JsonPropertyName("id")]
public string Id = string.Empty; public string Id { get; set; }
[JsonPropertyName("code")] [JsonPropertyName("code")]
public string Code = string.Empty; public string Code { get; set; }
[JsonPropertyName("imageType")] [JsonPropertyName("imageType")]
public string ImageType = string.Empty; public string ImageType { get; set; }
} }
public enum LoadingState public enum LoadingState
+17
View File
@@ -40,6 +40,23 @@ tags:
- Replacement - Replacement
- Privacy - Privacy
changelog: |- changelog: |-
**Hellion Chat 0.3.1 — Upstream emote regression fix**
Cherry-picks Infi's upstream commit ff899ff "Fix a regression
from API 15 updates" which changes the BetterTTV emote DTOs
(Emote and Top100) from public fields to public properties.
System.Text.Json under the API 15 toolchain only honours the
[JsonPropertyName] attribute on properties, so the previous
field-based version deserialised every fetched emote into empty
default values. Result: BetterTTV emotes were silently broken
on fresh installs. The fix is six lines and applies cleanly on
top of our defensive null-check from earlier; the EmoteCache
path-traversal hardening from 0.3.0 stays as it is.
Authorship of the fix is preserved with git cherry-pick -x, so
Infi shows up as the author on the commit. Thanks to him for
catching it in the upstream codebase.
**Hellion Chat 0.3.0 — Audit hardening, brand sweep and rebrand of slash commands** **Hellion Chat 0.3.0 — Audit hardening, brand sweep and rebrand of slash commands**
This release closes the remaining audit follow-ups from the This release closes the remaining audit follow-ups from the
+2 -2
View File
@@ -1,6 +1,6 @@
# Hellion Chat # Hellion Chat
**Version 0.3.0** — DSGVO-bewusste Erweiterung von [Chat 2](https://github.com/Infiziert90/ChatTwo) für FINAL FANTASY XIV / Dalamud. **Version 0.3.1** — DSGVO-bewusste Erweiterung von [Chat 2](https://github.com/Infiziert90/ChatTwo) für FINAL FANTASY XIV / Dalamud.
Hellion Chat baut auf Chat 2 auf und ergänzt es um Datenschutz- und Daten-Handling-Kontrollen, die mit den Datenschutz-Regeln in der EU, den USA und Japan im Einklang sind. Alle Chat-2-Funktionen, Befehle und Tastenkürzel funktionieren unverändert. Eigenständiger Plugin-Slot, eigene Konfiguration, eigene Datenbank. Hellion Chat baut auf Chat 2 auf und ergänzt es um Datenschutz- und Daten-Handling-Kontrollen, die mit den Datenschutz-Regeln in der EU, den USA und Japan im Einklang sind. Alle Chat-2-Funktionen, Befehle und Tastenkürzel funktionieren unverändert. Eigenständiger Plugin-Slot, eigene Konfiguration, eigene Datenbank.
@@ -231,7 +231,7 @@ Konflikte in Upstream-Sprach-Ressourcen (`Language.<lang>.resx`) kommen häufig
## Projektstatus ## Projektstatus
**Version 0.3.0** | Stand: Mai 2026 **Version 0.3.1** | Stand: Mai 2026
Alle Bootstrap-Phasen abgeschlossen: Alle Bootstrap-Phasen abgeschlossen:
+6 -6
View File
File diff suppressed because one or more lines are too long