JonKazama-Hellion
eca566321a
Reported by Carla: a tell arriving while you are typing pulls the focus away. The interruption is the visible half. The sharp half is that the input buffer belongs to the WINDOW while the send target is read off whatever tab is active at Enter -- so a line typed at one person could leave addressed to whoever just wrote, and in this game losing the keyboard means the next sentence walks the character around. Nothing is revealed now while any chat surface is mid-sentence, in any mode. The tab still appears and still carries its unread mark. The check lives in its own file because the answer has to be identical everywhere: it started inside the reveal plan, and a second pop-out path walked straight past it -- AutoTellTabsService opened windows off its own flag, at tab creation, a tick before the router was ever asked. Those two paths are one now. AutoTellTabsOpenAsPopout and TellAutoOpenMode were two settings for one decision, and the older one won every race, which is why the other looked inert. Config schema 28 carries the old flag forward so nobody's behaviour changes. "Off" went with it: it never stopped the tab from being created -- that is the auto-tell switch -- it only stopped the jump to it, which is what the switch below it does. Also in here, all from the same corner of the code: - Closing a tab was lost in the v2.0.0 rebuild. The trash entry lived in the retired ChatLogWindow menu, and the rebuilt one restored rename, sound, pop-out and pinning but not this. For tell tabs that left no way out at all: IsEditable keeps them out of the settings editor on purpose and points at the context menu, which could not close them either. Pinned tell tabs stay disabled with a tooltip rather than absent. - Re-anchoring the active tab used an unconditional Tabs[0] in three places, and Tabs[0] can be popped out -- so it ran OnTabActivated over a tab live in its own window and stripped its tell binding. With every tab popped, the seed and the re-anchor also fought each other every frame. - PinTab_LimitReached still pointed at "Promote to permanent", removed in May. Spanish said "Desija", which is not a word; Greek left "tell tabs" untranslated; pt-PT broke its own unpin verb. - Pop Out was a hardcoded English literal despite the key existing in all 25 languages since v1.5.6, and the tell-open modes were the last English display names in the plugin. - Segmented setting rows measured 200px flat, which cut German labels in half. They size to their longest label now. - Metrics.Scale still called GlobalScaleSafe. It is an alias for GlobalScale in current Dalamud, and dropping it clears the last compiler warning in the project.
26 lines
1.1 KiB
C#
26 lines
1.1 KiB
C#
namespace HellionChat.Util;
|
|
|
|
// "The user is mid-sentence somewhere." Asked before a tell is revealed, in any
|
|
// mode. Its own file because the answer has to be identical everywhere it is
|
|
// asked: this started as a guard inside the reveal plan, and a SECOND pop-out
|
|
// path walked straight past it -- the window opened anyway, took the keyboard
|
|
// with it, and in this game the next typed sentence walks the character around.
|
|
// The paths are one now, but a shared answer is what keeps it that way.
|
|
internal static class ChatInputBusy
|
|
{
|
|
// Reads two fields the draw path wrote; no ImGui call, so it is safe from the
|
|
// framework thread. Call it THERE, not from the message worker: the worker
|
|
// runs ahead of the frame and would sample a stale answer.
|
|
internal static bool Any()
|
|
{
|
|
if (Plugin.Instance.MainWindow is { IsInputBusy: true })
|
|
return true;
|
|
|
|
foreach (var window in Plugin.Instance.ChannelPopoutPool.Instances)
|
|
if (window is { IsOpen: true, IsInputBusy: true })
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
}
|