JonKazama-Hellion
4d54eabdac
General code-quality and robustness pass across the plugin: thread- safety on IPC state, resource-disposal cleanups, input validation, defensive null-checks and a few small UX glitches. Compliance docs (THIRD_PARTY_NOTICES, PRIVACY, COPYRIGHT) refreshed to v1.0.3. Highlights - ExtraChat IPC state synchronised across threads - ChatLogWindow autocomplete no longer leaks the unmanaged ImGuiListClipper allocation - ChatLogWindow + Popout style stack stays balanced when config toggles mid-frame - Retention sweep and privacy cleanup wait for the actual filter pass instead of the fire-and-forget Task that started it - Configuration.LatestVersion bumped to 13 to match the active migration path - GameFunctions placeholder buffer guarded against oversized replacement names - TellTarget.IsSet, ResolveTempInputChannel, InputPreview, IconUtil, Lender, Payloads, ExtraPayload all hardened against null / empty / EOF / cycle inputs - FontManager Lodestone download stays in scope for a follow-up (timeout + lazy init pending) - AutoTranslate replaced the msvcrt.dll memcmp P/Invoke with a managed Span comparison - Privacy cleanup worker thread marked IsBackground = true - Database cleanup now removes both legacy files in one click - Tell-target name redacted in the verbose debug log Compliance - THIRD_PARTY_NOTICES: last-reviewed bumped to v1.0.3, Pidgin 3.5.1, SQLitePCLRaw.lib.e_sqlite3 3.50.3 listed as direct dependency with CVE-2025-6965 / CVE-2025-7709 rationale - PRIVACY: last-reviewed bumped to v1.0.3, BetterTTV trigger wording clarified (list fetch at startup vs. on-demand image fetch) - COPYRIGHT: upstream attribution range widened Build: 0 warnings, 0 errors. No behavioural changes that would alter existing user configuration or stored chat history.
68 lines
2.1 KiB
C#
68 lines
2.1 KiB
C#
using System.Numerics;
|
|
using HellionChat.Util;
|
|
using Dalamud.Interface.Utility;
|
|
using Dalamud.Interface.Windowing;
|
|
using Dalamud.Utility;
|
|
using Dalamud.Bindings.ImGui;
|
|
using Lumina.Text.ReadOnly;
|
|
|
|
namespace HellionChat.Ui;
|
|
|
|
public class CommandHelpWindow : Window {
|
|
private ChatLogWindow LogWindow { get; }
|
|
private ReadOnlySeString? CommandDescription { get; set; }
|
|
|
|
internal CommandHelpWindow(ChatLogWindow logWindow) : base("command help##chat2-commandhelp")
|
|
{
|
|
LogWindow = logWindow;
|
|
|
|
Flags = ImGuiWindowFlags.NoSavedSettings | ImGuiWindowFlags.NoTitleBar | ImGuiWindowFlags.NoMove |
|
|
ImGuiWindowFlags.NoResize | ImGuiWindowFlags.NoFocusOnAppearing | ImGuiWindowFlags.AlwaysAutoResize;
|
|
|
|
RespectCloseHotkey = false;
|
|
DisableWindowSounds = true;
|
|
}
|
|
|
|
// Sets IsOpen to true if it should be drawn
|
|
public void UpdateContent(ReadOnlySeString commandDesc)
|
|
{
|
|
CommandDescription = commandDesc;
|
|
|
|
var width = 350;
|
|
var scaledWidth = width * ImGuiHelpers.GlobalScale;
|
|
var pos = LogWindow.LastWindowPos;
|
|
switch (Plugin.Config.CommandHelpSide) {
|
|
case CommandHelpSide.Right:
|
|
pos.X += LogWindow.LastWindowSize.X;
|
|
break;
|
|
case CommandHelpSide.Left:
|
|
pos.X -= scaledWidth;
|
|
break;
|
|
case CommandHelpSide.None:
|
|
default:
|
|
IsOpen = false;
|
|
return;
|
|
}
|
|
|
|
Position = pos;
|
|
SizeConstraints = new WindowSizeConstraints
|
|
{
|
|
// Use scaledWidth here so the size constraints stay in the same
|
|
// coordinate space as Position above; otherwise the help window
|
|
// ends up the wrong width at non-100% DPI.
|
|
MinimumSize = new Vector2(scaledWidth, 0),
|
|
MaximumSize = LogWindow.LastWindowSize with { X = scaledWidth }
|
|
};
|
|
|
|
IsOpen = true;
|
|
}
|
|
|
|
public override void Draw()
|
|
{
|
|
if (CommandDescription == null)
|
|
return;
|
|
|
|
LogWindow.DrawChunks(ChunkUtil.ToChunks(CommandDescription.Value.ToDalamudString(), ChunkSource.None, null).ToList());
|
|
}
|
|
}
|