JonKazama-Hellion
4d54eabdac
General code-quality and robustness pass across the plugin: thread- safety on IPC state, resource-disposal cleanups, input validation, defensive null-checks and a few small UX glitches. Compliance docs (THIRD_PARTY_NOTICES, PRIVACY, COPYRIGHT) refreshed to v1.0.3. Highlights - ExtraChat IPC state synchronised across threads - ChatLogWindow autocomplete no longer leaks the unmanaged ImGuiListClipper allocation - ChatLogWindow + Popout style stack stays balanced when config toggles mid-frame - Retention sweep and privacy cleanup wait for the actual filter pass instead of the fire-and-forget Task that started it - Configuration.LatestVersion bumped to 13 to match the active migration path - GameFunctions placeholder buffer guarded against oversized replacement names - TellTarget.IsSet, ResolveTempInputChannel, InputPreview, IconUtil, Lender, Payloads, ExtraPayload all hardened against null / empty / EOF / cycle inputs - FontManager Lodestone download stays in scope for a follow-up (timeout + lazy init pending) - AutoTranslate replaced the msvcrt.dll memcmp P/Invoke with a managed Span comparison - Privacy cleanup worker thread marked IsBackground = true - Database cleanup now removes both legacy files in one click - Tell-target name redacted in the verbose debug log Compliance - THIRD_PARTY_NOTICES: last-reviewed bumped to v1.0.3, Pidgin 3.5.1, SQLitePCLRaw.lib.e_sqlite3 3.50.3 listed as direct dependency with CVE-2025-6965 / CVE-2025-7709 rationale - PRIVACY: last-reviewed bumped to v1.0.3, BetterTTV trigger wording clarified (list fetch at startup vs. on-demand image fetch) - COPYRIGHT: upstream attribution range widened Build: 0 warnings, 0 errors. No behavioural changes that would alter existing user configuration or stored chat history.
39 lines
1.3 KiB
C#
39 lines
1.3 KiB
C#
using System.Text;
|
|
|
|
namespace HellionChat.Util;
|
|
|
|
public static class MemoryUtil
|
|
{
|
|
// Diagnostic helper. Pointer dereferences here would crash on a null/garbage
|
|
// address and a huge length would log megabytes of raw bytes; both are easy
|
|
// to trigger from a debugger and pollute the log with potentially sensitive
|
|
// game-state. Validate the inputs before reading.
|
|
private const int MaxDumpLength = 4096;
|
|
|
|
public static unsafe void PrintMemoryArea(nint address, int length)
|
|
{
|
|
if (address == nint.Zero)
|
|
throw new ArgumentException("Memory address cannot be zero.", nameof(address));
|
|
if (length <= 0)
|
|
throw new ArgumentOutOfRangeException(nameof(length), length, "Length must be positive.");
|
|
if (length > MaxDumpLength)
|
|
throw new ArgumentOutOfRangeException(nameof(length), length, $"Length exceeds the {MaxDumpLength}-byte safety cap.");
|
|
|
|
var ptr = (byte*)address;
|
|
var str = new StringBuilder("\n");
|
|
for(var i = 0; i < length; i++)
|
|
{
|
|
str.Append($"{ptr![i]:X02}");
|
|
|
|
if (i == 0)
|
|
continue;
|
|
|
|
if ((i+1) % 16 == 0)
|
|
str.Append('\n');
|
|
else if ((i+1) % 4 == 0)
|
|
str.Append(' ');
|
|
}
|
|
|
|
Plugin.Log.Information(str.ToString());
|
|
}
|
|
} |