feat(ui): pin failed-tell log-message ids and drop discovery logging

HellionChat/Integrations/FailedTellNotifier.cs

@@ -39,14 +39,6 @@ internal sealed class FailedTellNotifier : IDisposable
     {
         try
         {
-            // DISCOVERY (Task 2 Step 9): while the id set is empty, log every
-            // call so a failed tell can be triggered in-game and its id read.
-            // Remove this block once FailedTellLogMessageIds is pinned.
-            _logger.LogInformation(
-                "ShowLogMessageString id={Id} value={Value}",
-                logMessageId,
-                value is null ? "<null>" : value->ToString());
-
             if (FailedTellMatcher.ShouldNotify(
                     logMessageId, Plugin.Config.NotifyFailedTell,
                     FailedTellMatcher.FailedTellLogMessageIds))

HellionChat/_Helpers/FailedTellMatcher.cs

@@ -9,12 +9,14 @@ namespace HellionChat._Helpers;
 // TEST-MIRROR: ../../../Hellion Build test/Ui/FailedTellMatcherTests.cs
 public static class FailedTellMatcher
 {
-    // Log-message ids the game raises for a tell that could not be delivered.
-    // Pinned from discovery (see plan Task 2, Step 9). An empty set means the
-    // hook never toasts: "no toast over a false toast" until ids are pinned.
+    // Log-message ids the game raises for a tell that could not be delivered,
+    // pinned from in-game discovery (plan Task 2). 50 covers an unreachable
+    // recipient (offline, non-existent, or on another world); 3832 is a
+    // recipient inside an instance.
     public static readonly IReadOnlySet<uint> FailedTellLogMessageIds = new HashSet<uint>
     {
-        // pinned in Task 2 Step 9
+        50u,
+        3832u,
     };
 
     public static bool ShouldNotify(uint logMessageId, bool notifyEnabled, IReadOnlySet<uint> failedTellIds)