perf(baseline): time full Draw() handler into LastDrawMs field

This commit is contained in:
2026-06-16 19:13:45 +02:00
parent 458df3b4bd
commit 68c4e28495
+26
View File
@@ -166,6 +166,15 @@ public sealed class Plugin : IAsyncDalamudPlugin
// because the tick reads it from a different thread than the writer. // because the tick reads it from a different thread than the writer.
private volatile bool _isDisposing; private volatile bool _isDisposing;
// v1.9.0 B5: last full Draw() wall-time in ms, written once per frame at
// the end of the UiBuilder.Draw handler. Covers the GlobalStyleScope push
// and the font push (§7.5 First-Frame-HITCH must include atlas/style
// prologue cost), not just WindowSystem.Draw — measuring the inner call
// alone would drop the prologue and make the figure non-comparable to the
// v1.5.6 baseline. Only accumulated here; the disk write happens in
// PerformanceBaselineStep so the hot path stays allocation-free.
internal double LastDrawMs;
internal int DeferredSaveFrames = -1; internal int DeferredSaveFrames = -1;
// Cancels the v1.4.8 FTS5 bulk-insert worker on plugin teardown. The // Cancels the v1.4.8 FTS5 bulk-insert worker on plugin teardown. The
@@ -1011,6 +1020,15 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
private void Draw() private void Draw()
{
// v1.9.0 B5: time the whole handler (style + font prologue included).
// Bail before measuring once teardown has begun — a late Draw tick
// must not touch ThemeRegistry / FontManager after DisposeAsync.
if (_isDisposing)
return;
var drawWatch = Stopwatch.StartNew();
try
{ {
// v1.4.8 B2: pick up external edits of the active custom theme JSON // v1.4.8 B2: pick up external edits of the active custom theme JSON
// without forcing the user to re-click the picker. The disk-stat is // without forcing the user to re-click the picker. The disk-stat is
@@ -1055,6 +1073,14 @@ public sealed class Plugin : IAsyncDalamudPlugin
FileDialogManager.Draw(); FileDialogManager.Draw();
} }
finally
{
// finally so the early-return frames (loading screen / NG+) record
// their (cheap) time too instead of freezing on the last full frame.
drawWatch.Stop();
LastDrawMs = drawWatch.Elapsed.TotalMilliseconds;
}
}
internal void SaveConfig() internal void SaveConfig()
{ {