JonKazama-Hellion/HellionChat
1
0
Fork 0
Code Issues Pull Requests Actions Releases 28 Activity

feat(themes): opt-in chat color apply banner in themes tab

Browse Source 
When a theme defines its own chat channel colours and the current
Configuration.ChatColours don't match, a dezent banner offers Apply /
Keep — opt-in, never auto-overwriting user picks. Switching themes
re-arms the banner so each theme can be evaluated separately.
This commit is contained in:
Jon Kazama
2026-05-05 14:51:16 +02:00
parent 15a89dd6e7
commit f2086865ce
4 changed files with 96 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HellionChat/Resources/HellionStrings.Designer.cs
Generated
+3
View File
@@ -230,6 +230,9 @@ internal class HellionStrings
internal static string Settings_Themes_Custom => Get(nameof(Settings_Themes_Custom));
internal static string Settings_Themes_OpenFolder => Get(nameof(Settings_Themes_OpenFolder));
internal static string Settings_Themes_ExportActive => Get(nameof(Settings_Themes_ExportActive));
internal static string Settings_Themes_ApplyChatColors_Hint => Get(nameof(Settings_Themes_ApplyChatColors_Hint));
internal static string Settings_Themes_ApplyChatColors_Apply => Get(nameof(Settings_Themes_ApplyChatColors_Apply));
internal static string Settings_Themes_ApplyChatColors_Keep => Get(nameof(Settings_Themes_ApplyChatColors_Keep));
// Hellion Chat — General-Tab section headings
internal static string Settings_General_Input_Heading => Get(nameof(Settings_General_Input_Heading));
HellionChat/Resources/HellionStrings.de.resx
+9
View File
@@ -696,4 +696,13 @@
<data name="Settings_Themes_ExportActive" xml:space="preserve">
<value>Aktives exportieren...</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve">
<value>Dieses Theme schlägt eigene Channel-Farben vor.</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve">
<value>Übernehmen</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve">
<value>Behalten</value>
</data>
</root>
HellionChat/Resources/HellionStrings.resx
+9
View File
@@ -696,4 +696,13 @@
<data name="Settings_Themes_ExportActive" xml:space="preserve">
<value>Export active...</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve">
<value>This theme suggests its own chat channel colours.</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve">
<value>Apply</value>
</data>
<data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve">
<value>Keep current</value>
</data>
</root>
HellionChat/Ui/SettingsTabs/Themes.cs
+75
View File
@@ -12,6 +12,12 @@ internal sealed class Themes : ISettingsTab
private readonly Plugin Plugin;
private readonly Configuration Mutable;
// Tracks ob der User die Apply-Frage für das aktive Theme bereits
// beantwortet hat. Banner wird nur angezeigt wenn das Theme ein
// ChatColors-Set hat UND noch keine Antwort vorliegt UND die aktuellen
// Mutable.ChatColours davon abweichen.
private string? _applyDismissedFor;
public string Name => HellionStrings.ResourceManager.GetString("Settings_Tab_Themes") ?? "Themes" + "###tabs-themes";
internal Themes(Plugin plugin, Configuration mutable)
@@ -30,6 +36,8 @@ internal sealed class Themes : ISettingsTab
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u))
ImGui.TextUnformatted(active.Author);
DrawChatColorsApplyBanner(active);
ImGui.Spacing();
ImGui.Separator();
ImGui.Spacing();
@@ -143,6 +151,73 @@ internal sealed class Themes : ISettingsTab
{
Mutable.Theme = theme.Slug;
Plugin.ThemeRegistry.Switch(theme.Slug);
_applyDismissedFor = null; // Banner für neues Theme wieder zeigen
}
}
private void DrawChatColorsApplyBanner(Theme active)
{
// Klassik hat per Design keine ChatColors — kein Banner.
if (active.ChatColors is not { Channels.Count: > 0 } themeChatColors)
return;
// User hat die Frage bereits für genau dieses Theme beantwortet.
if (_applyDismissedFor == active.Slug)
return;
// Wenn die aktuellen Channel-Colors bereits exakt mit dem Theme-Vorschlag
// übereinstimmen, gibt's nichts zu tun.
var alreadyMatching = themeChatColors.Channels.All(kvp =>
Mutable.ChatColours.TryGetValue(kvp.Key, out var current) && current == kvp.Value);
if (alreadyMatching)
return;
ImGui.Spacing();
// Dezent-Akzent-Banner mit Border in Theme-Primary
var border = ColourUtil.RgbaToAbgr(active.Colors.Primary);
var bgFill = ColourUtil.RgbaToAbgr((active.Colors.Surface & 0xFFFFFF00u) | 0xCCu);
var origin = ImGui.GetCursorScreenPos();
var width = ImGui.GetContentRegionAvail().X;
var height = 64f;
var draw = ImGui.GetWindowDrawList();
draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f);
draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f);
var hint = HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Hint")
?? "This theme suggests its own chat channel colours.";
var applyLabel = HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Apply")
?? "Apply";
var keepLabel = HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Keep")
?? "Keep current";
var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary);
draw.AddText(origin + new Vector2(12f, 10f), textColor, hint);
// Buttons als InvisibleButton + DrawList-Overlay, damit sie konsistent
// zum Banner-Look bleiben.
using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark))
{
ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f));
if (ImGui.Button(applyLabel))
{
foreach (var kvp in themeChatColors.Channels)
Mutable.ChatColours[kvp.Key] = kvp.Value;
_applyDismissedFor = active.Slug;
}
}
ImGui.SameLine();
if (ImGui.Button(keepLabel))
{
_applyDismissedFor = active.Slug;
}
// Cursor unter den Banner setzen
ImGui.SetCursorScreenPos(origin + new Vector2(0f, height + 8f));
ImGui.Spacing();
}
}