Compare commits

..

1 Commits

Author SHA1 Message Date
renovate-bot 734703eddc chore(deps): pin dependencies
Security / scan (pull_request) Successful in 15s
2026-05-10 18:31:42 +00:00
81 changed files with 2281 additions and 2124 deletions
-34
View File
@@ -1,34 +0,0 @@
---
subtitle: Threading- und IPC-Sicherheits-Politur
versionsnatur: Wartung und Robustheit
---
**Hellion Chat 1.4.4 — Threading- und IPC-Sicherheits-Politur**
Fünfter Sub-Patch der v1.4.x Polish-Sweep-Serie. Threading-Annahmen werden explizit pro Methode dokumentiert, ein
Hot-Path-Lock im Auto-Tell-Tab-Counter fällt weg, IPC-Cleanup wird sichtbar wenn er fehlschlägt und der Privacy-Filter
spricht jetzt bei unbekannten ChatTypes.
- **AutoTellTabsService Hot-Path-Lock entfernt.** `ActiveTempTabCount` hat bisher pro Render-Frame ein LINQ-Count unter
einem Lock gemacht. Jetzt läuft das über einen Interlocked-Counter der parallel zur Tabs-Liste mitgeführt wird,
inklusive Resync-Hook für den Snapshot-Restore-Pfad in `SaveConfig`. Plus Pure-Helper-Test-Mirror in der Build-Suite
damit die Atomicity-Semantik nicht versehentlich wegrefactored wird
- **HonorificService selbst-dokumentierende Threading-Banner.** Statt eines Block-Comments am Klassen-Ende hat jede
IPC-Callback-Methode jetzt einen 1-Zeilen-Banner darüber, der den Thread-Kontext direkt am Call-Site benennt
(framework only, framework scheduled, any). Mehr Hilfe für künftige Reviews als ein abstraktes Threading-Kapitel
- **Unsubscribe-Failure ist jetzt sichtbar.** `TryUnsubscribe` hat ein Honorific-Unsubscribe-Failure bisher als Debug
geloggt, was bei Standard-Loglevel verschluckt wurde. Eine geleakte Subscription kann den Service über Plugin-Reloads
hinweg leben lassen, also läuft der Log jetzt auf Warning
- **AutoTranslate-Warmup blockiert den Plugin-Unload nicht mehr.** Der Cache-Warmup-Thread war ohne `IsBackground=true`
unterwegs, was den Unload um 100-300 ms verzögern konnte. Pattern-Match zu MessageManager und RetentionSweep (beide
seit v1.4.0)
- **Privacy-Filter loggt unbekannte ChatTypes.** Wenn FFXIV durch einen Patch einen neuen ChatType einführt der weder in
der Whitelist noch in den Defaults steht, wird er bisher silent durch den Failsafe geleitet. Jetzt loggt der Filter
einmalig pro Runtime eine Warning mit dem Type und dem Failsafe-Wert. Dedup über ein NonSerialized-HashSet, also kein
Log-Spam
- **Default-Flip für neue Installationen.** `PrivacyPersistUnknownChannels` startet bei neuen Configs jetzt auf `true`,
damit ein Patch-bedingt neuer ChatType nicht stillschweigend gedroppt wird bevor der User entscheiden kann. Bestehende
Configs behalten ihre Wahl, weil der Deserializer den Initializer überschreibt. Keine Migration, kein Schema-Bump
Keine User-sichtbaren Funktions-Änderungen außer dem Default-Flip für neue Installationen. Settings, Themes, Tabs und
das Privacy-Verhalten für Bestand bleiben unangetastet.
-28
View File
@@ -1,28 +0,0 @@
---
subtitle: UX und Robustheit
versionsnatur: UX-Polish-Cycle
---
**Hellion Chat 1.4.5 — UX und Robustheit**
Sechster Sub-Patch der v1.4.x Polish-Sweep-Serie. Render-Fehler im Chat-Fenster werden jetzt sichtbar, der
First-Run-Wizard hat eine explizite Cancel-Schaltfläche, der Eingabe-Verlauf bleibt nicht mehr über Plugin-Reloads
hinweg liegen, und die Statusleiste klippt in schmalen Fenstern nicht mehr.
- **Fehler-Benachrichtigung im Chat-Fenster.** Wenn ein Render-Fehler in `DrawChatLog` auftritt, zeigt das Plugin jetzt
eine einmalige Warning-Notification mit Verweis aufs `/xllog`, statt das Fenster stillschweigend leer zu lassen. Der
Stack-Trace selbst geht weiter via `Plugin.Log.Error` ins Logfile. De-Dup über Per-Session-Bool, damit ein
wiederkehrender Fehler die Notification-Stack nicht pro Frame neu vollkippt
- **First-Run-Wizard trennt Accept und Close.** `OnClose` setzt nicht mehr stillschweigend `FirstRunCompleted=true`,
also lässt das X den Wizard schwebend zurück und er kommt beim nächsten Plugin-Reload wieder. Eine neue „Später —
Defaults behalten"-Schaltfläche im Footer ist der explizite Weg, ohne Profil-Auswahl rauszukommen. Strings bilingual
EN+DE plus Tooltip
- **Eingabe-Verlauf wird beim Plugin-Reload geleert.** `InputHistoryService.Reset` hängt jetzt in `Plugin.DisposeAsync`
neben den anderen Pure-Memory-Cleanups, damit der statische Zustand aus der vorigen Session den nächsten Load nicht
mehr erbt
- **Statusleiste klippt nicht mehr.** Der rechtsbündige Versions-Slot wird ausgeblendet wenn die Chat-Window-Breite
abzüglich Versions-Text unter 200 px fällt — vorher überlappte er die vier linken Slots. Ab ausreichender Breite
taucht der Slot wieder auf
- **Intern:** `FontManager` fällt auf System-Font zurück wenn die eingebettete Hellion-Font-Resource fehlt
(Broken-csproj-Pfad, nie ein Produktions-Build), plus expliziter Session-Only-Invariant-Kommentar für Auto-Tell-Tabs
in `Plugin.cs:167-168` mit einem TempTabCounter-Init-Pin in der Build-Suite. Kein Schema-Bump, keine Migration
-18
View File
@@ -1,18 +0,0 @@
---
subtitle: Code Hygiene and Refactor
versionsnatur: Maintenance-Cycle
---
Wartungs-Patch ohne User-sichtbare Änderungen. Saubere Code-Basis als Vorbereitung auf das v1.4.7-Backlog-Cleanup, plus zwei geerbte Bugfixes aus dem ChatTwo-Upstream `f35b7d3`.
- **preflight.sh härter**: csharpier-Reflow-Check (Block E) und markdownlint (Block F) laufen jetzt im Pre-Push-Gate, statt erst beim Pre-Merge-Review aufzufallen.
- **FontManager-Fallback robuster**: Atlas-Toolkit-Throws aus kaputten Font-Configs (IO, InvalidOperation, ArgumentException) fallen jetzt zuverlässig auf NotoSansCjkRegular, statt den Atlas-Build mitzureißen. Der Exception-Typ wird im Log mitgegeben für die Diagnose.
- **URL-Validation beim Plugin-Load**: BrandingLinks (5 URLs) und IntegrationLinks (2 URLs) werden via `[ModuleInitializer]` geprüft. Ein Tippfehler bei einer künftigen URL-Rotation wirft jetzt sofort beim Plugin-Load, statt still beim Klick zu scheitern.
- **Cherry-Pick aus ChatTwo `f35b7d3`** — Memory-Leak in `Chat.SetChannel`: der native `Utf8String` wird jetzt auch dann freigegeben, wenn der Linkshell-Check den Channel ablehnt (vorher gefangen im early-return).
- **Cherry-Pick aus ChatTwo `f35b7d3`** — `Tab.Clone()` Deep-cloned jetzt `UsedChannel` und `TellTarget`. Vorher Reference-Share-Bug: PopOut- und Temp-Tabs mutierten sich gegenseitig.
- **Aktive-Tab-Underline pixel-perfect bei DPI-Scaling**: Die Underline-Pill skaliert jetzt mit `ImGuiHelpers.GlobalScale` und rundet die DrawList-Koordinaten auf physische Pixel. Kein Sub-Pixel-Blur mehr auf 125/150%-Setups.
- **IconButton-Width-Fix**: der manuelle `width - 2 * CellPadding.X`-Subtract verlor den HUD-Scale (Padding skaliert, der raw int nicht). Gemessene Breite läuft jetzt unverändert durch.
- **Test-Isolation für MessageStore**: `Dalamud.Utility.Util`-Surface (IsWine, OpenLink) läuft jetzt durch eine `IPlatformUtil`-Indirektion. MessageStores `IsWine`-Probe ist isoliert testbar in der Build-Suite. Plus: HellionStyle-ChildBgAlpha als Pure-Helper extrahiert, Plugin.SaveConfig kopiert nur Session-Tabs statt der ganzen Tab-Liste, SettingsOverview cached den DrawList einmal pro Frame.
- **Built-in-Theme-Roster**: Crystal Nocturne (Royal Sapphire + Electric Magenta auf Obsidian, von CRYSTALLITE) ersetzt Moonlit Bloom. User mit Moonlit Bloom als aktivem Theme fallen beim ersten Plugin-Load auf Hellion Arctic zurück.
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
@@ -101,16 +101,16 @@ jobs:
if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" } if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" }
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(4) } else { $_ } if ($_ -match '^ ') { $_.Substring(2) } else { $_ }
}) -join "`n" }) -join "`n"
$header = "**v$version " $header = "**Hellion Chat $version"
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging." throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**v", 1) $nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
$enBlock = $rest.Substring(0, $nextHdr).TrimEnd() $enBlock = $rest.Substring(0, $nextHdr).TrimEnd()
@@ -20,12 +20,16 @@ on:
push: push:
tags: tags:
- "v*" - "v*"
# Manual recovery trigger. Use Gitea's "Run workflow" UI and select the # Manual recovery trigger. Use when a tag was pushed but the auto-run
# tag (e.g. v1.4.4) from the Ref dropdown - not main. The Validate tag # was missed or failed: `gh workflow run release.yml -f tag=v0.6.1`.
# ref step below hard-fails if a non-tag ref is selected, because the # The tag input is validated against the same semver regex as the
# release-action reads GITHUB_REF directly and rejects anything that # auto-trigger before any string interpolation happens.
# does not start with refs/tags/.
workflow_dispatch: workflow_dispatch:
inputs:
tag:
description: "Existing tag to (re)release, e.g. v0.6.1"
required: true
type: string
permissions: permissions:
contents: write contents: write
@@ -37,21 +41,14 @@ jobs:
timeout-minutes: 20 timeout-minutes: 20
steps: steps:
# release-action@main reads GITHUB_REF directly (its action.yml # On push:tags, github.ref_name is the tag — checkout default works.
# does not declare a tag_name input). Validate up-front so manual # On workflow_dispatch, ref defaults to the branch the action was
# dispatches from a branch ref fail loud here instead of burning # invoked from; we need to explicitly check out the tag the user
# a full build before the final step errors out with "ref X is # supplied so the build comes from the tagged commit, not main.
# not a tag".
- name: Validate tag ref
run: |
if [[ "${GITHUB_REF}" != refs/tags/v* ]]; then
echo "::error::Release workflow must run on a v*.X.Y tag ref, got ${GITHUB_REF}"
echo "::error::Push a tag, or pick the tag (not main) in the workflow_dispatch Ref dropdown."
exit 1
fi
- name: Checkout - name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
ref: ${{ github.event.inputs.tag || github.ref }}
- name: Setup .NET 10 - name: Setup .NET 10
uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5 uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
@@ -92,11 +89,12 @@ jobs:
- name: Generate release body - name: Generate release body
shell: pwsh shell: pwsh
env: env:
# github.ref_name is the tag because Validate tag ref above # workflow_dispatch carries the user-supplied tag in inputs.tag;
# already enforced refs/tags/v*. Read via env: so the value # push:tags carries it in github.ref_name. Either way the value
# is a PowerShell variable, not inline shell text, and gets # is treated as a PowerShell variable (env-var pass), not as
# re-validated against the semver regex below. # inline shell text, and validated against the semver regex
TAG_NAME: ${{ github.ref_name }} # below before any string interpolation.
TAG_NAME: ${{ github.event.inputs.tag || github.ref_name }}
run: | run: |
$tag = $env:TAG_NAME $tag = $env:TAG_NAME
if ($tag -notmatch '^v\d+\.\d+\.\d+$') { if ($tag -notmatch '^v\d+\.\d+\.\d+$') {
@@ -113,22 +111,20 @@ jobs:
# changelog: is the last top-level key in the manifest, so # changelog: is the last top-level key in the manifest, so
# everything after the marker is the literal block. Strip the # everything after the marker is the literal block. Strip the
# 4-space yaml indent (prettier convention) from each line. # 2-space yaml indent from each line.
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(4) } else { $_ } if ($_ -match '^ ') { $_.Substring(2) } else { $_ }
}) -join "`n" }) -join "`n"
# Subblock convention: "**vX.Y.Z — <subtitle> (<date>)**" $header = "**Hellion Chat $version"
# matches verify-changelog-sync.sh and slim-rule grep.
$header = "**v$version "
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release." throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**v", 1) $nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
@@ -156,28 +152,19 @@ jobs:
Write-Host $body Write-Host $body
Write-Host "----------------------------------------" Write-Host "----------------------------------------"
# release-action@main only declares files/title/body/pre_release/
# draft/api_key/insecure as inputs (see its action.yml). It silently
# ignores anything else, including body_path and tag_name. The tag
# itself comes from GITHUB_REF, the body must be passed inline via
# body:, so we re-emit release-body.md as a step output first.
- name: Expose release body for release-action
id: body
shell: bash
run: |
{
echo 'content<<RELEASE_BODY_EOF'
cat release-body.md
echo 'RELEASE_BODY_EOF'
} >> "$GITHUB_OUTPUT"
# Gitea-native release action. Creates the release if the tag has no # Gitea-native release action. Creates the release if the tag has no
# release yet, or updates the existing one with latest.zip attached # release yet, or updates the existing one. body_path provides the
# and the generated body. The auto-injected GITHUB_TOKEN on Gitea # generated release body, files attaches latest.zip. The auto-injected
# Actions has Gitea-API scope and is sufficient for release write. # GITHUB_TOKEN on Gitea Actions has Gitea-API scope and is sufficient
# for release write.
- name: Attach to Gitea release - name: Attach to Gitea release
uses: https://gitea.com/actions/release-action@main uses: https://gitea.com/actions/release-action@main
with: with:
# Explicit tag_name so the action targets the correct release in
# both push:tags (auto) and workflow_dispatch (manual recovery)
# modes. Without this, dispatch runs would default to the branch
# ref (main) and fail to find the release.
tag_name: ${{ github.event.inputs.tag || github.ref_name }}
files: ${{ steps.locate.outputs.path }} files: ${{ steps.locate.outputs.path }}
body: ${{ steps.body.outputs.content }} body_path: release-body.md
api_key: ${{ secrets.GITHUB_TOKEN }} api_key: ${{ secrets.GITHUB_TOKEN }}
-4
View File
@@ -384,7 +384,3 @@ ChatTwo.Tests
TestResults TestResults
*.db-shm *.db-shm
*.db-wal *.db-wal
# Claude Code projekt-spezifisches Setup (lokal, nicht committed)
/.claude/
/CLAUDE.md
-2
View File
@@ -1,9 +1,7 @@
{ {
"MD007": { "indent": 4 }, "MD007": { "indent": 4 },
"MD013": false, "MD013": false,
"MD024": { "siblings_only": true },
"MD029": false, "MD029": false,
"MD033": false, "MD033": false,
"MD036": false,
"MD041": false "MD041": false
} }
+11 -28
View File
@@ -1,7 +1,6 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Threading;
using Dalamud.Game.Text; using Dalamud.Game.Text;
using Dalamud.Game.Text.SeStringHandling; using Dalamud.Game.Text.SeStringHandling;
using HellionChat.Code; using HellionChat.Code;
@@ -20,14 +19,6 @@ internal sealed class AutoTellTabsService : IDisposable
private readonly MessageStore _store; private readonly MessageStore _store;
private readonly object _tempTabsLock = new(); private readonly object _tempTabsLock = new();
// F2.1: lock-free counter mirrors Config.Tabs.Count(IsTempTab) so the
// hot-path getter doesn't contend with HandleTell on every render frame.
// Bumped from inside the existing mutation paths so it stays consistent
// with the underlying list — see SpawnTempTab, DropOldestTempTab, OnLogout
// and ResyncTempTabCounter (used by Plugin.cs snapshot-restore).
// TEST-MIRROR: ../../Hellion Build test/_Helpers/TempTabCounterTests.cs
private int _activeTempTabCount;
private bool _initialized; private bool _initialized;
internal AutoTellTabsService(Plugin plugin, MessageManager messageManager, MessageStore store) internal AutoTellTabsService(Plugin plugin, MessageManager messageManager, MessageStore store)
@@ -37,7 +28,16 @@ internal sealed class AutoTellTabsService : IDisposable
_store = store; _store = store;
} }
internal int ActiveTempTabCount => Volatile.Read(ref _activeTempTabCount); internal int ActiveTempTabCount
{
get
{
lock (_tempTabsLock)
{
return Plugin.Config.Tabs.Count(t => t.IsTempTab);
}
}
}
internal void Initialize() internal void Initialize()
{ {
@@ -46,25 +46,11 @@ internal sealed class AutoTellTabsService : IDisposable
return; return;
} }
// Seed the counter from the persisted Tabs list so a config that already
// contains TempTabs from a prior session starts in sync. Plugin.cs:168
// crash-recovery has already dropped TempTabs by the time we get here,
// so the snapshot reflects post-recovery reality.
Interlocked.Exchange(ref _activeTempTabCount, Plugin.Config.Tabs.Count(t => t.IsTempTab));
_messageManager.MessageProcessed += HandleTell; _messageManager.MessageProcessed += HandleTell;
Plugin.ClientState.Logout += OnLogout; Plugin.ClientState.Logout += OnLogout;
_initialized = true; _initialized = true;
} }
// F2.1: callable from outside paths that mutate Config.Tabs directly
// (Plugin.cs snapshot-restore). Atomically re-pegs the counter to the
// live IsTempTab count.
internal void ResyncTempTabCounter()
{
Interlocked.Exchange(ref _activeTempTabCount, Plugin.Config.Tabs.Count(t => t.IsTempTab));
}
public void Dispose() public void Dispose()
{ {
if (!_initialized) if (!_initialized)
@@ -198,7 +184,6 @@ internal sealed class AutoTellTabsService : IDisposable
} }
Plugin.Config.Tabs.RemoveAt(victim.Index); Plugin.Config.Tabs.RemoveAt(victim.Index);
Interlocked.Decrement(ref _activeTempTabCount);
// Re-anchor active tab to avoid silent switch when tab is dropped // Re-anchor active tab to avoid silent switch when tab is dropped
if (victim.Index <= _plugin.LastTab) if (victim.Index <= _plugin.LastTab)
@@ -223,7 +208,6 @@ internal sealed class AutoTellTabsService : IDisposable
} }
Plugin.Config.Tabs.Add(tab); Plugin.Config.Tabs.Add(tab);
Interlocked.Increment(ref _activeTempTabCount);
} }
private static Tab BuildTempTab(string playerName, uint worldRowId) private static Tab BuildTempTab(string playerName, uint worldRowId)
@@ -377,8 +361,7 @@ internal sealed class AutoTellTabsService : IDisposable
} }
} }
var removed = Plugin.Config.Tabs.RemoveAll(t => t.IsTempTab); Plugin.Config.Tabs.RemoveAll(t => t.IsTempTab);
Interlocked.Add(ref _activeTempTabCount, -removed);
// Force switch to tab 0 if active tab was temp or index is now out of range // Force switch to tab 0 if active tab was temp or index is now out of range
var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count; var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count;
-21
View File
@@ -1,6 +1,3 @@
using System.Runtime.CompilerServices;
using HellionChat.Util;
namespace HellionChat.Branding; namespace HellionChat.Branding;
// Centralised — a future invite/URL rotation only touches this file. // Centralised — a future invite/URL rotation only touches this file.
@@ -12,22 +9,4 @@ internal static class BrandingLinks
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat"; "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat";
public const string HellionForgeWebsite = "https://hellion-forge.cloud"; public const string HellionForgeWebsite = "https://hellion-forge.cloud";
public const string HellionMediaWebsite = "https://hellion-media.de/de"; public const string HellionMediaWebsite = "https://hellion-media.de/de";
// CA2255 warns against [ModuleInitializer] in library code, but Dalamud
// loads the plugin DLL directly so the module-init pass is the right hook
// for a one-shot URL sanity check at plugin load.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(
nameof(BrandingLinks),
HellionForgeDiscordInvite,
HellionForgeGitea,
HellionChatRepo,
HellionForgeWebsite,
HellionMediaWebsite
);
}
} }
+11 -11
View File
@@ -7,36 +7,36 @@ public enum ChatSource : ushort
{ {
None = 0, None = 0,
// The player controlled by this client /// <summary>The player currently controlled by the local client.</summary>
LocalPlayer = 1 << XivChatRelationKind.LocalPlayer, LocalPlayer = 1 << XivChatRelationKind.LocalPlayer,
// Member of the local party /// <summary>A player in the same 4-man or 8-man party as the local player.</summary>
PartyMember = 1 << XivChatRelationKind.PartyMember, PartyMember = 1 << XivChatRelationKind.PartyMember,
// Member of the alliance /// <summary>A player in the same alliance raid.</summary>
AllianceMember = 1 << XivChatRelationKind.AllianceMember, AllianceMember = 1 << XivChatRelationKind.AllianceMember,
// Other player /// <summary>A player not in the local player's party or alliance.</summary>
OtherPlayer = 1 << XivChatRelationKind.OtherPlayer, OtherPlayer = 1 << XivChatRelationKind.OtherPlayer,
// Enemy in combat /// <summary>An enemy entity that is currently in combat with the player or party.</summary>
EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy, EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy,
// Enemy out of combat /// <summary>An enemy entity that is not yet in combat or claimed.</summary>
UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy, UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy,
// Friendly NPC /// <summary>An NPC that is friendly or neutral to the player (e.g., EventNPCs).</summary>
FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc, FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc,
// Own pet or companion /// <summary>A pet (Summoner/Scholar) or companion (Chocobo) belonging to the local player.</summary>
PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion, PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion,
// Pet or companion of party members /// <summary>A pet or companion belonging to a member of the local player's party.</summary>
PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty, PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty,
// Pet or companion of alliance members /// <summary>A pet or companion belonging to a member of the alliance.</summary>
PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance, PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance,
// Pet or companion of other players /// <summary>A pet or companion belonging to a player not in the party or alliance.</summary>
PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther, PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther,
} }
+4 -51
View File
@@ -57,18 +57,8 @@ public class Configuration : IPluginConfiguration
// Empty set means the migration has not run yet — see Plugin.cs v6→v7. // Empty set means the migration has not run yet — see Plugin.cs v6→v7.
public HashSet<ChatType> PrivacyPersistChannels = []; public HashSet<ChatType> PrivacyPersistChannels = [];
// Failsafe for ChatTypes added by future FFXIV patches. New configs default // Failsafe for ChatTypes added by future FFXIV patches.
// to the failsafe via PrivacyDefaults; existing configs keep their saved public bool PrivacyPersistUnknownChannels;
// choice because the deserializer overrides this initializer.
public bool PrivacyPersistUnknownChannels = Privacy
.PrivacyDefaults
.DefaultPersistUnknownChannels;
// F3.2: dedup unknown-ChatType warnings so a chatty filter doesn't spam
// the log every frame. NonSerialized so the warning fires once per
// runtime, not once-ever-per-install.
[NonSerialized]
private readonly HashSet<ChatType> _warnedUnknownChannels = new();
public bool IsAllowedForStorage(ChatType type) public bool IsAllowedForStorage(ChatType type)
{ {
@@ -76,20 +66,6 @@ public class Configuration : IPluginConfiguration
return true; return true;
if (PrivacyPersistChannels.Contains(type)) if (PrivacyPersistChannels.Contains(type))
return true; return true;
// F3.2: log first occurrence of a ChatType the running build doesn't
// recognise — i.e. one a future FFXIV patch may have added. Known
// types the user opted out of are routed through the failsafe
// silently, like before.
if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type))
{
Plugin.Log.Warning(
"PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
type,
PrivacyPersistUnknownChannels
);
}
return PrivacyPersistUnknownChannels; return PrivacyPersistUnknownChannels;
} }
@@ -500,7 +476,7 @@ public class Tab
Opacity = Opacity, Opacity = Opacity,
Identifier = Identifier, Identifier = Identifier,
InputDisabled = InputDisabled, InputDisabled = InputDisabled,
CurrentChannel = CurrentChannel.Clone(), CurrentChannel = CurrentChannel,
CanMove = CanMove, CanMove = CanMove,
CanResize = CanResize, CanResize = CanResize,
IndependentHide = IndependentHide, IndependentHide = IndependentHide,
@@ -512,7 +488,7 @@ public class Tab
HideWhenInactive = HideWhenInactive, HideWhenInactive = HideWhenInactive,
IsTempTab = IsTempTab, IsTempTab = IsTempTab,
AllSenderMessages = AllSenderMessages, AllSenderMessages = AllSenderMessages,
TellTarget = TellTarget.Clone(), TellTarget = TellTarget.From(TellTarget),
IsGreeted = IsGreeted, IsGreeted = IsGreeted,
}; };
} }
@@ -690,29 +666,6 @@ public class UsedChannel
{ {
Channel = channel; Channel = channel;
} }
// ---------------------------------------------------------------
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Deep-clone the UsedChannel so Tab.Clone() no longer shares
// channel state (incl. TellTarget) with its origin Tab. Previously
// a reference copy: PopOut and Temp tabs mutated each other.
// - Name is intentionally a reference copy (matches upstream); it
// gets reassigned on every channel switch anyway.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/UsedChannelCloneTests.cs
// ---------------------------------------------------------------
public UsedChannel Clone()
{
return new UsedChannel
{
Channel = Channel,
Name = Name,
TellTarget = TellTarget?.Clone(),
UseTempChannel = UseTempChannel,
TempChannel = TempChannel,
TempTellTarget = TempTellTarget?.Clone(),
};
}
} }
[Serializable] [Serializable]
+9 -5
View File
@@ -32,8 +32,12 @@ internal static class ExportFormatExt
}; };
} }
// Serializes message snapshots to Markdown, JSON, or CSV. /// <summary>
// Caller handles pre-filtering except sender substring, which requires deserialized SeString.TextValue. /// Serializes message snapshots into Markdown, JSON, or CSV. The caller is
/// expected to filter the input enumerable; this class only handles
/// formatting and writes to the supplied path. Sender substring filtering
/// happens here because it requires deserialized SeString.TextValue.
/// </summary>
internal static class MessageExporter internal static class MessageExporter
{ {
internal record FilterDescription( internal record FilterDescription(
@@ -96,7 +100,6 @@ internal static class MessageExporter
var chatType = (ChatType)(ushort)m.Code.Type; var chatType = (ChatType)(ushort)m.Code.Type;
var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim(); var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim();
var content = m.ContentSource.TextValue; var content = m.ContentSource.TextValue;
if (string.IsNullOrEmpty(sender)) if (string.IsNullOrEmpty(sender))
w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}"); w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}");
else else
@@ -129,7 +132,8 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Manual JSON to avoid System.Text.Json policy coupling. // Manual JSON to avoid pulling in System.Text.Json policy choices.
// Output is a single object with metadata and an array of messages.
w.Write("{\n \"exported_at\": \""); w.Write("{\n \"exported_at\": \"");
w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture)); w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture));
w.Write("\",\n \"plugin\": \"Hellion Chat\",\n"); w.Write("\",\n \"plugin\": \"Hellion Chat\",\n");
@@ -190,7 +194,7 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Header always written so empty exports remain importable. // Header line always written so empty exports are still importable.
w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId"); w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId");
var count = 0; var count = 0;
foreach (var m in messages) foreach (var m in messages)
+9 -32
View File
@@ -44,26 +44,16 @@ public class FontManager
// Hellion font bytes (Exo 2, OFL-1.1); lazily loaded from manifest resources // Hellion font bytes (Exo 2, OFL-1.1); lazily loaded from manifest resources
private static byte[]? HellionFontBytes; private static byte[]? HellionFontBytes;
// Returns null when the embedded font resource is missing. Should never private static byte[] GetHellionFontBytes()
// happen on a signed release build, but a broken csproj or hand-rolled
// dev build can land here. Caller falls back to the system font path so
// the plugin still loads instead of crashing the whole UiBuilder.
private static byte[]? TryGetHellionFontBytes()
{ {
if (HellionFontBytes is not null) if (HellionFontBytes is not null)
return HellionFontBytes; return HellionFontBytes;
using var stream = typeof(FontManager).Assembly.GetManifestResourceStream( using var stream =
"HellionFont.ttf" typeof(FontManager).Assembly.GetManifestResourceStream("HellionFont.ttf")
); ?? throw new FileNotFoundException(
if (stream is null) "Hellion font resource not embedded in the assembly"
{
Plugin.Log.Warning(
"Hellion font resource missing — falling back to system default font."
); );
return null;
}
using var ms = new MemoryStream(); using var ms = new MemoryStream();
stream.CopyTo(ms); stream.CopyTo(ms);
HellionFontBytes = ms.ToArray(); HellionFontBytes = ms.ToArray();
@@ -156,11 +146,8 @@ public class FontManager
? Plugin.Config.FontSizeV2 ? Plugin.Config.FontSizeV2
: Plugin.Config.GlobalFontV2.SizePt; : Plugin.Config.GlobalFontV2.SizePt;
var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges }; var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges };
// F10.2: if the embedded font is missing, drop to the system font config.MergeFont = Plugin.Config.UseHellionFont
// path rather than letting the UiBuilder throw. ? tk.AddFontFromMemory(GetHellionFontBytes(), config, "Hellion-Exo2")
var hellionBytes = Plugin.Config.UseHellionFont ? TryGetHellionFontBytes() : null;
config.MergeFont = hellionBytes is not null
? tk.AddFontFromMemory(hellionBytes, config, "Hellion-Exo2")
: AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global"); : AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global");
config.SizePt = Plugin.Config.JapaneseFontV2.SizePt; config.SizePt = Plugin.Config.JapaneseFontV2.SizePt;
@@ -226,21 +213,11 @@ public class FontManager
return fontId.AddToBuildToolkit(tk, config); return fontId.AddToBuildToolkit(tk, config);
} }
catch (Exception e) catch (Exception e)
when (e when (e is FileNotFoundException or DirectoryNotFoundException or IOException)
is FileNotFoundException
or DirectoryNotFoundException
or IOException
or InvalidOperationException
or ArgumentException
)
{ {
// Atlas-toolkit throws span IO and validation failures; routing the
// wider set through the fallback keeps a corrupt font config from
// taking down the whole atlas build.
Plugin.Log.Warning( Plugin.Log.Warning(
e, e,
$"Configured {slot} font failed to load ({e.GetType().Name}), " $"Configured {slot} font unavailable, falling back to NotoSansCjkRegular"
+ "falling back to NotoSansCjkRegular"
); );
var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular); var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular);
return fallback.AddToBuildToolkit(tk, config); return fallback.AddToBuildToolkit(tk, config);
+40 -32
View File
@@ -174,7 +174,8 @@ internal sealed unsafe class Chat : IDisposable
internal static void RotateCrossLinkshellHistory(RotateMode mode) => internal static void RotateCrossLinkshellHistory(RotateMode mode) =>
UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode)); UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode));
// Look up a channel's user-defined color, returns null if 0 // This function looks up a channel's user-defined color.
// If this function ever returns 0, it returns null instead.
internal uint? GetChannelColor(ChatType type) internal uint? GetChannelColor(ChatType type)
{ {
var parent = type.Parent(); var parent = type.Parent();
@@ -214,7 +215,8 @@ internal sealed unsafe class Chat : IDisposable
if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null) if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null)
{ {
// Capture the just-typed character input // FIXME: this whole system sucks
// FIXME v2: I hate everything about this, but it works
Plugin.Framework.RunOnTick(() => Plugin.Framework.RunOnTick(() =>
{ {
string? input = null; string? input = null;
@@ -253,9 +255,13 @@ internal sealed unsafe class Chat : IDisposable
try try
{ {
// Prevent duplicate calls // We already called this function once, so we skip the duplicated call
// Also return the original value here so that vanilla chat receives all information
if (Plugin.ChatLogWindow.TellSpecial) if (Plugin.ChatLogWindow.TellSpecial)
{
Plugin.Log.Information("Return early to prevent duplicated call...");
return ChatLogRefreshHook!.Original(log, eventId, value); return ChatLogRefreshHook!.Original(log, eventId, value);
}
Plugin.ChatLogWindow.Activated( Plugin.ChatLogWindow.Activated(
new ChatActivatedArgs(new ChannelSwitchInfo(null)) new ChatActivatedArgs(new ChannelSwitchInfo(null))
@@ -269,7 +275,8 @@ internal sealed unsafe class Chat : IDisposable
Plugin.Log.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
return 1; // Prevent vanilla chat log from gaining focus // prevent the game from focusing the chat log
return 1;
} }
private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent) private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent)
@@ -423,24 +430,19 @@ internal sealed unsafe class Chat : IDisposable
); );
} }
// --------------------------------------------------------------- /// <summary>
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12) /// Returns true if the channel is any non-linkshell channel, or if the
// - Renamed ValidAnyLinkshell -> IsChannelOrExistingLinkshell. The /// linkshell actually exists.
// name now states intent: returns true for any non-linkshell /// </summary>
// channel, or a linkshell index that actually exists. internal static bool ValidAnyLinkshell(InputChannel channel)
// ---------------------------------------------------------------
internal static bool IsChannelOrExistingLinkshell(InputChannel channel)
{ {
var idx = channel.LinkshellIndex(); var idx = channel.LinkshellIndex();
if (idx == uint.MaxValue || channel.IsExtraChatLinkshell()) if (idx == uint.MaxValue || channel.IsExtraChatLinkshell())
return true; return true;
if (channel.IsLinkshell() && ValidLinkshell(idx))
if (channel.IsLinkshell()) return true;
return ValidLinkshell(idx); if (channel.IsCrossLinkshell() && ValidCrossLinkshell(idx))
return true;
if (channel.IsCrossLinkshell())
return ValidCrossLinkshell(idx);
return false; return false;
} }
@@ -475,7 +477,8 @@ internal sealed unsafe class Chat : IDisposable
_ => 1, _ => 1,
}; };
for (var i = 0; i < 8; i++) // Find valid linkshell within 8 iterations // Iterate up to 8 times to find a valid linkshell.
for (var i = 0; i < 8; i++)
{ {
currentIndex = (uint)((8 + currentIndex + delta) % 8); currentIndex = (uint)((8 + currentIndex + delta) % 8);
if (validFn(currentIndex)) if (validFn(currentIndex))
@@ -521,7 +524,7 @@ internal sealed unsafe class Chat : IDisposable
); );
// RotateLinkshell returns null when no valid linkshell is found within 8 iterations. // RotateLinkshell returns null when no valid linkshell is found within 8 iterations.
// Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic. // Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic.
return idx is null ? null : channel + idx.Value; // null if not found, otherwise new channel return idx is null ? null : channel + idx.Value;
} }
default: default:
return channel; return channel;
@@ -530,7 +533,11 @@ internal sealed unsafe class Chat : IDisposable
internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null) internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null)
{ {
// Ignore ExtraChat linkshells (use ChatLogWindow.SetChannel() instead) // ExtraChat linkshells aren't supported in game so we never want to
// call the ChangeChatChannel function with them.
//
// Callers should call ChatLogWindow.SetChannel() which handles
// ExtraChat channels
if (channel.IsExtraChatLinkshell()) if (channel.IsExtraChatLinkshell())
return; return;
@@ -539,17 +546,12 @@ internal sealed unsafe class Chat : IDisposable
if (idx == uint.MaxValue) if (idx == uint.MaxValue)
idx = 0; idx = 0;
// --------------------------------------------------------------- if (!ValidAnyLinkshell(channel))
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12) return;
// - Wrap ChangeChatChannel in the validity check instead of
// early-returning. The previous early return skipped Dtor and
// leaked the native Utf8String allocated a few lines above.
// ---------------------------------------------------------------
if (IsChannelOrExistingLinkshell(channel))
RaptureShellModule
.Instance()
->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true);
RaptureShellModule
.Instance()
->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true);
target->Dtor(true); target->Dtor(true);
} }
@@ -563,6 +565,9 @@ internal sealed unsafe class Chat : IDisposable
bool setChatType bool setChatType
) )
{ {
// param6 is 0 for contentId and 1 for objectId
// param7 is always 0 ?
if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel) if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel)
Plugin.CurrentTab.CurrentChannel.UseTempChannel = true; Plugin.CurrentTab.CurrentChannel.UseTempChannel = true;
@@ -737,7 +742,10 @@ internal sealed unsafe class Chat : IDisposable
internal bool CheckHideFlags() internal bool CheckHideFlags()
{ {
// Only hide chat in cutscene when vanilla chat would also be hidden // Only hide the chat in a cutscene when the vanilla chat would've
// also been hidden. This prevents Chat 2 from hiding for a split
// second before the cutscene actually starts, because the game sets
// the cutscene conditions before processing the skip.
var raptureAtkUnitManager = RaptureAtkUnitManager.Instance(); var raptureAtkUnitManager = RaptureAtkUnitManager.Instance();
return raptureAtkUnitManager == null return raptureAtkUnitManager == null
|| raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat); || raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat);
+12 -3
View File
@@ -15,10 +15,17 @@ public unsafe class ChatBox
mes->Dtor(true); mes->Dtor(true);
} }
public static void SendMessage(string message) => SendMessageUnsafe(ValidateMessage(message)); public static void SendMessage(string message)
{
var bytes = ValidateMessage(message);
SendMessageUnsafe(bytes);
}
// sanitiserOverride allows xUnit to bypass Utf8String->SanitizeString (game memory only). // Validation split out so the deterministic checks (UTF-8 length, sanitise
// Returns encoded bytes so SendMessage avoids a second GetBytes call. // round-trip) can run in xUnit without ClientStructs game memory. The
// sanitiser is injectable so tests can pin throw behaviour without invoking
// Utf8String->SanitizeString, which only resolves in-process. Returns the
// already-encoded bytes so SendMessage doesn't pay GetBytes twice.
// TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs // TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs
internal static byte[] ValidateMessage( internal static byte[] ValidateMessage(
string message, string message,
@@ -42,9 +49,11 @@ public unsafe class ChatBox
private static string SanitiseText(string text) private static string SanitiseText(string text)
{ {
var uText = Utf8String.FromString(text); var uText = Utf8String.FromString(text);
uText->SanitizeString((AllowedEntities)0x27F); uText->SanitizeString((AllowedEntities)0x27F);
var sanitised = uText->ToString(); var sanitised = uText->ToString();
uText->Dtor(true); uText->Dtor(true);
return sanitised; return sanitised;
} }
} }
+55 -18
View File
@@ -47,6 +47,7 @@ internal unsafe class GameFunctions : IDisposable
Chat = new Chat(Plugin); Chat = new Chat(Plugin);
Plugin.GameInteropProvider.InitializeFromAttributes(this); Plugin.GameInteropProvider.InitializeFromAttributes(this);
ResolveTextCommandPlaceholderHook?.Enable(); ResolveTextCommandPlaceholderHook?.Enable();
} }
@@ -54,24 +55,36 @@ internal unsafe class GameFunctions : IDisposable
{ {
Chat.Dispose(); Chat.Dispose();
KeybindManager.Dispose(); KeybindManager.Dispose();
ResolveTextCommandPlaceholderHook?.Dispose(); ResolveTextCommandPlaceholderHook?.Dispose();
Marshal.FreeHGlobal(PlaceholderNamePtr); Marshal.FreeHGlobal(PlaceholderNamePtr);
} }
internal void SendFriendRequest(string name, ushort world) => internal void SendFriendRequest(string name, ushort world)
{
ListCommand(name, world, "friendlist"); ListCommand(name, world, "friendlist");
}
internal void AddToBlacklist(string name, ushort world) => ListCommand(name, world, "blist"); internal void AddToBlacklist(string name, ushort world)
{
ListCommand(name, world, "blist");
}
internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId) => internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId)
{
AgentMutelist.Instance()->Add(accountId, contentId, name, worldId); AgentMutelist.Instance()->Add(accountId, contentId, name, worldId);
}
internal void AddToTermsList(SeString content) => internal void AddToTermsList(SeString content)
{
AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator()); AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator());
}
private void ListCommand(string name, ushort world, string commandName) private void ListCommand(string name, ushort world, string commandName)
{ {
var worldRow = Sheets.WorldSheet.GetRow(world); var worldRow = Sheets.WorldSheet.GetRow(world);
ReplacementName = $"{name}@{worldRow.Name.ToString()}"; ReplacementName = $"{name}@{worldRow.Name.ToString()}";
ChatBox.SendMessage($"/{commandName} add {Placeholder}"); ChatBox.SendMessage($"/{commandName} add {Placeholder}");
} }
@@ -95,6 +108,7 @@ internal unsafe class GameFunctions : IDisposable
{ {
for (var i = 0; i < 4; i++) for (var i = 0; i < 4; i++)
SetAddonInteractable($"ChatLogPanel_{i}", interactable); SetAddonInteractable($"ChatLogPanel_{i}", interactable);
SetAddonInteractable("ChatLog", interactable); SetAddonInteractable("ChatLog", interactable);
} }
@@ -110,6 +124,7 @@ internal unsafe class GameFunctions : IDisposable
var agent = AgentItemDetail.Instance(); var agent = AgentItemDetail.Instance();
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
// atkStage ain't gonna be null or we have bigger problems
if (agent == null || addon == null) if (agent == null || addon == null)
return; return;
@@ -118,19 +133,23 @@ internal unsafe class GameFunctions : IDisposable
agent->Index = 0; agent->Index = 0;
agent->Flag1 &= 0xEF; agent->Flag1 &= 0xEF;
agent->ItemId = id; agent->ItemId = id;
// agent->Flag2 = 1;
// TODO: Revert when CS offset lands in a release build. // agent->Flag3 = 0;
// TODO: Revert whenever CS is merged
*(byte*)((nint)agent + 0x21A) = 1; *(byte*)((nint)agent + 0x21A) = 1;
*(byte*)((nint)agent + 0x21E) = 0; *(byte*)((nint)agent + 0x21E) = 0;
// This just probably needs to be set
agent->AddonId = addon->Id; agent->AddonId = addon->Id;
// Skips early return
atkStage->TooltipManager.TooltipType |= 2; atkStage->TooltipManager.TooltipType |= 2;
addon->Show(false, 15); addon->Show(false, 15);
} }
internal static void CloseItemTooltip() internal static void CloseItemTooltip()
{ {
// Hide addon first to suppress the "addon close" sound. // hide addon first to prevent the "addon close" sound
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
if (addon != null) if (addon != null)
addon->Hide(true, false, 0); addon->Hide(true, false, 0);
@@ -148,7 +167,7 @@ internal unsafe class GameFunctions : IDisposable
internal static void OpenPartyFinder() internal static void OpenPartyFinder()
{ {
// 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01) // this whole method: 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01)
var lfg = AgentLookingForGroup.Instance(); var lfg = AgentLookingForGroup.Instance();
if (lfg->IsAgentActive()) if (lfg->IsAgentActive())
{ {
@@ -169,10 +188,15 @@ internal unsafe class GameFunctions : IDisposable
} }
} }
internal static bool IsMentor() => PlayerState.Instance()->IsMentor(); internal static bool IsMentor()
{
return PlayerState.Instance()->IsMentor();
}
internal static InfoProxyCommonList.CharacterData[] GetFriends() => internal static InfoProxyCommonList.CharacterData[] GetFriends()
InfoProxyFriendList.Instance()->CharDataSpan.ToArray(); {
return InfoProxyFriendList.Instance()->CharDataSpan.ToArray();
}
internal static void OpenQuestLog(RowRef<Quest> quest) internal static void OpenQuestLog(RowRef<Quest> quest)
{ {
@@ -199,12 +223,20 @@ internal unsafe class GameFunctions : IDisposable
AgentQuestJournal.Instance()->OpenForQuest(questId, 1); AgentQuestJournal.Instance()->OpenForQuest(questId, 1);
} }
internal static void OpenPartyFinder(uint id) => internal static void OpenPartyFinder(uint id)
{
AgentLookingForGroup.Instance()->OpenListing(id); AgentLookingForGroup.Instance()->OpenListing(id);
}
internal static void OpenAchievement(uint id) => AgentAchievement.Instance()->OpenById(id); internal static void OpenAchievement(uint id)
{
AgentAchievement.Instance()->OpenById(id);
}
internal static bool IsInInstance() => Plugin.Condition[ConditionFlag.BoundByDuty56]; internal static bool IsInInstance()
{
return Plugin.Condition[ConditionFlag.BoundByDuty56];
}
internal static bool TryOpenAdventurerPlate(ulong playerId) internal static bool TryOpenAdventurerPlate(ulong playerId)
{ {
@@ -223,7 +255,8 @@ internal unsafe class GameFunctions : IDisposable
internal static void ClickNoviceNetworkButton() internal static void ClickNoviceNetworkButton()
{ {
var agent = AgentChatLog.Instance(); var agent = AgentChatLog.Instance();
var value = new AtkValue { Type = ValueType.Int, Int = 3 }; // case 3 // case 3
var value = new AtkValue { Type = ValueType.Int, Int = 3 };
var result = 0; var result = 0;
var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*) var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*)
agent->VirtualTable; agent->VirtualTable;
@@ -242,8 +275,9 @@ internal unsafe class GameFunctions : IDisposable
byte a4 byte a4
) )
{ {
// Hook field is nullable due to the Signature attribute, but will never // The detour is only invoked through the hook, so the hook should
// be null during normal execution; guard covers the teardown race only. // never be null here, but the nullable field declaration forces us
// to handle the theoretical race during teardown.
if (ResolveTextCommandPlaceholderHook is null) if (ResolveTextCommandPlaceholderHook is null)
return nint.Zero; return nint.Zero;
@@ -251,7 +285,9 @@ internal unsafe class GameFunctions : IDisposable
if (ReplacementName == null || placeholder != Placeholder) if (ReplacementName == null || placeholder != Placeholder)
return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4); return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4);
// Guard against a malformed ReplacementName overflowing the 128-byte buffer. // The fixed buffer is 128 bytes; UTF-8 + null-terminator must fit.
// FFXIV player names plus an @World suffix should never approach this
// limit, but a malformed ReplacementName must not overflow the buffer.
var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName); var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName);
if (byteCount >= PlaceholderBufferSize) if (byteCount >= PlaceholderBufferSize)
{ {
@@ -264,6 +300,7 @@ internal unsafe class GameFunctions : IDisposable
MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName); MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName);
ReplacementName = null; ReplacementName = null;
return PlaceholderNamePtr; return PlaceholderNamePtr;
} }
} }
@@ -40,11 +40,5 @@ public class TellTarget
public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct); public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct);
// --------------------------------------------------------------- public static TellTarget From(TellTarget t) => new(t.Name, t.World, t.ContentId, t.Reason);
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Replaced static From(t) with an instance-style Clone() so call
// sites read like a copy operation, not a factory.
// TEST-MIRROR: ../../../Hellion Build test/_Helpers/TellTargetCloneTests.cs
// ---------------------------------------------------------------
public TellTarget Clone() => new(Name, World, ContentId, Reason);
} }
+1 -1
View File
@@ -1,7 +1,7 @@
<Project Sdk="Dalamud.NET.Sdk/15.0.0"> <Project Sdk="Dalamud.NET.Sdk/15.0.0">
<PropertyGroup> <PropertyGroup>
<!-- Independent versioning; see yaml changelog for upstream Chat 2 base --> <!-- Independent versioning; see yaml changelog for upstream Chat 2 base -->
<Version>1.4.6</Version> <Version>1.4.3</Version>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<!-- Use lock file to pin exact versions --> <!-- Use lock file to pin exact versions -->
+140 -106
View File
@@ -1,26 +1,57 @@
name: Hellion Chat name: Hellion Chat
author: Jon Kazama (Hellion Forge) author: JonKazama-Hellion
punchline: A Hellion Forge plugin — privacy-focused chat replacement for FFXIV, built for EU, US and JP data rules. punchline: Chat replacement with privacy controls aligned to EU, US and JP rules — based on Chat 2 (EUPL-1.2)
description: |- description: |-
Chat replacement for FINAL FANTASY XIV with privacy controls built around Hellion Chat is a privacy-focused chat replacement for FINAL FANTASY XIV
EU, US and JP data-protection rules. based on the Chat 2 codebase (EUPL-1.2). One feature is intentionally
removed (the optional webinterface) and a stack of privacy controls is
added on top. Tabs, channel filters, RGB colours, emotes, screenshot
mode, IPC integration and the chat replacement window itself work the
same. The webinterface is intentionally not part of Hellion Chat because
it serves a different use case from the smaller default footprint this
plugin is built around.
By default only your own conversations are stored. Public chat, NPC On top of that, Hellion Chat adds privacy and data-handling controls
dialogue and system messages stay out of the database unless you opt in. designed to align with the modern data protection rules that apply
Retention windows are configurable per channel, history can be wiped across the EU, the United States and Japan. By default only your own
retroactively, and everything can be exported on demand. conversations are stored; messages from strangers, NPCs and system
spam stay out of the database. Retention windows are configurable per
channel, history can be wiped retroactively, and stored data can be
exported on demand.
Key privacy and data-handling features:
Features:
- Channel whitelist with a Privacy-First default - Channel whitelist with a Privacy-First default
- Per-channel retention with a daily background sweep - Per-channel retention with a daily background sweep
- Retroactive cleanup (Ctrl+Shift confirm) - Retroactive cleanup with a Ctrl+Shift confirm
- Export to Markdown, JSON or CSV - Export to Markdown, JSON or CSV
- First-run wizard with three preset profiles - First-run wizard with three preset profiles (Privacy-First, Casual,
- Bilingual UI (EN/DE) with live language switching Full History)
- Own config and database — no shared state with other plugins - Bilingual UI (English and German) with live language switching
- Independent plugin state — own config file and database directory,
so Hellion Chat does not share state with upstream Chat 2
Based on Chat 2 by Infi and Anna (EUPL-1.2). v1.4.2 — ChatLog Frame-Hot-Path. Three per-frame allocation
Support: https://discord.gg/X9V7Kcv5gR patterns gone from the chat-log render path: card-mode borders
hoist invariants out of the per-message loop, auto-tell tab
tint and icon get a per-tab cache, and the status bar gates
its tab aggregation behind the same one-second cache it uses
for the format strings.
v1.4.3 — Plugin-Load Async-Init plus Repo-Cutover. Plugin
migrated to Dalamud's IAsyncDalamudPlugin so the heavy work
(migrations, service allocations, window construction, hook
subscription) runs in LoadAsync without blocking Dalamud's
UI. Schema-gate replaces the v9 → v16 migration chain;
configs on schema v16+ load directly. Custom-repo URL moves
to gitea.hellion-forge.cloud, the GitHub repo stays as a
frozen v1.4.2 snapshot.
Based on Chat 2 by Infi and Anna, licensed under EUPL-1.2.
Modding & support: join the Hellion Forge Discord at
https://discord.gg/X9V7Kcv5gR — community for Hellion Chat and
other Hellion Online Media plugins/tools.
repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat
accepts_feedback: true accepts_feedback: true
icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png
@@ -35,101 +66,104 @@ tags:
- Replacement - Replacement
- Privacy - Privacy
changelog: |- changelog: |-
**v1.4.6Code Hygiene and Refactor (2026-05-12)** **Hellion Chat 1.4.3Plugin-Load Async-Init + Repo-Cutover (2026-05-08)**
Maintenance patch. No user-visible behaviour changes; tightens the Plugin lifecycle migrated to Dalamud's `IAsyncDalamudPlugin`
development feedback loop, fixes two upstream-inherited bugs, and API. The constructor now does only the bootstrap-essentials
prepares the code for the v1.4.7 backlog cleanup. (config load, language init, conflict detection); migrations,
service allocations, window construction and hook subscription
move to LoadAsync. Dalamud can keep its UI responsive while the
heavy work runs.
- preflight.sh gains a csharpier reflow check and a markdownlint - IAsyncDalamudPlugin two-phase load with per-line CaptureFailure
pass so style drift and markdown violations are caught at the in DisposeAsync (mirrors LightlessSync's pattern); idempotency
pre-push gate guard protects against reload races
- FontManager fallback catches the full set of atlas-toolkit - Schema-gate replaces the v9 → v16 migration chain. Configs
throws (IO, InvalidOperation, ArgumentException) — a corrupt on schema v16+ load directly; older configs trigger an
font config no longer takes down the whole atlas build "install v1.4.2 first" error so the historic migration
- BrandingLinks and IntegrationLinks URLs validated on plugin path stays intact
load — a typo in a future URL rotation now throws at startup - AutoTranslate.PreloadCache moved off the load path. First
- Cherry-picked from ChatTwo upstream f35b7d3: Chat.SetChannel use may have a sub-second hitch instead of every-load; the
no longer leaks the native Utf8String when the linkshell check upstream chose differently, we accept first-use latency
rejects the channel - FontManager.BuildFonts is called sync at the start of
- Cherry-picked from ChatTwo upstream f35b7d3: Tab.Clone now LoadAsync; Dalamud rebuilds the font atlas on its own
deep-clones UsedChannel and TellTarget — PopOut and Temp tabs pipeline so the custom Hellion-Exo2 font appears with a
no longer mutate each other's channel state brief font-pop after load (matches ChatTwo's behaviour)
- Active-tab underline scales with DPI and rounds to physical - Custom-repo URL moved to gitea.hellion-forge.cloud/
pixels for crisp rendering above 100% scaling JonKazama-Hellion/HellionChat. GitHub repo stays as a
- IconButton width parameter no longer subtracts HUD-scaled frozen v1.4.2 snapshot; new releases ship from Gitea.
padding from a raw int (measured width passes through verbatim) Existing testers need to update the custom-repo URL once
- Internal: HellionStyle ChildBgAlpha extracted to a testable - Plugin-load time in this release sits at ~3.7 s median
helper; Plugin.SaveConfig clones only the temp tabs; (5 reloads), comparable to v1.4.2. Async migration is
SettingsOverview caches the draw-list per frame; foundational for v1.4.4 Lazy-Init optimisations rather
Dalamud.Utility.Util surface routed through an IPlatformUtil than an immediate user-perceived win
indirection (MessageStore IsWine probe is now testable in
isolation) Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
- Built-in themes: Crystal Nocturne (sapphire and electric
magenta over obsidian, by CRYSTALLITE) replaces Moonlit Bloom. Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
Users with Moonlit Bloom selected fall back to Hellion Arctic
on first load **Hellion Chat 1.4.2 — ChatLog Frame-Hot-Path**
Third sub-patch of the v1.4.x Polish Sweep series. Per-frame
allocations from the chat-log render path eliminated.
- DrawMessages card-mode hoists theme/drawList/winLeft/winRight/
borderColorAbgr out of the per-message loop. About 500
redundant calls per frame at 100 visible messages, multiplied
by every pop-out window
- Auto-tell tab tint and icon use a per-tab cache. Hash
computation and string allocation only happen when the tell
target name or world drifts. AutoTellTabTint stays a pure
hash helper; cache lives in a thin TabTintCache wrapper
- Status bar gates its tab aggregation behind the same
one-second cache it already used for the format strings.
LINQ Sum and Count replaced with a single foreach pass
that runs on roughly 1% of frames
Realistic frame-time recovery: 2-5% in typical scenes, more
on pop-out-heavy setups because the card-border hoist scales
per window.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 1.4.1 — Theme Engine Performance**
Second sub-patch of the v1.4.x Polish Sweep series. Heap
pressure from the theme engine's per-frame render path
removed, plus a tenth built-in theme and hardening for
the custom-theme hot-reload.
- Theme records carry a pre-computed ABGR-packed cache
for every color slot; cache is filled when the theme
is registered and refreshed defensively on every
Switch()
- HellionStyle.PushGlobal reads ABGR values from the
cache instead of calling ColourUtil.RgbaToAbgr per
slot per frame; ~13 % render-time recovery measured
in typical scenes (plan estimate was 26 %, real
~1015 %)
- ThemeRegistry custom-theme reload distinguishes a
recoverable file lock (editor mid-save) from a
permanent IO failure; locked themes keep their
last-known-good snapshot and retry on the next
lookup instead of dropping out of the picker
- New built-in: Synthwave Sunset — Hot Magenta + Cyan
on midnight violet, 80s neon-grid vibes; tenth theme
in the picker
- Author credits refreshed: brand themes are credited
as "Hellion Forge"; Mint Grove and Forge Merchantman
now credited to Carla Beleandis as a community thanks
No schema bump, no user-visible behaviour change other
than smoother frames on GC-sensitive setups and one
additional colour option.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2). Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
--- ---
**v1.4.5 — UX and Robustness (2026-05-12)** Earlier history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases
Sixth sub-patch of the v1.4.x polish-sweep series. Chat-log draw
failures surface as a notification, the first-run wizard has an
explicit "Later" option, the input history clears on plugin reload,
and the status bar version slot stops clipping in narrow windows.
- Chat window draw errors now show a one-shot notification instead
of failing silently — stack trace stays in /xllog
- First-run wizard: explicit "Later — keep defaults" button.
Closing the X no longer silently accepts the defaults; the wizard
reopens on the next plugin load if nothing was picked
- InputHistoryService clears on plugin dispose so the previous
session's typed commands don't bleed into the next load
- Status bar hides the version slot when the chat window is too
narrow to fit all five slots without overlap
- Internal: explicit session-only Auto-Tell-Tab invariant in
Plugin.cs plus a pinning test in the Build-Suite
- Internal: FontManager falls back to the system font if the
embedded Hellion font resource is missing — logs a Warning
---
**v1.4.4 — Threading and IPC safety polish (2026-05-12)**
Fifth sub-patch of the v1.4.x polish-sweep series. Threading
assumptions are documented per-method, a hot-path lock falls
away, and the privacy filter speaks up when an unknown ChatType
shows up.
- AutoTellTabs hot-path getter uses an Interlocked counter
instead of taking the lock on every read
- Honorific integration: per-method threading banners, plus
Warning-level log on unsubscribe failure
- AutoTranslate warmup thread marked IsBackground so plugin
unload doesn't wait for it
- PrivacyFilter logs once per unknown ChatType so a future
patch's added channel doesn't drop off the radar
- New installs persist unknown channels by default; existing
configs keep their explicit choice
---
**v1.4.3 — Faster plugin load + new repo (2026-05-08)**
Heavy startup work (migrations, hooks, windows) now runs async so
Dalamud's UI stays responsive during load. Load time is comparable
to v1.4.2 — this is the foundation for v1.4.4 optimisations.
- Two-phase async load via IAsyncDalamudPlugin
- Schema-gate replaces the v9→v16 migration chain; old configs
require a v1.4.2 install first
- AutoTranslate cache loads on first use instead of every startup
- Custom font (Hellion-Exo2) appears with a brief pop after load
- Repo moved to gitea.hellion-forge.cloud — update your custom-repo URL
---
Full history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases
-9
View File
@@ -4,7 +4,6 @@ namespace HellionChat;
// Shared input history for all ChatInputBars (main and pop-out windows). // Shared input history for all ChatInputBars (main and pop-out windows).
// Push deduplicates: existing entries are moved to the end when re-added. // Push deduplicates: existing entries are moved to the end when re-added.
// TEST-MIRROR: ../../Hellion Build test/Util/InputHistoryServiceTests.cs
public static class InputHistoryService public static class InputHistoryService
{ {
private const int MaxSize = 30; private const int MaxSize = 30;
@@ -42,12 +41,4 @@ public static class InputHistoryService
return null; return null;
return _entries[cursor]; return _entries[cursor];
} }
// Plugin reload doesn't reset static state automatically. Plugin.DisposeAsync
// calls this so the next load starts with an empty history instead of
// inheriting the previous session's entries.
public static void Reset()
{
_entries.Clear();
}
} }
+12 -13
View File
@@ -27,7 +27,6 @@ internal sealed class HonorificService : IDisposable
private readonly IFramework _framework; private readonly IFramework _framework;
private bool _versionWarningLogged; private bool _versionWarningLogged;
// Thread: framework only — IPC delivery + ImGui render both run there.
public HonorificTitleData? CurrentTitle { get; private set; } public HonorificTitleData? CurrentTitle { get; private set; }
public bool IsAvailable { get; private set; } public bool IsAvailable { get; private set; }
public (uint Major, uint Minor)? DetectedApiVersion { get; private set; } public (uint Major, uint Minor)? DetectedApiVersion { get; private set; }
@@ -72,7 +71,6 @@ internal sealed class HonorificService : IDisposable
TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing)); TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing));
} }
// Thread: framework (scheduled from ctor and OnReady).
private void TryInitialPull() private void TryInitialPull()
{ {
try try
@@ -110,7 +108,6 @@ internal sealed class HonorificService : IDisposable
} }
} }
// Thread: framework (Dalamud IPC delivery contract).
private void OnTitleChanged(string json) private void OnTitleChanged(string json)
{ {
// Skip updates on version mismatch; subscription stays live for reload. // Skip updates on version mismatch; subscription stays live for reload.
@@ -119,13 +116,12 @@ internal sealed class HonorificService : IDisposable
CurrentTitle = ParseTitleJson(json); CurrentTitle = ParseTitleJson(json);
} }
// Thread: any (Honorific dispatches NotifyReady from its own thread).
private void OnReady() private void OnReady()
{ {
// Schedule on framework thread — NotifyReady can dispatch from any thread.
_framework.RunOnFrameworkThread(TryInitialPull); _framework.RunOnFrameworkThread(TryInitialPull);
} }
// Thread: framework (IPC delivery contract); idempotent — Disposing fires once.
private void OnDisposing() private void OnDisposing()
{ {
// Honorific unloading — clear cached state so the header hides next frame. // Honorific unloading — clear cached state so the header hides next frame.
@@ -137,8 +133,6 @@ internal sealed class HonorificService : IDisposable
DetectedApiVersion = null; DetectedApiVersion = null;
} }
// Thread: framework (called from Dispose, which runs on the framework
// cleanup block in Plugin.DisposeAsync).
private void TryUnsubscribe(Action unsubscribe) private void TryUnsubscribe(Action unsubscribe)
{ {
try try
@@ -147,15 +141,20 @@ internal sealed class HonorificService : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// Warning not Debug — a silent unsubscribe failure leaks a live _log.Debug(ex, "Honorific unsubscribe failed (likely already gone).");
// subscription across plugin reloads.
_log.Warning(
ex,
"Honorific unsubscribe failed (likely API break or gate already gone)."
);
} }
} }
// Threading: IPC events and ImGui both run on the framework thread, so
// OnTitleChanged and the render path never race — no volatile/Interlocked
// needed as long as Dalamud's framework-thread delivery contract holds.
//
// Constructor and OnReady are exceptions: they run outside that contract
// (plugin-loader thread and Honorific's NotifyReady respectively), so both
// use RunOnFrameworkThread to safely reach ObjectTable.LocalPlayer.
// --- Pure-logic helpers; tested via HellionChat.Tests/Integrations. ---
internal static HonorificTitleData? ParseTitleJson(string json) internal static HonorificTitleData? ParseTitleJson(string json)
{ {
if (string.IsNullOrEmpty(json)) if (string.IsNullOrEmpty(json))
@@ -1,6 +1,3 @@
using System.Runtime.CompilerServices;
using HellionChat.Util;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// Third-party plugin URLs — separate from BrandingLinks (Hellion-owned URLs). // Third-party plugin URLs — separate from BrandingLinks (Hellion-owned URLs).
@@ -8,13 +5,4 @@ internal static class IntegrationLinks
{ {
public const string HonorificRepo = "https://github.com/Caraxi/Honorific"; public const string HonorificRepo = "https://github.com/Caraxi/Honorific";
public const string HonorificAuthor = "https://github.com/Caraxi"; public const string HonorificAuthor = "https://github.com/Caraxi";
// See BrandingLinks.ValidateUrls for the CA2255 rationale.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(nameof(IntegrationLinks), HonorificRepo, HonorificAuthor);
}
} }
+19 -8
View File
@@ -26,9 +26,10 @@ public sealed class ExtraChat : IDisposable
internal (string, uint)? ChannelOverride { get; set; } internal (string, uint)? ChannelOverride { get; set; }
// volatile: IPC callbacks fire on a Dalamud thread while ImGui reads these. // Volatile reference: IPC callbacks (OnChannelCommandColours/OnChannelNames) fire on a
// Reference assignment is atomic on x64, but the barrier ensures visibility // Dalamud-dispatcher thread while the ImGui thread reads the IReadOnlyDictionary projections.
// across threads (especially Mono/Wine). See AUDIT-2026-05-05 [SEC-01]. // Reference assignment is atomic on x64, but the JIT (especially Mono on Wine/Linux) needs
// the volatile barrier to guarantee visibility across threads. See AUDIT-2026-05-05 [SEC-01].
private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new(); private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new();
internal IReadOnlyDictionary<string, uint> ChannelCommandColours => internal IReadOnlyDictionary<string, uint> ChannelCommandColours =>
ChannelCommandColoursInternal; ChannelCommandColoursInternal;
@@ -53,7 +54,6 @@ public sealed class ExtraChat : IDisposable
OverrideChannelGate.Subscribe(OnOverrideChannel); OverrideChannelGate.Subscribe(OnOverrideChannel);
ChannelCommandColoursGate.Subscribe(OnChannelCommandColours); ChannelCommandColoursGate.Subscribe(OnChannelCommandColours);
ChannelNamesGate.Subscribe(OnChannelNames); ChannelNamesGate.Subscribe(OnChannelNames);
try try
{ {
ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!); ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!);
@@ -61,7 +61,7 @@ public sealed class ExtraChat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// ExtraChat is optional; IPC failure is normal when the plugin isn't loaded. // ExtraChat is optional; missing IPC peer is normal when the plugin isn't loaded.
Plugin.Log.Verbose(ex, "ExtraChat IPC initial state query failed (peer not loaded?)"); Plugin.Log.Verbose(ex, "ExtraChat IPC initial state query failed (peer not loaded?)");
} }
} }
@@ -75,11 +75,22 @@ public sealed class ExtraChat : IDisposable
private void OnOverrideChannel(OverrideInfo info) private void OnOverrideChannel(OverrideInfo info)
{ {
ChannelOverride = info.Channel == null ? null : (info.Channel, info.Rgba); if (info.Channel == null)
{
ChannelOverride = null;
return;
}
ChannelOverride = (info.Channel, info.Rgba);
} }
private void OnChannelCommandColours(Dictionary<string, uint> obj) => private void OnChannelCommandColours(Dictionary<string, uint> obj)
{
ChannelCommandColoursInternal = obj; ChannelCommandColoursInternal = obj;
}
private void OnChannelNames(Dictionary<Guid, string> obj) => ChannelNamesInternal = obj; private void OnChannelNames(Dictionary<Guid, string> obj)
{
ChannelNamesInternal = obj;
}
} }
+1 -1
View File
@@ -52,7 +52,7 @@ internal class MessageManager : IAsyncDisposable
{ {
Plugin = plugin; Plugin = plugin;
Store = new MessageStore(DatabasePath(), Plugin.PlatformUtil); Store = new MessageStore(DatabasePath());
PendingMessageThread = new Thread(() => PendingMessageThread = new Thread(() =>
ProcessPendingMessages(PendingThreadCancellationToken.Token) ProcessPendingMessages(PendingThreadCancellationToken.Token)
+207 -57
View File
@@ -9,6 +9,7 @@ using MessagePack;
using MessagePack.Formatters; using MessagePack.Formatters;
using MessagePack.Resolvers; using MessagePack.Resolvers;
using Microsoft.Data.Sqlite; using Microsoft.Data.Sqlite;
using DalamudUtil = Dalamud.Utility.Util;
using Encoding = System.Text.Encoding; using Encoding = System.Text.Encoding;
namespace HellionChat; namespace HellionChat;
@@ -126,6 +127,7 @@ internal class MessageStore : IDisposable
private const int MessageQueryLimit = 10_000; private const int MessageQueryLimit = 10_000;
private string DbPath { get; } private string DbPath { get; }
private SqliteConnection Connection { get; set; } private SqliteConnection Connection { get; set; }
internal static readonly MessagePackSerializerOptions MsgPackOptions = internal static readonly MessagePackSerializerOptions MsgPackOptions =
@@ -136,20 +138,19 @@ internal class MessageStore : IDisposable
) )
); );
private readonly IPlatformUtil _platformUtil; internal MessageStore(string dbPath)
internal MessageStore(string dbPath, IPlatformUtil platformUtil)
{ {
DbPath = dbPath; DbPath = dbPath;
_platformUtil = platformUtil;
Connection = Connect(); Connection = Connect();
Migrate(); Migrate();
} }
public void Dispose() public void Dispose()
{ {
// Pooling=false avoids ClearAllPools which is provider-wide and // Pooling=false (set in Connect) avoids ClearAllPools, which is
// would touch other plugins' SQLite connections. // provider-wide and would touch other plugins' SQLite connections.
// GC.Collect was here as a defensive flush; removed because explicit
// Close already releases everything we hold.
Connection.Close(); Connection.Close();
Connection.Dispose(); Connection.Dispose();
} }
@@ -168,13 +169,14 @@ internal class MessageStore : IDisposable
conn.Open(); conn.Open();
conn.Execute(@"PRAGMA journal_mode=WAL;"); conn.Execute(@"PRAGMA journal_mode=WAL;");
conn.Execute(@"PRAGMA synchronous=NORMAL;"); conn.Execute(@"PRAGMA synchronous=NORMAL;");
if (_platformUtil.IsWine) if (DalamudUtil.IsWine())
conn.Execute(@"PRAGMA cache_size = 32768;"); conn.Execute(@"PRAGMA cache_size = 32768;");
return conn; return conn;
} }
private void Migrate() private void Migrate()
{ {
// Get current user_version.
using var cmd = Connection.CreateCommand(); using var cmd = Connection.CreateCommand();
cmd.CommandText = "PRAGMA user_version;"; cmd.CommandText = "PRAGMA user_version;";
var userVersion = Convert.ToInt32(cmd.ExecuteScalar()); var userVersion = Convert.ToInt32(cmd.ExecuteScalar());
@@ -184,7 +186,9 @@ internal class MessageStore : IDisposable
{ {
case <= 0: case <= 0:
migrationsToDo.Add(Migrate0); migrationsToDo.Add(Migrate0);
// Migration support was only added in version 1. Migrate0 is idempotent.
// Migration support was only added in version 1. Migrate 0 is
// idempotent.
migrationsToDo.Add(Migrate1); migrationsToDo.Add(Migrate1);
migrationsToDo.Add(Migrate2); migrationsToDo.Add(Migrate2);
migrationsToDo.Add(Migrate3); migrationsToDo.Add(Migrate3);
@@ -234,6 +238,7 @@ internal class MessageStore : IDisposable
Plugin.Log.Information("Running migration 1: Adding Deleted column"); Plugin.Log.Information("Running migration 1: Adding Deleted column");
Connection.Execute( Connection.Execute(
@" @"
-- Migration 1: Add Deleted column
ALTER TABLE messages ADD COLUMN Deleted BOOLEAN NOT NULL DEFAULT false; ALTER TABLE messages ADD COLUMN Deleted BOOLEAN NOT NULL DEFAULT false;
" "
); );
@@ -246,6 +251,7 @@ internal class MessageStore : IDisposable
Plugin.Log.Information("Running migration 2: Adding Channel generated column"); Plugin.Log.Information("Running migration 2: Adding Channel generated column");
Connection.Execute( Connection.Execute(
@" @"
-- Migration 2: Add Channel generated column
ALTER TABLE messages ADD COLUMN Channel INTEGER GENERATED ALWAYS AS (Code & 0x7f) VIRTUAL; ALTER TABLE messages ADD COLUMN Channel INTEGER GENERATED ALWAYS AS (Code & 0x7f) VIRTUAL;
CREATE INDEX IF NOT EXISTS idx_messages_channel ON messages (Channel); CREATE INDEX IF NOT EXISTS idx_messages_channel ON messages (Channel);
" "
@@ -256,8 +262,9 @@ internal class MessageStore : IDisposable
private bool ColumnExists(string table, string column) private bool ColumnExists(string table, string column)
{ {
// PRAGMA does not accept SQLite parameter bindings. Table name is a // PRAGMA does not accept SQLite parameter bindings. The table name is
// compile-time constant from internal call sites only. // a compile-time constant fed in from internal call sites, so the
// interpolation cannot be reached from any user-controlled path.
using var cmd = Connection.CreateCommand(); using var cmd = Connection.CreateCommand();
cmd.CommandText = $"PRAGMA table_info({table});"; cmd.CommandText = $"PRAGMA table_info({table});";
using var reader = cmd.ExecuteReader(); using var reader = cmd.ExecuteReader();
@@ -273,8 +280,9 @@ internal class MessageStore : IDisposable
{ {
Plugin.Log.Information("Running migration 3: Fix log kinds to fit the new format"); Plugin.Log.Information("Running migration 3: Fix log kinds to fit the new format");
// Recovery for partially-applied Migrate3: schema already in target // Recovery for partially-applied Migrate3: if the schema is already
// shape but user_version was never bumped -- just record and exit. // in its target shape (new columns exist, old Code column gone) but
// user_version was never bumped, just record the version and exit.
if (ColumnExists("messages", "ChatType") && !ColumnExists("messages", "Code")) if (ColumnExists("messages", "ChatType") && !ColumnExists("messages", "Code"))
{ {
Plugin.Log.Information( Plugin.Log.Information(
@@ -286,6 +294,15 @@ internal class MessageStore : IDisposable
Connection.Execute( Connection.Execute(
@" @"
-- Migration 3: Fix log kinds to fit the new format
-- Add new ChatType, SourceKind, TargetKind (byte), SortCodeV2
-- Migrate OldChatColumn
-- ChatType = OldChatColumn & 0x7f
-- SourceKind = log2(1 << ((OldChatColumn >> 11) & 0xF))
-- TargetKind = trunc(log2(1 << ((OldChatColumn >> 7) & 0xF)))
-- Virtual SortCodeV2 = ChatType << 16 | SourceKind << 8 | TargetKind
-- Delete OldChatColumn, Virtual Channel
ALTER TABLE messages ADD COLUMN ChatType INTEGER; ALTER TABLE messages ADD COLUMN ChatType INTEGER;
CREATE INDEX IF NOT EXISTS idx_messages_chat_type ON messages (ChatType); CREATE INDEX IF NOT EXISTS idx_messages_chat_type ON messages (ChatType);
ALTER TABLE messages ADD COLUMN SourceKind INTEGER; ALTER TABLE messages ADD COLUMN SourceKind INTEGER;
@@ -311,8 +328,10 @@ internal class MessageStore : IDisposable
{ {
Plugin.Log.Information($"Setting version {version}"); Plugin.Log.Information($"Setting version {version}");
using var cmd = Connection.CreateCommand(); using var cmd = Connection.CreateCommand();
// PRAGMA does not accept SQLite parameter bindings; version is a // PRAGMA does not accept SQLite parameter bindings, and there is no
// compile-time int from the migration sequence, never user input. // pragma_ function variant that can set the version either. The
// version is a compile-time int from the migration sequence, never
// user input.
cmd.CommandText = $"PRAGMA user_version = {version};"; cmd.CommandText = $"PRAGMA user_version = {version};";
cmd.ExecuteNonQuery(); cmd.ExecuteNonQuery();
} }
@@ -323,8 +342,11 @@ internal class MessageStore : IDisposable
PerformMaintenance(); PerformMaintenance();
} }
// Returns a (ChatType, count) snapshot over non-deleted messages. /// <summary>
// Used by the Privacy tab to preview retroactive cleanup impact. /// Returns a (ChatType, count) snapshot over non-deleted messages.
/// Used by the Privacy tab to preview the impact of a retroactive
/// cleanup before the user confirms.
/// </summary>
internal Dictionary<int, long> GetMessageCountsByChatType() internal Dictionary<int, long> GetMessageCountsByChatType()
{ {
var result = new Dictionary<int, long>(); var result = new Dictionary<int, long>();
@@ -342,9 +364,12 @@ internal class MessageStore : IDisposable
return result; return result;
} }
// Deletes messages older than the per-channel retention window, with a global /// <summary>
// default for unmapped channels. Runs VACUUM only if rows were removed. /// Deletes messages older than the per-channel retention window, with a
// Returns the number of rows deleted. /// global default for channels not listed explicitly. Cutoffs are
/// computed from "now" at call time. Runs VACUUM only if anything was
/// removed. Returns the number of rows deleted.
/// </summary>
internal long DeleteByRetentionPolicy( internal long DeleteByRetentionPolicy(
IReadOnlyDictionary<int, int> chatTypeDaysMap, IReadOnlyDictionary<int, int> chatTypeDaysMap,
int defaultDays int defaultDays
@@ -383,7 +408,10 @@ internal class MessageStore : IDisposable
index++; index++;
} }
// defaultDays=0 means "keep forever" for unmapped channels. // Catch-all for channels without an explicit override. "0" is
// treated as "do not delete by default" — without an explicit
// user override, unmapped channels stay forever instead of
// getting wiped immediately.
if (defaultDays > 0) if (defaultDays > 0)
{ {
var defaultCutoff = nowMs - defaultDays * 86400000L; var defaultCutoff = nowMs - defaultDays * 86400000L;
@@ -411,14 +439,21 @@ internal class MessageStore : IDisposable
return deleted; return deleted;
} }
// Hard-deletes every message whose ChatType is not in the allowlist, /// <summary>
// then VACUUMs. Returns the number of rows deleted. /// Hard-deletes every message whose ChatType is not in the supplied
/// allowlist, then VACUUMs the database to reclaim disk space.
/// Returns the number of rows deleted.
/// </summary>
internal long CleanupRetainOnly(IReadOnlyCollection<int> allowedTypes) internal long CleanupRetainOnly(IReadOnlyCollection<int> allowedTypes)
{ {
if (allowedTypes.Count == 0) if (allowedTypes.Count == 0)
{
// Defensive: refuse a "delete everything" disguised as a filter.
// Use ClearMessages() if a full wipe is actually intended.
throw new InvalidOperationException( throw new InvalidOperationException(
"CleanupRetainOnly requires at least one allowed ChatType. Use ClearMessages for a full wipe." "CleanupRetainOnly requires at least one allowed ChatType. Use ClearMessages for a full wipe."
); );
}
long deleted; long deleted;
using (var cmd = Connection.CreateCommand()) using (var cmd = Connection.CreateCommand())
@@ -458,9 +493,14 @@ internal class MessageStore : IDisposable
internal void UpsertMessage(Message message) internal void UpsertMessage(Message message)
{ {
// Privacy filter -- drop disallowed ChatTypes before they reach storage. // Hellion Chat privacy filter drop disallowed ChatTypes before
// they reach the storage layer (single source of truth, also
// covers any future write paths e.g. webinterface backfill).
if (!Plugin.Config.IsAllowedForStorage(message.Code.Type)) if (!Plugin.Config.IsAllowedForStorage(message.Code.Type))
{ {
// Verbose-only: this fires for every dropped message, which is
// the common case for users with a tight privacy whitelist. Keep
// it for diagnostics but stay out of the default xllog stream.
Plugin.Log.Verbose($"Privacy filter dropped message: ChatType={message.Code.Type}"); Plugin.Log.Verbose($"Privacy filter dropped message: ChatType={message.Code.Type}");
return; return;
} }
@@ -469,11 +509,33 @@ internal class MessageStore : IDisposable
cmd.CommandText = cmd.CommandText =
@" @"
INSERT INTO messages ( INSERT INTO messages (
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel, Deleted Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel,
Deleted
) VALUES ( ) VALUES (
$Id, $Receiver, $ContentId, $Date, $ChatType, $SourceKind, $TargetKind, $Id,
$Sender, $Content, $SenderSource, $ContentSource, $ExtraChatChannel, false $Receiver,
$ContentId,
$Date,
$ChatType,
$SourceKind,
$TargetKind,
$Sender,
$Content,
$SenderSource,
$ContentSource,
$ExtraChatChannel,
false
) )
ON CONFLICT (id) DO UPDATE SET ON CONFLICT (id) DO UPDATE SET
Receiver = excluded.Receiver, Receiver = excluded.Receiver,
@@ -518,9 +580,13 @@ internal class MessageStore : IDisposable
cmd.ExecuteNonQuery(); cmd.ExecuteNonQuery();
} }
// Streams messages for export, sorted ascending by Date, excluding soft-deleted rows. /// <summary>
// Optional filters: chatTypes, from/to inclusive date range. /// Streams messages for export. Optional filters:
// Caller is responsible for disposing the enumerator. /// - <paramref name="chatTypes"/>: limit to these ChatTypes
/// - <paramref name="from"/> / <paramref name="to"/>: inclusive date range
/// Result is sorted ascending by Date and excludes soft-deleted rows.
/// Caller is responsible for disposing the enumerator.
/// </summary>
internal MessageEnumerator StreamForExport( internal MessageEnumerator StreamForExport(
IReadOnlyCollection<int>? chatTypes, IReadOnlyCollection<int>? chatTypes,
DateTimeOffset? from, DateTimeOffset? from,
@@ -540,8 +606,18 @@ internal class MessageStore : IDisposable
cmd.CommandText = cmd.CommandText =
@" @"
SELECT SELECT
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel
FROM messages FROM messages
WHERE " WHERE "
+ string.Join(" AND ", clauses) + string.Join(" AND ", clauses)
@@ -557,10 +633,12 @@ internal class MessageStore : IDisposable
return new MessageEnumerator(cmd.ExecuteReader()); return new MessageEnumerator(cmd.ExecuteReader());
} }
// Returns the most recent messages, oldest-first. /// <summary>
// receiver: filter by receiver ContentId (null = no filter) /// Get the most recent messages.
// since: only include messages after this date (null = no filter) /// </summary>
// count: max rows to return, defaults to 10,000 /// <param name="receiver">The receiver content ID to filter by. If null, no filtering is performed.</param>
/// <param name="since">Only show messages since this date. If null, no filtering is performed.</param>
/// <param name="count">The amount to return. Defaults to 10,000.</param>
internal MessageEnumerator GetMostRecentMessages( internal MessageEnumerator GetMostRecentMessages(
ulong? receiver = null, ulong? receiver = null,
DateTimeOffset? since = null, DateTimeOffset? since = null,
@@ -576,14 +654,25 @@ internal class MessageStore : IDisposable
var whereClause = "WHERE " + string.Join(" AND ", whereClauses); var whereClause = "WHERE " + string.Join(" AND ", whereClauses);
var cmd = Connection.CreateCommand(); var cmd = Connection.CreateCommand();
// Select last N by date DESC, then reverse to ascending order. // Select last N messages by date DESC, but reverse the order to get
// them in ascending order.
cmd.CommandText = cmd.CommandText =
@" @"
SELECT * SELECT *
FROM ( FROM (
SELECT SELECT
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel
FROM messages FROM messages
" "
+ whereClause + whereClause
@@ -593,7 +682,7 @@ internal class MessageStore : IDisposable
) )
ORDER BY Date ASC; ORDER BY Date ASC;
"; ";
cmd.CommandTimeout = 120; cmd.CommandTimeout = 120; // this could take a while on slow computers
if (receiver != null) if (receiver != null)
cmd.Parameters.AddWithValue("$Receiver", receiver); cmd.Parameters.AddWithValue("$Receiver", receiver);
@@ -605,10 +694,21 @@ internal class MessageStore : IDisposable
return new MessageEnumerator(cmd.ExecuteReader()); return new MessageEnumerator(cmd.ExecuteReader());
} }
// Returns up to limit tells exchanged with the named player, oldest-first. /// <summary>
// SQL narrows by Receiver + ChatType (indexed); client does the final /// Hellion Chat — Auto-Tell-Tabs history preload.
// PlayerPayload comparison. sqlScanLimit caps the scan to stay within ///
// the message-processing worker thread budget. /// Returns up to <paramref name="limit"/> tells exchanged with the named
/// player, oldest-first, ready to be added to a freshly spawned auto
/// tell tab. The Sender column is a serialized chunk blob, so SQL on its
/// own cannot filter by player identity; we narrow with SQL on Receiver
/// + ChatType (cheap, indexed) and let the client do the final
/// PlayerPayload comparison on the result set.
///
/// <paramref name="sqlScanLimit"/> caps how many recent tells we scan
/// before giving up. 500 covers around 10 days for an active greeter
/// and stays well under the 20 ms budget required to keep the spawn on
/// the message-processing worker thread.
/// </summary>
internal IReadOnlyList<Message> GetTellHistoryWithSender( internal IReadOnlyList<Message> GetTellHistoryWithSender(
ulong receiver, ulong receiver,
string senderName, string senderName,
@@ -618,14 +718,26 @@ internal class MessageStore : IDisposable
) )
{ {
if (limit <= 0) if (limit <= 0)
{
return []; return [];
}
using var cmd = Connection.CreateCommand(); using var cmd = Connection.CreateCommand();
cmd.CommandText = cmd.CommandText =
@" @"
SELECT SELECT
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel
FROM messages FROM messages
WHERE deleted = false WHERE deleted = false
AND Receiver = $Receiver AND Receiver = $Receiver
@@ -644,19 +756,27 @@ internal class MessageStore : IDisposable
foreach (var message in enumerator) foreach (var message in enumerator)
{ {
if (!ChunkUtil.MatchesSender(message, senderName, senderWorld)) if (!ChunkUtil.MatchesSender(message, senderName, senderWorld))
{
continue; continue;
}
collected.Add(message); collected.Add(message);
if (collected.Count >= limit) if (collected.Count >= limit)
{
break; break;
}
} }
// SQL was DESC (newest-first); reverse to oldest-first for tab display. // SQL was DESC (newest-first) so we hit the limit on the most
// recent matching tells. Reverse to oldest-first for chronological
// display in the tab.
collected.Reverse(); collected.Reverse();
return collected; return collected;
} }
// Soft-deletes a message so it won't appear in queries. /// <summary>
/// Marks a message as deleted so it won't get returned in queries.
/// </summary>
internal void DeleteMessage(Guid id) internal void DeleteMessage(Guid id)
{ {
using var cmd = Connection.CreateCommand(); using var cmd = Connection.CreateCommand();
@@ -683,6 +803,8 @@ internal class MessageStore : IDisposable
var whereClause = "WHERE " + string.Join(" AND ", whereClauses); var whereClause = "WHERE " + string.Join(" AND ", whereClauses);
// Select last N messages by date DESC, but reverse the order to get
// them in ascending order.
cmd.CommandText = cmd.CommandText =
@" @"
SELECT COUNT(*) SELECT COUNT(*)
@@ -694,7 +816,7 @@ internal class MessageStore : IDisposable
cmd.Parameters.AddWithValue("$After", ((DateTimeOffset)after).ToUnixTimeMilliseconds()); cmd.Parameters.AddWithValue("$After", ((DateTimeOffset)after).ToUnixTimeMilliseconds());
cmd.Parameters.AddWithValue("$Before", ((DateTimeOffset)before).ToUnixTimeMilliseconds()); cmd.Parameters.AddWithValue("$Before", ((DateTimeOffset)before).ToUnixTimeMilliseconds());
cmd.CommandTimeout = 120; cmd.CommandTimeout = 120; // this could take a while on slow computers
return (long)cmd.ExecuteScalar()!; return (long)cmd.ExecuteScalar()!;
} }
@@ -717,14 +839,26 @@ internal class MessageStore : IDisposable
var whereClause = $"WHERE {string.Join(" AND ", whereClauses)}"; var whereClause = $"WHERE {string.Join(" AND ", whereClauses)}";
// Select last N messages by date DESC, but reverse the order to get
// them in ascending order.
cmd.CommandText = cmd.CommandText =
@" @"
SELECT SELECT
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel
FROM messages FROM messages
" + whereClause; " + whereClause;
cmd.CommandTimeout = 120; cmd.CommandTimeout = 120; // this could take a while on slow computers
if (receiver != null) if (receiver != null)
cmd.Parameters.AddWithValue("$Receiver", receiver); cmd.Parameters.AddWithValue("$Receiver", receiver);
@@ -754,11 +888,23 @@ internal class MessageStore : IDisposable
var whereClause = $"WHERE {string.Join(" AND ", whereClauses)}"; var whereClause = $"WHERE {string.Join(" AND ", whereClauses)}";
// Select last N messages by date DESC, but reverse the order to get
// them in ascending order.
cmd.CommandText = cmd.CommandText =
@" @"
SELECT SELECT
Id, Receiver, ContentId, Date, ChatType, SourceKind, TargetKind, Id,
Sender, Content, SenderSource, ContentSource, ExtraChatChannel Receiver,
ContentId,
Date,
ChatType,
SourceKind,
TargetKind,
Sender,
Content,
SenderSource,
ContentSource,
ExtraChatChannel
FROM messages FROM messages
" "
+ whereClause + whereClause
@@ -766,7 +912,7 @@ internal class MessageStore : IDisposable
ORDER BY Date ORDER BY Date
LIMIT $Offset, $OffsetCount; LIMIT $Offset, $OffsetCount;
"; ";
cmd.CommandTimeout = 120; cmd.CommandTimeout = 120; // this could take a while on slow computers
if (receiver != null) if (receiver != null)
cmd.Parameters.AddWithValue("$Receiver", receiver); cmd.Parameters.AddWithValue("$Receiver", receiver);
@@ -779,8 +925,10 @@ internal class MessageStore : IDisposable
return new MessageEnumerator(cmd.ExecuteReader()); return new MessageEnumerator(cmd.ExecuteReader());
} }
// Builds a "$prefix0,$prefix1,..." placeholder list and binds values to the command. // Build "$prefix0,$prefix1,..." placeholder list and bind values to
// SQLite has no native array parameter, so placeholders are generated per entry. // the command. SQLite has no native array parameter, so we generate
// the list at runtime and bind each entry under its own name. Used
// for IN-clauses and similar dynamic-arity SQL fragments.
private static string BindIntList(SqliteCommand cmd, string prefix, IEnumerable<int> values) private static string BindIntList(SqliteCommand cmd, string prefix, IEnumerable<int> values)
{ {
var names = new List<string>(); var names = new List<string>();
@@ -803,6 +951,8 @@ internal class MessageEnumerator(DbDataReader reader)
{ {
private const int MaxErrorLogs = 10; private const int MaxErrorLogs = 10;
// FailedIds and FailedCount are separate, because messages might fail to
// even parse the ID field.
private readonly List<Guid> FailedIds = []; private readonly List<Guid> FailedIds = [];
private int FailedCount; private int FailedCount;
public bool DidError => FailedCount > 0; public bool DidError => FailedCount > 0;
+8 -28
View File
@@ -113,10 +113,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal Ui.StatusBar StatusBar { get; private set; } = null!; internal Ui.StatusBar StatusBar { get; private set; } = null!;
internal Integrations.HonorificService HonorificService { get; private set; } = null!; internal Integrations.HonorificService HonorificService { get; private set; } = null!;
// Platform indirection over Dalamud.Utility.Util. Wired in Phase-1 ctor so
// any service allocated in LoadAsync can read Plugin.PlatformUtil.
internal static IPlatformUtil PlatformUtil { get; private set; } = null!;
// Idempotency guard — Dalamud may fire DisposeAsync twice in a reload race. // Idempotency guard — Dalamud may fire DisposeAsync twice in a reload race.
private int _disposeStarted; private int _disposeStarted;
@@ -158,24 +154,17 @@ public sealed class Plugin : IAsyncDalamudPlugin
Config = Interface.GetPluginConfig() as Configuration ?? new Configuration(); Config = Interface.GetPluginConfig() as Configuration ?? new Configuration();
// Wire platform indirection before LoadAsync allocates anything that // Schema gate: v1.4.3 requires config v16. Users on older schemas
// needs Util.* — services then read Plugin.PlatformUtil instead of
// hitting the Dalamud static surface directly.
PlatformUtil = new DalamudPlatformUtil();
// Schema gate: v1.4.x requires config v16. Users on older schemas
// must install v1.4.2 first to run the migration chain. // must install v1.4.2 first to run the migration chain.
if (Config.Version < 16) if (Config.Version < 16)
{ {
throw new InvalidOperationException( throw new InvalidOperationException(
$"HellionChat v1.4.6 requires config schema v16, got v{Config.Version}. " $"HellionChat v1.4.3 requires config schema v16, got v{Config.Version}. "
+ "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.6." + "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.3."
); );
} }
// Session-only tabs are stripped on every load; AutoTellTabsService.Initialize // Drop session-only Auto-Tell-Tabs that a previous crash may have persisted.
// then re-pegs TempTabCounter from the stripped list, not the pre-strip snapshot.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/TempTabCounterTests.cs
Config.Tabs.RemoveAll(t => t.IsTempTab); Config.Tabs.RemoveAll(t => t.IsTempTab);
LanguageChanged(Interface.UiLanguage); LanguageChanged(Interface.UiLanguage);
@@ -383,8 +372,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
failure = CaptureFailure(failure, () => Functions?.Dispose()); failure = CaptureFailure(failure, () => Functions?.Dispose());
failure = CaptureFailure(failure, () => Commands?.Dispose()); failure = CaptureFailure(failure, () => Commands?.Dispose());
failure = CaptureFailure(failure, () => EmoteCache.Dispose()); failure = CaptureFailure(failure, () => EmoteCache.Dispose());
// Static input history would otherwise survive the plugin reload.
failure = CaptureFailure(failure, InputHistoryService.Reset);
if (failure is not null) if (failure is not null)
ExceptionDispatchInfo.Capture(failure).Throw(); ExceptionDispatchInfo.Capture(failure).Throw();
@@ -646,21 +633,14 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal void SaveConfig() internal void SaveConfig()
{ {
// Session-only Auto-Tell-Tabs aren't persisted, so they move aside // Strip session-only Auto-Tell-Tabs before serialization; restore after.
// before serialization and re-attach after. Cloning only the temp var snapshot = Config.Tabs.ToList();
// subset keeps the allocation proportional to AutoTellTabsLimit
// (<=15) instead of the full tab list.
var tempTabs = Config.Tabs.Where(t => t.IsTempTab).ToList();
Config.Tabs.RemoveAll(t => t.IsTempTab); Config.Tabs.RemoveAll(t => t.IsTempTab);
Interface.SavePluginConfig(Config); Interface.SavePluginConfig(Config);
Config.Tabs.AddRange(tempTabs); Config.Tabs.Clear();
Config.Tabs.AddRange(snapshot);
// F2.1: the mid-step RemoveAll bypasses AutoTellTabsService, so
// re-peg the counter. Null-conditional because SaveConfig can fire
// before Phase-2 init.
AutoTellTabsService?.ResyncTempTabCounter();
} }
internal void LanguageChanged(string langCode) internal void LanguageChanged(string langCode)
+12 -14
View File
@@ -4,15 +4,10 @@ namespace HellionChat.Privacy;
internal static class PrivacyDefaults internal static class PrivacyDefaults
{ {
// F3.1: failsafe for ChatTypes added by future FFXIV patches. New installs // Privacy-First default whitelist (DSGVO Art. 25 - Privacy by Default).
// persist unknown channels so a major patch's added ChatType isn't silently // Only the player's own conversations are persisted out-of-the-box.
// dropped before the user can opt in or out. Existing configs keep their // Public chat (Say/Shout/Yell), Novice Network, NPC dialogue, system
// explicit choice — see Configuration.cs PrivacyPersistUnknownChannels. // logs and battle messages are NOT persisted unless the user opts in.
internal const bool DefaultPersistUnknownChannels = true;
// DSGVO Art. 25 (Privacy by Default): only the player's own conversations
// are persisted out-of-the-box. Public chat, NPC dialogue, system logs and
// battle messages require explicit opt-in.
internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType> internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType>
{ {
ChatType.TellIncoming, ChatType.TellIncoming,
@@ -47,8 +42,10 @@ internal static class PrivacyDefaults
ChatType.ExtraChatLinkshell8, ChatType.ExtraChatLinkshell8,
}; };
// Per-channel retention in days. Unlisted channels fall back to // Default retention windows per channel (in days). Channels not listed
// Configuration.RetentionDefaultDays. Tells: 365, everything else: 90. // here fall back to Configuration.RetentionDefaultDays. Reflects the
// design spec: Tells 365, own-conversation channels 90, everything else
// shorter via the global default.
internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays = internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays =
new Dictionary<ChatType, int> new Dictionary<ChatType, int>
{ {
@@ -89,9 +86,10 @@ internal static class PrivacyDefaults
[ChatType.ExtraChatLinkshell8] = 90, [ChatType.ExtraChatLinkshell8] = 90,
}; };
// Casual: Privacy-First + public chat (Say/Shout/Yell, emotes, Novice // Casual profile = Privacy-First plus public chat (Say/Shout/Yell, both
// Network) with a 1-day window so recent RP/trade is searchable but // emote types, Novice Network), kept for a short 24-hour window so the
// third-party data doesn't accumulate. // last RP scene or shout trade is still searchable but third-party data
// doesn't accumulate forever.
internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>( internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>(
PrivacyFirstWhitelist PrivacyFirstWhitelist
) )
-2
View File
@@ -114,8 +114,6 @@ internal class HellionStrings
internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning)); internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning));
internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply)); internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply));
internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button)); internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button));
internal static string Wizard_Cancel_Label => Get(nameof(Wizard_Cancel_Label));
internal static string Wizard_Cancel_Tooltip => Get(nameof(Wizard_Cancel_Tooltip));
internal static string Export_Heading => Get(nameof(Export_Heading)); internal static string Export_Heading => Get(nameof(Export_Heading));
internal static string Export_Help => Get(nameof(Export_Help)); internal static string Export_Help => Get(nameof(Export_Help));
+10 -16
View File
@@ -222,12 +222,6 @@
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Wizard erneut zeigen</value> <value>Wizard erneut zeigen</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Später — Defaults behalten</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Schließt den Wizard ohne Profil-Auswahl. Die Plugin-Defaults bleiben aktiv und der Wizard erscheint beim nächsten Plugin-Reload erneut.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (DSGVO Art. 15 — Auskunftsrecht)</value> <value>Export (DSGVO Art. 15 — Auskunftsrecht)</value>
</data> </data>
@@ -645,7 +639,7 @@
<value>Allgemein</value> <value>Allgemein</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Sprache, Eingabe, Audio und Performance.</value> <value>Plugin-globale Einstellungen — Sprache, Eingabe, Audio, Performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Erscheinungsbild</value> <value>Erscheinungsbild</value>
@@ -663,25 +657,25 @@
<value>Fenster</value> <value>Fenster</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>Wann das Fenster sichtbar ist und ob es sich bewegen lässt.</value> <value>Verhalten des Fensters — wann es da ist, ob es bewegt werden kann.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>Tells, Vorschau, Nachrichten-Verhalten und Emotes.</value> <value>Wie Nachrichten angezeigt werden — Tells, Vorschau, Verhalten, Emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Eigene Chat-Tabs anlegen und konfigurieren.</value> <value>Tab-Verwaltung — eigene Chat-Tabs anlegen und konfigurieren.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Datenschutz</value> <value>Datenschutz</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>Privacy-Filter pro Channel und was gespeichert werden darf.</value> <value>Was darf gespeichert werden — Privacy-Filter pro Channel.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Datenbank</value> <value>Datenbank</value>
@@ -693,7 +687,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>Version, Mission, Lizenz und Changelog.</value> <value>Über das Plugin — Version, Mission, Lizenz, Changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -738,25 +732,25 @@
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>Theme, Fenster-Rahmen und Zeitstempel-Style.</value> <value>Wie das Fenster aussieht — Theme, Rahmen, Zeitstempel-Style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Schriften &amp; Farben</value> <value>Schriften &amp; Farben</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Schriftart, Schriftgröße und Chat-Farben pro Channel.</value> <value>Lesbarkeit — Schriftart, Schriftgröße, Chat-Farben pro Channel.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Daten-Verwaltung</value> <value>Daten-Verwaltung</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>Aufbewahrung, Aufräumen, Export und Datenbank-Statistiken.</value> <value>Was passiert mit gespeicherten Daten — Aufbewahrung, Aufräumen, Export, DB-Stats.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrationen</value> <value>Integrationen</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Kommende Integrationen in der Vorschau.</value> <value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Auto-detected, mit Vorschau auf kommende Integrationen.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
+164 -170
View File
@@ -19,28 +19,28 @@
<value>Enable privacy filter</value> <value>Enable privacy filter</value>
</data> </data>
<data name="Privacy_FilterEnabled_Description" xml:space="preserve"> <data name="Privacy_FilterEnabled_Description" xml:space="preserve">
<value>When enabled, only messages from allowed channels are written to the database. When disabled, the default behaviour applies — everything except battle logs is stored.</value> <value>When enabled, only messages from whitelisted channels are persisted to the database. Disabling restores the original behavior (everything except battle messages is stored).</value>
</data> </data>
<data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve"> <data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve">
<value>The filter only controls what is written to the local database. The chat log still shows every message live; excluded channels are simply no longer stored. If you also want to remove channels from the visible display, use the normal chat-tab filters in the game.</value> <value>The filter only controls what is written to the local database. The chat log itself keeps showing every message live, disallowed channels just stop being saved. Use the channel hide options in your in-game chat tabs if you want to remove channels from the visible chat.</value>
</data> </data>
<data name="Privacy_Filter_Tree_Heading" xml:space="preserve"> <data name="Privacy_Filter_Tree_Heading" xml:space="preserve">
<value>Privacy filter and whitelist</value> <value>Privacy filter and whitelist</value>
</data> </data>
<data name="Privacy_Whitelist_Help" xml:space="preserve"> <data name="Privacy_Whitelist_Help" xml:space="preserve">
<value>Choose which channels are saved to the local database. Default follows data minimisation: only your own conversations. Use the buttons below to apply a preset.</value> <value>Pick which channels are stored in the local database. Privacy-First default: only your own conversations. Use the buttons below to apply a preset.</value>
</data> </data>
<data name="Privacy_Preset_PrivacyFirst" xml:space="preserve"> <data name="Privacy_Preset_PrivacyFirst" xml:space="preserve">
<value>Data minimisation (recommended)</value> <value>Privacy-First (recommended)</value>
</data> </data>
<data name="Privacy_Preset_ClearAll" xml:space="preserve"> <data name="Privacy_Preset_ClearAll" xml:space="preserve">
<value>Deselect all</value> <value>Clear all</value>
</data> </data>
<data name="Privacy_Preset_SelectAll" xml:space="preserve"> <data name="Privacy_Preset_SelectAll" xml:space="preserve">
<value>Select all</value> <value>Select all</value>
</data> </data>
<data name="Privacy_Group_DirectMessages" xml:space="preserve"> <data name="Privacy_Group_DirectMessages" xml:space="preserve">
<value>Direct messages</value> <value>Direct Messages</value>
</data> </data>
<data name="Privacy_Group_PartyAlliance" xml:space="preserve"> <data name="Privacy_Group_PartyAlliance" xml:space="preserve">
<value>Party &amp; Alliance</value> <value>Party &amp; Alliance</value>
@@ -55,52 +55,52 @@
<value>Cross-World Linkshells</value> <value>Cross-World Linkshells</value>
</data> </data>
<data name="Privacy_Group_ExtraChat" xml:space="preserve"> <data name="Privacy_Group_ExtraChat" xml:space="preserve">
<value>ExtraChat (encrypted)</value> <value>ExtraChat (Encrypted)</value>
</data> </data>
<data name="Privacy_Group_PublicChat" xml:space="preserve"> <data name="Privacy_Group_PublicChat" xml:space="preserve">
<value>Public chat (third-party data)</value> <value>Public Chat (third-party data)</value>
</data> </data>
<data name="Privacy_Group_SystemLogs" xml:space="preserve"> <data name="Privacy_Group_SystemLogs" xml:space="preserve">
<value>System &amp; game logs</value> <value>System &amp; Game Logs</value>
</data> </data>
<data name="Privacy_PersistUnknown_Name" xml:space="preserve"> <data name="Privacy_PersistUnknown_Name" xml:space="preserve">
<value>Save unknown channel types</value> <value>Persist unknown channel types</value>
</data> </data>
<data name="Privacy_PersistUnknown_Description" xml:space="preserve"> <data name="Privacy_PersistUnknown_Description" xml:space="preserve">
<value>Safety net for ChatTypes added by future FFXIV patches that the plugin does not yet know about. Default is OFF (data minimisation). Enable if you want future channels to be fully logged as well.</value> <value>Failsafe for ChatTypes added by future FFXIV patches that this plugin does not yet know about. Default OFF (Privacy-First). Turn ON if you want a complete log including future channels.</value>
</data> </data>
<data name="Cleanup_Heading" xml:space="preserve"> <data name="Cleanup_Heading" xml:space="preserve">
<value>Apply filter to existing database</value> <value>Apply filter to existing database</value>
</data> </data>
<data name="Cleanup_Help_Intro" xml:space="preserve"> <data name="Cleanup_Help_Intro" xml:space="preserve">
<value>The privacy filter only affects new messages. The cleanup below lets you retroactively remove already-stored messages that do not match your saved whitelist.</value> <value>The privacy filter only applies to new messages. Use the cleanup below to retroactively remove already-stored messages that don't match your saved whitelist.</value>
</data> </data>
<data name="Cleanup_Help_SavedNote" xml:space="preserve"> <data name="Cleanup_Help_SavedNote" xml:space="preserve">
<value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved changes above. Click Save first if you want your current changes to be applied.</value> <value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved edits above. Click Save first if you want to apply your current edits.</value>
</data> </data>
<data name="Retention_Help_SavedNote" xml:space="preserve"> <data name="Retention_Help_SavedNote" xml:space="preserve">
<value>The manual run uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current changes.</value> <value>The manual sweep uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current edits.</value>
</data> </data>
<data name="Cleanup_Preview_Stale" xml:space="preserve"> <data name="Cleanup_Preview_Stale" xml:space="preserve">
<value>Preview is stale — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value> <value>Preview is out of date — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value>
</data> </data>
<data name="Cleanup_RefreshPreview" xml:space="preserve"> <data name="Cleanup_RefreshPreview" xml:space="preserve">
<value>Refresh preview</value> <value>Refresh preview</value>
</data> </data>
<data name="Cleanup_NoPreview" xml:space="preserve"> <data name="Cleanup_NoPreview" xml:space="preserve">
<value>No preview yet. Click Refresh to calculate the impact.</value> <value>No preview yet. Click Refresh to compute the impact.</value>
</data> </data>
<data name="Cleanup_TotalStored" xml:space="preserve"> <data name="Cleanup_TotalStored" xml:space="preserve">
<value>Total stored messages: {0:N0}</value> <value>Total stored messages: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillKeep" xml:space="preserve"> <data name="Cleanup_WillKeep" xml:space="preserve">
<value>Keep: {0:N0}</value> <value>Will keep: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillDelete" xml:space="preserve"> <data name="Cleanup_WillDelete" xml:space="preserve">
<value>Delete: {0:N0}</value> <value>Will delete: {0:N0}</value>
</data> </data>
<data name="Cleanup_Breakdown" xml:space="preserve"> <data name="Cleanup_Breakdown" xml:space="preserve">
<value>Breakdown by channel</value> <value>Per-channel breakdown</value>
</data> </data>
<data name="Cleanup_Marker_Keep" xml:space="preserve"> <data name="Cleanup_Marker_Keep" xml:space="preserve">
<value>[KEEP] </value> <value>[KEEP] </value>
@@ -112,46 +112,46 @@
<value>Apply current filter to database</value> <value>Apply current filter to database</value>
</data> </data>
<data name="Cleanup_Apply_Tooltip" xml:space="preserve"> <data name="Cleanup_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: Permanently deletes {0:N0} messages and runs VACUUM afterwards. Cannot be undone.</value> <value>Ctrl+Shift: Hard-deletes {0:N0} messages, then runs VACUUM. Cannot be undone.</value>
</data> </data>
<data name="Cleanup_Running" xml:space="preserve"> <data name="Cleanup_Running" xml:space="preserve">
<value>Cleanup running in the background…</value> <value>Cleanup running in background…</value>
</data> </data>
<data name="Cleanup_PreviewError" xml:space="preserve"> <data name="Cleanup_PreviewError" xml:space="preserve">
<value>Preview could not be calculated, see /xllog</value> <value>Failed to compute cleanup preview, see /xllog</value>
</data> </data>
<data name="Cleanup_Success" xml:space="preserve"> <data name="Cleanup_Success" xml:space="preserve">
<value>Cleanup complete, {0:N0} messages removed.</value> <value>Privacy cleanup complete: {0:N0} messages removed.</value>
</data> </data>
<data name="Cleanup_Error" xml:space="preserve"> <data name="Cleanup_Error" xml:space="preserve">
<value>Cleanup failed, see /xllog</value> <value>Privacy cleanup failed, see /xllog</value>
</data> </data>
<data name="Retention_Heading" xml:space="preserve"> <data name="Retention_Heading" xml:space="preserve">
<value>Message retention</value> <value>Message retention</value>
</data> </data>
<data name="Retention_Enabled_Name" xml:space="preserve"> <data name="Retention_Enabled_Name" xml:space="preserve">
<value>Automatically delete messages past their channel retention window</value> <value>Auto-delete messages after a per-channel retention window</value>
</data> </data>
<data name="Retention_Enabled_Description" xml:space="preserve"> <data name="Retention_Enabled_Description" xml:space="preserve">
<value>When enabled, messages older than the configured window are deleted on each plugin start (at most once every 24 hours). Default is OFF — the plugin never deletes anything without your explicit consent.</value> <value>When enabled, messages older than the configured window are deleted on every plugin start (at most once per 24 hours). Off by default. The plugin never deletes history without your explicit consent.</value>
</data> </data>
<data name="Retention_Default_Label" xml:space="preserve"> <data name="Retention_Default_Label" xml:space="preserve">
<value>Default retention (days, 0 = never)</value> <value>Default retention (days, 0 = never)</value>
</data> </data>
<data name="Retention_Default_Help" xml:space="preserve"> <data name="Retention_Default_Help" xml:space="preserve">
<value>Applies to channels that have no individual override below.</value> <value>Applies to channels without an explicit override below.</value>
</data> </data>
<data name="Retention_Reset_Spec" xml:space="preserve"> <data name="Retention_Reset_Spec" xml:space="preserve">
<value>Reset overrides to spec defaults</value> <value>Reset overrides to spec defaults</value>
</data> </data>
<data name="Retention_Clear_Overrides" xml:space="preserve"> <data name="Retention_Clear_Overrides" xml:space="preserve">
<value>Remove all overrides</value> <value>Clear all overrides</value>
</data> </data>
<data name="Retention_Tree_Heading" xml:space="preserve"> <data name="Retention_Tree_Heading" xml:space="preserve">
<value>Retention per channel</value> <value>Per-channel retention overrides</value>
</data> </data>
<data name="Retention_Tag_Override" xml:space="preserve"> <data name="Retention_Tag_Override" xml:space="preserve">
<value>[custom]</value> <value>[override]</value>
</data> </data>
<data name="Retention_Tag_Spec" xml:space="preserve"> <data name="Retention_Tag_Spec" xml:space="preserve">
<value>[spec]</value> <value>[spec]</value>
@@ -163,13 +163,13 @@
<value>reset</value> <value>reset</value>
</data> </data>
<data name="Retention_Apply_Label" xml:space="preserve"> <data name="Retention_Apply_Label" xml:space="preserve">
<value>Apply retention now</value> <value>Apply retention policy now</value>
</data> </data>
<data name="Retention_Apply_Tooltip" xml:space="preserve"> <data name="Retention_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: Runs the retention cleanup immediately using the SAVED policy. Save your changes first.</value> <value>Ctrl+Shift: runs the retention sweep immediately using the SAVED policy. Save your changes first.</value>
</data> </data>
<data name="Retention_Running" xml:space="preserve"> <data name="Retention_Running" xml:space="preserve">
<value>Retention cleanup running in the background…</value> <value>Retention sweep running in background…</value>
</data> </data>
<data name="Retention_LastRun_Never" xml:space="preserve"> <data name="Retention_LastRun_Never" xml:space="preserve">
<value>Last run: never</value> <value>Last run: never</value>
@@ -178,73 +178,67 @@
<value>Last run: {0:yyyy-MM-dd HH:mm}</value> <value>Last run: {0:yyyy-MM-dd HH:mm}</value>
</data> </data>
<data name="Retention_Success" xml:space="preserve"> <data name="Retention_Success" xml:space="preserve">
<value>Retention cleanup complete, {0:N0} messages removed.</value> <value>Retention sweep complete: {0:N0} messages removed.</value>
</data> </data>
<data name="Retention_Error" xml:space="preserve"> <data name="Retention_Error" xml:space="preserve">
<value>Retention cleanup failed, see /xllog</value> <value>Retention sweep failed, see /xllog</value>
</data> </data>
<data name="Wizard_Title" xml:space="preserve"> <data name="Wizard_Title" xml:space="preserve">
<value>Hellion Chat — Welcome</value> <value>Hellion Chat — Welcome</value>
</data> </data>
<data name="Wizard_Intro" xml:space="preserve"> <data name="Wizard_Intro" xml:space="preserve">
<value>Choose a starting profile. You can adjust everything later under Settings → Privacy.</value> <value>Pick a starting profile. You can change anything later under Settings → Privacy.</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve">
<value>Data minimisation (recommended)</value> <value>Privacy-First (recommended)</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve">
<value>Only your own conversations are stored: tells, party, FC, linkshells, cross-world linkshells, alliance, and ExtraChat. Public chat, NPC dialogues, and system spam are discarded at the storage level. Retention follows spec defaults (tells 365 days, own conversation channels 90 days).</value> <value>Only your own conversations are stored: Tells, Party, FC, Linkshells, Cross-World Linkshells, Alliance and ExtraChat. Public chat, NPC dialogue and system spam are dropped at the storage layer. Retention follows the spec defaults (Tells 365 days, own-conversation channels 90 days).</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve">
<value>Apply data minimisation</value> <value>Use Privacy-First</value>
</data> </data>
<data name="Wizard_Profile_Casual_Heading" xml:space="preserve"> <data name="Wizard_Profile_Casual_Heading" xml:space="preserve">
<value>Casual</value> <value>Casual</value>
</data> </data>
<data name="Wizard_Profile_Casual_Description" xml:space="preserve"> <data name="Wizard_Profile_Casual_Description" xml:space="preserve">
<value>Data minimisation plus a 24-hour window for public chat (say, shout, yell, both emote types, novice network). For RP players who want to re-read the last scene without keeping public chat forever.</value> <value>Privacy-First plus a 24-hour window for public chat (Say, Shout, Yell, both emote types, Novice Network). For RP players who want to look up the last scene without keeping public chat forever.</value>
</data> </data>
<data name="Wizard_Profile_Casual_Apply" xml:space="preserve"> <data name="Wizard_Profile_Casual_Apply" xml:space="preserve">
<value>Apply casual</value> <value>Use Casual</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve">
<value>Full history</value> <value>Full History</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Description" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Description" xml:space="preserve">
<value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behaviour). Retention is OFF, so the history grows indefinitely.</value> <value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behavior). Retention is OFF, history grows forever.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve">
<value>GDPR notice: Storing third-party messages (say/shout/yell from other players, NPC dialogues with player names, etc.) indefinitely may exceed the exemption for purely personal or household activities (Art. 2(2)(c)). Only use this profile if you have a clear reason to keep the full archive.</value> <value>GDPR notice: storing third-party messages (Say/Shout/Yell of strangers, NPC dialogue with player names, etc.) for an unlimited time may exceed the personal/household exemption (Art. 2(2)(c)). Use this profile only if you have a clear reason to keep the full archive.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve">
<value>Apply full history</value> <value>Use Full History</value>
</data> </data>
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Show wizard again</value> <value>Show wizard again</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Later — keep defaults</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Close the wizard without selecting a profile. The plugin defaults stay active and the wizard returns on next plugin load.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (GDPR Art. 15 — Right of access)</value> <value>Export (GDPR Art. 15 — right of access)</value>
</data> </data>
<data name="Export_Help" xml:space="preserve"> <data name="Export_Help" xml:space="preserve">
<value>Export stored messages as Markdown, JSON, or CSV. This lets you fulfil an access request from a person whose messages you have stored, or take your own history with you.</value> <value>Export stored messages to Markdown, JSON or CSV. Use this to fulfil a request for access from someone whose messages you have, or to take your own history with you.</value>
</data> </data>
<data name="Export_Range_Label" xml:space="preserve"> <data name="Export_Range_Label" xml:space="preserve">
<value>Last X days (0 = no time limit)</value> <value>Last X days (0 = all time)</value>
</data> </data>
<data name="Export_Sender_Label" xml:space="preserve"> <data name="Export_Sender_Label" xml:space="preserve">
<value>Sender contains (optional, case-insensitive)</value> <value>Sender contains (optional, case-insensitive)</value>
</data> </data>
<data name="Export_Channels_Heading" xml:space="preserve"> <data name="Export_Channels_Heading" xml:space="preserve">
<value>Restrict to channels</value> <value>Limit to channels</value>
</data> </data>
<data name="Export_Channels_AllOff" xml:space="preserve"> <data name="Export_Channels_AllOff" xml:space="preserve">
<value>(nothing selected = all stored channels)</value> <value>(none selected = all stored channels)</value>
</data> </data>
<data name="Export_Format_Label" xml:space="preserve"> <data name="Export_Format_Label" xml:space="preserve">
<value>Format</value> <value>Format</value>
@@ -265,41 +259,41 @@
<value>Save export</value> <value>Save export</value>
</data> </data>
<data name="Export_Running" xml:space="preserve"> <data name="Export_Running" xml:space="preserve">
<value>Export running in the background…</value> <value>Export running in background…</value>
</data> </data>
<data name="Export_Success" xml:space="preserve"> <data name="Export_Success" xml:space="preserve">
<value>Export complete, {0:N0} messages written to {1}</value> <value>Export complete: {0:N0} messages written to {1}</value>
</data> </data>
<data name="Export_Empty" xml:space="preserve"> <data name="Export_Empty" xml:space="preserve">
<value>Export complete, no message matched the filter.</value> <value>Export complete: no messages matched the filter.</value>
</data> </data>
<data name="Export_Error" xml:space="preserve"> <data name="Export_Error" xml:space="preserve">
<value>Export failed, see /xllog</value> <value>Export failed, see /xllog</value>
</data> </data>
<data name="Theme_Enabled_Name" xml:space="preserve"> <data name="Theme_Enabled_Name" xml:space="preserve">
<value>Use Hellion theme for all plugin windows</value> <value>Use the Hellion theme across all plugin windows</value>
</data> </data>
<data name="Theme_Enabled_Description" xml:space="preserve"> <data name="Theme_Enabled_Description" xml:space="preserve">
<value>Hellion Online Media palette of Arctic Cyan and Ember Orange, applied to the chat window, settings, viewer, and wizard. Disable to use the default Dalamud appearance.</value> <value>Hellion Online Media palette of Arctic Cyan plus Ember Orange, applied across the chat log, settings, viewers and the wizard. Disable to fall back to the default Dalamud look.</value>
</data> </data>
<data name="Theme_WindowOpacity_Label" xml:space="preserve"> <data name="Theme_WindowOpacity_Label" xml:space="preserve">
<value>Window opacity</value> <value>Window opacity</value>
</data> </data>
<data name="Theme_WindowOpacity_Help" xml:space="preserve"> <data name="Theme_WindowOpacity_Help" xml:space="preserve">
<value>How opaque the plugin windows are. Lower values let the game show through; form fields and dialogs stay fully opaque and readable on top.</value> <value>How opaque the plugin panes are. Lower values let the game shine through; form fields and dialogs stay opaque on top so they remain readable.</value>
</data> </data>
<data name="Theme_UseHellionFont_Name" xml:space="preserve"> <data name="Theme_UseHellionFont_Name" xml:space="preserve">
<value>Use bundled Hellion font (Exo 2)</value> <value>Use the bundled Hellion font (Exo 2)</value>
</data> </data>
<data name="Theme_UseHellionFont_Description" xml:space="preserve"> <data name="Theme_UseHellionFont_Description" xml:space="preserve">
<value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1), which ships with the plugin. Disable to fall back to the font selected under Settings → Font.</value> <value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1) which ships with the plugin. Disable to fall back to whatever font you picked under Settings → Fonts.</value>
</data> </data>
<data name="About_Maintainer_Heading" xml:space="preserve"> <data name="About_Maintainer_Heading" xml:space="preserve">
<value>Maintainer</value> <value>Maintainer</value>
</data> </data>
<data name="About_Maintainer_Body" xml:space="preserve"> <data name="About_Maintainer_Body" xml:space="preserve">
<value>I maintain Hellion Chat through Hellion Online Media. Contact details for licensing, legal, or business inquiries are on the website.</value> <value>I maintain Hellion Chat through Hellion Online Media. The website has the contact details for licensing, legal or business questions.</value>
</data> </data>
<data name="About_Maintainer_Website_Label" xml:space="preserve"> <data name="About_Maintainer_Website_Label" xml:space="preserve">
<value>Website:</value> <value>Website:</value>
@@ -309,76 +303,76 @@
<value>Why this fork exists</value> <value>Why this fork exists</value>
</data> </data>
<data name="About_Mission_P1" xml:space="preserve"> <data name="About_Mission_P1" xml:space="preserve">
<value>Hellion Chat is not meant to replace Chat 2. Chat 2 delivers a complete chat experience with a full history available for filtering, searching, and replay. That default is the right choice for most users. This fork takes a different approach: a smaller default footprint, with additional controls for users who prefer to keep less of other people's chat on disk.</value> <value>Hellion Chat is not trying to replace Chat 2. Chat 2 ships a complete chat experience with full history available for filtering, search and replay. That default is the right one for most users. This fork takes a different stance: a smaller default footprint, with extra knobs for users who want to keep less third-party chat on disk.</value>
</data> </data>
<data name="About_Mission_P2" xml:space="preserve"> <data name="About_Mission_P2" xml:space="preserve">
<value>The desire for this narrower default was personal. After two years with Chat 2, my database had grown to over two million messages, the majority of them /say, /shout, and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full history useful, and most users are happy to keep it. My own preference was for a smaller default. So I built this fork.</value> <value>The reason I wanted that narrower default was personal. After two years on Chat 2 my database had grown past two million messages, most of them /say, /shout and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full-history view powerful and most users are happy to keep it. For my own taste I wanted a smaller default. So I built this fork.</value>
</data> </data>
<data name="About_Mission_P3" xml:space="preserve"> <data name="About_Mission_P3" xml:space="preserve">
<value>I am not targeting a large audience, and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the original. Infi, Anna, or anyone else is welcome to look around, borrow ideas, ask questions, or simply ignore the project. All three are fine by me.</value> <value>I am not chasing a big audience and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the upstream plugin. Infi, Anna or anyone else are welcome to read it, borrow ideas, ask questions, or ignore the project. All three are fine by me.</value>
</data> </data>
<data name="About_BuiltOn_Heading" xml:space="preserve"> <data name="About_BuiltOn_Heading" xml:space="preserve">
<value>Built on Chat 2</value> <value>Built on Chat 2</value>
</data> </data>
<data name="About_BuiltOn_P1" xml:space="preserve"> <data name="About_BuiltOn_P1" xml:space="preserve">
<value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat-replacement window, IPC integration, render engine, and the entire storage core all come from the original.</value> <value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat replacement window, the IPC integration, the rendering engine and the entire storage core come from upstream Chat 2.</value>
</data> </data>
<data name="About_BuiltOn_P2" xml:space="preserve"> <data name="About_BuiltOn_P2" xml:space="preserve">
<value>The web interface is the only major piece I removed. It is built for remote access to the chat from a second device a different focus from the smaller default footprint this fork pursues. Adapting it to these defaults would have required significant rework, so removing it was the clean path for this particular fork.</value> <value>The webinterface is the only major piece I removed. It is built for remote access to chat from a second device, which is a different focus than the smaller default footprint this fork is built around. Aligning it with these defaults would have meant a substantial rebuild, so removing it was the cleaner path for this particular fork.</value>
</data> </data>
<data name="About_BuiltOn_Upstream_Label" xml:space="preserve"> <data name="About_BuiltOn_Upstream_Label" xml:space="preserve">
<value>Upstream repository:</value> <value>Upstream repository:</value>
</data> </data>
<data name="About_License_Heading" xml:space="preserve"> <data name="About_License_Heading" xml:space="preserve">
<value>Licence</value> <value>License</value>
</data> </data>
<data name="About_License_P1" xml:space="preserve"> <data name="About_License_P1" xml:space="preserve">
<value>Hellion Chat and Chat 2 are both released under the European Union Public Licence v1.2 (EUPL-1.2).</value> <value>Hellion Chat and Chat 2 both ship under the European Union Public Licence v1.2 (EUPL-1.2).</value>
</data> </data>
<data name="About_License_P2" xml:space="preserve"> <data name="About_License_P2" xml:space="preserve">
<value>© 2023 to 2026, the Chat 2 authors (Infi, Anna, and upstream contributors).</value> <value>© 2023 to 2026, the Chat 2 authors (Infi, Anna and the upstream contributors).</value>
</data> </data>
<data name="About_License_P3" xml:space="preserve"> <data name="About_License_P3" xml:space="preserve">
<value>© 2026 Hellion Online Media for the extensions in this fork.</value> <value>© 2026 Hellion Online Media for the additions made in this fork.</value>
</data> </data>
<data name="About_SE_Heading" xml:space="preserve"> <data name="About_SE_Heading" xml:space="preserve">
<value>FINAL FANTASY XIV notice</value> <value>FINAL FANTASY XIV disclaimer</value>
</data> </data>
<data name="About_SE_P1" xml:space="preserve"> <data name="About_SE_P1" xml:space="preserve">
<value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value> <value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value>
</data> </data>
<data name="About_SE_P2" xml:space="preserve"> <data name="About_SE_P2" xml:space="preserve">
<value>Hellion Chat is an unofficial fan plugin. It is not affiliated with Square Enix and is neither endorsed, sponsored, nor approved by them.</value> <value>Hellion Chat is an unofficial, fan-made plugin. It has no affiliation with Square Enix and is not endorsed, sponsored or approved by them.</value>
</data> </data>
<data name="About_Localization_Heading" xml:space="preserve"> <data name="About_Localization_Heading" xml:space="preserve">
<value>Localisation</value> <value>Localization</value>
</data> </data>
<data name="About_Localization_P1" xml:space="preserve"> <data name="About_Localization_P1" xml:space="preserve">
<value>The translations of the Hellion-specific strings were done by me. No additional languages are currently available.</value> <value>The German translations of the Hellion-specific strings come from me. Other languages are not provided yet.</value>
</data> </data>
<data name="About_Localization_P2" xml:space="preserve"> <data name="About_Localization_P2" xml:space="preserve">
<value>The translator list below belongs to the Chat 2 strings on Crowdin. These volunteers translated Chat 2, not the Hellion extensions.</value> <value>The translator list below covers the upstream Chat 2 strings on Crowdin. Those volunteers translated Chat 2, not the Hellion additions.</value>
</data> </data>
<data name="About_Translators_TreeNode" xml:space="preserve"> <data name="About_Translators_TreeNode" xml:space="preserve">
<value>Chat 2 community translators (upstream)</value> <value>Chat 2 community translators (upstream)</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (Runtime strings) --> <!-- Hellion Chat — Auto-Tell-Tabs (runtime strings) -->
<data name="AutoTellTabs_SectionHeader" xml:space="preserve"> <data name="AutoTellTabs_SectionHeader" xml:space="preserve">
<value>Active tells</value> <value>Active Tells</value>
</data> </data>
<data name="AutoTellTabs_HistorySeparator" xml:space="preserve"> <data name="AutoTellTabs_HistorySeparator" xml:space="preserve">
<value>— Earlier conversations —</value> <value>— Earlier conversations —</value>
</data> </data>
<data name="AutoTellTabs_HistoryLoadError" xml:space="preserve"> <data name="AutoTellTabs_HistoryLoadError" xml:space="preserve">
<value>Could not load history.</value> <value>History could not be loaded.</value>
</data> </data>
<data name="AutoTellTabs_GreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_GreetedTooltip" xml:space="preserve">
<value>Marked as greeted. Click to remove the mark.</value> <value>Marked as greeted. Click to remove the marker.</value>
</data> </data>
<data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve">
<value>Mark as greeted.</value> <value>Mark as greeted.</value>
@@ -389,62 +383,62 @@
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve">
<value>Automatically open a tab per conversation partner for every /tell</value> <value>Open a tab automatically for each tell partner</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve">
<value>As soon as you receive or send a /tell, a temporary tab is automatically opened for that player. Tabs are removed on logout.</value> <value>When you receive or send a /tell, a temporary tab dedicated to that player is opened automatically. Tabs vanish on logout.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve">
<value>Maximum number of auto-tell tabs</value> <value>Maximum number of auto tell tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve">
<value>When the limit is reached, greeted tabs with the oldest activity are closed first. Changes take effect on the next /tell.</value> <value>When the limit is reached, greeted tabs with the oldest activity are dropped first. The change applies on the next /tell.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve">
<value>Compact display</value> <value>Compact display</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve">
<value>Shows only a thin separator between regular tabs and auto-tell tabs, without a section header.</value> <value>Show only a thin separator between persistent tabs and auto tell tabs, without the section header.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve">
<value>Show "Mark as greeted" button</value> <value>Show "mark as greeted" button</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve">
<value>Adds a click button next to each auto-tell tab to mark a conversation partner as already greeted the tab name is then dimmed. Useful for club greeters managing many conversations in parallel. Off by default.</value> <value>Adds a click-to-toggle button next to each auto tell tab to mark a partner as already greeted, dimming the tab name when set. Useful for club greeters tracking many parallel conversations; off by default.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve">
<value>Open new /tell tabs directly as pop-outs</value> <value>Open new /tell tabs directly as pop-out</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve">
<value>When active, each newly created /tell tab is immediately opened as its own window. Closing the window returns the tab to the sidebar.</value> <value>When enabled, each newly created /tell tab opens directly as its own window. Closing the window returns the tab to the sidebar.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve">
<value>The number of preloaded tells can be configured in the Privacy tab.</value> <value>The number of preloaded tells is configured in the Privacy tab.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve">
<value>Note: If XIV Messenger or a similar plugin suppresses tells, disable the "Suppress DMs" option there so that Hellion Chat can receive tells and open the auto-tabs.</value> <value>Heads-up: if XIV Messanger or a similar plugin is suppressing direct messages, turn its "Suppress DMs" option off so Hellion Chat can receive tells and open the auto tabs.</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) -->
<data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve">
<value>Tell history in auto-tabs</value> <value>Tell history in auto tabs</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve">
<value>Number of preloaded tells</value> <value>Number of preloaded tells</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve">
<value>How many previous tell messages are loaded from the database when an auto-tell tab is opened. 0 disables preloading.</value> <value>How many earlier tell messages are loaded from the database when an auto tell tab is opened. 0 disables the preload.</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve">
<value>Only takes effect when auto-tell tabs are enabled in the Chat tab.</value> <value>Only takes effect when auto tell tabs are enabled in the Chat tab.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish v10 Wipe migration --> <!-- Hellion Chat — Settings UX Polish v10 wipe migration -->
<data name="SettingsRefactor_Migration_Title" xml:space="preserve"> <data name="SettingsRefactor_Migration_Title" xml:space="preserve">
<value>Settings restructured</value> <value>Settings reorganised</value>
</data> </data>
<data name="SettingsRefactor_Migration_Content" xml:space="preserve"> <data name="SettingsRefactor_Migration_Content" xml:space="preserve">
<value>Hellion Chat 0.5.0 has restructured the settings into thematic tabs. Your chat database and message history remain unchanged. Settings have been reset to defaults. If you want to re-select your privacy profile, the Reopen button is in the Privacy tab. A backup of the previous config is located at HellionChat.json.pre-v10-backup next to the active config file.</value> <value>Hellion Chat 0.5.0 reorganised the settings into themed tabs. Your chat database and your message history stay untouched. Settings have been reset to defaults; if you want to pick a privacy profile again, the reopen button is in the Privacy tab. A backup of your previous config is at HellionChat.json.pre-v10-backup next to the live config file.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish 8-tab structure --> <!-- Hellion Chat — Settings UX Polish 8-tab structure -->
@@ -461,30 +455,30 @@
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Tab_Tabs" xml:space="preserve"> <data name="Settings_Tab_Tabs" xml:space="preserve">
<value>Channels</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Tab_Database" xml:space="preserve"> <data name="Settings_Tab_Database" xml:space="preserve">
<value>Database</value> <value>Database</value>
</data> </data>
<data name="Settings_Tab_Information" xml:space="preserve"> <data name="Settings_Tab_Information" xml:space="preserve">
<value>About</value> <value>Information</value>
</data> </data>
<!-- Hellion Chat — General tab section headings --> <!-- Hellion Chat — General-Tab section headings -->
<data name="Settings_General_Input_Heading" xml:space="preserve"> <data name="Settings_General_Input_Heading" xml:space="preserve">
<value>Input</value> <value>Input</value>
</data> </data>
<data name="Settings_General_Audio_Heading" xml:space="preserve"> <data name="Settings_General_Audio_Heading" xml:space="preserve">
<value>Audio &amp; notifications</value> <value>Audio &amp; Notifications</value>
</data> </data>
<data name="Settings_General_Performance_Heading" xml:space="preserve"> <data name="Settings_General_Performance_Heading" xml:space="preserve">
<value>Performance</value> <value>Performance</value>
</data> </data>
<data name="Settings_General_Language_Heading" xml:space="preserve"> <data name="Settings_General_Language_Heading" xml:space="preserve">
<value>Language &amp; input aids</value> <value>Language &amp; Input Helpers</value>
</data> </data>
<!-- Hellion Chat — Appearance tab section headings --> <!-- Hellion Chat — Appearance-Tab section headings -->
<data name="Settings_Appearance_Theme_Heading" xml:space="preserve"> <data name="Settings_Appearance_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
@@ -492,32 +486,32 @@
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_Appearance_Colours_Heading" xml:space="preserve"> <data name="Settings_Appearance_Colours_Heading" xml:space="preserve">
<value>Chat colours</value> <value>Chat Colours</value>
</data> </data>
<data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve"> <data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve">
<value>Timestamps</value> <value>Timestamps</value>
</data> </data>
<!-- Hellion Chat — Window tab section headings --> <!-- Hellion Chat — Window-Tab section headings -->
<data name="Settings_Window_Hide_Heading" xml:space="preserve"> <data name="Settings_Window_Hide_Heading" xml:space="preserve">
<value>Hiding</value> <value>Hide</value>
</data> </data>
<data name="Settings_Window_InactivityHide_Heading" xml:space="preserve"> <data name="Settings_Window_InactivityHide_Heading" xml:space="preserve">
<value>Inactivity hiding</value> <value>Inactivity Hide</value>
</data> </data>
<data name="Settings_Window_Frame_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Heading" xml:space="preserve">
<value>Window frame</value> <value>Window Frame</value>
</data> </data>
<data name="Settings_Window_Tooltips_Heading" xml:space="preserve"> <data name="Settings_Window_Tooltips_Heading" xml:space="preserve">
<value>Tooltips</value> <value>Tooltips</value>
</data> </data>
<!-- Hellion Chat — Chat tab section headings --> <!-- Hellion Chat — Chat-Tab section headings -->
<data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve"> <data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve">
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="Settings_Chat_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Chat_Behaviour_Heading" xml:space="preserve">
<value>Message behaviour</value> <value>Message Behaviour</value>
</data> </data>
<data name="Settings_Chat_Preview_Heading" xml:space="preserve"> <data name="Settings_Chat_Preview_Heading" xml:space="preserve">
<value>Preview</value> <value>Preview</value>
@@ -526,7 +520,7 @@
<value>Emotes</value> <value>Emotes</value>
</data> </data>
<!-- Hellion Chat — Database tab section headings --> <!-- Hellion Chat — Database-Tab section headings -->
<data name="Settings_Database_Storage_Heading" xml:space="preserve"> <data name="Settings_Database_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
</data> </data>
@@ -537,9 +531,9 @@
<value>Maintenance</value> <value>Maintenance</value>
</data> </data>
<!-- Hellion Chat — Information tab section headings --> <!-- Hellion Chat — Information-Tab section headings -->
<data name="Settings_Information_VersionInfo_Heading" xml:space="preserve"> <data name="Settings_Information_VersionInfo_Heading" xml:space="preserve">
<value>Version info</value> <value>Version Info</value>
</data> </data>
<data name="Settings_Information_About_Heading" xml:space="preserve"> <data name="Settings_Information_About_Heading" xml:space="preserve">
<value>About HellionChat</value> <value>About HellionChat</value>
@@ -548,7 +542,7 @@
<value>Changelog</value> <value>Changelog</value>
</data> </data>
<!-- Hellion Chat — Default tab presets (channel-specific) --> <!-- Hellion Chat — Default tab presets (channel-themed) -->
<data name="Tabs_Presets_System" xml:space="preserve"> <data name="Tabs_Presets_System" xml:space="preserve">
<value>System</value> <value>System</value>
</data> </data>
@@ -559,36 +553,36 @@
<value>Party</value> <value>Party</value>
</data> </data>
<data name="Tabs_Presets_Beginner" xml:space="preserve"> <data name="Tabs_Presets_Beginner" xml:space="preserve">
<value>Novice</value> <value>Beginner</value>
</data> </data>
<data name="Tabs_Presets_Linkshell" xml:space="preserve"> <data name="Tabs_Presets_Linkshell" xml:space="preserve">
<value>Linkshell</value> <value>Linkshell</value>
</data> </data>
<data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve"> <data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve">
<value>If you use multiple linkshells, the maintainer recommends one tab per shell for a cleaner overview. Duplicate the tab and restrict the channel selection in each copy.</value> <value>If you use multiple linkshells, the maintainer recommends one tab per shell for cleaner readability. Duplicate this tab and narrow the channel selection per copy.</value>
</data> </data>
<!-- Hellion Chat — v1.2.0 per-tab icon override --> <!-- Hellion Chat — v1.2.0 per-tab icon override -->
<data name="Tabs_Icon_Label" xml:space="preserve"> <data name="Tabs_Icon_Label" xml:space="preserve">
<value>Tab icon</value> <value>Tab-Icon</value>
</data> </data>
<data name="Tabs_Icon_HelpMarker" xml:space="preserve"> <data name="Tabs_Icon_HelpMarker" xml:space="preserve">
<value>FontAwesome glyph for the sidebar. Default falls back to the tab name or channel type.</value> <value>FontAwesome-Glyph für die Sidebar. Default greift auf Tab-Name oder Channel-Typ.</value>
</data> </data>
<data name="Tabs_Icon_DefaultOption" xml:space="preserve"> <data name="Tabs_Icon_DefaultOption" xml:space="preserve">
<value>(Default mapping)</value> <value>(Default-Mapping)</value>
</data> </data>
<data name="ChatColourPresets_Default" xml:space="preserve"> <data name="ChatColourPresets_Default" xml:space="preserve">
<value>Classic (Chat 2 default)</value> <value>Klassik (Chat 2 Default)</value>
</data> </data>
<data name="ChatColourPresets_HighContrast" xml:space="preserve"> <data name="ChatColourPresets_HighContrast" xml:space="preserve">
<value>High contrast</value> <value>High-Contrast</value>
</data> </data>
<data name="ChatColourPresets_Pastell" xml:space="preserve"> <data name="ChatColourPresets_Pastell" xml:space="preserve">
<value>Pastel</value> <value>Pastell</value>
</data> </data>
<data name="ChatColourPresets_DarkModeTuned" xml:space="preserve"> <data name="ChatColourPresets_DarkModeTuned" xml:space="preserve">
<value>Dark mode tuned</value> <value>Dark-Mode-Tuned</value>
</data> </data>
<data name="ChatColourPresets_Hellion" xml:space="preserve"> <data name="ChatColourPresets_Hellion" xml:space="preserve">
<value>Hellion</value> <value>Hellion</value>
@@ -600,22 +594,22 @@
<value>Indigo Violet</value> <value>Indigo Violet</value>
</data> </data>
<data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve"> <data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve">
<value>Tip: Presets overwrite your current channel colours immediately.</value> <value>Tip: presets overwrite your current channel colours immediately.</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve">
<value>Enable input in pop-outs</value> <value>Enable input in pop-outs</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve">
<value>Master switch: allows typing and sending directly in any pop-out window (including auto-tell tabs). Channel switching in a pop-out acts globally like in the main window; the text buffer and history cursor are independent per pop-out.</value> <value>Master switch: lets you type and send messages directly inside every pop-out window (including auto-tell tabs). Channel changes inside a pop-out apply globally just like in the main window; the text buffer and history cursor stay independent per pop-out.</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Name" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Name" xml:space="preserve">
<value>Reset window position</value> <value>Reset Window Position</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Description" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Description" xml:space="preserve">
<value>Moves the chat window and all active pop-outs back to the top-left corner of the primary monitor. Useful when a window has ended up outside the visible area after a display layout change (monitor disconnected, resolution changed). The plugin also performs an automatic bounds check once per session; this button is the manual escape hatch if something still ends up unreachable.</value> <value>Snaps the chat window and every active pop-out back to the primary monitor's top-left corner. Useful when a window has drifted off-screen after a display layout change (monitor disconnected, resolution changed). The plugin also runs an automatic bounds check once per session this button is the manual backup if anything still ends up unreachable.</value>
</data> </data>
<data name="Popout_v060_HintText" xml:space="preserve"> <data name="Popout_v060_HintText" xml:space="preserve">
<value>New in v0.6.0: You can now type directly in pop-outs. Enable the master switch in the Window settings.</value> <value>New in v0.6.0: you can type directly inside pop-out windows. Toggle the master switch in the window settings to enable it.</value>
</data> </data>
<data name="Popout_v060_HintAck" xml:space="preserve"> <data name="Popout_v060_HintAck" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
@@ -624,19 +618,19 @@
<value>Open window settings</value> <value>Open window settings</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Body" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Body" xml:space="preserve">
<value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is active by default (can be disabled under Settings → Window).</value> <value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is enabled by default (can be turned off under Settings → Window).</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve">
<value>Open settings</value> <value>Open Settings</value>
</data> </data>
<data name="ChatTwoConflictTitle" xml:space="preserve"> <data name="ChatTwoConflictTitle" xml:space="preserve">
<value>Hellion Chat cannot start while Chat 2 is loaded.</value> <value>Hellion Chat cannot start while Chat 2 is loaded.</value>
</data> </data>
<data name="ChatTwoConflictBody" xml:space="preserve"> <data name="ChatTwoConflictBody" xml:space="preserve">
<value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same chat window in the game and would conflict at runtime.</value> <value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same in-game chat window and would conflict at runtime if loaded together.</value>
</data> </data>
<data name="ChatTwoConflictAction" xml:space="preserve"> <data name="ChatTwoConflictAction" xml:space="preserve">
<value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value> <value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value>
@@ -645,7 +639,7 @@
<value>General</value> <value>General</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Language, input, audio, and performance.</value> <value>Plugin-wide settings — language, input, audio, performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Appearance</value> <value>Appearance</value>
@@ -663,25 +657,25 @@
<value>Window</value> <value>Window</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>When the window is visible and whether it can be moved.</value> <value>Window behaviour — when it shows, whether it can move.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>Tells, preview, message behaviour, and emotes.</value> <value>How messages are displayed — tells, preview, behaviour, emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Create and configure custom chat tabs.</value> <value>Tab management — create and configure your own chat tabs.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Privacy</value> <value>Privacy</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>Privacy filter per channel and what may be stored.</value> <value>What's allowed to be stored — privacy filter per channel.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Database</value> <value>Database</value>
@@ -693,7 +687,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>Version, mission, licence, and changelog.</value> <value>About the plugin — version, mission, license, changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -711,16 +705,16 @@
<value>Open themes folder</value> <value>Open themes folder</value>
</data> </data>
<data name="Settings_Themes_ExportActive" xml:space="preserve"> <data name="Settings_Themes_ExportActive" xml:space="preserve">
<value>Export active</value> <value>Export active...</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve">
<value>This theme suggests its own channel colours.</value> <value>This theme suggests its own chat channel colours.</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve">
<value>Apply</value> <value>Apply</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve">
<value>Keep</value> <value>Keep current</value>
</data> </data>
<data name="StatusBar_Privacy_Enabled" xml:space="preserve"> <data name="StatusBar_Privacy_Enabled" xml:space="preserve">
<value>Privacy-First</value> <value>Privacy-First</value>
@@ -729,55 +723,55 @@
<value>Open</value> <value>Open</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Name" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Name" xml:space="preserve">
<value>Compact density</value> <value>Compact Density</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Description" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Description" xml:space="preserve">
<value>Switches the message layout from the card-row default back to single-line `[HH:mm] Sender: Text` rows.</value> <value>Schaltet das Message-Layout vom Card-Row-Default zurück auf einzeilige `[HH:mm] Sender: Text` Zeilen.</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve">
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>Theme, window frame, and timestamp style.</value> <value>How the window looks — theme, frame, timestamp style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Fonts &amp; Colours</value> <value>Fonts &amp; Colours</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Font, font size, and chat colours per channel.</value> <value>Readability — font, font size, per-channel chat colours.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Data management</value> <value>Data Management</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>Retention, cleanup, export, and database statistics.</value> <value>What happens to stored data — retention, cleanup, export, DB stats.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Other Dalamud plugins that HellionChat works with. Upcoming integrations in preview.</value> <value>Other Dalamud plugins HellionChat reacts to. Auto-detected, with a "coming soon" preview of upcoming integrations.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve">
<value>Window style</value> <value>Window Style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve">
<value>Timestamp style</value> <value>Timestamp Style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve">
<value>Window transparency</value> <value>Window Transparency</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve">
<value>How transparent the window background is. Lower values let more of the game show through. Tip: Dalamud's per-window menu (hamburger in the title bar) offers per-window overrides for opacity, background blur, click-through, and pinning — those take precedence over this slider for the respective window.</value> <value>How transparent the window background is. Lower values let the game show through more. Tip: Dalamud's per-window menu (Hamburger in the title bar) gives you per-window overrides for opacity, background blur, click-through and pinning — those override this slider for that window.</value>
</data> </data>
<data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve">
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve">
<value>Chat colours</value> <value>Chat Colours</value>
</data> </data>
<data name="Settings_DataManagement_Storage_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
@@ -792,22 +786,22 @@
<value>Export</value> <value>Export</value>
</data> </data>
<data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve"> <data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve">
<value>Database viewer</value> <value>Database Viewer</value>
</data> </data>
<data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve">
<value>Advanced (Shift+click to open)</value> <value>Advanced (Shift+Click to open)</value>
</data> </data>
<data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve">
<value>Behaviour</value> <value>Behaviour</value>
</data> </data>
<data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve"> <data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve">
<value>Hellion Chat 1.2.1 has reorganised the settings menu and removed the old "Override style" option (superseded by the theme system from 1.1.0). Your remaining settings are unchanged. Window transparency has been migrated to "Theme &amp; Layout". A backup of the previous config is located at pluginConfigs/HellionChat.json.pre-v16-backup next to the active HellionChat.json.</value> <value>Hellion Chat 1.2.1 reorganised the Settings menu and removed the legacy "Style override" option (made obsolete by the Themes system in 1.1.0). Your other settings are unchanged. Window opacity was migrated to Theme &amp; Layout. A backup of your previous config is at pluginConfigs/HellionChat.json.pre-v16-backup next to the live HellionChat.json.</value>
</data> </data>
<data name="Settings_Tab_Integrations" xml:space="preserve"> <data name="Settings_Tab_Integrations" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Integrations_Intro" xml:space="preserve"> <data name="Settings_Integrations_Intro" xml:space="preserve">
<value>Plugin integrations let HellionChat work together with other installed Dalamud plugins. Each integration automatically detects its target and silently disables itself when the target plugin is missing.</value> <value>Plugin integrations let HellionChat react to other installed Dalamud plugins. Each integration auto-detects its target and silently disables itself when the target plugin is not present.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve">
<value>Honorific</value> <value>Honorific</value>
@@ -819,13 +813,13 @@
<value>Not installed</value> <value>Not installed</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve">
<value>Incompatible API version ({0} expected, {1}.{2} found)</value> <value>Incompatible API version ({0} expected, {1}.{2} detected)</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve">
<value>Show Honorific title in chat header</value> <value>Show Honorific title in chat header</value>
</data> </data>
<data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve"> <data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve">
<value>Shows your custom title from Honorific in the header above the chat log, in the colour you have chosen.</value> <value>Displays your custom title from Honorific in the header above the chat log, in your chosen colour.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve"> <data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve">
<value>Honorific on GitHub</value> <value>Honorific on GitHub</value>
@@ -837,48 +831,48 @@
<value>Coming soon</value> <value>Coming soon</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve">
<value>These integrations are on the roadmap. The settings will appear automatically once the respective plugin is connected.</value> <value>These integrations are on the roadmap. The settings for each appear automatically once the underlying plugin is wired up.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve">
<value>Context menu actions</value> <value>Context menu actions</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve">
<value>Right-click a name in chat: jump to PlayerTrack, open the Lodestone profile, or compose a DM with one click.</value> <value>Right-click a name in chat to jump to PlayerTrack, open the Lodestone profile, or compose a DM in one click.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve">
<value>Smart notifications (NotificationMaster)</value> <value>Smart notifications (NotificationMaster)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve">
<value>Mentions and DMs via NotificationMaster: system toasts, taskbar flash, and per-channel sounds.</value> <value>Route mentions and DMs through NotificationMaster for system toasts, taskbar flash, and per-channel sounds.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve">
<value>RP status block (Moodles · LightlessClient)</value> <value>RP status block (Moodles · LightlessClient)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve">
<value>Show Moodles status icons and pair badges directly next to chat names for more roleplay context.</value> <value>Show Moodles status icons and pair-badges inline next to chat names for richer roleplay context.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve">
<value>ExtraChat channels</value> <value>ExtraChat channels</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve">
<value>Host end-to-end encrypted cross-datacenter linkshells natively in HellionChat.</value> <value>Host end-to-end-encrypted cross-datacenter linkshells natively in HellionChat.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve">
<value>Quick-DM button (XIVInstantMessenger)</value> <value>Quick DM button (XIVInstantMessenger)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve">
<value>Quick DM access directly from the chat window, one click.</value> <value>One-click DM compose without leaving the chat window.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve">
<value>Got an idea?</value> <value>Got an idea?</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve">
<value>Got an idea for a plugin integration that is not on the list? Come to the Hellion Forge Discord and write to me. Community input shapes the roadmap.</value> <value>Got an idea for a plugin integration that's not on this list? Hop on the Hellion Forge Discord and tell me. Community input drives the roadmap.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve">
<value>Open Hellion Forge</value> <value>Open Hellion Forge</value>
</data> </data>
<data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve"> <data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve">
<value>Custom title from Honorific</value> <value>Honorific custom title</value>
</data> </data>
</root> </root>
@@ -1,82 +0,0 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class CrystalNocturne
{
public const string Slug = "crystal-nocturne";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Crystal Nocturne",
Author: "CRYSTALLITE",
Description: "Royal sapphire and electric magenta over obsidian — a nocturne for the crystal-lit dance floor.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#1D4ED8"),
Primary: ColourUtil.HexToRgba("#3B82F6"),
PrimaryLight: ColourUtil.HexToRgba("#93C5FD"),
PrimaryGlow: ColourUtil.HexToRgba("#3B82F699"),
AccentDark: ColourUtil.HexToRgba("#A21CAF"),
Accent: ColourUtil.HexToRgba("#D946EF"),
AccentLight: ColourUtil.HexToRgba("#F0ABFC"),
Identity: ColourUtil.HexToRgba("#3B82F6"),
WindowBg: ColourUtil.HexToRgba("#08070F"),
ChildBg: ColourUtil.HexToRgba("#11101F"),
FrameBg: ColourUtil.HexToRgba("#1C1A33"),
Surface: ColourUtil.HexToRgba("#262340"),
SurfaceHover: ColourUtil.HexToRgba("#332D55"),
Border: ColourUtil.HexToRgba("#D946EF55"),
TextPrimary: ColourUtil.HexToRgba("#F5F3FF"),
TextMuted: ColourUtil.HexToRgba("#A5A0C0"),
TextDim: ColourUtil.HexToRgba("#4B4763"),
StatusSuccess: ColourUtil.HexToRgba("#10B981"),
StatusDanger: ColourUtil.HexToRgba("#F43F5E"),
StatusWarning: ColourUtil.HexToRgba("#FACC15"),
StatusInfo: ColourUtil.HexToRgba("#3B82F6")
),
Layout: new ThemeLayout(
WindowRounding: 2f,
ChildRounding: 1f,
PopupRounding: 2f,
FrameRounding: 1f,
GrabRounding: 1f,
TabRounding: 1f,
ScrollbarRounding: 2f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Crystal Nocturne — sapphire-blue identity for party/team channels,
// accent-magenta for tells, with mint/peach accents on linkshells
// so the eight LS slots stay individually distinguishable on the
// dark obsidian background.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#F5F3FF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#A5A0C0"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#D946EF"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#3B82F6"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#A5A0C0"),
}
)
);
}
@@ -2,7 +2,12 @@ using HellionChat.Util;
namespace HellionChat.Themes.Builtin; namespace HellionChat.Themes.Builtin;
// Deuteran/Protan-safe palette with preserved channel identity. // Hellion Spectrum: Deuteran/Protan-safe channel colours.
// Palette derived from Bang Wong, "Points of view: Color blindness",
// Nature Methods 8, 441 (2011). Channel identity (Tell pink, Yell yellow,
// Shout orange, Party blue, FC green) is preserved per Channel-Identity-
// Rule in docs/THEME-AUTHORING.md; tones are chosen so every channel
// stays distinguishable under red-green colour-vision deficiency.
internal static class HellionSpectrum internal static class HellionSpectrum
{ {
public const string Slug = "hellion-spectrum"; public const string Slug = "hellion-spectrum";
@@ -52,6 +57,9 @@ internal static class HellionSpectrum
ChatColors: new ThemeChatColors( ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint> new Dictionary<HellionChat.Code.ChatType, uint>
{ {
// Hellion Spectrum — Wong/Okabe-Ito tones within FFXIV channel
// identity. FC pulled slightly greener than vanilla cyan-teal so
// Party-blue and FC-green stay separable under deuteran sim.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"), [HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"), [HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"), [HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"),
@@ -0,0 +1,80 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class MoonlitBloom
{
public const string Slug = "moonlit-bloom";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Moonlit Bloom",
Author: "Hellion Forge",
Description: "Bloom Magenta + Soft Sage auf Deep Violet Night.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#C957D0"),
Primary: ColourUtil.HexToRgba("#E374E8"),
PrimaryLight: ColourUtil.HexToRgba("#EF8AF4"),
PrimaryGlow: ColourUtil.HexToRgba("#E374E899"),
AccentDark: ColourUtil.HexToRgba("#7AAC5C"),
Accent: ColourUtil.HexToRgba("#9CCB7C"),
AccentLight: ColourUtil.HexToRgba("#B6E297"),
Identity: ColourUtil.HexToRgba("#E374E8"),
WindowBg: ColourUtil.HexToRgba("#0E0C1F"),
ChildBg: ColourUtil.HexToRgba("#15122B"),
FrameBg: ColourUtil.HexToRgba("#1F1A38"),
Surface: ColourUtil.HexToRgba("#28224A"),
SurfaceHover: ColourUtil.HexToRgba("#332B5B"),
Border: ColourUtil.HexToRgba("#E374E844"),
TextPrimary: ColourUtil.HexToRgba("#ECE6F5"),
TextMuted: ColourUtil.HexToRgba("#9A8BB0"),
TextDim: ColourUtil.HexToRgba("#554B6E"),
StatusSuccess: ColourUtil.HexToRgba("#7AAC5C"),
StatusDanger: ColourUtil.HexToRgba("#E85C6A"),
StatusWarning: ColourUtil.HexToRgba("#E8B590"),
StatusInfo: ColourUtil.HexToRgba("#6278FF")
),
Layout: new ThemeLayout(
WindowRounding: 6f,
ChildRounding: 5f,
PopupRounding: 5f,
FrameRounding: 4f,
GrabRounding: 4f,
TabRounding: 4f,
ScrollbarRounding: 4f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Moonlit Bloom — Bloom-Magenta-Tönung. Sage-Drift in NoviceNetwork
// und Linkshell4. Tell-Pink-Identität bleibt sichtbar.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#ECE6F5"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F09A60"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#F0BC92"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#B6E297"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#C098D8"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#E8B0E8"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#9A8BB0"),
}
)
);
}
+6 -10
View File
@@ -15,21 +15,17 @@ public sealed class ThemeRegistry
public ThemeRegistry(string? customThemesDir = null) public ThemeRegistry(string? customThemesDir = null)
{ {
// Insertion order drives the Theme-Picker grid layout (3 columns).
// Row 1: blue family. Row 2: purple to magenta family.
// Row 3: green / warm / classic. Row 4: Synthwave Sunset as a
// retro bonus on its own line.
_builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase) _builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase)
{ {
{ HellionArctic.Slug, HellionArctic.Build() }, { HellionArctic.Slug, HellionArctic.Build() },
{ HellionSpectrum.Slug, HellionSpectrum.Build() }, { HellionSpectrum.Slug, HellionSpectrum.Build() },
{ NightBlue.Slug, NightBlue.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ IndigoViolet.Slug, IndigoViolet.Build() },
{ CrystalNocturne.Slug, CrystalNocturne.Build() },
{ MintGrove.Slug, MintGrove.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() },
{ Chat2Classic.Slug, Chat2Classic.Build() }, { Chat2Classic.Slug, Chat2Classic.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ MoonlitBloom.Slug, MoonlitBloom.Build() },
{ NightBlue.Slug, NightBlue.Build() },
{ IndigoViolet.Slug, IndigoViolet.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() },
{ MintGrove.Slug, MintGrove.Build() },
{ SynthwaveSunset.Slug, SynthwaveSunset.Build() }, { SynthwaveSunset.Slug, SynthwaveSunset.Build() },
}; };
+52 -15
View File
@@ -1,17 +1,34 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Deterministic hash-based color and icon tinting for Auto-Tell sidebar tabs. /// <summary>
// Same tell partner (name+world) always produces the same color and icon across /// Hash-Color-Tinting für Auto-Tell-Tabs in der Sidebar (v1.2.0).
// sessions. Pure string logic, no Dalamud dependency — testable without game refs. /// Differenziert Tells visuell ohne dass User pro Tab manuell ein
/// Custom-Icon setzen muss. Gleicher Tell-Partner (Name+World) liefert
/// konsistent dieselbe Farbe über Sessions hinweg.
///
/// Kuratierte 12-Farb-Palette aus dem Hellion-Theme-Pool: alle saturiert
/// mid-bright, lesbar gegen Dark-Theme-Backgrounds. Bei realistischen
/// 1-5 parallelen Tells ist Kollisions-Wahrscheinlichkeit gering.
///
/// Reine String-Logik (kein Dalamud-Dep) — testbar im HellionChat.Tests-
/// Projekt das ohne Dalamud-Reference baut.
/// </summary>
internal static class AutoTellTabTint internal static class AutoTellTabTint
{ {
// Fallback for invalid input (empty name or world=0). White matches /// <summary>
// TextPrimary default so the sidebar stays visually consistent. /// Fallback bei ungültigem Input (leerer Name, World=0). Standard-
/// Text-Color (weiß) — passt mit existierendem TextPrimary-Default
/// zusammen, sodass die Sidebar visuell konsistent bleibt.
/// </summary>
public const uint Fallback = 0xFFFFFFFFu; public const uint Fallback = 0xFFFFFFFFu;
// 12 saturated mid-bright colors from the built-in theme pool, readable /// <summary>
// on dark backgrounds. Collision risk is low at realistic 1-5 active tells. /// 12 saturierte mid-bright Farben aus den 5 Built-In-Themes
// RGBA format, matching ColourUtil.RgbaToAbgr convention. /// (Hellion-Arctic, Chat2-Klassik, Event-Horizon, Moonlit-Bloom,
/// Mint-Grove). Reihenfolge ist deterministisch — Hash-Index wählt
/// Farbe per Modulo. RGBA-Format (passt zu ColourUtil.RgbaToAbgr-
/// Konvention im restlichen Code).
/// </summary>
public static readonly IReadOnlyList<uint> Palette = new uint[] public static readonly IReadOnlyList<uint> Palette = new uint[]
{ {
0x00BED2FFu, // Arctic Cyan 0x00BED2FFu, // Arctic Cyan
@@ -28,19 +45,30 @@ internal static class AutoTellTabTint
0xE85D04FFu, // Deep Ember 0xE85D04FFu, // Deep Ember
}; };
/// <summary>
/// Liefert eine konsistente Tint-Color für einen Tell-Partner.
/// Hash basiert auf "Name@World" — Cross-World-Namen kollidieren
/// nur bei Hash-Bucket-Kollision, nicht durch Identitäts-Annahme.
/// </summary>
public static uint For(string name, uint world) public static uint For(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return Fallback; return Fallback;
// Mask to positive range so modulo always yields a valid index. // GetHashCode kann negativ sein; Bitmaske auf positive Range
// damit Modulo-Division immer einen validen Index liefert.
var key = $"{name}@{world}"; var key = $"{name}@{world}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return Palette[(int)(hash % Palette.Count)]; return Palette[(int)(hash % Palette.Count)];
} }
// 7 visually distinct FA glyphs that make sense in a tell context. /// <summary>
// Excludes cog/comment/users — those read as system or group tabs. /// Tell-spezifischer Icon-Pool. 7 visuell distinkte FontAwesome-Glyphen
/// die im Tell-Kontext sinnvoll wirken (envelope = Tell-Default, star/
/// heart/bell = personalisiert, bookmark/flag/fire = markiert/wichtig).
/// Bewusst kein cog/comment/users — die wären für System-/Group-Tabs
/// reserviert und würden im Tell-Bereich verwirrend wirken.
/// </summary>
public static readonly IReadOnlyList<string> IconPool = new[] public static readonly IReadOnlyList<string> IconPool = new[]
{ {
"envelope", "envelope",
@@ -52,17 +80,26 @@ internal static class AutoTellTabTint
"fire", "fire",
}; };
// "envelope" matches the tell context better than the old hardcoded "clock". /// <summary>
/// Fallback-Icon bei ungültigem Input. "envelope" passt semantisch zum
/// Tell-Kontext besser als das alte hardcoded "clock".
/// </summary>
public const string IconFallback = "envelope"; public const string IconFallback = "envelope";
/// <summary>
/// Liefert ein konsistentes Icon-Glyph für einen Tell-Partner.
/// Nutzt einen anderen Hash-Bias als For() (Color), damit Icon und
/// Color unabhängig variieren — gibt 7 × 12 = 84 distinct Combinations.
/// </summary>
public static string IconFor(string name, uint world) public static string IconFor(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return IconFallback; return IconFallback;
// Reversed key ("world@name") gives icon and color independent variation // Anderer Hash-Bias als For() (verschiedene Modulo-Basis): wir
// so the same tell partner doesn't always get the same color+icon pair. // nutzen "world@name" statt "name@world" damit Icon und Color
// 7 icons x 12 colors = 84 distinct combinations. // nicht synchron variieren. Ohne Bias-Trennung würden alle Tells
// mit derselben Color auch dasselbe Icon haben.
var key = $"{world}@{name}"; var key = $"{world}@{name}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return IconPool[(int)(hash % IconPool.Count)]; return IconPool[(int)(hash % IconPool.Count)];
+48 -23
View File
@@ -8,10 +8,16 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Input bar component for pop-out windows. Render() is a stub — the main // Hellion Chat — v0.6.0 input bar component for pop-out windows.
// window input layer stays in ChatLogWindow to avoid a high-risk extract. //
// RenderCompact() is the only v0.6.0 deliverable; Render() can be filled // Pragmatischer Refactor-Scope: Render() ist ein leerer Marker-Stub für
// in a later cycle if needed. // das Hauptfenster — der bestehende Input-Layer in ChatLogWindow bleibt
// unangetastet, weil ein 400-Zeilen-Extract aus einem 1926-Zeilen-File
// das v0.6.0-Risiko unverhältnismäßig erhöhen würde. Pop-Outs nutzen
// ausschließlich RenderCompact(), das ist der ganze v0.6.0-Mehrwert.
// Sollte das Hauptfenster selber später eine Compact-Variante brauchen
// (oder das große Extract sich aus anderem Grund lohnen), kann Render()
// in einem späteren Cycle gefüllt werden.
public sealed class ChatInputBar public sealed class ChatInputBar
{ {
private readonly Plugin _plugin; private readonly Plugin _plugin;
@@ -29,17 +35,22 @@ public sealed class ChatInputBar
public InputState State => _state; public InputState State => _state;
public bool IsFocused { get; private set; } public bool IsFocused { get; private set; }
// Stub — main window input is handled in ChatLogWindow. // Stub. v0.6.0 belässt den Hauptfenster-Input wie er ist.
public void Render() { } public void Render() { }
// Compact layout for pop-out windows: channel icon button left, text // Compact rendering for pop-out windows.
// input right. Auto-translate is intentionally excluded — the upstream
// popup isn't instanciable per window without a larger refactor, and
// typical pop-out use cases rarely need it. Can be added later if
// tester feedback warrants it.
// //
// Channel switching is global via Plugin.Functions.Chat (FFXIV API). // v0.6.0 Compact-Layout: Channel-Icon-Button links (Background-Farbe
// Text buffer and history cursor are independent per pop-out. // aus ChatColours), Text-Input rechts daneben. Auto-Translate-Picker
// ist bewusst NICHT im Compact-Mode (Spec-Abweichung Layout D → A).
// Rechtfertigung: das Hauptfenster-Auto-Complete-Popup ist nicht ohne
// grossen Refactor pro Window instanzierbar; typische Pop-Out-Use-Cases
// (FC-Greeter, Club-Hostess) brauchen Auto-Translate selten dort.
// Eigene Compact-Auto-Complete-Implementation kann ein späterer
// Cycle nachreichen wenn Tester-Feedback das verlangt.
//
// Channel-Switch wirkt via Plugin.Functions.Chat global (FFXIV-API).
// Pro Pop-Out unabhängig bleiben Text-Buffer und History-Cursor.
public void RenderCompact() public void RenderCompact()
{ {
var tab = _activeTabAccessor(); var tab = _activeTabAccessor();
@@ -53,15 +64,18 @@ public sealed class ChatInputBar
private void DrawCompactInput(Tab tab) private void DrawCompactInput(Tab tab)
{ {
// Input takes the whole remaining width — no auto-translate button
// reserved on the right side in v0.6.0 (see RenderCompact comment).
var inputWidth = ImGui.GetContentRegionAvail().X; var inputWidth = ImGui.GetContentRegionAvail().X;
if (inputWidth < 60f) if (inputWidth < 60f)
inputWidth = 60f; inputWidth = 60f;
ImGui.SetNextItemWidth(inputWidth); ImGui.SetNextItemWidth(inputWidth);
// CallbackHistory wires Up/Down navigation to InputHistoryService. // CallbackHistory wires up Up/Down navigation against the shared
// Submit detected via IsItemDeactivated + Enter, not EnterReturnsTrue // InputHistoryService. Submit is detected the same way the main
// (matches ChatLogWindow behavior). // window does it: via IsItemDeactivated + Enter, NOT EnterReturnsTrue
// (matching v0.5.x ChatLogWindow.cs behavior).
const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory; const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory;
ImGui.InputText( ImGui.InputText(
$"##chat-compact-input-{tab.Identifier}", $"##chat-compact-input-{tab.Identifier}",
@@ -86,8 +100,9 @@ public sealed class ChatInputBar
private void SubmitCompact(Tab tab) => private void SubmitCompact(Tab tab) =>
CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal); CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal);
// History navigation callback. Cursor math delegated to // History-navigation callback for the compact input. Cursor math is
// CompactInputHistoryNavigator; ImGui buffer splice stays here. // delegated to CompactInputHistoryNavigator; only the ImGui buffer
// splice stays here because it needs the live callback data.
// TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs // TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs
private int CompactCallback(scoped ref ImGuiInputTextCallbackData data) private int CompactCallback(scoped ref ImGuiInputTextCallbackData data)
{ {
@@ -133,7 +148,7 @@ public sealed class ChatInputBar
var v3 = ColourUtil.RgbaToVector3(rgba); var v3 = ColourUtil.RgbaToVector3(rgba);
var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f); var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f);
// Black foreground on bright backgrounds, white on dark. // Compute readable foreground — black on bright, white on dark
var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z; var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z;
var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f); var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f);
@@ -145,7 +160,8 @@ public sealed class ChatInputBar
using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg))
using (ImRaii.PushColor(ImGuiCol.Text, fg)) using (ImRaii.PushColor(ImGuiCol.Text, fg))
{ {
// Single-letter glyph as a quick visual cue until a proper icon font lands. // Single-letter glyph derived from the channel — quick visual cue
// until we have a proper icon font available in the compact bar.
var label = ChannelGlyph(inputType); var label = ChannelGlyph(inputType);
if ( if (
ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize)) ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize))
@@ -155,9 +171,13 @@ public sealed class ChatInputBar
} }
if (tab.Channel is not null && ImGui.IsItemHovered()) if (tab.Channel is not null && ImGui.IsItemHovered())
{
ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled); ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled);
}
else if (ImGui.IsItemHovered()) else if (ImGui.IsItemHovered())
{
ImGui.SetTooltip(inputType.Name()); ImGui.SetTooltip(inputType.Name());
}
using (var popup = ImRaii.Popup(popupId)) using (var popup = ImRaii.Popup(popupId))
{ {
@@ -201,12 +221,17 @@ public sealed class ChatInputBar
_ => "?", _ => "?",
}; };
// Forwards a tab-cycle keybind delta to the host (single source of truth). // Forwards a tab-cycle keybind delta to the host so all windows
public void HandleKeybindForward(int delta) => _host.ChangeTabDelta(delta); // navigate the same active-tab pointer (single source of truth).
public void HandleKeybindForward(int delta)
{
_host.ChangeTabDelta(delta);
}
} }
// Per-window input state. Each ChatInputBar owns one so pop-outs and the // Per-window input state. Each ChatInputBar instance owns one of these
// main window keep independent buffers and history cursors. // so pop-outs and the main window keep independent buffers and channels
// (State-Sync-Entscheidung A in the v0.6.0 spec).
public sealed class InputState public sealed class InputState
{ {
public string Buffer = string.Empty; public string Buffer = string.Empty;
+145 -94
View File
@@ -52,8 +52,10 @@ public sealed class ChatLogWindow : Window
private int ActivatePos = -1; private int ActivatePos = -1;
internal string Chat = string.Empty; internal string Chat = string.Empty;
// Input history extracted into InputHistoryService so pop-out windows share // Hellion Chat — v0.6.0 input history was extracted into
// the same Up/Down history. Cursor stays window-local (independent navigation). // InputHistoryService so pop-out windows with their own ChatInputBar
// share the same Up/Down history with the main window. The cursor
// stays window-local because each window navigates independently.
private int InputBacklogIdx = -1; private int InputBacklogIdx = -1;
public bool TellSpecial; public bool TellSpecial;
private readonly Stopwatch LastResize = new(); private readonly Stopwatch LastResize = new();
@@ -72,8 +74,11 @@ public sealed class ChatLogWindow : Window
public Vector2 LastWindowPos { get; private set; } = Vector2.Zero; public Vector2 LastWindowPos { get; private set; } = Vector2.Zero;
public Vector2 LastWindowSize { get; private set; } = Vector2.Zero; public Vector2 LastWindowSize { get; private set; } = Vector2.Zero;
// Guards against off-screen positions after a display layout change. // Window position recovery: guards against off-screen positions after a
// One-shot bounds check on first draw; manual reset button bypasses it. // display layout change (monitor disconnected, resolution changed). On
// the first draw after plugin load we run a one-shot bounds check to see
// whether the stored position still overlaps any visible viewport area.
// The manual reset button in the settings forces the position regardless.
private bool DidOnLoadBoundsCheck; private bool DidOnLoadBoundsCheck;
internal bool RequestPositionReset { get; set; } internal bool RequestPositionReset { get; set; }
@@ -90,10 +95,6 @@ public sealed class ChatLogWindow : Window
private bool PlayedClosingSound = true; private bool PlayedClosingSound = true;
private bool DrewThisFrame; private bool DrewThisFrame;
// One-shot guard so a recurring draw failure doesn't spam the
// notification stack frame-by-frame. Resets only on next plugin reload.
private bool NotifiedDrawFailure;
private long FrameTime; // set every frame private long FrameTime; // set every frame
internal long LastActivityTime = Environment.TickCount64; internal long LastActivityTime = Environment.TickCount64;
@@ -111,7 +112,9 @@ public sealed class ChatLogWindow : Window
IsOpen = true; IsOpen = true;
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
// AllowBackgroundBlur is set centrally in Plugin.Setup after AddWindow. // AllowBackgroundBlur wird nach AddWindow zentral in Plugin.Setup
// für alle registrierten Windows gesetzt — keine Per-Window-Logik
// hier nötig.
PayloadHandler = new PayloadHandler(this); PayloadHandler = new PayloadHandler(this);
HandlerLender = new Lender<PayloadHandler>(() => new PayloadHandler(this)); HandlerLender = new Lender<PayloadHandler>(() => new PayloadHandler(this));
@@ -119,8 +122,10 @@ public sealed class ChatLogWindow : Window
SetUpTextCommandChannels(); SetUpTextCommandChannels();
SetUpAllCommands(); SetUpAllCommands();
// Cache wrapper instances so Dispose can detach the same event objects // Cache the registered wrapper instances so Dispose can detach the same
// without going through Register() again. // event objects the constructor attached to, without going through
// Register() again (which would re-create the wrapper if the command
// happened to be missing from the dictionary).
_clearHellionCommand = Plugin.Commands.Register( _clearHellionCommand = Plugin.Commands.Register(
"/clearhellion", "/clearhellion",
"Clear the Hellion Chat log" "Clear the Hellion Chat log"
@@ -272,10 +277,7 @@ public sealed class ChatLogWindow : Window
} }
} }
if ( if (targetChannel == null || !GameFunctions.Chat.ValidAnyLinkshell(targetChannel.Value))
targetChannel == null
|| !GameFunctions.Chat.IsChannelOrExistingLinkshell(targetChannel.Value)
)
{ {
Plugin.Log.Warning( Plugin.Log.Warning(
$"Channel was set to an invalid value '{targetChannel}', ignoring" $"Channel was set to an invalid value '{targetChannel}', ignoring"
@@ -395,10 +397,11 @@ public sealed class ChatLogWindow : Window
} }
} }
// Delegates to InputHistoryService so pop-out ChatInputBar instances share
// history. Deduplication lives inside the service.
private void AddBacklog(string message) private void AddBacklog(string message)
{ {
// v0.6.0 — delegates to the shared InputHistoryService so pop-out
// ChatInputBar instances see the same history. Move-to-newest
// deduplication lives inside the service.
InputHistoryService.Push(message); InputHistoryService.Push(message);
} }
@@ -414,12 +417,15 @@ public sealed class ChatLogWindow : Window
if (Plugin.Config.PreviewPosition is PreviewPosition.Inside) if (Plugin.Config.PreviewPosition is PreviewPosition.Inside)
height -= Plugin.InputPreview.PreviewHeight; height -= Plugin.InputPreview.PreviewHeight;
// Header toolbar height is not subtracted by GetContentRegionAvail automatically // Hellion Chat v0.6.1 — Header-Toolbar rendert auf Window-Ebene über
// (it renders outside the normal layout path), so we subtract it explicitly. // einem horizontalen Layout-Pfad und wird von GetContentRegionAvail
// The hint banner renders before this block so ImGui already accounts for it. // hier drin NICHT automatisch berücksichtigt, daher expliziter Abzug.
// Banner dagegen rendert in DrawChatLog VOR diesem ganzen Block und
// ImGui zieht seine Höhe automatisch von GetContentRegionAvail ab,
// weil der Cursor schon weiter unten steht — kein eigener Abzug.
height -= ImGui.GetFrameHeightWithSpacing(); height -= ImGui.GetFrameHeightWithSpacing();
// Status bar at the window bottom reserves 22px + 2px spacing. // v1.2.0 — Status-Bar am Window-Boden reserviert 22 px + 2 px Spacing.
height -= StatusBar.Height + 2; height -= StatusBar.Height + 2;
return height; return height;
@@ -634,19 +640,6 @@ public sealed class ChatLogWindow : Window
catch (Exception ex) catch (Exception ex)
{ {
Plugin.Log.Error(ex, "Error drawing Chat Log window"); Plugin.Log.Error(ex, "Error drawing Chat Log window");
if (!NotifiedDrawFailure)
{
Plugin.Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification
{
Title = "Hellion Chat",
Content = "A drawing error occurred. Check /xllog for details.",
Type = Dalamud.Interface.ImGuiNotification.NotificationType.Warning,
InitialDuration = TimeSpan.FromSeconds(20),
}
);
NotifiedDrawFailure = true;
}
// Prevent recurring draw failures from constantly trying to grab // Prevent recurring draw failures from constantly trying to grab
// input focus, which breaks every other ImGui window. // input focus, which breaks every other ImGui window.
Activate = false; Activate = false;
@@ -666,8 +659,10 @@ public sealed class ChatLogWindow : Window
LastWindowSize = currentSize; LastWindowSize = currentSize;
LastWindowPos = ImGui.GetWindowPos(); LastWindowPos = ImGui.GetWindowPos();
// Manual reset snaps unconditionally; on-load check only fires when the // Window position recovery. Manual reset takes precedence and snaps
// stored position has no overlap with any visible viewport. // the window to the safe default unconditionally; the one-shot
// on-load check only fires when the persisted position has no
// overlap with any visible viewport area.
if (RequestPositionReset) if (RequestPositionReset)
{ {
RequestPositionReset = false; RequestPositionReset = false;
@@ -689,8 +684,11 @@ public sealed class ChatLogWindow : Window
if (IsChatMode && Plugin.InputPreview.IsDrawable) if (IsChatMode && Plugin.InputPreview.IsDrawable)
Plugin.InputPreview.CalculatePreview(); Plugin.InputPreview.CalculatePreview();
// Render the hint banner first so it sits above the tab area at full // Hellion Chat v0.6.1 — render the one-time hint banner first so it
// window width. ImGui accounts for its height automatically. // sits above the tab area / sidebar in full window width. ImGui's
// GetContentRegionAvail subtracts its height automatically because the
// cursor advances past it before the message log calls
// GetRemainingHeightForMessageLog, so we don't track the height here.
DrawV061HintBannerIfNeeded(); DrawV061HintBannerIfNeeded();
if (Plugin.Config.SidebarTabView) if (Plugin.Config.SidebarTabView)
@@ -715,7 +713,8 @@ public sealed class ChatLogWindow : Window
DrawChannelName(activeTab); DrawChannelName(activeTab);
} }
// inputColour computed up front so the channel selector button can share it. // v1.0.2 — compute inputColour up front so the channel selector button
// can also tint with it (existing input-text push remains below).
var inputType = activeTab.CurrentChannel.UseTempChannel var inputType = activeTab.CurrentChannel.UseTempChannel
? activeTab.CurrentChannel.TempChannel.ToChatType() ? activeTab.CurrentChannel.TempChannel.ToChatType()
: activeTab.CurrentChannel.Channel.ToChatType(); : activeTab.CurrentChannel.Channel.ToChatType();
@@ -1033,8 +1032,11 @@ public sealed class ChatLogWindow : Window
} }
else else
{ {
// ExtraChat channel names aren't available over IPC by index, // We cannot lookup ExtraChat channel names from index over
// so we skip the name lookup and show the short form instead. // IPC so we just don't show the name if it's the tabs channel.
//
// We don't call channel.ToChatType().Name() as it has the
// long name as used in the settings window.
channelNameChunks = channelNameChunks =
[ [
new TextChunk( new TextChunk(
@@ -1120,8 +1122,8 @@ public sealed class ChatLogWindow : Window
Plugin.CurrentTab.CurrentChannel.TempTellTarget = null; Plugin.CurrentTab.CurrentChannel.TempTellTarget = null;
} }
// ExtraChat linkshell channel switch: call the prefix command through the // Instead of calling SetChannel(), we ask the ExtraChat plugin to set a
// game chat because ExtraChat only registers stub handlers in Dalamud. // channel override by just calling the command directly.
if (channel.Value.IsExtraChatLinkshell()) if (channel.Value.IsExtraChatLinkshell())
{ {
// Check that the command is registered in Dalamud so the game code // Check that the command is registered in Dalamud so the game code
@@ -1167,8 +1169,10 @@ public sealed class ChatLogWindow : Window
]; ];
} }
// Pop-out windows route submission here. The main Chat buffer is briefly // v0.6.0 — pop-out windows route submission through this wrapper.
// used as a vehicle for SendChatBox and restored afterwards. // The main-window Chat buffer is briefly used as a vehicle for
// SendChatBox (which reads it directly) and restored afterwards so
// the main window does not visibly lose any half-typed input.
internal void SendChatBoxFromExternal(Tab tab, string text) internal void SendChatBoxFromExternal(Tab tab, string text)
{ {
var saved = Chat; var saved = Chat;
@@ -1213,7 +1217,7 @@ public sealed class ChatLogWindow : Window
?? activeTab.CurrentChannel.TellTarget; ?? activeTab.CurrentChannel.TellTarget;
if (target != null) if (target != null)
{ {
// ContentId 0: can't send directly, so format as /tell and let the game handle it. // ContentId 0 is a case where we can't directly send messages, so we send a /tell formatted message and let the game handle it
if (target.ContentId == 0) if (target.ContentId == 0)
{ {
trimmed = $"/tell {target.ToTargetString()} {trimmed}"; trimmed = $"/tell {target.ToTargetString()} {trimmed}";
@@ -1379,8 +1383,8 @@ public sealed class ChatLogWindow : Window
var maxLines = Plugin.Config.MaxLinesToRender; var maxLines = Plugin.Config.MaxLinesToRender;
var startLine = messages.Count > maxLines ? messages.Count - maxLines : 0; var startLine = messages.Count > maxLines ? messages.Count - maxLines : 0;
// Card-mode pre-loop: theme/drawList/winLeft/winRight/border are invariant // Card-mode pre-loop hoist: theme/drawList/winLeft/winRight/border
// per DrawMessages call; only cursorY moves per row. // are invariant per DrawMessages call; only cursorY moves per row.
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var drawList = ImGui.GetWindowDrawList(); var drawList = ImGui.GetWindowDrawList();
var winLeft = ImGui.GetWindowPos().X; var winLeft = ImGui.GetWindowPos().X;
@@ -1537,9 +1541,11 @@ public sealed class ChatLogWindow : Window
var lineWidth = ImGui.GetContentRegionAvail().X; var lineWidth = ImGui.GetContentRegionAvail().X;
// v1.2.0 card mode: sender on its own line in channel color, then body, // v1.2.0 — Card-Rows als Default, Compact-Density als Opt-Out.
// then a subtle border as a card separator. // Card-Mode: Sender-Header in Channel-Color auf eigener Zeile,
// Compact mode: sender + space + content on one line via SameLine. // dann Body, dann subtile Border-Bottom als Card-Trenner.
// Compact-Mode: bisheriges Verhalten — Sender + Space + Content
// auf einer Zeile via SameLine.
var useCard = !Plugin.Config.UseCompactDensity; var useCard = !Plugin.Config.UseCompactDensity;
if (useCard) if (useCard)
{ {
@@ -1552,7 +1558,7 @@ public sealed class ChatLogWindow : Window
{ {
DrawChunks(message.Sender, true, handler, lineWidth); DrawChunks(message.Sender, true, handler, lineWidth);
} }
// No SameLine — body renders on its own line. // KEIN SameLine — Body landet auf eigener Zeile.
} }
// We need to draw something otherwise the item visibility check below won't work. // We need to draw something otherwise the item visibility check below won't work.
@@ -1566,7 +1572,8 @@ public sealed class ChatLogWindow : Window
else else
DrawChunks(message.Content, true, handler, lineWidth); DrawChunks(message.Content, true, handler, lineWidth);
// Border bottom as card separator. Alpha reduced to 0x33 for subtlety. // Subtile Border-Bottom als Card-Trenner. Border-Farbe mit
// reduzierter Alpha (RGBA → 0x33) für dezente Trennung.
{ {
var rowEndY = ImGui.GetCursorScreenPos().Y; var rowEndY = ImGui.GetCursorScreenPos().Y;
drawList.AddLine( drawList.AddLine(
@@ -1639,22 +1646,19 @@ public sealed class ChatLogWindow : Window
if (!tabItem.Success) if (!tabItem.Success)
continue; continue;
// Active-tab underline pill (2px accent). No native ImGui underline API, // v1.2.0 — Active-Tab-Underline-Pill (2 px Akzent statt Background-Fill).
// so we use a direct DrawList pass. Pill height scales with GlobalScale // Bewusst direkt nach TabItem-Setup; GetItemRectMin/Max referenziert noch
// and all coordinates round to physical pixels so the line stays crisp // das Tab. ImGui hat keine native Underline-API, daher direkter DrawList-Pass.
// on 125/150% DPI setups instead of bleeding into a sub-pixel blur.
{ {
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
var max = ImGui.GetItemRectMax(); var max = ImGui.GetItemRectMax();
var pillHeight = MathF.Max(1f, MathF.Round(2f * ImGuiHelpers.GlobalScale)); const float pillHeight = 2f;
var yBottom = MathF.Round(max.Y);
var yTop = yBottom - pillHeight;
ImGui ImGui
.GetWindowDrawList() .GetWindowDrawList()
.AddRectFilled( .AddRectFilled(
new Vector2(MathF.Round(min.X), yTop), new Vector2(min.X, max.Y - pillHeight),
new Vector2(MathF.Round(max.X), yBottom), new Vector2(max.X, max.Y),
ColourUtil.RgbaToAbgr(theme.Colors.Accent) ColourUtil.RgbaToAbgr(theme.Colors.Accent)
); );
} }
@@ -1676,7 +1680,7 @@ public sealed class ChatLogWindow : Window
private void DrawTabSidebar() private void DrawTabSidebar()
{ {
var currentTab = -1; var currentTab = -1;
// Sidebar fixed at 44px, no resize. // v1.2.0 — Sidebar fix 44 px, kein Resize. Mehr Platz fürs Chat-Log.
using var tabTable = ImRaii.Table( using var tabTable = ImRaii.Table(
"tabs-table", "tabs-table",
2, 2,
@@ -1692,19 +1696,28 @@ public sealed class ChatLogWindow : Window
var hasTabSwitched = false; var hasTabSwitched = false;
var childHeight = GetRemainingHeightForMessageLog(); var childHeight = GetRemainingHeightForMessageLog();
// Sidebar child without ChildBg tint to avoid a colored block above the // v1.2.0 — Sidebar-Child ohne Theme-ChildBg, sonst füllt das
// header toolbar area. Vertical separation is handled by BordersInnerV. // bläuliche Frame-Rect auch den oberen HeaderToolbar-Padding-Bereich
// aus (sieht aus wie ein angeschnittener Block oberhalb der Buttons).
// Vertikale Trennung zur Message-Spalte bleibt durch BordersInnerV
// der Tab-Table erhalten.
using (ImRaii.PushColor(ImGuiCol.ChildBg, 0u)) using (ImRaii.PushColor(ImGuiCol.ChildBg, 0u))
using (var child = ImRaii.Child("##chat2-tab-sidebar", new Vector2(-1, childHeight))) using (var child = ImRaii.Child("##chat2-tab-sidebar", new Vector2(-1, childHeight)))
{ {
if (child) if (child)
{ {
// Top padding mirrors the HeaderToolbar height so sidebar buttons // v1.2.0 — Top-Padding spiegelt die HeaderToolbar-Höhe der
// align with the message log start. // rechten Spalte (DrawChatHeaderToolbar wird dort als erstes
// gerendert, eine Frame-Zeile + ItemSpacing). Ohne diesen
// Padding würden die Sidebar-Buttons oben am Window-Top
// kleben, während die Messages erst unter der Toolbar
// beginnen — vertikales Mismatch.
ImGui.Dummy(new Vector2(0, ImGui.GetFrameHeightWithSpacing())); ImGui.Dummy(new Vector2(0, ImGui.GetFrameHeightWithSpacing()));
var previousTab = Plugin.CurrentTab; var previousTab = Plugin.CurrentTab;
// Divider rendered once before the first temp tab with a live unit counter. // Hellion Chat — auto-tell-tabs section divider rendered
// exactly once before the first temp tab, with a live unit
// counter pulled directly from the tab list.
var tempTabHeaderRendered = false; var tempTabHeaderRendered = false;
var tempTabCount = Plugin.Config.Tabs.Count(t => t.IsTempTab); var tempTabCount = Plugin.Config.Tabs.Count(t => t.IsTempTab);
@@ -1739,8 +1752,11 @@ public sealed class ChatLogWindow : Window
if (showGreetedAffordance) if (showGreetedAffordance)
{ {
// Greeted toggle left of the selectable to keep click areas separate. // Greeted toggle sits left of the selectable so the
// Compact padding keeps the icon next to the tab name. // click areas stay separate. The icon also doubles
// as the visual "I'm done with this person" cue.
// Compact frame padding keeps the icon dezent next
// to the tab name instead of a chunky button block.
var greetedIcon = tab.IsGreeted var greetedIcon = tab.IsGreeted
? FontAwesomeIcon.CheckCircle ? FontAwesomeIcon.CheckCircle
: FontAwesomeIcon.Check; : FontAwesomeIcon.Check;
@@ -1768,8 +1784,10 @@ public sealed class ChatLogWindow : Window
ImGui.SameLine(); ImGui.SameLine();
} }
// Icon-only sidebar with tooltip on hover. Active tab gets accent color; // v1.2.0 — Icon-only Sidebar mit Tooltip beim Hover.
// greeted tabs are dimmed; tell tabs get a hash-based tint. // Active-Tab kriegt Akzent-Color am Icon, Greeted-Tabs
// werden auf TextDim gedimmt (löst den alten Header-
// Dim-Trick ab, da wir keine Selectable mehr nutzen).
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var icon = TabIconMapping.Resolve(tab); var icon = TabIconMapping.Resolve(tab);
uint iconColor; uint iconColor;
@@ -1783,8 +1801,8 @@ public sealed class ChatLogWindow : Window
} }
else if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet()) else if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet())
{ {
// Hash-based color tint differentiates parallel Auto-Tell tabs // v1.2.0 — Hash-Color-Tint differenziert parallele Auto-Tell-Tabs
// without requiring manual icon assignment per tab. // visuell ohne dass User pro Tab manuell ein Custom-Icon setzen muss.
iconColor = TabTintCache.GetTint(tab); iconColor = TabTintCache.GetTint(tab);
} }
else else
@@ -1817,8 +1835,9 @@ public sealed class ChatLogWindow : Window
if (isCurrentTab) if (isCurrentTab)
{ {
// Vertical accent pill on the left window edge, 3px wide, half tab height, // v1.2.0 — Vertikale Akzent-Pill an der linken Window-Kante.
// vertically centered. Direct DrawList pass, no native ImGui API for this. // 3 px breit, halbe Tab-Höhe, vertikal zentriert. ImGui hat keine
// native Pill-API, daher direkter DrawList-Pass.
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
var max = ImGui.GetItemRectMax(); var max = ImGui.GetItemRectMax();
const float pillWidth = 3f; const float pillWidth = 3f;
@@ -1834,8 +1853,10 @@ public sealed class ChatLogWindow : Window
); // leichter Rounding ); // leichter Rounding
} }
// Unread dot top-right of the icon. Active tabs have Unread=0 by convention // v1.2.0 — Unread-Dot oben rechts am Icon. Sichtbar ohne Hover, damit
// so the dot never conflicts with the active pill. // User Tabs mit ungelesenen Messages sofort erkennt. Aktive Tabs haben
// per Konvention Unread = 0 (LastTab-Branch in ChatLogWindow), daher
// kollidiert der Dot nicht mit der Active-Pill.
if (!isCurrentTab && tab.UnreadMode != UnreadMode.None && tab.Unread > 0) if (!isCurrentTab && tab.UnreadMode != UnreadMode.None && tab.Unread > 0)
{ {
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
@@ -1847,7 +1868,10 @@ public sealed class ChatLogWindow : Window
min.Y + dotRadius + dotPadding min.Y + dotRadius + dotPadding
); );
// Sin-based 2s pulse: alpha oscillates 60-100%. Skipped when ReduceMotion is on. // v1.2.0 — Sanfter Pulse-Effekt: Alpha schwankt zwischen 60% und
// 100% mit ~2-Sekunden-Cycle (subtil, nicht hektisch).
// Plugin.Config.ReduceMotion (Field seit v1.1.0) skipt den Pulse
// und rendert statisch — Default ist Animation an.
var dotColor = theme.Colors.StatusDanger; var dotColor = theme.Colors.StatusDanger;
if (!Plugin.Config.ReduceMotion) if (!Plugin.Config.ReduceMotion)
{ {
@@ -1917,8 +1941,14 @@ public sealed class ChatLogWindow : Window
Plugin.WantedTab = null; Plugin.WantedTab = null;
} }
// DrawChatHeaderToolbar: renders the pop-out button for the active tab. // Hellion Chat v0.6.1 — visible pop-out trigger right above the message
// v1.3.0 also renders the optional Honorific title slot left of it. // log so users discover the feature without having to right-click the tab.
// Renders only for the active tab in the main ChatLogWindow; pop-out
// windows have their own render path and skip this toolbar.
//
// Hellion Chat v1.3.0 also renders the optional Honorific title slot
// left of the pop-out button, when HonorificService reports an active
// custom title and the user has ShowHonorificTitleInHeader enabled.
private void DrawChatHeaderToolbar(Tab tab) private void DrawChatHeaderToolbar(Tab tab)
{ {
DrawHonorificTitleSlot(); DrawHonorificTitleSlot();
@@ -1943,9 +1973,16 @@ public sealed class ChatLogWindow : Window
} }
} }
// Title rendered first so DrawPopOutButton can anchor flush right via // Renders the Honorific custom title to the left of the pop-out button,
// GetContentRegionAvail. Call order in DrawChatHeaderToolbar matters. // wrapped in guillemets to match how the game itself displays titles.
// SameLine keeps both on the same toolbar row. // We lay out the title first, then DrawPopOutButton uses
// GetContentRegionAvail to anchor itself flush right, which is why the
// call order in DrawChatHeaderToolbar matters: title first, button second.
//
// The slot stays on the same line as the pop-out button so the chat
// log doesn't lose vertical space; we use ImGui.SameLine after our
// text so the cursor X is still on the toolbar row when the pop-out
// button takes over.
private void DrawHonorificTitleSlot() private void DrawHonorificTitleSlot()
{ {
var service = Plugin.HonorificService; var service = Plugin.HonorificService;
@@ -1991,7 +2028,8 @@ public sealed class ChatLogWindow : Window
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
// Group so IsItemHovered covers both the crown icon and the title text. // Group so the tooltip's IsItemHovered check fires for hover anywhere
// on the crown-plus-title pair, not just one of the two.
ImGui.BeginGroup(); ImGui.BeginGroup();
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted))) using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
@@ -2013,7 +2051,11 @@ public sealed class ChatLogWindow : Window
ImGui.SameLine(); ImGui.SameLine();
} }
// One-time hint banner for the pop-out header button and right-click pathway. // Hellion Chat v0.6.1 — One-Time-Hint-Banner introducing the chat header
// pop-out toolbar button and the right-click pathway. Reuses the visual
// pattern from Popout.cs DrawHintBannerIfNeeded so users see a familiar
// dismiss-affordance. Returns the vertical space the banner consumed
// (0 when not shown) so the message log can shrink accordingly.
private float DrawV061HintBannerIfNeeded() private float DrawV061HintBannerIfNeeded()
{ {
if (Plugin.Config.SeenPopOutHeaderHint) if (Plugin.Config.SeenPopOutHeaderHint)
@@ -2028,7 +2070,10 @@ public sealed class ChatLogWindow : Window
var bg = new System.Numerics.Vector4(0.16f, 0.20f, 0.28f, 1f); var bg = new System.Numerics.Vector4(0.16f, 0.20f, 0.28f, 1f);
var dismiss = false; var dismiss = false;
var openSettings = false; var openSettings = false;
// RAII style stack so an early return can never leave ImGui unbalanced. // RAII for the style stack so an early return in this block
// (or a later refactor that introduces one) can never leave the
// ImGui style stack unbalanced. Matches the convention used
// elsewhere in this file.
using (ImRaii.PushColor(ImGuiCol.ChildBg, bg)) using (ImRaii.PushColor(ImGuiCol.ChildBg, bg))
using (ImRaii.PushStyle(ImGuiStyleVar.FrameBorderSize, 1f)) using (ImRaii.PushStyle(ImGuiStyleVar.FrameBorderSize, 1f))
using ( using (
@@ -2131,8 +2176,10 @@ public sealed class ChatLogWindow : Window
internal readonly List<bool> PopOutDocked = []; internal readonly List<bool> PopOutDocked = [];
internal readonly HashSet<Guid> PopOutWindows = []; internal readonly HashSet<Guid> PopOutWindows = [];
// Live enumeration of active Popout windows for KeybindManager tab-cycle forwarding. // v0.6.0 — live enumeration of all active Popout windows so the
// Filters on IsOpen to skip closed-but-registered popouts. // KeybindManager can find a focused ChatInputBar to forward tab-cycle
// keybinds to. Filter on IsOpen prevents touching closed-but-still-
// registered popouts.
internal IEnumerable<Popout> ActivePopouts => internal IEnumerable<Popout> ActivePopouts =>
Plugin.WindowSystem.Windows.OfType<Popout>().Where(p => p.IsOpen); Plugin.WindowSystem.Windows.OfType<Popout>().Where(p => p.IsOpen);
@@ -2305,7 +2352,8 @@ public sealed class ChatLogWindow : Window
} }
finally finally
{ {
// Destroy frees the unmanaged ImGuiListClipper allocated above; without it the block leaks per render. // ImGuiListClipperPtr wraps an unmanaged ImGuiListClipper allocated above.
// Without Destroy() the unmanaged block leaks per autocomplete render.
clipper.Destroy(); clipper.Destroy();
} }
} }
@@ -2639,8 +2687,9 @@ public sealed class ChatLogWindow : Window
return $"Player {hashCode:X8}"; return $"Player {hashCode:X8}";
} }
// Snap threshold: minimum window overlap with a visible viewport before // Snap threshold in pixels: at least this much of the window must overlap
// we consider it off-screen. // a visible viewport so the user can still grab the first tab header.
// Below the threshold the window is considered off-screen.
private const int OnScreenMinOverlapX = 100; private const int OnScreenMinOverlapX = 100;
private const int OnScreenMinOverlapY = 40; private const int OnScreenMinOverlapY = 40;
@@ -2676,7 +2725,9 @@ public sealed class ChatLogWindow : Window
$"[Window-Recovery] {source}: snapping main window from {LastWindowPos} (size {LastWindowSize}) to {safePos}." $"[Window-Recovery] {source}: snapping main window from {LastWindowPos} (size {LastWindowSize}) to {safePos}."
); );
// Pop-outs don't persist across sessions so they can never end up off-screen // Pop-outs are intentionally non-persistent (cleared on plugin reload),
// after a reload. Only the main window needs explicit recovery. // so an off-screen pop-out can never survive a session boundary. The
// main window above is the only persistence target that needs an
// explicit recovery path.
} }
} }
+7
View File
@@ -211,6 +211,13 @@ public class DbViewer : Window
if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled)) if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled))
ImGui.SetTooltip(Language.Export_Txt_Tooltip); ImGui.SetTooltip(Language.Export_Txt_Tooltip);
// Hellion Chat: the JSON export button used to dump the database in
// the upstream webinterface's wire format. With the webinterface
// removed there is no consumer for that format any more, so the
// button is dropped. The Privacy tab's MessageExporter covers the
// same ground (Markdown / JSON / CSV) with channel and date filters
// and is the supported way to get history out of the plugin.
var width = 350 * ImGuiHelpers.GlobalScale; var width = 350 * ImGuiHelpers.GlobalScale;
var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64; var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64;
+9 -24
View File
@@ -30,10 +30,14 @@ public sealed class FirstRunWizard : Window
public override void OnClose() public override void OnClose()
{ {
// OnClose fires on explicit X-click and on plugin dispose. We never // Closing the wizard without picking anything = the user accepts
// implicitly accept the defaults here — the explicit "Later" button // whatever defaults are already in place. Mark as complete so we
// does that. If the user hasn't picked a profile yet, the wizard // don't pester them again on the next launch.
// reopens on the next plugin load. if (!Plugin.Config.FirstRunCompleted)
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
}
} }
public override void Draw() public override void Draw()
@@ -45,12 +49,7 @@ public sealed class FirstRunWizard : Window
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f; var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f;
// Reserve room for the footer separator + cancel button below the cards. var cardHeight = avail.Y - ImGui.GetTextLineHeightWithSpacing();
var footerReserve =
ImGui.GetStyle().ItemSpacing.Y * 3
+ ImGui.GetTextLineHeight()
+ ImGui.GetFrameHeightWithSpacing();
var cardHeight = avail.Y - footerReserve;
DrawCard( DrawCard(
"privacy-first", "privacy-first",
@@ -88,20 +87,6 @@ public sealed class FirstRunWizard : Window
HellionStrings.Wizard_Profile_FullHistory_Apply, HellionStrings.Wizard_Profile_FullHistory_Apply,
ApplyFullHistory ApplyFullHistory
); );
ImGui.Spacing();
ImGui.Separator();
ImGui.Spacing();
if (ImGui.Button(HellionStrings.Wizard_Cancel_Label))
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
IsOpen = false;
}
if (ImGui.IsItemHovered())
ImGuiUtil.Tooltip(HellionStrings.Wizard_Cancel_Tooltip);
} }
private void DrawCard( private void DrawCard(
+30 -12
View File
@@ -5,12 +5,18 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Theme-driven ImGui style override. PushGlobal is pushed once per frame /// <summary>
// in Plugin.Draw and drives every Hellion-rendered window. /// ImGui style override for Hellion Chat. v1.1.0 ist die Engine
/// theme-getrieben: PushGlobal nimmt eine Theme-Instance + Window-
/// Opacity, die gesamten Color- und Style-Slots werden aus dem Theme
/// gelesen statt aus einer fixen Konstanten-Tabelle.
/// </summary>
internal static class HellionStyle internal static class HellionStyle
{ {
// Local color stack for the active theme. Use inside a /// <summary>
// `using var _ = HellionStyle.Push(theme);` block. /// Local color stack auf Basis des aktiven Themes. Cheap. Use inside a
/// `using var _ = HellionStyle.Push(theme);` block.
/// </summary>
internal static IDisposable Push(Theme theme) internal static IDisposable Push(Theme theme)
{ {
var a = theme.AbgrCache; var a = theme.AbgrCache;
@@ -31,8 +37,13 @@ internal static class HellionStyle
return stack; return stack;
} }
// Global color and style stack pushed once per frame. /// <summary>
// windowOpacity: window background alpha (0.5-1.0). /// Global color and style-variable stack pushed once per frame in
/// Plugin.Draw. Drives every Hellion-rendered window from the active
/// theme's palette and layout values.
/// </summary>
/// <param name="theme">Active theme from ThemeRegistry.</param>
/// <param name="windowOpacity">Window background alpha (0.51.0).</param>
internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f) internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f)
{ {
var c = theme.Colors; var c = theme.Colors;
@@ -43,10 +54,17 @@ internal static class HellionStyle
var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF); var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF);
var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte; var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte;
// ChildBg alpha resolution lives in HellionStyleHelpers so the // ChildBg-Alpha: Sub-Bereiche (Tab-Sidebar, Message-Area, Input-Bar)
// threshold logic can be covered by a pure-helper test in the // werden im ChatLog-Window als BeginChild gezeichnet. Würde der ChildBg
// build suite. // mit dem gleichen Alpha wie WindowBg gerendert, multiplizieren sich
var childBgWithAlpha = HellionStyleHelpers.ResolveChildBgAlpha(c.ChildBg, windowOpacity); // die Layer (1 - (1-α)² Deckung), und 50 % WindowOpacity kommt mit
// 75 % Deckung im Child-Bereich an — das Fenster wirkt solider als der
// Slider verspricht. Bei voller Opacity bleibt der Theme-Akzent
// erhalten (Theme-eigene Alpha-Komponente, i.d.R. FF); sobald der User
// Transparenz zieht, wird ChildBg vollständig durchsichtig damit nur
// der WindowBg-Layer die finale Deckung bestimmt.
var childBgAlpha = windowOpacity >= 0.999f ? (c.ChildBg & 0xFFu) : 0u;
var childBgWithAlpha = (c.ChildBg & 0xFFFFFF00u) | childBgAlpha;
// Layout // Layout
stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding); stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding);
@@ -59,8 +77,8 @@ internal static class HellionStyle
stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize); stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize);
stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize); stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize);
// Surfaces — WindowBg/ChildBg use opacity-modulated values (RGBA path); // Surfaces — WindowBg/ChildBg use the per-push opacity-modulated value,
// everything else reads from the pre-computed ABGR cache. // so they go through the RGBA path; everything else reads from cache.
stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha); stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha);
stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha); stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha);
stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg); stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg);
-17
View File
@@ -1,17 +0,0 @@
namespace HellionChat.Ui;
internal static class HellionStyleHelpers
{
// Child surfaces are drawn over WindowBg, so at partial window opacity
// the theme's own ChildBg alpha would double-multiply and read too solid.
// Above ~full opacity we preserve the theme alpha; below it we wipe to 0
// so WindowBg alone carries the coverage. The 0.999f threshold is a
// float-imprecision guard around the user-facing 100% slider value.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/HellionStyleHelpersTests.cs
public static uint ResolveChildBgAlpha(uint themeChildBgRgba, float windowOpacity)
{
var alphaPreserved = windowOpacity >= 0.999f;
var childBgAlpha = alphaPreserved ? (themeChildBgRgba & 0xFFu) : 0u;
return (themeChildBgRgba & 0xFFFFFF00u) | childBgAlpha;
}
}
+55 -20
View File
@@ -12,15 +12,19 @@ internal class Popout : Window
private readonly Tab Tab; private readonly Tab Tab;
private readonly int Idx; private readonly int Idx;
private long FrameTime; private long FrameTime; // set every frame
private long LastActivityTime = Environment.TickCount64; private long LastActivityTime = Environment.TickCount64;
// Optional input bar inside the pop-out. Lazy-allocated when enabled, // v0.6.0 — optional input bar inside the pop-out window. Lazy-allocated
// torn down on toggle-off (buffer discarded intentionally). // when the user enables Tab.PopOutInputEnabled and torn down when the
// toggle is turned off (independent text buffer is intentionally
// discarded — see v0.6.0 spec edge-case P1).
public ChatInputBar? InputBar { get; private set; } public ChatInputBar? InputBar { get; private set; }
public bool HasFocusedInputBar => InputBar?.IsFocused ?? false; public bool HasFocusedInputBar => InputBar?.IsFocused ?? false;
// Exposed so AutoTellTabsService can locate this window during LRU eviction. // Hellion Chat — v0.6.1 expose just the tab identifier (not the whole Tab
// reference) so AutoTellTabsService.DropOldestTempTab can locate the
// matching pop-out window when an LRU temp tab gets evicted.
internal Guid TabIdentifier => Tab.Identifier; internal Guid TabIdentifier => Tab.Identifier;
public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx) public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx)
@@ -36,9 +40,12 @@ internal class Popout : Window
IsOpen = true; IsOpen = true;
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
// AllowBackgroundBlur is intentionally off: Dalamud blurs the entire // v1.2.1 — KEIN AllowBackgroundBlur. Pop-Outs werden vom User häufig
// tab container, not just this window, which would affect adjacent plugins. // im Dalamud-Tab-Container mit anderen Plugin-Windows kombiniert; in
// Users can enable blur per-window via the Dalamud hamburger menu. // dem Render-Pfad blurt Dalamud den gesamten Container, nicht nur
// das Pop-Out — würde die Tab-Bar oben und benachbarte Plugins
// mitziehen. Wer Blur in Pop-Outs will, kann ihn via Dalamud-
// Hamburger-Menü pro Window selbst aktivieren.
} }
public override void PreOpenCheck() public override void PreOpenCheck()
@@ -63,6 +70,7 @@ internal class Popout : Window
return true; return true;
} }
// Activity in the tab, this popout window, or the main chat log window.
var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime); var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime);
lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime); lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime);
return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout; return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout;
@@ -70,8 +78,10 @@ internal class Popout : Window
public override void PreDraw() public override void PreDraw()
{ {
// Theme engine pushes the active theme globally in Plugin.Draw; // Hellion Chat v1.1.0+ — Theme-Engine ist Source-of-Truth, kein
// pop-outs draw consistently without per-window overrides. // zusätzlicher Dalamud-StyleModel-Override mehr pro Window. Plugin.Draw
// pusht das aktive Hellion-Theme global; Pop-Out zeichnet sich damit
// konsistent zum Haupt-Chat-Window.
Flags = ImGuiWindowFlags.None; Flags = ImGuiWindowFlags.None;
if (!Plugin.Config.ShowPopOutTitleBar) if (!Plugin.Config.ShowPopOutTitleBar)
Flags |= ImGuiWindowFlags.NoTitleBar; Flags |= ImGuiWindowFlags.NoTitleBar;
@@ -82,10 +92,19 @@ internal class Popout : Window
if (!Tab.CanResize) if (!Tab.CanResize)
Flags |= ImGuiWindowFlags.NoResize; Flags |= ImGuiWindowFlags.NoResize;
// Guard against Idx pointing past the end if PopOutDocked was resized mid-frame. // Idx may point past the end if PopOutDocked was resized (e.g., a tab
// dropped) between the AddPopOutsToDraw() snapshot and this frame.
// Guard the read so we don't index into stale state.
if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx]) if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx])
{ {
BgAlpha = Tab.IndependentOpacity ? Tab.Opacity / 100f : Plugin.Config.WindowOpacity; if (Tab.IndependentOpacity)
{
BgAlpha = Tab.Opacity / 100f;
}
else
{
BgAlpha = Plugin.Config.WindowOpacity;
}
} }
} }
@@ -99,15 +118,24 @@ internal class Popout : Window
ImGui.Separator(); ImGui.Separator();
} }
// v0.6.0 — one-time hint banner explaining the new pop-out input
// feature. Shown once per user; "Got it" or "Open settings"
// dismisses it and persists the flag.
var hintBannerHeight = DrawHintBannerIfNeeded(); var hintBannerHeight = DrawHintBannerIfNeeded();
// Toggle-OFF resets InputBar so the next toggle-ON starts with a fresh buffer. // v0.6.0 — pop-out optional input bar. Reserve height first so the
// message log draws into the right region; only shown when the
// global master switch is on. Toggle-OFF resets InputBar so the
// next toggle-ON gives a fresh buffer (no stale text persists).
var inputEnabled = Plugin.Config.PopOutInputEnabled; var inputEnabled = Plugin.Config.PopOutInputEnabled;
if (!inputEnabled && InputBar != null) if (!inputEnabled && InputBar != null)
{
InputBar = null; InputBar = null;
}
if (inputEnabled) if (inputEnabled)
{
InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab); InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab);
}
var inputBarHeight = inputEnabled var inputBarHeight = inputEnabled
? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y ? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y
@@ -127,7 +155,8 @@ internal class Popout : Window
LastActivityTime = FrameTime; LastActivityTime = FrameTime;
} }
// Returns the vertical space consumed by the banner (0 when not shown). // Returns the vertical space the banner consumed (0 when not shown)
// so the message log can shrink accordingly.
private float DrawHintBannerIfNeeded() private float DrawHintBannerIfNeeded()
{ {
if (Plugin.Config.SeenPopOutInputHint) if (Plugin.Config.SeenPopOutInputHint)
@@ -211,18 +240,21 @@ internal class Popout : Window
private bool HideStateCheck() private bool HideStateCheck()
{ {
// if the chat has no hide state set, and the player has entered battle, we hide chat if they have configured it
if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle) if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle)
{ {
CurrentHideState = HideState.Battle; CurrentHideState = HideState.Battle;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None -> Battle"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Battle");
} }
// If the chat is hidden because of battle, we reset it here
if (CurrentHideState is HideState.Battle && !Plugin.InBattle) if (CurrentHideState is HideState.Battle && !Plugin.InBattle)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: Battle -> None"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: Battle None");
} }
// if the chat has no hide state and in a cutscene, set the hide state to cutscene
if ( if (
Tab.HideDuringCutscenes Tab.HideDuringCutscenes
&& CurrentHideState == HideState.None && CurrentHideState == HideState.None
@@ -232,10 +264,11 @@ internal class Popout : Window
if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags()) if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags())
{ {
CurrentHideState = HideState.Cutscene; CurrentHideState = HideState.Cutscene;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None -> Cutscene"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Cutscene");
} }
} }
// if the chat is hidden because of a cutscene and no longer in a cutscene, set the hide state to none
if ( if (
CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride
&& !Plugin.CutsceneActive && !Plugin.CutsceneActive
@@ -243,23 +276,25 @@ internal class Popout : Window
) )
{ {
Plugin.Log.Verbose( Plugin.Log.Verbose(
$"Popout HideState [{Tab.Name}]: {CurrentHideState} -> None (cutscene/gpose ended)" $"Popout HideState [{Tab.Name}]: {CurrentHideState} None (cutscene/gpose ended)"
); );
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
} }
// if the chat is hidden because of a cutscene and the chat has been activated, show chat
if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate) if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.CutsceneOverride; CurrentHideState = HideState.CutsceneOverride;
Plugin.Log.Verbose( Plugin.Log.Verbose(
$"Popout HideState [{Tab.Name}]: Cutscene -> CutsceneOverride (user activate)" $"Popout HideState [{Tab.Name}]: Cutscene CutsceneOverride (user activate)"
); );
} }
// if the user hid the chat and is now activating chat, reset the hide state
if (CurrentHideState == HideState.User && ChatLogWindow.Activate) if (CurrentHideState == HideState.User && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: User -> None (activate)"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: User None (activate)");
} }
return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle
+46 -22
View File
@@ -92,8 +92,10 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
View = SettingsView.Overview; View = SettingsView.Overview;
} }
// ESC in Detail view returns to Overview. Window focus check is // ESC im Detail-View kehrt zur Overview zurück. Window-Focus-Check ist
// required so ESC doesn't fire when the user targets a different window. // Pflicht — sonst triggert ESC auch wenn der User ein anderes Fenster
// fokussiert hat und ESC fürs Game-Menü drückt (Codebase-Pattern siehe
// Util/SearchSelector.cs:37).
if ( if (
View == SettingsView.Detail View == SettingsView.Detail
&& ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows) && ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows)
@@ -126,13 +128,13 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
private void DrawDetail() private void DrawDetail()
{ {
// Breadcrumb header -- accent cyan, clickable, returns to Overview. // Breadcrumb-Header — Akzent-Cyan, klickbar, führt zurück zur Overview
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u))
using (ImRaii.PushColor(ImGuiCol.Button, 0u)) using (ImRaii.PushColor(ImGuiCol.Button, 0u))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu))
{ {
if (ImGui.SmallButton("<- Settings")) if (ImGui.SmallButton(" Settings"))
{ {
View = SettingsView.Overview; View = SettingsView.Overview;
return; return;
@@ -147,8 +149,11 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Section content fills full width. Navigation back to another // Section-Content in voller Breite. Die Tab-Liste links ist überholt:
// section goes via the breadcrumb or ESC. // der User ist bereits über die Card-Übersicht navigiert, eine zweite
// Tab-Liste daneben würde nur den Vanilla-Look zurückbringen. Falls
// der User in eine andere Section will, geht er zurück zur Overview
// (Breadcrumb / ESC).
var style = ImGui.GetStyle(); var style = ImGui.GetStyle();
var height = var height =
ImGui.GetContentRegionAvail().Y ImGui.GetContentRegionAvail().Y
@@ -177,7 +182,9 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(Language.Settings_Discard)) if (ImGui.Button(Language.Settings_Discard))
{
IsOpen = false; IsOpen = false;
}
const string buttonLabel = "Anna's Ko-fi"; const string buttonLabel = "Anna's Ko-fi";
const string buttonLabel2 = "Infi's Ko-fi"; const string buttonLabel2 = "Infi's Ko-fi";
@@ -199,17 +206,18 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
); );
if (ImGui.Button(buttonLabel2)) if (ImGui.Button(buttonLabel2))
Plugin.PlatformUtil.OpenLink("https://ko-fi.com/infiii"); Dalamud.Utility.Util.OpenLink("https://ko-fi.com/infiii");
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(buttonLabel)) if (ImGui.Button(buttonLabel))
Plugin.PlatformUtil.OpenLink("https://ko-fi.com/lojewalo"); Dalamud.Utility.Util.OpenLink("https://ko-fi.com/lojewalo");
} }
if (!save) if (!save)
return; return;
// calculate all conditions before updating config
var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat; var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat;
var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride; var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride;
var fontChanged = var fontChanged =
@@ -222,16 +230,18 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001 Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001
|| Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001; || Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001;
var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled; var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled;
// v1.2.0 — Refilter only if a filter-relevant setting actually
// Only refilter when filter-relevant settings changed. Clear+Refilter // changed. The Clear+Refilter cycle reloads messages from the DB,
// reloads from the DB and silently drops in-session messages that // which silently wipes any in-session message that wasn't
// weren't persisted (Privacy-First blocks most channels). Cosmetic // persisted (Privacy-First config blocks most channels from DB).
// changes (theme, icons, layout) skip the cycle. // Cosmetic changes (theme, tab icons, layout flags) trigger no
// refilter — chat history stays intact.
var filtersChanged = HasFilterRelevantChanges(); var filtersChanged = HasFilterRelevantChanges();
Plugin.Config.UpdateFrom(Mutable, true); Plugin.Config.UpdateFrom(Mutable, true);
// Defer save by 60 frames to avoid committing changes that cause a crash. // save after 60 frames have passed, which should hopefully not
// commit any changes that cause a crash
Plugin.DeferredSaveFrames = 60; Plugin.DeferredSaveFrames = 60;
if (filtersChanged) if (filtersChanged)
{ {
@@ -249,16 +259,24 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
GameFunctions.GameFunctions.SetChatInteractable(true); GameFunctions.GameFunctions.SetChatInteractable(true);
if (Plugin.Config.ShowEmotes) if (Plugin.Config.ShowEmotes)
_ = EmoteCache.LoadData(); _ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside
Initialise(); Initialise();
} }
// Returns true if any filter-relevant setting changed between Plugin.Config /// <summary>
// and the Mutable copy. Gates Clear+Refilter on Save so cosmetic changes /// v1.2.0 — Detects whether any setting that influences message
// don't wipe in-session chat history. /// filtering changed between Plugin.Config and the Mutable working
/// copy. Used to gate the heavy ClearAllTabs+FilterAllTabsAsync cycle
/// in Save: cosmetic changes (theme, tab icons, layout flags) do not
/// touch the chat log, only filter-relevant changes do. Without this
/// gate, every settings save wipes the chat history of any channel
/// the Privacy filter blocks from being persisted to the DB —
/// reported by Flo from in-game testing 2026-05-05/06.
/// </summary>
private bool HasFilterRelevantChanges() private bool HasFilterRelevantChanges()
{ {
// Top-level privacy controls.
if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled) if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled)
return true; return true;
if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels) if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels)
@@ -267,23 +285,27 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
return true; return true;
// FilterIncludePreviousSessions changes the GetMostRecentMessages // FilterIncludePreviousSessions changes the GetMostRecentMessages
// window and is filter-relevant even outside the Privacy block. // window in MessageManager.FilterAllTabs and is therefore filter-
// relevant even though it lives outside the Privacy block.
if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions) if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions)
return true; return true;
// Compare persistent tabs only -- TempTabs are never refiltered. // Per-tab channel selection. Compare persistent tabs only
// TempTabs are session-only and never refiltered anyway.
var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList(); var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList();
var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList(); var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList();
if (origPersistent.Count != newPersistent.Count) if (origPersistent.Count != newPersistent.Count)
return true; return true; // add or delete
for (var i = 0; i < origPersistent.Count; i++) for (var i = 0; i < origPersistent.Count; i++)
{ {
var orig = origPersistent[i]; var orig = origPersistent[i];
var neu = newPersistent[i]; var neu = newPersistent[i];
// Identifier mismatch means reorder or slot swap -- treat as filter-relevant. // Identifier mismatch at the same index means reorder or
// a slot got swapped — treat as filter-relevant so the new
// channel-selection layout actually applies.
if (orig.Identifier != neu.Identifier) if (orig.Identifier != neu.Identifier)
return true; return true;
@@ -292,6 +314,8 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels)) if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels))
return true; return true;
// SelectedChannels is a Dictionary<ChatType, (ChatSource, ChatSource)>
// — value-tuple equality already does the right thing per-pair.
if (orig.SelectedChannels.Count != neu.SelectedChannels.Count) if (orig.SelectedChannels.Count != neu.SelectedChannels.Count)
return true; return true;
foreach (var pair in orig.SelectedChannels) foreach (var pair in orig.SelectedChannels)
+69 -72
View File
@@ -11,60 +11,48 @@ internal sealed class SettingsOverview
{ {
private readonly SettingsWindow _window; private readonly SettingsWindow _window;
// Card order matches the Tabs index in SettingsWindow 1:1. // Card-Reihenfolge entspricht 1:1 dem Tabs-Index in SettingsWindow.
private static (FontAwesomeIcon Icon, string Title, string Subtext)[] BuildCardDefs() => // v1.2.1: Cards thematisch re-sortiert. Theme & Layout vereint Theme-
[ // Picker + Frame-Style + Timestamps; Fonts & Colours vereint Schriften
( // + Chat-Farben; Data Management vereint Storage + Retention + Cleanup
FontAwesomeIcon.SlidersH, // + Export + DB-Viewer + Advanced.
HellionStrings.Settings_Card_General_Title, private static readonly (FontAwesomeIcon Icon, string TitleKey, string SubtextKey)[] CardDefs =
HellionStrings.Settings_Card_General_Subtext [
), (FontAwesomeIcon.SlidersH, "Settings_Card_General_Title", "Settings_Card_General_Subtext"),
( (
FontAwesomeIcon.Palette, FontAwesomeIcon.Palette,
HellionStrings.Settings_Card_ThemeAndLayout_Title, "Settings_Card_ThemeAndLayout_Title",
HellionStrings.Settings_Card_ThemeAndLayout_Subtext "Settings_Card_ThemeAndLayout_Subtext"
), ),
( (
FontAwesomeIcon.Font, FontAwesomeIcon.Font,
HellionStrings.Settings_Card_FontsAndColours_Title, "Settings_Card_FontsAndColours_Title",
HellionStrings.Settings_Card_FontsAndColours_Subtext "Settings_Card_FontsAndColours_Subtext"
), ),
( (
FontAwesomeIcon.WindowMaximize, FontAwesomeIcon.WindowMaximize,
HellionStrings.Settings_Card_Window_Title, "Settings_Card_Window_Title",
HellionStrings.Settings_Card_Window_Subtext "Settings_Card_Window_Subtext"
), ),
( (FontAwesomeIcon.Comments, "Settings_Card_Chat_Title", "Settings_Card_Chat_Subtext"),
FontAwesomeIcon.Comments, (FontAwesomeIcon.FolderTree, "Settings_Card_Tabs_Title", "Settings_Card_Tabs_Subtext"),
HellionStrings.Settings_Card_Chat_Title, (FontAwesomeIcon.ShieldAlt, "Settings_Card_Privacy_Title", "Settings_Card_Privacy_Subtext"),
HellionStrings.Settings_Card_Chat_Subtext (
), FontAwesomeIcon.Database,
( "Settings_Card_DataManagement_Title",
FontAwesomeIcon.FolderTree, "Settings_Card_DataManagement_Subtext"
HellionStrings.Settings_Card_Tabs_Title, ),
HellionStrings.Settings_Card_Tabs_Subtext (
), FontAwesomeIcon.Plug,
( "Settings_Card_Integrations_Title",
FontAwesomeIcon.ShieldAlt, "Settings_Card_Integrations_Subtext"
HellionStrings.Settings_Card_Privacy_Title, ),
HellionStrings.Settings_Card_Privacy_Subtext (
), FontAwesomeIcon.InfoCircle,
( "Settings_Card_Information_Title",
FontAwesomeIcon.Database, "Settings_Card_Information_Subtext"
HellionStrings.Settings_Card_DataManagement_Title, ),
HellionStrings.Settings_Card_DataManagement_Subtext ];
),
(
FontAwesomeIcon.Plug,
HellionStrings.Settings_Card_Integrations_Title,
HellionStrings.Settings_Card_Integrations_Subtext
),
(
FontAwesomeIcon.InfoCircle,
HellionStrings.Settings_Card_Information_Title,
HellionStrings.Settings_Card_Information_Subtext
),
];
public SettingsOverview(SettingsWindow window) public SettingsOverview(SettingsWindow window)
{ {
@@ -76,18 +64,19 @@ internal sealed class SettingsOverview
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var columns = avail.X >= 700f ? 3 : 2; var columns = avail.X >= 700f ? 3 : 2;
var cardWidth = (avail.X - (columns - 1) * 8f) / columns; var cardWidth = (avail.X - (columns - 1) * 8f) / columns;
// 110f accommodates two-line subtexts; wrap width is matched in DrawCard. // v1.2.1 — Subtexte wrappen jetzt auf zwei Zeilen, daher 110f statt der
// v1.1.0-Höhe 96f. Wrap-Breite + Y-Position der Subtext-Zeile sind in
// DrawCard auf den Card-Innenrand abgestimmt.
var cardHeight = 110f; var cardHeight = 110f;
// One draw-list lookup per frame instead of one per card. for (var i = 0; i < CardDefs.Length; i++)
var drawList = ImGui.GetWindowDrawList();
var cardDefs = BuildCardDefs();
for (var i = 0; i < cardDefs.Length; i++)
{ {
var (icon, title, subtext) = cardDefs[i]; var (icon, titleKey, subtextKey) = CardDefs[i];
DrawCard(i, icon, title, subtext, cardWidth, cardHeight, drawList); var title = HellionStrings.ResourceManager.GetString(titleKey) ?? titleKey;
var subtext = HellionStrings.ResourceManager.GetString(subtextKey) ?? subtextKey;
DrawCard(i, icon, title, subtext, cardWidth, cardHeight);
if ((i + 1) % columns != 0 && i != cardDefs.Length - 1) if ((i + 1) % columns != 0 && i != CardDefs.Length - 1)
ImGui.SameLine(); ImGui.SameLine();
} }
} }
@@ -98,12 +87,12 @@ internal sealed class SettingsOverview
string title, string title,
string subtext, string subtext,
float w, float w,
float h, float h
ImDrawListPtr drawList
) )
{ {
// BeginGroup makes the card a single layout item so SameLine works // BeginGroup macht den Card-Bereich zu einem einzelnen ImGui-Layout-Item.
// in the caller loop -- without it ImGui tracks each child separately. // Damit funktioniert SameLine() im Caller-Loop — sonst tracked ImGui die
// einzelnen InvisibleButton/Text-Items separat und das Wrapping bricht.
ImGui.BeginGroup(); ImGui.BeginGroup();
var cursorBefore = ImGui.GetCursorScreenPos(); var cursorBefore = ImGui.GetCursorScreenPos();
@@ -111,8 +100,12 @@ internal sealed class SettingsOverview
var hovered = ImGui.IsItemHovered(); var hovered = ImGui.IsItemHovered();
var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u; var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u;
drawList.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f); var draw = ImGui.GetWindowDrawList();
draw.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f);
// Inhalts-Overlay: Icon + Title via DrawList (kein Wrap nötig). Subtext
// läuft über ImGui-Cursor + PushTextWrapPos damit der Text bei
// Card-Innenbreite umbricht statt rechts geclippt zu werden.
var iconPos = cursorBefore + new Vector2(16f, 12f); var iconPos = cursorBefore + new Vector2(16f, 12f);
var titlePos = cursorBefore + new Vector2(16f, 40f); var titlePos = cursorBefore + new Vector2(16f, 40f);
var subtextPos = cursorBefore + new Vector2(16f, 62f); var subtextPos = cursorBefore + new Vector2(16f, 62f);
@@ -122,15 +115,17 @@ internal sealed class SettingsOverview
using (_window.Plugin.FontManager.FontAwesome.Push()) using (_window.Plugin.FontManager.FontAwesome.Push())
{ {
drawList.AddText(iconPos, titleColor, icon.ToIconString()); draw.AddText(iconPos, titleColor, icon.ToIconString());
} }
drawList.AddText(titlePos, titleColor, title); draw.AddText(titlePos, titleColor, title);
// Subtext wraps at card inner width (16px padding each side) via DrawList // Subtext mit Wrap auf Card-Innenbreite (16 px Padding links + rechts).
// to avoid expanding the group bounds and breaking SameLine in the card row. // Cursor-basiertes TextUnformatted würde die ImGui-Group-Bounds
// erweitern und das SameLine-Wrapping in der Card-Reihe brechen, daher
// bleibt der Subtext bewusst beim DrawList-Overlay-Pattern.
var subtextWrapWidth = w - 32f; var subtextWrapWidth = w - 32f;
drawList.AddText( draw.AddText(
ImGui.GetFont(), ImGui.GetFont(),
ImGui.GetFontSize(), ImGui.GetFontSize(),
subtextPos, subtextPos,
@@ -142,6 +137,8 @@ internal sealed class SettingsOverview
ImGui.EndGroup(); ImGui.EndGroup();
if (clicked) if (clicked)
{
_window.OpenSection(index); _window.OpenSection(index);
}
} }
} }
+42 -9
View File
@@ -9,7 +9,10 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Four sections: Auto-Tell Tabs, Behaviour, Preview, Emotes. // Chat-Tab — vier eigenständige Sektionen: Auto-Tell-Tabs, Behaviour,
// Preview, Emotes. Der Emotes-Block ist 1:1 aus der Bestand-Datei
// Emote.cs übernommen; die Datei wird in Plan-Task 11 (Settings UX
// Polish v0.5.0) entfernt, sobald alle Tabs migriert sind.
internal sealed class Chat : ISettingsTab internal sealed class Chat : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -19,8 +22,9 @@ internal sealed class Chat : ISettingsTab
private SearchSelector.SelectorPopupOptions WordPopupOptions; private SearchSelector.SelectorPopupOptions WordPopupOptions;
// Tracks which EmoteCache state WordPopupOptions was built for so we // Snapshot of EmoteCache.State for which we last built WordPopupOptions.
// don't refill every frame when FilteredSheet is empty. // Without this, an empty FilteredSheet (e.g., the user blocked every emote)
// would trigger a refill every frame the settings tab is open.
private EmoteCache.LoadingState? WordPopupOptionsBuiltFor; private EmoteCache.LoadingState? WordPopupOptionsBuiltFor;
internal Chat(Plugin plugin, Configuration mutable) internal Chat(Plugin plugin, Configuration mutable)
@@ -32,13 +36,15 @@ internal sealed class Chat : ISettingsTab
WordPopupOptionsBuiltFor = EmoteCache.State; WordPopupOptionsBuiltFor = EmoteCache.State;
} }
private SearchSelector.SelectorPopupOptions RefillSheet() => private SearchSelector.SelectorPopupOptions RefillSheet()
new SearchSelector.SelectorPopupOptions {
return new SearchSelector.SelectorPopupOptions
{ {
FilteredSheet = EmoteCache FilteredSheet = EmoteCache
.SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w)) .SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w))
.ToArray(), .ToArray(),
}; };
}
public void Draw(bool changed) public void Draw(bool changed)
{ {
@@ -55,7 +61,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -68,7 +76,9 @@ internal sealed class Chat : ISettingsTab
ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale); ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale);
var limit = Mutable.AutoTellTabsLimit; var limit = Mutable.AutoTellTabsLimit;
if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50)) if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50))
{
Mutable.AutoTellTabsLimit = limit; Mutable.AutoTellTabsLimit = limit;
}
ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description); ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description);
ImGui.Checkbox( ImGui.Checkbox(
@@ -109,7 +119,9 @@ internal sealed class Chat : ISettingsTab
100 100
) )
) )
{
Mutable.AutoTellTabsHistoryPreload = preload; Mutable.AutoTellTabsHistoryPreload = preload;
}
ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description); ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description);
ImGui.Spacing(); ImGui.Spacing();
@@ -121,7 +133,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -146,7 +160,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -162,7 +178,9 @@ internal sealed class Chat : ISettingsTab
foreach (var position in Enum.GetValues<PreviewPosition>()) foreach (var position in Enum.GetValues<PreviewPosition>())
{ {
if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position)) if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position))
{
Mutable.PreviewPosition = position; Mutable.PreviewPosition = position;
}
} }
} }
} }
@@ -175,7 +193,9 @@ internal sealed class Chat : ISettingsTab
ref Mutable.PreviewMinimum ref Mutable.PreviewMinimum
) )
) )
{
Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250); Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250);
}
ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf); ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf);
ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description); ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description);
@@ -186,7 +206,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -211,13 +233,17 @@ internal sealed class Chat : ISettingsTab
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0)); ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0));
// OpenPopup on click because SelectorPopup uses ContextPopupItem // Open the selector popup on left-click; SelectorPopup uses
// which only triggers on right-click by default. // ImRaii.ContextPopupItem internally which only opens on right-
// click otherwise — without this OpenPopup the button looked
// active but the popup never appeared on a normal click.
if (ImGui.IsItemClicked()) if (ImGui.IsItemClicked())
ImGui.OpenPopup("WordAddPopup"); ImGui.OpenPopup("WordAddPopup");
if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions)) if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions))
{
Mutable.BlockedEmotes.Add(newWord); Mutable.BlockedEmotes.Add(newWord);
}
using ( using (
var table = ImRaii.Table( var table = ImRaii.Table(
@@ -231,9 +257,11 @@ internal sealed class Chat : ISettingsTab
{ {
ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable); ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable);
ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f); ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f);
ImGui.TableHeadersRow(); ImGui.TableHeadersRow();
foreach (var word in Mutable.BlockedEmotes.ToArray()) var copiedList = Mutable.BlockedEmotes.ToArray();
foreach (var word in copiedList)
{ {
ImGui.TableNextColumn(); ImGui.TableNextColumn();
ImGui.TextUnformatted(word); ImGui.TextUnformatted(word);
@@ -246,7 +274,9 @@ internal sealed class Chat : ISettingsTab
!ImGui.GetIO().KeyCtrl !ImGui.GetIO().KeyCtrl
) )
) )
{
Mutable.BlockedEmotes.Remove(word); Mutable.BlockedEmotes.Remove(word);
}
} }
} }
} }
@@ -259,14 +289,17 @@ internal sealed class Chat : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
if (EmoteCache.State is EmoteCache.LoadingState.Done) if (EmoteCache.State is EmoteCache.LoadingState.Done)
{
ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready); ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready);
}
else else
{
ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady); ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady);
}
ImGui.TextUnformatted( ImGui.TextUnformatted(
$"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}" $"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}"
); );
using ( using (
var emoteTable = ImRaii.Table( var emoteTable = ImRaii.Table(
"##LoadedEmotes", "##LoadedEmotes",
+6 -4
View File
@@ -8,7 +8,9 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Combines the former About and Changelog tabs into three collapsible sections. // Information-Tab vereint die früheren About- und Changelog-Tabs in
// drei kollabierbaren Sektionen. Der About-Inhalt ist 1:1 aus About.cs
// übernommen, die Changelog-Render-Logik aus Changelog.cs.
internal sealed class Information : ISettingsTab internal sealed class Information : ISettingsTab
{ {
private Configuration Mutable { get; } private Configuration Mutable { get; }
@@ -97,7 +99,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(Language.Options_About_Github_Issues); ImGui.TextUnformatted(Language.Options_About_Github_Issues);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues"))
Plugin.PlatformUtil.OpenLink( Dalamud.Utility.Util.OpenLink(
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues" "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues"
); );
} }
@@ -116,7 +118,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label); ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia"))
Plugin.PlatformUtil.OpenLink("https://hellion-media.de"); Dalamud.Utility.Util.OpenLink("https://hellion-media.de");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
@@ -137,7 +139,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label); ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream"))
Plugin.PlatformUtil.OpenLink("https://github.com/Infiziert90/ChatTwo"); Dalamud.Utility.Util.OpenLink("https://github.com/Infiziert90/ChatTwo");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
+19 -12
View File
@@ -8,8 +8,9 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Added in v1.3.0. Each future integration cycle adds a section above // First settings tab introduced in v1.3.0 (Plugin Integrations Cycle 1).
// the "Coming soon" block and removes its stub item. // Designed to grow organically: each future cycle adds a new section above
// the "Coming soon" block and removes the corresponding stub item.
internal sealed class Integrations : ISettingsTab internal sealed class Integrations : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -47,9 +48,11 @@ internal sealed class Integrations : ISettingsTab
DrawHonorificStatus(); DrawHonorificStatus();
ImGui.Spacing(); ImGui.Spacing();
// Toggle works regardless of detection state: "show when available, // The toggle is enabled regardless of detection state — leaving it
// hide otherwise". Disabling it when Honorific is missing would force // on means "render when available, hide otherwise". Disabling the
// the user to retoggle on every reload. // toggle when Honorific is missing would force the user to retoggle
// it every time Honorific is reloaded, which is worse UX than the
// silent auto-hide.
if ( if (
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Integrations_Honorific_Toggle, HellionStrings.Settings_Integrations_Honorific_Toggle,
@@ -73,18 +76,20 @@ internal sealed class Integrations : ISettingsTab
} }
} }
// Honorific has no LICENSE in its repo so we link upstream and author // Maintainer attribution. Honorific has no LICENSE in its repo so we
// instead of bundling assets. Text labels because FA Brands isn't // can't bundle its assets, but linking to the upstream and the
// guaranteed in Dalamud's font set. // author's profile is the polite minimum. Plain ImGui buttons keep
// the visual weight modest, the FontAwesome Brands subset is not
// guaranteed in Dalamud's font set so we use text labels.
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo))
{ {
Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificRepo); Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificRepo);
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor))
{ {
Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificAuthor); Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificAuthor);
} }
} }
@@ -142,7 +147,9 @@ internal sealed class Integrations : ISettingsTab
ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro); ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro);
ImGui.Spacing(); ImGui.Spacing();
// Each integration cycle removes its stub here and adds a full section above. // Static list maintained in code (not Configuration). Each cycle
// that lands a real integration removes its stub here and adds a
// full section above the Coming Soon block.
DrawComingSoonItem( DrawComingSoonItem(
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title, HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title,
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description
@@ -193,7 +200,7 @@ internal sealed class Integrations : ISettingsTab
if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel)) if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel))
{ {
Plugin.PlatformUtil.OpenLink(BrandingLinks.HellionForgeDiscordInvite); Dalamud.Utility.Util.OpenLink(BrandingLinks.HellionForgeDiscordInvite);
} }
} }
+2 -1
View File
@@ -20,7 +20,8 @@ internal sealed class Privacy : ISettingsTab
Mutable = mutable; Mutable = mutable;
} }
// (HeadingKey, ChatType list). Heading resolved per-frame for live language switching. // (HeadingKey lookup, ChatType list). Heading is resolved per-frame so
// a runtime LanguageChanged call updates the labels immediately.
private static readonly (Func<string> Heading, ChatType[] Types)[] Groups = private static readonly (Func<string> Heading, ChatType[] Types)[] Groups =
[ [
( (
+7 -5
View File
@@ -123,7 +123,7 @@ internal sealed class Tabs : ISettingsTab
ImGuiInputTextFlags.EnterReturnsTrue ImGuiInputTextFlags.EnterReturnsTrue
); );
// Per-tab icon override added in v1.2.0. Falls back to default mapping if unset. // v1.2.0 — Per-Tab Icon-Override. Default-Mapping greift falls nichts gesetzt.
ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label); ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label);
ImGui.SameLine(); ImGui.SameLine();
ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker); ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker);
@@ -135,7 +135,7 @@ internal sealed class Tabs : ISettingsTab
{ {
if (combo.Success) if (combo.Success)
{ {
// First option clears the icon and lets the default mapping take over. // Erste Option: Default (löscht Icon, lässt Mapping greifen).
if ( if (
ImGui.Selectable( ImGui.Selectable(
HellionStrings.Tabs_Icon_DefaultOption, HellionStrings.Tabs_Icon_DefaultOption,
@@ -148,7 +148,7 @@ internal sealed class Tabs : ISettingsTab
ImGui.Separator(); ImGui.Separator();
// Options sourced from TabIconGlyphResolver.PickerOptions (single source of truth). // Pool-Optionen aus TabIconGlyphResolver.PickerOptions (Single-Source-of-Truth).
foreach (var option in TabIconGlyphResolver.PickerOptions) foreach (var option in TabIconGlyphResolver.PickerOptions)
{ {
var isSelected = string.Equals( var isSelected = string.Equals(
@@ -305,8 +305,10 @@ internal sealed class Tabs : ISettingsTab
ImGui.SameLine(); ImGui.SameLine();
// Guard against an empty worlds list (character switch or sheet not yet populated) // Guard against an empty worlds list — can happen briefly
// to avoid an out-of-bounds crash on worlds[selectedWorld]. // when switching characters or if the datacenter sheet
// has not yet populated. Without the guard the indexed
// access into worlds[selectedWorld] would crash.
if (worlds.Count == 0) if (worlds.Count == 0)
{ {
ImGui.TextDisabled("(no worlds available)"); ImGui.TextDisabled("(no worlds available)");
+36 -17
View File
@@ -43,9 +43,9 @@ internal sealed class ThemeAndLayout : ISettingsTab
var registry = Plugin.ThemeRegistry; var registry = Plugin.ThemeRegistry;
var active = registry.Get(Mutable.Theme); var active = registry.Get(Mutable.Theme);
ImGui.TextUnformatted( var activeLabelTemplate =
string.Format(HellionStrings.Settings_Themes_Active, active.Name) HellionStrings.ResourceManager.GetString("Settings_Themes_Active") ?? "Active: {0}";
); ImGui.TextUnformatted(string.Format(activeLabelTemplate, active.Name));
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u))
ImGui.TextUnformatted(active.Author); ImGui.TextUnformatted(active.Author);
@@ -55,7 +55,10 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.Settings_Themes_BuiltIns); var builtInsLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_BuiltIns")
?? "Built-in themes";
ImGui.TextUnformatted(builtInsLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(registry.AllBuiltIns(), active.Slug); DrawThemeGrid(registry.AllBuiltIns(), active.Slug);
@@ -65,7 +68,10 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.Settings_Themes_Custom); var customLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_Custom")
?? "Custom themes";
ImGui.TextUnformatted(customLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(customs, active.Slug); DrawThemeGrid(customs, active.Slug);
} }
@@ -74,15 +80,21 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Button(HellionStrings.Settings_Themes_OpenFolder)) var openFolderLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_OpenFolder")
?? "Open themes folder";
if (ImGui.Button(openFolderLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
Plugin.PlatformUtil.OpenLink(dir); Dalamud.Utility.Util.OpenLink(dir);
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Themes_ExportActive)) var exportLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ExportActive")
?? "Export active...";
if (ImGui.Button(exportLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
@@ -194,19 +206,25 @@ internal sealed class ThemeAndLayout : ISettingsTab
draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f); draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f);
draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f); draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f);
var hint =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Hint")
?? "This theme suggests its own chat channel colours.";
var applyLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Apply")
?? "Apply";
var keepLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Keep")
?? "Keep current";
var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary); var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary);
draw.AddText( draw.AddText(origin + new Vector2(12f, 10f), textColor, hint);
origin + new Vector2(12f, 10f),
textColor,
HellionStrings.Settings_Themes_ApplyChatColors_Hint
);
using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary)) using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark))
{ {
ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f)); ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f));
if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Apply)) if (ImGui.Button(applyLabel))
{ {
foreach (var kvp in themeChatColors.Channels) foreach (var kvp in themeChatColors.Channels)
Mutable.ChatColours[kvp.Key] = kvp.Value; Mutable.ChatColours[kvp.Key] = kvp.Value;
@@ -215,7 +233,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Keep)) if (ImGui.Button(keepLabel))
{ {
_applyDismissedFor = active.Slug; _applyDismissedFor = active.Slug;
} }
@@ -254,8 +272,9 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Slider range 50-100% maps to 0.5-1.0 internally. Floor at 50% prevents // Slider 50100 % UX-Range; intern 0.51.0 als WindowOpacity-Float.
// accidentally hiding the chat background (v1.2.0 bug at WindowAlpha=0). // Untere Schwelle 50 % verhindert versehentliches Komplett-Wegblenden
// des Chat-Hintergrunds (war v1.2.0 Bug bei WindowAlpha=0).
var opacityPercent = Mutable.WindowOpacity * 100f; var opacityPercent = Mutable.WindowOpacity * 100f;
if ( if (
ImGuiUtil.DragFloatVertical( ImGuiUtil.DragFloatVertical(
+10 -9
View File
@@ -7,14 +7,15 @@ namespace HellionChat.Ui.SettingsTabs;
internal static class ThemeMockup internal static class ThemeMockup
{ {
// Mini chat window mockup drawn directly into the WindowDrawList. // Zeichnet ein Mini-Chat-Window-Mockup mit den Theme-Werten direkt
// No textures, no per-frame allocations — pure AddRectFilled/AddText. // ins WindowDrawList. Keine Texture, keine Allocation pro Frame —
// alles via DrawList.AddRectFilled / AddText.
public static void Draw(Vector2 origin, Vector2 size, Theme theme) public static void Draw(Vector2 origin, Vector2 size, Theme theme)
{ {
var draw = ImGui.GetWindowDrawList(); var draw = ImGui.GetWindowDrawList();
var c = theme.Colors; var c = theme.Colors;
// Window background // Window-Bg
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
origin + size, origin + size,
@@ -22,7 +23,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Title bar // Title-Bar
var titleHeight = 14f; var titleHeight = 14f;
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
@@ -31,7 +32,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Tab bar (3 tabs) // Tab-Bar — 3 Mini-Tabs
var tabY = origin.Y + titleHeight + 4f; var tabY = origin.Y + titleHeight + 4f;
var tabHeight = 12f; var tabHeight = 12f;
for (var i = 0; i < 3; i++) for (var i = 0; i < 3; i++)
@@ -45,7 +46,7 @@ internal static class ThemeMockup
theme.Layout.TabRounding theme.Layout.TabRounding
); );
if (i == 0) // active pill if (i == 0) // Active-Pill
{ {
draw.AddRectFilled( draw.AddRectFilled(
new Vector2(tabX, tabY + tabHeight - 2f), new Vector2(tabX, tabY + tabHeight - 2f),
@@ -55,7 +56,7 @@ internal static class ThemeMockup
} }
} }
// Message card row // Card-Row mit Mock-Sender + Text
var rowY = tabY + tabHeight + 6f; var rowY = tabY + tabHeight + 6f;
var rowHeight = 18f; var rowHeight = 18f;
draw.AddRectFilled( draw.AddRectFilled(
@@ -65,7 +66,7 @@ internal static class ThemeMockup
2f 2f
); );
// Accent button (bottom right) // Akzent-Button rechts unten
var btnW = 28f; var btnW = 28f;
var btnH = 10f; var btnH = 10f;
var btnX = origin.X + size.X - btnW - 6f; var btnX = origin.X + size.X - btnW - 6f;
@@ -77,7 +78,7 @@ internal static class ThemeMockup
theme.Layout.FrameRounding theme.Layout.FrameRounding
); );
// Mockup border // Border um das gesamte Mockup
draw.AddRect( draw.AddRect(
origin, origin,
origin + size, origin + size,
+5 -2
View File
@@ -107,7 +107,7 @@ internal sealed class Window : ISettingsTab
1, 1,
10 10
); );
// Floor at 2 seconds to prevent self-soft-lock. // Untergrenze von 2 Sekunden gegen Selbst-Soft-Lock.
Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout); Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout);
using (ImRaii.Disabled(Mutable.HideInBattle)) using (ImRaii.Disabled(Mutable.HideInBattle))
@@ -177,6 +177,7 @@ internal sealed class Window : ISettingsTab
ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove); ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove);
ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize); ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize);
// v0.6.0 — global master switch for the pop-out input bar.
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Window_PopOutInputEnabled_Name, HellionStrings.Settings_Window_PopOutInputEnabled_Name,
ref Mutable.PopOutInputEnabled ref Mutable.PopOutInputEnabled
@@ -185,7 +186,9 @@ internal sealed class Window : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
// Fallback for off-screen windows after a display layout change. // Manual escape hatch for off-screen windows. The plugin already
// runs an automatic bounds check once per session, but a button
// is the user-friendly fallback after a display layout change.
if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name)) if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name))
Plugin.ChatLogWindow.RequestPositionReset = true; Plugin.ChatLogWindow.RequestPositionReset = true;
ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description); ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description);
+41 -25
View File
@@ -9,23 +9,32 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Bottom status bar, 22px tall. Slots left to right: channel indicator, /// <summary>
// privacy badge, counts, tells (hidden at 0), version (right-aligned). /// Bottom-Status-Bar (v1.2.0). Fix 22 px hoch, BorderTop als Trenner.
// Updates at 1Hz; format strings are cached between updates. /// Slots links → rechts: Channel-Indicator (Color-Dot + Channel-Name),
/// Privacy-Badge (Lock-Icon + Privacy-Label), Counts (Tabs + Msgs),
/// Tells (Auto-Tell-Counter, hidden bei 0), Version (rechtsbündig, muted).
///
/// Update-Frequenz: 1×/Sekunde. Format-Strings werden zwischen Updates
/// gecached, damit kein Per-Frame-Format-Allocation entsteht.
/// </summary>
internal sealed class StatusBar internal sealed class StatusBar
{ {
public const float Height = 22f; public const float Height = 22f;
private const long UpdateIntervalMs = 1000; private const long UpdateIntervalMs = 1000;
// Initially outdated so the first frame always computes fresh. // Cache-State — initial outdated, damit der erste Frame frisch berechnet.
private long _lastUpdateMs = -UpdateIntervalMs; private long _lastUpdateMs = -UpdateIntervalMs;
private string _cachedCountsText = string.Empty; private string _cachedCountsText = string.Empty;
private string _cachedTellsText = string.Empty; private string _cachedTellsText = string.Empty;
// Pure string logic, testable without ImGui init. /// <summary>
/// Reine String-Logik — testbar ohne ImGui-Init.
/// </summary>
public static string FormatCounts(int tabs, int messages) public static string FormatCounts(int tabs, int messages)
{ {
// InvariantCulture so locale doesn't affect the format (e.g. de_DE "1,2k"). // InvariantCulture: User-System-Locale darf das Format nicht
// verändern (de_DE würde sonst "1,2k" statt "1.2k" liefern).
var msgPart = var msgPart =
messages >= 1000 messages >= 1000
? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0) ? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0)
@@ -34,7 +43,10 @@ internal sealed class StatusBar
return $"{tabsPart} · {msgPart}"; return $"{tabsPart} · {msgPart}";
} }
// Pure string logic, testable without ImGui init. Returns empty string at 0 tells. /// <summary>
/// Reine String-Logik — testbar ohne ImGui-Init.
/// 0 Tells → Leerstring (Slot wird ausgeblendet).
/// </summary>
public static string FormatTells(int count) public static string FormatTells(int count)
{ {
if (count <= 0) if (count <= 0)
@@ -42,7 +54,8 @@ internal sealed class StatusBar
return $"{count} {(count == 1 ? "tell" : "tells")}"; return $"{count} {(count == 1 ? "tell" : "tells")}";
} }
// Single-pass replacement for a LINQ Sum+Count pair. Pure helper for unit testing. // Single-pass replacement for the LINQ Sum+Count pair in Draw. Pure
// helper so a future LINQ regression gets pinned by xUnit.
internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs) internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs)
{ {
int messages = 0, int messages = 0,
@@ -56,7 +69,10 @@ internal sealed class StatusBar
return (messages, tells); return (messages, tells);
} }
// Test hook to verify cache logic without a real time source. /// <summary>
/// Test-Hook: Cache-Logic ohne reale Time-Source verifizieren.
/// Nicht für Production-Render.
/// </summary>
internal (string counts, string tells) SnapshotForTest( internal (string counts, string tells) SnapshotForTest(
long now, long now,
int tabs, int tabs,
@@ -77,18 +93,24 @@ internal sealed class StatusBar
_lastUpdateMs = now; _lastUpdateMs = now;
} }
/// <summary>
/// Render-Pfad. Aufrufer pusht bereits den HellionStyle/Theme;
/// wir lesen nur die aktiven Theme-Farben und zeichnen.
/// </summary>
public void Draw(Plugin plugin) public void Draw(Plugin plugin)
{ {
var theme = plugin.ThemeRegistry.Active; var theme = plugin.ThemeRegistry.Active;
var now = Environment.TickCount64; var now = Environment.TickCount64;
// Outer gate keeps the foreach out of the hot path 99% of frames.
// UpdateCacheIfDue runs the same check internally — idempotent.
if (now - _lastUpdateMs >= UpdateIntervalMs) if (now - _lastUpdateMs >= UpdateIntervalMs)
{ {
var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs); var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs);
UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells); UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells);
} }
// Border top via DrawList -- ImGui.Separator has too much padding. // BorderTop als Trenner — DrawList-Line, ImGui-Separator hat zu viel Padding.
var cursorY = ImGui.GetCursorScreenPos().Y; var cursorY = ImGui.GetCursorScreenPos().Y;
var winLeft = ImGui.GetWindowPos().X; var winLeft = ImGui.GetWindowPos().X;
var winRight = winLeft + ImGui.GetWindowSize().X; var winRight = winLeft + ImGui.GetWindowSize().X;
@@ -101,9 +123,9 @@ internal sealed class StatusBar
1f 1f
); );
ImGui.Dummy(new Vector2(0, 2)); ImGui.Dummy(new Vector2(0, 2)); // BorderTop-Spacing
// Slot 1: active channel indicator // Slot 1: Active-Channel-Indicator
var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid; var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid;
var hasChannel = inputCh != InputChannel.Invalid; var hasChannel = inputCh != InputChannel.Invalid;
var chatType = inputCh.ToChatType(); var chatType = inputCh.ToChatType();
@@ -115,7 +137,7 @@ internal sealed class StatusBar
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(channelName); ImGui.TextUnformatted(channelName);
// Slot 2: privacy badge // Slot 2: Privacy-Badge — abgeleitet aus PrivacyFilterEnabled.
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
@@ -129,13 +151,13 @@ internal sealed class StatusBar
: HellionStrings.StatusBar_Privacy_Open; : HellionStrings.StatusBar_Privacy_Open;
ImGui.TextUnformatted(privacyLabel); ImGui.TextUnformatted(privacyLabel);
// Slot 3: counts // Slot 3: Counts
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(_cachedCountsText); ImGui.TextUnformatted(_cachedCountsText);
// Slot 4: tells (hidden at 0) // Slot 4: Tells (nur wenn > 0)
if (!string.IsNullOrEmpty(_cachedTellsText)) if (!string.IsNullOrEmpty(_cachedTellsText))
{ {
ImGui.SameLine(); ImGui.SameLine();
@@ -144,20 +166,14 @@ internal sealed class StatusBar
ImGui.TextUnformatted(_cachedTellsText); ImGui.TextUnformatted(_cachedTellsText);
} }
// Slot 5: version, right-aligned, muted. Hidden when the window is // Slot 5: Version (rechtsbündig, muted)
// too narrow to fit all five slots — the other four need ~200 px
// before the version text starts clipping into them.
var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion"; var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion";
var versionWidth = ImGui.CalcTextSize(versionText).X; var versionWidth = ImGui.CalcTextSize(versionText).X;
var contentRegionMax = ImGui.GetContentRegionMax().X; var contentRegionMax = ImGui.GetContentRegionMax().X;
const float MinOtherSlotsWidth = 200f; ImGui.SameLine(contentRegionMax - versionWidth);
if (contentRegionMax - versionWidth > MinOtherSlotsWidth) using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
{ {
ImGui.SameLine(contentRegionMax - versionWidth); ImGui.TextUnformatted(versionText);
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
{
ImGui.TextUnformatted(versionText);
}
} }
} }
+36 -11
View File
@@ -1,11 +1,22 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Pure string resolver logic with no Dalamud dependency, kept in its own /// <summary>
// file so tests (HellionChat.Tests, no Dalamud reference) can call it directly. /// Reine String-Resolver-Logik ohne Dalamud-Dependency. Bewusst in
// Used in the settings UI glyph picker and indirectly via TabIconMapping.Resolve. /// eigener Datei (Dependency-Boundary auf File-Level sichtbar), damit
/// Tests (HellionChat.Tests, Microsoft.NET.Sdk ohne Dalamud-Reference)
/// sie aufrufen können, ohne dass die JIT beim Methodenaufruf die
/// Dalamud-Assembly laden muss.
///
/// Wird im Settings-UI (T7) für die Glyph-Picker-Combobox und im
/// Render-Code indirekt über <see cref="TabIconMapping.Resolve(Tab)"/>
/// verwendet.
/// </summary>
internal static class TabIconGlyphResolver internal static class TabIconGlyphResolver
{ {
// Single source of truth for the glyph set; order matches the settings combobox. /// <summary>
/// Picker-Options-Pool — Single Source of Truth für das Glyph-Set.
/// Reihenfolge ist die UI-Reihenfolge im Settings-Tab Icon-Combobox.
/// </summary>
public static readonly IReadOnlyList<string> PickerOptions = public static readonly IReadOnlyList<string> PickerOptions =
[ [
"comment", "comment",
@@ -25,13 +36,20 @@ internal static class TabIconGlyphResolver
"fire", "fire",
]; ];
// Derived from PickerOptions -- never maintain this manually. /// <summary>
/// Glyph-Set, das überhaupt als Override akzeptiert wird. Aus
/// <see cref="PickerOptions"/> abgeleitet — KnownGlyphs nie
/// manuell pflegen.
/// </summary>
private static readonly HashSet<string> KnownGlyphs = new( private static readonly HashSet<string> KnownGlyphs = new(
PickerOptions, PickerOptions,
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
); );
// Tab.Name is localised, so we match against a pool of DE/EN synonyms. /// <summary>
/// Tab-Name → Default-Glyph-Name. Tab.Name wird per Lokalisierung
/// gesetzt; wir matchen daher gegen einen Pool aus DE/EN-Synonymen.
/// </summary>
private static readonly Dictionary<string, string> NameDefaults = new( private static readonly Dictionary<string, string> NameDefaults = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -51,11 +69,18 @@ internal static class TabIconGlyphResolver
["tell"] = "envelope", ["tell"] = "envelope",
}; };
// Resolves the glyph name for a tab. Priority order: /// <summary>
// 1. Tab.Icon override (if set): known glyph -> use it, unknown -> "hashtag" /// Test-Surface: Glyph-Name-Resolver ohne Dalamud-Dependency.
// 2. Auto-tell tab -> autoTellGlyph if provided, else "clock" /// Reihenfolge:
// 3. Name default lookup /// 1. Tab.Icon-Override (falls gesetzt und nicht nur Whitespace):
// 4. Fallback "hashtag" /// a) bekannter Glyph → diesen Glyph
/// b) unbekannter Glyph → harter Fallback "hashtag" (User hat
/// bewusst etwas gesetzt, also überstimmt das die Defaults)
/// 2. Auto-Tell-Tab → <paramref name="autoTellGlyph"/> falls
/// übergeben, sonst "clock".
/// 3. Tab-Name-Default (<see cref="NameDefaults"/>-Lookup)
/// 4. Fallback "hashtag"
/// </summary>
public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null) public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null)
{ {
if (!string.IsNullOrWhiteSpace(tab.Icon)) if (!string.IsNullOrWhiteSpace(tab.Icon))
+35 -8
View File
@@ -2,14 +2,31 @@ using Dalamud.Interface;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Default icon mapping for tabs, used in top-tabs (icon prefix) and sidebar (icon-only with tooltip). /// <summary>
// Users can override per tab via Settings -> Tabs -> Tab.Icon. /// Default-Icon-Mapping für Tabs. v1.2.0 Layout-Refresh nutzt das
// Pure string resolver logic lives in TabIconGlyphResolver (no Dalamud dependency) for testability. /// in Top-Tabs (Icon-Prefix) und Sidebar (Icon-only mit Tooltip).
/// User können in Settings → Tabs per Tab.Icon-Override eigene
/// FontAwesome-Glyphen setzen.
///
/// Diese Klasse ist Dalamud-abhängig (FontAwesomeIcon-Enum). Die
/// reine String-Resolver-Logik liegt bewusst in
/// <see cref="TabIconGlyphResolver"/> (eigene Datei, ohne
/// Dalamud-Imports), damit Tests sie ohne Dalamud-Reference aufrufen
/// können.
/// </summary>
internal static class TabIconMapping internal static class TabIconMapping
{ {
// Glyph name -> FontAwesomeIcon lookup for production resolve. /// <summary>
// Every key must also exist in TabIconGlyphResolver.PickerOptions. /// FontAwesome-Glyph-Name → Icon-Enum-Lookup. Wird für die
// A missing key silently falls back to FontAwesomeIcon.Hashtag (degraded, no crash). /// Production-Resolve-API benötigt.
///
/// INVARIANTE: Jeder Key in <see cref="GlyphLookup"/> muss auch in
/// <see cref="TabIconGlyphResolver.PickerOptions"/> stehen. Wird
/// ein Glyph zu PickerOptions hinzugefügt, aber nicht hier, fällt
/// die Override-Auflösung still auf <see cref="FontAwesomeIcon.Hashtag"/>
/// zurück (degraded, kein Crash). Build-Time-Enforcement ist nicht
/// möglich, weil PickerOptions ohne Dalamud-Reference auskommt.
/// </summary>
private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new( private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -31,13 +48,23 @@ internal static class TabIconMapping
["fire"] = FontAwesomeIcon.Fire, ["fire"] = FontAwesomeIcon.Fire,
}; };
// Resolves the icon for a tab. Auto-tell tabs get a per-partner hashed icon /// <summary>
// from the tell pool so parallel tells differ by glyph shape, not just colour. /// Production-Surface: liefert das Icon für einen Tab. Wrapper um
/// <see cref="TabIconGlyphResolver.ResolveGlyphName(Tab)"/> plus
/// Enum-Lookup. Wird von Render-Code (T3, T5) verwendet.
/// </summary>
public static FontAwesomeIcon Resolve(Tab tab) public static FontAwesomeIcon Resolve(Tab tab)
{ {
// v1.2.0 — Auto-Tell-Tabs bekommen ein per-Partner gehashtes
// Icon aus dem Tell-Pool. Damit unterscheiden sich parallele
// Tells nicht nur über die Color (For), sondern auch über die
// Glyph-Form. Berechnung bleibt hier (Dalamud-bound), weil
// TellTarget Dalamud-Imports hat.
string? autoTellGlyph = null; string? autoTellGlyph = null;
if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet()) if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet())
{
autoTellGlyph = TabTintCache.GetIcon(tab); autoTellGlyph = TabTintCache.GetIcon(tab);
}
var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph); var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph);
return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag; return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag;
+28 -19
View File
@@ -17,9 +17,10 @@ internal static class AutoTranslate
private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new(); private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new();
private static readonly HashSet<(uint, uint)> ValidEntries = []; private static readonly HashSet<(uint, uint)> ValidEntries = [];
// Serialises all reads/writes against Entries and ValidEntries. // Serializes all reads and writes against Entries / ValidEntries.
// PreloadCache fills both from a worker thread while the main thread // PreloadCache spawns a worker thread that fills both, while the main
// reads via Matching/ReplaceWithPayload/StartsWithCommand. // thread reads them via Matching / ReplaceWithPayload / StartsWithCommand
// — without this lock the HashSet/Dictionary access is undefined.
private static readonly object EntriesLock = new(); private static readonly object EntriesLock = new();
private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser() private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser()
@@ -53,22 +54,21 @@ internal static class AutoTranslate
return Map((name, sel) => (name, sel), sheetName, selector.Optional()); return Map((name, sel) => (name, sel), sheetName, selector.Optional());
} }
// Warms the auto-translate cache on a background thread so the first /// <summary>
// message send doesn't hitch the main thread. IsBackground keeps plugin /// Preloads auto-translate entries into the cache for the current game
// unload non-blocking even if the warmup is still in flight. /// language. Without this, the first message will take a long time to send
/// (which causes a hitch in the main thread).
///
/// This spawns a new thread.
/// </summary>
internal static void PreloadCache() internal static void PreloadCache()
{ {
var thread = new Thread(() => new Thread(() =>
{ {
var sw = Stopwatch.StartNew(); var sw = Stopwatch.StartNew();
AllEntries(); AllEntries();
Plugin.Log.Debug($"Warming up auto-translate took {sw.ElapsedMilliseconds}ms"); Plugin.Log.Debug($"Warming up auto-translate took {sw.ElapsedMilliseconds}ms");
}) }).Start();
{
IsBackground = true,
Name = "HellionChat-AutoTranslate-Warmup",
};
thread.Start();
} }
private static List<AutoTranslateEntry> AllEntries() private static List<AutoTranslateEntry> AllEntries()
@@ -104,7 +104,7 @@ internal static class AutoTranslate
{ {
if (lookup is not ("" or "@")) if (lookup is not ("" or "@"))
{ {
// SE added whitespace to newer entries; strip it before parsing. // SE added whitespace to the newest additions, but ParseOrThrow doesn't see them as valid
lookup = lookup.Replace(" ", ""); lookup = lookup.Replace(" ", "");
var (sheetName, selector) = parser.ParseOrThrow(lookup); var (sheetName, selector) = parser.ParseOrThrow(lookup);
@@ -144,13 +144,19 @@ internal static class AutoTranslate
columns.Add(0); columns.Add(0);
if (rows.Count == 0) if (rows.Count == 0)
// Can't use index-from-end here because we iterate over integers, // We can't use an "index from end" (like `^0`) here because
// not an array directly. `0..^0` would silently skip the sheet. // we're iterating over integers, not an array directly.
// Previously, we were setting `0..^0` which caused these
// sheets to be completely skipped due to this bug.
// See below.
rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1)); rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1));
foreach (var range in rows) foreach (var range in rows)
{ {
// Integer iteration -- can't use index-from-end (see above). // We iterate over the range by numerical values here, so
// we can't use an "index from end" otherwise nothing will
// happen.
// See above.
for (var i = range.Start.Value; i < range.End.Value; i++) for (var i = range.Start.Value; i < range.End.Value; i++)
{ {
if (!sheet.TryGetRow((uint)i, out var rowParser)) if (!sheet.TryGetRow((uint)i, out var rowParser))
@@ -255,6 +261,7 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return; return;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
@@ -301,8 +308,9 @@ internal static class AutoTranslate
start = -1; start = -1;
} }
// Span comparison avoids the msvcrt.dll P/Invoke which is fragile // Pure managed comparison via Span avoids the msvcrt.dll P/Invoke,
// under Wine and caused an extra managed-to-unmanaged copy per check. // which is fragile under Wine and triggered an extra managed-to-
// unmanaged copy per check.
if ( if (
i + search.Length < bytes.Length i + search.Length < bytes.Length
&& bytes.AsSpan(i, search.Length).SequenceEqual(search) && bytes.AsSpan(i, search.Length).SequenceEqual(search)
@@ -317,6 +325,7 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return false; return false;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
-16
View File
@@ -1,16 +0,0 @@
namespace HellionChat.Util;
internal sealed class DalamudPlatformUtil : IPlatformUtil
{
public DalamudPlatformUtil()
{
// Util.IsWine probes the host process and never changes for the
// lifetime of a plugin instance, so we cache it once at ctor.
// Mirrors LightlessSync/Services/DalamudUtilService:154.
IsWine = Dalamud.Utility.Util.IsWine();
}
public bool IsWine { get; }
public void OpenLink(string url) => Dalamud.Utility.Util.OpenLink(url);
}
+9 -3
View File
@@ -10,8 +10,9 @@ public static class GlobalParametersCache
public static int GetValue(int index) public static int GetValue(int index)
{ {
// Capture the array reference once so bounds check and read operate // Capture the array reference once so the bounds check and the
// on the same instance if Refresh reassigns Cache between the two. // indexed read operate on the same instance, even if Refresh
// reassigns Cache between the two operations.
var cache = Cache; var cache = Cache;
if (index < 0 || index >= cache.Length) if (index < 0 || index >= cache.Length)
return 0; return 0;
@@ -19,7 +20,12 @@ public static class GlobalParametersCache
return cache[index]; return cache[index];
} }
// Refreshes the cache from RaptureTextModule. Must be called on the main thread. /// <summary>
/// Refresh the cache of global parameters from RaptureTextModule.
/// </summary>
/// <remarks>
/// This should be called in the main thread when updates are necessary.
/// </remarks>
public static unsafe void Refresh() public static unsafe void Refresh()
{ {
if (!ThreadSafety.IsMainThread) if (!ThreadSafety.IsMainThread)
-11
View File
@@ -1,11 +0,0 @@
namespace HellionChat.Util;
// Indirection over Dalamud.Utility.Util's static surface so services can be
// constructed in an isolated xUnit AppDomain without loading Dalamud.dll.
// Production wiring lives in DalamudPlatformUtil; tests substitute a fake.
internal interface IPlatformUtil
{
bool IsWine { get; }
void OpenLink(string url);
}
+37 -9
View File
@@ -11,7 +11,8 @@ public readonly unsafe ref struct GfdFileView
private readonly ReadOnlySpan<byte> Span; private readonly ReadOnlySpan<byte> Span;
private readonly bool DirectLookup; private readonly bool DirectLookup;
// span: raw .gfd file bytes /// <summary>Initializes a new instance of the <see cref="GfdFileView"/> struct.</summary>
/// <param name="span">The data.</param>
public GfdFileView(ReadOnlySpan<byte> span) public GfdFileView(ReadOnlySpan<byte> span)
{ {
Span = span; Span = span;
@@ -26,13 +27,18 @@ public readonly unsafe ref struct GfdFileView
DirectLookup &= i + 1 == entries[i].Id; DirectLookup &= i + 1 == entries[i].Id;
} }
/// <summary>Gets the header.</summary>
private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span); private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span);
/// <summary>Gets the entries.</summary>
private ReadOnlySpan<GfdEntry> Entries => private ReadOnlySpan<GfdEntry> Entries =>
MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]); MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]);
// Returns true if the entry was found. /// <summary>Attempts to get an entry.</summary>
// followRedirect: whether to chase redirect chains. /// <param name="iconId">The icon ID.</param>
/// <param name="entry">The entry.</param>
/// <param name="followRedirect">Whether to follow redirects.</param>
/// <returns><c>true</c> if found.</returns>
public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true) public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true)
{ {
if (iconId == 0) if (iconId == 0)
@@ -44,8 +50,9 @@ public readonly unsafe ref struct GfdFileView
var entries = Entries; var entries = Entries;
if (DirectLookup) if (DirectLookup)
{ {
// Follow redirects on the direct-lookup path for consistency with // Resolve redirects on the direct-lookup path too — the binary-search
// the binary-search path. // path follows them, and skipping them here was inconsistent for
// contiguous ID sets.
var visited = 0; var visited = 0;
while (iconId <= entries.Length) while (iconId <= entries.Length)
{ {
@@ -100,28 +107,49 @@ public readonly unsafe ref struct GfdFileView
return false; return false;
} }
// .gfd file header /// <summary>Header of a .gfd file.</summary>
[StructLayout(LayoutKind.Sequential)] [StructLayout(LayoutKind.Sequential)]
public struct GfdHeader public struct GfdHeader
{ {
public fixed byte Signature[8]; // "gftd0100" /// <summary>Signature: "gftd0100".</summary>
public fixed byte Signature[8];
/// <summary>Number of entries.</summary>
public int Count; public int Count;
/// <summary>Unused/unknown.</summary>
public fixed byte Padding[4]; public fixed byte Padding[4];
} }
// .gfd file entry -- one icon slot /// <summary>An entry of a .gfd file.</summary>
[StructLayout(LayoutKind.Sequential, Size = 0x10)] [StructLayout(LayoutKind.Sequential, Size = 0x10)]
public struct GfdEntry public struct GfdEntry
{ {
/// <summary>ID of the entry.</summary>
public ushort Id; public ushort Id;
/// <summary>The left offset of the entry.</summary>
public ushort Left; public ushort Left;
/// <summary>The top offset of the entry.</summary>
public ushort Top; public ushort Top;
/// <summary>The width of the entry.</summary>
public ushort Width; public ushort Width;
/// <summary>The height of the entry.</summary>
public ushort Height; public ushort Height;
/// <summary>Unknown/unused.</summary>
public ushort Unk0A; public ushort Unk0A;
public ushort Redirect; // non-zero = redirects to another entry
/// <summary>The redirected entry, maybe.</summary>
public ushort Redirect;
/// <summary>Unknown/unused.</summary>
public ushort Unk0E; public ushort Unk0E;
/// <summary>Gets a value indicating whether this entry is effectively empty.</summary>
public bool IsEmpty => Width == 0 || Height == 0; public bool IsEmpty => Width == 0 || Height == 0;
} }
} }
+4 -12
View File
@@ -254,17 +254,6 @@ internal static class ImGuiUtil
return end; return end;
} }
// ---------------------------------------------------------------
// Inspired by ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).
// Upstream dropped the width parameter (no callers there); we keep
// it because two ChatLogWindow header buttons size themselves to
// match the ChannelIcon button's frame. The actual bug is the
// manual size = width - 2 * CellPadding.X subtraction: CellPadding
// scales with HUD scale, the raw int does not, so the button
// shrank under high HUD scales. ImGui.Button already handles its
// own frame padding internally — pass the measured width straight
// through.
// ---------------------------------------------------------------
internal static bool IconButton( internal static bool IconButton(
FontAwesomeIcon icon, FontAwesomeIcon icon,
string? id = null, string? id = null,
@@ -279,7 +268,10 @@ internal static class ImGuiUtil
bool ret; bool ret;
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
{ {
var size = width > 0 ? new Vector2(width, 0f) : Vector2.Zero; var size = Vector2.Zero;
if (width > 0)
size.X = width - 2 * ImGui.GetStyle().CellPadding.X;
ret = ImGui.Button(label, size); ret = ImGui.Button(label, size);
} }
+10 -2
View File
@@ -31,10 +31,18 @@ public static class MathUtil
public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}"; public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}";
} }
// Standard AABB overlap test. Inclusive on both axes to catch shared /// <summary>
// edges and identical rectangles (previous ValueInRange approach missed these). /// Checks if two rectangles overlap at any point.
/// </summary>
/// <param name="a"></param>
/// <param name="b"></param>
/// <returns>True if overlapping</returns>
public static bool HasOverlap(this Rectangle a, Rectangle b) public static bool HasOverlap(this Rectangle a, Rectangle b)
{ {
// Standard AABB overlap test: two rectangles overlap iff they
// overlap on both axes. The previous nested ValueInRange approach
// used strict inequalities at both ends, which dropped identical
// rectangles and shared-edge cases as false negatives.
return a.X < b.X + b.Width return a.X < b.X + b.Width
&& a.X + a.Width > b.X && a.X + a.Width > b.X
&& a.Y < b.Y + b.Height && a.Y < b.Y + b.Height
+42 -13
View File
@@ -13,10 +13,15 @@ internal class PartyFinderPayload : Payload
Id = id; Id = id;
} }
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
protected override void DecodeImpl(BinaryReader reader, long endOfStream) =>
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException();
}
} }
internal class AchievementPayload : Payload internal class AchievementPayload : Payload
@@ -30,10 +35,15 @@ internal class AchievementPayload : Payload
Id = id; Id = id;
} }
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
protected override void DecodeImpl(BinaryReader reader, long endOfStream) =>
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException();
}
} }
internal class UriPayload(Uri uri) : Payload internal class UriPayload(Uri uri) : Payload
@@ -45,14 +55,20 @@ internal class UriPayload(Uri uri) : Payload
private const string DefaultScheme = "https"; private const string DefaultScheme = "https";
private static readonly string[] ExpectedSchemes = ["http", "https"]; private static readonly string[] ExpectedSchemes = ["http", "https"];
// Parses a raw URI string. Defaults to https:// if no scheme is present. /// <summary>
// Throws UriFormatException for empty input or unsupported schemes. /// Create a URIPayload from a raw URI string. If the URI does not have a
/// scheme, it will default to https://.
/// </summary>
/// <exception cref="UriFormatException">
/// If the URI is invalid, or if the scheme is not supported.
/// </exception>
public static UriPayload ResolveUri(string rawUri) public static UriPayload ResolveUri(string rawUri)
{ {
ArgumentNullException.ThrowIfNull(rawUri); ArgumentNullException.ThrowIfNull(rawUri);
if (string.IsNullOrWhiteSpace(rawUri)) if (string.IsNullOrWhiteSpace(rawUri))
throw new UriFormatException("URI cannot be empty or whitespace."); throw new UriFormatException("URI cannot be empty or whitespace.");
// Check for an expected scheme '://', if not add 'https://'
if (ExpectedSchemes.Any(scheme => rawUri.StartsWith($"{scheme}://"))) if (ExpectedSchemes.Any(scheme => rawUri.StartsWith($"{scheme}://")))
return new UriPayload(new Uri(rawUri)); return new UriPayload(new Uri(rawUri));
@@ -62,10 +78,15 @@ internal class UriPayload(Uri uri) : Payload
return new UriPayload(new Uri($"{DefaultScheme}://{rawUri}")); return new UriPayload(new Uri($"{DefaultScheme}://{rawUri}"));
} }
protected override void DecodeImpl(BinaryReader reader, long endOfStream) => protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
throw new NotImplementedException();
}
} }
internal class EmotePayload : Payload internal class EmotePayload : Payload
@@ -74,10 +95,18 @@ internal class EmotePayload : Payload
public string Code = string.Empty; public string Code = string.Empty;
public static EmotePayload ResolveEmote(string code) => new EmotePayload { Code = code }; public static EmotePayload ResolveEmote(string code)
{
return new EmotePayload { Code = code };
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream) => protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
throw new NotImplementedException();
}
} }
+18 -9
View File
@@ -14,8 +14,12 @@ public static class TabsUtil
return channels; return channels;
} }
// Public-chat-only: Say, Yell, Shout. Group/FC/Linkshell and gameplay // Hellion-tuned General preset (v1.0.0 — sharpened defaults).
// events live in their own tabs to keep General focused on open-world chat. // Public-chat-only, the bare three channels you encounter in open
// world. Group/FC/Linkshell traffic moves to dedicated tabs, gameplay
// events (loot, crafting, gathering, NPC dialogue, PF pings) move to
// the System tab where they belong — keeps the General view focused
// on actual conversation in the immediate surroundings.
public static Tab VanillaGeneral => public static Tab VanillaGeneral =>
new() new()
{ {
@@ -51,8 +55,11 @@ public static class TabsUtil
AllSenderMessages = true, AllSenderMessages = true,
}; };
// Hellion tab presets. Names live in HellionStrings (EN+DE) so upstream // Hellion default-tab presets used by the v10 wipe migration. Names are
// resource files stay untouched. // kept in HellionStrings (EN+DE) instead of Language.* so the upstream
// resource files stay untouched. Channel selections cover the channels
// a typical Eorzea raider uses without forcing the user to hand-tick
// each box on first start.
public static Tab HellionFreeCompany => public static Tab HellionFreeCompany =>
new() new()
{ {
@@ -81,8 +88,10 @@ public static class TabsUtil
[ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All),
}, },
// No input-channel switch: Party pulls in multiple channel types // No automatic input-channel switch; the Gruppe tab is a read
// and auto-routing /party would surprise users wanting /alliance or /pvpteam. // surface that pulls in Party, CrossParty, Alliance and PvpTeam
// together. Auto-routing /party into this tab would surprise the
// user when they actually wanted /alliance or /pvpteam.
}; };
public static Tab HellionBeginner => public static Tab HellionBeginner =>
@@ -103,7 +112,7 @@ public static class TabsUtil
Name = HellionStrings.Tabs_Presets_System, Name = HellionStrings.Tabs_Presets_System,
SelectedChannels = new Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels = new Dictionary<ChatType, (ChatSource, ChatSource)>
{ {
// System noise // Plain system noise
[ChatType.Debug] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Debug] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.Urgent] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Urgent] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.Notice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Notice] = (ChatSourceExt.All, ChatSourceExt.All),
@@ -113,7 +122,7 @@ public static class TabsUtil
[ChatType.GatheringSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.GatheringSystem] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.NoviceNetworkSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NoviceNetworkSystem] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.BattleSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.BattleSystem] = (ChatSourceExt.All, ChatSourceExt.All),
// Login/logout/announcement noise // Login / logout / announcement noise
[ChatType.NpcAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NpcAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.FreeCompanyAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.FreeCompanyAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.FreeCompanyLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.FreeCompanyLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All),
@@ -121,7 +130,7 @@ public static class TabsUtil
[ChatType.PvpTeamLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.PvpTeamLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.RetainerSale] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.RetainerSale] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.PeriodicRecruitmentNotification] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.PeriodicRecruitmentNotification] = (ChatSourceExt.All, ChatSourceExt.All),
// Gameplay event streams // Gameplay-event streams (moved out of General in v1.0.0)
[ChatType.NpcDialogue] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NpcDialogue] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All),
+12 -2
View File
@@ -135,8 +135,18 @@ public static class Tokenizer
public int Precedence { get; set; } public int Precedence { get; set; }
} }
// Matches URLs with http(s):// or www. prefix, and bare domains on known TLDs. /// <summary>
// Examples: https://example.com, www.sub.example.com, example.com /// URLRegex returns a regex object that matches URLs like:
/// - https://example.com
/// - http://example.com
/// - www.example.com
/// - https://sub.example.com
/// - example.com
/// - sub.example.com
///
/// It matches URLs with www. or https:// prefix, and also matches URLs
/// without a prefix on specific TLDs.
/// </summary>
private static readonly Regex UrlRegex = new( private static readonly Regex UrlRegex = new(
@"(?<URL>((https?:\/\/|www\.)[a-z0-9-]+(\.[a-z0-9-]+)*|([a-z0-9-]+(\.[a-z0-9-]+)*\.(com|net|org|co|io|app)))(:[\d]{1,5})?(\/[^\s]*)?)", @"(?<URL>((https?:\/\/|www\.)[a-z0-9-]+(\.[a-z0-9-]+)*|([a-z0-9-]+(\.[a-z0-9-]+)*\.(com|net|org|co|io|app)))(:[\d]{1,5})?(\/[^\s]*)?)",
RegexOptions.Compiled | RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture RegexOptions.Compiled | RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture
-21
View File
@@ -1,21 +0,0 @@
namespace HellionChat.Util;
internal static class UrlValidation
{
// Used by BrandingLinks/IntegrationLinks at module init. A typo in a URL
// rotation throws loudly at plugin load instead of silently failing when
// a user clicks the broken button.
public static void ValidateAll(string source, params string[] urls)
{
foreach (var url in urls)
{
if (
!Uri.TryCreate(url, UriKind.Absolute, out var uri)
|| (uri.Scheme is not "https" and not "http")
)
{
throw new InvalidOperationException($"{source} contains malformed URL: {url}");
}
}
}
}
+1 -1
View File
@@ -22,7 +22,7 @@ public static class WrapperUtil
try try
{ {
Plugin.Log.Debug($"Opening URI {uri} in default browser"); Plugin.Log.Debug($"Opening URI {uri} in default browser");
Plugin.PlatformUtil.OpenLink(uri.ToString()); Dalamud.Utility.Util.OpenLink(uri.ToString());
} }
catch (Exception ex) catch (Exception ex)
{ {
@@ -2,17 +2,16 @@ using System;
namespace HellionChat._Helpers; namespace HellionChat._Helpers;
// Extracted history-navigation cursor math from CompactCallback to allow unit // Pure-helper mirror of the compact pop-out history-navigation cursor
// testing without ImGuiInputTextCallbackData (DeleteChars/InsertChars). // math. The original CompactCallback was tangled with ImGuiInputTextCallbackData
// Buffer mutation stays at the call site; only the cursor/replacement decision lives here. // (DeleteChars/InsertChars), which can't be exercised in xUnit. The
// ImGui buffer mutation stays at the call site; only the deterministic
// cursor-and-replacement decision lives here.
// //
// Index semantics match InputHistoryService: // Index semantics match InputHistoryService:
// index 0 = oldest entry // index 0 = oldest entry
// index Count-1 = newest entry // index Count - 1 = newest entry
// cursor == -1 = not browsing history // cursor == -1 = "not browsing history"
//
// replacement == null: caller must NOT touch the buffer (cursor unchanged).
// replacement != null: write it to the buffer (including "" to clear it).
// //
// TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputHistoryNavigatorTests.cs // TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputHistoryNavigatorTests.cs
public static class CompactInputHistoryNavigator public static class CompactInputHistoryNavigator
@@ -23,6 +22,9 @@ public static class CompactInputHistoryNavigator
Down, Down,
} }
// replacement == null means: caller must NOT touch the buffer. This
// distinguishes "cursor unchanged, leave the user's typing alone"
// from "cursor moved to an empty slot, clear the buffer".
public static (int cursor, string? replacement) Navigate( public static (int cursor, string? replacement) Navigate(
Direction direction, Direction direction,
int currentCursor, int currentCursor,
@@ -36,6 +38,7 @@ public static class CompactInputHistoryNavigator
ArgumentNullException.ThrowIfNull(push); ArgumentNullException.ThrowIfNull(push);
ArgumentNullException.ThrowIfNull(getByCursor); ArgumentNullException.ThrowIfNull(getByCursor);
var prev = currentCursor;
var next = currentCursor; var next = currentCursor;
switch (direction) switch (direction)
@@ -43,7 +46,8 @@ public static class CompactInputHistoryNavigator
case Direction.Up: case Direction.Up:
if (currentCursor == -1) if (currentCursor == -1)
{ {
// Stash current input so the user can recover it after browsing. // First Up press from a fresh buffer: stash whatever
// the user typed so they can recover it after browsing.
var offset = 0; var offset = 0;
if (!string.IsNullOrWhiteSpace(currentBuffer)) if (!string.IsNullOrWhiteSpace(currentBuffer))
{ {
@@ -53,9 +57,10 @@ public static class CompactInputHistoryNavigator
next = getCount() - 1 - offset; next = getCount() - 1 - offset;
} }
else if (currentCursor > 0) else if (currentCursor > 0)
{
next--; next--;
}
break; break;
case Direction.Down: case Direction.Down:
if (currentCursor != -1) if (currentCursor != -1)
{ {
@@ -66,9 +71,10 @@ public static class CompactInputHistoryNavigator
break; break;
} }
if (next == currentCursor) if (prev == next)
return (next, null); return (next, null);
return (next, getByCursor(next) ?? string.Empty); var replacement = getByCursor(next) ?? string.Empty;
return (next, replacement);
} }
} }
@@ -3,8 +3,11 @@ using HellionChat.Ui;
namespace HellionChat._Helpers; namespace HellionChat._Helpers;
// Extracted submit logic from ChatInputBar.SubmitCompact to allow unit testing // Pure-helper mirror of the compact pop-out submit flow. ChatInputBar's
// without a sealed ChatLogWindow dependency. // SubmitCompact used to inline this against a sealed ChatLogWindow, which
// blocks Moq-based isolation. Lifting the deterministic part into a POCO
// keeps the production call site a one-liner while letting xUnit assert
// the buffer/cursor reset and the sender contract directly.
// TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputSubmitterTests.cs // TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputSubmitterTests.cs
public static class CompactInputSubmitter public static class CompactInputSubmitter
{ {
+11 -17
View File
@@ -2,7 +2,7 @@
[![Build](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml/badge.svg?branch=main)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml) [![Build](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml/badge.svg?branch=main)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml)
[![License: EUPL-1.2](https://img.shields.io/badge/License-EUPL--1.2-blue.svg)](LICENSE) [![License: EUPL-1.2](https://img.shields.io/badge/License-EUPL--1.2-blue.svg)](LICENSE)
[![Latest release](https://img.shields.io/badge/release-v1.4.6-brightgreen)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/latest) [![Latest release](https://img.shields.io/badge/release-v1.4.3-brightgreen)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/latest)
[![Dalamud API](https://img.shields.io/badge/Dalamud-API_15-purple)](https://github.com/goatcorp/Dalamud) [![Dalamud API](https://img.shields.io/badge/Dalamud-API_15-purple)](https://github.com/goatcorp/Dalamud)
[![.NET](https://img.shields.io/badge/.NET-10.0-512BD4)](https://dotnet.microsoft.com/) [![.NET](https://img.shields.io/badge/.NET-10.0-512BD4)](https://dotnet.microsoft.com/)
[![FFXIV](https://img.shields.io/badge/FFXIV-Dawntrail-c3a37f)](https://www.finalfantasyxiv.com/) [![FFXIV](https://img.shields.io/badge/FFXIV-Dawntrail-c3a37f)](https://www.finalfantasyxiv.com/)
@@ -11,7 +11,7 @@
<img src="docs/images/hellion-forge.png" alt="Hellion Forge" width="180" /> <img src="docs/images/hellion-forge.png" alt="Hellion Forge" width="180" />
</p> </p>
**Version 1.4.6** — Privacy-first chat plugin for FINAL FANTASY XIV / Dalamud, built on **Version 1.4.3** — Privacy-first chat plugin for FINAL FANTASY XIV / Dalamud, built on
[Chat 2](https://github.com/Infiziert90/ChatTwo) (EUPL-1.2). [Chat 2](https://github.com/Infiziert90/ChatTwo) (EUPL-1.2).
Hellion Chat is a privacy-first plugin built on the Chat 2 foundation. The majority of the engine comes from Chat 2 Hellion Chat is a privacy-first plugin built on the Chat 2 foundation. The majority of the engine comes from Chat 2
@@ -102,7 +102,7 @@ Hellion Chat is developed under **Hellion Forge**, the specialized modding and p
#### Custom Themes (v1.1.0) #### Custom Themes (v1.1.0)
HellionChat ships a theme engine with ten built-in themes (Hellion Arctic, Hellion Spectrum, Chat 2 Classic, Event HellionChat ships a theme engine with ten built-in themes (Hellion Arctic, Hellion Spectrum, Chat 2 Classic, Event
Horizon, Crystal Nocturne, Mint Grove, Night Blue, Indigo Violet, Forge Merchantman, Synthwave Sunset) and a JSON-based Horizon, Moonlit Bloom, Mint Grove, Night Blue, Indigo Violet, Forge Merchantman, Synthwave Sunset) and a JSON-based
authoring format for custom themes. Schema and step-by-step guide in authoring format for custom themes. Schema and step-by-step guide in
[`docs/THEME-AUTHORING.md`](docs/THEME-AUTHORING.md). Hellion Spectrum is Deuteranopia/Protanopia-safe (red-green color [`docs/THEME-AUTHORING.md`](docs/THEME-AUTHORING.md). Hellion Spectrum is Deuteranopia/Protanopia-safe (red-green color
blindness) based on the Wong/Okabe-Ito palette. blindness) based on the Wong/Okabe-Ito palette.
@@ -286,20 +286,14 @@ An optional submission to the Dalamud main plugin repo (in addition to the custo
## Project Status ## Project Status
**Version 1.4.6** — Maintenance patch. No user-visible behaviour changes; tightens the development feedback loop and **Version 1.4.3** — Plugin-load async init plus repo cutover: the plugin has been migrated to Dalamud's
pulls in two ChatTwo upstream bugfixes. `scripts/preflight.sh` gains a csharpier reflow check and a markdownlint pass at `IAsyncDalamudPlugin` API. The constructor now handles only bootstrap essentials (config load, language init, conflict
the pre-push gate. `FontManager`'s font-fallback catch-filter now covers `InvalidOperationException` and detection); migrations, service allocations, window construction, and hook subscriptions move into `LoadAsync`, allowing
`ArgumentException` on top of the IO triad, so a corrupted font config no longer takes down the atlas build. Dalamud to keep the UI responsive during heavy lifting. A schema gate replaces the v9 → v16 migration chain; configs at
`BrandingLinks` and `IntegrationLinks` URLs validate themselves on plugin load — a typo in a future URL rotation throws schema v16+ load directly, older configs trigger an "install v1.4.2 first" error message. Custom repo URL migrated to
at startup instead of failing silently when a user clicks the broken button. Cherry-picked from ChatTwo upstream `gitea.hellion-forge.cloud`; the GitHub repo remains as a frozen v1.4.2 snapshot. Plugin load time is ~3.7 s median (5
`f35b7d3`: `Chat.SetChannel` no longer leaks the native `Utf8String` when the linkshell check rejects the channel, and reloads), comparable to v1.4.2 — the async migration is the foundation for v1.4.4 lazy-init optimizations, not a direct
`Tab.Clone` now deep-clones `UsedChannel` and `TellTarget` (the previous reference copy let PopOut and Temp tabs mutate user-facing win. Fourth sub-patch of the v1.4.x polish sweep series (as of 2026-05-08).
each other's channel state). The active-tab underline pill scales with DPI and rounds to physical pixels for crisp
rendering above 100 % DPI. Internal items: `HellionStyle` ChildBgAlpha extracted to a testable helper,
`Plugin.SaveConfig` clones only the temp-tab subset, `SettingsOverview` caches the draw-list per frame,
`Dalamud.Utility.Util` static surface routed through an `IPlatformUtil` indirection (`MessageStore`'s `IsWine` probe is
now testable in isolation). No schema bump, no migration. Seventh sub-patch of the v1.4.x polish sweep series (as of
2026-05-12).
Hellion Chat is a standalone plugin, no longer a fork in the repository sense. Fully completed: Hellion Chat is a standalone plugin, no longer a fork in the repository sense. Fully completed:
+9 -12
View File
@@ -56,18 +56,15 @@ Both are good projects. Use what fits you best.
## Tooling ## Tooling
| Tool | Purpose | | Tool | Purpose |
| ----------------------------------------------------- | ------------------------------------------------------------------- | | ----------------------------------------------------- | ------------------------------------------------------------- |
| [Claude](https://claude.ai) (Anthropic) | Pair-level AI assistance via Claude Code CLI | | [Claude](https://claude.ai) (Anthropic) | Pair-level AI assistance via Claude Code CLI |
| [VS Code](https://code.visualstudio.com) + C# Dev Kit | Primary IDE | | [VS Code](https://code.visualstudio.com) + C# Dev Kit | Primary IDE |
| Dedicated Windows 11 VM | Build and in-game test environment (Dalamud requires Windows) | | Dedicated Windows 11 VM | Build and in-game test environment (Dalamud requires Windows) |
| [dalamud.dev](https://dalamud.dev) | Dalamud API reference | | [dalamud.dev](https://dalamud.dev) | Dalamud API reference |
| [Microsoft Learn](https://learn.microsoft.com) | .NET and C# documentation | | [Microsoft Learn](https://learn.microsoft.com) | .NET and C# documentation |
| [Context7](https://context7.com) | Up-to-date library docs for Claude context | | [Context7](https://context7.com) | Up-to-date library docs for Claude context |
| [Stack Overflow](https://stackoverflow.com) | General C# and .NET problem-solving | | [Stack Overflow](https://stackoverflow.com) | General C# and .NET problem-solving |
| Custom build test suite | Pattern-based integration tests written from scratch, drawing on |
| | conventions from Lightless, Umbra and other standard FFXIV plugins. |
| | Not publicly available. Yet. |
## Contact ## Contact
+87 -208
View File
@@ -1,121 +1,13 @@
# Changelog — Hellion Chat # Changelog — Hellion Chat
All user-facing changes to Hellion Chat. Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), Alle nutzersichtbaren Änderungen an Hellion Chat. Das Format orientiert sich an
version numbers follow [Semantic Versioning](https://semver.org/). [Keep a Changelog](https://keepachangelog.com/de/1.0.0/), die Version-Nummern folgen
[Semantischer Versionierung](https://semver.org/lang/de/).
Detailed release notes per version are available directly on the Detaillierte Release-Notes pro Version stehen direkt am
[Gitea Release page](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases) and in the plugin [Gitea-Release](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases) und im Plugin-Changelog-Block
changelog block (`HellionChat/HellionChat.yaml``changelog:`). This file summarises releases as an overview and links (`HellionChat/HellionChat.yaml``changelog:`). Diese Datei fasst die Releases als Überblick zusammen und verlinkt für
to the release pages for details. Details auf die Release-Pages.
---
## Hellion Chat 1.4.6 — Code Hygiene and Refactor (2026-05-12)
Maintenance patch. No user-visible behaviour changes; tightens the development feedback loop, fixes two
upstream-inherited bugs from ChatTwo `f35b7d3`, and prepares the code for the v1.4.7 backlog cleanup.
- `scripts/preflight.sh` gains Block E (`dotnet csharpier check`) and Block F (`markdownlint-cli2`) so reflow drift and
markdown violations are caught at the pre-push gate. `.markdownlint.json` adds `MD024 siblings_only` and disables
`MD036` so the bilingual forge-post bold-emphasis headings pass linting; the `.claude/` directory is excluded from the
scan
- `FontManager.AddFontWithFallback` catch-filter now covers `InvalidOperationException` and `ArgumentException` on top
of the existing IO triad. The warning log carries the exception type name, so the diagnostic path knows which class
of atlas-toolkit throw triggered the NotoSansCjkRegular fallback
- `BrandingLinks` (5 URLs) and `Integrations/IntegrationLinks` (2 URLs) validate themselves on first module load via
`[ModuleInitializer]` + a shared `UrlValidation.ValidateAll` helper. A malformed URL now throws
`InvalidOperationException` at plugin load with the source class and the broken URL in the message
- Cherry-picked from ChatTwo upstream `f35b7d3`: `Chat.SetChannel` no longer leaks the native `Utf8String` when the
linkshell check rejects the channel. The validity check is now wrapped around the `ChangeChatChannel` call instead of
short-circuiting before `Dtor`. `ValidAnyLinkshell` is renamed to `IsChannelOrExistingLinkshell` and the
`ChatLogWindow` call-site follows the rename
- Cherry-picked from ChatTwo upstream `f35b7d3`: `Tab.Clone` now deep-clones `UsedChannel` and `TellTarget`. The old
`CurrentChannel = CurrentChannel` was a reference copy, so PopOut and Temp tabs mutated each other's channel state
(incl. tell target). `TellTarget.From(t)` static factory is replaced with an instance `Clone()`; `UsedChannel.Clone()`
is new and runs deep-clone on both TellTarget references
- `ChatLogWindow` active-tab underline pill now scales with `ImGuiHelpers.GlobalScale` and rounds its DrawList
coordinates to physical pixels via `MathF.Round`, so the 2 px line stays crisp on 125 % and 150 % DPI setups instead
of bleeding into a sub-pixel blur
- `ImGuiUtil.IconButton` width parameter no longer subtracts HUD-scaled `CellPadding.X * 2` from the raw `int` width.
`ImGui.Button` handles its own frame padding internally, so the measured `buttonWidth` now passes through verbatim
(inspired-by upstream `f35b7d3`, but our two call-sites need the parameter, so the param itself stays)
- Internal: `HellionStyle` ChildBgAlpha threshold logic extracted to `HellionStyleHelpers.ResolveChildBgAlpha` with a
build-suite mirror test that pins the 0.999f cutoff. `Plugin.SaveConfig` clones only the temp-tab subset in the
pre-serialization snapshot instead of the full tab list. `SettingsOverview` caches `ImGui.GetWindowDrawList()` once
per frame and passes the pointer down to `DrawCard`
- Internal: `Dalamud.Utility.Util` static surface (`IsWine`, `OpenLink`) routed through a new `IPlatformUtil`
indirection. `MessageStore`'s `IsWine` probe is now reachable from the xUnit AppDomain via a `FakePlatformUtil`
fixture (full isolated MessageStore construction still pending — `Plugin.Log.Information` in `Migrate0` is a separate
Dalamud-static surface, slated for v1.4.7)
- Built-in themes: Crystal Nocturne (royal sapphire and electric magenta over obsidian, by CRYSTALLITE) replaces
Moonlit Bloom in the built-in roster. Users who had Moonlit Bloom selected fall back to the default Hellion Arctic
on the first plugin load; an existing custom JSON copy of Moonlit Bloom under `pluginConfigs/HellionChat/themes/`
keeps working unchanged
Modding & support: join Hellion Forge — <https://discord.gg/X9V7Kcv5gR>
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
## Hellion Chat 1.4.5 — UX and Robustness (2026-05-12)
Sixth sub-patch of the v1.4.x polish-sweep series. User-visible robustness fixes plus two doc/test polish items from the
audit backlog. No schema bump, no migration.
- `ChatLogWindow.Draw` now surfaces a one-shot warning notification when the draw path throws. The stack trace still
goes to `/xllog` via `Plugin.Log.Error`; the notification is suppressed for the rest of the plugin session so a
recurring failure can't spam the notification stack frame-by-frame. Pattern-match to the existing `Plugin.cs:505-516`
migration-blocker notification
- `FirstRunWizard` splits accept from close. `OnClose` no longer silently sets `FirstRunCompleted`, so closing the X
leaves the wizard pending and it reopens on the next plugin load. A new footer "Later — keep defaults" button is the
explicit path to dismiss without picking a profile. Bilingual strings (EN + DE) plus a tooltip
- `InputHistoryService.Reset` is wired into `Plugin.DisposeAsync` alongside the existing pure-memory cleanups. Static
state used to survive a plugin reload — the next load now starts with an empty history
- `FontManager.GetHellionFontBytes` becomes `TryGetHellionFontBytes` with a nullable return. On miss (broken csproj,
hand-rolled dev build) the caller falls back to the system-font path that `UseHellionFont=false` already uses, plus a
`Plugin.Log.Warning`. The whole UiBuilder no longer throws if the embedded font resource is absent
- `Plugin.cs:167-168` gets a 4-line reasoning comment around the session-only `RemoveAll(IsTempTab)`: tells are usually
privacy-filtered, resurrecting an empty crashed-session tab would trigger DB reconstruction on the next load.
`TempTabCounter.InitFromList` mirrors the post-strip semantic in the Build-Suite with a pinning test
- `StatusBar.cs` drops the version slot when the chat window's content width minus the version text is below 200 px. The
right-aligned version used to clip into the four left-side slots in narrow windows
Modding & support: join Hellion Forge — <https://discord.gg/X9V7Kcv5gR>
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
## Hellion Chat 1.4.4 — Threading and IPC Safety Polish (2026-05-12)
Fifth sub-patch of the v1.4.x polish-sweep series. Threading assumptions are documented per-method, a hot-path lock
falls away in `AutoTellTabsService`, IPC-cleanup failures become visible, and the privacy filter now speaks up when an
unknown ChatType shows up.
- `AutoTellTabsService.ActiveTempTabCount` switches from a lock-protected LINQ `Count` to an `Interlocked` counter kept
in sync with `Config.Tabs` from inside the existing mutation paths. `Initialize()` seeds the counter from the
persisted Tabs list, and `SaveConfig`'s snapshot-restore path calls a new `ResyncTempTabCounter()` so the mid-step
`RemoveAll` doesn't leave the counter drifting. Pure-helper test mirror lives in the Build-Suite repo
- `HonorificService` per-method threading banners replace the block comment at the bottom of the file. Each IPC callback
(`TryInitialPull`, `OnTitleChanged`, `OnReady`, `OnDisposing`, `TryUnsubscribe`) and the `CurrentTitle` field carry a
one-line `// Thread:` annotation so the framework-thread invariant is visible at the call site
- `TryUnsubscribe` log-level upgraded from `Debug` to `Warning`. A silent unsubscribe failure leaks a live subscription
across plugin reloads, which is exactly the kind of issue that should not be at Debug
- `AutoTranslate.PreloadCache` thread now has `IsBackground = true` and a thread name. Without `IsBackground` the warmup
blocks plugin unload (typically 100-300 ms). Pattern-match to `MessageManager` (F6.1) and `Plugin.RetentionSweep`
(F9.3), both since v1.4.0
- `Configuration.IsAllowedForStorage` adds a one-line `Plugin.Log.Warning` for the first occurrence of any ChatType that
isn't in `PrivacyPersistChannels`. Dedup via a `NonSerialized` `HashSet<ChatType>`, so the warning fires once per
runtime — not once per frame, not once per install. Failsafe routing through `PrivacyPersistUnknownChannels` is
unchanged
- `PrivacyPersistUnknownChannels` field default flipped from `false` to `true` for new installs via a constant in
`PrivacyDefaults`. Existing configs keep their explicit choice — the deserializer overrides the initializer. No schema
bump, no migration, no first-run banner
Modding & support: join Hellion Forge — <https://discord.gg/X9V7Kcv5gR>
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
--- ---
@@ -148,8 +40,8 @@ Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
Third sub-patch of the v1.4.x Polish Sweep series. Per-frame allocations from the chat-log render path eliminated. Third sub-patch of the v1.4.x Polish Sweep series. Per-frame allocations from the chat-log render path eliminated.
- `DrawMessages` card-mode hoists `theme`/`drawList`/`winLeft`/`winRight`/`borderColorAbgr` out of the per-message loop. - `DrawMessages` card-mode hoists `theme`/`drawList`/`winLeft`/ `winRight`/`borderColorAbgr` out of the per-message
About 500 redundant calls per frame at 100 visible messages, multiplied by every pop-out window loop. About 500 redundant calls per frame at 100 visible messages, multiplied by every pop-out window
- Auto-tell tab tint and icon use a per-tab cache. Hash computation and string allocation only happen when the tell - Auto-tell tab tint and icon use a per-tab cache. Hash computation and string allocation only happen when the tell
target name or world drifts. `AutoTellTabTint` stays a pure hash helper; cache lives in a thin `TabTintCache` wrapper target name or world drifts. `AutoTellTabTint` stays a pure hash helper; cache lives in a thin `TabTintCache` wrapper
- Status bar gates its tab aggregation behind the same one-second cache it already used for the format strings. LINQ - Status bar gates its tab aggregation behind the same one-second cache it already used for the format strings. LINQ
@@ -213,7 +105,7 @@ Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
--- ---
## Hellion Chat 1.3.0 Plugin Integrations: Honorific ## Hellion Chat 1.3.0 - Plugin Integrations: Honorific
First step on the plugin-integration roadmap. HellionChat now listens to Honorific and shows your custom title in the First step on the plugin-integration roadmap. HellionChat now listens to Honorific and shows your custom title in the
chat header. The slot auto-hides when Honorific is not installed, when no custom title is active, or when you are using chat header. The slot auto-hides when Honorific is not installed, when no custom title is active, or when you are using
@@ -226,7 +118,7 @@ the original FFXIV title.
- Maintainer attribution buttons for Honorific repo and Caraxi - Maintainer attribution buttons for Honorific repo and Caraxi
- New service-class pattern under HellionChat/Integrations/ - New service-class pattern under HellionChat/Integrations/
Modding & support: join Hellion Forge <https://discord.gg/X9V7Kcv5gR> Modding and support: join Hellion Forge - <https://discord.gg/X9V7Kcv5gR>
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2). Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
@@ -285,7 +177,7 @@ Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
## v1.2.0 — Layout Refresh (2026-05-05) ## v1.2.0 — Layout Refresh (2026-05-05)
### Added ### 1.2.0 Added
- Sidebar tab modernization: icon-only at fixed 44 px, tooltip on hover, vertical accent pill for active tab - Sidebar tab modernization: icon-only at fixed 44 px, tooltip on hover, vertical accent pill for active tab
- Top tabs: accent underline pill replaces background fill on active tab - Top tabs: accent underline pill replaces background fill on active tab
@@ -298,12 +190,12 @@ Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
- Unread indicator: pulsing red dot in the top-right corner of any sidebar tab icon with unread messages, 2-second - Unread indicator: pulsing red dot in the top-right corner of any sidebar tab icon with unread messages, 2-second
sine-wave pulse, respects `Configuration.ReduceMotion` sine-wave pulse, respects `Configuration.ReduceMotion`
### Changed ### 1.2.0 Changed
- Migration v14 → v15: deprecated Configuration fields `HellionThemeEnabled` and `HellionThemeWindowOpacity` removed - Migration v14 → v15: deprecated Configuration fields `HellionThemeEnabled` and `HellionThemeWindowOpacity` removed
- Appearance settings cleaned: legacy theme-engine bindings replaced by Themes tab (introduced in v1.1.0) - Appearance settings cleaned: legacy theme-engine bindings replaced by Themes tab (introduced in v1.1.0)
### Fixed ### 1.2.0 Fixed
- Settings save no longer wipes chat history by default — the heavy `ClearAllTabs + FilterAllTabsAsync` cycle now only - Settings save no longer wipes chat history by default — the heavy `ClearAllTabs + FilterAllTabsAsync` cycle now only
runs when a filter-relevant setting actually changed (Privacy filter, persisted channels, per-tab channel selection). runs when a filter-relevant setting actually changed (Privacy filter, persisted channels, per-tab channel selection).
@@ -314,78 +206,75 @@ Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
- Sidebar child window no longer paints the top padding area with its frame background - Sidebar child window no longer paints the top padding area with its frame background
- Status bar version slot (`vX.Y.Z · Hellion`) no longer clips its rightmost character - Status bar version slot (`vX.Y.Z · Hellion`) no longer clips its rightmost character
### Notes ### 1.2.0 Notes
- Polish phase (animations, theme crossfade, header quick-picker) follows in v1.3.0 - Polish phase (animations, theme crossfade, header quick-picker) follows in v1.3.0
- Top-Tab icon prefixes were considered but dropped: Dalamud's default font atlas does not include FontAwesome - Top-Tab icon prefixes were considered but dropped: Dalamud's default font atlas does not include FontAwesome
codepoints, so mixed-font in a single TabItem label renders as tofu. Underline pill alone is the v1.2.0 visual codepoints, so mixed-font in a single TabItem label renders as tofu. Underline pill alone is the v1.2.0 visual
treatment for top tabs. Resolution would require Font-Atlas merge at FontManager level — out of scope. treatment for top tabs. Resolution would require Font-Atlas merge at FontManager level — out of scope.
---
## [1.1.0] — 2026-05-05 — Theme Foundation ## [1.1.0] — 2026-05-05 — Theme Foundation
First major UI cycle after v1.0.0. Theme engine, five built-in themes, custom themes via JSON, settings card grid. Erster großer UI-Cycle nach v1.0.0. Theme-Engine, fünf Built-In-Themes, Custom-Themes via JSON, Settings-Card-Grid.
### Added ### Hinzugefügt
- **Theme engine** with five built-in themes: Hellion Arctic (default), Chat 2 Classic, Event Horizon, Moonlit Bloom, - **Theme-Engine** mit fünf Built-In-Themes: Hellion Arctic (Default), Chat 2 Klassik, Event Horizon, Moonlit Bloom,
Mint Grove. Mint Grove.
- **Settings → Themes** with mini mockup preview per theme. Clicking a card instantly switches the entire plugin (chat, - **Settings → Themes** mit Mini-Mockup-Preview pro Theme. Klick auf eine Card switcht sofort das ganze Plugin (Chat,
settings, pop-outs). Settings, Pop-Out).
- **Custom themes via JSON** in `pluginConfigs/HellionChat/themes/`. On first start, `example-theme.json` is placed - **Custom-Themes via JSON** in `pluginConfigs/HellionChat/themes/`. Beim ersten Start wird `example-theme.json` als
there as a template. Vorlage abgelegt.
- **Optional theme chat channel colours**: themes can ship their own channel colours. On switch, a banner appears with - **Optional Theme-Chat-Channel-Colors**: Themes können eigene Channel-Farben mitliefern. Beim Switch erscheint ein
_Apply / Keep current_ — never applied automatically. Banner mit _Übernehmen / Behalten_ — nie automatisch.
- **Settings card grid**: new overview on open, clicking a card navigates into the section's detail view. Breadcrumb + - **Settings-Card-Grid**: neue Übersicht beim Öffnen, Card-Klick führt in die Detail-Ansicht der Section. Breadcrumb +
ESC navigate back. ESC führen zurück.
- **`docs/THEME-AUTHORING.md`** as a guide for writing custom themes, with Hellion Forge branding. - **`docs/THEME-AUTHORING.md`** als Anleitung zum Schreiben eigener Themes, mit Hellion-Forge-Branding.
### Changed ### Geändert
- **Plugin icon** updated to Hellion Forge hammer (previously a ChatTwo derivative). - **Plugin-Icon** auf Hellion Forge Hammer (vorher ChatTwo-Derivat).
- **Settings detail view** uses the full width — the second tab list on the left is gone because the card overview - **Settings-Detail-View** verwendet die volle Breite — die zweite Tab-Liste links ist weg, weil die Card-Übersicht den
handles navigation. Wechsel übernimmt.
- **`HellionStyle.PushGlobal`** is now theme-driven (`PushGlobal(theme, opacity)`) instead of const-palette-driven. - **`HellionStyle.PushGlobal`** ist jetzt theme-driven (`PushGlobal(theme, opacity)`) statt const-palette-driven.
- **Configuration v13 → v14**: all users land on `hellion-arctic`. Those who prefer the upstream look can select - **Configuration v13 → v14**: alle User landen auf `hellion-arctic`. Wer den Upstream-Look will, wählt `chat2-classic`
`chat2-classic` in Settings → Themes. in Settings → Themes.
### Deprecated ### Veraltet
- `Configuration.HellionThemeEnabled` and `HellionThemeWindowOpacity` remain readable for one release as a safety net - `Configuration.HellionThemeEnabled` und `HellionThemeWindowOpacity` bleiben für ein Release lesbar als Safety-Net,
but are no longer evaluated. Removal planned for v1.2.0. werden aber nicht mehr ausgewertet. Entfernung geplant in v1.2.0.
### Security ### Sicherheit
- Custom theme JSON loader validates `schemaVersion`, required fields and hex format. Invalid themes are skipped with a - Custom-Theme-JSON-Loader prüft `schemaVersion`, Pflichtfelder und Hex-Format. Ungültige Themes werden mit Warning
warning; the plugin continues loading with built-ins. übersprungen, das Plugin lädt mit Built-Ins weiter.
### Internal ### Intern
- 51 local unit tests (theme records, registry, JSON round-trip, sanity per built-in theme). Tests are gitignored. - 51 lokale Unit-Tests (Theme-Records, Registry, JSON-Round-Trip, Sanity pro Built-In-Theme). Tests sind gitignored.
--- ---
## [1.0.3] — 2026-05-04 — Polish Patch ## [1.0.3] — 2026-05-04 — Polish patch
Four small polish items from the backlog bundled together: Vier kleine Polish-Items aus dem Backlog gebündelt:
- **Hide on New Game+ menu**: optional global toggle that hides Hellion Chat (and all other plugin windows such as - **Hide bei New Game+ Menü**: Optionaler globaler Toggle der Hellion Chat (und alle weiteren Plugin-Fenster wie
Settings, DB Viewer, pop-outs) while the NG+ menu is open. Settings → Window → Frame, default off. Skips the entire Settings, DB-Viewer, Pop-Outs) ausblendet, solange das NG+-Menü offen ist. Settings → Fenster → Rahmen, Default aus.
`WindowSystem.Draw()` path analogous to the existing LoadingScreens pattern. Skipt analog zum bestehenden LoadingScreens-Pattern den gesamten `WindowSystem.Draw()`-Pfad.
- **Channel selector colouring**: optional tinting of the channel-select button (comment icon) next to the input field - **Channel-Selector-Färbung**: Optionales Tinting des Channel-Auswahl-Knopfs (Comment-Icon) neben dem Eingabefeld in
in the current channel colour. Settings → Appearance → Chat Colours, default on. Consistent with the existing input der aktuellen Channel-Farbe. Settings → Aussehen → Chat-Farben, Default an. Konsistent zur bestehenden
text colouring; ExtraChat override is carried over. Eingabetext-Färbung, ExtraChat-Override wird übernommen.
- **(De)buff icon aspect-ratio fix**: `PayloadHandler.InlineIcon` was squashing all hover icons to 32×32. Status icons - **(De)Buff-Icon Aspect-Ratio-Fix**: `PayloadHandler.InlineIcon` quetschte alle Hover-Icons auf 32×32. Status-Icons mit
with non-square dimensions (debuffs with an arrow indicator) are now shrunk aspect-preserving. Standalone float-math nicht-quadratischen Dimensionen (Debuffs mit Pfeil-Indikator) sind jetzt aspekt-erhaltend geshrinkt. Eigenständige
implementation with zero-size guard instead of a cherry-pick from the open ChatTwo PR #157 (which had an int-division Float-Math-Implementierung mit Zero-Size-Guard statt Cherry-Pick aus dem offenen ChatTwo PR #157 (der hatte eine
trap). int-Division-Falle).
- **HideState logging sweep**: all HideState transitions (Battle/Cutscene/User/Override plus pop-out mirroring) log at - **HideState-Logging-Sweep**: Alle HideState-Transitions (Battle/Cutscene/User/Override plus die Pop-Out-Spiegelung)
verbose level. Off by default; enable via `/xllog set HellionChat verbose` for bug-report diagnostics. loggen sich auf Verbose-Level. Aus by default, Aktivierung via `/xllog set HellionChat verbose` für
Bug-Report-Diagnose.
[Release Notes 1.0.3](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.3) [Release-Notes 1.0.3](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.3)
---
## [1.0.1] — 2026-05-04 — Window Position Recovery ## [1.0.1] — 2026-05-04 — Window Position Recovery
@@ -398,71 +287,61 @@ Bundled housekeeping since v1.0.0: documentation restructured into `docs/`, stal
cleaned up, Pidgin parser library bumped from 3.3.0 to 3.5.1, GitHub Actions bumps for `actions/setup-dotnet` (4 → 5) cleaned up, Pidgin parser library bumped from 3.3.0 to 3.5.1, GitHub Actions bumps for `actions/setup-dotnet` (4 → 5)
and `github/codeql-action` (3 → 4). and `github/codeql-action` (3 → 4).
[Release Notes 1.0.1](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.1) [Release-Notes 1.0.1](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.1)
---
## [1.0.0] — 2026-05-03 — Standalone Major Release ## [1.0.0] — 2026-05-03 — Standalone Major Release
First fully independent release. Code namespace, IPC channels and source tree structure consolidated under Erste vollständig eigenständige Version. Code-Namespace, IPC-Kanäle und Source-Tree-Struktur wurden auf `HellionChat.*`
`HellionChat.*`. Plugin refuses to start alongside an active upstream Chat 2 (bilingual conflict message). SQLite native konsolidiert. Plugin verweigert den Start bei aktivem Upstream Chat 2 (bilinguale Konflikt-Meldung). SQLite-Native auf
pinned to 3.50.3 (CVE-2025-6965, CVE-2025-7709). Tab layout default for new installs and users on config version 12 or 3.50.3 gepinnt (CVE-2025-6965, CVE-2025-7709). Tab-Layout-Default für neue Installationen und für User auf
older restructured (5 thematic tabs instead of 6+ kitchen-sink). Sweep of critical and major findings from the codebase Config-Version 12 oder älter neu strukturiert (5 thematische Tabs statt 6+ kitchen-sink). Sweep aus Critical- und
audit incorporated. Major-Findings aus dem Codebase-Audit eingearbeitet.
[Release Notes 1.0.0](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.0) [Release-Notes 1.0.0](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v1.0.0)
---
## [0.6.1] — 2026-05-03 — Pop-Out Discoverability & /tell Auto-Pop-Out ## [0.6.1] — 2026-05-03 — Pop-Out Discoverability & /tell Auto-Pop-Out
Pop-out button visible in the chat header, one-time hint banner for the pop-out feature. New setting "Open new /tell Pop-Out-Button im Chat-Header sichtbar, einmaliger Hint-Banner für die Pop-Out-Funktionalität. Neue Einstellung "Neue
tabs directly as pop-out". Pop-out input is now active by default. Bug fixes: ghost windows on LRU-drop / logout, dead /tell-Tabs direkt als Pop-Out öffnen". Pop-Out-Input ist jetzt standardmäßig aktiv. Bugfixes: Ghost-Windows bei LRU-Drop
zone below the input bar when the hint banner is active. / Logout, Dead-Zone unter dem Input-Bar bei aktivem Hint-Banner.
[Release Notes 0.6.1](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.6.1) [Release-Notes 0.6.1](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.6.1)
---
## [0.6.0] — 2026-05-03 — UX Polish: Pop-Out Input + Colour Presets ## [0.6.0] — 2026-05-03 — UX Polish: Pop-Out Input + Colour Presets
Two opt-in UX features. Pop-out windows optionally get a compact input bar with a channel-coloured icon button and an Zwei opt-in UX-Features. Pop-Out-Fenster bekommen optional eine kompakte Eingabe-Bar mit channel-farbigem Icon-Button
independent text buffer per pop-out. Seven built-in colour presets (Classic, High Contrast, Pastel, Dark Mode Tuned, und unabhängigem Text-Buffer pro Pop-Out. Sieben Built-in-Color-Presets (Klassik, High-Contrast, Pastell,
Hellion, Night Blue, Indigo Violet) for one-click apply. Configuration migration v10 → v11. Dark-Mode-Tuned, Hellion, Night Blue, Indigo Violet) zum One-Click-Apply. Konfigurations-Migration v10 → v11.
[Release Notes 0.6.0](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.6.0) [Release-Notes 0.6.0](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.6.0)
---
## [0.5.4] — 2026-05-02 — WrapText Hardening ## [0.5.4] — 2026-05-02 — WrapText Hardening
`ImGuiUtil.WrapText` rewritten from pointer arithmetic to Span- and index-based control flow. Permanently closes the `ImGuiUtil.WrapText` von Pointer-Arithmetik auf Span- und Index-basierten Control-Flow umgestellt. Schließt das
recurring CodeQL critical alert "unvalidated local pointer arithmetic". No user-visible behaviour change — word-wrap wiederkehrende CodeQL-Critical-Alert "unvalidated local pointer arithmetic" dauerhaft. Keine nutzersichtbare
output is byte-identical to 0.5.3. Verhaltensänderung — Word-Wrap-Output ist byte-identisch zu 0.5.3.
[Release Notes 0.5.4](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.5.4) [Release-Notes 0.5.4](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.5.4)
---
## [0.5.3] — 2026-05-02 — Pointer Arithmetic Hardening ## [0.5.3] — 2026-05-02 — Pointer Arithmetic Hardening
First attempt at closing the CodeQL critical alert in `ImGuiUtil.WrapText`. Encoded byte buffer length is validated via Erster Anlauf zur Schließung des CodeQL-Critical-Alerts in `ImGuiUtil.WrapText`. Encoded-Byte-Buffer-Length wird vor der
`GetByteCount` before pointer arithmetic. Pointer-Arithmetik via `GetByteCount` validiert.
[Release Notes 0.5.3](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.5.3) [Release-Notes 0.5.3](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/v0.5.3)
--- ---
## Earlier Versions ## Frühere Versionen
Releases before 0.5.3 (bootstrap phase 0.1.0 to 0.5.2) are available directly on the Gitea release stream: Releases vor 0.5.3 (Bootstrap-Phase 0.1.0 bis 0.5.2) sind direkt am GitHub-Release-Stream einsehbar:
[All Releases](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases) [Alle Releases](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases)
--- ---
## Maintenance Note ## Pflege-Hinweis
The source of truth for the user-facing changelog is the `changelog:` block in `HellionChat/HellionChat.yaml`. Die Source-of-Truth für den nutzersichtbaren Changelog ist der `changelog:`-Block in `HellionChat/HellionChat.yaml`.
`repo.json` and the GitHub release body are fed from there. This file (`docs/CHANGELOG.md`) is a curated summary with `repo.json` und der GitHub-Release-Body werden daraus gespeist. Diese Datei (`docs/CHANGELOG.md`) ist eine kuratierte
links to the release pages and is updated manually on each version bump. Zusammenfassung mit Verweis auf die Release-Pages und wird beim Versions-Bump manuell ergänzt.
+53 -49
View File
@@ -1,83 +1,87 @@
# Contributors — Hellion Chat # Contributors — Hellion Chat
Hellion Chat is a one-person project on the code side. But without the people on this page, the bug fixes and UX Hellion Chat ist von der Code-Seite ein Ein-Personen-Projekt. Aber ohne die Leute auf dieser Seite gäbe es weder die
improvements that have landed since the early versions would not exist. Every entry here has made the plugin concretely Bug-Fixes noch die UX-Verbesserungen, die seit den frühen Versionen reingelaufen sind. Jeder Eintrag hier hat das Plugin
better. konkret besser gemacht.
Attribution for the upstream Chat 2 authors (Infi and Anna) is intentionally in [`../NOTICE.md`](../NOTICE.md), not Die Anerkennung an die Upstream-Autoren von Chat 2 (Infi und Anna) liegt bewusst in [`../NOTICE.md`](../NOTICE.md),
here. This file covers contributions to the Hellion Chat side specifically. nicht hier. Diese Datei deckt explizit Beiträge zur Hellion-Chat-Seite ab.
--- ---
## Development ## Entwicklung
### JonKazama (Florian Wathling) — Maintainer ### JonKazama (Florian Wathling) — Maintainer
Hellion Chat is my first FFXIV plugin and my first larger C#/Dalamud project. My professional background is web Hellion Chat ist mein erstes FFXIV-Plugin und mein erstes größeres C#-/Dalamud-Projekt. Mein beruflicher Hintergrund ist
development (Next.js, React, TypeScript, Prisma). Plugin development in an unfamiliar codebase, ImGui, FFXIV game hooks Webentwicklung (Next.js, React, TypeScript, Prisma). Plugin-Entwicklung in einer fremden Codebase, ImGui,
and the entire Dalamud stack were new territory. FFXIV-Game-Hooks und der gesamte Dalamud-Stack waren Neuland.
Privacy-first defaults, per-channel retention, Auto-Tell-Tabs, pop-out input, ChatColours presets, the Hellion theme Privacy-First-Defaults, Per-Channel-Retention, Auto-Tell-Tabs, Pop-Out-Input, ChatColours-Presets, Hellion-Theme plus
plus Exo 2 font, and the v1.0.0 standalone cut are the Hellion-specific surface areas I built on top of the Chat 2 Exo-2-Font und der v1.0.0-Standalone-Cut sind die Hellion-spezifischen Surface-Areas, die ich auf das Chat-2-Fundament
foundation. The learning story behind that is in [`LEARNING-JOURNEY.md`](LEARNING-JOURNEY.md). aufgebaut habe. Die Lern-Geschichte dahinter steht in [`LEARNING-JOURNEY.md`](LEARNING-JOURNEY.md).
Hellion Chat is part of [Hellion Online Media](https://hellion-media.de). Hellion Chat ist Teil von [Hellion Online Media](https://hellion-media.de).
--- ---
## Testers ## Tester
A quick note: I do not test this plugin alone. The people listed here reported bugs before they hit more users, raised Eine kurze Notiz vorneweg: Ich teste das Plugin nicht allein. Die Leute hier haben mir Bugs gemeldet, bevor sie bei mehr
UX problems I had gone blind to, and brought in feature requests that pushed the plugin in directions I would not have Nutzern aufgeschlagen wären. Sie haben UX-Probleme angesprochen, die ich blind nicht mehr gesehen habe. Und sie haben
gone on my own. That is not a given. External testers are worth their time. Feature-Wünsche eingebracht, die das Plugin in Richtungen geschoben haben, in die ich von alleine nicht gegangen wäre.
Das ist nicht selbstverständlich. Externe Tester sind ihre Zeit wert.
### Carl Beleandis (Carla) — Beta Tester ### Carl Beleandis (Carla) — Beta-Tester
Carl has been testing since the bootstrap phase and has shaped both the pop-out mechanics and the theme direction. Carl testet seit der Bootstrap-Phase und hat sowohl die Pop-Out-Mechanik als auch die Theme-Richtung geprägt. Sein
Feedback comes direct and without detours, which is exactly what I need when testing. Feedback kommt direkt und ohne Umschweife und das ist genau, was ich beim Testen brauche.
Concrete contributions: Konkrete Beiträge:
- **Pop-out discoverability**pointing out that pop-outs were only reachable via right-click triggered the header - **Pop-Out-Discoverability**der Hinweis, dass Pop-Outs nur per Rechtsklick erreichbar waren, hat den Header-Button
button and the one-time hint banner in v0.6.1. I knew the right-click path by heart and had stopped seeing that new und den einmaligen Hint-Banner in v0.6.1 ausgelöst. Ich kannte den Rechtsklick-Pfad blind, deshalb hatte ich nicht
users could not find the feature at all. mehr gesehen, dass neue Nutzer die Funktion gar nicht finden.
- **/tell pop-out mode** — the request to open /tell tabs directly as a pop-out instead of going through the tab sidebar - **/tell-Pop-Out-Mode** — der Wunsch, /tell-Tabs direkt als Pop-Out zu öffnen statt über den Tab-Umweg, ist in v0.6.1
landed in v0.6.1 as an opt-in settings toggle. Bonus: during implementation an old ghost-window bug surfaced (LRU drop als opt-in Settings-Toggle gelandet. Bonus: Bei der Implementation ist ein alter Ghost-Window-Bug aufgefallen
left pop-out windows as ghosts), which got fixed at the same time. (LRU-Drop ließ Pop-Out-Fenster als Geister stehen), der gleich mit gefixt wurde.
- **Theme variants with brightness gradations** — the request for a green family shifted my thinking from "one theme = - **Theme-Varianten mit Helligkeits-Abstufungen** — der Wunsch nach einer Grün-Familie hat mein Verständnis von "ein
one colour" to "theme families with mood variants". On the [roadmap](ROADMAP.md) for a later cycle. Theme = eine Farbe" auf "Theme-Familien mit Stimmungs-Varianten" verschoben. Steht in der [Roadmap](ROADMAP.md) für
einen späteren Cycle.
### Jin (Jingliu) — Alpha Tester ### Jin (Jingliu) — Alpha-Tester
Jin is the active tester from day one and pushed the pop-out workflow architecture in a different direction. Jin ist der aktive Tester der ersten Stunde und hat den Pop-Out-Workflow architektonisch in eine andere Richtung
geschoben.
Concrete contributions: Konkrete Beiträge:
- **Pop-out tab with input bar**the suggestion to be able to type in a pop-out (instead of just reading) triggered - **Pop-Out-Tab mit Input-Feld**der Vorschlag, in einem Pop-Out auch tippen zu können (statt nur lesen), hat die
the v0.6.0 pop-out input bar. That was a larger refactor: the input layer from `ChatLogWindow` had to be opened up so v0.6.0 Pop-Out-Input-Bar ausgelöst. Das war ein größerer Refactor: Der Input-Layer aus `ChatLogWindow` musste so
it could also live in `Popout.cs`, with an independent text buffer and history cursor per pop-out. It dominated the geöffnet werden, dass er auch in `Popout.cs` lebt, mit unabhängigem Text-Buffer und History-Cursor pro Pop-Out. Hat
cycle because the design had to be clean before any code could happen. den Cycle dominiert, weil das Design erst sauber sein musste, bevor Code passieren konnte.
- **TempTell persistence**the request for /tell tabs to survive a relog via a pin toggle is on the - **TempTell Persistence**der Wunsch, /tell-Tabs per Pin-Toggle einen Relog überleben zu lassen, steht in der
[roadmap](ROADMAP.md) for a later cycle. It touches the tab system architecturally and needs its own design work. [Roadmap](ROADMAP.md) für einen späteren Cycle. Berührt das Tab-System architektonisch und braucht eigenes Design.
--- ---
## Translations ## Übersetzungen
Hellion-specific UI strings are maintained in `HellionChat/Resources/HellionStrings.<lang>.resx`. Hellion-eigene UI-Strings werden in `HellionChat/Resources/HellionStrings.<lang>.resx` gepflegt.
- **German (DE):** JonKazama (native speaker, primary project language) - **Deutsch (DE):** JonKazama (Native Speaker, Hauptsprache des Projekts)
Upstream language files (`Language.<lang>.resx`) are not covered here. They are maintained via the Die Upstream-Sprach-Dateien (`Language.<lang>.resx`) sind nicht Teil dieser Datei. Sie werden über das
[Chat 2 Crowdin project](https://github.com/Infiziert90/ChatTwo); Crowdin translators are listed in the plugin settings [Chat-2-Crowdin-Projekt](https://github.com/Infiziert90/ChatTwo) gepflegt; Crowdin-Übersetzer findest du in den
under **Info → "Chat 2 community translators"**. Plugin-Settings unter **Info → "Chat 2 community translators"**.
--- ---
## How to Contribute ## Wie du beitragen kannst
Bug reports, feature requests and feedback are welcome — the best place to reach me is the Hellion Forge Discord: Bug-Reports, Feature-Wünsche und Pull-Requests laufen über
[discord.gg/X9V7Kcv5gR](https://discord.gg/X9V7Kcv5gR). Join and ping me in the Hellion Chat channel. [Gitea Issues](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues). Workflow und Erwartungen stehen
in [`../CONTRIBUTING.md`](../CONTRIBUTING.md), Code of Conduct in [`../CODE_OF_CONDUCT.md`](../CODE_OF_CONDUCT.md).
For pull requests and contribution guidelines see [`../CONTRIBUTING.md`](../CONTRIBUTING.md), Code of Conduct in Tester-Pool für neue Versionen läuft über den Hellion-Forge-Discord:
[`../CODE_OF_CONDUCT.md`](../CODE_OF_CONDUCT.md). [discord.gg/X9V7Kcv5gR](https://discord.gg/X9V7Kcv5gR). Wer in den Tester-Channel rein will, einfach im Forge melden.
+223 -218
View File
@@ -1,331 +1,336 @@
# Development History and Learning Process # Entwicklungsgeschichte und Lernprozess
## Background ## Hintergrund
I am self-taught. Hellion Chat is my first FFXIV plugin and my first larger C# project. My professional background is Ich bin Autodidakt. Hellion Chat ist mein erstes FFXIV-Plugin und mein erstes größeres C#-Projekt. Mein beruflicher
web development (Next.js, React, TypeScript, Prisma, MySQL) — browser world with a JavaScript toolchain. I knew C# only Hintergrund ist Webentwicklung (Next.js, React, TypeScript, Prisma, MySQL), also Browser-Welt mit JavaScript-Toolchain.
superficially before this project, ImGui not at all, and Dalamud only as an end user through other plugins. C# kannte ich vor diesem Projekt nur oberflächlich, ImGui gar nicht, Dalamud nur als Endnutzer über andere Plugins.
When I get stuck somewhere, I use AI tools like Claude Code as a pair assistant. What that looks like exactly and which Wenn ich an einer Stelle nicht weiterkomme, nutze ich AI-Tools wie Claude Code als Pair-Hilfsmittel. Wie das genau
classification I use is documented transparently in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md). aussieht und welche Klassifikation ich verwende, steht transparent in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md).
--- ---
## Why a chat plugin at all? ## Warum überhaupt ein Chat-Plugin?
Hellion Chat is not meant to replace Chat 2. Chat 2 delivers a complete chat experience with full history, filters, Hellion Chat soll Chat 2 nicht ersetzen. Chat 2 liefert ein vollständiges Chat-Erlebnis mit kompletter Historie,
search and replay. For most users that is exactly the right thing. Filtern, Suche und Replay. Für die meisten Nutzer ist genau das richtig.
### Two million messages in two years ### Zwei Millionen Nachrichten in zwei Jahren
My desire for a tighter default was honestly personal at first. After two years with Chat 2 my database had grown to Mein Wunsch nach einem engeren Default war ehrlich gesagt erstmal persönlich. Nach zwei Jahren mit Chat 2 lag meine
over two million messages, the majority of them /say, /shout and /yell from complete strangers in Limsa. That is exactly Datenbank bei über zwei Millionen Nachrichten, der Großteil davon /say, /shout und /yell von wildfremden Leuten in
what makes Chat 2's full history useful, and most users are happy to keep it. My own preference wanted a smaller Limsa. Genau diese Daten machen Chat 2's Voll-Historie nützlich, und die meisten Nutzer behalten sie auch gerne. Mein
default. So I built this fork. eigener Geschmack wollte einen kleineren Default. Also habe ich diesen Fork gebaut.
### Greeter in several clubs ### Greeter in mehreren Clubs
There was a second use case: I am active as a greeter in several FFXIV clubs. The vanilla chat interface is not enough Dazu kam ein zweiter Use-Case: Ich bin in mehreren FFXIV-Clubs als Greeter aktiv. Für die Greeter-Arbeit reicht die
for greeter work. Parallel /tell conversations write into a single tab at the same time, and I constantly lose track of Vanilla-Chat-Oberfläche nicht. Parallel laufende /tell-Gespräche schreiben in einem einzigen Tab durcheinander, und ich
who wrote what. Auto-Tell-Tabs (one of the early Hellion Chat features) came directly from this workflow: one tab per verliere ständig den Faden, wer mir gerade was geschrieben hat. Auto-Tell-Tabs (eines der frühen Hellion-Chat-Features)
conversation partner, automatically spawned, with a manual greeted status. The privacy hygiene benefit was a nice bonus, ist genau für diesen Workflow entstanden: ein Tab pro Gesprächspartner, automatisch gespawnt, mit manuellem
not the trigger. Greeted-Status. Dass das auch der Privacy-Hygiene gut tut, war ein netter Bonus, nicht der Auslöser.
### Hellion Online Media ### Hellion Online Media
The privacy defaults also reflect a position from my main work. Hellion Online Media is my sole proprietorship, and data Die Privacy-Defaults sind außerdem eine Position aus meinem Hauptberuf. Hellion Online Media ist mein Einzelunternehmen,
protection toward clients is not a marketing slogan there but operationally relevant. This fork is the plugin form of und Datenschutz gegenüber Kunden ist da kein Marketing-Slogan, sondern operativ relevant. Dieser Fork ist die
the same stance. Plugin-Form derselben Haltung.
--- ---
## Why not contribute to the original? ## Warum nicht beim Original mitarbeiten?
Three reasons, in descending order of importance. Drei Gründe, in absteigender Wichtigkeit.
### Defaults are not negotiable, including mine ### Defaults sind nicht verhandelbar, auch nicht meine
Privacy-first as a default is a minority position. Chat 2 rightly serves the broad majority with full history as the Privacy-First als Standard ist eine Minderheits-Position. Chat 2 bedient zu Recht die breite Masse mit Voll-Historie als
default. Changing those defaults upstream would have been wrong. I would have flipped the standard for a large user base Default. Diese Defaults im Upstream zu ändern wäre falsch gewesen. Ich hätte den Standard für eine große Nutzerbasis
that wanted it as it was. A clean separation through a dedicated plugin slot was the more respectful path. umgekippt, die ihn so wollte, wie er ist. Saubere Trennung über einen eigenen Plugin-Slot war der respektvollere Weg.
### The web interface had to go ### Das Webinterface musste weg
It is a central Chat 2 feature for remote access from a second device. A PR removing it has no chance in a Das ist ein zentrales Chat-2-Feature für Remote-Zugriff vom Zweitgerät. Ein PR der das entfernt, hat in einem gepflegten
well-maintained upstream project, and that is correct. But exactly that web interface conflicts with the privacy-first Upstream-Projekt keine Chance, und das ist auch richtig so. Aber genau das Webinterface kollidiert mit der
premise of this fork: a chat plugin that starts a local HTTP server is too large an attack surface for my threat model. Privacy-First-These dieses Forks: Ein Chat-Plugin das einen lokalen HTTP-Server startet, ist für mein Threat-Model eine
So out it went. zu große Angriffsfläche. Also raus damit.
### Velocity ### Tempo
A solo-maintainer project with a small tester pool can iterate faster than an established plugin with a large user base. Ein Solo-Maintainer-Projekt mit kleinem Tester-Pool kann schneller iterieren als ein etabliertes Plugin mit großer
That is not a criticism of upstream but a different optimization. I do not need roadmap alignment, reviewer Nutzerbasis. Das ist kein Vorwurf an Upstream, sondern eine andere Optimierung. Ich brauche keine Roadmap-Abstimmung,
availability, or to spread audit consequences like the web interface removal across multiple releases. keine Reviewer-Verfügbarkeit, und kann Audit-Konsequenzen wie das Webinterface-Removal in einer einzigen Version
durchziehen statt über mehrere Releases.
EUPL-1.2 explicitly allows all of this with clear attribution. The code is open under the same license as Chat 2. Infi, EUPL-1.2 erlaubt das alles ausdrücklich, mit klarer Attribution. Der Code liegt offen unter derselben Lizenz wie Chat 2.
Anna, or anyone else can look in, take ideas, ask questions, or simply ignore the fork. All three are fine with me. Infi, Anna oder sonst jemand dürfen reinschauen, Ideen mitnehmen, Fragen stellen oder den Fork einfach ignorieren. Alles
drei ist für mich okay.
--- ---
## How I release this fast ## Wie ich so schnell release
Anyone looking at the repo sees a lot of releases and a high commit count in a short time. Both tend to read as red Wer auf den Repo schaut, sieht in kurzer Zeit viele Releases und sehr viele Commits. Beides wird von außen gerne als
flags from the outside: AI slop, salami tactics, code spam. In Hellion Chat both are deliberate decisions, and I would Red-Flag gelesen: KI-Slop, Salami-Taktik, Code-Spam. Bei Hellion Chat ist beides eine bewusste Entscheidung, und ich
rather explain them once than justify them later. erkläre lieber einmal warum, als mich später dafür zu rechtfertigen.
### Groundwork, long before the fork existed ### Vorarbeit, lange bevor der Fork existierte
Before I typed the first line into `HellionChat/`, I spent weeks as a reader. Using Chat 2 in-game and playing around Bevor ich die erste Zeile in `HellionChat/` getippt habe, war ich wochenlang nur Leser. Chat 2 ingame nutzen und damit
with it. Going through issues in the upstream tracker, especially the closed ones, because that is where you see how rumspielen. Issues im Upstream-Tracker durchgehen, vor allem die geschlossenen, weil dort steht, wie Infi und Anna Bugs
Infi and Anna narrow down bugs. Reading commits, including older ones, to understand _why_ an architecture decision was einkreisen. Commits lesen, gerne auch ältere, um zu verstehen, warum eine Architektur-Entscheidung getroffen wurde,
made, not just _that_ it was made. If I know today where things live in the codebase, it is not because I navigate nicht nur, dass sie getroffen wurde. Wenn ich heute weiß, wo im Code was liegt, dann nicht, weil ich besonders schnell
codebases particularly fast but because I read the code beforehand. durch eine Codebase navigiere, sondern weil ich den Code vorher gelesen habe.
That sounds obvious. It is not. The usual order for solo forks is fork first, understand later. I did it the other way Klingt nach Selbstverständlichkeit, ist es aber nicht. Die übliche Reihenfolge bei Solo-Forks heißt erst forken, dann
around. verstehen. Ich habe es andersrum gemacht.
One thing I noticed reading the codebase closely: some patterns felt familiar in ways I had not expected, structural ### Die Codebase von Infi und Anna
choices and comment styles that show up across a lot of modern plugin and tooling code regardless of how it was written.
Nothing worth reading into. Coding workflows have changed a lot in the last few years across the board, and the traces
of that show up everywhere. It did make me less self-conscious about my own workflow.
### Infi and Anna's codebase Hellion Chat baut auf einem Boden auf, der schon flach ist. Chat 2 ist sauber strukturiert, die Naming-Konventionen sind
konsistent, die Trennung zwischen Layern (Storage, UI, Game-Hooks, IPC) ist klar gezogen. Das ist in
Open-Source-Plugin-Welten nicht selbstverständlich, und es ist der Hauptgrund, warum sich Hellion-spezifische Features
oft "fast nativ" einbauen lassen. Ich muss nicht erst Spaghetti entwirren bevor ich was Eigenes danebenstellen kann.
Hellion Chat builds on a foundation that is already flat. Chat 2 is cleanly structured, naming conventions are Side-Fact: Selbst beim ersten Codebase-Walkthrough mit Claude kam mehrfach der Hinweis, dass die Architektur
consistent, and the separation between layers (storage, UI, game hooks, IPC) is clearly drawn. That is not a given in ungewöhnlich gut aufgeräumt ist und mehrere Erweiterungspunkte vorbereitet. Das hat Gewicht, weil es von außen kommt,
open-source plugin land, and it is the main reason Hellion-specific features often slot in "almost natively". I do not aber den eigentlichen Kredit kriegen Infi und Anna, nicht Claude.
have to untangle spaghetti before I can put something of my own next to it.
Side note: even during the first codebase walkthrough with Claude, the comment came up several times that the ### Atomar arbeiten, kleine Commits
architecture is unusually tidy and has several extension points prepared. That carries weight because it comes from
outside, but the actual credit goes to Infi and Anna, not Claude.
### Atomic work, small commits Ein Commit, eine logische Änderung. Wenn ich einen Bug fixe, parallel eine Variable umbenenne und nebenbei einen
Kommentar einbaue, sind das drei Commits, nicht einer. Klingt nach Mikro-Management, ist es aber nicht. Wenn in sechs
Monaten ein Bug auftaucht und ich `git bisect` brauche, finde ich die kaputte Änderung in zwei Minuten statt in zwei
Stunden. Bei einem 4000-Zeilen-Mega-Commit darf ich raten, welche der hundert Änderungen die kaputte ist.
One commit, one logical change. If I fix a bug, rename a variable and add a comment at the same time, that is three Den Stil habe ich bewusst auch deshalb beibehalten, weil Infi im Upstream häufig genauso arbeitet. Manchmal ein
commits, not one. Sounds like micro-management, it is not. If a bug surfaces in six months and I need `git bisect`, I Sechs-Zeilen-Commit, manchmal nur ein Typo-Fix. Das ist keine Schwäche, das ist eine Entscheidung für lesbare
find the broken change in two minutes instead of two hours. With a 4000-line mega-commit I get to guess which of the Git-History. Den Stil im Fork beizubehalten ist ein Respekt-Move: Wer die beiden Repos vergleicht, soll den gleichen
hundred changes is the broken one. Lese-Rhythmus haben.
I kept this style deliberately also because Infi works the same way upstream. Sometimes a six-line commit, sometimes Bonus für mich persönlich: Kleine Commits zwingen mich, jeden Schritt einzeln zu durchdenken und zu benennen. Wenn ich
just a typo fix. That is not a weakness, it is a decision for readable Git history. Keeping the style in the fork is a nicht in zwei Sätzen erklären kann, was ein Commit macht, ist die Änderung wahrscheinlich noch nicht klar genug. Auf
respect move: anyone comparing both repos should have the same reading rhythm. Beginner-Niveau ist das ein eingebauter Sanity-Check, den ich bei einem Big-Bang-Commit nicht hätte.
Personal bonus: small commits force me to think through and name each step individually. If I cannot explain what a ### AI als Beschleuniger, ehrlich
commit does in two sentences, the change is probably not clear enough yet. At beginner level that is a built-in sanity
check I would not have with a big-bang commit.
### AI as an accelerator, honestly Ja, AI hilft beim Tempo, und nicht zu knapp. Ohne CodeRabbit hätte ich Critical-Bugs der Klasse
`Equals/GetHashCode`-Anti-Pattern, Hook-Subscription-Leaks und TOCTOU-Races nicht gefunden. Ich bin schlicht zu
unerfahren für diese Klasse von Findings, das schreibe ich genau so hin.
Yes, AI helps with velocity, and not a little. Without CodeRabbit I would not have found critical bugs like Was ich aber nicht mache: blind Code übernehmen, weil ein Tool ihn als Fix markiert hat. Bei mehreren
`Equals/GetHashCode` anti-patterns, hook subscription leaks and TOCTOU races. I am simply too inexperienced for that CodeRabbit-Findings stand in den Original-Commits von Infi oder Anna sogar ein Stackoverflow-Link mit Begründung dabei,
class of findings, and I write that exactly as it is. warum eine bestimmte Stelle so aussieht wie sie aussieht. Die habe ich gelesen, bevor ich was geändert habe. Erst
verstehen, dann anfassen, dann committen. Das ist der Unterschied zwischen "AI gibt mir Code, ich pushe" und "AI zeigt
mir wo's klemmt, ich entscheide".
What I do not do: blindly take code because a tool marked it as a fix. On several CodeRabbit findings, the original Klassifikation und konkrete Beispiele zur AI-Nutzung stehen in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md). Hier in dieser
commits from Infi or Anna even included a Stack Overflow link explaining why a particular spot looks the way it does. I Sektion ging es nur um den Tempo-Aspekt: Recherche plus saubere Codebase plus atomare Commits plus AI-gestütztes
read those before touching anything. Understand first, then change, then commit. That is the difference between "AI Review-Sparring sind die vier Faktoren zusammen. Kein einzelner davon erklärt das Tempo allein.
gives me code, I push" and "AI shows me where it breaks, I decide".
Classification and concrete examples of AI usage are in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md). This section was only
about the velocity aspect: research plus a clean codebase plus atomic commits plus AI-assisted review sparring are the
four factors together. No single one explains the pace on its own.
--- ---
## From the web stack to C# / Dalamud ## Vom Web-Stack zu C# / Dalamud
### Type system? Less of a shock than expected ### Type-System? Weniger Schock als erwartet
C# after TypeScript was more comfortable than expected. Properties instead of getters/setters are clean, nullable C# nach TypeScript war angenehmer als gedacht. Properties statt getter/setter sind sauber, nullable reference types
reference types feel like `strict: true` in TypeScript. What was unfamiliar was having to think explicitly about value fühlen sich an wie `strict: true` in TypeScript. Ungewohnt war Wert-Typen vs. Referenz-Typen explizit denken zu müssen
types versus reference types (`struct` vs. `class` with real behavioural consequences), and generics with constraints (`struct` vs. `class` mit echten Verhaltens-Konsequenzen), und Generics mit Constraints sind syntaktisch anders genug,
are syntactically different enough that I stumble on them while reading. `async`/`await` is semantically similar, but dass ich beim Lesen kurz stocke. `async`/`await` ist semantisch ähnlich, aber Threading-Modelle sind in C# expliziter:
threading models are more explicit in C#: `Task.Run`, `ConfigureAwait`, synchronization contexts. That cost me several `Task.Run`, `ConfigureAwait`, Synchronization-Contexts. Das hat mich mehrere Bugs gekostet, bevor ich verstanden hatte,
bugs before I understood when the main thread (in plugin land: the framework tick) is actually critical. wann der Main-Thread (in Plugin-Welt: der Framework-Tick) wirklich kritisch ist.
### Build toolchain: similar, but different ### Build-Toolchain: ähnlich, aber anders
`dotnet` CLI, csproj XML, NuGet are functionally not far from npm and tsconfig. But the XML format of csproj is a `dotnet` CLI, csproj-XML, NuGet sind funktional nicht weit weg von npm und tsconfig. Aber das XML-Format der csproj ist
different language than JSON configs. The lock file (`packages.lock.json`) had to be actively enabled eine andere Sprache als JSON-Configs. Die Lock-Datei (`packages.lock.json`) musste ich erst aktiv aktivieren
(`RestorePackagesWithLockFile=true`); that is not the default. In the web stack, lock-file-first is standard, in the (`RestorePackagesWithLockFile=true`); das ist nicht Default. Im Web-Stack ist Lock-File-First Standard, im .NET-Stack
.NET stack apparently not. That was a real surprise. offenbar nicht. Das war eine echte Überraschung.
### ImGui is a different world ### ImGui ist eine andere Welt
Immediate-mode rendering has nothing in common with React component trees. There is no virtual DOM, no reconciliation, Immediate-Mode-Rendering hat mit React-Component-Trees nichts gemein. Es gibt keine virtuelle DOM, keine Reconciliation,
no "component state". Every frame the code redraws the UI from scratch, and state lives either in local variables I keinen "State der Komponente". Pro Frame zeichnet der Code die UI komplett neu, und der State lebt entweder in lokalen
manage myself or in ImGui's own ID stack logic. Variablen, die ich selbst verwalten muss, oder in der ImGui-eigenen ID-Stack-Logik.
What is two lines of `useState` in React is a member field plus manual ID stamps on widgets in ImGui, otherwise two Was in React zwei Zeilen `useState` sind, ist in ImGui ein Member-Field plus manuelle ID-Stempel auf den Widgets, sonst
selectables in the same loop collide because they fall back to the same ID. The ID stack collision in `SearchSelector` kollidieren zwei Selectables in derselben Loop, weil sie auf die gleiche ID zurückfallen. Die ID-Stack-Kollision in
(fixed in v1.0.0) was exactly that symptom: all selectables fell back to the same ambiguous ID until I mixed the row `SearchSelector` (gefixt in v1.0.0) war genau dieses Symptom: Alle Selectables fielen auf dieselbe ambiguous ID zurück,
index into the PushID. Classic "why is the wrong entry getting clicked" bug that you only find once you understand how bis ich den Row-Index in den Push-ID gemixt habe. Klassischer "warum klickt der falsche Eintrag"-Bug, den man nur
ImGui handles IDs internally. findet, wenn man verstanden hat, wie ImGui IDs intern handhabt.
### Dalamud specifics ### Dalamud-Spezifika
Plugin lifecycle, IPC subscriber pattern, hook system for game functions, game object threading. Much of that was only Plugin-Lifecycle, IPC-Subscriber-Pattern, Hook-System für Game-Functions, Game-Object-Threading. Viel davon war nur
understandable through reading the upstream codebase and through [dalamud.dev](https://dalamud.dev). Search results for durch Lesen der Upstream-Codebase und durch [dalamud.dev](https://dalamud.dev) zu verstehen. Meine Trainings- und
"Dalamud" often turn up outdated API examples from old versions. dalamud.dev is the reliable source. If someone is just Such-Ergebnisse für "Dalamud" liefern oft veraltete API-Beispiele aus alten Versionen. dalamud.dev ist die zuverlässige
starting out: go there, not to Stack Overflow. Quelle. Wenn jemand neu anfängt: dort hin, nicht zu Stack Overflow.
### The day DalamudPackager cost me a day ### Der Tag, an dem mich der DalamudPackager einen Tag gekostet hat
Dalamud SDK 15 ships its own default packager that writes icons and image URLs into the manifest. I had carried over a Dalamud SDK 15 liefert seinen eigenen Default-Packager mit, der Icons und Image-URLs ins Manifest einträgt. Ich hatte
`DalamudPackager.targets` file from the upstream repo with a `HandleImages` override, and it was overriding the SDK aus dem Upstream-Repo eine eigene `DalamudPackager.targets`-Datei mit `HandleImages`-Override übernommen, und die hat
default. Result: the manifest had no `IconUrl` anymore, and the plugin appeared in the plugin list without an icon. den SDK-Default überschrieben. Resultat: Das Manifest hatte keinen `IconUrl` mehr, und das Plugin tauchte in der
Plugin-Liste ohne Icon auf.
The symptom was easy to spot, the cause cost a day. I had treated the override file as mandatory when it was not. Symptom war einfach zu sehen, Ursache hat einen Tag gekostet. Ich hatte die Override-Datei für eine Pflicht-Datei
Removed in v0.5.2, SDK default running since then. Lesson: start with defaults, add overrides only when the default gehalten, war sie aber nicht. Removal in v0.5.2, seitdem läuft der SDK-Default. Lektion: Erstmal mit Defaults arbeiten,
demonstrably does not fit. Overrides erst wenn der Default nachweislich nicht passt.
--- ---
## What I learned from the fork ## Was ich aus dem Fork gelernt habe
### Refactoring in an unfamiliar codebase ### Refactor in einer fremden Codebase
The standalone cut in v1.0.0 migrated the entire `ChatTwo.*` identity to `HellionChat.*`. That sounds like find and Der Standalone-Cut in v1.0.0 hat die `ChatTwo.*`-Identität komplett auf `HellionChat.*` migriert. Klingt nach
replace. It was not. Find-and-Replace. War es nicht.
In concrete terms: code namespace across all 80 source files plus 100 using directives plus two FQN aliases plus the Konkret bedeutete das: Code-Namespace über alle 80 Source-Files plus 100 using-Direktiven plus zwei FQN-Aliases plus die
resource designer strings. Six IPC channels renamed (breaking change for third-party plugins, no known integrations). Resource-Designer-Strings. Sechs IPC-Channels umbenannt (Breaking Change für Drittplugins, keine bekannten Anbindungen).
Repo folder structure (`ChatTwo/` -> `HellionChat/`) including csproj, sln, all GitHub workflows and dependabot.yml. Repo-Ordner-Struktur (`ChatTwo/` `HellionChat/`) inklusive csproj, sln, allen GitHub-Workflows und der dependabot.yml.
Public-facing branding in README, repo.json and yaml reformulated to standalone framing. Public-Facing-Branding in README, repo.json, yaml auf Standalone-Framing umformuliert.
It was not a solo find-and-replace because Unicode string paths in workflow YAMLs need different quoting than C# Das war kein Solo-Find-and-Replace, weil Unicode-String-Pfade in Workflow-YAMLs anders quotiert werden müssen als
strings. Because resource designer files have generated content that not every toolchain tracks. And because the C#-Strings. Weil Resource-Designer-Files generierte Inhalte haben, die nicht jede Toolchain im Blick hat. Und weil die
`ChatTwo.*` IPC channel names are strings in `GetIpcSubscriber` calls: no symbol, no compile error if you miss one. That `ChatTwo.*`-IPC-Channel-Namen Strings in `GetIpcSubscriber`-Calls sind: kein Symbol, kein Compile-Error, wenn man einen
is when you find out what stays quiet. vergisst. Da merkst du, was alles still bleibt.
### Security is no longer abstract ### Sicherheit ist kein abstraktes Thema mehr
Before this project, supply chain security was academic for me. Three concrete lessons changed that. Vor diesem Projekt war Supply-Chain-Sicherheit für mich akademisch. Drei konkrete Lektionen haben das geändert.
**SQLite native binary.** I had to pin to 3.50.3 (`SQLitePCLRaw.lib.e_sqlite3` override) because `Microsoft.Data.Sqlite` **SQLite-Native-Binary.** Ich musste auf 3.50.3 pinnen (`SQLitePCLRaw.lib.e_sqlite3` Override), weil
was pulling in a transitively referenced library at a version containing CVE-2025-6965 (memory corruption via aggregate `Microsoft.Data.Sqlite` die transitiv nachgezogene Lib in einer Version mitschleppte, die CVE-2025-6965
term overflow) and CVE-2025-7709. The managed wrapper was new; the native library was not. Lesson: transitive (Memory-Corruption durch Aggregate-Term-Overflow) und CVE-2025-7709 enthielt. Der Managed-Wrapper war neu, die
dependencies do not audit themselves, you have to look. Native-Lib war es nicht. Lektion: Transitive Dependencies prüfen sich nicht von selbst, du musst hinschauen.
**Lock file drift.** `packages.lock.json` honoured via `RestorePackagesWithLockFile=true` in the csproj prevents **Lock-File-Drift.** `packages.lock.json` honored bei `dotnet restore` (per `RestorePackagesWithLockFile=true` in der
transitive versions from silently drifting between my machine and CI. I only understood why this is not the default csproj) verhindert, dass transitive Versionen zwischen meiner Maschine und CI silent driften. Erst nach einem
after a build output mismatch between local and GitHub Actions. Build-Output-Mismatch zwischen lokal und GitHub-Actions hatte ich überhaupt verstanden, warum das nicht der Default ist.
**WrapText and the CodeQL alert that cost three releases.** CodeQL flagged a critical alert in `ImGuiUtil.WrapText` for **WrapText und der CodeQL-Alarm der drei Releases gekostet hat.** CodeQL hat in `ImGuiUtil.WrapText` einen
unvalidated local pointer arithmetic. v0.5.2 validated an edge case. Alert came back. v0.5.3 checked buffer length via Critical-Alert wegen "unvalidated local pointer arithmetic" geworfen. v0.5.2 hat einen Edge-Case validiert. Alert kam
`GetByteCount` before the pointer math. Alert came back. v0.5.4 rebuilt the whole algorithm on `Span` and int offsets wieder. v0.5.3 hat den Buffer-Length via `GetByteCount` vor der Pointer-Math gecheckt. Alert kam wieder. v0.5.4 hat den
with a 16 KiB cap on the ArrayPool rent. Only then did it go quiet. ganzen Algorithmus auf `Span` und int-Offsets umgebaut, mit einem 16-KiB-Cap auf den ArrayPool-Rent. Erst da war Ruhe.
Lesson: when a static analyser complains three times in a row, the analyser is not oversensitive. The data flow logic Lektion: Wenn ein statischer Analyzer drei Mal hintereinander meckert, ist nicht der Analyzer überempfindlich. Die
is. Datenflusslogik ist es.
### CodeRabbit as an external code reviewer ### CodeRabbit als externer Code-Reviewer
The v1.0.0 sweep surfaced 3 critical and 21 major findings. Three classes were particularly instructive: Der v1.0.0-Sweep hat 3 Critical und 21 Major Findings hochgespült. Drei Klassen davon waren besonders lehrreich:
- **`Equals` methods comparing `GetHashCode()`.** Classic hash collision anti-pattern. Sounds like "if hashes are equal - **`Equals`-Methoden die `GetHashCode()` vergleichen.** Klassisches Hash-Kollisions-Anti-Pattern. Klingt nach "ist doch
the objects are equal", which is exactly backwards. Hashes can collide; the objects are not equal. egal, wenn Hashes gleich sind, sind die Objekte auch gleich", ist aber genau falsch. Hashes können kollidieren,
- **`Dispose` methods that only unsubscribe part of their subscriptions.** Leak on every plugin reload. In normal use Objekte sind dann nicht gleich.
you do not notice it immediately; in a long-running test you do. - **`Dispose`-Methoden die nur einen Teil der Subscriptions wieder abmelden.** Leak bei jedem Plugin-Reload. Im
- **TOCTOU races.** Between a bounds check and a read another thread can swap out the array underneath you Nutzer-Alltag merkst du das nicht sofort, im Long-Running-Test schon.
- **TOCTOU-Races.** Zwischen Bounds-Check und Read kann ein anderer Thread das Array unter dir austauschen
(`GlobalParametersCache`, `AutoTranslate`). (`GlobalParametersCache`, `AutoTranslate`).
I had at best read the theory on all of these before, never diagnosed them in my own code. CodeRabbit was the moment Davon hatte ich vorher bestenfalls die Theorie gelesen, nicht selbst diagnostiziert. CodeRabbit war für mich der Moment,
where "academic knowledge" became "okay, that is my code, that is my bug". wo "akademisches Wissen" zu "okay, das ist mein Code, das ist mein Bug" wurde.
### External testers are worth their weight ### Externe Tester sind ihr Gewicht in Gold wert
Carla's feedback on pop-out discoverability triggered the header button in v0.6.1. That pop-outs were only reachable via Carlas Feedback zur Pop-Out-Discoverability hat den Header-Button in v0.6.1 ausgelöst. Dass Pop-Outs nur per Rechtsklick
right-click was something I as maintainer had stopped seeing; I knew the path by heart. Carl's request for theme erreichbar waren, hatte ich als Maintainer nicht mehr gesehen, ich kannte den Pfad blind. Carls Wunsch nach
variants with brightness gradations shifted my thinking from "one theme = one colour" to "theme families with mood Theme-Varianten mit Helligkeits-Abstufungen hat mein Verständnis von "ein Theme = eine Farbe" auf "Theme-Familien mit
variants". Jingliu asked for TempTell persistence, which puts the tab system architecturally into question. Stimmungs-Varianten" verschoben. Jingliu hat TempTell-Persistence gefordert, was das Tab-System architektonisch in Frage
stellt.
Solo I would not have seen any of those three things. Full stop. Solo hätte ich diese drei Dinge nicht erkannt. Punkt.
### release.yml and the YAML rabbit hole ### release.yml und die Markdown-Hölle
The `release.yml` workflow simply did not fire on the first v0.6.0 tag push. I dug through permissions, secret scopes Der `release.yml`-Workflow ist beim ersten v0.6.0-Tag-Push einfach nicht losgegangen. Ich habe Stunden in Permissions,
and tag trigger configuration for hours before I understood what was actually happening: the PowerShell heredoc footer Secret-Scopes und Tag-Trigger-Konfiguration gegraben, bevor ich verstand, was eigentlich los war: Der
in the "Generate release body" step contained a `---` Markdown horizontal rule at column 1, and that terminated the YAML PowerShell-Heredoc-Footer im "Generate release body"-Step enthielt eine `---`-Markdown-Horizontal-Rule an Spalte 1, und
block scalar of `run: |`. GitHub could not parse the workflow file, so the push-tag trigger never registered. genau das hat das YAML-Block-Scalar von `run: |` beendet. GitHub konnte die Workflow-Datei nicht parsen, also hat der
Push-Tag-Trigger nie registriert.
Fix: extracted the footer into an external `.github/release-footer.md`, workflow reads it via `Get-Content`. Lesson: if Fix: Footer in eine externe `.github/release-footer.md` extrahiert, Workflow liest sie via `Get-Content` ein. Lektion:
a workflow does not trigger, verify first that GitHub can even parse the file. That was one of the bugs where I laughed Wenn ein Workflow nicht triggert, verifiziere als Erstes, dass GitHub die Datei überhaupt parsen kann. Das war einer der
briefly after the fix and then asked myself how many other YAML files I had that might have the same trap in them. Bugs, bei denen ich nach dem Fix kurz gelacht habe und mich dann gefragt, wie viele andere YAML-Dateien ich noch habe,
die so eine Falle drin haben könnten.
--- ---
## What I am still learning ## Was ich noch lerne
### Performance profiling in a game context ### Performance-Profiling im Game-Context
The FPS drop bug from upstream Chat 2 ([#145](https://github.com/Infiziert90/ChatTwo/issues/145)) has not been Der FPS-Drop-Bug aus Upstream Chat 2 ([#145](https://github.com/Infiziert90/ChatTwo/issues/145)) ist auch in Hellion
reproduced or verified in Hellion Chat. v1.0.0 applied several fixes on the suspected paths (DbViewer O(N²) -> O(N), Chat noch nicht reproduziert oder verifiziert. v1.0.0 hat mehrere Fixes auf den verdächtigen Pfaden (DbViewer O(N²)
AutoTranslate lock serialisation, EmoteCache HttpClient reuse), but systematic measurement under load is missing. I O(N), AutoTranslate Lock-Serialisierung, EmoteCache HttpClient-Reuse), aber das systematische Vermessen unter Last fehlt
still need to learn how to properly measure what is actually consuming the frame budget in a plugin context. mir. Ich muss noch lernen, wie man im Plugin-Kontext sauber misst, was wirklich das Frame-Budget frisst.
### Native interop and pointer math ### Native-Interop und Pointer-Math
Even after the WrapText Span refactor in v0.5.4, pointer math makes me uneasy. ImGui forces you into `unsafe` code in Auch nach dem WrapText-Span-Refactor in v0.5.4 ist mir Pointer-Math unsicher. ImGui zwingt einen an mehreren Stellen in
several places, and the safety margin from the "unbounded ArrayPool allocation" class of bugs is narrower than I would `unsafe`-Code, und der Sicherheitsabstand zur "unbounded ArrayPool allocation"-Klasse von Bugs ist schmaler als mir lieb
like. I want to get better at that before touching deeper ImGui custom drawing. ist. Da will ich besser werden, bevor ich tieferes ImGui-Custom-Drawing anfasse.
### Test discipline for plugin code ### Test-Disziplin für Plugin-Code
The repo currently has no test project. That is a deliberate decision, not a forgotten one. Testing plugin code with Aktuell hat das Repo kein Test-Projekt. Das ist eine bewusste Entscheidung, keine vergessene. Plugin-Code mit
FFXIV hooks and Dalamud lifecycle cleanly is non-trivial, and I had not found an approach that made sense without a FFXIV-Hooks und Dalamud-Lifecycle sauber zu testen ist nicht trivial, und ich hatte keinen Ansatz gefunden, der ohne
large mocking scaffold. Privacy filter and configuration migration would be good test candidates because they are riesiges Mocking-Gerüst sinnvoll wirkte. Privacy-Filter und Configuration-Migration wären gute Testkandidaten, weil sie
isolated. On the list, but not a quick win. isoliert sind. Steht auf der Liste, ist aber kein Quick-Win.
### Linux quirks under Wine ### Linux-Eigenheiten unter Wine
XDG compliance, libnotify integration, WireGuard network detection, all on the [roadmap](ROADMAP.md), and all XDG-Compliance, libnotify-Integration, WireGuard-Network-Detection, alles in der [Roadmap](ROADMAP.md), und alles
technically still unclear. Wine and sandboxed plugin code do not share all system APIs, and I do not know where the technisch noch nicht ganz klar. Wine und sandboxed Plugin-Code teilen nicht alle System-APIs, und ich weiß nicht, wo die
pitfalls are until I have found them. Stolperfallen liegen, bevor ich sie gefunden habe.
--- ---
## Use of AI tools ## Einsatz von AI-Tools
I use Claude Code as an assistant, not as a replacement for my own work. Ich verwende Claude Code als Hilfsmittel, nicht als Ersatz für eigene Arbeit.
**What I use AI for:** **Wofür ich AI einsetze:**
- Debugging problems where I am stuck after extended research of my own - Debugging von Problemen, bei denen ich nach längerer Eigenrecherche nicht weiterkomme
- Pattern recognition across large codebases (e.g. the ChatTwo -> HellionChat sweep across 80 files) - Mustererkennen über große Codebasen hinweg (z. B. der ChatTwoHellionChat-Sweep über 80 Dateien)
- Understanding questions on C# and Dalamud concepts I am not yet familiar with - Verständnisfragen zu C#- und Dalamud-Konzepten, die mir noch nicht geläufig sind
- Code review sparring before I run CodeRabbit on something - Code-Review-Sparring, bevor ich CodeRabbit drauflasse
**What I do myself:** **Was ich selbst mache:**
- Architecture and design decisions - Architektur und Designentscheidungen
- Privacy-first defaults and the threat model behind them - Privacy-First-Defaults und das Threat-Model dahinter
- Tester communication and roadmap prioritisation - Tester-Kommunikation und Roadmap-Priorisierung
- Reviewing, verifying, pushing - Reviewen, Verifizieren, Pushen
Classification and concrete examples are in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md). It matters to me that users and Die Klassifikation und konkrete Beispiele stehen in [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md). Mir ist wichtig, dass Nutzer
potential contributors understand how the code came together, especially for a plugin that handles user data. und potenzielle Beiträger verstehen, wie der Code zustande gekommen ist, gerade bei einem Plugin, das mit Nutzerdaten
arbeitet.
Yes, AI. Yes, alone. Both mentioned more than strictly necessary. Welcome to the open-source plugin climate. Ja, AI. Ja, alleine. Beides öfter erwähnt als nötig. Willkommen im Open-Source-Plugin-Klima.
--- ---
## Why this transparency ## Warum diese Transparenz
Anyone reading the source code should know: Wer sich den Quellcode ansieht, soll wissen:
- I am not a professional C# or plugin developer and am still learning - Ich bin kein professioneller C#- oder Plugin-Entwickler und lerne weiterhin dazu
- AI assistance is a tool, not a ghostwriter - AI-Unterstützung ist ein Werkzeug, kein Ghostwriter
- The privacy position, the design decisions and the roadmap are mine - Die Privacy-Position, die Designentscheidungen und die Roadmap sind meine
- I try to keep my code as clean and secure as my current skills allow - Ich versuche, meinen Code so sauber und sicher zu halten, wie meine aktuellen Fähigkeiten es zulassen
Hellion Chat is also a learning project, and that should be visible in the repository. Hellion Chat ist auch ein Lernprojekt, und das soll man dem Repository ansehen dürfen.
--- ---
## Links ## Verlinkungen
- [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md) -- AI pair disclosure with classification schema - [`AI_DISCLOSURE.md`](AI_DISCLOSURE.md) — KI-Pair-Disclosure mit Klassifikations-Schema
- [`CONTRIBUTORS.md`](CONTRIBUTORS.md) -- who has made this plugin better alongside me - [`CONTRIBUTORS.md`](CONTRIBUTORS.md) — wer hat dieses Plugin neben mir besser gemacht
- [`../NOTICE.md`](../NOTICE.md) -- attribution to Infi and Anna for the Chat 2 foundation - [`../NOTICE.md`](../NOTICE.md) — Anerkennung an Infi und Anna für das Chat-2-Fundament
- [`ROADMAP.md`](ROADMAP.md) -- planned cycles and topics - [`ROADMAP.md`](ROADMAP.md) — geplante Cycles und Themen
+132 -178
View File
@@ -1,220 +1,174 @@
# Hellion Chat — Roadmap # Hellion Chat — Roadmap
Planned work after the v1.0.0 standalone cut. This list is intentionally high-level: concrete specs, size estimates and Geplante Arbeit nach dem v1.0.0 Standalone-Cut. Diese Liste ist absichtlich grob: konkrete Specs, Größenschätzungen und
repro steps live in the internal backlog. External tracking runs via Repro-Steps liegen im internen Backlog. Tracking nach außen läuft über
[Gitea Issues](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues) with the `roadmap` label once an [Gitea Issues](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues) mit dem `roadmap`-Label, sobald
item is scheduled for a cycle. ein Item für einen Cycle eingeplant ist.
Order reflects priority, not a guarantee. Items may shift or be dropped entirely if they turn out to be a poor fit for Reihenfolge ist Priorität, nicht Garantie. Items können sich verschieben oder ganz wegfallen wenn sie sich beim
the plugin's privacy-first scope during brainstorming. Brainstorm als nicht passend zur Privacy-First-Schnittmenge des Plugins erweisen.
--- ---
## Next Cycle (v1.4.7) ## Nächster Cycle (v1.4.4)
**Backlog Cleanup.** Roll up the remaining audit items deferred from v1.4.0v1.4.6 and the new entries surfaced during **Window-Lazy-Open + Render-Init-Cost-Optimisation** — die in v1.4.3 gelegte IAsyncDalamudPlugin-Foundation jetzt für
v1.4.6 (notably the `Plugin.Log` indirection that would unlock fully isolated `MessageStore` construction tests, plus die echten User- spürbaren Wins nutzen. Window-Konstruktion erst beim ersten Open, Render-Path-Init-Kosten in den ersten
follow-up scope hinted at in the ChatTwo upstream f35b7d3 cherry-picks). Scope is consolidated during brainstorm. Frames runter. Konkrete Kandidaten und Größenschätzungen werden im v1.4.4-Brainstorm konsolidiert.
---
## v1.4.6 — Code Hygiene and Refactor (released 2026-05-12)
Seventh sub-patch of the v1.4.x Polish Sweep series. Maintenance patch — no user-visible behaviour changes; tightens
the development feedback loop and pulls in two ChatTwo upstream bugfixes. `scripts/preflight.sh` gains a csharpier
reflow check (Block E) and a markdownlint pass (Block F), so style drift and markdown violations are blocked at the
pre-push gate. `FontManager.AddFontWithFallback` catch-filter now spans `InvalidOperationException` and
`ArgumentException` on top of the existing IO triad, with the exception type name in the warning log so the
diagnostic path can see which atlas-toolkit throw triggered the fallback. `BrandingLinks` and `IntegrationLinks` run a
`[ModuleInitializer]` URL validation pass on plugin load; a typo in a future URL rotation now throws at startup
instead of failing silently when a user clicks the broken button. Cherry-picked from ChatTwo upstream `f35b7d3`:
`Chat.SetChannel` no longer leaks the native `Utf8String` when the linkshell check rejects the channel (rename to
`IsChannelOrExistingLinkshell` plus wrap-not-return), and `Tab.Clone` now deep-clones `UsedChannel` and `TellTarget`
(the previous reference copy let PopOut and Temp tabs mutate each other's channel state). The `ChatLogWindow`
active-tab underline pill scales with `ImGuiHelpers.GlobalScale` and rounds to physical pixels for crisp rendering
above 100 % DPI. Internal items: `HellionStyle` ChildBgAlpha extracted to a testable helper, `Plugin.SaveConfig`
clones only the temp-tab subset in the snapshot path, `SettingsOverview` caches the draw-list per frame,
`Dalamud.Utility.Util` static surface routed through an `IPlatformUtil` indirection (`MessageStore`'s `IsWine` probe
is now testable in isolation). No schema bump, no migration.
## v1.4.5 — UX and Robustness (released 2026-05-12)
Sixth sub-patch of the v1.4.x Polish Sweep series. User-visible robustness polish plus two doc/test polish items from
the audit backlog. Chat-log draw failures now surface as a one-shot notification instead of failing silently. The
first-run wizard splits accept from close: `OnClose` no longer silently sets `FirstRunCompleted`, and a new footer
"Later — keep defaults" button is the explicit path to dismiss without picking a profile. `InputHistoryService` clears
on plugin dispose so the previous session's typed commands don't bleed into the next load. `FontManager` falls back to
the system font path if the embedded Hellion font resource is missing (broken-csproj / dev-build only). The status bar
hides the version slot when the chat window is too narrow to fit all five slots without overlap. Plus
`Plugin.cs:167-168` gains an explicit session-only Auto-Tell-Tab invariant comment with a `TempTabCounter.InitFromList`
pin in the Build-Suite. No schema bump, no migration.
## v1.4.4 — Threading and IPC Safety Polish (released 2026-05-12)
Fifth sub-patch of the v1.4.x Polish Sweep series. `AutoTellTabsService.ActiveTempTabCount` switches from a
lock-protected LINQ `Count` to an `Interlocked` counter kept in sync from inside the existing mutation paths;
`Initialize()` seeds from the persisted Tabs list and `SaveConfig`'s snapshot-restore path calls a new
`ResyncTempTabCounter()` after the mid-step `RemoveAll`. `HonorificService` carries per-method threading banners and
`TryUnsubscribe`'s log level moves from Debug to Warning. `AutoTranslate.PreloadCache` is marked `IsBackground = true`
so plugin unload no longer waits for it. `Configuration.IsAllowedForStorage` logs once per unknown ChatType via a
`NonSerialized` `HashSet`, and `PrivacyPersistUnknownChannels` default flips to `true` for new installs. No schema bump,
no migration.
## v1.4.3 — Plugin-Load Async-Init + Repo-Cutover (released 2026-05-08) ## v1.4.3 — Plugin-Load Async-Init + Repo-Cutover (released 2026-05-08)
Fourth and largest sub-patch of the v1.4.x Polish Sweep series. Plugin migrated to Dalamud's `IAsyncDalamudPlugin` API: Vierter und größter Sub-Patch der v1.4.x Polish-Sweep-Serie. Plugin auf Dalamud's IAsyncDalamudPlugin-API migriert: der
the constructor handles only bootstrap essentials (config load, language init, conflict detection); migrations, service Konstruktor übernimmt nur noch Bootstrap-Essentials (Config-Load, Language-Init, Conflict-Detection), Migrationen,
allocations, window construction and hook subscription move to `LoadAsync`. Schema gate replaces the v9 → v16 migration Service-Allokationen, Window- Konstruktion und Hook-Subscription wandern in LoadAsync. Schema- Gate ersetzt die v9 → v16
chain; configs on schema v16+ load directly, older configs trigger an "install v1.4.2 first" error. Migrations-Kette; Configs auf Schema v16+ laden direkt, ältere Configs triggern eine "install v1.4.2
`AutoTranslate.PreloadCache` moved off the load path. `FontManager.BuildFonts` runs sync at the start of `LoadAsync`; first"-Fehlermeldung. AutoTranslate.PreloadCache vom Load-Pfad runter. FontManager.BuildFonts läuft sync am Start von
Dalamud rebuilds the font atlas on its own pipeline. Custom-repo URL cut over to `gitea.hellion-forge.cloud`; the GitHub LoadAsync, Dalamud baut den Font-Atlas auf seiner eigenen Pipeline. Custom-Repo-URL auf `gitea.hellion-forge.cloud`
repo remains as a frozen v1.4.2 snapshot. Plugin load time sits at ~3.7 s median (5 reloads), comparable to v1.4.2 — the cut-over, das GitHub-Repo bleibt als eingefrorener v1.4.2-Snapshot stehen. Plugin-Load-Zeit liegt bei ~3.7 s Median (5
async migration is a foundation for v1.4.4 lazy-init optimisations rather than an immediate user-perceived win. Reloads), vergleichbar mit v1.4.2: Async-Migration ist Foundation für v1.4.4 Lazy-Init- Optimierungen, kein direkter
User-spürbarer Win.
## v1.4.2 — ChatLog Frame-Hot-Path (released 2026-05-08) ## v1.4.2 — ChatLog Frame-Hot-Path (released <Datum>)
Third sub-patch of the v1.4.x Polish Sweep series. Per-frame allocations eliminated from the ChatLogWindow render path Dritter Sub-Patch der v1.4.x Polish-Sweep-Serie. Per-Frame- Allokationen aus dem ChatLogWindow-Render-Pfad und der
and the settings status bar. Card-mode border loop in `DrawMessages` hoists five invariants into a pre-loop hoist; Settings-StatusBar eliminiert. Card-Mode-Border-Loop in DrawMessages hebt fünf Invarianten in einen Pre-Loop-Hoist,
`AutoTellTabTint` gets a per-tab cache via `TabTintCache` (separate validation keys per cache, no cross-invalidation); AutoTellTabTint bekommt einen Per-Tab-Cache via TabTintCache (separate Validation-Keys pro Cache, kein
status bar moves the cache-gate check before the aggregation and replaces LINQ `Sum`+`Count` with a single-pass foreach. Cross-Invalidation), StatusBar zieht den Cache-Gate-Check vor die Aggregations und ersetzt LINQ Sum+Count durch eine
Single-Pass-Foreach.
## v1.4.1 — Theme Engine Performance (released 2026-05-08) ## v1.4.1 — Theme Engine Performance (released <Datum>)
Second sub-patch of the v1.4.x Polish Sweep series. ABGR cache pre-computed on theme records; `HellionStyle.PushGlobal` Zweiter Sub-Patch der v1.4.x Polish-Sweep-Serie. ABGR-Cache auf den Theme-Records pre-computed, HellionStyle.PushGlobal
reads from the cache instead of converting per slot per frame. **~13 % render-time recovery** in smoke tests (plan liest aus dem Cache statt pro Slot pro Frame zu konvertieren. **~13 % Render-Time-Recovery** im Smoke-Test
estimate of 26 % was conservative; real result ~1015 %). Custom-theme hot-reload survives transient file locks via (Plan-Erwartung 2-6 % war konservativ, real ~10-15 %). Custom-Theme-Hot-Reload überlebt transient File-Locks via
last-known-good snapshot. Plus: Synthwave Sunset as the tenth built-in, author credits consolidated under Hellion Forge, Last-Known-Good-Snapshot. Plus: Synthwave Sunset als zehnter Built-In, Author-Credits auf Hellion Forge konsolidiert,
Mint Grove + Forge Merchantman credited to Carla Beleandis as a community thanks. Mint Grove + Forge Merchantman auf Carla Beleandis als Community-Thanks.
## v1.4.0 — Critical Lifecycle Fixes (released 2026-05-07) ## v1.4.0 — Critical Lifecycle Fixes (released 2026-05-07)
First sub-patch of the v1.4.x Polish Sweep series. Seven P0 findings from audit passes 3 and 4 resolved: async-void Erster Sub-Patch der v1.4.x Polish-Sweep-Serie. Sieben P0- Findings aus Audit-Pass-3 und Pass-4 abgearbeitet:
loads, missing `IsBackground` flags, `GC.Collect` in Dispose, deferred-save race and pre-v13 backup lookup for async-void-Loads, fehlende IsBackground-Flags, GC.Collect in Dispose, DeferredSave-Race und Pre-v13-Backup-Lookup für
`WindowOpacity`. No schema bumps, no user-facing behaviour changes other than reload and shutdown running noticeably WindowOpacity. Keine Schema-Bumps, keine Funktions- Änderungen für den User außer dass Reload und Shutdown spürbar
cleaner. sauberer laufen.
## v1.3.0 Plugin Integrations: Honorific (released 2026-05-07) ## v1.3.0 - Plugin Integrations: Honorific (released 2026-05-07)
First cycle of the plugin integrations roadmap. Honorific custom titles displayed in the chat header with auto-detect Erster Cycle der Plugin-Integrations-Roadmap. Honorific-Custom- Titles werden im Chat-Header angezeigt, mit Auto-Detect
and silent fallback. New Integrations settings tab. Pattern-setter for the five following cycles (Context Menu, und silent Fallback. Neuer Integrations-Settings-Tab. Pattern- Etablierer für die fünf folgenden Cycles (Context-Menu,
NotificationMaster, RP Status Block, ExtraChat, XIVIM). NotificationMaster, RP-Status-Block, ExtraChat, XIVIM).
Spec: [Plugin Integrations Overview](../Hellion%20Chat%20Plugin-Integrationen.md) Spec: [Plugin-Integrationen-Übersicht](../Hellion%20Chat%20Plugin-Integrationen.md)
## v1.2.3 — Theme Expansion (released 2026-05-06) ## v1.2.3 — Theme Expansion (released 2026-05-06)
Four new built-in themes: Night Blue, Indigo Violet, Forge Merchantman, Hellion Spectrum (Deuteran/Protan-safe). No Vier neue Built-In-Themes: Night Blue, Indigo Violet, Forge Merchantman, Hellion Spectrum (Deuteran/Protan-safe). Keine
engine changes. See `docs/CHANGELOG.md`. Engine-Änderungen. Siehe `docs/CHANGELOG.md`.
(v1.2.2 was burned because the `repo.json` manifest was not bumped in sync on the first pushre-released as v1.2.3 (v1.2.2 wurde verbrannt weil das `repo.json`-Manifest beim ersten Push nicht synchron mitgebumpt wurdeRe-Release als
with full manifest synchronisation.) v1.2.3 mit kompletter Manifest-Synchronisation.)
## v1.2.1 — Settings Cleanup (released 2026-05-06) ## v1.2.1 — Settings Cleanup (released 2026-05-06)
Settings re-sorted thematically (9 cards), 4 dead settings removed, auto-migration v15 → v16 without data loss. Re-sortierte Settings (9 Cards thematisch), 4 tote Settings entfernt, Auto-Migration v15 → v16 ohne Daten-Verlust.
## v1.2.0 — Layout Refresh (released 2026-05-05) ## v1.2.0 — Layout Refresh (released 2026-05-05)
Top tabs refresh, sidebar tab icons, bottom status bar, card rows as default message render, auto-tell tab hashing. Top-Tabs-Refresh, Sidebar-Tab-Icons, Bottom-Status-Bar, Card-Rows als Default-Message-Render, Auto-Tell-Tab-Hashing.
## v1.1.0 — Theme Foundation (released 2026-05-05) ## v1.1.0 — Theme Foundation (released 2026-05-05)
Theme engine with five built-in themes, settings card grid, custom themes via JSON, theme authoring docs. Plugin icon Theme-Engine mit fünf Built-In-Themes, Settings-Card-Grid, Custom- Themes via JSON, Theme-Authoring-Doku. Plugin-Icon
updated to Hellion Forge hammer. See `docs/CHANGELOG.md` for details. auf Hellion Forge. Siehe `docs/CHANGELOG.md` für Details.
Items from the original v1.1.0 plan (ad-block / spam filter, receive-suppressed-tells toggle) were deferred in favour of Aus dem ursprünglichen v1.1.0-Plan (Ad-Block / Spam-Filter, Receive- Suppressed-Tells-Toggle) wurden zugunsten der
the theme engine — both items live on in the mid-term block. Theme-Engine zurück­ gestellt — beide Items leben weiter im Mittelfrist-Block.
## Mittelfristig (v1.4.x+)
- **Plugin-Integrations-Roadmap (Cycles 2-6)** - sechs Plugin- Integrationen geplant, Honorific (Cycle 1) ist live,
danach folgen Context-Menu, NotificationMaster, RP-Status-Block, ExtraChat und XIVIM in eigenen Cycles. Spec und
Cycle-Reihenfolge in [Plugin-Integrationen-Übersicht](../Hellion%20Chat%20Plugin-Integrationen.md).
- **Ad-Block / Spam-Filter** — Hybrid-Konzept aus eigenem Light-Filter und optionaler `NoSoliciting`-IPC-Integration.
Adressiert Werbe-Spam in öffentlichen Channels und Tells. Aus dem v1.1.0-Plan zurückgestellt.
- **Receive-Suppressed-Tells-Toggle** — Auto-Tell-Tabs greift auch wenn ein Drittplugin (z.B. XIVMessenger) die
/tell-Anzeige global suppressed. Gleicher Hook-Layer wie Ad-Block, deshalb gebündelt.
- **Database-Viewer Inline-Search** — Volltext-Suche im DB-Viewer via SQLite FTS5. Aktuell gibt es nur Datums- und
Channel-Filter.
- **TempTell Persistence** — Pin-Toggle auf TempTell-Tabs damit ausgewählte Tells einen Relog überleben. Tester-Wunsch
von Jingliu.
- **FontManager Async-Refactor**`LoadGameSymFontAsync` aus dem blockierenden Plugin-Constructor herausziehen.
Cold-Start-Hitching beim ersten Plugin-Start beheben (Severity niedrig, Plugin ist funktional).
- **Separate Opacity Active vs. Inactive** — zweiter Slider für inaktive Fenster-Deckkraft. Upstream lehnt das ab; wir
können hier anders entscheiden.
- **Failed-Tell-Notification** — sichtbare Nachricht bei /tell-Fail (offline, restricted instance, blacklisted,
world-mismatch) statt stillem Failure.
- **Per-Tab Sound-Notification** — Sound-Toggle und optional eigene .wav pro Tab, mit Mute-In-Combat-Option.
## Langfrist (v1.x+)
### Storage-Backends (drei Stufen Bestätigung)
- MySQL/MariaDB-Backend für Multi-Device-Setups
- PostgreSQL-Backend
- AES-256-Verschlüsselung für sensible Channels mit lokalem Key
### Linux-spezifisch
- WireGuard-Network-Detection als optionaler Filter-Trigger
- libnotify-Integration für native Linux-Toasts
- XDG-Compliance (komplex unter Wine)
### UX und Tab-Management
- **Regex Tab Routing** — Plugin-Output-Spam in eigene Tabs, Tells bestimmter Personen automatisch sortieren. Klar
abgegrenzt zum Ad-Block: Routing sortiert in Views, Block versteckt global.
- **Auto-Detect Duties** — Tab-Switch beim Duty-Start via Condition-Flag.
- **UX Bundle** — Vertical-Tab-Bar als Layout-Option, Shift+Mousewheel zum Tab-Header-Scrollen ohne Aktivierung,
globaler Hotkey zum Schließen des aktiven Tabs.
- **Configure Tab Title** — konfigurierbares Tab-Title-Format (Name / Name + abgekürzter World / voller Name / Custom),
pro Tab überschreibbar.
- **Name Display Options** — analog zu FFXIV-Vanilla (voller Name, Vorname abgekürzt, Initialen), per-Channel-Override
möglich.
- **Item & Flag Linking** — Outgoing: Shift-Klick auf Item/Flag sendet ins fokussierte Plugin-Input. Incoming:
Item-Links und Map-Coords klickbar.
- **Color Currently Selected Input Channel** — Channel-Selector-Button im Input-Bar mit Channel-Farbe einfärben.
- **Plugin-Disclosure Pre-Send Filter** — konfigurierbare Wort-/Regex-Liste blockiert das Senden mit Pre-Send-Confirm.
Schutz vor versehentlicher Plugin-Nennung in öffentlichen Channels.
- **Chat Clear on Name Change** — bei Charakter-Namensänderung lokalen Verlauf migrieren oder löschen, Default Wipe für
maximale Privacy.
- **Hide Plugin Window on NG+ Screen** — Hide-Logik um zusätzliche Addon-Namen erweitern.
- **Kick from Novice Network** — Mentor-Nische, Context-Menü-Eintrag mit Confirmation.
- **Text-to-Speech für /tell** — eingehende Tells via TTS, optional pro Sender, mit Channel-Filter und Mute-In-Combat.
Geringe Priorität.
### Distribution und Branding
- Hand-gezeichnetes Hellion-Logo (aktuell Platzhalter aus dem Hellion-Online-Media-Brand-Repo)
- GitHub Action für automatischen `repo.json`-Sync nach Tag-Push
- Submission ans Dalamud-Main-Plugin-Repo (zusätzlich zum Custom-Repo)
--- ---
## Mid-Term (v1.4.x+) ## Bug-Verifizierungen
- **Plugin Integrations Roadmap (Cycles 26)** — six plugin integrations planned; Honorific (Cycle 1) is live, followed Aus dem Upstream-Issue-Tracker übernommen, in Hellion Chat 1.0.0 noch nicht reproduziert oder verifiziert. Werden bei
by Context Menu, NotificationMaster, RP Status Block, ExtraChat and XIVIM in their own cycles. Spec and cycle order in Gelegenheit gegen den aktuellen Stand getestet.
[Plugin Integrations Overview](../Hellion%20Chat%20Plugin-Integrationen.md).
- **Ad-Block / Spam Filter** — hybrid concept combining a lightweight built-in filter with optional `NoSoliciting` IPC - **Right-Click Whisper Error** in Field Ops / Special Instances (Eureka, Bozja, Occult Crescent, DRS) — Upstream
integration. Addresses ad-spam in public channels and tells. Deferred from the v1.1.0 plan. [#168](https://github.com/Infiziert90/ChatTwo/issues/168). Reply-Helper scheint `@World`-Suffix zu schlucken.
- **Receive-Suppressed-Tells Toggle** — auto-tell tabs trigger even when a third-party plugin (e.g. XIVMessenger) - **FPS Drops with Plugin active** — Upstream [#145](https://github.com/Infiziert90/ChatTwo/issues/145). 1020 % Drop
globally suppresses /tell display. Same hook layer as ad-block, so they are bundled. seit upstream v1.29.19.0. v1.0.0 hat mehrere Fixes auf den verdächtigen Pfaden, Repro-Test gegen aktuellen Stand
- **Database Viewer Inline Search** — full-text search in the DB viewer via SQLite FTS5. Currently only date and channel offen.
filters are available. - **Add Blacklist from Plugin Window** — Upstream [#140](https://github.com/Infiziert90/ChatTwo/issues/140). Right-Click
- **TempTell Persistence** — pin toggle on TempTell tabs so selected tells survive a relog. Tester request from Jingliu. Add-to-Blacklist wirft "Cannot locate character with that name", via Vanilla-Chat funktioniert es.
- **FontManager Async Refactor**move `LoadGameSymFontAsync` out of the blocking plugin constructor. Fix cold-start - **DB-Viewer Column Sort**sortiert State-Column lexikografisch statt numerisch (10 vor 2). XIVIM
hitching on first plugin load (low severity; plugin is functional). [#82](https://github.com/NightmareXIV/XIVInstantMessenger/issues/82), Repro in Hellion Chat offen.
- **Separate Opacity Active vs. Inactive** — second slider for inactive window opacity. Upstream declines this; we can
decide differently here.
- **Failed-Tell Notification** — visible message on /tell failure (offline, restricted instance, blacklisted,
world-mismatch) instead of silent failure.
- **Per-Tab Sound Notification** — sound toggle and optionally a custom .wav per tab, with mute-in-combat option.
--- ---
## Long-Term (v1.x+) ## Lizenz-Boundary
### Storage Backends (three-stage confirmation) Hellion Chat ist EUPL-1.2-lizenziert. Konzept-Imports aus AGPL-3.0-Plugins (z.B. XIV Instant Messenger) sind
ausschließlich architektonische Inspiration, kein Code-Port. Code-Imports aus dem Upstream-Bestand sind seit v1.4.x
- MySQL/MariaDB backend for multi-device setups abgeschlossen, weil Chat 2 in einem grundlegenden Rework ist und selektive Patches nicht mehr sauber portierbar sind.
- PostgreSQL backend Stand und Begründung in [`UPSTREAM_SYNC.md`](UPSTREAM_SYNC.md).
- AES-256 encryption for sensitive channels with a local key
### Linux-Specific
- WireGuard network detection as an optional filter trigger
- libnotify integration for native Linux toasts
- XDG compliance (complex under Wine)
### UX and Tab Management
- **Regex Tab Routing** — route plugin output spam into dedicated tabs, auto-sort tells from specific people. Clearly
scoped against ad-block: routing sorts into views, blocking hides globally.
- **Auto-Detect Duties** — tab switch on duty start via condition flag.
- **UX Bundle** — vertical tab bar as a layout option, Shift+Mousewheel to scroll tab headers without activating them,
global hotkey to close the active tab.
- **Configure Tab Title** — configurable tab title format (name / name + abbreviated world / full name / custom),
overridable per tab.
- **Name Display Options** — analogous to FFXIV vanilla (full name, first name abbreviated, initials), per-channel
override possible.
- **Item & Flag Linking** — outgoing: Shift-click on an item/flag sends it to the focused plugin input. Incoming: item
links and map coordinates are clickable.
- **Color Currently Selected Input Channel** — tint the channel-selector button in the input bar with the current
channel colour.
- **Plugin-Disclosure Pre-Send Filter** — configurable word/regex list blocks sending with a pre-send confirmation.
Protects against accidentally mentioning plugins in public channels.
- **Chat Clear on Name Change** — on character name change, migrate or wipe local history; default is wipe for maximum
privacy.
- **Hide Plugin Window on NG+ Screen** — extend hide logic to cover additional addon names.
- **Kick from Novice Network** — mentor niche; context menu entry with confirmation.
- **Text-to-Speech for /tell** — incoming tells via TTS, optionally per sender, with channel filter and mute-in-combat.
Low priority.
### Distribution and Branding
- Hand-drawn Hellion logo (currently a placeholder from the Hellion Online Media brand repo)
- GitHub Action for automatic `repo.json` sync after tag push
- Submission to the Dalamud main plugin repository (in addition to the custom repo)
---
## Bug Verifications
Carried over from the upstream issue tracker; not yet reproduced or verified in Hellion Chat 1.0.0. Will be tested
against the current state when opportunity allows.
- **Right-Click Whisper Error** in Field Ops / Special Instances (Eureka, Bozja, Occult Crescent, DRS) — upstream
[#168](https://github.com/Infiziert90/ChatTwo/issues/168). Reply helper appears to swallow the `@World` suffix.
- **FPS Drops with Plugin Active** — upstream [#145](https://github.com/Infiziert90/ChatTwo/issues/145). 1020 % drop
since upstream v1.29.19.0. v1.0.0 includes several fixes on the suspected paths; repro test against the current state
is open.
- **Add Blacklist from Plugin Window** — upstream [#140](https://github.com/Infiziert90/ChatTwo/issues/140). Right-click
add-to-blacklist throws "Cannot locate character with that name"; works via vanilla chat.
- **DB Viewer Column Sort** — State column sorts lexicographically instead of numerically (10 before 2). XIVIM
[#82](https://github.com/NightmareXIV/XIVInstantMessenger/issues/82); repro in Hellion Chat open.
---
## Licence Boundary
Hellion Chat is licensed under EUPL-1.2. Concept imports from AGPL-3.0 plugins (e.g. XIV Instant Messenger) are
architectural inspiration only — no code was ported. Code imports from the upstream codebase are complete as of v1.4.x
because Chat 2 is undergoing a fundamental rework and selective patches are no longer cleanly portable. Status and
rationale in [`UPSTREAM_SYNC.md`](UPSTREAM_SYNC.md).
+1 -1
View File
@@ -141,7 +141,7 @@ A theme can tint these toward its brand family (e.g., a purple theme can shift T
**don't** flip them (Tell suddenly green, Yell suddenly cyan). RP groups and combat-spec setups depend on the visual **don't** flip them (Tell suddenly green, Yell suddenly cyan). RP groups and combat-spec setups depend on the visual
hierarchy. hierarchy.
The eight colored built-in themes (Hellion Arctic, Hellion Spectrum, Event Horizon, Crystal Nocturne, Mint Grove, Night The eight colored built-in themes (Hellion Arctic, Hellion Spectrum, Event Horizon, Moonlit Bloom, Mint Grove, Night
Blue, Indigo Violet, Forge Merchantman) all follow this rule — read their source for reference. Chat 2 Klassik Blue, Indigo Violet, Forge Merchantman) all follow this rule — read their source for reference. Chat 2 Klassik
intentionally ships without `chatChannels` so the user keeps their existing picks. intentionally ships without `chatChannels` so the user keeps their existing picks.
+5 -5
View File
@@ -26,8 +26,8 @@
}, },
{ {
"description": "TypeScript type definitions stay grouped with each other", "description": "TypeScript type definitions stay grouped with each other",
"groupName": "type definitions", "matchPackagePrefixes": ["@types/"],
"matchPackageNames": ["@types/{/,}**"] "groupName": "type definitions"
}, },
{ {
"description": "Dev dependencies in their own group", "description": "Dev dependencies in their own group",
@@ -37,13 +37,13 @@
{ {
"description": "Pin GitHub Action versions by SHA for supply-chain hygiene", "description": "Pin GitHub Action versions by SHA for supply-chain hygiene",
"matchManagers": ["github-actions"], "matchManagers": ["github-actions"],
"pinDigests": true, "pinDigests": true
"ignorePaths": [".gitea/workflows/**"]
} }
], ],
"vulnerabilityAlerts": { "vulnerabilityAlerts": {
"labels": ["security", "vulnerability"], "labels": ["security", "vulnerability"],
"schedule": ["at any time"] "schedule": ["at any time"],
"prPriority": 10
}, },
"lockFileMaintenance": { "lockFileMaintenance": {
"enabled": true, "enabled": true,
+8 -8
View File
File diff suppressed because one or more lines are too long
+2 -12
View File
@@ -1,9 +1,7 @@
#!/usr/bin/env bash #!/usr/bin/env bash
# preflight.sh — pre-push gate. Blocks A/B/C verify config drift; Block D is a # preflight.sh — pre-push gate. Blocks A/B/C verify config drift; Block D is a
# headless `dotnet build` to catch compile-time API drift; Block E runs # headless `dotnet build` to catch compile-time API drift. Test execution lives
# `dotnet csharpier check` against HellionChat/; Block F runs markdownlint # in the local Build-Suite repo and is NOT part of this preflight.
# against the repo's *.md files. Test execution lives in the local Build-Suite
# repo and is NOT part of this preflight.
set -euo pipefail set -euo pipefail
ROOT="$(cd "$(dirname "$0")/.." && pwd)" ROOT="$(cd "$(dirname "$0")/.." && pwd)"
@@ -21,12 +19,4 @@ echo "==> preflight: Block C — changelog sync"
echo "==> preflight: Block D — plugin compile health" echo "==> preflight: Block D — plugin compile health"
dotnet build HellionChat/HellionChat.csproj --configuration Release --nologo --verbosity quiet dotnet build HellionChat/HellionChat.csproj --configuration Release --nologo --verbosity quiet
echo "==> preflight: Block E — csharpier reflow check"
dotnet csharpier check HellionChat/
echo "==> preflight: Block F — markdownlint"
# npx --yes avoids a global install; first run caches into ~/.npm/_npx/.
# Subsequent runs are sub-second.
npx --yes markdownlint-cli2 "**/*.md" "#node_modules" "#bin" "#obj" "#.claude"
echo "==> preflight: ALL GREEN" echo "==> preflight: ALL GREEN"
+6 -6
View File
@@ -1,7 +1,7 @@
#!/usr/bin/env bash #!/usr/bin/env bash
# verify-changelog-sync.sh — Block C. # verify-changelog-sync.sh — Block C.
# Strips .0 suffix from repo.json AssemblyVersion to derive the 3-digit tag/version. # Strips .0 suffix from repo.json AssemblyVersion to derive the 3-digit tag/version.
# yaml.changelog is a single multi-line block with **vX.Y.Z** subblocks. # yaml.changelog is a single multi-line block with **Hellion Chat X.Y.Z** subblocks.
set -euo pipefail set -euo pipefail
ROOT="$(cd "$(dirname "$0")/.." && pwd)" ROOT="$(cd "$(dirname "$0")/.." && pwd)"
@@ -16,11 +16,11 @@ ok() { echo "verify-changelog-sync: OK — $1"; }
VER="$(jq -r '.[0].AssemblyVersion' "$REPO_JSON" | sed -E 's/\.0$//')" VER="$(jq -r '.[0].AssemblyVersion' "$REPO_JSON" | sed -E 's/\.0$//')"
TAG="v$VER" TAG="v$VER"
grep -qE "^[[:space:]]*\*\*v${VER}[^0-9]" "$YAML" \ grep -qE "^[[:space:]]*\*\*Hellion Chat ${VER}" "$YAML" \
|| fail "$YAML changelog missing **v${VER}** subblock. Fix: add the v${VER} block at the top of the changelog field." || fail "$YAML changelog missing **Hellion Chat ${VER}** subblock. Fix: add the v${VER} block at the top of the changelog field."
jq -r '.[0].Changelog' "$REPO_JSON" | grep -qE "^[[:space:]]*\*\*v${VER}[^0-9]" \ jq -r '.[0].Changelog' "$REPO_JSON" | grep -qE "^[[:space:]]*\*\*Hellion Chat ${VER}" \
|| fail "$REPO_JSON Changelog missing **v${VER}** subblock. Fix: copy the yaml changelog over." || fail "$REPO_JSON Changelog missing **Hellion Chat ${VER}** subblock. Fix: copy the yaml changelog over."
FORGE_FILE="$FORGE_DIR/${TAG}.md" FORGE_FILE="$FORGE_DIR/${TAG}.md"
[ -f "$FORGE_FILE" ] || fail "$FORGE_FILE missing. Fix: create from previous tag's file as template." [ -f "$FORGE_FILE" ] || fail "$FORGE_FILE missing. Fix: create from previous tag's file as template."
@@ -39,7 +39,7 @@ FOOTER_LEN=80
TOTAL=$((TITLE_LEN + ${#BODY} + FOOTER_LEN)) TOTAL=$((TITLE_LEN + ${#BODY} + FOOTER_LEN))
[ "$TOTAL" -le 5500 ] || fail "Forge embed total ~${TOTAL} chars > 5500 cap." [ "$TOTAL" -le 5500 ] || fail "Forge embed total ~${TOTAL} chars > 5500 cap."
YAML_VERSIONS="$(grep -cE '^[[:space:]]*\*\*v[0-9]+\.[0-9]+\.[0-9]+' "$YAML" || true)" YAML_VERSIONS="$(grep -cE '^[[:space:]]*\*\*Hellion Chat' "$YAML" || true)"
[ "$YAML_VERSIONS" -le 4 ] || fail "$YAML changelog has $YAML_VERSIONS version subblocks (max 4). Fix: move oldest to docs/CHANGELOG.md." [ "$YAML_VERSIONS" -le 4 ] || fail "$YAML changelog has $YAML_VERSIONS version subblocks (max 4). Fix: move oldest to docs/CHANGELOG.md."
ok "yaml/repo.json/forge-post in sync for $TAG, embed-total ~${TOTAL}/5500, $YAML_VERSIONS/4 subblocks" ok "yaml/repo.json/forge-post in sync for $TAG, embed-total ~${TOTAL}/5500, $YAML_VERSIONS/4 subblocks"