Compare commits

..

1 Commits

Author SHA1 Message Date
renovate-bot b6bd0b459a chore(deps): refresh
Security / scan (pull_request) Successful in 21s
2026-05-10 12:34:14 +00:00
111 changed files with 3608 additions and 4714 deletions
-34
View File
@@ -1,34 +0,0 @@
---
subtitle: Threading- und IPC-Sicherheits-Politur
versionsnatur: Wartung und Robustheit
---
**Hellion Chat 1.4.4 — Threading- und IPC-Sicherheits-Politur**
Fünfter Sub-Patch der v1.4.x Polish-Sweep-Serie. Threading-Annahmen werden explizit pro Methode dokumentiert, ein
Hot-Path-Lock im Auto-Tell-Tab-Counter fällt weg, IPC-Cleanup wird sichtbar wenn er fehlschlägt und der Privacy-Filter
spricht jetzt bei unbekannten ChatTypes.
- **AutoTellTabsService Hot-Path-Lock entfernt.** `ActiveTempTabCount` hat bisher pro Render-Frame ein LINQ-Count unter
einem Lock gemacht. Jetzt läuft das über einen Interlocked-Counter der parallel zur Tabs-Liste mitgeführt wird,
inklusive Resync-Hook für den Snapshot-Restore-Pfad in `SaveConfig`. Plus Pure-Helper-Test-Mirror in der Build-Suite
damit die Atomicity-Semantik nicht versehentlich wegrefactored wird
- **HonorificService selbst-dokumentierende Threading-Banner.** Statt eines Block-Comments am Klassen-Ende hat jede
IPC-Callback-Methode jetzt einen 1-Zeilen-Banner darüber, der den Thread-Kontext direkt am Call-Site benennt
(framework only, framework scheduled, any). Mehr Hilfe für künftige Reviews als ein abstraktes Threading-Kapitel
- **Unsubscribe-Failure ist jetzt sichtbar.** `TryUnsubscribe` hat ein Honorific-Unsubscribe-Failure bisher als Debug
geloggt, was bei Standard-Loglevel verschluckt wurde. Eine geleakte Subscription kann den Service über Plugin-Reloads
hinweg leben lassen, also läuft der Log jetzt auf Warning
- **AutoTranslate-Warmup blockiert den Plugin-Unload nicht mehr.** Der Cache-Warmup-Thread war ohne `IsBackground=true`
unterwegs, was den Unload um 100-300 ms verzögern konnte. Pattern-Match zu MessageManager und RetentionSweep (beide
seit v1.4.0)
- **Privacy-Filter loggt unbekannte ChatTypes.** Wenn FFXIV durch einen Patch einen neuen ChatType einführt der weder in
der Whitelist noch in den Defaults steht, wird er bisher silent durch den Failsafe geleitet. Jetzt loggt der Filter
einmalig pro Runtime eine Warning mit dem Type und dem Failsafe-Wert. Dedup über ein NonSerialized-HashSet, also kein
Log-Spam
- **Default-Flip für neue Installationen.** `PrivacyPersistUnknownChannels` startet bei neuen Configs jetzt auf `true`,
damit ein Patch-bedingt neuer ChatType nicht stillschweigend gedroppt wird bevor der User entscheiden kann. Bestehende
Configs behalten ihre Wahl, weil der Deserializer den Initializer überschreibt. Keine Migration, kein Schema-Bump
Keine User-sichtbaren Funktions-Änderungen außer dem Default-Flip für neue Installationen. Settings, Themes, Tabs und
das Privacy-Verhalten für Bestand bleiben unangetastet.
-28
View File
@@ -1,28 +0,0 @@
---
subtitle: UX und Robustheit
versionsnatur: UX-Polish-Cycle
---
**Hellion Chat 1.4.5 — UX und Robustheit**
Sechster Sub-Patch der v1.4.x Polish-Sweep-Serie. Render-Fehler im Chat-Fenster werden jetzt sichtbar, der
First-Run-Wizard hat eine explizite Cancel-Schaltfläche, der Eingabe-Verlauf bleibt nicht mehr über Plugin-Reloads
hinweg liegen, und die Statusleiste klippt in schmalen Fenstern nicht mehr.
- **Fehler-Benachrichtigung im Chat-Fenster.** Wenn ein Render-Fehler in `DrawChatLog` auftritt, zeigt das Plugin jetzt
eine einmalige Warning-Notification mit Verweis aufs `/xllog`, statt das Fenster stillschweigend leer zu lassen. Der
Stack-Trace selbst geht weiter via `Plugin.Log.Error` ins Logfile. De-Dup über Per-Session-Bool, damit ein
wiederkehrender Fehler die Notification-Stack nicht pro Frame neu vollkippt
- **First-Run-Wizard trennt Accept und Close.** `OnClose` setzt nicht mehr stillschweigend `FirstRunCompleted=true`,
also lässt das X den Wizard schwebend zurück und er kommt beim nächsten Plugin-Reload wieder. Eine neue „Später —
Defaults behalten"-Schaltfläche im Footer ist der explizite Weg, ohne Profil-Auswahl rauszukommen. Strings bilingual
EN+DE plus Tooltip
- **Eingabe-Verlauf wird beim Plugin-Reload geleert.** `InputHistoryService.Reset` hängt jetzt in `Plugin.DisposeAsync`
neben den anderen Pure-Memory-Cleanups, damit der statische Zustand aus der vorigen Session den nächsten Load nicht
mehr erbt
- **Statusleiste klippt nicht mehr.** Der rechtsbündige Versions-Slot wird ausgeblendet wenn die Chat-Window-Breite
abzüglich Versions-Text unter 200 px fällt — vorher überlappte er die vier linken Slots. Ab ausreichender Breite
taucht der Slot wieder auf
- **Intern:** `FontManager` fällt auf System-Font zurück wenn die eingebettete Hellion-Font-Resource fehlt
(Broken-csproj-Pfad, nie ein Produktions-Build), plus expliziter Session-Only-Invariant-Kommentar für Auto-Tell-Tabs
in `Plugin.cs:167-168` mit einem TempTabCounter-Init-Pin in der Build-Suite. Kein Schema-Bump, keine Migration
-33
View File
@@ -1,33 +0,0 @@
---
subtitle: Code Hygiene and Refactor
versionsnatur: Maintenance-Cycle
---
Wartungs-Patch ohne User-sichtbare Änderungen. Saubere Code-Basis als Vorbereitung auf das v1.4.7-Backlog-Cleanup, plus
zwei geerbte Bugfixes aus dem ChatTwo-Upstream `f35b7d3`.
- **preflight.sh härter**: csharpier-Reflow-Check (Block E) und markdownlint (Block F) laufen jetzt im Pre-Push-Gate,
statt erst beim Pre-Merge-Review aufzufallen.
- **FontManager-Fallback robuster**: Atlas-Toolkit-Throws aus kaputten Font-Configs (IO, InvalidOperation,
ArgumentException) fallen jetzt zuverlässig auf NotoSansCjkRegular, statt den Atlas-Build mitzureißen. Der
Exception-Typ wird im Log mitgegeben für die Diagnose.
- **URL-Validation beim Plugin-Load**: BrandingLinks (5 URLs) und IntegrationLinks (2 URLs) werden via
`[ModuleInitializer]` geprüft. Ein Tippfehler bei einer künftigen URL-Rotation wirft jetzt sofort beim Plugin-Load,
statt still beim Klick zu scheitern.
- **Cherry-Pick aus ChatTwo `f35b7d3`** — Memory-Leak in `Chat.SetChannel`: der native `Utf8String` wird jetzt auch dann
freigegeben, wenn der Linkshell-Check den Channel ablehnt (vorher gefangen im early-return).
- **Cherry-Pick aus ChatTwo `f35b7d3`** — `Tab.Clone()` Deep-cloned jetzt `UsedChannel` und `TellTarget`. Vorher
Reference-Share-Bug: PopOut- und Temp-Tabs mutierten sich gegenseitig.
- **Aktive-Tab-Underline pixel-perfect bei DPI-Scaling**: Die Underline-Pill skaliert jetzt mit
`ImGuiHelpers.GlobalScale` und rundet die DrawList-Koordinaten auf physische Pixel. Kein Sub-Pixel-Blur mehr auf
125/150%-Setups.
- **IconButton-Width-Fix**: der manuelle `width - 2 * CellPadding.X`-Subtract verlor den HUD-Scale (Padding skaliert,
der raw int nicht). Gemessene Breite läuft jetzt unverändert durch.
- **Test-Isolation für MessageStore**: `Dalamud.Utility.Util`-Surface (IsWine, OpenLink) läuft jetzt durch eine
`IPlatformUtil`-Indirektion. MessageStores `IsWine`-Probe ist isoliert testbar in der Build-Suite. Plus:
HellionStyle-ChildBgAlpha als Pure-Helper extrahiert, Plugin.SaveConfig kopiert nur Session-Tabs statt der ganzen
Tab-Liste, SettingsOverview cached den DrawList einmal pro Frame.
- **Built-in-Theme-Roster**: Crystal Nocturne (Royal Sapphire + Electric Magenta auf Obsidian, von CRYSTALLITE) ersetzt
Moonlit Bloom. User mit Moonlit Bloom als aktivem Theme fallen beim ersten Plugin-Load auf Hellion Arctic zurück.
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
-29
View File
@@ -1,29 +0,0 @@
---
subtitle: Backlog Cleanup and Mid-Features
versionsnatur: Mid-Feature-Patch
---
Achter Sub-Patch der v1.4.x Polish-Sweep-Serie. Erstes User-sichtbares Feature-Bundle seit v1.4.5 — angepinnte Tell-Tabs
die Relog überleben, opt-in Honorific-Glow, plus eine konfigurierbare Sidebar.
- **TempTell anpinnen**: Rechtsklick auf einen TempTell-Tab in der Sidebar → „Tab anpinnen". Angepinnte Tabs überleben
Plugin-Reload und Char-Logout, behalten ihre Konversations-Historie (wird beim Rehydrate aus dem MessageStore
nachgeladen) und bleiben an die gleiche /tell-Person gebunden. Hard-Cap 5 angepinnte Tabs in einem separaten Pool —
die normalen Auto-Tell-Tabs (15er Cap) sind davon entkoppelt, Gesamt-Decke 20. Die Sidebar gruppiert angepinnte Tabs
in einer eigenen „Angepinnt"-Sektion mit eigenem Trenner.
- **Honorific Glow-Outline**: rendert jetzt eine 8-Richtungs-DrawList-Outline wenn der Honorific-Titel eine Glow-Farbe
trägt. Opt-in via **Settings → Integrationen → Glow-Outline rendern (Honorific)** (Default OFF). Gradient (Color3 /
GradientColourSet / Wave / Pulse) wird geparst und im DTO weitergereicht, rendert aktuell aber statisch als
Primärfarbe — der volle Gradient-Port (Animations-Algorithmus + Pride-Palette) kommt als eigener Cycle nach.
- **Sidebar-Breite konfigurierbar**: in **Theme & Layout** ein Slider 44160 px. Default bleibt 44 px (icon-only), aber
breiter machen damit Sektion-Header wie „Aktive Tells (3)" oder „Angepinnt (2)" nicht abgeschnitten werden.
- **Settings-Save Channel-Fix**: ein Save mit aktivem Party- oder Linkshell-Tab konnte den Chat-Input zurück auf
`/tell <angepinnte Person>` springen lassen. `Configuration.UpdateFrom` bewahrt jetzt den Runtime-`CurrentChannel`
über den persistent-Tab-Merge hinweg, und `TabSwitched` deep-cloned den Seed-Channel statt sich den `UsedChannel` mit
dem vorigen Tab zu teilen.
- **Internal**: `IPluginLogProxy`-Indirektion vor Dalamud's `IPluginLog` über alle ~91 `Plugin.Log`-Call-Sites. Damit
läuft `MessageStore.Migrate0` voll-isoliert in xUnit (F12.1-Lücke aus v1.4.6 geschlossen). Plus: TempTab-Counter als
abgeleitete Property statt gecachtes Interlocked-Feld — die neuen Pin/Unpin-Übergänge sind Cold-Path, kein
Lock-Free-Vorteil mehr. Migration v16 → v17 ist rein additiv (neues `Tab.IsPinned`-Bool, Default false).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
-21
View File
@@ -1,21 +0,0 @@
---
subtitle: Hook-Layer und Polish-Quick-Wins
versionsnatur: Polish-Patch
---
- DbViewer Volltext-Suche: optionaler FTS5-Index über die ganze Chat-Historie.
Wird beim ersten v1.4.8-Start asynchron im Hintergrund gebaut, Progress als
Toast. Lokale Page-Suche bleibt Default. Such-Eingaben werden als exakte
Wortfolge gematcht; mehrere Wörter werden nur gefunden, wenn sie zusammen
und in der Reihenfolge stehen. Wer rohe FTS5-MATCH-Syntax nutzen will, setzt
eigene Anführungszeichen um den Suchbegriff.
- Custom-Theme-Files laden sich beim Speichern automatisch neu, wenn das Theme
aktiv ist. Kein Picker-Klick mehr nötig.
- Retention-Sweep blockt nicht mehr den Framework-Thread. Der Mini-Hitch von
~194ms pro Sweep ist weg.
- Statusleiste rendert sauber bei Windows-Skalierung über 100%.
- Receive-Suppressed-Tells-Routing wurde in diesem Cycle untersucht und auf
v1.5.x verschoben: wenn andere Plugins Tells via CheckMessageHandled
unterdrücken, überspringt FFXIVs Chat-Pipeline den RaptureLogModule-Resolver
und HellionChats Tab-Routing verliert den Tell-Partner. Der Fix liegt
architektonisch neben dem geplanten Ad-Block-Hook-Layer und kommt dort mit.
-37
View File
@@ -1,37 +0,0 @@
---
subtitle: Plugin-Load Render Polish
versionsnatur: Performance-Patch
---
- First-Frame-HITCH unter 100 ms: der erste Render-Frame des Plugins liegt
jetzt bei ~76 ms Median (vorher ~127 ms), die Dalamud-Warnung
„UiBuilder(Hellion Chat) > 100ms" beim Plugin-Start ist damit weg.
Erreicht durch das Verlagern von sechs nicht-essentiellen Render-
Sektionen (Statusleiste, Kanalname-Chunks, Fenster-Bounds-Check,
Hinweis-Banner, Autocomplete, Input-Preview) auf den zweiten Frame.
Bei 60 fps sieht man die deferred-Sektionen ~17 ms später, was im
Atlas-Build-Fenster nach einem Reload unsichtbar bleibt.
- Slash-Commands zentral registriert: /hellion, /hellionView,
/hellionSeString und /hellionDebugger werden jetzt im Plugin-Load zentral
registriert statt erst beim ersten Öffnen ihres Ziel-Fensters. Heißt: die
Befehle funktionieren ab dem ersten Tick, auch wenn das jeweilige Fenster
nie geöffnet wurde. Der „Einstellungen"-Button im Plugin-Manager hängt am
selben Pfad.
- Plugin-Load-Diagnose-Logs als Tripwire: die Profiling-Logs für
MessageStore.Connect, MessageStore.Migrate, FilterAllTabs und den
Auto-Translate-Warmup bleiben auf Information-Level eingeschaltet. Falls
eine zukünftige Änderung die Lade-Zeit wieder über 100 ms drückt, taucht
der Mehrverbrauch direkt im /xllog auf, ohne dass jemand erst den
Debug-Filter einschalten muss.
- ChatTwo-IPC-Kompatibilitäts-Layer: HellionChat spiegelt jetzt die
komplette ChatTwo-IPC-Surface (`GetChatInputState`,
`ChatInputStateChanged`, `Register`, `Unregister`, `Available`,
`Invoke`) zusätzlich zu unseren eigenen `HellionChat.*`-Gates unter
dem `ChatTwo.*`-Namensraum. Drittseitige Integrationen die nur auf
ChatTwo's IPC reagieren, etwa die Kontextmenü-Hooks von Artisan und
AllaganTools, funktionieren damit weiter ohne Code-Änderung auf
ihrer Seite. Die Conflict-Detection blockiert das parallele Laden
von ChatTwo, daher kein Namensraum-Konflikt im Live-Betrieb.
- Migration v17 unverändert: kein Schema-Bump, kein Config-Migrations-
Aufwand. Nach dem Update läuft das Plugin gegen die bestehende
v17-Datenbank weiter.
@@ -32,10 +32,10 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 uses: actions/checkout@v6
- name: Setup .NET 10 - name: Setup .NET 10
uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5 uses: actions/setup-dotnet@v5
with: with:
dotnet-version: 10.0.x dotnet-version: 10.0.x
@@ -101,16 +101,16 @@ jobs:
if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" } if ($idx -lt 0) { throw "V5: changelog-Block nicht gefunden in $yamlPath" }
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(4) } else { $_ } if ($_ -match '^ ') { $_.Substring(2) } else { $_ }
}) -join "`n" }) -join "`n"
$header = "**v$version " $header = "**Hellion Chat $version"
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging." throw "V5: No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**v", 1) $nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
$enBlock = $rest.Substring(0, $nextHdr).TrimEnd() $enBlock = $rest.Substring(0, $nextHdr).TrimEnd()
@@ -120,37 +120,17 @@ jobs:
$enBlock = $rest.TrimEnd() $enBlock = $rest.TrimEnd()
} }
# ---------- Embed-Felder + Per-Field-Caps (Discord-Hard-Limits) ---------- # ---------- Char-Cap-Check (5500 Total auf title + description + footer) ----------
# Discord enforces per-embed-field limits separately from the
# combined-total limit. We split the DE and EN blocks into two
# embeds that share the same release URL so Discord stitches
# them into one visual card. Hard caps per Discord docs:
# description: 4096 per embed
# title: 256 per embed
# footer.text: 2048 per embed
# combined sum across all embeds: 6000
$title = "Hellion Chat $version — $subtitle" $title = "Hellion Chat $version — $subtitle"
$deDesc = "**Deutsch**`n`n$deBody" $description = "**Deutsch**`n`n$deBody`n`n**English**`n`n$enBlock"
$enDesc = "**English**`n`n$enBlock"
$footerText = "Hellion Forge · $versionsnatur" $footerText = "Hellion Forge · $versionsnatur"
$releaseUrl = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/$tag" $totalChars = $title.Length + $description.Length + $footerText.Length
if ($totalChars -gt 5500) {
throw "V6: Total char count $totalChars exceeds 5500 limit. Major-Release detected — please post manually via Bot/Multi-Embed (see forge style §8). Forge-Auto-Announce stays off for this tag."
}
Write-Host "Char-Cap OK: $totalChars / 5500"
if ($deDesc.Length -gt 4096) { # ---------- Embed-Payload bauen ----------
throw "V6a: DE-Body too long for one embed ($($deDesc.Length) chars, max 4096). Trim .github/forge-posts/$tag.md or post the announcement manually (see forge style §8)."
}
if ($enDesc.Length -gt 4096) {
throw "V6b: EN-Block too long for one embed ($($enDesc.Length) chars, max 4096). Trim the changelog entry in HellionChat/HellionChat.yaml or post manually."
}
$totalChars = $title.Length + $deDesc.Length + $enDesc.Length + $footerText.Length
if ($totalChars -gt 6000) {
throw "V6c: Combined embed chars $totalChars exceed Discord's 6000-total limit. Major-Release detected — post manually via Bot/Multi-Embed (see forge style §8)."
}
Write-Host "Embed-Caps OK: de=$($deDesc.Length)/4096, en=$($enDesc.Length)/4096, total=$totalChars/6000"
# ---------- Embed-Payload bauen (zwei Embeds, gleiche url) ----------
# Sharing the same `url` tells Discord to render both embeds as a
# single contiguous card block. The title sits on the first embed,
# the footer + timestamp on the last so it reads as one post.
$payload = [ordered]@{ $payload = [ordered]@{
username = "Forge Herald" username = "Forge Herald"
avatar_url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png" avatar_url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png"
@@ -162,14 +142,9 @@ jobs:
embeds = @( embeds = @(
[ordered]@{ [ordered]@{
title = $title title = $title
url = $releaseUrl url = "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/tag/$tag"
color = 12730636 color = 12730636
description = $deDesc description = $description
},
[ordered]@{
url = $releaseUrl
color = 12730636
description = $enDesc
footer = [ordered]@{ text = $footerText } footer = [ordered]@{ text = $footerText }
timestamp = (Get-Date).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ss.fffZ") timestamp = (Get-Date).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ss.fffZ")
} }
@@ -20,12 +20,16 @@ on:
push: push:
tags: tags:
- "v*" - "v*"
# Manual recovery trigger. Use Gitea's "Run workflow" UI and select the # Manual recovery trigger. Use when a tag was pushed but the auto-run
# tag (e.g. v1.4.4) from the Ref dropdown - not main. The Validate tag # was missed or failed: `gh workflow run release.yml -f tag=v0.6.1`.
# ref step below hard-fails if a non-tag ref is selected, because the # The tag input is validated against the same semver regex as the
# release-action reads GITHUB_REF directly and rejects anything that # auto-trigger before any string interpolation happens.
# does not start with refs/tags/.
workflow_dispatch: workflow_dispatch:
inputs:
tag:
description: "Existing tag to (re)release, e.g. v0.6.1"
required: true
type: string
permissions: permissions:
contents: write contents: write
@@ -37,24 +41,17 @@ jobs:
timeout-minutes: 20 timeout-minutes: 20
steps: steps:
# release-action@main reads GITHUB_REF directly (its action.yml # On push:tags, github.ref_name is the tag — checkout default works.
# does not declare a tag_name input). Validate up-front so manual # On workflow_dispatch, ref defaults to the branch the action was
# dispatches from a branch ref fail loud here instead of burning # invoked from; we need to explicitly check out the tag the user
# a full build before the final step errors out with "ref X is # supplied so the build comes from the tagged commit, not main.
# not a tag".
- name: Validate tag ref
run: |
if [[ "${GITHUB_REF}" != refs/tags/v* ]]; then
echo "::error::Release workflow must run on a v*.X.Y tag ref, got ${GITHUB_REF}"
echo "::error::Push a tag, or pick the tag (not main) in the workflow_dispatch Ref dropdown."
exit 1
fi
- name: Checkout - name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 uses: actions/checkout@v6
with:
ref: ${{ github.event.inputs.tag || github.ref }}
- name: Setup .NET 10 - name: Setup .NET 10
uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5 uses: actions/setup-dotnet@v5
with: with:
dotnet-version: 10.0.x dotnet-version: 10.0.x
@@ -92,11 +89,12 @@ jobs:
- name: Generate release body - name: Generate release body
shell: pwsh shell: pwsh
env: env:
# github.ref_name is the tag because Validate tag ref above # workflow_dispatch carries the user-supplied tag in inputs.tag;
# already enforced refs/tags/v*. Read via env: so the value # push:tags carries it in github.ref_name. Either way the value
# is a PowerShell variable, not inline shell text, and gets # is treated as a PowerShell variable (env-var pass), not as
# re-validated against the semver regex below. # inline shell text, and validated against the semver regex
TAG_NAME: ${{ github.ref_name }} # below before any string interpolation.
TAG_NAME: ${{ github.event.inputs.tag || github.ref_name }}
run: | run: |
$tag = $env:TAG_NAME $tag = $env:TAG_NAME
if ($tag -notmatch '^v\d+\.\d+\.\d+$') { if ($tag -notmatch '^v\d+\.\d+\.\d+$') {
@@ -113,22 +111,20 @@ jobs:
# changelog: is the last top-level key in the manifest, so # changelog: is the last top-level key in the manifest, so
# everything after the marker is the literal block. Strip the # everything after the marker is the literal block. Strip the
# 4-space yaml indent (prettier convention) from each line. # 2-space yaml indent from each line.
$afterMarker = $raw.Substring($idx + $marker.Length) $afterMarker = $raw.Substring($idx + $marker.Length)
$changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object { $changelogBody = (($afterMarker -split "`r?`n") | ForEach-Object {
if ($_ -match '^ ') { $_.Substring(4) } else { $_ } if ($_ -match '^ ') { $_.Substring(2) } else { $_ }
}) -join "`n" }) -join "`n"
# Subblock convention: "**vX.Y.Z — <subtitle> (<date>)**" $header = "**Hellion Chat $version"
# matches verify-changelog-sync.sh and slim-rule grep.
$header = "**v$version "
$start = $changelogBody.IndexOf($header) $start = $changelogBody.IndexOf($header)
if ($start -lt 0) { if ($start -lt 0) {
throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release." throw "No changelog entry for version $version found in $yamlPath. Update the changelog block before tagging a release."
} }
$rest = $changelogBody.Substring($start) $rest = $changelogBody.Substring($start)
$nextHdr = $rest.IndexOf("`n`n**v", 1) $nextHdr = $rest.IndexOf("`n`n**Hellion Chat ", 1)
$trailer = $rest.IndexOf("`n`n---") $trailer = $rest.IndexOf("`n`n---")
if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) { if ($nextHdr -ge 0 -and ($trailer -lt 0 -or $nextHdr -lt $trailer)) {
@@ -156,28 +152,19 @@ jobs:
Write-Host $body Write-Host $body
Write-Host "----------------------------------------" Write-Host "----------------------------------------"
# release-action@main only declares files/title/body/pre_release/
# draft/api_key/insecure as inputs (see its action.yml). It silently
# ignores anything else, including body_path and tag_name. The tag
# itself comes from GITHUB_REF, the body must be passed inline via
# body:, so we re-emit release-body.md as a step output first.
- name: Expose release body for release-action
id: body
shell: bash
run: |
{
echo 'content<<RELEASE_BODY_EOF'
cat release-body.md
echo 'RELEASE_BODY_EOF'
} >> "$GITHUB_OUTPUT"
# Gitea-native release action. Creates the release if the tag has no # Gitea-native release action. Creates the release if the tag has no
# release yet, or updates the existing one with latest.zip attached # release yet, or updates the existing one. body_path provides the
# and the generated body. The auto-injected GITHUB_TOKEN on Gitea # generated release body, files attaches latest.zip. The auto-injected
# Actions has Gitea-API scope and is sufficient for release write. # GITHUB_TOKEN on Gitea Actions has Gitea-API scope and is sufficient
# for release write.
- name: Attach to Gitea release - name: Attach to Gitea release
uses: https://gitea.com/actions/release-action@main uses: https://gitea.com/actions/release-action@main
with: with:
# Explicit tag_name so the action targets the correct release in
# both push:tags (auto) and workflow_dispatch (manual recovery)
# modes. Without this, dispatch runs would default to the branch
# ref (main) and fail to find the release.
tag_name: ${{ github.event.inputs.tag || github.ref_name }}
files: ${{ steps.locate.outputs.path }} files: ${{ steps.locate.outputs.path }}
body: ${{ steps.body.outputs.content }} body_path: release-body.md
api_key: ${{ secrets.GITHUB_TOKEN }} api_key: ${{ secrets.GITHUB_TOKEN }}
-4
View File
@@ -384,7 +384,3 @@ ChatTwo.Tests
TestResults TestResults
*.db-shm *.db-shm
*.db-wal *.db-wal
# Claude Code projekt-spezifisches Setup (lokal, nicht committed)
/.claude/
/CLAUDE.md
-2
View File
@@ -1,9 +1,7 @@
{ {
"MD007": { "indent": 4 }, "MD007": { "indent": 4 },
"MD013": false, "MD013": false,
"MD024": { "siblings_only": true },
"MD029": false, "MD029": false,
"MD033": false, "MD033": false,
"MD036": false,
"MD041": false "MD041": false
} }
+99 -184
View File
@@ -1,10 +1,8 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Threading;
using Dalamud.Game.Text; using Dalamud.Game.Text;
using Dalamud.Game.Text.SeStringHandling; using Dalamud.Game.Text.SeStringHandling;
using Dalamud.Interface.ImGuiNotification;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.GameFunctions.Types; using HellionChat.GameFunctions.Types;
using HellionChat.Resources; using HellionChat.Resources;
@@ -12,8 +10,14 @@ using HellionChat.Util;
namespace HellionChat; namespace HellionChat;
// Auto-Tell-Tabs: spawns session-only tabs per /tell partner. // Hellion Chat — Auto-Tell-Tabs.
// Subscribes to MessageManager.MessageProcessed and ClientState.Logout. //
// Spawns a session-only tab per /tell partner so a club greeter can track
// multiple parallel conversations without losing context. Subscribes to
// MessageManager.MessageProcessed for live tells and to ClientState.Logout
// for the cleanup pass; everything else hangs off these two entry points.
//
// See spec: Hellion Chat Auto-Tell-Tabs Spec (Obsidian vault).
internal sealed class AutoTellTabsService : IDisposable internal sealed class AutoTellTabsService : IDisposable
{ {
private readonly Plugin _plugin; private readonly Plugin _plugin;
@@ -21,12 +25,6 @@ internal sealed class AutoTellTabsService : IDisposable
private readonly MessageStore _store; private readonly MessageStore _store;
private readonly object _tempTabsLock = new(); private readonly object _tempTabsLock = new();
// Hard cap on pinned TempTabs so the sidebar doesn't inflate over years
// of usage. Separate pool from AutoTellTabsLimit (15) — pinned tabs live
// in their own bucket. A configurable cap is a vault-backlog anchor for
// a later cycle if tester feedback demands it.
internal const int MaxPinnedTempTabs = 5;
private bool _initialized; private bool _initialized;
internal AutoTellTabsService(Plugin plugin, MessageManager messageManager, MessageStore store) internal AutoTellTabsService(Plugin plugin, MessageManager messageManager, MessageStore store)
@@ -36,14 +34,16 @@ internal sealed class AutoTellTabsService : IDisposable
_store = store; _store = store;
} }
// Derived from the tab list on read. Pin/Unpin/Promote/Logout simply internal int ActiveTempTabCount
// mutate IsPinned or remove tabs — the count adapts automatically. {
// Replaces the F2.1 Interlocked counter because the new pin-state get
// transitions are cold-path and don't need lock-free reads. {
internal int ActiveTempTabCount => lock (_tempTabsLock)
Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInUnpinnedPool); {
return Plugin.Config.Tabs.Count(t => t.IsTempTab);
internal int PinnedTempTabCount => Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInPinnedPool); }
}
}
internal void Initialize() internal void Initialize()
{ {
@@ -52,53 +52,11 @@ internal sealed class AutoTellTabsService : IDisposable
return; return;
} }
// Pinned tabs come out of the JSON with TellTarget set but
// CurrentChannel reset (NonSerialized). Without re-seeding, the chat
// input has no tell-target on the active pinned tab, and the
// game-side channel hook only repaints CurrentChannel once the user
// triggers a /tell or channel switch.
RehydratePinnedTabs();
_messageManager.MessageProcessed += HandleTell; _messageManager.MessageProcessed += HandleTell;
Plugin.ClientState.Logout += OnLogout; Plugin.ClientState.Logout += OnLogout;
_initialized = true; _initialized = true;
} }
private void RehydratePinnedTabs()
{
var pinned = Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInPinnedPool);
Plugin.LogProxy.Debug($"[Pin] Rehydrate scan: {pinned} pinned tab(s) found");
foreach (var tab in Plugin.Config.Tabs)
{
if (!TabLifecycleHelpers.IsInPinnedPool(tab))
continue;
if (tab.TellTarget is null || !tab.TellTarget.IsSet())
{
Plugin.LogProxy.Warning(
$"[Pin] Pinned tab '{tab.Name}' has no usable TellTarget "
+ $"(Name={tab.TellTarget?.Name ?? "<null>"} World={tab.TellTarget?.World ?? 0}). "
+ "Chat input on this tab will be empty until the partner sends a tell or you /tell manually."
);
continue;
}
tab.Channel ??= InputChannel.Tell;
tab.CurrentChannel.Channel = InputChannel.Tell;
tab.CurrentChannel.TellTarget = tab.TellTarget.Clone();
// MessageList is NonSerialized so pinned tabs come back empty.
// Preload the same history window the spawn path uses so the user
// sees the recent conversation, not a blank tab.
PreloadHistory(tab, tab.TellTarget.Name, tab.TellTarget.World, Guid.Empty);
Plugin.LogProxy.Debug(
$"[Pin] Rehydrated '{tab.Name}' -> Tell target {tab.TellTarget.Name}@{tab.TellTarget.World}"
);
}
}
public void Dispose() public void Dispose()
{ {
if (!_initialized) if (!_initialized)
@@ -129,8 +87,11 @@ internal sealed class AutoTellTabsService : IDisposable
var partner = ExtractTellPartner(message); var partner = ExtractTellPartner(message);
if (partner == null) if (partner == null)
{ {
// Diagnostics: helps detect regressions (FFXIV payload changes, new edge cases) // Real message without a player payload — e.g. GM tells, which
Plugin.LogProxy.Warning( // we deliberately skip. The diagnostics make future regressions
// (FFXIV changing tell payload shape, new edge cases) findable
// without having to crank up debug logging at the source.
Plugin.Log.Warning(
$"[AutoTellTabs] Could not extract tell partner. type={message.Code.Type}, " $"[AutoTellTabs] Could not extract tell partner. type={message.Code.Type}, "
+ $"senderChunks={message.Sender.Count}, contentChunks={message.Content.Count}, " + $"senderChunks={message.Sender.Count}, contentChunks={message.Content.Count}, "
+ $"senderSourcePayloads={message.SenderSource?.Payloads?.Count ?? 0}, " + $"senderSourcePayloads={message.SenderSource?.Payloads?.Count ?? 0}, "
@@ -144,23 +105,9 @@ internal sealed class AutoTellTabsService : IDisposable
var existing = FindTempTab(partner.Value.Name, partner.Value.World); var existing = FindTempTab(partner.Value.Name, partner.Value.World);
if (existing != null) if (existing != null)
{ {
// Already routed via MessageManager pipeline. Repair the // Tab already exists; Tab.Matches has already routed this
// tell-target if the fallback hit a pinned tab whose // message via the MessageManager pipeline (see Task 2 sender
// TellTarget didn't survive a previous round-trip — keeps // filter).
// FindTempTab fast on the next message.
if (
existing.IsPinned
&& (existing.TellTarget is null || !existing.TellTarget.IsSet())
)
{
existing.TellTarget = new TellTarget(
partner.Value.Name,
partner.Value.World,
0,
TellReason.Direct
);
_plugin.SaveConfig();
}
return; return;
} }
@@ -177,7 +124,10 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
if (message.Code.Type == ChatType.TellIncoming) if (message.Code.Type == ChatType.TellIncoming)
{ {
// Sender is the partner; check chunks first, then raw SeString as fallback // Incoming tell: the sender is the conversation partner. The
// PlayerPayload normally rides on a chunk's Link slot, but for
// some tell types FFXIV only puts it in the raw SeString —
// fall back to that before giving up.
var fromSender = var fromSender =
ChunkUtil.TryGetPlayerPayload(message.Sender) ChunkUtil.TryGetPlayerPayload(message.Sender)
?? ChunkUtil.TryGetPlayerPayload(message.SenderSource); ?? ChunkUtil.TryGetPlayerPayload(message.SenderSource);
@@ -188,7 +138,10 @@ internal sealed class AutoTellTabsService : IDisposable
return null; return null;
} }
// Outgoing tell: check content first, then channels's TellTarget as fallback // Outgoing tell: the local player is the sender, the partner shows
// up either as a payload in the content (for tells typed via the
// Chat 2 input bar) or as the channel's tracked tell target (set by
// the SetContextTellTarget game hook). Same SeString fallback.
var fromContent = var fromContent =
ChunkUtil.TryGetPlayerPayload(message.Content) ChunkUtil.TryGetPlayerPayload(message.Content)
?? ChunkUtil.TryGetPlayerPayload(message.ContentSource) ?? ChunkUtil.TryGetPlayerPayload(message.ContentSource)
@@ -210,35 +163,25 @@ internal sealed class AutoTellTabsService : IDisposable
return null; return null;
} }
private static Tab? FindTempTab(string name, uint world) private Tab? FindTempTab(string name, uint world)
{ {
var byTarget = Plugin.Config.Tabs.FirstOrDefault(t => return Plugin.Config.Tabs.FirstOrDefault(t =>
t.IsTempTab t.IsTempTab
&& t.TellTarget != null && t.TellTarget != null
&& string.Equals(t.TellTarget.Name, name, StringComparison.OrdinalIgnoreCase) && string.Equals(t.TellTarget.Name, name, StringComparison.OrdinalIgnoreCase)
&& t.TellTarget.World == world && t.TellTarget.World == world
); );
if (byTarget != null)
return byTarget;
// Fallback: match by tab name. Pinned tabs are named via
// FormatTabName(player, world) at spawn time, so the name is a
// stable secondary key when TellTarget didn't survive a save/load
// (older configs from a renamed pin, malformed migrations, etc.).
var expectedName = FormatTabName(name, world);
return Plugin.Config.Tabs.FirstOrDefault(t =>
t.IsTempTab && string.Equals(t.Name, expectedName, StringComparison.OrdinalIgnoreCase)
);
} }
internal void DropOldestTempTab() private void DropOldestTempTab()
{ {
// Pinned tabs live in their own bucket (MaxPinnedTempTabs) and are // Greeted tabs are dropped before un-greeted ones (the user said
// never drop candidates. They leave the bucket only via Unpin or // "I'm done with that conversation"), and within each bucket we
// PromoteToPermanent. // pick the oldest LastActivity. This protects active conversations
// and unfinished greetings while still freeing up a slot.
var victim = Plugin var victim = Plugin
.Config.Tabs.Select((tab, idx) => (Tab: tab, Index: idx)) .Config.Tabs.Select((tab, idx) => (Tab: tab, Index: idx))
.Where(t => TabLifecycleHelpers.IsInUnpinnedPool(t.Tab)) .Where(t => t.Tab.IsTempTab)
.OrderByDescending(t => t.Tab.IsGreeted) .OrderByDescending(t => t.Tab.IsGreeted)
.ThenBy(t => t.Tab.LastActivity) .ThenBy(t => t.Tab.LastActivity)
.FirstOrDefault(); .FirstOrDefault();
@@ -248,7 +191,12 @@ internal sealed class AutoTellTabsService : IDisposable
return; return;
} }
// Clean up pop-out window if tab is popped out // v0.6.1 — if the victim is currently popped out, tear down the
// matching Popout window first. Otherwise the window stays in
// PopOutWindows + WindowSystem and renders empty / re-spawns on the
// next AddPopOutsToDraw tick. Latent since pop-outs were introduced;
// becomes visible with AutoTellTabsOpenAsPopout where dropping a
// popped tab is now a routine code path.
if (victim.Tab.PopOut) if (victim.Tab.PopOut)
{ {
var popout = _plugin.ChatLogWindow.ActivePopouts.FirstOrDefault(p => var popout = _plugin.ChatLogWindow.ActivePopouts.FirstOrDefault(p =>
@@ -262,7 +210,8 @@ internal sealed class AutoTellTabsService : IDisposable
Plugin.Config.Tabs.RemoveAt(victim.Index); Plugin.Config.Tabs.RemoveAt(victim.Index);
// Re-anchor active tab to avoid silent switch when tab is dropped // Re-anchor the active tab so the user does not silently end up on
// a different conversation when their tab gets dropped or shifted.
if (victim.Index <= _plugin.LastTab) if (victim.Index <= _plugin.LastTab)
{ {
_plugin.WantedTab = 0; _plugin.WantedTab = 0;
@@ -273,12 +222,22 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
var tab = BuildTempTab(partner.Name, partner.World); var tab = BuildTempTab(partner.Name, partner.World);
// Preload history: chronological order with current message already persisted // Preload first so the tab opens with chronological history above
// the current message — and so a slow DB query never causes a
// visible "empty tab, then history pops in" effect on screen.
// The current message is already persisted in the store by the
// time MessageProcessed fires (see MessageManager.cs: UpsertMessage
// runs before the event), so we have to exclude it explicitly to
// avoid the separator landing below the live tell.
PreloadHistory(tab, partner.Name, partner.World, currentMessage.Id); PreloadHistory(tab, partner.Name, partner.World, currentMessage.Id);
tab.AddMessage(currentMessage, unread: true); tab.AddMessage(currentMessage, unread: true);
// Open as pop-out if configured (set before Tabs.Add for next render-tick) // Hellion Chat v0.6.1 — opt-in: open new /tell tabs directly as a
// pop-out window. Set BEFORE Tabs.Add so the next render-tick's
// AddPopOutsToDraw() sees PopOut=true and spawns the Popout window
// alongside the tab going into the list. No SaveConfig() because
// auto-tell tabs are IsTempTab (session-only, never persisted).
if (Plugin.Config.AutoTellTabsOpenAsPopout) if (Plugin.Config.AutoTellTabsOpenAsPopout)
{ {
tab.PopOut = true; tab.PopOut = true;
@@ -313,7 +272,9 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
return $"{playerName}@{worldRow.Name}"; return $"{playerName}@{worldRow.Name}";
} }
// Fallback if world lookup misses (rare; only for unseen worlds) // World sheet lookup miss is rare (only for FFXIV worlds Dalamud has
// not yet seen). Fall back to the raw RowId so the user still has a
// unique, readable label.
return $"{playerName}@World{worldRowId}"; return $"{playerName}@World{worldRowId}";
} }
@@ -327,7 +288,9 @@ internal sealed class AutoTellTabsService : IDisposable
try try
{ {
// Pull one extra row: current message is already in store and would eat a preload slot // Pull one extra row because the live tell that triggered this
// spawn is already in the store and would otherwise eat one of
// the user's preload-budget slots.
var history = _store.GetTellHistoryWithSender( var history = _store.GetTellHistoryWithSender(
_messageManager.CurrentContentId, _messageManager.CurrentContentId,
senderName, senderName,
@@ -342,17 +305,23 @@ internal sealed class AutoTellTabsService : IDisposable
if (historicMessages.Count == 0) if (historicMessages.Count == 0)
{ {
// No prior tells; leave tab empty to avoid orphaned "history loaded" marker // No prior tells with this player — leave the tab to start
// empty so the user does not see a "history loaded" marker
// sitting alone above the very first message.
return; return;
} }
// History is oldest-first; add in order for chronological display // The history list is already oldest-first, so a plain AddPrune
// loop produces the chronological order the user expects to see
// when the tab opens.
foreach (var message in historicMessages) foreach (var message in historicMessages)
{ {
tab.Messages.AddPrune(message, MessageManager.MessageDisplayLimit); tab.Messages.AddPrune(message, MessageManager.MessageDisplayLimit);
} }
// Separator between history and live tell (sorts after history but before current) // Visible separator between the loaded history and the live
// tell that triggered this spawn. Goes in last so it sorts
// after the historical messages but before the current one.
tab.Messages.AddPrune( tab.Messages.AddPrune(
MakeSystemMarker(HellionStrings.AutoTellTabs_HistorySeparator), MakeSystemMarker(HellionStrings.AutoTellTabs_HistorySeparator),
MessageManager.MessageDisplayLimit MessageManager.MessageDisplayLimit
@@ -360,8 +329,10 @@ internal sealed class AutoTellTabsService : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// Non-fatal: tab still spawns with visible error notice instead of silent history loss // Non-fatal: the tab still spawns, but the user gets a visible
Plugin.LogProxy.Error(ex, "[AutoTellTabs] History preload failed"); // notice instead of silently missing history. The error logs
// once with full stack trace for diagnosis.
Plugin.Log.Error(ex, "[AutoTellTabs] History preload failed");
tab.Messages.AddPrune( tab.Messages.AddPrune(
MakeSystemMarker(HellionStrings.AutoTellTabs_HistoryLoadError), MakeSystemMarker(HellionStrings.AutoTellTabs_HistoryLoadError),
MessageManager.MessageDisplayLimit MessageManager.MessageDisplayLimit
@@ -401,7 +372,9 @@ internal sealed class AutoTellTabsService : IDisposable
lock (_tempTabsLock) lock (_tempTabsLock)
{ {
// Guard against frame-race: sidebar might render a tab already removed by LRU or logout // Frame-race guard (E5): the sidebar might still render a tab
// that has already been removed by LRU drop or logout cleanup.
// Silently skip the toggle so we don't mutate stale state.
if (!Plugin.Config.Tabs.Contains(tab)) if (!Plugin.Config.Tabs.Contains(tab))
{ {
return; return;
@@ -415,16 +388,20 @@ internal sealed class AutoTellTabsService : IDisposable
{ {
lock (_tempTabsLock) lock (_tempTabsLock)
{ {
// Pinned TempTabs must survive char-switch — that's the whole point // Snapshot whether the active tab is about to be removed, BEFORE
// of pinning. Only unpinned ones get stripped. // we mutate the list — index lookups would lie to us afterwards.
var lastIndex = _plugin.LastTab; var lastIndex = _plugin.LastTab;
var lastIndexValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count; var lastIndexValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count;
var currentWasUnpinnedTempTab = var currentWasTempTab = lastIndexValid && Plugin.Config.Tabs[lastIndex].IsTempTab;
lastIndexValid
&& TabLifecycleHelpers.IsInUnpinnedPool(Plugin.Config.Tabs[lastIndex]);
// v0.6.1 — symmetric to DropOldestTempTab cleanup: tear down any
// popped-out temp tab windows before removing the tabs themselves,
// otherwise PopOutWindows + WindowSystem keep ghost entries until
// the next plugin reload. Especially relevant once Auto-Pop-Out is
// enabled — every logout would otherwise leak as many ghosts as
// there were active /tell pop-outs.
var poppedTempTabIds = Plugin var poppedTempTabIds = Plugin
.Config.Tabs.Where(t => TabLifecycleHelpers.IsInUnpinnedPool(t) && t.PopOut) .Config.Tabs.Where(t => t.IsTempTab && t.PopOut)
.Select(t => t.Identifier) .Select(t => t.Identifier)
.ToList(); .ToList();
if (poppedTempTabIds.Count > 0) if (poppedTempTabIds.Count > 0)
@@ -440,78 +417,16 @@ internal sealed class AutoTellTabsService : IDisposable
} }
} }
Plugin.Config.Tabs.RemoveAll(TabLifecycleHelpers.IsInUnpinnedPool); Plugin.Config.Tabs.RemoveAll(t => t.IsTempTab);
// Force switch to tab 0 if active tab was an unpinned temp tab or // Force a switch to tab 0 if the active tab was a temp tab OR
// index is now out of range. Pinned tabs survive — no switch needed. // if drops before the active index pushed LastTab out of range.
// Otherwise the user keeps their current persistent tab.
var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count; var stillValid = lastIndex >= 0 && lastIndex < Plugin.Config.Tabs.Count;
if (currentWasUnpinnedTempTab || !stillValid) if (currentWasTempTab || !stillValid)
{ {
_plugin.WantedTab = 0; _plugin.WantedTab = 0;
} }
} }
} }
internal bool TryPin(Tab tab)
{
if (!tab.IsTempTab || tab.IsPinned)
{
Plugin.LogProxy.Debug(
$"[Pin] TryPin skipped: IsTempTab={tab.IsTempTab} IsPinned={tab.IsPinned}"
);
return false;
}
if (PinnedTempTabCount >= MaxPinnedTempTabs)
{
WrapperUtil.AddNotification(
string.Format(HellionStrings.PinTab_LimitReached, MaxPinnedTempTabs),
NotificationType.Warning
);
return false;
}
tab.IsPinned = true;
Plugin.LogProxy.Debug(
$"[Pin] Pinned tab '{tab.Name}' target={tab.TellTarget?.Name}@{tab.TellTarget?.World}"
);
_plugin.SaveConfig();
return true;
}
internal void Unpin(Tab tab)
{
if (!tab.IsPinned)
{
return;
}
// If the unpinned pool is already full, dropping the oldest before
// flipping the flag avoids counting the just-unpinned tab as a drop
// candidate.
if (ActiveTempTabCount >= Plugin.Config.AutoTellTabsLimit)
{
DropOldestTempTab();
}
tab.IsPinned = false;
Plugin.LogProxy.Debug("[Pin] Unpinned tab '{tab.Name}'");
_plugin.SaveConfig();
}
internal void PromoteToPermanent(Tab tab)
{
if (!tab.IsTempTab)
{
return;
}
tab.IsTempTab = false;
tab.IsPinned = false;
tab.TellTarget = TellTarget.Empty();
Plugin.LogProxy.Debug(
$"[Pin] Promoted tab '{tab.Name}' to permanent (tell-binding dropped)"
);
_plugin.SaveConfig();
}
} }
+5 -27
View File
@@ -1,33 +1,11 @@
using System.Runtime.CompilerServices; // HellionChat/Branding/BrandingLinks.cs
using HellionChat.Util;
namespace HellionChat.Branding; namespace HellionChat.Branding;
// Centralised a future invite/URL rotation only touches this file. // Centralised so a future invite rotation only touches one file. The same
// link is currently hard-coded in repo.json, README.md, SUPPORT.md,
// CONTRIBUTORS.md and HellionChat.yaml — those will be migrated to consume
// this constant in a separate housekeeping sweep
internal static class BrandingLinks internal static class BrandingLinks
{ {
public const string HellionForgeDiscordInvite = "https://discord.gg/X9V7Kcv5gR"; public const string HellionForgeDiscordInvite = "https://discord.gg/X9V7Kcv5gR";
public const string HellionForgeGitea = "https://gitea.hellion-forge.cloud/Hellion-Forge";
public const string HellionChatRepo =
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat";
public const string HellionForgeWebsite = "https://hellion-forge.cloud";
public const string HellionMediaWebsite = "https://hellion-media.de/de";
// CA2255 warns against [ModuleInitializer] in library code, but Dalamud
// loads the plugin DLL directly so the module-init pass is the right hook
// for a one-shot URL sanity check at plugin load.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(
nameof(BrandingLinks),
HellionForgeDiscordInvite,
HellionForgeGitea,
HellionChatRepo,
HellionForgeWebsite,
HellionMediaWebsite
);
}
} }
+9 -1
View File
@@ -34,7 +34,9 @@ public abstract class Chunk
_ => null, _ => null,
}; };
// Returns basic text for hashing (content for TextChunk, icon name for IconChunk) /// <summary>
/// Get some basic text for use in generating hashes.
/// </summary>
internal string StringValue() internal string StringValue()
{ {
return this switch return this switch
@@ -106,6 +108,9 @@ public class TextChunk : Chunk
Content = content ?? ""; Content = content ?? "";
} }
/// <summary>
/// Creates a new TextChunk with identical styling to this one.
/// </summary>
public TextChunk NewWithStyle(ChunkSource source, Payload? link, string content) public TextChunk NewWithStyle(ChunkSource source, Payload? link, string content)
{ {
return new TextChunk(source, link, content) return new TextChunk(source, link, content)
@@ -117,6 +122,9 @@ public class TextChunk : Chunk
}; };
} }
/// <summary>
/// Creates a new TextChunk with identical styling to this one.
/// </summary>
public TextChunk NewWithStyle(Chunk chunk, string content) public TextChunk NewWithStyle(Chunk chunk, string content)
{ {
return new TextChunk(chunk, content) return new TextChunk(chunk, content)
+11 -11
View File
@@ -7,36 +7,36 @@ public enum ChatSource : ushort
{ {
None = 0, None = 0,
// The player controlled by this client /// <summary>The player currently controlled by the local client.</summary>
LocalPlayer = 1 << XivChatRelationKind.LocalPlayer, LocalPlayer = 1 << XivChatRelationKind.LocalPlayer,
// Member of the local party /// <summary>A player in the same 4-man or 8-man party as the local player.</summary>
PartyMember = 1 << XivChatRelationKind.PartyMember, PartyMember = 1 << XivChatRelationKind.PartyMember,
// Member of the alliance /// <summary>A player in the same alliance raid.</summary>
AllianceMember = 1 << XivChatRelationKind.AllianceMember, AllianceMember = 1 << XivChatRelationKind.AllianceMember,
// Other player /// <summary>A player not in the local player's party or alliance.</summary>
OtherPlayer = 1 << XivChatRelationKind.OtherPlayer, OtherPlayer = 1 << XivChatRelationKind.OtherPlayer,
// Enemy in combat /// <summary>An enemy entity that is currently in combat with the player or party.</summary>
EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy, EngagedEnemy = 1 << XivChatRelationKind.EngagedEnemy,
// Enemy out of combat /// <summary>An enemy entity that is not yet in combat or claimed.</summary>
UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy, UnengagedEnemy = 1 << XivChatRelationKind.UnengagedEnemy,
// Friendly NPC /// <summary>An NPC that is friendly or neutral to the player (e.g., EventNPCs).</summary>
FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc, FriendlyNpc = 1 << XivChatRelationKind.FriendlyNpc,
// Own pet or companion /// <summary>A pet (Summoner/Scholar) or companion (Chocobo) belonging to the local player.</summary>
PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion, PetOrCompanion = 1 << XivChatRelationKind.PetOrCompanion,
// Pet or companion of party members /// <summary>A pet or companion belonging to a member of the local player's party.</summary>
PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty, PetOrCompanionParty = 1 << XivChatRelationKind.PetOrCompanionParty,
// Pet or companion of alliance members /// <summary>A pet or companion belonging to a member of the alliance.</summary>
PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance, PetOrCompanionAlliance = 1 << XivChatRelationKind.PetOrCompanionAlliance,
// Pet or companion of other players /// <summary>A pet or companion belonging to a player not in the party or alliance.</summary>
PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther, PetOrCompanionOther = 1 << XivChatRelationKind.PetOrCompanionOther,
} }
+2 -2
View File
@@ -52,7 +52,7 @@ internal sealed class Commands : IDisposable
{ {
if (!Registered.TryGetValue(command, out var wrapper)) if (!Registered.TryGetValue(command, out var wrapper))
{ {
Plugin.LogProxy.Warning($"Missing registration for command {command}"); Plugin.Log.Warning($"Missing registration for command {command}");
return; return;
} }
@@ -62,7 +62,7 @@ internal sealed class Commands : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, $"Error while executing command {command}"); Plugin.Log.Error(ex, $"Error while executing command {command}");
} }
} }
} }
+161 -105
View File
@@ -34,41 +34,38 @@ public class ConfigKeyBind
[Serializable] [Serializable]
public class Configuration : IPluginConfiguration public class Configuration : IPluginConfiguration
{ {
private const int LatestVersion = 17; private const int LatestVersion = 16;
public int Version { get; set; } = LatestVersion; public int Version { get; set; } = LatestVersion;
// Slug-based; ThemeRegistry resolves the object at runtime. // v1.1.0 — Theme-Engine. Slug-basiert; ThemeRegistry liefert das Objekt.
public string Theme = "hellion-arctic"; public string Theme = "hellion-arctic";
// Global window opacity, applied across all themes. // v1.1.0 — Globale Window-Opacity, theme-übergreifend. Migration aus
// HellionThemeWindowOpacity beim Bump v13 → v14.
public float WindowOpacity = 0.85f; public float WindowOpacity = 0.85f;
// Reserved for future UI toggles; pre-declared to avoid a migration later. // v1.1.0 — Felder für künftige UI-Toggles (v1.2.0 / v1.3.0). Werden
// vorab angelegt, damit später keine Migration nötig ist.
public bool ReduceMotion; public bool ReduceMotion;
// v1.2.1: default flipped false → true. Compact single-line layout is // v1.2.1 — Default geflippt von false → true. Card-Rows-Layout aus
// more readable than the card-rows layout introduced in v1.2.0. // v1.2.0 wurde als zu dicht empfunden; Single-Line `[HH:mm] Sender:
// Text` ist besser lesbar und platzsparender. Bestand-User mit aktiv
// false werden durch die v15→v16-Migration auf den neuen Default
// gehoben (Heuristik: wer in v1.2.0 false hatte, hatte den damals
// neu eingeführten Default — kaum jemand hat aktiv abgeschaltet).
public bool UseCompactDensity = true; public bool UseCompactDensity = true;
// Privacy by Default master switch. Set false to restore upstream behaviour. // Hellion Chat — Privacy filter (DSGVO Art. 25 Privacy by Default).
// Master-switch defaults to true; set false to restore upstream behavior.
public bool PrivacyFilterEnabled = true; public bool PrivacyFilterEnabled = true;
// Empty set means the migration has not run yet — see Plugin.cs v6→v7. // Empty set means the migration has not run yet — see Plugin.cs v6→v7.
public HashSet<ChatType> PrivacyPersistChannels = []; public HashSet<ChatType> PrivacyPersistChannels = [];
// Failsafe for ChatTypes added by future FFXIV patches. New configs default // Failsafe for ChatTypes added by future FFXIV patches we don't know about.
// to the failsafe via PrivacyDefaults; existing configs keep their saved public bool PrivacyPersistUnknownChannels;
// choice because the deserializer overrides this initializer.
public bool PrivacyPersistUnknownChannels = Privacy
.PrivacyDefaults
.DefaultPersistUnknownChannels;
// F3.2: dedup unknown-ChatType warnings so a chatty filter doesn't spam
// the log every frame. NonSerialized so the warning fires once per
// runtime, not once-ever-per-install.
[NonSerialized]
private readonly HashSet<ChatType> _warnedUnknownChannels = new();
public bool IsAllowedForStorage(ChatType type) public bool IsAllowedForStorage(ChatType type)
{ {
@@ -76,52 +73,82 @@ public class Configuration : IPluginConfiguration
return true; return true;
if (PrivacyPersistChannels.Contains(type)) if (PrivacyPersistChannels.Contains(type))
return true; return true;
// F3.2: log first occurrence of a ChatType the running build doesn't
// recognise — i.e. one a future FFXIV patch may have added. Known
// types the user opted out of are routed through the failsafe
// silently, like before.
if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type))
{
Plugin.LogProxy.Warning(
"PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
type,
PrivacyPersistUnknownChannels
);
}
return PrivacyPersistUnknownChannels; return PrivacyPersistUnknownChannels;
} }
// Retention master switch defaults to false — plugin will not delete // Hellion Chat — Message retention (GDPR data minimization, time axis).
// history until the user explicitly opts in. // Master switch defaults to false; the plugin will not delete history
// until the user explicitly opts in.
public bool RetentionEnabled; public bool RetentionEnabled;
public int RetentionDefaultDays = 30; public int RetentionDefaultDays = 30;
public Dictionary<ChatType, int> RetentionPerChannelDays = []; public Dictionary<ChatType, int> RetentionPerChannelDays = [];
public DateTimeOffset RetentionLastRunAt = DateTimeOffset.MinValue; public DateTimeOffset RetentionLastRunAt = DateTimeOffset.MinValue;
// Hellion Chat first-run wizard — opens once on a fresh install. Existing
// ChatTwo users skip it because the v6→v7 migration sets the flag.
public bool FirstRunCompleted; public bool FirstRunCompleted;
// Use the bundled Exo 2 font (OFL-1.1) for the regular plugin font
// instead of whatever GlobalFontV2.FontId points at. Default ON so a
// fresh install gets the Hellion typography out-of-the-box; flip OFF
// to fall back to the user's chosen system or Dalamud font.
public bool UseHellionFont = true; public bool UseHellionFont = true;
// Cycle 1 of the plugin-integration roadmap. When Honorific is installed
// and reports a custom title, render it in the chat header above the
// message log. Auto-hides regardless when Honorific is missing or the
// active title is original/empty, so leaving this on is safe even for
// users who don't run Honorific.
public bool ShowHonorificTitleInHeader = true; public bool ShowHonorificTitleInHeader = true;
// v1.4.7 opt-in: renders the Honorific glow outline when the title carries // Hellion Chat — Auto-Tell-Tabs. When enabled, an incoming or outgoing
// a Glow colour. Default OFF — keeps v1.4.6 visuals untouched for users // /tell spawns a session-only tab dedicated to that conversation
// who don't care, and dodges the per-frame DrawList overhead on low-end // partner. See spec: Hellion Chat Auto-Tell-Tabs Spec (Obsidian).
// hardware. Gradient (Color3 / GradientColourSet) is parsed but rendered
// as the primary Color until a later cycle ports the animation.
public bool ShowHonorificGlow;
public bool EnableAutoTellTabs = true; public bool EnableAutoTellTabs = true;
// Hard cap on simultaneously open auto tell tabs. Range enforced by the
// settings slider (150). LRU drop favors greeted tabs first.
public int AutoTellTabsLimit = 15; public int AutoTellTabsLimit = 15;
// When true the sidebar shows only a thin separator before the temp
// tabs; when false a section header "Active Tells (n)" is rendered.
public bool AutoTellTabsCompactDisplay; public bool AutoTellTabsCompactDisplay;
// Number of prior tells to preload from the message store when an
// auto tell tab is spawned. Range 0100; 0 disables preload.
public int AutoTellTabsHistoryPreload = 20; public int AutoTellTabsHistoryPreload = 20;
// Sidebar width in pixels. Default 44 mirrors the icon-only layout from // Show the greeter "marked-as-greeted" toggle button next to each
// v1.2.0; users can widen up to 160 to fit a section-header line like // temp tab and dim the tab name when set. Off by default because the
// "Active Tells (3)" without truncation. // workflow is specific to club-greeter use cases — most users just
public int SidebarWidth = 44; // want the auto tabs themselves without the extra UI affordance.
public bool AutoTellTabsShowGreetedToggle; public bool AutoTellTabsShowGreetedToggle;
// Hellion Chat — One-Time-Hint-Banner that introduces the v0.6.0 pop-out
// input feature. Set to true once the user dismisses the banner from a
// pop-out window; never reset after that.
public bool SeenPopOutInputHint; public bool SeenPopOutInputHint;
// Hellion Chat — v0.6.0 master switch for the pop-out input bar.
// Global on purpose: per-tab makes no sense for Auto-Tell-Tabs which
// are session-only and would force the user to re-enable it for every
// new conversation. Default flipped to ON in v0.6.1 (was OFF in v0.6.0)
// because tester feedback called the manual toggle "umständlich, wirkt
// unfertig". v11 → v12 migration applies the same flip to existing users.
public bool PopOutInputEnabled = true; public bool PopOutInputEnabled = true;
// Hellion Chat — v0.6.1 One-Time-Hint-Banner that introduces the
// chat-header pop-out toolbar button and reminds about the pop-out
// input default flip. Set to true once the user dismisses the banner
// from the main chat window; never reset after that.
public bool SeenPopOutHeaderHint; public bool SeenPopOutHeaderHint;
// Hellion Chat — v0.6.1 opt-in: when true, AutoTellTabsService.SpawnTempTab
// sets tab.PopOut = true on every new auto-tell tab so the conversation
// pops out as its own window directly. Closing the pop-out returns the
// tab to the sidebar via the standard Popout.OnClose() flow. Default OFF
// because the existing sidebar workflow is what most users (especially
// club greeters tracking many parallel tells) expect by default.
public bool AutoTellTabsOpenAsPopout; public bool AutoTellTabsOpenAsPopout;
public int GetRetentionDays(ChatType type) public int GetRetentionDays(ChatType type)
@@ -140,7 +167,10 @@ public class Configuration : IPluginConfiguration
public bool HideInLoadingScreens; public bool HideInLoadingScreens;
public bool HideInBattle; public bool HideInBattle;
// v1.2.1: default flipped false → true for consistency with other hide defaults. // v1.2.1 — Default geflippt false → true. Hellion-UI im NG+-Menü
// versteckt zu halten ist konsistent mit den anderen Hide-Defaults
// (Cutscenes, Logged-out, UI-Hidden) — UI-out-of-the-way bei Story-
// Sequenzen.
public bool HideInNewGamePlusMenu = true; public bool HideInNewGamePlusMenu = true;
public bool HideWhenInactive; public bool HideWhenInactive;
public int InactivityHideTimeout = 10; public int InactivityHideTimeout = 10;
@@ -156,8 +186,18 @@ public class Configuration : IPluginConfiguration
public bool NativeItemTooltips = true; public bool NativeItemTooltips = true;
public bool PrettierTimestamps = true; public bool PrettierTimestamps = true;
public bool MoreCompactPretty; public bool MoreCompactPretty;
// v1.2.1 — Default geflippt false → true. Wiederholte Zeitstempel
// innerhalb derselben Minute lesen sich als Rauschen; ein einziger
// Timestamp pro Minute reicht aus um die Konversation zu verorten.
public bool HideSameTimestamps = true; public bool HideSameTimestamps = true;
public bool ShowNoviceNetwork; public bool ShowNoviceNetwork;
// Hellion Chat — vertical sidebar tab layout reads better than the
// horizontal tab strip in the company of Auto-Tell-Tabs (a club
// greeter typically tracks 515 simultaneous conversations). Bestand
// users keep their saved value untouched — only fresh installs pick
// up the new default.
public bool SidebarTabView = true; public bool SidebarTabView = true;
public bool PrintChangelog = true; public bool PrintChangelog = true;
public bool OnlyPreviewIf; public bool OnlyPreviewIf;
@@ -178,10 +218,22 @@ public class Configuration : IPluginConfiguration
public bool CollapseKeepUniqueLinks; public bool CollapseKeepUniqueLinks;
public bool PlaySounds = true; public bool PlaySounds = true;
public bool KeepInputFocus = true; public bool KeepInputFocus = true;
// v1.2.1 — Default gesenkt 5000 → 2500. 5000 ist auf Mid-Range-
// Hardware bei langen Sessions spürbar langsamer (Card-Layout
// re-Layout pro Frame), 2500 deckt eine typische Stunde Chat ab
// und bleibt smooth. User die mehr brauchen können bis 10000 hoch.
public int MaxLinesToRender = 2_500; // 1-10000 public int MaxLinesToRender = 2_500; // 1-10000
// Default ON to match a German / European 24h locale. The
// ChatLogWindow.cs format-flip in v0.5.1 honours this strictly via
// CultureInfo.InvariantCulture so the result is consistent across
// host locales.
public bool Use24HourClock = true; public bool Use24HourClock = true;
public bool ShowEmotes = true; public bool ShowEmotes = true;
public HashSet<string> BlockedEmotes = []; public HashSet<string> BlockedEmotes = [];
public bool FontsEnabled = true; public bool FontsEnabled = true;
public ExtraGlyphRanges ExtraGlyphRanges = 0; public ExtraGlyphRanges ExtraGlyphRanges = 0;
public float FontSizeV2 = 12.75f; public float FontSizeV2 = 12.75f;
@@ -206,6 +258,12 @@ public class Configuration : IPluginConfiguration
public float TooltipOffset; public float TooltipOffset;
// v1.2.1 — Default-Chat-Farben sind das Hellion-Brand-Preset. Der
// First-Run-Wizard bietet keine Theme-/Preset-Wahl an, daher kriegen
// neue User die Hellion-Brand-Farben out-of-the-box (Cyan-Familie für
// Standard/Tell, Ember/Warning für laute Channels). Bestand-User mit
// leerem ChatColours-Dict werden durch die v15→v16-Migration auf das
// Preset gehoben; User die bereits Custom-Farben haben, bleiben.
public Dictionary<ChatType, uint> ChatColours = BuildDefaultChatColours(); public Dictionary<ChatType, uint> ChatColours = BuildDefaultChatColours();
private static Dictionary<ChatType, uint> BuildDefaultChatColours() private static Dictionary<ChatType, uint> BuildDefaultChatColours()
@@ -275,7 +333,9 @@ public class Configuration : IPluginConfiguration
MaxLinesToRender = other.MaxLinesToRender; MaxLinesToRender = other.MaxLinesToRender;
Use24HourClock = other.Use24HourClock; Use24HourClock = other.Use24HourClock;
ShowEmotes = other.ShowEmotes; ShowEmotes = other.ShowEmotes;
// Deep-copy so settings window edits don't leak into live config before Save. // Deep-copy the set so the live and mutable Configuration instances don't share state
// — a HashSet reference assignment would cause edits in the settings window to leak
// into the live config before the user clicks Save.
BlockedEmotes = new HashSet<string>(other.BlockedEmotes); BlockedEmotes = new HashSet<string>(other.BlockedEmotes);
FontsEnabled = other.FontsEnabled; FontsEnabled = other.FontsEnabled;
ItalicEnabled = other.ItalicEnabled; ItalicEnabled = other.ItalicEnabled;
@@ -289,21 +349,28 @@ public class Configuration : IPluginConfiguration
ChatColours = other.ChatColours.ToDictionary(entry => entry.Key, entry => entry.Value); ChatColours = other.ChatColours.ToDictionary(entry => entry.Key, entry => entry.Value);
ColorSelectedInputChannelButton = other.ColorSelectedInputChannelButton; ColorSelectedInputChannelButton = other.ColorSelectedInputChannelButton;
// Keep live temp tabs alive across UpdateFrom — a settings save must // Hellion Chat — Auto-Tell-Tabs are session-only and therefore
// not destroy open tell conversations. Pinned TempTabs are persistent // never present in a disk-loaded copy. Keep the live temp tabs of
// and come through `other` like regular tabs; unpinned TempTabs are // *this* configuration alive across an UpdateFrom so a settings
// session-only and held from the local state. For persistent tabs // save (or sidebar-mode toggle) does not silently destroy the
// (incl. pinned), capture live runtime state by Identifier and restore // user's open tell conversations.
// it onto the freshly cloned tabs — CurrentChannel is critical because //
// the user may have switched channel in-game between settings-open // For persistent tabs we go through Tab.Clone() which intentionally
// and settings-save, and we'd otherwise overwrite that with the // does NOT copy the NonSerialized Messages list (avoids shared
// settings-time snapshot. // mutable state on disk-load). On a settings save that means the
var liveUnpinnedTempTabs = Tabs.Where(TabLifecycleHelpers.IsInUnpinnedPool).ToList(); // chat history for every persistent tab would be wiped — bug
var livePersistentSession = Tabs.Where(t => !TabLifecycleHelpers.IsInUnpinnedPool(t)) // reported by Flo 2026-05-05. We work around it by capturing the
.ToDictionary(t => t.Identifier, t => (t.Messages, t.LastSendUnread, t.CurrentChannel)); // live MessageList (and LastSendUnread counter) by Identifier
// before the replace, then restoring it onto the freshly cloned
// tabs whose Identifier survives Tab.Clone(). New tabs added in
// settings get a fresh empty MessageList; deleted tabs lose their
// history (intended).
var liveTempTabs = Tabs.Where(t => t.IsTempTab).ToList();
var livePersistentSession = Tabs.Where(t => !t.IsTempTab)
.ToDictionary(t => t.Identifier, t => (t.Messages, t.LastSendUnread));
Tabs = other Tabs = other
.Tabs.Where(t => !t.IsTempTab || t.IsPinned) .Tabs.Where(t => !t.IsTempTab)
.Select(t => .Select(t =>
{ {
var clone = t.Clone(); var clone = t.Clone();
@@ -311,12 +378,11 @@ public class Configuration : IPluginConfiguration
{ {
clone.Messages = live.Messages; clone.Messages = live.Messages;
clone.LastSendUnread = live.LastSendUnread; clone.LastSendUnread = live.LastSendUnread;
clone.CurrentChannel = live.CurrentChannel;
} }
return clone; return clone;
}) })
.ToList(); .ToList();
Tabs.AddRange(liveUnpinnedTempTabs); Tabs.AddRange(liveTempTabs);
ChatTabForward = other.ChatTabForward; ChatTabForward = other.ChatTabForward;
ChatTabBackward = other.ChatTabBackward; ChatTabBackward = other.ChatTabBackward;
@@ -336,7 +402,6 @@ public class Configuration : IPluginConfiguration
FirstRunCompleted = other.FirstRunCompleted; FirstRunCompleted = other.FirstRunCompleted;
UseHellionFont = other.UseHellionFont; UseHellionFont = other.UseHellionFont;
ShowHonorificTitleInHeader = other.ShowHonorificTitleInHeader; ShowHonorificTitleInHeader = other.ShowHonorificTitleInHeader;
ShowHonorificGlow = other.ShowHonorificGlow;
// v1.1.0 theme engine fields // v1.1.0 theme engine fields
Theme = other.Theme; Theme = other.Theme;
@@ -348,7 +413,6 @@ public class Configuration : IPluginConfiguration
AutoTellTabsLimit = other.AutoTellTabsLimit; AutoTellTabsLimit = other.AutoTellTabsLimit;
AutoTellTabsCompactDisplay = other.AutoTellTabsCompactDisplay; AutoTellTabsCompactDisplay = other.AutoTellTabsCompactDisplay;
AutoTellTabsHistoryPreload = other.AutoTellTabsHistoryPreload; AutoTellTabsHistoryPreload = other.AutoTellTabsHistoryPreload;
SidebarWidth = other.SidebarWidth;
AutoTellTabsShowGreetedToggle = other.AutoTellTabsShowGreetedToggle; AutoTellTabsShowGreetedToggle = other.AutoTellTabsShowGreetedToggle;
SeenPopOutInputHint = other.SeenPopOutInputHint; SeenPopOutInputHint = other.SeenPopOutInputHint;
@@ -392,7 +456,9 @@ public class Tab
{ {
public string Name = Language.Tab_DefaultName; public string Name = Language.Tab_DefaultName;
// Optional FontAwesome glyph name; null falls back to TabIconMapping default. // v1.2.0 — optionaler FontAwesome-Glyph-Name. Null bedeutet:
// Default-Mapping aus TabIconMapping greift (basiert auf Tab-Name).
// User können hier per Settings → Tabs einen eigenen Glyph setzen.
public string? Icon = null; public string? Icon = null;
[Obsolete("Removed in favor of SelectedChannels")] [Obsolete("Removed in favor of SelectedChannels")]
@@ -423,11 +489,6 @@ public class Tab
public bool HideWhenInactive; public bool HideWhenInactive;
public bool IsTempTab; public bool IsTempTab;
// Pinned TempTabs survive plugin reload and logout — tester feedback from
// Jin (v1.4.7). Pinned tabs live in their own pool (MaxPinnedTempTabs)
// separate from the AutoTellTabsLimit bucket.
public bool IsPinned;
public bool AllSenderMessages; public bool AllSenderMessages;
public TellTarget TellTarget = TellTarget.Empty(); public TellTarget TellTarget = TellTarget.Empty();
@@ -449,12 +510,15 @@ public class Tab
[NonSerialized] [NonSerialized]
public Guid Identifier = Guid.NewGuid(); public Guid Identifier = Guid.NewGuid();
// Session-only greeted flag for club-greeter workflows. // Hellion Chat — Auto-Tell-Tabs greeted flag. Toggled manually from the
// sidebar to mark a tell partner as already greeted in the current
// session. NonSerialized because the temp tab itself is session-only.
[NonSerialized] [NonSerialized]
public bool IsGreeted; public bool IsGreeted;
// Separate validation keys per cache so TellTarget changes don't // v1.4.2 — TabTintCache uses separate validation keys per cache so a
// cause GetTint and GetIcon to strand each other with stale entries. // TellTarget change picked up by GetTint can't strand GetIcon (or vice
// versa) with a stale entry that looks fresh on the shared key.
[NonSerialized] [NonSerialized]
internal string? _cachedTintTellName; internal string? _cachedTintTellName;
@@ -476,12 +540,17 @@ public class Tab
public bool Matches(Message message) public bool Matches(Message message)
{ {
if (!message.Matches(SelectedChannels, ExtraChatAll, ExtraChatChannels)) if (!message.Matches(SelectedChannels, ExtraChatAll, ExtraChatChannels))
{
return false; return false;
}
// Temp tabs are bound to a single conversation partner — other tells // Auto-tell temp tabs are bound to a single conversation partner;
// matching the channel filter must not land here. // every other tell that matches the channel filter must NOT land
// here, otherwise all temp tabs would mirror "Tell Exclusive".
if (IsTempTab && TellTarget?.IsSet() == true) if (IsTempTab && TellTarget?.IsSet() == true)
{
return ChunkUtil.MatchesSender(message, TellTarget.Name, TellTarget.World); return ChunkUtil.MatchesSender(message, TellTarget.Name, TellTarget.World);
}
return true; return true;
} }
@@ -524,7 +593,7 @@ public class Tab
Opacity = Opacity, Opacity = Opacity,
Identifier = Identifier, Identifier = Identifier,
InputDisabled = InputDisabled, InputDisabled = InputDisabled,
CurrentChannel = CurrentChannel.Clone(), CurrentChannel = CurrentChannel,
CanMove = CanMove, CanMove = CanMove,
CanResize = CanResize, CanResize = CanResize,
IndependentHide = IndependentHide, IndependentHide = IndependentHide,
@@ -535,14 +604,16 @@ public class Tab
HideInBattle = HideInBattle, HideInBattle = HideInBattle,
HideWhenInactive = HideWhenInactive, HideWhenInactive = HideWhenInactive,
IsTempTab = IsTempTab, IsTempTab = IsTempTab,
IsPinned = IsPinned,
AllSenderMessages = AllSenderMessages, AllSenderMessages = AllSenderMessages,
TellTarget = TellTarget.Clone(), TellTarget = TellTarget.From(TellTarget),
IsGreeted = IsGreeted, IsGreeted = IsGreeted,
}; };
} }
/// Ordered message list with duplicate ID tracking, sorting and mutex protection. /// <summary>
/// MessageList provides an ordered list of messages with duplicate ID
/// tracking, sorting and mutex protection.
/// </summary>
public class MessageList public class MessageList
{ {
private readonly SemaphoreSlim LockSlim = new(1, 1); private readonly SemaphoreSlim LockSlim = new(1, 1);
@@ -630,7 +701,10 @@ public class Tab
} }
} }
/// Current message count. Lock-per-read is acceptable for 1×/sec status bar polling. /// <summary>
/// Aktuelle Anzahl der gespeicherten Messages. Lock-acquire pro Read
/// ist OK für 1×/sec Status-Bar-Polling (v1.2.0).
/// </summary>
public int Count public int Count
{ {
get get
@@ -647,7 +721,9 @@ public class Tab
} }
} }
/// Returns an array copy of the message list for usage outside of main thread. /// <summary>
/// Returns an array copy of the message list for usage outside of main thread
/// </summary>
public async Task<Message[]> GetCopy(int millisecondsTimeout = -1) public async Task<Message[]> GetCopy(int millisecondsTimeout = -1)
{ {
await LockSlim.WaitAsync(millisecondsTimeout); await LockSlim.WaitAsync(millisecondsTimeout);
@@ -661,7 +737,10 @@ public class Tab
} }
} }
/// Returns a read-only list while holding a reader lock. Use with a using statement. /// <summary>
/// GetReadOnly returns a read-only list of messages while holding a
/// reader lock. The list should be used with a using statement.
/// </summary>
public RLockedMessageList GetReadOnly(int millisecondsTimeout = -1) public RLockedMessageList GetReadOnly(int millisecondsTimeout = -1)
{ {
LockSlim.Wait(millisecondsTimeout); LockSlim.Wait(millisecondsTimeout);
@@ -715,29 +794,6 @@ public class UsedChannel
{ {
Channel = channel; Channel = channel;
} }
// ---------------------------------------------------------------
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Deep-clone the UsedChannel so Tab.Clone() no longer shares
// channel state (incl. TellTarget) with its origin Tab. Previously
// a reference copy: PopOut and Temp tabs mutated each other.
// - Name is intentionally a reference copy (matches upstream); it
// gets reassigned on every channel switch anyway.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/UsedChannelCloneTests.cs
// ---------------------------------------------------------------
public UsedChannel Clone()
{
return new UsedChannel
{
Channel = Channel,
Name = Name,
TellTarget = TellTarget?.Clone(),
UseTempChannel = UseTempChannel,
TempChannel = TempChannel,
TempTellTarget = TempTellTarget?.Clone(),
};
}
} }
[Serializable] [Serializable]
+34 -20
View File
@@ -79,7 +79,7 @@ public static class EmoteCache
Done, Done,
} }
// All fields below are uninitialised while State != Done. // All of this data is uninitalized while State is not `LoadingState.Done`
public static LoadingState State = LoadingState.Unloaded; public static LoadingState State = LoadingState.Unloaded;
private static readonly Dictionary<string, Emote> Cache = new(); private static readonly Dictionary<string, Emote> Cache = new();
@@ -87,11 +87,15 @@ public static class EmoteCache
public static string[] SortedCodeArray = []; public static string[] SortedCodeArray = [];
// Cancelled on Dispose to stop in-flight downloads; replaced on re-enable. // Plugin-scoped cancellation source for in-flight emote loads. Dispose
// cancels every running download/texture-create so the workers don't
// touch a torn-down TextureProvider on plugin reload. Replaced with a
// fresh source on the next LoadData() call so a re-enable still works.
private static CancellationTokenSource Cts = new(); private static CancellationTokenSource Cts = new();
internal static CancellationToken Token => Cts.Token; internal static CancellationToken Token => Cts.Token;
// Tracks in-flight loads so Dispose can drain them before teardown. // Drain target for in-flight loads on Dispose; without this an orphan
// continuation could still write to a torn-down Texture/Frames field.
private static readonly ConcurrentBag<Task> PendingLoads = new(); private static readonly ConcurrentBag<Task> PendingLoads = new();
internal static void TrackLoad(Task loadTask, string emoteCode) internal static void TrackLoad(Task loadTask, string emoteCode)
@@ -101,10 +105,7 @@ public static class EmoteCache
t => t =>
{ {
if (t.IsFaulted) if (t.IsFaulted)
Plugin.LogProxy.Error( Plugin.Log.Error(t.Exception!, $"EmoteCache load failed for {emoteCode}");
t.Exception!,
$"EmoteCache load failed for {emoteCode}"
);
}, },
TaskScheduler.Default TaskScheduler.Default
) )
@@ -116,7 +117,8 @@ public static class EmoteCache
if (State is not LoadingState.Unloaded) if (State is not LoadingState.Unloaded)
return; return;
// Reset CTS if Dispose was called and the plugin is being re-enabled. // Refresh the CTS in case Dispose was called and we're being re-enabled
// in the same process (Dalamud /xlplugins toggle).
if (Cts.IsCancellationRequested) if (Cts.IsCancellationRequested)
Cts = new CancellationTokenSource(); Cts = new CancellationTokenSource();
@@ -138,8 +140,11 @@ public static class EmoteCache
var topList = await top.Content.ReadAsStringAsync(ct); var topList = await top.Content.ReadAsStringAsync(ct);
var jsonList = JsonSerializer.Deserialize<List<Top100>>(topList)!; var jsonList = JsonSerializer.Deserialize<List<Top100>>(topList)!;
// BetterTTV occasionally returns entries with a null Code; // BetterTTV occasionally returns entries with a null Code; the
// skip them so a single bad row doesn't break the whole cache. // upstream code passed those straight into Dictionary.TryAdd
// and tripped ArgumentNullException, killing the whole emote
// load. Skip them defensively so a single bad row no longer
// breaks the cache for everyone else.
foreach (var emote in jsonList) foreach (var emote in jsonList)
if ( if (
!string.IsNullOrEmpty(emote.Emote.Code) !string.IsNullOrEmpty(emote.Emote.Code)
@@ -155,13 +160,18 @@ public static class EmoteCache
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
// Plugin disposed mid-load; State stays on Loading so re-enable can retry. // Plugin disposed while the cache was loading; leave State on
// Loading so a subsequent re-enable can re-issue LoadData with
// a fresh CTS (handled above).
} }
catch (Exception ex) catch (Exception ex)
{ {
// Reset to Unloaded so a later trigger can retry without a plugin reload. // Reset to Unloaded so a later trigger (e.g. the user reopening
// the Emotes tab after the network recovers) can retry. Without
// this the State stays on Loading and the early-out at the top
// of LoadData blocks every further attempt until plugin reload.
State = LoadingState.Unloaded; State = LoadingState.Unloaded;
Plugin.LogProxy.Error(ex, "BetterTTV cache wasn't initialized"); Plugin.Log.Error(ex, "BetterTTV cache wasn't initialized");
} }
} }
@@ -217,7 +227,7 @@ public static class EmoteCache
} }
catch catch
{ {
Plugin.LogProxy.Error("Failed to convert"); Plugin.Log.Error("Failed to convert");
return null; return null;
} }
} }
@@ -238,8 +248,11 @@ public static class EmoteCache
internal async Task<byte[]> LoadAsync(Emote emote, CancellationToken ct) internal async Task<byte[]> LoadAsync(Emote emote, CancellationToken ct)
{ {
// Path-traversal guard: resolve and verify the candidate path stays // BetterTTV-supplied Id and ImageType are interpolated straight
// inside the cache directory before reading or writing. // into the filename. HTTPS protects the wire, but a compromised
// upstream could still hand us "../foo" and write into the
// pluginConfigs root (or worse). Resolve the candidate path and
// refuse anything that escapes the cache directory.
var dir = Path.GetFullPath( var dir = Path.GetFullPath(
Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1") Path.Join(Plugin.Interface.ConfigDirectory.FullName, "EmoteCacheV1")
); );
@@ -307,7 +320,7 @@ public static class EmoteCache
catch (Exception ex) catch (Exception ex)
{ {
Failed = true; Failed = true;
Plugin.LogProxy.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}"); Plugin.Log.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}");
} }
} }
@@ -384,7 +397,7 @@ public static class EmoteCache
var delay = frame.Metadata.GetGifMetadata().FrameDelay / 100f; var delay = frame.Metadata.GetGifMetadata().FrameDelay / 100f;
// Match browser behaviour: anything under 20ms rounds up to 100ms. // Follows the same pattern as browsers, anything under 0.02s delay will be rounded up to 0.1s
if (delay < 0.02f) if (delay < 0.02f)
delay = 0.1f; delay = 0.1f;
@@ -403,7 +416,8 @@ public static class EmoteCache
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
// Plugin disposed mid-load; release any partial frames. // Plugin disposed mid-load; partial frames are released by
// InnerDispose on the next dispose pass.
foreach (var f in Frames) foreach (var f in Frames)
f.Texture.Dispose(); f.Texture.Dispose();
Frames = []; Frames = [];
@@ -411,7 +425,7 @@ public static class EmoteCache
catch (Exception ex) catch (Exception ex)
{ {
Failed = true; Failed = true;
Plugin.LogProxy.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}"); Plugin.Log.Error(ex, $"Unable to load {emote.Code} with id {emote.Id}");
} }
} }
} }
+9 -5
View File
@@ -32,8 +32,12 @@ internal static class ExportFormatExt
}; };
} }
// Serializes message snapshots to Markdown, JSON, or CSV. /// <summary>
// Caller handles pre-filtering except sender substring, which requires deserialized SeString.TextValue. /// Serializes message snapshots into Markdown, JSON, or CSV. The caller is
/// expected to filter the input enumerable; this class only handles
/// formatting and writes to the supplied path. Sender substring filtering
/// happens here because it requires deserialized SeString.TextValue.
/// </summary>
internal static class MessageExporter internal static class MessageExporter
{ {
internal record FilterDescription( internal record FilterDescription(
@@ -96,7 +100,6 @@ internal static class MessageExporter
var chatType = (ChatType)(ushort)m.Code.Type; var chatType = (ChatType)(ushort)m.Code.Type;
var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim(); var sender = m.SenderSource.TextValue.Trim().Trim('<', '>', '[', ']', ':').Trim();
var content = m.ContentSource.TextValue; var content = m.ContentSource.TextValue;
if (string.IsNullOrEmpty(sender)) if (string.IsNullOrEmpty(sender))
w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}"); w.WriteLine($"**[{localDate:HH:mm}] {chatType}:** {content}");
else else
@@ -129,7 +132,8 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Manual JSON to avoid System.Text.Json policy coupling. // Manual JSON to avoid pulling in System.Text.Json policy choices.
// Output is a single object with metadata and an array of messages.
w.Write("{\n \"exported_at\": \""); w.Write("{\n \"exported_at\": \"");
w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture)); w.Write(DateTimeOffset.UtcNow.ToString("O", CultureInfo.InvariantCulture));
w.Write("\",\n \"plugin\": \"Hellion Chat\",\n"); w.Write("\",\n \"plugin\": \"Hellion Chat\",\n");
@@ -190,7 +194,7 @@ internal static class MessageExporter
FilterDescription filter FilterDescription filter
) )
{ {
// Header always written so empty exports remain importable. // Header line always written so empty exports are still importable.
w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId"); w.WriteLine("Date,ChatType,ChatTypeName,Sender,Content,Receiver,ContentId");
var count = 0; var count = 0;
foreach (var m in messages) foreach (var m in messages)
+38 -37
View File
@@ -41,29 +41,24 @@ public class FontManager
90f, 90f,
]; ];
// Hellion font bytes (Exo 2, OFL-1.1); lazily loaded from manifest resources /// <summary>
/// Backing bytes for the bundled Hellion font (Exo 2, OFL-1.1). Lazily
/// extracted from the assembly's manifest resources on first use; the
/// load happens inside the font atlas build callback so we keep the
/// allocation off the plugin constructor's hot path.
/// </summary>
private static byte[]? HellionFontBytes; private static byte[]? HellionFontBytes;
// Returns null when the embedded font resource is missing. Should never private static byte[] GetHellionFontBytes()
// happen on a signed release build, but a broken csproj or hand-rolled
// dev build can land here. Caller falls back to the system font path so
// the plugin still loads instead of crashing the whole UiBuilder.
private static byte[]? TryGetHellionFontBytes()
{ {
if (HellionFontBytes is not null) if (HellionFontBytes is not null)
return HellionFontBytes; return HellionFontBytes;
using var stream = typeof(FontManager).Assembly.GetManifestResourceStream( using var stream =
"HellionFont.ttf" typeof(FontManager).Assembly.GetManifestResourceStream("HellionFont.ttf")
?? throw new FileNotFoundException(
"Hellion font resource not embedded in the assembly"
); );
if (stream is null)
{
Plugin.LogProxy.Warning(
"Hellion font resource missing — falling back to system default font."
);
return null;
}
using var ms = new MemoryStream(); using var ms = new MemoryStream();
stream.CopyTo(ms); stream.CopyTo(ms);
HellionFontBytes = ms.ToArray(); HellionFontBytes = ms.ToArray();
@@ -75,9 +70,11 @@ public class FontManager
ushort[] BuildRange(IReadOnlyList<ushort>? chars, params nint[] ranges) ushort[] BuildRange(IReadOnlyList<ushort>? chars, params nint[] ranges)
{ {
var builder = new ImFontGlyphRangesBuilderPtr(ImGuiNative.ImFontGlyphRangesBuilder()); var builder = new ImFontGlyphRangesBuilderPtr(ImGuiNative.ImFontGlyphRangesBuilder());
// text
foreach (var range in ranges) foreach (var range in ranges)
builder.AddRanges((ushort*)range); builder.AddRanges((ushort*)range);
// chars
if (chars != null) if (chars != null)
{ {
for (var i = 0; i < chars.Count; i += 2) for (var i = 0; i < chars.Count; i += 2)
@@ -119,7 +116,13 @@ public class FontManager
JpRange = BuildRange(GlyphRangesJapanese.GlyphRanges); JpRange = BuildRange(GlyphRangesJapanese.GlyphRanges);
} }
// CPU-bound build offloaded to Task.Run; runs parallel with theme init /// <summary>
/// Async wrapper around <see cref="BuildFonts"/> for the Phase-1 LoadAsync
/// path. The font-atlas build is CPU-bound, so we offload via Task.Run and
/// honour the cancellation token at the scheduling boundary; this lets the
/// font build run in parallel with the theme init without blocking the
/// loader. Settings-driven manual rebuilds keep using the sync entry point.
/// </summary>
public async Task BuildFontsAsync(CancellationToken cancellationToken) public async Task BuildFontsAsync(CancellationToken cancellationToken)
{ {
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
@@ -151,16 +154,18 @@ public class FontManager
RegularFont = Plugin.Interface.UiBuilder.FontAtlas.NewDelegateFontHandle(e => RegularFont = Plugin.Interface.UiBuilder.FontAtlas.NewDelegateFontHandle(e =>
e.OnPreBuild(tk => e.OnPreBuild(tk =>
{ {
// v1.2.0: UseHellionFont controls font size selection // v1.2.0 — Bei aktiver Hellion-Schrift (Exo 2 ist Variable-Font)
// wird die User-Schriftgröße aus FontSizeV2 als SizePt angewendet.
// Der Bestand-Pfad nutzt weiter GlobalFontV2.SizePt aus dem
// Custom-Font-Stack. Ohne diese Verzweigung war FontSizeV2 bei
// UseHellionFont=true wirkungslos, was 4K-User mit größerer
// Skalierung blockierte (Settings → Erscheinungsbild → Schriftarten).
var basePt = Plugin.Config.UseHellionFont var basePt = Plugin.Config.UseHellionFont
? Plugin.Config.FontSizeV2 ? Plugin.Config.FontSizeV2
: Plugin.Config.GlobalFontV2.SizePt; : Plugin.Config.GlobalFontV2.SizePt;
var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges }; var config = new SafeFontConfig { SizePt = basePt, GlyphRanges = Ranges };
// F10.2: if the embedded font is missing, drop to the system font config.MergeFont = Plugin.Config.UseHellionFont
// path rather than letting the UiBuilder throw. ? tk.AddFontFromMemory(GetHellionFontBytes(), config, "Hellion-Exo2")
var hellionBytes = Plugin.Config.UseHellionFont ? TryGetHellionFontBytes() : null;
config.MergeFont = hellionBytes is not null
? tk.AddFontFromMemory(hellionBytes, config, "Hellion-Exo2")
: AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global"); : AddFontWithFallback(tk, Plugin.Config.GlobalFontV2.FontId, config, "global");
config.SizePt = Plugin.Config.JapaneseFontV2.SizePt; config.SizePt = Plugin.Config.JapaneseFontV2.SizePt;
@@ -213,7 +218,13 @@ public class FontManager
} }
} }
// Add font with fallback to NotoSansCjkRegular if unavailable /// <summary>
/// Try to add a user-configured font to the build toolkit, falling back to
/// the bundled NotoSansCjkRegular asset if the configured font isn't
/// available on the system. Without this guard a stale SystemFontId
/// pointing at a font the user uninstalled or that never existed on
/// Linux (e.g. "Crimson Text") tears down the entire font atlas build.
/// </summary>
private static ImFontPtr AddFontWithFallback( private static ImFontPtr AddFontWithFallback(
IFontAtlasBuildToolkitPreBuild tk, IFontAtlasBuildToolkitPreBuild tk,
IFontId fontId, IFontId fontId,
@@ -226,21 +237,11 @@ public class FontManager
return fontId.AddToBuildToolkit(tk, config); return fontId.AddToBuildToolkit(tk, config);
} }
catch (Exception e) catch (Exception e)
when (e when (e is FileNotFoundException or DirectoryNotFoundException or IOException)
is FileNotFoundException
or DirectoryNotFoundException
or IOException
or InvalidOperationException
or ArgumentException
)
{ {
// Atlas-toolkit throws span IO and validation failures; routing the Plugin.Log.Warning(
// wider set through the fallback keeps a corrupt font config from
// taking down the whole atlas build.
Plugin.LogProxy.Warning(
e, e,
$"Configured {slot} font failed to load ({e.GetType().Name}), " $"Configured {slot} font unavailable, falling back to NotoSansCjkRegular"
+ "falling back to NotoSansCjkRegular"
); );
var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular); var fallback = new DalamudAssetFontAndFamilyId(DalamudAsset.NotoSansCjkRegular);
return fallback.AddToBuildToolkit(tk, config); return fallback.AddToBuildToolkit(tk, config);
+44 -36
View File
@@ -174,7 +174,8 @@ internal sealed unsafe class Chat : IDisposable
internal static void RotateCrossLinkshellHistory(RotateMode mode) => internal static void RotateCrossLinkshellHistory(RotateMode mode) =>
UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode)); UIModule.Instance()->RotateCrossLinkshellHistory(GetRotateIdx(mode));
// Look up a channel's user-defined color, returns null if 0 // This function looks up a channel's user-defined color.
// If this function ever returns 0, it returns null instead.
internal uint? GetChannelColor(ChatType type) internal uint? GetChannelColor(ChatType type)
{ {
var parent = type.Parent(); var parent = type.Parent();
@@ -214,7 +215,8 @@ internal sealed unsafe class Chat : IDisposable
if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null) if (Plugin.Functions.KeybindManager.DirectChat && LastTypedCharacter != null)
{ {
// Capture the just-typed character input // FIXME: this whole system sucks
// FIXME v2: I hate everything about this, but it works
Plugin.Framework.RunOnTick(() => Plugin.Framework.RunOnTick(() =>
{ {
string? input = null; string? input = null;
@@ -236,7 +238,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
}); });
} }
@@ -253,9 +255,13 @@ internal sealed unsafe class Chat : IDisposable
try try
{ {
// Prevent duplicate calls // We already called this function once, so we skip the duplicated call
// Also return the original value here so that vanilla chat receives all information
if (Plugin.ChatLogWindow.TellSpecial) if (Plugin.ChatLogWindow.TellSpecial)
{
Plugin.Log.Information("Return early to prevent duplicated call...");
return ChatLogRefreshHook!.Original(log, eventId, value); return ChatLogRefreshHook!.Original(log, eventId, value);
}
Plugin.ChatLogWindow.Activated( Plugin.ChatLogWindow.Activated(
new ChatActivatedArgs(new ChannelSwitchInfo(null)) new ChatActivatedArgs(new ChannelSwitchInfo(null))
@@ -266,10 +272,11 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
return 1; // Prevent vanilla chat log from gaining focus // prevent the game from focusing the chat log
return 1;
} }
private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent) private CStringPointer ChangeChannelNameDetour(AgentChatLog* agent)
@@ -299,7 +306,7 @@ internal sealed unsafe class Chat : IDisposable
{ {
playerName = SeString.Parse(agent->TellPlayerName).TextValue; playerName = SeString.Parse(agent->TellPlayerName).TextValue;
worldId = agent->TellWorldId; worldId = agent->TellWorldId;
Plugin.LogProxy.Debug($"Detected tell target '[redacted]'@{worldId}"); Plugin.Log.Debug($"Detected tell target '[redacted]'@{worldId}");
} }
Plugin.CurrentTab.CurrentChannel = new UsedChannel Plugin.CurrentTab.CurrentChannel = new UsedChannel
@@ -358,7 +365,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
} }
@@ -408,7 +415,7 @@ internal sealed unsafe class Chat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
} }
@@ -423,24 +430,19 @@ internal sealed unsafe class Chat : IDisposable
); );
} }
// --------------------------------------------------------------- /// <summary>
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12) /// Returns true if the channel is any non-linkshell channel, or if the
// - Renamed ValidAnyLinkshell -> IsChannelOrExistingLinkshell. The /// linkshell actually exists.
// name now states intent: returns true for any non-linkshell /// </summary>
// channel, or a linkshell index that actually exists. internal static bool ValidAnyLinkshell(InputChannel channel)
// ---------------------------------------------------------------
internal static bool IsChannelOrExistingLinkshell(InputChannel channel)
{ {
var idx = channel.LinkshellIndex(); var idx = channel.LinkshellIndex();
if (idx == uint.MaxValue || channel.IsExtraChatLinkshell()) if (idx == uint.MaxValue || channel.IsExtraChatLinkshell())
return true; return true;
if (channel.IsLinkshell() && ValidLinkshell(idx))
if (channel.IsLinkshell()) return true;
return ValidLinkshell(idx); if (channel.IsCrossLinkshell() && ValidCrossLinkshell(idx))
return true;
if (channel.IsCrossLinkshell())
return ValidCrossLinkshell(idx);
return false; return false;
} }
@@ -475,7 +477,8 @@ internal sealed unsafe class Chat : IDisposable
_ => 1, _ => 1,
}; };
for (var i = 0; i < 8; i++) // Find valid linkshell within 8 iterations // Iterate up to 8 times to find a valid linkshell.
for (var i = 0; i < 8; i++)
{ {
currentIndex = (uint)((8 + currentIndex + delta) % 8); currentIndex = (uint)((8 + currentIndex + delta) % 8);
if (validFn(currentIndex)) if (validFn(currentIndex))
@@ -521,7 +524,7 @@ internal sealed unsafe class Chat : IDisposable
); );
// RotateLinkshell returns null when no valid linkshell is found within 8 iterations. // RotateLinkshell returns null when no valid linkshell is found within 8 iterations.
// Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic. // Forward the null so the caller can keep the existing channel instead of crashing on nullable arithmetic.
return idx is null ? null : channel + idx.Value; // null if not found, otherwise new channel return idx is null ? null : channel + idx.Value;
} }
default: default:
return channel; return channel;
@@ -530,7 +533,11 @@ internal sealed unsafe class Chat : IDisposable
internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null) internal void SetChannel(InputChannel channel, TellTarget? tellTarget = null)
{ {
// Ignore ExtraChat linkshells (use ChatLogWindow.SetChannel() instead) // ExtraChat linkshells aren't supported in game so we never want to
// call the ChangeChatChannel function with them.
//
// Callers should call ChatLogWindow.SetChannel() which handles
// ExtraChat channels
if (channel.IsExtraChatLinkshell()) if (channel.IsExtraChatLinkshell())
return; return;
@@ -539,17 +546,12 @@ internal sealed unsafe class Chat : IDisposable
if (idx == uint.MaxValue) if (idx == uint.MaxValue)
idx = 0; idx = 0;
// --------------------------------------------------------------- if (!ValidAnyLinkshell(channel))
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12) return;
// - Wrap ChangeChatChannel in the validity check instead of
// early-returning. The previous early return skipped Dtor and
// leaked the native Utf8String allocated a few lines above.
// ---------------------------------------------------------------
if (IsChannelOrExistingLinkshell(channel))
RaptureShellModule RaptureShellModule
.Instance() .Instance()
->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true); ->ChangeChatChannel(tellTarget != null ? 17 : (int)channel, idx, target, true);
target->Dtor(true); target->Dtor(true);
} }
@@ -563,6 +565,9 @@ internal sealed unsafe class Chat : IDisposable
bool setChatType bool setChatType
) )
{ {
// param6 is 0 for contentId and 1 for objectId
// param7 is always 0 ?
if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel) if (!Plugin.CurrentTab.CurrentChannel.UseTempChannel)
Plugin.CurrentTab.CurrentChannel.UseTempChannel = true; Plugin.CurrentTab.CurrentChannel.UseTempChannel = true;
@@ -624,7 +629,7 @@ internal sealed unsafe class Chat : IDisposable
if (contentId == 0) if (contentId == 0)
{ {
Plugin.ChatGui.PrintError(Language.Chat_SendTell_Error); Plugin.ChatGui.PrintError(Language.Chat_SendTell_Error);
Plugin.LogProxy.Warning( Plugin.Log.Warning(
"Tried to send a tell with ContentId being 0, sorry this is an internal error." "Tried to send a tell with ContentId being 0, sorry this is an internal error."
); );
return; return;
@@ -737,7 +742,10 @@ internal sealed unsafe class Chat : IDisposable
internal bool CheckHideFlags() internal bool CheckHideFlags()
{ {
// Only hide chat in cutscene when vanilla chat would also be hidden // Only hide the chat in a cutscene when the vanilla chat would've
// also been hidden. This prevents Chat 2 from hiding for a split
// second before the cutscene actually starts, because the game sets
// the cutscene conditions before processing the skip.
var raptureAtkUnitManager = RaptureAtkUnitManager.Instance(); var raptureAtkUnitManager = RaptureAtkUnitManager.Instance();
return raptureAtkUnitManager == null return raptureAtkUnitManager == null
|| raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat); || raptureAtkUnitManager->UiFlags.HasFlag(UiFlags.Chat);
+12 -3
View File
@@ -15,10 +15,17 @@ public unsafe class ChatBox
mes->Dtor(true); mes->Dtor(true);
} }
public static void SendMessage(string message) => SendMessageUnsafe(ValidateMessage(message)); public static void SendMessage(string message)
{
var bytes = ValidateMessage(message);
SendMessageUnsafe(bytes);
}
// sanitiserOverride allows xUnit to bypass Utf8String->SanitizeString (game memory only). // Validation split out so the deterministic checks (UTF-8 length, sanitise
// Returns encoded bytes so SendMessage avoids a second GetBytes call. // round-trip) can run in xUnit without ClientStructs game memory. The
// sanitiser is injectable so tests can pin throw behaviour without invoking
// Utf8String->SanitizeString, which only resolves in-process. Returns the
// already-encoded bytes so SendMessage doesn't pay GetBytes twice.
// TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs // TEST-MIRROR: ../../../Hellion Build test/GameFunctions/ChatBoxTests.cs
internal static byte[] ValidateMessage( internal static byte[] ValidateMessage(
string message, string message,
@@ -42,9 +49,11 @@ public unsafe class ChatBox
private static string SanitiseText(string text) private static string SanitiseText(string text)
{ {
var uText = Utf8String.FromString(text); var uText = Utf8String.FromString(text);
uText->SanitizeString((AllowedEntities)0x27F); uText->SanitizeString((AllowedEntities)0x27F);
var sanitised = uText->ToString(); var sanitised = uText->ToString();
uText->Dtor(true); uText->Dtor(true);
return sanitised; return sanitised;
} }
} }
+57 -20
View File
@@ -47,6 +47,7 @@ internal unsafe class GameFunctions : IDisposable
Chat = new Chat(Plugin); Chat = new Chat(Plugin);
Plugin.GameInteropProvider.InitializeFromAttributes(this); Plugin.GameInteropProvider.InitializeFromAttributes(this);
ResolveTextCommandPlaceholderHook?.Enable(); ResolveTextCommandPlaceholderHook?.Enable();
} }
@@ -54,24 +55,36 @@ internal unsafe class GameFunctions : IDisposable
{ {
Chat.Dispose(); Chat.Dispose();
KeybindManager.Dispose(); KeybindManager.Dispose();
ResolveTextCommandPlaceholderHook?.Dispose(); ResolveTextCommandPlaceholderHook?.Dispose();
Marshal.FreeHGlobal(PlaceholderNamePtr); Marshal.FreeHGlobal(PlaceholderNamePtr);
} }
internal void SendFriendRequest(string name, ushort world) => internal void SendFriendRequest(string name, ushort world)
{
ListCommand(name, world, "friendlist"); ListCommand(name, world, "friendlist");
}
internal void AddToBlacklist(string name, ushort world) => ListCommand(name, world, "blist"); internal void AddToBlacklist(string name, ushort world)
{
ListCommand(name, world, "blist");
}
internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId) => internal void AddToMuteList(ulong accountId, ulong contentId, string name, short worldId)
{
AgentMutelist.Instance()->Add(accountId, contentId, name, worldId); AgentMutelist.Instance()->Add(accountId, contentId, name, worldId);
}
internal void AddToTermsList(SeString content) => internal void AddToTermsList(SeString content)
{
AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator()); AgentTermFilter.Instance()->OpenNewFilterWindow(content.EncodeWithNullTerminator());
}
private void ListCommand(string name, ushort world, string commandName) private void ListCommand(string name, ushort world, string commandName)
{ {
var worldRow = Sheets.WorldSheet.GetRow(world); var worldRow = Sheets.WorldSheet.GetRow(world);
ReplacementName = $"{name}@{worldRow.Name.ToString()}"; ReplacementName = $"{name}@{worldRow.Name.ToString()}";
ChatBox.SendMessage($"/{commandName} add {Placeholder}"); ChatBox.SendMessage($"/{commandName} add {Placeholder}");
} }
@@ -95,6 +108,7 @@ internal unsafe class GameFunctions : IDisposable
{ {
for (var i = 0; i < 4; i++) for (var i = 0; i < 4; i++)
SetAddonInteractable($"ChatLogPanel_{i}", interactable); SetAddonInteractable($"ChatLogPanel_{i}", interactable);
SetAddonInteractable("ChatLog", interactable); SetAddonInteractable("ChatLog", interactable);
} }
@@ -110,6 +124,7 @@ internal unsafe class GameFunctions : IDisposable
var agent = AgentItemDetail.Instance(); var agent = AgentItemDetail.Instance();
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
// atkStage ain't gonna be null or we have bigger problems
if (agent == null || addon == null) if (agent == null || addon == null)
return; return;
@@ -118,19 +133,23 @@ internal unsafe class GameFunctions : IDisposable
agent->Index = 0; agent->Index = 0;
agent->Flag1 &= 0xEF; agent->Flag1 &= 0xEF;
agent->ItemId = id; agent->ItemId = id;
// agent->Flag2 = 1;
// TODO: Revert when CS offset lands in a release build. // agent->Flag3 = 0;
// TODO: Revert whenever CS is merged
*(byte*)((nint)agent + 0x21A) = 1; *(byte*)((nint)agent + 0x21A) = 1;
*(byte*)((nint)agent + 0x21E) = 0; *(byte*)((nint)agent + 0x21E) = 0;
// This just probably needs to be set
agent->AddonId = addon->Id; agent->AddonId = addon->Id;
// Skips early return
atkStage->TooltipManager.TooltipType |= 2; atkStage->TooltipManager.TooltipType |= 2;
addon->Show(false, 15); addon->Show(false, 15);
} }
internal static void CloseItemTooltip() internal static void CloseItemTooltip()
{ {
// Hide addon first to suppress the "addon close" sound. // hide addon first to prevent the "addon close" sound
var addon = GetAddon<AtkUnitBase>("ItemDetail"); var addon = GetAddon<AtkUnitBase>("ItemDetail");
if (addon != null) if (addon != null)
addon->Hide(true, false, 0); addon->Hide(true, false, 0);
@@ -148,7 +167,7 @@ internal unsafe class GameFunctions : IDisposable
internal static void OpenPartyFinder() internal static void OpenPartyFinder()
{ {
// 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01) // this whole method: 6.05: 84433A (FF 97 ?? ?? ?? ?? 41 B4 01)
var lfg = AgentLookingForGroup.Instance(); var lfg = AgentLookingForGroup.Instance();
if (lfg->IsAgentActive()) if (lfg->IsAgentActive())
{ {
@@ -169,10 +188,15 @@ internal unsafe class GameFunctions : IDisposable
} }
} }
internal static bool IsMentor() => PlayerState.Instance()->IsMentor(); internal static bool IsMentor()
{
return PlayerState.Instance()->IsMentor();
}
internal static InfoProxyCommonList.CharacterData[] GetFriends() => internal static InfoProxyCommonList.CharacterData[] GetFriends()
InfoProxyFriendList.Instance()->CharDataSpan.ToArray(); {
return InfoProxyFriendList.Instance()->CharDataSpan.ToArray();
}
internal static void OpenQuestLog(RowRef<Quest> quest) internal static void OpenQuestLog(RowRef<Quest> quest)
{ {
@@ -199,12 +223,20 @@ internal unsafe class GameFunctions : IDisposable
AgentQuestJournal.Instance()->OpenForQuest(questId, 1); AgentQuestJournal.Instance()->OpenForQuest(questId, 1);
} }
internal static void OpenPartyFinder(uint id) => internal static void OpenPartyFinder(uint id)
{
AgentLookingForGroup.Instance()->OpenListing(id); AgentLookingForGroup.Instance()->OpenListing(id);
}
internal static void OpenAchievement(uint id) => AgentAchievement.Instance()->OpenById(id); internal static void OpenAchievement(uint id)
{
AgentAchievement.Instance()->OpenById(id);
}
internal static bool IsInInstance() => Plugin.Condition[ConditionFlag.BoundByDuty56]; internal static bool IsInInstance()
{
return Plugin.Condition[ConditionFlag.BoundByDuty56];
}
internal static bool TryOpenAdventurerPlate(ulong playerId) internal static bool TryOpenAdventurerPlate(ulong playerId)
{ {
@@ -215,7 +247,7 @@ internal unsafe class GameFunctions : IDisposable
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Warning(e, "Unable to open adventurer plate"); Plugin.Log.Warning(e, "Unable to open adventurer plate");
return false; return false;
} }
} }
@@ -223,7 +255,8 @@ internal unsafe class GameFunctions : IDisposable
internal static void ClickNoviceNetworkButton() internal static void ClickNoviceNetworkButton()
{ {
var agent = AgentChatLog.Instance(); var agent = AgentChatLog.Instance();
var value = new AtkValue { Type = ValueType.Int, Int = 3 }; // case 3 // case 3
var value = new AtkValue { Type = ValueType.Int, Int = 3 };
var result = 0; var result = 0;
var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*) var vf0 = *(delegate* unmanaged<AgentChatLog*, int*, AtkValue*, ulong, ulong, int*>*)
agent->VirtualTable; agent->VirtualTable;
@@ -242,8 +275,9 @@ internal unsafe class GameFunctions : IDisposable
byte a4 byte a4
) )
{ {
// Hook field is nullable due to the Signature attribute, but will never // The detour is only invoked through the hook, so the hook should
// be null during normal execution; guard covers the teardown race only. // never be null here, but the nullable field declaration forces us
// to handle the theoretical race during teardown.
if (ResolveTextCommandPlaceholderHook is null) if (ResolveTextCommandPlaceholderHook is null)
return nint.Zero; return nint.Zero;
@@ -251,11 +285,13 @@ internal unsafe class GameFunctions : IDisposable
if (ReplacementName == null || placeholder != Placeholder) if (ReplacementName == null || placeholder != Placeholder)
return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4); return ResolveTextCommandPlaceholderHook.Original(a1, placeholderText, a3, a4);
// Guard against a malformed ReplacementName overflowing the 128-byte buffer. // The fixed buffer is 128 bytes; UTF-8 + null-terminator must fit.
// FFXIV player names plus an @World suffix should never approach this
// limit, but a malformed ReplacementName must not overflow the buffer.
var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName); var byteCount = System.Text.Encoding.UTF8.GetByteCount(ReplacementName);
if (byteCount >= PlaceholderBufferSize) if (byteCount >= PlaceholderBufferSize)
{ {
Plugin.LogProxy.Warning( Plugin.Log.Warning(
$"Replacement name too long for placeholder buffer ({byteCount} bytes >= {PlaceholderBufferSize}); falling back to original." $"Replacement name too long for placeholder buffer ({byteCount} bytes >= {PlaceholderBufferSize}); falling back to original."
); );
ReplacementName = null; ReplacementName = null;
@@ -264,6 +300,7 @@ internal unsafe class GameFunctions : IDisposable
MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName); MemoryHelper.WriteString(PlaceholderNamePtr, ReplacementName);
ReplacementName = null; ReplacementName = null;
return PlaceholderNamePtr; return PlaceholderNamePtr;
} }
} }
+1 -1
View File
@@ -507,7 +507,7 @@ internal unsafe class KeybindManager : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in chat Activated event"); Plugin.Log.Error(ex, "Error in chat Activated event");
} }
} }
@@ -40,11 +40,5 @@ public class TellTarget
public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct); public static TellTarget Empty() => new(string.Empty, 0, 0, TellReason.Direct);
// --------------------------------------------------------------- public static TellTarget From(TellTarget t) => new(t.Name, t.World, t.ContentId, t.Reason);
// Cherry-picked from ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12)
// - Replaced static From(t) with an instance-style Clone() so call
// sites read like a copy operation, not a factory.
// TEST-MIRROR: ../../../Hellion Build test/_Helpers/TellTargetCloneTests.cs
// ---------------------------------------------------------------
public TellTarget Clone() => new(Name, World, ContentId, Reason);
} }
+41 -9
View File
@@ -1,21 +1,36 @@
<Project Sdk="Dalamud.NET.Sdk/15.0.0"> <Project Sdk="Dalamud.NET.Sdk/15.0.0">
<PropertyGroup> <PropertyGroup>
<!-- Independent versioning; see yaml changelog for upstream Chat 2 base --> <!-- Hellion Chat versioning runs separately from upstream Chat 2.
<Version>1.4.9</Version> 0.1.0 is our bootstrap release; the underlying Chat 2 base is
called out in the yaml changelog so users can see what it
derives from. -->
<Version>1.4.3</Version>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<!-- Use lock file to pin exact versions --> <!-- Honor packages.lock.json on restore so floating version ranges
don't silently drift between machines or CI runs. -->
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<!-- v1.0.0+: standalone fork, no upstream cherry-pick compatibility --> <!-- v1.0.0 standalone cut — both AssemblyName and RootNamespace
are HellionChat. The plugin no longer maintains source-level
cherry-pick compatibility with upstream Infiziert90/ChatTwo;
upstream changes are integrated manually if at all. -->
<AssemblyName>HellionChat</AssemblyName> <AssemblyName>HellionChat</AssemblyName>
<RootNamespace>HellionChat</RootNamespace> <RootNamespace>HellionChat</RootNamespace>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<!-- Closed ranges prevent surprise major bumps during lock file regeneration --> <!-- Closed ranges on packages with breaking-change history block a
surprise major bump when the lock file is regenerated. The
lock file pins the exact version per build; the upper bound
keeps the unlock path from drifting across major lines. -->
<PackageReference Include="MessagePack" Version="[3.1.4, 4.0.0)" /> <PackageReference Include="MessagePack" Version="[3.1.4, 4.0.0)" />
<PackageReference Include="Microsoft.Data.Sqlite" Version="10.0.7" /> <PackageReference Include="Microsoft.Data.Sqlite" Version="10.0.7" />
<!-- SQLitePCLRaw override for CVE-2025-6965, CVE-2025-7709 (SQLite >= 3.50.3) --> <!-- Override the transitively-referenced native SQLite build to one
that ships SQLite >= 3.50.3 (CVE-2025-6965 memory corruption,
CVE-2025-7709 fixed in 3.50.x). Microsoft.Data.Sqlite 10.0.7
pulls SQLitePCLRaw 2.1.11 which carries the older lib; pinning
the lib package directly forces the newer native binary
without a major bump on the managed wrapper. -->
<PackageReference Include="SQLitePCLRaw.lib.e_sqlite3" Version="3.50.3" /> <PackageReference Include="SQLitePCLRaw.lib.e_sqlite3" Version="3.50.3" />
<PackageReference Include="morelinq" Version="4.4.0" /> <PackageReference Include="morelinq" Version="4.4.0" />
<PackageReference Include="Pidgin" Version="[3.5.1, 4.0.0)" /> <PackageReference Include="Pidgin" Version="[3.5.1, 4.0.0)" />
@@ -23,7 +38,9 @@
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>
<!-- Test assembly needs access to internal helpers (not redistributed) --> <!-- Pure-function test suites in HellionChat.Tests need access to
the internal helper classes (StringUtil, UriPayload, Tokenizer
etc.). Test assembly does not get redistributed. -->
<InternalsVisibleTo Include="HellionChat.Tests" /> <InternalsVisibleTo Include="HellionChat.Tests" />
</ItemGroup> </ItemGroup>
@@ -42,7 +59,15 @@
</EmbeddedResource> </EmbeddedResource>
</ItemGroup> </ItemGroup>
<!-- Embedded resources: Hellion font (Exo 2, OFL-1.1) + manifest resource --> <!-- HellionChat — Hellion-specific resource bundle (HellionStrings.resx
+ HellionStrings.<lang>.resx) is picked up automatically by the SDK
default include. Designer.cs is hand-maintained, no auto-gen needed. -->
<!-- Bundled Hellion font (Exo 2, OFL-1.1). Embedded as a manifest
resource with a fixed LogicalName so FontManager can pull the
bytes back at runtime via AddFontFromMemory. The OFL license
text travels with it inside the assembly to satisfy the
"license must be distributed with the font" clause. -->
<ItemGroup> <ItemGroup>
<EmbeddedResource Include="Resources\HellionFont.ttf"> <EmbeddedResource Include="Resources\HellionFont.ttf">
<LogicalName>HellionFont.ttf</LogicalName> <LogicalName>HellionFont.ttf</LogicalName>
@@ -55,7 +80,14 @@
</EmbeddedResource> </EmbeddedResource>
</ItemGroup> </ItemGroup>
<!-- Plugin icon: copy images/* to output for Dalamud discovery --> <!-- Plugin icon. Copy images/* into the build output so Dalamud
finds the icon next to the DLL, and let the SDK default
DalamudPackager pipeline include the same path in the
release ZIP. Earlier we shipped a custom DalamudPackager
targets override that explicitly set HandleImages and
ImagesPath; that override conflicted with the SDK 15
default and the resulting manifest carried no IconUrl.
Removed in v0.5.2. -->
<ItemGroup> <ItemGroup>
<None Include="images\**"> <None Include="images\**">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+192 -163
View File
@@ -1,26 +1,77 @@
name: Hellion Chat name: Hellion Chat
author: Jon Kazama (Hellion Forge) author: JonKazama-Hellion
punchline: A Hellion Forge plugin — privacy-focused chat replacement for FFXIV, built for EU, US and JP data rules. punchline: Chat replacement with privacy controls aligned to EU, US and JP rules — based on Chat 2 (EUPL-1.2)
description: |- description: |-
Chat replacement for FINAL FANTASY XIV with privacy controls built around Hellion Chat is a privacy-focused chat replacement for FINAL FANTASY XIV
EU, US and JP data-protection rules. based on the Chat 2 codebase (EUPL-1.2). One feature is intentionally
removed (the optional webinterface) and a stack of privacy controls is
added on top. Tabs, channel filters, RGB colours, emotes, screenshot
mode, IPC integration and the chat replacement window itself work the
same. The webinterface is intentionally not part of Hellion Chat because
it serves a different use case from the smaller default footprint this
plugin is built around.
By default only your own conversations are stored. Public chat, NPC On top of that, Hellion Chat adds privacy and data-handling controls
dialogue and system messages stay out of the database unless you opt in. designed to align with the modern data protection rules that apply
Retention windows are configurable per channel, history can be wiped across the EU, the United States and Japan. By default only your own
retroactively, and everything can be exported on demand. conversations are stored; messages from strangers, NPCs and system
spam stay out of the database. Retention windows are configurable per
channel, history can be wiped retroactively, and stored data can be
exported on demand.
Key privacy and data-handling features:
Features:
- Channel whitelist with a Privacy-First default - Channel whitelist with a Privacy-First default
- Per-channel retention with a daily background sweep - Per-channel retention with a daily background sweep
- Retroactive cleanup (Ctrl+Shift confirm) - Retroactive cleanup with a Ctrl+Shift confirm
- Export to Markdown, JSON or CSV - Export to Markdown, JSON or CSV
- First-run wizard with three preset profiles - First-run wizard with three preset profiles (Privacy-First, Casual,
- Bilingual UI (EN/DE) with live language switching Full History)
- Own config and database — no shared state with other plugins - Bilingual UI (English and German) with live language switching
- Independent plugin state — own config file and database directory,
so Hellion Chat does not share state with upstream Chat 2
Based on Chat 2 by Infi and Anna (EUPL-1.2). v1.3.0 First plugin integration cycle. Honorific custom titles
Support: https://discord.gg/X9V7Kcv5gR are shown in the chat header above the message log, with auto-detect
and silent fallback when Honorific is not installed.
v1.4.0 — Critical Lifecycle Fixes. Plugin reload and shutdown
are cleaner: SQLite no longer leans on GC pressure to release
its file, worker threads are explicitly background, deferred
config saves no longer get lost mid-disable, and pre-v13 config
backups carry the user's custom theme opacity into the v14 schema
instead of falling back to the default.
v1.4.1 — Theme Engine Performance plus a tenth built-in.
HellionStyle.PushGlobal reads pre-computed ABGR values from a
per-theme cache instead of converting RGBA per slot per frame
(~13 % render-time recovery in typical scenes). Custom-theme
hot-reload survives transient file locks (editor mid-save
keeps the last-known-good snapshot). Synthwave Sunset joins
as the tenth built-in theme — Hot Magenta + Cyan on midnight
violet, 80s neon-grid vibes.
v1.4.2 — ChatLog Frame-Hot-Path. Three per-frame allocation
patterns gone from the chat-log render path: card-mode borders
hoist invariants out of the per-message loop, auto-tell tab
tint and icon get a per-tab cache, and the status bar gates
its tab aggregation behind the same one-second cache it uses
for the format strings.
v1.4.3 — Plugin-Load Async-Init plus Repo-Cutover. Plugin
migrated to Dalamud's IAsyncDalamudPlugin so the heavy work
(migrations, service allocations, window construction, hook
subscription) runs in LoadAsync without blocking Dalamud's
UI. Schema-gate replaces the v9 → v16 migration chain;
configs on schema v16+ load directly. Custom-repo URL moves
to gitea.hellion-forge.cloud, the GitHub repo stays as a
frozen v1.4.2 snapshot.
Based on Chat 2 by Infi and Anna, licensed under EUPL-1.2.
Modding & support: join the Hellion Forge Discord at
https://discord.gg/X9V7Kcv5gR — community for Hellion Chat and
other Hellion Online Media plugins/tools.
repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat repo_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat
accepts_feedback: true accepts_feedback: true
icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png icon_url: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/raw/branch/main/HellionChat/images/icon.png
@@ -35,158 +86,136 @@ tags:
- Replacement - Replacement
- Privacy - Privacy
changelog: |- changelog: |-
**v1.4.9 — Plugin-Load Render Polish (2026-05-15)** **Hellion Chat 1.4.3 — Plugin-Load Async-Init + Repo-Cutover (2026-05-08)**
Tenth sub-patch of the v1.4.x polish-sweep series. First-frame Plugin lifecycle migrated to Dalamud's `IAsyncDalamudPlugin`
render cost drops from ~127 ms median to ~76 ms median, API. The constructor now does only the bootstrap-essentials
comfortably under Dalamud's 100 ms HITCH warning threshold. (config load, language init, conflict detection); migrations,
service allocations, window construction and hook subscription
move to LoadAsync. Dalamud can keep its UI responsive while the
heavy work runs.
- First-frame defer: six non-essential rendering sections inside - IAsyncDalamudPlugin two-phase load with per-line CaptureFailure
ChatLogWindow skip their first Draw and run one frame later in DisposeAsync (mirrors LightlessSync's pattern); idempotency
(bottom status bar, channel-name SeString chunks, window bounds guard protects against reload races
check, v0.6.1 hint banner, autocomplete, input-preview - Schema-gate replaces the v9 → v16 migration chain. Configs
calculation). User-visible delay is ~17 ms at 60 fps, hidden on schema v16+ load directly; older configs trigger an
inside the post-reload font-atlas build window. "install v1.4.2 first" error so the historic migration
- Slash-command centralisation: /hellion, /hellionView, path stays intact
/hellionSeString and /hellionDebugger are registered in - AutoTranslate.PreloadCache moved off the load path. First
LoadAsync instead of inside the corresponding window use may have a sub-second hitch instead of every-load; the
constructors. The plugin-manager Open and configuration buttons upstream chose differently, we accept first-use latency
hang on the same path. - FontManager.BuildFonts is called sync at the start of
- Plugin-load profiling logs stay on at Information level LoadAsync; Dalamud rebuilds the font atlas on its own
(MessageStore connect/migrate, FilterAllTabs, auto-translate pipeline so the custom Hellion-Exo2 font appears with a
warmup) as a regression tripwire — a future load past 100 ms brief font-pop after load (matches ChatTwo's behaviour)
will show up in /xllog without a Debug filter. - Custom-repo URL moved to gitea.hellion-forge.cloud/
- ChatTwo IPC compatibility layer: HellionChat now mirrors JonKazama-Hellion/HellionChat. GitHub repo stays as a
ChatTwo's full IPC surface (GetChatInputState, frozen v1.4.2 snapshot; new releases ship from Gitea.
ChatInputStateChanged, Register, Unregister, Available, Existing testers need to update the custom-repo URL once
Invoke) under the ChatTwo.* namespace in addition to our - Plugin-load time in this release sits at ~3.7 s median
existing HellionChat.* provider gates. Third-party (5 reloads), comparable to v1.4.2. Async migration is
integrations that historically only subscribe to ChatTwo's foundational for v1.4.4 Lazy-Init optimisations rather
IPC — for example Artisan's and AllaganTools' context-menu than an immediate user-perceived win
hooks — keep working without requiring a code change on their
side. Conflict detection prevents ChatTwo from loading in Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
parallel with HellionChat, so there is no slot-collision risk
at runtime. Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
- Migration v17 stays (no schema bump).
**Hellion Chat 1.4.2 — ChatLog Frame-Hot-Path**
Third sub-patch of the v1.4.x Polish Sweep series. Per-frame
allocations from the chat-log render path eliminated.
- DrawMessages card-mode hoists theme/drawList/winLeft/winRight/
borderColorAbgr out of the per-message loop. About 500
redundant calls per frame at 100 visible messages, multiplied
by every pop-out window
- Auto-tell tab tint and icon use a per-tab cache. Hash
computation and string allocation only happen when the tell
target name or world drifts. AutoTellTabTint stays a pure
hash helper; cache lives in a thin TabTintCache wrapper
- Status bar gates its tab aggregation behind the same
one-second cache it already used for the format strings.
LINQ Sum and Count replaced with a single foreach pass
that runs on roughly 1% of frames
Realistic frame-time recovery: 2-5% in typical scenes, more
on pop-out-heavy setups because the card-border hoist scales
per window.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 1.4.1 — Theme Engine Performance**
Second sub-patch of the v1.4.x Polish Sweep series. Heap
pressure from the theme engine's per-frame render path
removed, plus a tenth built-in theme and hardening for
the custom-theme hot-reload.
- Theme records carry a pre-computed ABGR-packed cache
for every color slot; cache is filled when the theme
is registered and refreshed defensively on every
Switch()
- HellionStyle.PushGlobal reads ABGR values from the
cache instead of calling ColourUtil.RgbaToAbgr per
slot per frame; ~13 % render-time recovery measured
in typical scenes (plan estimate was 26 %, real
~1015 %)
- ThemeRegistry custom-theme reload distinguishes a
recoverable file lock (editor mid-save) from a
permanent IO failure; locked themes keep their
last-known-good snapshot and retry on the next
lookup instead of dropping out of the picker
- New built-in: Synthwave Sunset — Hot Magenta + Cyan
on midnight violet, 80s neon-grid vibes; tenth theme
in the picker
- Author credits refreshed: brand themes are credited
as "Hellion Forge"; Mint Grove and Forge Merchantman
now credited to Carla Beleandis as a community thanks
No schema bump, no user-visible behaviour change other
than smoother frames on GC-sensitive setups and one
additional colour option.
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
**Hellion Chat 1.4.0 — Critical Lifecycle Fixes**
First sub-patch of the v1.4.x Polish Sweep series. Seven
known lifecycle and race bugs eliminated before any
performance refactor sits on top.
- MessageStore disposal no longer triggers GC.Collect
globally; Pooling=false on the SQLite connection means
there's nothing left to clean up by hand
- PendingMessage and RetentionSweep worker threads are
explicitly marked IsBackground=true so the plugin domain
can unload during XIVLauncher reload without waiting
for them
- EmoteCache image and gif loaders moved from async-void
to async Task with a shared task tracker, draining
on Dispose so an in-flight load can no longer write
to a disposed EmoteImages entry
- DisposeAsync 10s timeout now warns loudly instead of
silently leaving the worker behind
- Plugin.Dispose flushes any pending DeferredSaveFrames
before tearing services down, so settings changes
made in the last few frames before disable are no
longer lost
- The v13→v14 config migration now reads the pre-v13
backup and carries HellionThemeWindowOpacity into the
new WindowOpacity field instead of falling back to
the default 0.85
Modding & support: join Hellion Forge — https://discord.gg/X9V7Kcv5gR
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2). Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
--- ---
**v1.4.8 — Hook-Layer and Polish Quick-Wins (2026-05-14)** Earlier history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases
Ninth sub-patch of the v1.4.x polish-sweep series. Hook-layer
cluster (DbViewer FTS5 full-text search, ad-block foundation
investigation) plus three polish quick-wins.
- DbViewer full-text search: optional FTS5 index across the full
chat history. Built asynchronously on first load after the
update with a progress toast. The local page-filter remains
available as the default mode. Queries match as exact phrases
-- multi-word terms must appear together in order; advanced
users can opt into raw FTS5 MATCH syntax by wrapping their own
double-quotes.
- Custom theme files now auto-reload when edited while the theme
is active -- no need to re-click the theme in the picker.
- Retention sweep no longer blocks the framework thread, removing
the ~194ms mini-hitch per sweep.
- Status bar renders correctly at Windows display scaling > 100%.
- Receive-suppressed-tells routing investigated this cycle and
postponed to v1.5.x: when other plugins suppress tells via
CheckMessageHandled, the FFXIV chat pipeline skips the
RaptureLogModule.AddMsgSourceEntry path so HellionChat's
ContentIdResolverHook does not fire and tell-partner
identification breaks. The fix belongs next to the planned
ad-block hook layer where the same patch surface comes up.
- Internal: messages.Id is declared BLOB but stored as TEXT
(Microsoft.Data.Sqlite Guid binding). FTS bulk insert and
LoadByGuids match the TEXT storage form on both sides.
Migration v17 stays (no schema bump).
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
**v1.4.7 — Backlog Cleanup and Mid-Features (2026-05-13)**
Eighth sub-patch of the v1.4.x polish-sweep series. First
user-visible feature bundle since v1.4.5 — pinned tell tabs that
survive relog, opt-in Honorific glow rendering, and a configurable
sidebar.
- TempTell Pin: right-click a TempTell tab in the sidebar to pin
it. Pinned tabs survive relog, keep their conversation history
(loaded on demand from the message store), and stay bound to
the same /tell partner. Hard cap of 5 pinned tabs in a pool
separate from the 15-tab auto-tell pool — total ceiling is 20
tabs. New 'Pinned' section in the sidebar with its own divider
header
- Honorific Glow outline now renders when the title carries a
Glow colour. Opt-in via Settings → Integrations → 'Render glow
outlines (Honorific)' (default off, dodges the per-frame
DrawList overhead on low-end hardware). Gradient (Color3 /
GradientColourSet / Wave / Pulse) is parsed but rendered
statically — a later cycle will port the full animation
- Sidebar width is now configurable in Theme & Layout (range
44160 px). Default stays icon-only; widen to fit section
headers like 'Active Tells (3)' without truncation
- Settings Save no longer pops the chat input back to /tell with
a pinned partner — Configuration.UpdateFrom now preserves the
runtime CurrentChannel across the persistent-tab merge, and
TabSwitched deep-clones the seeded channel instead of sharing
the previous tab's UsedChannel
- Util/ImGuiUtil.cs DrawArrows IconButton id now uses
(id + 1).ToString() instead of the operator-precedence quirk
id + 1.ToString() — generated IDs stay numerically stable
- Internal: IPluginLogProxy indirection over Dalamud's IPluginLog
routes all ~91 Plugin.Log call sites through a testable proxy.
MessageStore.Migrate0 can now run in xUnit without loading
Dalamud.dll, closing the gap F12.1 left in v1.4.6
- Internal: TempTab counter switched from an Interlocked cached
field to a derived Tabs.Count(predicate) — pin-state transitions
are cold-path and don't need lock-free reads
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
**v1.4.6 — Code Hygiene and Refactor (2026-05-12)**
Maintenance patch. No user-visible behaviour changes; tightens the
development feedback loop, fixes two upstream-inherited bugs, and
prepares the code for the v1.4.7 backlog cleanup.
- preflight.sh gains a csharpier reflow check and a markdownlint
pass so style drift and markdown violations are caught at the
pre-push gate
- FontManager fallback catches the full set of atlas-toolkit
throws (IO, InvalidOperation, ArgumentException) — a corrupt
font config no longer takes down the whole atlas build
- BrandingLinks and IntegrationLinks URLs validated on plugin
load — a typo in a future URL rotation now throws at startup
- Cherry-picked from ChatTwo upstream f35b7d3: Chat.SetChannel
no longer leaks the native Utf8String when the linkshell check
rejects the channel
- Cherry-picked from ChatTwo upstream f35b7d3: Tab.Clone now
deep-clones UsedChannel and TellTarget — PopOut and Temp tabs
no longer mutate each other's channel state
- Active-tab underline scales with DPI and rounds to physical
pixels for crisp rendering above 100% scaling
- IconButton width parameter no longer subtracts HUD-scaled
padding from a raw int (measured width passes through verbatim)
- Internal: HellionStyle ChildBgAlpha extracted to a testable
helper; Plugin.SaveConfig clones only the temp tabs;
SettingsOverview caches the draw-list per frame;
Dalamud.Utility.Util surface routed through an IPlatformUtil
indirection (MessageStore IsWine probe is now testable in
isolation)
- Built-in themes: Crystal Nocturne (sapphire and electric
magenta over obsidian, by CRYSTALLITE) replaces Moonlit Bloom.
Users with Moonlit Bloom selected fall back to Hellion Arctic
on first load
Based on Chat 2 1.35.3 (upstream Infiziert90/ChatTwo, EUPL-1.2).
---
Full history: https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases
+10 -12
View File
@@ -2,9 +2,14 @@ using System.Collections.Generic;
namespace HellionChat; namespace HellionChat;
// Shared input history for all ChatInputBars (main and pop-out windows). // Hellion Chat — v0.6.0 shared input history. Replaces the embedded
// Push deduplicates: existing entries are moved to the end when re-added. // ChatLogWindow.InputBacklog so that pop-out windows with their own
// TEST-MIRROR: ../../Hellion Build test/Util/InputHistoryServiceTests.cs // ChatInputBar can navigate the same Up/Down history as the main window.
// Index semantics are kept identical to the v0.5.x InputBacklog:
// index 0 = oldest entry
// index Count - 1 = newest entry
// Push performs move-to-newest deduplication: existing entries are
// removed before the new one is appended at the end.
public static class InputHistoryService public static class InputHistoryService
{ {
private const int MaxSize = 30; private const int MaxSize = 30;
@@ -21,7 +26,8 @@ public static class InputHistoryService
var trimmed = entry.Trim(); var trimmed = entry.Trim();
// Move-to-newest: remove existing entry before adding at the end // Move-to-newest: existing entries are removed before the append
// so the same line typed twice does not occupy two history slots.
for (var i = 0; i < _entries.Count; i++) for (var i = 0; i < _entries.Count; i++)
{ {
if (_entries[i] == trimmed) if (_entries[i] == trimmed)
@@ -42,12 +48,4 @@ public static class InputHistoryService
return null; return null;
return _entries[cursor]; return _entries[cursor];
} }
// Plugin reload doesn't reset static state automatically. Plugin.DisposeAsync
// calls this so the next load starts with an empty history instead of
// inheriting the previous session's entries.
public static void Reset()
{
_entries.Clear();
}
} }
+91 -31
View File
@@ -6,17 +6,25 @@ using Newtonsoft.Json;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// Newtonsoft.Json is used here for IPC compatibility with Honorific, which // We pull Newtonsoft.Json into this single file for IPC compatibility:
// serialises TitleData with it. It's a transitive Dalamud dependency — no // Honorific serialises its TitleData with Newtonsoft (see
// new NuGet entry needed. The rest of HellionChat uses System.Text.Json. // Honorific-master/IpcProvider.cs:9 and CustomTitle.cs:12). Using the
// same library guarantees identical handling of System.Numerics.Vector3?
// and the enum fields we ignore. Newtonsoft is a transitive dependency
// via Dalamud, so no new NuGet entry is needed. The rest of HellionChat
// keeps using System.Text.Json.
internal sealed class HonorificService : IDisposable internal sealed class HonorificService : IDisposable
{ {
private const string IpcNamespace = "Honorific"; private const string IpcNamespace = "Honorific";
// Major version of the Honorific IPC contract we're built against. // Major version of the Honorific IPC contract HellionChat is built against.
// Used both by the runtime compatibility check and by the settings tab when
// it tells the user which major version we expected, so the literal lives
// in exactly one place.
internal const uint ExpectedApiMajor = 3; internal const uint ExpectedApiMajor = 3;
// IPC gates — kept as fields so Dispose can unsubscribe the same instances. // IPC gates we subscribe to. Keep them as fields so Dispose can
// unsubscribe the same instances we subscribed in the constructor.
private readonly ICallGateSubscriber<(uint, uint)> _apiVersion; private readonly ICallGateSubscriber<(uint, uint)> _apiVersion;
private readonly ICallGateSubscriber<string> _getLocalCharacterTitle; private readonly ICallGateSubscriber<string> _getLocalCharacterTitle;
private readonly ICallGateSubscriber<string, object> _localCharacterTitleChanged; private readonly ICallGateSubscriber<string, object> _localCharacterTitleChanged;
@@ -27,7 +35,6 @@ internal sealed class HonorificService : IDisposable
private readonly IFramework _framework; private readonly IFramework _framework;
private bool _versionWarningLogged; private bool _versionWarningLogged;
// Thread: framework only — IPC delivery + ImGui render both run there.
public HonorificTitleData? CurrentTitle { get; private set; } public HonorificTitleData? CurrentTitle { get; private set; }
public bool IsAvailable { get; private set; } public bool IsAvailable { get; private set; }
public (uint Major, uint Minor)? DetectedApiVersion { get; private set; } public (uint Major, uint Minor)? DetectedApiVersion { get; private set; }
@@ -41,11 +48,23 @@ internal sealed class HonorificService : IDisposable
_framework = framework; _framework = framework;
_log = log; _log = log;
// Gate objects are cached per-name by Dalamud and safe to register // Dalamud caches gate objects per-name for the lifetime of the
// before Honorific loads — they just won't fire until it does. // plugin interface, so we can register subscribers even when
// Initial pull is scheduled on the framework thread because plugin // Honorific isn't loaded yet — the gate just won't fire. Calling
// constructors run on the loader thread, and Honorific's IPC handlers // InvokeFunc before Honorific is up will throw, which is why the
// read ObjectTable.LocalPlayer which throws off the framework thread. // initial pull below is wrapped in try-catch.
//
// Thread-context: plugin constructors run on Dalamud's plugin-loader
// thread, NOT the framework thread. Honorific's IPC handlers read
// ObjectTable.LocalPlayer (Honorific IpcProvider.cs:61), which throws
// "Not on main thread!" outside the framework thread. If Honorific is
// already loaded when HellionChat starts, a synchronous InvokeFunc
// here would surface that exception, the broad catch below would
// mark IsAvailable=false, and OnTitleChanged's `if (!IsAvailable)`
// gate would block every subsequent title update. We therefore
// schedule the initial pull onto the framework thread via
// IFramework.RunOnFrameworkThread so the IPC call sees the right
// thread context.
_apiVersion = pluginInterface.GetIpcSubscriber<(uint, uint)>($"{IpcNamespace}.ApiVersion"); _apiVersion = pluginInterface.GetIpcSubscriber<(uint, uint)>($"{IpcNamespace}.ApiVersion");
_getLocalCharacterTitle = pluginInterface.GetIpcSubscriber<string>( _getLocalCharacterTitle = pluginInterface.GetIpcSubscriber<string>(
$"{IpcNamespace}.GetLocalCharacterTitle" $"{IpcNamespace}.GetLocalCharacterTitle"
@@ -65,14 +84,16 @@ internal sealed class HonorificService : IDisposable
public void Dispose() public void Dispose()
{ {
// Wrap each unsubscribe — a missing gate must not block the others. // Honorific may already be gone by the time we dispose. Wrap each
// Leaking a subscription keeps this service alive across plugin reloads. // unsubscribe so a missing gate doesn't prevent the others from
// unsubscribing — leaking even one subscription leaves a callback
// alive that captures `this`, which keeps the whole service alive
// and breaks plugin reload.
TryUnsubscribe(() => _localCharacterTitleChanged.Unsubscribe(OnTitleChanged)); TryUnsubscribe(() => _localCharacterTitleChanged.Unsubscribe(OnTitleChanged));
TryUnsubscribe(() => _ready.Unsubscribe(OnReady)); TryUnsubscribe(() => _ready.Unsubscribe(OnReady));
TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing)); TryUnsubscribe(() => _disposing.Unsubscribe(OnDisposing));
} }
// Thread: framework (scheduled from ctor and OnReady).
private void TryInitialPull() private void TryInitialPull()
{ {
try try
@@ -98,47 +119,68 @@ internal sealed class HonorificService : IDisposable
IsAvailable = true; IsAvailable = true;
_versionWarningLogged = false; _versionWarningLogged = false;
// Pull the current title once at startup; from here on we rely
// on LocalCharacterTitleChanged events.
var json = _getLocalCharacterTitle.InvokeFunc(); var json = _getLocalCharacterTitle.InvokeFunc();
CurrentTitle = ParseTitleJson(json); CurrentTitle = ParseTitleJson(json);
} }
catch (Exception ex) catch (Exception ex)
{ {
// Honorific not installed or not yet initialised — Ready will retry. // Honorific isn't installed or hasn't initialised yet. The Ready
// event will give us a second chance later. Log at Debug so
// users without Honorific don't see noise on every reload.
_log.Debug(ex, "Honorific not available at HellionChat startup; awaiting Ready."); _log.Debug(ex, "Honorific not available at HellionChat startup; awaiting Ready.");
IsAvailable = false; IsAvailable = false;
CurrentTitle = null; CurrentTitle = null;
} }
} }
// Thread: framework (Dalamud IPC delivery contract). // Honorific fires LocalCharacterTitleChanged through its nameplate hook
// (Honorific-master/Plugin.cs:665), which means we get title updates on
// character switches automatically as soon as the new character is
// rendered. While the user is in the character-select menu, HellionChat's
// window is hidden by default via HideWhenNotLoggedIn (Configuration.cs:152),
// so the stale-title window between logout and login isn't user-visible.
private void OnTitleChanged(string json) private void OnTitleChanged(string json)
{ {
// Skip updates on version mismatch; subscription stays live for reload. // Don't update cached state when we've already decided we can't trust
// Honorific (e.g. version mismatch). Subscription stays live in case a
// compatible Honorific reloads, in which case Ready triggers TryInitialPull
// and sets IsAvailable back to true.
if (!IsAvailable) if (!IsAvailable)
return; return;
CurrentTitle = ParseTitleJson(json); CurrentTitle = ParseTitleJson(json);
} }
// Thread: any (Honorific dispatches NotifyReady from its own thread).
private void OnReady() private void OnReady()
{ {
// Honorific loaded after HellionChat; redo the version check and
// initial pull. Idempotent on purpose — Honorific can fire Ready
// more than once across reloads.
//
// Honorific's NotifyReady may dispatch from any thread, and
// TryInitialPull eventually calls IPC handlers that read
// ObjectTable.LocalPlayer — same "Not on main thread!" hazard as
// the constructor path. Schedule onto the framework thread.
_framework.RunOnFrameworkThread(TryInitialPull); _framework.RunOnFrameworkThread(TryInitialPull);
} }
// Thread: framework (IPC delivery contract); idempotent — Disposing fires once.
private void OnDisposing() private void OnDisposing()
{ {
// Honorific unloading — clear cached state so the header hides next frame. // Honorific is unloading. Drop our cached state so the header
// Subscriptions stay registered in case Honorific reloads. // hides on the next frame; subscriptions stay registered because
// CurrentTitle is already nulled by OnTitleChanged before this fires, // the gates may come back later (Honorific reload).
// re-clearing here is belt-and-braces. //
// Race-note: Honorific's NotifyDisposing calls ChangedLocalCharacterTitle(null)
// BEFORE SendMessage on the Disposing gate (IpcProvider.cs:109-111),
// so OnTitleChanged is expected to fire first and already null out
// CurrentTitle. We re-clear here as belt-and-braces; should the
// ordering ever flip, ShouldRenderSlot would still gate on IsAvailable.
CurrentTitle = null; CurrentTitle = null;
IsAvailable = false; IsAvailable = false;
DetectedApiVersion = null; DetectedApiVersion = null;
} }
// Thread: framework (called from Dispose, which runs on the framework
// cleanup block in Plugin.DisposeAsync).
private void TryUnsubscribe(Action unsubscribe) private void TryUnsubscribe(Action unsubscribe)
{ {
try try
@@ -147,15 +189,33 @@ internal sealed class HonorificService : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// Warning not Debug — a silent unsubscribe failure leaks a live _log.Debug(ex, "Honorific unsubscribe failed (likely already gone).");
// subscription across plugin reloads.
_log.Warning(
ex,
"Honorific unsubscribe failed (likely API break or gate already gone)."
);
} }
} }
// Threading note: Dalamud fires IPC events on the framework thread and
// ImGui renders on the framework thread, so OnTitleChanged and the
// render path that reads CurrentTitle never race — OnTitleChanged is
// safe to keep direct (no RunOnFrameworkThread wrap needed) because
// LocalCharacterTitleChanged delivery is framework-thread by Dalamud
// contract. If a future change moves either side onto a worker thread,
// switch to volatile/Interlocked for the CurrentTitle field.
//
// The constructor's initial pull and OnReady, on the other hand, are
// explicitly scheduled via IFramework.RunOnFrameworkThread because
// they run outside that contract: the constructor executes on the
// plugin-loader thread, and Honorific's NotifyReady can dispatch from
// any thread. Both call paths eventually invoke IPC handlers that read
// ObjectTable.LocalPlayer, which throws "Not on main thread!" off the
// framework thread — see the constructor comment block for context.
//
// Divergence from ChatTwo/Ipc/ExtraChat.cs: that file uses `volatile`
// on its state fields out of caution. We don't, because the framework-
// thread delivery is the documented Dalamud contract. If the two files
// ever need to share a threading audit, this is the place to revisit.
// --- Pure-logic helpers below; tested via HellionChat.Tests/Integrations. ---
internal static HonorificTitleData? ParseTitleJson(string json) internal static HonorificTitleData? ParseTitleJson(string json)
{ {
if (string.IsNullOrEmpty(json)) if (string.IsNullOrEmpty(json))
+8 -13
View File
@@ -2,21 +2,16 @@ using System.Numerics;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// Local DTO mirroring Honorific's TitleData — no hard reference to Honorific.dll // Local DTO mirroring Honorific's TitleData shape. We replicate the structure
// so HellionChat loads cleanly when Honorific is absent. // instead of referencing Honorific.dll because a hard build-time dependency
// // would couple the two assemblies and break HellionChat at load time when
// v1.4.7: render Glow only. Gradient (Color3 / GradientColourSet / Style) is // Honorific is missing. Glow, Color3, GradientColourSet and GradientAnimationStyle
// parsed and stashed so a future cycle can render it without re-shaping the // are intentionally omitted — Cycle 1 renders text in the primary Color only;
// JSON roundtrip — see vault anchor "Honorific Full Gradient Port" (would // the "Honorific Full Fidelity" backlog item adds them later as a pure
// need GradientSystem.cs + the hardcoded Pride-palette list ported, or an // extension that won't break this DTO's existing consumers.
// upstream IPC PR exposing the resolved frame colour).
internal sealed record HonorificTitleData( internal sealed record HonorificTitleData(
string? Title, string? Title,
bool IsPrefix, bool IsPrefix,
bool IsOriginal, bool IsOriginal,
Vector3? Color, Vector3? Color
Vector3? Glow,
Vector3? Color3,
int? GradientColourSet,
string? GradientAnimationStyle
); );
+5 -13
View File
@@ -1,20 +1,12 @@
using System.Runtime.CompilerServices;
using HellionChat.Util;
namespace HellionChat.Integrations; namespace HellionChat.Integrations;
// Third-party plugin URLs — separate from BrandingLinks (Hellion-owned URLs). // External URLs for the third-party plugins HellionChat integrates with.
// Kept separate from BrandingLinks (which is for Hellion-owned URLs) so
// future cycles can extend this file with maintainer attribution links
// for Moodles, NotificationMaster, ExtraChat, etc. without polluting the
// brand-links class.
internal static class IntegrationLinks internal static class IntegrationLinks
{ {
public const string HonorificRepo = "https://github.com/Caraxi/Honorific"; public const string HonorificRepo = "https://github.com/Caraxi/Honorific";
public const string HonorificAuthor = "https://github.com/Caraxi"; public const string HonorificAuthor = "https://github.com/Caraxi";
// See BrandingLinks.ValidateUrls for the CA2255 rationale.
#pragma warning disable CA2255
[ModuleInitializer]
#pragma warning restore CA2255
internal static void ValidateUrls()
{
UrlValidation.ValidateAll(nameof(IntegrationLinks), HonorificRepo, HonorificAuthor);
}
} }
+21 -13
View File
@@ -26,9 +26,10 @@ public sealed class ExtraChat : IDisposable
internal (string, uint)? ChannelOverride { get; set; } internal (string, uint)? ChannelOverride { get; set; }
// volatile: IPC callbacks fire on a Dalamud thread while ImGui reads these. // Volatile reference: IPC callbacks (OnChannelCommandColours/OnChannelNames) fire on a
// Reference assignment is atomic on x64, but the barrier ensures visibility // Dalamud-dispatcher thread while the ImGui thread reads the IReadOnlyDictionary projections.
// across threads (especially Mono/Wine). See AUDIT-2026-05-05 [SEC-01]. // Reference assignment is atomic on x64, but the JIT (especially Mono on Wine/Linux) needs
// the volatile barrier to guarantee visibility across threads. See AUDIT-2026-05-05 [SEC-01].
private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new(); private volatile Dictionary<string, uint> ChannelCommandColoursInternal = new();
internal IReadOnlyDictionary<string, uint> ChannelCommandColours => internal IReadOnlyDictionary<string, uint> ChannelCommandColours =>
ChannelCommandColoursInternal; ChannelCommandColoursInternal;
@@ -53,7 +54,6 @@ public sealed class ExtraChat : IDisposable
OverrideChannelGate.Subscribe(OnOverrideChannel); OverrideChannelGate.Subscribe(OnOverrideChannel);
ChannelCommandColoursGate.Subscribe(OnChannelCommandColours); ChannelCommandColoursGate.Subscribe(OnChannelCommandColours);
ChannelNamesGate.Subscribe(OnChannelNames); ChannelNamesGate.Subscribe(OnChannelNames);
try try
{ {
ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!); ChannelCommandColoursInternal = ChannelCommandColoursGate.InvokeFunc(null!);
@@ -61,11 +61,8 @@ public sealed class ExtraChat : IDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
// ExtraChat is optional; IPC failure is normal when the plugin isn't loaded. // ExtraChat is optional; missing IPC peer is normal when the plugin isn't loaded.
Plugin.LogProxy.Verbose( Plugin.Log.Verbose(ex, "ExtraChat IPC initial state query failed (peer not loaded?)");
ex,
"ExtraChat IPC initial state query failed (peer not loaded?)"
);
} }
} }
@@ -78,11 +75,22 @@ public sealed class ExtraChat : IDisposable
private void OnOverrideChannel(OverrideInfo info) private void OnOverrideChannel(OverrideInfo info)
{ {
ChannelOverride = info.Channel == null ? null : (info.Channel, info.Rgba); if (info.Channel == null)
{
ChannelOverride = null;
return;
} }
private void OnChannelCommandColours(Dictionary<string, uint> obj) => ChannelOverride = (info.Channel, info.Rgba);
ChannelCommandColoursInternal = obj; }
private void OnChannelNames(Dictionary<Guid, string> obj) => ChannelNamesInternal = obj; private void OnChannelCommandColours(Dictionary<string, uint> obj)
{
ChannelCommandColoursInternal = obj;
}
private void OnChannelNames(Dictionary<Guid, string> obj)
{
ChannelNamesInternal = obj;
}
} }
-23
View File
@@ -19,17 +19,6 @@ internal sealed class TypingIpc : IDisposable
private ICallGateProvider<ChatInputState> StateQueryGate { get; } private ICallGateProvider<ChatInputState> StateQueryGate { get; }
private ICallGateProvider<ChatInputState, object?> StateChangedGate { get; } private ICallGateProvider<ChatInputState, object?> StateChangedGate { get; }
// v1.4.9 R4: ChatTwo IPC compatibility mirror. Some third-party plugins
// have a no-fork policy and subscribe only to ChatTwo.*-prefixed IPC
// gates. HellionChat replaces ChatTwo (conflict detection prevents
// parallel loading), so mirroring the ChatTwo provider slots lets those
// plugins keep working without code changes on their side. The tuple
// shape is textually identical to ChatTwo's IPC surface (same member
// order, same underlying types — ChatType is `ushort` in both repos)
// so Dalamud's IPC marshalling matches across plugin boundaries.
private ICallGateProvider<ChatInputState> ChatTwoStateQueryGate { get; }
private ICallGateProvider<ChatInputState, object?> ChatTwoStateChangedGate { get; }
private ChatInputState LastState; private ChatInputState LastState;
private bool HasState; private bool HasState;
@@ -44,16 +33,7 @@ internal sealed class TypingIpc : IDisposable
"HellionChat.ChatInputStateChanged" "HellionChat.ChatInputStateChanged"
); );
// v1.4.9 R4: ChatTwo-prefixed compatibility slots (see class-level comment).
ChatTwoStateQueryGate = Plugin.Interface.GetIpcProvider<ChatInputState>(
"ChatTwo.GetChatInputState"
);
ChatTwoStateChangedGate = Plugin.Interface.GetIpcProvider<ChatInputState, object?>(
"ChatTwo.ChatInputStateChanged"
);
StateQueryGate.RegisterFunc(GetState); StateQueryGate.RegisterFunc(GetState);
ChatTwoStateQueryGate.RegisterFunc(GetState);
} }
private ChatInputState BuildState() private ChatInputState BuildState()
@@ -87,13 +67,10 @@ internal sealed class TypingIpc : IDisposable
HasState = true; HasState = true;
LastState = state; LastState = state;
StateChangedGate.SendMessage(state); StateChangedGate.SendMessage(state);
// v1.4.9 R4: mirror on ChatTwo-prefixed slot for no-fork-policy plugins.
ChatTwoStateChangedGate.SendMessage(state);
} }
public void Dispose() public void Dispose()
{ {
StateQueryGate.UnregisterFunc(); StateQueryGate.UnregisterFunc();
ChatTwoStateQueryGate.UnregisterFunc();
} }
} }
-49
View File
@@ -19,26 +19,6 @@ internal sealed class IpcManager : IDisposable
object? object?
> InvokeGate { get; } > InvokeGate { get; }
// v1.4.9 R4: ChatTwo IPC compatibility mirror. Third-party plugins with
// a no-fork policy (e.g. Artisan, AllaganTools) only subscribe to the
// ChatTwo.*-prefixed context-menu integration gates. Mirroring all four
// provider slots under the ChatTwo namespace lets those plugins keep
// working without code changes on their side. Conflict detection
// prevents ChatTwo and HellionChat from loading in parallel, so no slot
// collision risk.
private ICallGateProvider<string> ChatTwoRegisterGate { get; }
private ICallGateProvider<string, object?> ChatTwoUnregisterGate { get; }
private ICallGateProvider<object?> ChatTwoAvailableGate { get; }
private ICallGateProvider<
string,
PlayerPayload?,
ulong,
Payload?,
SeString?,
SeString?,
object?
> ChatTwoInvokeGate { get; }
internal List<string> Registered { get; } = []; internal List<string> Registered { get; } = [];
public IpcManager() public IpcManager()
@@ -61,32 +41,7 @@ internal sealed class IpcManager : IDisposable
object? object?
>("HellionChat.Invoke"); >("HellionChat.Invoke");
// v1.4.9 R4: ChatTwo-prefixed mirrors of the four context-menu slots
// above. Share the same Register/Unregister backing methods so a
// plugin that subscribes via either namespace lands in the same
// Registered list. SendMessage on Invoke fans out to both gates.
ChatTwoRegisterGate = Plugin.Interface.GetIpcProvider<string>("ChatTwo.Register");
ChatTwoRegisterGate.RegisterFunc(Register);
ChatTwoAvailableGate = Plugin.Interface.GetIpcProvider<object?>("ChatTwo.Available");
ChatTwoUnregisterGate = Plugin.Interface.GetIpcProvider<string, object?>(
"ChatTwo.Unregister"
);
ChatTwoUnregisterGate.RegisterAction(Unregister);
ChatTwoInvokeGate = Plugin.Interface.GetIpcProvider<
string,
PlayerPayload?,
ulong,
Payload?,
SeString?,
SeString?,
object?
>("ChatTwo.Invoke");
AvailableGate.SendMessage(); AvailableGate.SendMessage();
ChatTwoAvailableGate.SendMessage();
} }
internal void Invoke( internal void Invoke(
@@ -99,8 +54,6 @@ internal sealed class IpcManager : IDisposable
) )
{ {
InvokeGate.SendMessage(id, sender, contentId, payload, senderString, content); InvokeGate.SendMessage(id, sender, contentId, payload, senderString, content);
// v1.4.9 R4: fan out the same event to plugins listening on ChatTwo.Invoke.
ChatTwoInvokeGate.SendMessage(id, sender, contentId, payload, senderString, content);
} }
private string Register() private string Register()
@@ -119,8 +72,6 @@ internal sealed class IpcManager : IDisposable
{ {
UnregisterGate.UnregisterAction(); UnregisterGate.UnregisterAction();
RegisterGate.UnregisterFunc(); RegisterGate.UnregisterFunc();
ChatTwoUnregisterGate.UnregisterAction();
ChatTwoRegisterGate.UnregisterFunc();
Registered.Clear(); Registered.Clear();
} }
} }
+4 -4
View File
@@ -153,8 +153,8 @@ public partial class Message
} }
catch (ArgumentException ex) catch (ArgumentException ex)
{ {
Plugin.LogProxy.Error(ex, "Failed to parse extra chat channel GUID"); Plugin.Log.Error(ex, "Failed to parse extra chat channel GUID");
Plugin.LogProxy.Error($"Byte Array: ${string.Join(", ", data[4..^1])}"); Plugin.Log.Error($"Byte Array: ${string.Join(", ", data[4..^1])}");
return Guid.Empty; return Guid.Empty;
} }
} }
@@ -251,7 +251,7 @@ public partial class Message
AddChunkWithMessage( AddChunkWithMessage(
text.NewWithStyle(chunk.Source, chunk.Link, token.Value) text.NewWithStyle(chunk.Source, chunk.Link, token.Value)
); );
Plugin.LogProxy.Debug( Plugin.Log.Debug(
$"Invalid URL accepted by Regex but failed URI parsing: '{token.Value}'" $"Invalid URL accepted by Regex but failed URI parsing: '{token.Value}'"
); );
} }
@@ -416,7 +416,7 @@ public partial class Message
catch (Exception) catch (Exception)
{ {
AddChunkWithMessage(text.NewWithStyle(chunk.Source, chunk.Link, split)); AddChunkWithMessage(text.NewWithStyle(chunk.Source, chunk.Link, split));
Plugin.LogProxy.Debug($"Failed to parse the text param: '{split}'"); Plugin.Log.Debug($"Failed to parse the text param: '{split}'");
} }
} }
} }
+52 -23
View File
@@ -27,7 +27,16 @@ internal class MessageManager : IAsyncDisposable
private Dictionary<ChatType, NameFormatting> Formats { get; } = []; private Dictionary<ChatType, NameFormatting> Formats { get; } = [];
private ulong LastContentId { get; set; } private ulong LastContentId { get; set; }
// PendingSync (main thread) → PendingAsync (worker thread); LinkedList for O(1) Last access // Messages go into the PendingSync queue first, which will be consumed one
// at a time in the main thread. This is to delay the async processing until
// after we've received the content ID from the ContentIdResolver hook.
//
// After that, the message is enqueued in the PendingAsync queue, which will
// be consumed in a separate thread and perform more processing (emotes,
// URLs) as well as inserting the message into the database.
// LinkedList instead of Queue: ContentIdResolver hits PendingSync.Last
// every hook call. Queue<T>.Last() is the LINQ extension and walks the
// whole queue (O(n)); LinkedList<T>.Last is an O(1) node reference.
private LinkedList<PendingMessage> PendingSync { get; } = []; private LinkedList<PendingMessage> PendingSync { get; } = [];
private ConcurrentQueue<PendingMessage> PendingAsync { get; } = []; private ConcurrentQueue<PendingMessage> PendingAsync { get; } = [];
private readonly Thread PendingMessageThread; private readonly Thread PendingMessageThread;
@@ -44,16 +53,21 @@ internal class MessageManager : IAsyncDisposable
} }
} }
// Auto-Tell-Tabs hook: fires after a message is processed and stored, allowing // Hellion Chat — Auto-Tell-Tabs hook. Fires after a fully processed
// AutoTellTabsService to spawn or refresh temp tabs without coupling. // message has been routed to all matching persistent tabs and stored
// in the database. The AutoTellTabsService subscribes to spawn or
// refresh temp tabs without having to wedge itself into ProcessMessage
// directly.
public event Action<Message>? MessageProcessed; public event Action<Message>? MessageProcessed;
internal unsafe MessageManager(Plugin plugin) internal unsafe MessageManager(Plugin plugin)
{ {
Plugin = plugin; Plugin = plugin;
Store = new MessageStore(DatabasePath(), Plugin.PlatformUtil, Plugin.LogProxy); Store = new MessageStore(DatabasePath());
// IsBackground so a stuck worker never blocks plugin unload.
// Cooperative cancel via PendingThreadCancellationToken first, background flag is the safety net.
PendingMessageThread = new Thread(() => PendingMessageThread = new Thread(() =>
ProcessPendingMessages(PendingThreadCancellationToken.Token) ProcessPendingMessages(PendingThreadCancellationToken.Token)
) )
@@ -91,11 +105,14 @@ internal class MessageManager : IAsyncDisposable
await Task.Delay(100); await Task.Delay(100);
if (PendingMessageThread.IsAlive) if (PendingMessageThread.IsAlive)
Plugin.LogProxy.Warning( Plugin.Log.Warning(
"PendingMessageThread did not observe cancellation within 10s. " "PendingMessageThread did not observe cancellation within 10s. "
+ "Worker remains on background thread; next plugin reload releases it." + "Worker remains on a background thread; next plugin reload releases it. "
+ "If this recurs, file a bug with /xllog after the previous reload."
); );
// CTS owns an unmanaged WaitHandle; dispose even if the worker is
// alive — it checks IsCancellationRequested via the linked token.
PendingThreadCancellationToken.Dispose(); PendingThreadCancellationToken.Dispose();
Store.Dispose(); Store.Dispose();
@@ -137,7 +154,7 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error processing pending message"); Plugin.Log.Error(ex, "Error processing pending message");
} }
} }
else else
@@ -149,7 +166,12 @@ internal class MessageManager : IAsyncDisposable
internal void ClearAllTabs() internal void ClearAllTabs()
{ {
// TempTabs are session-only (not persisted); exclude them to preserve Tell history // Hellion Chat — TempTabs haben keine DB-Persistenz (session-only,
// direkt vom AutoTellTabsService befüllt). Ein Clear+Refilter würde
// sie leer hinterlassen weil FilterAllTabs nichts aus der DB
// findet — Tells sind oft durch Privacy-Filter blockiert oder
// schlicht session-flüchtig. TempTabs vom Clear-Pfad ausschließen
// damit Settings-Save den Tell-Verlauf nicht zerstört.
foreach (var tab in Plugin.Config.Tabs.Where(t => !t.IsTempTab)) foreach (var tab in Plugin.Config.Tabs.Where(t => !t.IsTempTab))
tab.Clear(); tab.Clear();
} }
@@ -162,7 +184,12 @@ internal class MessageManager : IAsyncDisposable
using var messages = Store.GetMostRecentMessages(CurrentContentId, since); using var messages = Store.GetMostRecentMessages(CurrentContentId, since);
// TempTabs are excluded; they maintain live state from AutoTellTabsService // We store the pending messages to be added to the chat log in a
// temporary list, and apply them all at once after filtering.
// TempTabs werden ausgeschlossen — sie bleiben live-state aus dem
// AutoTellTabsService, ein DB-Refilter würde sie nur partial
// wiederherstellen falls Tells in DB liegen, oder leer lassen wenn
// Privacy-Filter sie blockiert hat.
var pendingTabs = Plugin var pendingTabs = Plugin
.Config.Tabs.Where(t => !t.IsTempTab) .Config.Tabs.Where(t => !t.IsTempTab)
.Select(tab => (tab, new List<Message>())) .Select(tab => (tab, new List<Message>()))
@@ -171,7 +198,7 @@ internal class MessageManager : IAsyncDisposable
foreach (var (_, pendingMessages) in pendingTabs.Where(ptab => ptab.Item1.Matches(message))) foreach (var (_, pendingMessages) in pendingTabs.Where(ptab => ptab.Item1.Matches(message)))
pendingMessages.Add(message); pendingMessages.Add(message);
// Apply messages to chat log all at once. // Apply the messages to the chat log in one go.
foreach (var (tab, pendingMessages) in pendingTabs) foreach (var (tab, pendingMessages) in pendingTabs)
tab.Messages.AddSortPrune(pendingMessages, MessageDisplayLimit); tab.Messages.AddSortPrune(pendingMessages, MessageDisplayLimit);
@@ -180,14 +207,13 @@ internal class MessageManager : IAsyncDisposable
WrapperUtil.AddNotification(Language.LoadMessages_Error, NotificationType.Error); WrapperUtil.AddNotification(Language.LoadMessages_Error, NotificationType.Error);
// Mark failed messages as deleted to prevent retry attempts // Mark the failed messages as deleted so we don't try to load them
// again.
var failedIds = messages.FailedMessageIds(); var failedIds = messages.FailedMessageIds();
Plugin.LogProxy.Info( Plugin.Log.Info($"Marking {failedIds.Count} messages as deleted due to parse failures");
$"Marking {failedIds.Count} messages as deleted due to parse failures"
);
foreach (var msgId in messages.FailedMessageIds()) foreach (var msgId in messages.FailedMessageIds())
{ {
Plugin.LogProxy.Debug($"Marking message '{msgId}' as deleted due to parse failure"); Plugin.Log.Debug($"Marking message '{msgId}' as deleted due to parse failure");
Store.DeleteMessage(msgId); Store.DeleteMessage(msgId);
} }
} }
@@ -203,13 +229,10 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in FilterAllTabs"); Plugin.Log.Error(ex, "Error in FilterAllTabs");
} }
// v1.4.9 R3 profiling: Information so the xllog tail surfaces this Plugin.Log.Debug($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms");
// without a Debug filter. Belt-and-suspenders for future plugin-load
// regressions; remains in place after Sub-Task 3.4 Befund.
Plugin.LogProxy.Information($"FilterAllTabs took {stopwatch.ElapsedMilliseconds}ms");
}); });
} }
@@ -233,10 +256,16 @@ internal class MessageManager : IAsyncDisposable
// Update colour codes. // Update colour codes.
GlobalParametersCache.Refresh(); GlobalParametersCache.Refresh();
// Delay to next tick to get content ID from ContentIdResolver hook // We delay messages to be handed off to the async processing thread
// in the next tick, otherwise we can't get the content ID from the hook
// below.
PendingSync.AddLast(pendingMessage); PendingSync.AddLast(pendingMessage);
} }
// This hook is called immediately after receiving a message with the
// message's content ID. If multiple messages are received in the same tick,
// this will be called for each message immediately after ChatMessage is
// called for each message.
private unsafe void ContentIdResolver( private unsafe void ContentIdResolver(
RaptureLogModule* agent, RaptureLogModule* agent,
ulong contentId, ulong contentId,
@@ -264,7 +293,7 @@ internal class MessageManager : IAsyncDisposable
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error in ContentIdResolver"); Plugin.Log.Error(ex, "Error in ContentIdResolver");
} }
} }
@@ -379,7 +408,7 @@ internal class MessageManager : IAsyncDisposable
var after = formats var after = formats
.GetRange(firstStringParam + 1, secondStringParam - firstStringParam) .GetRange(firstStringParam + 1, secondStringParam - firstStringParam)
.Where(payload => payload.Type == ReadOnlySePayloadType.Text) .Where(payload => payload.Type == ReadOnlySePayloadType.Text)
.Select(text => Encoding.UTF8.GetString(text.Body.Span)); .Select(text => Encoding.UTF8.GetString(text.Body.Span)); // Can't use `ToString()` as it defaults to macro
var nameFormatting = NameFormatting.Of(string.Join("", before), string.Join("", after)); var nameFormatting = NameFormatting.Of(string.Join("", before), string.Join("", after));
Formats[type] = nameFormatting; Formats[type] = nameFormatting;
File diff suppressed because it is too large Load Diff
+3 -3
View File
@@ -131,7 +131,7 @@ public sealed class PayloadHandler
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error executing integration"); Plugin.Log.Error(ex, "Error executing integration");
} }
} }
@@ -535,7 +535,7 @@ public sealed class PayloadHandler
) )
) )
{ {
Plugin.LogProxy.Warning("Could not find DalamudLinkHandlers"); Plugin.Log.Warning("Could not find DalamudLinkHandlers");
return; return;
} }
@@ -546,7 +546,7 @@ public sealed class PayloadHandler
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error executing DalamudLinkPayload handler"); Plugin.Log.Error(ex, "Error executing DalamudLinkPayload handler");
} }
} }
+181 -337
View File
@@ -14,7 +14,6 @@ using HellionChat.Ipc;
using HellionChat.Resources; using HellionChat.Resources;
using HellionChat.Ui; using HellionChat.Ui;
using HellionChat.Util; using HellionChat.Util;
using Microsoft.Data.Sqlite;
namespace HellionChat; namespace HellionChat;
@@ -91,8 +90,10 @@ public sealed class Plugin : IAsyncDalamudPlugin
public readonly WindowSystem WindowSystem = new(PluginName); public readonly WindowSystem WindowSystem = new(PluginName);
// Phase-2 services are constructed in LoadAsync; null! shape is kept // v1.4.3: properties moved from { get; } to { get; private set; } = null!;
// consistent across all properties for clarity. // because LoadAsync now owns construction of the Phase-2 services.
// Phase-1 services use the same shape for consistency, even though
// they're still allocated in the ctor.
public SettingsWindow SettingsWindow { get; private set; } = null!; public SettingsWindow SettingsWindow { get; private set; } = null!;
public ChatLogWindow ChatLogWindow { get; private set; } = null!; public ChatLogWindow ChatLogWindow { get; private set; } = null!;
public DbViewer DbViewer { get; private set; } = null!; public DbViewer DbViewer { get; private set; } = null!;
@@ -114,41 +115,27 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal Ui.StatusBar StatusBar { get; private set; } = null!; internal Ui.StatusBar StatusBar { get; private set; } = null!;
internal Integrations.HonorificService HonorificService { get; private set; } = null!; internal Integrations.HonorificService HonorificService { get; private set; } = null!;
// Platform indirection over Dalamud.Utility.Util. Wired in Phase-1 ctor so // (B3) Lightless idempotency guard — Dalamud may fire DisposeAsync twice
// any service allocated in LoadAsync can read Plugin.PlatformUtil. // in a reload race; second call short-circuits.
internal static IPlatformUtil PlatformUtil { get; private set; } = null!;
// Log indirection over Dalamud's IPluginLog. Same rationale as PlatformUtil:
// call-sites read through LogProxy so MessageStore can be tested in
// isolation. Wired immediately after Dalamud injects Log.
internal static IPluginLogProxy LogProxy { get; private set; } = null!;
// Idempotency guard — Dalamud may fire DisposeAsync twice in a reload race.
private int _disposeStarted; private int _disposeStarted;
// Set in the first DisposeAsync statement so async callbacks scheduled
// via Framework.RunOnTick (v1.4.8 B3 retention sweep) can early-bail
// before they touch state that has already been torn down. Volatile
// because the tick reads it from a different thread than the writer.
private volatile bool _isDisposing;
internal int DeferredSaveFrames = -1; internal int DeferredSaveFrames = -1;
// Cancels the v1.4.8 FTS5 bulk-insert worker on plugin teardown. The // Serialises retention sweeps. The 24h auto-sweep on plugin load and
// worker runs off the framework thread on its own SqliteConnection, so a // the manual button in the Privacy tab both run on background threads;
// Dispose mid-rebuild must signal cancellation before MessageManager // without this gate, hitting the manual button moments after a fresh
// tears down (the worker logs "rebuild failed" via Log on error paths). // plugin start would launch two sweeps in parallel and the second one
private CancellationTokenSource? _ftsRebuildCts; // would just re-do work the first one already finished. The lock guards
// the flag — the flag check itself bails before we touch the database.
// Serialises retention sweeps so a manual trigger and the 24h auto-sweep // Volatile because the ImGui thread reads the flag outside the lock to
// can't run in parallel. Volatile because the ImGui thread reads it outside // gate the manual button; without it the JIT may cache the value in a
// the lock to gate the manual button. // register and miss the background-thread update.
internal readonly object RetentionSweepLock = new(); internal readonly object RetentionSweepLock = new();
internal volatile bool RetentionSweepRunning; internal volatile bool RetentionSweepRunning;
internal DateTime GameStarted { get; } internal DateTime GameStarted { get; }
// Tab management lives here rather than in ChatLogWindow for access reasons. // Tab management needs to happen outside the chatlog window class for access reasons
internal int LastTab { get; set; } internal int LastTab { get; set; }
internal int? WantedTab { get; set; } internal int? WantedTab { get; set; }
internal Tab CurrentTab internal Tab CurrentTab
@@ -162,47 +149,52 @@ public sealed class Plugin : IAsyncDalamudPlugin
public Plugin() public Plugin()
{ {
// Phase-1 ctor: bootstrap-essentials only (conflict gate, config load, // Phase-1 ctor stays minimal: bootstrap-essentials only (conflict
// language + ImGui init). All service/window allocation lives in LoadAsync. // gate, config load, language + ImGui init, WindowSystem skeleton).
// Schema migrations and every service / window allocation moved to
// LoadAsync so the sync ctor returns fast. On failure here nothing
// is initialized yet, so just throw — there is nothing to clean up.
// Block load if upstream Chat 2 is active — prevents IPC collisions // Refuse to start if upstream Chat 2 is loaded — prevents IPC
// and double-replacement of the in-game chat window. // channel collisions and double-replacement of the in-game chat
// window. Throwing here makes Dalamud abort the load cleanly with
// our localized message instead of crashing FFXIV mid-frame.
ChatTwoConflictDetector.ThrowIfChatTwoIsLoaded(Interface); ChatTwoConflictDetector.ThrowIfChatTwoIsLoaded(Interface);
GameStarted = Process.GetCurrentProcess().StartTime.ToUniversalTime(); GameStarted = Process.GetCurrentProcess().StartTime.ToUniversalTime();
// Migrate config + database from upstream ChatTwo on first start. // Hellion Chat: take over config + database from upstream ChatTwo
// before Dalamud loads our plugin config. Idempotent: only acts on
// the first start where the legacy paths exist and ours don't.
MigrateFromChatTwoLayout(); MigrateFromChatTwoLayout();
Config = Interface.GetPluginConfig() as Configuration ?? new Configuration(); Config = Interface.GetPluginConfig() as Configuration ?? new Configuration();
// Wire platform indirection before LoadAsync allocates anything that // Schema-gate: v1.4.3 only supports config schema v16. Older configs
// needs Util.* — services then read Plugin.PlatformUtil instead of // went through their migrations in v1.2.1 (v15→v16) and earlier; users
// hitting the Dalamud static surface directly. // who skipped past those releases need to install v1.4.2 first to run
PlatformUtil = new DalamudPlatformUtil(); // the migration chain, then upgrade to v1.4.3.
LogProxy = new DalamudPluginLogProxy(Log);
// Schema gate: v1.4.x requires config v16+. Users on older schemas
// must install v1.4.2 first to run the migration chain. v17 adds
// Tab.IsPinned (additive, no data migration needed) so v16 configs
// load cleanly and get their Version stamp bumped after the gate.
if (Config.Version < 16) if (Config.Version < 16)
{ {
throw new InvalidOperationException( throw new InvalidOperationException(
$"HellionChat v1.4.9 requires config schema v16, got v{Config.Version}. " $"HellionChat v1.4.3 requires config schema v16, got v{Config.Version}. "
+ "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.9." + "Please install v1.4.2 first to migrate the configuration, then upgrade to v1.4.3."
); );
} }
Config.Version = 17;
// Unpinned TempTabs are session-only and dropped on every load. Pinned // Hellion Chat — Auto-Tell-Tabs Defense-in-Depth. SaveConfig
// TempTabs survive reload — Jin's tester feedback (v1.4.7). // already strips temp tabs before persistence, but a previous
Config.Tabs.RemoveAll(TabLifecycleHelpers.ShouldStripOnLoad); // crash or external write could have left them in the JSON.
// Drop them on load to guarantee the session-only invariant.
Config.Tabs.RemoveAll(t => t.IsTempTab);
LanguageChanged(Interface.UiLanguage); LanguageChanged(Interface.UiLanguage);
ImGuiUtil.Initialize(this); ImGuiUtil.Initialize(this);
DeferredSaveFrames = -1; DeferredSaveFrames = -1;
// WindowSystem skeleton is initialised by the readonly field above —
// no AddWindow yet; window construction lives in LoadAsync.
} }
public async Task LoadAsync(CancellationToken cancellationToken) public async Task LoadAsync(CancellationToken cancellationToken)
@@ -211,8 +203,14 @@ public sealed class Plugin : IAsyncDalamudPlugin
try try
{ {
// Default tab layout on fresh install. Tells are handled by // Hellion v1.0.0 default tab layout. Five thematically separated
// Auto-Tell-Tabs; Novice Network has no preset tab by design. // tabs: General catches the immediate-surroundings public chat
// (Say/Yell/Shout) only; System absorbs the rest of the technical
// and gameplay-event noise; FreeCompany, Group and Linkshell each
// own their respective channel set. Tells are not in a static
// tab anymore — Auto-Tell-Tabs spawns dedicated per-conversation
// tabs on demand. Novice-Network gets no preset tab; users who
// want it can add HellionBeginner from Settings → Tabs.
if (Config.Tabs.Count == 0) if (Config.Tabs.Count == 0)
{ {
Config.Tabs.Add(TabsUtil.VanillaGeneral); Config.Tabs.Add(TabsUtil.VanillaGeneral);
@@ -224,29 +222,32 @@ public sealed class Plugin : IAsyncDalamudPlugin
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// BuildFonts registers handles with Dalamud's FontAtlas; the atlas // Sync allocation + handle registration. BuildFonts() registers
// rebuilds async a few frames later (visible "font-pop" on first load). // IFontHandles with Dalamud's UiBuilder.FontAtlas — registration
// itself is non-blocking (handles stored, lambdas queued). Dalamud
// rebuilds the atlas on its own pipeline a few frames later; first
// frames render with the default font until the rebuild lands and
// ImGui switches to Hellion-Exo2 / NotoSans (visible "font-pop").
// Mirrors ChatTwo Plugin.cs:152.
FontManager = new FontManager(); FontManager = new FontManager();
FontManager.BuildFonts(); FontManager.BuildFonts();
// ThemeRegistry must be wired before the first Draw tick. // Theme init stays sync on the LoadAsync continuation — cheap,
// and Active is read every Draw frame, so the registry must be
// wired before the first hook fires.
var customThemesDir = Path.Combine(Interface.ConfigDirectory.FullName, "themes"); var customThemesDir = Path.Combine(Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(customThemesDir); Directory.CreateDirectory(customThemesDir);
SeedExampleThemeIfEmpty(customThemesDir); SeedExampleThemeIfEmpty(customThemesDir);
ThemeRegistry = new Themes.ThemeRegistry(customThemesDir); ThemeRegistry = new Themes.ThemeRegistry(customThemesDir);
// Warm up the custom-theme cache before the first Switch.
// LoadCustomBySlug is a reverse-lookup over _customCache; on a
// cold cache a Config.Theme that points at a custom slug would
// fall through to the built-in default. AllCustom is a lazy
// enumerable, so iterate it explicitly to materialise the cache.
foreach (var _ in ThemeRegistry.AllCustom()) { }
ThemeRegistry.Switch(Config.Theme); ThemeRegistry.Switch(Config.Theme);
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// Service allocations order encodes dependencies. // Service allocations: order encodes dependencies. Commands is
// HonorificService registers IPC subscribers early to catch // alloc-only here; Initialise() runs after windows exist so the
// Ready/Disposing events from the first frame. // slash-commands can toggle their visibility. HonorificService
// registers IPC subscribers up-front so Ready/Disposing events
// are caught from the very first frame.
FileDialogManager = new FileDialogManager(); FileDialogManager = new FileDialogManager();
Commands = new Commands(); Commands = new Commands();
Functions = new GameFunctions.GameFunctions(this); Functions = new GameFunctions.GameFunctions(this);
@@ -257,6 +258,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
StatusBar = new Ui.StatusBar(); StatusBar = new Ui.StatusBar();
MessageManager = new MessageManager(this); MessageManager = new MessageManager(this);
// Auto-Tell-Tabs subscribes to MessageManager.MessageProcessed for
// live tells and to ClientState.Logout for cleanup; needs the live
// store handed in at construction.
AutoTellTabsService = new AutoTellTabsService( AutoTellTabsService = new AutoTellTabsService(
this, this,
MessageManager, MessageManager,
@@ -264,6 +268,7 @@ public sealed class Plugin : IAsyncDalamudPlugin
); );
AutoTellTabsService.Initialize(); AutoTellTabsService.Initialize();
// SelfTest steps poll Active per frame and need the registry wired.
SelfTestRegistry.RegisterTestSteps([new SelfTests.ThemeSwitchSelfTestStep(this)]); SelfTestRegistry.RegisterTestSteps([new SelfTests.ThemeSwitchSelfTestStep(this)]);
ChatLogWindow = new ChatLogWindow(this); ChatLogWindow = new ChatLogWindow(this);
@@ -284,155 +289,57 @@ public sealed class Plugin : IAsyncDalamudPlugin
WindowSystem.AddWindow(DebuggerWindow); WindowSystem.AddWindow(DebuggerWindow);
WindowSystem.AddWindow(FirstRunWizard); WindowSystem.AddWindow(FirstRunWizard);
// Open the wizard on a fresh install. Existing ChatTwo users have
// FirstRunCompleted set to true by the v6→v7 migration above.
if (!Config.FirstRunCompleted) if (!Config.FirstRunCompleted)
FirstRunWizard.IsOpen = true; FirstRunWizard.IsOpen = true;
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// Populate the command dictionary + UiBuilder hooks BEFORE // let all the other components register, then initialize commands
// Commands.Initialise() walks the dictionary and registers each
// entry with Dalamud's CommandManager (Commands.cs:15-28). Adding
// wrappers after Initialise() would leak them — they'd live in
// the dictionary but never reach Dalamud.
SetupCommands();
Commands.Initialise(); Commands.Initialise();
// Daily retention sweep fire-and-forget, skips when disabled // Daily retention sweep, fire-and-forget. Skips itself when
// or already ran within the past 24 hours. // disabled or when it already ran within the past 24 hours.
RunRetentionSweepIfDue(); RunRetentionSweepIfDue();
if (Config.ShowEmotes) if (Config.ShowEmotes)
_ = EmoteCache.LoadData(); _ = EmoteCache.LoadData(); // Fire-and-forget, exceptions caught inside
if (Interface.Reason is not PluginLoadReason.Boot) if (Interface.Reason is not PluginLoadReason.Boot)
MessageManager.FilterAllTabsAsync(); MessageManager.FilterAllTabsAsync();
// Kick the FTS5 rebuild worker if Migrate4 just added the schema or
// a previous run was cut short (InitFtsReadyCache leaves _ftsReady
// false in that case). Runs off the framework thread on its own
// SqliteConnection so the live UpsertMessage path keeps flowing
// through the chunked-commit windows.
_ftsRebuildCts = new CancellationTokenSource();
if (!MessageManager.Store.IsFtsIndexBuilt)
{
var token = _ftsRebuildCts.Token;
_ = Task.Run(
async () =>
{
// FQN: Plugin.Notification (Z.74) shadows the type name.
Dalamud.Interface.ImGuiNotification.IActiveNotification? notif = null;
try
{
notif = Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification
{
Title = "Hellion Chat",
Content = "Indexing chat history for full-text search...",
Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Info,
Minimized = false,
InitialDuration = TimeSpan.FromMinutes(10),
}
);
// Progress<T> raises this callback on the captured
// sync-context (Task.Run worker pool). IActiveNotification
// is ImGui-backed and mutates the UI, so marshal the
// mutation onto the framework thread via RunOnTick.
var progress = new Progress<long>(done =>
{
Framework.RunOnTick(() =>
{
if (notif is { } n)
n.Content = $"Indexing chat history: {done:N0} messages...";
});
});
// Worker-owned connection. Closed+disposed before we
// flip the readiness flag so the DbViewer never sees
// IsFtsIndexBuilt=true while the worker connection
// is still alive.
SqliteConnection? workerConn = null;
try
{
workerConn = MessageManager.Store.OpenSecondaryConnection();
var total = await Task.Run(
() =>
MessageManager.Store.RebuildFtsIndex(
workerConn,
progress,
token
),
token
)
.ConfigureAwait(false);
workerConn.Close();
workerConn.Dispose();
workerConn = null;
MessageManager.Store.MarkFtsIndexBuilt();
if (notif is { } final)
{
final.Content = $"Indexed {total:N0} messages.";
final.Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Success;
final.InitialDuration = TimeSpan.FromSeconds(5);
}
}
finally
{
workerConn?.Dispose();
}
}
catch (OperationCanceledException)
{
notif?.DismissNow();
}
catch (Exception ex)
{
Log.Error(ex, "FTS index rebuild failed");
if (notif is { } err)
{
err.Content =
"Full-text indexing failed -- search will use local filter only.";
err.Type = Dalamud
.Interface
.ImGuiNotification
.NotificationType
.Error;
}
}
},
_ftsRebuildCts.Token
);
}
Interface.UiBuilder.DisableCutsceneUiHide = true; Interface.UiBuilder.DisableCutsceneUiHide = true;
Interface.UiBuilder.DisableGposeUiHide = true; Interface.UiBuilder.DisableGposeUiHide = true;
#if !DEBUG #if !DEBUG
// Fire-and-forget first auto-translate use may have a sub-second // Fire-and-forget on a worker thread. The first auto-translate use of
// hitch if the cache hasn't filled yet, but avoids blocking load. // a session may have a sub-second hitch if the cache hasn't filled yet,
// but that's preferable to making every user wait ~300 ms during
// plugin load for a cache they may never touch. ChatTwo (upstream)
// does this sync; we trade load-time for first-use latency.
_ = Task.Run(AutoTranslate.PreloadCache, cancellationToken); _ = Task.Run(AutoTranslate.PreloadCache, cancellationToken);
#endif #endif
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
// Hooks last — all services and windows must be live before // (B1) Hooks last: every service and window must be live before
// the first Draw / FrameworkUpdate tick fires. // Dalamud fires our first Draw / FrameworkUpdate tick. Anything
// earlier risks rendering against null FontManager / ThemeRegistry.
Framework.Update += FrameworkUpdate; Framework.Update += FrameworkUpdate;
Interface.UiBuilder.Draw += Draw; Interface.UiBuilder.Draw += Draw;
Interface.LanguageChanged += LanguageChanged; Interface.LanguageChanged += LanguageChanged;
// Hellion Chat — surface a "main UI" entry point so Dalamud's
// plugin list shows the Open-Plugin button. Settings is the
// most useful landing place; OpenConfigUi is already wired to
// the same toggle inside SettingsWindow.
Interface.UiBuilder.OpenMainUi += OpenMainUi;
} }
catch catch
{ {
// Mirror the v1.4.0 load-failure recovery: hand off to DisposeAsync
// so partially-built services are torn down. Swallow the cleanup
// exception so the original load failure stays the visible cause.
try try
{ {
await DisposeAsync().ConfigureAwait(false); await DisposeAsync().ConfigureAwait(false);
@@ -444,40 +351,28 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
} }
// Suppressing this warning because DisposeAsync may run after a partial
// LoadAsync, so some properties may not be initialized.
[SuppressMessage("ReSharper", "ConditionalAccessQualifierIsNonNullableAccordingToAPIContract")] [SuppressMessage("ReSharper", "ConditionalAccessQualifierIsNonNullableAccordingToAPIContract")]
public async ValueTask DisposeAsync() public async ValueTask DisposeAsync()
{ {
// Idempotency guard — second call short-circuits on reload race. // (B3) Idempotency guard — Dalamud may reload-race us; second
// call short-circuits so we don't double-dispose services.
if (Interlocked.Exchange(ref _disposeStarted, 1) != 0) if (Interlocked.Exchange(ref _disposeStarted, 1) != 0)
return; return;
// Set before any cleanup so deferred Framework.RunOnTick callbacks
// (B3 retention sweep) see the flag and bail out before they touch
// MessageManager / Log / static fields that the rest of this method
// is about to tear down.
_isDisposing = true;
Exception? failure = null; Exception? failure = null;
// Unsubscribe hooks first — mirrors the hooks-last subscribe order in LoadAsync. // Hooks unsubscribe FIRST so no Draw / FrameworkUpdate / LanguageChanged
// tick can fire while we're tearing services down. Mirrors the
// hooks-last subscribe order in LoadAsync.
failure = CaptureFailure(failure, () => Interface.UiBuilder.OpenMainUi -= OpenMainUi);
failure = CaptureFailure(failure, () => Interface.LanguageChanged -= LanguageChanged); failure = CaptureFailure(failure, () => Interface.LanguageChanged -= LanguageChanged);
failure = CaptureFailure(failure, () => Interface.UiBuilder.Draw -= Draw); failure = CaptureFailure(failure, () => Interface.UiBuilder.Draw -= Draw);
failure = CaptureFailure(failure, () => Framework.Update -= FrameworkUpdate); failure = CaptureFailure(failure, () => Framework.Update -= FrameworkUpdate);
// Signal the FTS rebuild worker to bail. Runs before MessageManager // v1.4.0 F5.3 — flush a pending DeferredSave before service teardown,
// tears down so the worker's "rebuild failed" log path still finds // since FrameworkUpdate just got unsubscribed and won't fire it.
// a live Log static. Worker owns its own SqliteConnection and disposes
// it itself; we only flip the cancellation flag here.
failure = CaptureFailure(
failure,
() =>
{
_ftsRebuildCts?.Cancel();
_ftsRebuildCts?.Dispose();
}
);
// Flush a pending DeferredSave — FrameworkUpdate won't fire it anymore.
failure = CaptureFailure( failure = CaptureFailure(
failure, failure,
() => () =>
@@ -490,10 +385,13 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
); );
// Unsubscribe AutoTellTabs before MessageManager goes away. // Auto-Tell-Tabs unsubscribes from MessageProcessed before MessageManager
// goes away. Pure-memory cleanup, no framework-thread requirement.
failure = CaptureFailure(failure, () => AutoTellTabsService?.Dispose()); failure = CaptureFailure(failure, () => AutoTellTabsService?.Dispose());
// MessageManager has its own async dispose path (DB flush, thread shutdown). // v1.4.0 F6.2 — MessageManager has its own async dispose path
// (DB flush, pending-message thread shutdown). Run it before the
// framework-block so the worker threads are quiesced first.
if (MessageManager is not null) if (MessageManager is not null)
{ {
failure = await CaptureFailureAsync( failure = await CaptureFailureAsync(
@@ -503,29 +401,36 @@ public sealed class Plugin : IAsyncDalamudPlugin
.ConfigureAwait(false); .ConfigureAwait(false);
} }
// Game-function / IPC / window cleanup must run on the framework thread. // (B4) Game-Function / IPC / UI-Window cleanup MUST run on the
// framework thread. WindowSystem mutations and IPC subscriber
// disposes touch Dalamud state that's only safe from the framework.
// Worker-thread DisposeAsync would race the next Draw tick.
// Per-line CaptureFailure so a single throw can't strand the lines
// behind it; mirrors Lightless DisposeFrameworkBoundServicesAsync.
try try
{ {
await Framework await Framework
.RunOnFrameworkThread(() => .RunOnFrameworkThread(() =>
{ {
// TearDown slash-commands + UiBuilder hooks before windows // Game-Functions first — other services may still query
// tear down. Slash-commands holding handlers that reach // chat-interactable state during their Dispose.
// the windows would otherwise see a half-torn Plugin.
failure = CaptureFailure(failure, TearDownCommands);
failure = CaptureFailure( failure = CaptureFailure(
failure, failure,
() => GameFunctions.GameFunctions.SetChatInteractable(true) () => GameFunctions.GameFunctions.SetChatInteractable(true)
); );
// IPC subscribers before windows — prevents a final IPC event // IPC subscribers — dispose before windows so any final
// from reaching a half-torn ChatLogWindow. // event firing from the IPC source can't reach a half-torn
// ChatLogWindow.
failure = CaptureFailure(failure, () => HonorificService?.Dispose()); failure = CaptureFailure(failure, () => HonorificService?.Dispose());
failure = CaptureFailure(failure, () => TypingIpc?.Dispose()); failure = CaptureFailure(failure, () => TypingIpc?.Dispose());
failure = CaptureFailure(failure, () => ExtraChat?.Dispose()); failure = CaptureFailure(failure, () => ExtraChat?.Dispose());
failure = CaptureFailure(failure, () => Ipc?.Dispose()); failure = CaptureFailure(failure, () => Ipc?.Dispose());
// Windows — RemoveAllWindows first, then per-window Dispose.
// Order matches the pre-v1.4.3 Dispose body byte-for-byte.
// CommandHelpWindow and FirstRunWizard don't implement
// IDisposable; their resources are reclaimed via WindowSystem.
failure = CaptureFailure(failure, () => WindowSystem?.RemoveAllWindows()); failure = CaptureFailure(failure, () => WindowSystem?.RemoveAllWindows());
failure = CaptureFailure(failure, () => ChatLogWindow?.Dispose()); failure = CaptureFailure(failure, () => ChatLogWindow?.Dispose());
failure = CaptureFailure(failure, () => DbViewer?.Dispose()); failure = CaptureFailure(failure, () => DbViewer?.Dispose());
@@ -541,19 +446,19 @@ public sealed class Plugin : IAsyncDalamudPlugin
failure ??= ex; failure ??= ex;
} }
// Pure-memory cleanups — no Framework / UI / IPC touch. // Pure-memory cleanups — no Framework / UI / IPC touch, so they
// run on whatever thread DisposeAsync resumes on.
failure = CaptureFailure(failure, () => Functions?.Dispose()); failure = CaptureFailure(failure, () => Functions?.Dispose());
failure = CaptureFailure(failure, () => Commands?.Dispose()); failure = CaptureFailure(failure, () => Commands?.Dispose());
failure = CaptureFailure(failure, () => EmoteCache.Dispose()); failure = CaptureFailure(failure, () => EmoteCache.Dispose());
// Static input history would otherwise survive the plugin reload.
failure = CaptureFailure(failure, InputHistoryService.Reset);
if (failure is not null) if (failure is not null)
ExceptionDispatchInfo.Capture(failure).Throw(); ExceptionDispatchInfo.Capture(failure).Throw();
} }
// Run cleanup actions individually so a single failure doesn't strand // Lightless-pattern capture helpers: run cleanup, remember the FIRST
// the remaining teardown steps. // exception, keep going. Without these one mid-teardown failure would
// skip every cleanup behind it and leave services half-torn.
private static Exception? CaptureFailure(Exception? failure, Action action) private static Exception? CaptureFailure(Exception? failure, Action action)
{ {
try try
@@ -594,6 +499,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
var ourConfigFile = Path.Combine(pluginConfigsDir, "HellionChat.json"); var ourConfigFile = Path.Combine(pluginConfigsDir, "HellionChat.json");
var ourConfigDir = Interface.ConfigDirectory.FullName; var ourConfigDir = Interface.ConfigDirectory.FullName;
// Track whether anything legitimately blocked us. The most common
// cause is upstream Chat 2 still being loaded — its SQLite handle
// keeps chat-sqlite.db locked and File.Move throws IOException.
var lockedBlocker = false; var lockedBlocker = false;
try try
@@ -615,6 +523,13 @@ public sealed class Plugin : IAsyncDalamudPlugin
lockedBlocker = true; lockedBlocker = true;
} }
// The plugin's ConfigDirectory may already exist on first load
// (Dalamud creates it), so check at the file level instead of
// skipping when the directory is present. Move every legacy
// entry whose target name is not occupied yet, then remove the
// source dir if it ends up empty. Each move is wrapped on its
// own so a single locked file (the SQLite db while ChatTwo still
// runs) does not abandon the rest of the migration.
if (!Directory.Exists(legacyConfigDir)) if (!Directory.Exists(legacyConfigDir))
return; return;
@@ -622,8 +537,6 @@ public sealed class Plugin : IAsyncDalamudPlugin
{ {
Directory.CreateDirectory(ourConfigDir); Directory.CreateDirectory(ourConfigDir);
// Move each file individually so a single locked file (e.g. the
// SQLite db while ChatTwo is still loaded) doesn't abort the rest.
foreach (var file in Directory.EnumerateFiles(legacyConfigDir)) foreach (var file in Directory.EnumerateFiles(legacyConfigDir))
{ {
var target = Path.Combine(ourConfigDir, Path.GetFileName(file)); var target = Path.Combine(ourConfigDir, Path.GetFileName(file));
@@ -677,6 +590,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (lockedBlocker) if (lockedBlocker)
{ {
// Surface the most common cause to the user as a notification
// so they don't think Hellion Chat lost their history when in
// fact upstream Chat 2 was still holding the database file.
Notification.AddNotification( Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification new Dalamud.Interface.ImGuiNotification.Notification
{ {
@@ -692,80 +608,15 @@ public sealed class Plugin : IAsyncDalamudPlugin
} }
} }
// Central slash-command + UiBuilder.OpenConfigUi/OpenMainUi subscribe so private void OpenMainUi()
// the four lazy windows (Settings, DbViewer, SeStringDebugger, Debugger)
// have working entry points before they're constructed.
private void SetupCommands()
{ {
// ChatLogWindow.cs:128 already registers /hellion (ToggleChat). The // Settings is the most useful landing surface — same target as the
// description-arg here keeps the Dalamud help list populated. // Configure button. SettingsWindow.Toggle is internal and already
Commands.Register("/hellion", "Perform various actions with Hellion Chat.").Execute += // wired to OpenConfigUi, so re-using IsOpen keeps both entry points
OnHellionSettingsCommand; // behaviourally identical.
Commands SettingsWindow.IsOpen = !SettingsWindow.IsOpen;
.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute += OnHellionViewCommand;
Commands.Register("/hellionDebugger", showInHelp: false).Execute +=
OnHellionDebuggerCommand;
#if DEBUG
// SeStringDebugger.cs lives under #if DEBUG too; keep this out of release builds.
Commands.Register("/hellionSeString", showInHelp: false).Execute +=
OnHellionSeStringCommand;
#endif
// Plugin-Manager "Settings" button. Was in Settings.cs:67 pre-v1.4.9.
Interface.UiBuilder.OpenConfigUi += OnOpenConfigUi;
// Plugin-Manager "Open" button. Was in Plugin.cs LoadAsync pre-v1.4.9
// (separate OpenMainUi handler that flipped SettingsWindow.IsOpen).
Interface.UiBuilder.OpenMainUi += OnOpenMainUi;
} }
private void TearDownCommands()
{
Interface.UiBuilder.OpenMainUi -= OnOpenMainUi;
Interface.UiBuilder.OpenConfigUi -= OnOpenConfigUi;
Commands.Register("/hellion", "Perform various actions with Hellion Chat.").Execute -=
OnHellionSettingsCommand;
Commands
.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute -= OnHellionViewCommand;
Commands.Register("/hellionDebugger", showInHelp: false).Execute -=
OnHellionDebuggerCommand;
#if DEBUG
Commands.Register("/hellionSeString", showInHelp: false).Execute -=
OnHellionSeStringCommand;
#endif
}
private void OnHellionSettingsCommand(string command, string arguments)
{
// /hellion with args is intentionally a no-op (matches pre-v1.4.9
// Settings.cs:76-80 behaviour).
if (string.IsNullOrWhiteSpace(arguments))
SettingsWindow.Toggle();
}
private void OnOpenConfigUi() => SettingsWindow.Toggle();
private void OnOpenMainUi() => SettingsWindow.Toggle();
private void OnHellionViewCommand(string _, string __) => DbViewer.Toggle();
private void OnHellionDebuggerCommand(string _, string __) => DebuggerWindow.Toggle();
#if DEBUG
private void OnHellionSeStringCommand(string _, string __) => SeStringDebugger.Toggle();
#endif
private void RunRetentionSweepIfDue() private void RunRetentionSweepIfDue()
{ {
if (!Config.RetentionEnabled) if (!Config.RetentionEnabled)
@@ -773,7 +624,8 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (DateTimeOffset.UtcNow - Config.RetentionLastRunAt < TimeSpan.FromHours(24)) if (DateTimeOffset.UtcNow - Config.RetentionLastRunAt < TimeSpan.FromHours(24))
return; return;
// Snapshot the policy so the user can edit settings while the sweep runs. // Snapshot the policy so the user can edit settings while we run.
// Spec defaults form the baseline; explicit user overrides win.
var policy = new Dictionary<int, int>(); var policy = new Dictionary<int, int>();
foreach (var (type, days) in Privacy.PrivacyDefaults.DefaultRetentionDays) foreach (var (type, days) in Privacy.PrivacyDefaults.DefaultRetentionDays)
policy[(int)(ushort)type] = days; policy[(int)(ushort)type] = days;
@@ -781,10 +633,16 @@ public sealed class Plugin : IAsyncDalamudPlugin
policy[(int)(ushort)type] = days; policy[(int)(ushort)type] = days;
var defaultDays = Config.RetentionDefaultDays; var defaultDays = Config.RetentionDefaultDays;
// IsBackground = true so a stuck sweep never blocks plugin unload. // IsBackground = true for the same reason as PendingMessageThread:
// a stuck sweep must never block plugin unload. RunRetentionSweepIfDue
// guards the run-frequency, and the sweep itself uses the framework's
// cooperative cancellation pattern. The background flag is the safety
// net if the sweep ever takes longer than expected.
new Thread(() => new Thread(() =>
{ {
// Bail early if a manual sweep is already in flight. // Bail out cheaply if a manual sweep is already in flight; the
// lock around the actual work would queue us up otherwise and
// we would just re-do whatever the manual run already did.
lock (RetentionSweepLock) lock (RetentionSweepLock)
{ {
if (RetentionSweepRunning) if (RetentionSweepRunning)
@@ -801,31 +659,18 @@ public sealed class Plugin : IAsyncDalamudPlugin
if (deleted > 0) if (deleted > 0)
{ {
Log.Information($"Retention sweep deleted {deleted} expired messages."); Log.Information($"Retention sweep deleted {deleted} expired messages.");
// Schedule on the next framework tick to avoid the ~194ms // Run the clear+refilter synchronously on the framework thread.
// hitch from blocking with .Wait() while the framework // Earlier this called FilterAllTabsAsync(), which is fire-and-forget
// finishes the current frame. Tabs-list mutation must // — the .Wait() here would return as soon as the inner Task.Run was
// stay on the framework thread because Plugin.Config.Tabs // dispatched, racing the next sweep cycle against the still-running
// (Configuration.cs:222) is not lock-protected and // filter pass. See AUDIT-2026-05-05 [QUAL-02].
// AutoTellTabsService can mutate it from background paths. Framework
// Pattern reference: SimpleTweaks .Run(() =>
// Tweaks/Chat/CaseInsensitiveCommands.cs:45.
Framework.RunOnTick(() =>
{
// The retention thread is IsBackground=true so plugin
// unload can fire while a scheduled tick is still
// pending; bail before touching anything torn down.
if (_isDisposing)
return;
try
{ {
MessageManager.ClearAllTabs(); MessageManager.ClearAllTabs();
MessageManager.FilterAllTabs(); MessageManager.FilterAllTabs();
} })
catch (Exception ex) .Wait();
{
Log.Error(ex, "Retention sweep clear+refilter failed");
}
});
} }
else else
{ {
@@ -849,13 +694,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
private void Draw() private void Draw()
{ {
// v1.4.8 B2: pick up external edits of the active custom theme JSON // Theme-Engine ist ab v14 immer aktiv; Klassik ist jetzt ein eigenes
// without forcing the user to re-click the picker. The disk-stat is // Theme statt einem deaktivierten Hellion-Theme. Active wird einmal
// 1Hz-throttled inside RefreshActiveIfStale, so this is essentially // pro Frame aus der Registry gelesen.
// free on built-in themes and ~1 stat/second on custom themes.
ThemeRegistry.RefreshActiveIfStale();
// Theme engine is always active; Classic is a theme, not a disabled state.
using IDisposable _style = HellionStyle.PushGlobal( using IDisposable _style = HellionStyle.PushGlobal(
ThemeRegistry.Active, ThemeRegistry.Active,
Config.WindowOpacity Config.WindowOpacity
@@ -870,7 +711,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
return; return;
} }
// Hide all plugin windows while the New Game+ menu is open. // v1.0.2 — global skip while the New Game+ menu (QuestRedo addon) is
// open. Hides every plugin window in one shot (chat log, pop-outs,
// settings, db viewer, etc.), matching the LoadingScreens pattern.
if ( if (
Config.HideInNewGamePlusMenu Config.HideInNewGamePlusMenu
&& GameFunctions.GameFunctions.IsAddonInteractable( && GameFunctions.GameFunctions.IsAddonInteractable(
@@ -899,17 +742,17 @@ public sealed class Plugin : IAsyncDalamudPlugin
internal void SaveConfig() internal void SaveConfig()
{ {
// Only unpinned TempTabs are session-only — they move aside before // Hellion Chat — Auto-Tell-Tabs are session-only. Strip them out
// serialization and re-attach after. Pinned TempTabs stay in // before serialization so a crash mid-session can never persist
// Config.Tabs across the save so JSON includes them. Cloning only the // them. We snapshot the full tab list first and restore it after
// unpinned subset keeps the allocation proportional to // the save, preserving the user's order and open conversations.
// AutoTellTabsLimit (<=15) instead of the full tab list. var snapshot = Config.Tabs.ToList();
var unpinnedTempTabs = Config.Tabs.Where(TabLifecycleHelpers.IsInUnpinnedPool).ToList(); Config.Tabs.RemoveAll(t => t.IsTempTab);
Config.Tabs.RemoveAll(TabLifecycleHelpers.ShouldStripOnSave);
Interface.SavePluginConfig(Config); Interface.SavePluginConfig(Config);
Config.Tabs.AddRange(unpinnedTempTabs); Config.Tabs.Clear();
Config.Tabs.AddRange(snapshot);
} }
internal void LanguageChanged(string langCode) internal void LanguageChanged(string langCode)
@@ -951,8 +794,9 @@ public sealed class Plugin : IAsyncDalamudPlugin
Condition[ConditionFlag.OccupiedInCutSceneEvent] Condition[ConditionFlag.OccupiedInCutSceneEvent]
|| Condition[ConditionFlag.WatchingCutscene78]; || Condition[ConditionFlag.WatchingCutscene78];
// Seeds example-theme.json into the themes dir on first run. // v1.1.0 — wenn der themes/-Ordner leer ist, schreiben wir die embedded
// Skipped if any custom JSON already exists. // example-theme.json als Vorlage rein. Bestehende User-Customs werden
// nicht angefasst (existing JSONs lassen den Block überspringen).
private static void SeedExampleThemeIfEmpty(string dir) private static void SeedExampleThemeIfEmpty(string dir)
{ {
if (Directory.EnumerateFiles(dir, "*.json").Any()) if (Directory.EnumerateFiles(dir, "*.json").Any())
+12 -14
View File
@@ -4,15 +4,10 @@ namespace HellionChat.Privacy;
internal static class PrivacyDefaults internal static class PrivacyDefaults
{ {
// F3.1: failsafe for ChatTypes added by future FFXIV patches. New installs // Privacy-First default whitelist (DSGVO Art. 25 - Privacy by Default).
// persist unknown channels so a major patch's added ChatType isn't silently // Only the player's own conversations are persisted out-of-the-box.
// dropped before the user can opt in or out. Existing configs keep their // Public chat (Say/Shout/Yell), Novice Network, NPC dialogue, system
// explicit choice — see Configuration.cs PrivacyPersistUnknownChannels. // logs and battle messages are NOT persisted unless the user opts in.
internal const bool DefaultPersistUnknownChannels = true;
// DSGVO Art. 25 (Privacy by Default): only the player's own conversations
// are persisted out-of-the-box. Public chat, NPC dialogue, system logs and
// battle messages require explicit opt-in.
internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType> internal static readonly IReadOnlySet<ChatType> PrivacyFirstWhitelist = new HashSet<ChatType>
{ {
ChatType.TellIncoming, ChatType.TellIncoming,
@@ -47,8 +42,10 @@ internal static class PrivacyDefaults
ChatType.ExtraChatLinkshell8, ChatType.ExtraChatLinkshell8,
}; };
// Per-channel retention in days. Unlisted channels fall back to // Default retention windows per channel (in days). Channels not listed
// Configuration.RetentionDefaultDays. Tells: 365, everything else: 90. // here fall back to Configuration.RetentionDefaultDays. Reflects the
// design spec: Tells 365, own-conversation channels 90, everything else
// shorter via the global default.
internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays = internal static readonly IReadOnlyDictionary<ChatType, int> DefaultRetentionDays =
new Dictionary<ChatType, int> new Dictionary<ChatType, int>
{ {
@@ -89,9 +86,10 @@ internal static class PrivacyDefaults
[ChatType.ExtraChatLinkshell8] = 90, [ChatType.ExtraChatLinkshell8] = 90,
}; };
// Casual: Privacy-First + public chat (Say/Shout/Yell, emotes, Novice // Casual profile = Privacy-First plus public chat (Say/Shout/Yell, both
// Network) with a 1-day window so recent RP/trade is searchable but // emote types, Novice Network), kept for a short 24-hour window so the
// third-party data doesn't accumulate. // last RP scene or shout trade is still searchable but third-party data
// doesn't accumulate forever.
internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>( internal static readonly IReadOnlySet<ChatType> CasualWhitelist = new HashSet<ChatType>(
PrivacyFirstWhitelist PrivacyFirstWhitelist
) )
+52 -9
View File
@@ -4,8 +4,11 @@ using HellionChat.Util;
namespace HellionChat.Resources; namespace HellionChat.Resources;
// Built-in colour presets applied via Settings UI → ChatColours. // Hellion Chat — v0.6.0 built-in colour presets for the ChatColours
// Battle-channel types are intentionally excluded to preserve combat-log tuning. // settings section. Read-only static data; users apply a preset via the
// settings UI which overwrites Configuration.ChatColours immediately.
// Battle-channel types are intentionally NOT covered by the stylistic
// presets so that combat-log tuning the user has done stays intact.
public sealed record ChatColourPreset( public sealed record ChatColourPreset(
string DisplayName, string DisplayName,
string LocalizationKey, string LocalizationKey,
@@ -66,7 +69,9 @@ public static class ChatColourPresets
}; };
} }
// Mirrors ChatTypeExt.DefaultColor; channels without a default are skipped. // The Default preset spiegelt 1:1 die Werte aus ChatTypeExt.DefaultColor.
// Channels ohne Default-Wert (return null) werden ausgelassen — wer sie
// anwenden will, behält seine aktuelle Farbe.
private static IReadOnlyDictionary<ChatType, uint> BuildDefault() private static IReadOnlyDictionary<ChatType, uint> BuildDefault()
{ {
var dict = new Dictionary<ChatType, uint>(); var dict = new Dictionary<ChatType, uint>();
@@ -178,22 +183,33 @@ public static class ChatColourPresets
}; };
} }
// Hellion brand preset — Arctic Cyan + Ember Orange palette. // Hellion brand preset — Arctic Cyan + Ember Orange palette aus
// Cyan family for Standard/Tell, Ember/Warning for loud channels, // /mnt/ssd-fast/Projekte/hellion-media/hellion-media-website/BRANDING.md
// Status colours for Linkshells, darker variants for CrossLinkshells. // (Schema-Stand 2026-04-16). Channels sind über das ganze Brand-Spektrum
// verteilt damit jede Zeile auf einen Glance unterscheidbar ist:
// Cyan-Familie für Standard/Tell, Ember + Warning für laute Channels,
// Status-Farben (Success, Danger) für Linkshells. CrossLinkshells
// nutzen die dunkleren/sattersten Varianten derselben Hue-Familien.
private static IReadOnlyDictionary<ChatType, uint> BuildHellion() private static IReadOnlyDictionary<ChatType, uint> BuildHellion()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
// Standard / Tell — Cyan-Familie (Brand-Primary)
[ChatType.Say] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light #4DD9E8 [ChatType.Say] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light #4DD9E8
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan #00BED2 [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan #00BED2
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark #0097A7 [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark #0097A7
// Laute Channels — Ember/Warning
[ChatType.Yell] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning #F0AD4E [ChatType.Yell] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning #F0AD4E
[ChatType.Shout] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember #F97316 [ChatType.Shout] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember #F97316
// Gruppen-Channels — Success/Ember-dark/Cyan
[ChatType.Party] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success #5CB85C [ChatType.Party] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success #5CB85C
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark #E85D04 [ChatType.Alliance] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark #E85D04
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(0, 190, 210), // Brand Cyan
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(77, 217, 232), // Cyan-light
// Linkshells 1-8 — über das ganze Brand-Spektrum verteilt
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(251, 146, 60), // Ember-light #FB923C [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(251, 146, 60), // Ember-light #FB923C
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(240, 173, 78), // Warning
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(92, 184, 92), // Success
@@ -202,6 +218,8 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(0, 151, 167), // Cyan-dark
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(249, 115, 22), // Brand Ember
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(217, 83, 79), // Danger #D9534F [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(217, 83, 79), // Danger #D9534F
// CrossWorld-Linkshells 1-8 — dunklere/sattersere Varianten
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(232, 93, 4), // Ember-dark
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(200, 140, 50), // Warning-dark [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(200, 140, 50), // Warning-dark
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(60, 140, 60), // Success-dark [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(60, 140, 60), // Success-dark
@@ -213,20 +231,31 @@ public static class ChatColourPresets
}; };
} }
// Night Blue — cool nautical theme, deep navy without purple. // Bonus preset — Night Blue, KAZAMA-Stimmungs-Theme aus
// /mnt/HDD-Data1/Obsidian/Vault/Systeme/KAZAMA/Theming/Night Blue + Indigo Violet Themes.md
// Klassisch, kühl, technisch — Marineblau-Tiefe ohne Lila-Anteil.
// Bewusst NICHT als Brand-Preset markiert (Vault-Boundary): die KAZAMA-Themes
// sind persönliche Stimmungs-Themes, nicht Teil des Hellion-Brand-Systems.
private static IReadOnlyDictionary<ChatType, uint> BuildNightBlue() private static IReadOnlyDictionary<ChatType, uint> BuildNightBlue()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
// Standard / Tell — Royal Blue Akzent-Familie
[ChatType.Say] = ColourUtil.ComponentsToRgba(230, 237, 247), // text-primary [ChatType.Say] = ColourUtil.ComponentsToRgba(230, 237, 247), // text-primary
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(106, 176, 255), // akzent-hot [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(106, 176, 255), // akzent-hot
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary
// Laute Channels — Warning/Danger Status-Töne
[ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), // warning [ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), // warning
[ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), // danger [ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), // danger
// Gruppen — Success/Akzent-Variations
[ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), // success [ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), // success
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), // warm-orange-light [ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), // warm-orange-light
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(74, 144, 226), // akzent-primary
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(140, 160, 191), // text-dim [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(140, 160, 191), // text-dim
// Linkshells 1-8 — über Spektrum verteilt
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130), [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130),
@@ -235,6 +264,8 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(100, 200, 220), [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(100, 200, 220),
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(106, 176, 255), [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(106, 176, 255),
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(140, 160, 191), [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(140, 160, 191),
// CrossWorld-Linkshells — gedämpfte Variants
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50), [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50),
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80), [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80),
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60), [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60),
@@ -246,20 +277,30 @@ public static class ChatColourPresets
}; };
} }
// Indigo Violet — warm-mystic theme, deep indigo with violet accent. // Bonus preset — Indigo Violet, KAZAMA-Stimmungs-Theme aus demselben
// Vault-Doc. Warm-mystisch, "Galaxy/Glitter/Nordlicht" — tiefes Indigo
// mit kräftigem Violet-Akzent. Persönlicher Favorit (siehe Vault).
// Auch nicht als Brand-Preset (siehe NightBlue-Note oben).
private static IReadOnlyDictionary<ChatType, uint> BuildIndigoViolet() private static IReadOnlyDictionary<ChatType, uint> BuildIndigoViolet()
{ {
return new Dictionary<ChatType, uint> return new Dictionary<ChatType, uint>
{ {
[ChatType.Say] = ColourUtil.ComponentsToRgba(240, 230, 255), // text-primary // Standard / Tell — Royal Violet Akzent-Familie
[ChatType.Say] = ColourUtil.ComponentsToRgba(240, 230, 255), // text-primary (light lavender)
[ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(176, 124, 255), // akzent-hot [ChatType.TellIncoming] = ColourUtil.ComponentsToRgba(176, 124, 255), // akzent-hot
[ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary [ChatType.TellOutgoing] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary
// Laute Channels — geteilt mit Night Blue (Status-Farben)
[ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Yell] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122), [ChatType.Shout] = ColourUtil.ComponentsToRgba(255, 92, 122),
// Gruppen
[ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151), [ChatType.Party] = ColourUtil.ComponentsToRgba(61, 220, 151),
[ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Alliance] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary [ChatType.FreeCompany] = ColourUtil.ComponentsToRgba(139, 77, 222), // akzent-primary
[ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(168, 144, 208), // text-dim [ChatType.NoviceNetwork] = ColourUtil.ComponentsToRgba(168, 144, 208), // text-dim
// Linkshells 1-8
[ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74), [ChatType.Linkshell1] = ColourUtil.ComponentsToRgba(255, 184, 74),
[ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100), [ChatType.Linkshell2] = ColourUtil.ComponentsToRgba(255, 144, 100),
[ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130), [ChatType.Linkshell3] = ColourUtil.ComponentsToRgba(255, 220, 130),
@@ -268,6 +309,8 @@ public static class ChatColourPresets
[ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(139, 77, 222), [ChatType.Linkshell6] = ColourUtil.ComponentsToRgba(139, 77, 222),
[ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(130, 90, 200), [ChatType.Linkshell7] = ColourUtil.ComponentsToRgba(130, 90, 200),
[ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(168, 144, 208), [ChatType.Linkshell8] = ColourUtil.ComponentsToRgba(168, 144, 208),
// CrossWorld-Linkshells
[ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50), [ChatType.CrossLinkshell1] = ColourUtil.ComponentsToRgba(200, 130, 50),
[ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80), [ChatType.CrossLinkshell2] = ColourUtil.ComponentsToRgba(220, 110, 80),
[ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60), [ChatType.CrossLinkshell3] = ColourUtil.ComponentsToRgba(200, 180, 60),
-19
View File
@@ -114,8 +114,6 @@ internal class HellionStrings
internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning)); internal static string Wizard_Profile_FullHistory_GdprWarning => Get(nameof(Wizard_Profile_FullHistory_GdprWarning));
internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply)); internal static string Wizard_Profile_FullHistory_Apply => Get(nameof(Wizard_Profile_FullHistory_Apply));
internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button)); internal static string Wizard_Reopen_Button => Get(nameof(Wizard_Reopen_Button));
internal static string Wizard_Cancel_Label => Get(nameof(Wizard_Cancel_Label));
internal static string Wizard_Cancel_Tooltip => Get(nameof(Wizard_Cancel_Tooltip));
internal static string Export_Heading => Get(nameof(Export_Heading)); internal static string Export_Heading => Get(nameof(Export_Heading));
internal static string Export_Help => Get(nameof(Export_Help)); internal static string Export_Help => Get(nameof(Export_Help));
@@ -170,16 +168,6 @@ internal class HellionStrings
internal static string AutoTellTabs_HistoryLoadError => Get(nameof(AutoTellTabs_HistoryLoadError)); internal static string AutoTellTabs_HistoryLoadError => Get(nameof(AutoTellTabs_HistoryLoadError));
internal static string AutoTellTabs_GreetedTooltip => Get(nameof(AutoTellTabs_GreetedTooltip)); internal static string AutoTellTabs_GreetedTooltip => Get(nameof(AutoTellTabs_GreetedTooltip));
internal static string AutoTellTabs_UnGreetedTooltip => Get(nameof(AutoTellTabs_UnGreetedTooltip)); internal static string AutoTellTabs_UnGreetedTooltip => Get(nameof(AutoTellTabs_UnGreetedTooltip));
internal static string PinTab_MenuPin => Get(nameof(PinTab_MenuPin));
internal static string PinTab_MenuUnpin => Get(nameof(PinTab_MenuUnpin));
internal static string PinTab_MenuPromote => Get(nameof(PinTab_MenuPromote));
internal static string PinTab_PromoteTooltip => Get(nameof(PinTab_PromoteTooltip));
internal static string PinTab_LimitReached => Get(nameof(PinTab_LimitReached));
internal static string PinTab_PinnedTooltip => Get(nameof(PinTab_PinnedTooltip));
internal static string PinTab_PinTooltip => Get(nameof(PinTab_PinTooltip));
internal static string PinTab_SectionHeader => Get(nameof(PinTab_SectionHeader));
internal static string Settings_ThemeAndLayout_SidebarWidth_Name => Get(nameof(Settings_ThemeAndLayout_SidebarWidth_Name));
internal static string Settings_ThemeAndLayout_SidebarWidth_Description => Get(nameof(Settings_ThemeAndLayout_SidebarWidth_Description));
// Hellion Chat — Auto-Tell-Tabs Chat settings tab // Hellion Chat — Auto-Tell-Tabs Chat settings tab
internal static string ChatLog_AutoTellTabs_Section_Title => Get(nameof(ChatLog_AutoTellTabs_Section_Title)); internal static string ChatLog_AutoTellTabs_Section_Title => Get(nameof(ChatLog_AutoTellTabs_Section_Title));
@@ -380,8 +368,6 @@ internal class HellionStrings
internal static string Settings_Integrations_Honorific_Status_Incompatible => Get(nameof(Settings_Integrations_Honorific_Status_Incompatible)); internal static string Settings_Integrations_Honorific_Status_Incompatible => Get(nameof(Settings_Integrations_Honorific_Status_Incompatible));
internal static string Settings_Integrations_Honorific_Toggle => Get(nameof(Settings_Integrations_Honorific_Toggle)); internal static string Settings_Integrations_Honorific_Toggle => Get(nameof(Settings_Integrations_Honorific_Toggle));
internal static string Settings_Integrations_Honorific_ToggleHint => Get(nameof(Settings_Integrations_Honorific_ToggleHint)); internal static string Settings_Integrations_Honorific_ToggleHint => Get(nameof(Settings_Integrations_Honorific_ToggleHint));
internal static string Settings_Integrations_Honorific_Glow_Toggle => Get(nameof(Settings_Integrations_Honorific_Glow_Toggle));
internal static string Settings_Integrations_Honorific_Glow_Hint => Get(nameof(Settings_Integrations_Honorific_Glow_Hint));
internal static string Settings_Integrations_Honorific_LinkRepo => Get(nameof(Settings_Integrations_Honorific_LinkRepo)); internal static string Settings_Integrations_Honorific_LinkRepo => Get(nameof(Settings_Integrations_Honorific_LinkRepo));
internal static string Settings_Integrations_Honorific_LinkAuthor => Get(nameof(Settings_Integrations_Honorific_LinkAuthor)); internal static string Settings_Integrations_Honorific_LinkAuthor => Get(nameof(Settings_Integrations_Honorific_LinkAuthor));
internal static string Settings_Integrations_ComingSoon_SectionHeader => Get(nameof(Settings_Integrations_ComingSoon_SectionHeader)); internal static string Settings_Integrations_ComingSoon_SectionHeader => Get(nameof(Settings_Integrations_ComingSoon_SectionHeader));
@@ -402,9 +388,4 @@ internal class HellionStrings
// Hellion Chat — v1.3.0 Honorific title slot tooltip // Hellion Chat — v1.3.0 Honorific title slot tooltip
internal static string ChatHeader_HonorificTitle_Tooltip => Get(nameof(ChatHeader_HonorificTitle_Tooltip)); internal static string ChatHeader_HonorificTitle_Tooltip => Get(nameof(ChatHeader_HonorificTitle_Tooltip));
// Hellion Chat — v1.4.8 DbViewer full-text search toggle
internal static string DbViewer_FullTextToggle => Get(nameof(DbViewer_FullTextToggle));
internal static string DbViewer_FullTextToggle_Hint_Indexing => Get(nameof(DbViewer_FullTextToggle_Hint_Indexing));
internal static string DbViewer_FullTextToggle_Hint_PhraseMode => Get(nameof(DbViewer_FullTextToggle_Hint_PhraseMode));
} }
+11 -62
View File
@@ -222,12 +222,6 @@
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Wizard erneut zeigen</value> <value>Wizard erneut zeigen</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Später — Defaults behalten</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Schließt den Wizard ohne Profil-Auswahl. Die Plugin-Defaults bleiben aktiv und der Wizard erscheint beim nächsten Plugin-Reload erneut.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (DSGVO Art. 15 — Auskunftsrecht)</value> <value>Export (DSGVO Art. 15 — Auskunftsrecht)</value>
</data> </data>
@@ -383,36 +377,6 @@
<data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve">
<value>Als begrüßt markieren.</value> <value>Als begrüßt markieren.</value>
</data> </data>
<data name="PinTab_MenuPin" xml:space="preserve">
<value>Tab anpinnen</value>
</data>
<data name="PinTab_MenuUnpin" xml:space="preserve">
<value>Tab lösen</value>
</data>
<data name="PinTab_MenuPromote" xml:space="preserve">
<value>In Standard-Tab umwandeln</value>
</data>
<data name="PinTab_PromoteTooltip" xml:space="preserve">
<value>Wandelt den TempTell in einen regulären Tab um. Die Tell-Bindung an die Person geht verloren, der Tab fängt dann Nachrichten anhand der Channel-Filter ein. Für „Tab überlebt Relog" stattdessen „Tab anpinnen" wählen.</value>
</data>
<data name="PinTab_LimitReached" xml:space="preserve">
<value>Maximal {0} angepinnte Tell-Tabs erreicht. Erst einen lösen oder dauerhaft behalten.</value>
</data>
<data name="PinTab_PinnedTooltip" xml:space="preserve">
<value>Angepinnt — überlebt Relog.</value>
</data>
<data name="PinTab_PinTooltip" xml:space="preserve">
<value>Angepinnte Tabs überleben Relog und behalten die Bindung an die Tell-Person.</value>
</data>
<data name="PinTab_SectionHeader" xml:space="preserve">
<value>Angepinnt</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Name" xml:space="preserve">
<value>Sidebar-Breite</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Description" xml:space="preserve">
<value>Breite der Tab-Sidebar in Pixeln. Default (44 px) ist Icon-only; breiter machen damit Sektion-Header wie „Aktive Tells (3)" nicht abgeschnitten werden.</value>
</data>
<!-- Hellion Chat — Auto-Tell-Tabs (Chat-Einstellungstab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Chat-Einstellungstab) -->
<data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve">
@@ -428,7 +392,7 @@
<value>Maximale Anzahl der Auto-Tell-Tabs</value> <value>Maximale Anzahl der Auto-Tell-Tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve">
<value>Beim Erreichen werden begrüßte Tabs mit der ältesten Aktivität zuerst geschlossen. Änderungen greifen beim nächsten /tell. Diese Grenze gilt nur für den automatisch verwalteten Pool. Angepinnte Tell-Tabs (Rechtsklick → Tab anpinnen) leben in einem separaten Pool von bis zu 5 Tabs und überleben Relog.</value> <value>Beim Erreichen werden begrüßte Tabs mit der ältesten Aktivität zuerst geschlossen. Änderungen greifen beim nächsten /tell.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve">
<value>Kompakte Anzeige</value> <value>Kompakte Anzeige</value>
@@ -675,7 +639,7 @@
<value>Allgemein</value> <value>Allgemein</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Sprache, Eingabe, Audio und Performance.</value> <value>Plugin-globale Einstellungen — Sprache, Eingabe, Audio, Performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Erscheinungsbild</value> <value>Erscheinungsbild</value>
@@ -693,25 +657,25 @@
<value>Fenster</value> <value>Fenster</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>Wann das Fenster sichtbar ist und ob es sich bewegen lässt.</value> <value>Verhalten des Fensters — wann es da ist, ob es bewegt werden kann.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>Tells, Vorschau, Nachrichten-Verhalten und Emotes.</value> <value>Wie Nachrichten angezeigt werden — Tells, Vorschau, Verhalten, Emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Eigene Chat-Tabs anlegen und konfigurieren.</value> <value>Tab-Verwaltung — eigene Chat-Tabs anlegen und konfigurieren.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Datenschutz</value> <value>Datenschutz</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>Privacy-Filter pro Channel und was gespeichert werden darf.</value> <value>Was darf gespeichert werden — Privacy-Filter pro Channel.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Datenbank</value> <value>Datenbank</value>
@@ -723,7 +687,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>Version, Mission, Lizenz und Changelog.</value> <value>Über das Plugin — Version, Mission, Lizenz, Changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -768,25 +732,25 @@
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>Theme, Fenster-Rahmen und Zeitstempel-Style.</value> <value>Wie das Fenster aussieht — Theme, Rahmen, Zeitstempel-Style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Schriften &amp; Farben</value> <value>Schriften &amp; Farben</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Schriftart, Schriftgröße und Chat-Farben pro Channel.</value> <value>Lesbarkeit — Schriftart, Schriftgröße, Chat-Farben pro Channel.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Daten-Verwaltung</value> <value>Daten-Verwaltung</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>Aufbewahrung, Aufräumen, Export und Datenbank-Statistiken.</value> <value>Was passiert mit gespeicherten Daten — Aufbewahrung, Aufräumen, Export, DB-Stats.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrationen</value> <value>Integrationen</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Kommende Integrationen in der Vorschau.</value> <value>Andere Dalamud-Plugins, mit denen HellionChat zusammenarbeitet. Auto-detected, mit Vorschau auf kommende Integrationen.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
@@ -857,12 +821,6 @@
<data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve"> <data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve">
<value>Zeigt deinen Custom-Titel aus Honorific im Header über dem Chat-Log an, in der von dir gewählten Farbe.</value> <value>Zeigt deinen Custom-Titel aus Honorific im Header über dem Chat-Log an, in der von dir gewählten Farbe.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Glow_Toggle" xml:space="preserve">
<value>Glow-Outline rendern (Honorific)</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Hint" xml:space="preserve">
<value>Kann die Framerate auf schwacher Hardware drücken. Rendert die Glow-Outline für Honorific-Titel, die sie nutzen. Gradient-Animation wird noch nicht unterstützt und wird stattdessen als Primärfarbe gezeichnet.</value>
</data>
<data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve"> <data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve">
<value>Honorific auf GitHub</value> <value>Honorific auf GitHub</value>
</data> </data>
@@ -917,13 +875,4 @@
<data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve"> <data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve">
<value>Custom-Titel von Honorific</value> <value>Custom-Titel von Honorific</value>
</data> </data>
<data name="DbViewer_FullTextToggle" xml:space="preserve">
<value>Volltext-Suche</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_Indexing" xml:space="preserve">
<value>Der Volltext-Index wird noch gebaut. Die lokale Suche bleibt verfügbar.</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_PhraseMode" xml:space="preserve">
<value>Sucht nach der exakten Wortfolge. Mehrere Wörter werden nur gefunden, wenn sie zusammen und in dieser Reihenfolge stehen. Wer rohe FTS5-MATCH-Syntax nutzen will, setzt eigene Anführungszeichen um den Suchbegriff.</value>
</data>
</root> </root>
+164 -215
View File
@@ -19,28 +19,28 @@
<value>Enable privacy filter</value> <value>Enable privacy filter</value>
</data> </data>
<data name="Privacy_FilterEnabled_Description" xml:space="preserve"> <data name="Privacy_FilterEnabled_Description" xml:space="preserve">
<value>When enabled, only messages from allowed channels are written to the database. When disabled, the default behaviour applies — everything except battle logs is stored.</value> <value>When enabled, only messages from whitelisted channels are persisted to the database. Disabling restores the original behavior (everything except battle messages is stored).</value>
</data> </data>
<data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve"> <data name="Privacy_FilterEnabled_StorageOnly_Help" xml:space="preserve">
<value>The filter only controls what is written to the local database. The chat log still shows every message live; excluded channels are simply no longer stored. If you also want to remove channels from the visible display, use the normal chat-tab filters in the game.</value> <value>The filter only controls what is written to the local database. The chat log itself keeps showing every message live, disallowed channels just stop being saved. Use the channel hide options in your in-game chat tabs if you want to remove channels from the visible chat.</value>
</data> </data>
<data name="Privacy_Filter_Tree_Heading" xml:space="preserve"> <data name="Privacy_Filter_Tree_Heading" xml:space="preserve">
<value>Privacy filter and whitelist</value> <value>Privacy filter and whitelist</value>
</data> </data>
<data name="Privacy_Whitelist_Help" xml:space="preserve"> <data name="Privacy_Whitelist_Help" xml:space="preserve">
<value>Choose which channels are saved to the local database. Default follows data minimisation: only your own conversations. Use the buttons below to apply a preset.</value> <value>Pick which channels are stored in the local database. Privacy-First default: only your own conversations. Use the buttons below to apply a preset.</value>
</data> </data>
<data name="Privacy_Preset_PrivacyFirst" xml:space="preserve"> <data name="Privacy_Preset_PrivacyFirst" xml:space="preserve">
<value>Data minimisation (recommended)</value> <value>Privacy-First (recommended)</value>
</data> </data>
<data name="Privacy_Preset_ClearAll" xml:space="preserve"> <data name="Privacy_Preset_ClearAll" xml:space="preserve">
<value>Deselect all</value> <value>Clear all</value>
</data> </data>
<data name="Privacy_Preset_SelectAll" xml:space="preserve"> <data name="Privacy_Preset_SelectAll" xml:space="preserve">
<value>Select all</value> <value>Select all</value>
</data> </data>
<data name="Privacy_Group_DirectMessages" xml:space="preserve"> <data name="Privacy_Group_DirectMessages" xml:space="preserve">
<value>Direct messages</value> <value>Direct Messages</value>
</data> </data>
<data name="Privacy_Group_PartyAlliance" xml:space="preserve"> <data name="Privacy_Group_PartyAlliance" xml:space="preserve">
<value>Party &amp; Alliance</value> <value>Party &amp; Alliance</value>
@@ -55,52 +55,52 @@
<value>Cross-World Linkshells</value> <value>Cross-World Linkshells</value>
</data> </data>
<data name="Privacy_Group_ExtraChat" xml:space="preserve"> <data name="Privacy_Group_ExtraChat" xml:space="preserve">
<value>ExtraChat (encrypted)</value> <value>ExtraChat (Encrypted)</value>
</data> </data>
<data name="Privacy_Group_PublicChat" xml:space="preserve"> <data name="Privacy_Group_PublicChat" xml:space="preserve">
<value>Public chat (third-party data)</value> <value>Public Chat (third-party data)</value>
</data> </data>
<data name="Privacy_Group_SystemLogs" xml:space="preserve"> <data name="Privacy_Group_SystemLogs" xml:space="preserve">
<value>System &amp; game logs</value> <value>System &amp; Game Logs</value>
</data> </data>
<data name="Privacy_PersistUnknown_Name" xml:space="preserve"> <data name="Privacy_PersistUnknown_Name" xml:space="preserve">
<value>Save unknown channel types</value> <value>Persist unknown channel types</value>
</data> </data>
<data name="Privacy_PersistUnknown_Description" xml:space="preserve"> <data name="Privacy_PersistUnknown_Description" xml:space="preserve">
<value>Safety net for ChatTypes added by future FFXIV patches that the plugin does not yet know about. Default is OFF (data minimisation). Enable if you want future channels to be fully logged as well.</value> <value>Failsafe for ChatTypes added by future FFXIV patches that this plugin does not yet know about. Default OFF (Privacy-First). Turn ON if you want a complete log including future channels.</value>
</data> </data>
<data name="Cleanup_Heading" xml:space="preserve"> <data name="Cleanup_Heading" xml:space="preserve">
<value>Apply filter to existing database</value> <value>Apply filter to existing database</value>
</data> </data>
<data name="Cleanup_Help_Intro" xml:space="preserve"> <data name="Cleanup_Help_Intro" xml:space="preserve">
<value>The privacy filter only affects new messages. The cleanup below lets you retroactively remove already-stored messages that do not match your saved whitelist.</value> <value>The privacy filter only applies to new messages. Use the cleanup below to retroactively remove already-stored messages that don't match your saved whitelist.</value>
</data> </data>
<data name="Cleanup_Help_SavedNote" xml:space="preserve"> <data name="Cleanup_Help_SavedNote" xml:space="preserve">
<value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved changes above. Click Save first if you want your current changes to be applied.</value> <value>Cleanup uses your SAVED whitelist (Plugin.Config), not unsaved edits above. Click Save first if you want to apply your current edits.</value>
</data> </data>
<data name="Retention_Help_SavedNote" xml:space="preserve"> <data name="Retention_Help_SavedNote" xml:space="preserve">
<value>The manual run uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current changes.</value> <value>The manual sweep uses your SAVED retention policy, not the slider values above. Click Save first if you want the run to apply your current edits.</value>
</data> </data>
<data name="Cleanup_Preview_Stale" xml:space="preserve"> <data name="Cleanup_Preview_Stale" xml:space="preserve">
<value>Preview is stale — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value> <value>Preview is out of date — your whitelist has changed since the last refresh. Click Refresh to recalculate.</value>
</data> </data>
<data name="Cleanup_RefreshPreview" xml:space="preserve"> <data name="Cleanup_RefreshPreview" xml:space="preserve">
<value>Refresh preview</value> <value>Refresh preview</value>
</data> </data>
<data name="Cleanup_NoPreview" xml:space="preserve"> <data name="Cleanup_NoPreview" xml:space="preserve">
<value>No preview yet. Click Refresh to calculate the impact.</value> <value>No preview yet. Click Refresh to compute the impact.</value>
</data> </data>
<data name="Cleanup_TotalStored" xml:space="preserve"> <data name="Cleanup_TotalStored" xml:space="preserve">
<value>Total stored messages: {0:N0}</value> <value>Total stored messages: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillKeep" xml:space="preserve"> <data name="Cleanup_WillKeep" xml:space="preserve">
<value>Keep: {0:N0}</value> <value>Will keep: {0:N0}</value>
</data> </data>
<data name="Cleanup_WillDelete" xml:space="preserve"> <data name="Cleanup_WillDelete" xml:space="preserve">
<value>Delete: {0:N0}</value> <value>Will delete: {0:N0}</value>
</data> </data>
<data name="Cleanup_Breakdown" xml:space="preserve"> <data name="Cleanup_Breakdown" xml:space="preserve">
<value>Breakdown by channel</value> <value>Per-channel breakdown</value>
</data> </data>
<data name="Cleanup_Marker_Keep" xml:space="preserve"> <data name="Cleanup_Marker_Keep" xml:space="preserve">
<value>[KEEP] </value> <value>[KEEP] </value>
@@ -112,46 +112,46 @@
<value>Apply current filter to database</value> <value>Apply current filter to database</value>
</data> </data>
<data name="Cleanup_Apply_Tooltip" xml:space="preserve"> <data name="Cleanup_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: Permanently deletes {0:N0} messages and runs VACUUM afterwards. Cannot be undone.</value> <value>Ctrl+Shift: Hard-deletes {0:N0} messages, then runs VACUUM. Cannot be undone.</value>
</data> </data>
<data name="Cleanup_Running" xml:space="preserve"> <data name="Cleanup_Running" xml:space="preserve">
<value>Cleanup running in the background…</value> <value>Cleanup running in background…</value>
</data> </data>
<data name="Cleanup_PreviewError" xml:space="preserve"> <data name="Cleanup_PreviewError" xml:space="preserve">
<value>Preview could not be calculated, see /xllog</value> <value>Failed to compute cleanup preview, see /xllog</value>
</data> </data>
<data name="Cleanup_Success" xml:space="preserve"> <data name="Cleanup_Success" xml:space="preserve">
<value>Cleanup complete, {0:N0} messages removed.</value> <value>Privacy cleanup complete: {0:N0} messages removed.</value>
</data> </data>
<data name="Cleanup_Error" xml:space="preserve"> <data name="Cleanup_Error" xml:space="preserve">
<value>Cleanup failed, see /xllog</value> <value>Privacy cleanup failed, see /xllog</value>
</data> </data>
<data name="Retention_Heading" xml:space="preserve"> <data name="Retention_Heading" xml:space="preserve">
<value>Message retention</value> <value>Message retention</value>
</data> </data>
<data name="Retention_Enabled_Name" xml:space="preserve"> <data name="Retention_Enabled_Name" xml:space="preserve">
<value>Automatically delete messages past their channel retention window</value> <value>Auto-delete messages after a per-channel retention window</value>
</data> </data>
<data name="Retention_Enabled_Description" xml:space="preserve"> <data name="Retention_Enabled_Description" xml:space="preserve">
<value>When enabled, messages older than the configured window are deleted on each plugin start (at most once every 24 hours). Default is OFF — the plugin never deletes anything without your explicit consent.</value> <value>When enabled, messages older than the configured window are deleted on every plugin start (at most once per 24 hours). Off by default. The plugin never deletes history without your explicit consent.</value>
</data> </data>
<data name="Retention_Default_Label" xml:space="preserve"> <data name="Retention_Default_Label" xml:space="preserve">
<value>Default retention (days, 0 = never)</value> <value>Default retention (days, 0 = never)</value>
</data> </data>
<data name="Retention_Default_Help" xml:space="preserve"> <data name="Retention_Default_Help" xml:space="preserve">
<value>Applies to channels that have no individual override below.</value> <value>Applies to channels without an explicit override below.</value>
</data> </data>
<data name="Retention_Reset_Spec" xml:space="preserve"> <data name="Retention_Reset_Spec" xml:space="preserve">
<value>Reset overrides to spec defaults</value> <value>Reset overrides to spec defaults</value>
</data> </data>
<data name="Retention_Clear_Overrides" xml:space="preserve"> <data name="Retention_Clear_Overrides" xml:space="preserve">
<value>Remove all overrides</value> <value>Clear all overrides</value>
</data> </data>
<data name="Retention_Tree_Heading" xml:space="preserve"> <data name="Retention_Tree_Heading" xml:space="preserve">
<value>Retention per channel</value> <value>Per-channel retention overrides</value>
</data> </data>
<data name="Retention_Tag_Override" xml:space="preserve"> <data name="Retention_Tag_Override" xml:space="preserve">
<value>[custom]</value> <value>[override]</value>
</data> </data>
<data name="Retention_Tag_Spec" xml:space="preserve"> <data name="Retention_Tag_Spec" xml:space="preserve">
<value>[spec]</value> <value>[spec]</value>
@@ -163,13 +163,13 @@
<value>reset</value> <value>reset</value>
</data> </data>
<data name="Retention_Apply_Label" xml:space="preserve"> <data name="Retention_Apply_Label" xml:space="preserve">
<value>Apply retention now</value> <value>Apply retention policy now</value>
</data> </data>
<data name="Retention_Apply_Tooltip" xml:space="preserve"> <data name="Retention_Apply_Tooltip" xml:space="preserve">
<value>Ctrl+Shift: Runs the retention cleanup immediately using the SAVED policy. Save your changes first.</value> <value>Ctrl+Shift: runs the retention sweep immediately using the SAVED policy. Save your changes first.</value>
</data> </data>
<data name="Retention_Running" xml:space="preserve"> <data name="Retention_Running" xml:space="preserve">
<value>Retention cleanup running in the background…</value> <value>Retention sweep running in background…</value>
</data> </data>
<data name="Retention_LastRun_Never" xml:space="preserve"> <data name="Retention_LastRun_Never" xml:space="preserve">
<value>Last run: never</value> <value>Last run: never</value>
@@ -178,73 +178,67 @@
<value>Last run: {0:yyyy-MM-dd HH:mm}</value> <value>Last run: {0:yyyy-MM-dd HH:mm}</value>
</data> </data>
<data name="Retention_Success" xml:space="preserve"> <data name="Retention_Success" xml:space="preserve">
<value>Retention cleanup complete, {0:N0} messages removed.</value> <value>Retention sweep complete: {0:N0} messages removed.</value>
</data> </data>
<data name="Retention_Error" xml:space="preserve"> <data name="Retention_Error" xml:space="preserve">
<value>Retention cleanup failed, see /xllog</value> <value>Retention sweep failed, see /xllog</value>
</data> </data>
<data name="Wizard_Title" xml:space="preserve"> <data name="Wizard_Title" xml:space="preserve">
<value>Hellion Chat — Welcome</value> <value>Hellion Chat — Welcome</value>
</data> </data>
<data name="Wizard_Intro" xml:space="preserve"> <data name="Wizard_Intro" xml:space="preserve">
<value>Choose a starting profile. You can adjust everything later under Settings → Privacy.</value> <value>Pick a starting profile. You can change anything later under Settings → Privacy.</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Heading" xml:space="preserve">
<value>Data minimisation (recommended)</value> <value>Privacy-First (recommended)</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Description" xml:space="preserve">
<value>Only your own conversations are stored: tells, party, FC, linkshells, cross-world linkshells, alliance, and ExtraChat. Public chat, NPC dialogues, and system spam are discarded at the storage level. Retention follows spec defaults (tells 365 days, own conversation channels 90 days).</value> <value>Only your own conversations are stored: Tells, Party, FC, Linkshells, Cross-World Linkshells, Alliance and ExtraChat. Public chat, NPC dialogue and system spam are dropped at the storage layer. Retention follows the spec defaults (Tells 365 days, own-conversation channels 90 days).</value>
</data> </data>
<data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve"> <data name="Wizard_Profile_PrivacyFirst_Apply" xml:space="preserve">
<value>Apply data minimisation</value> <value>Use Privacy-First</value>
</data> </data>
<data name="Wizard_Profile_Casual_Heading" xml:space="preserve"> <data name="Wizard_Profile_Casual_Heading" xml:space="preserve">
<value>Casual</value> <value>Casual</value>
</data> </data>
<data name="Wizard_Profile_Casual_Description" xml:space="preserve"> <data name="Wizard_Profile_Casual_Description" xml:space="preserve">
<value>Data minimisation plus a 24-hour window for public chat (say, shout, yell, both emote types, novice network). For RP players who want to re-read the last scene without keeping public chat forever.</value> <value>Privacy-First plus a 24-hour window for public chat (Say, Shout, Yell, both emote types, Novice Network). For RP players who want to look up the last scene without keeping public chat forever.</value>
</data> </data>
<data name="Wizard_Profile_Casual_Apply" xml:space="preserve"> <data name="Wizard_Profile_Casual_Apply" xml:space="preserve">
<value>Apply casual</value> <value>Use Casual</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Heading" xml:space="preserve">
<value>Full history</value> <value>Full History</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Description" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Description" xml:space="preserve">
<value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behaviour). Retention is OFF, so the history grows indefinitely.</value> <value>Disables the privacy filter entirely. Stores everything except battle logs (the original full-history behavior). Retention is OFF, history grows forever.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_GdprWarning" xml:space="preserve">
<value>GDPR notice: Storing third-party messages (say/shout/yell from other players, NPC dialogues with player names, etc.) indefinitely may exceed the exemption for purely personal or household activities (Art. 2(2)(c)). Only use this profile if you have a clear reason to keep the full archive.</value> <value>GDPR notice: storing third-party messages (Say/Shout/Yell of strangers, NPC dialogue with player names, etc.) for an unlimited time may exceed the personal/household exemption (Art. 2(2)(c)). Use this profile only if you have a clear reason to keep the full archive.</value>
</data> </data>
<data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve"> <data name="Wizard_Profile_FullHistory_Apply" xml:space="preserve">
<value>Apply full history</value> <value>Use Full History</value>
</data> </data>
<data name="Wizard_Reopen_Button" xml:space="preserve"> <data name="Wizard_Reopen_Button" xml:space="preserve">
<value>Show wizard again</value> <value>Show wizard again</value>
</data> </data>
<data name="Wizard_Cancel_Label" xml:space="preserve">
<value>Later — keep defaults</value>
</data>
<data name="Wizard_Cancel_Tooltip" xml:space="preserve">
<value>Close the wizard without selecting a profile. The plugin defaults stay active and the wizard returns on next plugin load.</value>
</data>
<data name="Export_Heading" xml:space="preserve"> <data name="Export_Heading" xml:space="preserve">
<value>Export (GDPR Art. 15 — Right of access)</value> <value>Export (GDPR Art. 15 — right of access)</value>
</data> </data>
<data name="Export_Help" xml:space="preserve"> <data name="Export_Help" xml:space="preserve">
<value>Export stored messages as Markdown, JSON, or CSV. This lets you fulfil an access request from a person whose messages you have stored, or take your own history with you.</value> <value>Export stored messages to Markdown, JSON or CSV. Use this to fulfil a request for access from someone whose messages you have, or to take your own history with you.</value>
</data> </data>
<data name="Export_Range_Label" xml:space="preserve"> <data name="Export_Range_Label" xml:space="preserve">
<value>Last X days (0 = no time limit)</value> <value>Last X days (0 = all time)</value>
</data> </data>
<data name="Export_Sender_Label" xml:space="preserve"> <data name="Export_Sender_Label" xml:space="preserve">
<value>Sender contains (optional, case-insensitive)</value> <value>Sender contains (optional, case-insensitive)</value>
</data> </data>
<data name="Export_Channels_Heading" xml:space="preserve"> <data name="Export_Channels_Heading" xml:space="preserve">
<value>Restrict to channels</value> <value>Limit to channels</value>
</data> </data>
<data name="Export_Channels_AllOff" xml:space="preserve"> <data name="Export_Channels_AllOff" xml:space="preserve">
<value>(nothing selected = all stored channels)</value> <value>(none selected = all stored channels)</value>
</data> </data>
<data name="Export_Format_Label" xml:space="preserve"> <data name="Export_Format_Label" xml:space="preserve">
<value>Format</value> <value>Format</value>
@@ -265,41 +259,41 @@
<value>Save export</value> <value>Save export</value>
</data> </data>
<data name="Export_Running" xml:space="preserve"> <data name="Export_Running" xml:space="preserve">
<value>Export running in the background…</value> <value>Export running in background…</value>
</data> </data>
<data name="Export_Success" xml:space="preserve"> <data name="Export_Success" xml:space="preserve">
<value>Export complete, {0:N0} messages written to {1}</value> <value>Export complete: {0:N0} messages written to {1}</value>
</data> </data>
<data name="Export_Empty" xml:space="preserve"> <data name="Export_Empty" xml:space="preserve">
<value>Export complete, no message matched the filter.</value> <value>Export complete: no messages matched the filter.</value>
</data> </data>
<data name="Export_Error" xml:space="preserve"> <data name="Export_Error" xml:space="preserve">
<value>Export failed, see /xllog</value> <value>Export failed, see /xllog</value>
</data> </data>
<data name="Theme_Enabled_Name" xml:space="preserve"> <data name="Theme_Enabled_Name" xml:space="preserve">
<value>Use Hellion theme for all plugin windows</value> <value>Use the Hellion theme across all plugin windows</value>
</data> </data>
<data name="Theme_Enabled_Description" xml:space="preserve"> <data name="Theme_Enabled_Description" xml:space="preserve">
<value>Hellion Online Media palette of Arctic Cyan and Ember Orange, applied to the chat window, settings, viewer, and wizard. Disable to use the default Dalamud appearance.</value> <value>Hellion Online Media palette of Arctic Cyan plus Ember Orange, applied across the chat log, settings, viewers and the wizard. Disable to fall back to the default Dalamud look.</value>
</data> </data>
<data name="Theme_WindowOpacity_Label" xml:space="preserve"> <data name="Theme_WindowOpacity_Label" xml:space="preserve">
<value>Window opacity</value> <value>Window opacity</value>
</data> </data>
<data name="Theme_WindowOpacity_Help" xml:space="preserve"> <data name="Theme_WindowOpacity_Help" xml:space="preserve">
<value>How opaque the plugin windows are. Lower values let the game show through; form fields and dialogs stay fully opaque and readable on top.</value> <value>How opaque the plugin panes are. Lower values let the game shine through; form fields and dialogs stay opaque on top so they remain readable.</value>
</data> </data>
<data name="Theme_UseHellionFont_Name" xml:space="preserve"> <data name="Theme_UseHellionFont_Name" xml:space="preserve">
<value>Use bundled Hellion font (Exo 2)</value> <value>Use the bundled Hellion font (Exo 2)</value>
</data> </data>
<data name="Theme_UseHellionFont_Description" xml:space="preserve"> <data name="Theme_UseHellionFont_Description" xml:space="preserve">
<value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1), which ships with the plugin. Disable to fall back to the font selected under Settings → Font.</value> <value>Renders chat and UI in Exo 2 (SIL Open Font License 1.1) which ships with the plugin. Disable to fall back to whatever font you picked under Settings → Fonts.</value>
</data> </data>
<data name="About_Maintainer_Heading" xml:space="preserve"> <data name="About_Maintainer_Heading" xml:space="preserve">
<value>Maintainer</value> <value>Maintainer</value>
</data> </data>
<data name="About_Maintainer_Body" xml:space="preserve"> <data name="About_Maintainer_Body" xml:space="preserve">
<value>I maintain Hellion Chat through Hellion Online Media. Contact details for licensing, legal, or business inquiries are on the website.</value> <value>I maintain Hellion Chat through Hellion Online Media. The website has the contact details for licensing, legal or business questions.</value>
</data> </data>
<data name="About_Maintainer_Website_Label" xml:space="preserve"> <data name="About_Maintainer_Website_Label" xml:space="preserve">
<value>Website:</value> <value>Website:</value>
@@ -309,172 +303,142 @@
<value>Why this fork exists</value> <value>Why this fork exists</value>
</data> </data>
<data name="About_Mission_P1" xml:space="preserve"> <data name="About_Mission_P1" xml:space="preserve">
<value>Hellion Chat is not meant to replace Chat 2. Chat 2 delivers a complete chat experience with a full history available for filtering, searching, and replay. That default is the right choice for most users. This fork takes a different approach: a smaller default footprint, with additional controls for users who prefer to keep less of other people's chat on disk.</value> <value>Hellion Chat is not trying to replace Chat 2. Chat 2 ships a complete chat experience with full history available for filtering, search and replay. That default is the right one for most users. This fork takes a different stance: a smaller default footprint, with extra knobs for users who want to keep less third-party chat on disk.</value>
</data> </data>
<data name="About_Mission_P2" xml:space="preserve"> <data name="About_Mission_P2" xml:space="preserve">
<value>The desire for this narrower default was personal. After two years with Chat 2, my database had grown to over two million messages, the majority of them /say, /shout, and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full history useful, and most users are happy to keep it. My own preference was for a smaller default. So I built this fork.</value> <value>The reason I wanted that narrower default was personal. After two years on Chat 2 my database had grown past two million messages, most of them /say, /shout and /yell from strangers in Limsa. That data is exactly what makes Chat 2's full-history view powerful and most users are happy to keep it. For my own taste I wanted a smaller default. So I built this fork.</value>
</data> </data>
<data name="About_Mission_P3" xml:space="preserve"> <data name="About_Mission_P3" xml:space="preserve">
<value>I am not targeting a large audience, and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the original. Infi, Anna, or anyone else is welcome to look around, borrow ideas, ask questions, or simply ignore the project. All three are fine by me.</value> <value>I am not chasing a big audience and the fork is not in competition with Chat 2. The code is open under the same EUPL-1.2 licence as the upstream plugin. Infi, Anna or anyone else are welcome to read it, borrow ideas, ask questions, or ignore the project. All three are fine by me.</value>
</data> </data>
<data name="About_BuiltOn_Heading" xml:space="preserve"> <data name="About_BuiltOn_Heading" xml:space="preserve">
<value>Built on Chat 2</value> <value>Built on Chat 2</value>
</data> </data>
<data name="About_BuiltOn_P1" xml:space="preserve"> <data name="About_BuiltOn_P1" xml:space="preserve">
<value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat-replacement window, IPC integration, render engine, and the entire storage core all come from the original.</value> <value>Hellion Chat is a fork of Chat 2 by Infi and Anna (ascclemens). The chat replacement window, the IPC integration, the rendering engine and the entire storage core come from upstream Chat 2.</value>
</data> </data>
<data name="About_BuiltOn_P2" xml:space="preserve"> <data name="About_BuiltOn_P2" xml:space="preserve">
<value>The web interface is the only major piece I removed. It is built for remote access to the chat from a second device a different focus from the smaller default footprint this fork pursues. Adapting it to these defaults would have required significant rework, so removing it was the clean path for this particular fork.</value> <value>The webinterface is the only major piece I removed. It is built for remote access to chat from a second device, which is a different focus than the smaller default footprint this fork is built around. Aligning it with these defaults would have meant a substantial rebuild, so removing it was the cleaner path for this particular fork.</value>
</data> </data>
<data name="About_BuiltOn_Upstream_Label" xml:space="preserve"> <data name="About_BuiltOn_Upstream_Label" xml:space="preserve">
<value>Upstream repository:</value> <value>Upstream repository:</value>
</data> </data>
<data name="About_License_Heading" xml:space="preserve"> <data name="About_License_Heading" xml:space="preserve">
<value>Licence</value> <value>License</value>
</data> </data>
<data name="About_License_P1" xml:space="preserve"> <data name="About_License_P1" xml:space="preserve">
<value>Hellion Chat and Chat 2 are both released under the European Union Public Licence v1.2 (EUPL-1.2).</value> <value>Hellion Chat and Chat 2 both ship under the European Union Public Licence v1.2 (EUPL-1.2).</value>
</data> </data>
<data name="About_License_P2" xml:space="preserve"> <data name="About_License_P2" xml:space="preserve">
<value>© 2023 to 2026, the Chat 2 authors (Infi, Anna, and upstream contributors).</value> <value>© 2023 to 2026, the Chat 2 authors (Infi, Anna and the upstream contributors).</value>
</data> </data>
<data name="About_License_P3" xml:space="preserve"> <data name="About_License_P3" xml:space="preserve">
<value>© 2026 Hellion Online Media for the extensions in this fork.</value> <value>© 2026 Hellion Online Media for the additions made in this fork.</value>
</data> </data>
<data name="About_SE_Heading" xml:space="preserve"> <data name="About_SE_Heading" xml:space="preserve">
<value>FINAL FANTASY XIV notice</value> <value>FINAL FANTASY XIV disclaimer</value>
</data> </data>
<data name="About_SE_P1" xml:space="preserve"> <data name="About_SE_P1" xml:space="preserve">
<value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value> <value>FINAL FANTASY XIV © SQUARE ENIX CO., LTD. All rights reserved.</value>
</data> </data>
<data name="About_SE_P2" xml:space="preserve"> <data name="About_SE_P2" xml:space="preserve">
<value>Hellion Chat is an unofficial fan plugin. It is not affiliated with Square Enix and is neither endorsed, sponsored, nor approved by them.</value> <value>Hellion Chat is an unofficial, fan-made plugin. It has no affiliation with Square Enix and is not endorsed, sponsored or approved by them.</value>
</data> </data>
<data name="About_Localization_Heading" xml:space="preserve"> <data name="About_Localization_Heading" xml:space="preserve">
<value>Localisation</value> <value>Localization</value>
</data> </data>
<data name="About_Localization_P1" xml:space="preserve"> <data name="About_Localization_P1" xml:space="preserve">
<value>The translations of the Hellion-specific strings were done by me. No additional languages are currently available.</value> <value>The German translations of the Hellion-specific strings come from me. Other languages are not provided yet.</value>
</data> </data>
<data name="About_Localization_P2" xml:space="preserve"> <data name="About_Localization_P2" xml:space="preserve">
<value>The translator list below belongs to the Chat 2 strings on Crowdin. These volunteers translated Chat 2, not the Hellion extensions.</value> <value>The translator list below covers the upstream Chat 2 strings on Crowdin. Those volunteers translated Chat 2, not the Hellion additions.</value>
</data> </data>
<data name="About_Translators_TreeNode" xml:space="preserve"> <data name="About_Translators_TreeNode" xml:space="preserve">
<value>Chat 2 community translators (upstream)</value> <value>Chat 2 community translators (upstream)</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (Runtime strings) --> <!-- Hellion Chat — Auto-Tell-Tabs (runtime strings) -->
<data name="AutoTellTabs_SectionHeader" xml:space="preserve"> <data name="AutoTellTabs_SectionHeader" xml:space="preserve">
<value>Active tells</value> <value>Active Tells</value>
</data> </data>
<data name="AutoTellTabs_HistorySeparator" xml:space="preserve"> <data name="AutoTellTabs_HistorySeparator" xml:space="preserve">
<value>— Earlier conversations —</value> <value>— Earlier conversations —</value>
</data> </data>
<data name="AutoTellTabs_HistoryLoadError" xml:space="preserve"> <data name="AutoTellTabs_HistoryLoadError" xml:space="preserve">
<value>Could not load history.</value> <value>History could not be loaded.</value>
</data> </data>
<data name="AutoTellTabs_GreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_GreetedTooltip" xml:space="preserve">
<value>Marked as greeted. Click to remove the mark.</value> <value>Marked as greeted. Click to remove the marker.</value>
</data> </data>
<data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve"> <data name="AutoTellTabs_UnGreetedTooltip" xml:space="preserve">
<value>Mark as greeted.</value> <value>Mark as greeted.</value>
</data> </data>
<data name="PinTab_MenuPin" xml:space="preserve">
<value>Pin Tab</value>
</data>
<data name="PinTab_MenuUnpin" xml:space="preserve">
<value>Unpin Tab</value>
</data>
<data name="PinTab_MenuPromote" xml:space="preserve">
<value>Promote to permanent</value>
</data>
<data name="PinTab_PromoteTooltip" xml:space="preserve">
<value>Turns this TempTell into a regular tab. The tell binding to the partner is dropped — the tab will catch messages by its channel filters from now on. For "tab survives relog while staying bound to this partner", use Pin Tab instead.</value>
</data>
<data name="PinTab_PinTooltip" xml:space="preserve">
<value>Pinned tabs survive relog and stay bound to this conversation partner.</value>
</data>
<data name="PinTab_SectionHeader" xml:space="preserve">
<value>Pinned</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Name" xml:space="preserve">
<value>Sidebar width</value>
</data>
<data name="Settings_ThemeAndLayout_SidebarWidth_Description" xml:space="preserve">
<value>Width of the tab sidebar in pixels. The default (44 px) is icon-only; widen it to fit the section headers like "Active Tells (3)" without truncation.</value>
</data>
<data name="PinTab_LimitReached" xml:space="preserve">
<value>Maximum of {0} pinned tell tabs reached. Unpin one first, or use Promote to permanent.</value>
</data>
<data name="PinTab_PinnedTooltip" xml:space="preserve">
<value>Pinned — survives relog.</value>
</data>
<!-- Hellion Chat — Auto-Tell-Tabs (Chat settings tab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Chat settings tab) -->
<data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Section_Title" xml:space="preserve">
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Name" xml:space="preserve">
<value>Automatically open a tab per conversation partner for every /tell</value> <value>Open a tab automatically for each tell partner</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Enable_Description" xml:space="preserve">
<value>As soon as you receive or send a /tell, a temporary tab is automatically opened for that player. Tabs are removed on logout.</value> <value>When you receive or send a /tell, a temporary tab dedicated to that player is opened automatically. Tabs vanish on logout.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Name" xml:space="preserve">
<value>Maximum number of auto-tell tabs</value> <value>Maximum number of auto tell tabs</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Limit_Description" xml:space="preserve">
<value>When the limit is reached, greeted tabs with the oldest activity are closed first. Changes take effect on the next /tell. This limit applies to the auto-managed pool. Pinned tell tabs (right-click → Pin Tab) live in a separate pool of up to 5 and survive relog.</value> <value>When the limit is reached, greeted tabs with the oldest activity are dropped first. The change applies on the next /tell.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Name" xml:space="preserve">
<value>Compact display</value> <value>Compact display</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_Compact_Description" xml:space="preserve">
<value>Shows only a thin separator between regular tabs and auto-tell tabs, without a section header.</value> <value>Show only a thin separator between persistent tabs and auto tell tabs, without the section header.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Name" xml:space="preserve">
<value>Show "Mark as greeted" button</value> <value>Show "mark as greeted" button</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_GreetedToggle_Description" xml:space="preserve">
<value>Adds a click button next to each auto-tell tab to mark a conversation partner as already greeted the tab name is then dimmed. Useful for club greeters managing many conversations in parallel. Off by default.</value> <value>Adds a click-to-toggle button next to each auto tell tab to mark a partner as already greeted, dimming the tab name when set. Useful for club greeters tracking many parallel conversations; off by default.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Name" xml:space="preserve">
<value>Open new /tell tabs directly as pop-outs</value> <value>Open new /tell tabs directly as pop-out</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_OpenAsPopout_Description" xml:space="preserve">
<value>When active, each newly created /tell tab is immediately opened as its own window. Closing the window returns the tab to the sidebar.</value> <value>When enabled, each newly created /tell tab opens directly as its own window. Closing the window returns the tab to the sidebar.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_PreloadHint" xml:space="preserve">
<value>The number of preloaded tells can be configured in the Privacy tab.</value> <value>The number of preloaded tells is configured in the Privacy tab.</value>
</data> </data>
<data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve"> <data name="ChatLog_AutoTellTabs_ConflictHint" xml:space="preserve">
<value>Note: If XIV Messenger or a similar plugin suppresses tells, disable the "Suppress DMs" option there so that Hellion Chat can receive tells and open the auto-tabs.</value> <value>Heads-up: if XIV Messanger or a similar plugin is suppressing direct messages, turn its "Suppress DMs" option off so Hellion Chat can receive tells and open the auto tabs.</value>
</data> </data>
<!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) --> <!-- Hellion Chat — Auto-Tell-Tabs (Privacy settings tab) -->
<data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Section_Title" xml:space="preserve">
<value>Tell history in auto-tabs</value> <value>Tell history in auto tabs</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Name" xml:space="preserve">
<value>Number of preloaded tells</value> <value>Number of preloaded tells</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Description" xml:space="preserve">
<value>How many previous tell messages are loaded from the database when an auto-tell tab is opened. 0 disables preloading.</value> <value>How many earlier tell messages are loaded from the database when an auto tell tab is opened. 0 disables the preload.</value>
</data> </data>
<data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve"> <data name="Privacy_AutoTellTabs_Preload_Hint" xml:space="preserve">
<value>Only takes effect when auto-tell tabs are enabled in the Chat tab.</value> <value>Only takes effect when auto tell tabs are enabled in the Chat tab.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish v10 Wipe migration --> <!-- Hellion Chat — Settings UX Polish v10 wipe migration -->
<data name="SettingsRefactor_Migration_Title" xml:space="preserve"> <data name="SettingsRefactor_Migration_Title" xml:space="preserve">
<value>Settings restructured</value> <value>Settings reorganised</value>
</data> </data>
<data name="SettingsRefactor_Migration_Content" xml:space="preserve"> <data name="SettingsRefactor_Migration_Content" xml:space="preserve">
<value>Hellion Chat 0.5.0 has restructured the settings into thematic tabs. Your chat database and message history remain unchanged. Settings have been reset to defaults. If you want to re-select your privacy profile, the Reopen button is in the Privacy tab. A backup of the previous config is located at HellionChat.json.pre-v10-backup next to the active config file.</value> <value>Hellion Chat 0.5.0 reorganised the settings into themed tabs. Your chat database and your message history stay untouched. Settings have been reset to defaults; if you want to pick a privacy profile again, the reopen button is in the Privacy tab. A backup of your previous config is at HellionChat.json.pre-v10-backup next to the live config file.</value>
</data> </data>
<!-- Hellion Chat — Settings UX Polish 8-tab structure --> <!-- Hellion Chat — Settings UX Polish 8-tab structure -->
@@ -491,30 +455,30 @@
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Tab_Tabs" xml:space="preserve"> <data name="Settings_Tab_Tabs" xml:space="preserve">
<value>Channels</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Tab_Database" xml:space="preserve"> <data name="Settings_Tab_Database" xml:space="preserve">
<value>Database</value> <value>Database</value>
</data> </data>
<data name="Settings_Tab_Information" xml:space="preserve"> <data name="Settings_Tab_Information" xml:space="preserve">
<value>About</value> <value>Information</value>
</data> </data>
<!-- Hellion Chat — General tab section headings --> <!-- Hellion Chat — General-Tab section headings -->
<data name="Settings_General_Input_Heading" xml:space="preserve"> <data name="Settings_General_Input_Heading" xml:space="preserve">
<value>Input</value> <value>Input</value>
</data> </data>
<data name="Settings_General_Audio_Heading" xml:space="preserve"> <data name="Settings_General_Audio_Heading" xml:space="preserve">
<value>Audio &amp; notifications</value> <value>Audio &amp; Notifications</value>
</data> </data>
<data name="Settings_General_Performance_Heading" xml:space="preserve"> <data name="Settings_General_Performance_Heading" xml:space="preserve">
<value>Performance</value> <value>Performance</value>
</data> </data>
<data name="Settings_General_Language_Heading" xml:space="preserve"> <data name="Settings_General_Language_Heading" xml:space="preserve">
<value>Language &amp; input aids</value> <value>Language &amp; Input Helpers</value>
</data> </data>
<!-- Hellion Chat — Appearance tab section headings --> <!-- Hellion Chat — Appearance-Tab section headings -->
<data name="Settings_Appearance_Theme_Heading" xml:space="preserve"> <data name="Settings_Appearance_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
@@ -522,32 +486,32 @@
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_Appearance_Colours_Heading" xml:space="preserve"> <data name="Settings_Appearance_Colours_Heading" xml:space="preserve">
<value>Chat colours</value> <value>Chat Colours</value>
</data> </data>
<data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve"> <data name="Settings_Appearance_Timestamps_Heading" xml:space="preserve">
<value>Timestamps</value> <value>Timestamps</value>
</data> </data>
<!-- Hellion Chat — Window tab section headings --> <!-- Hellion Chat — Window-Tab section headings -->
<data name="Settings_Window_Hide_Heading" xml:space="preserve"> <data name="Settings_Window_Hide_Heading" xml:space="preserve">
<value>Hiding</value> <value>Hide</value>
</data> </data>
<data name="Settings_Window_InactivityHide_Heading" xml:space="preserve"> <data name="Settings_Window_InactivityHide_Heading" xml:space="preserve">
<value>Inactivity hiding</value> <value>Inactivity Hide</value>
</data> </data>
<data name="Settings_Window_Frame_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Heading" xml:space="preserve">
<value>Window frame</value> <value>Window Frame</value>
</data> </data>
<data name="Settings_Window_Tooltips_Heading" xml:space="preserve"> <data name="Settings_Window_Tooltips_Heading" xml:space="preserve">
<value>Tooltips</value> <value>Tooltips</value>
</data> </data>
<!-- Hellion Chat — Chat tab section headings --> <!-- Hellion Chat — Chat-Tab section headings -->
<data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve"> <data name="Settings_Chat_AutoTellTabs_Heading" xml:space="preserve">
<value>Auto-Tell-Tabs</value> <value>Auto-Tell-Tabs</value>
</data> </data>
<data name="Settings_Chat_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Chat_Behaviour_Heading" xml:space="preserve">
<value>Message behaviour</value> <value>Message Behaviour</value>
</data> </data>
<data name="Settings_Chat_Preview_Heading" xml:space="preserve"> <data name="Settings_Chat_Preview_Heading" xml:space="preserve">
<value>Preview</value> <value>Preview</value>
@@ -556,7 +520,7 @@
<value>Emotes</value> <value>Emotes</value>
</data> </data>
<!-- Hellion Chat — Database tab section headings --> <!-- Hellion Chat — Database-Tab section headings -->
<data name="Settings_Database_Storage_Heading" xml:space="preserve"> <data name="Settings_Database_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
</data> </data>
@@ -567,9 +531,9 @@
<value>Maintenance</value> <value>Maintenance</value>
</data> </data>
<!-- Hellion Chat — Information tab section headings --> <!-- Hellion Chat — Information-Tab section headings -->
<data name="Settings_Information_VersionInfo_Heading" xml:space="preserve"> <data name="Settings_Information_VersionInfo_Heading" xml:space="preserve">
<value>Version info</value> <value>Version Info</value>
</data> </data>
<data name="Settings_Information_About_Heading" xml:space="preserve"> <data name="Settings_Information_About_Heading" xml:space="preserve">
<value>About HellionChat</value> <value>About HellionChat</value>
@@ -578,7 +542,7 @@
<value>Changelog</value> <value>Changelog</value>
</data> </data>
<!-- Hellion Chat — Default tab presets (channel-specific) --> <!-- Hellion Chat — Default tab presets (channel-themed) -->
<data name="Tabs_Presets_System" xml:space="preserve"> <data name="Tabs_Presets_System" xml:space="preserve">
<value>System</value> <value>System</value>
</data> </data>
@@ -589,36 +553,36 @@
<value>Party</value> <value>Party</value>
</data> </data>
<data name="Tabs_Presets_Beginner" xml:space="preserve"> <data name="Tabs_Presets_Beginner" xml:space="preserve">
<value>Novice</value> <value>Beginner</value>
</data> </data>
<data name="Tabs_Presets_Linkshell" xml:space="preserve"> <data name="Tabs_Presets_Linkshell" xml:space="preserve">
<value>Linkshell</value> <value>Linkshell</value>
</data> </data>
<data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve"> <data name="Tabs_Presets_Linkshell_Hint" xml:space="preserve">
<value>If you use multiple linkshells, the maintainer recommends one tab per shell for a cleaner overview. Duplicate the tab and restrict the channel selection in each copy.</value> <value>If you use multiple linkshells, the maintainer recommends one tab per shell for cleaner readability. Duplicate this tab and narrow the channel selection per copy.</value>
</data> </data>
<!-- Hellion Chat — v1.2.0 per-tab icon override --> <!-- Hellion Chat — v1.2.0 per-tab icon override -->
<data name="Tabs_Icon_Label" xml:space="preserve"> <data name="Tabs_Icon_Label" xml:space="preserve">
<value>Tab icon</value> <value>Tab-Icon</value>
</data> </data>
<data name="Tabs_Icon_HelpMarker" xml:space="preserve"> <data name="Tabs_Icon_HelpMarker" xml:space="preserve">
<value>FontAwesome glyph for the sidebar. Default falls back to the tab name or channel type.</value> <value>FontAwesome-Glyph für die Sidebar. Default greift auf Tab-Name oder Channel-Typ.</value>
</data> </data>
<data name="Tabs_Icon_DefaultOption" xml:space="preserve"> <data name="Tabs_Icon_DefaultOption" xml:space="preserve">
<value>(Default mapping)</value> <value>(Default-Mapping)</value>
</data> </data>
<data name="ChatColourPresets_Default" xml:space="preserve"> <data name="ChatColourPresets_Default" xml:space="preserve">
<value>Classic (Chat 2 default)</value> <value>Klassik (Chat 2 Default)</value>
</data> </data>
<data name="ChatColourPresets_HighContrast" xml:space="preserve"> <data name="ChatColourPresets_HighContrast" xml:space="preserve">
<value>High contrast</value> <value>High-Contrast</value>
</data> </data>
<data name="ChatColourPresets_Pastell" xml:space="preserve"> <data name="ChatColourPresets_Pastell" xml:space="preserve">
<value>Pastel</value> <value>Pastell</value>
</data> </data>
<data name="ChatColourPresets_DarkModeTuned" xml:space="preserve"> <data name="ChatColourPresets_DarkModeTuned" xml:space="preserve">
<value>Dark mode tuned</value> <value>Dark-Mode-Tuned</value>
</data> </data>
<data name="ChatColourPresets_Hellion" xml:space="preserve"> <data name="ChatColourPresets_Hellion" xml:space="preserve">
<value>Hellion</value> <value>Hellion</value>
@@ -630,22 +594,22 @@
<value>Indigo Violet</value> <value>Indigo Violet</value>
</data> </data>
<data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve"> <data name="Settings_Appearance_Colours_PresetsHint" xml:space="preserve">
<value>Tip: Presets overwrite your current channel colours immediately.</value> <value>Tip: presets overwrite your current channel colours immediately.</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Name" xml:space="preserve">
<value>Enable input in pop-outs</value> <value>Enable input in pop-outs</value>
</data> </data>
<data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve"> <data name="Settings_Window_PopOutInputEnabled_Description" xml:space="preserve">
<value>Master switch: allows typing and sending directly in any pop-out window (including auto-tell tabs). Channel switching in a pop-out acts globally like in the main window; the text buffer and history cursor are independent per pop-out.</value> <value>Master switch: lets you type and send messages directly inside every pop-out window (including auto-tell tabs). Channel changes inside a pop-out apply globally just like in the main window; the text buffer and history cursor stay independent per pop-out.</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Name" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Name" xml:space="preserve">
<value>Reset window position</value> <value>Reset Window Position</value>
</data> </data>
<data name="Settings_Window_ResetPosition_Description" xml:space="preserve"> <data name="Settings_Window_ResetPosition_Description" xml:space="preserve">
<value>Moves the chat window and all active pop-outs back to the top-left corner of the primary monitor. Useful when a window has ended up outside the visible area after a display layout change (monitor disconnected, resolution changed). The plugin also performs an automatic bounds check once per session; this button is the manual escape hatch if something still ends up unreachable.</value> <value>Snaps the chat window and every active pop-out back to the primary monitor's top-left corner. Useful when a window has drifted off-screen after a display layout change (monitor disconnected, resolution changed). The plugin also runs an automatic bounds check once per session this button is the manual backup if anything still ends up unreachable.</value>
</data> </data>
<data name="Popout_v060_HintText" xml:space="preserve"> <data name="Popout_v060_HintText" xml:space="preserve">
<value>New in v0.6.0: You can now type directly in pop-outs. Enable the master switch in the Window settings.</value> <value>New in v0.6.0: you can type directly inside pop-out windows. Toggle the master switch in the window settings to enable it.</value>
</data> </data>
<data name="Popout_v060_HintAck" xml:space="preserve"> <data name="Popout_v060_HintAck" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
@@ -654,19 +618,19 @@
<value>Open window settings</value> <value>Open window settings</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Body" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Body" xml:space="preserve">
<value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is active by default (can be disabled under Settings → Window).</value> <value>You can open any chat tab as its own window. Click the window icon in the top right or right-click the tab. New in v0.6.1: pop-out input is enabled by default (can be turned off under Settings → Window).</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_Ack" xml:space="preserve">
<value>Got it</value> <value>Got it</value>
</data> </data>
<data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve"> <data name="Hint_v061_PopOutHeader_OpenSettings" xml:space="preserve">
<value>Open settings</value> <value>Open Settings</value>
</data> </data>
<data name="ChatTwoConflictTitle" xml:space="preserve"> <data name="ChatTwoConflictTitle" xml:space="preserve">
<value>Hellion Chat cannot start while Chat 2 is loaded.</value> <value>Hellion Chat cannot start while Chat 2 is loaded.</value>
</data> </data>
<data name="ChatTwoConflictBody" xml:space="preserve"> <data name="ChatTwoConflictBody" xml:space="preserve">
<value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same chat window in the game and would conflict at runtime.</value> <value>Hellion Chat is a standalone fork of Chat 2. Both plugins replace the same in-game chat window and would conflict at runtime if loaded together.</value>
</data> </data>
<data name="ChatTwoConflictAction" xml:space="preserve"> <data name="ChatTwoConflictAction" xml:space="preserve">
<value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value> <value>Disable Chat 2 in /xlplugins, then re-enable Hellion Chat.</value>
@@ -675,7 +639,7 @@
<value>General</value> <value>General</value>
</data> </data>
<data name="Settings_Card_General_Subtext" xml:space="preserve"> <data name="Settings_Card_General_Subtext" xml:space="preserve">
<value>Language, input, audio, and performance.</value> <value>Plugin-wide settings — language, input, audio, performance.</value>
</data> </data>
<data name="Settings_Card_Appearance_Title" xml:space="preserve"> <data name="Settings_Card_Appearance_Title" xml:space="preserve">
<value>Appearance</value> <value>Appearance</value>
@@ -693,25 +657,25 @@
<value>Window</value> <value>Window</value>
</data> </data>
<data name="Settings_Card_Window_Subtext" xml:space="preserve"> <data name="Settings_Card_Window_Subtext" xml:space="preserve">
<value>When the window is visible and whether it can be moved.</value> <value>Window behaviour — when it shows, whether it can move.</value>
</data> </data>
<data name="Settings_Card_Chat_Title" xml:space="preserve"> <data name="Settings_Card_Chat_Title" xml:space="preserve">
<value>Chat</value> <value>Chat</value>
</data> </data>
<data name="Settings_Card_Chat_Subtext" xml:space="preserve"> <data name="Settings_Card_Chat_Subtext" xml:space="preserve">
<value>Tells, preview, message behaviour, and emotes.</value> <value>How messages are displayed — tells, preview, behaviour, emotes.</value>
</data> </data>
<data name="Settings_Card_Tabs_Title" xml:space="preserve"> <data name="Settings_Card_Tabs_Title" xml:space="preserve">
<value>Tabs</value> <value>Tabs</value>
</data> </data>
<data name="Settings_Card_Tabs_Subtext" xml:space="preserve"> <data name="Settings_Card_Tabs_Subtext" xml:space="preserve">
<value>Create and configure custom chat tabs.</value> <value>Tab management — create and configure your own chat tabs.</value>
</data> </data>
<data name="Settings_Card_Privacy_Title" xml:space="preserve"> <data name="Settings_Card_Privacy_Title" xml:space="preserve">
<value>Privacy</value> <value>Privacy</value>
</data> </data>
<data name="Settings_Card_Privacy_Subtext" xml:space="preserve"> <data name="Settings_Card_Privacy_Subtext" xml:space="preserve">
<value>Privacy filter per channel and what may be stored.</value> <value>What's allowed to be stored — privacy filter per channel.</value>
</data> </data>
<data name="Settings_Card_Database_Title" xml:space="preserve"> <data name="Settings_Card_Database_Title" xml:space="preserve">
<value>Database</value> <value>Database</value>
@@ -723,7 +687,7 @@
<value>Information</value> <value>Information</value>
</data> </data>
<data name="Settings_Card_Information_Subtext" xml:space="preserve"> <data name="Settings_Card_Information_Subtext" xml:space="preserve">
<value>Version, mission, licence, and changelog.</value> <value>About the plugin — version, mission, license, changelog.</value>
</data> </data>
<data name="Settings_Tab_Themes" xml:space="preserve"> <data name="Settings_Tab_Themes" xml:space="preserve">
<value>Themes</value> <value>Themes</value>
@@ -741,16 +705,16 @@
<value>Open themes folder</value> <value>Open themes folder</value>
</data> </data>
<data name="Settings_Themes_ExportActive" xml:space="preserve"> <data name="Settings_Themes_ExportActive" xml:space="preserve">
<value>Export active</value> <value>Export active...</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Hint" xml:space="preserve">
<value>This theme suggests its own channel colours.</value> <value>This theme suggests its own chat channel colours.</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Apply" xml:space="preserve">
<value>Apply</value> <value>Apply</value>
</data> </data>
<data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve"> <data name="Settings_Themes_ApplyChatColors_Keep" xml:space="preserve">
<value>Keep</value> <value>Keep current</value>
</data> </data>
<data name="StatusBar_Privacy_Enabled" xml:space="preserve"> <data name="StatusBar_Privacy_Enabled" xml:space="preserve">
<value>Privacy-First</value> <value>Privacy-First</value>
@@ -759,55 +723,55 @@
<value>Open</value> <value>Open</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Name" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Name" xml:space="preserve">
<value>Compact density</value> <value>Compact Density</value>
</data> </data>
<data name="Appearance_UseCompactDensity_Description" xml:space="preserve"> <data name="Appearance_UseCompactDensity_Description" xml:space="preserve">
<value>Switches the message layout from the card-row default back to single-line `[HH:mm] Sender: Text` rows.</value> <value>Schaltet das Message-Layout vom Card-Row-Default zurück auf einzeilige `[HH:mm] Sender: Text` Zeilen.</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Title" xml:space="preserve">
<value>Theme &amp; Layout</value> <value>Theme &amp; Layout</value>
</data> </data>
<data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve"> <data name="Settings_Card_ThemeAndLayout_Subtext" xml:space="preserve">
<value>Theme, window frame, and timestamp style.</value> <value>How the window looks — theme, frame, timestamp style.</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Title" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Title" xml:space="preserve">
<value>Fonts &amp; Colours</value> <value>Fonts &amp; Colours</value>
</data> </data>
<data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve"> <data name="Settings_Card_FontsAndColours_Subtext" xml:space="preserve">
<value>Font, font size, and chat colours per channel.</value> <value>Readability — font, font size, per-channel chat colours.</value>
</data> </data>
<data name="Settings_Card_DataManagement_Title" xml:space="preserve"> <data name="Settings_Card_DataManagement_Title" xml:space="preserve">
<value>Data management</value> <value>Data Management</value>
</data> </data>
<data name="Settings_Card_DataManagement_Subtext" xml:space="preserve"> <data name="Settings_Card_DataManagement_Subtext" xml:space="preserve">
<value>Retention, cleanup, export, and database statistics.</value> <value>What happens to stored data — retention, cleanup, export, DB stats.</value>
</data> </data>
<data name="Settings_Card_Integrations_Title" xml:space="preserve"> <data name="Settings_Card_Integrations_Title" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Card_Integrations_Subtext" xml:space="preserve"> <data name="Settings_Card_Integrations_Subtext" xml:space="preserve">
<value>Other Dalamud plugins that HellionChat works with. Upcoming integrations in preview.</value> <value>Other Dalamud plugins HellionChat reacts to. Auto-detected, with a "coming soon" preview of upcoming integrations.</value>
</data> </data>
<data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_Theme_Heading" xml:space="preserve">
<value>Theme</value> <value>Theme</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowStyle_Heading" xml:space="preserve">
<value>Window style</value> <value>Window Style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve"> <data name="Settings_ThemeAndLayout_TimestampStyle_Heading" xml:space="preserve">
<value>Timestamp style</value> <value>Timestamp Style</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Name" xml:space="preserve">
<value>Window transparency</value> <value>Window Transparency</value>
</data> </data>
<data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve"> <data name="Settings_ThemeAndLayout_WindowOpacity_Description" xml:space="preserve">
<value>How transparent the window background is. Lower values let more of the game show through. Tip: Dalamud's per-window menu (hamburger in the title bar) offers per-window overrides for opacity, background blur, click-through, and pinning — those take precedence over this slider for the respective window.</value> <value>How transparent the window background is. Lower values let the game show through more. Tip: Dalamud's per-window menu (Hamburger in the title bar) gives you per-window overrides for opacity, background blur, click-through and pinning — those override this slider for that window.</value>
</data> </data>
<data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Fonts_Heading" xml:space="preserve">
<value>Fonts</value> <value>Fonts</value>
</data> </data>
<data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve"> <data name="Settings_FontsAndColours_Colours_Heading" xml:space="preserve">
<value>Chat colours</value> <value>Chat Colours</value>
</data> </data>
<data name="Settings_DataManagement_Storage_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Storage_Heading" xml:space="preserve">
<value>Storage</value> <value>Storage</value>
@@ -822,22 +786,22 @@
<value>Export</value> <value>Export</value>
</data> </data>
<data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve"> <data name="Settings_DataManagement_DbViewer_Heading" xml:space="preserve">
<value>Database viewer</value> <value>Database Viewer</value>
</data> </data>
<data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve"> <data name="Settings_DataManagement_Advanced_Heading" xml:space="preserve">
<value>Advanced (Shift+click to open)</value> <value>Advanced (Shift+Click to open)</value>
</data> </data>
<data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve"> <data name="Settings_Window_Frame_Behaviour_Heading" xml:space="preserve">
<value>Behaviour</value> <value>Behaviour</value>
</data> </data>
<data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve"> <data name="Migration_v16_OverrideStyle_Toast" xml:space="preserve">
<value>Hellion Chat 1.2.1 has reorganised the settings menu and removed the old "Override style" option (superseded by the theme system from 1.1.0). Your remaining settings are unchanged. Window transparency has been migrated to "Theme &amp; Layout". A backup of the previous config is located at pluginConfigs/HellionChat.json.pre-v16-backup next to the active HellionChat.json.</value> <value>Hellion Chat 1.2.1 reorganised the Settings menu and removed the legacy "Style override" option (made obsolete by the Themes system in 1.1.0). Your other settings are unchanged. Window opacity was migrated to Theme &amp; Layout. A backup of your previous config is at pluginConfigs/HellionChat.json.pre-v16-backup next to the live HellionChat.json.</value>
</data> </data>
<data name="Settings_Tab_Integrations" xml:space="preserve"> <data name="Settings_Tab_Integrations" xml:space="preserve">
<value>Integrations</value> <value>Integrations</value>
</data> </data>
<data name="Settings_Integrations_Intro" xml:space="preserve"> <data name="Settings_Integrations_Intro" xml:space="preserve">
<value>Plugin integrations let HellionChat work together with other installed Dalamud plugins. Each integration automatically detects its target and silently disables itself when the target plugin is missing.</value> <value>Plugin integrations let HellionChat react to other installed Dalamud plugins. Each integration auto-detects its target and silently disables itself when the target plugin is not present.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_Honorific_SectionHeader" xml:space="preserve">
<value>Honorific</value> <value>Honorific</value>
@@ -849,19 +813,13 @@
<value>Not installed</value> <value>Not installed</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Status_Incompatible" xml:space="preserve">
<value>Incompatible API version ({0} expected, {1}.{2} found)</value> <value>Incompatible API version ({0} expected, {1}.{2} detected)</value>
</data> </data>
<data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve"> <data name="Settings_Integrations_Honorific_Toggle" xml:space="preserve">
<value>Show Honorific title in chat header</value> <value>Show Honorific title in chat header</value>
</data> </data>
<data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve"> <data name="Settings_Integrations_Honorific_ToggleHint" xml:space="preserve">
<value>Shows your custom title from Honorific in the header above the chat log, in the colour you have chosen.</value> <value>Displays your custom title from Honorific in the header above the chat log, in your chosen colour.</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Toggle" xml:space="preserve">
<value>Render glow outlines (Honorific)</value>
</data>
<data name="Settings_Integrations_Honorific_Glow_Hint" xml:space="preserve">
<value>May reduce frame rate on low-end hardware. Renders glow outlines for Honorific titles that use them. Gradient animation is not yet supported and will render as the primary colour.</value>
</data> </data>
<data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve"> <data name="Settings_Integrations_Honorific_LinkRepo" xml:space="preserve">
<value>Honorific on GitHub</value> <value>Honorific on GitHub</value>
@@ -873,57 +831,48 @@
<value>Coming soon</value> <value>Coming soon</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Intro" xml:space="preserve">
<value>These integrations are on the roadmap. The settings will appear automatically once the respective plugin is connected.</value> <value>These integrations are on the roadmap. The settings for each appear automatically once the underlying plugin is wired up.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Title" xml:space="preserve">
<value>Context menu actions</value> <value>Context menu actions</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ContextMenu_Description" xml:space="preserve">
<value>Right-click a name in chat: jump to PlayerTrack, open the Lodestone profile, or compose a DM with one click.</value> <value>Right-click a name in chat to jump to PlayerTrack, open the Lodestone profile, or compose a DM in one click.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Title" xml:space="preserve">
<value>Smart notifications (NotificationMaster)</value> <value>Smart notifications (NotificationMaster)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_Notifications_Description" xml:space="preserve">
<value>Mentions and DMs via NotificationMaster: system toasts, taskbar flash, and per-channel sounds.</value> <value>Route mentions and DMs through NotificationMaster for system toasts, taskbar flash, and per-channel sounds.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Title" xml:space="preserve">
<value>RP status block (Moodles · LightlessClient)</value> <value>RP status block (Moodles · LightlessClient)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_RPStatus_Description" xml:space="preserve">
<value>Show Moodles status icons and pair badges directly next to chat names for more roleplay context.</value> <value>Show Moodles status icons and pair-badges inline next to chat names for richer roleplay context.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Title" xml:space="preserve">
<value>ExtraChat channels</value> <value>ExtraChat channels</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_ExtraChat_Description" xml:space="preserve">
<value>Host end-to-end encrypted cross-datacenter linkshells natively in HellionChat.</value> <value>Host end-to-end-encrypted cross-datacenter linkshells natively in HellionChat.</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Title" xml:space="preserve">
<value>Quick-DM button (XIVInstantMessenger)</value> <value>Quick DM button (XIVInstantMessenger)</value>
</data> </data>
<data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve"> <data name="Settings_Integrations_ComingSoon_QuickDM_Description" xml:space="preserve">
<value>Quick DM access directly from the chat window, one click.</value> <value>One-click DM compose without leaving the chat window.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_SectionHeader" xml:space="preserve">
<value>Got an idea?</value> <value>Got an idea?</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_Body" xml:space="preserve">
<value>Got an idea for a plugin integration that is not on the list? Come to the Hellion Forge Discord and write to me. Community input shapes the roadmap.</value> <value>Got an idea for a plugin integration that's not on this list? Hop on the Hellion Forge Discord and tell me. Community input drives the roadmap.</value>
</data> </data>
<data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve"> <data name="Settings_Integrations_GotAnIdea_LinkLabel" xml:space="preserve">
<value>Open Hellion Forge</value> <value>Open Hellion Forge</value>
</data> </data>
<data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve"> <data name="ChatHeader_HonorificTitle_Tooltip" xml:space="preserve">
<value>Custom title from Honorific</value> <value>Honorific custom title</value>
</data>
<data name="DbViewer_FullTextToggle" xml:space="preserve">
<value>Full-text search</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_Indexing" xml:space="preserve">
<value>The full-text index is still being built. The local filter remains available.</value>
</data>
<data name="DbViewer_FullTextToggle_Hint_PhraseMode" xml:space="preserve">
<value>Searches for the exact phrase. Multi-word queries match only when the words appear together in order. To use raw FTS5 MATCH syntax, wrap your term in double quotes yourself.</value>
</data> </data>
</root> </root>
@@ -4,9 +4,13 @@ using HellionChat.Themes;
namespace HellionChat.SelfTests; namespace HellionChat.SelfTests;
// Validates the runtime theme-switch contract: polls ThemeRegistry.Active // Validates the runtime theme-switch contract from the user side. The
// per frame until the slug moves away and back, then sanity-checks that // caller toggles the active theme via Settings -> Theme & Layout, the
// the ABGR cache was recomputed on switch. // step polls ThemeRegistry.Active per frame and only passes once the
// slug has moved away from the initial value and back. The ABGR cache
// is sanity-checked on every frame: a freshly switched theme must carry
// a populated cache, otherwise Switch() forgot the recompute and the UI
// would still draw, just with all-transparent slots.
internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep
{ {
private readonly Plugin plugin; private readonly Plugin plugin;
@@ -69,8 +73,9 @@ internal sealed class ThemeSwitchSelfTestStep : ISelfTestStep
this.switchedAway = false; this.switchedAway = false;
} }
// Any non-zero slot confirms the cache was recomputed — no reference // Any non-zero slot proves the cache was actually recomputed for the
// comparison since custom themes can share slot values with built-ins. // current theme. We don't compare against a reference, because custom
// themes can legitimately share slot values with a built-in.
private static bool HasPopulatedCache(Theme theme) private static bool HasPopulatedCache(Theme theme)
{ {
var cache = theme.AbgrCache; var cache = theme.AbgrCache;
@@ -1,82 +0,0 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class CrystalNocturne
{
public const string Slug = "crystal-nocturne";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Crystal Nocturne",
Author: "CRYSTALLITE",
Description: "Royal sapphire and electric magenta over obsidian — a nocturne for the crystal-lit dance floor.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#1D4ED8"),
Primary: ColourUtil.HexToRgba("#3B82F6"),
PrimaryLight: ColourUtil.HexToRgba("#93C5FD"),
PrimaryGlow: ColourUtil.HexToRgba("#3B82F699"),
AccentDark: ColourUtil.HexToRgba("#A21CAF"),
Accent: ColourUtil.HexToRgba("#D946EF"),
AccentLight: ColourUtil.HexToRgba("#F0ABFC"),
Identity: ColourUtil.HexToRgba("#3B82F6"),
WindowBg: ColourUtil.HexToRgba("#08070F"),
ChildBg: ColourUtil.HexToRgba("#11101F"),
FrameBg: ColourUtil.HexToRgba("#1C1A33"),
Surface: ColourUtil.HexToRgba("#262340"),
SurfaceHover: ColourUtil.HexToRgba("#332D55"),
Border: ColourUtil.HexToRgba("#D946EF55"),
TextPrimary: ColourUtil.HexToRgba("#F5F3FF"),
TextMuted: ColourUtil.HexToRgba("#A5A0C0"),
TextDim: ColourUtil.HexToRgba("#4B4763"),
StatusSuccess: ColourUtil.HexToRgba("#10B981"),
StatusDanger: ColourUtil.HexToRgba("#F43F5E"),
StatusWarning: ColourUtil.HexToRgba("#FACC15"),
StatusInfo: ColourUtil.HexToRgba("#3B82F6")
),
Layout: new ThemeLayout(
WindowRounding: 2f,
ChildRounding: 1f,
PopupRounding: 2f,
FrameRounding: 1f,
GrabRounding: 1f,
TabRounding: 1f,
ScrollbarRounding: 2f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Crystal Nocturne — sapphire-blue identity for party/team channels,
// accent-magenta for tells, with mint/peach accents on linkshells
// so the eight LS slots stay individually distinguishable on the
// dark obsidian background.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#F5F3FF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#10B981"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#FACC15"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0ABFC"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#93C5FD"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#A5A0C0"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#D946EF"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#3B82F6"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#A5A0C0"),
}
)
);
}
@@ -2,7 +2,12 @@ using HellionChat.Util;
namespace HellionChat.Themes.Builtin; namespace HellionChat.Themes.Builtin;
// Deuteran/Protan-safe palette with preserved channel identity. // Hellion Spectrum: Deuteran/Protan-safe channel colours.
// Palette derived from Bang Wong, "Points of view: Color blindness",
// Nature Methods 8, 441 (2011). Channel identity (Tell pink, Yell yellow,
// Shout orange, Party blue, FC green) is preserved per Channel-Identity-
// Rule in docs/THEME-AUTHORING.md; tones are chosen so every channel
// stays distinguishable under red-green colour-vision deficiency.
internal static class HellionSpectrum internal static class HellionSpectrum
{ {
public const string Slug = "hellion-spectrum"; public const string Slug = "hellion-spectrum";
@@ -52,6 +57,9 @@ internal static class HellionSpectrum
ChatColors: new ThemeChatColors( ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint> new Dictionary<HellionChat.Code.ChatType, uint>
{ {
// Hellion Spectrum — Wong/Okabe-Ito tones within FFXIV channel
// identity. FC pulled slightly greener than vanilla cyan-teal so
// Party-blue and FC-green stay separable under deuteran sim.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"), [HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#FFFFFF"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"), [HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0E442"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"), [HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#D55E00"),
@@ -0,0 +1,80 @@
using HellionChat.Util;
namespace HellionChat.Themes.Builtin;
internal static class MoonlitBloom
{
public const string Slug = "moonlit-bloom";
public static Theme Build() =>
new(
Slug: Slug,
Name: "Moonlit Bloom",
Author: "Hellion Forge",
Description: "Bloom Magenta + Soft Sage auf Deep Violet Night.",
Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#C957D0"),
Primary: ColourUtil.HexToRgba("#E374E8"),
PrimaryLight: ColourUtil.HexToRgba("#EF8AF4"),
PrimaryGlow: ColourUtil.HexToRgba("#E374E899"),
AccentDark: ColourUtil.HexToRgba("#7AAC5C"),
Accent: ColourUtil.HexToRgba("#9CCB7C"),
AccentLight: ColourUtil.HexToRgba("#B6E297"),
Identity: ColourUtil.HexToRgba("#E374E8"),
WindowBg: ColourUtil.HexToRgba("#0E0C1F"),
ChildBg: ColourUtil.HexToRgba("#15122B"),
FrameBg: ColourUtil.HexToRgba("#1F1A38"),
Surface: ColourUtil.HexToRgba("#28224A"),
SurfaceHover: ColourUtil.HexToRgba("#332B5B"),
Border: ColourUtil.HexToRgba("#E374E844"),
TextPrimary: ColourUtil.HexToRgba("#ECE6F5"),
TextMuted: ColourUtil.HexToRgba("#9A8BB0"),
TextDim: ColourUtil.HexToRgba("#554B6E"),
StatusSuccess: ColourUtil.HexToRgba("#7AAC5C"),
StatusDanger: ColourUtil.HexToRgba("#E85C6A"),
StatusWarning: ColourUtil.HexToRgba("#E8B590"),
StatusInfo: ColourUtil.HexToRgba("#6278FF")
),
Layout: new ThemeLayout(
WindowRounding: 6f,
ChildRounding: 5f,
PopupRounding: 5f,
FrameRounding: 4f,
GrabRounding: 4f,
TabRounding: 4f,
ScrollbarRounding: 4f,
WindowBorderSize: 1f,
FrameBorderSize: 1f
),
Typography: new ThemeTypography(),
IsBuiltIn: true,
ChatColors: new ThemeChatColors(
new Dictionary<HellionChat.Code.ChatType, uint>
{
// Moonlit Bloom — Bloom-Magenta-Tönung. Sage-Drift in NoviceNetwork
// und Linkshell4. Tell-Pink-Identität bleibt sichtbar.
[HellionChat.Code.ChatType.Say] = ColourUtil.HexToRgba("#ECE6F5"),
[HellionChat.Code.ChatType.Yell] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Shout] = ColourUtil.HexToRgba("#F09A60"),
[HellionChat.Code.ChatType.TellIncoming] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.TellOutgoing] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Party] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Alliance] = ColourUtil.HexToRgba("#F0B090"),
[HellionChat.Code.ChatType.FreeCompany] = ColourUtil.HexToRgba("#A8C8E8"),
[HellionChat.Code.ChatType.NoviceNetwork] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.CrossParty] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell1] = ColourUtil.HexToRgba("#9CCB7C"),
[HellionChat.Code.ChatType.Linkshell2] = ColourUtil.HexToRgba("#F0BC92"),
[HellionChat.Code.ChatType.Linkshell3] = ColourUtil.HexToRgba("#F0D080"),
[HellionChat.Code.ChatType.Linkshell4] = ColourUtil.HexToRgba("#B6E297"),
[HellionChat.Code.ChatType.Linkshell5] = ColourUtil.HexToRgba("#A0B0F0"),
[HellionChat.Code.ChatType.Linkshell6] = ColourUtil.HexToRgba("#C098D8"),
[HellionChat.Code.ChatType.Linkshell7] = ColourUtil.HexToRgba("#EF8AF4"),
[HellionChat.Code.ChatType.Linkshell8] = ColourUtil.HexToRgba("#E8B0E8"),
[HellionChat.Code.ChatType.CustomEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.StandardEmote] = ColourUtil.HexToRgba("#E8B590"),
[HellionChat.Code.ChatType.Echo] = ColourUtil.HexToRgba("#9A8BB0"),
}
)
);
}
@@ -10,7 +10,7 @@ internal static class SynthwaveSunset
new( new(
Slug: Slug, Slug: Slug,
Name: "Synthwave Sunset", Name: "Synthwave Sunset",
Author: "Zoe Moon", Author: "Hellion Forge",
Description: "Hot Magenta + Cyan on midnight violet. 80s neon-grid vibes for late-night raids.", Description: "Hot Magenta + Cyan on midnight violet. 80s neon-grid vibes for late-night raids.",
Colors: new ThemeColors( Colors: new ThemeColors(
PrimaryDark: ColourUtil.HexToRgba("#C71585"), PrimaryDark: ColourUtil.HexToRgba("#C71585"),
+4 -2
View File
@@ -2,6 +2,8 @@ using HellionChat.Code;
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Optional per-theme chat colours applied to Configuration.ChatColours on user request. // Optional pro Theme. Wenn ein Theme ChatColors mitliefert, kann der
// Themes without this leave channel colours untouched. // User sie per Klick im Themes-Tab auf Configuration.ChatColours anwenden.
// Ein Theme ohne ChatColors (z.B. chat2-classic) lässt die User-Channel-
// Farben unverändert.
public sealed record ThemeChatColors(IReadOnlyDictionary<ChatType, uint> Channels); public sealed record ThemeChatColors(IReadOnlyDictionary<ChatType, uint> Channels);
+1 -1
View File
@@ -1,6 +1,6 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Colour values as 0xRRGGBBAA RgbaToAbgr handles the byte-swap for ImGui. // Color-Werte als 0xRRGGBBAA, RgbaToAbgr handled den Byte-Swap zu ImGui.
public sealed record ThemeColors( public sealed record ThemeColors(
uint PrimaryDark, uint PrimaryDark,
uint Primary, uint Primary,
+4 -2
View File
@@ -66,8 +66,10 @@ internal static class ThemeJsonLoader
var dict = new Dictionary<HellionChat.Code.ChatType, uint>(); var dict = new Dictionary<HellionChat.Code.ChatType, uint>();
foreach (var prop in el.EnumerateObject()) foreach (var prop in el.EnumerateObject())
{ {
// Property name is the ChatType name (e.g. "Say", "Tell"), value is hex like theme colours. // Property-Name ist der ChatType-Name als String (z.B. "Say", "Tell"),
// Unknown channel names are silently skipped for forward-compat with future SE channels. // Value ist Hex wie bei den Theme-Colors. Unbekannte Channel-Names
// werden still übersprungen — Forward-Compat falls SE neue Channels
// einführt.
if ( if (
!Enum.TryParse<HellionChat.Code.ChatType>( !Enum.TryParse<HellionChat.Code.ChatType>(
prop.Name, prop.Name,
+1 -1
View File
@@ -1,6 +1,6 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Layout values mirror the ImGuiStyleVar slots pushed by HellionStyle. // Layout-Werte spiegeln die ImGuiStyleVar-Slots, die HellionStyle pusht.
public sealed record ThemeLayout( public sealed record ThemeLayout(
float WindowRounding, float WindowRounding,
float ChildRounding, float ChildRounding,
+25 -114
View File
@@ -6,13 +6,6 @@ public sealed class ThemeRegistry
{ {
public const string DefaultSlug = HellionArctic.Slug; public const string DefaultSlug = HellionArctic.Slug;
// 1Hz throttle for the v1.4.8 B2 auto-refresh-on-active path. The
// Plugin.Draw hook calls RefreshActiveIfStale every frame, but the
// actual File.GetLastWriteTimeUtc disk-stat only runs once per second
// -- 60fps would otherwise mean 3600 stats/min on the same path (more
// on Wine). Same idiom as the StatusBar 1Hz cache.
private const long ActiveStampPollIntervalMs = 1000;
private readonly Dictionary<string, Theme> _builtIns; private readonly Dictionary<string, Theme> _builtIns;
private readonly Dictionary<string, (Theme Theme, DateTime Stamp)> _customCache = new( private readonly Dictionary<string, (Theme Theme, DateTime Stamp)> _customCache = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
@@ -20,36 +13,23 @@ public sealed class ThemeRegistry
private readonly string? _customThemesDir; private readonly string? _customThemesDir;
private Theme _active; private Theme _active;
// v1.4.8 B2: source path of the currently active custom theme. Captured
// at Switch() time so RefreshActiveIfStale does not have to reconstruct
// a filename from the slug -- custom theme filenames are not required
// to match the slug they declare in the JSON body. Null when the active
// theme is built-in or no custom-themes directory is configured.
private string? _activeCustomPath;
private long _lastActiveStampCheckMs = -ActiveStampPollIntervalMs;
private DateTime _lastActiveStamp = DateTime.MinValue;
public ThemeRegistry(string? customThemesDir = null) public ThemeRegistry(string? customThemesDir = null)
{ {
// Insertion order drives the Theme-Picker grid layout (3 columns).
// Row 1: blue family. Row 2: purple to magenta family.
// Row 3: green / warm / classic. Row 4: Synthwave Sunset as a
// retro bonus on its own line.
_builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase) _builtIns = new Dictionary<string, Theme>(StringComparer.OrdinalIgnoreCase)
{ {
{ HellionArctic.Slug, HellionArctic.Build() }, { HellionArctic.Slug, HellionArctic.Build() },
{ HellionSpectrum.Slug, HellionSpectrum.Build() }, { HellionSpectrum.Slug, HellionSpectrum.Build() },
{ NightBlue.Slug, NightBlue.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ IndigoViolet.Slug, IndigoViolet.Build() },
{ CrystalNocturne.Slug, CrystalNocturne.Build() },
{ MintGrove.Slug, MintGrove.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() },
{ Chat2Classic.Slug, Chat2Classic.Build() }, { Chat2Classic.Slug, Chat2Classic.Build() },
{ EventHorizon.Slug, EventHorizon.Build() },
{ MoonlitBloom.Slug, MoonlitBloom.Build() },
{ NightBlue.Slug, NightBlue.Build() },
{ IndigoViolet.Slug, IndigoViolet.Build() },
{ ForgeMerchantman.Slug, ForgeMerchantman.Build() },
{ MintGrove.Slug, MintGrove.Build() },
{ SynthwaveSunset.Slug, SynthwaveSunset.Build() }, { SynthwaveSunset.Slug, SynthwaveSunset.Build() },
}; };
// Centralised so Build() factories stay free of cache plumbing. // Centralised so the ten .Build() factories stay free of cache plumbing.
foreach (var theme in _builtIns.Values) foreach (var theme in _builtIns.Values)
theme.RecomputeAbgrCache(); theme.RecomputeAbgrCache();
@@ -64,9 +44,7 @@ public sealed class ThemeRegistry
if (_builtIns.TryGetValue(slug, out var b)) if (_builtIns.TryGetValue(slug, out var b))
return b; return b;
// Discard the source path here; Switch is the only call-site that var custom = LoadCustomBySlug(slug);
// needs to remember it for the auto-refresh hook.
var custom = LoadCustomBySlug(slug, out _);
if (custom != null) if (custom != null)
return custom; return custom;
@@ -77,74 +55,17 @@ public sealed class ThemeRegistry
public IEnumerable<Theme> AllCustom() => RefreshCustomCache(); public IEnumerable<Theme> AllCustom() => RefreshCustomCache();
// Built-in-first to match Get(slug)'s lookup order. A user theme JSON
// that declares the same slug as a built-in is ignored deliberately --
// having Switch prefer custom and Get prefer built-in would produce
// a state where _active and Get(_active.Slug) disagree.
public void Switch(string slug) public void Switch(string slug)
{ {
if (_builtIns.TryGetValue(slug, out var builtin)) var theme = Get(slug);
{ // Defensive — idempotent and cheap, so any future theme source
_active = builtin; // that forgets the cache fill still ends up with a populated one.
_active.RecomputeAbgrCache(); theme.RecomputeAbgrCache();
_activeCustomPath = null; _active = theme;
return;
} }
var customTheme = LoadCustomBySlug(slug, out var customPath); // 0x80070020 = SHARING_VIOLATION, 0x80070021 = LOCK_VIOLATION. Other
if (customTheme is not null) // IO failures are permanent and get the theme dropped instead of retried.
{
_active = customTheme;
// Defensive — ensures any future theme source always gets a populated cache.
_active.RecomputeAbgrCache();
_activeCustomPath = customPath;
// Force a first-tick reload-check after the switch so the stamp
// baseline is established on the next RefreshActiveIfStale call.
_lastActiveStamp = DateTime.MinValue;
return;
}
// Fallback: neither built-in nor custom matched. Drop to default
// and clear the active custom path so RefreshActiveIfStale stays idle.
_active = _builtIns[DefaultSlug];
_active.RecomputeAbgrCache();
_activeCustomPath = null;
}
// 1Hz-throttled disk-stat on the currently active custom theme file.
// When the file's LastWriteTime moves forward (editor save), reload the
// theme via Get() so the user sees the edit immediately without
// re-selecting in the picker. Built-in themes short-circuit; custom
// themes without an _activeCustomPath (e.g. Switch fell to default)
// short-circuit too.
public void RefreshActiveIfStale()
{
var now = Environment.TickCount64;
if (now - _lastActiveStampCheckMs < ActiveStampPollIntervalMs)
return;
_lastActiveStampCheckMs = now;
if (_active.IsBuiltIn)
return;
var path = _activeCustomPath;
if (path is null || !File.Exists(path))
return;
var stamp = File.GetLastWriteTimeUtc(path);
if (!ThemeStampDiff.IsStale(_lastActiveStamp, stamp))
return;
_lastActiveStamp = stamp;
// Get() re-runs RefreshCustomCache which picks up the new content
// (the cache keys by path + LastWriteTime, so a mtime bump invalidates).
// RecomputeAbgrCache happens inside RefreshCustomCache on cache miss.
var reloaded = Get(_active.Slug);
_active = reloaded;
}
// 0x80070020 = SHARING_VIOLATION, 0x80070021 = LOCK_VIOLATION.
// Other IO failures are permanent — theme is dropped instead of retried.
internal static bool IsRecoverableFileLock(Exception? ex) internal static bool IsRecoverableFileLock(Exception? ex)
{ {
if (ex is not IOException io) if (ex is not IOException io)
@@ -153,30 +74,19 @@ public sealed class ThemeRegistry
return code == 0x80070020u || code == 0x80070021u; return code == 0x80070020u || code == 0x80070021u;
} }
// Slug -> Theme lookup with the source path as an out-param so the // Custom-Themes werden lazy aus dem Verzeichnis geladen, Cache mit
// Switch path can remember which file backs the active custom theme. // LastWriteTime-Token. Eine geänderte JSON wird beim nächsten Lookup
// Pure reverse-lookup over the existing _customCache: that cache is // neu eingelesen.
// already Path -> (Theme, Stamp), so iterating it costs nothing, private Theme? LoadCustomBySlug(string slug)
// avoids a re-parse of every JSON, and keeps the parse logic (and
// the recoverable-file-lock recovery) confined to RefreshCustomCache.
// The cache must be warm before this runs; Plugin.LoadAsync triggers
// a one-time warm-up via AllCustom() before the first Switch call.
private Theme? LoadCustomBySlug(string slug, out string? sourcePath)
{ {
sourcePath = null;
if (_customThemesDir is null) if (_customThemesDir is null)
return null; return null;
if (!Directory.Exists(_customThemesDir)) if (!Directory.Exists(_customThemesDir))
return null; return null;
foreach (var kvp in _customCache) foreach (var theme in RefreshCustomCache())
{ if (string.Equals(theme.Slug, slug, StringComparison.OrdinalIgnoreCase))
if (string.Equals(kvp.Value.Theme.Slug, slug, StringComparison.OrdinalIgnoreCase)) return theme;
{
sourcePath = kvp.Key;
return kvp.Value.Theme;
}
}
return null; return null;
} }
@@ -205,8 +115,9 @@ public sealed class ThemeRegistry
} }
catch (Exception ex) when (IsRecoverableFileLock(ex)) catch (Exception ex) when (IsRecoverableFileLock(ex))
{ {
// Editor mid-save: keep last known good, retry on next refresh. // Editor mid-save: keep the cached snapshot, leave the stamp
Plugin.LogProxy.Debug( // alone so the next refresh retries automatically.
Plugin.Log.Debug(
$"Custom theme {Path.GetFileName(path)} is locked, keeping last known good" $"Custom theme {Path.GetFileName(path)} is locked, keeping last known good"
); );
if (cached.Theme is not null) if (cached.Theme is not null)
-20
View File
@@ -1,20 +0,0 @@
namespace HellionChat.Themes;
// Pure stale-check for the v1.4.8 B2 theme-auto-refresh-on-active path.
// Lives in a free helper class so the Build-Suite can exercise the diff
// rules without instantiating ThemeRegistry (which touches the Dalamud
// log proxy and the filesystem). The rules:
// - DateTime.MinValue on the current stat means we could not read the
// file -- hold the last known good (return false).
// - Equal stamps mean no change since we last saw it.
// - Any other difference, including the first observation where lastSeen
// is MinValue, counts as stale and triggers a reload.
internal static class ThemeStampDiff
{
public static bool IsStale(System.DateTime lastSeen, System.DateTime current)
{
if (current == System.DateTime.MinValue)
return false;
return current != lastSeen;
}
}
+2 -1
View File
@@ -1,6 +1,7 @@
namespace HellionChat.Themes; namespace HellionChat.Themes;
// Optional per-theme; reserved as an extension point for future theme slots. // Optional pro Theme. v1.1.0 nutzt das nicht aktiv; ist als Erweiterungspunkt
// für zukünftige Theme-Slots vorbereitet.
public sealed record ThemeTypography( public sealed record ThemeTypography(
float? OverrideGlobalFontSizePt = null, float? OverrideGlobalFontSizePt = null,
float? OverrideSymbolsFontSizePt = null float? OverrideSymbolsFontSizePt = null
+52 -15
View File
@@ -1,17 +1,34 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Deterministic hash-based color and icon tinting for Auto-Tell sidebar tabs. /// <summary>
// Same tell partner (name+world) always produces the same color and icon across /// Hash-Color-Tinting für Auto-Tell-Tabs in der Sidebar (v1.2.0).
// sessions. Pure string logic, no Dalamud dependency — testable without game refs. /// Differenziert Tells visuell ohne dass User pro Tab manuell ein
/// Custom-Icon setzen muss. Gleicher Tell-Partner (Name+World) liefert
/// konsistent dieselbe Farbe über Sessions hinweg.
///
/// Kuratierte 12-Farb-Palette aus dem Hellion-Theme-Pool: alle saturiert
/// mid-bright, lesbar gegen Dark-Theme-Backgrounds. Bei realistischen
/// 1-5 parallelen Tells ist Kollisions-Wahrscheinlichkeit gering.
///
/// Reine String-Logik (kein Dalamud-Dep) — testbar im HellionChat.Tests-
/// Projekt das ohne Dalamud-Reference baut.
/// </summary>
internal static class AutoTellTabTint internal static class AutoTellTabTint
{ {
// Fallback for invalid input (empty name or world=0). White matches /// <summary>
// TextPrimary default so the sidebar stays visually consistent. /// Fallback bei ungültigem Input (leerer Name, World=0). Standard-
/// Text-Color (weiß) — passt mit existierendem TextPrimary-Default
/// zusammen, sodass die Sidebar visuell konsistent bleibt.
/// </summary>
public const uint Fallback = 0xFFFFFFFFu; public const uint Fallback = 0xFFFFFFFFu;
// 12 saturated mid-bright colors from the built-in theme pool, readable /// <summary>
// on dark backgrounds. Collision risk is low at realistic 1-5 active tells. /// 12 saturierte mid-bright Farben aus den 5 Built-In-Themes
// RGBA format, matching ColourUtil.RgbaToAbgr convention. /// (Hellion-Arctic, Chat2-Klassik, Event-Horizon, Moonlit-Bloom,
/// Mint-Grove). Reihenfolge ist deterministisch — Hash-Index wählt
/// Farbe per Modulo. RGBA-Format (passt zu ColourUtil.RgbaToAbgr-
/// Konvention im restlichen Code).
/// </summary>
public static readonly IReadOnlyList<uint> Palette = new uint[] public static readonly IReadOnlyList<uint> Palette = new uint[]
{ {
0x00BED2FFu, // Arctic Cyan 0x00BED2FFu, // Arctic Cyan
@@ -28,19 +45,30 @@ internal static class AutoTellTabTint
0xE85D04FFu, // Deep Ember 0xE85D04FFu, // Deep Ember
}; };
/// <summary>
/// Liefert eine konsistente Tint-Color für einen Tell-Partner.
/// Hash basiert auf "Name@World" — Cross-World-Namen kollidieren
/// nur bei Hash-Bucket-Kollision, nicht durch Identitäts-Annahme.
/// </summary>
public static uint For(string name, uint world) public static uint For(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return Fallback; return Fallback;
// Mask to positive range so modulo always yields a valid index. // GetHashCode kann negativ sein; Bitmaske auf positive Range
// damit Modulo-Division immer einen validen Index liefert.
var key = $"{name}@{world}"; var key = $"{name}@{world}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return Palette[(int)(hash % Palette.Count)]; return Palette[(int)(hash % Palette.Count)];
} }
// 7 visually distinct FA glyphs that make sense in a tell context. /// <summary>
// Excludes cog/comment/users — those read as system or group tabs. /// Tell-spezifischer Icon-Pool. 7 visuell distinkte FontAwesome-Glyphen
/// die im Tell-Kontext sinnvoll wirken (envelope = Tell-Default, star/
/// heart/bell = personalisiert, bookmark/flag/fire = markiert/wichtig).
/// Bewusst kein cog/comment/users — die wären für System-/Group-Tabs
/// reserviert und würden im Tell-Bereich verwirrend wirken.
/// </summary>
public static readonly IReadOnlyList<string> IconPool = new[] public static readonly IReadOnlyList<string> IconPool = new[]
{ {
"envelope", "envelope",
@@ -52,17 +80,26 @@ internal static class AutoTellTabTint
"fire", "fire",
}; };
// "envelope" matches the tell context better than the old hardcoded "clock". /// <summary>
/// Fallback-Icon bei ungültigem Input. "envelope" passt semantisch zum
/// Tell-Kontext besser als das alte hardcoded "clock".
/// </summary>
public const string IconFallback = "envelope"; public const string IconFallback = "envelope";
/// <summary>
/// Liefert ein konsistentes Icon-Glyph für einen Tell-Partner.
/// Nutzt einen anderen Hash-Bias als For() (Color), damit Icon und
/// Color unabhängig variieren — gibt 7 × 12 = 84 distinct Combinations.
/// </summary>
public static string IconFor(string name, uint world) public static string IconFor(string name, uint world)
{ {
if (string.IsNullOrEmpty(name) || world == 0) if (string.IsNullOrEmpty(name) || world == 0)
return IconFallback; return IconFallback;
// Reversed key ("world@name") gives icon and color independent variation // Anderer Hash-Bias als For() (verschiedene Modulo-Basis): wir
// so the same tell partner doesn't always get the same color+icon pair. // nutzen "world@name" statt "name@world" damit Icon und Color
// 7 icons x 12 colors = 84 distinct combinations. // nicht synchron variieren. Ohne Bias-Trennung würden alle Tells
// mit derselben Color auch dasselbe Icon haben.
var key = $"{world}@{name}"; var key = $"{world}@{name}";
var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF); var hash = (uint)(key.GetHashCode() & 0x7FFFFFFF);
return IconPool[(int)(hash % IconPool.Count)]; return IconPool[(int)(hash % IconPool.Count)];
+48 -23
View File
@@ -8,10 +8,16 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Input bar component for pop-out windows. Render() is a stub — the main // Hellion Chat — v0.6.0 input bar component for pop-out windows.
// window input layer stays in ChatLogWindow to avoid a high-risk extract. //
// RenderCompact() is the only v0.6.0 deliverable; Render() can be filled // Pragmatischer Refactor-Scope: Render() ist ein leerer Marker-Stub für
// in a later cycle if needed. // das Hauptfenster — der bestehende Input-Layer in ChatLogWindow bleibt
// unangetastet, weil ein 400-Zeilen-Extract aus einem 1926-Zeilen-File
// das v0.6.0-Risiko unverhältnismäßig erhöhen würde. Pop-Outs nutzen
// ausschließlich RenderCompact(), das ist der ganze v0.6.0-Mehrwert.
// Sollte das Hauptfenster selber später eine Compact-Variante brauchen
// (oder das große Extract sich aus anderem Grund lohnen), kann Render()
// in einem späteren Cycle gefüllt werden.
public sealed class ChatInputBar public sealed class ChatInputBar
{ {
private readonly Plugin _plugin; private readonly Plugin _plugin;
@@ -29,17 +35,22 @@ public sealed class ChatInputBar
public InputState State => _state; public InputState State => _state;
public bool IsFocused { get; private set; } public bool IsFocused { get; private set; }
// Stub — main window input is handled in ChatLogWindow. // Stub. v0.6.0 belässt den Hauptfenster-Input wie er ist.
public void Render() { } public void Render() { }
// Compact layout for pop-out windows: channel icon button left, text // Compact rendering for pop-out windows.
// input right. Auto-translate is intentionally excluded — the upstream
// popup isn't instanciable per window without a larger refactor, and
// typical pop-out use cases rarely need it. Can be added later if
// tester feedback warrants it.
// //
// Channel switching is global via Plugin.Functions.Chat (FFXIV API). // v0.6.0 Compact-Layout: Channel-Icon-Button links (Background-Farbe
// Text buffer and history cursor are independent per pop-out. // aus ChatColours), Text-Input rechts daneben. Auto-Translate-Picker
// ist bewusst NICHT im Compact-Mode (Spec-Abweichung Layout D → A).
// Rechtfertigung: das Hauptfenster-Auto-Complete-Popup ist nicht ohne
// grossen Refactor pro Window instanzierbar; typische Pop-Out-Use-Cases
// (FC-Greeter, Club-Hostess) brauchen Auto-Translate selten dort.
// Eigene Compact-Auto-Complete-Implementation kann ein späterer
// Cycle nachreichen wenn Tester-Feedback das verlangt.
//
// Channel-Switch wirkt via Plugin.Functions.Chat global (FFXIV-API).
// Pro Pop-Out unabhängig bleiben Text-Buffer und History-Cursor.
public void RenderCompact() public void RenderCompact()
{ {
var tab = _activeTabAccessor(); var tab = _activeTabAccessor();
@@ -53,15 +64,18 @@ public sealed class ChatInputBar
private void DrawCompactInput(Tab tab) private void DrawCompactInput(Tab tab)
{ {
// Input takes the whole remaining width — no auto-translate button
// reserved on the right side in v0.6.0 (see RenderCompact comment).
var inputWidth = ImGui.GetContentRegionAvail().X; var inputWidth = ImGui.GetContentRegionAvail().X;
if (inputWidth < 60f) if (inputWidth < 60f)
inputWidth = 60f; inputWidth = 60f;
ImGui.SetNextItemWidth(inputWidth); ImGui.SetNextItemWidth(inputWidth);
// CallbackHistory wires Up/Down navigation to InputHistoryService. // CallbackHistory wires up Up/Down navigation against the shared
// Submit detected via IsItemDeactivated + Enter, not EnterReturnsTrue // InputHistoryService. Submit is detected the same way the main
// (matches ChatLogWindow behavior). // window does it: via IsItemDeactivated + Enter, NOT EnterReturnsTrue
// (matching v0.5.x ChatLogWindow.cs behavior).
const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory; const ImGuiInputTextFlags flags = ImGuiInputTextFlags.CallbackHistory;
ImGui.InputText( ImGui.InputText(
$"##chat-compact-input-{tab.Identifier}", $"##chat-compact-input-{tab.Identifier}",
@@ -86,8 +100,9 @@ public sealed class ChatInputBar
private void SubmitCompact(Tab tab) => private void SubmitCompact(Tab tab) =>
CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal); CompactInputSubmitter.TrySubmit(_state, tab, _host.SendChatBoxFromExternal);
// History navigation callback. Cursor math delegated to // History-navigation callback for the compact input. Cursor math is
// CompactInputHistoryNavigator; ImGui buffer splice stays here. // delegated to CompactInputHistoryNavigator; only the ImGui buffer
// splice stays here because it needs the live callback data.
// TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs // TEST-MIRROR: ../_Helpers/CompactInputHistoryNavigator.cs
private int CompactCallback(scoped ref ImGuiInputTextCallbackData data) private int CompactCallback(scoped ref ImGuiInputTextCallbackData data)
{ {
@@ -133,7 +148,7 @@ public sealed class ChatInputBar
var v3 = ColourUtil.RgbaToVector3(rgba); var v3 = ColourUtil.RgbaToVector3(rgba);
var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f); var bg = new Vector4(v3.X, v3.Y, v3.Z, 1f);
// Black foreground on bright backgrounds, white on dark. // Compute readable foreground — black on bright, white on dark
var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z; var luminance = 0.2126f * v3.X + 0.7152f * v3.Y + 0.0722f * v3.Z;
var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f); var fg = luminance > 0.55f ? new Vector4(0f, 0f, 0f, 1f) : new Vector4(1f, 1f, 1f, 1f);
@@ -145,7 +160,8 @@ public sealed class ChatInputBar
using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, bg))
using (ImRaii.PushColor(ImGuiCol.Text, fg)) using (ImRaii.PushColor(ImGuiCol.Text, fg))
{ {
// Single-letter glyph as a quick visual cue until a proper icon font lands. // Single-letter glyph derived from the channel — quick visual cue
// until we have a proper icon font available in the compact bar.
var label = ChannelGlyph(inputType); var label = ChannelGlyph(inputType);
if ( if (
ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize)) ImGui.Button($"{label}##chan-compact", new Vector2(buttonSize, buttonSize))
@@ -155,9 +171,13 @@ public sealed class ChatInputBar
} }
if (tab.Channel is not null && ImGui.IsItemHovered()) if (tab.Channel is not null && ImGui.IsItemHovered())
{
ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled); ImGui.SetTooltip(Resources.Language.ChatLog_SwitcherDisabled);
}
else if (ImGui.IsItemHovered()) else if (ImGui.IsItemHovered())
{
ImGui.SetTooltip(inputType.Name()); ImGui.SetTooltip(inputType.Name());
}
using (var popup = ImRaii.Popup(popupId)) using (var popup = ImRaii.Popup(popupId))
{ {
@@ -201,12 +221,17 @@ public sealed class ChatInputBar
_ => "?", _ => "?",
}; };
// Forwards a tab-cycle keybind delta to the host (single source of truth). // Forwards a tab-cycle keybind delta to the host so all windows
public void HandleKeybindForward(int delta) => _host.ChangeTabDelta(delta); // navigate the same active-tab pointer (single source of truth).
public void HandleKeybindForward(int delta)
{
_host.ChangeTabDelta(delta);
}
} }
// Per-window input state. Each ChatInputBar owns one so pop-outs and the // Per-window input state. Each ChatInputBar instance owns one of these
// main window keep independent buffers and history cursors. // so pop-outs and the main window keep independent buffers and channels
// (State-Sync-Entscheidung A in the v0.6.0 spec).
public sealed class InputState public sealed class InputState
{ {
public string Buffer = string.Empty; public string Buffer = string.Empty;
+173 -321
View File
@@ -52,8 +52,10 @@ public sealed class ChatLogWindow : Window
private int ActivatePos = -1; private int ActivatePos = -1;
internal string Chat = string.Empty; internal string Chat = string.Empty;
// Input history extracted into InputHistoryService so pop-out windows share // Hellion Chat — v0.6.0 input history was extracted into
// the same Up/Down history. Cursor stays window-local (independent navigation). // InputHistoryService so pop-out windows with their own ChatInputBar
// share the same Up/Down history with the main window. The cursor
// stays window-local because each window navigates independently.
private int InputBacklogIdx = -1; private int InputBacklogIdx = -1;
public bool TellSpecial; public bool TellSpecial;
private readonly Stopwatch LastResize = new(); private readonly Stopwatch LastResize = new();
@@ -72,8 +74,11 @@ public sealed class ChatLogWindow : Window
public Vector2 LastWindowPos { get; private set; } = Vector2.Zero; public Vector2 LastWindowPos { get; private set; } = Vector2.Zero;
public Vector2 LastWindowSize { get; private set; } = Vector2.Zero; public Vector2 LastWindowSize { get; private set; } = Vector2.Zero;
// Guards against off-screen positions after a display layout change. // Window position recovery: guards against off-screen positions after a
// One-shot bounds check on first draw; manual reset button bypasses it. // display layout change (monitor disconnected, resolution changed). On
// the first draw after plugin load we run a one-shot bounds check to see
// whether the stored position still overlaps any visible viewport area.
// The manual reset button in the settings forces the position regardless.
private bool DidOnLoadBoundsCheck; private bool DidOnLoadBoundsCheck;
internal bool RequestPositionReset { get; set; } internal bool RequestPositionReset { get; set; }
@@ -90,10 +95,6 @@ public sealed class ChatLogWindow : Window
private bool PlayedClosingSound = true; private bool PlayedClosingSound = true;
private bool DrewThisFrame; private bool DrewThisFrame;
// One-shot guard so a recurring draw failure doesn't spam the
// notification stack frame-by-frame. Resets only on next plugin reload.
private bool NotifiedDrawFailure;
private long FrameTime; // set every frame private long FrameTime; // set every frame
internal long LastActivityTime = Environment.TickCount64; internal long LastActivityTime = Environment.TickCount64;
@@ -111,7 +112,9 @@ public sealed class ChatLogWindow : Window
IsOpen = true; IsOpen = true;
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
// AllowBackgroundBlur is set centrally in Plugin.Setup after AddWindow. // AllowBackgroundBlur wird nach AddWindow zentral in Plugin.Setup
// für alle registrierten Windows gesetzt — keine Per-Window-Logik
// hier nötig.
PayloadHandler = new PayloadHandler(this); PayloadHandler = new PayloadHandler(this);
HandlerLender = new Lender<PayloadHandler>(() => new PayloadHandler(this)); HandlerLender = new Lender<PayloadHandler>(() => new PayloadHandler(this));
@@ -119,8 +122,10 @@ public sealed class ChatLogWindow : Window
SetUpTextCommandChannels(); SetUpTextCommandChannels();
SetUpAllCommands(); SetUpAllCommands();
// Cache wrapper instances so Dispose can detach the same event objects // Cache the registered wrapper instances so Dispose can detach the same
// without going through Register() again. // event objects the constructor attached to, without going through
// Register() again (which would re-create the wrapper if the command
// happened to be missing from the dictionary).
_clearHellionCommand = Plugin.Commands.Register( _clearHellionCommand = Plugin.Commands.Register(
"/clearhellion", "/clearhellion",
"Clear the Hellion Chat log" "Clear the Hellion Chat log"
@@ -272,12 +277,9 @@ public sealed class ChatLogWindow : Window
} }
} }
if ( if (targetChannel == null || !GameFunctions.Chat.ValidAnyLinkshell(targetChannel.Value))
targetChannel == null
|| !GameFunctions.Chat.IsChannelOrExistingLinkshell(targetChannel.Value)
)
{ {
Plugin.LogProxy.Warning( Plugin.Log.Warning(
$"Channel was set to an invalid value '{targetChannel}', ignoring" $"Channel was set to an invalid value '{targetChannel}', ignoring"
); );
return; return;
@@ -331,11 +333,11 @@ public sealed class ChatLogWindow : Window
{ {
case "hide": case "hide":
CurrentHideState = HideState.User; CurrentHideState = HideState.User;
Plugin.LogProxy.Verbose("HideState: → User (chat hide command)"); Plugin.Log.Verbose("HideState: → User (chat hide command)");
break; break;
case "show": case "show":
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.LogProxy.Verbose("HideState: → None (chat show command)"); Plugin.Log.Verbose("HideState: → None (chat show command)");
break; break;
case "toggle": case "toggle":
CurrentHideState = CurrentHideState switch CurrentHideState = CurrentHideState switch
@@ -345,7 +347,7 @@ public sealed class ChatLogWindow : Window
HideState.None => HideState.User, HideState.None => HideState.User,
_ => CurrentHideState, _ => CurrentHideState,
}; };
Plugin.LogProxy.Verbose($"HideState: → {CurrentHideState} (chat toggle command)"); Plugin.Log.Verbose($"HideState: → {CurrentHideState} (chat toggle command)");
break; break;
} }
} }
@@ -395,10 +397,11 @@ public sealed class ChatLogWindow : Window
} }
} }
// Delegates to InputHistoryService so pop-out ChatInputBar instances share
// history. Deduplication lives inside the service.
private void AddBacklog(string message) private void AddBacklog(string message)
{ {
// v0.6.0 — delegates to the shared InputHistoryService so pop-out
// ChatInputBar instances see the same history. Move-to-newest
// deduplication lives inside the service.
InputHistoryService.Push(message); InputHistoryService.Push(message);
} }
@@ -414,14 +417,16 @@ public sealed class ChatLogWindow : Window
if (Plugin.Config.PreviewPosition is PreviewPosition.Inside) if (Plugin.Config.PreviewPosition is PreviewPosition.Inside)
height -= Plugin.InputPreview.PreviewHeight; height -= Plugin.InputPreview.PreviewHeight;
// Header toolbar height is not subtracted by GetContentRegionAvail automatically // Hellion Chat v0.6.1 — Header-Toolbar rendert auf Window-Ebene über
// (it renders outside the normal layout path), so we subtract it explicitly. // einem horizontalen Layout-Pfad und wird von GetContentRegionAvail
// The hint banner renders before this block so ImGui already accounts for it. // hier drin NICHT automatisch berücksichtigt, daher expliziter Abzug.
// Banner dagegen rendert in DrawChatLog VOR diesem ganzen Block und
// ImGui zieht seine Höhe automatisch von GetContentRegionAvail ab,
// weil der Cursor schon weiter unten steht — kein eigener Abzug.
height -= ImGui.GetFrameHeightWithSpacing(); height -= ImGui.GetFrameHeightWithSpacing();
// StatusBar.Height now bakes in its own DPI-aware 2px spacer, so the // v1.2.0 — Status-Bar am Window-Boden reserviert 22 px + 2 px Spacing.
// window reservation is just Height -- no extra +2 (v1.4.8 B1). height -= StatusBar.Height + 2;
height -= StatusBar.Height;
return height; return height;
} }
@@ -442,24 +447,11 @@ public sealed class ChatLogWindow : Window
private void TabSwitched(Tab newTab, Tab previousTab) private void TabSwitched(Tab newTab, Tab previousTab)
{ {
// Use the fixed channel if set by the user. Otherwise, if the new tab // Use the fixed channel if set by the user, or set it to the current tabs channel if this tab wasn't accessed before
// has no channel state yet (fresh from JSON, never selected this
// session), seed from the previous tab — but deep-clone so we don't
// share TellTarget with the previous tab. Without the clone, a later
// /tell on the new tab would mutate the pinned tab's TellTarget and
// the Party/Linkshell channel would pop back to the pinned tell-mark.
if (newTab.Channel is not null) if (newTab.Channel is not null)
{
newTab.CurrentChannel.Channel = newTab.Channel.Value; newTab.CurrentChannel.Channel = newTab.Channel.Value;
}
else if (newTab.CurrentChannel.Channel is InputChannel.Invalid) else if (newTab.CurrentChannel.Channel is InputChannel.Invalid)
{ newTab.CurrentChannel = previousTab.CurrentChannel;
newTab.CurrentChannel = previousTab.CurrentChannel.Clone();
Plugin.LogProxy.Debug(
$"[Tab] '{newTab.Name}' seeded channel from '{previousTab.Name}' "
+ $"(Channel={newTab.CurrentChannel.Channel}, TellTarget={newTab.CurrentChannel.TellTarget?.ToTargetString() ?? "null"})"
);
}
SetChannel(newTab.CurrentChannel.Channel); SetChannel(newTab.CurrentChannel.Channel);
} }
@@ -483,14 +475,14 @@ public sealed class ChatLogWindow : Window
if (Plugin.Config.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle) if (Plugin.Config.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle)
{ {
CurrentHideState = HideState.Battle; CurrentHideState = HideState.Battle;
Plugin.LogProxy.Verbose("HideState: None → Battle"); Plugin.Log.Verbose("HideState: None → Battle");
} }
// If the chat is hidden because of battle, we reset it here // If the chat is hidden because of battle, we reset it here
if (CurrentHideState is HideState.Battle && !Plugin.InBattle) if (CurrentHideState is HideState.Battle && !Plugin.InBattle)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.LogProxy.Verbose("HideState: Battle → None"); Plugin.Log.Verbose("HideState: Battle → None");
} }
// if the chat has no hide state and in a cutscene, set the hide state to cutscene // if the chat has no hide state and in a cutscene, set the hide state to cutscene
@@ -503,7 +495,7 @@ public sealed class ChatLogWindow : Window
if (Plugin.Functions.Chat.CheckHideFlags()) if (Plugin.Functions.Chat.CheckHideFlags())
{ {
CurrentHideState = HideState.Cutscene; CurrentHideState = HideState.Cutscene;
Plugin.LogProxy.Verbose("HideState: None → Cutscene"); Plugin.Log.Verbose("HideState: None → Cutscene");
} }
} }
@@ -514,7 +506,7 @@ public sealed class ChatLogWindow : Window
&& !Plugin.GposeActive && !Plugin.GposeActive
) )
{ {
Plugin.LogProxy.Verbose($"HideState: {CurrentHideState} → None (cutscene/gpose ended)"); Plugin.Log.Verbose($"HideState: {CurrentHideState} → None (cutscene/gpose ended)");
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
} }
@@ -522,14 +514,14 @@ public sealed class ChatLogWindow : Window
if (CurrentHideState == HideState.Cutscene && Activate) if (CurrentHideState == HideState.Cutscene && Activate)
{ {
CurrentHideState = HideState.CutsceneOverride; CurrentHideState = HideState.CutsceneOverride;
Plugin.LogProxy.Verbose("HideState: Cutscene → CutsceneOverride (user activate)"); Plugin.Log.Verbose("HideState: Cutscene → CutsceneOverride (user activate)");
} }
// if the user hid the chat and is now activating chat, reset the hide state // if the user hid the chat and is now activating chat, reset the hide state
if (CurrentHideState == HideState.User && Activate) if (CurrentHideState == HideState.User && Activate)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.LogProxy.Verbose("HideState: User → None (activate)"); Plugin.Log.Verbose("HideState: User → None (activate)");
} }
if ( if (
@@ -636,15 +628,6 @@ public sealed class ChatLogWindow : Window
IsOpen = true; IsOpen = true;
} }
// v1.4.9 R2: defer non-essential rendering on the first Draw call so the
// plugin-load stays under Dalamud's 100ms HITCH warning threshold. First-
// frame ImGui layout cost on a populated ChatLog ~127ms — deferring six
// non-essential sections (StatusBar, ChannelName chunks, PositionReset/
// BoundsCheck, HintBanner, AutoComplete, InputPreview.CalculatePreview)
// shaves ~33ms down to ~94ms. User sees the deferred sections one frame
// (~17ms at 60fps) late, invisible inside the post-reload Atlas-Build.
private bool _firstFrameDone;
public override void Draw() public override void Draw()
{ {
DrewThisFrame = true; DrewThisFrame = true;
@@ -652,39 +635,15 @@ public sealed class ChatLogWindow : Window
{ {
DrawChatLog(); DrawChatLog();
AddPopOutsToDraw(); AddPopOutsToDraw();
// v1.4.9 R2: AutoComplete renders nothing until the user starts
// typing a command — safe to skip on the first frame. ~6ms.
if (_firstFrameDone)
DrawAutoComplete(); DrawAutoComplete();
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Error drawing Chat Log window"); Plugin.Log.Error(ex, "Error drawing Chat Log window");
if (!NotifiedDrawFailure)
{
Plugin.Notification.AddNotification(
new Dalamud.Interface.ImGuiNotification.Notification
{
Title = "Hellion Chat",
Content = "A drawing error occurred. Check /xllog for details.",
Type = Dalamud.Interface.ImGuiNotification.NotificationType.Warning,
InitialDuration = TimeSpan.FromSeconds(20),
}
);
NotifiedDrawFailure = true;
}
// Prevent recurring draw failures from constantly trying to grab // Prevent recurring draw failures from constantly trying to grab
// input focus, which breaks every other ImGui window. // input focus, which breaks every other ImGui window.
Activate = false; Activate = false;
} }
finally
{
// Flag flips after the first Draw completes (success or caught
// exception). Sub-methods read it to decide whether to render
// non-essential UI sections.
_firstFrameDone = true;
}
} }
private static bool IsChatMode => private static bool IsChatMode =>
@@ -700,14 +659,10 @@ public sealed class ChatLogWindow : Window
LastWindowSize = currentSize; LastWindowSize = currentSize;
LastWindowPos = ImGui.GetWindowPos(); LastWindowPos = ImGui.GetWindowPos();
// v1.4.9 R2: skip the bounds-check chain on the first frame. The // Window position recovery. Manual reset takes precedence and snaps
// EnsureWindowOnScreen viewport iteration is ~10ms first-frame and // the window to the safe default unconditionally; the one-shot
// not user-visible — frame 1 catches the same check before the // on-load check only fires when the persisted position has no
// user notices a mispositioned window. // overlap with any visible viewport area.
if (_firstFrameDone)
{
// Manual reset snaps unconditionally; on-load check only fires when the
// stored position has no overlap with any visible viewport.
if (RequestPositionReset) if (RequestPositionReset)
{ {
RequestPositionReset = false; RequestPositionReset = false;
@@ -719,7 +674,6 @@ public sealed class ChatLogWindow : Window
DidOnLoadBoundsCheck = true; DidOnLoadBoundsCheck = true;
EnsureWindowOnScreen("on-load"); EnsureWindowOnScreen("on-load");
} }
}
if (resized) if (resized)
LastResize.Restart(); LastResize.Restart();
@@ -727,16 +681,14 @@ public sealed class ChatLogWindow : Window
LastViewport = ImGui.GetWindowViewport().Handle; LastViewport = ImGui.GetWindowViewport().Handle;
WasDocked = ImGui.IsWindowDocked(); WasDocked = ImGui.IsWindowDocked();
// v1.4.9 R2: CalculatePreview triggers InputPreview's first-frame if (IsChatMode && Plugin.InputPreview.IsDrawable)
// lazy init (~3-5ms). User-typing-driven, safe to defer one frame.
if (_firstFrameDone && IsChatMode && Plugin.InputPreview.IsDrawable)
Plugin.InputPreview.CalculatePreview(); Plugin.InputPreview.CalculatePreview();
// Render the hint banner first so it sits above the tab area at full // Hellion Chat v0.6.1 — render the one-time hint banner first so it
// window width. ImGui accounts for its height automatically. // sits above the tab area / sidebar in full window width. ImGui's
// v1.4.9 R2: skip on first frame (~3-5ms layout cost). The banner // GetContentRegionAvail subtracts its height automatically because the
// is a v0.6.1 migration notice that returns the same result frame 1. // cursor advances past it before the message log calls
if (_firstFrameDone) // GetRemainingHeightForMessageLog, so we don't track the height here.
DrawV061HintBannerIfNeeded(); DrawV061HintBannerIfNeeded();
if (Plugin.Config.SidebarTabView) if (Plugin.Config.SidebarTabView)
@@ -761,7 +713,8 @@ public sealed class ChatLogWindow : Window
DrawChannelName(activeTab); DrawChannelName(activeTab);
} }
// inputColour computed up front so the channel selector button can share it. // v1.0.2 — compute inputColour up front so the channel selector button
// can also tint with it (existing input-text push remains below).
var inputType = activeTab.CurrentChannel.UseTempChannel var inputType = activeTab.CurrentChannel.UseTempChannel
? activeTab.CurrentChannel.TempChannel.ToChatType() ? activeTab.CurrentChannel.TempChannel.ToChatType()
: activeTab.CurrentChannel.Channel.ToChatType(); : activeTab.CurrentChannel.Channel.ToChatType();
@@ -970,10 +923,6 @@ public sealed class ChatLogWindow : Window
// v1.2.0 — Bottom-Status-Bar. Letzter Render-Step in DrawChatLog, // v1.2.0 — Bottom-Status-Bar. Letzter Render-Step in DrawChatLog,
// damit alle Zeilen-Operationen davor keine Layout-Sprünge auslösen. // damit alle Zeilen-Operationen davor keine Layout-Sprünge auslösen.
// v1.4.9 R2: skip on the first frame; ~12ms of first-frame layout
// cost. User sees the StatusBar 1 frame (~17ms at 60fps) later
// which is hidden inside the post-reload Atlas-Build window.
if (_firstFrameDone)
Plugin.StatusBar.Draw(Plugin); Plugin.StatusBar.Draw(Plugin);
} }
@@ -1025,16 +974,6 @@ public sealed class ChatLogWindow : Window
private void DrawChannelName(Tab activeTab) private void DrawChannelName(Tab activeTab)
{ {
// v1.4.9 R2: plain-text fallback on the first frame. ReadChannelName
// builds SeString chunks and DrawChunks runs SeString-Renderer layout
// — together ~18ms first-frame. Frame 1 renders the real chunks; the
// user sees the tab name for ~17ms during the post-reload window.
if (!_firstFrameDone)
{
ImGui.TextUnformatted(activeTab.Name);
return;
}
var currentChannel = ReadChannelName(activeTab); var currentChannel = ReadChannelName(activeTab);
if (!currentChannel.SequenceEqual(PreviousChannel)) if (!currentChannel.SequenceEqual(PreviousChannel))
PreviousChannel = currentChannel; PreviousChannel = currentChannel;
@@ -1093,8 +1032,11 @@ public sealed class ChatLogWindow : Window
} }
else else
{ {
// ExtraChat channel names aren't available over IPC by index, // We cannot lookup ExtraChat channel names from index over
// so we skip the name lookup and show the short form instead. // IPC so we just don't show the name if it's the tabs channel.
//
// We don't call channel.ToChatType().Name() as it has the
// long name as used in the settings window.
channelNameChunks = channelNameChunks =
[ [
new TextChunk( new TextChunk(
@@ -1180,8 +1122,8 @@ public sealed class ChatLogWindow : Window
Plugin.CurrentTab.CurrentChannel.TempTellTarget = null; Plugin.CurrentTab.CurrentChannel.TempTellTarget = null;
} }
// ExtraChat linkshell channel switch: call the prefix command through the // Instead of calling SetChannel(), we ask the ExtraChat plugin to set a
// game chat because ExtraChat only registers stub handlers in Dalamud. // channel override by just calling the command directly.
if (channel.Value.IsExtraChatLinkshell()) if (channel.Value.IsExtraChatLinkshell())
{ {
// Check that the command is registered in Dalamud so the game code // Check that the command is registered in Dalamud so the game code
@@ -1227,8 +1169,10 @@ public sealed class ChatLogWindow : Window
]; ];
} }
// Pop-out windows route submission here. The main Chat buffer is briefly // v0.6.0 — pop-out windows route submission through this wrapper.
// used as a vehicle for SendChatBox and restored afterwards. // The main-window Chat buffer is briefly used as a vehicle for
// SendChatBox (which reads it directly) and restored afterwards so
// the main window does not visibly lose any half-typed input.
internal void SendChatBoxFromExternal(Tab tab, string text) internal void SendChatBoxFromExternal(Tab tab, string text)
{ {
var saved = Chat; var saved = Chat;
@@ -1273,7 +1217,7 @@ public sealed class ChatLogWindow : Window
?? activeTab.CurrentChannel.TellTarget; ?? activeTab.CurrentChannel.TellTarget;
if (target != null) if (target != null)
{ {
// ContentId 0: can't send directly, so format as /tell and let the game handle it. // ContentId 0 is a case where we can't directly send messages, so we send a /tell formatted message and let the game handle it
if (target.ContentId == 0) if (target.ContentId == 0)
{ {
trimmed = $"/tell {target.ToTargetString()} {trimmed}"; trimmed = $"/tell {target.ToTargetString()} {trimmed}";
@@ -1439,8 +1383,8 @@ public sealed class ChatLogWindow : Window
var maxLines = Plugin.Config.MaxLinesToRender; var maxLines = Plugin.Config.MaxLinesToRender;
var startLine = messages.Count > maxLines ? messages.Count - maxLines : 0; var startLine = messages.Count > maxLines ? messages.Count - maxLines : 0;
// Card-mode pre-loop: theme/drawList/winLeft/winRight/border are invariant // Card-mode pre-loop hoist: theme/drawList/winLeft/winRight/border
// per DrawMessages call; only cursorY moves per row. // are invariant per DrawMessages call; only cursorY moves per row.
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var drawList = ImGui.GetWindowDrawList(); var drawList = ImGui.GetWindowDrawList();
var winLeft = ImGui.GetWindowPos().X; var winLeft = ImGui.GetWindowPos().X;
@@ -1597,9 +1541,11 @@ public sealed class ChatLogWindow : Window
var lineWidth = ImGui.GetContentRegionAvail().X; var lineWidth = ImGui.GetContentRegionAvail().X;
// v1.2.0 card mode: sender on its own line in channel color, then body, // v1.2.0 — Card-Rows als Default, Compact-Density als Opt-Out.
// then a subtle border as a card separator. // Card-Mode: Sender-Header in Channel-Color auf eigener Zeile,
// Compact mode: sender + space + content on one line via SameLine. // dann Body, dann subtile Border-Bottom als Card-Trenner.
// Compact-Mode: bisheriges Verhalten — Sender + Space + Content
// auf einer Zeile via SameLine.
var useCard = !Plugin.Config.UseCompactDensity; var useCard = !Plugin.Config.UseCompactDensity;
if (useCard) if (useCard)
{ {
@@ -1612,7 +1558,7 @@ public sealed class ChatLogWindow : Window
{ {
DrawChunks(message.Sender, true, handler, lineWidth); DrawChunks(message.Sender, true, handler, lineWidth);
} }
// No SameLine — body renders on its own line. // KEIN SameLine — Body landet auf eigener Zeile.
} }
// We need to draw something otherwise the item visibility check below won't work. // We need to draw something otherwise the item visibility check below won't work.
@@ -1626,7 +1572,8 @@ public sealed class ChatLogWindow : Window
else else
DrawChunks(message.Content, true, handler, lineWidth); DrawChunks(message.Content, true, handler, lineWidth);
// Border bottom as card separator. Alpha reduced to 0x33 for subtlety. // Subtile Border-Bottom als Card-Trenner. Border-Farbe mit
// reduzierter Alpha (RGBA → 0x33) für dezente Trennung.
{ {
var rowEndY = ImGui.GetCursorScreenPos().Y; var rowEndY = ImGui.GetCursorScreenPos().Y;
drawList.AddLine( drawList.AddLine(
@@ -1668,7 +1615,7 @@ public sealed class ChatLogWindow : Window
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Warning(ex, "Error drawing chat log"); Plugin.Log.Warning(ex, "Error drawing chat log");
} }
} }
@@ -1699,22 +1646,19 @@ public sealed class ChatLogWindow : Window
if (!tabItem.Success) if (!tabItem.Success)
continue; continue;
// Active-tab underline pill (2px accent). No native ImGui underline API, // v1.2.0 — Active-Tab-Underline-Pill (2 px Akzent statt Background-Fill).
// so we use a direct DrawList pass. Pill height scales with GlobalScale // Bewusst direkt nach TabItem-Setup; GetItemRectMin/Max referenziert noch
// and all coordinates round to physical pixels so the line stays crisp // das Tab. ImGui hat keine native Underline-API, daher direkter DrawList-Pass.
// on 125/150% DPI setups instead of bleeding into a sub-pixel blur.
{ {
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
var max = ImGui.GetItemRectMax(); var max = ImGui.GetItemRectMax();
var pillHeight = MathF.Max(1f, MathF.Round(2f * ImGuiHelpers.GlobalScale)); const float pillHeight = 2f;
var yBottom = MathF.Round(max.Y);
var yTop = yBottom - pillHeight;
ImGui ImGui
.GetWindowDrawList() .GetWindowDrawList()
.AddRectFilled( .AddRectFilled(
new Vector2(MathF.Round(min.X), yTop), new Vector2(min.X, max.Y - pillHeight),
new Vector2(MathF.Round(max.X), yBottom), new Vector2(max.X, max.Y),
ColourUtil.RgbaToAbgr(theme.Colors.Accent) ColourUtil.RgbaToAbgr(theme.Colors.Accent)
); );
} }
@@ -1733,34 +1677,10 @@ public sealed class ChatLogWindow : Window
Plugin.WantedTab = null; Plugin.WantedTab = null;
} }
// Sidebar render order: persistent tabs in their original Plugin.Config.Tabs
// position, then pinned TempTabs, then unpinned TempTabs. Returns indices
// into Plugin.Config.Tabs so tabI in the loop body still mirrors the real
// list position (LastTab / WantedTab stay consistent).
private static List<int> BuildSidebarRenderOrder()
{
var tabs = Plugin.Config.Tabs;
var persistent = new List<int>(tabs.Count);
var pinned = new List<int>();
var unpinned = new List<int>();
for (var i = 0; i < tabs.Count; i++)
{
if (TabLifecycleHelpers.IsInPinnedPool(tabs[i]))
pinned.Add(i);
else if (TabLifecycleHelpers.IsInUnpinnedPool(tabs[i]))
unpinned.Add(i);
else
persistent.Add(i);
}
persistent.AddRange(pinned);
persistent.AddRange(unpinned);
return persistent;
}
private void DrawTabSidebar() private void DrawTabSidebar()
{ {
var currentTab = -1; var currentTab = -1;
// Sidebar fixed at 44px, no resize. // v1.2.0 — Sidebar fix 44 px, kein Resize. Mehr Platz fürs Chat-Log.
using var tabTable = ImRaii.Table( using var tabTable = ImRaii.Table(
"tabs-table", "tabs-table",
2, 2,
@@ -1769,62 +1689,51 @@ public sealed class ChatLogWindow : Window
if (!tabTable.Success) if (!tabTable.Success)
return; return;
var sidebarWidth = Math.Clamp(Plugin.Config.SidebarWidth, 44, 160); ImGui.TableSetupColumn("tabs", ImGuiTableColumnFlags.WidthFixed, 44f);
ImGui.TableSetupColumn("tabs", ImGuiTableColumnFlags.WidthFixed, sidebarWidth);
ImGui.TableSetupColumn("chat", ImGuiTableColumnFlags.WidthStretch, 1); ImGui.TableSetupColumn("chat", ImGuiTableColumnFlags.WidthStretch, 1);
ImGui.TableNextColumn(); ImGui.TableNextColumn();
var hasTabSwitched = false; var hasTabSwitched = false;
var childHeight = GetRemainingHeightForMessageLog(); var childHeight = GetRemainingHeightForMessageLog();
// Sidebar child without ChildBg tint to avoid a colored block above the // v1.2.0 — Sidebar-Child ohne Theme-ChildBg, sonst füllt das
// header toolbar area. Vertical separation is handled by BordersInnerV. // bläuliche Frame-Rect auch den oberen HeaderToolbar-Padding-Bereich
// aus (sieht aus wie ein angeschnittener Block oberhalb der Buttons).
// Vertikale Trennung zur Message-Spalte bleibt durch BordersInnerV
// der Tab-Table erhalten.
using (ImRaii.PushColor(ImGuiCol.ChildBg, 0u)) using (ImRaii.PushColor(ImGuiCol.ChildBg, 0u))
using (var child = ImRaii.Child("##chat2-tab-sidebar", new Vector2(-1, childHeight))) using (var child = ImRaii.Child("##chat2-tab-sidebar", new Vector2(-1, childHeight)))
{ {
if (child) if (child)
{ {
// Top padding mirrors the HeaderToolbar height so sidebar buttons // v1.2.0 — Top-Padding spiegelt die HeaderToolbar-Höhe der
// align with the message log start. // rechten Spalte (DrawChatHeaderToolbar wird dort als erstes
// gerendert, eine Frame-Zeile + ItemSpacing). Ohne diesen
// Padding würden die Sidebar-Buttons oben am Window-Top
// kleben, während die Messages erst unter der Toolbar
// beginnen — vertikales Mismatch.
ImGui.Dummy(new Vector2(0, ImGui.GetFrameHeightWithSpacing())); ImGui.Dummy(new Vector2(0, ImGui.GetFrameHeightWithSpacing()));
var previousTab = Plugin.CurrentTab; var previousTab = Plugin.CurrentTab;
// Render order: persistent → pinned TempTabs → unpinned TempTabs. // Hellion Chat — auto-tell-tabs section divider rendered
// Underlying Plugin.Config.Tabs order is untouched (tabI mirrors // exactly once before the first temp tab, with a live unit
// the real list index), only the display sequence groups by // counter pulled directly from the tab list.
// section so each section can carry its own divider header.
var renderOrder = BuildSidebarRenderOrder();
var pinnedHeaderRendered = false;
var tempTabHeaderRendered = false; var tempTabHeaderRendered = false;
var pinnedCount = Plugin.Config.Tabs.Count(TabLifecycleHelpers.IsInPinnedPool); var tempTabCount = Plugin.Config.Tabs.Count(t => t.IsTempTab);
var unpinnedTempCount = Plugin.Config.Tabs.Count(
TabLifecycleHelpers.IsInUnpinnedPool
);
foreach (var tabI in renderOrder) for (var tabI = 0; tabI < Plugin.Config.Tabs.Count; tabI++)
{ {
var tab = Plugin.Config.Tabs[tabI]; var tab = Plugin.Config.Tabs[tabI];
if (tab.PopOut) if (tab.PopOut)
continue; continue;
if (TabLifecycleHelpers.IsInPinnedPool(tab) && !pinnedHeaderRendered) if (tab.IsTempTab && !tempTabHeaderRendered)
{ {
ImGui.Separator(); ImGui.Separator();
if (!Plugin.Config.AutoTellTabsCompactDisplay) if (!Plugin.Config.AutoTellTabsCompactDisplay)
{ {
ImGui.TextDisabled( ImGui.TextDisabled(
$"{HellionStrings.PinTab_SectionHeader} ({pinnedCount})" $"{HellionStrings.AutoTellTabs_SectionHeader} ({tempTabCount})"
);
}
pinnedHeaderRendered = true;
}
else if (TabLifecycleHelpers.IsInUnpinnedPool(tab) && !tempTabHeaderRendered)
{
ImGui.Separator();
if (!Plugin.Config.AutoTellTabsCompactDisplay)
{
ImGui.TextDisabled(
$"{HellionStrings.AutoTellTabs_SectionHeader} ({unpinnedTempCount})"
); );
} }
tempTabHeaderRendered = true; tempTabHeaderRendered = true;
@@ -1843,8 +1752,11 @@ public sealed class ChatLogWindow : Window
if (showGreetedAffordance) if (showGreetedAffordance)
{ {
// Greeted toggle left of the selectable to keep click areas separate. // Greeted toggle sits left of the selectable so the
// Compact padding keeps the icon next to the tab name. // click areas stay separate. The icon also doubles
// as the visual "I'm done with this person" cue.
// Compact frame padding keeps the icon dezent next
// to the tab name instead of a chunky button block.
var greetedIcon = tab.IsGreeted var greetedIcon = tab.IsGreeted
? FontAwesomeIcon.CheckCircle ? FontAwesomeIcon.CheckCircle
: FontAwesomeIcon.Check; : FontAwesomeIcon.Check;
@@ -1872,8 +1784,10 @@ public sealed class ChatLogWindow : Window
ImGui.SameLine(); ImGui.SameLine();
} }
// Icon-only sidebar with tooltip on hover. Active tab gets accent color; // v1.2.0 — Icon-only Sidebar mit Tooltip beim Hover.
// greeted tabs are dimmed; tell tabs get a hash-based tint. // Active-Tab kriegt Akzent-Color am Icon, Greeted-Tabs
// werden auf TextDim gedimmt (löst den alten Header-
// Dim-Trick ab, da wir keine Selectable mehr nutzen).
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
var icon = TabIconMapping.Resolve(tab); var icon = TabIconMapping.Resolve(tab);
uint iconColor; uint iconColor;
@@ -1887,8 +1801,8 @@ public sealed class ChatLogWindow : Window
} }
else if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet()) else if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet())
{ {
// Hash-based color tint differentiates parallel Auto-Tell tabs // v1.2.0 — Hash-Color-Tint differenziert parallele Auto-Tell-Tabs
// without requiring manual icon assignment per tab. // visuell ohne dass User pro Tab manuell ein Custom-Icon setzen muss.
iconColor = TabTintCache.GetTint(tab); iconColor = TabTintCache.GetTint(tab);
} }
else else
@@ -1913,19 +1827,17 @@ public sealed class ChatLogWindow : Window
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(iconColor))) using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(iconColor)))
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
{ {
// Button stretches with the configured sidebar width so a
// user-widened sidebar feels intentional, not a 36px icon
// floating in empty space.
clicked = ImGui.Button( clicked = ImGui.Button(
$"{icon.ToIconString()}##sidebar-tab-{tabI}", $"{icon.ToIconString()}##sidebar-tab-{tabI}",
new Vector2(sidebarWidth - 8f, ImGui.GetFrameHeight()) new Vector2(36f, ImGui.GetFrameHeight())
); );
} }
if (isCurrentTab) if (isCurrentTab)
{ {
// Vertical accent pill on the left window edge, 3px wide, half tab height, // v1.2.0 — Vertikale Akzent-Pill an der linken Window-Kante.
// vertically centered. Direct DrawList pass, no native ImGui API for this. // 3 px breit, halbe Tab-Höhe, vertikal zentriert. ImGui hat keine
// native Pill-API, daher direkter DrawList-Pass.
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
var max = ImGui.GetItemRectMax(); var max = ImGui.GetItemRectMax();
const float pillWidth = 3f; const float pillWidth = 3f;
@@ -1941,8 +1853,10 @@ public sealed class ChatLogWindow : Window
); // leichter Rounding ); // leichter Rounding
} }
// Unread dot top-right of the icon. Active tabs have Unread=0 by convention // v1.2.0 — Unread-Dot oben rechts am Icon. Sichtbar ohne Hover, damit
// so the dot never conflicts with the active pill. // User Tabs mit ungelesenen Messages sofort erkennt. Aktive Tabs haben
// per Konvention Unread = 0 (LastTab-Branch in ChatLogWindow), daher
// kollidiert der Dot nicht mit der Active-Pill.
if (!isCurrentTab && tab.UnreadMode != UnreadMode.None && tab.Unread > 0) if (!isCurrentTab && tab.UnreadMode != UnreadMode.None && tab.Unread > 0)
{ {
var min = ImGui.GetItemRectMin(); var min = ImGui.GetItemRectMin();
@@ -1954,7 +1868,10 @@ public sealed class ChatLogWindow : Window
min.Y + dotRadius + dotPadding min.Y + dotRadius + dotPadding
); );
// Sin-based 2s pulse: alpha oscillates 60-100%. Skipped when ReduceMotion is on. // v1.2.0 — Sanfter Pulse-Effekt: Alpha schwankt zwischen 60% und
// 100% mit ~2-Sekunden-Cycle (subtil, nicht hektisch).
// Plugin.Config.ReduceMotion (Field seit v1.1.0) skipt den Pulse
// und rendert statisch — Default ist Animation an.
var dotColor = theme.Colors.StatusDanger; var dotColor = theme.Colors.StatusDanger;
if (!Plugin.Config.ReduceMotion) if (!Plugin.Config.ReduceMotion)
{ {
@@ -1978,35 +1895,11 @@ public sealed class ChatLogWindow : Window
); );
} }
// Pin indicator: subtle thumbtack glyph top-left of the icon.
// Muted colour because the "Pinned" section header already
// groups these tabs visually — this is just a per-tab
// confirmation glyph, not the primary discoverability cue.
if (tab.IsPinned)
{
var min = ImGui.GetItemRectMin();
const float pinPadding = 1f;
var pinPos = new Vector2(min.X + pinPadding, min.Y + pinPadding);
var pinColor = theme.Colors.TextMuted;
// Dim further so the glyph reads as a hint, not a badge.
var pinAbgr = ColourUtil.RgbaToAbgr(pinColor) & 0x77FFFFFFu;
using (Plugin.FontManager.FontAwesome.Push())
{
ImGui
.GetWindowDrawList()
.AddText(pinPos, pinAbgr, FontAwesomeIcon.Thumbtack.ToIconString());
}
}
// Tooltip mit Tab-Name + Unread-Counter beim Hover. // Tooltip mit Tab-Name + Unread-Counter beim Hover.
if (ImGui.IsItemHovered()) if (ImGui.IsItemHovered())
{ {
using var tt = ImRaii.Tooltip(); using var tt = ImRaii.Tooltip();
ImGui.TextUnformatted($"{tab.Name}{unread}"); ImGui.TextUnformatted($"{tab.Name}{unread}");
if (tab.IsPinned)
{
ImGui.TextUnformatted(HellionStrings.PinTab_PinnedTooltip);
}
} }
DrawTabContextMenu(tab, tabI); DrawTabContextMenu(tab, tabI);
@@ -2048,8 +1941,14 @@ public sealed class ChatLogWindow : Window
Plugin.WantedTab = null; Plugin.WantedTab = null;
} }
// DrawChatHeaderToolbar: renders the pop-out button for the active tab. // Hellion Chat v0.6.1 — visible pop-out trigger right above the message
// v1.3.0 also renders the optional Honorific title slot left of it. // log so users discover the feature without having to right-click the tab.
// Renders only for the active tab in the main ChatLogWindow; pop-out
// windows have their own render path and skip this toolbar.
//
// Hellion Chat v1.3.0 also renders the optional Honorific title slot
// left of the pop-out button, when HonorificService reports an active
// custom title and the user has ShowHonorificTitleInHeader enabled.
private void DrawChatHeaderToolbar(Tab tab) private void DrawChatHeaderToolbar(Tab tab)
{ {
DrawHonorificTitleSlot(); DrawHonorificTitleSlot();
@@ -2074,9 +1973,16 @@ public sealed class ChatLogWindow : Window
} }
} }
// Title rendered first so DrawPopOutButton can anchor flush right via // Renders the Honorific custom title to the left of the pop-out button,
// GetContentRegionAvail. Call order in DrawChatHeaderToolbar matters. // wrapped in guillemets to match how the game itself displays titles.
// SameLine keeps both on the same toolbar row. // We lay out the title first, then DrawPopOutButton uses
// GetContentRegionAvail to anchor itself flush right, which is why the
// call order in DrawChatHeaderToolbar matters: title first, button second.
//
// The slot stays on the same line as the pop-out button so the chat
// log doesn't lose vertical space; we use ImGui.SameLine after our
// text so the cursor X is still on the toolbar row when the pop-out
// button takes over.
private void DrawHonorificTitleSlot() private void DrawHonorificTitleSlot()
{ {
var service = Plugin.HonorificService; var service = Plugin.HonorificService;
@@ -2122,7 +2028,8 @@ public sealed class ChatLogWindow : Window
var theme = Plugin.ThemeRegistry.Active; var theme = Plugin.ThemeRegistry.Active;
// Group so IsItemHovered covers both the crown icon and the title text. // Group so the tooltip's IsItemHovered check fires for hover anywhere
// on the crown-plus-title pair, not just one of the two.
ImGui.BeginGroup(); ImGui.BeginGroup();
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted))) using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
@@ -2130,7 +2037,10 @@ public sealed class ChatLogWindow : Window
ImGui.TextUnformatted(FontAwesomeIcon.Crown.ToIconString()); ImGui.TextUnformatted(FontAwesomeIcon.Crown.ToIconString());
} }
ImGui.SameLine(0f, gapAfterCrown); ImGui.SameLine(0f, gapAfterCrown);
DrawHonorificTitleText(rendered, titleColor, title.Glow); using (ImRaii.PushColor(ImGuiCol.Text, titleColor))
{
ImGui.TextUnformatted(rendered);
}
ImGui.EndGroup(); ImGui.EndGroup();
if (ImGui.IsItemHovered()) if (ImGui.IsItemHovered())
@@ -2141,36 +2051,11 @@ public sealed class ChatLogWindow : Window
ImGui.SameLine(); ImGui.SameLine();
} }
// Renders the title text, optionally with a glow outline pre-pass. Glow is // Hellion Chat v0.6.1 — One-Time-Hint-Banner introducing the chat header
// drawn at 8 cardinal offsets (±1 px) in the glow colour at reduced alpha, // pop-out toolbar button and the right-click pathway. Reuses the visual
// then the primary text on top. The pre-pass uses the window draw list so // pattern from Popout.cs DrawHintBannerIfNeeded so users see a familiar
// it composites correctly with the regular ImGui text that follows. // dismiss-affordance. Returns the vertical space the banner consumed
private void DrawHonorificTitleText(string rendered, Vector4 titleColor, Vector3? glow) // (0 when not shown) so the message log can shrink accordingly.
{
if (Plugin.Config.ShowHonorificGlow && glow is { } g)
{
var pos = ImGui.GetCursorScreenPos();
var glowColor = new Vector4(g.X, g.Y, g.Z, 0.4f);
var glowAbgr = ImGui.ColorConvertFloat4ToU32(glowColor);
var drawList = ImGui.GetWindowDrawList();
for (var dy = -1; dy <= 1; dy++)
{
for (var dx = -1; dx <= 1; dx++)
{
if (dx == 0 && dy == 0)
continue;
drawList.AddText(new Vector2(pos.X + dx, pos.Y + dy), glowAbgr, rendered);
}
}
}
using (ImRaii.PushColor(ImGuiCol.Text, titleColor))
{
ImGui.TextUnformatted(rendered);
}
}
// One-time hint banner for the pop-out header button and right-click pathway.
private float DrawV061HintBannerIfNeeded() private float DrawV061HintBannerIfNeeded()
{ {
if (Plugin.Config.SeenPopOutHeaderHint) if (Plugin.Config.SeenPopOutHeaderHint)
@@ -2185,7 +2070,10 @@ public sealed class ChatLogWindow : Window
var bg = new System.Numerics.Vector4(0.16f, 0.20f, 0.28f, 1f); var bg = new System.Numerics.Vector4(0.16f, 0.20f, 0.28f, 1f);
var dismiss = false; var dismiss = false;
var openSettings = false; var openSettings = false;
// RAII style stack so an early return can never leave ImGui unbalanced. // RAII for the style stack so an early return in this block
// (or a later refactor that introduces one) can never leave the
// ImGui style stack unbalanced. Matches the convention used
// elsewhere in this file.
using (ImRaii.PushColor(ImGuiCol.ChildBg, bg)) using (ImRaii.PushColor(ImGuiCol.ChildBg, bg))
using (ImRaii.PushStyle(ImGuiStyleVar.FrameBorderSize, 1f)) using (ImRaii.PushStyle(ImGuiStyleVar.FrameBorderSize, 1f))
using ( using (
@@ -2216,7 +2104,7 @@ public sealed class ChatLogWindow : Window
{ {
Plugin.Config.SeenPopOutHeaderHint = true; Plugin.Config.SeenPopOutHeaderHint = true;
Plugin.SaveConfig(); Plugin.SaveConfig();
Plugin.LogProxy.Debug("v0.6.1 pop-out header hint dismissed"); Plugin.Log.Debug("v0.6.1 pop-out header hint dismissed");
if (openSettings) if (openSettings)
Plugin.SettingsWindow.Toggle(); Plugin.SettingsWindow.Toggle();
} }
@@ -2281,57 +2169,17 @@ public sealed class ChatLogWindow : Window
anyChanged = true; anyChanged = true;
} }
if (tab.IsTempTab)
{
ImGui.Separator();
DrawPinControls(tab);
}
if (anyChanged) if (anyChanged)
Plugin.SaveConfig(); Plugin.SaveConfig();
} }
private void DrawPinControls(Tab tab)
{
var svc = Plugin.AutoTellTabsService;
if (svc == null)
return;
if (tab.IsPinned)
{
if (ImGui.MenuItem(HellionStrings.PinTab_MenuUnpin))
{
svc.Unpin(tab);
ImGui.CloseCurrentPopup();
}
}
else
{
var atCap = svc.PinnedTempTabCount >= AutoTellTabsService.MaxPinnedTempTabs;
if (ImGui.MenuItem(HellionStrings.PinTab_MenuPin, enabled: !atCap))
{
if (svc.TryPin(tab))
ImGui.CloseCurrentPopup();
}
if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled))
{
ImGui.SetTooltip(
atCap
? string.Format(
HellionStrings.PinTab_LimitReached,
AutoTellTabsService.MaxPinnedTempTabs
)
: HellionStrings.PinTab_PinTooltip
);
}
}
}
internal readonly List<bool> PopOutDocked = []; internal readonly List<bool> PopOutDocked = [];
internal readonly HashSet<Guid> PopOutWindows = []; internal readonly HashSet<Guid> PopOutWindows = [];
// Live enumeration of active Popout windows for KeybindManager tab-cycle forwarding. // v0.6.0 — live enumeration of all active Popout windows so the
// Filters on IsOpen to skip closed-but-registered popouts. // KeybindManager can find a focused ChatInputBar to forward tab-cycle
// keybinds to. Filter on IsOpen prevents touching closed-but-still-
// registered popouts.
internal IEnumerable<Popout> ActivePopouts => internal IEnumerable<Popout> ActivePopouts =>
Plugin.WindowSystem.Windows.OfType<Popout>().Where(p => p.IsOpen); Plugin.WindowSystem.Windows.OfType<Popout>().Where(p => p.IsOpen);
@@ -2504,7 +2352,8 @@ public sealed class ChatLogWindow : Window
} }
finally finally
{ {
// Destroy frees the unmanaged ImGuiListClipper allocated above; without it the block leaks per render. // ImGuiListClipperPtr wraps an unmanaged ImGuiListClipper allocated above.
// Without Destroy() the unmanaged block leaks per autocomplete render.
clipper.Destroy(); clipper.Destroy();
} }
} }
@@ -2838,8 +2687,9 @@ public sealed class ChatLogWindow : Window
return $"Player {hashCode:X8}"; return $"Player {hashCode:X8}";
} }
// Snap threshold: minimum window overlap with a visible viewport before // Snap threshold in pixels: at least this much of the window must overlap
// we consider it off-screen. // a visible viewport so the user can still grab the first tab header.
// Below the threshold the window is considered off-screen.
private const int OnScreenMinOverlapX = 100; private const int OnScreenMinOverlapX = 100;
private const int OnScreenMinOverlapY = 40; private const int OnScreenMinOverlapY = 40;
@@ -2871,11 +2721,13 @@ public sealed class ChatLogWindow : Window
var viewport = ImGui.GetMainViewport(); var viewport = ImGui.GetMainViewport();
var safePos = viewport.WorkPos + SafeDefaultOffset; var safePos = viewport.WorkPos + SafeDefaultOffset;
Position = safePos; Position = safePos;
Plugin.LogProxy.Info( Plugin.Log.Info(
$"[Window-Recovery] {source}: snapping main window from {LastWindowPos} (size {LastWindowSize}) to {safePos}." $"[Window-Recovery] {source}: snapping main window from {LastWindowPos} (size {LastWindowSize}) to {safePos}."
); );
// Pop-outs don't persist across sessions so they can never end up off-screen // Pop-outs are intentionally non-persistent (cleared on plugin reload),
// after a reload. Only the main window needs explicit recovery. // so an off-screen pop-out can never survive a session boundary. The
// main window above is the only persistence target that needs an
// explicit recovery path.
} }
} }
+27 -75
View File
@@ -2,7 +2,6 @@
using System.Globalization; using System.Globalization;
using System.Numerics; using System.Numerics;
using System.Text; using System.Text;
using System.Threading;
using Dalamud.Bindings.ImGui; using Dalamud.Bindings.ImGui;
using Dalamud.Game.Text.SeStringHandling.Payloads; using Dalamud.Game.Text.SeStringHandling.Payloads;
using Dalamud.Interface; using Dalamud.Interface;
@@ -34,21 +33,11 @@ public class DbViewer : Window
private int CurrentPage = 1; private int CurrentPage = 1;
private string SimpleSearchTerm = ""; private string SimpleSearchTerm = "";
// v1.4.8 H2: opt-in full-text search across the whole DB via FTS5.
// Transient UI state (per-session), not persisted -- users opt in fresh
// every time so they always see the page-filter as the default mode.
private bool UseFullTextSearch;
private bool OnlyCurrentCharacter = true; private bool OnlyCurrentCharacter = true;
private readonly Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels; private readonly Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels;
private bool IsProcessing; private bool IsProcessing;
private long ProcessingStart = Environment.TickCount64; private long ProcessingStart = Environment.TickCount64;
// Bumped per trigger so a late worker drops itself instead of overwriting
// a newer result.
private long _ftsFilterSeq;
private (DateTime Min, DateTime Max, int Page, bool Local, int ChannelCount) LastProcessed; private (DateTime Min, DateTime Max, int Page, bool Local, int ChannelCount) LastProcessed;
private string MinDateString = ""; private string MinDateString = "";
@@ -93,13 +82,29 @@ public class DbViewer : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin
.Commands.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
// Slash-command tear-down moved to Plugin.TearDownCommands. Plugin
.Commands.Register(
"/hellionView",
"Get access to your message history, with simple filter options.",
true
)
.Execute -= Toggle;
} }
private void Toggle(string _, string __) => Toggle();
public override void Draw() public override void Draw()
{ {
var totalPages = (int)Math.Ceiling((double)Count / RowPerPage); var totalPages = (int)Math.Ceiling((double)Count / RowPerPage);
@@ -206,6 +211,13 @@ public class DbViewer : Window
if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled)) if (ImGui.IsItemHovered(ImGuiHoveredFlags.AllowWhenDisabled))
ImGui.SetTooltip(Language.Export_Txt_Tooltip); ImGui.SetTooltip(Language.Export_Txt_Tooltip);
// Hellion Chat: the JSON export button used to dump the database in
// the upstream webinterface's wire format. With the webinterface
// removed there is no consumer for that format any more, so the
// button is dropped. The Privacy tab's MessageExporter covers the
// same ground (Markdown / JSON / CSV) with channel and date filters
// and is the supported way to get history out of the plugin.
var width = 350 * ImGuiHelpers.GlobalScale; var width = 350 * ImGuiHelpers.GlobalScale;
var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64; var loadingIndicator = IsProcessing && ProcessingStart < Environment.TickCount64;
@@ -228,24 +240,6 @@ public class DbViewer : Window
tooltipRight: Language.Page_ArrowRight_Tooltip tooltipRight: Language.Page_ArrowRight_Tooltip
); );
// Full-text search toggle (v1.4.8 H2). IsFtsIndexBuilt is a cached
// volatile bool in MessageStore -- single field read per frame, no
// SELECT count(*). ImRaii.Disabled blocks any click while the index
// is still being built, so no defensive force-off branch needed
// inside the if-body. UseFullTextSearch is transient UI state, so we
// do not call SaveConfig here.
var ftsReady = Plugin.MessageManager.Store.IsFtsIndexBuilt;
using (ImRaii.Disabled(!ftsReady))
{
if (ImGui.Checkbox(HellionStrings.DbViewer_FullTextToggle, ref UseFullTextSearch))
TriggerFilterRefresh();
}
ImGuiUtil.HelpMarker(
ftsReady
? HellionStrings.DbViewer_FullTextToggle_Hint_PhraseMode
: HellionStrings.DbViewer_FullTextToggle_Hint_Indexing
);
ImGui.SameLine(ImGui.GetContentRegionMax().X - width); ImGui.SameLine(ImGui.GetContentRegionMax().X - width);
ImGui.SetNextItemWidth(width); ImGui.SetNextItemWidth(width);
if ( if (
@@ -256,7 +250,7 @@ public class DbViewer : Window
30 30
) )
) )
TriggerFilterRefresh(); Filtered = Filter(Messages);
// Third row // Third row
@@ -320,7 +314,7 @@ public class DbViewer : Window
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Failed reading messages from database"); Plugin.Log.Error(ex, "Failed reading messages from database");
} }
finally finally
{ {
@@ -460,53 +454,11 @@ public class DbViewer : Window
} }
} }
// FTS path hits SQLite per keystroke -- dispatch to a worker, drop stale
// results via _ftsFilterSeq. Page-filter path is in-memory LINQ, stays
// inline.
private void TriggerFilterRefresh()
{
if (!UseFullTextSearch || !Plugin.MessageManager.Store.IsFtsIndexBuilt)
{
Filtered = Filter(Messages);
return;
}
var snapshot = Messages;
var mySeq = Interlocked.Increment(ref _ftsFilterSeq);
Task.Run(() =>
{
try
{
var result = Filter(snapshot);
if (Interlocked.Read(ref _ftsFilterSeq) == mySeq)
Filtered = result;
}
catch (Exception ex)
{
Plugin.LogProxy.Error(ex, "FTS filter worker failed");
}
});
}
private ConcurrentStack<Message> Filter(Message[] messages) private ConcurrentStack<Message> Filter(Message[] messages)
{ {
if (SimpleSearchTerm == "") if (SimpleSearchTerm == "")
return new ConcurrentStack<Message>(messages.Reverse().OrderByDescending(m => m.Date)); return new ConcurrentStack<Message>(messages.Reverse().OrderByDescending(m => m.Date));
// Full-text mode bypasses the page-bounded messages array and queries
// the FTS5 index across the whole DB. IsFtsIndexBuilt re-check guards
// against the (rare) case of the toggle being on while the index is
// mid-rebuild -- ImRaii.Disabled prevents the user from flipping it,
// but a Dispose-and-reopen during indexing could leave UseFullTextSearch
// true while ftsReady flipped back to false; the local fallback below
// still serves the page.
if (UseFullTextSearch && Plugin.MessageManager.Store.IsFtsIndexBuilt)
{
var guidHits = Plugin.MessageManager.Store.FullTextSearch(SimpleSearchTerm);
var resolved = Plugin.MessageManager.Store.LoadByGuids(guidHits);
return new ConcurrentStack<Message>(resolved.OrderByDescending(m => m.Date));
}
return new ConcurrentStack<Message>( return new ConcurrentStack<Message>(
messages messages
.Reverse() .Reverse()
@@ -625,7 +577,7 @@ public class DbViewer : Window
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, "Failed creating txt backup"); Plugin.Log.Error(ex, "Failed creating txt backup");
Notification.Content = "Error ..."; Notification.Content = "Error ...";
Notification.Type = NotificationType.Error; Notification.Type = NotificationType.Error;
+5 -1
View File
@@ -28,13 +28,17 @@ public class DebuggerWindow : Window, IDisposable
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute += Toggle;
} }
public void Dispose() public void Dispose()
{ {
// Slash-command tear-down moved to Plugin.TearDownCommands. Plugin.Commands.Register("/hellionDebugger", showInHelp: false).Execute -= Toggle;
} }
private void Toggle(string _, string __) => Toggle();
public override unsafe void Draw() public override unsafe void Draw()
{ {
var agent = (nint)AgentItemDetail.Instance(); var agent = (nint)AgentItemDetail.Instance();
+9 -24
View File
@@ -30,10 +30,14 @@ public sealed class FirstRunWizard : Window
public override void OnClose() public override void OnClose()
{ {
// OnClose fires on explicit X-click and on plugin dispose. We never // Closing the wizard without picking anything = the user accepts
// implicitly accept the defaults here — the explicit "Later" button // whatever defaults are already in place. Mark as complete so we
// does that. If the user hasn't picked a profile yet, the wizard // don't pester them again on the next launch.
// reopens on the next plugin load. if (!Plugin.Config.FirstRunCompleted)
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
}
} }
public override void Draw() public override void Draw()
@@ -45,12 +49,7 @@ public sealed class FirstRunWizard : Window
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f; var cardWidth = (avail.X - ImGui.GetStyle().ItemSpacing.X * 2) / 3f;
// Reserve room for the footer separator + cancel button below the cards. var cardHeight = avail.Y - ImGui.GetTextLineHeightWithSpacing();
var footerReserve =
ImGui.GetStyle().ItemSpacing.Y * 3
+ ImGui.GetTextLineHeight()
+ ImGui.GetFrameHeightWithSpacing();
var cardHeight = avail.Y - footerReserve;
DrawCard( DrawCard(
"privacy-first", "privacy-first",
@@ -88,20 +87,6 @@ public sealed class FirstRunWizard : Window
HellionStrings.Wizard_Profile_FullHistory_Apply, HellionStrings.Wizard_Profile_FullHistory_Apply,
ApplyFullHistory ApplyFullHistory
); );
ImGui.Spacing();
ImGui.Separator();
ImGui.Spacing();
if (ImGui.Button(HellionStrings.Wizard_Cancel_Label))
{
Plugin.Config.FirstRunCompleted = true;
Plugin.SaveConfig();
IsOpen = false;
}
if (ImGui.IsItemHovered())
ImGuiUtil.Tooltip(HellionStrings.Wizard_Cancel_Tooltip);
} }
private void DrawCard( private void DrawCard(
+30 -12
View File
@@ -5,12 +5,18 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Theme-driven ImGui style override. PushGlobal is pushed once per frame /// <summary>
// in Plugin.Draw and drives every Hellion-rendered window. /// ImGui style override for Hellion Chat. v1.1.0 ist die Engine
/// theme-getrieben: PushGlobal nimmt eine Theme-Instance + Window-
/// Opacity, die gesamten Color- und Style-Slots werden aus dem Theme
/// gelesen statt aus einer fixen Konstanten-Tabelle.
/// </summary>
internal static class HellionStyle internal static class HellionStyle
{ {
// Local color stack for the active theme. Use inside a /// <summary>
// `using var _ = HellionStyle.Push(theme);` block. /// Local color stack auf Basis des aktiven Themes. Cheap. Use inside a
/// `using var _ = HellionStyle.Push(theme);` block.
/// </summary>
internal static IDisposable Push(Theme theme) internal static IDisposable Push(Theme theme)
{ {
var a = theme.AbgrCache; var a = theme.AbgrCache;
@@ -31,8 +37,13 @@ internal static class HellionStyle
return stack; return stack;
} }
// Global color and style stack pushed once per frame. /// <summary>
// windowOpacity: window background alpha (0.5-1.0). /// Global color and style-variable stack pushed once per frame in
/// Plugin.Draw. Drives every Hellion-rendered window from the active
/// theme's palette and layout values.
/// </summary>
/// <param name="theme">Active theme from ThemeRegistry.</param>
/// <param name="windowOpacity">Window background alpha (0.51.0).</param>
internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f) internal static IDisposable PushGlobal(Theme theme, float windowOpacity = 1.0f)
{ {
var c = theme.Colors; var c = theme.Colors;
@@ -43,10 +54,17 @@ internal static class HellionStyle
var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF); var alphaByte = (uint)Math.Clamp((int)(windowOpacity * 255f), 0x55, 0xFF);
var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte; var windowBgWithAlpha = (c.WindowBg & 0xFFFFFF00u) | alphaByte;
// ChildBg alpha resolution lives in HellionStyleHelpers so the // ChildBg-Alpha: Sub-Bereiche (Tab-Sidebar, Message-Area, Input-Bar)
// threshold logic can be covered by a pure-helper test in the // werden im ChatLog-Window als BeginChild gezeichnet. Würde der ChildBg
// build suite. // mit dem gleichen Alpha wie WindowBg gerendert, multiplizieren sich
var childBgWithAlpha = HellionStyleHelpers.ResolveChildBgAlpha(c.ChildBg, windowOpacity); // die Layer (1 - (1-α)² Deckung), und 50 % WindowOpacity kommt mit
// 75 % Deckung im Child-Bereich an — das Fenster wirkt solider als der
// Slider verspricht. Bei voller Opacity bleibt der Theme-Akzent
// erhalten (Theme-eigene Alpha-Komponente, i.d.R. FF); sobald der User
// Transparenz zieht, wird ChildBg vollständig durchsichtig damit nur
// der WindowBg-Layer die finale Deckung bestimmt.
var childBgAlpha = windowOpacity >= 0.999f ? (c.ChildBg & 0xFFu) : 0u;
var childBgWithAlpha = (c.ChildBg & 0xFFFFFF00u) | childBgAlpha;
// Layout // Layout
stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding); stack.PushStyleVar(ImGuiStyleVar.WindowRounding, l.WindowRounding);
@@ -59,8 +77,8 @@ internal static class HellionStyle
stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize); stack.PushStyleVar(ImGuiStyleVar.WindowBorderSize, l.WindowBorderSize);
stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize); stack.PushStyleVar(ImGuiStyleVar.FrameBorderSize, l.FrameBorderSize);
// Surfaces — WindowBg/ChildBg use opacity-modulated values (RGBA path); // Surfaces — WindowBg/ChildBg use the per-push opacity-modulated value,
// everything else reads from the pre-computed ABGR cache. // so they go through the RGBA path; everything else reads from cache.
stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha); stack.PushColor(ImGuiCol.WindowBg, windowBgWithAlpha);
stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha); stack.PushColor(ImGuiCol.ChildBg, childBgWithAlpha);
stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg); stack.PushColorAbgr(ImGuiCol.PopupBg, a.ChildBg);
-17
View File
@@ -1,17 +0,0 @@
namespace HellionChat.Ui;
internal static class HellionStyleHelpers
{
// Child surfaces are drawn over WindowBg, so at partial window opacity
// the theme's own ChildBg alpha would double-multiply and read too solid.
// Above ~full opacity we preserve the theme alpha; below it we wipe to 0
// so WindowBg alone carries the coverage. The 0.999f threshold is a
// float-imprecision guard around the user-facing 100% slider value.
// TEST-MIRROR: ../../Hellion Build test/_Helpers/HellionStyleHelpersTests.cs
public static uint ResolveChildBgAlpha(uint themeChildBgRgba, float windowOpacity)
{
var alphaPreserved = windowOpacity >= 0.999f;
var childBgAlpha = alphaPreserved ? (themeChildBgRgba & 0xFFu) : 0u;
return (themeChildBgRgba & 0xFFFFFF00u) | childBgAlpha;
}
}
+58 -23
View File
@@ -12,15 +12,19 @@ internal class Popout : Window
private readonly Tab Tab; private readonly Tab Tab;
private readonly int Idx; private readonly int Idx;
private long FrameTime; private long FrameTime; // set every frame
private long LastActivityTime = Environment.TickCount64; private long LastActivityTime = Environment.TickCount64;
// Optional input bar inside the pop-out. Lazy-allocated when enabled, // v0.6.0 — optional input bar inside the pop-out window. Lazy-allocated
// torn down on toggle-off (buffer discarded intentionally). // when the user enables Tab.PopOutInputEnabled and torn down when the
// toggle is turned off (independent text buffer is intentionally
// discarded — see v0.6.0 spec edge-case P1).
public ChatInputBar? InputBar { get; private set; } public ChatInputBar? InputBar { get; private set; }
public bool HasFocusedInputBar => InputBar?.IsFocused ?? false; public bool HasFocusedInputBar => InputBar?.IsFocused ?? false;
// Exposed so AutoTellTabsService can locate this window during LRU eviction. // Hellion Chat — v0.6.1 expose just the tab identifier (not the whole Tab
// reference) so AutoTellTabsService.DropOldestTempTab can locate the
// matching pop-out window when an LRU temp tab gets evicted.
internal Guid TabIdentifier => Tab.Identifier; internal Guid TabIdentifier => Tab.Identifier;
public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx) public Popout(ChatLogWindow chatLogWindow, Tab tab, int idx)
@@ -36,9 +40,12 @@ internal class Popout : Window
IsOpen = true; IsOpen = true;
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
// AllowBackgroundBlur is intentionally off: Dalamud blurs the entire // v1.2.1 — KEIN AllowBackgroundBlur. Pop-Outs werden vom User häufig
// tab container, not just this window, which would affect adjacent plugins. // im Dalamud-Tab-Container mit anderen Plugin-Windows kombiniert; in
// Users can enable blur per-window via the Dalamud hamburger menu. // dem Render-Pfad blurt Dalamud den gesamten Container, nicht nur
// das Pop-Out — würde die Tab-Bar oben und benachbarte Plugins
// mitziehen. Wer Blur in Pop-Outs will, kann ihn via Dalamud-
// Hamburger-Menü pro Window selbst aktivieren.
} }
public override void PreOpenCheck() public override void PreOpenCheck()
@@ -63,6 +70,7 @@ internal class Popout : Window
return true; return true;
} }
// Activity in the tab, this popout window, or the main chat log window.
var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime); var lastActivityTime = Math.Max(Tab.LastActivity, LastActivityTime);
lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime); lastActivityTime = Math.Max(lastActivityTime, ChatLogWindow.LastActivityTime);
return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout; return FrameTime - lastActivityTime <= 1000 * Plugin.Config.InactivityHideTimeout;
@@ -70,8 +78,10 @@ internal class Popout : Window
public override void PreDraw() public override void PreDraw()
{ {
// Theme engine pushes the active theme globally in Plugin.Draw; // Hellion Chat v1.1.0+ — Theme-Engine ist Source-of-Truth, kein
// pop-outs draw consistently without per-window overrides. // zusätzlicher Dalamud-StyleModel-Override mehr pro Window. Plugin.Draw
// pusht das aktive Hellion-Theme global; Pop-Out zeichnet sich damit
// konsistent zum Haupt-Chat-Window.
Flags = ImGuiWindowFlags.None; Flags = ImGuiWindowFlags.None;
if (!Plugin.Config.ShowPopOutTitleBar) if (!Plugin.Config.ShowPopOutTitleBar)
Flags |= ImGuiWindowFlags.NoTitleBar; Flags |= ImGuiWindowFlags.NoTitleBar;
@@ -82,10 +92,19 @@ internal class Popout : Window
if (!Tab.CanResize) if (!Tab.CanResize)
Flags |= ImGuiWindowFlags.NoResize; Flags |= ImGuiWindowFlags.NoResize;
// Guard against Idx pointing past the end if PopOutDocked was resized mid-frame. // Idx may point past the end if PopOutDocked was resized (e.g., a tab
// dropped) between the AddPopOutsToDraw() snapshot and this frame.
// Guard the read so we don't index into stale state.
if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx]) if (Idx >= 0 && Idx < ChatLogWindow.PopOutDocked.Count && !ChatLogWindow.PopOutDocked[Idx])
{ {
BgAlpha = Tab.IndependentOpacity ? Tab.Opacity / 100f : Plugin.Config.WindowOpacity; if (Tab.IndependentOpacity)
{
BgAlpha = Tab.Opacity / 100f;
}
else
{
BgAlpha = Plugin.Config.WindowOpacity;
}
} }
} }
@@ -99,15 +118,24 @@ internal class Popout : Window
ImGui.Separator(); ImGui.Separator();
} }
// v0.6.0 — one-time hint banner explaining the new pop-out input
// feature. Shown once per user; "Got it" or "Open settings"
// dismisses it and persists the flag.
var hintBannerHeight = DrawHintBannerIfNeeded(); var hintBannerHeight = DrawHintBannerIfNeeded();
// Toggle-OFF resets InputBar so the next toggle-ON starts with a fresh buffer. // v0.6.0 — pop-out optional input bar. Reserve height first so the
// message log draws into the right region; only shown when the
// global master switch is on. Toggle-OFF resets InputBar so the
// next toggle-ON gives a fresh buffer (no stale text persists).
var inputEnabled = Plugin.Config.PopOutInputEnabled; var inputEnabled = Plugin.Config.PopOutInputEnabled;
if (!inputEnabled && InputBar != null) if (!inputEnabled && InputBar != null)
{
InputBar = null; InputBar = null;
}
if (inputEnabled) if (inputEnabled)
{
InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab); InputBar ??= new ChatInputBar(ChatLogWindow.Plugin, ChatLogWindow, () => Tab);
}
var inputBarHeight = inputEnabled var inputBarHeight = inputEnabled
? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y ? ImGui.GetFrameHeightWithSpacing() + ImGui.GetStyle().ItemSpacing.Y
@@ -127,7 +155,8 @@ internal class Popout : Window
LastActivityTime = FrameTime; LastActivityTime = FrameTime;
} }
// Returns the vertical space consumed by the banner (0 when not shown). // Returns the vertical space the banner consumed (0 when not shown)
// so the message log can shrink accordingly.
private float DrawHintBannerIfNeeded() private float DrawHintBannerIfNeeded()
{ {
if (Plugin.Config.SeenPopOutInputHint) if (Plugin.Config.SeenPopOutInputHint)
@@ -175,7 +204,7 @@ internal class Popout : Window
{ {
Plugin.Config.SeenPopOutInputHint = true; Plugin.Config.SeenPopOutInputHint = true;
ChatLogWindow.Plugin.SaveConfig(); ChatLogWindow.Plugin.SaveConfig();
Plugin.LogProxy.Debug("Pop-Out input hint dismissed"); Plugin.Log.Debug("Pop-Out input hint dismissed");
if (openSettings) if (openSettings)
ChatLogWindow.Plugin.SettingsWindow.Toggle(); ChatLogWindow.Plugin.SettingsWindow.Toggle();
} }
@@ -211,18 +240,21 @@ internal class Popout : Window
private bool HideStateCheck() private bool HideStateCheck()
{ {
// if the chat has no hide state set, and the player has entered battle, we hide chat if they have configured it
if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle) if (Tab.HideInBattle && CurrentHideState == HideState.None && Plugin.InBattle)
{ {
CurrentHideState = HideState.Battle; CurrentHideState = HideState.Battle;
Plugin.LogProxy.Verbose($"Popout HideState [{Tab.Name}]: None -> Battle"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Battle");
} }
// If the chat is hidden because of battle, we reset it here
if (CurrentHideState is HideState.Battle && !Plugin.InBattle) if (CurrentHideState is HideState.Battle && !Plugin.InBattle)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.LogProxy.Verbose($"Popout HideState [{Tab.Name}]: Battle -> None"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: Battle None");
} }
// if the chat has no hide state and in a cutscene, set the hide state to cutscene
if ( if (
Tab.HideDuringCutscenes Tab.HideDuringCutscenes
&& CurrentHideState == HideState.None && CurrentHideState == HideState.None
@@ -232,34 +264,37 @@ internal class Popout : Window
if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags()) if (ChatLogWindow.Plugin.Functions.Chat.CheckHideFlags())
{ {
CurrentHideState = HideState.Cutscene; CurrentHideState = HideState.Cutscene;
Plugin.LogProxy.Verbose($"Popout HideState [{Tab.Name}]: None -> Cutscene"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: None Cutscene");
} }
} }
// if the chat is hidden because of a cutscene and no longer in a cutscene, set the hide state to none
if ( if (
CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride CurrentHideState is HideState.Cutscene or HideState.CutsceneOverride
&& !Plugin.CutsceneActive && !Plugin.CutsceneActive
&& !Plugin.GposeActive && !Plugin.GposeActive
) )
{ {
Plugin.LogProxy.Verbose( Plugin.Log.Verbose(
$"Popout HideState [{Tab.Name}]: {CurrentHideState} -> None (cutscene/gpose ended)" $"Popout HideState [{Tab.Name}]: {CurrentHideState} None (cutscene/gpose ended)"
); );
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
} }
// if the chat is hidden because of a cutscene and the chat has been activated, show chat
if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate) if (CurrentHideState == HideState.Cutscene && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.CutsceneOverride; CurrentHideState = HideState.CutsceneOverride;
Plugin.LogProxy.Verbose( Plugin.Log.Verbose(
$"Popout HideState [{Tab.Name}]: Cutscene -> CutsceneOverride (user activate)" $"Popout HideState [{Tab.Name}]: Cutscene CutsceneOverride (user activate)"
); );
} }
// if the user hid the chat and is now activating chat, reset the hide state
if (CurrentHideState == HideState.User && ChatLogWindow.Activate) if (CurrentHideState == HideState.User && ChatLogWindow.Activate)
{ {
CurrentHideState = HideState.None; CurrentHideState = HideState.None;
Plugin.LogProxy.Verbose($"Popout HideState [{Tab.Name}]: User -> None (activate)"); Plugin.Log.Verbose($"Popout HideState [{Tab.Name}]: User None (activate)");
} }
return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle return CurrentHideState is HideState.Cutscene or HideState.User or HideState.Battle
+9 -1
View File
@@ -29,13 +29,21 @@ public class SeStringDebugger : Window
RespectCloseHotkey = false; RespectCloseHotkey = false;
DisableWindowSounds = true; DisableWindowSounds = true;
#if DEBUG
Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute += Toggle;
#endif
} }
public void Dispose() public void Dispose()
{ {
// Slash-command tear-down moved to Plugin.TearDownCommands. #if DEBUG
Plugin.Commands.Register("/hellionSeString", showInHelp: false).Execute -= Toggle;
#endif
} }
private void Toggle(string _, string __) => Toggle();
public override void Draw() public override void Draw()
{ {
if (Plugin.MessageManager.LastMessage.Sender == null) if (Plugin.MessageManager.LastMessage.Sender == null)
+59 -23
View File
@@ -60,11 +60,23 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
DisableWindowSounds = true; DisableWindowSounds = true;
Initialise(); Initialise();
Plugin
.Commands.Register("/hellion", "Perform various actions with Hellion Chat.")
.Execute += Command;
Plugin.Interface.UiBuilder.OpenConfigUi += Toggle;
} }
public void Dispose() public void Dispose()
{ {
// Slash-command + OpenConfigUi tear-down moved to Plugin.TearDownCommands. Plugin.Interface.UiBuilder.OpenConfigUi -= Toggle;
Plugin.Commands.Register("/hellion").Execute -= Command;
}
private void Command(string command, string args)
{
if (string.IsNullOrWhiteSpace(args))
Toggle();
} }
private void Initialise() private void Initialise()
@@ -80,8 +92,10 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
View = SettingsView.Overview; View = SettingsView.Overview;
} }
// ESC in Detail view returns to Overview. Window focus check is // ESC im Detail-View kehrt zur Overview zurück. Window-Focus-Check ist
// required so ESC doesn't fire when the user targets a different window. // Pflicht — sonst triggert ESC auch wenn der User ein anderes Fenster
// fokussiert hat und ESC fürs Game-Menü drückt (Codebase-Pattern siehe
// Util/SearchSelector.cs:37).
if ( if (
View == SettingsView.Detail View == SettingsView.Detail
&& ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows) && ImGui.IsWindowFocused(ImGuiFocusedFlags.RootAndChildWindows)
@@ -114,13 +128,13 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
private void DrawDetail() private void DrawDetail()
{ {
// Breadcrumb header -- accent cyan, clickable, returns to Overview. // Breadcrumb-Header — Akzent-Cyan, klickbar, führt zurück zur Overview
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF00BED2u))
using (ImRaii.PushColor(ImGuiCol.Button, 0u)) using (ImRaii.PushColor(ImGuiCol.Button, 0u))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, 0x33FFFFFFu))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, 0x55FFFFFFu))
{ {
if (ImGui.SmallButton("<- Settings")) if (ImGui.SmallButton(" Settings"))
{ {
View = SettingsView.Overview; View = SettingsView.Overview;
return; return;
@@ -135,8 +149,11 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Section content fills full width. Navigation back to another // Section-Content in voller Breite. Die Tab-Liste links ist überholt:
// section goes via the breadcrumb or ESC. // der User ist bereits über die Card-Übersicht navigiert, eine zweite
// Tab-Liste daneben würde nur den Vanilla-Look zurückbringen. Falls
// der User in eine andere Section will, geht er zurück zur Overview
// (Breadcrumb / ESC).
var style = ImGui.GetStyle(); var style = ImGui.GetStyle();
var height = var height =
ImGui.GetContentRegionAvail().Y ImGui.GetContentRegionAvail().Y
@@ -165,7 +182,9 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(Language.Settings_Discard)) if (ImGui.Button(Language.Settings_Discard))
{
IsOpen = false; IsOpen = false;
}
const string buttonLabel = "Anna's Ko-fi"; const string buttonLabel = "Anna's Ko-fi";
const string buttonLabel2 = "Infi's Ko-fi"; const string buttonLabel2 = "Infi's Ko-fi";
@@ -187,17 +206,18 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
); );
if (ImGui.Button(buttonLabel2)) if (ImGui.Button(buttonLabel2))
Plugin.PlatformUtil.OpenLink("https://ko-fi.com/infiii"); Dalamud.Utility.Util.OpenLink("https://ko-fi.com/infiii");
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(buttonLabel)) if (ImGui.Button(buttonLabel))
Plugin.PlatformUtil.OpenLink("https://ko-fi.com/lojewalo"); Dalamud.Utility.Util.OpenLink("https://ko-fi.com/lojewalo");
} }
if (!save) if (!save)
return; return;
// calculate all conditions before updating config
var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat; var hideChanged = !Mutable.HideChat && Mutable.HideChat != Plugin.Config.HideChat;
var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride; var languageChanged = Mutable.LanguageOverride != Plugin.Config.LanguageOverride;
var fontChanged = var fontChanged =
@@ -210,16 +230,18 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001 Math.Abs(Mutable.SymbolsFontSizeV2 - Plugin.Config.SymbolsFontSizeV2) > 0.001
|| Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001; || Math.Abs(Mutable.FontSizeV2 - Plugin.Config.FontSizeV2) > 0.001;
var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled; var italicStateChanged = Mutable.ItalicEnabled != Plugin.Config.ItalicEnabled;
// v1.2.0 — Refilter only if a filter-relevant setting actually
// Only refilter when filter-relevant settings changed. Clear+Refilter // changed. The Clear+Refilter cycle reloads messages from the DB,
// reloads from the DB and silently drops in-session messages that // which silently wipes any in-session message that wasn't
// weren't persisted (Privacy-First blocks most channels). Cosmetic // persisted (Privacy-First config blocks most channels from DB).
// changes (theme, icons, layout) skip the cycle. // Cosmetic changes (theme, tab icons, layout flags) trigger no
// refilter — chat history stays intact.
var filtersChanged = HasFilterRelevantChanges(); var filtersChanged = HasFilterRelevantChanges();
Plugin.Config.UpdateFrom(Mutable, true); Plugin.Config.UpdateFrom(Mutable, true);
// Defer save by 60 frames to avoid committing changes that cause a crash. // save after 60 frames have passed, which should hopefully not
// commit any changes that cause a crash
Plugin.DeferredSaveFrames = 60; Plugin.DeferredSaveFrames = 60;
if (filtersChanged) if (filtersChanged)
{ {
@@ -237,16 +259,24 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
GameFunctions.GameFunctions.SetChatInteractable(true); GameFunctions.GameFunctions.SetChatInteractable(true);
if (Plugin.Config.ShowEmotes) if (Plugin.Config.ShowEmotes)
_ = EmoteCache.LoadData(); _ = EmoteCache.LoadData(); // Fire-and-forget intentional, exceptions are caught inside
Initialise(); Initialise();
} }
// Returns true if any filter-relevant setting changed between Plugin.Config /// <summary>
// and the Mutable copy. Gates Clear+Refilter on Save so cosmetic changes /// v1.2.0 — Detects whether any setting that influences message
// don't wipe in-session chat history. /// filtering changed between Plugin.Config and the Mutable working
/// copy. Used to gate the heavy ClearAllTabs+FilterAllTabsAsync cycle
/// in Save: cosmetic changes (theme, tab icons, layout flags) do not
/// touch the chat log, only filter-relevant changes do. Without this
/// gate, every settings save wipes the chat history of any channel
/// the Privacy filter blocks from being persisted to the DB —
/// reported by Flo from in-game testing 2026-05-05/06.
/// </summary>
private bool HasFilterRelevantChanges() private bool HasFilterRelevantChanges()
{ {
// Top-level privacy controls.
if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled) if (Mutable.PrivacyFilterEnabled != Plugin.Config.PrivacyFilterEnabled)
return true; return true;
if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels) if (Mutable.PrivacyPersistUnknownChannels != Plugin.Config.PrivacyPersistUnknownChannels)
@@ -255,23 +285,27 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
return true; return true;
// FilterIncludePreviousSessions changes the GetMostRecentMessages // FilterIncludePreviousSessions changes the GetMostRecentMessages
// window and is filter-relevant even outside the Privacy block. // window in MessageManager.FilterAllTabs and is therefore filter-
// relevant even though it lives outside the Privacy block.
if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions) if (Mutable.FilterIncludePreviousSessions != Plugin.Config.FilterIncludePreviousSessions)
return true; return true;
// Compare persistent tabs only -- TempTabs are never refiltered. // Per-tab channel selection. Compare persistent tabs only
// TempTabs are session-only and never refiltered anyway.
var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList(); var origPersistent = Plugin.Config.Tabs.Where(t => !t.IsTempTab).ToList();
var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList(); var newPersistent = Mutable.Tabs.Where(t => !t.IsTempTab).ToList();
if (origPersistent.Count != newPersistent.Count) if (origPersistent.Count != newPersistent.Count)
return true; return true; // add or delete
for (var i = 0; i < origPersistent.Count; i++) for (var i = 0; i < origPersistent.Count; i++)
{ {
var orig = origPersistent[i]; var orig = origPersistent[i];
var neu = newPersistent[i]; var neu = newPersistent[i];
// Identifier mismatch means reorder or slot swap -- treat as filter-relevant. // Identifier mismatch at the same index means reorder or
// a slot got swapped — treat as filter-relevant so the new
// channel-selection layout actually applies.
if (orig.Identifier != neu.Identifier) if (orig.Identifier != neu.Identifier)
return true; return true;
@@ -280,6 +314,8 @@ public sealed class SettingsWindow : Dalamud.Interface.Windowing.Window
if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels)) if (!orig.ExtraChatChannels.SetEquals(neu.ExtraChatChannels))
return true; return true;
// SelectedChannels is a Dictionary<ChatType, (ChatSource, ChatSource)>
// — value-tuple equality already does the right thing per-pair.
if (orig.SelectedChannels.Count != neu.SelectedChannels.Count) if (orig.SelectedChannels.Count != neu.SelectedChannels.Count)
return true; return true;
foreach (var pair in orig.SelectedChannels) foreach (var pair in orig.SelectedChannels)
+49 -52
View File
@@ -11,58 +11,46 @@ internal sealed class SettingsOverview
{ {
private readonly SettingsWindow _window; private readonly SettingsWindow _window;
// Card order matches the Tabs index in SettingsWindow 1:1. // Card-Reihenfolge entspricht 1:1 dem Tabs-Index in SettingsWindow.
private static (FontAwesomeIcon Icon, string Title, string Subtext)[] BuildCardDefs() => // v1.2.1: Cards thematisch re-sortiert. Theme & Layout vereint Theme-
// Picker + Frame-Style + Timestamps; Fonts & Colours vereint Schriften
// + Chat-Farben; Data Management vereint Storage + Retention + Cleanup
// + Export + DB-Viewer + Advanced.
private static readonly (FontAwesomeIcon Icon, string TitleKey, string SubtextKey)[] CardDefs =
[ [
( (FontAwesomeIcon.SlidersH, "Settings_Card_General_Title", "Settings_Card_General_Subtext"),
FontAwesomeIcon.SlidersH,
HellionStrings.Settings_Card_General_Title,
HellionStrings.Settings_Card_General_Subtext
),
( (
FontAwesomeIcon.Palette, FontAwesomeIcon.Palette,
HellionStrings.Settings_Card_ThemeAndLayout_Title, "Settings_Card_ThemeAndLayout_Title",
HellionStrings.Settings_Card_ThemeAndLayout_Subtext "Settings_Card_ThemeAndLayout_Subtext"
), ),
( (
FontAwesomeIcon.Font, FontAwesomeIcon.Font,
HellionStrings.Settings_Card_FontsAndColours_Title, "Settings_Card_FontsAndColours_Title",
HellionStrings.Settings_Card_FontsAndColours_Subtext "Settings_Card_FontsAndColours_Subtext"
), ),
( (
FontAwesomeIcon.WindowMaximize, FontAwesomeIcon.WindowMaximize,
HellionStrings.Settings_Card_Window_Title, "Settings_Card_Window_Title",
HellionStrings.Settings_Card_Window_Subtext "Settings_Card_Window_Subtext"
),
(
FontAwesomeIcon.Comments,
HellionStrings.Settings_Card_Chat_Title,
HellionStrings.Settings_Card_Chat_Subtext
),
(
FontAwesomeIcon.FolderTree,
HellionStrings.Settings_Card_Tabs_Title,
HellionStrings.Settings_Card_Tabs_Subtext
),
(
FontAwesomeIcon.ShieldAlt,
HellionStrings.Settings_Card_Privacy_Title,
HellionStrings.Settings_Card_Privacy_Subtext
), ),
(FontAwesomeIcon.Comments, "Settings_Card_Chat_Title", "Settings_Card_Chat_Subtext"),
(FontAwesomeIcon.FolderTree, "Settings_Card_Tabs_Title", "Settings_Card_Tabs_Subtext"),
(FontAwesomeIcon.ShieldAlt, "Settings_Card_Privacy_Title", "Settings_Card_Privacy_Subtext"),
( (
FontAwesomeIcon.Database, FontAwesomeIcon.Database,
HellionStrings.Settings_Card_DataManagement_Title, "Settings_Card_DataManagement_Title",
HellionStrings.Settings_Card_DataManagement_Subtext "Settings_Card_DataManagement_Subtext"
), ),
( (
FontAwesomeIcon.Plug, FontAwesomeIcon.Plug,
HellionStrings.Settings_Card_Integrations_Title, "Settings_Card_Integrations_Title",
HellionStrings.Settings_Card_Integrations_Subtext "Settings_Card_Integrations_Subtext"
), ),
( (
FontAwesomeIcon.InfoCircle, FontAwesomeIcon.InfoCircle,
HellionStrings.Settings_Card_Information_Title, "Settings_Card_Information_Title",
HellionStrings.Settings_Card_Information_Subtext "Settings_Card_Information_Subtext"
), ),
]; ];
@@ -76,18 +64,19 @@ internal sealed class SettingsOverview
var avail = ImGui.GetContentRegionAvail(); var avail = ImGui.GetContentRegionAvail();
var columns = avail.X >= 700f ? 3 : 2; var columns = avail.X >= 700f ? 3 : 2;
var cardWidth = (avail.X - (columns - 1) * 8f) / columns; var cardWidth = (avail.X - (columns - 1) * 8f) / columns;
// 110f accommodates two-line subtexts; wrap width is matched in DrawCard. // v1.2.1 — Subtexte wrappen jetzt auf zwei Zeilen, daher 110f statt der
// v1.1.0-Höhe 96f. Wrap-Breite + Y-Position der Subtext-Zeile sind in
// DrawCard auf den Card-Innenrand abgestimmt.
var cardHeight = 110f; var cardHeight = 110f;
// One draw-list lookup per frame instead of one per card. for (var i = 0; i < CardDefs.Length; i++)
var drawList = ImGui.GetWindowDrawList();
var cardDefs = BuildCardDefs();
for (var i = 0; i < cardDefs.Length; i++)
{ {
var (icon, title, subtext) = cardDefs[i]; var (icon, titleKey, subtextKey) = CardDefs[i];
DrawCard(i, icon, title, subtext, cardWidth, cardHeight, drawList); var title = HellionStrings.ResourceManager.GetString(titleKey) ?? titleKey;
var subtext = HellionStrings.ResourceManager.GetString(subtextKey) ?? subtextKey;
DrawCard(i, icon, title, subtext, cardWidth, cardHeight);
if ((i + 1) % columns != 0 && i != cardDefs.Length - 1) if ((i + 1) % columns != 0 && i != CardDefs.Length - 1)
ImGui.SameLine(); ImGui.SameLine();
} }
} }
@@ -98,12 +87,12 @@ internal sealed class SettingsOverview
string title, string title,
string subtext, string subtext,
float w, float w,
float h, float h
ImDrawListPtr drawList
) )
{ {
// BeginGroup makes the card a single layout item so SameLine works // BeginGroup macht den Card-Bereich zu einem einzelnen ImGui-Layout-Item.
// in the caller loop -- without it ImGui tracks each child separately. // Damit funktioniert SameLine() im Caller-Loop — sonst tracked ImGui die
// einzelnen InvisibleButton/Text-Items separat und das Wrapping bricht.
ImGui.BeginGroup(); ImGui.BeginGroup();
var cursorBefore = ImGui.GetCursorScreenPos(); var cursorBefore = ImGui.GetCursorScreenPos();
@@ -111,8 +100,12 @@ internal sealed class SettingsOverview
var hovered = ImGui.IsItemHovered(); var hovered = ImGui.IsItemHovered();
var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u; var bgColor = hovered ? 0xFF22303Fu : 0xFF1A2538u;
drawList.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f); var draw = ImGui.GetWindowDrawList();
draw.AddRectFilled(cursorBefore, cursorBefore + new Vector2(w, h), bgColor, 4f);
// Inhalts-Overlay: Icon + Title via DrawList (kein Wrap nötig). Subtext
// läuft über ImGui-Cursor + PushTextWrapPos damit der Text bei
// Card-Innenbreite umbricht statt rechts geclippt zu werden.
var iconPos = cursorBefore + new Vector2(16f, 12f); var iconPos = cursorBefore + new Vector2(16f, 12f);
var titlePos = cursorBefore + new Vector2(16f, 40f); var titlePos = cursorBefore + new Vector2(16f, 40f);
var subtextPos = cursorBefore + new Vector2(16f, 62f); var subtextPos = cursorBefore + new Vector2(16f, 62f);
@@ -122,15 +115,17 @@ internal sealed class SettingsOverview
using (_window.Plugin.FontManager.FontAwesome.Push()) using (_window.Plugin.FontManager.FontAwesome.Push())
{ {
drawList.AddText(iconPos, titleColor, icon.ToIconString()); draw.AddText(iconPos, titleColor, icon.ToIconString());
} }
drawList.AddText(titlePos, titleColor, title); draw.AddText(titlePos, titleColor, title);
// Subtext wraps at card inner width (16px padding each side) via DrawList // Subtext mit Wrap auf Card-Innenbreite (16 px Padding links + rechts).
// to avoid expanding the group bounds and breaking SameLine in the card row. // Cursor-basiertes TextUnformatted würde die ImGui-Group-Bounds
// erweitern und das SameLine-Wrapping in der Card-Reihe brechen, daher
// bleibt der Subtext bewusst beim DrawList-Overlay-Pattern.
var subtextWrapWidth = w - 32f; var subtextWrapWidth = w - 32f;
drawList.AddText( draw.AddText(
ImGui.GetFont(), ImGui.GetFont(),
ImGui.GetFontSize(), ImGui.GetFontSize(),
subtextPos, subtextPos,
@@ -142,6 +137,8 @@ internal sealed class SettingsOverview
ImGui.EndGroup(); ImGui.EndGroup();
if (clicked) if (clicked)
{
_window.OpenSection(index); _window.OpenSection(index);
} }
}
} }
+42 -9
View File
@@ -9,7 +9,10 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Four sections: Auto-Tell Tabs, Behaviour, Preview, Emotes. // Chat-Tab — vier eigenständige Sektionen: Auto-Tell-Tabs, Behaviour,
// Preview, Emotes. Der Emotes-Block ist 1:1 aus der Bestand-Datei
// Emote.cs übernommen; die Datei wird in Plan-Task 11 (Settings UX
// Polish v0.5.0) entfernt, sobald alle Tabs migriert sind.
internal sealed class Chat : ISettingsTab internal sealed class Chat : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -19,8 +22,9 @@ internal sealed class Chat : ISettingsTab
private SearchSelector.SelectorPopupOptions WordPopupOptions; private SearchSelector.SelectorPopupOptions WordPopupOptions;
// Tracks which EmoteCache state WordPopupOptions was built for so we // Snapshot of EmoteCache.State for which we last built WordPopupOptions.
// don't refill every frame when FilteredSheet is empty. // Without this, an empty FilteredSheet (e.g., the user blocked every emote)
// would trigger a refill every frame the settings tab is open.
private EmoteCache.LoadingState? WordPopupOptionsBuiltFor; private EmoteCache.LoadingState? WordPopupOptionsBuiltFor;
internal Chat(Plugin plugin, Configuration mutable) internal Chat(Plugin plugin, Configuration mutable)
@@ -32,13 +36,15 @@ internal sealed class Chat : ISettingsTab
WordPopupOptionsBuiltFor = EmoteCache.State; WordPopupOptionsBuiltFor = EmoteCache.State;
} }
private SearchSelector.SelectorPopupOptions RefillSheet() => private SearchSelector.SelectorPopupOptions RefillSheet()
new SearchSelector.SelectorPopupOptions {
return new SearchSelector.SelectorPopupOptions
{ {
FilteredSheet = EmoteCache FilteredSheet = EmoteCache
.SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w)) .SortedCodeArray.Where(w => !Mutable.BlockedEmotes.Contains(w))
.ToArray(), .ToArray(),
}; };
}
public void Draw(bool changed) public void Draw(bool changed)
{ {
@@ -55,7 +61,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_AutoTellTabs_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -68,7 +76,9 @@ internal sealed class Chat : ISettingsTab
ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale); ImGui.SetNextItemWidth(200f * ImGuiHelpers.GlobalScale);
var limit = Mutable.AutoTellTabsLimit; var limit = Mutable.AutoTellTabsLimit;
if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50)) if (ImGui.SliderInt(HellionStrings.ChatLog_AutoTellTabs_Limit_Name, ref limit, 1, 50))
{
Mutable.AutoTellTabsLimit = limit; Mutable.AutoTellTabsLimit = limit;
}
ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description); ImGuiUtil.HelpMarker(HellionStrings.ChatLog_AutoTellTabs_Limit_Description);
ImGui.Checkbox( ImGui.Checkbox(
@@ -109,7 +119,9 @@ internal sealed class Chat : ISettingsTab
100 100
) )
) )
{
Mutable.AutoTellTabsHistoryPreload = preload; Mutable.AutoTellTabsHistoryPreload = preload;
}
ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description); ImGuiUtil.HelpMarker(HellionStrings.Privacy_AutoTellTabs_Preload_Description);
ImGui.Spacing(); ImGui.Spacing();
@@ -121,7 +133,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Behaviour_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -146,7 +160,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Preview_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -162,10 +178,12 @@ internal sealed class Chat : ISettingsTab
foreach (var position in Enum.GetValues<PreviewPosition>()) foreach (var position in Enum.GetValues<PreviewPosition>())
{ {
if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position)) if (ImGui.Selectable(position.Name(), Mutable.PreviewPosition == position))
{
Mutable.PreviewPosition = position; Mutable.PreviewPosition = position;
} }
} }
} }
}
ImGuiUtil.HelpMarker(Language.Options_Preview_Description); ImGuiUtil.HelpMarker(Language.Options_Preview_Description);
if ( if (
@@ -175,7 +193,9 @@ internal sealed class Chat : ISettingsTab
ref Mutable.PreviewMinimum ref Mutable.PreviewMinimum
) )
) )
{
Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250); Mutable.PreviewMinimum = Math.Clamp(Mutable.PreviewMinimum, 1, 250);
}
ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf); ImGui.Checkbox(Language.Options_PreviewOnlyIf_Name, ref Mutable.OnlyPreviewIf);
ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description); ImGuiUtil.HelpMarker(Language.Options_PreviewOnlyIf_Description);
@@ -186,7 +206,9 @@ internal sealed class Chat : ISettingsTab
{ {
using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading); using var tree = ImRaii.TreeNode(HellionStrings.Settings_Chat_Emotes_Heading);
if (!tree.Success) if (!tree.Success)
{
return; return;
}
using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false)) using (ImRaii.PushIndent(ImGui.GetStyle().IndentSpacing, false))
{ {
@@ -211,13 +233,17 @@ internal sealed class Chat : ISettingsTab
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0)); ImGui.Button(FontAwesomeIcon.Plus.ToIconString(), new Vector2(buttonWidth, 0));
// OpenPopup on click because SelectorPopup uses ContextPopupItem // Open the selector popup on left-click; SelectorPopup uses
// which only triggers on right-click by default. // ImRaii.ContextPopupItem internally which only opens on right-
// click otherwise — without this OpenPopup the button looked
// active but the popup never appeared on a normal click.
if (ImGui.IsItemClicked()) if (ImGui.IsItemClicked())
ImGui.OpenPopup("WordAddPopup"); ImGui.OpenPopup("WordAddPopup");
if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions)) if (SearchSelector.SelectorPopup("WordAddPopup", out var newWord, WordPopupOptions))
{
Mutable.BlockedEmotes.Add(newWord); Mutable.BlockedEmotes.Add(newWord);
}
using ( using (
var table = ImRaii.Table( var table = ImRaii.Table(
@@ -231,9 +257,11 @@ internal sealed class Chat : ISettingsTab
{ {
ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable); ImGui.TableSetupColumn(Language.Options_Emote_EmoteTable);
ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f); ImGui.TableSetupColumn("##Del", ImGuiTableColumnFlags.WidthStretch, 0.07f);
ImGui.TableHeadersRow(); ImGui.TableHeadersRow();
foreach (var word in Mutable.BlockedEmotes.ToArray()) var copiedList = Mutable.BlockedEmotes.ToArray();
foreach (var word in copiedList)
{ {
ImGui.TableNextColumn(); ImGui.TableNextColumn();
ImGui.TextUnformatted(word); ImGui.TextUnformatted(word);
@@ -246,10 +274,12 @@ internal sealed class Chat : ISettingsTab
!ImGui.GetIO().KeyCtrl !ImGui.GetIO().KeyCtrl
) )
) )
{
Mutable.BlockedEmotes.Remove(word); Mutable.BlockedEmotes.Remove(word);
} }
} }
} }
}
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
@@ -259,14 +289,17 @@ internal sealed class Chat : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
if (EmoteCache.State is EmoteCache.LoadingState.Done) if (EmoteCache.State is EmoteCache.LoadingState.Done)
{
ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready); ImGui.TextColored(ImGuiColors.HealerGreen, Language.Options_Emote_Ready);
}
else else
{
ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady); ImGui.TextColored(ImGuiColors.DPSRed, Language.Options_Emote_NotReady);
}
ImGui.TextUnformatted( ImGui.TextUnformatted(
$"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}" $"{Language.Options_Emote_Loaded} {EmoteCache.SortedCodeArray.Length}"
); );
using ( using (
var emoteTable = ImRaii.Table( var emoteTable = ImRaii.Table(
"##LoadedEmotes", "##LoadedEmotes",
+15 -19
View File
@@ -229,7 +229,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Error(e, "Unable to delete old database"); Plugin.Log.Error(e, "Unable to delete old database");
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
Language.Options_Database_Old_Delete_Error, Language.Options_Database_Old_Delete_Error,
NotificationType.Error NotificationType.Error
@@ -391,9 +391,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.Config.RetentionLastRunAt = DateTimeOffset.UtcNow; Plugin.Config.RetentionLastRunAt = DateTimeOffset.UtcNow;
Plugin.SaveConfig(); Plugin.SaveConfig();
Plugin.LogProxy.Information( Plugin.Log.Information($"Manual retention run deleted {deleted} expired messages.");
$"Manual retention run deleted {deleted} expired messages."
);
if (deleted > 0) if (deleted > 0)
{ {
@@ -407,7 +405,7 @@ internal sealed class DataManagement : ISettingsTab
.Wait(TimeSpan.FromSeconds(5)) .Wait(TimeSpan.FromSeconds(5))
) )
{ {
Plugin.LogProxy.Warning( Plugin.Log.Warning(
"Retention sweep: framework refresh timed out after 5s." "Retention sweep: framework refresh timed out after 5s."
); );
} }
@@ -420,7 +418,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Error(e, "Manual retention run failed"); Plugin.Log.Error(e, "Manual retention run failed");
WrapperUtil.AddNotification(HellionStrings.Retention_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Retention_Error, NotificationType.Error);
} }
finally finally
@@ -568,7 +566,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Error(e, "Failed to compute cleanup preview"); Plugin.Log.Error(e, "Failed to compute cleanup preview");
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
HellionStrings.Cleanup_PreviewError, HellionStrings.Cleanup_PreviewError,
NotificationType.Error NotificationType.Error
@@ -589,7 +587,7 @@ internal sealed class DataManagement : ISettingsTab
try try
{ {
var deleted = Plugin.MessageManager.Store.CleanupRetainOnly(allowed); var deleted = Plugin.MessageManager.Store.CleanupRetainOnly(allowed);
Plugin.LogProxy.Information($"Privacy cleanup: deleted {deleted} messages"); Plugin.Log.Information($"Privacy cleanup: deleted {deleted} messages");
if ( if (
!Plugin !Plugin
@@ -601,9 +599,7 @@ internal sealed class DataManagement : ISettingsTab
.Wait(TimeSpan.FromSeconds(5)) .Wait(TimeSpan.FromSeconds(5))
) )
{ {
Plugin.LogProxy.Warning( Plugin.Log.Warning("Privacy cleanup: framework refresh timed out after 5s.");
"Privacy cleanup: framework refresh timed out after 5s."
);
} }
WrapperUtil.AddNotification( WrapperUtil.AddNotification(
@@ -613,7 +609,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Error(e, "Privacy cleanup failed"); Plugin.Log.Error(e, "Privacy cleanup failed");
WrapperUtil.AddNotification(HellionStrings.Cleanup_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Cleanup_Error, NotificationType.Error);
} }
finally finally
@@ -773,7 +769,7 @@ internal sealed class DataManagement : ISettingsTab
} }
catch (Exception e) catch (Exception e)
{ {
Plugin.LogProxy.Error(e, "Export failed"); Plugin.Log.Error(e, "Export failed");
WrapperUtil.AddNotification(HellionStrings.Export_Error, NotificationType.Error); WrapperUtil.AddNotification(HellionStrings.Export_Error, NotificationType.Error);
} }
finally finally
@@ -853,7 +849,7 @@ internal sealed class DataManagement : ISettingsTab
) )
) )
{ {
Plugin.LogProxy.Warning("Clearing messages from database"); Plugin.Log.Warning("Clearing messages from database");
Plugin.MessageManager.Store.ClearMessages(); Plugin.MessageManager.Store.ClearMessages();
Plugin.MessageManager.ClearAllTabs(); Plugin.MessageManager.ClearAllTabs();
@@ -911,7 +907,7 @@ internal sealed class DataManagement : ISettingsTab
private void InsertMessages(int count) private void InsertMessages(int count)
{ {
Plugin.LogProxy.Info($"Inserting {count} messages due to user request"); Plugin.Log.Info($"Inserting {count} messages due to user request");
var stopwatch = Stopwatch.StartNew(); var stopwatch = Stopwatch.StartNew();
var playerName = Plugin.PlayerState.CharacterName; var playerName = Plugin.PlayerState.CharacterName;
@@ -956,7 +952,7 @@ internal sealed class DataManagement : ISettingsTab
var elapsedTicks = stopwatch.ElapsedTicks; var elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.LogProxy.Info( Plugin.Log.Info(
$"Crafted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Crafted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
@@ -966,7 +962,7 @@ internal sealed class DataManagement : ISettingsTab
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.LogProxy.Info( Plugin.Log.Info(
$"Upserted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Upserted {count} messages in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
@@ -977,7 +973,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.MessageManager.ClearAllTabs(); Plugin.MessageManager.ClearAllTabs();
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.LogProxy.Info( Plugin.Log.Info(
$"Cleared {Plugin.Config.Tabs.Count} tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Cleared {Plugin.Config.Tabs.Count} tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
}) })
@@ -990,7 +986,7 @@ internal sealed class DataManagement : ISettingsTab
Plugin.MessageManager.FilterAllTabs(); Plugin.MessageManager.FilterAllTabs();
elapsedTicks = stopwatch.ElapsedTicks; elapsedTicks = stopwatch.ElapsedTicks;
stopwatch.Stop(); stopwatch.Stop();
Plugin.LogProxy.Info( Plugin.Log.Info(
$"Fetched and filtered all tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)" $"Fetched and filtered all tabs in {elapsedTicks} ticks ({elapsedTicks / TimeSpan.TicksPerMillisecond}ms)"
); );
}) })
@@ -312,6 +312,6 @@ internal sealed class FontsAndColours : ISettingsTab
} }
Plugin.SaveConfig(); Plugin.SaveConfig();
GlobalParametersCache.Refresh(); GlobalParametersCache.Refresh();
Plugin.LogProxy.Debug($"Applied chat colour preset: {preset.DisplayName}"); Plugin.Log.Debug($"Applied chat colour preset: {preset.DisplayName}");
} }
} }
+6 -4
View File
@@ -8,7 +8,9 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Combines the former About and Changelog tabs into three collapsible sections. // Information-Tab vereint die früheren About- und Changelog-Tabs in
// drei kollabierbaren Sektionen. Der About-Inhalt ist 1:1 aus About.cs
// übernommen, die Changelog-Render-Logik aus Changelog.cs.
internal sealed class Information : ISettingsTab internal sealed class Information : ISettingsTab
{ {
private Configuration Mutable { get; } private Configuration Mutable { get; }
@@ -97,7 +99,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(Language.Options_About_Github_Issues); ImGui.TextUnformatted(Language.Options_About_Github_Issues);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "githubIssues"))
Plugin.PlatformUtil.OpenLink( Dalamud.Utility.Util.OpenLink(
"https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues" "https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/issues"
); );
} }
@@ -116,7 +118,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label); ImGui.TextUnformatted(HellionStrings.About_Maintainer_Website_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "hellionMedia"))
Plugin.PlatformUtil.OpenLink("https://hellion-media.de"); Dalamud.Utility.Util.OpenLink("https://hellion-media.de");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
@@ -137,7 +139,7 @@ internal sealed class Information : ISettingsTab
ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label); ImGui.TextUnformatted(HellionStrings.About_BuiltOn_Upstream_Label);
ImGui.SameLine(); ImGui.SameLine();
if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream")) if (ImGuiUtil.IconButton(FontAwesomeIcon.ExternalLinkAlt, "chatTwoUpstream"))
Plugin.PlatformUtil.OpenLink("https://github.com/Infiziert90/ChatTwo"); Dalamud.Utility.Util.OpenLink("https://github.com/Infiziert90/ChatTwo");
ImGuiHelpers.ScaledDummy(10.0f); ImGuiHelpers.ScaledDummy(10.0f);
+19 -23
View File
@@ -8,8 +8,9 @@ using HellionChat.Util;
namespace HellionChat.Ui.SettingsTabs; namespace HellionChat.Ui.SettingsTabs;
// Added in v1.3.0. Each future integration cycle adds a section above // First settings tab introduced in v1.3.0 (Plugin Integrations Cycle 1).
// the "Coming soon" block and removes its stub item. // Designed to grow organically: each future cycle adds a new section above
// the "Coming soon" block and removes the corresponding stub item.
internal sealed class Integrations : ISettingsTab internal sealed class Integrations : ISettingsTab
{ {
private Plugin Plugin { get; } private Plugin Plugin { get; }
@@ -47,9 +48,11 @@ internal sealed class Integrations : ISettingsTab
DrawHonorificStatus(); DrawHonorificStatus();
ImGui.Spacing(); ImGui.Spacing();
// Toggle works regardless of detection state: "show when available, // The toggle is enabled regardless of detection state — leaving it
// hide otherwise". Disabling it when Honorific is missing would force // on means "render when available, hide otherwise". Disabling the
// the user to retoggle on every reload. // toggle when Honorific is missing would force the user to retoggle
// it every time Honorific is reloaded, which is worse UX than the
// silent auto-hide.
if ( if (
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Integrations_Honorific_Toggle, HellionStrings.Settings_Integrations_Honorific_Toggle,
@@ -71,31 +74,22 @@ internal sealed class Integrations : ISettingsTab
{ {
ImGui.TextWrapped(HellionStrings.Settings_Integrations_Honorific_ToggleHint); ImGui.TextWrapped(HellionStrings.Settings_Integrations_Honorific_ToggleHint);
} }
if (
ImGui.Checkbox(
HellionStrings.Settings_Integrations_Honorific_Glow_Toggle,
ref Mutable.ShowHonorificGlow
)
)
{
Plugin.SaveConfig();
}
ImGuiUtil.HelpMarker(HellionStrings.Settings_Integrations_Honorific_Glow_Hint);
} }
// Honorific has no LICENSE in its repo so we link upstream and author // Maintainer attribution. Honorific has no LICENSE in its repo so we
// instead of bundling assets. Text labels because FA Brands isn't // can't bundle its assets, but linking to the upstream and the
// guaranteed in Dalamud's font set. // author's profile is the polite minimum. Plain ImGui buttons keep
// the visual weight modest, the FontAwesome Brands subset is not
// guaranteed in Dalamud's font set so we use text labels.
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkRepo))
{ {
Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificRepo); Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificRepo);
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor)) if (ImGui.Button(HellionStrings.Settings_Integrations_Honorific_LinkAuthor))
{ {
Plugin.PlatformUtil.OpenLink(IntegrationLinks.HonorificAuthor); Dalamud.Utility.Util.OpenLink(IntegrationLinks.HonorificAuthor);
} }
} }
@@ -153,7 +147,9 @@ internal sealed class Integrations : ISettingsTab
ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro); ImGui.TextWrapped(HellionStrings.Settings_Integrations_ComingSoon_Intro);
ImGui.Spacing(); ImGui.Spacing();
// Each integration cycle removes its stub here and adds a full section above. // Static list maintained in code (not Configuration). Each cycle
// that lands a real integration removes its stub here and adds a
// full section above the Coming Soon block.
DrawComingSoonItem( DrawComingSoonItem(
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title, HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Title,
HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description HellionStrings.Settings_Integrations_ComingSoon_ContextMenu_Description
@@ -204,7 +200,7 @@ internal sealed class Integrations : ISettingsTab
if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel)) if (ImGui.Button(HellionStrings.Settings_Integrations_GotAnIdea_LinkLabel))
{ {
Plugin.PlatformUtil.OpenLink(BrandingLinks.HellionForgeDiscordInvite); Dalamud.Utility.Util.OpenLink(BrandingLinks.HellionForgeDiscordInvite);
} }
} }
+2 -1
View File
@@ -20,7 +20,8 @@ internal sealed class Privacy : ISettingsTab
Mutable = mutable; Mutable = mutable;
} }
// (HeadingKey, ChatType list). Heading resolved per-frame for live language switching. // (HeadingKey lookup, ChatType list). Heading is resolved per-frame so
// a runtime LanguageChanged call updates the labels immediately.
private static readonly (Func<string> Heading, ChatType[] Types)[] Groups = private static readonly (Func<string> Heading, ChatType[] Types)[] Groups =
[ [
( (
+7 -5
View File
@@ -123,7 +123,7 @@ internal sealed class Tabs : ISettingsTab
ImGuiInputTextFlags.EnterReturnsTrue ImGuiInputTextFlags.EnterReturnsTrue
); );
// Per-tab icon override added in v1.2.0. Falls back to default mapping if unset. // v1.2.0 — Per-Tab Icon-Override. Default-Mapping greift falls nichts gesetzt.
ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label); ImGui.TextUnformatted(HellionStrings.Tabs_Icon_Label);
ImGui.SameLine(); ImGui.SameLine();
ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker); ImGuiUtil.HelpMarker(HellionStrings.Tabs_Icon_HelpMarker);
@@ -135,7 +135,7 @@ internal sealed class Tabs : ISettingsTab
{ {
if (combo.Success) if (combo.Success)
{ {
// First option clears the icon and lets the default mapping take over. // Erste Option: Default (löscht Icon, lässt Mapping greifen).
if ( if (
ImGui.Selectable( ImGui.Selectable(
HellionStrings.Tabs_Icon_DefaultOption, HellionStrings.Tabs_Icon_DefaultOption,
@@ -148,7 +148,7 @@ internal sealed class Tabs : ISettingsTab
ImGui.Separator(); ImGui.Separator();
// Options sourced from TabIconGlyphResolver.PickerOptions (single source of truth). // Pool-Optionen aus TabIconGlyphResolver.PickerOptions (Single-Source-of-Truth).
foreach (var option in TabIconGlyphResolver.PickerOptions) foreach (var option in TabIconGlyphResolver.PickerOptions)
{ {
var isSelected = string.Equals( var isSelected = string.Equals(
@@ -305,8 +305,10 @@ internal sealed class Tabs : ISettingsTab
ImGui.SameLine(); ImGui.SameLine();
// Guard against an empty worlds list (character switch or sheet not yet populated) // Guard against an empty worlds list — can happen briefly
// to avoid an out-of-bounds crash on worlds[selectedWorld]. // when switching characters or if the datacenter sheet
// has not yet populated. Without the guard the indexed
// access into worlds[selectedWorld] would crash.
if (worlds.Count == 0) if (worlds.Count == 0)
{ {
ImGui.TextDisabled("(no worlds available)"); ImGui.TextDisabled("(no worlds available)");
+37 -38
View File
@@ -43,9 +43,9 @@ internal sealed class ThemeAndLayout : ISettingsTab
var registry = Plugin.ThemeRegistry; var registry = Plugin.ThemeRegistry;
var active = registry.Get(Mutable.Theme); var active = registry.Get(Mutable.Theme);
ImGui.TextUnformatted( var activeLabelTemplate =
string.Format(HellionStrings.Settings_Themes_Active, active.Name) HellionStrings.ResourceManager.GetString("Settings_Themes_Active") ?? "Active: {0}";
); ImGui.TextUnformatted(string.Format(activeLabelTemplate, active.Name));
using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u)) using (ImRaii.PushColor(ImGuiCol.Text, 0xFF8FA3B5u))
ImGui.TextUnformatted(active.Author); ImGui.TextUnformatted(active.Author);
@@ -55,7 +55,10 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.Settings_Themes_BuiltIns); var builtInsLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_BuiltIns")
?? "Built-in themes";
ImGui.TextUnformatted(builtInsLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(registry.AllBuiltIns(), active.Slug); DrawThemeGrid(registry.AllBuiltIns(), active.Slug);
@@ -65,7 +68,10 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
ImGui.TextUnformatted(HellionStrings.Settings_Themes_Custom); var customLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_Custom")
?? "Custom themes";
ImGui.TextUnformatted(customLabel);
ImGui.Spacing(); ImGui.Spacing();
DrawThemeGrid(customs, active.Slug); DrawThemeGrid(customs, active.Slug);
} }
@@ -74,15 +80,21 @@ internal sealed class ThemeAndLayout : ISettingsTab
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Button(HellionStrings.Settings_Themes_OpenFolder)) var openFolderLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_OpenFolder")
?? "Open themes folder";
if (ImGui.Button(openFolderLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
Plugin.PlatformUtil.OpenLink(dir); Dalamud.Utility.Util.OpenLink(dir);
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Themes_ExportActive)) var exportLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ExportActive")
?? "Export active...";
if (ImGui.Button(exportLabel))
{ {
var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes"); var dir = Path.Combine(Plugin.Interface.ConfigDirectory.FullName, "themes");
Directory.CreateDirectory(dir); Directory.CreateDirectory(dir);
@@ -90,7 +102,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
var path = Path.Combine(dir, fileName); var path = Path.Combine(dir, fileName);
var json = ThemeJsonWriter.Serialize(active); var json = ThemeJsonWriter.Serialize(active);
File.WriteAllText(path, json); File.WriteAllText(path, json);
Plugin.LogProxy.Information($"Exported active theme '{active.Slug}' to {path}"); Plugin.Log.Information($"Exported active theme '{active.Slug}' to {path}");
} }
} }
} }
@@ -194,19 +206,25 @@ internal sealed class ThemeAndLayout : ISettingsTab
draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f); draw.AddRectFilled(origin, origin + new Vector2(width, height), bgFill, 4f);
draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f); draw.AddRect(origin, origin + new Vector2(width, height), border, 4f, ImDrawFlags.None, 1f);
var hint =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Hint")
?? "This theme suggests its own chat channel colours.";
var applyLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Apply")
?? "Apply";
var keepLabel =
HellionStrings.ResourceManager.GetString("Settings_Themes_ApplyChatColors_Keep")
?? "Keep current";
var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary); var textColor = ColourUtil.RgbaToAbgr(active.Colors.TextPrimary);
draw.AddText( draw.AddText(origin + new Vector2(12f, 10f), textColor, hint);
origin + new Vector2(12f, 10f),
textColor,
HellionStrings.Settings_Themes_ApplyChatColors_Hint
);
using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary)) using (ImRaii.PushColor(ImGuiCol.Button, active.Colors.Primary))
using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight)) using (ImRaii.PushColor(ImGuiCol.ButtonHovered, active.Colors.PrimaryLight))
using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark)) using (ImRaii.PushColor(ImGuiCol.ButtonActive, active.Colors.PrimaryDark))
{ {
ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f)); ImGui.SetCursorScreenPos(origin + new Vector2(12f, 32f));
if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Apply)) if (ImGui.Button(applyLabel))
{ {
foreach (var kvp in themeChatColors.Channels) foreach (var kvp in themeChatColors.Channels)
Mutable.ChatColours[kvp.Key] = kvp.Value; Mutable.ChatColours[kvp.Key] = kvp.Value;
@@ -215,7 +233,7 @@ internal sealed class ThemeAndLayout : ISettingsTab
} }
ImGui.SameLine(); ImGui.SameLine();
if (ImGui.Button(HellionStrings.Settings_Themes_ApplyChatColors_Keep)) if (ImGui.Button(keepLabel))
{ {
_applyDismissedFor = active.Slug; _applyDismissedFor = active.Slug;
} }
@@ -250,32 +268,13 @@ internal sealed class ThemeAndLayout : ISettingsTab
string.Format(Language.Options_SidebarTabView_Description, Plugin.PluginName) string.Format(Language.Options_SidebarTabView_Description, Plugin.PluginName)
); );
if (Mutable.SidebarTabView)
{
var sidebarWidth = Mutable.SidebarWidth;
if (
ImGui.SliderInt(
HellionStrings.Settings_ThemeAndLayout_SidebarWidth_Name,
ref sidebarWidth,
44,
160,
$"{sidebarWidth} px"
)
)
{
Mutable.SidebarWidth = sidebarWidth;
}
ImGuiUtil.HelpMarker(
HellionStrings.Settings_ThemeAndLayout_SidebarWidth_Description
);
}
ImGui.Spacing(); ImGui.Spacing();
ImGui.Separator(); ImGui.Separator();
ImGui.Spacing(); ImGui.Spacing();
// Slider range 50-100% maps to 0.5-1.0 internally. Floor at 50% prevents // Slider 50100 % UX-Range; intern 0.51.0 als WindowOpacity-Float.
// accidentally hiding the chat background (v1.2.0 bug at WindowAlpha=0). // Untere Schwelle 50 % verhindert versehentliches Komplett-Wegblenden
// des Chat-Hintergrunds (war v1.2.0 Bug bei WindowAlpha=0).
var opacityPercent = Mutable.WindowOpacity * 100f; var opacityPercent = Mutable.WindowOpacity * 100f;
if ( if (
ImGuiUtil.DragFloatVertical( ImGuiUtil.DragFloatVertical(
+10 -9
View File
@@ -7,14 +7,15 @@ namespace HellionChat.Ui.SettingsTabs;
internal static class ThemeMockup internal static class ThemeMockup
{ {
// Mini chat window mockup drawn directly into the WindowDrawList. // Zeichnet ein Mini-Chat-Window-Mockup mit den Theme-Werten direkt
// No textures, no per-frame allocations — pure AddRectFilled/AddText. // ins WindowDrawList. Keine Texture, keine Allocation pro Frame —
// alles via DrawList.AddRectFilled / AddText.
public static void Draw(Vector2 origin, Vector2 size, Theme theme) public static void Draw(Vector2 origin, Vector2 size, Theme theme)
{ {
var draw = ImGui.GetWindowDrawList(); var draw = ImGui.GetWindowDrawList();
var c = theme.Colors; var c = theme.Colors;
// Window background // Window-Bg
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
origin + size, origin + size,
@@ -22,7 +23,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Title bar // Title-Bar
var titleHeight = 14f; var titleHeight = 14f;
draw.AddRectFilled( draw.AddRectFilled(
origin, origin,
@@ -31,7 +32,7 @@ internal static class ThemeMockup
theme.Layout.WindowRounding theme.Layout.WindowRounding
); );
// Tab bar (3 tabs) // Tab-Bar — 3 Mini-Tabs
var tabY = origin.Y + titleHeight + 4f; var tabY = origin.Y + titleHeight + 4f;
var tabHeight = 12f; var tabHeight = 12f;
for (var i = 0; i < 3; i++) for (var i = 0; i < 3; i++)
@@ -45,7 +46,7 @@ internal static class ThemeMockup
theme.Layout.TabRounding theme.Layout.TabRounding
); );
if (i == 0) // active pill if (i == 0) // Active-Pill
{ {
draw.AddRectFilled( draw.AddRectFilled(
new Vector2(tabX, tabY + tabHeight - 2f), new Vector2(tabX, tabY + tabHeight - 2f),
@@ -55,7 +56,7 @@ internal static class ThemeMockup
} }
} }
// Message card row // Card-Row mit Mock-Sender + Text
var rowY = tabY + tabHeight + 6f; var rowY = tabY + tabHeight + 6f;
var rowHeight = 18f; var rowHeight = 18f;
draw.AddRectFilled( draw.AddRectFilled(
@@ -65,7 +66,7 @@ internal static class ThemeMockup
2f 2f
); );
// Accent button (bottom right) // Akzent-Button rechts unten
var btnW = 28f; var btnW = 28f;
var btnH = 10f; var btnH = 10f;
var btnX = origin.X + size.X - btnW - 6f; var btnX = origin.X + size.X - btnW - 6f;
@@ -77,7 +78,7 @@ internal static class ThemeMockup
theme.Layout.FrameRounding theme.Layout.FrameRounding
); );
// Mockup border // Border um das gesamte Mockup
draw.AddRect( draw.AddRect(
origin, origin,
origin + size, origin + size,
+5 -2
View File
@@ -107,7 +107,7 @@ internal sealed class Window : ISettingsTab
1, 1,
10 10
); );
// Floor at 2 seconds to prevent self-soft-lock. // Untergrenze von 2 Sekunden gegen Selbst-Soft-Lock.
Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout); Mutable.InactivityHideTimeout = Math.Max(2, Mutable.InactivityHideTimeout);
using (ImRaii.Disabled(Mutable.HideInBattle)) using (ImRaii.Disabled(Mutable.HideInBattle))
@@ -177,6 +177,7 @@ internal sealed class Window : ISettingsTab
ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove); ImGui.Checkbox(Language.Options_CanMove_Name, ref Mutable.CanMove);
ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize); ImGui.Checkbox(Language.Options_CanResize_Name, ref Mutable.CanResize);
// v0.6.0 — global master switch for the pop-out input bar.
ImGui.Checkbox( ImGui.Checkbox(
HellionStrings.Settings_Window_PopOutInputEnabled_Name, HellionStrings.Settings_Window_PopOutInputEnabled_Name,
ref Mutable.PopOutInputEnabled ref Mutable.PopOutInputEnabled
@@ -185,7 +186,9 @@ internal sealed class Window : ISettingsTab
ImGui.Spacing(); ImGui.Spacing();
// Fallback for off-screen windows after a display layout change. // Manual escape hatch for off-screen windows. The plugin already
// runs an automatic bounds check once per session, but a button
// is the user-friendly fallback after a display layout change.
if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name)) if (ImGui.Button(HellionStrings.Settings_Window_ResetPosition_Name))
Plugin.ChatLogWindow.RequestPositionReset = true; Plugin.ChatLogWindow.RequestPositionReset = true;
ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description); ImGuiUtil.HelpMarker(HellionStrings.Settings_Window_ResetPosition_Description);
+39 -32
View File
@@ -2,7 +2,6 @@ using System.Globalization;
using System.Numerics; using System.Numerics;
using Dalamud.Bindings.ImGui; using Dalamud.Bindings.ImGui;
using Dalamud.Interface; using Dalamud.Interface;
using Dalamud.Interface.Utility;
using Dalamud.Interface.Utility.Raii; using Dalamud.Interface.Utility.Raii;
using HellionChat.Code; using HellionChat.Code;
using HellionChat.Resources; using HellionChat.Resources;
@@ -10,31 +9,32 @@ using HellionChat.Util;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Bottom status bar. Slots left to right: channel indicator, privacy badge, /// <summary>
// counts, tells (hidden at 0), version (right-aligned). Updates at 1Hz; /// Bottom-Status-Bar (v1.2.0). Fix 22 px hoch, BorderTop als Trenner.
// format strings are cached between updates. /// Slots links → rechts: Channel-Indicator (Color-Dot + Channel-Name),
/// Privacy-Badge (Lock-Icon + Privacy-Label), Counts (Tabs + Msgs),
/// Tells (Auto-Tell-Counter, hidden bei 0), Version (rechtsbündig, muted).
///
/// Update-Frequenz: 1×/Sekunde. Format-Strings werden zwischen Updates
/// gecached, damit kein Per-Frame-Format-Allocation entsteht.
/// </summary>
internal sealed class StatusBar internal sealed class StatusBar
{ {
// DPI-aware bar height. The previous fixed 22px constant clipped on public const float Height = 22f;
// Windows display-scaling >100% because ImGui renders the font bigger
// than the reservation. GetTextLineHeightWithSpacing scales with the
// current ImGui font; the 2px spacer is GlobalScale-rounded to stay
// on integer pixel boundaries (same idiom as v1.4.6 F7.2 underline-pill
// in ChatLogWindow.cs:1639-1653).
public static float Height =>
ImGui.GetTextLineHeightWithSpacing() + MathF.Round(2f * ImGuiHelpers.GlobalScale);
private const long UpdateIntervalMs = 1000; private const long UpdateIntervalMs = 1000;
// Initially outdated so the first frame always computes fresh. // Cache-State — initial outdated, damit der erste Frame frisch berechnet.
private long _lastUpdateMs = -UpdateIntervalMs; private long _lastUpdateMs = -UpdateIntervalMs;
private string _cachedCountsText = string.Empty; private string _cachedCountsText = string.Empty;
private string _cachedTellsText = string.Empty; private string _cachedTellsText = string.Empty;
// Pure string logic, testable without ImGui init. /// <summary>
/// Reine String-Logik — testbar ohne ImGui-Init.
/// </summary>
public static string FormatCounts(int tabs, int messages) public static string FormatCounts(int tabs, int messages)
{ {
// InvariantCulture so locale doesn't affect the format (e.g. de_DE "1,2k"). // InvariantCulture: User-System-Locale darf das Format nicht
// verändern (de_DE würde sonst "1,2k" statt "1.2k" liefern).
var msgPart = var msgPart =
messages >= 1000 messages >= 1000
? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0) ? string.Format(CultureInfo.InvariantCulture, "{0:0.0}k msg", messages / 1000.0)
@@ -43,7 +43,10 @@ internal sealed class StatusBar
return $"{tabsPart} · {msgPart}"; return $"{tabsPart} · {msgPart}";
} }
// Pure string logic, testable without ImGui init. Returns empty string at 0 tells. /// <summary>
/// Reine String-Logik — testbar ohne ImGui-Init.
/// 0 Tells → Leerstring (Slot wird ausgeblendet).
/// </summary>
public static string FormatTells(int count) public static string FormatTells(int count)
{ {
if (count <= 0) if (count <= 0)
@@ -51,7 +54,8 @@ internal sealed class StatusBar
return $"{count} {(count == 1 ? "tell" : "tells")}"; return $"{count} {(count == 1 ? "tell" : "tells")}";
} }
// Single-pass replacement for a LINQ Sum+Count pair. Pure helper for unit testing. // Single-pass replacement for the LINQ Sum+Count pair in Draw. Pure
// helper so a future LINQ regression gets pinned by xUnit.
internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs) internal static (int messages, int tells) AggregateForStatusBar(IList<Tab> tabs)
{ {
int messages = 0, int messages = 0,
@@ -65,7 +69,10 @@ internal sealed class StatusBar
return (messages, tells); return (messages, tells);
} }
// Test hook to verify cache logic without a real time source. /// <summary>
/// Test-Hook: Cache-Logic ohne reale Time-Source verifizieren.
/// Nicht für Production-Render.
/// </summary>
internal (string counts, string tells) SnapshotForTest( internal (string counts, string tells) SnapshotForTest(
long now, long now,
int tabs, int tabs,
@@ -86,18 +93,24 @@ internal sealed class StatusBar
_lastUpdateMs = now; _lastUpdateMs = now;
} }
/// <summary>
/// Render-Pfad. Aufrufer pusht bereits den HellionStyle/Theme;
/// wir lesen nur die aktiven Theme-Farben und zeichnen.
/// </summary>
public void Draw(Plugin plugin) public void Draw(Plugin plugin)
{ {
var theme = plugin.ThemeRegistry.Active; var theme = plugin.ThemeRegistry.Active;
var now = Environment.TickCount64; var now = Environment.TickCount64;
// Outer gate keeps the foreach out of the hot path 99% of frames.
// UpdateCacheIfDue runs the same check internally — idempotent.
if (now - _lastUpdateMs >= UpdateIntervalMs) if (now - _lastUpdateMs >= UpdateIntervalMs)
{ {
var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs); var (messages, tells) = AggregateForStatusBar(Plugin.Config.Tabs);
UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells); UpdateCacheIfDue(now, Plugin.Config.Tabs.Count, messages, tells);
} }
// Border top via DrawList -- ImGui.Separator has too much padding. // BorderTop als Trenner — DrawList-Line, ImGui-Separator hat zu viel Padding.
var cursorY = ImGui.GetCursorScreenPos().Y; var cursorY = ImGui.GetCursorScreenPos().Y;
var winLeft = ImGui.GetWindowPos().X; var winLeft = ImGui.GetWindowPos().X;
var winRight = winLeft + ImGui.GetWindowSize().X; var winRight = winLeft + ImGui.GetWindowSize().X;
@@ -110,9 +123,9 @@ internal sealed class StatusBar
1f 1f
); );
ImGui.Dummy(new Vector2(0, 2)); ImGui.Dummy(new Vector2(0, 2)); // BorderTop-Spacing
// Slot 1: active channel indicator // Slot 1: Active-Channel-Indicator
var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid; var inputCh = plugin.CurrentTab?.CurrentChannel?.Channel ?? InputChannel.Invalid;
var hasChannel = inputCh != InputChannel.Invalid; var hasChannel = inputCh != InputChannel.Invalid;
var chatType = inputCh.ToChatType(); var chatType = inputCh.ToChatType();
@@ -124,7 +137,7 @@ internal sealed class StatusBar
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(channelName); ImGui.TextUnformatted(channelName);
// Slot 2: privacy badge // Slot 2: Privacy-Badge — abgeleitet aus PrivacyFilterEnabled.
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
@@ -138,13 +151,13 @@ internal sealed class StatusBar
: HellionStrings.StatusBar_Privacy_Open; : HellionStrings.StatusBar_Privacy_Open;
ImGui.TextUnformatted(privacyLabel); ImGui.TextUnformatted(privacyLabel);
// Slot 3: counts // Slot 3: Counts
ImGui.SameLine(); ImGui.SameLine();
DrawSeparator(); DrawSeparator();
ImGui.SameLine(); ImGui.SameLine();
ImGui.TextUnformatted(_cachedCountsText); ImGui.TextUnformatted(_cachedCountsText);
// Slot 4: tells (hidden at 0) // Slot 4: Tells (nur wenn > 0)
if (!string.IsNullOrEmpty(_cachedTellsText)) if (!string.IsNullOrEmpty(_cachedTellsText))
{ {
ImGui.SameLine(); ImGui.SameLine();
@@ -153,22 +166,16 @@ internal sealed class StatusBar
ImGui.TextUnformatted(_cachedTellsText); ImGui.TextUnformatted(_cachedTellsText);
} }
// Slot 5: version, right-aligned, muted. Hidden when the window is // Slot 5: Version (rechtsbündig, muted)
// too narrow to fit all five slots — the other four need ~200 px
// before the version text starts clipping into them.
var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion"; var versionText = $"v{Plugin.Interface.Manifest.AssemblyVersion} · Hellion";
var versionWidth = ImGui.CalcTextSize(versionText).X; var versionWidth = ImGui.CalcTextSize(versionText).X;
var contentRegionMax = ImGui.GetContentRegionMax().X; var contentRegionMax = ImGui.GetContentRegionMax().X;
const float MinOtherSlotsWidth = 200f;
if (contentRegionMax - versionWidth > MinOtherSlotsWidth)
{
ImGui.SameLine(contentRegionMax - versionWidth); ImGui.SameLine(contentRegionMax - versionWidth);
using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted))) using (ImRaii.PushColor(ImGuiCol.Text, ColourUtil.RgbaToAbgr(theme.Colors.TextMuted)))
{ {
ImGui.TextUnformatted(versionText); ImGui.TextUnformatted(versionText);
} }
} }
}
private static void DrawDot(uint rgba) private static void DrawDot(uint rgba)
{ {
+36 -11
View File
@@ -1,11 +1,22 @@
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Pure string resolver logic with no Dalamud dependency, kept in its own /// <summary>
// file so tests (HellionChat.Tests, no Dalamud reference) can call it directly. /// Reine String-Resolver-Logik ohne Dalamud-Dependency. Bewusst in
// Used in the settings UI glyph picker and indirectly via TabIconMapping.Resolve. /// eigener Datei (Dependency-Boundary auf File-Level sichtbar), damit
/// Tests (HellionChat.Tests, Microsoft.NET.Sdk ohne Dalamud-Reference)
/// sie aufrufen können, ohne dass die JIT beim Methodenaufruf die
/// Dalamud-Assembly laden muss.
///
/// Wird im Settings-UI (T7) für die Glyph-Picker-Combobox und im
/// Render-Code indirekt über <see cref="TabIconMapping.Resolve(Tab)"/>
/// verwendet.
/// </summary>
internal static class TabIconGlyphResolver internal static class TabIconGlyphResolver
{ {
// Single source of truth for the glyph set; order matches the settings combobox. /// <summary>
/// Picker-Options-Pool — Single Source of Truth für das Glyph-Set.
/// Reihenfolge ist die UI-Reihenfolge im Settings-Tab Icon-Combobox.
/// </summary>
public static readonly IReadOnlyList<string> PickerOptions = public static readonly IReadOnlyList<string> PickerOptions =
[ [
"comment", "comment",
@@ -25,13 +36,20 @@ internal static class TabIconGlyphResolver
"fire", "fire",
]; ];
// Derived from PickerOptions -- never maintain this manually. /// <summary>
/// Glyph-Set, das überhaupt als Override akzeptiert wird. Aus
/// <see cref="PickerOptions"/> abgeleitet — KnownGlyphs nie
/// manuell pflegen.
/// </summary>
private static readonly HashSet<string> KnownGlyphs = new( private static readonly HashSet<string> KnownGlyphs = new(
PickerOptions, PickerOptions,
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
); );
// Tab.Name is localised, so we match against a pool of DE/EN synonyms. /// <summary>
/// Tab-Name → Default-Glyph-Name. Tab.Name wird per Lokalisierung
/// gesetzt; wir matchen daher gegen einen Pool aus DE/EN-Synonymen.
/// </summary>
private static readonly Dictionary<string, string> NameDefaults = new( private static readonly Dictionary<string, string> NameDefaults = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -51,11 +69,18 @@ internal static class TabIconGlyphResolver
["tell"] = "envelope", ["tell"] = "envelope",
}; };
// Resolves the glyph name for a tab. Priority order: /// <summary>
// 1. Tab.Icon override (if set): known glyph -> use it, unknown -> "hashtag" /// Test-Surface: Glyph-Name-Resolver ohne Dalamud-Dependency.
// 2. Auto-tell tab -> autoTellGlyph if provided, else "clock" /// Reihenfolge:
// 3. Name default lookup /// 1. Tab.Icon-Override (falls gesetzt und nicht nur Whitespace):
// 4. Fallback "hashtag" /// a) bekannter Glyph → diesen Glyph
/// b) unbekannter Glyph → harter Fallback "hashtag" (User hat
/// bewusst etwas gesetzt, also überstimmt das die Defaults)
/// 2. Auto-Tell-Tab → <paramref name="autoTellGlyph"/> falls
/// übergeben, sonst "clock".
/// 3. Tab-Name-Default (<see cref="NameDefaults"/>-Lookup)
/// 4. Fallback "hashtag"
/// </summary>
public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null) public static string ResolveGlyphName(Tab tab, string? autoTellGlyph = null)
{ {
if (!string.IsNullOrWhiteSpace(tab.Icon)) if (!string.IsNullOrWhiteSpace(tab.Icon))
+35 -8
View File
@@ -2,14 +2,31 @@ using Dalamud.Interface;
namespace HellionChat.Ui; namespace HellionChat.Ui;
// Default icon mapping for tabs, used in top-tabs (icon prefix) and sidebar (icon-only with tooltip). /// <summary>
// Users can override per tab via Settings -> Tabs -> Tab.Icon. /// Default-Icon-Mapping für Tabs. v1.2.0 Layout-Refresh nutzt das
// Pure string resolver logic lives in TabIconGlyphResolver (no Dalamud dependency) for testability. /// in Top-Tabs (Icon-Prefix) und Sidebar (Icon-only mit Tooltip).
/// User können in Settings → Tabs per Tab.Icon-Override eigene
/// FontAwesome-Glyphen setzen.
///
/// Diese Klasse ist Dalamud-abhängig (FontAwesomeIcon-Enum). Die
/// reine String-Resolver-Logik liegt bewusst in
/// <see cref="TabIconGlyphResolver"/> (eigene Datei, ohne
/// Dalamud-Imports), damit Tests sie ohne Dalamud-Reference aufrufen
/// können.
/// </summary>
internal static class TabIconMapping internal static class TabIconMapping
{ {
// Glyph name -> FontAwesomeIcon lookup for production resolve. /// <summary>
// Every key must also exist in TabIconGlyphResolver.PickerOptions. /// FontAwesome-Glyph-Name → Icon-Enum-Lookup. Wird für die
// A missing key silently falls back to FontAwesomeIcon.Hashtag (degraded, no crash). /// Production-Resolve-API benötigt.
///
/// INVARIANTE: Jeder Key in <see cref="GlyphLookup"/> muss auch in
/// <see cref="TabIconGlyphResolver.PickerOptions"/> stehen. Wird
/// ein Glyph zu PickerOptions hinzugefügt, aber nicht hier, fällt
/// die Override-Auflösung still auf <see cref="FontAwesomeIcon.Hashtag"/>
/// zurück (degraded, kein Crash). Build-Time-Enforcement ist nicht
/// möglich, weil PickerOptions ohne Dalamud-Reference auskommt.
/// </summary>
private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new( private static readonly Dictionary<string, FontAwesomeIcon> GlyphLookup = new(
StringComparer.OrdinalIgnoreCase StringComparer.OrdinalIgnoreCase
) )
@@ -31,13 +48,23 @@ internal static class TabIconMapping
["fire"] = FontAwesomeIcon.Fire, ["fire"] = FontAwesomeIcon.Fire,
}; };
// Resolves the icon for a tab. Auto-tell tabs get a per-partner hashed icon /// <summary>
// from the tell pool so parallel tells differ by glyph shape, not just colour. /// Production-Surface: liefert das Icon für einen Tab. Wrapper um
/// <see cref="TabIconGlyphResolver.ResolveGlyphName(Tab)"/> plus
/// Enum-Lookup. Wird von Render-Code (T3, T5) verwendet.
/// </summary>
public static FontAwesomeIcon Resolve(Tab tab) public static FontAwesomeIcon Resolve(Tab tab)
{ {
// v1.2.0 — Auto-Tell-Tabs bekommen ein per-Partner gehashtes
// Icon aus dem Tell-Pool. Damit unterscheiden sich parallele
// Tells nicht nur über die Color (For), sondern auch über die
// Glyph-Form. Berechnung bleibt hier (Dalamud-bound), weil
// TellTarget Dalamud-Imports hat.
string? autoTellGlyph = null; string? autoTellGlyph = null;
if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet()) if (tab.IsTempTab && tab.TellTarget != null && tab.TellTarget.IsSet())
{
autoTellGlyph = TabTintCache.GetIcon(tab); autoTellGlyph = TabTintCache.GetIcon(tab);
}
var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph); var glyph = TabIconGlyphResolver.ResolveGlyphName(tab, autoTellGlyph);
return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag; return GlyphLookup.TryGetValue(glyph, out var icon) ? icon : FontAwesomeIcon.Hashtag;
+30 -26
View File
@@ -17,9 +17,10 @@ internal static class AutoTranslate
private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new(); private static readonly Dictionary<ClientLanguage, List<AutoTranslateEntry>> Entries = new();
private static readonly HashSet<(uint, uint)> ValidEntries = []; private static readonly HashSet<(uint, uint)> ValidEntries = [];
// Serialises all reads/writes against Entries and ValidEntries. // Serializes all reads and writes against Entries / ValidEntries.
// PreloadCache fills both from a worker thread while the main thread // PreloadCache spawns a worker thread that fills both, while the main
// reads via Matching/ReplaceWithPayload/StartsWithCommand. // thread reads them via Matching / ReplaceWithPayload / StartsWithCommand
// — without this lock the HashSet/Dictionary access is undefined.
private static readonly object EntriesLock = new(); private static readonly object EntriesLock = new();
private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser() private static Parser<char, (string name, Maybe<IEnumerable<ISelectorPart>> selector)> Parser()
@@ -53,27 +54,21 @@ internal static class AutoTranslate
return Map((name, sel) => (name, sel), sheetName, selector.Optional()); return Map((name, sel) => (name, sel), sheetName, selector.Optional());
} }
// Warms the auto-translate cache on a background thread so the first /// <summary>
// message send doesn't hitch the main thread. IsBackground keeps plugin /// Preloads auto-translate entries into the cache for the current game
// unload non-blocking even if the warmup is still in flight. /// language. Without this, the first message will take a long time to send
/// (which causes a hitch in the main thread).
///
/// This spawns a new thread.
/// </summary>
internal static void PreloadCache() internal static void PreloadCache()
{ {
var thread = new Thread(() => new Thread(() =>
{ {
var sw = Stopwatch.StartNew(); var sw = Stopwatch.StartNew();
AllEntries(); AllEntries();
// v1.4.9 R3 profiling: Information so the xllog tail surfaces this Plugin.Log.Debug($"Warming up auto-translate took {sw.ElapsedMilliseconds}ms");
// without a Debug filter. Belt-and-suspenders for future plugin-load }).Start();
// regressions; remains in place after Sub-Task 3.4 Befund.
Plugin.LogProxy.Information(
$"Warming up auto-translate took {sw.ElapsedMilliseconds}ms"
);
})
{
IsBackground = true,
Name = "HellionChat-AutoTranslate-Warmup",
};
thread.Start();
} }
private static List<AutoTranslateEntry> AllEntries() private static List<AutoTranslateEntry> AllEntries()
@@ -109,7 +104,7 @@ internal static class AutoTranslate
{ {
if (lookup is not ("" or "@")) if (lookup is not ("" or "@"))
{ {
// SE added whitespace to newer entries; strip it before parsing. // SE added whitespace to the newest additions, but ParseOrThrow doesn't see them as valid
lookup = lookup.Replace(" ", ""); lookup = lookup.Replace(" ", "");
var (sheetName, selector) = parser.ParseOrThrow(lookup); var (sheetName, selector) = parser.ParseOrThrow(lookup);
@@ -149,13 +144,19 @@ internal static class AutoTranslate
columns.Add(0); columns.Add(0);
if (rows.Count == 0) if (rows.Count == 0)
// Can't use index-from-end here because we iterate over integers, // We can't use an "index from end" (like `^0`) here because
// not an array directly. `0..^0` would silently skip the sheet. // we're iterating over integers, not an array directly.
// Previously, we were setting `0..^0` which caused these
// sheets to be completely skipped due to this bug.
// See below.
rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1)); rows.Add(..Index.FromStart((int)sheet.GetRowAt(sheet.Count - 1).RowId + 1));
foreach (var range in rows) foreach (var range in rows)
{ {
// Integer iteration -- can't use index-from-end (see above). // We iterate over the range by numerical values here, so
// we can't use an "index from end" otherwise nothing will
// happen.
// See above.
for (var i = range.Start.Value; i < range.End.Value; i++) for (var i = range.Start.Value; i < range.End.Value; i++)
{ {
if (!sheet.TryGetRow((uint)i, out var rowParser)) if (!sheet.TryGetRow((uint)i, out var rowParser))
@@ -202,7 +203,7 @@ internal static class AutoTranslate
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error(ex, $"failed to translate: {lookup}"); Plugin.Log.Error(ex, $"failed to translate: {lookup}");
} }
} }
@@ -260,6 +261,7 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return; return;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
@@ -306,8 +308,9 @@ internal static class AutoTranslate
start = -1; start = -1;
} }
// Span comparison avoids the msvcrt.dll P/Invoke which is fragile // Pure managed comparison via Span avoids the msvcrt.dll P/Invoke,
// under Wine and caused an extra managed-to-unmanaged copy per check. // which is fragile under Wine and triggered an extra managed-to-
// unmanaged copy per check.
if ( if (
i + search.Length < bytes.Length i + search.Length < bytes.Length
&& bytes.AsSpan(i, search.Length).SequenceEqual(search) && bytes.AsSpan(i, search.Length).SequenceEqual(search)
@@ -322,6 +325,7 @@ internal static class AutoTranslate
if (bytes.Length <= search.Length) if (bytes.Length <= search.Length)
return false; return false;
// populate the list of valid entries
bool needBuild; bool needBuild;
lock (EntriesLock) lock (EntriesLock)
needBuild = ValidEntries.Count == 0; needBuild = ValidEntries.Count == 0;
-16
View File
@@ -1,16 +0,0 @@
namespace HellionChat.Util;
internal sealed class DalamudPlatformUtil : IPlatformUtil
{
public DalamudPlatformUtil()
{
// Util.IsWine probes the host process and never changes for the
// lifetime of a plugin instance, so we cache it once at ctor.
// Mirrors LightlessSync/Services/DalamudUtilService:154.
IsWine = Dalamud.Utility.Util.IsWine();
}
public bool IsWine { get; }
public void OpenLink(string url) => Dalamud.Utility.Util.OpenLink(url);
}
-61
View File
@@ -1,61 +0,0 @@
using System;
using Dalamud.Plugin.Services;
namespace HellionChat.Util;
internal sealed class DalamudPluginLogProxy : IPluginLogProxy
{
private readonly IPluginLog _log;
public DalamudPluginLogProxy(IPluginLog log) => _log = log;
public void Verbose(string message) => _log.Verbose(message);
public void Verbose(Exception exception, string message) => _log.Verbose(exception, message);
public void Verbose(string messageTemplate, params object[] values) =>
_log.Verbose(messageTemplate, values);
public void Debug(string message) => _log.Debug(message);
public void Debug(Exception exception, string message) => _log.Debug(exception, message);
public void Debug(string messageTemplate, params object[] values) =>
_log.Debug(messageTemplate, values);
public void Information(string message) => _log.Information(message);
public void Information(Exception exception, string message) =>
_log.Information(exception, message);
public void Information(string messageTemplate, params object[] values) =>
_log.Information(messageTemplate, values);
public void Info(string message) => _log.Info(message);
public void Info(Exception exception, string message) => _log.Info(exception, message);
public void Info(string messageTemplate, params object[] values) =>
_log.Info(messageTemplate, values);
public void Warning(string message) => _log.Warning(message);
public void Warning(Exception exception, string message) => _log.Warning(exception, message);
public void Warning(string messageTemplate, params object[] values) =>
_log.Warning(messageTemplate, values);
public void Error(string message) => _log.Error(message);
public void Error(Exception exception, string message) => _log.Error(exception, message);
public void Error(string messageTemplate, params object[] values) =>
_log.Error(messageTemplate, values);
public void Fatal(string message) => _log.Fatal(message);
public void Fatal(Exception exception, string message) => _log.Fatal(exception, message);
public void Fatal(string messageTemplate, params object[] values) =>
_log.Fatal(messageTemplate, values);
}
+9 -3
View File
@@ -10,8 +10,9 @@ public static class GlobalParametersCache
public static int GetValue(int index) public static int GetValue(int index)
{ {
// Capture the array reference once so bounds check and read operate // Capture the array reference once so the bounds check and the
// on the same instance if Refresh reassigns Cache between the two. // indexed read operate on the same instance, even if Refresh
// reassigns Cache between the two operations.
var cache = Cache; var cache = Cache;
if (index < 0 || index >= cache.Length) if (index < 0 || index >= cache.Length)
return 0; return 0;
@@ -19,7 +20,12 @@ public static class GlobalParametersCache
return cache[index]; return cache[index];
} }
// Refreshes the cache from RaptureTextModule. Must be called on the main thread. /// <summary>
/// Refresh the cache of global parameters from RaptureTextModule.
/// </summary>
/// <remarks>
/// This should be called in the main thread when updates are necessary.
/// </remarks>
public static unsafe void Refresh() public static unsafe void Refresh()
{ {
if (!ThreadSafety.IsMainThread) if (!ThreadSafety.IsMainThread)
-11
View File
@@ -1,11 +0,0 @@
namespace HellionChat.Util;
// Indirection over Dalamud.Utility.Util's static surface so services can be
// constructed in an isolated xUnit AppDomain without loading Dalamud.dll.
// Production wiring lives in DalamudPlatformUtil; tests substitute a fake.
internal interface IPlatformUtil
{
bool IsWine { get; }
void OpenLink(string url);
}
-40
View File
@@ -1,40 +0,0 @@
using System;
namespace HellionChat.Util;
// Indirection over Dalamud's IPluginLog so MessageStore can be constructed
// in an isolated xUnit AppDomain without loading Dalamud.dll — same pattern
// as IPlatformUtil from F12.1. A later DI-container cycle (v1.5.x) may
// replace this with Microsoft.Extensions.Logging's ILogger<T>.
internal interface IPluginLogProxy
{
void Verbose(string message);
void Verbose(Exception exception, string message);
void Verbose(string messageTemplate, params object[] values);
void Debug(string message);
void Debug(Exception exception, string message);
void Debug(string messageTemplate, params object[] values);
void Information(string message);
void Information(Exception exception, string message);
void Information(string messageTemplate, params object[] values);
// IPluginLog exposes Info as a distinct method (short alias of
// Information) — both are present so call-sites stay drop-in.
void Info(string message);
void Info(Exception exception, string message);
void Info(string messageTemplate, params object[] values);
void Warning(string message);
void Warning(Exception exception, string message);
void Warning(string messageTemplate, params object[] values);
void Error(string message);
void Error(Exception exception, string message);
void Error(string messageTemplate, params object[] values);
void Fatal(string message);
void Fatal(Exception exception, string message);
void Fatal(string messageTemplate, params object[] values);
}
+37 -9
View File
@@ -11,7 +11,8 @@ public readonly unsafe ref struct GfdFileView
private readonly ReadOnlySpan<byte> Span; private readonly ReadOnlySpan<byte> Span;
private readonly bool DirectLookup; private readonly bool DirectLookup;
// span: raw .gfd file bytes /// <summary>Initializes a new instance of the <see cref="GfdFileView"/> struct.</summary>
/// <param name="span">The data.</param>
public GfdFileView(ReadOnlySpan<byte> span) public GfdFileView(ReadOnlySpan<byte> span)
{ {
Span = span; Span = span;
@@ -26,13 +27,18 @@ public readonly unsafe ref struct GfdFileView
DirectLookup &= i + 1 == entries[i].Id; DirectLookup &= i + 1 == entries[i].Id;
} }
/// <summary>Gets the header.</summary>
private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span); private ref readonly GfdHeader Header => ref MemoryMarshal.AsRef<GfdHeader>(Span);
/// <summary>Gets the entries.</summary>
private ReadOnlySpan<GfdEntry> Entries => private ReadOnlySpan<GfdEntry> Entries =>
MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]); MemoryMarshal.Cast<byte, GfdEntry>(Span[sizeof(GfdHeader)..]);
// Returns true if the entry was found. /// <summary>Attempts to get an entry.</summary>
// followRedirect: whether to chase redirect chains. /// <param name="iconId">The icon ID.</param>
/// <param name="entry">The entry.</param>
/// <param name="followRedirect">Whether to follow redirects.</param>
/// <returns><c>true</c> if found.</returns>
public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true) public bool TryGetEntry(uint iconId, out GfdEntry entry, bool followRedirect = true)
{ {
if (iconId == 0) if (iconId == 0)
@@ -44,8 +50,9 @@ public readonly unsafe ref struct GfdFileView
var entries = Entries; var entries = Entries;
if (DirectLookup) if (DirectLookup)
{ {
// Follow redirects on the direct-lookup path for consistency with // Resolve redirects on the direct-lookup path too — the binary-search
// the binary-search path. // path follows them, and skipping them here was inconsistent for
// contiguous ID sets.
var visited = 0; var visited = 0;
while (iconId <= entries.Length) while (iconId <= entries.Length)
{ {
@@ -100,28 +107,49 @@ public readonly unsafe ref struct GfdFileView
return false; return false;
} }
// .gfd file header /// <summary>Header of a .gfd file.</summary>
[StructLayout(LayoutKind.Sequential)] [StructLayout(LayoutKind.Sequential)]
public struct GfdHeader public struct GfdHeader
{ {
public fixed byte Signature[8]; // "gftd0100" /// <summary>Signature: "gftd0100".</summary>
public fixed byte Signature[8];
/// <summary>Number of entries.</summary>
public int Count; public int Count;
/// <summary>Unused/unknown.</summary>
public fixed byte Padding[4]; public fixed byte Padding[4];
} }
// .gfd file entry -- one icon slot /// <summary>An entry of a .gfd file.</summary>
[StructLayout(LayoutKind.Sequential, Size = 0x10)] [StructLayout(LayoutKind.Sequential, Size = 0x10)]
public struct GfdEntry public struct GfdEntry
{ {
/// <summary>ID of the entry.</summary>
public ushort Id; public ushort Id;
/// <summary>The left offset of the entry.</summary>
public ushort Left; public ushort Left;
/// <summary>The top offset of the entry.</summary>
public ushort Top; public ushort Top;
/// <summary>The width of the entry.</summary>
public ushort Width; public ushort Width;
/// <summary>The height of the entry.</summary>
public ushort Height; public ushort Height;
/// <summary>Unknown/unused.</summary>
public ushort Unk0A; public ushort Unk0A;
public ushort Redirect; // non-zero = redirects to another entry
/// <summary>The redirected entry, maybe.</summary>
public ushort Redirect;
/// <summary>Unknown/unused.</summary>
public ushort Unk0E; public ushort Unk0E;
/// <summary>Gets a value indicating whether this entry is effectively empty.</summary>
public bool IsEmpty => Width == 0 || Height == 0; public bool IsEmpty => Width == 0 || Height == 0;
} }
} }
+5 -15
View File
@@ -254,17 +254,6 @@ internal static class ImGuiUtil
return end; return end;
} }
// ---------------------------------------------------------------
// Inspired by ChatTwo upstream f35b7d3 (Infiziert90, 2026-05-12).
// Upstream dropped the width parameter (no callers there); we keep
// it because two ChatLogWindow header buttons size themselves to
// match the ChannelIcon button's frame. The actual bug is the
// manual size = width - 2 * CellPadding.X subtraction: CellPadding
// scales with HUD scale, the raw int does not, so the button
// shrank under high HUD scales. ImGui.Button already handles its
// own frame padding internally — pass the measured width straight
// through.
// ---------------------------------------------------------------
internal static bool IconButton( internal static bool IconButton(
FontAwesomeIcon icon, FontAwesomeIcon icon,
string? id = null, string? id = null,
@@ -279,7 +268,10 @@ internal static class ImGuiUtil
bool ret; bool ret;
using (Plugin.FontManager.FontAwesome.Push()) using (Plugin.FontManager.FontAwesome.Push())
{ {
var size = width > 0 ? new Vector2(width, 0f) : Vector2.Zero; var size = Vector2.Zero;
if (width > 0)
size.X = width - 2 * ImGui.GetStyle().CellPadding.X;
ret = ImGui.Button(label, size); ret = ImGui.Button(label, size);
} }
@@ -583,9 +575,7 @@ internal static class ImGuiUtil
using (ImRaii.Disabled(isMax)) using (ImRaii.Disabled(isMax))
{ {
// Parentheses pin the operator precedence: without them this resolves as if (IconButton(FontAwesomeIcon.ArrowRight, id + 1.ToString()))
// id.ToString() + "1" (e.g. "01" instead of "1").
if (IconButton(FontAwesomeIcon.ArrowRight, (id + 1).ToString()))
selected++; selected++;
} }
+10 -2
View File
@@ -31,10 +31,18 @@ public static class MathUtil
public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}"; public override string ToString() => $"X: {X} Y: {Y} Width: {Width} Height: {Height}";
} }
// Standard AABB overlap test. Inclusive on both axes to catch shared /// <summary>
// edges and identical rectangles (previous ValueInRange approach missed these). /// Checks if two rectangles overlap at any point.
/// </summary>
/// <param name="a"></param>
/// <param name="b"></param>
/// <returns>True if overlapping</returns>
public static bool HasOverlap(this Rectangle a, Rectangle b) public static bool HasOverlap(this Rectangle a, Rectangle b)
{ {
// Standard AABB overlap test: two rectangles overlap iff they
// overlap on both axes. The previous nested ValueInRange approach
// used strict inequalities at both ends, which dropped identical
// rectangles and shared-edge cases as false negatives.
return a.X < b.X + b.Width return a.X < b.X + b.Width
&& a.X + a.Width > b.X && a.X + a.Width > b.X
&& a.Y < b.Y + b.Height && a.Y < b.Y + b.Height
+1 -1
View File
@@ -42,6 +42,6 @@ public static class MemoryUtil
str.Append(' '); str.Append(' ');
} }
Plugin.LogProxy.Information(str.ToString()); Plugin.Log.Information(str.ToString());
} }
} }
+42 -13
View File
@@ -13,10 +13,15 @@ internal class PartyFinderPayload : Payload
Id = id; Id = id;
} }
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
protected override void DecodeImpl(BinaryReader reader, long endOfStream) =>
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException();
}
} }
internal class AchievementPayload : Payload internal class AchievementPayload : Payload
@@ -30,10 +35,15 @@ internal class AchievementPayload : Payload
Id = id; Id = id;
} }
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
protected override void DecodeImpl(BinaryReader reader, long endOfStream) =>
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException();
}
} }
internal class UriPayload(Uri uri) : Payload internal class UriPayload(Uri uri) : Payload
@@ -45,14 +55,20 @@ internal class UriPayload(Uri uri) : Payload
private const string DefaultScheme = "https"; private const string DefaultScheme = "https";
private static readonly string[] ExpectedSchemes = ["http", "https"]; private static readonly string[] ExpectedSchemes = ["http", "https"];
// Parses a raw URI string. Defaults to https:// if no scheme is present. /// <summary>
// Throws UriFormatException for empty input or unsupported schemes. /// Create a URIPayload from a raw URI string. If the URI does not have a
/// scheme, it will default to https://.
/// </summary>
/// <exception cref="UriFormatException">
/// If the URI is invalid, or if the scheme is not supported.
/// </exception>
public static UriPayload ResolveUri(string rawUri) public static UriPayload ResolveUri(string rawUri)
{ {
ArgumentNullException.ThrowIfNull(rawUri); ArgumentNullException.ThrowIfNull(rawUri);
if (string.IsNullOrWhiteSpace(rawUri)) if (string.IsNullOrWhiteSpace(rawUri))
throw new UriFormatException("URI cannot be empty or whitespace."); throw new UriFormatException("URI cannot be empty or whitespace.");
// Check for an expected scheme '://', if not add 'https://'
if (ExpectedSchemes.Any(scheme => rawUri.StartsWith($"{scheme}://"))) if (ExpectedSchemes.Any(scheme => rawUri.StartsWith($"{scheme}://")))
return new UriPayload(new Uri(rawUri)); return new UriPayload(new Uri(rawUri));
@@ -62,10 +78,15 @@ internal class UriPayload(Uri uri) : Payload
return new UriPayload(new Uri($"{DefaultScheme}://{rawUri}")); return new UriPayload(new Uri($"{DefaultScheme}://{rawUri}"));
} }
protected override void DecodeImpl(BinaryReader reader, long endOfStream) => protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
throw new NotImplementedException();
}
} }
internal class EmotePayload : Payload internal class EmotePayload : Payload
@@ -74,10 +95,18 @@ internal class EmotePayload : Payload
public string Code = string.Empty; public string Code = string.Empty;
public static EmotePayload ResolveEmote(string code) => new EmotePayload { Code = code }; public static EmotePayload ResolveEmote(string code)
{
return new EmotePayload { Code = code };
}
protected override void DecodeImpl(BinaryReader reader, long endOfStream) => protected override void DecodeImpl(BinaryReader reader, long endOfStream)
{
throw new NotImplementedException(); throw new NotImplementedException();
}
protected override byte[] EncodeImpl() => throw new NotImplementedException(); protected override byte[] EncodeImpl()
{
throw new NotImplementedException();
}
} }
-16
View File
@@ -1,16 +0,0 @@
namespace HellionChat.Util;
// Pure predicates for the TempTab pin lifecycle. Extracted from the strip
// sites in Plugin.cs and Configuration.cs so they stay in lockstep — a
// load-time strip that disagrees with the save-time strip is exactly how
// pinned tabs would silently fall out of the JSON.
internal static class TabLifecycleHelpers
{
public static bool IsInUnpinnedPool(Tab t) => t.IsTempTab && !t.IsPinned;
public static bool IsInPinnedPool(Tab t) => t.IsTempTab && t.IsPinned;
public static bool ShouldStripOnLoad(Tab t) => IsInUnpinnedPool(t);
public static bool ShouldStripOnSave(Tab t) => IsInUnpinnedPool(t);
}
+18 -9
View File
@@ -14,8 +14,12 @@ public static class TabsUtil
return channels; return channels;
} }
// Public-chat-only: Say, Yell, Shout. Group/FC/Linkshell and gameplay // Hellion-tuned General preset (v1.0.0 — sharpened defaults).
// events live in their own tabs to keep General focused on open-world chat. // Public-chat-only, the bare three channels you encounter in open
// world. Group/FC/Linkshell traffic moves to dedicated tabs, gameplay
// events (loot, crafting, gathering, NPC dialogue, PF pings) move to
// the System tab where they belong — keeps the General view focused
// on actual conversation in the immediate surroundings.
public static Tab VanillaGeneral => public static Tab VanillaGeneral =>
new() new()
{ {
@@ -51,8 +55,11 @@ public static class TabsUtil
AllSenderMessages = true, AllSenderMessages = true,
}; };
// Hellion tab presets. Names live in HellionStrings (EN+DE) so upstream // Hellion default-tab presets used by the v10 wipe migration. Names are
// resource files stay untouched. // kept in HellionStrings (EN+DE) instead of Language.* so the upstream
// resource files stay untouched. Channel selections cover the channels
// a typical Eorzea raider uses without forcing the user to hand-tick
// each box on first start.
public static Tab HellionFreeCompany => public static Tab HellionFreeCompany =>
new() new()
{ {
@@ -81,8 +88,10 @@ public static class TabsUtil
[ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All),
}, },
// No input-channel switch: Party pulls in multiple channel types // No automatic input-channel switch; the Gruppe tab is a read
// and auto-routing /party would surprise users wanting /alliance or /pvpteam. // surface that pulls in Party, CrossParty, Alliance and PvpTeam
// together. Auto-routing /party into this tab would surprise the
// user when they actually wanted /alliance or /pvpteam.
}; };
public static Tab HellionBeginner => public static Tab HellionBeginner =>
@@ -103,7 +112,7 @@ public static class TabsUtil
Name = HellionStrings.Tabs_Presets_System, Name = HellionStrings.Tabs_Presets_System,
SelectedChannels = new Dictionary<ChatType, (ChatSource, ChatSource)> SelectedChannels = new Dictionary<ChatType, (ChatSource, ChatSource)>
{ {
// System noise // Plain system noise
[ChatType.Debug] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Debug] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.Urgent] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Urgent] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.Notice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.Notice] = (ChatSourceExt.All, ChatSourceExt.All),
@@ -113,7 +122,7 @@ public static class TabsUtil
[ChatType.GatheringSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.GatheringSystem] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.NoviceNetworkSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NoviceNetworkSystem] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.BattleSystem] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.BattleSystem] = (ChatSourceExt.All, ChatSourceExt.All),
// Login/logout/announcement noise // Login / logout / announcement noise
[ChatType.NpcAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NpcAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.FreeCompanyAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.FreeCompanyAnnouncement] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.FreeCompanyLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.FreeCompanyLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All),
@@ -121,7 +130,7 @@ public static class TabsUtil
[ChatType.PvpTeamLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.PvpTeamLoginLogout] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.RetainerSale] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.RetainerSale] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.PeriodicRecruitmentNotification] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.PeriodicRecruitmentNotification] = (ChatSourceExt.All, ChatSourceExt.All),
// Gameplay event streams // Gameplay-event streams (moved out of General in v1.0.0)
[ChatType.NpcDialogue] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.NpcDialogue] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootNotice] = (ChatSourceExt.All, ChatSourceExt.All),
[ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All), [ChatType.LootRoll] = (ChatSourceExt.All, ChatSourceExt.All),
+12 -2
View File
@@ -135,8 +135,18 @@ public static class Tokenizer
public int Precedence { get; set; } public int Precedence { get; set; }
} }
// Matches URLs with http(s):// or www. prefix, and bare domains on known TLDs. /// <summary>
// Examples: https://example.com, www.sub.example.com, example.com /// URLRegex returns a regex object that matches URLs like:
/// - https://example.com
/// - http://example.com
/// - www.example.com
/// - https://sub.example.com
/// - example.com
/// - sub.example.com
///
/// It matches URLs with www. or https:// prefix, and also matches URLs
/// without a prefix on specific TLDs.
/// </summary>
private static readonly Regex UrlRegex = new( private static readonly Regex UrlRegex = new(
@"(?<URL>((https?:\/\/|www\.)[a-z0-9-]+(\.[a-z0-9-]+)*|([a-z0-9-]+(\.[a-z0-9-]+)*\.(com|net|org|co|io|app)))(:[\d]{1,5})?(\/[^\s]*)?)", @"(?<URL>((https?:\/\/|www\.)[a-z0-9-]+(\.[a-z0-9-]+)*|([a-z0-9-]+(\.[a-z0-9-]+)*\.(com|net|org|co|io|app)))(:[\d]{1,5})?(\/[^\s]*)?)",
RegexOptions.Compiled | RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture RegexOptions.Compiled | RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture
-21
View File
@@ -1,21 +0,0 @@
namespace HellionChat.Util;
internal static class UrlValidation
{
// Used by BrandingLinks/IntegrationLinks at module init. A typo in a URL
// rotation throws loudly at plugin load instead of silently failing when
// a user clicks the broken button.
public static void ValidateAll(string source, params string[] urls)
{
foreach (var url in urls)
{
if (
!Uri.TryCreate(url, UriKind.Absolute, out var uri)
|| (uri.Scheme is not "https" and not "http")
)
{
throw new InvalidOperationException($"{source} contains malformed URL: {url}");
}
}
}
}
+3 -3
View File
@@ -21,12 +21,12 @@ public static class WrapperUtil
{ {
try try
{ {
Plugin.LogProxy.Debug($"Opening URI {uri} in default browser"); Plugin.Log.Debug($"Opening URI {uri} in default browser");
Plugin.PlatformUtil.OpenLink(uri.ToString()); Dalamud.Utility.Util.OpenLink(uri.ToString());
} }
catch (Exception ex) catch (Exception ex)
{ {
Plugin.LogProxy.Error($"Error opening URI: {ex}"); Plugin.Log.Error($"Error opening URI: {ex}");
AddNotification(Language.Context_OpenInBrowserError, NotificationType.Error); AddNotification(Language.Context_OpenInBrowserError, NotificationType.Error);
} }
} }
@@ -2,17 +2,16 @@ using System;
namespace HellionChat._Helpers; namespace HellionChat._Helpers;
// Extracted history-navigation cursor math from CompactCallback to allow unit // Pure-helper mirror of the compact pop-out history-navigation cursor
// testing without ImGuiInputTextCallbackData (DeleteChars/InsertChars). // math. The original CompactCallback was tangled with ImGuiInputTextCallbackData
// Buffer mutation stays at the call site; only the cursor/replacement decision lives here. // (DeleteChars/InsertChars), which can't be exercised in xUnit. The
// ImGui buffer mutation stays at the call site; only the deterministic
// cursor-and-replacement decision lives here.
// //
// Index semantics match InputHistoryService: // Index semantics match InputHistoryService:
// index 0 = oldest entry // index 0 = oldest entry
// index Count-1 = newest entry // index Count - 1 = newest entry
// cursor == -1 = not browsing history // cursor == -1 = "not browsing history"
//
// replacement == null: caller must NOT touch the buffer (cursor unchanged).
// replacement != null: write it to the buffer (including "" to clear it).
// //
// TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputHistoryNavigatorTests.cs // TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputHistoryNavigatorTests.cs
public static class CompactInputHistoryNavigator public static class CompactInputHistoryNavigator
@@ -23,6 +22,9 @@ public static class CompactInputHistoryNavigator
Down, Down,
} }
// replacement == null means: caller must NOT touch the buffer. This
// distinguishes "cursor unchanged, leave the user's typing alone"
// from "cursor moved to an empty slot, clear the buffer".
public static (int cursor, string? replacement) Navigate( public static (int cursor, string? replacement) Navigate(
Direction direction, Direction direction,
int currentCursor, int currentCursor,
@@ -36,6 +38,7 @@ public static class CompactInputHistoryNavigator
ArgumentNullException.ThrowIfNull(push); ArgumentNullException.ThrowIfNull(push);
ArgumentNullException.ThrowIfNull(getByCursor); ArgumentNullException.ThrowIfNull(getByCursor);
var prev = currentCursor;
var next = currentCursor; var next = currentCursor;
switch (direction) switch (direction)
@@ -43,7 +46,8 @@ public static class CompactInputHistoryNavigator
case Direction.Up: case Direction.Up:
if (currentCursor == -1) if (currentCursor == -1)
{ {
// Stash current input so the user can recover it after browsing. // First Up press from a fresh buffer: stash whatever
// the user typed so they can recover it after browsing.
var offset = 0; var offset = 0;
if (!string.IsNullOrWhiteSpace(currentBuffer)) if (!string.IsNullOrWhiteSpace(currentBuffer))
{ {
@@ -53,9 +57,10 @@ public static class CompactInputHistoryNavigator
next = getCount() - 1 - offset; next = getCount() - 1 - offset;
} }
else if (currentCursor > 0) else if (currentCursor > 0)
{
next--; next--;
}
break; break;
case Direction.Down: case Direction.Down:
if (currentCursor != -1) if (currentCursor != -1)
{ {
@@ -66,9 +71,10 @@ public static class CompactInputHistoryNavigator
break; break;
} }
if (next == currentCursor) if (prev == next)
return (next, null); return (next, null);
return (next, getByCursor(next) ?? string.Empty); var replacement = getByCursor(next) ?? string.Empty;
return (next, replacement);
} }
} }
@@ -3,8 +3,11 @@ using HellionChat.Ui;
namespace HellionChat._Helpers; namespace HellionChat._Helpers;
// Extracted submit logic from ChatInputBar.SubmitCompact to allow unit testing // Pure-helper mirror of the compact pop-out submit flow. ChatInputBar's
// without a sealed ChatLogWindow dependency. // SubmitCompact used to inline this against a sealed ChatLogWindow, which
// blocks Moq-based isolation. Lifting the deterministic part into a POCO
// keeps the production call site a one-liner while letting xUnit assert
// the buffer/cursor reset and the sender contract directly.
// TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputSubmitterTests.cs // TEST-MIRROR: ../../../Hellion Build test/Ui/CompactInputSubmitterTests.cs
public static class CompactInputSubmitter public static class CompactInputSubmitter
{ {
+11 -21
View File
@@ -2,7 +2,7 @@
[![Build](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml/badge.svg?branch=main)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml) [![Build](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml/badge.svg?branch=main)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/actions/workflows/build.yml)
[![License: EUPL-1.2](https://img.shields.io/badge/License-EUPL--1.2-blue.svg)](LICENSE) [![License: EUPL-1.2](https://img.shields.io/badge/License-EUPL--1.2-blue.svg)](LICENSE)
[![Latest release](https://img.shields.io/badge/release-v1.4.9-brightgreen)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/latest) [![Latest release](https://img.shields.io/badge/release-v1.4.3-brightgreen)](https://gitea.hellion-forge.cloud/JonKazama-Hellion/HellionChat/releases/latest)
[![Dalamud API](https://img.shields.io/badge/Dalamud-API_15-purple)](https://github.com/goatcorp/Dalamud) [![Dalamud API](https://img.shields.io/badge/Dalamud-API_15-purple)](https://github.com/goatcorp/Dalamud)
[![.NET](https://img.shields.io/badge/.NET-10.0-512BD4)](https://dotnet.microsoft.com/) [![.NET](https://img.shields.io/badge/.NET-10.0-512BD4)](https://dotnet.microsoft.com/)
[![FFXIV](https://img.shields.io/badge/FFXIV-Dawntrail-c3a37f)](https://www.finalfantasyxiv.com/) [![FFXIV](https://img.shields.io/badge/FFXIV-Dawntrail-c3a37f)](https://www.finalfantasyxiv.com/)
@@ -11,7 +11,7 @@
<img src="docs/images/hellion-forge.png" alt="Hellion Forge" width="180" /> <img src="docs/images/hellion-forge.png" alt="Hellion Forge" width="180" />
</p> </p>
**Version 1.4.9** — Privacy-first chat plugin for FINAL FANTASY XIV / Dalamud, built on **Version 1.4.3** — Privacy-first chat plugin for FINAL FANTASY XIV / Dalamud, built on
[Chat 2](https://github.com/Infiziert90/ChatTwo) (EUPL-1.2). [Chat 2](https://github.com/Infiziert90/ChatTwo) (EUPL-1.2).
Hellion Chat is a privacy-first plugin built on the Chat 2 foundation. The majority of the engine comes from Chat 2 Hellion Chat is a privacy-first plugin built on the Chat 2 foundation. The majority of the engine comes from Chat 2
@@ -102,7 +102,7 @@ Hellion Chat is developed under **Hellion Forge**, the specialized modding and p
#### Custom Themes (v1.1.0) #### Custom Themes (v1.1.0)
HellionChat ships a theme engine with ten built-in themes (Hellion Arctic, Hellion Spectrum, Chat 2 Classic, Event HellionChat ships a theme engine with ten built-in themes (Hellion Arctic, Hellion Spectrum, Chat 2 Classic, Event
Horizon, Crystal Nocturne, Mint Grove, Night Blue, Indigo Violet, Forge Merchantman, Synthwave Sunset) and a JSON-based Horizon, Moonlit Bloom, Mint Grove, Night Blue, Indigo Violet, Forge Merchantman, Synthwave Sunset) and a JSON-based
authoring format for custom themes. Schema and step-by-step guide in authoring format for custom themes. Schema and step-by-step guide in
[`docs/THEME-AUTHORING.md`](docs/THEME-AUTHORING.md). Hellion Spectrum is Deuteranopia/Protanopia-safe (red-green color [`docs/THEME-AUTHORING.md`](docs/THEME-AUTHORING.md). Hellion Spectrum is Deuteranopia/Protanopia-safe (red-green color
blindness) based on the Wong/Okabe-Ito palette. blindness) based on the Wong/Okabe-Ito palette.
@@ -286,24 +286,14 @@ An optional submission to the Dalamud main plugin repo (in addition to the custo
## Project Status ## Project Status
**Version 1.4.9** — Plugin-Load Render Polish. First-frame render cost is now well under Dalamud's 100 ms HITCH **Version 1.4.3** — Plugin-load async init plus repo cutover: the plugin has been migrated to Dalamud's
warning threshold (~76 ms median, down from ~127 ms). The gain comes from deferring six non-essential rendering `IAsyncDalamudPlugin` API. The constructor now handles only bootstrap essentials (config load, language init, conflict
sections on the very first Draw — bottom status bar, channel-name SeString chunks, window bounds check, hint detection); migrations, service allocations, window construction, and hook subscriptions move into `LoadAsync`, allowing
banner, autocomplete and input-preview calculation — so the initial ImGui layout cost is spread between frame 0 Dalamud to keep the UI responsive during heavy lifting. A schema gate replaces the v9 → v16 migration chain; configs at
and frame 1 instead of all hitting at once. At 60 fps the user sees those sections one frame (~17 ms) later, which schema v16+ load directly, older configs trigger an "install v1.4.2 first" error message. Custom repo URL migrated to
is invisible inside the post-reload font-atlas build window. Slash commands `/hellion`, `/hellionView`, `gitea.hellion-forge.cloud`; the GitHub repo remains as a frozen v1.4.2 snapshot. Plugin load time is ~3.7 s median (5
`/hellionSeString` and `/hellionDebugger` are now registered centrally during plugin load so they work before reloads), comparable to v1.4.2 — the async migration is the foundation for v1.4.4 lazy-init optimizations, not a direct
their target window is opened the first time. The configuration-button entry in Dalamud's plugin manager hangs on user-facing win. Fourth sub-patch of the v1.4.x polish sweep series (as of 2026-05-08).
the same path. Three plugin-load profiling logs (auto-translate warm-up, message-store connect, tab filter) stay
on at Information level as a regression tripwire — if a future change pushes the load past 100 ms again, the cost
is right there in `/xllog`. The release also ships a ChatTwo IPC compatibility layer: HellionChat now mirrors
ChatTwo's full IPC surface (`GetChatInputState`, `ChatInputStateChanged`, `Register`, `Unregister`, `Available`,
`Invoke`) under the `ChatTwo.*` namespace in addition to our existing `HellionChat.*` provider gates, so
third-party integrations that historically only subscribe to ChatTwo's IPC (Artisan's and AllaganTools' context-
menu hooks are the practical examples) keep working without requiring a code change on their side. Conflict
detection prevents ChatTwo from loading in parallel with HellionChat, so there is no slot-collision risk at
runtime. Migration v17 stays (no schema bump). Tenth sub-patch of the v1.4.x polish sweep series (as of
2026-05-15).
Hellion Chat is a standalone plugin, no longer a fork in the repository sense. Fully completed: Hellion Chat is a standalone plugin, no longer a fork in the repository sense. Fully completed:

Some files were not shown because too many files have changed in this diff Show More