JonKazama-Hellion
9ea9e96145
The real defect first. RefreshDatabaseMetadata was the one worker of six that never took the shared lock, and its flag was the one of six missing from the tab's busy state. It calls MessageCount, which holds the read lock, so a wipe could start while it was in there -- and the tab would not have known to grey the button, because it could not see the worker. Both halves fixed. The pattern is why: seven near-copies of one worker skeleton, and each copy decided something slightly different. The clear button failed silently when its thread could not start. The most destructive control in the plugin, pressed, and nothing happens, with no way to tell that from a wipe that worked -- while the three harmless workers beside it do report. Maintenance was the mirror: its comment promises refusals are said out loud, and then swallowed the actual failure. Three start-failure paths also bypassed the notify helper that carries the teardown check, three weeks after it was added for exactly that. The database numbers now wait for a real read, like the clear hint already did. Zero bytes and zero messages read as an empty database, not as a number nobody has fetched. SelectionAfterDelete is gone, with its three tests. The accordion has no selection, so its return value went into a discard -- a function answering a question the interface does not ask, with green tests guarding nothing. The project's own self-test README calls that the anti-pattern of record. Six new keys replaced by the translated orphans that already said the same thing. A commit earlier in this cycle is literally called "stop duplicating a key" and these went past it. The duplicate button also had the label "Add", which is the one string out of ninety-four that was never written. Tests: CleanupDeleteTypes had none, and with the failsafe on -- how a fresh config ships -- it is the path every cleanup takes. Four now, including the one that matters: an empty list deletes nothing rather than everything. And a self-test for the gate wiring, which is what would have caught the metadata worker. The unit tests prove the gate works; nothing proved the workers use it.
155 lines
5.4 KiB
C#
155 lines
5.4 KiB
C#
using HellionChat.Code;
|
|
using HellionChat.Resources;
|
|
|
|
namespace HellionChat.Privacy;
|
|
|
|
// The eight buckets the privacy surface sorts channels into. Eighty-nine
|
|
// checkboxes in one flat list is not a choice anybody makes; eight named groups
|
|
// is. Shared by the export form and the persist grid so the two screens
|
|
// describe channels the same way.
|
|
//
|
|
// Headings are functions, not strings, so a language switch at runtime relabels
|
|
// them on the next frame. A captured string would keep the language the window
|
|
// happened to be opened in.
|
|
//
|
|
// Game Master channels follow ChatTypeExt.Parent(), which already pairs each of
|
|
// them with its player counterpart. Filing them all under system traffic reads
|
|
// tidier but puts GmTell -- a private two-person conversation -- outside the
|
|
// direct-messages group, and an access request that quietly drops part of what
|
|
// it promises is the dangerous kind of gap.
|
|
//
|
|
// Every ChatType belongs to exactly one group, and a build-suite test pins that.
|
|
// A channel in no group cannot be picked in any of these screens, which reads as
|
|
// a missing checkbox rather than as an omission.
|
|
internal static class ChannelGroups
|
|
{
|
|
internal static readonly (Func<string> Heading, ChatType[] Types)[] All =
|
|
[
|
|
(
|
|
() => HellionStrings.Privacy_Group_DirectMessages,
|
|
[ChatType.TellIncoming, ChatType.TellOutgoing, ChatType.GmTell]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_PartyAlliance,
|
|
[
|
|
ChatType.Party,
|
|
ChatType.CrossParty,
|
|
ChatType.Alliance,
|
|
ChatType.PvpTeam,
|
|
ChatType.PvpTeamAnnouncement,
|
|
ChatType.PvpTeamLoginLogout,
|
|
ChatType.GmParty,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_FreeCompany,
|
|
[
|
|
ChatType.FreeCompany,
|
|
ChatType.FreeCompanyAnnouncement,
|
|
ChatType.FreeCompanyLoginLogout,
|
|
ChatType.GmFreeCompany,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_Linkshells,
|
|
[
|
|
ChatType.Linkshell1,
|
|
ChatType.Linkshell2,
|
|
ChatType.Linkshell3,
|
|
ChatType.Linkshell4,
|
|
ChatType.Linkshell5,
|
|
ChatType.Linkshell6,
|
|
ChatType.Linkshell7,
|
|
ChatType.Linkshell8,
|
|
ChatType.GmLinkshell1,
|
|
ChatType.GmLinkshell2,
|
|
ChatType.GmLinkshell3,
|
|
ChatType.GmLinkshell4,
|
|
ChatType.GmLinkshell5,
|
|
ChatType.GmLinkshell6,
|
|
ChatType.GmLinkshell7,
|
|
ChatType.GmLinkshell8,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_CrossLinkshells,
|
|
[
|
|
ChatType.CrossLinkshell1,
|
|
ChatType.CrossLinkshell2,
|
|
ChatType.CrossLinkshell3,
|
|
ChatType.CrossLinkshell4,
|
|
ChatType.CrossLinkshell5,
|
|
ChatType.CrossLinkshell6,
|
|
ChatType.CrossLinkshell7,
|
|
ChatType.CrossLinkshell8,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_ExtraChat,
|
|
[
|
|
ChatType.ExtraChatLinkshell1,
|
|
ChatType.ExtraChatLinkshell2,
|
|
ChatType.ExtraChatLinkshell3,
|
|
ChatType.ExtraChatLinkshell4,
|
|
ChatType.ExtraChatLinkshell5,
|
|
ChatType.ExtraChatLinkshell6,
|
|
ChatType.ExtraChatLinkshell7,
|
|
ChatType.ExtraChatLinkshell8,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_PublicChat,
|
|
[
|
|
ChatType.Say,
|
|
ChatType.Shout,
|
|
ChatType.Yell,
|
|
ChatType.NoviceNetwork,
|
|
ChatType.NoviceNetworkSystem,
|
|
ChatType.CustomEmote,
|
|
ChatType.StandardEmote,
|
|
ChatType.GmSay,
|
|
ChatType.GmShout,
|
|
ChatType.GmYell,
|
|
ChatType.GmNoviceNetwork,
|
|
]
|
|
),
|
|
(
|
|
() => HellionStrings.Privacy_Group_SystemLogs,
|
|
[
|
|
ChatType.System,
|
|
ChatType.Notice,
|
|
ChatType.Urgent,
|
|
ChatType.Echo,
|
|
ChatType.NpcDialogue,
|
|
ChatType.NpcAnnouncement,
|
|
ChatType.LootNotice,
|
|
ChatType.LootRoll,
|
|
ChatType.RetainerSale,
|
|
ChatType.Crafting,
|
|
ChatType.Gathering,
|
|
ChatType.Sign,
|
|
ChatType.RandomNumber,
|
|
ChatType.MessageBook,
|
|
ChatType.Alarm,
|
|
ChatType.Orchestrion,
|
|
ChatType.GlamourNotifications,
|
|
ChatType.PeriodicRecruitmentNotification,
|
|
ChatType.GatheringSystem,
|
|
ChatType.Progress,
|
|
ChatType.Debug,
|
|
ChatType.Error,
|
|
ChatType.Item,
|
|
ChatType.Action,
|
|
ChatType.BattleSystem,
|
|
ChatType.Damage,
|
|
ChatType.Healing,
|
|
ChatType.Miss,
|
|
ChatType.GainBuff,
|
|
ChatType.GainDebuff,
|
|
ChatType.LoseBuff,
|
|
ChatType.LoseDebuff,
|
|
]
|
|
),
|
|
];
|
|
}
|