JonKazama-Hellion
4d54eabdac
General code-quality and robustness pass across the plugin: thread- safety on IPC state, resource-disposal cleanups, input validation, defensive null-checks and a few small UX glitches. Compliance docs (THIRD_PARTY_NOTICES, PRIVACY, COPYRIGHT) refreshed to v1.0.3. Highlights - ExtraChat IPC state synchronised across threads - ChatLogWindow autocomplete no longer leaks the unmanaged ImGuiListClipper allocation - ChatLogWindow + Popout style stack stays balanced when config toggles mid-frame - Retention sweep and privacy cleanup wait for the actual filter pass instead of the fire-and-forget Task that started it - Configuration.LatestVersion bumped to 13 to match the active migration path - GameFunctions placeholder buffer guarded against oversized replacement names - TellTarget.IsSet, ResolveTempInputChannel, InputPreview, IconUtil, Lender, Payloads, ExtraPayload all hardened against null / empty / EOF / cycle inputs - FontManager Lodestone download stays in scope for a follow-up (timeout + lazy init pending) - AutoTranslate replaced the msvcrt.dll memcmp P/Invoke with a managed Span comparison - Privacy cleanup worker thread marked IsBackground = true - Database cleanup now removes both legacy files in one click - Tell-target name redacted in the verbose debug log Compliance - THIRD_PARTY_NOTICES: last-reviewed bumped to v1.0.3, Pidgin 3.5.1, SQLitePCLRaw.lib.e_sqlite3 3.50.3 listed as direct dependency with CVE-2025-6965 / CVE-2025-7709 rationale - PRIVACY: last-reviewed bumped to v1.0.3, BetterTTV trigger wording clarified (list fetch at startup vs. on-demand image fetch) - COPYRIGHT: upstream attribution range widened Build: 0 warnings, 0 errors. No behavioural changes that would alter existing user configuration or stored chat history.
114 lines
2.8 KiB
C#
Executable File
114 lines
2.8 KiB
C#
Executable File
using Dalamud.Game.Text.SeStringHandling;
|
|
|
|
namespace HellionChat.Util;
|
|
|
|
internal class PartyFinderPayload : Payload
|
|
{
|
|
public override PayloadType Type => (PayloadType) 0x50;
|
|
|
|
internal uint Id { get; }
|
|
|
|
internal PartyFinderPayload(uint id)
|
|
{
|
|
Id = id;
|
|
}
|
|
|
|
protected override byte[] EncodeImpl()
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
|
|
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|
|
|
|
internal class AchievementPayload : Payload
|
|
{
|
|
public override PayloadType Type => (PayloadType) 0x51;
|
|
|
|
internal uint Id { get; }
|
|
|
|
internal AchievementPayload(uint id)
|
|
{
|
|
Id = id;
|
|
}
|
|
|
|
protected override byte[] EncodeImpl()
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
|
|
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|
|
|
|
|
|
internal class UriPayload(Uri uri) : Payload
|
|
{
|
|
public override PayloadType Type => (PayloadType) 0x52;
|
|
|
|
public Uri Uri { get; } = uri;
|
|
|
|
private const string DefaultScheme = "https";
|
|
private static readonly string[] ExpectedSchemes = ["http", "https"];
|
|
|
|
/// <summary>
|
|
/// Create a URIPayload from a raw URI string. If the URI does not have a
|
|
/// scheme, it will default to https://.
|
|
/// </summary>
|
|
/// <exception cref="UriFormatException">
|
|
/// If the URI is invalid, or if the scheme is not supported.
|
|
/// </exception>
|
|
public static UriPayload ResolveUri(string rawUri)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(rawUri);
|
|
if (string.IsNullOrWhiteSpace(rawUri))
|
|
throw new UriFormatException("URI cannot be empty or whitespace.");
|
|
|
|
// Check for an expected scheme '://', if not add 'https://'
|
|
if (ExpectedSchemes.Any(scheme => rawUri.StartsWith($"{scheme}://")))
|
|
return new UriPayload(new Uri(rawUri));
|
|
|
|
if (rawUri.Contains("://"))
|
|
throw new UriFormatException($"Unsupported scheme in URL: {rawUri}");
|
|
|
|
return new UriPayload(new Uri($"{DefaultScheme}://{rawUri}"));
|
|
}
|
|
|
|
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
|
|
protected override byte[] EncodeImpl()
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|
|
|
|
internal class EmotePayload : Payload
|
|
{
|
|
public override PayloadType Type => (PayloadType) 0x53;
|
|
|
|
public string Code = string.Empty;
|
|
|
|
public static EmotePayload ResolveEmote(string code)
|
|
{
|
|
return new EmotePayload { Code = code };
|
|
}
|
|
|
|
protected override void DecodeImpl(BinaryReader reader, long endOfStream)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
|
|
protected override byte[] EncodeImpl()
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|