fix: post-review polish on v1.4.4
- IsAllowedForStorage warning now only fires for ChatTypes the build doesn't recognise (Enum.IsDefined), not for opted-out known ones - Drop stale tests-location comment in HonorificService
This commit is contained in:
@@ -77,12 +77,14 @@ public class Configuration : IPluginConfiguration
|
||||
if (PrivacyPersistChannels.Contains(type))
|
||||
return true;
|
||||
|
||||
// F3.2: log first occurrence so a new patch's ChatType doesn't drop
|
||||
// off the radar. Failsafe still applies via PrivacyPersistUnknownChannels.
|
||||
if (_warnedUnknownChannels.Add(type))
|
||||
// F3.2: log first occurrence of a ChatType the running build doesn't
|
||||
// recognise — i.e. one a future FFXIV patch may have added. Known
|
||||
// types the user opted out of are routed through the failsafe
|
||||
// silently, like before.
|
||||
if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type))
|
||||
{
|
||||
Plugin.Log.Warning(
|
||||
"PrivacyFilter: unknown ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
|
||||
"PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
|
||||
type,
|
||||
PrivacyPersistUnknownChannels
|
||||
);
|
||||
|
||||
@@ -156,8 +156,6 @@ internal sealed class HonorificService : IDisposable
|
||||
}
|
||||
}
|
||||
|
||||
// --- Pure-logic helpers; tested via HellionChat.Tests/Integrations. ---
|
||||
|
||||
internal static HonorificTitleData? ParseTitleJson(string json)
|
||||
{
|
||||
if (string.IsNullOrEmpty(json))
|
||||
|
||||
Reference in New Issue
Block a user