fix: post-review polish on v1.4.4

- IsAllowedForStorage warning now only fires for ChatTypes the build
  doesn't recognise (Enum.IsDefined), not for opted-out known ones
- Drop stale tests-location comment in HonorificService
This commit is contained in:
2026-05-12 10:47:43 +02:00
parent 0982b68a4a
commit 57da455700
2 changed files with 6 additions and 6 deletions
+6 -4
View File
@@ -77,12 +77,14 @@ public class Configuration : IPluginConfiguration
if (PrivacyPersistChannels.Contains(type)) if (PrivacyPersistChannels.Contains(type))
return true; return true;
// F3.2: log first occurrence so a new patch's ChatType doesn't drop // F3.2: log first occurrence of a ChatType the running build doesn't
// off the radar. Failsafe still applies via PrivacyPersistUnknownChannels. // recognise — i.e. one a future FFXIV patch may have added. Known
if (_warnedUnknownChannels.Add(type)) // types the user opted out of are routed through the failsafe
// silently, like before.
if (!Enum.IsDefined(typeof(ChatType), type) && _warnedUnknownChannels.Add(type))
{ {
Plugin.Log.Warning( Plugin.Log.Warning(
"PrivacyFilter: unknown ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.", "PrivacyFilter: unrecognised ChatType {Type} — falling back to PrivacyPersistUnknownChannels={Persist}.",
type, type,
PrivacyPersistUnknownChannels PrivacyPersistUnknownChannels
); );
@@ -156,8 +156,6 @@ internal sealed class HonorificService : IDisposable
} }
} }
// --- Pure-logic helpers; tested via HellionChat.Tests/Integrations. ---
internal static HonorificTitleData? ParseTitleJson(string json) internal static HonorificTitleData? ParseTitleJson(string json)
{ {
if (string.IsNullOrEmpty(json)) if (string.IsNullOrEmpty(json))